RFR(S): 8008088: SA can hang the VM

[David Holmes]

Hi Rickard,

This looks good. Reviewed.

I am a little confused about the problem though. I would expect only a 
process-directed signal to cause this problem (as opposed to 
thread-directed) - is that the case? The ptrace info doesn't make a 
distinction so perhaps not. Though in that case I would have expected to 
see this problem long ago, if for example SEGV from a null reference 
access could cause a stop.

David

On 13/02/2013 10:28 PM, Rickard Bäckman wrote:
> Hi all,
>
> can I please have a couple of reviews of this change.
>
> The problem discovered was the on Linux and BSD SA uses the ptrace() method to stop the threads before inspecting the memory of the process. However since SA doesn't check which signal was the stopping one it is possible that we stop on another signal. Doing so means that that signal is lost as well as the SIGSTOP remains as a pending signal for the process. When SA detaches, the SIGSTOP will be delivered to the process and the process will go to the Sleeping state (not executing any more code).
>
> This change introduces a check on the signal, such that if the signal wasn't a SIGSTOP we restart the thread and wait for a new signal.
>
> Webrev: http://cr.openjdk.java.net/~rbackman/8008088/
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008088
>
> Thanks
> /R
>