RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()

Alan Bateman Alan.Bateman at oracle.com
Tue Feb 19 08:01:46 PST 2013


On 13/02/2013 09:47, Yekaterina Kantserova wrote:
> Hi everyone,
>
> This small fixconcerns jdk.testlibrary.JdkFinder utility class. The 
> check below is too OS dependent and should be deleted.
> ...
>         binPath += File.separatorChar + "bin" + File.separatorChar + 
> executable;
>         File toolFile = new File(binPath);
> ==> if (!toolFile.exists()) {
>             throw new RuntimeException(binPath + " does not exist");
>         }
> ...
>
> On windows if executable is specified as e.g. 'java', without '.exe', 
> the File exists() will fail. But it's still possible to run executable.
This looks okay to me, do you have someone to push this for you?

-Alan.


More information about the serviceability-dev mailing list