RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

Staffan Larsen staffan.larsen at oracle.com
Tue Feb 19 11:01:43 PST 2013


Looks good.

/Staffan

On 19 feb 2013, at 13:52, Nils Loodin <nils.loodin at oracle.com> wrote:

> Here's the updated webrev:
> 
> http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/
> 
> Regards,
> Nils Loodin
> 
> On 02/19/2013 12:09 PM, Nils Loodin wrote:
>> On 02/09/2013 03:13 AM, David Holmes wrote:
>>> On 9/02/2013 2:40 AM, Nils Loodin wrote:
>>>> Please review the following very small and insignificant change:
>>>> Basically, I need to access a performance-counter by name from within
>>>> the JVM.
>>> 
>>> The method name by_name seems a little odd to me. find_by_name would
>>> seem more consistent (particularly if you consider the strange
>>> PerfDataList::by_name method - which compares names)
>> 
>> 
>> I think you're right. I'll rename it to find_by_name instead and send
>> out another webrev.
>> 
>> Nisse
>> 
>>> 
>>> David
>>> 
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007804
>>>> http://cr.openjdk.java.net/~nloodin/8007804/webrev.00/
>>>> 
>>>> Regards,
>>>> Nils Loodin
>>>> 
>>>> 
>> 
> 



More information about the serviceability-dev mailing list