RFR(S): 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order with lock MethodData_lock/19 -- possible deadlock

[Markus Grönlund]

Looks good Staffan (not a Reviewer).

Thanks
Markus

-----Original Message-----
From: Staffan Larsen 
Sent: den 18 februari 2013 11:16
To: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net
Subject: RFR(S): 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order with lock MethodData_lock/19 -- possible deadlock

Please review this change for hs24 / jdku.

webrev: http://cr.openjdk.java.net/~sla/8005572/webrev.00/

The problem lies with the order of the newly introduced JfrBuffer_lock and JfrStream_lock compared to the MethodData_lock. There are cases where we need to take the Jfr* locks while holding the MethodData_lock. Ths solution is simply to increase the lock order for the Jfr* locks. This change has baked for a while in internal testing and showed no regressions.

Thanks,
/Staffan