RFR (XS): 8005592: ClassLoaderDataGraph::_unloading incorrectly defined as nonstatic in vmStructs

[Mikael Vidstedt]

Thanks Karen, I have verified that the SA does not look for the 
_unloading field. I will remove it!

Cheers,
Mikael

On 2013-01-11 05:11, Karen Kinnear wrote:
> Mikael,
>
> I like the assertion that you added.
> I believe that this field isn't used by SA - so if you could double-check that in SA - if that is the case, please
> just remove it from vmStructs before checking in.
>
> thanks,
> Karen
>
> On Dec 28, 2012, at 5:24 PM, Mikael Vidstedt wrote:
>
>> Please review the following change.
>>
>> Background:
>>
>> The _unloading field is a static field in ClassLoaderDataGraph (in classLoaderData.hpp) and should therefore be defined using static_field, as opposed to nonstatic_field, in vmStructs.
>>
>> Apart from changing from nonstatic_field to static_field I also added an assert in the CHECK_NONSTATIC_VM_STRUCT_ENTRY macro to make sure any field offsets are within the bounds of the corresponding structs. The assert triggers for _unloading before the change to static_field.
>>
>> The change passes JPRT.
>>
>> http://cr.openjdk.java.net/~mikael/8005592/webrev.00/
>>
>> Thanks,
>> Mikael
>>