Review Request (S) 8006542: JSR 292: the VM_RedefineClasses::append_entry() must support invokedynamic entry kinds

[Christian Thalinger]

On Jan 22, 2013, at 4:07 PM, serguei.spitsyn at oracle.com wrote:

> 
> Please, review the fix for:
>  https://jbs.oracle.com/bugs/browse/JDK-8006542
> 
> 
> Open webrev:
>  http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8006542-JVMTI-JSR292.1/

src/share/vm/prims/jvmtiRedefineClasses.hpp:

+  // Support for constant pool merging (these routines are in alpha order):
   void append_entry(constantPoolHandle scratch_cp, int scratch_i,
     constantPoolHandle *merge_cp_p, int *merge_cp_length_p, TRAPS);
+  int find_or_append_indirect_entry(constantPoolHandle scratch_cp, int scratch_i,
+    constantPoolHandle *merge_cp_p, int *merge_cp_length_p, TRAPS);
   int find_new_index(int old_index);

Not really alpha order ;-)

Otherwise this looks good (as far as I can tell).

-- Chris

> 
> Summary:
>  Need a support for invokedynamic entry kinds when new and old constant pools are merged.
> 
> Testing:
>  vm/mlvm/indy/func/jvmti/redefineClassInBootstrap
>  Asked the VM SQE team to develop new INDY tests for better coverage.
> 
> 
> Thanks,
> Serguei
> 
> 
>