Question of 'contributor' at hg commit

[David Holmes]

Also check out:

http://openjdk.java.net/guide/producingChangeset.html#create

I prefer the full form:

Contributed-by: Ben Bitdiddle <ben at bits.org>

David

On 25/01/2013 12:26 PM, Tao Mao wrote:
> Check out jcheck.py code
> http://hg.openjdk.java.net/code-tools/jcheck/dist/raw-file/tip/jcheck.py
>
> con_check = re.compile("Contributed-by: ((" + addr_pat + ")(, (" +
> addr_pat + "))*)$")
>
> jcheck can take multiple contributors (N >= 1) as long as you comply
> with the format.
>
> It's a good thing to have a format including spacing requirement. But
> the code probably should provide a more useful error message to correct
> its users.
>
> Tao
>
> On 1/24/13 5:51 PM, Yumin Qi wrote:
>> Yes, no more than one leading space needed, also, the space between
>> ',' and following email address is a must too. Very confusing. jcheck
>> should ignore extra spaces.
>>
>> Thanks
>> Yumin
>>
>> On 1/24/2013 5:44 PM, mark.reinhold at oracle.com wrote:
>>> 2013/1/24 17:31 -0800, ysr1729 at gmail.com:
>>>> may be it can't parse two email addresses. Probably expecting a
>>>> single email
>>>> address in contributed by line?
>>> It can handle multiple addresses. Try removing the extra space before
>>> the first address, i.e., make it:
>>>
>>> Contributed-by: yunda.mly at taobao.com, yumin.qi at oracle.com
>>>
>>> rather than:
>>>
>>> Contributed-by: yunda.mly at taobao.com, yumin.qi at oracle.com
>>>
>>> - Mark
>