8007142: Add utility classes for writing better multiprocess tests in jtreg

[Martin Buchholz]

I don't have time for a detailed review, but I have some high-level
comments.

A lot of this is good functionality that should be provided in the jdk
proper,
notably getting process ids and manipulating process output (a higher level
interface to ProcessBuilder).  See the test ProcessBuilder/Basic for
previous work by myself.

Source files need to be newline-terminated.

<code> is so 1990s.  Use {@code instead.

Do you really need test.jdk to find yourself?  Why not use java.home, which
is always present?

On Wed, Jan 30, 2013 at 6:40 AM, Rickard Bäckman <rickard.backman at oracle.com
> wrote:

> Katja,
>
> I think the change looks good.
> However we need to find an official reviewer before we can push this.
>
> Can we get an official reviewer to look on this change please?
>
> Thanks
> /R
>
> On Jan 30, 2013, at 3:11 PM, Yekaterina Kantserova wrote:
>
> > Hi everyone,
> >
> > In the previous mail I've referred to already existing BUG number, which
> was wrong. Here comes the webrev referred to the new BUG
> >
> > http://cr.openjdk.java.net/~ykantser/8007142/webrev.00/
> >
> > Thanks,
> > Katja
> >
> > -------- Original Message --------
> > Subject:      8006413: Add utility classes for writing better
> multiprocess tests in jtreg
> > Date: Tue, 29 Jan 2013 15:13:11 +0100
> > From: Yekaterina Kantserova <yekaterina.kantserova at oracle.com>
> > To:   core-libs-dev at openjdk.java.net
> > CC:   jfr_dev_ww_grp <jfr_dev_ww_grp at oracle.com>
> >
> > Hi everyone,
> >
> > Christian Törnqvist has done a great job to make it easier to run
> > multi-process tests in jtreg. His webrev
> > (
> > http://cr.openjdk.java.net/~ctornqvi/webrev/8006413/webrev.03/
> > ) is
> > already approved and on the way into the hotspot repo.
> >
> > This webrev
> > http://cr.openjdk.java.net/~ykantser/8006413/webrev.00/
> >  is
> > for putting these utility classes into the jdk repo. I'm going to use
> > them for the JFR testing in the first hand.
> >
> > The webrev is almost a copy of Christian's except JcmdBase.java, utility
> > class for starting jcmd, and some extra methods in OutputAnalyzer.java.
> >
> > Thanks,
> > Katja
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130130/f7e89b15/attachment.html