Codereview for JDK-8016221: A unit test should not use a fixed port to run a jmx connector (JDCMD MBean Tests)
shanliang
shanliang.jiang at oracle.com
Wed Jul 3 03:33:11 PDT 2013
Thanks Jaroslav and Daniel for the code review.
Still not get review from a code reviewer, not sure I could do push with
the current reviews, this is a simple test fix, and only changing way to
start a JMX connector server/client: allowing RMI Sever to use an any
free port, instead to specify a fixed port.
Thanks,
Shanliang
Daniel Fuchs wrote:
> Hi Shanliang,
>
> This change looks good.
> There's probably a subtle difference between invoking a command
> through a user created JMXConnectorServer as opposed as sending it
> through the default agent - but I don't think that's what matters
> here.
>
> cheers,
>
> -- daniel
>
> On 6/12/13 9:56 AM, shanliang wrote:
>> Re-send with right subject :)
>>
>> Shanliang
>>
>> shanliang wrote:
>>> Hi,
>>>
>>> The fix is to address https://jbs.oracle.com/bugs/browse/JDK-8016221
>>>
>>> Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8016221/webrev.00/
>>>
>>> Instead to use a fixed port to run a JMX connector, we specify the
>>> port as 0:
>>> JMXServiceURL url = new JMXServiceURL("rmi", null, 0);
>>> to allow JMX to select a free port.
>>>
>>> and the fix makes sure to close the client and server when the test is
>>> finished (passed or failed).
>>>
>>> Shanliang
>>>
>>>
>>
>
More information about the serviceability-dev
mailing list