RFR - Changes to address CCC 8014135: Support for statically linked agents

[Alan Bateman]

On 03/07/2013 22:17, BILL PITTORE wrote:
> These changes address bug 8014135 which adds support for statically 
> linked agents in the VM. This is a followup to the recent JNI spec 
> changes that addressed statically linked JNI libraries( 8005716).
> The JEP for this change is the same JEP as the JNI changes:
> http://openjdk.java.net/jeps/178
>
> Webrevs are here:
>
> http://cr.openjdk.java.net/~bpittore/8014135/jdk/webrev.00/

I looked at the javadoc updates to the attach API.

One thing that doesn't come across very clearly is the mapping from the 
agentLibrary parameter to "agent-lib-name". I think that needs a few 
words so that it's clear that it is not literally looking for 
"Agent_OnAttach_agent-lib-name" but rather "Agent_OnAttach" + 
<agent-lib-name> where <agent-lib-name> is the library name in the 
agentLibrary parameter.

As I recall, the JVM Tool Interface is supposed to be referred so as 
"JVM TI" rather than "JVMTI".

Otherwise it looks okay to me.

-Alan