jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public

[Jaroslav Bachorik]

On 07/09/2013 09:42 PM, Mandy Chung wrote:
> On 7/9/13 3:02 AM, Jaroslav Bachorik wrote:
>> Please, review the final version of the changes:
>> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.07
>>
> 
> The change looks reasonable. In the class spec for  MXBean, suggest to
> rename
> 
>    interface ThisIsNotMXBean{}
> 
> to something more explicit
> 
>    interface NonPublicInterfaceNotMXBean{}

Since this was a part of the CCC review which was approved I am not sure
if I am allowed to change the class spec. If it is allowed I have no
objections against the proposal and will change the interface name.

> 
> You removed JMX.checkProxyInterface.  I believe the checkPackageAccess
> method on the given mbean
> interface is called somewhere as part of the MBean validation - where is
> that check being done?

com.sun.jmx.mbeanserver.MBeanIntrospector.getMethods() performs this
check. It is not possible to construct an M(X)Bean proxy without
consulting com.sun.jmx.mbeanserver.MBeanIntrospector.getMethods() first.

This functionality is enforced by a closed vulnerability test.

-JB-

> 
> Other than that, it's fine with me.
> 
> Mandy
> 
>> It addresses all the concerns raised during the CCC process.
>>
>> I will need at least one official OpenJDK reviewer for the integration.
>>
>> Thanks,
>>
>> -JB-
>