RFR: 8019826 Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE

shanliang shanliang.jiang at oracle.com
Wed Jul 10 09:48:34 PDT 2013


It looks fine to me.

Shanliang

Jaroslav Bachorik wrote:
> Please, review this simple fix.
>
> http://cr.openjdk.java.net/~jbachorik/8019826/webrev.00
>
> Firstly, the patch removes a conditional early exit which checks for a
> build 52 of an unspecified major JVM version - it is not needed any
> more. Basically, the condition just made the test a noop till the latest
> hotspot version.
>
> The second fix is correctly setting the "mbean" attribute - it was not
> properly initialized and because of this the test was going to fail with
> NPE.
>
> Thanks,
>
> -JB-
>   



More information about the serviceability-dev mailing list