RFR: 8019826 Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE

Mandy Chung mandy.chung at oracle.com
Wed Jul 10 22:49:32 PDT 2013


Looks good.

Mandy

On Jul 10, 2013, at 5:10 PM, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:

> Please, review this simple fix.
> 
> http://cr.openjdk.java.net/~jbachorik/8019826/webrev.00
> 
> Firstly, the patch removes a conditional early exit which checks for a
> build 52 of an unspecified major JVM version - it is not needed any
> more. Basically, the condition just made the test a noop till the latest
> hotspot version.
> 
> The second fix is correctly setting the "mbean" attribute - it was not
> properly initialized and because of this the test was going to fail with
> NPE.
> 
> Thanks,
> 
> -JB-


More information about the serviceability-dev mailing list