jmx-dev RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

Daniel Fuchs daniel.fuchs at oracle.com
Thu Jul 18 05:11:37 PDT 2013


Hi Jaroslav,

Looks good overall.

Small nit:

You should remove the comment lines 322-327
in ModelMBeanInfoSupport.java since your changes make it obsolete.

Also the copyright year in ImmutableDataTest should be 2013 (not 2005).

No need for another round of review.

-- daniel

On 7/18/13 11:54 AM, Jaroslav Bachorik wrote:
> Hi,
>
> thanks for the comments.
>
> Here (http://cr.openjdk.java.net/~jbachorik/8002307/webrev.03/) is the
> updated webrev implementing suggestions from Daniel and Shanliang.
>
> -JB-
>
>



More information about the serviceability-dev mailing list