RFR: Event based tracing is missing thread exit

David Holmes david.holmes at oracle.com
Thu Jul 25 16:57:31 PDT 2013


Erik,

On 26/07/2013 1:21 AM, Erik Gahlin wrote:
> Hello,
>
> Could you be so kind and review this small change. The fix is targeted
> for jdk7u40, and the hook is needed to have a leak free event tracing
> implementation.
>
> http://cr.openjdk.java.net/~egahlin/8021353/

Seems okay. Though THREAD_DESTRUCTOR might be more apt as it isn't 
always the case that a thread is exiting. The Thread destructor can be 
called in a number of circumstances, and sometimes it is the current 
thread deleting itself, at which point you need to be wary of what bits 
of the thread data you touch ;-)

Cheers,
David

> Thanks
> Erik


More information about the serviceability-dev mailing list