Review Request (M) 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments

[David Holmes]

Hi Serguei,

On 26/07/2013 10:14 AM, serguei.spitsyn at oracle.com wrote:
>
> Please, review the fix for:
>    bug: http://bugs.sun.com/view_bug.do?bug_id=7187554
>    jbs: https://jbs.oracle.com/bugs/browse/JDK-7187554
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/7187554-JVMTI-JSR292.1

In the templateInterpreter code why did you put this guard on your new 
code (from x86_32 version):

1923 #if INCLUDE_JVMTI

when the whole chunk of code this is situated in is specifically for 
JVMTI support

1824   //
1825   // JVMTI PopFrame support
1826   //

???

David
-----

>
> Summary:
>    Restore the appendix argument of a polymorphic intrinsic call
>    needed for a invokestatic re-execution after JVMTI PopFrame().
>
> Description
>    When JVMTI's PopFrame removes a frame that was called via a call site
> that
>    takes an appendix and that call site is reexecuted the appendix is
> not on
>    the stack anymore because it got removed by the adapter.
>    This fix is to detect such a case and push the appendix on the stack
> again before reexecution.
>
>
> Testing:
>    UTE tests - in progress: vm.mlvm.testlist, nsk.jvmti.testlist,
> nsk.jdi.testlist
>
> Thanks,
> Serguei