RR(S): 8020943: Memory leak when GCNotifier uses create_from_platform_dependent_str()

[Kevin Walls]

Thanks Fred,

(refreshed for the (C) nit in the same location)
Kevin


On 31/07/13 11:54, frederic parain wrote:
> Looks good to me.
>
> Minot nit: Copyright year update line 2
>
> Fred (not a Reviewer)
>
> On 31/07/2013 11:45, Kevin Walls wrote:
>> Hi,
>>
>> I'd like to get a review on this small change:
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020943
>> https://jbs.oracle.com/bugs/browse/JDK-8020943
>>
>> webrev
>> http://cr.openjdk.java.net/~kevinw/8020943/webrev.00/
>>
>> It turns out there's a leak in the gc notifier: reproduce by attaching
>> e.g. JConsole and watching, if there is frequent GC the number of
>> apparently unowned String objects that can't get collect continually
>> increases.
>>
>> In the notifier, the method it calls to create String objects involves a
>> JNI call that leaves a Handle behind and doesn't get cleared.   There is
>> a simpler method to call, there is no need for all that work, as we are
>> dealing with a small set of simple strings in the JVM being converted,
>> to describe the collection type, cause, ...
>>
>> Thanks
>> Kevin
>