About bug fix of 8010278

[Kevin Walls]

Hi Kris,

Yes, fixing the post-nashorn javascript issues is very welcome!... The 
sa.js fix I mention is attached to bug 8011888 but not out for review 
yet that I have seen.  Maybe you want to ping the owner and decide which 
fix should proceed...

I was just commenting that I couldn't reproduce the problem Yumin 
reported in 8021444 due to those javascript issues in sa.js...  So I 
used the sa.js that was attached to 8011888 to get that working.

Trying your sa.js now: yes, that at least runs CLHSDB OK and e.g. the 
ciReplay tests pass.

Thanks!
Kevin


On 31/07/13 08:54, Krystal Mok wrote:
> Hi Kevin,
>
> Just noticed this one. I wonder if the suggested sa.js fix is similar 
> to the one I purposed here:
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-July/010831.html
>
> Regards,
> Kris
>
>
> On Fri, Jul 26, 2013 at 5:20 PM, Kevin Walls <kevin.walls at oracle.com 
> <mailto:kevin.walls at oracle.com>> wrote:
>
>
>     Hi Yumin,
>
>     Sure no problem I'll look into it.   Looks like in ClassDump we
>     should check classFilter != null before doing that initialisation
>     in the run() method.
>
>     At the moment trying jtreg on test/compiler/ciReplay I get a
>     failure in TestSA.sh, as it calls sun.jvm.hotspot.CLHSDB, and
>     gives the javascript exceptions characteristic of 8011888.
>      Rebuilding with the suggested new sa.js I see in that bug, I'll
>     test and let you know...
>
>     Thanks!
>     Kevin
>
>
>
>
>     On 26/07/13 02:17, Yumin Qi wrote:
>
>         Hi, Kevin
>
>         http://cr.openjdk.java.net/~kevinw/8010278/webrev.03/
>         <http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/>
>         <http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/>
>           I found this fix breaks C2 replay for dumping loaded java
>         classes:
>
>                 at
>         sun.jvm.hotspot.tools.jcore.PackageNameFilter.canInclude(PackageNameFilter.java:55)
>                 at
>         sun.jvm.hotspot.tools.jcore.ClassDump.dumpKlass(ClassDump.java:135)
>                 at
>         sun.jvm.hotspot.tools.jcore.ClassDump.access$000(ClassDump.java:38)
>                 at
>         sun.jvm.hotspot.tools.jcore.ClassDump$1.visit(ClassDump.java:106)
>                 at
>         sun.jvm.hotspot.memory.Dictionary.classesDo(Dictionary.java:68)
>                 at
>         sun.jvm.hotspot.memory.SystemDictionary.classesDo(SystemDictionary.java:190)
>                 at
>         sun.jvm.hotspot.tools.jcore.ClassDump.run(ClassDump.java:102)
>                 at
>         sun.jvm.hotspot.DumpLoadedClasses.run(DumpLoadedClasses.java:65)
>                 at
>         sun.jvm.hotspot.DumpLoadedClasses.main(DumpLoadedClasses.java:43)
>
>           The problem is with Replay, we set BootFilter and
>         NonBootFilter for ClassDump, but this changeset ignored the
>         existing filter.
>           I filed a bug against this problem.
>
>         https://jbs.oracle.com/bugs/browse/JDK-8021444
>
>         Thanks
>         Yumin
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130731/257dbb56/attachment.html