Review Request (S) 8014052: JSR292: assert(end_offset == next_offset) failed: matched ending

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Jun 3 12:49:44 PDT 2013


May I have one more review, please?

One more explanation to help to understand the fix...
The call to finalize_operands_merge() was originally misplaced.
As a result, the finalize_operands_merge() is not called in some cases 
which is wrong.
The fix is to make it called unconditionally.

Thanks,
Serguei

On 5/31/13 10:29 AM, serguei.spitsyn at oracle.com wrote:
> Thanks, Vladimir!
> Serguei
>
> On 5/31/13 10:03 AM, Vladimir Kozlov wrote:
>> Good.
>>
>> Vladimir
>>
>> On 5/30/13 11:19 PM, serguei.spitsyn at oracle.com wrote:
>>> Please, review the fix for:
>>>    bug: https://jbs.oracle.com/bugs/browse/JDK-8014052
>>>    jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052
>>>
>>>
>>> Open webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014052-JVMTI-JSR292.1 
>>>
>>>
>>>
>>> Summary:
>>>    A call to the finalize_operands_merge() must be unconditional.
>>>    Otherwise, the merge of the bootstrap method operands is not
>>> completed correctly.
>>>
>>>
>>> Testing: vm/mlvm, nsk/jvmti, nsk/jdi, nsk/jdwp
>>>
>>> Thanks,
>>> Serguei
>



More information about the serviceability-dev mailing list