Code Review Request: 8016576: Overrides warnings in jdi and jconsole

[Chris Hegarty]

On 06/17/2013 08:08 PM, Kurchi Hazra wrote:
>
>>> - Maybe a webrev helps:
>>> http://cr.openjdk.java.net/~khazra/8016576/webrev.01/
>>> <http://cr.openjdk.java.net/%7Ekhazra/8016576/webrev.01/>
>>
>> Looks fine, but trivially remove the unnecessary null check in equals
>> before pushing. If 'o instanceof XObject', then it cannot be null.
>> Similar for SDE.equals
> - For XObject I am checking if object is null which is a member of
> XObject (and not o) -

Apologies, you are correct. Since I'm unlikely to ever look at this code 
again ;-) I'll refrain from suggesting to rename the variables to 
something less obscure/confusing.

 > I'll remove the null check in SDE.

Thanks,

-Chris.

>
>>
>> -Chris.
>