From rickard.backman at oracle.com Fri Mar 1 01:27:52 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Fri, 1 Mar 2013 10:27:52 +0100 Subject: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub() || sender_blob->is_nmethod()) failed: Impossible call chain Message-ID: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com> Hi all, here comes another update to frame.safe_for_sender. If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. In this case we read one that pointed into the Safepoint blob. We now pretty much guarded for all kind of blobs in safe_for_sender, so I've changed the method to not assert in the end but to do it the same was as the frame_sparc.cpp did it. Everything that is not a nmethod at the end of the method is not safe. I've also changed another check for a frame_size == 0 to frame_size <= 0 to make it somewhat more safer. The bug: http://bugs.sun.com/view_bug.do?bug_id=8008357 Webrev: http://cr.openjdk.java.net/~rbackman/8008357/ This webrev is for HS24. Thanks /R From xuelei.fan at oracle.com Fri Mar 1 02:35:40 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 01 Mar 2013 10:35:40 +0000 Subject: hg: jdk8/tl/jdk: 7030966: Support AEAD CipherSuites Message-ID: <20130301103619.27EE547512@hg.openjdk.java.net> Changeset: def2e05299b7 Author: xuelei Date: 2013-03-01 02:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/def2e05299b7 7030966: Support AEAD CipherSuites Reviewed-by: weijun, wetmore, valeriep ! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java ! src/share/classes/sun/security/internal/spec/TlsKeyMaterialParameterSpec.java ! src/share/classes/sun/security/internal/spec/TlsKeyMaterialSpec.java ! src/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java + src/share/classes/sun/security/ssl/Authenticator.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/EngineInputRecord.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/EngineWriter.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/MAC.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ec/TestEC.java ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/sslecc/CipherTest.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java + test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKeyGCM.java ! test/sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java ! test/sun/security/ssl/sanity/interop/CipherTest.java ! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java From coleen.phillimore at oracle.com Fri Mar 1 05:23:26 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Fri, 01 Mar 2013 13:23:26 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets Message-ID: <20130301132335.2B72D47515@hg.openjdk.java.net> Changeset: 63e54c37ac64 Author: simonis Date: 2013-02-27 09:40 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/63e54c37ac64 8008959: Fix non-PCH build on Linux, Windows and MacOS X Summary: Fix the build without precompiled headers by either including the missing ".inline.hpp" files into the appropriate files or by turning inline-functions declared in header files into ordinary functions in ".cpp" files. Reviewed-by: coleenp, stefank, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.hpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/atomic_bsd_x86.inline.hpp ! src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp ! src/os_cpu/bsd_zero/vm/atomic_bsd_zero.inline.hpp ! src/os_cpu/linux_sparc/vm/atomic_linux_sparc.inline.hpp ! src/os_cpu/linux_x86/vm/atomic_linux_x86.inline.hpp ! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp ! src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/os_cpu/solaris_sparc/vm/orderAccess_solaris_sparc.inline.hpp ! src/os_cpu/solaris_x86/vm/atomic_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/windows_x86/vm/atomic_windows_x86.inline.hpp ! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/oops/symbol.cpp ! src/share/vm/oops/symbol.hpp Changeset: a506ac816f14 Author: coleenp Date: 2013-02-27 07:35 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a506ac816f14 Merge Changeset: 143973ced9ab Author: coleenp Date: 2013-02-28 18:37 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/143973ced9ab Merge From kevin.walls at oracle.com Fri Mar 1 09:34:02 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 01 Mar 2013 17:34:02 +0000 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event Message-ID: <5130E68A.4040806@oracle.com> Hi, I'd like some reviews on this CMS Concurrent Mode Failure event: http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ The event doesn't actually carry any new information, but it is a warning we need to capture. This is against hsx24, I'll prepare the same, or reviewed, changes against very latest hotspot also. Thanks Kevin From volker.simonis at gmail.com Fri Mar 1 10:49:16 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 1 Mar 2013 19:49:16 +0100 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> <50901145.1040500@oracle.com> <50906205.8020607@oracle.com> Message-ID: Hi Christian, I run into this issue in our PPC port when switching to HS24. The problem is that there's the following assertion in bytecodeInterpreter.cpp: assert(labs(istate->_stack_base - istate->_stack_limit) == (istate->_method->max_stack() + 1)) failed: bad stack limit This fails because 'istate->_method->max_stack()' takes into account the 'extra_stack_entries()' while the value for 'istate->_stack_limit' does not account for it. 'istate->_stack_limit' is computed in 'CppInterpreterGenerator::generate_compute_interpreter_state()' right from the 'max_stack' member of methodOopDesc. Now if I understand you right, you suggest to remove all the parts which add the 'extra_stack_entries()' to the stack size. But wouldn't that be wrong? Isn't it necessary to prepare the stack to hold these two extra field in case they are needed by a method which contains invokedynamic calls? As far as I can see the template interpreter is still using this 'extra_stack' in 'AbstractInterpreter::size_top_interpreter_activation' although you advised to remove it in your mail. If the 'extra_stack' is really not needed, would it be reasonable to change the mention assertion to use 'verifier_max_stack()' instead of 'max_stack()'? Thank you and best regards, Volker On Wed, Oct 31, 2012 at 6:54 PM, Christian Thalinger wrote: > > On Oct 30, 2012, at 4:25 PM, serguei.spitsyn at oracle.com wrote: > >> Ok, it seems there are some suspicious fragments in the interpreter code. >> Christian, could you, please, check and comment the fragments below? >> >> This is how the Method::max_stack() is defined: >> >> src/share/vm/oops/method.hpp: >> >> int verifier_max_stack() const { return _max_stack; } >> int max_stack() const { return _max_stack + extra_stack_entries(); } >> void set_max_stack(int size) { _max_stack = size; } >> . . . >> static int extra_stack_entries() { return EnableInvokeDynamic ? 2 : 0; } >> >> >> The following code fragments are unaware that the method->max_stack() returns _max_stack + extra_stack_entries() : >> >> src/cpu/sparc/vm/cppInterpreter_sparc.cpp: >> src/cpu/sparc/vm/cppInterpreter_x86.cpp: >> >> static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { >> . . . >> const int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? >> return (round_to(max_stack + >> extra_stack + > > Remove extra_stack. > >> . . . >> } >> . . . >> void BytecodeInterpreter::layout_interpreterState(interpreterState to_fill, >> . . . >> int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? >> to_fill->_stack_limit = stack_base - (method->max_stack() + 1 + extra_stack); > > Remove extra_stack (but keep the +1; see comment nearby). > >> . . . >> } >> >> >> src/cpu/sparc/vm/templateInterpreter_sparc.cpp: >> >> static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { >> . . . >> const int max_stack_words = max_stack * Interpreter::stackElementWords; >> return (round_to((max_stack_words >> //6815692//+ Method::extra_stack_words() ???? > > The comment needs to be removed. > >> . . . >> } >> >> At the size_activation_helper call sites the second parameter is usually passed as method->max_stack(). >> >> >> src/cpu/x86/vm/templateInterpreter_x86_32.cpp: >> src/cpu/x86/vm/templateInterpreter_x86_64.cpp: >> >> int AbstractInterpreter::size_top_interpreter_activation(Method* method) { >> . . . >> const int extra_stack = Method::extra_stack_entries(); >> const int method_stack = (method->max_locals() + method->max_stack() + extra_stack) * > > Remove extra_stack. > >> Interpreter::stackElementWords; >> . . . >> } >> >> >> src/share/vm/interpreter/oopMapCache.cpp: >> >> void OopMapForCacheEntry::compute_map(TRAPS) { >> . . . >> // First check if it is a method where the stackmap is always empty >> if (method()->code_size() == 0 || method()->max_locals() + method()->max_stack() == 0) { >> _entry->set_mask_size(0); >> } else { >> . . . >> } >> >> Above, if the invokedynamic is enabled then the method()->max_stack() can not be 0. >> We need to check it if this fact does not break the fragment. > > That means we are always generating oop maps even if we wouldn't need them. Let me think more about this... > > -- Chris > >> >> >> I'm still looking at other places... >> >> >> Thanks, >> Serguei >> >> >> On 10/30/12 10:41 AM, serguei.spitsyn at oracle.com wrote: >>> I have a plan to look at it, at least for other serviceablity code. >>> It'd be good if someone from the runtime or compiler team checked it too. >>> >>> Thanks, >>> Serguei >>> >>> >>> On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: >>>> Thumbs up. >>>> >>>> Is someone going to do an audit for similar missing changes >>>> from max_stack() (not max_size()) to verifier_max_stack()? >>>> >>>> Dan >>>> >>>> >>>> On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >>>>> Hello, >>>>> >>>>> >>>>> Please, review the fix for CR: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >>>>> >>>>> CR in JIRA: >>>>> https://jbs.oracle.com/bugs/browse/JDK-7194607 >>>>> >>>>> Open webrev: >>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >>>>> >>>>> >>>>> Summary: >>>>> >>>>> This issue is caused by the changes in the oops/method.hpp for invokedynamic (JSR 292). >>>>> Now the max_stack() adds +2 to the original code attribute stack size if invokedynamic is enabled. >>>>> The verifier_max_stack() must be used in the jvmtiClassFileReconstituter.cpp >>>>> instead of the max_size() to get the code attribute stack size. >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>> >> > From jonathan.gibbons at oracle.com Fri Mar 1 11:35:15 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 01 Mar 2013 19:35:15 +0000 Subject: hg: jdk8/tl/langtools: 8008949: javadoc stopped copying doc-files Message-ID: <20130301193521.0B3404752A@hg.openjdk.java.net> Changeset: 6f988040a1c8 Author: jjg Date: 2013-03-01 10:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6f988040a1c8 8008949: javadoc stopped copying doc-files Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + test/com/sun/javadoc/testDocFiles/TestDocFiles.java + test/com/sun/javadoc/testDocFiles/pkg/Test.java + test/com/sun/javadoc/testDocFiles/pkg/doc-files/test.txt From serguei.spitsyn at oracle.com Fri Mar 1 12:00:03 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 01 Mar 2013 12:00:03 -0800 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> <50901145.1040500@oracle.com> <50906205.8020607@oracle.com> Message-ID: <513108C3.9050005@oracle.com> Hi Volker, I've added your questions into a comment section of the bug report: https://jbs.oracle.com/bugs/browse/JDK-8002087 It is to keep all possible issues accounted. I do not have a personal preference yet on how to resolve this better. So, let's wait for Christian to answer. Thanks, Serguei On 3/1/13 10:49 AM, Volker Simonis wrote: > Hi Christian, > > I run into this issue in our PPC port when switching to HS24. > > The problem is that there's the following assertion in bytecodeInterpreter.cpp: > > assert(labs(istate->_stack_base - istate->_stack_limit) == > (istate->_method->max_stack() + 1)) failed: bad stack limit > > This fails because 'istate->_method->max_stack()' takes into account > the 'extra_stack_entries()' while the value for 'istate->_stack_limit' > does not account for it. 'istate->_stack_limit' is computed in > 'CppInterpreterGenerator::generate_compute_interpreter_state()' right > from the 'max_stack' member of methodOopDesc. > > Now if I understand you right, you suggest to remove all the parts > which add the 'extra_stack_entries()' to the stack size. But wouldn't > that be wrong? Isn't it necessary to prepare the stack to hold these > two extra field in case they are needed by a method which contains > invokedynamic calls? As far as I can see the template interpreter is > still using this 'extra_stack' in > 'AbstractInterpreter::size_top_interpreter_activation' although you > advised to remove it in your mail. > > If the 'extra_stack' is really not needed, would it be reasonable to > change the mention assertion to use 'verifier_max_stack()' instead of > 'max_stack()'? > > Thank you and best regards, > Volker > > > > On Wed, Oct 31, 2012 at 6:54 PM, Christian Thalinger > wrote: >> On Oct 30, 2012, at 4:25 PM, serguei.spitsyn at oracle.com wrote: >> >>> Ok, it seems there are some suspicious fragments in the interpreter code. >>> Christian, could you, please, check and comment the fragments below? >>> >>> This is how the Method::max_stack() is defined: >>> >>> src/share/vm/oops/method.hpp: >>> >>> int verifier_max_stack() const { return _max_stack; } >>> int max_stack() const { return _max_stack + extra_stack_entries(); } >>> void set_max_stack(int size) { _max_stack = size; } >>> . . . >>> static int extra_stack_entries() { return EnableInvokeDynamic ? 2 : 0; } >>> >>> >>> The following code fragments are unaware that the method->max_stack() returns _max_stack + extra_stack_entries() : >>> >>> src/cpu/sparc/vm/cppInterpreter_sparc.cpp: >>> src/cpu/sparc/vm/cppInterpreter_x86.cpp: >>> >>> static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { >>> . . . >>> const int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? >>> return (round_to(max_stack + >>> extra_stack + >> Remove extra_stack. >> >>> . . . >>> } >>> . . . >>> void BytecodeInterpreter::layout_interpreterState(interpreterState to_fill, >>> . . . >>> int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? >>> to_fill->_stack_limit = stack_base - (method->max_stack() + 1 + extra_stack); >> Remove extra_stack (but keep the +1; see comment nearby). >> >>> . . . >>> } >>> >>> >>> src/cpu/sparc/vm/templateInterpreter_sparc.cpp: >>> >>> static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { >>> . . . >>> const int max_stack_words = max_stack * Interpreter::stackElementWords; >>> return (round_to((max_stack_words >>> //6815692//+ Method::extra_stack_words() ???? >> The comment needs to be removed. >> >>> . . . >>> } >>> >>> At the size_activation_helper call sites the second parameter is usually passed as method->max_stack(). >>> >>> >>> src/cpu/x86/vm/templateInterpreter_x86_32.cpp: >>> src/cpu/x86/vm/templateInterpreter_x86_64.cpp: >>> >>> int AbstractInterpreter::size_top_interpreter_activation(Method* method) { >>> . . . >>> const int extra_stack = Method::extra_stack_entries(); >>> const int method_stack = (method->max_locals() + method->max_stack() + extra_stack) * >> Remove extra_stack. >> >>> Interpreter::stackElementWords; >>> . . . >>> } >>> >>> >>> src/share/vm/interpreter/oopMapCache.cpp: >>> >>> void OopMapForCacheEntry::compute_map(TRAPS) { >>> . . . >>> // First check if it is a method where the stackmap is always empty >>> if (method()->code_size() == 0 || method()->max_locals() + method()->max_stack() == 0) { >>> _entry->set_mask_size(0); >>> } else { >>> . . . >>> } >>> >>> Above, if the invokedynamic is enabled then the method()->max_stack() can not be 0. >>> We need to check it if this fact does not break the fragment. >> That means we are always generating oop maps even if we wouldn't need them. Let me think more about this... >> >> -- Chris >> >>> >>> I'm still looking at other places... >>> >>> >>> Thanks, >>> Serguei >>> >>> >>> On 10/30/12 10:41 AM, serguei.spitsyn at oracle.com wrote: >>>> I have a plan to look at it, at least for other serviceablity code. >>>> It'd be good if someone from the runtime or compiler team checked it too. >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: >>>>> Thumbs up. >>>>> >>>>> Is someone going to do an audit for similar missing changes >>>>> from max_stack() (not max_size()) to verifier_max_stack()? >>>>> >>>>> Dan >>>>> >>>>> >>>>> On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >>>>>> Hello, >>>>>> >>>>>> >>>>>> Please, review the fix for CR: >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >>>>>> >>>>>> CR in JIRA: >>>>>> https://jbs.oracle.com/bugs/browse/JDK-7194607 >>>>>> >>>>>> Open webrev: >>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >>>>>> >>>>>> >>>>>> Summary: >>>>>> >>>>>> This issue is caused by the changes in the oops/method.hpp for invokedynamic (JSR 292). >>>>>> Now the max_stack() adds +2 to the original code attribute stack size if invokedynamic is enabled. >>>>>> The verifier_max_stack() must be used in the jvmtiClassFileReconstituter.cpp >>>>>> instead of the max_size() to get the code attribute stack size. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> From sean.mullan at oracle.com Fri Mar 1 13:26:11 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Fri, 01 Mar 2013 21:26:11 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130301212643.176DB477C3@hg.openjdk.java.net> Changeset: 1652ac7b4bfd Author: mullan Date: 2013-03-01 16:12 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1652ac7b4bfd 8008908: Access denied when invoking Subject.doAsPrivileged() Summary: wildcard principal names are not processed correctly Reviewed-by: xuelei ! src/share/classes/sun/security/provider/PolicyFile.java + test/sun/security/provider/PolicyFile/WildcardPrincipalName.java + test/sun/security/provider/PolicyFile/wildcard.policy Changeset: 1ca712765acb Author: mullan Date: 2013-03-01 16:15 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ca712765acb Merge From dan.xu at oracle.com Fri Mar 1 14:30:57 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 01 Mar 2013 22:30:57 +0000 Subject: hg: jdk8/tl/jdk: 8006645: TEST_BUG: java/nio/file/Files/CopyAndMove.java failing intermittently (sol) Message-ID: <20130301223119.D494B477C9@hg.openjdk.java.net> Changeset: 30e30ef6077e Author: dxu Date: 2013-03-01 14:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30e30ef6077e 8006645: TEST_BUG: java/nio/file/Files/CopyAndMove.java failing intermittently (sol) Summary: Fix test failures and update java doc of Files.move Reviewed-by: alanb, chegar ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/CopyAndMove.java From daniel.daugherty at oracle.com Fri Mar 1 18:08:24 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sat, 02 Mar 2013 02:08:24 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 26 new changesets Message-ID: <20130302021035.E1573477D1@hg.openjdk.java.net> Changeset: db3359133cdd Author: katleman Date: 2013-02-21 11:12 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/db3359133cdd Added tag jdk8-b78 for changeset d5e12e7d2f71 ! .hgtags Changeset: 555ec35a2507 Author: amurillo Date: 2013-02-22 10:02 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/555ec35a2507 Merge Changeset: 6691814929b6 Author: amurillo Date: 2013-02-22 10:02 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6691814929b6 Added tag hs25-b20 for changeset 555ec35a2507 ! .hgtags Changeset: be1fbee20765 Author: amurillo Date: 2013-02-22 10:12 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be1fbee20765 8008692: new hotspot build - hs25-b21 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 77f9b6d0126e Author: sspitsyn Date: 2013-02-27 12:20 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77f9b6d0126e Merge - agent/make/bugspot.bat - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java - agent/src/share/native/jvmdi/sa.cpp - agent/src/share/native/jvmdi/sa.dsp - agent/src/share/native/jvmdi/sa.dsw - agent/src/share/native/jvmdi/sa.hpp - make/bsd/makefiles/wb.make - make/linux/makefiles/wb.make - make/solaris/makefiles/wb.make - make/windows/makefiles/wb.make - src/share/tools/whitebox/sun/hotspot/WhiteBox.java - src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java Changeset: 0598674c0056 Author: jwilhelm Date: 2013-02-21 11:16 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0598674c0056 8008314: Unimplemented() Atomic::load breaks the applications Summary: jlong atomics isn't fully implemented om all 32-bit platforms so we try to avoid it. In this case the atomic add wasn't needed. Reviewed-by: dholmes, dlong ! src/share/vm/runtime/atomic.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: 96c885895d22 Author: johnc Date: 2013-02-22 11:01 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/96c885895d22 8007221: G1: concurrent phase durations do not state the time units ("secs") Summary: Add timer units to concurrent marking phases where the units were missing. Reviewed-by: jmasa, ysr ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: 9a8ee5301f33 Author: brutisso Date: 2013-02-26 11:52 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9a8ee5301f33 Merge Changeset: f1fb03a251e9 Author: poonam Date: 2013-02-21 23:58 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f1fb03a251e9 8008546: Wrong G1ConfidencePercent results in GUARANTEE(VARIANCE() > -1.0) FAILED Reviewed-by: brutisso, johnc Contributed-by: vladimir.kempik at oracle.com ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: fd32b88a87e9 Author: poonam Date: 2013-02-23 17:40 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fd32b88a87e9 Merge Changeset: 9289a00709b5 Author: poonam Date: 2013-02-26 08:58 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9289a00709b5 Merge Changeset: b685ca4f4fb9 Author: ehelin Date: 2013-02-20 16:41 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b685ca4f4fb9 8008536: Add HotSpot support for printing class loader statistics for JMap Reviewed-by: sla, brutisso + agent/src/share/classes/sun/jvm/hotspot/tools/ClassLoaderStats.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 3d3379aab292 Author: ehelin Date: 2013-02-26 22:31 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3d3379aab292 Merge - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 9a094d29af19 Author: ehelin Date: 2013-02-06 07:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9a094d29af19 8004924: NPG: jmap -heap output should contain ClassMetaspaceSize value Reviewed-by: stefank, mgerdin ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java + test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java Changeset: b5e03c8ead49 Author: brutisso Date: 2013-02-28 09:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5e03c8ead49 Merge - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 6931f425c517 Author: roland Date: 2013-02-25 14:13 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6931f425c517 8007294: ReduceFieldZeroing doesn't check for dependent load and can lead to incorrect execution Summary: InitializeNode::can_capture_store() must check that the captured store doesn't overwrite a memory location that is loaded before the store. Reviewed-by: kvn ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/phaseX.cpp + test/compiler/8007294/Test8007294.java Changeset: 706c919d3b56 Author: roland Date: 2013-02-26 12:18 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/706c919d3b56 8007722: C2: "assert(tp->base() != Type::AnyPtr) failed: not a bare pointer" at machnode.cpp:376 Summary: GetAndSetP's MachNode should capture bottom type. Reviewed-by: kvn ! src/share/vm/adlc/formssel.cpp + test/compiler/8007722/Test8007722.java Changeset: a00ed9736260 Author: drchase Date: 2013-02-26 15:38 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a00ed9736260 8007776: Test6852078.java timeouts Summary: if more than 100 seconds and more than 100 iterations have both passed, then exit is allowed. Reviewed-by: kvn ! test/compiler/6852078/Test6852078.java Changeset: 133bf557ef77 Author: iignatyev Date: 2013-02-27 05:58 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/133bf557ef77 8007439: C2: adding successful message of inlining Reviewed-by: kvn, vlivanov ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/parse.hpp Changeset: b02157cd249f Author: vlivanov Date: 2013-02-27 08:03 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b02157cd249f Merge Changeset: 338da89b2592 Author: vlivanov Date: 2013-02-28 15:31 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/338da89b2592 Merge Changeset: 5d395eb2626f Author: katleman Date: 2013-02-28 10:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5d395eb2626f Added tag jdk8-b79 for changeset 6691814929b6 ! .hgtags Changeset: df5396524152 Author: amurillo Date: 2013-03-01 04:45 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/df5396524152 Merge - agent/make/bugspot.bat - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java - agent/src/share/native/jvmdi/sa.cpp - agent/src/share/native/jvmdi/sa.dsp - agent/src/share/native/jvmdi/sa.dsw - agent/src/share/native/jvmdi/sa.hpp - make/bsd/makefiles/wb.make - make/linux/makefiles/wb.make - make/solaris/makefiles/wb.make - make/windows/makefiles/wb.make - src/share/tools/whitebox/sun/hotspot/WhiteBox.java - src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java Changeset: 4a198b201f3c Author: amurillo Date: 2013-03-01 04:45 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4a198b201f3c Added tag hs25-b21 for changeset df5396524152 ! .hgtags Changeset: 7f482030ff64 Author: amurillo Date: 2013-03-01 04:58 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7f482030ff64 8009226: new hotspot build - hs25-b22 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 3e83d69c19db Author: dcubed Date: 2013-03-01 15:59 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3e83d69c19db Merge From chris.hegarty at oracle.com Sat Mar 2 00:56:36 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sat, 02 Mar 2013 08:56:36 +0000 Subject: hg: jdk8/tl/jdk: 8008378: FJP.commonPool support parallelism 0, add awaitQuiescence Message-ID: <20130302085658.C3B57477DA@hg.openjdk.java.net> Changeset: f08ad5938709 Author: chegar Date: 2013-03-02 08:54 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f08ad5938709 8008378: FJP.commonPool support parallelism 0, add awaitQuiescence Reviewed-by: chegar Contributed-by: Doug Lea
, Chris Hegarty ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java + test/java/util/concurrent/forkjoin/ThreadLessCommon.java + test/java/util/concurrent/forkjoin/ThrowingRunnable.java From yumin.qi at oracle.com Sat Mar 2 23:57:22 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Sat, 02 Mar 2013 23:57:22 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <50FF849E.7030104@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> Message-ID: <51330262.2000102@oracle.com> Hi, all Please review at the new changes. Include 1) use unique_thread_id (which is a 64 bit integer on Macosx) to identify thread. Add a function in BsdDebuggerLocal to call the newly added function BsdThread.getUniqueThreadId to get this id. Meanwhile, move the code of forming threadList in native part to BsdDebuggerLocal.java since the thread ids of all java threads can be obtained from Threads and coding is much easier and clear. 2) To have better performance, get all java thread ids, stack infos (stack begin, stack end) into one array of long which is decoded in native code and used to set thread ids. This save much more time first time to fill java thread ids. 3) remove DarwinVtblAccess.java which added in last version , its functionality moved to BsdVtblAccess.java 4) BugSpotAgent.java no long exists, remove the changes. 5) remove unsupported platform defs. http://cr.openjdk.java.net/~minqi/8003348/ Thanks Yumin On 1/22/2013 10:35 PM, Yumin Qi wrote: > Hi, Staffan (and Serguei) > > Made some clean for code. > 1) added mach-o file fat header parsing as you suggested. > 2) modified get_real_path as you indicated it could run with > jre/bin/java > 3) moved output information from CommandProcessor.java to > PStack.java for printing out pstack not available for Darwin. > 4) code clean, file header update. > > Please take a look at same location. > > Thanks > Yumin > > On 1/18/2013 3:58 AM, Staffan Larsen wrote: >> Thanks for doing this Yumin! >> >> I tried to apply you patch and run it, but I can't get SA to open a >> core file. You can see the exception I get below. Is there some kind >> of setup I need to do? This is against a jvmg build of Hotspot. >> >> I also noticed that you forgot to update BugSpotAgent.java with the >> same changes as in HotspotAgent.java. This makes the jstack tool fail. >> >> I will look at the changes more closely. >> >> Thanks, >> /Staffan >> >> >> >> Opening core file, please wait... >> Unable to open core file >> /cores/core.79028: >> >> Doesn't appear to be a HotSpot VM (could not find symbol >> "gHotSpotVMTypes" in >> remote process) >> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a >> HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) >> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >> hsdb> Input stream closed. >> >> >> On 17 jan 2013, at 22:23, Yumin Qi wrote: >> >>> Hi, >>> >>> Please review for the changes for SA to read core file on Mac OS >>> X, this is feature is not implemented on previous releases. >>> This change made for SA to work on core file on Darwin, but >>> still some function not fixed, such as 'pstack'. This is intended to >>> integrate into 8. >>> >>> http://cr.openjdk.java.net/~minqi/8003348/ >>> >>> Please take some time since the code change is a little bigger. >>> >>> Thanks very much >>> Yumin From kumar.x.srinivasan at oracle.com Sun Mar 3 21:45:44 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 04 Mar 2013 05:45:44 +0000 Subject: hg: jdk8/tl/jdk: 8007297: [pack200] allow opcodes with InterfaceMethodRefs Message-ID: <20130304054606.8A143477FE@hg.openjdk.java.net> Changeset: df76ba760eec Author: ksrini Date: 2013-03-03 20:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df76ba760eec 8007297: [pack200] allow opcodes with InterfaceMethodRefs Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/InstructionTests.java ! test/tools/pack200/Utils.java From sundararajan.athijegannathan at oracle.com Mon Mar 4 08:49:44 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 04 Mar 2013 16:49:44 +0000 Subject: hg: jdk8/tl/nashorn: 9 new changesets Message-ID: <20130304164950.17A2147812@hg.openjdk.java.net> Changeset: 071e859b371e Author: attila Date: 2013-02-27 15:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/071e859b371e 8009143: Eliminate Dynalink dependency on java.beans Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/BeansLinker.java Changeset: 928ea3d8faf0 Author: attila Date: 2013-02-27 15:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/928ea3d8faf0 8009146: Eliminate some dead code in preparation for immutable AST Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/Assignment.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java Changeset: 1da9e37697f6 Author: attila Date: 2013-02-27 16:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1da9e37697f6 8009150: Previous dead code elimination was incomplete Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/ir/BinaryNode.java Changeset: 1e03be240534 Author: sundar Date: 2013-02-28 20:31 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1e03be240534 8009229: ant makefile default target should be "test" Reviewed-by: lagergren, jlaskey ! make/build.xml Changeset: 037e1de7ab1a Author: hannesw Date: 2013-02-28 22:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/037e1de7ab1a 8009240: RegExpScanner code is inefficient and too complex Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java Changeset: 7e9fbe621d87 Author: sundar Date: 2013-03-01 15:58 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7e9fbe621d87 8009263: Fix all javadoc errors in nashorn code Reviewed-by: hannesw, lagergren ! make/project.properties ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/objects/DateParser.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java Changeset: 3b222c90b7de Author: jlaskey Date: 2013-03-02 11:26 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3b222c90b7de Merge Changeset: f90810d79b57 Author: hannesw Date: 2013-03-04 11:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f90810d79b57 8008370: coffee script compiler doesn't work with Nashorn Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8008370.js + test/script/basic/JDK-8008370.js.EXPECTED Changeset: fe5211fc3114 Author: jlaskey Date: 2013-03-04 11:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fe5211fc3114 8009379: Remove $ from generated class names Reviewed-by: attila, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java - src/jdk/nashorn/internal/scripts/JO$.java + src/jdk/nashorn/internal/scripts/JO.java - src/jdk/nashorn/internal/scripts/JS$.java + src/jdk/nashorn/internal/scripts/JS.java From staffan.larsen at oracle.com Mon Mar 4 10:56:21 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 4 Mar 2013 19:56:21 +0100 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Message-ID: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: 57 static void dll_build_name(char* buffer, size_t buflen, 58 const char* pname, const char* fname) { 59 // Based on os_solaris.cpp 60 61 char *path_sep = PATH_SEPARATOR; 62 char *pathname = (char *)pname; 63 while (strlen(pathname) > 0) { 64 char *p = strchr(pathname, *path_sep); 65 if (p == NULL) { 66 p = pathname + strlen(pathname); 67 } 68 /* check for NULL path */ 69 if (p == pathname) { 70 continue; 71 } 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), 73 pathname, fname); 74 75 if (access(buffer, F_OK) == 0) { 76 break; 77 } 78 pathname = p + 1; 79 *buffer = '\0'; 80 } If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). The same code show up in both the solaris code and the windows code as well as hprof. bug: http://bugs.sun.com/view_bug.do?bug_id=8009397 webrev: http://cr.openjdk.java.net/~sla/8009397/webrev.00/ Thanks, /Staffan From joe.darcy at oracle.com Mon Mar 4 19:43:26 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 05 Mar 2013 03:43:26 +0000 Subject: hg: jdk8/tl/jdk: 8009267: Restore isAnnotationPresent methods in public AnnotatedElement implementations Message-ID: <20130305034349.4068A4782F@hg.openjdk.java.net> Changeset: 83e847f59fd6 Author: darcy Date: 2013-03-04 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83e847f59fd6 8009267: Restore isAnnotationPresent methods in public AnnotatedElement implementations Reviewed-by: jjg ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/reflect/AccessibleObject.java + test/java/lang/reflect/OldenCompilingWithDefaults.java From naoto.sato at oracle.com Mon Mar 4 20:48:47 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 05 Mar 2013 04:48:47 +0000 Subject: hg: jdk8/tl/jdk: 8004240: Return value from getAdapterPrefence() can be modified Message-ID: <20130305044903.5A26C47830@hg.openjdk.java.net> Changeset: 1a2e59d19d3e Author: naoto Date: 2013-03-04 20:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1a2e59d19d3e 8004240: Return value from getAdapterPrefence() can be modified Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java + test/java/util/Locale/Bug8004240.java From rickard.backman at oracle.com Mon Mar 4 23:07:58 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 5 Mar 2013 08:07:58 +0100 Subject: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub() || sender_blob->is_nmethod()) failed: Impossible call chain In-Reply-To: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com> References: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com> Message-ID: <788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com> Anyone have time to look at this? Thanks /R On Mar 1, 2013, at 10:27 AM, Rickard B?ckman wrote: > Hi all, > > here comes another update to frame.safe_for_sender. > If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. > In this case we read one that pointed into the Safepoint blob. > > We now pretty much guarded for all kind of blobs in safe_for_sender, > so I've changed the method to not assert in the end but to do it the same was as the frame_sparc.cpp did it. Everything that is not > a nmethod at the end of the method is not safe. > > I've also changed another check for a frame_size == 0 to frame_size <= 0 to make it somewhat more safer. > > The bug: http://bugs.sun.com/view_bug.do?bug_id=8008357 > Webrev: http://cr.openjdk.java.net/~rbackman/8008357/ > > This webrev is for HS24. > > Thanks > /R From staffan.larsen at oracle.com Mon Mar 4 23:24:46 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 5 Mar 2013 08:24:46 +0100 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c Message-ID: A very small fix for a warning. webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ Thanks, /Staffan From markus.gronlund at oracle.com Mon Mar 4 23:36:59 2013 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Mon, 4 Mar 2013 23:36:59 -0800 (PST) Subject: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub() || sender_blob->is_nmethod()) failed: Impossible call chain In-Reply-To: <788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com> References: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com> <788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com> Message-ID: <83095bcd-17c5-42d8-9ab0-f488dd57294a@default> Rickard, The comments on line 221-222 is are a bit confusion in association with the conditional and the follow-up assert on line 225. The comment outlines the layout and invariant for nmethods, but in the conditional (sender_blob->frame_size() <= 0), there is an assert that sender_blob is NOT an nmethod? This is a bit unclear. Also, the sentence is weird: "if the frame size is 0 something (or less) is bad because every nmethod..." Also, do you need that particular assert there? The same logic comes again in non-asserting code at line 234. Maybe just rework/remove the assert and weave in the real logic for that check? Not a Reviewer. Cheers Markus -----Original Message----- From: Rickard B?ckman Sent: den 5 mars 2013 08:08 To: serviceability-dev serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: Re: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub() || sender_blob->is_nmethod()) failed: Impossible call chain Anyone have time to look at this? Thanks /R On Mar 1, 2013, at 10:27 AM, Rickard B?ckman wrote: > Hi all, > > here comes another update to frame.safe_for_sender. > If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. > In this case we read one that pointed into the Safepoint blob. > > We now pretty much guarded for all kind of blobs in safe_for_sender, > so I've changed the method to not assert in the end but to do it the > same was as the frame_sparc.cpp did it. Everything that is not a nmethod at the end of the method is not safe. > > I've also changed another check for a frame_size == 0 to frame_size <= 0 to make it somewhat more safer. > > The bug: http://bugs.sun.com/view_bug.do?bug_id=8008357 > Webrev: http://cr.openjdk.java.net/~rbackman/8008357/ > > This webrev is for HS24. > > Thanks > /R From david.holmes at oracle.com Mon Mar 4 23:39:53 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 05 Mar 2013 17:39:53 +1000 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: References: Message-ID: <5135A149.3040608@oracle.com> Looks fine to me - thanks Staffan! David On 5/03/2013 5:24 PM, Staffan Larsen wrote: > A very small fix for a warning. > > webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ > > Thanks, > /Staffan > From markus.gronlund at oracle.com Mon Mar 4 23:48:23 2013 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Mon, 4 Mar 2013 23:48:23 -0800 (PST) Subject: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub() || sender_blob->is_nmethod()) failed: Impossible call chain In-Reply-To: <83095bcd-17c5-42d8-9ab0-f488dd57294a@default> References: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com> <788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com> <83095bcd-17c5-42d8-9ab0-f488dd57294a@default> Message-ID: Rickard, Sorry, please forget about my first comments on the first assert: "The comments on line 221-222 is are a bit confusion in association with the conditional and the follow-up assert on line 225. The comment outlines the layout and invariant for nmethods, but in the conditional (sender_blob->frame_size() <= 0), there is an assert that sender_blob is NOT an nmethod?" This is of course correct, I read it wrongly. The assert is placed ok there. Maybe just fix up the comments? Cheers Markus -----Original Message----- From: Markus Gr?nlund Sent: den 5 mars 2013 08:37 To: Rickard B?ckman Cc: serviceability-dev serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: RE: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub() || sender_blob->is_nmethod()) failed: Impossible call chain Rickard, The comments on line 221-222 is are a bit confusion in association with the conditional and the follow-up assert on line 225. The comment outlines the layout and invariant for nmethods, but in the conditional (sender_blob->frame_size() <= 0), there is an assert that sender_blob is NOT an nmethod? This is a bit unclear. Also, the sentence is weird: "if the frame size is 0 something (or less) is bad because every nmethod..." Also, do you need that particular assert there? The same logic comes again in non-asserting code at line 234. Maybe just rework/remove the assert and weave in the real logic for that check? Not a Reviewer. Cheers Markus -----Original Message----- From: Rickard B?ckman Sent: den 5 mars 2013 08:08 To: serviceability-dev serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: Re: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub() || sender_blob->is_nmethod()) failed: Impossible call chain Anyone have time to look at this? Thanks /R On Mar 1, 2013, at 10:27 AM, Rickard B?ckman wrote: > Hi all, > > here comes another update to frame.safe_for_sender. > If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. > In this case we read one that pointed into the Safepoint blob. > > We now pretty much guarded for all kind of blobs in safe_for_sender, > so I've changed the method to not assert in the end but to do it the > same was as the frame_sparc.cpp did it. Everything that is not a nmethod at the end of the method is not safe. > > I've also changed another check for a frame_size == 0 to frame_size <= 0 to make it somewhat more safer. > > The bug: http://bugs.sun.com/view_bug.do?bug_id=8008357 > Webrev: http://cr.openjdk.java.net/~rbackman/8008357/ > > This webrev is for HS24. > > Thanks > /R From serguei.spitsyn at oracle.com Tue Mar 5 01:18:05 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 05 Mar 2013 01:18:05 -0800 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: References: Message-ID: <5135B84D.9020401@oracle.com> Looks good. Thanks, Serguei On 3/4/13 11:24 PM, Staffan Larsen wrote: > A very small fix for a warning. > > webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ > > Thanks, > /Staffan From chris.hegarty at oracle.com Tue Mar 5 02:12:52 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 05 Mar 2013 10:12:52 +0000 Subject: hg: jdk8/tl/jdk: 8009259: TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently Message-ID: <20130305101319.BD3DC47839@hg.openjdk.java.net> Changeset: 62639ca66ab9 Author: ewang Date: 2013-03-05 10:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62639ca66ab9 8009259: TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently Reviewed-by: chegar, alanb ! test/sun/misc/Cleaner/ExitOnThrow.java ! test/sun/misc/Cleaner/exitOnThrow.sh From staffan.larsen at oracle.com Tue Mar 5 02:23:28 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 05 Mar 2013 10:23:28 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8009287: [parfait] Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c Message-ID: <20130305102335.9DD5E4783B@hg.openjdk.java.net> Changeset: 255c0a4cb4eb Author: sla Date: 2013-03-05 08:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/255c0a4cb4eb 8009287: [parfait] Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c Reviewed-by: dholmes, kvn, mikael, morris ! agent/src/os/linux/ps_core.c From staffan.larsen at oracle.com Tue Mar 5 05:11:38 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 5 Mar 2013 14:11:38 +0100 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <51330262.2000102@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> Message-ID: <59AFD517-67D0-44DC-A832-91590ED33C39@oracle.com> Yumin, This looks much better. Thank you for spending the extra time on this. The SA code in general (and the native code in particular) is quite messy and could use a lot of cleanup, but we'll have to leave that for later. A few comments below: General comment: Please use "#ifdef __APPLE__" consistently (instead of sometimes using "#ifndef __APPLE__"). I think this makes it easier to read the code. MacosxDebuggerLocal.m getThreadIntegerRegisterSet(): - Should be renamed getThreadIntegerRegisterSetFromCore() or something similar to indicate that this is used only for core files. readBytesFromProcess() - Should also be renamed tom include FromCore. Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_attach0__I() - It looks like the code for ptrace_attach (lines 528-534) were accidentally removed fill_java_threads - CHECK_EXCEPTION_(0) should be CHECK_EXCEPTION_(false) - I think cinfos should be of type uint64_t* since it holds some (more or less) untyped values. - The inner loop can be made easier to read by breaking out the reading of cinfos[]. Something like: for (j = 0; j < len; j += 3) { lwpid_t lwp = cinfos[j]; uint64_t beg = cinfos[j + 1]; uint64_t end = cinfos[j + 2]; if ((regs.r_rsp < end && regs.r_rsp >= beg) || (regs.r_rbp < end && regs.r_rbp >= beg)) { set_lwp_id(ph, i, lwp); break; } } - Also note in the above code that rsp and rbp cannot be equal to end, they have to be strictly smaller. BsbDebuggerLocal.java getThreadForIdentifierAddress(Address addr) - I had intentionally made this throw an exception when fixing JDK-8006423. This was so that a BsdThread could not be created without setting the unique_thread_id. Is that no longer valid? Or was this method resurrected by mistake? getJavaThreadsInfo - nit: no need to cast the value from t.getStackBaseValue(), it's already a long BsdThread.java BsdThread(BsdDebugger debugger, Address threadIdAddr) - This constructor was removed in JDK-8006423 - see above. HotspotAgent.java connectRemoteDebugger() - The if-clause is missing a case for "darwin". (Unfortunately remote debugging does not work even after this fix because of the changes I recently made to BsdAMD64JavaThreadPDAccess.getThreadProxy(), so that will have to be revisted.) Thanks, /Staffan On 3 mar 2013, at 08:57, Yumin Qi wrote: > Hi, all > > Please review at the new changes. Include > 1) use unique_thread_id (which is a 64 bit integer on Macosx) to identify thread. Add a function in BsdDebuggerLocal to call the newly added function BsdThread.getUniqueThreadId to get this id. Meanwhile, move the code of forming threadList in native part to BsdDebuggerLocal.java since the thread ids of all java threads can be obtained from Threads and coding is much easier and clear. > > 2) To have better performance, get all java thread ids, stack infos (stack begin, stack end) into one array of long which is decoded in native code and used to set thread ids. This save much more time first time to fill java thread ids. > > 3) remove DarwinVtblAccess.java which added in last version , its functionality moved to BsdVtblAccess.java > > 4) BugSpotAgent.java no long exists, remove the changes. > > 5) remove unsupported platform defs. > > http://cr.openjdk.java.net/~minqi/8003348/ > > Thanks > Yumin > > On 1/22/2013 10:35 PM, Yumin Qi wrote: >> Hi, Staffan (and Serguei) >> >> Made some clean for code. >> 1) added mach-o file fat header parsing as you suggested. >> 2) modified get_real_path as you indicated it could run with jre/bin/java >> 3) moved output information from CommandProcessor.java to PStack.java for printing out pstack not available for Darwin. >> 4) code clean, file header update. >> >> Please take a look at same location. >> >> Thanks >> Yumin >> >> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>> Thanks for doing this Yumin! >>> >>> I tried to apply you patch and run it, but I can't get SA to open a core file. You can see the exception I get below. Is there some kind of setup I need to do? This is against a jvmg build of Hotspot. >>> >>> I also noticed that you forgot to update BugSpotAgent.java with the same changes as in HotspotAgent.java. This makes the jstack tool fail. >>> >>> I will look at the changes more closely. >>> >>> Thanks, >>> /Staffan >>> >>> >>> >>> Opening core file, please wait... >>> Unable to open core file >>> /cores/core.79028: >>> >>> Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in >>> remote process) >>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) >>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>> hsdb> Input stream closed. >>> >>> >>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>> >>>> Hi, >>>> >>>> Please review for the changes for SA to read core file on Mac OS X, this is feature is not implemented on previous releases. >>>> This change made for SA to work on core file on Darwin, but still some function not fixed, such as 'pstack'. This is intended to integrate into 8. >>>> >>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>> >>>> Please take some time since the code change is a little bigger. >>>> >>>> Thanks very much >>>> Yumin > From staffan.larsen at oracle.com Tue Mar 5 05:18:15 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 5 Mar 2013 14:18:15 +0100 Subject: [PATCH] typeToVtbl of BasicTypeDataBase should not be static In-Reply-To: References: Message-ID: Yunda, Thanks for the patch. I have created issue JDK-8009456 to track this and can sponsor the fix as soon as we get a Review of the fix. /Staffan On 28 feb 2013, at 04:59, ??(Yunda) wrote: > Hi all, > > I found that when I detached a java process and attached another java process, the ?universe? command of CLHSDB didn?t show the right information. But when I restarted CLHSDB and attached to the same process the problem disappeared: > > hsdb> attach 29211 > Attaching to process 29211, please wait... > hsdb> universe > Heap Parameters: > ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289aa8,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> > hsdb> detach > hsdb> attach 29887 > Attaching to process 29887, please wait... > hsdb> universe > Heap Parameters: > unknown subtype of CollectedHeap @ 0x0000000000d56fb0 (0x00000000ca600000,0x0000000100000000) > hsdb> quit > [~]$ java -cp .:$JAVA_HOME/lib/sa-jdi.jar sun.jvm.hotspot.CLHSDB > hsdb> attach 29887 > Attaching to process 29887, please wait... > hsdb> universe > Heap Parameters: > ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289a68,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> > > I think it?s caused by the wrong definition of ?typeToVtbl? field of BasicTypeDataBase. Since typeToVtbl should be recreated every time SA attaches to a new process, it should not be static. So I made a small patch fo fix it: > > diff -r ec2eddfed950 agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java > --- a/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Tue Feb 26 14:09:52 2013 +0100 > +++ b/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Thu Feb 28 11:57:55 2013 +0800 > @@ -150,7 +150,7 @@ > return VM.getVM().getOopSize(); > } > - static HashMap typeToVtbl = new HashMap(); > + private HashMap typeToVtbl = new HashMap(); > private Address vtblForType(Type type) { > Address vtblAddr = (Address)typeToVtbl.get(type); > > > After applying this patch, the problem I mentioned above disappeared. > > Regards, > Yunda > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130305/0d26f0e2/attachment.html From staffan.larsen at oracle.com Tue Mar 5 05:20:31 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 5 Mar 2013 14:20:31 +0100 Subject: [PATCH] A small fix on "scanoops" command in CLHSDB In-Reply-To: References: <51259564.2070501@oracle.com> <65F834EF-10EF-4768-92F4-12D0984A2C4A@oracle.com> Message-ID: I have created issue JDK-8009457 to track this. Still waiting for a review, though. Thanks, /Staffan On 22 feb 2013, at 04:32, ???? wrote: > Staffan & Kris, > > Thank both of you for reviewing this. Hope you two could be official Reviewer soon J > > Regards, > Yunda > > ??????: Staffan Larsen [mailto:staffan.larsen at oracle.com] > ????????: 2013??2??21?? 18:21 > ??????: Krystal Mo > ????: ????; serviceability-dev at openjdk.java.net > ????: Re: [PATCH] A small fix on "scanoops" command in CLHSDB > > I think this looks good, too. I'm not an official Reviewer, either. > > Thanks, > /Staffan > > On 21 feb 2013, at 04:32, Krystal Mo wrote: > > > Hi Yunda, > > This patch looks reasonable to me. But you'll need an official Reviewer to review this. > > - Kris > > On 2013/2/19 1:24, ???? wrote: > Hi all, > > When I use ??scanoops?? command in CLHSDB, I find that if the type doesn??t exist, the output will be all the oops in the scope [start, end]. (see below) I think that??s irrational because all the oops between 0x00000000ee2000a0 and 0x00000000ee200550 are of type ??java/lang/Class?? and there??s no type ??java/lang/Class2?? or ??com/taobao/Test?? at all! > > hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 > 0x00000000ee2000a0 java/lang/Class > 0x00000000ee200118 java/lang/Class > 0x00000000ee200190 java/lang/Class > 0x00000000ee200208 java/lang/Class > 0x00000000ee200280 java/lang/Class > 0x00000000ee2002f8 java/lang/Class > 0x00000000ee200370 java/lang/Class > 0x00000000ee2003e8 java/lang/Class > 0x00000000ee200460 java/lang/Class > 0x00000000ee2004d8 java/lang/Class > hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 java/lang/Class2 > 0x00000000ee2000a0 java/lang/Class > 0x00000000ee200118 java/lang/Class > 0x00000000ee200190 java/lang/Class > 0x00000000ee200208 java/lang/Class > 0x00000000ee200280 java/lang/Class > 0x00000000ee2002f8 java/lang/Class > 0x00000000ee200370 java/lang/Class > 0x00000000ee2003e8 java/lang/Class > 0x00000000ee200460 java/lang/Class > 0x00000000ee2004d8 java/lang/Class > hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 com/taobao/Test > 0x00000000ee2000a0 java/lang/Class > 0x00000000ee200118 java/lang/Class > 0x00000000ee200190 java/lang/Class > 0x00000000ee200208 java/lang/Class > 0x00000000ee200280 java/lang/Class > 0x00000000ee2002f8 java/lang/Class > 0x00000000ee200370 java/lang/Class > 0x00000000ee2003e8 java/lang/Class > 0x00000000ee200460 java/lang/Class > 0x00000000ee2004d8 java/lang/Class > > I know the reason is that the usage of scanoops is ??scanoops start end [ type ]?? and ??type?? is optional. When you don??t input the ??type??, the output will be all the oops in the scope [start, end]. But I think the two situations are different and CLHSDB should give right prompt. So I made a small fix: > > diff -r b5e3ec9c69fa agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java > --- a/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Mon Feb 18 12:49:53 2013 +0100 > +++ b/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Tue Feb 19 16:43:45 2013 +0800 > @@ -1132,6 +1132,10 @@ > Klass klass = null; > if (t.countTokens() == 1) { > klass = SystemDictionaryHelper.findInstanceKlass(t.nextToken()); > + if(klass == null) { > + out.println("No such type."); > + return; > + } > } > while (base != null && base.lessThan(end)) { > long step = stride; > > And the effect will be: > hsdb> scanoops 0x0000000758600000 0x000000075860ffff com/taobao/Test > No such type. > > Regards, > Yunda > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ??????(????????????)?????????????????????????????????????????????????????????????????????????????????????????????????????????? ?????????????????????????????????? > > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130305/a80321da/attachment-0001.html From Alan.Bateman at oracle.com Tue Mar 5 06:19:38 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 05 Mar 2013 14:19:38 +0000 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> Message-ID: <5135FEFA.5070002@oracle.com> On 04/03/2013 18:56, Staffan Larsen wrote: > I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: > > : > > bug: http://bugs.sun.com/view_bug.do?bug_id=8009397 > webrev: http://cr.openjdk.java.net/~sla/8009397/webrev.00/ > This is a good find and the changes looks good to me. -Alan. From chris.hegarty at oracle.com Tue Mar 5 06:31:19 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 05 Mar 2013 14:31:19 +0000 Subject: hg: jdk8/tl/jdk: 8008804: file descriptor leak in src/windows/native/java/net/DualStackPlainSocketImpl.c Message-ID: <20130305143143.6BA2947841@hg.openjdk.java.net> Changeset: b5bef1f71de6 Author: jzavgren Date: 2013-03-05 14:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5bef1f71de6 8008804: file descriptor leak in src/windows/native/java/net/DualStackPlainSocketImpl.c Reviewed-by: alanb, chegar, dsamersoff ! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c From chris.hegarty at oracle.com Tue Mar 5 07:06:02 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 05 Mar 2013 15:06:02 +0000 Subject: hg: jdk8/tl/jdk: 4880778: URL final class has protected methods Message-ID: <20130305150624.D2EB747845@hg.openjdk.java.net> Changeset: be79440b8026 Author: jzavgren Date: 2013-03-05 09:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be79440b8026 4880778: URL final class has protected methods Summary: The two set() methods have been defined to be package private. Reviewed-by: alanb, chegar, khazra ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLStreamHandler.java From maurizio.cimadamore at oracle.com Tue Mar 5 07:55:55 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 05 Mar 2013 15:55:55 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20130305155606.5F88C47847@hg.openjdk.java.net> Changeset: 69cd2bfd4a31 Author: mcimadamore Date: 2013-03-05 14:04 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/69cd2bfd4a31 8004962: Code generation crash with lambda and local classes Summary: Translation info should be propagated from LambdaToMethod to Lower Reviewed-by: jjg, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/lambda/LambdaCapture07.java Changeset: d2a98dde7ecc Author: mcimadamore Date: 2013-03-05 14:12 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d2a98dde7ecc 8009227: Certain diagnostics should not be deferred Summary: Add new diagnostic flag to mark non deferrable diagnostics Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/lambda/abort/CompletionFailure.java Changeset: a708c5f1da06 Author: mcimadamore Date: 2013-03-05 14:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a708c5f1da06 8009154: Missing cast in method reference bridge leads to NoSuchMethodError Summary: Missing cast in generated method reference bridge Reviewed-by: rfield, jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/MethodReference65.java Changeset: 12202e6ab78a Author: mcimadamore Date: 2013-03-05 14:19 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/12202e6ab78a 8009129: Illegal access error when calling method reference Summary: Javac generates method handle referencing non public type Reviewed-by: jjg, rfield ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/diags/examples/NotDefPublicCantAccessFragment/NotDefPublicCantAccessFragment.java + test/tools/javac/diags/examples/NotDefPublicCantAccessFragment/p/C.java + test/tools/javac/lambda/inaccessibleMref01/InaccessibleMref01.java + test/tools/javac/lambda/inaccessibleMref01/InaccessibleMref01.out + test/tools/javac/lambda/inaccessibleMref01/p1/C.java + test/tools/javac/lambda/inaccessibleMref02/InaccessibleMref02.java + test/tools/javac/lambda/inaccessibleMref02/p1/C.java From mikael.vidstedt at oracle.com Tue Mar 5 09:04:21 2013 From: mikael.vidstedt at oracle.com (Mikael Vidstedt) Date: Tue, 05 Mar 2013 09:04:21 -0800 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: References: Message-ID: <51362595.3000402@oracle.com> Looks good! Cheers, Mikael On 2013-03-04 23:24, Staffan Larsen wrote: > A very small fix for a warning. > > webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ > > Thanks, > /Staffan From staffan.larsen at oracle.com Tue Mar 5 10:19:48 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 5 Mar 2013 19:19:48 +0100 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <5135FEFA.5070002@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <5135FEFA.5070002@oracle.com> Message-ID: <6C61000D-683C-4ECC-A5DA-34703C66C9E1@oracle.com> Thanks Alan! On 5 mar 2013, at 15:19, Alan Bateman wrote: > On 04/03/2013 18:56, Staffan Larsen wrote: >> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: >> >> : >> >> bug: http://bugs.sun.com/view_bug.do?bug_id=8009397 >> webrev: http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >> > This is a good find and the changes looks good to me. > > -Alan. From serguei.spitsyn at oracle.com Tue Mar 5 11:26:49 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 05 Mar 2013 11:26:49 -0800 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> Message-ID: <513646F9.3060601@oracle.com> Hi Staffan, Thank you for this discovery! It looks good, but I have a couple of comments. It seems, there is one more problem in this code: 68 /* check for NULL path */ 69 if (p == pathname) { 70 continue;<== Endless loop if we hit this line 71 } Do we need to do 'pathname++' before continuing at the line #70? It is going to be endless loop in cases there is a PATH_SEPARATOR at the beginning of paths or two PATH_SEPARATOR's in a row. These would be incorrect path lists but the code above is targeting exactly such cases. Also, the argument name "pathname" in the original code is confusing. Should we rename it to "pathnames"? Thanks, Serguei On 3/4/13 10:56 AM, Staffan Larsen wrote: > I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: > > 57 static void dll_build_name(char* buffer, size_t buflen, > 58 const char* pname, const char* fname) { > 59 // Based on os_solaris.cpp > 60 > 61 char *path_sep = PATH_SEPARATOR; > 62 char *pathname = (char *)pname; > 63 while (strlen(pathname) > 0) { > 64 char *p = strchr(pathname, *path_sep); > 65 if (p == NULL) { > 66 p = pathname + strlen(pathname); > 67 } > 68 /* check for NULL path */ > 69 if (p == pathname) { > 70 continue; > 71 } > 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), > 73 pathname, fname); > 74 > 75 if (access(buffer, F_OK) == 0) { > 76 break; > 77 } > 78 pathname = p + 1; > 79 *buffer = '\0'; > 80 } > > If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). > > The same code show up in both the solaris code and the windows code as well as hprof. > > bug: http://bugs.sun.com/view_bug.do?bug_id=8009397 > webrev: http://cr.openjdk.java.net/~sla/8009397/webrev.00/ > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130305/e9c32748/attachment.html From serguei.spitsyn at oracle.com Tue Mar 5 12:09:45 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 05 Mar 2013 12:09:45 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <51330262.2000102@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> Message-ID: <51365109.2070403@oracle.com> Hi Yumin, I'm reviewing it. Thank you for doing this for the Serviceability team! Thanks, Serguei On 3/2/13 11:57 PM, Yumin Qi wrote: > Hi, all > > Please review at the new changes. Include > 1) use unique_thread_id (which is a 64 bit integer on Macosx) to > identify thread. Add a function in BsdDebuggerLocal to call the newly > added function BsdThread.getUniqueThreadId to get this id. Meanwhile, > move the code of forming threadList in native part to > BsdDebuggerLocal.java since the thread ids of all java threads can be > obtained from Threads and coding is much easier and clear. > > 2) To have better performance, get all java thread ids, stack > infos (stack begin, stack end) into one array of long which is decoded > in native code and used to set thread ids. This save much more time > first time to fill java thread ids. > > 3) remove DarwinVtblAccess.java which added in last version , its > functionality moved to BsdVtblAccess.java > > 4) BugSpotAgent.java no long exists, remove the changes. > > 5) remove unsupported platform defs. > > http://cr.openjdk.java.net/~minqi/8003348/ > > Thanks > Yumin > > On 1/22/2013 10:35 PM, Yumin Qi wrote: >> Hi, Staffan (and Serguei) >> >> Made some clean for code. >> 1) added mach-o file fat header parsing as you suggested. >> 2) modified get_real_path as you indicated it could run with >> jre/bin/java >> 3) moved output information from CommandProcessor.java to >> PStack.java for printing out pstack not available for Darwin. >> 4) code clean, file header update. >> >> Please take a look at same location. >> >> Thanks >> Yumin >> >> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>> Thanks for doing this Yumin! >>> >>> I tried to apply you patch and run it, but I can't get SA to open a >>> core file. You can see the exception I get below. Is there some kind >>> of setup I need to do? This is against a jvmg build of Hotspot. >>> >>> I also noticed that you forgot to update BugSpotAgent.java with the >>> same changes as in HotspotAgent.java. This makes the jstack tool fail. >>> >>> I will look at the changes more closely. >>> >>> Thanks, >>> /Staffan >>> >>> >>> >>> Opening core file, please wait... >>> Unable to open core file >>> /cores/core.79028: >>> >>> Doesn't appear to be a HotSpot VM (could not find symbol >>> "gHotSpotVMTypes" in >>> remote process) >>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a >>> HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) >>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>> hsdb> Input stream closed. >>> >>> >>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>> >>>> Hi, >>>> >>>> Please review for the changes for SA to read core file on Mac >>>> OS X, this is feature is not implemented on previous releases. >>>> This change made for SA to work on core file on Darwin, but >>>> still some function not fixed, such as 'pstack'. This is intended >>>> to integrate into 8. >>>> >>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>> >>>> Please take some time since the code change is a little bigger. >>>> >>>> Thanks very much >>>> Yumin > From martinrb at google.com Tue Mar 5 13:18:11 2013 From: martinrb at google.com (martinrb at google.com) Date: Tue, 05 Mar 2013 21:18:11 +0000 Subject: hg: jdk8/tl: 8006988: build-infra: Configure fails if 'cl' is in path on linux Message-ID: <20130305211811.50DEA47860@hg.openjdk.java.net> Changeset: a9c8a32d09f9 Author: martin Date: 2013-03-05 13:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a9c8a32d09f9 8006988: build-infra: Configure fails if 'cl' is in path on linux Summary: Respect user CC and CXX environment variables; use cl iff on windows Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 From dean.long at oracle.com Tue Mar 5 15:08:57 2013 From: dean.long at oracle.com (Dean Long) Date: Tue, 05 Mar 2013 15:08:57 -0800 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: <5135A149.3040608@oracle.com> References: <5135A149.3040608@oracle.com> Message-ID: <51367B09.8030008@oracle.com> What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or "map", and have the caller check for NULL? dl On 3/4/2013 11:39 PM, David Holmes wrote: > Looks fine to me - thanks Staffan! > > David > > On 5/03/2013 5:24 PM, Staffan Larsen wrote: >> A very small fix for a warning. >> >> webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ >> >> Thanks, >> /Staffan >> From david.holmes at oracle.com Tue Mar 5 15:23:27 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 06 Mar 2013 09:23:27 +1000 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: <51367B09.8030008@oracle.com> References: <5135A149.3040608@oracle.com> <51367B09.8030008@oracle.com> Message-ID: <51367E6F.8030103@oracle.com> On 6/03/2013 9:08 AM, Dean Long wrote: > What if allocate_init_map() fails to allocate memory? Shouldn't > add_class_share_map_info() follow the pattern of add_map_info(): > return NULL or "map", and have the caller check for NULL? AFAICS apart from one seeming bug, if we can't allocate a new map it does no harm in terms of the code that looks at the map. The bug is: 177 mp = ph->core->class_share_maps; 178 if (mp) { 179 print_debug("can't locate map_info at 0x%lx, trying class share maps\n", 180 addr); where I think 178 should be "if (mp==NULL)". Everything else will just do nothing upon encountering a NULL map. The fix addresses the parfait warning and leaves the code functionally unchanged. So any robustness issues would need to be done via a follow up RFE. David > dl > > On 3/4/2013 11:39 PM, David Holmes wrote: >> Looks fine to me - thanks Staffan! >> >> David >> >> On 5/03/2013 5:24 PM, Staffan Larsen wrote: >>> A very small fix for a warning. >>> >>> webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ >>> >>> Thanks, >>> /Staffan >>> > From lana.steuck at oracle.com Tue Mar 5 16:01:22 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Mar 2013 00:01:22 +0000 Subject: hg: jdk8/tl: 8 new changesets Message-ID: <20130306000123.11A4547868@hg.openjdk.java.net> Changeset: 91d35211e744 Author: katleman Date: 2013-02-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/91d35211e744 Added tag jdk8-b78 for changeset fd1a5574cf68 ! .hgtags Changeset: 85b5b4cc388c Author: katleman Date: 2013-02-28 10:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/85b5b4cc388c Added tag jdk8-b79 for changeset 91d35211e744 ! .hgtags Changeset: ab82853d3365 Author: erikj Date: 2013-02-21 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ab82853d3365 8008451: Make mac builds on 10.8 work on 10.7 Reviewed-by: ohair, ddehaven ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: d3e3d5b06f45 Author: ohair Date: 2013-02-23 10:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d3e3d5b06f45 8004712: build-infra: Move user guide from web pages to repository Summary: Just the initial work, will need more changes. Reviewed-by: tbell ! README ! README-builds.html Changeset: 2778e6576e21 Author: katleman Date: 2013-02-26 13:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2778e6576e21 Merge Changeset: 0adf9c626bb1 Author: katleman Date: 2013-02-28 20:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0adf9c626bb1 Merge Changeset: c022bc48b7ed Author: lana Date: 2013-03-05 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c022bc48b7ed Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in Changeset: c4901c0e0579 Author: lana Date: 2013-03-05 15:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c4901c0e0579 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 From lana.steuck at oracle.com Tue Mar 5 16:01:21 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Mar 2013 00:01:21 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20130306000131.A9C324786A@hg.openjdk.java.net> Changeset: 70d8658d2a30 Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/70d8658d2a30 Added tag jdk8-b78 for changeset 391de4c992d1 ! .hgtags Changeset: b0224010e2f0 Author: katleman Date: 2013-02-28 10:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b0224010e2f0 Added tag jdk8-b79 for changeset 70d8658d2a30 ! .hgtags From lana.steuck at oracle.com Tue Mar 5 16:01:23 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Mar 2013 00:01:23 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20130306000136.6CE1B4786B@hg.openjdk.java.net> Changeset: 58fa065dd5d6 Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/58fa065dd5d6 Added tag jdk8-b78 for changeset 00958c5a7070 ! .hgtags Changeset: 4873a0499bc3 Author: katleman Date: 2013-02-28 10:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4873a0499bc3 Added tag jdk8-b79 for changeset 58fa065dd5d6 ! .hgtags From lana.steuck at oracle.com Tue Mar 5 16:01:21 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Mar 2013 00:01:21 +0000 Subject: hg: jdk8/tl/corba: 3 new changesets Message-ID: <20130306000126.4D88F47869@hg.openjdk.java.net> Changeset: e41fb1aa0329 Author: katleman Date: 2013-02-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e41fb1aa0329 Added tag jdk8-b78 for changeset 27d6368ae8ba ! .hgtags Changeset: 5f3d4a6bdd02 Author: katleman Date: 2013-02-28 10:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5f3d4a6bdd02 Added tag jdk8-b79 for changeset e41fb1aa0329 ! .hgtags Changeset: 67ef27b4e16c Author: lana Date: 2013-03-05 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/67ef27b4e16c Merge From lana.steuck at oracle.com Tue Mar 5 16:01:26 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Mar 2013 00:01:26 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130306000154.C13E14786C@hg.openjdk.java.net> Changeset: 56dfafbb9e1a Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/56dfafbb9e1a Added tag jdk8-b78 for changeset af8417e590f4 ! .hgtags Changeset: a8227c617684 Author: katleman Date: 2013-02-28 10:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a8227c617684 Added tag jdk8-b79 for changeset 56dfafbb9e1a ! .hgtags Changeset: 188a07a0a7a0 Author: lana Date: 2013-03-05 11:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/188a07a0a7a0 Merge From lana.steuck at oracle.com Tue Mar 5 16:01:39 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Mar 2013 00:01:39 +0000 Subject: hg: jdk8/tl/hotspot: 40 new changesets Message-ID: <20130306000357.EF8EF4786D@hg.openjdk.java.net> Changeset: db3359133cdd Author: katleman Date: 2013-02-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/db3359133cdd Added tag jdk8-b78 for changeset d5e12e7d2f71 ! .hgtags Changeset: 57b81d6c3641 Author: amurillo Date: 2013-02-15 13:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/57b81d6c3641 8008286: new hotspot build - hs25-b20 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7adae9244bc8 Author: mgronlun Date: 2013-02-13 11:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7adae9244bc8 8007312: null check signal semaphore in os::signal_notify windows Reviewed-by: dholmes, sla ! src/os/windows/vm/os_windows.cpp Changeset: 2394a89e89f4 Author: rbackman Date: 2013-02-13 09:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2394a89e89f4 8008088: SA can hang the VM Reviewed-by: mgronlun, sla, dholmes ! agent/src/os/bsd/libproc_impl.c ! agent/src/os/bsd/libproc_impl.h ! agent/src/os/bsd/ps_proc.c ! agent/src/os/linux/libproc_impl.c ! agent/src/os/linux/libproc_impl.h ! agent/src/os/linux/ps_proc.c Changeset: 49618582fc5b Author: sla Date: 2013-02-14 13:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/49618582fc5b 8004840: Jstack seems to output unnecessary information in 7u9 Reviewed-by: dholmes, coleenp, sspitsyn, rbackman ! agent/src/share/classes/sun/jvm/hotspot/memory/CMSCollector.java ! agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java Changeset: 3a531d40ad93 Author: acorn Date: 2013-02-14 14:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3a531d40ad93 8007736: VerifyError for static method in interface Reviewed-by: dholmes, acorn Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/classfile/verifier.cpp + test/runtime/8007736/TestStaticIF.java Changeset: e7e9e08147fc Author: mikael Date: 2013-02-14 12:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e7e9e08147fc 8007639: Workaround for ccache in vm.make is incorrect Summary: Fixed makefile logic to correctly special case JRE_RELEASE_VERSION and vm_version.o Reviewed-by: dholmes, erikj ! make/bsd/makefiles/vm.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/vm.make Changeset: 5d5c577296fd Author: sla Date: 2013-02-15 08:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5d5c577296fd 8008102: SA on OS X does not stop the attached process Reviewed-by: dholmes, rbackman ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: f35f1fbab3e1 Author: sla Date: 2013-02-15 10:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f35f1fbab3e1 Merge Changeset: dc1de5e78a85 Author: dsamersoff Date: 2013-02-15 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc1de5e78a85 Merge Changeset: f82bcc429e8c Author: sla Date: 2013-02-18 10:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f82bcc429e8c 8007901: SA: Don't read flag values as constants Reviewed-by: dholmes, mikael ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/runtime/vmStructs.cpp Changeset: b5e3ec9c69fa Author: sla Date: 2013-02-18 12:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5e3ec9c69fa 8007779: os::die() on solaris should generate core file Reviewed-by: dholmes, rbackman ! src/os/solaris/vm/os_solaris.cpp Changeset: 5cd2fac2ae70 Author: hseigel Date: 2013-02-19 08:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5cd2fac2ae70 6749267: Signal handler should save/restore errno Summary: Save errno before processing signal, then restore it. Reviewed-by: acorn, sspitsyn ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp Changeset: 56c364daccc3 Author: emc Date: 2013-02-19 11:36 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/56c364daccc3 8007153: Ensure that MethodParameters API works properly with RedefineClasses Summary: Adds code to HotSpot to properly update MethodParameter attributes' constant pool indexes when redefineClasses is called Reviewed-by: coleenp, sspitsyn ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 1048edb5434a Author: coleenp Date: 2013-02-19 13:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1048edb5434a Merge Changeset: 20fff74158eb Author: sspitsyn Date: 2013-02-20 08:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20fff74158eb Merge Changeset: bbc7936779f9 Author: brutisso Date: 2013-02-14 09:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bbc7936779f9 8006398: Add regression tests for deprectated GCs Reviewed-by: ehelin, jwilhelm, jmasa ! test/TEST.ROOT + test/gc/startup_warnings/TestCMS.java + test/gc/startup_warnings/TestCMSIncrementalMode.java + test/gc/startup_warnings/TestCMSNoIncrementalMode.java + test/gc/startup_warnings/TestDefNewCMS.java + test/gc/startup_warnings/TestG1.java + test/gc/startup_warnings/TestIncGC.java + test/gc/startup_warnings/TestParNewCMS.java + test/gc/startup_warnings/TestParNewSerialOld.java + test/gc/startup_warnings/TestParallelGC.java + test/gc/startup_warnings/TestParallelScavengeSerialOld.java + test/gc/startup_warnings/TestSerialGC.java Changeset: fd7b3770c77e Author: tamao Date: 2013-02-14 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd7b3770c77e 8007764: Wrong initialized value of max_gc_pause_sec for an instance of class AdaptiveSizePolicy Summary: This is a fix of an initialization mistake for class AdaptiveSizePolicy. Reviewed-by: jmasa Contributed-by: Tao Mao ! src/share/vm/memory/collectorPolicy.cpp Changeset: ccc57295818b Author: johnc Date: 2013-02-19 16:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ccc57295818b 8006628: NEED_TEST for JDK-8002870 Summary: Regression test for 8000311. Verifies that PLABStats works with zero parallel GC threads. Reviewed-by: jmasa, johnc Contributed-by: Filipp Zhinkin + test/gc/8000311/Test8000311.java Changeset: b9c5e46bf915 Author: johnc Date: 2013-02-20 12:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b9c5e46bf915 8008188: Add regression test for 8005875 Summary: Add regression test for crash seen in 8005875. Test is run with G1 and PGCT=0 and issues "jcmd Thread.print" against itself. Without the fix for 8005875 the test will crash. Reviewed-by: brutisso + test/gc/TestG1ZeroPGCTJcmdThreadPrint.java Changeset: 5741d3fc502d Author: brutisso Date: 2013-02-21 13:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5741d3fc502d Merge Changeset: c59b7900a2bd Author: roland Date: 2013-02-18 09:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c59b7900a2bd 8007959: Use expensive node logic for more math nodes Summary: use expensive node logic for other more math nodes. Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/subnode.hpp Changeset: 514efad5e81a Author: drchase Date: 2013-02-18 14:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/514efad5e81a 8008180: Several tests in compiler/5091921 need more time to run Summary: Added an explicit timeouts. Reviewed-by: kvn, twisti ! test/compiler/5091921/Test6850611.java ! test/compiler/5091921/Test6890943.java ! test/compiler/5091921/Test6905845.java ! test/compiler/5091921/Test6992759.java Changeset: a2bc322ca273 Author: drchase Date: 2013-02-18 15:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a2bc322ca273 7102300: performance warnings cause results diff failure in Test6890943 Summary: Strip lines matching the performance warning from the output before diff. Reviewed-by: kvn ! test/compiler/5091921/Test6890943.sh Changeset: ad736b4683b4 Author: kvn Date: 2013-02-18 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ad736b4683b4 8004867: VM crashing with assert "share/vm/opto/node.hpp:357 - assert(i < _max) failed: oob" Summary: Added few checks and early bailout from Superword optimization to avoid such cases in a future. Reviewed-by: roland, twisti ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/superword.hpp + test/compiler/8004867/TestIntAtomicCAS.java + test/compiler/8004867/TestIntAtomicOrdered.java + test/compiler/8004867/TestIntAtomicVolatile.java + test/compiler/8004867/TestIntUnsafeCAS.java + test/compiler/8004867/TestIntUnsafeOrdered.java + test/compiler/8004867/TestIntUnsafeVolatile.java Changeset: 2e4b16122164 Author: vlivanov Date: 2013-02-21 06:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2e4b16122164 Merge Changeset: 579f6adb7f51 Author: jprovino Date: 2013-02-05 13:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/579f6adb7f51 8003539: Minimal VM don't react to -Dcom.sun.management and -XX:+ManagementServer Summary: A warning message should be displayed if these options are used with the Minimal VM. Reviewed-by: dholmes, dsamersoff ! src/share/vm/runtime/arguments.cpp Changeset: 9e2da96f9976 Author: bpittore Date: 2013-02-08 16:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9e2da96f9976 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 6c2da81297c5 Author: kvn Date: 2013-02-12 09:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6c2da81297c5 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 84a926fe53d0 Author: bpittore Date: 2013-01-24 13:27 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/84a926fe53d0 8005722: Assert in c1_LIR.hpp incorrect wrt to number of register operands Summary: In LIR_OpVisitState::visit() the receiver operand is processed twice Reviewed-by: roland, vladidan ! src/share/vm/c1/c1_LIR.cpp Changeset: cf9a2071eeac Author: jprovino Date: 2013-02-14 11:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cf9a2071eeac 8006878: Some non-existent GC source files are in the minimalVM exclude list. Summary: cmsPermGen.cpp, psPermGen.cpp have been removed. yieldWorkingGroup.cpp typo is fixed. immutableSpace.cpp was in the list twice. Reviewed-by: dholmes, jmasa ! make/excludeSrc.make ! src/share/vm/utilities/yieldingWorkgroup.cpp Changeset: 1605eef8e11e Author: jprovino Date: 2013-02-14 11:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1605eef8e11e 8003581: UseG1GC is not properly accounted for by INCLUDE_ALTERNATE_GCS Summary: Fix warning messages when selected garbage collectors are excluded from the minimal jvm. Reviewed-by: dholmes, cjplummer ! src/share/vm/runtime/arguments.cpp Changeset: 9c7d0948523f Author: jprovino Date: 2013-02-15 14:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c7d0948523f Merge Changeset: 1ba18258caa4 Author: bpittore Date: 2013-02-15 21:53 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1ba18258caa4 Merge ! src/share/vm/runtime/arguments.cpp Changeset: abf488c22e09 Author: bpittore Date: 2013-02-20 23:29 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/abf488c22e09 Merge Changeset: 2af22eb04623 Author: vladidan Date: 2013-02-21 09:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2af22eb04623 Merge Changeset: ed96c6015470 Author: vladidan Date: 2013-02-21 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed96c6015470 Merge Changeset: 555ec35a2507 Author: amurillo Date: 2013-02-22 10:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/555ec35a2507 Merge Changeset: 6691814929b6 Author: amurillo Date: 2013-02-22 10:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6691814929b6 Added tag hs25-b20 for changeset 555ec35a2507 ! .hgtags Changeset: 5d395eb2626f Author: katleman Date: 2013-02-28 10:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5d395eb2626f Added tag jdk8-b79 for changeset 6691814929b6 ! .hgtags From lana.steuck at oracle.com Tue Mar 5 16:01:53 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 06 Mar 2013 00:01:53 +0000 Subject: hg: jdk8/tl/jdk: 12 new changesets Message-ID: <20130306000514.3EE0B4786E@hg.openjdk.java.net> Changeset: bb97c93e4fd7 Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb97c93e4fd7 Added tag jdk8-b78 for changeset 00b7535d743f ! .hgtags Changeset: 5245b2f1c53d Author: ngthomas Date: 2013-02-21 17:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5245b2f1c53d 8008691: Build failure (NEWBUILD=false) on Mac Reviewed-by: art, anthony ! make/sun/lwawt/FILES_export_macosx.gmk Changeset: c933505d75c2 Author: dcherepanov Date: 2013-02-26 12:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c933505d75c2 Merge Changeset: d967dd39a5ca Author: katleman Date: 2013-02-28 10:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d967dd39a5ca Added tag jdk8-b79 for changeset c933505d75c2 ! .hgtags Changeset: 5a1ea5bbe10a Author: erikj Date: 2013-02-21 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a1ea5bbe10a 8007387: "sed: RE error: illegal byte sequence" when building images on Mac Reviewed-by: tbell ! makefiles/Images.gmk Changeset: a287f6a0d46d Author: erikj Date: 2013-02-21 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a287f6a0d46d 8008451: Make mac builds on 10.8 work on 10.7 Reviewed-by: ohair, ddehaven ! make/common/Defs-macosx.gmk Changeset: 5d27f8702118 Author: erikj Date: 2013-02-21 14:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d27f8702118 8007903: 8005583's changes to make/install-rules.gmk need to made to jdk/make/closed/InstallWrapper.gmk Reviewed-by: tbell, ohair ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-utils.gmk Changeset: f0b5b57014b3 Author: katleman Date: 2013-02-26 13:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0b5b57014b3 Merge Changeset: 8d3dbb724859 Author: katleman Date: 2013-02-27 13:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d3dbb724859 Merge Changeset: b760d5d4b8d3 Author: katleman Date: 2013-02-28 19:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b760d5d4b8d3 8009196: install doesn't define $(AR) as /usr/ccs/bin/ar, results in ar: Command not found Reviewed-by: tbell ! make/common/shared/Defs-utils.gmk Changeset: dfb40f066c6c Author: katleman Date: 2013-02-28 20:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfb40f066c6c Merge Changeset: f960a34f05ce Author: lana Date: 2013-03-05 11:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f960a34f05ce Merge ! makefiles/Images.gmk From yumin.qi at oracle.com Tue Mar 5 16:26:26 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 05 Mar 2013 16:26:26 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <51365109.2070403@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <51365109.2070403@oracle.com> Message-ID: <51368D32.4090106@oracle.com> Hi, Serguei and Staffan Based on reply from Staffan, I made changes and it is in same link: http://cr.openjdk.java.net/~minqi/8003348/ For __APPLE__ def, I changed most of the places where it is used. Still exists '#ifndef' because of lonely code which does not belong to "APPLE". I accidently removed ptrace_attach, now restore it. Thanks Yumin On 3/5/2013 12:09 PM, serguei.spitsyn at oracle.com wrote: > Hi Yumin, > > I'm reviewing it. > Thank you for doing this for the Serviceability team! > > Thanks, > Serguei > > On 3/2/13 11:57 PM, Yumin Qi wrote: >> Hi, all >> >> Please review at the new changes. Include >> 1) use unique_thread_id (which is a 64 bit integer on Macosx) to >> identify thread. Add a function in BsdDebuggerLocal to call the newly >> added function BsdThread.getUniqueThreadId to get this id. Meanwhile, >> move the code of forming threadList in native part to >> BsdDebuggerLocal.java since the thread ids of all java threads can be >> obtained from Threads and coding is much easier and clear. >> >> 2) To have better performance, get all java thread ids, stack >> infos (stack begin, stack end) into one array of long which is >> decoded in native code and used to set thread ids. This save much >> more time first time to fill java thread ids. >> >> 3) remove DarwinVtblAccess.java which added in last version , its >> functionality moved to BsdVtblAccess.java >> >> 4) BugSpotAgent.java no long exists, remove the changes. >> >> 5) remove unsupported platform defs. >> >> http://cr.openjdk.java.net/~minqi/8003348/ >> >> Thanks >> Yumin >> >> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>> Hi, Staffan (and Serguei) >>> >>> Made some clean for code. >>> 1) added mach-o file fat header parsing as you suggested. >>> 2) modified get_real_path as you indicated it could run with >>> jre/bin/java >>> 3) moved output information from CommandProcessor.java to >>> PStack.java for printing out pstack not available for Darwin. >>> 4) code clean, file header update. >>> >>> Please take a look at same location. >>> >>> Thanks >>> Yumin >>> >>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>> Thanks for doing this Yumin! >>>> >>>> I tried to apply you patch and run it, but I can't get SA to open a >>>> core file. You can see the exception I get below. Is there some >>>> kind of setup I need to do? This is against a jvmg build of Hotspot. >>>> >>>> I also noticed that you forgot to update BugSpotAgent.java with the >>>> same changes as in HotspotAgent.java. This makes the jstack tool fail. >>>> >>>> I will look at the changes more closely. >>>> >>>> Thanks, >>>> /Staffan >>>> >>>> >>>> >>>> Opening core file, please wait... >>>> Unable to open core file >>>> /cores/core.79028: >>>> >>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>> "gHotSpotVMTypes" in >>>> remote process) >>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a >>>> HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) >>>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>> hsdb> Input stream closed. >>>> >>>> >>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>> >>>>> Hi, >>>>> >>>>> Please review for the changes for SA to read core file on Mac >>>>> OS X, this is feature is not implemented on previous releases. >>>>> This change made for SA to work on core file on Darwin, but >>>>> still some function not fixed, such as 'pstack'. This is intended >>>>> to integrate into 8. >>>>> >>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>> >>>>> Please take some time since the code change is a little bigger. >>>>> >>>>> Thanks very much >>>>> Yumin >> > From dean.long at oracle.com Tue Mar 5 16:44:56 2013 From: dean.long at oracle.com (Dean Long) Date: Tue, 05 Mar 2013 16:44:56 -0800 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: <51367E6F.8030103@oracle.com> References: <5135A149.3040608@oracle.com> <51367B09.8030008@oracle.com> <51367E6F.8030103@oracle.com> Message-ID: <51369188.8090304@oracle.com> On 3/5/2013 3:23 PM, David Holmes wrote: > On 6/03/2013 9:08 AM, Dean Long wrote: >> What if allocate_init_map() fails to allocate memory? Shouldn't >> add_class_share_map_info() follow the pattern of add_map_info(): >> return NULL or "map", and have the caller check for NULL? > > AFAICS apart from one seeming bug, if we can't allocate a new map it > does no harm in terms of the code that looks at the map. The bug is: > > 177 mp = ph->core->class_share_maps; > 178 if (mp) { > 179 print_debug("can't locate map_info at 0x%lx, trying class > share maps\n", > 180 addr); > > where I think 178 should be "if (mp==NULL)". Everything else will just > do nothing upon encountering a NULL map. > > The fix addresses the parfait warning and leaves the code functionally > unchanged. So any robustness issues would need to be done via a follow > up RFE. > Why not just add "return map" at the end of the function? It seems closer to the intent of the original code, assuming it addresses the parfait warning. dl > David > >> dl >> >> On 3/4/2013 11:39 PM, David Holmes wrote: >>> Looks fine to me - thanks Staffan! >>> >>> David >>> >>> On 5/03/2013 5:24 PM, Staffan Larsen wrote: >>>> A very small fix for a warning. >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ >>>> >>>> Thanks, >>>> /Staffan >>>> >> From david.holmes at oracle.com Tue Mar 5 16:48:56 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 06 Mar 2013 10:48:56 +1000 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: <51369188.8090304@oracle.com> References: <5135A149.3040608@oracle.com> <51367B09.8030008@oracle.com> <51367E6F.8030103@oracle.com> <51369188.8090304@oracle.com> Message-ID: <51369278.5060409@oracle.com> On 6/03/2013 10:44 AM, Dean Long wrote: > On 3/5/2013 3:23 PM, David Holmes wrote: >> On 6/03/2013 9:08 AM, Dean Long wrote: >>> What if allocate_init_map() fails to allocate memory? Shouldn't >>> add_class_share_map_info() follow the pattern of add_map_info(): >>> return NULL or "map", and have the caller check for NULL? >> >> AFAICS apart from one seeming bug, if we can't allocate a new map it >> does no harm in terms of the code that looks at the map. The bug is: >> >> 177 mp = ph->core->class_share_maps; >> 178 if (mp) { >> 179 print_debug("can't locate map_info at 0x%lx, trying class >> share maps\n", >> 180 addr); >> >> where I think 178 should be "if (mp==NULL)". Everything else will just >> do nothing upon encountering a NULL map. >> >> The fix addresses the parfait warning and leaves the code functionally >> unchanged. So any robustness issues would need to be done via a follow >> up RFE. >> > Why not just add "return map" at the end of the function? It seems > closer to the intent of the original code, assuming it > addresses the parfait warning. Nothing expects a return value from that function so what point is there in returning something? I would expect that to simply produce another warning/error about a function return value being ignored. David ----- > > dl > >> David >> >>> dl >>> >>> On 3/4/2013 11:39 PM, David Holmes wrote: >>>> Looks fine to me - thanks Staffan! >>>> >>>> David >>>> >>>> On 5/03/2013 5:24 PM, Staffan Larsen wrote: >>>>> A very small fix for a warning. >>>>> >>>>> webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>> > From dean.long at oracle.com Tue Mar 5 17:37:01 2013 From: dean.long at oracle.com (Dean Long) Date: Tue, 05 Mar 2013 17:37:01 -0800 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: <51369278.5060409@oracle.com> References: <5135A149.3040608@oracle.com> <51367B09.8030008@oracle.com> <51367E6F.8030103@oracle.com> <51369188.8090304@oracle.com> <51369278.5060409@oracle.com> Message-ID: <51369DBD.6030309@oracle.com> On 3/5/2013 4:48 PM, David Holmes wrote: > On 6/03/2013 10:44 AM, Dean Long wrote: >> On 3/5/2013 3:23 PM, David Holmes wrote: >>> On 6/03/2013 9:08 AM, Dean Long wrote: >>>> What if allocate_init_map() fails to allocate memory? Shouldn't >>>> add_class_share_map_info() follow the pattern of add_map_info(): >>>> return NULL or "map", and have the caller check for NULL? >>> >>> AFAICS apart from one seeming bug, if we can't allocate a new map it >>> does no harm in terms of the code that looks at the map. The bug is: >>> >>> 177 mp = ph->core->class_share_maps; >>> 178 if (mp) { >>> 179 print_debug("can't locate map_info at 0x%lx, trying class >>> share maps\n", >>> 180 addr); >>> >>> where I think 178 should be "if (mp==NULL)". Everything else will just >>> do nothing upon encountering a NULL map. >>> >>> The fix addresses the parfait warning and leaves the code functionally >>> unchanged. So any robustness issues would need to be done via a follow >>> up RFE. >>> >> Why not just add "return map" at the end of the function? It seems >> closer to the intent of the original code, assuming it >> addresses the parfait warning. > > Nothing expects a return value from that function so what point is > there in returning something? I would expect that to simply produce > another warning/error about a function return value being ignored. > If it complains about that then wouldn't we need to put (void) in front of all calls to strcat(), for example? Anyway, I'm OK with the current change if Staffan files an RFE for other issue. dl > David > ----- > >> >> dl >> >>> David >>> >>>> dl >>>> >>>> On 3/4/2013 11:39 PM, David Holmes wrote: >>>>> Looks fine to me - thanks Staffan! >>>>> >>>>> David >>>>> >>>>> On 5/03/2013 5:24 PM, Staffan Larsen wrote: >>>>>> A very small fix for a warning. >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>>> >>>> >> From serguei.spitsyn at oracle.com Tue Mar 5 20:36:43 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 05 Mar 2013 20:36:43 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <51330262.2000102@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> Message-ID: <5136C7DB.3010801@oracle.com> Hi Yumin, A partial review below. * agent/src/os/bsd/MacosxDebuggerLocal.m * 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); 153 CHECK_EXCEPTION; 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", 155 "()[J"); 156 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); Is CHECK_EXCEPTION needed after the line #154? The indent is 3 instead of 2: Lines 360-410, 775-788 ||*agent/src/os/bsd/libproc.h* 36 #ifdef __APPLE__ . . . 46 #ifndef bool 47 typedef int bool; 48 #define true 1 49 #define false 0 50 #endif // bool . . . 57 #else // __APPLE__ . . . 76 // This C bool type must be int for compatibility with BSD calls and 77 // it would be a mistake to equivalence it to C++ bool on many platforms 78 typedef int bool; 79 #define true 1 80 #define false 0 81 82 #endif // __APPLE__ The bool, true and false are defined the same way for APPLE and not APPLE. Would it make sense to define it just once? ||*agent/src/os/bsd/ps_core.c* Need a clean up: 869 // thread_command thrcmd; Space is missed after "if", wrong indent at line #873: 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { 873 goto err; Lines 893, 1087 are too long. The function read_core_segments() is big and not well readable. Would it make sense to consider to separate some of its internals as a local functions. For instance, the lines 921-950 are good candidates for it. The indent is 3: 1015 if (exists(filepath)) { 1016 strcpy(rpath, filepath); 1017 return true; 1018 } I did not understand the comments, probably, some words are missing: 1070 mach_header_64 header; // used to check if a file header in segment . . . 1110 // this is the file begining to core file. Not consistent, other fragments before used "goto err;" : 1122 return false; // error . . . 1133 return false; Too many ifdef'ed fragments with __APPLE__ Is it possibler to combine them into bigger chunks or refactor in a different way? For instance, the function Pgrab_core() is not readable. It'd be better to have two separated versions of the function for apple and not apple. Still to review: ||*agent/src/os/bsd/symtab.c* ||*agent/src/os/bsd/symtab.h* ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* ||*agent/src/share/native/sadis.c* ||*make/bsd/makefiles/saproc.make* Thanks, Serguei On 3/2/13 11:57 PM, Yumin Qi wrote: > Hi, all > > Please review at the new changes. Include > 1) use unique_thread_id (which is a 64 bit integer on Macosx) to > identify thread. Add a function in BsdDebuggerLocal to call the newly > added function BsdThread.getUniqueThreadId to get this id. Meanwhile, > move the code of forming threadList in native part to > BsdDebuggerLocal.java since the thread ids of all java threads can be > obtained from Threads and coding is much easier and clear. > > 2) To have better performance, get all java thread ids, stack > infos (stack begin, stack end) into one array of long which is decoded > in native code and used to set thread ids. This save much more time > first time to fill java thread ids. > > 3) remove DarwinVtblAccess.java which added in last version , its > functionality moved to BsdVtblAccess.java > > 4) BugSpotAgent.java no long exists, remove the changes. > > 5) remove unsupported platform defs. > > http://cr.openjdk.java.net/~minqi/8003348/ > > Thanks > Yumin > > On 1/22/2013 10:35 PM, Yumin Qi wrote: >> Hi, Staffan (and Serguei) >> >> Made some clean for code. >> 1) added mach-o file fat header parsing as you suggested. >> 2) modified get_real_path as you indicated it could run with >> jre/bin/java >> 3) moved output information from CommandProcessor.java to >> PStack.java for printing out pstack not available for Darwin. >> 4) code clean, file header update. >> >> Please take a look at same location. >> >> Thanks >> Yumin >> >> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>> Thanks for doing this Yumin! >>> >>> I tried to apply you patch and run it, but I can't get SA to open a >>> core file. You can see the exception I get below. Is there some kind >>> of setup I need to do? This is against a jvmg build of Hotspot. >>> >>> I also noticed that you forgot to update BugSpotAgent.java with the >>> same changes as in HotspotAgent.java. This makes the jstack tool fail. >>> >>> I will look at the changes more closely. >>> >>> Thanks, >>> /Staffan >>> >>> >>> >>> Opening core file, please wait... >>> Unable to open core file >>> /cores/core.79028: >>> >>> Doesn't appear to be a HotSpot VM (could not find symbol >>> "gHotSpotVMTypes" in >>> remote process) >>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a >>> HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) >>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>> hsdb> Input stream closed. >>> >>> >>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>> >>>> Hi, >>>> >>>> Please review for the changes for SA to read core file on Mac >>>> OS X, this is feature is not implemented on previous releases. >>>> This change made for SA to work on core file on Darwin, but >>>> still some function not fixed, such as 'pstack'. This is intended >>>> to integrate into 8. >>>> >>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>> >>>> Please take some time since the code change is a little bigger. >>>> >>>> Thanks very much >>>> Yumin > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130305/a934d0e0/attachment-0001.html From david.holmes at oracle.com Tue Mar 5 23:36:22 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 06 Mar 2013 07:36:22 +0000 Subject: hg: jdk8/tl: 8009529: Fix for 8006988 missed closed configure changes Message-ID: <20130306073622.B6BFE47882@hg.openjdk.java.net> Changeset: 929e2461818b Author: dholmes Date: 2013-03-05 22:45 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/rev/929e2461818b 8009529: Fix for 8006988 missed closed configure changes Reviewed-by: mr ! common/autoconf/generated-configure.sh From staffan.larsen at oracle.com Wed Mar 6 02:08:39 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 06 Mar 2013 10:08:39 +0000 Subject: hg: jdk8/tl/jdk: 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Message-ID: <20130306100905.09CEC4788F@hg.openjdk.java.net> Changeset: 34372bb9115d Author: sla Date: 2013-03-05 19:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34372bb9115d 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Reviewed-by: alanb ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof_init.c ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c From staffan.larsen at oracle.com Wed Mar 6 07:24:00 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 6 Mar 2013 16:24:00 +0100 Subject: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c In-Reply-To: <51367E6F.8030103@oracle.com> References: <5135A149.3040608@oracle.com> <51367B09.8030008@oracle.com> <51367E6F.8030103@oracle.com> Message-ID: <29AF58D4-F19B-4FFD-AE44-A2D3CCD921FB@oracle.com> On 6 mar 2013, at 00:23, David Holmes wrote: > On 6/03/2013 9:08 AM, Dean Long wrote: >> What if allocate_init_map() fails to allocate memory? Shouldn't >> add_class_share_map_info() follow the pattern of add_map_info(): >> return NULL or "map", and have the caller check for NULL? > > AFAICS apart from one seeming bug, if we can't allocate a new map it does no harm in terms of the code that looks at the map. The bug is: > > 177 mp = ph->core->class_share_maps; > 178 if (mp) { > 179 print_debug("can't locate map_info at 0x%lx, trying class share maps\n", > 180 addr); > > where I think 178 should be "if (mp==NULL)". I think this code is correct, although it took me a while to realize. If it can find a class share map, it reports that it will start looking at it. /Staffan > Everything else will just do nothing upon encountering a NULL map. > > The fix addresses the parfait warning and leaves the code functionally unchanged. So any robustness issues would need to be done via a follow up RFE. > > David > >> dl >> >> On 3/4/2013 11:39 PM, David Holmes wrote: >>> Looks fine to me - thanks Staffan! >>> >>> David >>> >>> On 5/03/2013 5:24 PM, Staffan Larsen wrote: >>>> A very small fix for a warning. >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ >>>> >>>> Thanks, >>>> /Staffan >>>> >> From maurizio.cimadamore at oracle.com Wed Mar 6 07:34:30 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 06 Mar 2013 15:34:30 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130306153443.7FD8C4789E@hg.openjdk.java.net> Changeset: d0178bd8125c Author: mcimadamore Date: 2013-03-06 15:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0178bd8125c 8009299: Javac crashes when compiling method reference to static interface method Summary: Assertion in Check.checMethod is too strict Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java + test/tools/javac/lambda/MethodReference66.java Changeset: 8a78243291ef Author: mcimadamore Date: 2013-03-06 15:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8a78243291ef 8009459: Wrong behavior of diamond finder with source level 7 Summary: Diamond finder doesn't take into account different inference behaviors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/diamond/6939780/T6939780.java + test/tools/javac/generics/diamond/6939780/T6939780_7.out + test/tools/javac/generics/diamond/6939780/T6939780_8.out - test/tools/javac/generics/diamond/T6939780.java - test/tools/javac/generics/diamond/T6939780.out Changeset: c98b3e96c726 Author: mcimadamore Date: 2013-03-06 15:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c98b3e96c726 8009391: Synthetic name of serializable lambda methods should not contain negative numbers Summary: Use hex representation of method signature hashcode to avoid negative numbers Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java From jesper.wilhelmsson at oracle.com Wed Mar 6 08:04:48 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 06 Mar 2013 17:04:48 +0100 Subject: RFR: JDK-8008790 - Promotion failed tracing event for all GCs In-Reply-To: <512CDA9C.3050607@oracle.com> References: <512B5EB7.4050107@oracle.com> <512CDA9C.3050607@oracle.com> Message-ID: <51376920.3030704@oracle.com> Hi, Additional feedback resulted in a new webrev: http://cr.openjdk.java.net/~jwilhelm/8008790/webrev.hsx24.3/ Thanks, /Jesper On 26/2/13 4:54 PM, Jesper Wilhelmsson wrote: > Hi, > > After some internal feedback a new version of the webrev is available at: > > http://cr.openjdk.java.net/~jwilhelm/8008790/webrev.hsx24.2/ > > The biggest change is that the promotion failed event now is sent once per > thread instead of merging the info into one event. > > Thanks, > /Jesper > > > On 25/2/13 1:53 PM, Jesper Wilhelmsson wrote: >> Hi, >> >> I'm looking for a couple of reviews for the promotion failed tracing event, now >> implemented for ParNew and Serial GC. >> >> I have replaced the existing counters and booleans with a PromotionFailedInfo >> object and uses that throughout, so now promotion failed reporting (through the >> tracing framework) looks the same and reports the same data for all young >> collectors. >> >> I have added two new fields to the promotion failed event: firstSize as reported >> by ParNew logging, and smallestSize which is the smallest object size that >> failed to promote. >> >> Webrew: http://cr.openjdk.java.net/~jwilhelm/8008790 >> >> Testing: Passes JPRT and the existing promotion failed tests with all collectors. >> >> Thanks, >> /Jesper From mike.duigou at oracle.com Wed Mar 6 08:47:34 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 06 Mar 2013 16:47:34 +0000 Subject: hg: jdk8/tl: 8009162: root repo "make test" target should run against image Message-ID: <20130306164734.C6784478A4@hg.openjdk.java.net> Changeset: b35d986ff276 Author: mduigou Date: 2013-03-06 08:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b35d986ff276 8009162: root repo "make test" target should run against image Reviewed-by: alanb, martin, erikj ! common/makefiles/Main.gmk From yumin.qi at oracle.com Wed Mar 6 08:54:15 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Wed, 06 Mar 2013 08:54:15 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <5136C7DB.3010801@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> Message-ID: <513774B7.8090900@oracle.com> Thanks, Serguei Will take care what you have indicated but refactoring code for ps_core.c (Pgrab_core). Maybe in future, code cleaning should include this, the better choice I think is regroup code to detail in specific platform, such as with new file ps_core_darwin.c etc but not now. /Yumin On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: > > Hi Yumin, > > > A partial review below. > > * > agent/src/os/bsd/MacosxDebuggerLocal.m > * > > 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); > 153 CHECK_EXCEPTION; > 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", > 155 "()[J"); > 156 > 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); > > Is CHECK_EXCEPTION needed after the line #154? > > The indent is 3 instead of 2: > Lines 360-410, 775-788 > > ||*agent/src/os/bsd/libproc.h* > 36 #ifdef __APPLE__ > . . . > 46 #ifndef bool > 47 typedef int bool; > 48 #define true 1 > 49 #define false 0 > 50 #endif // bool > . . . > 57 #else // __APPLE__ > . . . > 76 // This C bool type must be int for compatibility with BSD calls and > 77 // it would be a mistake to equivalence it to C++ bool on many platforms > 78 typedef int bool; > 79 #define true 1 > 80 #define false 0 > 81 > 82 #endif // __APPLE__ > The bool, true and false are defined the same way for APPLE and not APPLE. > Would it make sense to define it just once? > > ||*agent/src/os/bsd/ps_core.c* > > Need a clean up: > 869 // thread_command thrcmd; > > Space is missed after "if", wrong indent at line #873: > 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { > 873 goto err; > Lines 893, 1087 are too long. > > The function read_core_segments() is big and not well readable. > Would it make sense to consider to separate some of its internals as a > local functions. > For instance, the lines 921-950 are good candidates for it. > > The indent is 3: > 1015 if (exists(filepath)) { > 1016 strcpy(rpath, filepath); > 1017 return true; > 1018 } > I did not understand the comments, probably, some words are missing: > 1070 mach_header_64 header; // used to check if a file header in segment > . . . > 1110 // this is the file begining to core file. > > > Not consistent, other fragments before used "goto err;" : > 1122 return false; // error > . . . > 1133 return false; > > Too many ifdef'ed fragments with __APPLE__ > Is it possibler to combine them into bigger chunks or refactor in a > different way? > For instance, the function Pgrab_core() is not readable. > It'd be better to have two separated versions of the function for > apple and not apple. > > > Still to review: > > ||*agent/src/os/bsd/symtab.c* > ||*agent/src/os/bsd/symtab.h* > ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* > ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* > ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* > *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* > ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* > ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* > ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* > ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* > ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* > ||*agent/src/share/native/sadis.c* > ||*make/bsd/makefiles/saproc.make* > > > Thanks, > Serguei > > > On 3/2/13 11:57 PM, Yumin Qi wrote: >> Hi, all >> >> Please review at the new changes. Include >> 1) use unique_thread_id (which is a 64 bit integer on Macosx) to >> identify thread. Add a function in BsdDebuggerLocal to call the newly >> added function BsdThread.getUniqueThreadId to get this id. Meanwhile, >> move the code of forming threadList in native part to >> BsdDebuggerLocal.java since the thread ids of all java threads can be >> obtained from Threads and coding is much easier and clear. >> >> 2) To have better performance, get all java thread ids, stack >> infos (stack begin, stack end) into one array of long which is >> decoded in native code and used to set thread ids. This save much >> more time first time to fill java thread ids. >> >> 3) remove DarwinVtblAccess.java which added in last version , its >> functionality moved to BsdVtblAccess.java >> >> 4) BugSpotAgent.java no long exists, remove the changes. >> >> 5) remove unsupported platform defs. >> >> http://cr.openjdk.java.net/~minqi/8003348/ >> >> Thanks >> Yumin >> >> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>> Hi, Staffan (and Serguei) >>> >>> Made some clean for code. >>> 1) added mach-o file fat header parsing as you suggested. >>> 2) modified get_real_path as you indicated it could run with >>> jre/bin/java >>> 3) moved output information from CommandProcessor.java to >>> PStack.java for printing out pstack not available for Darwin. >>> 4) code clean, file header update. >>> >>> Please take a look at same location. >>> >>> Thanks >>> Yumin >>> >>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>> Thanks for doing this Yumin! >>>> >>>> I tried to apply you patch and run it, but I can't get SA to open a >>>> core file. You can see the exception I get below. Is there some >>>> kind of setup I need to do? This is against a jvmg build of Hotspot. >>>> >>>> I also noticed that you forgot to update BugSpotAgent.java with the >>>> same changes as in HotspotAgent.java. This makes the jstack tool fail. >>>> >>>> I will look at the changes more closely. >>>> >>>> Thanks, >>>> /Staffan >>>> >>>> >>>> >>>> Opening core file, please wait... >>>> Unable to open core file >>>> /cores/core.79028: >>>> >>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>> "gHotSpotVMTypes" in >>>> remote process) >>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a >>>> HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) >>>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>> hsdb> Input stream closed. >>>> >>>> >>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>> >>>>> Hi, >>>>> >>>>> Please review for the changes for SA to read core file on Mac >>>>> OS X, this is feature is not implemented on previous releases. >>>>> This change made for SA to work on core file on Darwin, but >>>>> still some function not fixed, such as 'pstack'. This is intended >>>>> to integrate into 8. >>>>> >>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>> >>>>> Please take some time since the code change is a little bigger. >>>>> >>>>> Thanks very much >>>>> Yumin >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130306/1b08789e/attachment-0001.html From joel.franck at oracle.com Wed Mar 6 09:40:50 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Wed, 06 Mar 2013 17:40:50 +0000 Subject: hg: jdk8/tl/jdk: 8007808: Missing method: Executable.getAnnotatedReturnType() Message-ID: <20130306174104.E4845478A9@hg.openjdk.java.net> Changeset: 38e1821c4472 Author: jfranck Date: 2013-03-06 18:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38e1821c4472 8007808: Missing method: Executable.getAnnotatedReturnType() Reviewed-by: darcy, forax ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java From jesper.wilhelmsson at oracle.com Wed Mar 6 09:44:17 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 06 Mar 2013 18:44:17 +0100 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <5130E68A.4040806@oracle.com> References: <5130E68A.4040806@oracle.com> Message-ID: <51378071.2060107@oracle.com> Looks good! Since we want to implement this event for G1 as well, maybe we should remove the "CMS" from the event name and path? Thanks, /Jesper On 1/3/13 6:34 PM, Kevin Walls wrote: > Hi, > > I'd like some reviews on this CMS Concurrent Mode Failure event: > > http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ > > The event doesn't actually carry any new information, but it is a warning we > need to capture. > > This is against hsx24, I'll prepare the same, or reviewed, changes against very > latest hotspot also. > > Thanks > Kevin > From erik.helin at oracle.com Wed Mar 6 10:01:18 2013 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 06 Mar 2013 19:01:18 +0100 Subject: RFR: JDK-8008790 - Promotion failed tracing event for all GCs In-Reply-To: <51376920.3030704@oracle.com> References: <512B5EB7.4050107@oracle.com> <512CDA9C.3050607@oracle.com> <51376920.3030704@oracle.com> Message-ID: <5137846E.30904@oracle.com> Hi Jesper, looks good. Thanks, Erik On 03/06/2013 05:04 PM, Jesper Wilhelmsson wrote: > Hi, > > Additional feedback resulted in a new webrev: > > http://cr.openjdk.java.net/~jwilhelm/8008790/webrev.hsx24.3/ > > Thanks, > /Jesper > > > On 26/2/13 4:54 PM, Jesper Wilhelmsson wrote: >> Hi, >> >> After some internal feedback a new version of the webrev is available at: >> >> http://cr.openjdk.java.net/~jwilhelm/8008790/webrev.hsx24.2/ >> >> The biggest change is that the promotion failed event now is sent once >> per >> thread instead of merging the info into one event. >> >> Thanks, >> /Jesper >> >> >> On 25/2/13 1:53 PM, Jesper Wilhelmsson wrote: >>> Hi, >>> >>> I'm looking for a couple of reviews for the promotion failed tracing >>> event, now >>> implemented for ParNew and Serial GC. >>> >>> I have replaced the existing counters and booleans with a >>> PromotionFailedInfo >>> object and uses that throughout, so now promotion failed reporting >>> (through the >>> tracing framework) looks the same and reports the same data for all >>> young >>> collectors. >>> >>> I have added two new fields to the promotion failed event: firstSize >>> as reported >>> by ParNew logging, and smallestSize which is the smallest object size >>> that >>> failed to promote. >>> >>> Webrew: http://cr.openjdk.java.net/~jwilhelm/8008790 >>> >>> Testing: Passes JPRT and the existing promotion failed tests with all >>> collectors. >>> >>> Thanks, >>> /Jesper From erik.helin at oracle.com Wed Mar 6 10:19:09 2013 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 06 Mar 2013 19:19:09 +0100 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <5130E68A.4040806@oracle.com> References: <5130E68A.4040806@oracle.com> Message-ID: <5137889D.2080200@oracle.com> Hi Kevin, I think that there _might_ be a bug in CMS which was present even before you added the event tracing. If you look in aquire_control_and_collect, you will see that "should_compact" can be set to false by decide_foreground_collection_type. If this is the case, then we will end up in do_mark_sweep_work. The problem is that you have already reported, and CMS has already printed, that a concurrent mode failure has occurred in acquire_control_and_collect. Then, when you enter do_mark_sweep_work, you will once again report, and CMS will again print, that concurrent mode failure has happened. I am not 100% sure that I am right, by I believe that this can happen. What do you think? Thanks, Erik On 03/01/2013 06:34 PM, Kevin Walls wrote: > Hi, > > I'd like some reviews on this CMS Concurrent Mode Failure event: > > http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ > > The event doesn't actually carry any new information, but it is a > warning we need to capture. > > This is against hsx24, I'll prepare the same, or reviewed, changes > against very latest hotspot also. > > Thanks > Kevin > From staffan.larsen at oracle.com Wed Mar 6 11:36:00 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 6 Mar 2013 20:36:00 +0100 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <513646F9.3060601@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <513646F9.3060601@oracle.com> Message-ID: Nice catch, Serguei! Unfortunately I have already pushed my change, but I filed "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop" to track this new problem and I am working on a fix. Thanks, /Staffan On 5 mar 2013, at 20:26, serguei.spitsyn at oracle.com wrote: > Hi Staffan, > > Thank you for this discovery! > It looks good, but I have a couple of comments. > > It seems, there is one more problem in this code: > 68 /* check for NULL path */ > 69 if (p == pathname) { > 70 continue; <== Endless loop if we hit this line > 71 } > > Do we need to do 'pathname++' before continuing at the line #70? > It is going to be endless loop in cases there is a PATH_SEPARATOR > at the beginning of paths or two PATH_SEPARATOR's in a row. > These would be incorrect path lists but the code above is targeting exactly such cases. > > Also, the argument name "pathname" in the original code is confusing. > Should we rename it to "pathnames"? > > Thanks, > Serguei > > > On 3/4/13 10:56 AM, Staffan Larsen wrote: >> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: >> >> 57 static void dll_build_name(char* buffer, size_t buflen, >> 58 const char* pname, const char* fname) { >> 59 // Based on os_solaris.cpp >> 60 >> 61 char *path_sep = PATH_SEPARATOR; >> 62 char *pathname = (char *)pname; >> 63 while (strlen(pathname) > 0) { >> 64 char *p = strchr(pathname, *path_sep); >> 65 if (p == NULL) { >> 66 p = pathname + strlen(pathname); >> 67 } >> 68 /* check for NULL path */ >> 69 if (p == pathname) { >> 70 continue; >> 71 } >> 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), >> 73 pathname, fname); >> 74 >> 75 if (access(buffer, F_OK) == 0) { >> 76 break; >> 77 } >> 78 pathname = p + 1; >> 79 *buffer = '\0'; >> 80 } >> >> If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). >> >> The same code show up in both the solaris code and the windows code as well as hprof. >> >> bug: http://bugs.sun.com/view_bug.do?bug_id=8009397 >> webrev: http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130306/e7015e12/attachment.html From serguei.spitsyn at oracle.com Wed Mar 6 11:48:24 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 06 Mar 2013 11:48:24 -0800 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <513646F9.3060601@oracle.com> Message-ID: <51379D88.6080807@oracle.com> Staffan, Thank you for the confirmation and taking care about this issue! Thanks, Serguei On 3/6/13 11:36 AM, Staffan Larsen wrote: > Nice catch, Serguei! > > Unfortunately I have already pushed my change, but I filed > "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite > loop" to track this new problem and I am working on a fix. > > Thanks, > /Staffan > > > On 5 mar 2013, at 20:26, serguei.spitsyn at oracle.com > wrote: > >> Hi Staffan, >> >> Thank you for this discovery! >> It looks good, but I have a couple of comments. >> >> It seems, there is one more problem in this code: >> 68 /* check for NULL path */ >> 69 if (p == pathname) { >> 70 continue;<== Endless loop if we hit this line >> 71 } >> >> Do we need to do 'pathname++' before continuing at the line #70? >> It is going to be endless loop in cases there is a PATH_SEPARATOR >> at the beginning of paths or two PATH_SEPARATOR's in a row. >> These would be incorrect path lists but the code above is targeting >> exactly such cases. >> >> Also, the argument name "pathname" in the original code is confusing. >> Should we rename it to "pathnames"? >> >> Thanks, >> Serguei >> >> >> On 3/4/13 10:56 AM, Staffan Larsen wrote: >>> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: >>> >>> 57 static void dll_build_name(char* buffer, size_t buflen, >>> 58 const char* pname, const char* fname) { >>> 59 // Based on os_solaris.cpp >>> 60 >>> 61 char *path_sep = PATH_SEPARATOR; >>> 62 char *pathname = (char *)pname; >>> 63 while (strlen(pathname) > 0) { >>> 64 char *p = strchr(pathname, *path_sep); >>> 65 if (p == NULL) { >>> 66 p = pathname + strlen(pathname); >>> 67 } >>> 68 /* check for NULL path */ >>> 69 if (p == pathname) { >>> 70 continue; >>> 71 } >>> 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), >>> 73 pathname, fname); >>> 74 >>> 75 if (access(buffer, F_OK) == 0) { >>> 76 break; >>> 77 } >>> 78 pathname = p + 1; >>> 79 *buffer = '\0'; >>> 80 } >>> >>> If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). >>> >>> The same code show up in both the solaris code and the windows code as well as hprof. >>> >>> bug:http://bugs.sun.com/view_bug.do?bug_id=8009397 >>> webrev:http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >>> >>> Thanks, >>> /Staffan >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130306/29686939/attachment-0001.html From zhengyu.gu at oracle.com Wed Mar 6 12:05:26 2013 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Wed, 06 Mar 2013 20:05:26 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7107135: Stack guard pages are no more protected after loading a shared library with executable stack Message-ID: <20130306200533.0FE8D478AE@hg.openjdk.java.net> Changeset: 9058789475af Author: iklam Date: 2013-03-05 13:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9058789475af 7107135: Stack guard pages are no more protected after loading a shared library with executable stack Summary: Detect the execstack attribute of the loaded library and attempt to fix the stack guard using Safepoint op. Reviewed-by: dholmes, zgu Contributed-by: ioi.lam at oracle.com ! src/os/linux/vm/globals_linux.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vm_operations.hpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp + test/runtime/7107135/Test.java + test/runtime/7107135/Test7107135.sh + test/runtime/7107135/TestMT.java + test/runtime/7107135/test.c From yunda.mly at taobao.com Wed Mar 6 16:10:35 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 7 Mar 2013 00:10:35 +0000 Subject: [PATCH] A small fix on "scanoops" command in CLHSDB In-Reply-To: References: <51259564.2070501@oracle.com> <65F834EF-10EF-4768-92F4-12D0984A2C4A@oracle.com> Message-ID: Staffan, Thanks for doing this, too? Regards, Yunda From: Staffan Larsen [mailto:staffan.larsen at oracle.com] Sent: Tuesday, March 05, 2013 9:21 PM To: ??(Yunda) Cc: Krystal Mo; serviceability-dev at openjdk.java.net Subject: Re: [PATCH] A small fix on "scanoops" command in CLHSDB I have created issue JDK-8009457 to track this. Still waiting for a review, though. Thanks, /Staffan On 22 feb 2013, at 04:32, ?? > wrote: Staffan & Kris, Thank both of you for reviewing this. Hope you two could be official Reviewer soon ? Regards, Yunda ???: Staffan Larsen [mailto:staffan.larsen at oracle.com] ????: 2013?2?21? 18:21 ???: Krystal Mo ??: ??; serviceability-dev at openjdk.java.net ??: Re: [PATCH] A small fix on "scanoops" command in CLHSDB I think this looks good, too. I'm not an official Reviewer, either. Thanks, /Staffan On 21 feb 2013, at 04:32, Krystal Mo > wrote: Hi Yunda, This patch looks reasonable to me. But you'll need an official Reviewer to review this. - Kris On 2013/2/19 1:24, ?? wrote: Hi all, When I use ?scanoops? command in CLHSDB, I find that if the type doesn?t exist, the output will be all the oops in the scope [start, end]. (see below) I think that?s irrational because all the oops between 0x00000000ee2000a0 and 0x00000000ee200550 are of type ?java/lang/Class? and there?s no type ?java/lang/Class2? or ?com/taobao/Test? at all! hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 0x00000000ee2000a0 java/lang/Class 0x00000000ee200118 java/lang/Class 0x00000000ee200190 java/lang/Class 0x00000000ee200208 java/lang/Class 0x00000000ee200280 java/lang/Class 0x00000000ee2002f8 java/lang/Class 0x00000000ee200370 java/lang/Class 0x00000000ee2003e8 java/lang/Class 0x00000000ee200460 java/lang/Class 0x00000000ee2004d8 java/lang/Class hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 java/lang/Class2 0x00000000ee2000a0 java/lang/Class 0x00000000ee200118 java/lang/Class 0x00000000ee200190 java/lang/Class 0x00000000ee200208 java/lang/Class 0x00000000ee200280 java/lang/Class 0x00000000ee2002f8 java/lang/Class 0x00000000ee200370 java/lang/Class 0x00000000ee2003e8 java/lang/Class 0x00000000ee200460 java/lang/Class 0x00000000ee2004d8 java/lang/Class hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 com/taobao/Test 0x00000000ee2000a0 java/lang/Class 0x00000000ee200118 java/lang/Class 0x00000000ee200190 java/lang/Class 0x00000000ee200208 java/lang/Class 0x00000000ee200280 java/lang/Class 0x00000000ee2002f8 java/lang/Class 0x00000000ee200370 java/lang/Class 0x00000000ee2003e8 java/lang/Class 0x00000000ee200460 java/lang/Class 0x00000000ee2004d8 java/lang/Class I know the reason is that the usage of scanoops is ?scanoops start end [ type ]? and ?type? is optional. When you don?t input the ?type?, the output will be all the oops in the scope [start, end]. But I think the two situations are different and CLHSDB should give right prompt. So I made a small fix: diff -r b5e3ec9c69fa agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java --- a/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Mon Feb 18 12:49:53 2013 +0100 +++ b/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Tue Feb 19 16:43:45 2013 +0800 @@ -1132,6 +1132,10 @@ Klass klass = null; if (t.countTokens() == 1) { klass = SystemDictionaryHelper.findInstanceKlass(t.nextToken()); + if(klass == null) { + out.println("No such type."); + return; + } } while (base != null && base.lessThan(end)) { long step = stride; And the effect will be: hsdb> scanoops 0x0000000758600000 0x000000075860ffff com/taobao/Test No such type. Regards, Yunda [X] This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)????????????????????????????????????????????????????? ????????????????? [X] This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/42f38c6a/attachment-0001.html From yunda.mly at taobao.com Wed Mar 6 16:09:59 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 7 Mar 2013 00:09:59 +0000 Subject: [PATCH] typeToVtbl of BasicTypeDataBase should not be static In-Reply-To: References: Message-ID: Staffan, Thanks! I think the issue here is quite clear, since the role of "typeToVtbl " filed of BasicTypeDataBase is similar to "typeToVtblMap" field of BasicVtblAccess and the latter is not static. Regards, Yunda From: Staffan Larsen [mailto:staffan.larsen at oracle.com] Sent: Tuesday, March 05, 2013 9:18 PM To: ??(Yunda) Cc: serviceability-dev at openjdk.java.net Subject: Re: [PATCH] typeToVtbl of BasicTypeDataBase should not be static Yunda, Thanks for the patch. I have created issue JDK-8009456 to track this and can sponsor the fix as soon as we get a Review of the fix. /Staffan On 28 feb 2013, at 04:59, ??(Yunda) > wrote: Hi all, I found that when I detached a java process and attached another java process, the ?universe? command of CLHSDB didn?t show the right information. But when I restarted CLHSDB and attached to the same process the problem disappeared: hsdb> attach 29211 Attaching to process 29211, please wait... hsdb> universe Heap Parameters: ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289aa8,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> hsdb> detach hsdb> attach 29887 Attaching to process 29887, please wait... hsdb> universe Heap Parameters: unknown subtype of CollectedHeap @ 0x0000000000d56fb0 (0x00000000ca600000,0x0000000100000000) hsdb> quit [~]$ java -cp .:$JAVA_HOME/lib/sa-jdi.jar sun.jvm.hotspot.CLHSDB hsdb> attach 29887 Attaching to process 29887, please wait... hsdb> universe Heap Parameters: ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289a68,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> I think it?s caused by the wrong definition of ?typeToVtbl? field of BasicTypeDataBase. Since typeToVtbl should be recreated every time SA attaches to a new process, it should not be static. So I made a small patch fo fix it: diff -r ec2eddfed950 agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java --- a/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Tue Feb 26 14:09:52 2013 +0100 +++ b/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Thu Feb 28 11:57:55 2013 +0800 @@ -150,7 +150,7 @@ return VM.getVM().getOopSize(); } - static HashMap typeToVtbl = new HashMap(); + private HashMap typeToVtbl = new HashMap(); private Address vtblForType(Type type) { Address vtblAddr = (Address)typeToVtbl.get(type); After applying this patch, the problem I mentioned above disappeared. Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/f24173e2/attachment-0001.html From martinrb at google.com Wed Mar 6 18:55:09 2013 From: martinrb at google.com (martinrb at google.com) Date: Thu, 07 Mar 2013 02:55:09 +0000 Subject: hg: jdk8/tl/jdk: 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so Message-ID: <20130307025522.AD40C47D95@hg.openjdk.java.net> Changeset: 14e49a70729a Author: martin Date: 2013-03-06 17:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14e49a70729a 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so Summary: Define FILES_m to force use of linker script Reviewed-by: sherman, alanb, ohair ! make/java/zip/Makefile ! src/share/native/java/util/zip/Inflater.c From weijun.wang at oracle.com Wed Mar 6 19:39:22 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 07 Mar 2013 03:39:22 +0000 Subject: hg: jdk8/tl/jdk: 8009604: old make images failed: JarBASE64Encoder class not found Message-ID: <20130307034007.ECBA047D9B@hg.openjdk.java.net> Changeset: cf54f6be3e9e Author: weijun Date: 2013-03-07 11:32 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf54f6be3e9e 8009604: old make images failed: JarBASE64Encoder class not found Reviewed-by: xuelei, wetmore ! make/common/Release.gmk From staffan.larsen at oracle.com Thu Mar 7 00:10:07 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 7 Mar 2013 09:10:07 +0100 Subject: RFR(S): 8006637 Failure to filter out native frame events on Solaris In-Reply-To: References: Message-ID: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> Adding core-libs-dev and re-asking for a review. Thanks, /Staffan On 27 feb 2013, at 15:59, Staffan Larsen wrote: > Please review the following test fix. > > webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 > > The problem is that the test assumes that no other threads call String.intern() while the tests is running. This is normally ok, but when running with JFR there are other threads calling String.intern() in the background and the test fails. The solution is to add a thread filter to the method exit requests so that only calls to String.inter() in the main thread are reported. > > Thanks, > /Staffan From staffan.larsen at oracle.com Thu Mar 7 00:27:11 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 7 Mar 2013 09:27:11 +0100 Subject: RFR(S): 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order with lock MethodData_lock/19 -- possible deadlock In-Reply-To: <21B2FFE7-AC80-4FE8-9704-ECDC33D5F889@oracle.com> References: <21B2FFE7-AC80-4FE8-9704-ECDC33D5F889@oracle.com> Message-ID: <9AE653E2-F251-4B8B-A6AD-965A25F2FF04@oracle.com> Can I have a Review for this small change, please. Thanks, /Staffan On 18 feb 2013, at 11:15, Staffan Larsen wrote: > Please review this change for hs24 / jdku. > > webrev: http://cr.openjdk.java.net/~sla/8005572/webrev.00/ > > The problem lies with the order of the newly introduced JfrBuffer_lock and JfrStream_lock compared to the MethodData_lock. There are cases where we need to take the Jfr* locks while holding the MethodData_lock. Ths solution is simply to increase the lock order for the Jfr* locks. This change has baked for a while in internal testing and showed no regressions. > > Thanks, > /Staffan From serguei.spitsyn at oracle.com Thu Mar 7 02:05:00 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 07 Mar 2013 02:05:00 -0800 Subject: RFR(S): 8006637 Failure to filter out native frame events on Solaris In-Reply-To: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> References: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> Message-ID: <5138664C.8060907@oracle.com> Looks good. Thanks, Serguei On 3/7/13 12:10 AM, Staffan Larsen wrote: > Adding core-libs-dev and re-asking for a review. > > Thanks, > /Staffan > > On 27 feb 2013, at 15:59, Staffan Larsen wrote: > >> Please review the following test fix. >> >> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 >> >> The problem is that the test assumes that no other threads call String.intern() while the tests is running. This is normally ok, but when running with JFR there are other threads calling String.intern() in the background and the test fails. The solution is to add a thread filter to the method exit requests so that only calls to String.inter() in the main thread are reported. >> >> Thanks, >> /Staffan From vicente.romero at oracle.com Thu Mar 7 02:08:16 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 07 Mar 2013 10:08:16 +0000 Subject: hg: jdk8/tl/langtools: 8009138: javac, equals-hashCode warning tuning Message-ID: <20130307100821.D563B47DD3@hg.openjdk.java.net> Changeset: 3806171b52d8 Author: vromero Date: 2013-03-07 10:04 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3806171b52d8 8009138: javac, equals-hashCode warning tuning Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/6563143/EqualsHashCodeWarningTest.java + test/tools/javac/6563143/EqualsHashCodeWarningTest.out - test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.java - test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.out From vicente.romero at oracle.com Thu Mar 7 02:14:15 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 07 Mar 2013 10:14:15 +0000 Subject: hg: jdk8/tl/langtools: 8009170: Regression: javac generates redundant bytecode in assignop involving arrays Message-ID: <20130307101418.ED30447DD6@hg.openjdk.java.net> Changeset: 823fb9229724 Author: vromero Date: 2013-03-07 10:12 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/823fb9229724 8009170: Regression: javac generates redundant bytecode in assignop involving arrays Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! test/tools/javac/7167125/DiffResultAfterSameOperationInnerClasses.java + test/tools/javac/8009170/RedundantByteCodeInArrayTest.java From chris.hegarty at oracle.com Thu Mar 7 02:22:06 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 07 Mar 2013 10:22:06 +0000 Subject: hg: jdk8/tl/jdk: 6370908: Add support for HTTP_CONNECT proxy in Socket class Message-ID: <20130307102235.A0BFF47DD9@hg.openjdk.java.net> Changeset: 48b7295f02f8 Author: chegar Date: 2013-03-07 10:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48b7295f02f8 6370908: Add support for HTTP_CONNECT proxy in Socket class Reviewed-by: chegar Contributed-by: Damjan Jovanovic , Chris Hegarty + src/share/classes/java/net/HttpConnectSocketImpl.java ! src/share/classes/java/net/Socket.java + test/java/net/Socket/HttpProxy.java From david.holmes at oracle.com Thu Mar 7 02:53:01 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 07 Mar 2013 20:53:01 +1000 Subject: RFR(S): 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order with lock MethodData_lock/19 -- possible deadlock In-Reply-To: <9AE653E2-F251-4B8B-A6AD-965A25F2FF04@oracle.com> References: <21B2FFE7-AC80-4FE8-9704-ECDC33D5F889@oracle.com> <9AE653E2-F251-4B8B-A6AD-965A25F2FF04@oracle.com> Message-ID: <5138718D.8080708@oracle.com> On 7/03/2013 6:27 PM, Staffan Larsen wrote: > Can I have a Review for this small change, please. I could have sworn I'd already seen this one and reviewed it :) If it fixes the problem - looks fine. David > Thanks, > /Staffan > > On 18 feb 2013, at 11:15, Staffan Larsen wrote: > >> Please review this change for hs24 / jdku. >> >> webrev: http://cr.openjdk.java.net/~sla/8005572/webrev.00/ >> >> The problem lies with the order of the newly introduced JfrBuffer_lock and JfrStream_lock compared to the MethodData_lock. There are cases where we need to take the Jfr* locks while holding the MethodData_lock. Ths solution is simply to increase the lock order for the Jfr* locks. This change has baked for a while in internal testing and showed no regressions. >> >> Thanks, >> /Staffan > From staffan.larsen at oracle.com Thu Mar 7 03:28:21 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 7 Mar 2013 12:28:21 +0100 Subject: RFR(S): 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order with lock MethodData_lock/19 -- possible deadlock In-Reply-To: <5138718D.8080708@oracle.com> References: <21B2FFE7-AC80-4FE8-9704-ECDC33D5F889@oracle.com> <9AE653E2-F251-4B8B-A6AD-965A25F2FF04@oracle.com> <5138718D.8080708@oracle.com> Message-ID: Thanks David! On 7 mar 2013, at 11:53, David Holmes wrote: > On 7/03/2013 6:27 PM, Staffan Larsen wrote: >> Can I have a Review for this small change, please. > > I could have sworn I'd already seen this one and reviewed it :) > > If it fixes the problem - looks fine. > > David > >> Thanks, >> /Staffan >> >> On 18 feb 2013, at 11:15, Staffan Larsen wrote: >> >>> Please review this change for hs24 / jdku. >>> >>> webrev: http://cr.openjdk.java.net/~sla/8005572/webrev.00/ >>> >>> The problem lies with the order of the newly introduced JfrBuffer_lock and JfrStream_lock compared to the MethodData_lock. There are cases where we need to take the Jfr* locks while holding the MethodData_lock. Ths solution is simply to increase the lock order for the Jfr* locks. This change has baked for a while in internal testing and showed no regressions. >>> >>> Thanks, >>> /Staffan >> From staffan.larsen at oracle.com Thu Mar 7 03:54:08 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 7 Mar 2013 12:54:08 +0100 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <51379D88.6080807@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <513646F9.3060601@oracle.com> <51379D88.6080807@oracle.com> Message-ID: <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com> Here is a webrev for fixing this problem. I actually removed all of our own tokenization code in dll_build_name() and replaced it with calls to strtok_r (strtok_s on windows) instead. I think this should be more robust, at the cost of an extra memory allocation. I've also added the const qualifier to some of the parameters. http://cr.openjdk.java.net/~sla/8009558/webrev.02/ All of the jdi and hprof tests passes with this change. Thanks, /Staffan On 6 mar 2013, at 20:48, serguei.spitsyn at oracle.com wrote: > Staffan, > > Thank you for the confirmation and taking care about this issue! > > Thanks, > Serguei > > > On 3/6/13 11:36 AM, Staffan Larsen wrote: >> Nice catch, Serguei! >> >> Unfortunately I have already pushed my change, but I filed "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop" to track this new problem and I am working on a fix. >> >> Thanks, >> /Staffan >> >> >> On 5 mar 2013, at 20:26, serguei.spitsyn at oracle.com wrote: >> >>> Hi Staffan, >>> >>> Thank you for this discovery! >>> It looks good, but I have a couple of comments. >>> >>> It seems, there is one more problem in this code: >>> 68 /* check for NULL path */ >>> 69 if (p == pathname) { >>> 70 continue; <== Endless loop if we hit this line >>> 71 } >>> >>> Do we need to do 'pathname++' before continuing at the line #70? >>> It is going to be endless loop in cases there is a PATH_SEPARATOR >>> at the beginning of paths or two PATH_SEPARATOR's in a row. >>> These would be incorrect path lists but the code above is targeting exactly such cases. >>> >>> Also, the argument name "pathname" in the original code is confusing. >>> Should we rename it to "pathnames"? >>> >>> Thanks, >>> Serguei >>> >>> >>> On 3/4/13 10:56 AM, Staffan Larsen wrote: >>>> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: >>>> >>>> 57 static void dll_build_name(char* buffer, size_t buflen, >>>> 58 const char* pname, const char* fname) { >>>> 59 // Based on os_solaris.cpp >>>> 60 >>>> 61 char *path_sep = PATH_SEPARATOR; >>>> 62 char *pathname = (char *)pname; >>>> 63 while (strlen(pathname) > 0) { >>>> 64 char *p = strchr(pathname, *path_sep); >>>> 65 if (p == NULL) { >>>> 66 p = pathname + strlen(pathname); >>>> 67 } >>>> 68 /* check for NULL path */ >>>> 69 if (p == pathname) { >>>> 70 continue; >>>> 71 } >>>> 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), >>>> 73 pathname, fname); >>>> 74 >>>> 75 if (access(buffer, F_OK) == 0) { >>>> 76 break; >>>> 77 } >>>> 78 pathname = p + 1; >>>> 79 *buffer = '\0'; >>>> 80 } >>>> >>>> If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). >>>> >>>> The same code show up in both the solaris code and the windows code as well as hprof. >>>> >>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8009397 >>>> webrev: http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >>>> >>>> Thanks, >>>> /Staffan >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/cd1ef1b9/attachment.html From robert.field at oracle.com Thu Mar 7 08:27:35 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Thu, 07 Mar 2013 16:27:35 +0000 Subject: hg: jdk8/tl/langtools: 8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization Message-ID: <20130307162738.D16F347E00@hg.openjdk.java.net> Changeset: a02c3ddc182b Author: rfield Date: 2013-03-07 08:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a02c3ddc182b 8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/GenericMethodRefImplClass.java From kevin.walls at oracle.com Thu Mar 7 08:52:00 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 07 Mar 2013 16:52:00 +0000 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <5137889D.2080200@oracle.com> References: <5130E68A.4040806@oracle.com> <5137889D.2080200@oracle.com> Message-ID: <5138C5B0.3040609@oracle.com> Hi Erik - Yes, now you mention it I can see the route to printing the old warning or logging the event twice... I don't think it's reported as a problem, or maybe it's very rare and nobody has spotted it. But assuming it's not a "user-requested" collection, to get that false "should_compact" in acquire_control_and_collect, we need to call decide_foreground_collection_type(), and when it calls incremental_collection_will_fail(), that returns false. Possibly that is why we don't see the event reported twice in practice***: if we've got to this point, and state>Idling, we are usually here because that inc. collection would fail/is failing... Thanks Kevin *** if anybody really does hit this, or think it's likely, we can look again... On 06/03/13 18:19, Erik Helin wrote: > Hi Kevin, > > I think that there _might_ be a bug in CMS which was present even > before you added the event tracing. > > If you look in aquire_control_and_collect, you will see that > "should_compact" can be set to false by > decide_foreground_collection_type. If this is the case, then we will > end up in do_mark_sweep_work. > > The problem is that you have already reported, and CMS has already > printed, that a concurrent mode failure has occurred in > acquire_control_and_collect. Then, when you enter do_mark_sweep_work, > you will once again report, and CMS will again print, that concurrent > mode failure has happened. > > I am not 100% sure that I am right, by I believe that this can happen. > > What do you think? > > Thanks, > Erik > > On 03/01/2013 06:34 PM, Kevin Walls wrote: >> Hi, >> >> I'd like some reviews on this CMS Concurrent Mode Failure event: >> >> http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ >> >> The event doesn't actually carry any new information, but it is a >> warning we need to capture. >> >> This is against hsx24, I'll prepare the same, or reviewed, changes >> against very latest hotspot also. >> >> Thanks >> Kevin >> > From serguei.spitsyn at oracle.com Thu Mar 7 09:39:21 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 07 Mar 2013 09:39:21 -0800 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <513646F9.3060601@oracle.com> <51379D88.6080807@oracle.com> <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com> Message-ID: <5138D0C9.4030705@oracle.com> Nice fix! This is more clear and robust. Extra memory allocation is Ok. Thanks, Serguei On 3/7/13 3:54 AM, Staffan Larsen wrote: > Here is a webrev for fixing this problem. I actually removed all of > our own tokenization code in dll_build_name() and replaced it with > calls to strtok_r (strtok_s on windows) instead. I think this should > be more robust, at the cost of an extra memory allocation. I've also > added the const qualifier to some of the parameters. > > http://cr.openjdk.java.net/~sla/8009558/webrev.02/ > > > All of the jdi and hprof tests passes with this change. > > Thanks, > /Staffan > > On 6 mar 2013, at 20:48, serguei.spitsyn at oracle.com > wrote: > >> Staffan, >> >> Thank you for the confirmation and taking care about this issue! >> >> Thanks, >> Serguei >> >> >> On 3/6/13 11:36 AM, Staffan Larsen wrote: >>> Nice catch, Serguei! >>> >>> Unfortunately I have already pushed my change, but I filed >>> "JDK-8009558: linked_md.c::dll_build_name can get stuck in an >>> infinite loop" to track this new problem and I am working on a fix. >>> >>> Thanks, >>> /Staffan >>> >>> >>> On 5 mar 2013, at 20:26, serguei.spitsyn at oracle.com >>> wrote: >>> >>>> Hi Staffan, >>>> >>>> Thank you for this discovery! >>>> It looks good, but I have a couple of comments. >>>> >>>> It seems, there is one more problem in this code: >>>> 68 /* check for NULL path */ >>>> 69 if (p == pathname) { >>>> 70 continue;<== Endless loop if we hit this line >>>> 71 } >>>> >>>> Do we need to do 'pathname++' before continuing at the line #70? >>>> It is going to be endless loop in cases there is a PATH_SEPARATOR >>>> at the beginning of paths or two PATH_SEPARATOR's in a row. >>>> These would be incorrect path lists but the code above is targeting >>>> exactly such cases. >>>> >>>> Also, the argument name "pathname" in the original code is confusing. >>>> Should we rename it to "pathnames"? >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 3/4/13 10:56 AM, Staffan Larsen wrote: >>>>> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: >>>>> >>>>> 57 static void dll_build_name(char* buffer, size_t buflen, >>>>> 58 const char* pname, const char* fname) { >>>>> 59 // Based on os_solaris.cpp >>>>> 60 >>>>> 61 char *path_sep = PATH_SEPARATOR; >>>>> 62 char *pathname = (char *)pname; >>>>> 63 while (strlen(pathname) > 0) { >>>>> 64 char *p = strchr(pathname, *path_sep); >>>>> 65 if (p == NULL) { >>>>> 66 p = pathname + strlen(pathname); >>>>> 67 } >>>>> 68 /* check for NULL path */ >>>>> 69 if (p == pathname) { >>>>> 70 continue; >>>>> 71 } >>>>> 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), >>>>> 73 pathname, fname); >>>>> 74 >>>>> 75 if (access(buffer, F_OK) == 0) { >>>>> 76 break; >>>>> 77 } >>>>> 78 pathname = p + 1; >>>>> 79 *buffer = '\0'; >>>>> 80 } >>>>> >>>>> If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). >>>>> >>>>> The same code show up in both the solaris code and the windows code as well as hprof. >>>>> >>>>> bug:http://bugs.sun.com/view_bug.do?bug_id=8009397 >>>>> webrev:http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >>>>> >>>>> Thanks, >>>>> /Staffan >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/52b7b49b/attachment-0001.html From serguei.spitsyn at oracle.com Thu Mar 7 15:32:50 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 07 Mar 2013 15:32:50 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <513774B7.8090900@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> Message-ID: <513923A2.9040909@oracle.com> Hi Yumin, No insisting on refactoring, it is just desirable. :) * agent/src/os/bsd/symtab.c* Need a cleanup: 54 // #define NAMELEN 4096 78 // dysymtab_command dysymtabcmd; 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); This function is too big, it would be nice to factor out some of its body fragments as functions: 55 struct symtab* build_symtab(int fd) { The line 137 is too long. You can do like this: int size = symtabcmd.strsize * sizeof(char); if (read(fd, (void *)(symtab->strs), size) != size) { Space is missed: 145 //fix size No point to start new line if similar fragments like that do not have it: 153 symtab->symbols[i].size = 154 symtabcmd.strsize - symtab->symbols[i].size; Empty line is needed after the structure definition: 199 void *c_data; 200 }; 201 // read symbol table from given fd. 202 struct symtab* build_symtab(int fd) { ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* Need a consistent indentation (4?) as they are 2 and 3. For instance, the BsdDebuggerLocal.java has indent == 4. The flag name " newVT" does not match the comments, should it be named "oldVT" ? : 46 if (newVT) { 47 // old C++ ABI 48 vt = isDarwin ? "_vt_" : "__vt_"; 49 } else { 50 // new C++ ABI 51 vt = "_ZTV"; 52 } *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* Incorrect indent, it must be 4: 86 public long getUniqueThreadId() { 87 return unique_thread_id; 88 } Sorry for paying too much attention to indentation! It is because the SA indentation is a real mess. :) But this project is a nice progress in the SA area! In fact, it is a lot of work. I bet, you spent a lot of time debugging this code. Thanks, Serguei On 3/6/13 8:54 AM, Yumin Qi wrote: > Thanks, Serguei > > Will take care what you have indicated but refactoring code for > ps_core.c (Pgrab_core). Maybe in future, code cleaning should include > this, the better choice I think is regroup code to detail in specific > platform, such as with new file ps_core_darwin.c etc but not now. > > /Yumin > > On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >> >> Hi Yumin, >> >> >> A partial review below. >> >> * >> agent/src/os/bsd/MacosxDebuggerLocal.m >> * >> >> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >> 153 CHECK_EXCEPTION; >> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >> 155 "()[J"); >> 156 >> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >> >> Is CHECK_EXCEPTION needed after the line #154? >> >> The indent is 3 instead of 2: >> Lines 360-410, 775-788 >> >> ||*agent/src/os/bsd/libproc.h* >> 36 #ifdef __APPLE__ >> . . . >> 46 #ifndef bool >> 47 typedef int bool; >> 48 #define true 1 >> 49 #define false 0 >> 50 #endif // bool >> . . . >> 57 #else // __APPLE__ >> . . . >> 76 // This C bool type must be int for compatibility with BSD calls and >> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >> 78 typedef int bool; >> 79 #define true 1 >> 80 #define false 0 >> 81 >> 82 #endif // __APPLE__ >> The bool, true and false are defined the same way for APPLE and not >> APPLE. >> Would it make sense to define it just once? >> >> ||*agent/src/os/bsd/ps_core.c* >> >> Need a clean up: >> 869 // thread_command thrcmd; >> >> Space is missed after "if", wrong indent at line #873: >> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >> 873 goto err; >> Lines 893, 1087 are too long. >> >> The function read_core_segments() is big and not well readable. >> Would it make sense to consider to separate some of its internals as >> a local functions. >> For instance, the lines 921-950 are good candidates for it. >> >> The indent is 3: >> 1015 if (exists(filepath)) { >> 1016 strcpy(rpath, filepath); >> 1017 return true; >> 1018 } >> I did not understand the comments, probably, some words are missing: >> 1070 mach_header_64 header; // used to check if a file header in segment >> . . . >> 1110 // this is the file begining to core file. >> >> >> Not consistent, other fragments before used "goto err;" : >> 1122 return false; // error >> . . . >> 1133 return false; >> >> Too many ifdef'ed fragments with __APPLE__ >> Is it possibler to combine them into bigger chunks or refactor in a >> different way? >> For instance, the function Pgrab_core() is not readable. >> It'd be better to have two separated versions of the function for >> apple and not apple. >> >> >> Still to review: >> >> ||*agent/src/os/bsd/symtab.c* >> ||*agent/src/os/bsd/symtab.h* >> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >> ||*agent/src/share/native/sadis.c* >> ||*make/bsd/makefiles/saproc.make* >> >> >> Thanks, >> Serguei >> >> >> On 3/2/13 11:57 PM, Yumin Qi wrote: >>> Hi, all >>> >>> Please review at the new changes. Include >>> 1) use unique_thread_id (which is a 64 bit integer on Macosx) to >>> identify thread. Add a function in BsdDebuggerLocal to call the >>> newly added function BsdThread.getUniqueThreadId to get this id. >>> Meanwhile, move the code of forming threadList in native part to >>> BsdDebuggerLocal.java since the thread ids of all java threads can >>> be obtained from Threads and coding is much easier and clear. >>> >>> 2) To have better performance, get all java thread ids, stack >>> infos (stack begin, stack end) into one array of long which is >>> decoded in native code and used to set thread ids. This save much >>> more time first time to fill java thread ids. >>> >>> 3) remove DarwinVtblAccess.java which added in last version , >>> its functionality moved to BsdVtblAccess.java >>> >>> 4) BugSpotAgent.java no long exists, remove the changes. >>> >>> 5) remove unsupported platform defs. >>> >>> http://cr.openjdk.java.net/~minqi/8003348/ >>> >>> Thanks >>> Yumin >>> >>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>> Hi, Staffan (and Serguei) >>>> >>>> Made some clean for code. >>>> 1) added mach-o file fat header parsing as you suggested. >>>> 2) modified get_real_path as you indicated it could run with >>>> jre/bin/java >>>> 3) moved output information from CommandProcessor.java to >>>> PStack.java for printing out pstack not available for Darwin. >>>> 4) code clean, file header update. >>>> >>>> Please take a look at same location. >>>> >>>> Thanks >>>> Yumin >>>> >>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>> Thanks for doing this Yumin! >>>>> >>>>> I tried to apply you patch and run it, but I can't get SA to open >>>>> a core file. You can see the exception I get below. Is there some >>>>> kind of setup I need to do? This is against a jvmg build of Hotspot. >>>>> >>>>> I also noticed that you forgot to update BugSpotAgent.java with >>>>> the same changes as in HotspotAgent.java. This makes the jstack >>>>> tool fail. >>>>> >>>>> I will look at the changes more closely. >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> >>>>> >>>>> Opening core file, please wait... >>>>> Unable to open core file >>>>> /cores/core.79028: >>>>> >>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>> "gHotSpotVMTypes" in >>>>> remote process) >>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a >>>>> HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote >>>>> process) >>>>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>> hsdb> Input stream closed. >>>>> >>>>> >>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please review for the changes for SA to read core file on Mac >>>>>> OS X, this is feature is not implemented on previous releases. >>>>>> This change made for SA to work on core file on Darwin, but >>>>>> still some function not fixed, such as 'pstack'. This is intended >>>>>> to integrate into 8. >>>>>> >>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>> >>>>>> Please take some time since the code change is a little bigger. >>>>>> >>>>>> Thanks very much >>>>>> Yumin >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/47e28585/attachment.html From yumin.qi at oracle.com Thu Mar 7 15:55:19 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Thu, 07 Mar 2013 15:55:19 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <513923A2.9040909@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> Message-ID: <513928E7.50404@oracle.com> Hi, Serguei Thanks for the review, I reviewed the part of Pgrab_core, you are right, I now put the code into two chunks: APPLE and none APPLE. Will send another webrev for you tonight --- add all your concerns. See answers below: On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: > Hi Yumin, > > No insisting on refactoring, it is just desirable. :) > > * > agent/src/os/bsd/symtab.c* > > Need a cleanup: > 54 // #define NAMELEN 4096 > 78 // dysymtab_command dysymtabcmd; > 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); Yes, will. > > > This function is too big, it would be nice to factor out some > of its body fragments as functions: > 55 struct symtab* build_symtab(int fd) { Will try to make it nice. > The line 137 is too long. You can do like this: > int size = symtabcmd.strsize * sizeof(char); > if (read(fd, (void *)(symtab->strs), size) != size) { > Space is missed: > 145 //fix size > OK, will change. > No point to start new line if similar fragments like that do not have it: > 153 symtab->symbols[i].size = > 154 symtabcmd.strsize - symtab->symbols[i].size; Will change. > Empty line is needed after the structure definition: > 199 void *c_data; > 200 }; > 201 // read symbol table from given fd. > 202 struct symtab* build_symtab(int fd) { > Will change. > ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* > > Need a consistent indentation (4?) as they are 2 and 3. > For instance, the BsdDebuggerLocal.java has indent == 4. > Will change to 4. The SA code has no consistent coding style, some place you will see 3, some place 2 or 4. For Java code, I will change them to have 4 spaces. For C, have done some with 2, but still large amount of code ended with 3. This needs future clean work. > > The flag name " newVT" does not match the comments, should it be named > "oldVT" ? : > 46 if (newVT) { > 47 // old C++ ABI > 48 vt = isDarwin ? "_vt_" : "__vt_"; > 49 } else { > 50 // new C++ ABI > 51 vt = "_ZTV"; > 52 } Oh, I see, the comments reversed. > > *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* > > Incorrect indent, it must be 4: > 86 public long getUniqueThreadId() { > 87 return unique_thread_id; > 88 } > Yes. > Sorry for paying too much attention to indentation! > It is because the SA indentation is a real mess. :) > > But this project is a nice progress in the SA area! > In fact, it is a lot of work. > I bet, you spent a lot of time debugging this code. > My work is making SA reading core on Macosx work, now we have a working version! thanks. Yumin > > Thanks, > Serguei > > On 3/6/13 8:54 AM, Yumin Qi wrote: >> Thanks, Serguei >> >> Will take care what you have indicated but refactoring code for >> ps_core.c (Pgrab_core). Maybe in future, code cleaning should include >> this, the better choice I think is regroup code to detail in specific >> platform, such as with new file ps_core_darwin.c etc but not now. >> >> /Yumin >> >> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>> >>> Hi Yumin, >>> >>> >>> A partial review below. >>> >>> * >>> agent/src/os/bsd/MacosxDebuggerLocal.m >>> * >>> >>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>> 153 CHECK_EXCEPTION; >>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>> 155 "()[J"); >>> 156 >>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>> >>> Is CHECK_EXCEPTION needed after the line #154? >>> >>> The indent is 3 instead of 2: >>> Lines 360-410, 775-788 >>> >>> ||*agent/src/os/bsd/libproc.h* >>> 36 #ifdef __APPLE__ >>> . . . >>> 46 #ifndef bool >>> 47 typedef int bool; >>> 48 #define true 1 >>> 49 #define false 0 >>> 50 #endif // bool >>> . . . >>> 57 #else // __APPLE__ >>> . . . >>> 76 // This C bool type must be int for compatibility with BSD calls and >>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>> 78 typedef int bool; >>> 79 #define true 1 >>> 80 #define false 0 >>> 81 >>> 82 #endif // __APPLE__ >>> The bool, true and false are defined the same way for APPLE and not >>> APPLE. >>> Would it make sense to define it just once? >>> >>> ||*agent/src/os/bsd/ps_core.c* >>> >>> Need a clean up: >>> 869 // thread_command thrcmd; >>> >>> Space is missed after "if", wrong indent at line #873: >>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>> 873 goto err; >>> Lines 893, 1087 are too long. >>> >>> The function read_core_segments() is big and not well readable. >>> Would it make sense to consider to separate some of its internals as >>> a local functions. >>> For instance, the lines 921-950 are good candidates for it. >>> >>> The indent is 3: >>> 1015 if (exists(filepath)) { >>> 1016 strcpy(rpath, filepath); >>> 1017 return true; >>> 1018 } >>> I did not understand the comments, probably, some words are missing: >>> 1070 mach_header_64 header; // used to check if a file header in segment >>> . . . >>> 1110 // this is the file begining to core file. >>> >>> >>> Not consistent, other fragments before used "goto err;" : >>> 1122 return false; // error >>> . . . >>> 1133 return false; >>> >>> Too many ifdef'ed fragments with __APPLE__ >>> Is it possibler to combine them into bigger chunks or refactor in a >>> different way? >>> For instance, the function Pgrab_core() is not readable. >>> It'd be better to have two separated versions of the function for >>> apple and not apple. >>> >>> >>> Still to review: >>> >>> ||*agent/src/os/bsd/symtab.c* >>> ||*agent/src/os/bsd/symtab.h* >>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >>> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >>> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >>> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >>> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >>> ||*agent/src/share/native/sadis.c* >>> ||*make/bsd/makefiles/saproc.make* >>> >>> >>> Thanks, >>> Serguei >>> >>> >>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>> Hi, all >>>> >>>> Please review at the new changes. Include >>>> 1) use unique_thread_id (which is a 64 bit integer on Macosx) to >>>> identify thread. Add a function in BsdDebuggerLocal to call the >>>> newly added function BsdThread.getUniqueThreadId to get this id. >>>> Meanwhile, move the code of forming threadList in native part to >>>> BsdDebuggerLocal.java since the thread ids of all java threads can >>>> be obtained from Threads and coding is much easier and clear. >>>> >>>> 2) To have better performance, get all java thread ids, stack >>>> infos (stack begin, stack end) into one array of long which is >>>> decoded in native code and used to set thread ids. This save much >>>> more time first time to fill java thread ids. >>>> >>>> 3) remove DarwinVtblAccess.java which added in last version , >>>> its functionality moved to BsdVtblAccess.java >>>> >>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>> >>>> 5) remove unsupported platform defs. >>>> >>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>> >>>> Thanks >>>> Yumin >>>> >>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>> Hi, Staffan (and Serguei) >>>>> >>>>> Made some clean for code. >>>>> 1) added mach-o file fat header parsing as you suggested. >>>>> 2) modified get_real_path as you indicated it could run with >>>>> jre/bin/java >>>>> 3) moved output information from CommandProcessor.java to >>>>> PStack.java for printing out pstack not available for Darwin. >>>>> 4) code clean, file header update. >>>>> >>>>> Please take a look at same location. >>>>> >>>>> Thanks >>>>> Yumin >>>>> >>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>> Thanks for doing this Yumin! >>>>>> >>>>>> I tried to apply you patch and run it, but I can't get SA to open >>>>>> a core file. You can see the exception I get below. Is there some >>>>>> kind of setup I need to do? This is against a jvmg build of Hotspot. >>>>>> >>>>>> I also noticed that you forgot to update BugSpotAgent.java with >>>>>> the same changes as in HotspotAgent.java. This makes the jstack >>>>>> tool fail. >>>>>> >>>>>> I will look at the changes more closely. >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>>> >>>>>> >>>>>> >>>>>> Opening core file, please wait... >>>>>> Unable to open core file >>>>>> /cores/core.79028: >>>>>> >>>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>>> "gHotSpotVMTypes" in >>>>>> remote process) >>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be >>>>>> a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote >>>>>> process) >>>>>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>> hsdb> Input stream closed. >>>>>> >>>>>> >>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please review for the changes for SA to read core file on >>>>>>> Mac OS X, this is feature is not implemented on previous releases. >>>>>>> This change made for SA to work on core file on Darwin, but >>>>>>> still some function not fixed, such as 'pstack'. This is >>>>>>> intended to integrate into 8. >>>>>>> >>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>> >>>>>>> Please take some time since the code change is a little >>>>>>> bigger. >>>>>>> >>>>>>> Thanks very much >>>>>>> Yumin >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/9953b5d8/attachment-0001.html From serguei.spitsyn at oracle.com Thu Mar 7 16:01:52 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 07 Mar 2013 16:01:52 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <513928E7.50404@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> <513928E7.50404@oracle.com> Message-ID: <51392A70.5040107@oracle.com> Thank you for making the suggested changes! Serguei On 3/7/13 3:55 PM, Yumin Qi wrote: > Hi, Serguei > > Thanks for the review, I reviewed the part of Pgrab_core, you are > right, I now put the code into two chunks: APPLE and none APPLE. > Will send another webrev for you tonight --- add all your concerns. > > See answers below: > > On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: >> Hi Yumin, >> >> No insisting on refactoring, it is just desirable. :) >> >> * >> agent/src/os/bsd/symtab.c* >> >> Need a cleanup: >> 54 // #define NAMELEN 4096 >> 78 // dysymtab_command dysymtabcmd; >> 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); > Yes, will. >> >> >> This function is too big, it would be nice to factor out some >> of its body fragments as functions: >> 55 struct symtab* build_symtab(int fd) { > Will try to make it nice. >> The line 137 is too long. You can do like this: >> int size = symtabcmd.strsize * sizeof(char); >> if (read(fd, (void *)(symtab->strs), size) != size) { >> Space is missed: >> 145 //fix size >> > OK, will change. >> No point to start new line if similar fragments like that do not have it: >> 153 symtab->symbols[i].size = >> 154 symtabcmd.strsize - symtab->symbols[i].size; > Will change. >> Empty line is needed after the structure definition: >> 199 void *c_data; >> 200 }; >> 201 // read symbol table from given fd. >> 202 struct symtab* build_symtab(int fd) { >> > Will change. >> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >> >> Need a consistent indentation (4?) as they are 2 and 3. >> For instance, the BsdDebuggerLocal.java has indent == 4. >> > Will change to 4. > The SA code has no consistent coding style, some place you will see 3, > some place 2 or 4. > For Java code, I will change them to have 4 spaces. For C, have done > some with 2, but still large amount of code ended with 3. > This needs future clean work. >> >> The flag name " newVT" does not match the comments, should it be >> named "oldVT" ? : >> 46 if (newVT) { >> 47 // old C++ ABI >> 48 vt = isDarwin ? "_vt_" : "__vt_"; >> 49 } else { >> 50 // new C++ ABI >> 51 vt = "_ZTV"; >> 52 } > Oh, I see, the comments reversed. >> >> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >> >> Incorrect indent, it must be 4: >> 86 public long getUniqueThreadId() { >> 87 return unique_thread_id; >> 88 } >> > Yes. >> Sorry for paying too much attention to indentation! >> It is because the SA indentation is a real mess. :) >> >> But this project is a nice progress in the SA area! >> In fact, it is a lot of work. >> I bet, you spent a lot of time debugging this code. >> > My work is making SA reading core on Macosx work, now we have a > working version! thanks. > > Yumin >> >> Thanks, >> Serguei >> >> On 3/6/13 8:54 AM, Yumin Qi wrote: >>> Thanks, Serguei >>> >>> Will take care what you have indicated but refactoring code for >>> ps_core.c (Pgrab_core). Maybe in future, code cleaning should >>> include this, the better choice I think is regroup code to detail in >>> specific platform, such as with new file ps_core_darwin.c etc but >>> not now. >>> >>> /Yumin >>> >>> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>>> >>>> Hi Yumin, >>>> >>>> >>>> A partial review below. >>>> >>>> * >>>> agent/src/os/bsd/MacosxDebuggerLocal.m >>>> * >>>> >>>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>>> 153 CHECK_EXCEPTION; >>>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>>> 155 "()[J"); >>>> 156 >>>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>>> >>>> Is CHECK_EXCEPTION needed after the line #154? >>>> >>>> The indent is 3 instead of 2: >>>> Lines 360-410, 775-788 >>>> >>>> ||*agent/src/os/bsd/libproc.h* >>>> 36 #ifdef __APPLE__ >>>> . . . >>>> 46 #ifndef bool >>>> 47 typedef int bool; >>>> 48 #define true 1 >>>> 49 #define false 0 >>>> 50 #endif // bool >>>> . . . >>>> 57 #else // __APPLE__ >>>> . . . >>>> 76 // This C bool type must be int for compatibility with BSD calls and >>>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>>> 78 typedef int bool; >>>> 79 #define true 1 >>>> 80 #define false 0 >>>> 81 >>>> 82 #endif // __APPLE__ >>>> The bool, true and false are defined the same way for APPLE and not >>>> APPLE. >>>> Would it make sense to define it just once? >>>> >>>> ||*agent/src/os/bsd/ps_core.c* >>>> >>>> Need a clean up: >>>> 869 // thread_command thrcmd; >>>> >>>> Space is missed after "if", wrong indent at line #873: >>>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>>> 873 goto err; >>>> Lines 893, 1087 are too long. >>>> >>>> The function read_core_segments() is big and not well readable. >>>> Would it make sense to consider to separate some of its internals >>>> as a local functions. >>>> For instance, the lines 921-950 are good candidates for it. >>>> >>>> The indent is 3: >>>> 1015 if (exists(filepath)) { >>>> 1016 strcpy(rpath, filepath); >>>> 1017 return true; >>>> 1018 } >>>> I did not understand the comments, probably, some words are missing: >>>> 1070 mach_header_64 header; // used to check if a file header in segment >>>> . . . >>>> 1110 // this is the file begining to core file. >>>> >>>> >>>> Not consistent, other fragments before used "goto err;" : >>>> 1122 return false; // error >>>> . . . >>>> 1133 return false; >>>> >>>> Too many ifdef'ed fragments with __APPLE__ >>>> Is it possibler to combine them into bigger chunks or refactor in a >>>> different way? >>>> For instance, the function Pgrab_core() is not readable. >>>> It'd be better to have two separated versions of the function for >>>> apple and not apple. >>>> >>>> >>>> Still to review: >>>> >>>> ||*agent/src/os/bsd/symtab.c* >>>> ||*agent/src/os/bsd/symtab.h* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >>>> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >>>> ||*agent/src/share/native/sadis.c* >>>> ||*make/bsd/makefiles/saproc.make* >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>>> Hi, all >>>>> >>>>> Please review at the new changes. Include >>>>> 1) use unique_thread_id (which is a 64 bit integer on Macosx) >>>>> to identify thread. Add a function in BsdDebuggerLocal to call the >>>>> newly added function BsdThread.getUniqueThreadId to get this id. >>>>> Meanwhile, move the code of forming threadList in native part to >>>>> BsdDebuggerLocal.java since the thread ids of all java threads can >>>>> be obtained from Threads and coding is much easier and clear. >>>>> >>>>> 2) To have better performance, get all java thread ids, stack >>>>> infos (stack begin, stack end) into one array of long which is >>>>> decoded in native code and used to set thread ids. This save much >>>>> more time first time to fill java thread ids. >>>>> >>>>> 3) remove DarwinVtblAccess.java which added in last version , >>>>> its functionality moved to BsdVtblAccess.java >>>>> >>>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>>> >>>>> 5) remove unsupported platform defs. >>>>> >>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>> >>>>> Thanks >>>>> Yumin >>>>> >>>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>>> Hi, Staffan (and Serguei) >>>>>> >>>>>> Made some clean for code. >>>>>> 1) added mach-o file fat header parsing as you suggested. >>>>>> 2) modified get_real_path as you indicated it could run with >>>>>> jre/bin/java >>>>>> 3) moved output information from CommandProcessor.java to >>>>>> PStack.java for printing out pstack not available for Darwin. >>>>>> 4) code clean, file header update. >>>>>> >>>>>> Please take a look at same location. >>>>>> >>>>>> Thanks >>>>>> Yumin >>>>>> >>>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>>> Thanks for doing this Yumin! >>>>>>> >>>>>>> I tried to apply you patch and run it, but I can't get SA to >>>>>>> open a core file. You can see the exception I get below. Is >>>>>>> there some kind of setup I need to do? This is against a jvmg >>>>>>> build of Hotspot. >>>>>>> >>>>>>> I also noticed that you forgot to update BugSpotAgent.java with >>>>>>> the same changes as in HotspotAgent.java. This makes the jstack >>>>>>> tool fail. >>>>>>> >>>>>>> I will look at the changes more closely. >>>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>>> >>>>>>> >>>>>>> >>>>>>> Opening core file, please wait... >>>>>>> Unable to open core file >>>>>>> /cores/core.79028: >>>>>>> >>>>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>>>> "gHotSpotVMTypes" in >>>>>>> remote process) >>>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be >>>>>>> a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote >>>>>>> process) >>>>>>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>>> hsdb> Input stream closed. >>>>>>> >>>>>>> >>>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Please review for the changes for SA to read core file on >>>>>>>> Mac OS X, this is feature is not implemented on previous releases. >>>>>>>> This change made for SA to work on core file on Darwin, but >>>>>>>> still some function not fixed, such as 'pstack'. This is >>>>>>>> intended to integrate into 8. >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>> >>>>>>>> Please take some time since the code change is a little >>>>>>>> bigger. >>>>>>>> >>>>>>>> Thanks very much >>>>>>>> Yumin >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/77491449/attachment-0001.html From poonam.bajaj at oracle.com Thu Mar 7 16:03:04 2013 From: poonam.bajaj at oracle.com (Poonam Bajaj) Date: Fri, 08 Mar 2013 05:33:04 +0530 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <5130E68A.4040806@oracle.com> References: <5130E68A.4040806@oracle.com> Message-ID: <51392AB8.7010503@oracle.com> Hi Kevin, Changes look good to me. Thanks, Poonam On 3/1/2013 11:04 PM, Kevin Walls wrote: > Hi, > > I'd like some reviews on this CMS Concurrent Mode Failure event: > > http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ > > The event doesn't actually carry any new information, but it is a > warning we need to capture. > > This is against hsx24, I'll prepare the same, or reviewed, changes > against very latest hotspot also. > > Thanks > Kevin > From zhengyu.gu at oracle.com Thu Mar 7 20:50:30 2013 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Fri, 08 Mar 2013 04:50:30 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8008257: NMT: assert(new_rec->is_allocation_record()) failed when running with shared memory option Message-ID: <20130308045035.1553047EBB@hg.openjdk.java.net> Changeset: 6b803ba47588 Author: zgu Date: 2013-03-07 14:06 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b803ba47588 8008257: NMT: assert(new_rec->is_allocation_record()) failed when running with shared memory option Summary: Corrected virtual memory recording and tagging code when large pages are used Reviewed-by: coleenp, ccheung ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp From yumin.qi at oracle.com Thu Mar 7 22:22:35 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Thu, 07 Mar 2013 22:22:35 -0800 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <51392A70.5040107@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> <513928E7.50404@oracle.com> <51392A70.5040107@oracle.com> Message-ID: <513983AB.8070805@oracle.com> Serguei and Saffan, Please take look at the same link for new webrev. Thanks Yumin On 3/7/2013 4:01 PM, serguei.spitsyn at oracle.com wrote: > Thank you for making the suggested changes! > Serguei > > On 3/7/13 3:55 PM, Yumin Qi wrote: >> Hi, Serguei >> >> Thanks for the review, I reviewed the part of Pgrab_core, you are >> right, I now put the code into two chunks: APPLE and none APPLE. >> Will send another webrev for you tonight --- add all your concerns. >> >> See answers below: >> >> On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: >>> Hi Yumin, >>> >>> No insisting on refactoring, it is just desirable. :) >>> >>> * >>> agent/src/os/bsd/symtab.c* >>> >>> Need a cleanup: >>> 54 // #define NAMELEN 4096 >>> 78 // dysymtab_command dysymtabcmd; >>> 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); >> Yes, will. >>> >>> >>> This function is too big, it would be nice to factor out some >>> of its body fragments as functions: >>> 55 struct symtab* build_symtab(int fd) { >> Will try to make it nice. >>> The line 137 is too long. You can do like this: >>> int size = symtabcmd.strsize * sizeof(char); >>> if (read(fd, (void *)(symtab->strs), size) != size) { >>> Space is missed: >>> 145 //fix size >>> >> OK, will change. >>> No point to start new line if similar fragments like that do not >>> have it: >>> 153 symtab->symbols[i].size = >>> 154 symtabcmd.strsize - symtab->symbols[i].size; >> Will change. >>> Empty line is needed after the structure definition: >>> 199 void *c_data; >>> 200 }; >>> 201 // read symbol table from given fd. >>> 202 struct symtab* build_symtab(int fd) { >>> >> Will change. >>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>> >>> Need a consistent indentation (4?) as they are 2 and 3. >>> For instance, the BsdDebuggerLocal.java has indent == 4. >>> >> Will change to 4. >> The SA code has no consistent coding style, some place you will see >> 3, some place 2 or 4. >> For Java code, I will change them to have 4 spaces. For C, have done >> some with 2, but still large amount of code ended with 3. >> This needs future clean work. >>> >>> The flag name " newVT" does not match the comments, should it be >>> named "oldVT" ? : >>> 46 if (newVT) { >>> 47 // old C++ ABI >>> 48 vt = isDarwin ? "_vt_" : "__vt_"; >>> 49 } else { >>> 50 // new C++ ABI >>> 51 vt = "_ZTV"; >>> 52 } >> Oh, I see, the comments reversed. >>> >>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>> >>> Incorrect indent, it must be 4: >>> 86 public long getUniqueThreadId() { >>> 87 return unique_thread_id; >>> 88 } >>> >> Yes. >>> Sorry for paying too much attention to indentation! >>> It is because the SA indentation is a real mess. :) >>> >>> But this project is a nice progress in the SA area! >>> In fact, it is a lot of work. >>> I bet, you spent a lot of time debugging this code. >>> >> My work is making SA reading core on Macosx work, now we have a >> working version! thanks. >> >> Yumin >>> >>> Thanks, >>> Serguei >>> >>> On 3/6/13 8:54 AM, Yumin Qi wrote: >>>> Thanks, Serguei >>>> >>>> Will take care what you have indicated but refactoring code for >>>> ps_core.c (Pgrab_core). Maybe in future, code cleaning should >>>> include this, the better choice I think is regroup code to detail >>>> in specific platform, such as with new file ps_core_darwin.c etc >>>> but not now. >>>> >>>> /Yumin >>>> >>>> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>>>> >>>>> Hi Yumin, >>>>> >>>>> >>>>> A partial review below. >>>>> >>>>> * >>>>> agent/src/os/bsd/MacosxDebuggerLocal.m >>>>> * >>>>> >>>>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>>>> 153 CHECK_EXCEPTION; >>>>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>>>> 155 "()[J"); >>>>> 156 >>>>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>>>> >>>>> Is CHECK_EXCEPTION needed after the line #154? >>>>> >>>>> The indent is 3 instead of 2: >>>>> Lines 360-410, 775-788 >>>>> >>>>> ||*agent/src/os/bsd/libproc.h* >>>>> 36 #ifdef __APPLE__ >>>>> . . . >>>>> 46 #ifndef bool >>>>> 47 typedef int bool; >>>>> 48 #define true 1 >>>>> 49 #define false 0 >>>>> 50 #endif // bool >>>>> . . . >>>>> 57 #else // __APPLE__ >>>>> . . . >>>>> 76 // This C bool type must be int for compatibility with BSD calls and >>>>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>>>> 78 typedef int bool; >>>>> 79 #define true 1 >>>>> 80 #define false 0 >>>>> 81 >>>>> 82 #endif // __APPLE__ >>>>> The bool, true and false are defined the same way for APPLE and >>>>> not APPLE. >>>>> Would it make sense to define it just once? >>>>> >>>>> ||*agent/src/os/bsd/ps_core.c* >>>>> >>>>> Need a clean up: >>>>> 869 // thread_command thrcmd; >>>>> >>>>> Space is missed after "if", wrong indent at line #873: >>>>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>>>> 873 goto err; >>>>> Lines 893, 1087 are too long. >>>>> >>>>> The function read_core_segments() is big and not well readable. >>>>> Would it make sense to consider to separate some of its internals >>>>> as a local functions. >>>>> For instance, the lines 921-950 are good candidates for it. >>>>> >>>>> The indent is 3: >>>>> 1015 if (exists(filepath)) { >>>>> 1016 strcpy(rpath, filepath); >>>>> 1017 return true; >>>>> 1018 } >>>>> I did not understand the comments, probably, some words are missing: >>>>> 1070 mach_header_64 header; // used to check if a file header in segment >>>>> . . . >>>>> 1110 // this is the file begining to core file. >>>>> >>>>> >>>>> Not consistent, other fragments before used "goto err;" : >>>>> 1122 return false; // error >>>>> . . . >>>>> 1133 return false; >>>>> >>>>> Too many ifdef'ed fragments with __APPLE__ >>>>> Is it possibler to combine them into bigger chunks or refactor in >>>>> a different way? >>>>> For instance, the function Pgrab_core() is not readable. >>>>> It'd be better to have two separated versions of the function for >>>>> apple and not apple. >>>>> >>>>> >>>>> Still to review: >>>>> >>>>> ||*agent/src/os/bsd/symtab.c* >>>>> ||*agent/src/os/bsd/symtab.h* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >>>>> ||*agent/src/share/native/sadis.c* >>>>> ||*make/bsd/makefiles/saproc.make* >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>>>> Hi, all >>>>>> >>>>>> Please review at the new changes. Include >>>>>> 1) use unique_thread_id (which is a 64 bit integer on Macosx) >>>>>> to identify thread. Add a function in BsdDebuggerLocal to call >>>>>> the newly added function BsdThread.getUniqueThreadId to get this >>>>>> id. Meanwhile, move the code of forming threadList in native part >>>>>> to BsdDebuggerLocal.java since the thread ids of all java threads >>>>>> can be obtained from Threads and coding is much easier and clear. >>>>>> >>>>>> 2) To have better performance, get all java thread ids, stack >>>>>> infos (stack begin, stack end) into one array of long which is >>>>>> decoded in native code and used to set thread ids. This save much >>>>>> more time first time to fill java thread ids. >>>>>> >>>>>> 3) remove DarwinVtblAccess.java which added in last version , >>>>>> its functionality moved to BsdVtblAccess.java >>>>>> >>>>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>>>> >>>>>> 5) remove unsupported platform defs. >>>>>> >>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>> >>>>>> Thanks >>>>>> Yumin >>>>>> >>>>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>>>> Hi, Staffan (and Serguei) >>>>>>> >>>>>>> Made some clean for code. >>>>>>> 1) added mach-o file fat header parsing as you suggested. >>>>>>> 2) modified get_real_path as you indicated it could run with >>>>>>> jre/bin/java >>>>>>> 3) moved output information from CommandProcessor.java to >>>>>>> PStack.java for printing out pstack not available for Darwin. >>>>>>> 4) code clean, file header update. >>>>>>> >>>>>>> Please take a look at same location. >>>>>>> >>>>>>> Thanks >>>>>>> Yumin >>>>>>> >>>>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>>>> Thanks for doing this Yumin! >>>>>>>> >>>>>>>> I tried to apply you patch and run it, but I can't get SA to >>>>>>>> open a core file. You can see the exception I get below. Is >>>>>>>> there some kind of setup I need to do? This is against a jvmg >>>>>>>> build of Hotspot. >>>>>>>> >>>>>>>> I also noticed that you forgot to update BugSpotAgent.java with >>>>>>>> the same changes as in HotspotAgent.java. This makes the jstack >>>>>>>> tool fail. >>>>>>>> >>>>>>>> I will look at the changes more closely. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> /Staffan >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Opening core file, please wait... >>>>>>>> Unable to open core file >>>>>>>> /cores/core.79028: >>>>>>>> >>>>>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>>>>> "gHotSpotVMTypes" in >>>>>>>> remote process) >>>>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to >>>>>>>> be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in >>>>>>>> remote process) >>>>>>>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>>>> hsdb> Input stream closed. >>>>>>>> >>>>>>>> >>>>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please review for the changes for SA to read core file on >>>>>>>>> Mac OS X, this is feature is not implemented on previous >>>>>>>>> releases. >>>>>>>>> This change made for SA to work on core file on Darwin, >>>>>>>>> but still some function not fixed, such as 'pstack'. This is >>>>>>>>> intended to integrate into 8. >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>> >>>>>>>>> Please take some time since the code change is a little >>>>>>>>> bigger. >>>>>>>>> >>>>>>>>> Thanks very much >>>>>>>>> Yumin >>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130307/ae33003c/attachment-0001.html From john.coomes at oracle.com Fri Mar 8 01:44:18 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Mar 2013 09:44:18 +0000 Subject: hg: hsx/hotspot-rt: 6 new changesets Message-ID: <20130308094418.8B2A747F0B@hg.openjdk.java.net> Changeset: ab82853d3365 Author: erikj Date: 2013-02-21 14:16 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ab82853d3365 8008451: Make mac builds on 10.8 work on 10.7 Reviewed-by: ohair, ddehaven ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: d3e3d5b06f45 Author: ohair Date: 2013-02-23 10:47 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/d3e3d5b06f45 8004712: build-infra: Move user guide from web pages to repository Summary: Just the initial work, will need more changes. Reviewed-by: tbell ! README ! README-builds.html Changeset: 2778e6576e21 Author: katleman Date: 2013-02-26 13:23 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/2778e6576e21 Merge Changeset: 0adf9c626bb1 Author: katleman Date: 2013-02-28 20:29 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/0adf9c626bb1 Merge Changeset: 907a926d3c96 Author: erikj Date: 2013-03-04 16:45 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/907a926d3c96 8004352: build-infra: Limit JOBS on large machines Reviewed-by: mduigou ! common/autoconf/build-performance.m4 ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/spec.gmk.in ! common/makefiles/JavaCompilation.gmk ! common/makefiles/Main.gmk Changeset: cd7f2c7e2a0e Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/cd7f2c7e2a0e Added tag jdk8-b80 for changeset 907a926d3c96 ! .hgtags From john.coomes at oracle.com Fri Mar 8 01:44:23 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Mar 2013 09:44:23 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b80 for changeset 5f3d4a6bdd02 Message-ID: <20130308094426.6F37647F0C@hg.openjdk.java.net> Changeset: 2a00aeeb466b Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/2a00aeeb466b Added tag jdk8-b80 for changeset 5f3d4a6bdd02 ! .hgtags From john.coomes at oracle.com Fri Mar 8 01:44:30 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Mar 2013 09:44:30 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b80 for changeset 4873a0499bc3 Message-ID: <20130308094443.2BD7147FA4@hg.openjdk.java.net> Changeset: ef3495555a4c Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/ef3495555a4c Added tag jdk8-b80 for changeset 4873a0499bc3 ! .hgtags From john.coomes at oracle.com Fri Mar 8 01:44:48 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Mar 2013 09:44:48 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b80 for changeset b0224010e2f0 Message-ID: <20130308094453.CE7F248001@hg.openjdk.java.net> Changeset: c88bb21560cc Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/c88bb21560cc Added tag jdk8-b80 for changeset b0224010e2f0 ! .hgtags From erik.helin at oracle.com Fri Mar 8 01:50:48 2013 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 08 Mar 2013 10:50:48 +0100 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <5138C5B0.3040609@oracle.com> References: <5130E68A.4040806@oracle.com> <5137889D.2080200@oracle.com> <5138C5B0.3040609@oracle.com> Message-ID: <5139B478.8080605@oracle.com> Kevin, On 03/07/2013 05:52 PM, Kevin Walls wrote: > Hi Erik - > > Yes, now you mention it I can see the route to printing the old warning > or logging the event twice... > > I don't think it's reported as a problem, or maybe it's very rare and > nobody has spotted it. It is possible to reproduce the problem with a Java program that simply allocates until OOM: import java.util.ArrayList; public class Reproducer { public static ArrayList garbage = new ArrayList(); public static void main(String[] args) { while (true) { garbage.add(new byte[1024]); } } } Compile the above Java program and then run: java -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails -XX:-UseCMSCompactAtFullCollection -Xmx100m Reproducer Depending on how fast machine you have, the Java program will run for about 2 seconds and the GC logs will show (near the start of the output): [GC (Allocation Failure) [ParNew: 30720K->30720K(30720K), 0.0001940 secs][CMS[CMS-concurrent-mark: 0.035/0.036 secs] [Times: user=0.03 sys=0.00, real=0.04 secs] (concurrent mode failure) (concurrent mode failure)[YG occupancy: 30720 K (30720 K)][checkpointRootsFinalWork[Rescan (parallel) , 0.0314620 secs][refProcessingWork[weak refs processing, 0.0000320 secs][class unloading, 0.0006770 secs][scrub symbol table, 0.0009850 secs][scrub string table, 0.0000690 secs], 0.0021430 secs], 0.0339750 secs]: 50655K->50654K(68288K), 0.0972030 secs] 81375K->81374K(99008K), [Metaspace: 2662K->2662K(4486K/110592K)], 0.0980400 secs] [Times: user=0.11 sys=0.00, real=0.10 secs] Please notice the two "(concurrent mode failure)" above which are printed for the reason I explained in my previous email. On 03/07/2013 05:52 PM, Kevin Walls wrote: > But assuming it's not a "user-requested" collection, to get that false > "should_compact" in acquire_control_and_collect, we need to call > decide_foreground_collection_type(), and when it calls > incremental_collection_will_fail(), that returns false. This is assuming that the flag UseCMSCompactAtFullCollection is true. On 03/07/2013 05:52 PM, Kevin Walls wrote: > Possibly that is why we don't see the event reported twice in > practice***: if we've got to this point, and state>Idling, we are > usually here because that inc. collection would fail/is failing... This is most likely the reason, since UseCMSCompactAtFullCollection is true by default and if users aren't changing it, then your reasoning is correct. I suggest that we file a separate bug for CMS printing out "(concurrent mode failure)" twice, fix that and then we base your trace code on that. What do you think? Thanks, Erik > Thanks > Kevin > > *** if anybody really does hit this, or think it's likely, we can look > again... > > > > On 06/03/13 18:19, Erik Helin wrote: >> Hi Kevin, >> >> I think that there _might_ be a bug in CMS which was present even >> before you added the event tracing. >> >> If you look in aquire_control_and_collect, you will see that >> "should_compact" can be set to false by >> decide_foreground_collection_type. If this is the case, then we will >> end up in do_mark_sweep_work. >> >> The problem is that you have already reported, and CMS has already >> printed, that a concurrent mode failure has occurred in >> acquire_control_and_collect. Then, when you enter do_mark_sweep_work, >> you will once again report, and CMS will again print, that concurrent >> mode failure has happened. >> >> I am not 100% sure that I am right, by I believe that this can happen. >> >> What do you think? >> >> Thanks, >> Erik >> >> On 03/01/2013 06:34 PM, Kevin Walls wrote: >>> Hi, >>> >>> I'd like some reviews on this CMS Concurrent Mode Failure event: >>> >>> http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ >>> >>> The event doesn't actually carry any new information, but it is a >>> warning we need to capture. >>> >>> This is against hsx24, I'll prepare the same, or reviewed, changes >>> against very latest hotspot also. >>> >>> Thanks >>> Kevin >>> >> > From john.coomes at oracle.com Fri Mar 8 01:45:06 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Mar 2013 09:45:06 +0000 Subject: hg: hsx/hotspot-rt/jdk: 8 new changesets Message-ID: <20130308094720.4359E48002@hg.openjdk.java.net> Changeset: 5a1ea5bbe10a Author: erikj Date: 2013-02-21 14:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5a1ea5bbe10a 8007387: "sed: RE error: illegal byte sequence" when building images on Mac Reviewed-by: tbell ! makefiles/Images.gmk Changeset: a287f6a0d46d Author: erikj Date: 2013-02-21 14:16 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a287f6a0d46d 8008451: Make mac builds on 10.8 work on 10.7 Reviewed-by: ohair, ddehaven ! make/common/Defs-macosx.gmk Changeset: 5d27f8702118 Author: erikj Date: 2013-02-21 14:23 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5d27f8702118 8007903: 8005583's changes to make/install-rules.gmk need to made to jdk/make/closed/InstallWrapper.gmk Reviewed-by: tbell, ohair ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-utils.gmk Changeset: f0b5b57014b3 Author: katleman Date: 2013-02-26 13:23 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f0b5b57014b3 Merge Changeset: 8d3dbb724859 Author: katleman Date: 2013-02-27 13:10 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8d3dbb724859 Merge Changeset: b760d5d4b8d3 Author: katleman Date: 2013-02-28 19:30 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b760d5d4b8d3 8009196: install doesn't define $(AR) as /usr/ccs/bin/ar, results in ar: Command not found Reviewed-by: tbell ! make/common/shared/Defs-utils.gmk Changeset: dfb40f066c6c Author: katleman Date: 2013-02-28 20:30 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/dfb40f066c6c Merge Changeset: d60a95b95f01 Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d60a95b95f01 Added tag jdk8-b80 for changeset dfb40f066c6c ! .hgtags From john.coomes at oracle.com Fri Mar 8 01:48:42 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Mar 2013 09:48:42 +0000 Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b80 for changeset a8227c617684 Message-ID: <20130308094855.2408648003@hg.openjdk.java.net> Changeset: ed69d087fdfd Author: katleman Date: 2013-03-07 11:18 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ed69d087fdfd Added tag jdk8-b80 for changeset a8227c617684 ! .hgtags From kevin.walls at oracle.com Fri Mar 8 02:08:26 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 08 Mar 2013 10:08:26 +0000 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <5139B478.8080605@oracle.com> References: <5130E68A.4040806@oracle.com> <5137889D.2080200@oracle.com> <5138C5B0.3040609@oracle.com> <5139B478.8080605@oracle.com> Message-ID: <5139B89A.8000304@oracle.com> Hi Erik - aha yes, so not that rare then for the right kind of program! I'll talk to you about when/how to do this and the new event. Thanks Kevin On 08/03/13 09:50, Erik Helin wrote: > Kevin, > > On 03/07/2013 05:52 PM, Kevin Walls wrote: >> Hi Erik - >> >> Yes, now you mention it I can see the route to printing the old warning >> or logging the event twice... >> >> I don't think it's reported as a problem, or maybe it's very rare and >> nobody has spotted it. > > It is possible to reproduce the problem with a Java program that > simply allocates until OOM: > > import java.util.ArrayList; > > public class Reproducer { > public static ArrayList garbage = new ArrayList(); > public static void main(String[] args) { > while (true) { > garbage.add(new byte[1024]); > } > } > } > > Compile the above Java program and then run: > > java -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails > -XX:-UseCMSCompactAtFullCollection -Xmx100m Reproducer > > Depending on how fast machine you have, the Java program will run for > about 2 seconds and the GC logs will show (near the start of the output): > > [GC (Allocation Failure) [ParNew: 30720K->30720K(30720K), 0.0001940 > secs][CMS[CMS-concurrent-mark: 0.035/0.036 secs] [Times: user=0.03 > sys=0.00, real=0.04 secs] > (concurrent mode failure) (concurrent mode failure)[YG occupancy: > 30720 K (30720 K)][checkpointRootsFinalWork[Rescan (parallel) , > 0.0314620 secs][refProcessingWork[weak refs processing, 0.0000320 > secs][class unloading, 0.0006770 secs][scrub symbol table, 0.0009850 > secs][scrub string table, 0.0000690 secs], 0.0021430 secs], 0.0339750 > secs]: 50655K->50654K(68288K), 0.0972030 secs] 81375K->81374K(99008K), > [Metaspace: 2662K->2662K(4486K/110592K)], 0.0980400 secs] [Times: > user=0.11 sys=0.00, real=0.10 secs] > > Please notice the two "(concurrent mode failure)" above which are > printed for the reason I explained in my previous email. > > On 03/07/2013 05:52 PM, Kevin Walls wrote: >> But assuming it's not a "user-requested" collection, to get that false >> "should_compact" in acquire_control_and_collect, we need to call >> decide_foreground_collection_type(), and when it calls >> incremental_collection_will_fail(), that returns false. > > This is assuming that the flag UseCMSCompactAtFullCollection is true. > > On 03/07/2013 05:52 PM, Kevin Walls wrote: >> Possibly that is why we don't see the event reported twice in >> practice***: if we've got to this point, and state>Idling, we are >> usually here because that inc. collection would fail/is failing... > > This is most likely the reason, since UseCMSCompactAtFullCollection is > true by default and if users aren't changing it, then your reasoning > is correct. > > I suggest that we file a separate bug for CMS printing out > "(concurrent mode failure)" twice, fix that and then we base your > trace code on that. > > What do you think? > > Thanks, > Erik > >> Thanks >> Kevin >> >> *** if anybody really does hit this, or think it's likely, we can look >> again... >> >> >> >> On 06/03/13 18:19, Erik Helin wrote: >>> Hi Kevin, >>> >>> I think that there _might_ be a bug in CMS which was present even >>> before you added the event tracing. >>> >>> If you look in aquire_control_and_collect, you will see that >>> "should_compact" can be set to false by >>> decide_foreground_collection_type. If this is the case, then we will >>> end up in do_mark_sweep_work. >>> >>> The problem is that you have already reported, and CMS has already >>> printed, that a concurrent mode failure has occurred in >>> acquire_control_and_collect. Then, when you enter do_mark_sweep_work, >>> you will once again report, and CMS will again print, that concurrent >>> mode failure has happened. >>> >>> I am not 100% sure that I am right, by I believe that this can happen. >>> >>> What do you think? >>> >>> Thanks, >>> Erik >>> >>> On 03/01/2013 06:34 PM, Kevin Walls wrote: >>>> Hi, >>>> >>>> I'd like some reviews on this CMS Concurrent Mode Failure event: >>>> >>>> http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ >>>> >>>> The event doesn't actually carry any new information, but it is a >>>> warning we need to capture. >>>> >>>> This is against hsx24, I'll prepare the same, or reviewed, changes >>>> against very latest hotspot also. >>>> >>>> Thanks >>>> Kevin >>>> >>> >> > From alan.bateman at oracle.com Fri Mar 8 04:08:11 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 08 Mar 2013 12:08:11 +0000 Subject: hg: jdk8/tl/jdk: 8006000: TEST_BUG: java/lang/invoke/lambda/LambdaAccessControlTest.java fails intermittently Message-ID: <20130308120900.960EE48005@hg.openjdk.java.net> Changeset: 98cf76df3e6e Author: alanb Date: 2013-03-08 12:03 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98cf76df3e6e 8006000: TEST_BUG: java/lang/invoke/lambda/LambdaAccessControlTest.java fails intermittently Reviewed-by: chegar + test/java/lang/invoke/lambda/LUtils.java ! test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java ! test/java/lang/invoke/lambda/LambdaAccessControlTest.java From alan.bateman at oracle.com Fri Mar 8 11:59:54 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 08 Mar 2013 19:59:54 +0000 Subject: hg: jdk8/tl/jdk: 8009645: ClassFileTransformer hooks in ClassLoader no longer required Message-ID: <20130308200022.69D2248014@hg.openjdk.java.net> Changeset: 01908630df14 Author: alanb Date: 2013-03-08 19:51 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01908630df14 8009645: ClassFileTransformer hooks in ClassLoader no longer required Reviewed-by: mchung, iris ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/sun/misc/ClassFileTransformer.java From mike.duigou at oracle.com Fri Mar 8 15:46:28 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 08 Mar 2013 23:46:28 +0000 Subject: hg: jdk8/tl/jdk: 8001667: Comparator combinators and extension methods Message-ID: <20130308234653.BB4EA48025@hg.openjdk.java.net> Changeset: e38b46041049 Author: mduigou Date: 2013-03-08 15:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e38b46041049 8001667: Comparator combinators and extension methods Reviewed-by: mduigou, briangoetz Contributed-by: henry.jen at oracle.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Comparator.java + src/share/classes/java/util/Comparators.java ! test/java/util/Collections/ReverseOrder.java + test/java/util/ComparatorsTest.java From coleen.phillimore at oracle.com Fri Mar 8 17:39:41 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Sat, 09 Mar 2013 01:39:41 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8003553: NPG: metaspace objects should be zeroed in constructors Message-ID: <20130309013948.0829348026@hg.openjdk.java.net> Changeset: 3efdfd6ddbf2 Author: coleenp Date: 2013-03-08 11:47 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3efdfd6ddbf2 8003553: NPG: metaspace objects should be zeroed in constructors Summary: Zero metadata in constructors, not in allocation (and some in constructors) Reviewed-by: jmasa, sspitsyn ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/memory/metablock.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/runtime/vmStructs.cpp From daniel.daugherty at oracle.com Fri Mar 8 21:19:18 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sat, 09 Mar 2013 05:19:18 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 25 new changesets Message-ID: <20130309052014.EF06048030@hg.openjdk.java.net> Changeset: a252e688abcf Author: jmasa Date: 2013-02-01 17:02 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a252e688abcf 7189971: Implement CMSWaitDuration for non-incremental mode of CMS Reviewed-by: jmasa, johnc, ysr Contributed-by: michal at frajt.eu ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/runtime/globals.hpp Changeset: 0624b9d81255 Author: ehelin Date: 2013-03-04 13:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0624b9d81255 8004172: Update jstat counter names to reflect metaspace changes Reviewed-by: stefank, jmasa ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp Changeset: 27714220e50e Author: johnc Date: 2013-03-04 12:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/27714220e50e 8007036: G1: Too many old regions added to last mixed GC Summary: Stop adding old regions to collection set when the remaining reclaimable bytes reaches, or goes below, G1HeapWastePercent. Changes were also reviewed by Vitaly Davidovich . Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: d778bb46a9a5 Author: erikj Date: 2013-03-04 22:39 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d778bb46a9a5 8008451: Make mac builds on 10.8 work on 10.7 Reviewed-by: jcoomes, ohair ! make/bsd/makefiles/gcc.make Changeset: c71e15057f1d Author: stefank Date: 2013-03-07 14:29 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c71e15057f1d Merge Changeset: 7369298bec7e Author: collins Date: 2013-02-27 20:36 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7369298bec7e 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option Summary: Small changes to hotspot tests to remove "-server" and replace with ${TESTVMOPTS} Reviewed-by: kvn ! test/compiler/6431242/Test.java ! test/compiler/6589834/Test_ia32.java ! test/compiler/6636138/Test1.java ! test/compiler/6636138/Test2.java ! test/compiler/6795161/Test.java ! test/compiler/6946040/TestCharShortByteSwap.java ! test/compiler/7068051/Test7068051.sh ! test/compiler/8000805/Test8000805.java Changeset: 5cf033ff06c4 Author: bpittore Date: 2013-03-01 14:06 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5cf033ff06c4 Merge Changeset: af5ac43f06e9 Author: jprovino Date: 2013-03-07 10:46 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/af5ac43f06e9 Merge Changeset: 0b8f9c8d2617 Author: jiangli Date: 2013-03-07 10:39 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0b8f9c8d2617 Merge Changeset: 40b7c6b800ab Author: morris Date: 2013-03-01 14:26 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/40b7c6b800ab 8008327: [parfait] Unitialized variable in hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m Summary: Fix unitialized variable and return value. Reviewed-by: kvn ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: bf06968a8a00 Author: morris Date: 2013-03-04 13:15 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bf06968a8a00 8008559: [parfait] Path through non-void function '_ZN2os15thread_cpu_timeEP6Thread' returns an undefined value Summary: safety checks for non-Apple thread time functions Reviewed-by: kvn ! src/os/bsd/vm/os_bsd.cpp Changeset: c40fbf634c90 Author: morris Date: 2013-03-05 04:24 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c40fbf634c90 8008574: [parfait] Null pointer deference in hotspot/src/share/vm/runtime/frame.cpp Summary: fix null pointer Reviewed-by: kvn ! src/share/vm/runtime/frame.cpp Changeset: 571076d3c79d Author: shade Date: 2013-03-05 04:24 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/571076d3c79d 8009120: Fuzz instruction scheduling in HotSpot compilers Reviewed-by: kvn, vlivanov ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/lcm.cpp Changeset: 4f553e24b3b5 Author: vlivanov Date: 2013-03-05 08:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4f553e24b3b5 Merge Changeset: 872b3feace55 Author: morris Date: 2013-03-05 18:03 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/872b3feace55 8008750: [partfait] Null pointer deference in hotspot/src/share/vm/oops/instanceKlass.hpp Summary: fix null pointer Reviewed-by: kvn, coleenp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 8651f608fea4 Author: roland Date: 2013-03-06 10:28 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8651f608fea4 8009460: C2compiler crash in machnode::in_regmask(unsigned int) Summary: 7121140 may not correctly break the Allocate -> MemBarStoreStore link Reviewed-by: kvn ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/macro.cpp Changeset: ff55877839bc Author: kvn Date: 2013-03-06 12:25 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ff55877839bc 8009472: Print additional information for 8004640 failure Summary: dump nodes and types in 8004640 case. Reviewed-by: roland ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/memnode.cpp Changeset: bdb602473679 Author: morris Date: 2013-03-07 14:46 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bdb602473679 Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: b5bd25d55994 Author: morris Date: 2013-03-07 18:03 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5bd25d55994 Merge Changeset: fbda7e1dee9a Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fbda7e1dee9a Added tag jdk8-b80 for changeset 4a198b201f3c ! .hgtags Changeset: dd6350b4abc4 Author: amurillo Date: 2013-03-08 08:10 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dd6350b4abc4 Merge Changeset: 65b797426a3b Author: amurillo Date: 2013-03-08 08:10 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/65b797426a3b Added tag hs25-b22 for changeset dd6350b4abc4 ! .hgtags Changeset: 8196357e95b5 Author: amurillo Date: 2013-03-08 08:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8196357e95b5 8009688: new hotspot build - hs25-b23 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 252ad8d5f22b Author: dcubed Date: 2013-03-08 17:14 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/252ad8d5f22b Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: 35ef86296a5d Author: dcubed Date: 2013-03-08 17:49 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/35ef86296a5d Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp From weijun.wang at oracle.com Sat Mar 9 01:29:54 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Sat, 09 Mar 2013 09:29:54 +0000 Subject: hg: jdk8/tl/jdk: 8000653: SPNEGO tests fail at context.getDelegCred().getRemainingInitLifetime(mechOid) Message-ID: <20130309093019.0384148035@hg.openjdk.java.net> Changeset: 230bafd05509 Author: weijun Date: 2013-03-09 17:27 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/230bafd05509 8000653: SPNEGO tests fail at context.getDelegCred().getRemainingInitLifetime(mechOid) Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/GSSCredentialImpl.java ! src/share/classes/sun/security/jgss/spnego/SpNegoCredElement.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/SpnegoLifeTime.java From sundararajan.athijegannathan at oracle.com Sun Mar 10 09:01:11 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Sun, 10 Mar 2013 16:01:11 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20130310160119.3F48E4804E@hg.openjdk.java.net> Changeset: 3d57f57acd9c Author: sundar Date: 2013-03-06 22:38 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3d57f57acd9c 8009553: Object.create(Array.prototype) doesn't respect reset length Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/objects/Global.java + test/script/basic/JDK-8009553.js Changeset: 5759f600fcf7 Author: sundar Date: 2013-03-09 21:49 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5759f600fcf7 8009559: clean up method handle lookup code. Reviewed-by: ahgross, jlaskey, attila, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java ! make/java.security.override ! src/jdk/internal/dynalink/beans/CheckRestrictedPackage.java - src/jdk/internal/dynalink/beans/CheckRestrictedPackageInternal.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java - src/jdk/internal/dynalink/beans/RestrictedPackageTester.java + src/jdk/internal/dynalink/beans/SafeUnreflector.java + src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java + src/jdk/internal/dynalink/beans/SandboxClassLoader.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java + src/jdk/internal/dynalink/beans/sandbox/Unreflector.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java + src/jdk/nashorn/internal/lookup/Lookup.java + src/jdk/nashorn/internal/lookup/MethodHandleFactory.java + src/jdk/nashorn/internal/lookup/MethodHandleFunctionality.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/SpillProperty.java ! src/jdk/nashorn/internal/runtime/Undefined.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java - src/jdk/nashorn/internal/runtime/linker/Lookup.java - src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java - src/jdk/nashorn/internal/runtime/linker/MethodHandleFunctionality.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java + test/script/currently-failing/JDK-8006529.js - test/script/trusted/JDK-8006529.js From vicente.romero at oracle.com Mon Mar 11 08:36:35 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 11 Mar 2013 15:36:35 +0000 Subject: hg: jdk8/tl/langtools: 6181889: Empty try/finally results in bytecodes being generated Message-ID: <20130311153638.7968E48064@hg.openjdk.java.net> Changeset: c61add6bf8ac Author: vromero Date: 2013-03-11 15:35 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c61add6bf8ac 6181889: Empty try/finally results in bytecodes being generated Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T6181889/EmptyFinallyTest.java From robert.field at oracle.com Mon Mar 11 10:03:43 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Mon, 11 Mar 2013 17:03:43 +0000 Subject: hg: jdk8/tl/langtools: 8009742: Bad lambda name for lambda in a static initializer or ctor Message-ID: <20130311170347.DC1574806F@hg.openjdk.java.net> Changeset: d0ae21e3a382 Author: rfield Date: 2013-03-11 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0ae21e3a382 8009742: Bad lambda name for lambda in a static initializer or ctor Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/SerializedLambdaInInit.java From jonathan.gibbons at oracle.com Mon Mar 11 19:04:34 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 12 Mar 2013 02:04:34 +0000 Subject: hg: jdk8/tl/langtools: 8009843: sjavac should accept -cp as synonym for -classpath Message-ID: <20130312020439.A685648090@hg.openjdk.java.net> Changeset: fbb6e470079d Author: ohrstrom Date: 2013-03-11 19:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fbb6e470079d 8009843: sjavac should accept -cp as synonym for -classpath Reviewed-by: jjg ! src/share/classes/com/sun/tools/sjavac/Main.java From joel.franck at oracle.com Tue Mar 12 03:18:06 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 12 Mar 2013 10:18:06 +0000 Subject: hg: jdk8/tl/langtools: 8005205: tests missing bugid for repeating annotation change Message-ID: <20130312101819.082034809E@hg.openjdk.java.net> Changeset: 7fe9b9d29095 Author: jfranck Date: 2013-03-12 11:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fe9b9d29095 8005205: tests missing bugid for repeating annotation change Reviewed-by: jjg, ssides ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java From coleen.phillimore at oracle.com Tue Mar 12 07:54:15 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 12 Mar 2013 14:54:15 +0000 Subject: hg: jdk8/tl/jdk: 7154889: Non-zero padding is still not allowed in the tableswitch/lookupswitch instructions. Message-ID: <20130312145449.738A5480A7@hg.openjdk.java.net> Changeset: 334ddf3b101f Author: coleenp Date: 2013-03-12 10:35 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/334ddf3b101f 7154889: Non-zero padding is still not allowed in the tableswitch/lookupswitch instructions. Summary: Do not check that the padding bytes are zero if class file format version >=51. Reviewed-by: dholmes, coleenp, mullan, kvn Contributed-by: harold.seigel at oracle.com ! src/share/native/common/check_code.c From kevin.walls at oracle.com Tue Mar 12 08:58:22 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 12 Mar 2013 15:58:22 +0000 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <51378071.2060107@oracle.com> References: <5130E68A.4040806@oracle.com> <51378071.2060107@oracle.com> Message-ID: <513F509E.3010808@oracle.com> Hi, This is the updated hsx24 webrev with a more generic name: http://cr.openjdk.java.net/~kevinw/8008917/hsx24.01/webrev/ it builds upon the change for 8009723, so a second failure message is removed when compared to the parent, as that change isn't in hsx24 yet (only latest, so a backport of that is required before pushing this). Thanks Kevin Jesper Wilhelmsson wrote: > Looks good! > > Since we want to implement this event for G1 as well, maybe we should > remove the "CMS" from the event name and path? > > Thanks, > /Jesper > > On 1/3/13 6:34 PM, Kevin Walls wrote: >> Hi, >> >> I'd like some reviews on this CMS Concurrent Mode Failure event: >> >> http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ >> >> The event doesn't actually carry any new information, but it is a >> warning we >> need to capture. >> >> This is against hsx24, I'll prepare the same, or reviewed, changes >> against very >> latest hotspot also. >> >> Thanks >> Kevin >> From maurizio.cimadamore at oracle.com Tue Mar 12 09:03:21 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 12 Mar 2013 16:03:21 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20130312160338.BC5D1480AA@hg.openjdk.java.net> Changeset: 6db9a3b1a93f Author: mcimadamore Date: 2013-03-12 16:02 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6db9a3b1a93f 8008540: Constructor reference to non-reifiable array should be rejected 8008539: Spurious error when constructor reference mention an interface type 8008538: Constructor reference accepts wildcard parameterized types Summary: Overhaul of Check.checkConstructorRefType Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/lambda/MethodReference38.out + test/tools/javac/lambda/MethodReference64.java + test/tools/javac/lambda/MethodReference64.out Changeset: 5ddecb91d843 Author: mcimadamore Date: 2013-03-12 16:02 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5ddecb91d843 8009545: Graph inference: dependencies between inference variables should be set during incorporation Summary: Move all transitivity checks into the incorporation round Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/lambda/TargetType28.out From joel.franck at oracle.com Tue Mar 12 09:41:03 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 12 Mar 2013 16:41:03 +0000 Subject: hg: jdk8/tl/langtools: 7196531: Duplicate error messages on repeating annotations Message-ID: <20130312164106.305CE480B1@hg.openjdk.java.net> Changeset: f427043f8c65 Author: jfranck Date: 2013-03-12 17:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f427043f8c65 7196531: Duplicate error messages on repeating annotations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Annotate.java + test/tools/javac/annotations/repeatingAnnotations/DuplicateErrors.java + test/tools/javac/annotations/repeatingAnnotations/DuplicateErrors.out ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out ! test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out ! test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.out From jesper.wilhelmsson at oracle.com Tue Mar 12 10:49:43 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 12 Mar 2013 18:49:43 +0100 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <513F509E.3010808@oracle.com> References: <5130E68A.4040806@oracle.com> <51378071.2060107@oracle.com> <513F509E.3010808@oracle.com> Message-ID: <513F6AB7.7080401@oracle.com> Looks good! Ship it! /Jesper On 12/3/13 4:58 PM, Kevin Walls wrote: > Hi, > > This is the updated hsx24 webrev with a more generic name: > > http://cr.openjdk.java.net/~kevinw/8008917/hsx24.01/webrev/ > > it builds upon the change for 8009723, so a second failure message is removed > when compared to the parent, as that change isn't in hsx24 yet (only latest, so > a backport of that is required before pushing this). > > Thanks > Kevin > > > Jesper Wilhelmsson wrote: >> Looks good! >> >> Since we want to implement this event for G1 as well, maybe we should remove >> the "CMS" from the event name and path? >> >> Thanks, >> /Jesper >> >> On 1/3/13 6:34 PM, Kevin Walls wrote: >>> Hi, >>> >>> I'd like some reviews on this CMS Concurrent Mode Failure event: >>> >>> http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ >>> >>> The event doesn't actually carry any new information, but it is a warning we >>> need to capture. >>> >>> This is against hsx24, I'll prepare the same, or reviewed, changes against very >>> latest hotspot also. >>> >>> Thanks >>> Kevin >>> > From serguei.spitsyn at oracle.com Tue Mar 12 12:52:27 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 12 Mar 2013 12:52:27 -0700 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <513983AB.8070805@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> <513928E7.50404@oracle.com> <51392A70.5040107@oracle.com> <513983AB.8070805@oracle.com> Message-ID: <513F877B.5010302@oracle.com> Yumin, The updated webrev looks good. Just some simple cosmetic and debug comments below. *agent/src/os/bsd/MacosxDebuggerLocal.m* Nice refactoring! 350 /** Only used for core file reading, set thread_id for threads which got after core file parsing. 351 When parsing core file on Mac OS X, thread context is available but thread id. 352 We identify them as java threads by checking if a thread's rsp or rbp within a java thread's 353 stack(stack info is recoreded when it is created). Note Macosx uses unique_thread_id which is 354 different from other platforms though printed ids are still pthread id. 355 Function BsdDebuggerLocal.getJavaThreadsInfo returns an array of long integers to host 356 all java threads' id, stack_start, stack_end as: 357 [uid0, stack_start0, stack_end0, uid1, stack_start1, stack_end1, ...] 358 359 The work cannot be done at init0 since Threads is not available yet(VM not initialized yet). 360 This function should be called only once if succeeded */ It'd be better to start lines 351-360 with the '*'. The sentence at line 351 is not clear. 393 /* core file only, called from Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_getThreadIntegerRegisterSet0 */ 394 jlongArray getThreadIntegerRegisterSetFromCore(JNIEnv *env, jobject this_obj, long lwp_id) { 395 // On Mac OS X, we can not get thread_id from x86Thread_State_t, but they are recorded in JavaThread of JVM The comment lines 393 and 395 are two long and can be split in two. 440 regs[REG_INDEX(RDI)] = gregs.r_rdi; 441 regs[REG_INDEX(RIP)] = gregs.r_rip; 442 regs[REG_INDEX(CS)] = gregs.r_cs; 443 regs[REG_INDEX(RSP)] = gregs.r_rsp; 444 regs[REG_INDEX(SS)] = gregs.r_ss; 445 regs[REG_INDEX(FSBASE)] = 0; 446 regs[REG_INDEX(GSBASE)] = 0; 447 regs[REG_INDEX(DS)] = gregs.r_ds; 448 regs[REG_INDEX(ES)] = gregs.r_es; 449 regs[REG_INDEX(FS)] = gregs.r_fs; 450 regs[REG_INDEX(GS)] = gregs.r_gs; 451 regs[REG_INDEX(TRAPNO)] = gregs.r_trapno; 452 regs[REG_INDEX(RFL)] = gregs.r_rflags; At least, the lines 442, 444, 447-450 and 452 can be aligned as 440-441. 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! [PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); The line above is too long. You can split it like this: 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! " "[PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); *agent/src/os/bsd/Makefile* The lines 25 and 55 are too long. | |*agent/src/os/bsd/libproc_impl.c* | I see you've fixed many indents in this file. | || *agent/src/os/bsd/ps_core.c* 565 print_debug(" r_r15: 0x%" PRIx64 "\n", threadinfo->regs.r_r15); 566 print_debug(" r_r14: 0x%" PRIx64 "\n", threadinfo->regs.r_r14); 567 print_debug(" r_r13: 0x%" PRIx64 "\n", threadinfo->regs.r_r13); 568 print_debug(" r_r12: 0x%" PRIx64 "\n", threadinfo->regs.r_r12); 569 print_debug(" r_r11: 0x%" PRIx64 "\n", threadinfo->regs.r_r11); 570 print_debug(" r_r10: 0x%" PRIx64 "\n", threadinfo->regs.r_r10); 571 print_debug(" r_r9: 0x%" PRIx64 "\n", threadinfo->regs.r_r9); 572 print_debug(" r_r8: 0x%" PRIx64 "\n", threadinfo->regs.r_r8); 573 print_debug(" r_rdi: 0x%" PRIx64 "\n", threadinfo->regs.r_rdi); 574 print_debug(" r_rsi: 0x%" PRIx64 "\n", threadinfo->regs.r_rsi); 575 print_debug(" r_rbp: 0x%" PRIx64 "\n", threadinfo->regs.r_rbp); 576 print_debug(" r_rbx: 0x%" PRIx64 "\n", threadinfo->regs.r_rbx); 577 print_debug(" r_rdx: 0x%" PRIx64 "\n", threadinfo->regs.r_rdx); 578 print_debug(" r_rcx: 0x%" PRIx64 "\n", threadinfo->regs.r_rcx); 579 print_debug(" r_rax: 0x%" PRIx64 "\n", threadinfo->regs.r_rax); 580 print_debug(" r_fs: 0x%" PRIx32 "\n", threadinfo->regs.r_fs); 581 print_debug(" r_gs: 0x%" PRIx32 "\n", threadinfo->regs.r_gs); 582 print_debug(" r_rip 0x%" PRIx64 "\n", threadinfo->regs.r_rip); 583 print_debug(" r_cs: 0x%" PRIx64 "\n", threadinfo->regs.r_cs); 584 print_debug(" r_rflags: 0x%" PRIx64 "\n", threadinfo->regs.r_rflags); 585 print_debug(" r_rsp: 0x%" PRIx64 "\n", threadinfo->regs.r_rsp); The lines can be aligned better and printed info will be more readable too: 571-572,580-583 622 print_debug("segment added: %" PRIu64 " 0x%" PRIx64 " %d\n", segcmd.fileoff, segcmd.vmaddr, segcmd.vmsize); 816 print_debug("map_info %d: vmaddr = 0x%016" PRIx64 " fileoff = %" PRIu64 " vmsize = %" PRIu64 "\n", j, iter->vaddr, iter->offset, iter->memsz); The print_debug lines are too long. One empty line extra: 272-273. 956 if (read_core_segments(ph) != true) 957 goto err; 958 959 // allocate and sort maps into map_array, we need to do this 960 // here because read_shared_lib_info needs to read from debuggee 961 // address space 962 if (sort_map_array(ph) != true) 963 goto err; 964 965 if (read_shared_lib_info(ph) != true) 966 goto err; 967 968 // sort again because we have added more mappings from shared objects 969 if (sort_map_array(ph) != true) 970 goto err; 971 972 if (init_classsharing_workaround(ph) != true) 973 goto err; Probably have to print a debug error message for before "goto err;". Thanks, Serguei ** On 3/7/13 10:22 PM, Yumin Qi wrote: > Serguei and Saffan, > > Please take look at the same link for new webrev. > > Thanks > Yumin > > On 3/7/2013 4:01 PM, serguei.spitsyn at oracle.com wrote: >> Thank you for making the suggested changes! >> Serguei >> >> On 3/7/13 3:55 PM, Yumin Qi wrote: >>> Hi, Serguei >>> >>> Thanks for the review, I reviewed the part of Pgrab_core, you are >>> right, I now put the code into two chunks: APPLE and none APPLE. >>> Will send another webrev for you tonight --- add all your concerns. >>> >>> See answers below: >>> >>> On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: >>>> Hi Yumin, >>>> >>>> No insisting on refactoring, it is just desirable. :) >>>> >>>> * >>>> agent/src/os/bsd/symtab.c* >>>> >>>> Need a cleanup: >>>> 54 // #define NAMELEN 4096 >>>> 78 // dysymtab_command dysymtabcmd; >>>> 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); >>> Yes, will. >>>> >>>> >>>> This function is too big, it would be nice to factor out some >>>> of its body fragments as functions: >>>> 55 struct symtab* build_symtab(int fd) { >>> Will try to make it nice. >>>> The line 137 is too long. You can do like this: >>>> int size = symtabcmd.strsize * sizeof(char); >>>> if (read(fd, (void *)(symtab->strs), size) != size) { >>>> Space is missed: >>>> 145 //fix size >>>> >>> OK, will change. >>>> No point to start new line if similar fragments like that do not >>>> have it: >>>> 153 symtab->symbols[i].size = >>>> 154 symtabcmd.strsize - symtab->symbols[i].size; >>> Will change. >>>> Empty line is needed after the structure definition: >>>> 199 void *c_data; >>>> 200 }; >>>> 201 // read symbol table from given fd. >>>> 202 struct symtab* build_symtab(int fd) { >>>> >>> Will change. >>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>> >>>> Need a consistent indentation (4?) as they are 2 and 3. >>>> For instance, the BsdDebuggerLocal.java has indent == 4. >>>> >>> Will change to 4. >>> The SA code has no consistent coding style, some place you will see >>> 3, some place 2 or 4. >>> For Java code, I will change them to have 4 spaces. For C, have done >>> some with 2, but still large amount of code ended with 3. >>> This needs future clean work. >>>> >>>> The flag name " newVT" does not match the comments, should it be >>>> named "oldVT" ? : >>>> 46 if (newVT) { >>>> 47 // old C++ ABI >>>> 48 vt = isDarwin ? "_vt_" : "__vt_"; >>>> 49 } else { >>>> 50 // new C++ ABI >>>> 51 vt = "_ZTV"; >>>> 52 } >>> Oh, I see, the comments reversed. >>>> >>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>> >>>> Incorrect indent, it must be 4: >>>> 86 public long getUniqueThreadId() { >>>> 87 return unique_thread_id; >>>> 88 } >>>> >>> Yes. >>>> Sorry for paying too much attention to indentation! >>>> It is because the SA indentation is a real mess. :) >>>> >>>> But this project is a nice progress in the SA area! >>>> In fact, it is a lot of work. >>>> I bet, you spent a lot of time debugging this code. >>>> >>> My work is making SA reading core on Macosx work, now we have a >>> working version! thanks. >>> >>> Yumin >>>> >>>> Thanks, >>>> Serguei >>>> >>>> On 3/6/13 8:54 AM, Yumin Qi wrote: >>>>> Thanks, Serguei >>>>> >>>>> Will take care what you have indicated but refactoring code for >>>>> ps_core.c (Pgrab_core). Maybe in future, code cleaning should >>>>> include this, the better choice I think is regroup code to detail >>>>> in specific platform, such as with new file ps_core_darwin.c etc >>>>> but not now. >>>>> >>>>> /Yumin >>>>> >>>>> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>>>>> >>>>>> Hi Yumin, >>>>>> >>>>>> >>>>>> A partial review below. >>>>>> >>>>>> * >>>>>> agent/src/os/bsd/MacosxDebuggerLocal.m >>>>>> * >>>>>> >>>>>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>>>>> 153 CHECK_EXCEPTION; >>>>>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>>>>> 155 "()[J"); >>>>>> 156 >>>>>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>>>>> >>>>>> Is CHECK_EXCEPTION needed after the line #154? >>>>>> >>>>>> The indent is 3 instead of 2: >>>>>> Lines 360-410, 775-788 >>>>>> >>>>>> ||*agent/src/os/bsd/libproc.h* >>>>>> 36 #ifdef __APPLE__ >>>>>> . . . >>>>>> 46 #ifndef bool >>>>>> 47 typedef int bool; >>>>>> 48 #define true 1 >>>>>> 49 #define false 0 >>>>>> 50 #endif // bool >>>>>> . . . >>>>>> 57 #else // __APPLE__ >>>>>> . . . >>>>>> 76 // This C bool type must be int for compatibility with BSD calls and >>>>>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>>>>> 78 typedef int bool; >>>>>> 79 #define true 1 >>>>>> 80 #define false 0 >>>>>> 81 >>>>>> 82 #endif // __APPLE__ >>>>>> The bool, true and false are defined the same way for APPLE and >>>>>> not APPLE. >>>>>> Would it make sense to define it just once? >>>>>> >>>>>> ||*agent/src/os/bsd/ps_core.c* >>>>>> >>>>>> Need a clean up: >>>>>> 869 // thread_command thrcmd; >>>>>> >>>>>> Space is missed after "if", wrong indent at line #873: >>>>>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>>>>> 873 goto err; >>>>>> Lines 893, 1087 are too long. >>>>>> >>>>>> The function read_core_segments() is big and not well readable. >>>>>> Would it make sense to consider to separate some of its internals >>>>>> as a local functions. >>>>>> For instance, the lines 921-950 are good candidates for it. >>>>>> >>>>>> The indent is 3: >>>>>> 1015 if (exists(filepath)) { >>>>>> 1016 strcpy(rpath, filepath); >>>>>> 1017 return true; >>>>>> 1018 } >>>>>> I did not understand the comments, probably, some words are missing: >>>>>> 1070 mach_header_64 header; // used to check if a file header in segment >>>>>> . . . >>>>>> 1110 // this is the file begining to core file. >>>>>> >>>>>> >>>>>> Not consistent, other fragments before used "goto err;" : >>>>>> 1122 return false; // error >>>>>> . . . >>>>>> 1133 return false; >>>>>> >>>>>> Too many ifdef'ed fragments with __APPLE__ >>>>>> Is it possibler to combine them into bigger chunks or refactor in >>>>>> a different way? >>>>>> For instance, the function Pgrab_core() is not readable. >>>>>> It'd be better to have two separated versions of the function for >>>>>> apple and not apple. >>>>>> >>>>>> >>>>>> Still to review: >>>>>> >>>>>> ||*agent/src/os/bsd/symtab.c* >>>>>> ||*agent/src/os/bsd/symtab.h* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >>>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >>>>>> ||*agent/src/share/native/sadis.c* >>>>>> ||*make/bsd/makefiles/saproc.make* >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>> >>>>>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>>>>> Hi, all >>>>>>> >>>>>>> Please review at the new changes. Include >>>>>>> 1) use unique_thread_id (which is a 64 bit integer on Macosx) >>>>>>> to identify thread. Add a function in BsdDebuggerLocal to call >>>>>>> the newly added function BsdThread.getUniqueThreadId to get this >>>>>>> id. Meanwhile, move the code of forming threadList in native >>>>>>> part to BsdDebuggerLocal.java since the thread ids of all java >>>>>>> threads can be obtained from Threads and coding is much easier >>>>>>> and clear. >>>>>>> >>>>>>> 2) To have better performance, get all java thread ids, >>>>>>> stack infos (stack begin, stack end) into one array of long >>>>>>> which is decoded in native code and used to set thread ids. This >>>>>>> save much more time first time to fill java thread ids. >>>>>>> >>>>>>> 3) remove DarwinVtblAccess.java which added in last version >>>>>>> , its functionality moved to BsdVtblAccess.java >>>>>>> >>>>>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>>>>> >>>>>>> 5) remove unsupported platform defs. >>>>>>> >>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>> >>>>>>> Thanks >>>>>>> Yumin >>>>>>> >>>>>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>>>>> Hi, Staffan (and Serguei) >>>>>>>> >>>>>>>> Made some clean for code. >>>>>>>> 1) added mach-o file fat header parsing as you suggested. >>>>>>>> 2) modified get_real_path as you indicated it could run with >>>>>>>> jre/bin/java >>>>>>>> 3) moved output information from CommandProcessor.java to >>>>>>>> PStack.java for printing out pstack not available for Darwin. >>>>>>>> 4) code clean, file header update. >>>>>>>> >>>>>>>> Please take a look at same location. >>>>>>>> >>>>>>>> Thanks >>>>>>>> Yumin >>>>>>>> >>>>>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>>>>> Thanks for doing this Yumin! >>>>>>>>> >>>>>>>>> I tried to apply you patch and run it, but I can't get SA to >>>>>>>>> open a core file. You can see the exception I get below. Is >>>>>>>>> there some kind of setup I need to do? This is against a jvmg >>>>>>>>> build of Hotspot. >>>>>>>>> >>>>>>>>> I also noticed that you forgot to update BugSpotAgent.java >>>>>>>>> with the same changes as in HotspotAgent.java. This makes the >>>>>>>>> jstack tool fail. >>>>>>>>> >>>>>>>>> I will look at the changes more closely. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> /Staffan >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Opening core file, please wait... >>>>>>>>> Unable to open core file >>>>>>>>> /cores/core.79028: >>>>>>>>> >>>>>>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>>>>>> "gHotSpotVMTypes" in >>>>>>>>> remote process) >>>>>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to >>>>>>>>> be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in >>>>>>>>> remote process) >>>>>>>>> at >>>>>>>>> sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>>>>> hsdb> Input stream closed. >>>>>>>>> >>>>>>>>> >>>>>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Please review for the changes for SA to read core file on >>>>>>>>>> Mac OS X, this is feature is not implemented on previous >>>>>>>>>> releases. >>>>>>>>>> This change made for SA to work on core file on Darwin, >>>>>>>>>> but still some function not fixed, such as 'pstack'. This is >>>>>>>>>> intended to integrate into 8. >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>>> >>>>>>>>>> Please take some time since the code change is a little >>>>>>>>>> bigger. >>>>>>>>>> >>>>>>>>>> Thanks very much >>>>>>>>>> Yumin >>>>>>> >>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130312/0f3c4f37/attachment-0001.html From yumin.qi at oracle.com Tue Mar 12 14:09:40 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 12 Mar 2013 14:09:40 -0700 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <513F877B.5010302@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> <513928E7.50404@oracle.com> <51392A70.5040107@oracle.com> <513983AB.8070805@oracle.com> <513F877B.5010302@oracle.com> Message-ID: <513F9994.6030309@oracle.com> Serguei, Thanks. Staffan, can you have a look at the new changes, concern? Thanks Yumin On 3/12/2013 12:52 PM, serguei.spitsyn at oracle.com wrote: > Yumin, > > The updated webrev looks good. > Just some simple cosmetic and debug comments below. > > > *agent/src/os/bsd/MacosxDebuggerLocal.m* > > Nice refactoring! > > 350 /** Only used for core file reading, set thread_id for threads which got after core file parsing. > 351 When parsing core file on Mac OS X, thread context is available but thread id. > 352 We identify them as java threads by checking if a thread's rsp or rbp within a java thread's > 353 stack(stack info is recoreded when it is created). Note Macosx uses unique_thread_id which is > 354 different from other platforms though printed ids are still pthread id. > 355 Function BsdDebuggerLocal.getJavaThreadsInfo returns an array of long integers to host > 356 all java threads' id, stack_start, stack_end as: > 357 [uid0, stack_start0, stack_end0, uid1, stack_start1, stack_end1, ...] > 358 > 359 The work cannot be done at init0 since Threads is not available yet(VM not initialized yet). > 360 This function should be called only once if succeeded */ > It'd be better to start lines 351-360 with the '*'. > The sentence at line 351 is not clear. > > > 393 /* core file only, called from Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_getThreadIntegerRegisterSet0 */ > 394 jlongArray getThreadIntegerRegisterSetFromCore(JNIEnv *env, jobject this_obj, long lwp_id) { > 395 // On Mac OS X, we can not get thread_id from x86Thread_State_t, but they are recorded in JavaThread of JVM > The comment lines 393 and 395 are two long and can be split in two. > > 440 regs[REG_INDEX(RDI)] = gregs.r_rdi; > 441 regs[REG_INDEX(RIP)] = gregs.r_rip; > 442 regs[REG_INDEX(CS)] = gregs.r_cs; > 443 regs[REG_INDEX(RSP)] = gregs.r_rsp; > 444 regs[REG_INDEX(SS)] = gregs.r_ss; > 445 regs[REG_INDEX(FSBASE)] = 0; > 446 regs[REG_INDEX(GSBASE)] = 0; > 447 regs[REG_INDEX(DS)] = gregs.r_ds; > 448 regs[REG_INDEX(ES)] = gregs.r_es; > 449 regs[REG_INDEX(FS)] = gregs.r_fs; > 450 regs[REG_INDEX(GS)] = gregs.r_gs; > 451 regs[REG_INDEX(TRAPNO)] = gregs.r_trapno; > 452 regs[REG_INDEX(RFL)] = gregs.r_rflags; > > At least, the lines 442, 444, 447-450 and 452 can be aligned as 440-441. > > 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! [PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); > The line above is too long. You can split it like this: > 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! " > "[PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); > > *agent/src/os/bsd/Makefile* > > The lines 25 and 55 are too long. > > | > |*agent/src/os/bsd/libproc_impl.c* > > | I see you've fixed many indents in this file. > | > > > || *agent/src/os/bsd/ps_core.c* > > 565 print_debug(" r_r15: 0x%" PRIx64 "\n", threadinfo->regs.r_r15); > 566 print_debug(" r_r14: 0x%" PRIx64 "\n", threadinfo->regs.r_r14); > 567 print_debug(" r_r13: 0x%" PRIx64 "\n", threadinfo->regs.r_r13); > 568 print_debug(" r_r12: 0x%" PRIx64 "\n", threadinfo->regs.r_r12); > 569 print_debug(" r_r11: 0x%" PRIx64 "\n", threadinfo->regs.r_r11); > 570 print_debug(" r_r10: 0x%" PRIx64 "\n", threadinfo->regs.r_r10); > 571 print_debug(" r_r9: 0x%" PRIx64 "\n", threadinfo->regs.r_r9); > 572 print_debug(" r_r8: 0x%" PRIx64 "\n", threadinfo->regs.r_r8); > 573 print_debug(" r_rdi: 0x%" PRIx64 "\n", threadinfo->regs.r_rdi); > 574 print_debug(" r_rsi: 0x%" PRIx64 "\n", threadinfo->regs.r_rsi); > 575 print_debug(" r_rbp: 0x%" PRIx64 "\n", threadinfo->regs.r_rbp); > 576 print_debug(" r_rbx: 0x%" PRIx64 "\n", threadinfo->regs.r_rbx); > 577 print_debug(" r_rdx: 0x%" PRIx64 "\n", threadinfo->regs.r_rdx); > 578 print_debug(" r_rcx: 0x%" PRIx64 "\n", threadinfo->regs.r_rcx); > 579 print_debug(" r_rax: 0x%" PRIx64 "\n", threadinfo->regs.r_rax); > 580 print_debug(" r_fs: 0x%" PRIx32 "\n", threadinfo->regs.r_fs); > 581 print_debug(" r_gs: 0x%" PRIx32 "\n", threadinfo->regs.r_gs); > 582 print_debug(" r_rip 0x%" PRIx64 "\n", threadinfo->regs.r_rip); > 583 print_debug(" r_cs: 0x%" PRIx64 "\n", threadinfo->regs.r_cs); > 584 print_debug(" r_rflags: 0x%" PRIx64 "\n", threadinfo->regs.r_rflags); > 585 print_debug(" r_rsp: 0x%" PRIx64 "\n", threadinfo->regs.r_rsp); > > > The lines can be aligned better and printed info will be more readable too: > 571-572,580-583 > > > 622 print_debug("segment added: %" PRIu64 " 0x%" PRIx64 " %d\n", segcmd.fileoff, segcmd.vmaddr, segcmd.vmsize); > 816 print_debug("map_info %d: vmaddr = 0x%016" PRIx64 " fileoff = %" PRIu64 " vmsize = %" PRIu64 "\n", j, iter->vaddr, iter->offset, iter->memsz); > The print_debug lines are too long. > > > One empty line extra: 272-273. > > > 956 if (read_core_segments(ph) != true) > 957 goto err; > 958 > 959 // allocate and sort maps into map_array, we need to do this > 960 // here because read_shared_lib_info needs to read from debuggee > 961 // address space > 962 if (sort_map_array(ph) != true) > 963 goto err; > 964 > 965 if (read_shared_lib_info(ph) != true) > 966 goto err; > 967 > 968 // sort again because we have added more mappings from shared objects > 969 if (sort_map_array(ph) != true) > 970 goto err; > 971 > 972 if (init_classsharing_workaround(ph) != true) > 973 goto err; > > Probably have to print a debug error message for before "goto err;". > > > Thanks, > Serguei > > On 3/7/13 10:22 PM, Yumin Qi wrote: >> Serguei and Saffan, >> >> Please take look at the same link for new webrev. >> >> Thanks >> Yumin >> >> On 3/7/2013 4:01 PM, serguei.spitsyn at oracle.com wrote: >>> Thank you for making the suggested changes! >>> Serguei >>> >>> On 3/7/13 3:55 PM, Yumin Qi wrote: >>>> Hi, Serguei >>>> >>>> Thanks for the review, I reviewed the part of Pgrab_core, you are >>>> right, I now put the code into two chunks: APPLE and none APPLE. >>>> Will send another webrev for you tonight --- add all your concerns. >>>> >>>> See answers below: >>>> >>>> On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: >>>>> Hi Yumin, >>>>> >>>>> No insisting on refactoring, it is just desirable. :) >>>>> >>>>> * >>>>> agent/src/os/bsd/symtab.c* >>>>> >>>>> Need a cleanup: >>>>> 54 // #define NAMELEN 4096 >>>>> 78 // dysymtab_command dysymtabcmd; >>>>> 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); >>>> Yes, will. >>>>> >>>>> >>>>> This function is too big, it would be nice to factor out some >>>>> of its body fragments as functions: >>>>> 55 struct symtab* build_symtab(int fd) { >>>> Will try to make it nice. >>>>> The line 137 is too long. You can do like this: >>>>> int size = symtabcmd.strsize * sizeof(char); >>>>> if (read(fd, (void *)(symtab->strs), size) != size) { >>>>> Space is missed: >>>>> 145 //fix size >>>>> >>>> OK, will change. >>>>> No point to start new line if similar fragments like that do not >>>>> have it: >>>>> 153 symtab->symbols[i].size = >>>>> 154 symtabcmd.strsize - symtab->symbols[i].size; >>>> Will change. >>>>> Empty line is needed after the structure definition: >>>>> 199 void *c_data; >>>>> 200 }; >>>>> 201 // read symbol table from given fd. >>>>> 202 struct symtab* build_symtab(int fd) { >>>>> >>>> Will change. >>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>> >>>>> Need a consistent indentation (4?) as they are 2 and 3. >>>>> For instance, the BsdDebuggerLocal.java has indent == 4. >>>>> >>>> Will change to 4. >>>> The SA code has no consistent coding style, some place you will see >>>> 3, some place 2 or 4. >>>> For Java code, I will change them to have 4 spaces. For C, have >>>> done some with 2, but still large amount of code ended with 3. >>>> This needs future clean work. >>>>> >>>>> The flag name " newVT" does not match the comments, should it be >>>>> named "oldVT" ? : >>>>> 46 if (newVT) { >>>>> 47 // old C++ ABI >>>>> 48 vt = isDarwin ? "_vt_" : "__vt_"; >>>>> 49 } else { >>>>> 50 // new C++ ABI >>>>> 51 vt = "_ZTV"; >>>>> 52 } >>>> Oh, I see, the comments reversed. >>>>> >>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>> >>>>> Incorrect indent, it must be 4: >>>>> 86 public long getUniqueThreadId() { >>>>> 87 return unique_thread_id; >>>>> 88 } >>>>> >>>> Yes. >>>>> Sorry for paying too much attention to indentation! >>>>> It is because the SA indentation is a real mess. :) >>>>> >>>>> But this project is a nice progress in the SA area! >>>>> In fact, it is a lot of work. >>>>> I bet, you spent a lot of time debugging this code. >>>>> >>>> My work is making SA reading core on Macosx work, now we have a >>>> working version! thanks. >>>> >>>> Yumin >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> On 3/6/13 8:54 AM, Yumin Qi wrote: >>>>>> Thanks, Serguei >>>>>> >>>>>> Will take care what you have indicated but refactoring code for >>>>>> ps_core.c (Pgrab_core). Maybe in future, code cleaning should >>>>>> include this, the better choice I think is regroup code to detail >>>>>> in specific platform, such as with new file ps_core_darwin.c etc >>>>>> but not now. >>>>>> >>>>>> /Yumin >>>>>> >>>>>> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>>>>>> >>>>>>> Hi Yumin, >>>>>>> >>>>>>> >>>>>>> A partial review below. >>>>>>> >>>>>>> * >>>>>>> agent/src/os/bsd/MacosxDebuggerLocal.m >>>>>>> * >>>>>>> >>>>>>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>>>>>> 153 CHECK_EXCEPTION; >>>>>>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>>>>>> 155 "()[J"); >>>>>>> 156 >>>>>>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>>>>>> >>>>>>> Is CHECK_EXCEPTION needed after the line #154? >>>>>>> >>>>>>> The indent is 3 instead of 2: >>>>>>> Lines 360-410, 775-788 >>>>>>> >>>>>>> ||*agent/src/os/bsd/libproc.h* >>>>>>> 36 #ifdef __APPLE__ >>>>>>> . . . >>>>>>> 46 #ifndef bool >>>>>>> 47 typedef int bool; >>>>>>> 48 #define true 1 >>>>>>> 49 #define false 0 >>>>>>> 50 #endif // bool >>>>>>> . . . >>>>>>> 57 #else // __APPLE__ >>>>>>> . . . >>>>>>> 76 // This C bool type must be int for compatibility with BSD calls and >>>>>>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>>>>>> 78 typedef int bool; >>>>>>> 79 #define true 1 >>>>>>> 80 #define false 0 >>>>>>> 81 >>>>>>> 82 #endif // __APPLE__ >>>>>>> The bool, true and false are defined the same way for APPLE and >>>>>>> not APPLE. >>>>>>> Would it make sense to define it just once? >>>>>>> >>>>>>> ||*agent/src/os/bsd/ps_core.c* >>>>>>> >>>>>>> Need a clean up: >>>>>>> 869 // thread_command thrcmd; >>>>>>> >>>>>>> Space is missed after "if", wrong indent at line #873: >>>>>>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>>>>>> 873 goto err; >>>>>>> Lines 893, 1087 are too long. >>>>>>> >>>>>>> The function read_core_segments() is big and not well readable. >>>>>>> Would it make sense to consider to separate some of its >>>>>>> internals as a local functions. >>>>>>> For instance, the lines 921-950 are good candidates for it. >>>>>>> >>>>>>> The indent is 3: >>>>>>> 1015 if (exists(filepath)) { >>>>>>> 1016 strcpy(rpath, filepath); >>>>>>> 1017 return true; >>>>>>> 1018 } >>>>>>> I did not understand the comments, probably, some words are missing: >>>>>>> 1070 mach_header_64 header; // used to check if a file header in segment >>>>>>> . . . >>>>>>> 1110 // this is the file begining to core file. >>>>>>> >>>>>>> >>>>>>> Not consistent, other fragments before used "goto err;" : >>>>>>> 1122 return false; // error >>>>>>> . . . >>>>>>> 1133 return false; >>>>>>> >>>>>>> Too many ifdef'ed fragments with __APPLE__ >>>>>>> Is it possibler to combine them into bigger chunks or refactor >>>>>>> in a different way? >>>>>>> For instance, the function Pgrab_core() is not readable. >>>>>>> It'd be better to have two separated versions of the function >>>>>>> for apple and not apple. >>>>>>> >>>>>>> >>>>>>> Still to review: >>>>>>> >>>>>>> ||*agent/src/os/bsd/symtab.c* >>>>>>> ||*agent/src/os/bsd/symtab.h* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >>>>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >>>>>>> ||*agent/src/share/native/sadis.c* >>>>>>> ||*make/bsd/makefiles/saproc.make* >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Serguei >>>>>>> >>>>>>> >>>>>>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>>>>>> Hi, all >>>>>>>> >>>>>>>> Please review at the new changes. Include >>>>>>>> 1) use unique_thread_id (which is a 64 bit integer on >>>>>>>> Macosx) to identify thread. Add a function in BsdDebuggerLocal >>>>>>>> to call the newly added function BsdThread.getUniqueThreadId to >>>>>>>> get this id. Meanwhile, move the code of forming threadList in >>>>>>>> native part to BsdDebuggerLocal.java since the thread ids of >>>>>>>> all java threads can be obtained from Threads and coding is >>>>>>>> much easier and clear. >>>>>>>> >>>>>>>> 2) To have better performance, get all java thread ids, >>>>>>>> stack infos (stack begin, stack end) into one array of long >>>>>>>> which is decoded in native code and used to set thread ids. >>>>>>>> This save much more time first time to fill java thread ids. >>>>>>>> >>>>>>>> 3) remove DarwinVtblAccess.java which added in last version >>>>>>>> , its functionality moved to BsdVtblAccess.java >>>>>>>> >>>>>>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>>>>>> >>>>>>>> 5) remove unsupported platform defs. >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>> >>>>>>>> Thanks >>>>>>>> Yumin >>>>>>>> >>>>>>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>>>>>> Hi, Staffan (and Serguei) >>>>>>>>> >>>>>>>>> Made some clean for code. >>>>>>>>> 1) added mach-o file fat header parsing as you suggested. >>>>>>>>> 2) modified get_real_path as you indicated it could run with >>>>>>>>> jre/bin/java >>>>>>>>> 3) moved output information from CommandProcessor.java to >>>>>>>>> PStack.java for printing out pstack not available for Darwin. >>>>>>>>> 4) code clean, file header update. >>>>>>>>> >>>>>>>>> Please take a look at same location. >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> Yumin >>>>>>>>> >>>>>>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>>>>>> Thanks for doing this Yumin! >>>>>>>>>> >>>>>>>>>> I tried to apply you patch and run it, but I can't get SA to >>>>>>>>>> open a core file. You can see the exception I get below. Is >>>>>>>>>> there some kind of setup I need to do? This is against a jvmg >>>>>>>>>> build of Hotspot. >>>>>>>>>> >>>>>>>>>> I also noticed that you forgot to update BugSpotAgent.java >>>>>>>>>> with the same changes as in HotspotAgent.java. This makes the >>>>>>>>>> jstack tool fail. >>>>>>>>>> >>>>>>>>>> I will look at the changes more closely. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> /Staffan >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Opening core file, please wait... >>>>>>>>>> Unable to open core file >>>>>>>>>> /cores/core.79028: >>>>>>>>>> >>>>>>>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>>>>>>> "gHotSpotVMTypes" in >>>>>>>>>> remote process) >>>>>>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to >>>>>>>>>> be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in >>>>>>>>>> remote process) >>>>>>>>>> at >>>>>>>>>> sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>>>>>> at >>>>>>>>>> sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>>>>>> hsdb> Input stream closed. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Please review for the changes for SA to read core file >>>>>>>>>>> on Mac OS X, this is feature is not implemented on previous >>>>>>>>>>> releases. >>>>>>>>>>> This change made for SA to work on core file on Darwin, >>>>>>>>>>> but still some function not fixed, such as 'pstack'. This is >>>>>>>>>>> intended to integrate into 8. >>>>>>>>>>> >>>>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>>>> >>>>>>>>>>> Please take some time since the code change is a little >>>>>>>>>>> bigger. >>>>>>>>>>> >>>>>>>>>>> Thanks very much >>>>>>>>>>> Yumin >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130312/cc536c2c/attachment-0001.html From serguei.spitsyn at oracle.com Tue Mar 12 14:12:41 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 12 Mar 2013 14:12:41 -0700 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <513F9994.6030309@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> <513928E7.50404@oracle.com> <51392A70.5040107@oracle.com> <513983AB.8070805@oracle.com> <513F877B.5010302@oracle.com> <513F9994.6030309@oracle.com> Message-ID: <513F9A49.8090906@oracle.com> Yumin, It looks like Staffan is on vacation this week: Vacation: March 11 - 15 Thanks, Serguei On 3/12/13 2:09 PM, Yumin Qi wrote: > Serguei, > > Thanks. > > Staffan, can you have a look at the new changes, concern? > > Thanks > Yumin > On 3/12/2013 12:52 PM, serguei.spitsyn at oracle.com wrote: >> Yumin, >> >> The updated webrev looks good. >> Just some simple cosmetic and debug comments below. >> >> >> *agent/src/os/bsd/MacosxDebuggerLocal.m* >> >> Nice refactoring! >> >> 350 /** Only used for core file reading, set thread_id for threads which got after core file parsing. >> 351 When parsing core file on Mac OS X, thread context is available but thread id. >> 352 We identify them as java threads by checking if a thread's rsp or rbp within a java thread's >> 353 stack(stack info is recoreded when it is created). Note Macosx uses unique_thread_id which is >> 354 different from other platforms though printed ids are still pthread id. >> 355 Function BsdDebuggerLocal.getJavaThreadsInfo returns an array of long integers to host >> 356 all java threads' id, stack_start, stack_end as: >> 357 [uid0, stack_start0, stack_end0, uid1, stack_start1, stack_end1, ...] >> 358 >> 359 The work cannot be done at init0 since Threads is not available yet(VM not initialized yet). >> 360 This function should be called only once if succeeded */ >> It'd be better to start lines 351-360 with the '*'. >> The sentence at line 351 is not clear. >> >> >> 393 /* core file only, called from Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_getThreadIntegerRegisterSet0 */ >> 394 jlongArray getThreadIntegerRegisterSetFromCore(JNIEnv *env, jobject this_obj, long lwp_id) { >> 395 // On Mac OS X, we can not get thread_id from x86Thread_State_t, but they are recorded in JavaThread of JVM >> The comment lines 393 and 395 are two long and can be split in two. >> >> 440 regs[REG_INDEX(RDI)] = gregs.r_rdi; >> 441 regs[REG_INDEX(RIP)] = gregs.r_rip; >> 442 regs[REG_INDEX(CS)] = gregs.r_cs; >> 443 regs[REG_INDEX(RSP)] = gregs.r_rsp; >> 444 regs[REG_INDEX(SS)] = gregs.r_ss; >> 445 regs[REG_INDEX(FSBASE)] = 0; >> 446 regs[REG_INDEX(GSBASE)] = 0; >> 447 regs[REG_INDEX(DS)] = gregs.r_ds; >> 448 regs[REG_INDEX(ES)] = gregs.r_es; >> 449 regs[REG_INDEX(FS)] = gregs.r_fs; >> 450 regs[REG_INDEX(GS)] = gregs.r_gs; >> 451 regs[REG_INDEX(TRAPNO)] = gregs.r_trapno; >> 452 regs[REG_INDEX(RFL)] = gregs.r_rflags; >> >> At least, the lines 442, 444, 447-450 and 452 can be aligned as 440-441. >> >> 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! [PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); >> The line above is too long. You can split it like this: >> 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! " >> "[PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); >> >> *agent/src/os/bsd/Makefile* >> >> The lines 25 and 55 are too long. >> >> | >> |*agent/src/os/bsd/libproc_impl.c* >> >> | I see you've fixed many indents in this file. >> | >> >> >> || *agent/src/os/bsd/ps_core.c* >> >> 565 print_debug(" r_r15: 0x%" PRIx64 "\n", threadinfo->regs.r_r15); >> 566 print_debug(" r_r14: 0x%" PRIx64 "\n", threadinfo->regs.r_r14); >> 567 print_debug(" r_r13: 0x%" PRIx64 "\n", threadinfo->regs.r_r13); >> 568 print_debug(" r_r12: 0x%" PRIx64 "\n", threadinfo->regs.r_r12); >> 569 print_debug(" r_r11: 0x%" PRIx64 "\n", threadinfo->regs.r_r11); >> 570 print_debug(" r_r10: 0x%" PRIx64 "\n", threadinfo->regs.r_r10); >> 571 print_debug(" r_r9: 0x%" PRIx64 "\n", threadinfo->regs.r_r9); >> 572 print_debug(" r_r8: 0x%" PRIx64 "\n", threadinfo->regs.r_r8); >> 573 print_debug(" r_rdi: 0x%" PRIx64 "\n", threadinfo->regs.r_rdi); >> 574 print_debug(" r_rsi: 0x%" PRIx64 "\n", threadinfo->regs.r_rsi); >> 575 print_debug(" r_rbp: 0x%" PRIx64 "\n", threadinfo->regs.r_rbp); >> 576 print_debug(" r_rbx: 0x%" PRIx64 "\n", threadinfo->regs.r_rbx); >> 577 print_debug(" r_rdx: 0x%" PRIx64 "\n", threadinfo->regs.r_rdx); >> 578 print_debug(" r_rcx: 0x%" PRIx64 "\n", threadinfo->regs.r_rcx); >> 579 print_debug(" r_rax: 0x%" PRIx64 "\n", threadinfo->regs.r_rax); >> 580 print_debug(" r_fs: 0x%" PRIx32 "\n", threadinfo->regs.r_fs); >> 581 print_debug(" r_gs: 0x%" PRIx32 "\n", threadinfo->regs.r_gs); >> 582 print_debug(" r_rip 0x%" PRIx64 "\n", threadinfo->regs.r_rip); >> 583 print_debug(" r_cs: 0x%" PRIx64 "\n", threadinfo->regs.r_cs); >> 584 print_debug(" r_rflags: 0x%" PRIx64 "\n", threadinfo->regs.r_rflags); >> 585 print_debug(" r_rsp: 0x%" PRIx64 "\n", threadinfo->regs.r_rsp); >> >> >> The lines can be aligned better and printed info will be more readable too: >> 571-572,580-583 >> >> >> 622 print_debug("segment added: %" PRIu64 " 0x%" PRIx64 " %d\n", segcmd.fileoff, segcmd.vmaddr, segcmd.vmsize); >> 816 print_debug("map_info %d: vmaddr = 0x%016" PRIx64 " fileoff = %" PRIu64 " vmsize = %" PRIu64 "\n", j, iter->vaddr, iter->offset, iter->memsz); >> The print_debug lines are too long. >> >> >> One empty line extra: 272-273. >> >> >> 956 if (read_core_segments(ph) != true) >> 957 goto err; >> 958 >> 959 // allocate and sort maps into map_array, we need to do this >> 960 // here because read_shared_lib_info needs to read from debuggee >> 961 // address space >> 962 if (sort_map_array(ph) != true) >> 963 goto err; >> 964 >> 965 if (read_shared_lib_info(ph) != true) >> 966 goto err; >> 967 >> 968 // sort again because we have added more mappings from shared objects >> 969 if (sort_map_array(ph) != true) >> 970 goto err; >> 971 >> 972 if (init_classsharing_workaround(ph) != true) >> 973 goto err; >> >> Probably have to print a debug error message for before "goto err;". >> >> >> Thanks, >> Serguei >> >> On 3/7/13 10:22 PM, Yumin Qi wrote: >>> Serguei and Saffan, >>> >>> Please take look at the same link for new webrev. >>> >>> Thanks >>> Yumin >>> >>> On 3/7/2013 4:01 PM, serguei.spitsyn at oracle.com wrote: >>>> Thank you for making the suggested changes! >>>> Serguei >>>> >>>> On 3/7/13 3:55 PM, Yumin Qi wrote: >>>>> Hi, Serguei >>>>> >>>>> Thanks for the review, I reviewed the part of Pgrab_core, you >>>>> are right, I now put the code into two chunks: APPLE and none APPLE. >>>>> Will send another webrev for you tonight --- add all your concerns. >>>>> >>>>> See answers below: >>>>> >>>>> On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: >>>>>> Hi Yumin, >>>>>> >>>>>> No insisting on refactoring, it is just desirable. :) >>>>>> >>>>>> * >>>>>> agent/src/os/bsd/symtab.c* >>>>>> >>>>>> Need a cleanup: >>>>>> 54 // #define NAMELEN 4096 >>>>>> 78 // dysymtab_command dysymtabcmd; >>>>>> 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); >>>>> Yes, will. >>>>>> >>>>>> >>>>>> This function is too big, it would be nice to factor out some >>>>>> of its body fragments as functions: >>>>>> 55 struct symtab* build_symtab(int fd) { >>>>> Will try to make it nice. >>>>>> The line 137 is too long. You can do like this: >>>>>> int size = symtabcmd.strsize * sizeof(char); >>>>>> if (read(fd, (void *)(symtab->strs), size) != size) { >>>>>> Space is missed: >>>>>> 145 //fix size >>>>>> >>>>> OK, will change. >>>>>> No point to start new line if similar fragments like that do not >>>>>> have it: >>>>>> 153 symtab->symbols[i].size = >>>>>> 154 symtabcmd.strsize - symtab->symbols[i].size; >>>>> Will change. >>>>>> Empty line is needed after the structure definition: >>>>>> 199 void *c_data; >>>>>> 200 }; >>>>>> 201 // read symbol table from given fd. >>>>>> 202 struct symtab* build_symtab(int fd) { >>>>>> >>>>> Will change. >>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>>> >>>>>> Need a consistent indentation (4?) as they are 2 and 3. >>>>>> For instance, the BsdDebuggerLocal.java has indent == 4. >>>>>> >>>>> Will change to 4. >>>>> The SA code has no consistent coding style, some place you will >>>>> see 3, some place 2 or 4. >>>>> For Java code, I will change them to have 4 spaces. For C, have >>>>> done some with 2, but still large amount of code ended with 3. >>>>> This needs future clean work. >>>>>> >>>>>> The flag name " newVT" does not match the comments, should it be >>>>>> named "oldVT" ? : >>>>>> 46 if (newVT) { >>>>>> 47 // old C++ ABI >>>>>> 48 vt = isDarwin ? "_vt_" : "__vt_"; >>>>>> 49 } else { >>>>>> 50 // new C++ ABI >>>>>> 51 vt = "_ZTV"; >>>>>> 52 } >>>>> Oh, I see, the comments reversed. >>>>>> >>>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>>> >>>>>> Incorrect indent, it must be 4: >>>>>> 86 public long getUniqueThreadId() { >>>>>> 87 return unique_thread_id; >>>>>> 88 } >>>>>> >>>>> Yes. >>>>>> Sorry for paying too much attention to indentation! >>>>>> It is because the SA indentation is a real mess. :) >>>>>> >>>>>> But this project is a nice progress in the SA area! >>>>>> In fact, it is a lot of work. >>>>>> I bet, you spent a lot of time debugging this code. >>>>>> >>>>> My work is making SA reading core on Macosx work, now we have a >>>>> working version! thanks. >>>>> >>>>> Yumin >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>> On 3/6/13 8:54 AM, Yumin Qi wrote: >>>>>>> Thanks, Serguei >>>>>>> >>>>>>> Will take care what you have indicated but refactoring code >>>>>>> for ps_core.c (Pgrab_core). Maybe in future, code cleaning >>>>>>> should include this, the better choice I think is regroup code >>>>>>> to detail in specific platform, such as with new file >>>>>>> ps_core_darwin.c etc but not now. >>>>>>> >>>>>>> /Yumin >>>>>>> >>>>>>> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>>>>>>> >>>>>>>> Hi Yumin, >>>>>>>> >>>>>>>> >>>>>>>> A partial review below. >>>>>>>> >>>>>>>> * >>>>>>>> agent/src/os/bsd/MacosxDebuggerLocal.m >>>>>>>> * >>>>>>>> >>>>>>>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>>>>>>> 153 CHECK_EXCEPTION; >>>>>>>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>>>>>>> 155 "()[J"); >>>>>>>> 156 >>>>>>>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>>>>>>> >>>>>>>> Is CHECK_EXCEPTION needed after the line #154? >>>>>>>> >>>>>>>> The indent is 3 instead of 2: >>>>>>>> Lines 360-410, 775-788 >>>>>>>> >>>>>>>> ||*agent/src/os/bsd/libproc.h* >>>>>>>> 36 #ifdef __APPLE__ >>>>>>>> . . . >>>>>>>> 46 #ifndef bool >>>>>>>> 47 typedef int bool; >>>>>>>> 48 #define true 1 >>>>>>>> 49 #define false 0 >>>>>>>> 50 #endif // bool >>>>>>>> . . . >>>>>>>> 57 #else // __APPLE__ >>>>>>>> . . . >>>>>>>> 76 // This C bool type must be int for compatibility with BSD calls and >>>>>>>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>>>>>>> 78 typedef int bool; >>>>>>>> 79 #define true 1 >>>>>>>> 80 #define false 0 >>>>>>>> 81 >>>>>>>> 82 #endif // __APPLE__ >>>>>>>> The bool, true and false are defined the same way for APPLE and >>>>>>>> not APPLE. >>>>>>>> Would it make sense to define it just once? >>>>>>>> >>>>>>>> ||*agent/src/os/bsd/ps_core.c* >>>>>>>> >>>>>>>> Need a clean up: >>>>>>>> 869 // thread_command thrcmd; >>>>>>>> >>>>>>>> Space is missed after "if", wrong indent at line #873: >>>>>>>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>>>>>>> 873 goto err; >>>>>>>> Lines 893, 1087 are too long. >>>>>>>> >>>>>>>> The function read_core_segments() is big and not well readable. >>>>>>>> Would it make sense to consider to separate some of its >>>>>>>> internals as a local functions. >>>>>>>> For instance, the lines 921-950 are good candidates for it. >>>>>>>> >>>>>>>> The indent is 3: >>>>>>>> 1015 if (exists(filepath)) { >>>>>>>> 1016 strcpy(rpath, filepath); >>>>>>>> 1017 return true; >>>>>>>> 1018 } >>>>>>>> I did not understand the comments, probably, some words are >>>>>>>> missing: >>>>>>>> 1070 mach_header_64 header; // used to check if a file header in segment >>>>>>>> . . . >>>>>>>> 1110 // this is the file begining to core file. >>>>>>>> >>>>>>>> >>>>>>>> Not consistent, other fragments before used "goto err;" : >>>>>>>> 1122 return false; // error >>>>>>>> . . . >>>>>>>> 1133 return false; >>>>>>>> >>>>>>>> Too many ifdef'ed fragments with __APPLE__ >>>>>>>> Is it possibler to combine them into bigger chunks or refactor >>>>>>>> in a different way? >>>>>>>> For instance, the function Pgrab_core() is not readable. >>>>>>>> It'd be better to have two separated versions of the function >>>>>>>> for apple and not apple. >>>>>>>> >>>>>>>> >>>>>>>> Still to review: >>>>>>>> >>>>>>>> ||*agent/src/os/bsd/symtab.c* >>>>>>>> ||*agent/src/os/bsd/symtab.h* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >>>>>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >>>>>>>> ||*agent/src/share/native/sadis.c* >>>>>>>> ||*make/bsd/makefiles/saproc.make* >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Serguei >>>>>>>> >>>>>>>> >>>>>>>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>>>>>>> Hi, all >>>>>>>>> >>>>>>>>> Please review at the new changes. Include >>>>>>>>> 1) use unique_thread_id (which is a 64 bit integer on >>>>>>>>> Macosx) to identify thread. Add a function in BsdDebuggerLocal >>>>>>>>> to call the newly added function BsdThread.getUniqueThreadId >>>>>>>>> to get this id. Meanwhile, move the code of forming threadList >>>>>>>>> in native part to BsdDebuggerLocal.java since the thread ids >>>>>>>>> of all java threads can be obtained from Threads and coding is >>>>>>>>> much easier and clear. >>>>>>>>> >>>>>>>>> 2) To have better performance, get all java thread ids, >>>>>>>>> stack infos (stack begin, stack end) into one array of long >>>>>>>>> which is decoded in native code and used to set thread ids. >>>>>>>>> This save much more time first time to fill java thread ids. >>>>>>>>> >>>>>>>>> 3) remove DarwinVtblAccess.java which added in last >>>>>>>>> version , its functionality moved to BsdVtblAccess.java >>>>>>>>> >>>>>>>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>>>>>>> >>>>>>>>> 5) remove unsupported platform defs. >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> Yumin >>>>>>>>> >>>>>>>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>>>>>>> Hi, Staffan (and Serguei) >>>>>>>>>> >>>>>>>>>> Made some clean for code. >>>>>>>>>> 1) added mach-o file fat header parsing as you suggested. >>>>>>>>>> 2) modified get_real_path as you indicated it could run >>>>>>>>>> with jre/bin/java >>>>>>>>>> 3) moved output information from CommandProcessor.java to >>>>>>>>>> PStack.java for printing out pstack not available for Darwin. >>>>>>>>>> 4) code clean, file header update. >>>>>>>>>> >>>>>>>>>> Please take a look at same location. >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> Yumin >>>>>>>>>> >>>>>>>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>>>>>>> Thanks for doing this Yumin! >>>>>>>>>>> >>>>>>>>>>> I tried to apply you patch and run it, but I can't get SA to >>>>>>>>>>> open a core file. You can see the exception I get below. Is >>>>>>>>>>> there some kind of setup I need to do? This is against a >>>>>>>>>>> jvmg build of Hotspot. >>>>>>>>>>> >>>>>>>>>>> I also noticed that you forgot to update BugSpotAgent.java >>>>>>>>>>> with the same changes as in HotspotAgent.java. This makes >>>>>>>>>>> the jstack tool fail. >>>>>>>>>>> >>>>>>>>>>> I will look at the changes more closely. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> /Staffan >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Opening core file, please wait... >>>>>>>>>>> Unable to open core file >>>>>>>>>>> /cores/core.79028: >>>>>>>>>>> >>>>>>>>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>>>>>>>> "gHotSpotVMTypes" in >>>>>>>>>>> remote process) >>>>>>>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear >>>>>>>>>>> to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" >>>>>>>>>>> in remote process) >>>>>>>>>>> at >>>>>>>>>>> sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>>>>>>> at >>>>>>>>>>> sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>>>>>>> hsdb> Input stream closed. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> Please review for the changes for SA to read core file >>>>>>>>>>>> on Mac OS X, this is feature is not implemented on previous >>>>>>>>>>>> releases. >>>>>>>>>>>> This change made for SA to work on core file on Darwin, >>>>>>>>>>>> but still some function not fixed, such as 'pstack'. This >>>>>>>>>>>> is intended to integrate into 8. >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>>>>> >>>>>>>>>>>> Please take some time since the code change is a >>>>>>>>>>>> little bigger. >>>>>>>>>>>> >>>>>>>>>>>> Thanks very much >>>>>>>>>>>> Yumin >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130312/4235d4e1/attachment-0001.html From bradford.wetmore at oracle.com Tue Mar 12 15:47:46 2013 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Tue, 12 Mar 2013 22:47:46 +0000 Subject: hg: jdk8/tl/jdk: 8009925: Back out AEAD CipherSuites temporarily Message-ID: <20130312224809.7E893480C5@hg.openjdk.java.net> Changeset: 6379415d8fca Author: wetmore Date: 2013-03-12 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6379415d8fca 8009925: Back out AEAD CipherSuites temporarily Reviewed-by: valeriep ! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java ! src/share/classes/sun/security/internal/spec/TlsKeyMaterialParameterSpec.java ! src/share/classes/sun/security/internal/spec/TlsKeyMaterialSpec.java ! src/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java - src/share/classes/sun/security/ssl/Authenticator.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/EngineInputRecord.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/EngineWriter.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/MAC.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ec/TestEC.java ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/sslecc/CipherTest.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java - test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKeyGCM.java ! test/sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java ! test/sun/security/ssl/sanity/interop/CipherTest.java ! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java From alexey.utkin at oracle.com Wed Mar 13 02:29:18 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Wed, 13 Mar 2013 09:29:18 +0000 Subject: hg: jdk8/tl/jdk: 7190897: (fs) Files.isWritable method returns false when the path is writable (win) Message-ID: <20130313093002.3D7E4480E4@hg.openjdk.java.net> Changeset: e497a050e059 Author: uta Date: 2013-03-13 13:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e497a050e059 7190897: (fs) Files.isWritable method returns false when the path is writable (win) Summary: The [GetEffectiveRightsFromAcl] based implementation was changed to the [AccessCheck] based. Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/classes/sun/nio/fs/WindowsSecurity.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c From coleen.phillimore at oracle.com Wed Mar 13 10:28:08 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 13 Mar 2013 17:28:08 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8009836: nsk/regression/b4222717 fails with empty stack trace Message-ID: <20130313172818.76B7E480F4@hg.openjdk.java.net> Changeset: 5939f5953b45 Author: coleenp Date: 2013-03-13 09:10 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5939f5953b45 8009836: nsk/regression/b4222717 fails with empty stack trace Summary: Some zeroing was missed for bug 8003553, causing empty stack traces and Xcom crashes, add back zeroing to metablock Reviewed-by: dholmes, rbackman ! src/share/vm/memory/metablock.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/method.cpp From alan.bateman at oracle.com Wed Mar 13 11:02:17 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 13 Mar 2013 18:02:17 +0000 Subject: hg: jdk8/tl/jdk: 8009751: (se) Selector spin when select, close and interestOps(0) invoked at same time (lnx) Message-ID: <20130313180229.95508480F6@hg.openjdk.java.net> Changeset: e33cbbe21419 Author: alanb Date: 2013-03-13 17:58 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e33cbbe21419 8009751: (se) Selector spin when select, close and interestOps(0) invoked at same time (lnx) Reviewed-by: zhouyx, chegar, robm ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java From fweimer at redhat.com Wed Mar 13 12:17:06 2013 From: fweimer at redhat.com (Florian Weimer) Date: Wed, 13 Mar 2013 20:17:06 +0100 Subject: Official number assignments for JDP In-Reply-To: <5118DE30.4080109@oracle.com> References: <5111208D.1000809@oracle.com> <5112779A.8060500@redhat.com> <511389CE.1080703@oracle.com> <5118C7D3.2090903@redhat.com> <5118DE30.4080109@oracle.com> Message-ID: <5140D0B2.80102@redhat.com> On 02/11/2013 01:04 PM, Dmitry Samersoff wrote: > Thank you for doing it. I'll check with client team what is better for > them. Hi, IANA has just notified me that 7095/UDP is now listed as an official port number for JDP: Florian -- Florian Weimer / Red Hat Product Security Team From dmitry.samersoff at oracle.com Wed Mar 13 12:22:48 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 13 Mar 2013 23:22:48 +0400 Subject: Official number assignments for JDP In-Reply-To: <5140D0B2.80102@redhat.com> References: <5111208D.1000809@oracle.com> <5112779A.8060500@redhat.com> <511389CE.1080703@oracle.com> <5118C7D3.2090903@redhat.com> <5118DE30.4080109@oracle.com> <5140D0B2.80102@redhat.com> Message-ID: <5140D208.2090505@oracle.com> Florian, Thank you very much for doing it. I'll file the CR and change default numbers. -Dmitry On 2013-03-13 23:17, Florian Weimer wrote: > On 02/11/2013 01:04 PM, Dmitry Samersoff wrote: >> Thank you for doing it. I'll check with client team what is better for >> them. > > Hi, > > IANA has just notified me that 7095/UDP is now listed as an official > port number for JDP: > > > > > Florian -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From coleen.phillimore at oracle.com Wed Mar 13 12:26:46 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 13 Mar 2013 19:26:46 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130313192651.2D728480FC@hg.openjdk.java.net> Changeset: 96480359523a Author: coleenp Date: 2013-03-11 14:00 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/96480359523a 8008965: @Contended fails with classes having static fields Summary: Disable @Contended support for static fields Reviewed-by: coleenp, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/classfile/classFileParser.cpp + test/runtime/8003985/Test8003985.java Changeset: d6320e955c89 Author: coleenp Date: 2013-03-13 13:47 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d6320e955c89 Merge From mandy.chung at oracle.com Wed Mar 13 13:41:55 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 13 Mar 2013 20:41:55 +0000 Subject: hg: jdk8/tl/jdk: 8002070: Remove the stack search for a resource bundle for Logger to use Message-ID: <20130313204217.902A648100@hg.openjdk.java.net> Changeset: 94335b6ffb32 Author: jgish Date: 2013-03-13 11:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94335b6ffb32 8002070: Remove the stack search for a resource bundle for Logger to use Summary: The fragile, vulnerable, stack crawling has been eliminated from findResourceBundle(String) Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/LoggerResourceBundleRace.java From joel.franck at oracle.com Wed Mar 13 14:04:41 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Wed, 13 Mar 2013 21:04:41 +0000 Subject: hg: jdk8/tl/langtools: 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error Message-ID: <20130313210446.1ED5948102@hg.openjdk.java.net> Changeset: eb0198033c5c Author: jfranck Date: 2013-03-13 22:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eb0198033c5c 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTarget.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeParameter.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeParameter.out + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeUse.java + test/tools/javac/annotations/repeatingAnnotations/DefaultTargetTypeUse.out + test/tools/javac/annotations/repeatingAnnotations/NoTargetOnContainer.java + test/tools/javac/annotations/repeatingAnnotations/NoTargetOnContainer2.java From coleen.phillimore at oracle.com Wed Mar 13 14:25:11 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 13 Mar 2013 21:25:11 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8009829: CDS: JDK JPRT test fails crash in Symbol::equals() Message-ID: <20130313212513.6DD1F48103@hg.openjdk.java.net> Changeset: 0ede345ec7c9 Author: coleenp Date: 2013-03-13 15:15 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0ede345ec7c9 8009829: CDS: JDK JPRT test fails crash in Symbol::equals() Summary: -Xshare:dump was creating a Symbol in C_heap. There's an assert there that jdk jprt wasn't hitting because it was only done in product Reviewed-by: dholmes, hseigel, iklam ! src/share/vm/classfile/symbolTable.cpp From bhavesh.x.patel at oracle.com Wed Mar 13 14:47:41 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 13 Mar 2013 21:47:41 +0000 Subject: hg: jdk8/tl/langtools: 8009684: Default top left frame should be "All Packages" in the generated javadoc documentation Message-ID: <20130313214744.A7D3448104@hg.openjdk.java.net> Changeset: e0ef84e33167 Author: bpatel Date: 2013-03-13 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e0ef84e33167 8009684: Default top left frame should be "All Packages" in the generated javadoc documentation Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java From dan.xu at oracle.com Wed Mar 13 15:00:40 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Wed, 13 Mar 2013 22:00:40 +0000 Subject: hg: jdk8/tl/jdk: 8001334: Remove use of JVM_* functions from java.io code Message-ID: <20130313220052.0F6B248106@hg.openjdk.java.net> Changeset: ef0c60b93a17 Author: dxu Date: 2013-03-13 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef0c60b93a17 8001334: Remove use of JVM_* functions from java.io code Summary: Replace JVM_* functions with direct system calls in java io area Reviewed-by: alanb, uta, martin ! make/java/nio/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/native/java/io/ObjectOutputStream.c ! src/share/native/java/io/io_util.c ! src/share/native/java/io/io_util.h ! src/solaris/native/common/jdk_util_md.h ! src/solaris/native/java/io/FileDescriptor_md.c ! src/solaris/native/java/io/UnixFileSystem_md.c ! src/solaris/native/java/io/io_util_md.c ! src/solaris/native/java/io/io_util_md.h ! src/windows/native/common/jdk_util_md.h ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h From coleen.phillimore at oracle.com Wed Mar 13 16:52:41 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 13 Mar 2013 23:52:41 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8003419: NPG: Clean up metadata created during class loading if failure Message-ID: <20130313235245.A40BC48112@hg.openjdk.java.net> Changeset: c8b31b461e1a Author: coleenp Date: 2013-03-13 17:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c8b31b461e1a 8003419: NPG: Clean up metadata created during class loading if failure Summary: Store metadata on ClassFileParser instance to be cleaned up by destructor. This enabled some refactoring of the enormous parseClassFile function. Reviewed-by: jmasa, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp From rob.mckenna at oracle.com Wed Mar 13 17:21:29 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 14 Mar 2013 00:21:29 +0000 Subject: hg: jdk8/tl/jdk: 8009650: HttpClient available() check throws SocketException when connection has been closed Message-ID: <20130314002140.CE65748113@hg.openjdk.java.net> Changeset: f5c85c0a9af0 Author: robm Date: 2013-03-14 00:21 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5c85c0a9af0 8009650: HttpClient available() check throws SocketException when connection has been closed Reviewed-by: chegar, khazra, dsamersoff Contributed-by: sdouglas at redhat.com ! src/share/classes/sun/net/www/http/HttpClient.java + test/sun/net/www/http/HttpClient/IsAvailable.java From david.holmes at oracle.com Wed Mar 13 22:51:31 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 14 Mar 2013 05:51:31 +0000 Subject: hg: jdk8/tl: 8009428: Revert changes to $ substitution performed as part of nashorn integration Message-ID: <20130314055131.A82AC48123@hg.openjdk.java.net> Changeset: 19a59a13b3ef Author: dholmes Date: 2013-03-14 01:41 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/19a59a13b3ef 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj ! common/makefiles/MakeBase.gmk From david.holmes at oracle.com Wed Mar 13 22:52:29 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 14 Mar 2013 05:52:29 +0000 Subject: hg: jdk8/tl/jdk: 8009429: Miscellaneous profiles cleanup; ... Message-ID: <20130314055240.BC8A448125@hg.openjdk.java.net> Changeset: 41289b4a1819 Author: dholmes Date: 2013-03-14 01:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41289b4a1819 8009429: Miscellaneous profiles cleanup 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj ! makefiles/CreateJars.gmk ! makefiles/ProfileNames.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt From david.holmes at oracle.com Wed Mar 13 22:52:11 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 14 Mar 2013 05:52:11 +0000 Subject: hg: jdk8/tl/langtools: 8009429: Miscellaneous profiles cleanup Message-ID: <20130314055216.9BF6A48124@hg.openjdk.java.net> Changeset: 82dc1e827c2a Author: dholmes Date: 2013-03-14 01:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/82dc1e827c2a 8009429: Miscellaneous profiles cleanup Reviewed-by: jjg, alanb ! src/share/classes/com/sun/tools/javac/sym/Profiles.java From david.holmes at oracle.com Wed Mar 13 22:58:12 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 14 Mar 2013 15:58:12 +1000 Subject: tl forest update In-Reply-To: <20130314055131.A82AC48123@hg.openjdk.java.net> References: <20130314055131.A82AC48123@hg.openjdk.java.net> Message-ID: <514166F4.1090107@oracle.com> Sorry for the wide distribution but you all see the push messages anyway. I've just pushed a coordinated set of changes to the top-level, langtools and jdk repos in the tl forest. If you use tl you will need to ensure that you update all of these repos to ensure they are in sync. Thanks, David From vicente.romero at oracle.com Thu Mar 14 01:31:30 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 14 Mar 2013 08:31:30 +0000 Subject: hg: jdk8/tl/langtools: 8008582: jtreg failures after conversion of shell tests to Java Message-ID: <20130314083137.5398D4812A@hg.openjdk.java.net> Changeset: 2e21ecd7a5ad Author: vromero Date: 2013-03-14 08:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2e21ecd7a5ad 8008582: jtreg failures after conversion of shell tests to Java Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/ArrayUtils.java ! test/tools/javac/4846262/CheckEBCDICLocaleTest.java ! test/tools/javac/ClassPathTest/ClassPathTest.java ! test/tools/javac/ProtectedInnerClass/ProtectedInnerClassesTest.java ! test/tools/javac/lib/ToolBox.java ! test/tools/javac/links/LinksTest.java ! test/tools/javac/newlines/NewLineTest.java ! test/tools/javah/6257087/T6257087.java ! test/tools/javah/constMacroTest/ConstMacroTest.java ! test/tools/javap/stackmap/StackmapTest.java From yumin.qi at oracle.com Thu Mar 14 03:53:19 2013 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Thu, 14 Mar 2013 10:53:19 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8003348: SA can not read core file on OS Message-ID: <20130314105326.00E164812F@hg.openjdk.java.net> Changeset: 39432a1cefdd Author: minqi Date: 2013-03-14 00:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/39432a1cefdd 8003348: SA can not read core file on OS Summary: Macosx uses Mach-O file format for binary files, not ELF format. Currently SA works on core files on other platforms, t his change enables SA work on core file generated on Darwin. Reviewed-by: sla, sspitsyn Contributed-by: yumin.qi at oracle.com ! agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/os/bsd/Makefile ! agent/src/os/bsd/libproc.h ! agent/src/os/bsd/libproc_impl.c ! agent/src/os/bsd/libproc_impl.h ! agent/src/os/bsd/ps_core.c ! agent/src/os/bsd/symtab.c ! agent/src/os/bsd/symtab.h ! agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java ! agent/src/share/native/sadis.c ! make/bsd/makefiles/saproc.make From yunda.mly at taobao.com Thu Mar 14 03:59:51 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 14 Mar 2013 10:59:51 +0000 Subject: Why the type of GCId in gcTrace.hpp is uint? Message-ID: Hi all, I notice that in gcTrace.hpp the type of GCId is unit, but in trace.xml the type is ULONG. Could someone tell me if there?s a special reason, or it?s just a mistake? Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130314/8ecf2c61/attachment.html From jesper.wilhelmsson at oracle.com Thu Mar 14 08:29:37 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 14 Mar 2013 16:29:37 +0100 Subject: Why the type of GCId in gcTrace.hpp is uint? In-Reply-To: References: Message-ID: <5141ECE1.7000104@oracle.com> Hi Yunda, Thanks for reporting this! It is a bug indeed. I filed CR 8010090 and will fix it asap. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010090 Thanks, /Jesper On 14/3/13 11:59 AM, ??(Yunda) wrote: > Hi all, > > I notice that in gcTrace.hpp > > the type of GCId is unit, but in trace.xml > > the type is ULONG. Could someone tell me if there?s a special reason, or it?s > just a mistake? > > Regards, > > Yunda > > > -------------------------------------------------------------------------------- > > This email (including any attachments) is confidential and may be legally > privileged. If you received this email in error, please delete it immediately > and do not copy it or use it for any purpose or disclose its contents to any > other person. Thank you. > > ???(??????)?????????????????????????????? > ???????????????????????????????????????? From alan.bateman at oracle.com Thu Mar 14 09:55:54 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 14 Mar 2013 16:55:54 +0000 Subject: hg: jdk8/tl/jdk: 8005716: Enhance JNI specification to allow support of static JNI libraries in Embedded JREs Message-ID: <20130314165617.BB6D74814D@hg.openjdk.java.net> Changeset: f010eb1e696f Author: alanb Date: 2013-03-14 16:03 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f010eb1e696f 8005716: Enhance JNI specification to allow support of static JNI libraries in Embedded JREs Reviewed-by: dlong, alanb, mduigou Contributed-by: bill.pittore at oracle.com, bob.vandette at oracle.com ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/System.java ! src/share/javavm/export/jni.h ! src/share/native/common/jni_util.h ! src/share/native/java/lang/ClassLoader.c ! src/solaris/native/common/jni_util_md.c ! src/windows/native/common/jni_util_md.c From alan.bateman at oracle.com Thu Mar 14 10:01:28 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 14 Mar 2013 17:01:28 +0000 Subject: hg: jdk8/tl/jdk: 7183800: TEST_BUG: Update tests to run on Ubuntu 12.04 (localhost is 127.0.1.1) Message-ID: <20130314170139.BAE4D4814E@hg.openjdk.java.net> Changeset: ca9469a15792 Author: alanb Date: 2013-03-14 16:59 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca9469a15792 7183800: TEST_BUG: Update tests to run on Ubuntu 12.04 (localhost is 127.0.1.1) Reviewed-by: alanb, chegar Contributed-by: yiming.wang at oracle.com ! test/java/nio/channels/DatagramChannel/Connect.java ! test/java/nio/channels/DatagramChannel/ConnectedSend.java ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java ! test/javax/management/remote/mandatory/connection/RMIConnectionIdTest.java From mandy.chung at oracle.com Thu Mar 14 10:35:31 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 14 Mar 2013 17:35:31 +0000 Subject: hg: jdk8/tl/langtools: 8005428: Update jdeps to read the same profile information as by javac Message-ID: <20130314173533.D94FC48150@hg.openjdk.java.net> Changeset: fd3fdaff0257 Author: mchung Date: 2013-03-14 10:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fd3fdaff0257 8005428: Update jdeps to read the same profile information as by javac Reviewed-by: alanb ! make/netbeans/langtools/nbproject/project.xml ! src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/Profiles.java ! src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties - src/share/classes/com/sun/tools/jdeps/resources/jdk.properties ! test/tools/jdeps/Basic.java ! test/tools/jdeps/p/Foo.java + test/tools/jdeps/profiles.properties From naoto.sato at oracle.com Thu Mar 14 11:30:25 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Thu, 14 Mar 2013 18:30:25 +0000 Subject: hg: jdk8/tl/jdk: 8008576: Calendar mismatch using Host LocaleProviderAdapter Message-ID: <20130314183045.3F77648151@hg.openjdk.java.net> Changeset: d79503c4c56f Author: naoto Date: 2013-03-14 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d79503c4c56f 8008576: Calendar mismatch using Host LocaleProviderAdapter Reviewed-by: okutsu ! make/java/java/FILES_java.gmk ! src/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/sun/util/locale/LanguageTag.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java + src/share/classes/sun/util/locale/provider/CalendarProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java + src/share/classes/sun/util/spi/CalendarProvider.java ! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c From yunda.mly at taobao.com Thu Mar 14 19:36:25 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Fri, 15 Mar 2013 02:36:25 +0000 Subject: Why the type of GCId in gcTrace.hpp is uint? In-Reply-To: <5141ECE1.7000104@oracle.com> References: <5141ECE1.7000104@oracle.com> Message-ID: Jesper, Thanks. I think you should consider that in trace.xml the type of compileID is INTEGER and the type of javalangthread is JAVALANGTHREAD. Since they all have similar meanings( as an ID), could they be a same type? Regards, Yunda > -----Original Message----- > From: Jesper Wilhelmsson [mailto:jesper.wilhelmsson at oracle.com] > Sent: Thursday, March 14, 2013 11:30 PM > To: ??(Yunda) > Cc: hotspot-gc-dev openjdk.java.net (hotspot-gc-dev at openjdk.java.net); > serviceability-dev at openjdk.java.net > Subject: Re: Why the type of GCId in gcTrace.hpp is uint? > > Hi Yunda, > > Thanks for reporting this! It is a bug indeed. > I filed CR 8010090 and will fix it asap. > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010090 > > Thanks, > /Jesper > > > On 14/3/13 11:59 AM, ??(Yunda) wrote: > > Hi all, > > > > I notice that in gcTrace.hpp > > > are/vm/gc_implementation/shared/gcTrace.hpp> > > the type of GCId is unit, but in trace.xml > > > are/vm/gc_implementation/shared/gcTrace.hpp> > > the type is ULONG. Could someone tell me if there?s a special reason, > > or it?s just a mistake? > > > > Regards, > > > > Yunda > > > > > > ---------------------------------------------------------------------- > > ---------- > > > > This email (including any attachments) is confidential and may be > > legally privileged. If you received this email in error, please delete > > it immediately and do not copy it or use it for any purpose or > > disclose its contents to any other person. Thank you. > > > > ???(??????)?????????????????????? > ???????? > > ??????????????????????????????? > ????????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From robert.field at oracle.com Thu Mar 14 22:55:20 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 15 Mar 2013 05:55:20 +0000 Subject: hg: jdk8/tl/langtools: 8010010: NPE generating serializedLambdaName for nested lambda Message-ID: <20130315055525.7183448174@hg.openjdk.java.net> Changeset: fbbf5376e7e4 Author: rfield Date: 2013-03-14 22:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fbbf5376e7e4 8010010: NPE generating serializedLambdaName for nested lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaLambdaSerialized.java From vicente.romero at oracle.com Fri Mar 15 02:03:49 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 15 Mar 2013 09:03:49 +0000 Subject: hg: jdk8/tl/langtools: 5053846: javac: MethodRef entries are duplicated in the constant pool Message-ID: <20130315090356.3245148179@hg.openjdk.java.net> Changeset: fa24eba012bd Author: vromero Date: 2013-03-15 09:02 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fa24eba012bd 5053846: javac: MethodRef entries are duplicated in the constant pool Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T5053846/MethodRefDupInConstantPoolTest.java From joel.franck at oracle.com Fri Mar 15 05:41:20 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Fri, 15 Mar 2013 12:41:20 +0000 Subject: hg: jdk8/tl/langtools: 8007767: TargetAnnoCombo.java need to be updated to add a new test mode Message-ID: <20130315124125.EF12E4817E@hg.openjdk.java.net> Changeset: 195b71850b56 Author: mnunez Date: 2013-03-15 13:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/195b71850b56 8007767: TargetAnnoCombo.java need to be updated to add a new test mode Reviewed-by: jjg, strarup ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/TargetAnnoCombo.java - test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java From sundararajan.athijegannathan at oracle.com Fri Mar 15 07:01:26 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 15 Mar 2013 14:01:26 +0000 Subject: hg: jdk8/tl/jdk: 8010136: Make jrunscript's init.js to work on nashorn Message-ID: <20130315140149.457B248180@hg.openjdk.java.net> Changeset: 46ad8dfabd5f Author: sundar Date: 2013-03-15 19:30 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ad8dfabd5f 8010136: Make jrunscript's init.js to work on nashorn Reviewed-by: lagergren, hannesw ! src/share/classes/com/sun/tools/script/shell/init.js From krystal.mo at oracle.com Fri Mar 15 10:55:39 2013 From: krystal.mo at oracle.com (Krystal Mo) Date: Fri, 15 Mar 2013 10:55:39 -0700 Subject: Request for Review: JDK-8008796: SA: Oop.iterateFields() should support CompressedKlassPointers again In-Reply-To: <512C17E8.9030702@oracle.com> References: <512C17E8.9030702@oracle.com> Message-ID: <5143609B.9070905@oracle.com> cc'ing hotspot-runtime for a review -------- Original Message -------- Subject: Request for Review: JDK-8008796: SA: Oop.iterateFields() should support CompressedKlassPointers again Date: Mon, 25 Feb 2013 18:03:20 -0800 From: Krystal Mo Organization: Oracle Corporation To: "??(Yunda)" CC: serviceability-dev at openjdk.java.net Hi all, Could I have a review for this small change, please? Webrev: http://cr.openjdk.java.net/~kmo/8008796/webrev.00/ CR: http://bugs.sun.com/view_bug.do?bug_id=8008796 (should be available externally soon) 8008796: SA: Oop.iterateFields() should support CompressedKlassPointers again Summary: add a missing change from JDK-7054512 so that Oop.iterateFields() works with UseCompressedKlassPointers Reviewed-by: ? Contributed-by: yunda.mly at taobao.com Thanks, Kris On 2013/2/25 17:14, ??(Yunda) wrote: > > Kris, > > Thanks a lot! > > Regards, > > Yunda > > *From:*serviceability-dev-bounces at openjdk.java.net > [mailto:serviceability-dev-bounces at openjdk.java.net] *On Behalf Of > *Krystal Mo > *Sent:* Monday, February 25, 2013 7:19 PM > *To:* serviceability-dev at openjdk.java.net > *Subject:* Re: Oop.iterateFields() should support > CompressedKlassPointers again > > Hi Yunda, > > Thanks for fixing this. I actually have the exact same fix for this > problem, along with fixes for some other problems in SA in my local > workspace, but haven't come around to sending it out for public review > yet. > > I think this is just a missed change in JDK-7054512. I have created a > JIRA issue for you: JDK-8008796: SA: Oop.iterateFields() should > support CompressedKlassPointers again. I'll prepare a webrev and send > it out for official review later. > > Thanks, > Kris > > On 2013/2/25 2:58, ??(Yunda) wrote: > > Hi all, > > When I used CLHSDB just now I met this error: > > hsdb> inspect 0x00000000ee255080 > > instance of "java/io/InputStream" @ 0x00000000ee255080 @ > 0x00000000ee255080 (size = 24) > > Exception in thread "main" java.lang.InternalError: unimplemented > > at sun.jvm.hotspot.oops.Oop.iterateFields(Oop.java:151) > > at > sun.jvm.hotspot.oops.Instance.iterateFields(Instance.java:66) > > at sun.jvm.hotspot.oops.Oop.iterate(Oop.java:143) > > at > sun.jvm.hotspot.ui.tree.OopTreeNodeAdapter.getChildCount(OopTreeNodeAdapter.java:65) > > at > sun.jvm.hotspot.CommandProcessor$Command.printNode(CommandProcessor.java:231) > > at > sun.jvm.hotspot.CommandProcessor$24.doit(CommandProcessor.java:1008) > > at > sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:1897) > > at > sun.jvm.hotspot.CommandProcessor.executeCommand(CommandProcessor.java:1867) > > at > sun.jvm.hotspot.CommandProcessor.run(CommandProcessor.java:1747) > > at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:91) > > at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) > > I found it?s caused by the code of > sun.jvm.hotspot.oops.Oop.iterateFields(): > > void iterateFields(OopVisitor visitor, boolean doVMFields) { > > if (doVMFields) { > > visitor.doCInt(mark, true); > > if (VM.getVM().isCompressedKlassPointersEnabled()) { > > *throw new InternalError("unimplemented");* > > } else { > > visitor.doMetadata(klass, true); > > } > > } > > } > > When compressed oops( which is by default) are used an > InternalError of ?unimplemented? will be throwed. But actually it > can be implemented easily by just one line of code: > > visitor.doMetadata(compressedKlass, true); > > I checked the hotspot-rt repo and I found it was implemented this > way before changeset 3601, the main implementation of NPG. Since > 3601 changed a whole lot of stuff, the ?compressedKlass? field > couldn?t get the right value, as in line 51: > > // compressedKlass = new > CIntField(type.getCIntegerField("_metadata._compressed_klass"), 0); > > So the code in iterateFields() was changed to throwing an > InternalError accordingly. > > But the ?compressedKlass? field can get the right value now. So I > think it?s time to change the code back and here?s the diff > against the latest hotspot-rt: > > diff -r 2f881161d085 > agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java > > --- a/agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java Mon > Feb 25 18:25:24 2013 +0800 > > +++ b/agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java Mon > Feb 25 18:47:08 2013 +0800 > > @@ -148,7 +148,7 @@ > > if (doVMFields) { > > visitor.doCInt(mark, true); > > if (VM.getVM().isCompressedKlassPointersEnabled()) { > > - throw new InternalError("unimplemented"); > > + visitor.doMetadata(compressedKlass, true); > > } else { > > visitor.doMetadata(klass, true); > > } > > Regards, > > Yunda > > ------------------------------------------------------------------------ > > > This email (including any attachments) is confidential and may be > legally privileged. If you received this email in error, please > delete it immediately and do not copy it or use it for any purpose > or disclose its contents to any other person. Thank you. > > ???(?? ?? ??)?? ?? ????????????????? > ????????????????????????????????? > ???????????????? > > > ------------------------------------------------------------------------ > > This email (including any attachments) is confidential and may be > legally privileged. If you received this email in error, please delete > it immediately and do not copy it or use it for any purpose or > disclose its contents to any other person. Thank you. > > ???(??????)???????????????????????? > ??????????????????????????? ?? ????? > ???????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130315/a0b99475/attachment-0001.html From roland.westrelin at oracle.com Fri Mar 15 12:43:05 2013 From: roland.westrelin at oracle.com (Roland Westrelin) Date: Fri, 15 Mar 2013 20:43:05 +0100 Subject: Request for Review: JDK-8008796: SA: Oop.iterateFields() should support CompressedKlassPointers again In-Reply-To: <5143609B.9070905@oracle.com> References: <512C17E8.9030702@oracle.com> <5143609B.9070905@oracle.com> Message-ID: <39C7FE57-41CC-4F6E-8FAB-21B7463789F6@oracle.com> It looks good to me. Roland. From coleen.phillimore at oracle.com Fri Mar 15 17:08:01 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Sat, 16 Mar 2013 00:08:01 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8007725: NPG: Klass::restore_unshareable_info() triggers assert(k->java_mirror() == NULL) Message-ID: <20130316000805.5E140481AC@hg.openjdk.java.net> Changeset: 1fc4d4768b90 Author: coleenp Date: 2013-03-15 17:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1fc4d4768b90 8007725: NPG: Klass::restore_unshareable_info() triggers assert(k->java_mirror() == NULL) Summary: Check for exception during SystemDictionary::resolve_instance_class_or_null() and clean up. Reviewed-by: coleenp, acorn, hseigel, minqi Contributed-by: ioi.lam at oracle.com ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/method.cpp From zhengyu.gu at oracle.com Fri Mar 15 21:07:08 2013 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Sat, 16 Mar 2013 04:07:08 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130316040714.8E825481B5@hg.openjdk.java.net> Changeset: 82f49e8e2c28 Author: zgu Date: 2013-03-15 11:53 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/82f49e8e2c28 8009614: nsk/split_verifier/stress/ifelse/ifelse002_30 fails with 'assert((size & (granularity - 1)) == 0) failed: size not aligned to os::vm_allocation_granularity() Summary: Align up vm allocation size to os defined granularity Reviewed-by: dholmes, coleenp ! src/share/vm/memory/metaspace.cpp Changeset: 919a5f9f36a9 Author: zgu Date: 2013-03-15 17:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/919a5f9f36a9 Merge From krystal.mo at oracle.com Fri Mar 15 22:04:57 2013 From: krystal.mo at oracle.com (Krystal Mo) Date: Fri, 15 Mar 2013 22:04:57 -0700 Subject: Request for Review: JDK-8008796: SA: Oop.iterateFields() should support CompressedKlassPointers again In-Reply-To: <39C7FE57-41CC-4F6E-8FAB-21B7463789F6@oracle.com> References: <512C17E8.9030702@oracle.com> <5143609B.9070905@oracle.com> <39C7FE57-41CC-4F6E-8FAB-21B7463789F6@oracle.com> Message-ID: <5143FD79.7040102@oracle.com> Thank you, Roland! - Kris On 2013/3/15 12:43, Roland Westrelin wrote: > It looks good to me. > > Roland. From lana.steuck at oracle.com Sat Mar 16 22:57:41 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sun, 17 Mar 2013 05:57:41 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20130317055750.9B76A481E9@hg.openjdk.java.net> Changeset: c88bb21560cc Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c88bb21560cc Added tag jdk8-b80 for changeset b0224010e2f0 ! .hgtags Changeset: d8d8032d02d7 Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d8d8032d02d7 Added tag jdk8-b81 for changeset c88bb21560cc ! .hgtags From lana.steuck at oracle.com Sat Mar 16 22:57:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sun, 17 Mar 2013 05:57:37 +0000 Subject: hg: jdk8/tl/corba: 11 new changesets Message-ID: <20130317055749.2EB07481E8@hg.openjdk.java.net> Changeset: 2a00aeeb466b Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2a00aeeb466b Added tag jdk8-b80 for changeset 5f3d4a6bdd02 ! .hgtags Changeset: 0ac9424678e7 Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0ac9424678e7 Added tag jdk8-b81 for changeset 2a00aeeb466b ! .hgtags Changeset: 05386b4610e9 Author: lana Date: 2013-03-12 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/05386b4610e9 Merge Changeset: 3c73273667ae Author: coffeys Date: 2012-10-30 17:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3c73273667ae 8000631: Restrict access to class constructor Reviewed-by: alanb, ahgross ! make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk ! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream_1_0.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream_1_0.java ! src/share/classes/com/sun/corba/se/impl/io/FVDCodeBaseImpl.java ! src/share/classes/com/sun/corba/se/impl/io/ValueHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/io/ValueUtility.java ! src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/Util.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java ! src/share/classes/com/sun/corba/se/impl/orbutil/ORBUtility.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java ! src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdFactory.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java + src/share/classes/sun/corba/JavaCorbaAccess.java + src/share/classes/sun/corba/SharedSecrets.java Changeset: 80882eae6279 Author: ngmr Date: 2012-10-30 17:15 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/80882eae6279 8000540: Improve IIOP type reuse management Reviewed-by: alanb, ahgross, coffeys ! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java Changeset: 0ca1fc7c5f44 Author: mbankal Date: 2012-12-17 07:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0ca1fc7c5f44 7141694: Improving CORBA internals Reviewed-by: coffeys, ahgross ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java Changeset: f4f39d873b9a Author: coffeys Date: 2012-11-06 15:50 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/f4f39d873b9a 7201066: Change modifiers on unused fields Reviewed-by: alanb, skoivu ! src/share/classes/com/sun/corba/se/impl/activation/ServerMain.java ! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java ! src/share/classes/com/sun/corba/se/impl/orbutil/ObjectStreamClass_1_3_1.java Changeset: 59bff16bc0bf Author: ewendeli Date: 2013-02-19 21:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/59bff16bc0bf Merge - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java Changeset: 996bd5fd0941 Author: ewendeli Date: 2013-02-25 07:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/996bd5fd0941 Merge - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java Changeset: 7341134e52ff Author: lana Date: 2013-03-12 18:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7341134e52ff Merge - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java - src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java Changeset: 48e1bc77004d Author: lana Date: 2013-03-14 19:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/48e1bc77004d Merge From lana.steuck at oracle.com Sat Mar 16 22:57:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sun, 17 Mar 2013 05:57:37 +0000 Subject: hg: jdk8/tl: 10 new changesets Message-ID: <20130317055738.4ED1E481E7@hg.openjdk.java.net> Changeset: 907a926d3c96 Author: erikj Date: 2013-03-04 16:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/907a926d3c96 8004352: build-infra: Limit JOBS on large machines Reviewed-by: mduigou ! common/autoconf/build-performance.m4 ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/spec.gmk.in ! common/makefiles/JavaCompilation.gmk ! common/makefiles/Main.gmk Changeset: cd7f2c7e2a0e Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cd7f2c7e2a0e Added tag jdk8-b80 for changeset 907a926d3c96 ! .hgtags Changeset: 52741ab7c601 Author: erikj Date: 2013-03-06 10:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/52741ab7c601 8008073: build-infra: Need --with-dxsdk option? And awt/sound -I option additions? Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/autoconf/toolchain_windows.m4 Changeset: 235854886494 Author: katleman Date: 2013-03-11 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/235854886494 Merge Changeset: 145dbc56f931 Author: tbell Date: 2013-03-12 22:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/145dbc56f931 8009819: build-infra: RE jdk8 build forest fails for windows since addition of --with-dxsdk Reviewed-by: katleman ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 0dc28db6525f Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0dc28db6525f Added tag jdk8-b81 for changeset 145dbc56f931 ! .hgtags Changeset: 980ccff2d4f5 Author: lana Date: 2013-03-12 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/980ccff2d4f5 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 22b9a31a92eb Author: lana Date: 2013-03-13 23:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/22b9a31a92eb Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: a69761ae281b Author: lana Date: 2013-03-14 19:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a69761ae281b Merge Changeset: 4984ac509993 Author: lana Date: 2013-03-15 23:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4984ac509993 Merge From lana.steuck at oracle.com Sat Mar 16 22:57:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sun, 17 Mar 2013 05:57:36 +0000 Subject: hg: jdk8/tl/jaxp: 7 new changesets Message-ID: <20130317055802.134E6481EA@hg.openjdk.java.net> Changeset: ef3495555a4c Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ef3495555a4c Added tag jdk8-b80 for changeset 4873a0499bc3 ! .hgtags Changeset: 94000590f01f Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/94000590f01f Added tag jdk8-b81 for changeset ef3495555a4c ! .hgtags Changeset: f4898ff0aff1 Author: joehw Date: 2012-12-12 15:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f4898ff0aff1 8001235: Improve JAXP HTTP handling Reviewed-by: lancea, skoivu ! src/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java Changeset: 3206516132e8 Author: ewendeli Date: 2013-02-19 21:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/3206516132e8 Merge Changeset: 46ce56a4e40f Author: ewendeli Date: 2013-02-25 07:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/46ce56a4e40f Merge Changeset: 8a0cb78fefbc Author: lana Date: 2013-03-12 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8a0cb78fefbc Merge Changeset: d5a58291f09a Author: lana Date: 2013-03-14 19:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d5a58291f09a Merge From lana.steuck at oracle.com Sat Mar 16 22:57:54 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sun, 17 Mar 2013 05:57:54 +0000 Subject: hg: jdk8/tl/langtools: 5 new changesets Message-ID: <20130317055811.0DCBC481EB@hg.openjdk.java.net> Changeset: ed69d087fdfd Author: katleman Date: 2013-03-07 11:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed69d087fdfd Added tag jdk8-b80 for changeset a8227c617684 ! .hgtags Changeset: 58289451d9ed Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58289451d9ed Added tag jdk8-b81 for changeset ed69d087fdfd ! .hgtags Changeset: 39f8eb897ec6 Author: lana Date: 2013-03-12 16:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/39f8eb897ec6 Merge - test/tools/apt/Basics/NullAPF.java - test/tools/apt/Basics/apt.sh - test/tools/apt/verifyVariables.sh - test/tools/javac/4846262/Test.java - test/tools/javac/4846262/Test.out - test/tools/javac/4846262/Test.sh - test/tools/javac/6302184/T6302184.sh - test/tools/javac/ClassPathTest/ClassPathTest.sh - test/tools/javac/ClassPathTest/ClassPathTest1.java - test/tools/javac/ClassPathTest/ClassPathTest2.java - test/tools/javac/ClassPathTest/ClassPathTest3.java - test/tools/javac/ClassPathTest/bar/pkg/ClassPathTestAux2.java - test/tools/javac/ClassPathTest/foo/pkg/ClassPathTestAux1.java - test/tools/javac/ClassPathTest/pkg/ClassPathTestAux3.java - test/tools/javac/ExtDirs/ExtDirTest_1.java - test/tools/javac/ExtDirs/ExtDirTest_2.java - test/tools/javac/ExtDirs/ExtDirTest_3.java - test/tools/javac/ExtDirs/ExtDirs.sh - test/tools/javac/MethodParameters.java - test/tools/javac/MissingInclude.java - test/tools/javac/MissingInclude.sh - test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh - test/tools/javac/ProtectedInnerClass/ProtectedInnerClass_2.java - test/tools/javac/ProtectedInnerClass/p1/ProtectedInnerClass1.java - test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass2.java - test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass3.java - test/tools/javac/T5090006/T5090006.java - test/tools/javac/T5090006/compiler.sh - test/tools/javac/constDebug/ConstDebug.java - test/tools/javac/constDebug/ConstDebug.sh - test/tools/javac/fatalErrors/NoJavaLang.java - test/tools/javac/fatalErrors/NoJavaLang.out - test/tools/javac/fatalErrors/NoJavaLang.sh - test/tools/javac/generics/diamond/T6939780.java - test/tools/javac/generics/diamond/T6939780.out - test/tools/javac/innerClassFile/Driver.sh - test/tools/javac/innerClassFile/x/B.java - test/tools/javac/innerClassFile/x/C.java - test/tools/javac/innerClassFile/y/Main.java - test/tools/javac/innerClassFile/y/R1.java - test/tools/javac/innerClassFile/y/R2.java - test/tools/javac/innerClassFile/y/R3.java - test/tools/javac/javazip/A.java - test/tools/javac/javazip/Test.sh - test/tools/javac/javazip/bad/B.java - test/tools/javac/javazip/good/B.java - test/tools/javac/links/T.java - test/tools/javac/links/b/B.java - test/tools/javac/links/links.sh - test/tools/javac/newlines/Newlines.sh - test/tools/javac/stackmap/T4955930.java - test/tools/javac/stackmap/T4955930.sh - test/tools/javac/unicode/SupplementaryJavaID6.sh - test/tools/javah/6257087/foo.java - test/tools/javah/6257087/foo.sh - test/tools/javah/6257087/foo_bar.h - test/tools/javah/ConstMacroTest.sh - test/tools/javah/MissingParamClassException.java - test/tools/javah/MissingParamClassTest.sh - test/tools/javah/ParamClassTest.java - test/tools/javah/SubClassConsts.java - test/tools/javah/SubClassConsts.out - test/tools/javah/SubClassConsts.win - test/tools/javah/SuperClassConsts.java - test/tools/javap/NotPackagePrivateInterface.java - test/tools/javap/PublicInterfaceTest.sh - test/tools/javap/pathsep.sh - test/tools/javap/stackmap/T6271292.java - test/tools/javap/stackmap/T6271292.out - test/tools/javap/stackmap/T6271292.sh Changeset: 825da6847791 Author: lana Date: 2013-03-14 19:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/825da6847791 Merge Changeset: a3049f4a7987 Author: lana Date: 2013-03-15 23:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a3049f4a7987 Merge From lana.steuck at oracle.com Sat Mar 16 22:58:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sun, 17 Mar 2013 05:58:56 +0000 Subject: hg: jdk8/tl/hotspot: 72 new changesets Message-ID: <20130317060119.D3613481EC@hg.openjdk.java.net> Changeset: be1fbee20765 Author: amurillo Date: 2013-02-22 10:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/be1fbee20765 8008692: new hotspot build - hs25-b21 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1b0dc9f87e75 Author: mgerdin Date: 2013-02-19 18:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b0dc9f87e75 8006753: fix failed for JDK-8002415 White box testing API for HotSpot Summary: Modify WhiteBoxAPI to use interface classes from test/testlibrary instead, add ClassFileInstaller to resolve the boot class path issue Reviewed-by: ctornqvi, dsamersoff, coleenp, kvn ! make/Makefile ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/vm.make - make/bsd/makefiles/wb.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/vm.make - make/linux/makefiles/wb.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/vm.make - make/solaris/makefiles/wb.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make - make/windows/makefiles/wb.make - src/share/tools/whitebox/sun/hotspot/WhiteBox.java - src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java ! src/share/vm/runtime/arguments.cpp ! test/compiler/whitebox/DeoptimizeAllTest.java ! test/compiler/whitebox/DeoptimizeMethodTest.java ! test/compiler/whitebox/IsMethodCompilableTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java ! test/compiler/whitebox/SetDontInlineMethodTest.java ! test/runtime/NMT/AllocTestType.java ! test/runtime/NMT/PrintNMTStatistics.java ! test/runtime/NMT/SummarySanityCheck.java ! test/sanity/WBApi.java ! test/serviceability/ParserTest.java + test/testlibrary/ClassFileInstaller.java + test/testlibrary/whitebox/sun/hotspot/WhiteBox.java + test/testlibrary/whitebox/sun/hotspot/parser/DiagnosticCommand.java Changeset: 4c1d8002ffb1 Author: hseigel Date: 2013-02-20 07:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4c1d8002ffb1 8004495: [parfait] False positive Buffer overflow in hotspot/src/os/linux/vm/os_linux.cpp Summary: Delete the questionable source code because it is for no-longer supported versions of Linux. Reviewed-by: mikael, coleenp ! src/os/linux/vm/os_linux.cpp Changeset: b861c8af2510 Author: hseigel Date: 2013-02-20 07:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b861c8af2510 Merge - make/bsd/makefiles/wb.make - make/linux/makefiles/wb.make - make/solaris/makefiles/wb.make - make/windows/makefiles/wb.make - src/share/tools/whitebox/sun/hotspot/WhiteBox.java - src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java Changeset: b6d5b3e50379 Author: dcubed Date: 2013-02-20 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b6d5b3e50379 6799919: Recursive calls to report_vm_out_of_memory are handled incorrectly Summary: report_vm_out_of_memory() should allow VMError.report_and_die() to handle multiple out of native memory errors. Reviewed-by: dcubed, dholmes, coleenp, acorn Contributed-by: ron.durbin at oracle.com ! src/share/vm/utilities/debug.cpp Changeset: fc64254f5579 Author: zgu Date: 2013-02-21 07:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fc64254f5579 8008071: Crashed in promote_malloc_records() with Kitchensink after 19 days Summary: Added NULL pointer check for arena size record Reviewed-by: sspitsyn, dholmes ! src/share/vm/services/memSnapshot.cpp Changeset: 5ed317b25e23 Author: sla Date: 2013-02-22 10:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ed317b25e23 7165259: Remove BugSpot Reviewed-by: coleenp, mgronlun ! agent/make/Makefile - agent/make/bugspot.bat ! agent/make/marks_notes.html ! agent/src/os/win32/windbg/sawindbg.cpp - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java ! agent/src/share/classes/sun/jvm/hotspot/ui/SAPanel.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js - agent/src/share/native/jvmdi/sa.cpp - agent/src/share/native/jvmdi/sa.dsp - agent/src/share/native/jvmdi/sa.dsw - agent/src/share/native/jvmdi/sa.hpp ! make/sa.files Changeset: f16e75e0cf11 Author: coleenp Date: 2013-02-22 08:36 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f16e75e0cf11 8000797: NPG: is_pseudo_string_at() doesn't work Summary: Zero Symbol* for constant pool strings to indicate pseudo_strings (objects that aren't strings). Clean up JVM_CONSTANT_Object and unused flags. Reviewed-by: sspitsyn, jrose ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/ConstantTag.java ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/generateOopMap.cpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/constantTag.hpp Changeset: 94478a033036 Author: sspitsyn Date: 2013-02-22 10:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/94478a033036 Merge - agent/make/bugspot.bat - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java - agent/src/share/native/jvmdi/sa.cpp - agent/src/share/native/jvmdi/sa.dsp - agent/src/share/native/jvmdi/sa.dsw - agent/src/share/native/jvmdi/sa.hpp - make/bsd/makefiles/wb.make - make/linux/makefiles/wb.make - make/solaris/makefiles/wb.make - make/windows/makefiles/wb.make - src/share/tools/whitebox/sun/hotspot/WhiteBox.java - src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java ! src/share/vm/runtime/arguments.cpp Changeset: ec2eddfed950 Author: rbackman Date: 2013-02-26 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ec2eddfed950 8008340: [sampling] assert(upper->pc_offset() >= pc_offset) failed: sanity Reviewed-by: kvn, sla ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp Changeset: 77f9b6d0126e Author: sspitsyn Date: 2013-02-27 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/77f9b6d0126e Merge - agent/make/bugspot.bat - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java - agent/src/share/native/jvmdi/sa.cpp - agent/src/share/native/jvmdi/sa.dsp - agent/src/share/native/jvmdi/sa.dsw - agent/src/share/native/jvmdi/sa.hpp - make/bsd/makefiles/wb.make - make/linux/makefiles/wb.make - make/solaris/makefiles/wb.make - make/windows/makefiles/wb.make - src/share/tools/whitebox/sun/hotspot/WhiteBox.java - src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java Changeset: 0598674c0056 Author: jwilhelm Date: 2013-02-21 11:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0598674c0056 8008314: Unimplemented() Atomic::load breaks the applications Summary: jlong atomics isn't fully implemented om all 32-bit platforms so we try to avoid it. In this case the atomic add wasn't needed. Reviewed-by: dholmes, dlong ! src/share/vm/runtime/atomic.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: 96c885895d22 Author: johnc Date: 2013-02-22 11:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96c885895d22 8007221: G1: concurrent phase durations do not state the time units ("secs") Summary: Add timer units to concurrent marking phases where the units were missing. Reviewed-by: jmasa, ysr ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: 9a8ee5301f33 Author: brutisso Date: 2013-02-26 11:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9a8ee5301f33 Merge Changeset: f1fb03a251e9 Author: poonam Date: 2013-02-21 23:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f1fb03a251e9 8008546: Wrong G1ConfidencePercent results in GUARANTEE(VARIANCE() > -1.0) FAILED Reviewed-by: brutisso, johnc Contributed-by: vladimir.kempik at oracle.com ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: fd32b88a87e9 Author: poonam Date: 2013-02-23 17:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd32b88a87e9 Merge Changeset: 9289a00709b5 Author: poonam Date: 2013-02-26 08:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9289a00709b5 Merge Changeset: b685ca4f4fb9 Author: ehelin Date: 2013-02-20 16:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b685ca4f4fb9 8008536: Add HotSpot support for printing class loader statistics for JMap Reviewed-by: sla, brutisso + agent/src/share/classes/sun/jvm/hotspot/tools/ClassLoaderStats.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 3d3379aab292 Author: ehelin Date: 2013-02-26 22:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3d3379aab292 Merge - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 9a094d29af19 Author: ehelin Date: 2013-02-06 07:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9a094d29af19 8004924: NPG: jmap -heap output should contain ClassMetaspaceSize value Reviewed-by: stefank, mgerdin ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java + test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java Changeset: b5e03c8ead49 Author: brutisso Date: 2013-02-28 09:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5e03c8ead49 Merge - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 6931f425c517 Author: roland Date: 2013-02-25 14:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6931f425c517 8007294: ReduceFieldZeroing doesn't check for dependent load and can lead to incorrect execution Summary: InitializeNode::can_capture_store() must check that the captured store doesn't overwrite a memory location that is loaded before the store. Reviewed-by: kvn ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/phaseX.cpp + test/compiler/8007294/Test8007294.java Changeset: 706c919d3b56 Author: roland Date: 2013-02-26 12:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/706c919d3b56 8007722: C2: "assert(tp->base() != Type::AnyPtr) failed: not a bare pointer" at machnode.cpp:376 Summary: GetAndSetP's MachNode should capture bottom type. Reviewed-by: kvn ! src/share/vm/adlc/formssel.cpp + test/compiler/8007722/Test8007722.java Changeset: a00ed9736260 Author: drchase Date: 2013-02-26 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a00ed9736260 8007776: Test6852078.java timeouts Summary: if more than 100 seconds and more than 100 iterations have both passed, then exit is allowed. Reviewed-by: kvn ! test/compiler/6852078/Test6852078.java Changeset: 133bf557ef77 Author: iignatyev Date: 2013-02-27 05:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/133bf557ef77 8007439: C2: adding successful message of inlining Reviewed-by: kvn, vlivanov ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/parse.hpp Changeset: b02157cd249f Author: vlivanov Date: 2013-02-27 08:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b02157cd249f Merge Changeset: 338da89b2592 Author: vlivanov Date: 2013-02-28 15:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/338da89b2592 Merge Changeset: df5396524152 Author: amurillo Date: 2013-03-01 04:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df5396524152 Merge - agent/make/bugspot.bat - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/JavaLineNumberInfo.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/Main.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PCFinder.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/PackageScanner.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/RegisterPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTraceEntry.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/StackTracePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/ThreadListPanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/VariablePanel.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/AddressTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/DoubleTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/EnumTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FieldTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/FloatTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/LongTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/bugspot/tree/ObjectTreeNodeAdapter.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/BreakpointEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CIntegerAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/CStringAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/Event.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ExceptionEvent.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/JNIHandleAccessor.java - agent/src/share/classes/sun/jvm/hotspot/livejvm/ServiceabilityAgentJVMDIModule.java - agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java - agent/src/share/native/jvmdi/sa.cpp - agent/src/share/native/jvmdi/sa.dsp - agent/src/share/native/jvmdi/sa.dsw - agent/src/share/native/jvmdi/sa.hpp - make/bsd/makefiles/wb.make - make/linux/makefiles/wb.make - make/solaris/makefiles/wb.make - make/windows/makefiles/wb.make - src/share/tools/whitebox/sun/hotspot/WhiteBox.java - src/share/tools/whitebox/sun/hotspot/parser/DiagnosticCommand.java Changeset: 4a198b201f3c Author: amurillo Date: 2013-03-01 04:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4a198b201f3c Added tag hs25-b21 for changeset df5396524152 ! .hgtags Changeset: fbda7e1dee9a Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fbda7e1dee9a Added tag jdk8-b80 for changeset 4a198b201f3c ! .hgtags Changeset: 7f482030ff64 Author: amurillo Date: 2013-03-01 04:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7f482030ff64 8009226: new hotspot build - hs25-b22 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1f9994892f89 Author: stefank Date: 2013-02-21 17:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1f9994892f89 8008549: NPG: SystemDictionary::find(...) unnecessarily keeps class loaders alive Summary: SystemDictionary::find(...) should not create and register ClassLoaderData objects for class loaders. Reviewed-by: coleenp, acorn Contributed-by: Stefan Karlsson , Erik Helin ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 3c9db54c2660 Author: mikael Date: 2013-02-26 08:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c9db54c2660 8008081: Print outs do not have matching arguments Summary: Corrected formatted prints to have matching arguments, removed dead print_frame_layout function Reviewed-by: sla, dholmes ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/services/memReporter.cpp ! src/share/vm/utilities/numberSeq.cpp Changeset: 05f2fc6b4ea7 Author: dholmes Date: 2013-02-27 04:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/05f2fc6b4ea7 Merge Changeset: 96bd4772ec62 Author: kevinw Date: 2013-02-27 14:02 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96bd4772ec62 8008807: SA: jstack crash when target has mismatched bitness (Linux) Reviewed-by: rbackman, sla, poonam ! agent/src/os/linux/LinuxDebuggerLocal.c Changeset: 698b615a1cde Author: kevinw Date: 2013-02-27 16:40 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/698b615a1cde Merge Changeset: 651919d134f7 Author: kevinw Date: 2013-02-27 22:40 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/651919d134f7 7178741: SA: jstack -m produce UnalignedAddressException in output (Linux) Reviewed-by: poonam, sla ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/x86/LinuxX86CFrame.java Changeset: 5ee250974db9 Author: dcubed Date: 2013-02-27 15:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ee250974db9 8007476: assert(the_owner != NULL) failed: Did not find owning Java thread for lock word address Summary: Make deadlock detection a little more robust in the case of being unable to find the JavaThread associated with an object lock. Reviewed-by: sla, acorn ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/threadService.cpp Changeset: a140cd925462 Author: dcubed Date: 2013-02-28 05:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a140cd925462 Merge Changeset: 63e54c37ac64 Author: simonis Date: 2013-02-27 09:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/63e54c37ac64 8008959: Fix non-PCH build on Linux, Windows and MacOS X Summary: Fix the build without precompiled headers by either including the missing ".inline.hpp" files into the appropriate files or by turning inline-functions declared in header files into ordinary functions in ".cpp" files. Reviewed-by: coleenp, stefank, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.hpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/atomic_bsd_x86.inline.hpp ! src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp ! src/os_cpu/bsd_zero/vm/atomic_bsd_zero.inline.hpp ! src/os_cpu/linux_sparc/vm/atomic_linux_sparc.inline.hpp ! src/os_cpu/linux_x86/vm/atomic_linux_x86.inline.hpp ! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp ! src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/os_cpu/solaris_sparc/vm/orderAccess_solaris_sparc.inline.hpp ! src/os_cpu/solaris_x86/vm/atomic_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/windows_x86/vm/atomic_windows_x86.inline.hpp ! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/oops/symbol.cpp ! src/share/vm/oops/symbol.hpp Changeset: a506ac816f14 Author: coleenp Date: 2013-02-27 07:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a506ac816f14 Merge Changeset: 143973ced9ab Author: coleenp Date: 2013-02-28 18:37 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/143973ced9ab Merge Changeset: 3e83d69c19db Author: dcubed Date: 2013-03-01 15:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3e83d69c19db Merge Changeset: a252e688abcf Author: jmasa Date: 2013-02-01 17:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a252e688abcf 7189971: Implement CMSWaitDuration for non-incremental mode of CMS Reviewed-by: jmasa, johnc, ysr Contributed-by: michal at frajt.eu ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/runtime/globals.hpp Changeset: 0624b9d81255 Author: ehelin Date: 2013-03-04 13:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0624b9d81255 8004172: Update jstat counter names to reflect metaspace changes Reviewed-by: stefank, jmasa ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp Changeset: 27714220e50e Author: johnc Date: 2013-03-04 12:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/27714220e50e 8007036: G1: Too many old regions added to last mixed GC Summary: Stop adding old regions to collection set when the remaining reclaimable bytes reaches, or goes below, G1HeapWastePercent. Changes were also reviewed by Vitaly Davidovich . Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: d778bb46a9a5 Author: erikj Date: 2013-03-04 22:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d778bb46a9a5 8008451: Make mac builds on 10.8 work on 10.7 Reviewed-by: jcoomes, ohair ! make/bsd/makefiles/gcc.make Changeset: c71e15057f1d Author: stefank Date: 2013-03-07 14:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c71e15057f1d Merge Changeset: 7369298bec7e Author: collins Date: 2013-02-27 20:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7369298bec7e 7115383: TEST_BUG: some jtreg tests fail because they explicitly specify -server option Summary: Small changes to hotspot tests to remove "-server" and replace with ${TESTVMOPTS} Reviewed-by: kvn ! test/compiler/6431242/Test.java ! test/compiler/6589834/Test_ia32.java ! test/compiler/6636138/Test1.java ! test/compiler/6636138/Test2.java ! test/compiler/6795161/Test.java ! test/compiler/6946040/TestCharShortByteSwap.java ! test/compiler/7068051/Test7068051.sh ! test/compiler/8000805/Test8000805.java Changeset: 5cf033ff06c4 Author: bpittore Date: 2013-03-01 14:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5cf033ff06c4 Merge Changeset: af5ac43f06e9 Author: jprovino Date: 2013-03-07 10:46 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/af5ac43f06e9 Merge Changeset: 0b8f9c8d2617 Author: jiangli Date: 2013-03-07 10:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b8f9c8d2617 Merge Changeset: 40b7c6b800ab Author: morris Date: 2013-03-01 14:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/40b7c6b800ab 8008327: [parfait] Unitialized variable in hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m Summary: Fix unitialized variable and return value. Reviewed-by: kvn ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: bf06968a8a00 Author: morris Date: 2013-03-04 13:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf06968a8a00 8008559: [parfait] Path through non-void function '_ZN2os15thread_cpu_timeEP6Thread' returns an undefined value Summary: safety checks for non-Apple thread time functions Reviewed-by: kvn ! src/os/bsd/vm/os_bsd.cpp Changeset: c40fbf634c90 Author: morris Date: 2013-03-05 04:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c40fbf634c90 8008574: [parfait] Null pointer deference in hotspot/src/share/vm/runtime/frame.cpp Summary: fix null pointer Reviewed-by: kvn ! src/share/vm/runtime/frame.cpp Changeset: 571076d3c79d Author: shade Date: 2013-03-05 04:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/571076d3c79d 8009120: Fuzz instruction scheduling in HotSpot compilers Reviewed-by: kvn, vlivanov ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/lcm.cpp Changeset: 4f553e24b3b5 Author: vlivanov Date: 2013-03-05 08:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4f553e24b3b5 Merge Changeset: 872b3feace55 Author: morris Date: 2013-03-05 18:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/872b3feace55 8008750: [partfait] Null pointer deference in hotspot/src/share/vm/oops/instanceKlass.hpp Summary: fix null pointer Reviewed-by: kvn, coleenp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 8651f608fea4 Author: roland Date: 2013-03-06 10:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8651f608fea4 8009460: C2compiler crash in machnode::in_regmask(unsigned int) Summary: 7121140 may not correctly break the Allocate -> MemBarStoreStore link Reviewed-by: kvn ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/macro.cpp Changeset: ff55877839bc Author: kvn Date: 2013-03-06 12:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ff55877839bc 8009472: Print additional information for 8004640 failure Summary: dump nodes and types in 8004640 case. Reviewed-by: roland ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/memnode.cpp Changeset: bdb602473679 Author: morris Date: 2013-03-07 14:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bdb602473679 Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: b5bd25d55994 Author: morris Date: 2013-03-07 18:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5bd25d55994 Merge Changeset: dd6350b4abc4 Author: amurillo Date: 2013-03-08 08:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dd6350b4abc4 Merge Changeset: 65b797426a3b Author: amurillo Date: 2013-03-08 08:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/65b797426a3b Added tag hs25-b22 for changeset dd6350b4abc4 ! .hgtags Changeset: f1629878512f Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f1629878512f Added tag jdk8-b81 for changeset 65b797426a3b ! .hgtags Changeset: b95ad0610fef Author: asaha Date: 2012-10-26 09:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b95ad0610fef Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/gc_implementation/parallelScavenge/PSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/ContigPermSpace.java - agent/src/share/classes/sun/jvm/hotspot/memory/PermGen.java - agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/CompiledICHolderKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/KlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodDataKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/TypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/ui/tree/BadOopTreeNodeAdapter.java - make/solaris/makefiles/reorder_COMPILER1_amd64 - make/solaris/makefiles/reorder_COMPILER1_i486 - make/solaris/makefiles/reorder_COMPILER1_sparc - make/solaris/makefiles/reorder_COMPILER1_sparcv9 - make/solaris/makefiles/reorder_COMPILER2_amd64 - make/solaris/makefiles/reorder_COMPILER2_i486 - make/solaris/makefiles/reorder_COMPILER2_sparc - make/solaris/makefiles/reorder_COMPILER2_sparcv9 - make/solaris/makefiles/reorder_CORE_i486 - make/solaris/makefiles/reorder_CORE_sparc - make/solaris/makefiles/reorder_CORE_sparcv9 - make/solaris/makefiles/reorder_TIERED_amd64 - make/solaris/makefiles/reorder_TIERED_i486 - make/solaris/makefiles/reorder_TIERED_sparc - make/solaris/makefiles/reorder_TIERED_sparcv9 - make/solaris/reorder.sh - src/cpu/sparc/vm/dump_sparc.cpp - src/cpu/x86/vm/dump_x86_32.cpp - src/cpu/x86/vm/dump_x86_64.cpp - src/cpu/zero/vm/dump_zero.cpp - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java - src/share/vm/ci/ciArrayKlassKlass.hpp - src/share/vm/ci/ciCPCache.cpp - src/share/vm/ci/ciCPCache.hpp - src/share/vm/ci/ciInstanceKlassKlass.cpp - src/share/vm/ci/ciInstanceKlassKlass.hpp - src/share/vm/ci/ciKlassKlass.cpp - src/share/vm/ci/ciKlassKlass.hpp - src/share/vm/ci/ciMethodKlass.cpp - src/share/vm/ci/ciMethodKlass.hpp - src/share/vm/ci/ciObjArrayKlassKlass.cpp - src/share/vm/ci/ciObjArrayKlassKlass.hpp - src/share/vm/ci/ciTypeArrayKlassKlass.cpp - src/share/vm/ci/ciTypeArrayKlassKlass.hpp ! src/share/vm/compiler/compilerOracle.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.hpp - src/share/vm/memory/classify.cpp - src/share/vm/memory/classify.hpp - src/share/vm/memory/compactPermGen.hpp - src/share/vm/memory/compactingPermGenGen.cpp - src/share/vm/memory/compactingPermGenGen.hpp - src/share/vm/memory/dump.cpp - src/share/vm/memory/permGen.cpp - src/share/vm/memory/permGen.hpp - src/share/vm/memory/restore.cpp - src/share/vm/memory/serialize.cpp - src/share/vm/oops/arrayKlassKlass.cpp - src/share/vm/oops/arrayKlassKlass.hpp - src/share/vm/oops/compiledICHolderKlass.cpp - src/share/vm/oops/compiledICHolderKlass.hpp - src/share/vm/oops/compiledICHolderOop.cpp - src/share/vm/oops/compiledICHolderOop.hpp - src/share/vm/oops/constMethodKlass.cpp - src/share/vm/oops/constMethodKlass.hpp - src/share/vm/oops/constMethodOop.cpp - src/share/vm/oops/constMethodOop.hpp - src/share/vm/oops/constantPoolKlass.cpp - src/share/vm/oops/constantPoolKlass.hpp - src/share/vm/oops/constantPoolOop.cpp - src/share/vm/oops/constantPoolOop.hpp - src/share/vm/oops/cpCacheKlass.cpp - src/share/vm/oops/cpCacheKlass.hpp - src/share/vm/oops/cpCacheOop.cpp - src/share/vm/oops/cpCacheOop.hpp - src/share/vm/oops/instanceKlassKlass.cpp - src/share/vm/oops/instanceKlassKlass.hpp - src/share/vm/oops/klassKlass.cpp - src/share/vm/oops/klassKlass.hpp - src/share/vm/oops/klassOop.cpp - src/share/vm/oops/klassOop.hpp - src/share/vm/oops/methodDataKlass.cpp - src/share/vm/oops/methodDataKlass.hpp - src/share/vm/oops/methodDataOop.cpp - src/share/vm/oops/methodDataOop.hpp - src/share/vm/oops/methodKlass.cpp - src/share/vm/oops/methodKlass.hpp - src/share/vm/oops/methodOop.cpp - src/share/vm/oops/methodOop.hpp - src/share/vm/oops/objArrayKlassKlass.cpp - src/share/vm/oops/objArrayKlassKlass.hpp - src/share/vm/oops/typeArrayKlassKlass.cpp - src/share/vm/oops/typeArrayKlassKlass.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 77443715ec55 Author: kamg Date: 2012-11-05 17:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/77443715ec55 8001307: Modify ACC_SUPER behavior Summary: Disallow non-virtual calls even when ACC_SUPER is absent. Reviewed-by: kvn, acorn ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/runtime/globals.hpp Changeset: b5cb079ecaa4 Author: ewendeli Date: 2013-02-03 22:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5cb079ecaa4 Merge ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 1cabf9c80e84 Author: ewendeli Date: 2013-02-19 21:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1cabf9c80e84 Merge ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/runtime/arguments.cpp Changeset: d4a32a6f8c82 Author: ewendeli Date: 2013-02-25 07:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d4a32a6f8c82 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 11d5942ef9c7 Author: lana Date: 2013-03-12 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11d5942ef9c7 Merge ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5ee744831dcb Author: lana Date: 2013-03-14 19:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ee744831dcb Merge From lana.steuck at oracle.com Sat Mar 16 23:02:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sun, 17 Mar 2013 06:02:56 +0000 Subject: hg: jdk8/tl/jdk: 99 new changesets Message-ID: <20130317062159.EADE2481ED@hg.openjdk.java.net> Changeset: d60a95b95f01 Author: katleman Date: 2013-03-07 11:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d60a95b95f01 Added tag jdk8-b80 for changeset dfb40f066c6c ! .hgtags Changeset: 758db1c4c65c Author: ehelin Date: 2013-03-04 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/758db1c4c65c 8009384: Temporarily disable jstat tests to ease complicated push Reviewed-by: mchung ! test/ProblemList.txt Changeset: aee1c6c52b68 Author: erikj Date: 2013-03-06 16:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aee1c6c52b68 8008073: build-infra: Need --with-dxsdk option? And awt/sound -I option additions? Reviewed-by: tbell ! makefiles/CompileNativeLibraries.gmk Changeset: da8edcfc19af Author: katleman Date: 2013-03-11 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da8edcfc19af Merge Changeset: bc0ca8bc4637 Author: erikj Date: 2013-03-12 15:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc0ca8bc4637 8009695: embedded/GP/RI: This intermittent error happens too often, makes the build unstable, and waste machine Reviewed-by: dholmes, tbell ! make/common/shared/Defs-utils.gmk ! makefiles/Images.gmk Changeset: c0f8022eba53 Author: katleman Date: 2013-03-12 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0f8022eba53 Merge Changeset: 509c45748f3e Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/509c45748f3e Added tag jdk8-b81 for changeset c0f8022eba53 ! .hgtags Changeset: f6eb212081b2 Author: jgodinez Date: 2013-02-14 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6eb212081b2 8008173: [parfait] #1173 Uninitialised variable -- TransformHelper.cpp Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: 4b11045a9c4c Author: jgodinez Date: 2013-02-18 14:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b11045a9c4c 8005191: [parfait] #384 sun/font/layout/LookupProcessor.cpp Null pointer dereference Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/font/layout/LookupProcessor.cpp Changeset: 41008f5cef1a Author: lana Date: 2013-02-19 22:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41008f5cef1a Merge - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java Changeset: d2d7da120c37 Author: jgodinez Date: 2013-02-22 11:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d2d7da120c37 8006110: pageDialog is showing the swing dialog with DialogTypeSelection.NATIVE Reviewed-by: bae, prr ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 99c1f910abcc Author: jgodinez Date: 2013-02-22 13:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99c1f910abcc 8005796: [parfait] Possible uninitialised variable at jdk/src/share/native/sun/java2d/loops/ByteBinary1Bit.c Reviewed-by: prr, vadim, flar Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/loops/AnyByteBinary.h ! src/share/native/sun/java2d/loops/ByteIndexed.h ! src/share/native/sun/java2d/loops/IntArgb.h ! src/share/native/sun/java2d/loops/IntArgbBm.h ! src/share/native/sun/java2d/loops/IntArgbPre.h ! src/share/native/sun/java2d/loops/Ushort4444Argb.h ! src/share/native/sun/java2d/loops/UshortIndexed.h Changeset: 934f5f10107d Author: lana Date: 2013-02-22 11:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/934f5f10107d Merge Changeset: 4fd6048a78c0 Author: lana Date: 2013-02-22 23:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4fd6048a78c0 Merge Changeset: f3368a3fc023 Author: bae Date: 2013-03-05 17:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3368a3fc023 7152608: [macosx] Crash in liblwawt.dylib in AccelGlyphCache_RemoveCellInfo Reviewed-by: jgodinez, ant ! src/macosx/classes/sun/font/CStrike.java ! src/macosx/classes/sun/font/CStrikeDisposer.java ! src/macosx/native/sun/font/AWTStrike.m Changeset: fd8810d50c99 Author: bae Date: 2013-03-07 14:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd8810d50c99 8005530: [lcms] Improve performance of ColorConverOp for default destinations Reviewed-by: prr, jgodinez ! make/sun/cmm/lcms/Makefile ! make/sun/cmm/lcms/mapfile-vers ! makefiles/CompileNativeLibraries.gmk ! makefiles/mapfiles/liblcms/mapfile-vers ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/share/demo/java2d/J2DBench/build.xml + src/share/demo/java2d/J2DBench/resources/cmm_images/img_icc_large.jpg + src/share/demo/java2d/J2DBench/resources/cmm_images/img_icc_medium.jpg + src/share/demo/java2d/J2DBench/resources/cmm_images/img_icc_small.jpg ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/EmbeddedProfileTests.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 8e9b133dcec9 Author: lana Date: 2013-03-12 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e9b133dcec9 Merge Changeset: e6c94a202bfd Author: alexsch Date: 2013-02-15 14:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6c94a202bfd 7173873: JFrame.setDefaultCloseOperation(EXIT_ON_CLOSE) will never lead to SE if EXIT_ON_CLOSE is already set Reviewed-by: malenkov, serb ! src/share/classes/javax/swing/JFrame.java Changeset: 4bf242def958 Author: dingxmin Date: 2013-02-15 15:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bf242def958 8008289: DefaultButtonModel instance keeps stale listeners in html FormView Reviewed-by: malenkov, alexsch ! src/share/classes/javax/swing/text/html/FormView.java + test/javax/swing/text/html/7189299/bug7189299.java Changeset: 88a83b9e9baa Author: kshefov Date: 2013-02-15 17:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a83b9e9baa 8005920: After pressing combination Windows Key and M key, the frame, the instruction and the dialog can't be minimized. Reviewed-by: serb, denis Contributed-by: Vera Akulova ! test/java/awt/Modal/WsDisabledStyle/Winkey/Winkey.java Changeset: 0fe12ecf80b2 Author: pchelko Date: 2013-02-19 11:26 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fe12ecf80b2 8008374: Build failure (NEWBUILD=false) on Mac Summary: Fixed an old build system failure Reviewed-by: art, anthony ! make/sun/lwawt/FILES_export_macosx.gmk Changeset: 5ad0bd367f6d Author: kshefov Date: 2013-02-19 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ad0bd367f6d 8008379: TEST_BUG: Fail automatically with java.lang.NullPointerException. Reviewed-by: serb, anthony + test/java/awt/Modal/ModalDialogMultiscreenTest/ModalDialogMultiscreenTest.java Changeset: a43115c6359d Author: kshefov Date: 2013-02-19 20:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a43115c6359d 8006070: TEST_BUG: Up and down the Y coordinate of the mouse position, the selected item doesn't change for the single list. Reviewed-by: serb, anthony + test/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html + test/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java Changeset: 9bc26b7b8b47 Author: lana Date: 2013-02-19 22:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bc26b7b8b47 Merge - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java Changeset: 73d1efc4710a Author: ant Date: 2013-02-22 15:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73d1efc4710a 8006406: lightweight embedding in other Java UI toolkits Reviewed-by: serb, anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java + src/macosx/classes/sun/lwawt/LWLightweightFramePeer.java ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformComponent.java + src/macosx/classes/sun/lwawt/macosx/CPlatformLWComponent.java + src/macosx/classes/sun/lwawt/macosx/CPlatformLWView.java + src/macosx/classes/sun/lwawt/macosx/CPlatformLWWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/java/awt/peer/FramePeer.java ! src/share/classes/java/awt/peer/WindowPeer.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/HToolkit.java + src/share/classes/sun/awt/LightweightFrame.java ! src/share/classes/sun/awt/SunToolkit.java + src/share/classes/sun/swing/JLightweightFrame.java + src/share/classes/sun/swing/LightweightContent.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java ! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java + src/windows/classes/sun/awt/windows/WLightweightFramePeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h ! src/windows/native/sun/windows/awt_Window.h Changeset: 63bb402d4a6a Author: lana Date: 2013-02-23 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63bb402d4a6a Merge Changeset: d502cc7bcc3d Author: pchelko Date: 2013-02-25 10:17 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d502cc7bcc3d 8006634: Unify LWCToolkit.invokeAndWait() and sun.awt.datatransfer.ToolkitThreadBlockedHandler Summary: Changed the logic for the nested event loops and deleted deadlock detection Reviewed-by: art, denis ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/ApplicationDelegate.m ! src/macosx/native/sun/awt/CClipboard.m ! src/macosx/native/sun/awt/CDropTarget.m ! src/macosx/native/sun/awt/CMenu.m ! src/macosx/native/sun/awt/CMenuBar.m ! src/macosx/native/sun/awt/CMenuItem.m ! src/macosx/native/sun/awt/JavaComponentAccessibility.m ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: e58f0b163f43 Author: denis Date: 2013-02-27 19:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e58f0b163f43 7178079: REGRESSION: Some AWT Drag-n-Drop tests fail since JDK 7u6 b13 Reviewed-by: serb, anthony ! src/macosx/classes/sun/lwawt/macosx/CDropTargetContextPeer.java Changeset: bc914b7f0878 Author: denis Date: 2013-02-27 20:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc914b7f0878 8009158: Incomplete fix for 7178079 Reviewed-by: serb, anthony ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java Changeset: 3dee850e2653 Author: serb Date: 2013-02-28 17:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3dee850e2653 8008660: Failure in 2D Queue Flusher thread on Mac Reviewed-by: swingler, bae ! src/macosx/classes/sun/awt/CGraphicsConfig.java ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java ! src/macosx/classes/sun/lwawt/macosx/CRobot.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/CRobot.m ! src/macosx/native/sun/awt/LWCToolkit.h ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/java2d/opengl/CGLGraphicsConfig.m Changeset: 554d0f41a6ab Author: serb Date: 2013-02-28 20:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/554d0f41a6ab 8003169: [macosx] JVM crash after disconnecting from projector Reviewed-by: anthony, alexsch ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/CGraphicsDevice.m Changeset: 657a02fcaa00 Author: malenkov Date: 2013-03-01 14:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/657a02fcaa00 7163696: JCK Swing interactive test JScrollBarTest0013 fails with Nimbus and GTK L&Fs Reviewed-by: alexsch ! src/share/classes/java/beans/PropertyDescriptor.java ! test/java/beans/Introspector/Test7192955.java Changeset: 5816595a4cdc Author: serb Date: 2013-03-01 15:31 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5816595a4cdc 7194902: [macosx] closed/java/awt/Button/DoubleActionEventTest/DoubleActionEventTest failed since jdk8b49 7181403: Invalid MouseEvent conversion with SwingUtilities.convertMouseEvent Reviewed-by: malenkov, alexsch ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/share/classes/javax/swing/SwingUtilities.java Changeset: 4912a9e3a95e Author: serb Date: 2013-03-01 21:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4912a9e3a95e 7184945: [macosx] NPE in AquaComboBoxUI since jdk7u6b17, jdk8b47 Reviewed-by: malenkov, alexsch ! src/macosx/classes/com/apple/laf/AquaComboBoxUI.java Changeset: 91e17a813483 Author: alexsch Date: 2013-03-06 19:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91e17a813483 6877495: JTextField and JTextArea does not support supplementary characters Reviewed-by: serb, alexp ! src/share/classes/sun/awt/datatransfer/DataTransferer.java + test/sun/awt/datatransfer/SuplementaryCharactersTransferTest.java Changeset: 7962014b1729 Author: mcherkas Date: 2013-03-06 20:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7962014b1729 8007295: Reduce number of warnings in awt classes Reviewed-by: bae, anthony ! src/share/classes/java/awt/CheckboxMenuItem.java ! src/share/classes/java/awt/Cursor.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/Menu.java ! src/share/classes/java/awt/MenuBar.java ! src/share/classes/java/awt/MenuComponent.java ! src/share/classes/java/awt/MenuItem.java ! src/share/classes/java/awt/RenderingHints.java ! src/share/classes/java/awt/datatransfer/Clipboard.java ! src/share/classes/java/awt/dnd/DragGestureEvent.java ! src/share/classes/java/awt/dnd/DragGestureRecognizer.java ! src/share/classes/java/awt/dnd/DragSource.java ! src/share/classes/java/awt/dnd/InvalidDnDOperationException.java ! src/share/classes/java/awt/geom/AffineTransform.java Changeset: f3ffead3069e Author: lana Date: 2013-03-12 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3ffead3069e Merge Changeset: 5880bfd30db1 Author: lana Date: 2013-03-12 16:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5880bfd30db1 Merge - make/tools/javazic/Makefile - make/tools/src/build/tools/javazic/BackEnd.java - make/tools/src/build/tools/javazic/Checksum.java - make/tools/src/build/tools/javazic/DayOfWeek.java - make/tools/src/build/tools/javazic/Gen.java - make/tools/src/build/tools/javazic/GenDoc.java - make/tools/src/build/tools/javazic/Main.java - make/tools/src/build/tools/javazic/Mappings.java - make/tools/src/build/tools/javazic/Month.java - make/tools/src/build/tools/javazic/Rule.java - make/tools/src/build/tools/javazic/RuleDay.java - make/tools/src/build/tools/javazic/RuleRec.java - make/tools/src/build/tools/javazic/Simple.java - make/tools/src/build/tools/javazic/Time.java - make/tools/src/build/tools/javazic/Timezone.java - make/tools/src/build/tools/javazic/Zone.java - make/tools/src/build/tools/javazic/ZoneRec.java - make/tools/src/build/tools/javazic/Zoneinfo.java - src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java - src/share/classes/java/util/function/Block.java - src/share/classes/java/util/function/DoubleBlock.java - src/share/classes/java/util/function/IntBlock.java - src/share/classes/java/util/function/LongBlock.java - test/javax/script/RhinoExceptionTest.java Changeset: 72ffb2bc15bb Author: lana Date: 2013-03-12 18:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72ffb2bc15bb Merge - make/tools/javazic/Makefile - make/tools/src/build/tools/javazic/BackEnd.java - make/tools/src/build/tools/javazic/Checksum.java - make/tools/src/build/tools/javazic/DayOfWeek.java - make/tools/src/build/tools/javazic/Gen.java - make/tools/src/build/tools/javazic/GenDoc.java - make/tools/src/build/tools/javazic/Main.java - make/tools/src/build/tools/javazic/Mappings.java - make/tools/src/build/tools/javazic/Month.java - make/tools/src/build/tools/javazic/Rule.java - make/tools/src/build/tools/javazic/RuleDay.java - make/tools/src/build/tools/javazic/RuleRec.java - make/tools/src/build/tools/javazic/Simple.java - make/tools/src/build/tools/javazic/Time.java - make/tools/src/build/tools/javazic/Timezone.java - make/tools/src/build/tools/javazic/Zone.java - make/tools/src/build/tools/javazic/ZoneRec.java - make/tools/src/build/tools/javazic/Zoneinfo.java - src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java - src/share/classes/java/util/function/Block.java - src/share/classes/java/util/function/DoubleBlock.java - src/share/classes/java/util/function/IntBlock.java - src/share/classes/java/util/function/LongBlock.java ! test/ProblemList.txt - test/javax/script/RhinoExceptionTest.java Changeset: 66a892bb28b7 Author: anthony Date: 2012-10-12 15:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/66a892bb28b7 7173145: Improve in-memory representation of splashscreens Reviewed-by: bae, mschoene ! src/share/native/sun/awt/splashscreen/splashscreen_jpeg.c Changeset: 85bf51db473c Author: xuelei Date: 2012-10-15 07:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85bf51db473c 7192393: Better Checking of order of TLS Messages Summary: Also reviewed by Andrew Gross Reviewed-by: weijun ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java Changeset: 24a3eb2f0553 Author: malenkov Date: 2012-10-15 19:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24a3eb2f0553 7200493: Improve cache handling Reviewed-by: art, ahgross ! src/share/classes/com/sun/beans/finder/MethodFinder.java Changeset: c7c39320bc6c Author: rupashka Date: 2012-10-16 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c7c39320bc6c 7186948: Improve Swing data validation Reviewed-by: art, ahgross ! src/share/classes/javax/swing/UIDefaults.java Changeset: 3c8d0085b094 Author: ksrini Date: 2012-10-16 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c8d0085b094 7186945: Unpack200 improvement Reviewed-by: jrose, jjh, mschoene ! src/share/native/com/sun/java/util/jar/pack/jni.cpp Changeset: 01f67953c057 Author: ksrini Date: 2012-10-16 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01f67953c057 7186957: Improve Pack200 data validation Reviewed-by: jrose, jjh, mschoene ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp Changeset: b0bf41ba1cf8 Author: ksrini Date: 2012-10-16 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0bf41ba1cf8 7186946: Refine unpacker resource usage Reviewed-by: jrose, jjh, mschoene ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java ! src/share/native/com/sun/java/util/jar/pack/jni.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp Changeset: f0bc5a6dff2b Author: ksrini Date: 2012-10-16 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0bc5a6dff2b 7200499: Better data validation for options Reviewed-by: darcy, jjh, mschoene ! src/share/bin/jli_util.h ! src/windows/bin/java_md.c Changeset: 7e19ab4ff5d3 Author: ksrini Date: 2012-10-16 10:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e19ab4ff5d3 7200500: Launcher better input validation Reviewed-by: darcy, jjh, mschoene ! src/share/bin/parse_manifest.c Changeset: 62f3270f03fa Author: dholmes Date: 2012-08-22 21:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62f3270f03fa 6776941: Improve thread pool shutdown Reviewed-by: dl, skoivu ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java Changeset: e7cce63bf293 Author: xuelei Date: 2012-10-22 07:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7cce63bf293 7192392: Better validation of client keys Summary: Also reviewed by Andrew Gross Reviewed-by: vinnie ! src/share/classes/com/sun/crypto/provider/DHKeyAgreement.java ! src/share/classes/sun/security/pkcs11/P11KeyAgreement.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DHClientKeyExchange.java ! src/share/classes/sun/security/ssl/DHCrypt.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java ! src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java - src/share/classes/sun/security/util/KeyLength.java + src/share/classes/sun/security/util/KeyUtil.java ! test/sun/security/mscapi/ShortRSAKeyWithinTLS.java Changeset: 091dd6eb30aa Author: khazra Date: 2012-10-22 11:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/091dd6eb30aa 7186954: Improve connection performance Reviewed-by: chegar, skoivu ! src/share/classes/sun/net/httpserver/ChunkedInputStream.java ! src/share/classes/sun/net/www/http/ChunkedInputStream.java Changeset: c26d42a92bd8 Author: weijun Date: 2012-09-19 12:58 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c26d42a92bd8 8000210: Improve JarFile code quality Reviewed-by: ahgross, xuelei, mschoene ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/sun/security/util/DerIndefLenConverter.java Changeset: a54b61ae6f12 Author: mullan Date: 2012-10-26 15:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a54b61ae6f12 7201068: Better handling of UI elements Reviewed-by: xuelei ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 71ab8d79c6b4 Author: asaha Date: 2012-10-26 10:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71ab8d79c6b4 Merge - src/macosx/classes/sun/awt/SunToolkitSubclass.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/sun/invoke/util/ValueConversions.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: be07910b3fad Author: asaha Date: 2012-10-26 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be07910b3fad Merge Changeset: e14221289076 Author: dsamersoff Date: 2012-10-30 17:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e14221289076 8000539: JMX implementation allows invocation of methods of a system class Summary: Added extra packageAccess check call Reviewed-by: ahgross, dfuchs Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java Changeset: 64440cc2ea8b Author: mchung Date: 2012-11-02 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64440cc2ea8b 7197546: (proxy) Reflect about creating reflective proxies Reviewed-by: alanb, jdn, jrose ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! test/java/rmi/server/RMIClassLoader/loadProxyClasses/security.policy Changeset: f936be5be1e7 Author: rupashka Date: 2012-11-06 15:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f936be5be1e7 7200491: Tighten up JTable layout code Reviewed-by: art, skoivu ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java Changeset: 3069b91ff041 Author: chegar Date: 2012-11-07 14:26 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3069b91ff041 7201071: InetSocketAddress serialization issue Reviewed-by: alanb, michaelm, skoivu ! src/share/classes/java/net/InetSocketAddress.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c ! src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c ! test/java/nio/channels/DatagramChannel/SendToUnresolved.java Changeset: 69fd15e0437d Author: smarks Date: 2012-11-08 15:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69fd15e0437d 7201070: Serialization to conform to protocol Reviewed-by: dmocek, ahgross, skoivu ! src/share/classes/java/io/ObjectInputStream.java Changeset: 9097b6ec0ecd Author: ksrini Date: 2012-11-09 14:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9097b6ec0ecd 8002091: tools/launcher/ToolsOpts.java test started to fail since 7u11 b01 on Windows Reviewed-by: darcy, jjh, mschoene ! src/share/bin/jli_util.h ! src/windows/bin/java_md.c ! test/tools/launcher/ToolsOpts.java Changeset: 7bc8d5a63d9e Author: bagiras Date: 2012-11-15 23:03 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bc8d5a63d9e 7192977: Issue in toolkit thread Reviewed-by: skoivu, rupashka, art ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/Window.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/sun/applet/AppletPanel.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java Changeset: 09e2dcd476cf Author: bae Date: 2012-11-16 11:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09e2dcd476cf 8001972: Improve image processing Reviewed-by: prr, ahgross ! src/share/classes/sun/awt/image/ByteComponentRaster.java ! src/share/classes/sun/awt/image/ByteInterleavedRaster.java ! src/share/classes/sun/awt/image/ShortComponentRaster.java ! src/share/classes/sun/awt/image/ShortInterleavedRaster.java ! src/share/native/sun/awt/image/awt_parseImage.c ! src/share/native/sun/awt/medialib/safe_alloc.h Changeset: 1b616e1ca09c Author: dmocek Date: 2012-11-19 13:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b616e1ca09c 6563318: RMI data sanitization Reviewed-by: ahgross, hawtin, mchung, smarks ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java ! test/java/rmi/testlibrary/JavaVM.java Changeset: aa8717a5c9cd Author: dmocek Date: 2012-11-19 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aa8717a5c9cd 8001242: Improve RMI HTTP conformance Reviewed-by: ahgross, mchung, smarks ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java ! src/share/classes/sun/rmi/transport/proxy/HttpInputStream.java Changeset: ecedf46ae7db Author: bae Date: 2012-11-20 11:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecedf46ae7db 8002325: Improve management of images Reviewed-by: prr, ahgross ! src/share/native/sun/awt/image/awt_parseImage.c ! src/share/native/sun/awt/image/awt_parseImage.h Changeset: eda84d5738e3 Author: denis Date: 2012-11-26 20:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eda84d5738e3 7186952: Improve clipboard access Reviewed-by: serb, ahgross ! src/share/classes/java/awt/TextComponent.java ! src/windows/native/sun/windows/awt_TextComponent.cpp ! src/windows/native/sun/windows/awt_TextComponent.h Changeset: d1668eca22bf Author: mchung Date: 2012-11-26 22:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1668eca22bf 6664509: Add logging context 6664528: Find log level matching its name or value given at construction time Reviewed-by: alanb, ahgross, jgish, hawtin ! src/share/classes/java/util/logging/Level.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/logging/LoggingProxyImpl.java ! src/share/classes/java/util/logging/SimpleFormatter.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/misc/JavaAWTAccess.java ! src/share/lib/security/java.security Changeset: b8ee2e9ff7e3 Author: denis Date: 2012-11-30 15:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8ee2e9ff7e3 7201064: Better dialogue checking Reviewed-by: serb, skoivu ! src/share/classes/java/awt/Dialog.java Changeset: 90bbdae7aaa4 Author: ewendeli Date: 2013-02-03 23:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90bbdae7aaa4 Merge ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/logging/LoggingProxyImpl.java ! src/share/classes/java/util/logging/SimpleFormatter.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java ! src/share/classes/sun/rmi/transport/proxy/HttpInputStream.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DHClientKeyExchange.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java - src/share/classes/sun/security/util/KeyLength.java ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c ! src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c ! test/java/rmi/testlibrary/JavaVM.java Changeset: cc2057f84eb7 Author: mchung Date: 2012-12-05 14:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc2057f84eb7 8004175: Restricted packages added in java.security are missing in java.security-{macosx, solaris, windows} Reviewed-by: alanb, ahgross, mullan ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 89e43b8940c9 Author: dsamersoff Date: 2012-12-07 22:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89e43b8940c9 8000537: Contextualize RequiredModelMBean class Summary: Contextualize RequiredModelMBean class Reviewed-by: asaha Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java Changeset: 7933c80c162a Author: denis Date: 2012-12-12 21:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7933c80c162a 8004341: Two JCK tests fails with 7u11 b06 Reviewed-by: serb, skoivu ! src/share/classes/java/awt/Dialog.java Changeset: ed08394e1a15 Author: mullan Date: 2012-12-18 13:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ed08394e1a15 8004302: javax/xml/soap/Test7013971.java fails since jdk6u39b01 Reviewed-by: vinnie, skoivu, mgrebac, ohair, tbell ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/Makefile Changeset: 32cd4975d2d6 Author: mchung Date: 2013-01-10 19:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32cd4975d2d6 8005615: Java Logger fails to load tomcat logger implementation (JULI) Reviewed-by: alanb, ahgross ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/CustomLogManager.java + test/java/util/logging/CustomLogManagerTest.java + test/java/util/logging/SimpleLogManager.java Changeset: c0fbd737aef0 Author: ewendeli Date: 2013-01-28 11:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0fbd737aef0 8006864: Update java.security-linux to include changes in java.security Reviewed-by: mchung, mullan ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 12491fa16985 Author: ewendeli Date: 2013-02-05 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12491fa16985 Merge ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/java/lang/Class.java - src/share/classes/sun/security/util/KeyLength.java Changeset: de419ea8ed8f Author: mchung Date: 2013-01-28 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de419ea8ed8f 8006882: Proxy generated classes in sun.proxy package breaks JMockit Reviewed-by: alanb, ahgross ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 8effe3b7489d Author: dfuchs Date: 2013-01-30 11:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8effe3b7489d 8006446: Restrict MBeanServer access Reviewed-by: alanb, mchung, darcy, jrose, ahgross, skoivu ! src/share/classes/com/sun/jmx/mbeanserver/ClassLoaderRepositorySupport.java ! src/share/classes/com/sun/jmx/mbeanserver/JmxMBeanServer.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanSupport.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation2Test.java ! test/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation3Test.java Changeset: ebfb0bb58428 Author: mchung Date: 2013-01-24 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebfb0bb58428 8004937: Improve proxy construction Reviewed-by: jrose, ahgross ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandleProxies.java Changeset: af11c227a91e Author: mchung Date: 2013-02-05 22:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af11c227a91e 8007393: Possible race condition after JDK-6664509 Reviewed-by: alanb, jgish ! src/share/classes/java/util/logging/LogManager.java Changeset: 1143bb5e7064 Author: mchung Date: 2013-02-07 09:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1143bb5e7064 8007611: logging behavior in applet changed Reviewed-by: alanb, jgish ! src/share/classes/java/util/logging/LogManager.java Changeset: 5925630b7a7d Author: xuelei Date: 2013-02-07 16:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5925630b7a7d 8006777: Improve TLS handling of invalid messages Reviewed-by: wetmore, ahgross ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/EngineInputRecord.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/MAC.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: d57363ff612f Author: valeriep Date: 2013-02-07 16:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d57363ff612f 8007688: Blacklist known bad certificate Summary: Added two known bad certs to the blacklist certs. Reviewed-by: mullan ! src/share/classes/sun/security/util/UntrustedCertificates.java Changeset: c18aeb4ca957 Author: ewendeli Date: 2013-02-19 21:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c18aeb4ca957 Merge ! src/share/bin/parse_manifest.c ! src/share/classes/java/lang/Class.java - src/share/classes/sun/security/util/KeyLength.java ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/sun/awt/image/awt_parseImage.c ! test/Makefile Changeset: f7fb3de623ba Author: ewendeli Date: 2013-02-19 21:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fb3de623ba Merge Changeset: f686c8e3c8e0 Author: ewendeli Date: 2013-02-25 08:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f686c8e3c8e0 Merge ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/logging/LogManager.java - src/share/classes/sun/security/util/KeyLength.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp Changeset: e3cac5962e32 Author: vlivanov Date: 2013-02-22 03:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3cac5962e32 8006439: Improve MethodHandles coverage Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandles.java Changeset: 62be74f35886 Author: vlivanov Date: 2013-02-22 03:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62be74f35886 8006179: JSR292 MethodHandles lookup with interface using findVirtual() Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/DirectMethodHandle.java Changeset: 9995881dfb4e Author: vlivanov Date: 2013-02-22 02:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9995881dfb4e 8006125: Update MethodHandles library interactions Reviewed-by: jrose ! src/share/classes/sun/reflect/misc/MethodUtil.java Changeset: 0807820fca96 Author: vlivanov Date: 2013-02-22 02:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0807820fca96 8004933: Improve MethodHandle interaction with libraries Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: ae1fed8d80e1 Author: ewendeli Date: 2013-02-26 06:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae1fed8d80e1 Merge - src/share/classes/sun/security/util/KeyLength.java Changeset: 5e4c2d7f3b67 Author: ewendeli Date: 2013-02-26 20:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e4c2d7f3b67 Merge ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandles.java - src/share/classes/sun/security/util/KeyLength.java Changeset: 4d4848124bff Author: ewendeli Date: 2013-02-27 09:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d4848124bff Merge - src/share/classes/sun/security/util/KeyLength.java Changeset: 36ff48ae6ffe Author: ewendeli Date: 2013-02-27 18:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36ff48ae6ffe Merge - src/share/classes/sun/security/util/KeyLength.java Changeset: 931fb59eae26 Author: lana Date: 2013-03-12 19:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/931fb59eae26 Merge ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/lang/Class.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/EngineInputRecord.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/MAC.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java - src/share/classes/sun/security/util/KeyLength.java ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java Changeset: 9528e88f8d53 Author: lana Date: 2013-03-13 23:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9528e88f8d53 Merge - make/tools/javazic/Makefile - make/tools/src/build/tools/javazic/BackEnd.java - make/tools/src/build/tools/javazic/Checksum.java - make/tools/src/build/tools/javazic/DayOfWeek.java - make/tools/src/build/tools/javazic/Gen.java - make/tools/src/build/tools/javazic/GenDoc.java - make/tools/src/build/tools/javazic/Main.java - make/tools/src/build/tools/javazic/Mappings.java - make/tools/src/build/tools/javazic/Month.java - make/tools/src/build/tools/javazic/Rule.java - make/tools/src/build/tools/javazic/RuleDay.java - make/tools/src/build/tools/javazic/RuleRec.java - make/tools/src/build/tools/javazic/Simple.java - make/tools/src/build/tools/javazic/Time.java - make/tools/src/build/tools/javazic/Timezone.java - make/tools/src/build/tools/javazic/Zone.java - make/tools/src/build/tools/javazic/ZoneRec.java - make/tools/src/build/tools/javazic/Zoneinfo.java ! makefiles/CompileNativeLibraries.gmk ! makefiles/Images.gmk - src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java - src/share/classes/java/util/function/Block.java - src/share/classes/java/util/function/DoubleBlock.java - src/share/classes/java/util/function/IntBlock.java - src/share/classes/java/util/function/LongBlock.java - src/share/classes/sun/security/util/KeyLength.java - test/javax/script/RhinoExceptionTest.java Changeset: f282190e931a Author: lana Date: 2013-03-14 19:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f282190e931a Merge Changeset: c1a142965db0 Author: lana Date: 2013-03-15 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1a142965db0 Merge ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/java/util/logging/Logger.java - src/share/classes/sun/security/util/KeyLength.java From chris.hegarty at oracle.com Sun Mar 17 01:36:24 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sun, 17 Mar 2013 08:36:24 +0000 Subject: hg: jdk8/tl/jdk: 8009222: java.lang.IllegalArgumentException: not invocable, no method type when attempting to get getter method handle for a static field Message-ID: <20130317083702.33312481F1@hg.openjdk.java.net> Changeset: c1165d566a23 Author: vlivanov Date: 2013-03-06 16:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1165d566a23 8009222: java.lang.IllegalArgumentException: not invocable, no method type when attempting to get getter method handle for a static field Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/DirectMethodHandle.java + test/java/lang/invoke/8009222/Test8009222.java From chris.hegarty at oracle.com Sun Mar 17 02:56:52 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sun, 17 Mar 2013 09:56:52 +0000 Subject: hg: jdk8/tl/jdk: 8010142: ProblemList.txt updates (3/2013) Message-ID: <20130317095730.7A3E3481F2@hg.openjdk.java.net> Changeset: ec8229b26dbc Author: chegar Date: 2013-03-17 09:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec8229b26dbc 8010142: ProblemList.txt updates (3/2013) Reviewed-by: alanb ! test/ProblemList.txt From daniel.daugherty at oracle.com Sun Mar 17 12:09:28 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sun, 17 Mar 2013 19:09:28 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 38 new changesets Message-ID: <20130317191045.11E81481FE@hg.openjdk.java.net> Changeset: fad90b102190 Author: jprovino Date: 2013-03-06 13:38 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fad90b102190 8008310: Some adjustments needed to minimal VM warnings and errors for unsupported command line options Summary: Changes to arguments.cpp for warnings vs. errors. Changes for CDS arguments. Reviewed-by: coleenp, cjplummer ! make/excludeSrc.make ! src/share/vm/memory/filemap.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 47bc9800972c Author: jprovino Date: 2013-03-06 13:46 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/47bc9800972c 8006498: #if is wrong in the code. Summary: ASSERT and other symbols used incorrectly with #if are supposed to be defined or not. Reviewed-by: dholmes, mikael ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.hpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/code/compressedStream.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiTrace.hpp Changeset: 67342b960b47 Author: jprovino Date: 2013-03-06 13:50 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/67342b960b47 8008474: Add -Wundef to warning flags. Summary: Force use of undefined macros to be and error. Reviewed-by: dholmes, mikael ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/gcc.make Changeset: cb75b67f04fb Author: jprovino Date: 2013-03-08 12:35 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cb75b67f04fb Merge ! make/bsd/makefiles/gcc.make Changeset: 69ffa4ac9e53 Author: jprovino Date: 2013-03-12 00:02 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/69ffa4ac9e53 8009835: Only produce a warning when -Xshare:auto is explicitly requested Summary: The minimal JVM is printing a warning message for default settings when it should quitely ignore them. Reviewed-by: coleenp, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 9102c4111564 Author: jprovino Date: 2013-03-14 10:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9102c4111564 Merge Changeset: ed53b50794d7 Author: vladidan Date: 2013-03-14 12:49 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ed53b50794d7 Merge Changeset: 0094485b46c7 Author: roland Date: 2013-03-13 09:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0094485b46c7 8009761: Deoptimization on sparc doesn't set Llast_SP correctly in the interpreter frames it creates Summary: deoptimization doesn't set up callee frames so that they restore caller frames correctly. Reviewed-by: kvn ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/runtime/vframeArray.hpp + test/compiler/8009761/Test8009761.java Changeset: 056ab43544a4 Author: neliasso Date: 2013-03-13 10:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/056ab43544a4 8009721: Make PhaseLive independent from regalloc Summary: Moved class definition of LRG_List from chaitin.hpp to live.hpp Reviewed-by: kvn, rbackman, roland Contributed-by: niclas.adlertz at oracle.com ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/live.hpp Changeset: 6d98efabf3ba Author: neliasso Date: 2013-03-13 13:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6d98efabf3ba Merge Changeset: b7c2c5b2572c Author: neliasso Date: 2013-02-13 10:25 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b7c2c5b2572c 8005772: Stubs report compile id -1 in phase events Summary: Use 0 to indicate id is NA, -1 for error or uninitalized Reviewed-by: kvn, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/compile.cpp Changeset: 71f13276159d Author: morris Date: 2013-03-14 07:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/71f13276159d 8008560: [parfait] Null pointer deference in hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Summary: add null pointer check in signal handler Reviewed-by: kvn ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: fba788946616 Author: morris Date: 2013-03-14 16:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fba788946616 Merge Changeset: 9def4075da6d Author: tamao Date: 2013-03-05 15:36 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9def4075da6d 8008079: G1: Add nextObject routine to CMBitMapRO and replace nextWord Summary: Update the task local finger to the start of the next object when marking aborts, in order to avoid the redundant scanning of all 0's when the marking task restarts, if otherwise updating to the next word. In addition, reuse the routine nextObject() in routine iterate(). Reviewed-by: johnc, ysr Contributed-by: tamao ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: 209f8ba5020b Author: tamao Date: 2013-03-07 10:44 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/209f8ba5020b 8008368: Deprecate MaxGCMinorPauseMillis Summary: Deprecate MaxGCMinorPauseMillis and emit a warning if set by users Reviewed-by: brutisso, johnc Contributed-by: tamao ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 1f3354851c91 Author: stefank Date: 2013-03-11 08:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1f3354851c91 Merge Changeset: 167812fe00bb Author: kevinw Date: 2013-03-11 12:56 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/167812fe00bb 8009723: CMS logs "concurrent mode failure" twice when using (disabling) -XX:-UseCMSCompactAtFullCollection Reviewed-by: jwilhelm, ehelin, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 71f619500f9b Author: kevinw Date: 2013-03-11 15:37 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/71f619500f9b Merge Changeset: 1c88b99a2b01 Author: mgerdin Date: 2013-03-12 09:42 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1c88b99a2b01 8009282: Assertion "assert(used_and_free == capacity_bytes) failed: Accounting is wrong" failed with -XX:+Verbose -XX:+TraceMetadataChunkAllocation Summary: Assertion is only valid when at a safepoint, adjust accordingly. Reviewed-by: stefank, jmasa, tamao ! src/share/vm/memory/metaspace.cpp Changeset: ca9580859cf4 Author: stefank Date: 2013-03-11 02:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ca9580859cf4 8004697: SIGSEGV on Solaris sparc with -XX:+UseNUMA Summary: Don't scan pages outside the given range. Reviewed-by: jwilhelm, jmasa ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp Changeset: 62609ffa2fc6 Author: tschatzl Date: 2013-03-12 15:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/62609ffa2fc6 8008684: CMS: concurrent phase start markers should always be printed Summary: Print the concurrent phase start markers for CMS when PrintGCDetails is enabled, not only if both PrintGCDetails and PrintGCTimeStamps are. Reviewed-by: mgerdin, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: eac371996b44 Author: brutisso Date: 2013-03-12 08:33 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/eac371996b44 8001049: VM crashes when running with large -Xms and not specifying ObjectAlignmentInBytes Summary: Take the initial heap size into account when checking the heap size for compressed oops Reviewed-by: jmasa, kvn, hseigel, ctornqvi ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 993d878108d9 Author: brutisso Date: 2013-03-13 05:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/993d878108d9 Merge Changeset: 82657b6a8cc0 Author: jmasa Date: 2013-03-12 11:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/82657b6a8cc0 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared Reviewed-by: johnc ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/memory/collectorPolicy.cpp Changeset: 15401203db6b Author: stefank Date: 2013-03-15 08:57 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/15401203db6b Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/runtime/arguments.cpp Changeset: a10dc1469c3f Author: stefank Date: 2013-03-15 04:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a10dc1469c3f Merge Changeset: f1629878512f Author: katleman Date: 2013-03-14 15:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f1629878512f Added tag jdk8-b81 for changeset 65b797426a3b ! .hgtags Changeset: b95ad0610fef Author: asaha Date: 2012-10-26 09:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b95ad0610fef Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/gc_implementation/parallelScavenge/PSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/ContigPermSpace.java - agent/src/share/classes/sun/jvm/hotspot/memory/PermGen.java - agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/CompiledICHolderKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/KlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodDataKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/TypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/ui/tree/BadOopTreeNodeAdapter.java - make/solaris/makefiles/reorder_COMPILER1_amd64 - make/solaris/makefiles/reorder_COMPILER1_i486 - make/solaris/makefiles/reorder_COMPILER1_sparc - make/solaris/makefiles/reorder_COMPILER1_sparcv9 - make/solaris/makefiles/reorder_COMPILER2_amd64 - make/solaris/makefiles/reorder_COMPILER2_i486 - make/solaris/makefiles/reorder_COMPILER2_sparc - make/solaris/makefiles/reorder_COMPILER2_sparcv9 - make/solaris/makefiles/reorder_CORE_i486 - make/solaris/makefiles/reorder_CORE_sparc - make/solaris/makefiles/reorder_CORE_sparcv9 - make/solaris/makefiles/reorder_TIERED_amd64 - make/solaris/makefiles/reorder_TIERED_i486 - make/solaris/makefiles/reorder_TIERED_sparc - make/solaris/makefiles/reorder_TIERED_sparcv9 - make/solaris/reorder.sh - src/cpu/sparc/vm/dump_sparc.cpp - src/cpu/x86/vm/dump_x86_32.cpp - src/cpu/x86/vm/dump_x86_64.cpp - src/cpu/zero/vm/dump_zero.cpp - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java - src/share/vm/ci/ciArrayKlassKlass.hpp - src/share/vm/ci/ciCPCache.cpp - src/share/vm/ci/ciCPCache.hpp - src/share/vm/ci/ciInstanceKlassKlass.cpp - src/share/vm/ci/ciInstanceKlassKlass.hpp - src/share/vm/ci/ciKlassKlass.cpp - src/share/vm/ci/ciKlassKlass.hpp - src/share/vm/ci/ciMethodKlass.cpp - src/share/vm/ci/ciMethodKlass.hpp - src/share/vm/ci/ciObjArrayKlassKlass.cpp - src/share/vm/ci/ciObjArrayKlassKlass.hpp - src/share/vm/ci/ciTypeArrayKlassKlass.cpp - src/share/vm/ci/ciTypeArrayKlassKlass.hpp ! src/share/vm/compiler/compilerOracle.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.hpp - src/share/vm/memory/classify.cpp - src/share/vm/memory/classify.hpp - src/share/vm/memory/compactPermGen.hpp - src/share/vm/memory/compactingPermGenGen.cpp - src/share/vm/memory/compactingPermGenGen.hpp - src/share/vm/memory/dump.cpp - src/share/vm/memory/permGen.cpp - src/share/vm/memory/permGen.hpp - src/share/vm/memory/restore.cpp - src/share/vm/memory/serialize.cpp - src/share/vm/oops/arrayKlassKlass.cpp - src/share/vm/oops/arrayKlassKlass.hpp - src/share/vm/oops/compiledICHolderKlass.cpp - src/share/vm/oops/compiledICHolderKlass.hpp - src/share/vm/oops/compiledICHolderOop.cpp - src/share/vm/oops/compiledICHolderOop.hpp - src/share/vm/oops/constMethodKlass.cpp - src/share/vm/oops/constMethodKlass.hpp - src/share/vm/oops/constMethodOop.cpp - src/share/vm/oops/constMethodOop.hpp - src/share/vm/oops/constantPoolKlass.cpp - src/share/vm/oops/constantPoolKlass.hpp - src/share/vm/oops/constantPoolOop.cpp - src/share/vm/oops/constantPoolOop.hpp - src/share/vm/oops/cpCacheKlass.cpp - src/share/vm/oops/cpCacheKlass.hpp - src/share/vm/oops/cpCacheOop.cpp - src/share/vm/oops/cpCacheOop.hpp - src/share/vm/oops/instanceKlassKlass.cpp - src/share/vm/oops/instanceKlassKlass.hpp - src/share/vm/oops/klassKlass.cpp - src/share/vm/oops/klassKlass.hpp - src/share/vm/oops/klassOop.cpp - src/share/vm/oops/klassOop.hpp - src/share/vm/oops/methodDataKlass.cpp - src/share/vm/oops/methodDataKlass.hpp - src/share/vm/oops/methodDataOop.cpp - src/share/vm/oops/methodDataOop.hpp - src/share/vm/oops/methodKlass.cpp - src/share/vm/oops/methodKlass.hpp - src/share/vm/oops/methodOop.cpp - src/share/vm/oops/methodOop.hpp - src/share/vm/oops/objArrayKlassKlass.cpp - src/share/vm/oops/objArrayKlassKlass.hpp - src/share/vm/oops/typeArrayKlassKlass.cpp - src/share/vm/oops/typeArrayKlassKlass.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 77443715ec55 Author: kamg Date: 2012-11-05 17:03 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77443715ec55 8001307: Modify ACC_SUPER behavior Summary: Disallow non-virtual calls even when ACC_SUPER is absent. Reviewed-by: kvn, acorn ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/runtime/globals.hpp Changeset: b5cb079ecaa4 Author: ewendeli Date: 2013-02-03 22:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5cb079ecaa4 Merge ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 1cabf9c80e84 Author: ewendeli Date: 2013-02-19 21:45 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1cabf9c80e84 Merge ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/runtime/arguments.cpp Changeset: d4a32a6f8c82 Author: ewendeli Date: 2013-02-25 07:22 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d4a32a6f8c82 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 11d5942ef9c7 Author: lana Date: 2013-03-12 18:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/11d5942ef9c7 Merge ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5ee744831dcb Author: lana Date: 2013-03-14 19:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ee744831dcb Merge Changeset: 0631ebcc45f0 Author: amurillo Date: 2013-03-15 11:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0631ebcc45f0 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 3db4ab0e12f4 Author: amurillo Date: 2013-03-15 11:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3db4ab0e12f4 Added tag hs25-b23 for changeset 0631ebcc45f0 ! .hgtags Changeset: 7ae04e71af90 Author: amurillo Date: 2013-03-15 11:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7ae04e71af90 8010105: new hotspot build - hs25-b24 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 82ab039b9680 Author: dcubed Date: 2013-03-17 08:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/82ab039b9680 Merge ! src/share/vm/memory/metaspace.cpp From sundararajan.athijegannathan at oracle.com Sun Mar 17 22:23:21 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 18 Mar 2013 05:23:21 +0000 Subject: hg: jdk8/tl/nashorn: 6 new changesets Message-ID: <20130318052326.24CA148207@hg.openjdk.java.net> Changeset: c54e218333be Author: sundar Date: 2013-03-12 18:12 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c54e218333be 8009757: Package access clean up and refactoring Reviewed-by: jlaskey, lagergren, attila ! docs/JavaScriptingProgrammersGuide.html ! docs/source/javaarray.js ! make/build.xml ! make/java.security.override ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java + src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java + src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js ! src/jdk/nashorn/internal/runtime/resources/parser.js ! test/script/basic/JDK-8008448.js ! test/script/basic/NASHORN-401.js ! test/script/basic/consstring.js ! test/script/basic/fileline.js ! test/script/basic/javainnerclasses.js ! test/script/basic/list.js ! test/script/basic/map.js ! test/script/basic/stdin.js ! test/script/sandbox/javaextend.js ! test/script/sandbox/javaextend.js.EXPECTED ! test/script/sandbox/reflection.js - test/script/sandbox/reflection.js.EXPECTED ! test/script/sandbox/unsafe.js - test/script/sandbox/unsafe.js.EXPECTED ! test/script/trusted/urlreader.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java - test/src/jdk/nashorn/internal/runtime/Nashorn401TestSubject.java ! test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java - test/src/jdk/nashorn/internal/test/models/ConstructorWithArgument.java - test/src/jdk/nashorn/internal/test/models/DessertTopping.java - test/src/jdk/nashorn/internal/test/models/DessertToppingFloorWaxDriver.java - test/src/jdk/nashorn/internal/test/models/FinalClass.java - test/src/jdk/nashorn/internal/test/models/FloorWax.java - test/src/jdk/nashorn/internal/test/models/NoAccessibleConstructorClass.java - test/src/jdk/nashorn/internal/test/models/NonPublicClass.java - test/src/jdk/nashorn/internal/test/models/OuterClass.java - test/src/jdk/nashorn/internal/test/models/OverloadedSam.java - test/src/jdk/nashorn/internal/test/models/OverrideObject.java - test/src/jdk/nashorn/internal/test/models/StringArgs.java - test/src/jdk/nashorn/internal/test/models/Toothpaste.java + test/src/jdk/nashorn/test/models/ConstructorWithArgument.java + test/src/jdk/nashorn/test/models/DessertTopping.java + test/src/jdk/nashorn/test/models/DessertToppingFloorWaxDriver.java + test/src/jdk/nashorn/test/models/FinalClass.java + test/src/jdk/nashorn/test/models/FloorWax.java + test/src/jdk/nashorn/test/models/Nashorn401TestSubject.java + test/src/jdk/nashorn/test/models/NoAccessibleConstructorClass.java + test/src/jdk/nashorn/test/models/NonPublicClass.java + test/src/jdk/nashorn/test/models/OuterClass.java + test/src/jdk/nashorn/test/models/OverloadedSam.java + test/src/jdk/nashorn/test/models/OverrideObject.java + test/src/jdk/nashorn/test/models/SourceHelper.java + test/src/jdk/nashorn/test/models/StringArgs.java + test/src/jdk/nashorn/test/models/Toothpaste.java Changeset: e15806b9d716 Author: lagergren Date: 2013-03-12 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e15806b9d716 8009718: Lazy execution architecture continued - ScriptFunctionData is either final or recompilable. Moved ScriptFunctionData creation logic away from runtime to compile time. Prepared for method generation/specialization. Got rid of ScriptFunctionImplTrampoline whose semantics could be done as part of the relinking anyway. Merge with the lookup package change. Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java - src/jdk/nashorn/internal/ir/annotations/ChildNode.java - src/jdk/nashorn/internal/ir/annotations/ParentNode.java ! src/jdk/nashorn/internal/ir/annotations/Reference.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java - src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java + src/jdk/nashorn/internal/runtime/CompiledFunction.java + src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAException.java + src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java + src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java - src/jdk/nashorn/internal/runtime/SpecializedMethodChooser.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! test/script/currently-failing/JDK-8006529.js + test/script/currently-failing/clone_ir.js Changeset: 60684aeba89c Author: sundar Date: 2013-03-12 21:17 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/60684aeba89c 8009868: For loop with "true" as condition results in AssertionError in codegen Reviewed-by: jlaskey, hannesw, lagergren ! src/jdk/nashorn/internal/codegen/Lower.java + test/script/basic/JDK-8009868.js Changeset: 390d44ba90cf Author: lagergren Date: 2013-03-14 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/390d44ba90cf 8009982: Lazy execution bugfix. Added lazy sunspider unit test. Added mandreel to compile-octane test. Fixed warnings Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpResult.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java ! test/script/basic/compile-octane.js.EXPECTED ! test/script/basic/run-octane.js + test/script/basic/runsunspider-eager.js + test/script/basic/runsunspider-lazy.js ! test/script/basic/runsunspider.js Changeset: d5d80b52cf1c Author: lagergren Date: 2013-03-15 16:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d5d80b52cf1c 8010147: Forgot to add EXPECTED files for lazy and eager sunspider test Reviewed-by: sundar, jlaskey + test/script/basic/runsunspider-eager.js.EXPECTED + test/script/basic/runsunspider-lazy.js.EXPECTED - test/script/basic/runsunspider.js.EXPECTED Changeset: 4daacf8a25ef Author: sundar Date: 2013-03-15 21:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4daacf8a25ef 8010145: removed workaround "init.js" in nashorn repo Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/Formatter.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/api/scripting/resources/engine.js - src/jdk/nashorn/api/scripting/resources/init.js From staffan.larsen at oracle.com Mon Mar 18 06:52:56 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Mar 2013 14:52:56 +0100 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <513F9994.6030309@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> <513928E7.50404@oracle.com> <51392A70.5040107@oracle.com> <513983AB.8070805@oracle.com> <513F877B.5010302@oracle.com> <513F9994.6030309@oracle.com> Message-ID: <2D1E589C-3E85-4B05-8232-FB6441A793DF@oracle.com> Yumin, I'm ok with these changes now (although I'm not an official Reviewer). What testing have you done? Do we have existing tests that exercise this code? /Staffan On 12 mar 2013, at 22:09, Yumin Qi wrote: > Serguei, > > Thanks. > > Staffan, can you have a look at the new changes, concern? > > Thanks > Yumin > On 3/12/2013 12:52 PM, serguei.spitsyn at oracle.com wrote: >> Yumin, >> >> The updated webrev looks good. >> Just some simple cosmetic and debug comments below. >> >> >> agent/src/os/bsd/MacosxDebuggerLocal.m >> >> Nice refactoring! >> >> 350 /** Only used for core file reading, set thread_id for threads which got after core file parsing. >> 351 When parsing core file on Mac OS X, thread context is available but thread id. >> 352 We identify them as java threads by checking if a thread's rsp or rbp within a java thread's >> 353 stack(stack info is recoreded when it is created). Note Macosx uses unique_thread_id which is >> 354 different from other platforms though printed ids are still pthread id. >> 355 Function BsdDebuggerLocal.getJavaThreadsInfo returns an array of long integers to host >> 356 all java threads' id, stack_start, stack_end as: >> 357 [uid0, stack_start0, stack_end0, uid1, stack_start1, stack_end1, ...] >> 358 >> 359 The work cannot be done at init0 since Threads is not available yet(VM not initialized yet). >> 360 This function should be called only once if succeeded */ >> It'd be better to start lines 351-360 with the '*'. >> The sentence at line 351 is not clear. >> >> >> 393 /* core file only, called from Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_getThreadIntegerRegisterSet0 */ >> 394 jlongArray getThreadIntegerRegisterSetFromCore(JNIEnv *env, jobject this_obj, long lwp_id) { >> 395 // On Mac OS X, we can not get thread_id from x86Thread_State_t, but they are recorded in JavaThread of JVM >> The comment lines 393 and 395 are two long and can be split in two. >> >> 440 regs[REG_INDEX(RDI)] = gregs.r_rdi; >> 441 regs[REG_INDEX(RIP)] = gregs.r_rip; >> 442 regs[REG_INDEX(CS)] = gregs.r_cs; >> 443 regs[REG_INDEX(RSP)] = gregs.r_rsp; >> 444 regs[REG_INDEX(SS)] = gregs.r_ss; >> 445 regs[REG_INDEX(FSBASE)] = 0; >> 446 regs[REG_INDEX(GSBASE)] = 0; >> 447 regs[REG_INDEX(DS)] = gregs.r_ds; >> 448 regs[REG_INDEX(ES)] = gregs.r_es; >> 449 regs[REG_INDEX(FS)] = gregs.r_fs; >> 450 regs[REG_INDEX(GS)] = gregs.r_gs; >> 451 regs[REG_INDEX(TRAPNO)] = gregs.r_trapno; >> 452 regs[REG_INDEX(RFL)] = gregs.r_rflags; >> >> At least, the lines 442, 444, 447-450 and 452 can be aligned as 440-441. >> >> 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! [PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); >> The line above is too long. You can split it like this: >> 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! " >> "[PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); >> >> agent/src/os/bsd/Makefile >> >> The lines 25 and 55 are too long. >> >> agent/src/os/bsd/libproc_impl.c >> >> I see you've fixed many indents in this file. >> >> >> agent/src/os/bsd/ps_core.c >> >> 565 print_debug(" r_r15: 0x%" PRIx64 "\n", threadinfo->regs.r_r15); >> 566 print_debug(" r_r14: 0x%" PRIx64 "\n", threadinfo->regs.r_r14); >> 567 print_debug(" r_r13: 0x%" PRIx64 "\n", threadinfo->regs.r_r13); >> 568 print_debug(" r_r12: 0x%" PRIx64 "\n", threadinfo->regs.r_r12); >> 569 print_debug(" r_r11: 0x%" PRIx64 "\n", threadinfo->regs.r_r11); >> 570 print_debug(" r_r10: 0x%" PRIx64 "\n", threadinfo->regs.r_r10); >> 571 print_debug(" r_r9: 0x%" PRIx64 "\n", threadinfo->regs.r_r9); >> 572 print_debug(" r_r8: 0x%" PRIx64 "\n", threadinfo->regs.r_r8); >> 573 print_debug(" r_rdi: 0x%" PRIx64 "\n", threadinfo->regs.r_rdi); >> 574 print_debug(" r_rsi: 0x%" PRIx64 "\n", threadinfo->regs.r_rsi); >> 575 print_debug(" r_rbp: 0x%" PRIx64 "\n", threadinfo->regs.r_rbp); >> 576 print_debug(" r_rbx: 0x%" PRIx64 "\n", threadinfo->regs.r_rbx); >> 577 print_debug(" r_rdx: 0x%" PRIx64 "\n", threadinfo->regs.r_rdx); >> 578 print_debug(" r_rcx: 0x%" PRIx64 "\n", threadinfo->regs.r_rcx); >> 579 print_debug(" r_rax: 0x%" PRIx64 "\n", threadinfo->regs.r_rax); >> 580 print_debug(" r_fs: 0x%" PRIx32 "\n", threadinfo->regs.r_fs); >> 581 print_debug(" r_gs: 0x%" PRIx32 "\n", threadinfo->regs.r_gs); >> 582 print_debug(" r_rip 0x%" PRIx64 "\n", threadinfo->regs.r_rip); >> 583 print_debug(" r_cs: 0x%" PRIx64 "\n", threadinfo->regs.r_cs); >> 584 print_debug(" r_rflags: 0x%" PRIx64 "\n", threadinfo->regs.r_rflags); >> 585 print_debug(" r_rsp: 0x%" PRIx64 "\n", threadinfo->regs.r_rsp); >> >> >> The lines can be aligned better and printed info will be more readable too: >> 571-572, 580-583 >> >> >> 622 print_debug("segment added: %" PRIu64 " 0x%" PRIx64 " %d\n", segcmd.fileoff, segcmd.vmaddr, segcmd.vmsize); >> 816 print_debug("map_info %d: vmaddr = 0x%016" PRIx64 " fileoff = %" PRIu64 " vmsize = %" PRIu64 "\n", j, iter->vaddr, iter->offset, iter->memsz); >> The print_debug lines are too long. >> >> >> One empty line extra: 272-273. >> >> 956 if (read_core_segments(ph) != true) >> 957 goto err; >> 958 >> 959 // allocate and sort maps into map_array, we need to do this >> 960 // here because read_shared_lib_info needs to read from debuggee >> 961 // address space >> 962 if (sort_map_array(ph) != true) >> 963 goto err; >> 964 >> 965 if (read_shared_lib_info(ph) != true) >> 966 goto err; >> 967 >> 968 // sort again because we have added more mappings from shared objects >> 969 if (sort_map_array(ph) != true) >> 970 goto err; >> 971 >> 972 if (init_classsharing_workaround(ph) != true) >> 973 goto err; >> >> Probably have to print a debug error message for before "goto err;". >> >> >> Thanks, >> Serguei >> >> On 3/7/13 10:22 PM, Yumin Qi wrote: >>> Serguei and Saffan, >>> >>> Please take look at the same link for new webrev. >>> >>> Thanks >>> Yumin >>> >>> On 3/7/2013 4:01 PM, serguei.spitsyn at oracle.com wrote: >>>> Thank you for making the suggested changes! >>>> Serguei >>>> >>>> On 3/7/13 3:55 PM, Yumin Qi wrote: >>>>> Hi, Serguei >>>>> >>>>> Thanks for the review, I reviewed the part of Pgrab_core, you are right, I now put the code into two chunks: APPLE and none APPLE. >>>>> Will send another webrev for you tonight --- add all your concerns. >>>>> >>>>> See answers below: >>>>> >>>>> On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: >>>>>> Hi Yumin, >>>>>> >>>>>> No insisting on refactoring, it is just desirable. :) >>>>>> >>>>>> >>>>>> agent/src/os/bsd/symtab.c >>>>>> >>>>>> Need a cleanup: >>>>>> 54 // #define NAMELEN 4096 >>>>>> 78 // dysymtab_command dysymtabcmd; >>>>>> 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); >>>>> Yes, will. >>>>>> >>>>>> >>>>>> This function is too big, it would be nice to factor out some >>>>>> of its body fragments as functions: >>>>>> 55 struct symtab* build_symtab(int fd) { >>>>> Will try to make it nice. >>>>>> The line 137 is too long. You can do like this: >>>>>> int size = symtabcmd.strsize * sizeof(char); >>>>>> if (read(fd, (void *)(symtab->strs), size) != size) { >>>>>> Space is missed: >>>>>> 145 //fix size >>>>>> >>>>> OK, will change. >>>>>> No point to start new line if similar fragments like that do not have it: >>>>>> 153 symtab->symbols[i].size = >>>>>> 154 symtabcmd.strsize - symtab->symbols[i].size; >>>>> Will change. >>>>>> Empty line is needed after the structure definition: >>>>>> 199 void *c_data; >>>>>> 200 }; >>>>>> 201 // read symbol table from given fd. >>>>>> 202 struct symtab* build_symtab(int fd) { >>>>>> >>>>> Will change. >>>>>> agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java >>>>>> >>>>>> Need a consistent indentation (4?) as they are 2 and 3. >>>>>> For instance, the BsdDebuggerLocal.java has indent == 4. >>>>>> >>>>> Will change to 4. >>>>> The SA code has no consistent coding style, some place you will see 3, some place 2 or 4. >>>>> For Java code, I will change them to have 4 spaces. For C, have done some with 2, but still large amount of code ended with 3. >>>>> This needs future clean work. >>>>>> >>>>>> The flag name " newVT" does not match the comments, should it be named "oldVT" ? : >>>>>> 46 if (newVT) { >>>>>> 47 // old C++ ABI >>>>>> 48 vt = isDarwin ? "_vt_" : "__vt_"; >>>>>> 49 } else { >>>>>> 50 // new C++ ABI >>>>>> 51 vt = "_ZTV"; >>>>>> 52 } >>>>> Oh, I see, the comments reversed. >>>>>> >>>>>> agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java >>>>>> >>>>>> Incorrect indent, it must be 4: >>>>>> 86 public long getUniqueThreadId() { >>>>>> 87 return unique_thread_id; >>>>>> 88 } >>>>>> >>>>> Yes. >>>>>> Sorry for paying too much attention to indentation! >>>>>> It is because the SA indentation is a real mess. :) >>>>>> >>>>>> But this project is a nice progress in the SA area! >>>>>> In fact, it is a lot of work. >>>>>> I bet, you spent a lot of time debugging this code. >>>>>> >>>>> My work is making SA reading core on Macosx work, now we have a working version! thanks. >>>>> >>>>> Yumin >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>> On 3/6/13 8:54 AM, Yumin Qi wrote: >>>>>>> Thanks, Serguei >>>>>>> >>>>>>> Will take care what you have indicated but refactoring code for ps_core.c (Pgrab_core). Maybe in future, code cleaning should include this, the better choice I think is regroup code to detail in specific platform, such as with new file ps_core_darwin.c etc but not now. >>>>>>> >>>>>>> /Yumin >>>>>>> >>>>>>> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>>>>>>> Hi Yumin, >>>>>>>> >>>>>>>> >>>>>>>> A partial review below. >>>>>>>> >>>>>>>> >>>>>>>> agent/src/os/bsd/MacosxDebuggerLocal.m >>>>>>>> >>>>>>>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>>>>>>> 153 CHECK_EXCEPTION; >>>>>>>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>>>>>>> 155 "()[J"); >>>>>>>> 156 >>>>>>>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>>>>>>> >>>>>>>> Is CHECK_EXCEPTION needed after the line #154? >>>>>>>> >>>>>>>> The indent is 3 instead of 2: >>>>>>>> Lines 360-410, 775-788 >>>>>>>> >>>>>>>> >>>>>>>> agent/src/os/bsd/libproc.h >>>>>>>> 36 #ifdef __APPLE__ >>>>>>>> . . . >>>>>>>> 46 #ifndef bool >>>>>>>> 47 typedef int bool; >>>>>>>> 48 #define true 1 >>>>>>>> 49 #define false 0 >>>>>>>> 50 #endif // bool >>>>>>>> . . . >>>>>>>> 57 #else // __APPLE__ >>>>>>>> . . . >>>>>>>> 76 // This C bool type must be int for compatibility with BSD calls and >>>>>>>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>>>>>>> 78 typedef int bool; >>>>>>>> 79 #define true 1 >>>>>>>> 80 #define false 0 >>>>>>>> 81 >>>>>>>> 82 #endif // __APPLE__ >>>>>>>> The bool, true and false are defined the same way for APPLE and not APPLE. >>>>>>>> Would it make sense to define it just once? >>>>>>>> >>>>>>>> agent/src/os/bsd/ps_core.c >>>>>>>> >>>>>>>> Need a clean up: >>>>>>>> 869 // thread_command thrcmd; >>>>>>>> >>>>>>>> Space is missed after "if", wrong indent at line #873: >>>>>>>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>>>>>>> 873 goto err; >>>>>>>> Lines 893, 1087 are too long. >>>>>>>> >>>>>>>> The function read_core_segments() is big and not well readable. >>>>>>>> Would it make sense to consider to separate some of its internals as a local functions. >>>>>>>> For instance, the lines 921-950 are good candidates for it. >>>>>>>> >>>>>>>> The indent is 3: >>>>>>>> 1015 if (exists(filepath)) { >>>>>>>> 1016 strcpy(rpath, filepath); >>>>>>>> 1017 return true; >>>>>>>> 1018 } >>>>>>>> I did not understand the comments, probably, some words are missing: >>>>>>>> 1070 mach_header_64 header; // used to check if a file header in segment >>>>>>>> . . . >>>>>>>> 1110 // this is the file begining to core file. >>>>>>>> >>>>>>>> >>>>>>>> Not consistent, other fragments before used "goto err;" : >>>>>>>> 1122 return false; // error >>>>>>>> . . . >>>>>>>> 1133 return false; >>>>>>>> >>>>>>>> Too many ifdef'ed fragments with __APPLE__ >>>>>>>> Is it possibler to combine them into bigger chunks or refactor in a different way? >>>>>>>> For instance, the function Pgrab_core() is not readable. >>>>>>>> It'd be better to have two separated versions of the function for apple and not apple. >>>>>>>> >>>>>>>> >>>>>>>> Still to review: >>>>>>>> >>>>>>>> agent/src/os/bsd/symtab.c >>>>>>>> agent/src/os/bsd/symtab.h >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java >>>>>>>> agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java >>>>>>>> agent/src/share/native/sadis.c >>>>>>>> make/bsd/makefiles/saproc.make >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Serguei >>>>>>>> >>>>>>>> >>>>>>>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>>>>>>> Hi, all >>>>>>>>> >>>>>>>>> Please review at the new changes. Include >>>>>>>>> 1) use unique_thread_id (which is a 64 bit integer on Macosx) to identify thread. Add a function in BsdDebuggerLocal to call the newly added function BsdThread.getUniqueThreadId to get this id. Meanwhile, move the code of forming threadList in native part to BsdDebuggerLocal.java since the thread ids of all java threads can be obtained from Threads and coding is much easier and clear. >>>>>>>>> >>>>>>>>> 2) To have better performance, get all java thread ids, stack infos (stack begin, stack end) into one array of long which is decoded in native code and used to set thread ids. This save much more time first time to fill java thread ids. >>>>>>>>> >>>>>>>>> 3) remove DarwinVtblAccess.java which added in last version , its functionality moved to BsdVtblAccess.java >>>>>>>>> >>>>>>>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>>>>>>> >>>>>>>>> 5) remove unsupported platform defs. >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> Yumin >>>>>>>>> >>>>>>>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>>>>>>> Hi, Staffan (and Serguei) >>>>>>>>>> >>>>>>>>>> Made some clean for code. >>>>>>>>>> 1) added mach-o file fat header parsing as you suggested. >>>>>>>>>> 2) modified get_real_path as you indicated it could run with jre/bin/java >>>>>>>>>> 3) moved output information from CommandProcessor.java to PStack.java for printing out pstack not available for Darwin. >>>>>>>>>> 4) code clean, file header update. >>>>>>>>>> >>>>>>>>>> Please take a look at same location. >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> Yumin >>>>>>>>>> >>>>>>>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>>>>>>> Thanks for doing this Yumin! >>>>>>>>>>> >>>>>>>>>>> I tried to apply you patch and run it, but I can't get SA to open a core file. You can see the exception I get below. Is there some kind of setup I need to do? This is against a jvmg build of Hotspot. >>>>>>>>>>> >>>>>>>>>>> I also noticed that you forgot to update BugSpotAgent.java with the same changes as in HotspotAgent.java. This makes the jstack tool fail. >>>>>>>>>>> >>>>>>>>>>> I will look at the changes more closely. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> /Staffan >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Opening core file, please wait... >>>>>>>>>>> Unable to open core file >>>>>>>>>>> /cores/core.79028: >>>>>>>>>>> >>>>>>>>>>> Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in >>>>>>>>>>> remote process) >>>>>>>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" in remote process) >>>>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>>>>>>> hsdb> Input stream closed. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> Please review for the changes for SA to read core file on Mac OS X, this is feature is not implemented on previous releases. >>>>>>>>>>>> This change made for SA to work on core file on Darwin, but still some function not fixed, such as 'pstack'. This is intended to integrate into 8. >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>>>>> >>>>>>>>>>>> Please take some time since the code change is a little bigger. >>>>>>>>>>>> >>>>>>>>>>>> Thanks very much >>>>>>>>>>>> Yumin >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130318/ac76066c/attachment-0001.html From staffan.larsen at oracle.com Mon Mar 18 07:13:20 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Mar 2013 15:13:20 +0100 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <513646F9.3060601@oracle.com> <51379D88.6080807@oracle.com> <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com> Message-ID: Can I get an official Review of this change? Thanks, /Staffan On 7 mar 2013, at 12:54, Staffan Larsen wrote: > Here is a webrev for fixing this problem. I actually removed all of our own tokenization code in dll_build_name() and replaced it with calls to strtok_r (strtok_s on windows) instead. I think this should be more robust, at the cost of an extra memory allocation. I've also added the const qualifier to some of the parameters. > > http://cr.openjdk.java.net/~sla/8009558/webrev.02/ > > All of the jdi and hprof tests passes with this change. > > Thanks, > /Staffan > > On 6 mar 2013, at 20:48, serguei.spitsyn at oracle.com wrote: > >> Staffan, >> >> Thank you for the confirmation and taking care about this issue! >> >> Thanks, >> Serguei >> >> >> On 3/6/13 11:36 AM, Staffan Larsen wrote: >>> Nice catch, Serguei! >>> >>> Unfortunately I have already pushed my change, but I filed "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop" to track this new problem and I am working on a fix. >>> >>> Thanks, >>> /Staffan >>> >>> >>> On 5 mar 2013, at 20:26, serguei.spitsyn at oracle.com wrote: >>> >>>> Hi Staffan, >>>> >>>> Thank you for this discovery! >>>> It looks good, but I have a couple of comments. >>>> >>>> It seems, there is one more problem in this code: >>>> 68 /* check for NULL path */ >>>> 69 if (p == pathname) { >>>> 70 continue; <== Endless loop if we hit this line >>>> 71 } >>>> >>>> Do we need to do 'pathname++' before continuing at the line #70? >>>> It is going to be endless loop in cases there is a PATH_SEPARATOR >>>> at the beginning of paths or two PATH_SEPARATOR's in a row. >>>> These would be incorrect path lists but the code above is targeting exactly such cases. >>>> >>>> Also, the argument name "pathname" in the original code is confusing. >>>> Should we rename it to "pathnames"? >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 3/4/13 10:56 AM, Staffan Larsen wrote: >>>>> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: >>>>> >>>>> 57 static void dll_build_name(char* buffer, size_t buflen, >>>>> 58 const char* pname, const char* fname) { >>>>> 59 // Based on os_solaris.cpp >>>>> 60 >>>>> 61 char *path_sep = PATH_SEPARATOR; >>>>> 62 char *pathname = (char *)pname; >>>>> 63 while (strlen(pathname) > 0) { >>>>> 64 char *p = strchr(pathname, *path_sep); >>>>> 65 if (p == NULL) { >>>>> 66 p = pathname + strlen(pathname); >>>>> 67 } >>>>> 68 /* check for NULL path */ >>>>> 69 if (p == pathname) { >>>>> 70 continue; >>>>> 71 } >>>>> 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), >>>>> 73 pathname, fname); >>>>> 74 >>>>> 75 if (access(buffer, F_OK) == 0) { >>>>> 76 break; >>>>> 77 } >>>>> 78 pathname = p + 1; >>>>> 79 *buffer = '\0'; >>>>> 80 } >>>>> >>>>> If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). >>>>> >>>>> The same code show up in both the solaris code and the windows code as well as hprof. >>>>> >>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8009397 >>>>> webrev: http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >>>>> >>>>> Thanks, >>>>> /Staffan >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130318/5dabc113/attachment.html From staffan.larsen at oracle.com Mon Mar 18 07:14:03 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Mar 2013 15:14:03 +0100 Subject: RFR(S): 8006637 Failure to filter out native frame events on Solaris In-Reply-To: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> References: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> Message-ID: <182C0956-0285-48E6-9A56-E90DDEDEDBB0@oracle.com> I still need an official Review for this change. Thanks, Staffan On 7 mar 2013, at 09:10, Staffan Larsen wrote: > Adding core-libs-dev and re-asking for a review. > > Thanks, > /Staffan > > On 27 feb 2013, at 15:59, Staffan Larsen wrote: > >> Please review the following test fix. >> >> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 >> >> The problem is that the test assumes that no other threads call String.intern() while the tests is running. This is normally ok, but when running with JFR there are other threads calling String.intern() in the background and the test fails. The solution is to add a thread filter to the method exit requests so that only calls to String.inter() in the main thread are reported. >> >> Thanks, >> /Staffan > From jonathan.gibbons at oracle.com Mon Mar 18 08:46:33 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 18 Mar 2013 15:46:33 +0000 Subject: hg: jdk8/tl/langtools: 8005220: RFE to write javap tests for repeating annotations. Message-ID: <20130318154636.C04EB48212@hg.openjdk.java.net> Changeset: 1f8c28134ffc Author: jjg Date: 2013-03-18 08:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f8c28134ffc 8005220: RFE to write javap tests for repeating annotations. Reviewed-by: jjg Contributed-by: peter.jensen at oracle.com + test/tools/javap/output/RepeatingTypeAnnotations.java + test/tools/javap/output/Tester.java From serguei.spitsyn at oracle.com Mon Mar 18 09:47:04 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 18 Mar 2013 09:47:04 -0700 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <513646F9.3060601@oracle.com> <51379D88.6080807@oracle.com> <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com> Message-ID: <51474508.7040000@oracle.com> I already reviewed this, and it is a good fix. Please, see my email attached. Thanks, Serguei On 3/18/13 7:13 AM, Staffan Larsen wrote: > Can I get an official Review of this change? > > Thanks, > /Staffan > > On 7 mar 2013, at 12:54, Staffan Larsen > wrote: > >> Here is a webrev for fixing this problem. I actually removed all of >> our own tokenization code in dll_build_name() and replaced it with >> calls to strtok_r (strtok_s on windows) instead. I think this should >> be more robust, at the cost of an extra memory allocation. I've also >> added the const qualifier to some of the parameters. >> >> http://cr.openjdk.java.net/~sla/8009558/webrev.02/ >> >> >> All of the jdi and hprof tests passes with this change. >> >> Thanks, >> /Staffan >> >> On 6 mar 2013, at 20:48, serguei.spitsyn at oracle.com >> wrote: >> >>> Staffan, >>> >>> Thank you for the confirmation and taking care about this issue! >>> >>> Thanks, >>> Serguei >>> >>> >>> On 3/6/13 11:36 AM, Staffan Larsen wrote: >>>> Nice catch, Serguei! >>>> >>>> Unfortunately I have already pushed my change, but I filed >>>> "JDK-8009558: linked_md.c::dll_build_name can get stuck in an >>>> infinite loop" to track this new problem and I am working on a fix. >>>> >>>> Thanks, >>>> /Staffan >>>> >>>> >>>> On 5 mar 2013, at 20:26, serguei.spitsyn at oracle.com >>>> wrote: >>>> >>>>> Hi Staffan, >>>>> >>>>> Thank you for this discovery! >>>>> It looks good, but I have a couple of comments. >>>>> >>>>> It seems, there is one more problem in this code: >>>>> 68 /* check for NULL path */ >>>>> 69 if (p == pathname) { >>>>> 70 continue;<== Endless loop if we hit this line >>>>> 71 } >>>>> >>>>> Do we need to do 'pathname++' before continuing at the line #70? >>>>> It is going to be endless loop in cases there is a PATH_SEPARATOR >>>>> at the beginning of paths or two PATH_SEPARATOR's in a row. >>>>> These would be incorrect path lists but the code above is >>>>> targeting exactly such cases. >>>>> >>>>> Also, the argument name "pathname" in the original code is confusing. >>>>> Should we rename it to "pathnames"? >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> On 3/4/13 10:56 AM, Staffan Larsen wrote: >>>>>> I accidentally stepped on this bug the other day. There is a problem in linker_md.c : dll_build_name() where an internal pointer can be moved to point outside the string. The code looks like: >>>>>> >>>>>> 57 static void dll_build_name(char* buffer, size_t buflen, >>>>>> 58 const char* pname, const char* fname) { >>>>>> 59 // Based on os_solaris.cpp >>>>>> 60 >>>>>> 61 char *path_sep = PATH_SEPARATOR; >>>>>> 62 char *pathname = (char *)pname; >>>>>> 63 while (strlen(pathname) > 0) { >>>>>> 64 char *p = strchr(pathname, *path_sep); >>>>>> 65 if (p == NULL) { >>>>>> 66 p = pathname + strlen(pathname); >>>>>> 67 } >>>>>> 68 /* check for NULL path */ >>>>>> 69 if (p == pathname) { >>>>>> 70 continue; >>>>>> 71 } >>>>>> 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." LIB_SUFFIX, (p - pathname), >>>>>> 73 pathname, fname); >>>>>> 74 >>>>>> 75 if (access(buffer, F_OK) == 0) { >>>>>> 76 break; >>>>>> 77 } >>>>>> 78 pathname = p + 1; >>>>>> 79 *buffer = '\0'; >>>>>> 80 } >>>>>> >>>>>> If the supplied pname is a buffer with a simple path without any path separators in it, p will be set to the terminating nul on line 66. Then on line 78 it will be moved outside the buffer. Fixing this also necessitates fixes to the callers to check for an empty return string (in buffer). >>>>>> >>>>>> The same code show up in both the solaris code and the windows code as well as hprof. >>>>>> >>>>>> bug:http://bugs.sun.com/view_bug.do?bug_id=8009397 >>>>>> webrev:http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130318/9e4af837/attachment-0001.html -------------- next part -------------- An embedded message was scrubbed... From: "serguei.spitsyn at oracle.com" Subject: Re: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Date: Thu, 07 Mar 2013 10:49:05 -0800 Size: 14237 Url: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130318/9e4af837/AttachedMessage-0001.nws From yumin.qi at oracle.com Mon Mar 18 09:49:54 2013 From: yumin.qi at oracle.com (Yumin Qi) Date: Mon, 18 Mar 2013 09:49:54 -0700 Subject: RFR: 8003348: SA can not read core file on OS X In-Reply-To: <2D1E589C-3E85-4B05-8232-FB6441A793DF@oracle.com> References: <50F86BBB.8000709@oracle.com> <50FF849E.7030104@oracle.com> <51330262.2000102@oracle.com> <5136C7DB.3010801@oracle.com> <513774B7.8090900@oracle.com> <513923A2.9040909@oracle.com> <513928E7.50404@oracle.com> <51392A70.5040107@oracle.com> <513983AB.8070805@oracle.com> <513F877B.5010302@oracle.com> <513F9994.6030309@oracle.com> <2D1E589C-3E85-4B05-8232-FB6441A793DF@oracle.com> Message-ID: <514745B2.6010902@oracle.com> Hi, Staffan The code already integrated into hotspot_rt --- manually test thread stacks and other related functions (type info etc), showed OK. Thanks Yumin On 3/18/2013 6:52 AM, Staffan Larsen wrote: > Yumin, > > I'm ok with these changes now (although I'm not an official Reviewer). > > What testing have you done? Do we have existing tests that exercise > this code? > > /Staffan > > On 12 mar 2013, at 22:09, Yumin Qi > wrote: > >> Serguei, >> >> Thanks. >> >> Staffan, can you have a look at the new changes, concern? >> >> Thanks >> Yumin >> On 3/12/2013 12:52 PM, serguei.spitsyn at oracle.com wrote: >>> Yumin, >>> >>> The updated webrev looks good. >>> Just some simple cosmetic and debug comments below. >>> >>> >>> *agent/src/os/bsd/MacosxDebuggerLocal.m* >>> >>> Nice refactoring! >>> >>> 350 /** Only used for core file reading, set thread_id for threads which got after core file parsing. >>> 351 When parsing core file on Mac OS X, thread context is available but thread id. >>> 352 We identify them as java threads by checking if a thread's rsp or rbp within a java thread's >>> 353 stack(stack info is recoreded when it is created). Note Macosx uses unique_thread_id which is >>> 354 different from other platforms though printed ids are still pthread id. >>> 355 Function BsdDebuggerLocal.getJavaThreadsInfo returns an array of long integers to host >>> 356 all java threads' id, stack_start, stack_end as: >>> 357 [uid0, stack_start0, stack_end0, uid1, stack_start1, stack_end1, ...] >>> 358 >>> 359 The work cannot be done at init0 since Threads is not available yet(VM not initialized yet). >>> 360 This function should be called only once if succeeded */ >>> It'd be better to start lines 351-360 with the '*'. >>> The sentence at line 351 is not clear. >>> >>> >>> 393 /* core file only, called from Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_getThreadIntegerRegisterSet0 */ >>> 394 jlongArray getThreadIntegerRegisterSetFromCore(JNIEnv *env, jobject this_obj, long lwp_id) { >>> 395 // On Mac OS X, we can not get thread_id from x86Thread_State_t, but they are recorded in JavaThread of JVM >>> The comment lines 393 and 395 are two long and can be split in two. >>> >>> 440 regs[REG_INDEX(RDI)] = gregs.r_rdi; >>> 441 regs[REG_INDEX(RIP)] = gregs.r_rip; >>> 442 regs[REG_INDEX(CS)] = gregs.r_cs; >>> 443 regs[REG_INDEX(RSP)] = gregs.r_rsp; >>> 444 regs[REG_INDEX(SS)] = gregs.r_ss; >>> 445 regs[REG_INDEX(FSBASE)] = 0; >>> 446 regs[REG_INDEX(GSBASE)] = 0; >>> 447 regs[REG_INDEX(DS)] = gregs.r_ds; >>> 448 regs[REG_INDEX(ES)] = gregs.r_es; >>> 449 regs[REG_INDEX(FS)] = gregs.r_fs; >>> 450 regs[REG_INDEX(GS)] = gregs.r_gs; >>> 451 regs[REG_INDEX(TRAPNO)] = gregs.r_trapno; >>> 452 regs[REG_INDEX(RFL)] = gregs.r_rflags; >>> >>> At least, the lines 442, 444, 447-450 and 452 can be aligned as 440-441. >>> >>> 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! [PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); >>> The line above is too long. You can split it like this: >>> 652 print_error("attach: Failed to correctly attach to VM. VM might HANG! " >>> "[PTRACE_CONT failed, stopped by %d]\n", WSTOPSIG(status)); >>> >>> *agent/src/os/bsd/Makefile* >>> >>> The lines 25 and 55 are too long. >>> >>> | >>> |*agent/src/os/bsd/libproc_impl.c* >>> >>> | I see you've fixed many indents in this file. >>> | >>> >>> >>> || *agent/src/os/bsd/ps_core.c* >>> >>> 565 print_debug(" r_r15: 0x%" PRIx64 "\n", threadinfo->regs.r_r15); >>> 566 print_debug(" r_r14: 0x%" PRIx64 "\n", threadinfo->regs.r_r14); >>> 567 print_debug(" r_r13: 0x%" PRIx64 "\n", threadinfo->regs.r_r13); >>> 568 print_debug(" r_r12: 0x%" PRIx64 "\n", threadinfo->regs.r_r12); >>> 569 print_debug(" r_r11: 0x%" PRIx64 "\n", threadinfo->regs.r_r11); >>> 570 print_debug(" r_r10: 0x%" PRIx64 "\n", threadinfo->regs.r_r10); >>> 571 print_debug(" r_r9: 0x%" PRIx64 "\n", threadinfo->regs.r_r9); >>> 572 print_debug(" r_r8: 0x%" PRIx64 "\n", threadinfo->regs.r_r8); >>> 573 print_debug(" r_rdi: 0x%" PRIx64 "\n", threadinfo->regs.r_rdi); >>> 574 print_debug(" r_rsi: 0x%" PRIx64 "\n", threadinfo->regs.r_rsi); >>> 575 print_debug(" r_rbp: 0x%" PRIx64 "\n", threadinfo->regs.r_rbp); >>> 576 print_debug(" r_rbx: 0x%" PRIx64 "\n", threadinfo->regs.r_rbx); >>> 577 print_debug(" r_rdx: 0x%" PRIx64 "\n", threadinfo->regs.r_rdx); >>> 578 print_debug(" r_rcx: 0x%" PRIx64 "\n", threadinfo->regs.r_rcx); >>> 579 print_debug(" r_rax: 0x%" PRIx64 "\n", threadinfo->regs.r_rax); >>> 580 print_debug(" r_fs: 0x%" PRIx32 "\n", threadinfo->regs.r_fs); >>> 581 print_debug(" r_gs: 0x%" PRIx32 "\n", threadinfo->regs.r_gs); >>> 582 print_debug(" r_rip 0x%" PRIx64 "\n", threadinfo->regs.r_rip); >>> 583 print_debug(" r_cs: 0x%" PRIx64 "\n", threadinfo->regs.r_cs); >>> 584 print_debug(" r_rflags: 0x%" PRIx64 "\n", threadinfo->regs.r_rflags); >>> 585 print_debug(" r_rsp: 0x%" PRIx64 "\n", threadinfo->regs.r_rsp); >>> >>> >>> The lines can be aligned better and printed info will be more readable too: >>> 571-572,580-583 >>> >>> >>> 622 print_debug("segment added: %" PRIu64 " 0x%" PRIx64 " %d\n", segcmd.fileoff, segcmd.vmaddr, segcmd.vmsize); >>> 816 print_debug("map_info %d: vmaddr = 0x%016" PRIx64 " fileoff = %" PRIu64 " vmsize = %" PRIu64 "\n", j, iter->vaddr, iter->offset, iter->memsz); >>> The print_debug lines are too long. >>> >>> >>> One empty line extra: 272-273. >>> >>> >>> 956 if (read_core_segments(ph) != true) >>> 957 goto err; >>> 958 >>> 959 // allocate and sort maps into map_array, we need to do this >>> 960 // here because read_shared_lib_info needs to read from debuggee >>> 961 // address space >>> 962 if (sort_map_array(ph) != true) >>> 963 goto err; >>> 964 >>> 965 if (read_shared_lib_info(ph) != true) >>> 966 goto err; >>> 967 >>> 968 // sort again because we have added more mappings from shared objects >>> 969 if (sort_map_array(ph) != true) >>> 970 goto err; >>> 971 >>> 972 if (init_classsharing_workaround(ph) != true) >>> 973 goto err; >>> >>> Probably have to print a debug error message for before "goto err;". >>> >>> >>> Thanks, >>> Serguei >>> >>> On 3/7/13 10:22 PM, Yumin Qi wrote: >>>> Serguei and Saffan, >>>> >>>> Please take look at the same link for new webrev. >>>> >>>> Thanks >>>> Yumin >>>> >>>> On 3/7/2013 4:01 PM, serguei.spitsyn at oracle.com wrote: >>>>> Thank you for making the suggested changes! >>>>> Serguei >>>>> >>>>> On 3/7/13 3:55 PM, Yumin Qi wrote: >>>>>> Hi, Serguei >>>>>> >>>>>> Thanks for the review, I reviewed the part of Pgrab_core, you >>>>>> are right, I now put the code into two chunks: APPLE and none APPLE. >>>>>> Will send another webrev for you tonight --- add all your concerns. >>>>>> >>>>>> See answers below: >>>>>> >>>>>> On 3/7/2013 3:32 PM, serguei.spitsyn at oracle.com wrote: >>>>>>> Hi Yumin, >>>>>>> >>>>>>> No insisting on refactoring, it is just desirable. :) >>>>>>> >>>>>>> * >>>>>>> agent/src/os/bsd/symtab.c* >>>>>>> >>>>>>> Need a cleanup: >>>>>>> 54 // #define NAMELEN 4096 >>>>>>> 78 // dysymtab_command dysymtabcmd; >>>>>>> 114 // guarantee(symtab->hash_table, "unexpected failure: dbopen"); >>>>>> Yes, will. >>>>>>> >>>>>>> >>>>>>> This function is too big, it would be nice to factor out some >>>>>>> of its body fragments as functions: >>>>>>> 55 struct symtab* build_symtab(int fd) { >>>>>> Will try to make it nice. >>>>>>> The line 137 is too long. You can do like this: >>>>>>> int size = symtabcmd.strsize * sizeof(char); >>>>>>> if (read(fd, (void *)(symtab->strs), size) != size) { >>>>>>> Space is missed: >>>>>>> 145 //fix size >>>>>>> >>>>>> OK, will change. >>>>>>> No point to start new line if similar fragments like that do not >>>>>>> have it: >>>>>>> 153 symtab->symbols[i].size = >>>>>>> 154 symtabcmd.strsize - symtab->symbols[i].size; >>>>>> Will change. >>>>>>> Empty line is needed after the structure definition: >>>>>>> 199 void *c_data; >>>>>>> 200 }; >>>>>>> 201 // read symbol table from given fd. >>>>>>> 202 struct symtab* build_symtab(int fd) { >>>>>>> >>>>>> Will change. >>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>>>> >>>>>>> Need a consistent indentation (4?) as they are 2 and 3. >>>>>>> For instance, the BsdDebuggerLocal.java has indent == 4. >>>>>>> >>>>>> Will change to 4. >>>>>> The SA code has no consistent coding style, some place you will >>>>>> see 3, some place 2 or 4. >>>>>> For Java code, I will change them to have 4 spaces. For C, have >>>>>> done some with 2, but still large amount of code ended with 3. >>>>>> This needs future clean work. >>>>>>> >>>>>>> The flag name " newVT" does not match the comments, should it be >>>>>>> named "oldVT" ? : >>>>>>> 46 if (newVT) { >>>>>>> 47 // old C++ ABI >>>>>>> 48 vt = isDarwin ? "_vt_" : "__vt_"; >>>>>>> 49 } else { >>>>>>> 50 // new C++ ABI >>>>>>> 51 vt = "_ZTV"; >>>>>>> 52 } >>>>>> Oh, I see, the comments reversed. >>>>>>> >>>>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>>>> >>>>>>> Incorrect indent, it must be 4: >>>>>>> 86 public long getUniqueThreadId() { >>>>>>> 87 return unique_thread_id; >>>>>>> 88 } >>>>>>> >>>>>> Yes. >>>>>>> Sorry for paying too much attention to indentation! >>>>>>> It is because the SA indentation is a real mess. :) >>>>>>> >>>>>>> But this project is a nice progress in the SA area! >>>>>>> In fact, it is a lot of work. >>>>>>> I bet, you spent a lot of time debugging this code. >>>>>>> >>>>>> My work is making SA reading core on Macosx work, now we have a >>>>>> working version! thanks. >>>>>> >>>>>> Yumin >>>>>>> >>>>>>> Thanks, >>>>>>> Serguei >>>>>>> >>>>>>> On 3/6/13 8:54 AM, Yumin Qi wrote: >>>>>>>> Thanks, Serguei >>>>>>>> >>>>>>>> Will take care what you have indicated but refactoring code >>>>>>>> for ps_core.c (Pgrab_core). Maybe in future, code cleaning >>>>>>>> should include this, the better choice I think is regroup code >>>>>>>> to detail in specific platform, such as with new file >>>>>>>> ps_core_darwin.c etc but not now. >>>>>>>> >>>>>>>> /Yumin >>>>>>>> >>>>>>>> On 3/5/2013 8:36 PM, serguei.spitsyn at oracle.com wrote: >>>>>>>>> >>>>>>>>> Hi Yumin, >>>>>>>>> >>>>>>>>> >>>>>>>>> A partial review below. >>>>>>>>> >>>>>>>>> * >>>>>>>>> agent/src/os/bsd/MacosxDebuggerLocal.m >>>>>>>>> * >>>>>>>>> >>>>>>>>> 152 listAdd_ID = (*env)->GetMethodID(env, listClass, "add", "(Ljava/lang/Object;)Z"); >>>>>>>>> 153 CHECK_EXCEPTION; >>>>>>>>> 154 getJavaThreadsInfo_ID = (*env)->GetMethodID(env, cls, "getJavaThreadsInfo", >>>>>>>>> 155 "()[J"); >>>>>>>>> 156 >>>>>>>>> 157 init_libproc(getenv("LIBSAPROC_DEBUG") != NULL); >>>>>>>>> >>>>>>>>> Is CHECK_EXCEPTION needed after the line #154? >>>>>>>>> >>>>>>>>> The indent is 3 instead of 2: >>>>>>>>> Lines 360-410, 775-788 >>>>>>>>> >>>>>>>>> >>>>>>>>> ||*agent/src/os/bsd/libproc.h* >>>>>>>>> 36 #ifdef __APPLE__ >>>>>>>>> . . . >>>>>>>>> 46 #ifndef bool >>>>>>>>> 47 typedef int bool; >>>>>>>>> 48 #define true 1 >>>>>>>>> 49 #define false 0 >>>>>>>>> 50 #endif // bool >>>>>>>>> . . . >>>>>>>>> 57 #else // __APPLE__ >>>>>>>>> . . . >>>>>>>>> 76 // This C bool type must be int for compatibility with BSD calls and >>>>>>>>> 77 // it would be a mistake to equivalence it to C++ bool on many platforms >>>>>>>>> 78 typedef int bool; >>>>>>>>> 79 #define true 1 >>>>>>>>> 80 #define false 0 >>>>>>>>> 81 >>>>>>>>> 82 #endif // __APPLE__ >>>>>>>>> The bool, true and false are defined the same way for APPLE >>>>>>>>> and not APPLE. >>>>>>>>> Would it make sense to define it just once? >>>>>>>>> >>>>>>>>> ||*agent/src/os/bsd/ps_core.c* >>>>>>>>> >>>>>>>>> Need a clean up: >>>>>>>>> 869 // thread_command thrcmd; >>>>>>>>> >>>>>>>>> Space is missed after "if", wrong indent at line #873: >>>>>>>>> 872 if(read(fd, (void *)&fhead, sizeof(mach_header_64)) != sizeof(mach_header_64)) { >>>>>>>>> 873 goto err; >>>>>>>>> Lines 893, 1087 are too long. >>>>>>>>> >>>>>>>>> The function read_core_segments() is big and not well readable. >>>>>>>>> Would it make sense to consider to separate some of its >>>>>>>>> internals as a local functions. >>>>>>>>> For instance, the lines 921-950 are good candidates for it. >>>>>>>>> >>>>>>>>> The indent is 3: >>>>>>>>> 1015 if (exists(filepath)) { >>>>>>>>> 1016 strcpy(rpath, filepath); >>>>>>>>> 1017 return true; >>>>>>>>> 1018 } >>>>>>>>> I did not understand the comments, probably, some words are >>>>>>>>> missing: >>>>>>>>> 1070 mach_header_64 header; // used to check if a file header in segment >>>>>>>>> . . . >>>>>>>>> 1110 // this is the file begining to core file. >>>>>>>>> >>>>>>>>> >>>>>>>>> Not consistent, other fragments before used "goto err;" : >>>>>>>>> 1122 return false; // error >>>>>>>>> . . . >>>>>>>>> 1133 return false; >>>>>>>>> >>>>>>>>> Too many ifdef'ed fragments with __APPLE__ >>>>>>>>> Is it possibler to combine them into bigger chunks or refactor >>>>>>>>> in a different way? >>>>>>>>> For instance, the function Pgrab_core() is not readable. >>>>>>>>> It'd be better to have two separated versions of the function >>>>>>>>> for apple and not apple. >>>>>>>>> >>>>>>>>> >>>>>>>>> Still to review: >>>>>>>>> >>>>>>>>> ||*agent/src/os/bsd/symtab.c* >>>>>>>>> ||*agent/src/os/bsd/symtab.h* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/BsdVtblAccess.java* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java* >>>>>>>>> *agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java* >>>>>>>>> ||*agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java* >>>>>>>>> ||*agent/src/share/native/sadis.c* >>>>>>>>> ||*make/bsd/makefiles/saproc.make* >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Serguei >>>>>>>>> >>>>>>>>> >>>>>>>>> On 3/2/13 11:57 PM, Yumin Qi wrote: >>>>>>>>>> Hi, all >>>>>>>>>> >>>>>>>>>> Please review at the new changes. Include >>>>>>>>>> 1) use unique_thread_id (which is a 64 bit integer on >>>>>>>>>> Macosx) to identify thread. Add a function in >>>>>>>>>> BsdDebuggerLocal to call the newly added function >>>>>>>>>> BsdThread.getUniqueThreadId to get this id. Meanwhile, move >>>>>>>>>> the code of forming threadList in native part to >>>>>>>>>> BsdDebuggerLocal.java since the thread ids of all java >>>>>>>>>> threads can be obtained from Threads and coding is much >>>>>>>>>> easier and clear. >>>>>>>>>> >>>>>>>>>> 2) To have better performance, get all java thread ids, >>>>>>>>>> stack infos (stack begin, stack end) into one array of long >>>>>>>>>> which is decoded in native code and used to set thread ids. >>>>>>>>>> This save much more time first time to fill java thread ids. >>>>>>>>>> >>>>>>>>>> 3) remove DarwinVtblAccess.java which added in last >>>>>>>>>> version , its functionality moved to BsdVtblAccess.java >>>>>>>>>> >>>>>>>>>> 4) BugSpotAgent.java no long exists, remove the changes. >>>>>>>>>> >>>>>>>>>> 5) remove unsupported platform defs. >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> Yumin >>>>>>>>>> >>>>>>>>>> On 1/22/2013 10:35 PM, Yumin Qi wrote: >>>>>>>>>>> Hi, Staffan (and Serguei) >>>>>>>>>>> >>>>>>>>>>> Made some clean for code. >>>>>>>>>>> 1) added mach-o file fat header parsing as you suggested. >>>>>>>>>>> 2) modified get_real_path as you indicated it could run >>>>>>>>>>> with jre/bin/java >>>>>>>>>>> 3) moved output information from CommandProcessor.java to >>>>>>>>>>> PStack.java for printing out pstack not available for Darwin. >>>>>>>>>>> 4) code clean, file header update. >>>>>>>>>>> >>>>>>>>>>> Please take a look at same location. >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> Yumin >>>>>>>>>>> >>>>>>>>>>> On 1/18/2013 3:58 AM, Staffan Larsen wrote: >>>>>>>>>>>> Thanks for doing this Yumin! >>>>>>>>>>>> >>>>>>>>>>>> I tried to apply you patch and run it, but I can't get SA >>>>>>>>>>>> to open a core file. You can see the exception I get below. >>>>>>>>>>>> Is there some kind of setup I need to do? This is against a >>>>>>>>>>>> jvmg build of Hotspot. >>>>>>>>>>>> >>>>>>>>>>>> I also noticed that you forgot to update BugSpotAgent.java >>>>>>>>>>>> with the same changes as in HotspotAgent.java. This makes >>>>>>>>>>>> the jstack tool fail. >>>>>>>>>>>> >>>>>>>>>>>> I will look at the changes more closely. >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> /Staffan >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Opening core file, please wait... >>>>>>>>>>>> Unable to open core file >>>>>>>>>>>> /cores/core.79028: >>>>>>>>>>>> >>>>>>>>>>>> Doesn't appear to be a HotSpot VM (could not find symbol >>>>>>>>>>>> "gHotSpotVMTypes" in >>>>>>>>>>>> remote process) >>>>>>>>>>>> sun.jvm.hotspot.debugger.DebuggerException: Doesn't appear >>>>>>>>>>>> to be a HotSpot VM (could not find symbol "gHotSpotVMTypes" >>>>>>>>>>>> in remote process) >>>>>>>>>>>> at >>>>>>>>>>>> sun.jvm.hotspot.HotSpotAgent.setupVM(HotSpotAgent.java:385) >>>>>>>>>>>> at sun.jvm.hotspot.HotSpotAgent.go(HotSpotAgent.java:287) >>>>>>>>>>>> at >>>>>>>>>>>> sun.jvm.hotspot.HotSpotAgent.attach(HotSpotAgent.java:146) >>>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.attachDebugger(CLHSDB.java:188) >>>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.run(CLHSDB.java:55) >>>>>>>>>>>> at sun.jvm.hotspot.CLHSDB.main(CLHSDB.java:35) >>>>>>>>>>>> hsdb> Input stream closed. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 17 jan 2013, at 22:23, Yumin Qi wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> Please review for the changes for SA to read core file >>>>>>>>>>>>> on Mac OS X, this is feature is not implemented on >>>>>>>>>>>>> previous releases. >>>>>>>>>>>>> This change made for SA to work on core file on >>>>>>>>>>>>> Darwin, but still some function not fixed, such as >>>>>>>>>>>>> 'pstack'. This is intended to integrate into 8. >>>>>>>>>>>>> >>>>>>>>>>>>> http://cr.openjdk.java.net/~minqi/8003348/ >>>>>>>>>>>>> >>>>>>>>>>>>> Please take some time since the code change is a >>>>>>>>>>>>> little bigger. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks very much >>>>>>>>>>>>> Yumin >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130318/b56c94c6/attachment-0001.html From serguei.spitsyn at oracle.com Mon Mar 18 09:54:00 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 18 Mar 2013 09:54:00 -0700 Subject: RFR(S): 8006637 Failure to filter out native frame events on Solaris In-Reply-To: <182C0956-0285-48E6-9A56-E90DDEDEDBB0@oracle.com> References: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> <182C0956-0285-48E6-9A56-E90DDEDEDBB0@oracle.com> Message-ID: <514746A8.7090205@oracle.com> It is just a remainder that I reviewed this as well (the fix is good too). My email is attached. Thanks, Serguei On 3/18/13 7:14 AM, Staffan Larsen wrote: > I still need an official Review for this change. > > Thanks, > Staffan > > On 7 mar 2013, at 09:10, Staffan Larsen wrote: > >> Adding core-libs-dev and re-asking for a review. >> >> Thanks, >> /Staffan >> >> On 27 feb 2013, at 15:59, Staffan Larsen wrote: >> >>> Please review the following test fix. >>> >>> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 >>> >>> The problem is that the test assumes that no other threads call String.intern() while the tests is running. This is normally ok, but when running with JFR there are other threads calling String.intern() in the background and the test fails. The solution is to add a thread filter to the method exit requests so that only calls to String.inter() in the main thread are reported. >>> >>> Thanks, >>> /Staffan -------------- next part -------------- An embedded message was scrubbed... From: "serguei.spitsyn at oracle.com" Subject: Re: RFR(S): 8006637 Failure to filter out native frame events on Solaris Date: Thu, 07 Mar 2013 02:05:00 -0800 Size: 1697 Url: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130318/0f21447a/AttachedMessage.nws From jesper.wilhelmsson at oracle.com Mon Mar 18 14:04:30 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Mon, 18 Mar 2013 22:04:30 +0100 Subject: RFR(XS): 8010227: Remove promotion failed from young collection event Message-ID: <5147815E.20601@oracle.com> Could I have a couple of reviews for this really small change? Bug 8010227: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010227 The young garbage collection tracing event has a boolean to indicate if a promotion failed has occurred or not. This information is also available in its own event so the variable is duplicating the information. It was introduced for convenience to make it easy to see if a collection got promotion failed or not when looking at the GC events. However, the existence of this variable complicates the implementation of the evacuation failed event for G1, so we have decided to remove it. Webrev: http://cr.openjdk.java.net/~jwilhelm/8010227/webrev/ Thanks, /Jesper From david.holmes at oracle.com Mon Mar 18 18:09:53 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Mar 2013 11:09:53 +1000 Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket In-Reply-To: <51474508.7040000@oracle.com> References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com> <513646F9.3060601@oracle.com> <51379D88.6080807@oracle.com> <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com> <51474508.7040000@oracle.com> Message-ID: <5147BAE1.8070509@oracle.com> Hi Serguei, On 19/03/2013 2:47 AM, serguei.spitsyn at oracle.com wrote: > I already reviewed this, and it is a good fix. > Please, see my email attached. You are not an OpenJDK Reviewer [1] . Staffan needs an official Review from a Reviewer before it can be pushed. That doesn't mean your review is not wanted or appreciated - it mostly certain is - but an official Review is still required. Cheers, David [1] http://openjdk.java.net/bylaws#reviewer > Thanks, > Serguei > > On 3/18/13 7:13 AM, Staffan Larsen wrote: >> Can I get an official Review of this change? >> >> Thanks, >> /Staffan >> >> On 7 mar 2013, at 12:54, Staffan Larsen > > wrote: >> >>> Here is a webrev for fixing this problem. I actually removed all of >>> our own tokenization code in dll_build_name() and replaced it with >>> calls to strtok_r (strtok_s on windows) instead. I think this should >>> be more robust, at the cost of an extra memory allocation. I've also >>> added the const qualifier to some of the parameters. >>> >>> http://cr.openjdk.java.net/~sla/8009558/webrev.02/ >>> >>> >>> All of the jdi and hprof tests passes with this change. >>> >>> Thanks, >>> /Staffan >>> >>> On 6 mar 2013, at 20:48, serguei.spitsyn at oracle.com >>> wrote: >>> >>>> Staffan, >>>> >>>> Thank you for the confirmation and taking care about this issue! >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 3/6/13 11:36 AM, Staffan Larsen wrote: >>>>> Nice catch, Serguei! >>>>> >>>>> Unfortunately I have already pushed my change, but I filed >>>>> "JDK-8009558: linked_md.c::dll_build_name can get stuck in an >>>>> infinite loop" to track this new problem and I am working on a fix. >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> >>>>> On 5 mar 2013, at 20:26, serguei.spitsyn at oracle.com >>>>> wrote: >>>>> >>>>>> Hi Staffan, >>>>>> >>>>>> Thank you for this discovery! >>>>>> It looks good, but I have a couple of comments. >>>>>> >>>>>> It seems, there is one more problem in this code: >>>>>> 68 /* check for NULL path */ >>>>>> 69 if (p == pathname) { >>>>>> 70 continue;<== Endless loop if we hit this line >>>>>> 71 } >>>>>> >>>>>> Do we need to do 'pathname++' before continuing at the line #70? >>>>>> It is going to be endless loop in cases there is a PATH_SEPARATOR >>>>>> at the beginning of paths or two PATH_SEPARATOR's in a row. >>>>>> These would be incorrect path lists but the code above is >>>>>> targeting exactly such cases. >>>>>> >>>>>> Also, the argument name "pathname" in the original code is confusing. >>>>>> Should we rename it to "pathnames"? >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>> >>>>>> On 3/4/13 10:56 AM, Staffan Larsen wrote: >>>>>>> I accidentally stepped on this bug the other day. There is a >>>>>>> problem in linker_md.c : dll_build_name() where an internal >>>>>>> pointer can be moved to point outside the string. The code looks >>>>>>> like: >>>>>>> >>>>>>> 57 static void dll_build_name(char* buffer, size_t buflen, >>>>>>> 58 const char* pname, const char* >>>>>>> fname) { >>>>>>> 59 // Based on os_solaris.cpp >>>>>>> 60 >>>>>>> 61 char *path_sep = PATH_SEPARATOR; >>>>>>> 62 char *pathname = (char *)pname; >>>>>>> 63 while (strlen(pathname) > 0) { >>>>>>> 64 char *p = strchr(pathname, *path_sep); >>>>>>> 65 if (p == NULL) { >>>>>>> 66 p = pathname + strlen(pathname); >>>>>>> 67 } >>>>>>> 68 /* check for NULL path */ >>>>>>> 69 if (p == pathname) { >>>>>>> 70 continue; >>>>>>> 71 } >>>>>>> 72 (void)snprintf(buffer, buflen, "%.*s/lib%s." >>>>>>> LIB_SUFFIX, (p - pathname), >>>>>>> 73 pathname, fname); >>>>>>> 74 >>>>>>> 75 if (access(buffer, F_OK) == 0) { >>>>>>> 76 break; >>>>>>> 77 } >>>>>>> 78 pathname = p + 1; >>>>>>> 79 *buffer = '\0'; >>>>>>> 80 } >>>>>>> >>>>>>> If the supplied pname is a buffer with a simple path without any >>>>>>> path separators in it, p will be set to the terminating nul on >>>>>>> line 66. Then on line 78 it will be moved outside the buffer. >>>>>>> Fixing this also necessitates fixes to the callers to check for >>>>>>> an empty return string (in buffer). >>>>>>> >>>>>>> The same code show up in both the solaris code and the windows >>>>>>> code as well as hprof. >>>>>>> >>>>>>> bug:http://bugs.sun.com/view_bug.do?bug_id=8009397 >>>>>>> webrev:http://cr.openjdk.java.net/~sla/8009397/webrev.00/ >>>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>> >>>>> >>>> >>> >> > From david.holmes at oracle.com Mon Mar 18 18:31:52 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Mar 2013 11:31:52 +1000 Subject: RFR(XS): 8010227: Remove promotion failed from young collection event In-Reply-To: <5147815E.20601@oracle.com> References: <5147815E.20601@oracle.com> Message-ID: <5147C008.80408@oracle.com> This deletion looks fine to me. David On 19/03/2013 7:04 AM, Jesper Wilhelmsson wrote: > Could I have a couple of reviews for this really small change? > > Bug 8010227: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010227 > > The young garbage collection tracing event has a boolean to indicate if > a promotion failed has occurred or not. This information is also > available in its own event so the variable is duplicating the > information. It was introduced for convenience to make it easy to see if > a collection got promotion failed or not when looking at the GC events. > However, the existence of this variable complicates the implementation > of the evacuation failed event for G1, so we have decided to remove it. > > Webrev: http://cr.openjdk.java.net/~jwilhelm/8010227/webrev/ > > Thanks, > /Jesper From jonathan.gibbons at oracle.com Mon Mar 18 18:35:56 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 19 Mar 2013 01:35:56 +0000 Subject: hg: jdk8/tl/jaxws: 8007803: Implement javax.lang.model API for Type Annotations Message-ID: <20130319013600.64CC548234@hg.openjdk.java.net> Changeset: 0ab59cba6167 Author: jjg Date: 2013-03-18 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/0ab59cba6167 8007803: Implement javax.lang.model API for Type Annotations Reviewed-by: darcy ! src/share/jaxws_classes/com/sun/tools/internal/jxc/model/nav/ApNavigator.java From jonathan.gibbons at oracle.com Mon Mar 18 18:36:30 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 19 Mar 2013 01:36:30 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20130319013639.115A448235@hg.openjdk.java.net> Changeset: 40adaf938847 Author: jjg Date: 2013-03-18 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/40adaf938847 8008425: Remove interim new javax.lang.model API for type-annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java - src/share/classes/javax/lang/model/type/AnnotatedType.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/Types.java Changeset: 97f6839673d6 Author: jjg Date: 2013-03-18 18:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97f6839673d6 8007803: Implement javax.lang.model API for Type Annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java + src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java + src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeMirror.java ! src/share/classes/javax/lang/model/util/Types.java From daniel.daugherty at oracle.com Mon Mar 18 19:48:56 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Mon, 18 Mar 2013 20:48:56 -0600 Subject: Committed should not larger than max_size in ContiguousSpacePool while using ParNew with UseAdaptiveSizePolicy In-Reply-To: <18C57CA0D63174418D00CFAB14D96F6602C85C@CNHZ-EXMAIL-07.ali.com> References: <18C57CA0D63174418D00CFAB14D96F6602C85C@CNHZ-EXMAIL-07.ali.com> Message-ID: <5147D218.9060402@oracle.com> Hongxi, I'm redirecting this message to the HotSpot GC OpenJDK alias and the Serviceability OpenJDK alias. JMX is owned by the Serviceability team and you've also got some GC questions here... Dan P.S. Bcc'ed the Runtime OpenJDK so you folks know that this message has been redirected... On 3/18/13 7:59 PM, ????(hongxi) wrote: > > Hi all?? > > Sorry if here is not the right place to submit this small fix. > > Days ago, some of our systems occur this exception: > > 2013-01-22 16:59:07,351 ERROR protocol.MBeanServerMessageHandler {141} > - handle message error objectName=com.alibaba.dragoon:type=GC > > javax.management.RuntimeErrorException: java.lang.InternalError: > Memory Pool not found > > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:858) > > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:869) > > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:670) > > at > com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638) > > at > com.alibaba.dragoon.common.protocol.MBeanServerMessageHandler.getAttributeInternal(MBeanServerMessageHandler.java:242) > > at > com.alibaba.dragoon.common.protocol.MBeanServerMessageHandler.handle(MBeanServerMessageHandler.java:113) > > at > com.alibaba.dragoon.common.protocol.MessageHandlerAdapter.handle(MessageHandlerAdapter.java:53) > > at > com.alibaba.dragoon.common.protocol.DragoonSession.receiveMessageIntenal(DragoonSession.java:204) > > at > com.alibaba.dragoon.common.protocol.DragoonSession.receiveMessage(DragoonSession.java:178) > > at > com.alibaba.dragoon.common.protocol.transport.socket.SocketSessionImpl$1.run(SocketSessionImpl.java:211) > > Caused by: java.lang.InternalError: Memory Pool not found > > at sun.management.MemoryPoolImpl.getUsage0(Native Method) > > at sun.management.MemoryPoolImpl.getUsage(MemoryPoolImpl.java:77) > > at com.alibaba.dragoon.client.jmx.GC.getEdenSpaceUsed(GC.java:185) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:597) > > at > com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:93) > > at > com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:27) > > at > com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:208) > > at com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:65) > > at > com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:216) > > at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:666) > > ... 7 more > > The jvm argument is as bellow?? > > /usr/java/bin/java -server -Xmx5g -Xms5g -Xmn512m -XX:PermSize=128m > -Xss256k -XX:+DisableExplicitGC -XX:+UseConcMarkSweepGC > -XX:+CMSParallelRemarkEnabled -XX:+UseCMSCompactAtFullCollection > > -XX:+UseFastAccessorMethods -XX:+UseCMSInitiatingOccupancyOnly > -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseCompressedOops > -XX:ParallelGCThreads=4 -XX:+UseAdaptiveSizePolicy > > -Dcom.sun.management.jmxremote.port=1100 > -Dcom.sun.management.jmxremote.ssl=false > -Dcom.sun.management.jmxremote.authenticate=false > -Djava.rmi.server.hostname=localhost > > -Dhummock.output.logs=/home/admin/output/logs -Djava.awt.headless=true > -Djava.net.preferIPv4Stack=true > > At last, we found it??s possible a jvm bug, when UseAdaptiveSizePolicy > + ParNew, if the eden is expanded the max size of eden??s > ContiguousSpacePool will not be updated, perhaps the commited is > larger than max_size. Though at last I know UseAdaptiveSizePolicy has > some problems with CMS and it has been disabled in the latest jdk7u, I > think I should submit a patch to fix this small bug. My patch is in > the attachment. > > Regrads > > hongxi > > > ------------------------------------------------------------------------ > > This email (including any attachments) is confidential and may be > legally privileged. If you received this email in error, please delete > it immediately and do not copy it or use it for any purpose or > disclose its contents to any other person. Thank you. > > ??????(????????????)???????????????????????????????????????????????? > ?????????????????????????????????????????????????????????? ?????????? > ???????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130318/102061a5/attachment-0001.html From bengt.rutisson at oracle.com Mon Mar 18 23:53:26 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 19 Mar 2013 07:53:26 +0100 Subject: Committed should not larger than max_size in ContiguousSpacePool while using ParNew with UseAdaptiveSizePolicy In-Reply-To: <5147D218.9060402@oracle.com> References: <18C57CA0D63174418D00CFAB14D96F6602C85C@CNHZ-EXMAIL-07.ali.com> <5147D218.9060402@oracle.com> Message-ID: <51480B66.9010704@oracle.com> Hi Hongxi Thanks for supplying the patch. What Java version are you using? I think that using adaptive sizing with ParNew has never worked very well. In fact this feature has been disabled in the main branch about a year ago (I think it went in to 7u4). See: 7112413 : JVM Crash, possibly GC-related http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112413 So, I would not recommend using -XX:+UseAdaptiveSizePolicy with -XX:+UseConcMarkSweepGC. The only supported GC for adaptive size policy is the parallel GC. Even with your patch I think you will see crashes if you continue running with the command line you supplied. I have only looked briefly at your patch, but I think that it may be hiding a problem more than fixing it. I think we should in fact have max size set up properly. If capacity turns out to be larger than max size we have a real problem. Just hiding this by updating the max size seems a bit scary to me. Bengt On 3/19/13 3:48 AM, Daniel D. Daugherty wrote: > Hongxi, > > I'm redirecting this message to the HotSpot GC OpenJDK alias > and the Serviceability OpenJDK alias. JMX is owned by the > Serviceability team and you've also got some GC questions > here... > > Dan > > P.S. > Bcc'ed the Runtime OpenJDK so you folks know that this message > has been redirected... > > On 3/18/13 7:59 PM, ????(hongxi) wrote: >> >> Hi all?? >> >> Sorry if here is not the right place to submit this small fix. >> >> Days ago, some of our systems occur this exception: >> >> 2013-01-22 16:59:07,351 ERROR protocol.MBeanServerMessageHandler >> {141} - handle message error objectName=com.alibaba.dragoon:type=GC >> >> javax.management.RuntimeErrorException: java.lang.InternalError: >> Memory Pool not found >> >> at >> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:858) >> >> at >> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:869) >> >> at >> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:670) >> >> at >> com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638) >> >> at >> com.alibaba.dragoon.common.protocol.MBeanServerMessageHandler.getAttributeInternal(MBeanServerMessageHandler.java:242) >> >> at >> com.alibaba.dragoon.common.protocol.MBeanServerMessageHandler.handle(MBeanServerMessageHandler.java:113) >> >> at >> com.alibaba.dragoon.common.protocol.MessageHandlerAdapter.handle(MessageHandlerAdapter.java:53) >> >> at >> com.alibaba.dragoon.common.protocol.DragoonSession.receiveMessageIntenal(DragoonSession.java:204) >> >> at >> com.alibaba.dragoon.common.protocol.DragoonSession.receiveMessage(DragoonSession.java:178) >> >> at >> com.alibaba.dragoon.common.protocol.transport.socket.SocketSessionImpl$1.run(SocketSessionImpl.java:211) >> >> Caused by: java.lang.InternalError: Memory Pool not found >> >> at sun.management.MemoryPoolImpl.getUsage0(Native Method) >> >> at sun.management.MemoryPoolImpl.getUsage(MemoryPoolImpl.java:77) >> >> at com.alibaba.dragoon.client.jmx.GC.getEdenSpaceUsed(GC.java:185) >> >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) >> >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) >> >> at java.lang.reflect.Method.invoke(Method.java:597) >> >> at >> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:93) >> >> at >> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:27) >> >> at >> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:208) >> >> at >> com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:65) >> >> at >> com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:216) >> >> at >> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:666) >> >> ... 7 more >> >> The jvm argument is as bellow?? >> >> /usr/java/bin/java -server -Xmx5g -Xms5g -Xmn512m -XX:PermSize=128m >> -Xss256k -XX:+DisableExplicitGC -XX:+UseConcMarkSweepGC >> -XX:+CMSParallelRemarkEnabled -XX:+UseCMSCompactAtFullCollection >> >> -XX:+UseFastAccessorMethods -XX:+UseCMSInitiatingOccupancyOnly >> -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseCompressedOops >> -XX:ParallelGCThreads=4 -XX:+UseAdaptiveSizePolicy >> >> -Dcom.sun.management.jmxremote.port=1100 >> -Dcom.sun.management.jmxremote.ssl=false >> -Dcom.sun.management.jmxremote.authenticate=false >> -Djava.rmi.server.hostname=localhost >> >> -Dhummock.output.logs=/home/admin/output/logs >> -Djava.awt.headless=true -Djava.net.preferIPv4Stack=true >> >> At last, we found it??s possible a jvm bug, when UseAdaptiveSizePolicy >> + ParNew, if the eden is expanded the max size of eden??s >> ContiguousSpacePool will not be updated, perhaps the commited is >> larger than max_size. Though at last I know UseAdaptiveSizePolicy has >> some problems with CMS and it has been disabled in the latest jdk7u, >> I think I should submit a patch to fix this small bug. My patch is in >> the attachment. >> >> Regrads >> >> hongxi >> >> >> ------------------------------------------------------------------------ >> >> This email (including any attachments) is confidential and may be >> legally privileged. If you received this email in error, please >> delete it immediately and do not copy it or use it for any purpose or >> disclose its contents to any other person. Thank you. >> >> ??????(????????????)???????????????????????????????????????????????? >> ?????????????????????????????????????????????????????? ???? ???????? >> ?????????????????????????? > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130319/669bd1ba/attachment.html From hongxi.sy at taobao.com Tue Mar 19 00:27:35 2013 From: hongxi.sy at taobao.com (=?gb2312?B?uunO9Shob25neGkp?=) Date: Tue, 19 Mar 2013 07:27:35 +0000 Subject: =?gb2312?B?tPC4tDogQ29tbWl0dGVkIHNob3VsZCBub3QgbGFyZ2VyIHRoYW4gbWF4X3Np?= =?gb2312?B?emUgaW4gQ29udGlndW91c1NwYWNlUG9vbCB3aGlsZSB1c2luZyBQYXJOZXcg?= =?gb2312?Q?with_UseAdaptiveSizePolicy?= In-Reply-To: <51480B66.9010704@oracle.com> References: <18C57CA0D63174418D00CFAB14D96F6602C85C@CNHZ-EXMAIL-07.ali.com> <5147D218.9060402@oracle.com> <51480B66.9010704@oracle.com> Message-ID: <18C57CA0D63174418D00CFAB14D96F6602C907@CNHZ-EXMAIL-07.ali.com> Our java version is 6u32 ,an old version. Actually The patch can only fix the exception list in the last email. Now our system has closed UseAdaptiveSizePolicy while using CMS, it??s runs happily. Regards hongxi ??????: Bengt Rutisson [mailto:bengt.rutisson at oracle.com] ????????: 2013??3??19?? 14:53 ??????: daniel.daugherty at oracle.com ????: ????(hongxi); serviceability-dev at openjdk.java.net; hotspot-gc-dev at openjdk.java.net ????: Re: Committed should not larger than max_size in ContiguousSpacePool while using ParNew with UseAdaptiveSizePolicy Hi Hongxi Thanks for supplying the patch. What Java version are you using? I think that using adaptive sizing with ParNew has never worked very well. In fact this feature has been disabled in the main branch about a year ago (I think it went in to 7u4). See: 7112413 : JVM Crash, possibly GC-related http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112413 So, I would not recommend using -XX:+UseAdaptiveSizePolicy with -XX:+UseConcMarkSweepGC. The only supported GC for adaptive size policy is the parallel GC. Even with your patch I think you will see crashes if you continue running with the command line you supplied. I have only looked briefly at your patch, but I think that it may be hiding a problem more than fixing it. I think we should in fact have max size set up properly. If capacity turns out to be larger than max size we have a real problem. Just hiding this by updating the max size seems a bit scary to me. Bengt On 3/19/13 3:48 AM, Daniel D. Daugherty wrote: Hongxi, I'm redirecting this message to the HotSpot GC OpenJDK alias and the Serviceability OpenJDK alias. JMX is owned by the Serviceability team and you've also got some GC questions here... Dan P.S. Bcc'ed the Runtime OpenJDK so you folks know that this message has been redirected... On 3/18/13 7:59 PM, ????(hongxi) wrote: Hi all?? Sorry if here is not the right place to submit this small fix. Days ago, some of our systems occur this exception: 2013-01-22 16:59:07,351 ERROR protocol.MBeanServerMessageHandler {141} - handle message error objectName=com.alibaba.dragoon:type=GC javax.management.RuntimeErrorException: java.lang.InternalError: Memory Pool not found at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:858) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:869) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:670) at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638) at com.alibaba.dragoon.common.protocol.MBeanServerMessageHandler.getAttributeInternal(MBeanServerMessageHandler.java:242) at com.alibaba.dragoon.common.protocol.MBeanServerMessageHandler.handle(MBeanServerMessageHandler.java:113) at com.alibaba.dragoon.common.protocol.MessageHandlerAdapter.handle(MessageHandlerAdapter.java:53) at com.alibaba.dragoon.common.protocol.DragoonSession.receiveMessageIntenal(DragoonSession.java:204) at com.alibaba.dragoon.common.protocol.DragoonSession.receiveMessage(DragoonSession.java:178) at com.alibaba.dragoon.common.protocol.transport.socket.SocketSessionImpl$1.run(SocketSessionImpl.java:211) Caused by: java.lang.InternalError: Memory Pool not found at sun.management.MemoryPoolImpl.getUsage0(Native Method) at sun.management.MemoryPoolImpl.getUsage(MemoryPoolImpl.java:77) at com.alibaba.dragoon.client.jmx.GC.getEdenSpaceUsed(GC.java:185) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:93) at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:27) at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:208) at com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:65) at com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:216) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:666) ... 7 more The jvm argument is as bellow?? /usr/java/bin/java -server -Xmx5g -Xms5g -Xmn512m -XX:PermSize=128m -Xss256k -XX:+DisableExplicitGC -XX:+UseConcMarkSweepGC -XX:+CMSParallelRemarkEnabled -XX:+UseCMSCompactAtFullCollection -XX:+UseFastAccessorMethods -XX:+UseCMSInitiatingOccupancyOnly -XX:CMSInitiatingOccupancyFraction=70 -XX:+UseCompressedOops -XX:ParallelGCThreads=4 -XX:+UseAdaptiveSizePolicy -Dcom.sun.management.jmxremote.port=1100 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false -Djava.rmi.server.hostname=localhost -Dhummock.output.logs=/home/admin/output/logs -Djava.awt.headless=true -Djava.net.preferIPv4Stack=true At last, we found it??s possible a jvm bug, when UseAdaptiveSizePolicy + ParNew, if the eden is expanded the max size of eden??s ContiguousSpacePool will not be updated, perhaps the commited is larger than max_size. Though at last I know UseAdaptiveSizePolicy has some problems with CMS and it has been disabled in the latest jdk7u, I think I should submit a patch to fix this small bug. My patch is in the attachment. Regrads hongxi ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ??????(????????????)?????????????????????????????????????????????????????????????????????????????????????????????????????? ???? ?????????????????????????????????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130319/955f08b8/attachment-0001.html From yunda.mly at taobao.com Tue Mar 19 00:45:49 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Tue, 19 Mar 2013 07:45:49 +0000 Subject: [PATCH] typeToVtbl of BasicTypeDataBase should not be static In-Reply-To: References: Message-ID: cc'ing hotspot-runtime for an official Review. Regards, Yunda From: Staffan Larsen [mailto:staffan.larsen at oracle.com] Sent: Tuesday, March 05, 2013 9:18 PM To: ??(Yunda) Cc: serviceability-dev at openjdk.java.net Subject: Re: [PATCH] typeToVtbl of BasicTypeDataBase should not be static Yunda, Thanks for the patch. I have created issue JDK-8009456 to track this and can sponsor the fix as soon as we get a Review of the fix. /Staffan On 28 feb 2013, at 04:59, ??(Yunda) > wrote: Hi all, I found that when I detached a java process and attached another java process, the ?universe? command of CLHSDB didn?t show the right information. But when I restarted CLHSDB and attached to the same process the problem disappeared: hsdb> attach 29211 Attaching to process 29211, please wait... hsdb> universe Heap Parameters: ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289aa8,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> hsdb> detach hsdb> attach 29887 Attaching to process 29887, please wait... hsdb> universe Heap Parameters: unknown subtype of CollectedHeap @ 0x0000000000d56fb0 (0x00000000ca600000,0x0000000100000000) hsdb> quit [~]$ java -cp .:$JAVA_HOME/lib/sa-jdi.jar sun.jvm.hotspot.CLHSDB hsdb> attach 29887 Attaching to process 29887, please wait... hsdb> universe Heap Parameters: ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289a68,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> I think it?s caused by the wrong definition of ?typeToVtbl? field of BasicTypeDataBase. Since typeToVtbl should be recreated every time SA attaches to a new process, it should not be static. So I made a small patch fo fix it: diff -r ec2eddfed950 agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java --- a/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Tue Feb 26 14:09:52 2013 +0100 +++ b/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Thu Feb 28 11:57:55 2013 +0800 @@ -150,7 +150,7 @@ return VM.getVM().getOopSize(); } - static HashMap typeToVtbl = new HashMap(); + private HashMap typeToVtbl = new HashMap(); private Address vtblForType(Type type) { Address vtblAddr = (Address)typeToVtbl.get(type); After applying this patch, the problem I mentioned above disappeared. Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130319/15aa0a24/attachment-0001.html From yunda.mly at taobao.com Tue Mar 19 00:46:18 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Tue, 19 Mar 2013 07:46:18 +0000 Subject: [PATCH] A small fix on "scanoops" command in CLHSDB In-Reply-To: References: <51259564.2070501@oracle.com> <65F834EF-10EF-4768-92F4-12D0984A2C4A@oracle.com> Message-ID: cc'ing hotspot-runtime for an official Review, too. Regards, Yunda From: Staffan Larsen [mailto:staffan.larsen at oracle.com] Sent: Tuesday, March 05, 2013 9:21 PM To: ??(Yunda) Cc: Krystal Mo; serviceability-dev at openjdk.java.net Subject: Re: [PATCH] A small fix on "scanoops" command in CLHSDB I have created issue JDK-8009457 to track this. Still waiting for a review, though. Thanks, /Staffan On 22 feb 2013, at 04:32, ?? > wrote: Staffan & Kris, Thank both of you for reviewing this. Hope you two could be official Reviewer soon ? Regards, Yunda ???: Staffan Larsen [mailto:staffan.larsen at oracle.com] ????: 2013?2?21? 18:21 ???: Krystal Mo ??: ??; serviceability-dev at openjdk.java.net ??: Re: [PATCH] A small fix on "scanoops" command in CLHSDB I think this looks good, too. I'm not an official Reviewer, either. Thanks, /Staffan On 21 feb 2013, at 04:32, Krystal Mo > wrote: Hi Yunda, This patch looks reasonable to me. But you'll need an official Reviewer to review this. - Kris On 2013/2/19 1:24, ?? wrote: Hi all, When I use ?scanoops? command in CLHSDB, I find that if the type doesn?t exist, the output will be all the oops in the scope [start, end]. (see below) I think that?s irrational because all the oops between 0x00000000ee2000a0 and 0x00000000ee200550 are of type ?java/lang/Class? and there?s no type ?java/lang/Class2? or ?com/taobao/Test? at all! hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 0x00000000ee2000a0 java/lang/Class 0x00000000ee200118 java/lang/Class 0x00000000ee200190 java/lang/Class 0x00000000ee200208 java/lang/Class 0x00000000ee200280 java/lang/Class 0x00000000ee2002f8 java/lang/Class 0x00000000ee200370 java/lang/Class 0x00000000ee2003e8 java/lang/Class 0x00000000ee200460 java/lang/Class 0x00000000ee2004d8 java/lang/Class hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 java/lang/Class2 0x00000000ee2000a0 java/lang/Class 0x00000000ee200118 java/lang/Class 0x00000000ee200190 java/lang/Class 0x00000000ee200208 java/lang/Class 0x00000000ee200280 java/lang/Class 0x00000000ee2002f8 java/lang/Class 0x00000000ee200370 java/lang/Class 0x00000000ee2003e8 java/lang/Class 0x00000000ee200460 java/lang/Class 0x00000000ee2004d8 java/lang/Class hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 com/taobao/Test 0x00000000ee2000a0 java/lang/Class 0x00000000ee200118 java/lang/Class 0x00000000ee200190 java/lang/Class 0x00000000ee200208 java/lang/Class 0x00000000ee200280 java/lang/Class 0x00000000ee2002f8 java/lang/Class 0x00000000ee200370 java/lang/Class 0x00000000ee2003e8 java/lang/Class 0x00000000ee200460 java/lang/Class 0x00000000ee2004d8 java/lang/Class I know the reason is that the usage of scanoops is ?scanoops start end [ type ]? and ?type? is optional. When you don?t input the ?type?, the output will be all the oops in the scope [start, end]. But I think the two situations are different and CLHSDB should give right prompt. So I made a small fix: diff -r b5e3ec9c69fa agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java --- a/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Mon Feb 18 12:49:53 2013 +0100 +++ b/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Tue Feb 19 16:43:45 2013 +0800 @@ -1132,6 +1132,10 @@ Klass klass = null; if (t.countTokens() == 1) { klass = SystemDictionaryHelper.findInstanceKlass(t.nextToken()); + if(klass == null) { + out.println("No such type."); + return; + } } while (base != null && base.lessThan(end)) { long step = stride; And the effect will be: hsdb> scanoops 0x0000000758600000 0x000000075860ffff com/taobao/Test No such type. Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)????????????????????????????????????????????????????? ????????????????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130319/2da54cc1/attachment-0001.html From Alan.Bateman at oracle.com Tue Mar 19 00:51:55 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Mar 2013 07:51:55 +0000 Subject: RFR(S): 8006637 Failure to filter out native frame events on Solaris In-Reply-To: <182C0956-0285-48E6-9A56-E90DDEDEDBB0@oracle.com> References: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> <182C0956-0285-48E6-9A56-E90DDEDEDBB0@oracle.com> Message-ID: <5148191B.4060401@oracle.com> I see Serguei has reviewed this. It looks okay to me too. -Alan. On 18/03/2013 14:14, Staffan Larsen wrote: > I still need an official Review for this change. > > Thanks, > Staffan > > On 7 mar 2013, at 09:10, Staffan Larsen wrote: > >> Adding core-libs-dev and re-asking for a review. >> >> Thanks, >> /Staffan >> >> On 27 feb 2013, at 15:59, Staffan Larsen wrote: >> >>> Please review the following test fix. >>> >>> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 >>> >>> The problem is that the test assumes that no other threads call String.intern() while the tests is running. This is normally ok, but when running with JFR there are other threads calling String.intern() in the background and the test fails. The solution is to add a thread filter to the method exit requests so that only calls to String.inter() in the main thread are reported. >>> >>> Thanks, >>> /Staffan From staffan.larsen at oracle.com Tue Mar 19 01:54:05 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 19 Mar 2013 09:54:05 +0100 Subject: RFR(S): 8006637 Failure to filter out native frame events on Solaris In-Reply-To: <5148191B.4060401@oracle.com> References: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> <182C0956-0285-48E6-9A56-E90DDEDEDBB0@oracle.com> <5148191B.4060401@oracle.com> Message-ID: <6BC8DCF3-605A-4E1F-8BB9-F165D016931B@oracle.com> Thanks! On 19 mar 2013, at 08:51, Alan Bateman wrote: > > I see Serguei has reviewed this. It looks okay to me too. > > -Alan. > > On 18/03/2013 14:14, Staffan Larsen wrote: >> I still need an official Review for this change. >> >> Thanks, >> Staffan >> >> On 7 mar 2013, at 09:10, Staffan Larsen wrote: >> >>> Adding core-libs-dev and re-asking for a review. >>> >>> Thanks, >>> /Staffan >>> >>> On 27 feb 2013, at 15:59, Staffan Larsen wrote: >>> >>>> Please review the following test fix. >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ >>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 >>>> >>>> The problem is that the test assumes that no other threads call String.intern() while the tests is running. This is normally ok, but when running with JFR there are other threads calling String.intern() in the background and the test fails. The solution is to add a thread filter to the method exit requests so that only calls to String.inter() in the main thread are reported. >>>> >>>> Thanks, >>>> /Staffan > From staffan.larsen at oracle.com Tue Mar 19 01:53:39 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 19 Mar 2013 08:53:39 +0000 Subject: hg: jdk8/tl/jdk: 8006637: Failure to filter out native frame events on Solaris Message-ID: <20130319085407.F1BA148247@hg.openjdk.java.net> Changeset: a0275a47fa78 Author: sla Date: 2013-03-19 09:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0275a47fa78 8006637: Failure to filter out native frame events on Solaris Summary: Test is confused by other threads calling String.intern(). Add a thread filter to avoid this. Reviewed-by: sspitsyn, alanb ! test/com/sun/jdi/NativeInstanceFilter.java From bengt.rutisson at oracle.com Tue Mar 19 02:51:03 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 19 Mar 2013 10:51:03 +0100 Subject: RFR: 8008917 CMS: Concurrent mode failure tracing event In-Reply-To: <513F6AB7.7080401@oracle.com> References: <5130E68A.4040806@oracle.com> <51378071.2060107@oracle.com> <513F509E.3010808@oracle.com> <513F6AB7.7080401@oracle.com> Message-ID: <51483507.6050508@oracle.com> Hi Kevin, Me and Erik looked at this and we think it looks good. One minor thing would be to wrap the lines inside "if (first_state > Idling) {" in a separate method to make it more readable. Thanks, Bengt and Erik On 3/12/13 6:49 PM, Jesper Wilhelmsson wrote: > Looks good! > Ship it! > /Jesper > > > On 12/3/13 4:58 PM, Kevin Walls wrote: >> Hi, >> >> This is the updated hsx24 webrev with a more generic name: >> >> http://cr.openjdk.java.net/~kevinw/8008917/hsx24.01/webrev/ >> >> it builds upon the change for 8009723, so a second failure message is >> removed >> when compared to the parent, as that change isn't in hsx24 yet (only >> latest, so >> a backport of that is required before pushing this). >> >> Thanks >> Kevin >> >> >> Jesper Wilhelmsson wrote: >>> Looks good! >>> >>> Since we want to implement this event for G1 as well, maybe we >>> should remove >>> the "CMS" from the event name and path? >>> >>> Thanks, >>> /Jesper >>> >>> On 1/3/13 6:34 PM, Kevin Walls wrote: >>>> Hi, >>>> >>>> I'd like some reviews on this CMS Concurrent Mode Failure event: >>>> >>>> http://cr.openjdk.java.net/~kevinw/8008917/hotspot/ >>>> >>>> The event doesn't actually carry any new information, but it is a >>>> warning we >>>> need to capture. >>>> >>>> This is against hsx24, I'll prepare the same, or reviewed, changes >>>> against very >>>> latest hotspot also. >>>> >>>> Thanks >>>> Kevin >>>> >> From bengt.rutisson at oracle.com Tue Mar 19 02:53:13 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 19 Mar 2013 10:53:13 +0100 Subject: RFR(XS): 8010227: Remove promotion failed from young collection event In-Reply-To: <5147815E.20601@oracle.com> References: <5147815E.20601@oracle.com> Message-ID: <51483589.5080407@oracle.com> Hi Jesper, I think you can remove the YoungGCInfo class all together. Other than that it looks good. Bengt On 3/18/13 10:04 PM, Jesper Wilhelmsson wrote: > Could I have a couple of reviews for this really small change? > > Bug 8010227: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010227 > > The young garbage collection tracing event has a boolean to indicate > if a promotion failed has occurred or not. This information is also > available in its own event so the variable is duplicating the > information. It was introduced for convenience to make it easy to see > if a collection got promotion failed or not when looking at the GC > events. However, the existence of this variable complicates the > implementation of the evacuation failed event for G1, so we have > decided to remove it. > > Webrev: http://cr.openjdk.java.net/~jwilhelm/8010227/webrev/ > > Thanks, > /Jesper -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130319/834a76e8/attachment.html From david.holmes at oracle.com Tue Mar 19 03:01:43 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 19 Mar 2013 10:01:43 +0000 Subject: hg: jdk8/tl/jdk: 8009426: "profiles" target fails due to nashorn if "images" is not built first Message-ID: <20130319100204.DE7DD4824A@hg.openjdk.java.net> Changeset: e766da5575fa Author: dholmes Date: 2013-03-19 06:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e766da5575fa 8009426: "profiles" target fails due to nashorn if "images" is not built first Reviewed-by: alanb ! makefiles/CreateJars.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt From jesper.wilhelmsson at oracle.com Tue Mar 19 05:13:58 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 19 Mar 2013 13:13:58 +0100 Subject: RFR(XS): 8010227: Remove promotion failed from young collection event In-Reply-To: <51483589.5080407@oracle.com> References: <5147815E.20601@oracle.com> <51483589.5080407@oracle.com> Message-ID: <51485686.2050505@oracle.com> Yes, I'll do that. Thanks! /Jesper On 19/3/13 10:53 AM, Bengt Rutisson wrote: > > Hi Jesper, > > I think you can remove the YoungGCInfo class all together. Other than that it > looks good. > > Bengt > > On 3/18/13 10:04 PM, Jesper Wilhelmsson wrote: >> Could I have a couple of reviews for this really small change? >> >> Bug 8010227: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010227 >> >> The young garbage collection tracing event has a boolean to indicate if a >> promotion failed has occurred or not. This information is also available in >> its own event so the variable is duplicating the information. It was >> introduced for convenience to make it easy to see if a collection got >> promotion failed or not when looking at the GC events. However, the existence >> of this variable complicates the implementation of the evacuation failed event >> for G1, so we have decided to remove it. >> >> Webrev: http://cr.openjdk.java.net/~jwilhelm/8010227/webrev/ >> >> Thanks, >> /Jesper > From jesper.wilhelmsson at oracle.com Tue Mar 19 05:15:03 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 19 Mar 2013 13:15:03 +0100 Subject: RFR(XS): 8010227: Remove promotion failed from young collection event In-Reply-To: <5147C008.80408@oracle.com> References: <5147815E.20601@oracle.com> <5147C008.80408@oracle.com> Message-ID: <514856C7.4090201@oracle.com> Thanks for looking at it! /Jesper On 19/3/13 2:31 AM, David Holmes wrote: > This deletion looks fine to me. > > David > > On 19/03/2013 7:04 AM, Jesper Wilhelmsson wrote: >> Could I have a couple of reviews for this really small change? >> >> Bug 8010227: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010227 >> >> The young garbage collection tracing event has a boolean to indicate if >> a promotion failed has occurred or not. This information is also >> available in its own event so the variable is duplicating the >> information. It was introduced for convenience to make it easy to see if >> a collection got promotion failed or not when looking at the GC events. >> However, the existence of this variable complicates the implementation >> of the evacuation failed event for G1, so we have decided to remove it. >> >> Webrev: http://cr.openjdk.java.net/~jwilhelm/8010227/webrev/ >> >> Thanks, >> /Jesper From staffan.larsen at oracle.com Tue Mar 19 06:00:34 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 19 Mar 2013 14:00:34 +0100 Subject: [PATCH] A small fix on "scanoops" command in CLHSDB In-Reply-To: References: <51259564.2070501@oracle.com> <65F834EF-10EF-4768-92F4-12D0984A2C4A@oracle.com> Message-ID: Coleen wrote to me privately that she is ok with the change. I have submitted a JPRT job with the change. Thanks, /Staffan On 19 mar 2013, at 08:46, ??(Yunda) wrote: > cc'ing hotspot-runtime for an official Review, too. > > Regards, > Yunda > > From: Staffan Larsen [mailto:staffan.larsen at oracle.com] > Sent: Tuesday, March 05, 2013 9:21 PM > To: ??(Yunda) > Cc: Krystal Mo; serviceability-dev at openjdk.java.net > Subject: Re: [PATCH] A small fix on "scanoops" command in CLHSDB > > I have created issue JDK-8009457 to track this. Still waiting for a review, though. > > Thanks, > /Staffan > > On 22 feb 2013, at 04:32, ?? wrote: > > > Staffan & Kris, > > Thank both of you for reviewing this. Hope you two could be official Reviewer soon J > > Regards, > Yunda > > ???: Staffan Larsen [mailto:staffan.larsen at oracle.com] > ????: 2013?2?21? 18:21 > ???: Krystal Mo > ??: ??; serviceability-dev at openjdk.java.net > ??: Re: [PATCH] A small fix on "scanoops" command in CLHSDB > > I think this looks good, too. I'm not an official Reviewer, either. > > Thanks, > /Staffan > > On 21 feb 2013, at 04:32, Krystal Mo wrote: > > > Hi Yunda, > > This patch looks reasonable to me. But you'll need an official Reviewer to review this. > > - Kris > > On 2013/2/19 1:24, ?? wrote: > Hi all, > > When I use ?scanoops? command in CLHSDB, I find that if the type doesn?t exist, the output will be all the oops in the scope [start, end]. (see below) I think that?s irrational because all the oops between 0x00000000ee2000a0 and 0x00000000ee200550 are of type ?java/lang/Class? and there?s no type ?java/lang/Class2? or ?com/taobao/Test? at all! > > hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 > 0x00000000ee2000a0 java/lang/Class > 0x00000000ee200118 java/lang/Class > 0x00000000ee200190 java/lang/Class > 0x00000000ee200208 java/lang/Class > 0x00000000ee200280 java/lang/Class > 0x00000000ee2002f8 java/lang/Class > 0x00000000ee200370 java/lang/Class > 0x00000000ee2003e8 java/lang/Class > 0x00000000ee200460 java/lang/Class > 0x00000000ee2004d8 java/lang/Class > hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 java/lang/Class2 > 0x00000000ee2000a0 java/lang/Class > 0x00000000ee200118 java/lang/Class > 0x00000000ee200190 java/lang/Class > 0x00000000ee200208 java/lang/Class > 0x00000000ee200280 java/lang/Class > 0x00000000ee2002f8 java/lang/Class > 0x00000000ee200370 java/lang/Class > 0x00000000ee2003e8 java/lang/Class > 0x00000000ee200460 java/lang/Class > 0x00000000ee2004d8 java/lang/Class > hsdb> scanoops 0x00000000ee2000a0 0x00000000ee200550 com/taobao/Test > 0x00000000ee2000a0 java/lang/Class > 0x00000000ee200118 java/lang/Class > 0x00000000ee200190 java/lang/Class > 0x00000000ee200208 java/lang/Class > 0x00000000ee200280 java/lang/Class > 0x00000000ee2002f8 java/lang/Class > 0x00000000ee200370 java/lang/Class > 0x00000000ee2003e8 java/lang/Class > 0x00000000ee200460 java/lang/Class > 0x00000000ee2004d8 java/lang/Class > > I know the reason is that the usage of scanoops is ?scanoops start end [ type ]? and ?type? is optional. When you don?t input the ?type?, the output will be all the oops in the scope [start, end]. But I think the two situations are different and CLHSDB should give right prompt. So I made a small fix: > > diff -r b5e3ec9c69fa agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java > --- a/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Mon Feb 18 12:49:53 2013 +0100 > +++ b/agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java Tue Feb 19 16:43:45 2013 +0800 > @@ -1132,6 +1132,10 @@ > Klass klass = null; > if (t.countTokens() == 1) { > klass = SystemDictionaryHelper.findInstanceKlass(t.nextToken()); > + if(klass == null) { > + out.println("No such type."); > + return; > + } > } > while (base != null && base.lessThan(end)) { > long step = stride; > > And the effect will be: > hsdb> scanoops 0x0000000758600000 0x000000075860ffff com/taobao/Test > No such type. > > Regards, > Yunda > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)????????????????????????????????????????????????????? ????????????????? > > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130319/5ba3c0b8/attachment-0001.html From staffan.larsen at oracle.com Tue Mar 19 06:02:43 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 19 Mar 2013 14:02:43 +0100 Subject: [PATCH] typeToVtbl of BasicTypeDataBase should not be static In-Reply-To: References: Message-ID: <924A5018-C9D0-4EFB-8131-BB5C4614A9C4@oracle.com> Coleen wrote to me privately that she is ok with the change. I have submitted a JPRT job with the change. Thanks, /Staffan On 19 mar 2013, at 08:45, ??(Yunda) wrote: > cc'ing hotspot-runtime for an official Review. > > Regards, > Yunda > > From: Staffan Larsen [mailto:staffan.larsen at oracle.com] > Sent: Tuesday, March 05, 2013 9:18 PM > To: ??(Yunda) > Cc: serviceability-dev at openjdk.java.net > Subject: Re: [PATCH] typeToVtbl of BasicTypeDataBase should not be static > > Yunda, > > Thanks for the patch. I have created issue JDK-8009456 to track this and can sponsor the fix as soon as we get a Review of the fix. > > /Staffan > > On 28 feb 2013, at 04:59, ??(Yunda) wrote: > > > Hi all, > > I found that when I detached a java process and attached another java process, the ?universe? command of CLHSDB didn?t show the right information. But when I restarted CLHSDB and attached to the same process the problem disappeared: > > hsdb> attach 29211 > Attaching to process 29211, please wait... > hsdb> universe > Heap Parameters: > ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289aa8,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> > hsdb> detach > hsdb> attach 29887 > Attaching to process 29887, please wait... > hsdb> universe > Heap Parameters: > unknown subtype of CollectedHeap @ 0x0000000000d56fb0 (0x00000000ca600000,0x0000000100000000) > hsdb> quit > [~]$ java -cp .:$JAVA_HOME/lib/sa-jdi.jar sun.jvm.hotspot.CLHSDB > hsdb> attach 29887 > Attaching to process 29887, please wait... > hsdb> universe > Heap Parameters: > ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289a68,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> > > I think it?s caused by the wrong definition of ?typeToVtbl? field of BasicTypeDataBase. Since typeToVtbl should be recreated every time SA attaches to a new process, it should not be static. So I made a small patch fo fix it: > > diff -r ec2eddfed950 agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java > --- a/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Tue Feb 26 14:09:52 2013 +0100 > +++ b/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Thu Feb 28 11:57:55 2013 +0800 > @@ -150,7 +150,7 @@ > return VM.getVM().getOopSize(); > } > - static HashMap typeToVtbl = new HashMap(); > + private HashMap typeToVtbl = new HashMap(); > private Address vtblForType(Type type) { > Address vtblAddr = (Address)typeToVtbl.get(type); > > > After applying this patch, the problem I mentioned above disappeared. > > Regards, > Yunda > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130319/5ccb7a6c/attachment-0001.html From staffan.larsen at oracle.com Tue Mar 19 09:07:21 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 19 Mar 2013 16:07:21 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130319160730.6CC7048252@hg.openjdk.java.net> Changeset: 117bb0519114 Author: sla Date: 2013-03-19 13:41 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/117bb0519114 8009456: SA: typeToVtbl of BasicTypeDataBase should not be static Reviewed-by: coleenp, sla Contributed-by: yunda.mly at taobao.com ! agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Changeset: 686916dc0439 Author: sla Date: 2013-03-19 13:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/686916dc0439 8009457: SA: A small fix on "scanoops" command in CLHSDB Reviewed-by: sla, coleenp, kmo Contributed-by: yunda.mly at taobao.com ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java From chris.hegarty at oracle.com Tue Mar 19 09:32:49 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 19 Mar 2013 16:32:49 +0000 Subject: hg: jdk8/tl/jdk: 8007607: security native code doesn't always use malloc, realloc, and calloc correctly Message-ID: <20130319163312.61ECD48255@hg.openjdk.java.net> Changeset: 4103eb6b2137 Author: jzavgren Date: 2013-03-18 14:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4103eb6b2137 8007607: security native code doesn't always use malloc, realloc, and calloc correctly Reviewed-by: chegar, dsamersoff, valeriep ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c ! src/share/native/sun/security/jgss/wrapper/NativeUtil.c ! src/solaris/native/com/sun/security/auth/module/Solaris.c ! src/solaris/native/com/sun/security/auth/module/Unix.c ! src/solaris/native/sun/security/smartcardio/pcsc_md.c From joe.darcy at oracle.com Tue Mar 19 13:10:56 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 19 Mar 2013 20:10:56 +0000 Subject: hg: jdk8/tl/langtools: 8010179: Remove transitional target values from javac Message-ID: <20130319201101.A6E1248267@hg.openjdk.java.net> Changeset: a4913ea9bb62 Author: darcy Date: 2013-03-19 13:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4913ea9bb62 8010179: Remove transitional target values from javac Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! test/tools/javac/ClassFileModifiers/MemberModifiers.java ! test/tools/javac/profiles/ProfileOptionTest.java From jonathan.gibbons at oracle.com Tue Mar 19 15:13:41 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 19 Mar 2013 22:13:41 +0000 Subject: hg: jdk8/tl/langtools: 8010315: doclint errors in javac public API Message-ID: <20130319221347.ADC2648271@hg.openjdk.java.net> Changeset: 578eb3dd111d Author: jjg Date: 2013-03-19 15:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/578eb3dd111d 8010315: doclint errors in javac public API Reviewed-by: darcy ! make/build.xml ! src/share/classes/com/sun/source/util/DocTreeScanner.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/type/ExecutableType.java From mike.duigou at oracle.com Tue Mar 19 16:10:09 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 19 Mar 2013 23:10:09 +0000 Subject: hg: jdk8/tl/jdk: 8001642: Add Optional, OptionalDouble, OptionalInt, OptionalLong Message-ID: <20130319231031.7F46B48272@hg.openjdk.java.net> Changeset: 2241a2d34085 Author: mduigou Date: 2013-03-19 16:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2241a2d34085 8001642: Add Optional, OptionalDouble, OptionalInt, OptionalLong Reviewed-by: mduigou, darcy, alanb, jjb Contributed-by: Brian Goetz + src/share/classes/java/util/Optional.java + src/share/classes/java/util/OptionalDouble.java + src/share/classes/java/util/OptionalInt.java + src/share/classes/java/util/OptionalLong.java + test/java/util/Optional/Basic.java + test/java/util/Optional/BasicDouble.java + test/java/util/Optional/BasicInt.java + test/java/util/Optional/BasicLong.java From lana.steuck at oracle.com Tue Mar 19 16:20:15 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 19 Mar 2013 23:20:15 +0000 Subject: hg: jdk8/tl/hotspot: 40 new changesets Message-ID: <20130319232131.9284F48273@hg.openjdk.java.net> Changeset: 8196357e95b5 Author: amurillo Date: 2013-03-08 08:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8196357e95b5 8009688: new hotspot build - hs25-b23 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 255c0a4cb4eb Author: sla Date: 2013-03-05 08:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/255c0a4cb4eb 8009287: [parfait] Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c Reviewed-by: dholmes, kvn, mikael, morris ! agent/src/os/linux/ps_core.c Changeset: 9058789475af Author: iklam Date: 2013-03-05 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9058789475af 7107135: Stack guard pages are no more protected after loading a shared library with executable stack Summary: Detect the execstack attribute of the loaded library and attempt to fix the stack guard using Safepoint op. Reviewed-by: dholmes, zgu Contributed-by: ioi.lam at oracle.com ! src/os/linux/vm/globals_linux.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vm_operations.hpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp + test/runtime/7107135/Test.java + test/runtime/7107135/Test7107135.sh + test/runtime/7107135/TestMT.java + test/runtime/7107135/test.c Changeset: 6b803ba47588 Author: zgu Date: 2013-03-07 14:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6b803ba47588 8008257: NMT: assert(new_rec->is_allocation_record()) failed when running with shared memory option Summary: Corrected virtual memory recording and tagging code when large pages are used Reviewed-by: coleenp, ccheung ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp Changeset: 3efdfd6ddbf2 Author: coleenp Date: 2013-03-08 11:47 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3efdfd6ddbf2 8003553: NPG: metaspace objects should be zeroed in constructors Summary: Zero metadata in constructors, not in allocation (and some in constructors) Reviewed-by: jmasa, sspitsyn ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/memory/metablock.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 252ad8d5f22b Author: dcubed Date: 2013-03-08 17:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/252ad8d5f22b Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: 35ef86296a5d Author: dcubed Date: 2013-03-08 17:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/35ef86296a5d Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 5939f5953b45 Author: coleenp Date: 2013-03-13 09:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5939f5953b45 8009836: nsk/regression/b4222717 fails with empty stack trace Summary: Some zeroing was missed for bug 8003553, causing empty stack traces and Xcom crashes, add back zeroing to metablock Reviewed-by: dholmes, rbackman ! src/share/vm/memory/metablock.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/method.cpp Changeset: 96480359523a Author: coleenp Date: 2013-03-11 14:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96480359523a 8008965: @Contended fails with classes having static fields Summary: Disable @Contended support for static fields Reviewed-by: coleenp, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/classfile/classFileParser.cpp + test/runtime/8003985/Test8003985.java Changeset: d6320e955c89 Author: coleenp Date: 2013-03-13 13:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d6320e955c89 Merge Changeset: 0ede345ec7c9 Author: coleenp Date: 2013-03-13 15:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0ede345ec7c9 8009829: CDS: JDK JPRT test fails crash in Symbol::equals() Summary: -Xshare:dump was creating a Symbol in C_heap. There's an assert there that jdk jprt wasn't hitting because it was only done in product Reviewed-by: dholmes, hseigel, iklam ! src/share/vm/classfile/symbolTable.cpp Changeset: c8b31b461e1a Author: coleenp Date: 2013-03-13 17:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c8b31b461e1a 8003419: NPG: Clean up metadata created during class loading if failure Summary: Store metadata on ClassFileParser instance to be cleaned up by destructor. This enabled some refactoring of the enormous parseClassFile function. Reviewed-by: jmasa, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: fad90b102190 Author: jprovino Date: 2013-03-06 13:38 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fad90b102190 8008310: Some adjustments needed to minimal VM warnings and errors for unsupported command line options Summary: Changes to arguments.cpp for warnings vs. errors. Changes for CDS arguments. Reviewed-by: coleenp, cjplummer ! make/excludeSrc.make ! src/share/vm/memory/filemap.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 47bc9800972c Author: jprovino Date: 2013-03-06 13:46 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/47bc9800972c 8006498: #if is wrong in the code. Summary: ASSERT and other symbols used incorrectly with #if are supposed to be defined or not. Reviewed-by: dholmes, mikael ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.hpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/code/compressedStream.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiTrace.hpp Changeset: 67342b960b47 Author: jprovino Date: 2013-03-06 13:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/67342b960b47 8008474: Add -Wundef to warning flags. Summary: Force use of undefined macros to be and error. Reviewed-by: dholmes, mikael ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/gcc.make Changeset: cb75b67f04fb Author: jprovino Date: 2013-03-08 12:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cb75b67f04fb Merge ! make/bsd/makefiles/gcc.make Changeset: 69ffa4ac9e53 Author: jprovino Date: 2013-03-12 00:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/69ffa4ac9e53 8009835: Only produce a warning when -Xshare:auto is explicitly requested Summary: The minimal JVM is printing a warning message for default settings when it should quitely ignore them. Reviewed-by: coleenp, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 9102c4111564 Author: jprovino Date: 2013-03-14 10:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9102c4111564 Merge Changeset: ed53b50794d7 Author: vladidan Date: 2013-03-14 12:49 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed53b50794d7 Merge Changeset: 0094485b46c7 Author: roland Date: 2013-03-13 09:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0094485b46c7 8009761: Deoptimization on sparc doesn't set Llast_SP correctly in the interpreter frames it creates Summary: deoptimization doesn't set up callee frames so that they restore caller frames correctly. Reviewed-by: kvn ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/runtime/vframeArray.hpp + test/compiler/8009761/Test8009761.java Changeset: 056ab43544a4 Author: neliasso Date: 2013-03-13 10:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/056ab43544a4 8009721: Make PhaseLive independent from regalloc Summary: Moved class definition of LRG_List from chaitin.hpp to live.hpp Reviewed-by: kvn, rbackman, roland Contributed-by: niclas.adlertz at oracle.com ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/live.hpp Changeset: 6d98efabf3ba Author: neliasso Date: 2013-03-13 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6d98efabf3ba Merge Changeset: b7c2c5b2572c Author: neliasso Date: 2013-02-13 10:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b7c2c5b2572c 8005772: Stubs report compile id -1 in phase events Summary: Use 0 to indicate id is NA, -1 for error or uninitalized Reviewed-by: kvn, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/compile.cpp Changeset: 71f13276159d Author: morris Date: 2013-03-14 07:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/71f13276159d 8008560: [parfait] Null pointer deference in hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Summary: add null pointer check in signal handler Reviewed-by: kvn ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: fba788946616 Author: morris Date: 2013-03-14 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fba788946616 Merge Changeset: 9def4075da6d Author: tamao Date: 2013-03-05 15:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9def4075da6d 8008079: G1: Add nextObject routine to CMBitMapRO and replace nextWord Summary: Update the task local finger to the start of the next object when marking aborts, in order to avoid the redundant scanning of all 0's when the marking task restarts, if otherwise updating to the next word. In addition, reuse the routine nextObject() in routine iterate(). Reviewed-by: johnc, ysr Contributed-by: tamao ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: 209f8ba5020b Author: tamao Date: 2013-03-07 10:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/209f8ba5020b 8008368: Deprecate MaxGCMinorPauseMillis Summary: Deprecate MaxGCMinorPauseMillis and emit a warning if set by users Reviewed-by: brutisso, johnc Contributed-by: tamao ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 1f3354851c91 Author: stefank Date: 2013-03-11 08:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1f3354851c91 Merge Changeset: 167812fe00bb Author: kevinw Date: 2013-03-11 12:56 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/167812fe00bb 8009723: CMS logs "concurrent mode failure" twice when using (disabling) -XX:-UseCMSCompactAtFullCollection Reviewed-by: jwilhelm, ehelin, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 71f619500f9b Author: kevinw Date: 2013-03-11 15:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/71f619500f9b Merge Changeset: 1c88b99a2b01 Author: mgerdin Date: 2013-03-12 09:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1c88b99a2b01 8009282: Assertion "assert(used_and_free == capacity_bytes) failed: Accounting is wrong" failed with -XX:+Verbose -XX:+TraceMetadataChunkAllocation Summary: Assertion is only valid when at a safepoint, adjust accordingly. Reviewed-by: stefank, jmasa, tamao ! src/share/vm/memory/metaspace.cpp Changeset: ca9580859cf4 Author: stefank Date: 2013-03-11 02:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ca9580859cf4 8004697: SIGSEGV on Solaris sparc with -XX:+UseNUMA Summary: Don't scan pages outside the given range. Reviewed-by: jwilhelm, jmasa ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp Changeset: 62609ffa2fc6 Author: tschatzl Date: 2013-03-12 15:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/62609ffa2fc6 8008684: CMS: concurrent phase start markers should always be printed Summary: Print the concurrent phase start markers for CMS when PrintGCDetails is enabled, not only if both PrintGCDetails and PrintGCTimeStamps are. Reviewed-by: mgerdin, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: eac371996b44 Author: brutisso Date: 2013-03-12 08:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eac371996b44 8001049: VM crashes when running with large -Xms and not specifying ObjectAlignmentInBytes Summary: Take the initial heap size into account when checking the heap size for compressed oops Reviewed-by: jmasa, kvn, hseigel, ctornqvi ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 993d878108d9 Author: brutisso Date: 2013-03-13 05:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/993d878108d9 Merge Changeset: 82657b6a8cc0 Author: jmasa Date: 2013-03-12 11:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/82657b6a8cc0 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared Reviewed-by: johnc ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/memory/collectorPolicy.cpp Changeset: 15401203db6b Author: stefank Date: 2013-03-15 08:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/15401203db6b Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/runtime/arguments.cpp Changeset: a10dc1469c3f Author: stefank Date: 2013-03-15 04:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a10dc1469c3f Merge Changeset: 0631ebcc45f0 Author: amurillo Date: 2013-03-15 11:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0631ebcc45f0 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 3db4ab0e12f4 Author: amurillo Date: 2013-03-15 11:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3db4ab0e12f4 Added tag hs25-b23 for changeset 0631ebcc45f0 ! .hgtags From jonathan.gibbons at oracle.com Tue Mar 19 17:04:52 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 20 Mar 2013 00:04:52 +0000 Subject: hg: jdk8/tl/langtools: 8010361: fix some langtools findbugs issues Message-ID: <20130320000457.EA5E048276@hg.openjdk.java.net> Changeset: a03c4a86ea2b Author: jjg Date: 2013-03-19 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a03c4a86ea2b 8010361: fix some langtools findbugs issues Reviewed-by: darcy ! src/share/classes/com/sun/tools/classfile/Code_attribute.java ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/javah/Util.java ! src/share/classes/com/sun/tools/javap/StackMapWriter.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java ! src/share/classes/com/sun/tools/sjavac/Main.java ! src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java From jonathan.gibbons at oracle.com Tue Mar 19 17:06:23 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 20 Mar 2013 00:06:23 +0000 Subject: hg: jdk8/tl/langtools: 8010333: Remove com.sun.tools.javac.Server Message-ID: <20130320000626.1358E48278@hg.openjdk.java.net> Changeset: 9cf17b7a5fe7 Author: jjg Date: 2013-03-19 17:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9cf17b7a5fe7 8010333: Remove com.sun.tools.javac.Server Reviewed-by: darcy - src/share/classes/com/sun/tools/javac/Server.java From yunda.mly at taobao.com Tue Mar 19 18:47:55 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Wed, 20 Mar 2013 01:47:55 +0000 Subject: [PATCH] typeToVtbl of BasicTypeDataBase should not be static In-Reply-To: <924A5018-C9D0-4EFB-8131-BB5C4614A9C4@oracle.com> References: <924A5018-C9D0-4EFB-8131-BB5C4614A9C4@oracle.com> Message-ID: Staffan, Thanks. I saw the changes have already been pushed. Regards, Yunda From: Staffan Larsen [mailto:staffan.larsen at oracle.com] Sent: Tuesday, March 19, 2013 9:03 PM To: ??(Yunda) Cc: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net Subject: Re: [PATCH] typeToVtbl of BasicTypeDataBase should not be static Coleen wrote to me privately that she is ok with the change. I have submitted a JPRT job with the change. Thanks, /Staffan On 19 mar 2013, at 08:45, ??(Yunda) > wrote: cc'ing hotspot-runtime for an official Review. Regards, Yunda From: Staffan Larsen [mailto:staffan.larsen at oracle.com] Sent: Tuesday, March 05, 2013 9:18 PM To: ??(Yunda) Cc: serviceability-dev at openjdk.java.net Subject: Re: [PATCH] typeToVtbl of BasicTypeDataBase should not be static Yunda, Thanks for the patch. I have created issue JDK-8009456 to track this and can sponsor the fix as soon as we get a Review of the fix. /Staffan On 28 feb 2013, at 04:59, ??(Yunda) > wrote: Hi all, I found that when I detached a java process and attached another java process, the ?universe? command of CLHSDB didn?t show the right information. But when I restarted CLHSDB and attached to the same process the problem disappeared: hsdb> attach 29211 Attaching to process 29211, please wait... hsdb> universe Heap Parameters: ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289aa8,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> hsdb> detach hsdb> attach 29887 Attaching to process 29887, please wait... hsdb> universe Heap Parameters: unknown subtype of CollectedHeap @ 0x0000000000d56fb0 (0x00000000ca600000,0x0000000100000000) hsdb> quit [~]$ java -cp .:$JAVA_HOME/lib/sa-jdi.jar sun.jvm.hotspot.CLHSDB hsdb> attach 29887 Attaching to process 29887, please wait... hsdb> universe Heap Parameters: ParallelScavengeHeap [ PSYoungGen [ eden = [0x00000000ee200000,0x00000000ee289a68,0x00000000eef70000] , from = [0x00000000ef1a0000,0x00000000ef1a0000,0x00000000ef3d0000] , to = [0x00000000eef70000,0x00000000eef70000,0x00000000ef1a0000] ] PSOldGen [ [0x00000000ca600000,0x00000000ca600000,0x00000000cc9c0000] ] ] hsdb> I think it?s caused by the wrong definition of ?typeToVtbl? field of BasicTypeDataBase. Since typeToVtbl should be recreated every time SA attaches to a new process, it should not be static. So I made a small patch fo fix it: diff -r ec2eddfed950 agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java --- a/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Tue Feb 26 14:09:52 2013 +0100 +++ b/agent/src/share/classes/sun/jvm/hotspot/types/basic/BasicTypeDataBase.java Thu Feb 28 11:57:55 2013 +0800 @@ -150,7 +150,7 @@ return VM.getVM().getOopSize(); } - static HashMap typeToVtbl = new HashMap(); + private HashMap typeToVtbl = new HashMap(); private Address vtblForType(Type type) { Address vtblAddr = (Address)typeToVtbl.get(type); After applying this patch, the problem I mentioned above disappeared. Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130320/ace3fda2/attachment-0001.html From jonathan.gibbons at oracle.com Tue Mar 19 19:17:21 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 20 Mar 2013 02:17:21 +0000 Subject: hg: jdk8/tl/langtools: 8010317: DocLint incorrectly reports some 
 tags as empty
Message-ID: <20130320021726.56BFA4827E@hg.openjdk.java.net>

Changeset: 74d7f9bcac93
Author:    jjg
Date:      2013-03-19 19:16 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/74d7f9bcac93

8010317: DocLint incorrectly reports some 
 tags as empty
Reviewed-by: darcy

! src/share/classes/com/sun/tools/doclint/Checker.java
+ test/tools/doclint/EmptyPreTest.java


From daniel.daugherty at oracle.com  Tue Mar 19 22:57:32 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Wed, 20 Mar 2013 05:57:32 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 7030610: runtime/6878713/Test6878713.sh
	fails Error. failed to clean up files after test; ...
Message-ID: <20130320055736.1407448284@hg.openjdk.java.net>

Changeset: eca90b8a06eb
Author:    rdurbin
Date:      2013-03-19 11:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/eca90b8a06eb

7030610: runtime/6878713/Test6878713.sh fails Error. failed to clean up files after test
7123945: runtime/6878713/Test6878713.sh require about 2G of native memory, swaps and times out
Summary: Add new diagnostic option -XX:MallocMaxTestWords=NNN and fix Test6878713.sh.
Reviewed-by: dcubed, coleenp, dholmes, iklam

! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.cpp
! test/runtime/6878713/Test6878713.sh


From christian.tornqvist at oracle.com  Wed Mar 20 02:15:48 2013
From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com)
Date: Wed, 20 Mar 2013 09:15:48 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8010084: Race in
	runtime/NMT/BaselineWithParameter.java
Message-ID: <20130320091554.26E5F4828F@hg.openjdk.java.net>

Changeset: a649f6511c04
Author:    ctornqvi
Date:      2013-03-20 08:17 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a649f6511c04

8010084: Race in runtime/NMT/BaselineWithParameter.java
Summary: Added a waitFor() on the process
Reviewed-by: mgerdin, sla, zgu

! test/runtime/NMT/BaselineWithParameter.java


From alexey.utkin at oracle.com  Wed Mar 20 02:29:53 2013
From: alexey.utkin at oracle.com (alexey.utkin at oracle.com)
Date: Wed, 20 Mar 2013 09:29:53 +0000
Subject: hg: jdk8/tl/jdk: 8006193: (process) Clean-up
	java.lang.ProcessImpl.finalize, does not need to be public
Message-ID: <20130320093007.2E72848291@hg.openjdk.java.net>

Changeset: fb23896a01f5
Author:    uta
Date:      2013-03-20 13:21 +0400
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb23896a01f5

8006193: (process) Clean-up java.lang.ProcessImpl.finalize, does not need to be public
Reviewed-by: alanb

! src/windows/classes/java/lang/ProcessImpl.java


From chris.hegarty at oracle.com  Wed Mar 20 09:00:34 2013
From: chris.hegarty at oracle.com (chris.hegarty at oracle.com)
Date: Wed, 20 Mar 2013 16:00:34 +0000
Subject: hg: jdk8/tl/jdk: 8010282:
	sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should
	be thread-safe
Message-ID: <20130320160054.9B3564829D@hg.openjdk.java.net>

Changeset: 3070b7363853
Author:    chegar
Date:      2013-03-20 14:39 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3070b7363853

8010282: sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should be thread-safe
Reviewed-by: khazra, alanb

! src/share/classes/sun/net/www/protocol/jar/JarURLConnection.java
! src/solaris/classes/sun/net/www/protocol/jar/JarFileFactory.java
! src/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java


From coleen.phillimore at oracle.com  Wed Mar 20 09:02:06 2013
From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com)
Date: Wed, 20 Mar 2013 16:02:06 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8008217: CDS: Class data sharing limits
	the malloc heap on Solaris
Message-ID: <20130320160208.46A334829E@hg.openjdk.java.net>

Changeset: 91bf0bdae37b
Author:    coleenp
Date:      2013-03-20 08:04 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/91bf0bdae37b

8008217: CDS: Class data sharing limits the malloc heap on Solaris
Summary: In 64bit VM move CDS archive address to 32G on all platforms using new flag SharedBaseAddress.  In 32bit VM set CDS archive address to 3Gb on Linux and let other OSs pick the address.
Reviewed-by: kvn, dcubed, zgu, hseigel

! src/os_cpu/bsd_x86/vm/globals_bsd_x86.hpp
! src/os_cpu/bsd_zero/vm/globals_bsd_zero.hpp
! src/os_cpu/linux_sparc/vm/globals_linux_sparc.hpp
! src/os_cpu/linux_x86/vm/globals_linux_x86.hpp
! src/os_cpu/linux_zero/vm/globals_linux_zero.hpp
! src/os_cpu/solaris_sparc/vm/globals_solaris_sparc.hpp
! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp
! src/os_cpu/windows_x86/vm/globals_windows_x86.hpp
! src/share/vm/memory/filemap.cpp
! src/share/vm/memory/metaspace.cpp
! src/share/vm/runtime/globals.hpp


From sean.mullan at oracle.com  Wed Mar 20 09:07:12 2013
From: sean.mullan at oracle.com (sean.mullan at oracle.com)
Date: Wed, 20 Mar 2013 16:07:12 +0000
Subject: hg: jdk8/tl/jdk: 3 new changesets
Message-ID: <20130320160747.CAF5F4829F@hg.openjdk.java.net>

Changeset: 38116bfe5323
Author:    mullan
Date:      2013-03-20 10:58 -0400
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38116bfe5323

8010112: NullPointerException in sun.security.provider.certpath.CertId()
Reviewed-by: vinnie

! src/share/classes/sun/security/provider/certpath/CertId.java
! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java
! src/share/classes/sun/security/provider/certpath/RevocationChecker.java
! src/share/classes/sun/security/x509/X509CertImpl.java

Changeset: 9859856920ed
Author:    mullan
Date:      2013-03-20 11:23 -0400
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9859856920ed

Merge

- src/share/classes/sun/security/util/KeyLength.java

Changeset: 38c1d0c2d6a6
Author:    mullan
Date:      2013-03-20 12:06 -0400
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38c1d0c2d6a6

Merge



From mandy.chung at oracle.com  Wed Mar 20 09:51:42 2013
From: mandy.chung at oracle.com (mandy.chung at oracle.com)
Date: Wed, 20 Mar 2013 16:51:42 +0000
Subject: hg: jdk8/tl/jdk: 8006104: Improve tests to test ".useParentHandlers"
	property set in the logging configuration
Message-ID: <20130320165154.8D490482A5@hg.openjdk.java.net>

Changeset: ccd9f53377c4
Author:    mchung
Date:      2013-03-20 09:50 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ccd9f53377c4

8006104: Improve tests to test ".useParentHandlers" property set in the logging configuration
Reviewed-by: alanb

! test/java/util/logging/CustomLogManager.java
! test/java/util/logging/CustomLogManagerTest.java


From karen.kinnear at oracle.com  Wed Mar 20 11:47:45 2013
From: karen.kinnear at oracle.com (karen.kinnear at oracle.com)
Date: Wed, 20 Mar 2013 18:47:45 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130320184749.4609F482B0@hg.openjdk.java.net>

Changeset: 2c7663baeb67
Author:    acorn
Date:      2013-03-20 11:43 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2c7663baeb67

8010017: lambda: reflection get(Declared)Methods support for default methods.
Summary: Don't expose vm generated overpass (bridges to default methods).
Reviewed-by: dholmes, fparain

! src/share/vm/prims/jvm.cpp

Changeset: 79259e97a072
Author:    acorn
Date:      2013-03-20 12:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/79259e97a072

Merge



From joe.darcy at oracle.com  Wed Mar 20 15:21:33 2013
From: joe.darcy at oracle.com (joe.darcy at oracle.com)
Date: Wed, 20 Mar 2013 22:21:33 +0000
Subject: hg: jdk8/tl/jdk: 8010427: Refine Method.isDefault implementation
Message-ID: <20130320222204.58614482BF@hg.openjdk.java.net>

Changeset: cf0049037deb
Author:    darcy
Date:      2013-03-20 15:21 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf0049037deb

8010427: Refine Method.isDefault implementation
Reviewed-by: acorn, dlsmith

! src/share/classes/java/lang/reflect/Method.java


From christian.tornqvist at oracle.com  Wed Mar 20 15:26:46 2013
From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com)
Date: Wed, 20 Mar 2013 22:26:46 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8007982: some runtime/CommandLine/ tests
	fail on 32-bit platforms
Message-ID: <20130320222648.AAC0B482C1@hg.openjdk.java.net>

Changeset: 1feda2e9f044
Author:    ctornqvi
Date:      2013-03-20 20:40 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1feda2e9f044

8007982: some runtime/CommandLine/ tests fail on 32-bit platforms
Summary: Changed tests to use platform independent flags
Reviewed-by: collins, hseigel, zgu

! test/runtime/CommandLine/BooleanFlagWithInvalidValue.java
! test/runtime/CommandLine/FlagWithInvalidValue.java
! test/runtime/CommandLine/NonBooleanFlagWithInvalidBooleanPrefix.java


From joe.darcy at oracle.com  Wed Mar 20 17:41:53 2013
From: joe.darcy at oracle.com (joe.darcy at oracle.com)
Date: Thu, 21 Mar 2013 00:41:53 +0000
Subject: hg: jdk8/tl/langtools: 8010364: Clarify javax.lang.model API for Type
	Annotations
Message-ID: <20130321004156.BF54C482CC@hg.openjdk.java.net>

Changeset: 972474640b7d
Author:    darcy
Date:      2013-03-20 17:41 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/972474640b7d

8010364: Clarify javax.lang.model API for Type Annotations
Reviewed-by: jjg, abuckley

! src/share/classes/javax/lang/model/AnnotatedConstruct.java
! src/share/classes/javax/lang/model/type/ExecutableType.java


From david.holmes at oracle.com  Wed Mar 20 19:40:14 2013
From: david.holmes at oracle.com (david.holmes at oracle.com)
Date: Thu, 21 Mar 2013 02:40:14 +0000
Subject: hg: jdk8/tl/jdk: 8006818: SunEC and SunPKCS11 providers should be in
	all profiles
Message-ID: <20130321024037.46C27482D2@hg.openjdk.java.net>

Changeset: 3c1a4966d901
Author:    dholmes
Date:      2013-03-20 22:39 -0400
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1a4966d901

8006818: SunEC and SunPKCS11 providers should be in all profiles
Reviewed-by: dholmes, alanb, valeriep
Contributed-by: Jen Dority 

! makefiles/profile-includes.txt


From daniel.daugherty at oracle.com  Thu Mar 21 00:17:48 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Thu, 21 Mar 2013 07:17:48 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130321071755.0D200482D8@hg.openjdk.java.net>

Changeset: 81d1b58c078f
Author:    rdurbin
Date:      2013-03-20 20:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/81d1b58c078f

8010396: checking MallocMaxTestWords in testMalloc() function is redundant
Summary: Remove redundant checks in testMalloc and add assert.
Reviewed-by: dcubed, coleenp, dholmes

! src/share/vm/runtime/os.cpp

Changeset: e7081eb7e786
Author:    dcubed
Date:      2013-03-20 20:52 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e7081eb7e786

Merge



From sundararajan.athijegannathan at oracle.com  Thu Mar 21 06:50:20 2013
From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com)
Date: Thu, 21 Mar 2013 13:50:20 +0000
Subject: hg: jdk8/tl/jdk: 8009869: Need to modify java.security property
	package.access to include nashorn packages
Message-ID: <20130321135033.A694C482E8@hg.openjdk.java.net>

Changeset: 9ee1aff76498
Author:    sundar
Date:      2013-03-21 19:19 +0530
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ee1aff76498

8009869: Need to modify java.security property package.access to include nashorn packages
Reviewed-by: ahgross, jlaskey, lagergren

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows


From zhengyu.gu at oracle.com  Thu Mar 21 10:27:00 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Thu, 21 Mar 2013 17:27:00 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130321172704.D9D8C482EF@hg.openjdk.java.net>

Changeset: 06db4c0afbf3
Author:    zgu
Date:      2013-03-20 09:42 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/06db4c0afbf3

8009298: NMT: Special version of class loading/unloading with runThese stresses out NMT
8009777: NMT: add new NMT dcmd to control auto shutdown option
Summary: Added diagnostic VM option and DCmd command to allow NMT stay alive under stress situation
Reviewed-by: dcubed, coleenp

! src/share/vm/runtime/globals.hpp
! src/share/vm/services/memTracker.cpp
! src/share/vm/services/memTracker.hpp
! src/share/vm/services/nmtDCmd.cpp
! src/share/vm/services/nmtDCmd.hpp

Changeset: 0ac03fef364f
Author:    zgu
Date:      2013-03-21 06:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0ac03fef364f

Merge

! src/share/vm/runtime/globals.hpp


From rob.mckenna at oracle.com  Thu Mar 21 10:32:52 2013
From: rob.mckenna at oracle.com (rob.mckenna at oracle.com)
Date: Thu, 21 Mar 2013 17:32:52 +0000
Subject: hg: jdk8/tl/jdk: 8009251: Add proxy handling and keep-alive fixes to
	jsse
Message-ID: <20130321173305.A6311482F0@hg.openjdk.java.net>

Changeset: 3f8fbb0ab155
Author:    robm
Date:      2013-03-21 17:33 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f8fbb0ab155

8009251: Add proxy handling and keep-alive fixes to jsse
Reviewed-by: chegar

! src/share/classes/sun/net/www/http/HttpClient.java
! src/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java
! src/share/classes/sun/net/www/protocol/https/HttpsClient.java


From john.coomes at oracle.com  Fri Mar 22 01:35:31 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 22 Mar 2013 08:35:31 +0000
Subject: hg: hsx/hotspot-rt/corba: 14 new changesets
Message-ID: <20130322083541.80D8E4832C@hg.openjdk.java.net>

Changeset: 0ac9424678e7
Author:    katleman
Date:      2013-03-14 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/0ac9424678e7

Added tag jdk8-b81 for changeset 2a00aeeb466b

! .hgtags

Changeset: e725dd195858
Author:    dmeetry
Date:      2013-02-15 01:49 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/e725dd195858

7199858: Marshal exception is wrong
Reviewed-by: lancea

! src/share/classes/com/sun/corba/se/impl/corba/TypeCodeImpl.java

Changeset: c528d8ce83f1
Author:    lana
Date:      2013-02-19 20:48 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/c528d8ce83f1

Merge


Changeset: 67ef27b4e16c
Author:    lana
Date:      2013-03-05 11:46 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/67ef27b4e16c

Merge


Changeset: 05386b4610e9
Author:    lana
Date:      2013-03-12 16:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/05386b4610e9

Merge


Changeset: 3c73273667ae
Author:    coffeys
Date:      2012-10-30 17:06 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/3c73273667ae

8000631: Restrict access to class constructor
Reviewed-by: alanb, ahgross

! make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk
! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java
! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream_1_0.java
! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream_1_0.java
! src/share/classes/com/sun/corba/se/impl/io/FVDCodeBaseImpl.java
! src/share/classes/com/sun/corba/se/impl/io/ValueHandlerImpl.java
! src/share/classes/com/sun/corba/se/impl/io/ValueUtility.java
! src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/Util.java
! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java
! src/share/classes/com/sun/corba/se/impl/orbutil/ORBUtility.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java
! src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdFactory.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java
+ src/share/classes/sun/corba/JavaCorbaAccess.java
+ src/share/classes/sun/corba/SharedSecrets.java

Changeset: 80882eae6279
Author:    ngmr
Date:      2012-10-30 17:15 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/80882eae6279

8000540: Improve IIOP type reuse management
Reviewed-by: alanb, ahgross, coffeys

! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java

Changeset: 0ca1fc7c5f44
Author:    mbankal
Date:      2012-12-17 07:43 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/0ca1fc7c5f44

7141694: Improving CORBA internals
Reviewed-by: coffeys, ahgross

! src/share/classes/com/sun/corba/se/spi/orb/ORB.java

Changeset: f4f39d873b9a
Author:    coffeys
Date:      2012-11-06 15:50 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/f4f39d873b9a

7201066: Change modifiers on unused fields
Reviewed-by: alanb, skoivu

! src/share/classes/com/sun/corba/se/impl/activation/ServerMain.java
! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java
! src/share/classes/com/sun/corba/se/impl/orbutil/ObjectStreamClass_1_3_1.java

Changeset: 59bff16bc0bf
Author:    ewendeli
Date:      2013-02-19 21:44 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/59bff16bc0bf

Merge

- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java

Changeset: 996bd5fd0941
Author:    ewendeli
Date:      2013-02-25 07:21 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/996bd5fd0941

Merge

- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java

Changeset: 7341134e52ff
Author:    lana
Date:      2013-03-12 18:16 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/7341134e52ff

Merge

- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPInputStream_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/IIOPOutputStream_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryIdCache_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3.java
- src/share/classes/com/sun/corba/se/impl/orbutil/ValueHandlerImpl_1_3_1.java

Changeset: 48e1bc77004d
Author:    lana
Date:      2013-03-14 19:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/48e1bc77004d

Merge


Changeset: a45bb25a67c7
Author:    katleman
Date:      2013-03-21 10:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/a45bb25a67c7

Added tag jdk8-b82 for changeset 48e1bc77004d

! .hgtags


From john.coomes at oracle.com  Fri Mar 22 01:35:24 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 22 Mar 2013 08:35:24 +0000
Subject: hg: hsx/hotspot-rt: 22 new changesets
Message-ID: <20130322083525.4DE634832B@hg.openjdk.java.net>

Changeset: 52741ab7c601
Author:    erikj
Date:      2013-03-06 10:50 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/52741ab7c601

8008073: build-infra: Need --with-dxsdk option? And awt/sound -I option additions?
Reviewed-by: tbell

! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! common/autoconf/toolchain.m4
! common/autoconf/toolchain_windows.m4

Changeset: 235854886494
Author:    katleman
Date:      2013-03-11 13:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/235854886494

Merge


Changeset: 145dbc56f931
Author:    tbell
Date:      2013-03-12 22:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/145dbc56f931

8009819: build-infra: RE jdk8 build forest fails for windows since addition of --with-dxsdk
Reviewed-by: katleman

! common/autoconf/generated-configure.sh
! common/autoconf/toolchain_windows.m4

Changeset: 0dc28db6525f
Author:    katleman
Date:      2013-03-14 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/0dc28db6525f

Added tag jdk8-b81 for changeset 145dbc56f931

! .hgtags

Changeset: ecc8fda8f187
Author:    darcy
Date:      2013-02-19 00:24 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ecc8fda8f187

8008435: Fix new build to include jdk.Supported in ct.sym
Reviewed-by: erikj

! common/makefiles/javadoc/NON_CORE_PKGS.gmk

Changeset: eca3bce3d151
Author:    lana
Date:      2013-02-19 20:48 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/eca3bce3d151

Merge


Changeset: c641268c4532
Author:    mduigou
Date:      2013-02-20 17:56 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c641268c4532

8008629: webrev.ksh needs to quote bug title it gets back from scraping bugs.sun.com
Reviewed-by: darcy

! make/scripts/webrev.ksh

Changeset: b70196e01c53
Author:    lana
Date:      2013-02-21 17:39 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b70196e01c53

Merge


Changeset: 5b0b6ef58dbf
Author:    jjg
Date:      2013-02-25 15:08 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/5b0b6ef58dbf

8008914: Add nashorn to the tl build
Reviewed-by: mr, tbell, jjh
Contributed-by: erik.joelsson at oracle.com, james.laskey at oracle.com

! Makefile
! common/autoconf/generated-configure.sh
! common/autoconf/source-dirs.m4
! common/autoconf/spec.gmk.in
! common/bin/hgforest.sh
! common/makefiles/Main.gmk
! common/makefiles/MakeBase.gmk
! make/Defs-internal.gmk
! make/jdk-rules.gmk
! make/sanity-rules.gmk
! make/scripts/hgforest.sh

Changeset: e065107437b9
Author:    alanb
Date:      2013-02-26 14:08 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e065107437b9

8008978: nashorn-rules.gmk missing
Reviewed-by: alanb
Contributed-by: erik.joelsson at oracle.com, james.laskey at oracle.com

+ make/nashorn-rules.gmk

Changeset: cb0ac8979caa
Author:    tbell
Date:      2013-02-26 09:25 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/cb0ac8979caa

8009019: Updates to generated-configure.sh required for 8008914
Reviewed-by: sundar, jlaskey, jjg

! common/autoconf/generated-configure.sh

Changeset: a9c8a32d09f9
Author:    martin
Date:      2013-03-05 13:16 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/a9c8a32d09f9

8006988: build-infra: Configure fails if 'cl' is in path on linux
Summary: Respect user CC and CXX environment variables; use cl iff on windows
Reviewed-by: erikj

! common/autoconf/generated-configure.sh
! common/autoconf/toolchain.m4

Changeset: c022bc48b7ed
Author:    lana
Date:      2013-03-05 11:46 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c022bc48b7ed

Merge

! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in

Changeset: c4901c0e0579
Author:    lana
Date:      2013-03-05 15:09 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c4901c0e0579

Merge

! common/autoconf/generated-configure.sh
! common/autoconf/toolchain.m4

Changeset: 929e2461818b
Author:    dholmes
Date:      2013-03-05 22:45 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/929e2461818b

8009529: Fix for 8006988 missed closed configure changes
Reviewed-by: mr

! common/autoconf/generated-configure.sh

Changeset: b35d986ff276
Author:    mduigou
Date:      2013-03-06 08:37 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b35d986ff276

8009162: root repo "make test" target should run against image
Reviewed-by: alanb, martin, erikj

! common/makefiles/Main.gmk

Changeset: 980ccff2d4f5
Author:    lana
Date:      2013-03-12 16:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/980ccff2d4f5

Merge

! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! common/makefiles/Main.gmk

Changeset: 22b9a31a92eb
Author:    lana
Date:      2013-03-13 23:21 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/22b9a31a92eb

Merge

! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! common/autoconf/toolchain.m4

Changeset: a69761ae281b
Author:    lana
Date:      2013-03-14 19:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/a69761ae281b

Merge


Changeset: e2057191f6da
Author:    omajid
Date:      2013-03-18 10:47 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e2057191f6da

8010030: Allow configure to detect if EC implementation is present
Reviewed-by: andrew, dholmes

! common/autoconf/configure.ac
! common/autoconf/generated-configure.sh
! common/autoconf/jdk-options.m4
! common/autoconf/spec.gmk.in

Changeset: 29153d0df68f
Author:    omajid
Date:      2013-03-19 11:25 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/29153d0df68f

8010277: Configure doesn't fail when Xrender.h is missing
Reviewed-by: andrew

! common/autoconf/generated-configure.sh
! common/autoconf/libraries.m4

Changeset: 466685ba01bf
Author:    katleman
Date:      2013-03-21 10:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/466685ba01bf

Added tag jdk8-b82 for changeset 29153d0df68f

! .hgtags


From john.coomes at oracle.com  Fri Mar 22 01:35:46 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 22 Mar 2013 08:35:46 +0000
Subject: hg: hsx/hotspot-rt/jaxp: 7 new changesets
Message-ID: <20130322083611.5E7D64832D@hg.openjdk.java.net>

Changeset: 94000590f01f
Author:    katleman
Date:      2013-03-14 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/94000590f01f

Added tag jdk8-b81 for changeset ef3495555a4c

! .hgtags

Changeset: f4898ff0aff1
Author:    joehw
Date:      2012-12-12 15:19 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/f4898ff0aff1

8001235: Improve JAXP HTTP handling
Reviewed-by: lancea, skoivu

! src/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java

Changeset: 3206516132e8
Author:    ewendeli
Date:      2013-02-19 21:45 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/3206516132e8

Merge


Changeset: 46ce56a4e40f
Author:    ewendeli
Date:      2013-02-25 07:22 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/46ce56a4e40f

Merge


Changeset: 8a0cb78fefbc
Author:    lana
Date:      2013-03-12 18:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/8a0cb78fefbc

Merge


Changeset: d5a58291f09a
Author:    lana
Date:      2013-03-14 19:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/d5a58291f09a

Merge


Changeset: a46d69a1a8ec
Author:    katleman
Date:      2013-03-21 10:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/a46d69a1a8ec

Added tag jdk8-b82 for changeset d5a58291f09a

! .hgtags


From john.coomes at oracle.com  Fri Mar 22 01:36:16 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 22 Mar 2013 08:36:16 +0000
Subject: hg: hsx/hotspot-rt/jaxws: 2 new changesets
Message-ID: <20130322083624.C25DC4832E@hg.openjdk.java.net>

Changeset: d8d8032d02d7
Author:    katleman
Date:      2013-03-14 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/d8d8032d02d7

Added tag jdk8-b81 for changeset c88bb21560cc

! .hgtags

Changeset: a1dcc0d83da1
Author:    katleman
Date:      2013-03-21 10:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/a1dcc0d83da1

Added tag jdk8-b82 for changeset d8d8032d02d7

! .hgtags


From john.coomes at oracle.com  Fri Mar 22 01:43:07 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 22 Mar 2013 08:43:07 +0000
Subject: hg: hsx/hotspot-rt/jdk: 171 new changesets
Message-ID: <20130322093622.EE2A64832F@hg.openjdk.java.net>

Changeset: 758db1c4c65c
Author:    ehelin
Date:      2013-03-04 15:40 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/758db1c4c65c

8009384: Temporarily disable jstat tests to ease complicated push
Reviewed-by: mchung

! test/ProblemList.txt

Changeset: aee1c6c52b68
Author:    erikj
Date:      2013-03-06 16:15 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/aee1c6c52b68

8008073: build-infra: Need --with-dxsdk option? And awt/sound -I option additions?
Reviewed-by: tbell

! makefiles/CompileNativeLibraries.gmk

Changeset: da8edcfc19af
Author:    katleman
Date:      2013-03-11 13:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/da8edcfc19af

Merge


Changeset: bc0ca8bc4637
Author:    erikj
Date:      2013-03-12 15:17 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bc0ca8bc4637

8009695: embedded/GP/RI: This intermittent error happens too often, makes the build unstable, and waste machine
Reviewed-by: dholmes, tbell

! make/common/shared/Defs-utils.gmk
! makefiles/Images.gmk

Changeset: c0f8022eba53
Author:    katleman
Date:      2013-03-12 19:19 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c0f8022eba53

Merge


Changeset: 509c45748f3e
Author:    katleman
Date:      2013-03-14 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/509c45748f3e

Added tag jdk8-b81 for changeset c0f8022eba53

! .hgtags

Changeset: f6eb212081b2
Author:    jgodinez
Date:      2013-02-14 14:14 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f6eb212081b2

8008173: [parfait] #1173 Uninitialised variable -- TransformHelper.cpp
Reviewed-by: prr, vadim
Contributed-by: jia-hong.chen at oracle.com

! src/share/native/sun/java2d/loops/TransformHelper.c

Changeset: 4b11045a9c4c
Author:    jgodinez
Date:      2013-02-18 14:04 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4b11045a9c4c

8005191: [parfait] #384 sun/font/layout/LookupProcessor.cpp Null pointer dereference
Reviewed-by: prr, vadim
Contributed-by: jia-hong.chen at oracle.com

! src/share/native/sun/font/layout/LookupProcessor.cpp

Changeset: 41008f5cef1a
Author:    lana
Date:      2013-02-19 22:10 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/41008f5cef1a

Merge

- src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java
- src/share/classes/java/time/PeriodParser.java
- src/share/classes/java/time/calendar/ChronoDateImpl.java
- src/share/classes/java/time/calendar/HijrahChrono.java
- src/share/classes/java/time/calendar/HijrahDate.java
- src/share/classes/java/time/calendar/HijrahDeviationReader.java
- src/share/classes/java/time/calendar/HijrahEra.java
- src/share/classes/java/time/calendar/JapaneseChrono.java
- src/share/classes/java/time/calendar/JapaneseDate.java
- src/share/classes/java/time/calendar/JapaneseEra.java
- src/share/classes/java/time/calendar/MinguoChrono.java
- src/share/classes/java/time/calendar/MinguoDate.java
- src/share/classes/java/time/calendar/MinguoEra.java
- src/share/classes/java/time/calendar/Ser.java
- src/share/classes/java/time/calendar/ThaiBuddhistChrono.java
- src/share/classes/java/time/calendar/ThaiBuddhistDate.java
- src/share/classes/java/time/calendar/ThaiBuddhistEra.java
- src/share/classes/java/time/calendar/package-info.java
- src/share/classes/java/time/format/DateTimeFormatters.java
- src/share/classes/java/time/format/DateTimePrintException.java
- src/share/classes/java/time/temporal/Chrono.java
- src/share/classes/java/time/temporal/ChronoLocalDate.java
- src/share/classes/java/time/temporal/ChronoLocalDateTime.java
- src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java
- src/share/classes/java/time/temporal/ChronoZonedDateTime.java
- src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java
- src/share/classes/java/time/temporal/Era.java
- src/share/classes/java/time/temporal/ISOChrono.java
- src/share/classes/java/time/temporal/ISOEra.java
- src/share/classes/java/time/temporal/ISOFields.java
- src/share/classes/java/time/temporal/MonthDay.java
- src/share/classes/java/time/temporal/OffsetDate.java
- src/share/classes/java/time/temporal/OffsetDateTime.java
- src/share/classes/java/time/temporal/OffsetTime.java
- src/share/classes/java/time/temporal/Ser.java
- src/share/classes/java/time/temporal/SimplePeriod.java
- src/share/classes/java/time/temporal/TemporalAdder.java
- src/share/classes/java/time/temporal/TemporalSubtractor.java
- src/share/classes/java/time/temporal/Year.java
- src/share/classes/java/time/temporal/YearMonth.java
- src/share/classes/sun/util/calendar/TzIDOldMapping.java
- test/java/time/META-INF/services/java.time.temporal.Chrono
- test/java/time/tck/java/time/calendar/CopticChrono.java
- test/java/time/tck/java/time/calendar/CopticDate.java
- test/java/time/tck/java/time/calendar/CopticEra.java
- test/java/time/tck/java/time/calendar/TestChronoLocalDate.java
- test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/calendar/TestHijrahChrono.java
- test/java/time/tck/java/time/calendar/TestJapaneseChrono.java
- test/java/time/tck/java/time/calendar/TestMinguoChrono.java
- test/java/time/tck/java/time/calendar/TestServiceLoader.java
- test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java
- test/java/time/tck/java/time/format/TCKDateTimePrintException.java
- test/java/time/tck/java/time/temporal/TCKISOFields.java
- test/java/time/tck/java/time/temporal/TCKMonthDay.java
- test/java/time/tck/java/time/temporal/TCKOffsetDate.java
- test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java
- test/java/time/tck/java/time/temporal/TCKOffsetTime.java
- test/java/time/tck/java/time/temporal/TCKSimplePeriod.java
- test/java/time/tck/java/time/temporal/TCKYear.java
- test/java/time/tck/java/time/temporal/TCKYearMonth.java
- test/java/time/tck/java/time/temporal/TestChrono.java
- test/java/time/tck/java/time/temporal/TestISOChrono.java
- test/java/time/test/java/time/TestPeriodParser.java
- test/java/time/test/java/time/format/TestDateTimeFormatters.java
- test/java/time/test/java/time/format/TestDateTimePrintException.java
- test/java/time/test/java/time/format/TestPadParserDecorator.java
- test/java/time/test/java/time/format/TestZoneIdParser.java
- test/java/time/test/java/time/temporal/TestISOChronoImpl.java
- test/java/time/test/java/time/temporal/TestMonthDay.java
- test/java/time/test/java/time/temporal/TestOffsetDate.java
- test/java/time/test/java/time/temporal/TestOffsetDateTime.java
- test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java
- test/java/time/test/java/time/temporal/TestOffsetTime.java
- test/java/time/test/java/time/temporal/TestYear.java
- test/java/time/test/java/time/temporal/TestYearMonth.java

Changeset: d2d7da120c37
Author:    jgodinez
Date:      2013-02-22 11:01 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d2d7da120c37

8006110: pageDialog is showing the swing dialog with DialogTypeSelection.NATIVE
Reviewed-by: bae, prr

! src/share/classes/sun/print/RasterPrinterJob.java

Changeset: 99c1f910abcc
Author:    jgodinez
Date:      2013-02-22 13:20 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/99c1f910abcc

8005796: [parfait] Possible uninitialised variable at jdk/src/share/native/sun/java2d/loops/ByteBinary1Bit.c
Reviewed-by: prr, vadim, flar
Contributed-by: jia-hong.chen at oracle.com

! src/share/native/sun/java2d/loops/AnyByteBinary.h
! src/share/native/sun/java2d/loops/ByteIndexed.h
! src/share/native/sun/java2d/loops/IntArgb.h
! src/share/native/sun/java2d/loops/IntArgbBm.h
! src/share/native/sun/java2d/loops/IntArgbPre.h
! src/share/native/sun/java2d/loops/Ushort4444Argb.h
! src/share/native/sun/java2d/loops/UshortIndexed.h

Changeset: 934f5f10107d
Author:    lana
Date:      2013-02-22 11:37 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/934f5f10107d

Merge


Changeset: 4fd6048a78c0
Author:    lana
Date:      2013-02-22 23:12 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4fd6048a78c0

Merge


Changeset: f3368a3fc023
Author:    bae
Date:      2013-03-05 17:18 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f3368a3fc023

7152608: [macosx] Crash in liblwawt.dylib in AccelGlyphCache_RemoveCellInfo
Reviewed-by: jgodinez, ant

! src/macosx/classes/sun/font/CStrike.java
! src/macosx/classes/sun/font/CStrikeDisposer.java
! src/macosx/native/sun/font/AWTStrike.m

Changeset: fd8810d50c99
Author:    bae
Date:      2013-03-07 14:05 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fd8810d50c99

8005530: [lcms] Improve performance of ColorConverOp for default destinations
Reviewed-by: prr, jgodinez

! make/sun/cmm/lcms/Makefile
! make/sun/cmm/lcms/mapfile-vers
! makefiles/CompileNativeLibraries.gmk
! makefiles/mapfiles/liblcms/mapfile-vers
! src/share/classes/sun/java2d/cmm/lcms/LCMS.java
! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java
! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
! src/share/demo/java2d/J2DBench/build.xml
+ src/share/demo/java2d/J2DBench/resources/cmm_images/img_icc_large.jpg
+ src/share/demo/java2d/J2DBench/resources/cmm_images/img_icc_medium.jpg
+ src/share/demo/java2d/J2DBench/resources/cmm_images/img_icc_small.jpg
! src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConversionTests.java
+ src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/EmbeddedProfileTests.java
! src/share/native/sun/java2d/cmm/lcms/LCMS.c

Changeset: 8e9b133dcec9
Author:    lana
Date:      2013-03-12 16:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8e9b133dcec9

Merge


Changeset: e6c94a202bfd
Author:    alexsch
Date:      2013-02-15 14:24 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e6c94a202bfd

7173873: JFrame.setDefaultCloseOperation(EXIT_ON_CLOSE) will never lead to SE if EXIT_ON_CLOSE is already set
Reviewed-by: malenkov, serb

! src/share/classes/javax/swing/JFrame.java

Changeset: 4bf242def958
Author:    dingxmin
Date:      2013-02-15 15:05 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4bf242def958

8008289: DefaultButtonModel instance keeps stale listeners in html FormView
Reviewed-by: malenkov, alexsch

! src/share/classes/javax/swing/text/html/FormView.java
+ test/javax/swing/text/html/7189299/bug7189299.java

Changeset: 88a83b9e9baa
Author:    kshefov
Date:      2013-02-15 17:46 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88a83b9e9baa

8005920: After pressing combination Windows Key and M key, the frame, the instruction and the dialog can't be minimized.
Reviewed-by: serb, denis
Contributed-by: Vera Akulova 

! test/java/awt/Modal/WsDisabledStyle/Winkey/Winkey.java

Changeset: 0fe12ecf80b2
Author:    pchelko
Date:      2013-02-19 11:26 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0fe12ecf80b2

8008374: Build failure (NEWBUILD=false) on Mac
Summary: Fixed an old build system failure
Reviewed-by: art, anthony

! make/sun/lwawt/FILES_export_macosx.gmk

Changeset: 5ad0bd367f6d
Author:    kshefov
Date:      2013-02-19 17:26 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5ad0bd367f6d

8008379: TEST_BUG: Fail automatically with java.lang.NullPointerException.
Reviewed-by: serb, anthony

+ test/java/awt/Modal/ModalDialogMultiscreenTest/ModalDialogMultiscreenTest.java

Changeset: a43115c6359d
Author:    kshefov
Date:      2013-02-19 20:00 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a43115c6359d

8006070: TEST_BUG: Up and down the Y coordinate of the mouse position, the selected item doesn't change for the single list.
Reviewed-by: serb, anthony

+ test/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
+ test/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java

Changeset: 9bc26b7b8b47
Author:    lana
Date:      2013-02-19 22:23 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9bc26b7b8b47

Merge

- src/share/classes/java/time/PeriodParser.java
- src/share/classes/java/time/calendar/ChronoDateImpl.java
- src/share/classes/java/time/calendar/HijrahChrono.java
- src/share/classes/java/time/calendar/HijrahDate.java
- src/share/classes/java/time/calendar/HijrahDeviationReader.java
- src/share/classes/java/time/calendar/HijrahEra.java
- src/share/classes/java/time/calendar/JapaneseChrono.java
- src/share/classes/java/time/calendar/JapaneseDate.java
- src/share/classes/java/time/calendar/JapaneseEra.java
- src/share/classes/java/time/calendar/MinguoChrono.java
- src/share/classes/java/time/calendar/MinguoDate.java
- src/share/classes/java/time/calendar/MinguoEra.java
- src/share/classes/java/time/calendar/Ser.java
- src/share/classes/java/time/calendar/ThaiBuddhistChrono.java
- src/share/classes/java/time/calendar/ThaiBuddhistDate.java
- src/share/classes/java/time/calendar/ThaiBuddhistEra.java
- src/share/classes/java/time/calendar/package-info.java
- src/share/classes/java/time/format/DateTimeFormatters.java
- src/share/classes/java/time/format/DateTimePrintException.java
- src/share/classes/java/time/temporal/Chrono.java
- src/share/classes/java/time/temporal/ChronoLocalDate.java
- src/share/classes/java/time/temporal/ChronoLocalDateTime.java
- src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java
- src/share/classes/java/time/temporal/ChronoZonedDateTime.java
- src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java
- src/share/classes/java/time/temporal/Era.java
- src/share/classes/java/time/temporal/ISOChrono.java
- src/share/classes/java/time/temporal/ISOEra.java
- src/share/classes/java/time/temporal/ISOFields.java
- src/share/classes/java/time/temporal/MonthDay.java
- src/share/classes/java/time/temporal/OffsetDate.java
- src/share/classes/java/time/temporal/OffsetDateTime.java
- src/share/classes/java/time/temporal/OffsetTime.java
- src/share/classes/java/time/temporal/Ser.java
- src/share/classes/java/time/temporal/SimplePeriod.java
- src/share/classes/java/time/temporal/TemporalAdder.java
- src/share/classes/java/time/temporal/TemporalSubtractor.java
- src/share/classes/java/time/temporal/Year.java
- src/share/classes/java/time/temporal/YearMonth.java
- src/share/classes/sun/util/calendar/TzIDOldMapping.java
- test/java/time/META-INF/services/java.time.temporal.Chrono
- test/java/time/tck/java/time/calendar/CopticChrono.java
- test/java/time/tck/java/time/calendar/CopticDate.java
- test/java/time/tck/java/time/calendar/CopticEra.java
- test/java/time/tck/java/time/calendar/TestChronoLocalDate.java
- test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java
- test/java/time/tck/java/time/calendar/TestHijrahChrono.java
- test/java/time/tck/java/time/calendar/TestJapaneseChrono.java
- test/java/time/tck/java/time/calendar/TestMinguoChrono.java
- test/java/time/tck/java/time/calendar/TestServiceLoader.java
- test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java
- test/java/time/tck/java/time/format/TCKDateTimePrintException.java
- test/java/time/tck/java/time/temporal/TCKISOFields.java
- test/java/time/tck/java/time/temporal/TCKMonthDay.java
- test/java/time/tck/java/time/temporal/TCKOffsetDate.java
- test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java
- test/java/time/tck/java/time/temporal/TCKOffsetTime.java
- test/java/time/tck/java/time/temporal/TCKSimplePeriod.java
- test/java/time/tck/java/time/temporal/TCKYear.java
- test/java/time/tck/java/time/temporal/TCKYearMonth.java
- test/java/time/tck/java/time/temporal/TestChrono.java
- test/java/time/tck/java/time/temporal/TestISOChrono.java
- test/java/time/test/java/time/TestPeriodParser.java
- test/java/time/test/java/time/format/TestDateTimeFormatters.java
- test/java/time/test/java/time/format/TestDateTimePrintException.java
- test/java/time/test/java/time/format/TestPadParserDecorator.java
- test/java/time/test/java/time/format/TestZoneIdParser.java
- test/java/time/test/java/time/temporal/TestISOChronoImpl.java
- test/java/time/test/java/time/temporal/TestMonthDay.java
- test/java/time/test/java/time/temporal/TestOffsetDate.java
- test/java/time/test/java/time/temporal/TestOffsetDateTime.java
- test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java
- test/java/time/test/java/time/temporal/TestOffsetTime.java
- test/java/time/test/java/time/temporal/TestYear.java
- test/java/time/test/java/time/temporal/TestYearMonth.java

Changeset: 73d1efc4710a
Author:    ant
Date:      2013-02-22 15:13 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/73d1efc4710a

8006406: lightweight embedding in other Java UI toolkits
Reviewed-by: serb, anthony, art

! src/macosx/classes/sun/lwawt/LWComponentPeer.java
+ src/macosx/classes/sun/lwawt/LWLightweightFramePeer.java
! src/macosx/classes/sun/lwawt/LWToolkit.java
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformComponent.java
+ src/macosx/classes/sun/lwawt/macosx/CPlatformLWComponent.java
+ src/macosx/classes/sun/lwawt/macosx/CPlatformLWView.java
+ src/macosx/classes/sun/lwawt/macosx/CPlatformLWWindow.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/share/classes/java/awt/peer/FramePeer.java
! src/share/classes/java/awt/peer/WindowPeer.java
! src/share/classes/sun/awt/EmbeddedFrame.java
! src/share/classes/sun/awt/HToolkit.java
+ src/share/classes/sun/awt/LightweightFrame.java
! src/share/classes/sun/awt/SunToolkit.java
+ src/share/classes/sun/swing/JLightweightFrame.java
+ src/share/classes/sun/swing/LightweightContent.java
! src/solaris/classes/sun/awt/X11/XFramePeer.java
! src/solaris/classes/sun/awt/X11/XToolkit.java
! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java
! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java
! src/windows/classes/sun/awt/windows/WFramePeer.java
+ src/windows/classes/sun/awt/windows/WLightweightFramePeer.java
! src/windows/classes/sun/awt/windows/WToolkit.java
! src/windows/native/sun/windows/awt_Frame.cpp
! src/windows/native/sun/windows/awt_Frame.h
! src/windows/native/sun/windows/awt_Window.h

Changeset: 63bb402d4a6a
Author:    lana
Date:      2013-02-23 19:49 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/63bb402d4a6a

Merge


Changeset: d502cc7bcc3d
Author:    pchelko
Date:      2013-02-25 10:17 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d502cc7bcc3d

8006634: Unify LWCToolkit.invokeAndWait() and sun.awt.datatransfer.ToolkitThreadBlockedHandler
Summary: Changed the logic for the nested event loops and deleted deadlock detection
Reviewed-by: art, denis

! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java
! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/macosx/native/sun/awt/AWTView.m
! src/macosx/native/sun/awt/ApplicationDelegate.m
! src/macosx/native/sun/awt/CClipboard.m
! src/macosx/native/sun/awt/CDropTarget.m
! src/macosx/native/sun/awt/CMenu.m
! src/macosx/native/sun/awt/CMenuBar.m
! src/macosx/native/sun/awt/CMenuItem.m
! src/macosx/native/sun/awt/JavaComponentAccessibility.m
! src/macosx/native/sun/awt/LWCToolkit.m
! src/macosx/native/sun/osxapp/ThreadUtilities.h
! src/macosx/native/sun/osxapp/ThreadUtilities.m

Changeset: e58f0b163f43
Author:    denis
Date:      2013-02-27 19:38 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e58f0b163f43

7178079: REGRESSION: Some AWT Drag-n-Drop tests fail since JDK 7u6 b13
Reviewed-by: serb, anthony

! src/macosx/classes/sun/lwawt/macosx/CDropTargetContextPeer.java

Changeset: bc914b7f0878
Author:    denis
Date:      2013-02-27 20:34 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bc914b7f0878

8009158: Incomplete fix for 7178079
Reviewed-by: serb, anthony

! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java

Changeset: 3dee850e2653
Author:    serb
Date:      2013-02-28 17:04 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3dee850e2653

8008660: Failure in 2D Queue Flusher thread on Mac
Reviewed-by: swingler, bae

! src/macosx/classes/sun/awt/CGraphicsConfig.java
! src/macosx/classes/sun/awt/CGraphicsDevice.java
! src/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java
! src/macosx/classes/sun/lwawt/macosx/CRobot.java
! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/macosx/native/sun/awt/CRobot.m
! src/macosx/native/sun/awt/LWCToolkit.h
! src/macosx/native/sun/awt/LWCToolkit.m
! src/macosx/native/sun/java2d/opengl/CGLGraphicsConfig.m

Changeset: 554d0f41a6ab
Author:    serb
Date:      2013-02-28 20:27 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/554d0f41a6ab

8003169: [macosx] JVM crash after disconnecting from projector
Reviewed-by: anthony, alexsch

! src/macosx/classes/sun/awt/CGraphicsDevice.java
! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/macosx/native/sun/awt/CGraphicsDevice.m

Changeset: 657a02fcaa00
Author:    malenkov
Date:      2013-03-01 14:30 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/657a02fcaa00

7163696: JCK Swing interactive test JScrollBarTest0013 fails with Nimbus and GTK L&Fs
Reviewed-by: alexsch

! src/share/classes/java/beans/PropertyDescriptor.java
! test/java/beans/Introspector/Test7192955.java

Changeset: 5816595a4cdc
Author:    serb
Date:      2013-03-01 15:31 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5816595a4cdc

7194902: [macosx] closed/java/awt/Button/DoubleActionEventTest/DoubleActionEventTest failed since jdk8b49
7181403: Invalid MouseEvent conversion with SwingUtilities.convertMouseEvent
Reviewed-by: malenkov, alexsch

! src/macosx/classes/sun/lwawt/LWComponentPeer.java
! src/share/classes/javax/swing/SwingUtilities.java

Changeset: 4912a9e3a95e
Author:    serb
Date:      2013-03-01 21:50 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4912a9e3a95e

7184945: [macosx] NPE in AquaComboBoxUI since jdk7u6b17, jdk8b47
Reviewed-by: malenkov, alexsch

! src/macosx/classes/com/apple/laf/AquaComboBoxUI.java

Changeset: 91e17a813483
Author:    alexsch
Date:      2013-03-06 19:42 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/91e17a813483

6877495: JTextField and JTextArea does not support supplementary characters
Reviewed-by: serb, alexp

! src/share/classes/sun/awt/datatransfer/DataTransferer.java
+ test/sun/awt/datatransfer/SuplementaryCharactersTransferTest.java

Changeset: 7962014b1729
Author:    mcherkas
Date:      2013-03-06 20:10 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7962014b1729

8007295: Reduce number of warnings in awt classes
Reviewed-by: bae, anthony

! src/share/classes/java/awt/CheckboxMenuItem.java
! src/share/classes/java/awt/Cursor.java
! src/share/classes/java/awt/EventQueue.java
! src/share/classes/java/awt/Menu.java
! src/share/classes/java/awt/MenuBar.java
! src/share/classes/java/awt/MenuComponent.java
! src/share/classes/java/awt/MenuItem.java
! src/share/classes/java/awt/RenderingHints.java
! src/share/classes/java/awt/datatransfer/Clipboard.java
! src/share/classes/java/awt/dnd/DragGestureEvent.java
! src/share/classes/java/awt/dnd/DragGestureRecognizer.java
! src/share/classes/java/awt/dnd/DragSource.java
! src/share/classes/java/awt/dnd/InvalidDnDOperationException.java
! src/share/classes/java/awt/geom/AffineTransform.java

Changeset: f3ffead3069e
Author:    lana
Date:      2013-03-12 16:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f3ffead3069e

Merge


Changeset: 153884b550f0
Author:    chegar
Date:      2013-02-14 13:01 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/153884b550f0

8008201: Add java/lang/Class/asSubclass/BasicUnit.java to the ProblemList
Reviewed-by: mcimadamore

! test/ProblemList.txt

Changeset: e57019d2f34a
Author:    mduigou
Date:      2013-02-13 14:50 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e57019d2f34a

8008167: IdentityHashMap.[keySet|values|entrySet].toArray speed-up
Reviewed-by: mduigou, martin
Contributed-by: Peter Levart 

! src/share/classes/java/util/IdentityHashMap.java

Changeset: 1405ad6afb1e
Author:    bharadwaj
Date:      2013-02-14 11:09 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1405ad6afb1e

8007736: VerifyError for use of static method in interface
Reviewed-by: mchung

! src/share/native/common/check_code.c
+ test/vm/verifier/TestStaticIF.java

Changeset: 1ce1a307cded
Author:    sherman
Date:      2013-02-15 01:17 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ce1a307cded

8008254: j.u.Calendar.JavatimeTest failed at TL b78 pit testing
Summary: to use j.t.ZoneId zone name to keep round-trip
Reviewed-by: okutsu

! test/java/util/Calendar/JavatimeTest.java

Changeset: 048637b40787
Author:    chegar
Date:      2013-02-15 11:06 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/048637b40787

8008223: java/net/BindException/Test.java fails rarely
Reviewed-by: khazra, alanb

! test/java/net/BindException/Test.java

Changeset: 7748ffdca16a
Author:    rfield
Date:      2013-02-16 12:36 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7748ffdca16a

8004970: Implement serialization in the lambda metafactory
Reviewed-by: forax

! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java
! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
! src/share/classes/java/lang/invoke/LambdaMetafactory.java
! src/share/classes/java/lang/invoke/MethodHandleInfo.java
+ src/share/classes/java/lang/invoke/SerializedLambda.java
! src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java
+ test/java/lang/invoke/lambda/LambdaSerialization.java

Changeset: 43726ed11fb3
Author:    sherman
Date:      2013-02-17 01:01 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/43726ed11fb3

8008348: The leftover jdk/make/tools/javazic causes build problems with hs25-b19 control
Summary: To remove jdk/make/tools/javazic from the jdk repo
Reviewed-by: alanb

- make/tools/javazic/Makefile
- make/tools/src/build/tools/javazic/BackEnd.java
- make/tools/src/build/tools/javazic/Checksum.java
- make/tools/src/build/tools/javazic/DayOfWeek.java
- make/tools/src/build/tools/javazic/Gen.java
- make/tools/src/build/tools/javazic/GenDoc.java
- make/tools/src/build/tools/javazic/Main.java
- make/tools/src/build/tools/javazic/Mappings.java
- make/tools/src/build/tools/javazic/Month.java
- make/tools/src/build/tools/javazic/Rule.java
- make/tools/src/build/tools/javazic/RuleDay.java
- make/tools/src/build/tools/javazic/RuleRec.java
- make/tools/src/build/tools/javazic/Simple.java
- make/tools/src/build/tools/javazic/Time.java
- make/tools/src/build/tools/javazic/Timezone.java
- make/tools/src/build/tools/javazic/Zone.java
- make/tools/src/build/tools/javazic/ZoneRec.java
- make/tools/src/build/tools/javazic/Zoneinfo.java

Changeset: ce6a2fcb4c9b
Author:    yhuang
Date:      2013-02-16 21:22 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ce6a2fcb4c9b

8006748: getISO3Country() returns wrong value
Reviewed-by: naoto

! src/share/classes/java/util/LocaleISOData.java

Changeset: bcde0486261e
Author:    dingxmin
Date:      2013-02-18 08:14 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bcde0486261e

6429204: (se) Concurrent Selector.register and SelectionKey.interestOps can ignore interestOps
Reviewed-by: alanb

! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java
+ test/java/nio/channels/Selector/RacyDeregister.java

Changeset: 49b3d8efd30a
Author:    darcy
Date:      2013-02-19 00:19 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/49b3d8efd30a

8008434: Misc javadoc warning fixes in DateTimeFormatterBuilder and TimeZone
Reviewed-by: mduigou, okutsu

! src/share/classes/java/time/format/DateTimeFormatterBuilder.java
! src/share/classes/java/util/TimeZone.java

Changeset: 885bb24f6018
Author:    coffeys
Date:      2013-02-19 14:07 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/885bb24f6018

7197187: Currency.isPastCutoverDate should be made more robust
Reviewed-by: alanb

! src/share/classes/java/util/Currency.java

Changeset: 01b6b0dd2006
Author:    coffeys
Date:      2013-02-19 14:12 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01b6b0dd2006

8007315: HttpURLConnection.filterHeaderField method returns null where empty string is expected
Reviewed-by: chegar

! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
! test/sun/net/www/protocol/http/HttpOnly.java

Changeset: 824187de1591
Author:    jzavgren
Date:      2013-02-19 16:19 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/824187de1591

8007609: WinNTFileSystem_md.c should correctly check value returned from realloc
Reviewed-by: alanb, chegar, dholmes

! src/windows/native/java/io/WinNTFileSystem_md.c

Changeset: e20c1c9197bf
Author:    emc
Date:      2013-02-19 17:09 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e20c1c9197bf

8008312: Re-enable MethodParameter tests in JDK
Reviewed-by: darcy

! src/share/classes/java/lang/reflect/Parameter.java
! test/java/lang/reflect/Parameter/WithParameters.java

Changeset: af396ec087f4
Author:    naoto
Date:      2013-02-19 10:34 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/af396ec087f4

7092447: Clarify the default locale used in each locale sensitive operation
Reviewed-by: okutsu

! src/share/classes/java/text/DateFormat.java
! src/share/classes/java/text/DateFormatSymbols.java
! src/share/classes/java/text/DecimalFormat.java
! src/share/classes/java/text/DecimalFormatSymbols.java
! src/share/classes/java/text/MessageFormat.java
! src/share/classes/java/text/NumberFormat.java
! src/share/classes/java/text/SimpleDateFormat.java
! src/share/classes/java/time/format/DateTimeFormatSymbols.java
! src/share/classes/java/util/Calendar.java
! src/share/classes/java/util/Currency.java
! src/share/classes/java/util/Formatter.java
! src/share/classes/java/util/GregorianCalendar.java
! src/share/classes/java/util/Locale.java
! src/share/classes/java/util/Scanner.java

Changeset: 16efb7ba188f
Author:    mduigou
Date:      2013-02-19 11:56 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/16efb7ba188f

8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and "Bi" (two operand). Adds utility extension methods. Includes some name changes for existing functional interfaces per EG decisions.
Reviewed-by: briangoetz, darcy, chegar, dholmes

! src/share/classes/java/time/chrono/HijrahDeviationReader.java
! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java
! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java
! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicLong.java
! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java
! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicReference.java
! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java
! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java
! src/share/classes/java/util/concurrent/atomic/LongAccumulator.java
! src/share/classes/java/util/concurrent/atomic/Striped64.java
+ src/share/classes/java/util/function/BiConsumer.java
+ src/share/classes/java/util/function/BiFunction.java
+ src/share/classes/java/util/function/BiPredicate.java
! src/share/classes/java/util/function/BinaryOperator.java
- src/share/classes/java/util/function/Block.java
+ src/share/classes/java/util/function/BooleanSupplier.java
+ src/share/classes/java/util/function/Consumer.java
! src/share/classes/java/util/function/DoubleBinaryOperator.java
- src/share/classes/java/util/function/DoubleBlock.java
+ src/share/classes/java/util/function/DoubleConsumer.java
! src/share/classes/java/util/function/DoubleFunction.java
+ src/share/classes/java/util/function/DoublePredicate.java
! src/share/classes/java/util/function/DoubleSupplier.java
! src/share/classes/java/util/function/DoubleUnaryOperator.java
! src/share/classes/java/util/function/Function.java
! src/share/classes/java/util/function/IntBinaryOperator.java
- src/share/classes/java/util/function/IntBlock.java
+ src/share/classes/java/util/function/IntConsumer.java
! src/share/classes/java/util/function/IntFunction.java
+ src/share/classes/java/util/function/IntPredicate.java
! src/share/classes/java/util/function/IntSupplier.java
! src/share/classes/java/util/function/IntUnaryOperator.java
! src/share/classes/java/util/function/LongBinaryOperator.java
- src/share/classes/java/util/function/LongBlock.java
+ src/share/classes/java/util/function/LongConsumer.java
! src/share/classes/java/util/function/LongFunction.java
+ src/share/classes/java/util/function/LongPredicate.java
! src/share/classes/java/util/function/LongSupplier.java
! src/share/classes/java/util/function/LongUnaryOperator.java
+ src/share/classes/java/util/function/ObjDoubleConsumer.java
+ src/share/classes/java/util/function/ObjIntConsumer.java
+ src/share/classes/java/util/function/ObjLongConsumer.java
! src/share/classes/java/util/function/Predicate.java
+ src/share/classes/java/util/function/ToDoubleBiFunction.java
+ src/share/classes/java/util/function/ToDoubleFunction.java
+ src/share/classes/java/util/function/ToIntBiFunction.java
+ src/share/classes/java/util/function/ToIntFunction.java
+ src/share/classes/java/util/function/ToLongBiFunction.java
+ src/share/classes/java/util/function/ToLongFunction.java
! src/share/classes/java/util/function/UnaryOperator.java
! src/share/classes/java/util/function/package-info.java
! test/java/lang/PrimitiveSumMinMaxTest.java

Changeset: 267bca6af07e
Author:    jzavgren
Date:      2013-02-19 15:31 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/267bca6af07e

8008107: [parfait] Use after free of pointer in jdk/src/share/native/sun/security/pkcs11/wrapper/p11_convert.c
Reviewed-by: mullan, chegar

! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c

Changeset: ec1a79c3a99c
Author:    ksrini
Date:      2013-02-19 16:49 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ec1a79c3a99c

8008262: pack200 should support MethodParameters - part 2
Reviewed-by: jrose

! src/share/classes/com/sun/java/util/jar/pack/Attribute.java
! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java
! src/share/native/com/sun/java/util/jar/pack/bands.cpp
! src/share/native/com/sun/java/util/jar/pack/bands.h
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp
! test/tools/pack200/AttributeTests.java
! test/tools/pack200/Utils.java

Changeset: 85a44860f5bb
Author:    lana
Date:      2013-02-19 20:52 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/85a44860f5bb

Merge

- src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java

Changeset: ca43e2761a1d
Author:    ykantser
Date:      2013-02-13 10:24 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ca43e2761a1d

8008089: Delete OS dependent check in JdkFinder.getExecutable()
Reviewed-by: egahlin, alanb

! test/lib/testlibrary/jdk/testlibrary/JdkFinder.java

Changeset: 0a2b308cc82d
Author:    uta
Date:      2013-02-20 16:39 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0a2b308cc82d

8007454: (process) SetHandleInformation parameters DWORD (not BOOLEAN)
Summary: the SetHandleInformation arguments list was fixed.
Reviewed-by: alanb

! src/windows/native/java/lang/ProcessImpl_md.c

Changeset: 5772e9edbc4c
Author:    dcubed
Date:      2013-02-20 13:23 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5772e9edbc4c

8008352: java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh fails on MKS
Summary: Use more portable pattern counting constructs in test driver.
Reviewed-by: sspitsyn, sla, coleenp

! test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh

Changeset: 1da987f0311a
Author:    rfield
Date:      2013-02-21 15:46 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1da987f0311a

8008356: Test LambdaSerialization.java failing
Summary: run in /othervm mode
Reviewed-by: ksrini

! test/java/lang/invoke/lambda/LambdaSerialization.java

Changeset: 03db11a7fb8e
Author:    lana
Date:      2013-02-21 17:43 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/03db11a7fb8e

Merge


Changeset: 9078c34437ab
Author:    msheppar
Date:      2013-02-21 20:01 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9078c34437ab

8006182: cleanup to use java.util.Base64 in java security component, providers, and regression tests
Summary: Refactored code to use java.util.Base64 Mime Encoder and Decoder as a replacement for sun.misc.BASE64Encoder and sun.misc.BASE64Decoder
Reviewed-by: vinnie, chegar, sherman

! src/share/classes/sun/security/pkcs10/PKCS10.java
! src/share/classes/sun/security/provider/X509Factory.java
! src/share/classes/sun/security/tools/jarsigner/Main.java
! src/share/classes/sun/security/tools/keytool/Main.java
! src/share/classes/sun/security/util/ManifestEntryVerifier.java
! src/share/classes/sun/security/util/SignatureFileVerifier.java
! src/share/classes/sun/security/x509/X509CertImpl.java
! src/share/classes/sun/tools/jar/Manifest.java
! src/share/classes/sun/tools/jar/SignatureFile.java
! test/javax/security/auth/kerberos/KerberosTixDateTest.java
! test/sun/security/krb5/auto/HttpNegotiateServer.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/MD2InTrustAnchor.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/TrustTrustedCert.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/SelfIssuedCert.java
! test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsClient/ProxyTunnelServer.java
! test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketSNISensitive.java
! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java
! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java
! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/ProxyTunnelServer.java

Changeset: c6d77b2b4478
Author:    stefank
Date:      2013-01-22 13:53 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c6d77b2b4478

8006506: Add test for redefining methods in backtraces to java/lang/instrument tests
Reviewed-by: sspitsyn, coleenp

+ test/java/lang/instrument/RedefineMethodInBacktrace.sh
+ test/java/lang/instrument/RedefineMethodInBacktraceAgent.java
+ test/java/lang/instrument/RedefineMethodInBacktraceApp.java
+ test/java/lang/instrument/RedefineMethodInBacktraceTarget.java
+ test/java/lang/instrument/RedefineMethodInBacktraceTarget_2.java

Changeset: 0e93015e77f6
Author:    stefank
Date:      2013-01-22 15:25 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0e93015e77f6

7140852: Add test for 7022100
Reviewed-by: sspitsyn, coleenp

+ test/java/lang/instrument/RedefineMethodWithAnnotations.sh
+ test/java/lang/instrument/RedefineMethodWithAnnotationsAgent.java
+ test/java/lang/instrument/RedefineMethodWithAnnotationsAnnotations.java
+ test/java/lang/instrument/RedefineMethodWithAnnotationsApp.java
+ test/java/lang/instrument/RedefineMethodWithAnnotationsTarget.java
+ test/java/lang/instrument/RedefineMethodWithAnnotationsTarget_2.java

Changeset: 63fe6a9820b6
Author:    alanb
Date:      2013-02-22 14:04 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/63fe6a9820b6

8008290: (profiles) Startup regression due to additional checking of JAR file manifests
Reviewed-by: lancea, chegar, iris, mchung, sherman

! src/share/classes/java/util/jar/JarFile.java
! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java
! src/share/classes/sun/misc/JavaUtilJarAccess.java
! src/share/classes/sun/misc/URLClassPath.java

Changeset: 9f9dac5a9e74
Author:    lancea
Date:      2013-02-22 09:29 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9f9dac5a9e74

8008716: address typo in CallableStatement javadocs
Reviewed-by: chegar

! src/share/classes/java/sql/CallableStatement.java

Changeset: 8d8a35ac7d40
Author:    lancea
Date:      2013-02-22 09:58 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8d8a35ac7d40

Merge


Changeset: 6f9b3e216b01
Author:    darcy
Date:      2013-02-23 13:32 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6f9b3e216b01

6556996: (ann spec) SuppressWarnings strings should be documented
Reviewed-by: mduigou, chegar, abuckley

! src/share/classes/java/lang/Deprecated.java
! src/share/classes/java/lang/Override.java
! src/share/classes/java/lang/SafeVarargs.java
! src/share/classes/java/lang/SuppressWarnings.java
! src/share/classes/java/lang/annotation/Inherited.java
! src/share/classes/java/lang/annotation/Retention.java
! src/share/classes/java/lang/annotation/Target.java

Changeset: 155095c245b4
Author:    alanb
Date:      2013-02-25 17:17 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/155095c245b4

8008808: Allowed dependencies added by JDK-8008481 no longer required
Reviewed-by: tbell, chegar

! make/tools/src/build/tools/deps/refs.allowed

Changeset: 58f829566fe3
Author:    bchristi
Date:      2013-02-25 14:19 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/58f829566fe3

8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C
Summary: Avoid automated test failure by just exiting when in 'C' locale
Reviewed-by: naoto, ksrini

! test/ProblemList.txt
! test/tools/launcher/I18NJarTest.java

Changeset: 4cf4403c9bf2
Author:    jjg
Date:      2013-02-25 15:08 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4cf4403c9bf2

8008914: Add nashorn to the tl build
Reviewed-by: mr, tbell, jjh
Contributed-by: erik.joelsson at oracle.com, james.laskey at oracle.com

! make/launchers/Makefile
! makefiles/CompileLaunchers.gmk
! makefiles/CreateJars.gmk
! test/tools/launcher/VersionCheck.java

Changeset: bc92e4b044e2
Author:    kmo
Date:      2013-02-26 11:05 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bc92e4b044e2

7087570: java.lang.invoke.MemberName information wrong for method handles created with findConstructor
Summary: REF_invokeSpecial DMHs (which are unusual) get marked explicitly; tweak the MHI to use this bit
Reviewed-by: jrose, twisti

! src/share/classes/java/lang/invoke/DirectMethodHandle.java
! src/share/classes/java/lang/invoke/MethodHandle.java
! src/share/classes/java/lang/invoke/MethodHandleImpl.java
! src/share/classes/java/lang/invoke/MethodHandleInfo.java
! src/share/classes/java/lang/invoke/MethodHandles.java
+ test/java/lang/invoke/7087570/Test7087570.java

Changeset: 5fcecbcefb71
Author:    chegar
Date:      2013-02-26 11:06 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5fcecbcefb71

Merge


Changeset: 77447981db73
Author:    chegar
Date:      2013-02-26 11:18 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/77447981db73

Merge


Changeset: 022cd5adc0fa
Author:    alanb
Date:      2013-02-26 14:16 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/022cd5adc0fa

8008977: profiles build broken by Nashorn build changes
Reviewed-by: chegar

! makefiles/profile-rtjar-includes.txt

Changeset: 5ebc62421717
Author:    rfield
Date:      2013-02-26 10:38 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5ebc62421717

8008770: SerializedLambda incorrect class loader for lambda deserializing class
Summary: current thread's context ClassLoader was used to load class by name, pass class not name in serialization (Thank you Peter Levart for test and prototype. Thank you Sundar and Peter for unofficial reviews)
Reviewed-by: forax

! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
! src/share/classes/java/lang/invoke/SerializedLambda.java
+ test/java/lang/invoke/lambda/LambdaClassLoaderSerialization.java
! test/java/lang/invoke/lambda/LambdaSerialization.java

Changeset: ecd33c6ab12f
Author:    alanb
Date:      2013-02-26 22:39 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ecd33c6ab12f

8009029: SunEC provider classes ending up in rt.jar after Nashorn build changes
Reviewed-by: mduigou

! makefiles/CreateJars.gmk

Changeset: 543be9488e50
Author:    darcy
Date:      2013-02-26 17:01 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/543be9488e50

8009102: Several docs warnings in Project Lambda APIs
Reviewed-by: mduigou

! src/share/classes/java/lang/invoke/LambdaMetafactory.java
! src/share/classes/java/util/function/BinaryOperator.java
! src/share/classes/java/util/function/ToDoubleBiFunction.java

Changeset: d623f520557b
Author:    darcy
Date:      2013-02-26 17:38 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d623f520557b

8008279: Remove InvalidContainerAnnotationError.java
Reviewed-by: jfranck

- src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java
! src/share/classes/java/lang/reflect/AnnotatedElement.java
! src/share/classes/sun/reflect/annotation/AnnotationSupport.java

Changeset: f5416026cdf5
Author:    sundar
Date:      2013-02-27 17:22 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f5416026cdf5

8009115: jtreg tests under jdk/test/javax/script should use nashorn as script engine
Reviewed-by: alanb

! test/javax/script/CauseExceptionTest.java
+ test/javax/script/ExceptionTest.java
! test/javax/script/GetInterfaceTest.java
! test/javax/script/Helper.java
- test/javax/script/RhinoExceptionTest.java
! test/javax/script/StringWriterPrintTest.java
! test/javax/script/Test3.js
! test/javax/script/Test5.java
! test/javax/script/Test5.js
! test/javax/script/Test6.java
! test/javax/script/Test7.js
! test/javax/script/UnescapedBracketRegExTest.java
! test/javax/script/VersionTest.java

Changeset: 13013dedcdfd
Author:    alanb
Date:      2013-02-27 14:24 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/13013dedcdfd

8008793: SecurityManager.checkXXX behavior not specified for methods that check AWTPermission and AWT not present
Reviewed-by: hawtin, mullan, dsamersoff, mchung

! src/share/classes/java/lang/SecurityManager.java
! src/share/classes/sun/security/util/SecurityConstants.java
! test/java/lang/SecurityManager/NoAWT.java

Changeset: 1b3173c326e6
Author:    sundar
Date:      2013-02-27 20:34 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1b3173c326e6

8009140: jtreg tests under sun/tools/jrunscript should use nashorn engine
Reviewed-by: alanb

! test/sun/tools/jrunscript/CheckEngine.java
! test/sun/tools/jrunscript/jrunscript-DTest.sh
! test/sun/tools/jrunscript/jrunscript-argsTest.sh
! test/sun/tools/jrunscript/jrunscript-cpTest.sh
! test/sun/tools/jrunscript/jrunscript-eTest.sh
! test/sun/tools/jrunscript/jrunscript-fTest.sh
! test/sun/tools/jrunscript/jrunscriptTest.sh
! test/sun/tools/jrunscript/repl.out

Changeset: 093fdf8937bd
Author:    vladidan
Date:      2013-02-22 17:12 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/093fdf8937bd

8005545: Add System property to identify ARCH specific details such as ARM hard-float binaries
Summary: Adding sun.os.abi Java Property support
Reviewed-by: bobv, alanb, dholmes

! makefiles/Images.gmk
! src/share/native/java/lang/System.c
! src/share/native/java/lang/java_props.h
! src/solaris/native/java/lang/java_props_md.c

Changeset: f4b01f4e8f35
Author:    mduigou
Date:      2013-02-27 11:00 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f4b01f4e8f35

8008785: IdentityHashMap.values().toArray(V[]) broken by JDK-8008167
Reviewed-by: alanb

! src/share/classes/java/util/IdentityHashMap.java
+ test/java/util/Map/ToArray.java

Changeset: 7d272e524768
Author:    chegar
Date:      2013-02-28 12:39 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7d272e524768

8006409: ThreadLocalRandom should dropping padding fields from its serialized form
Reviewed-by: dl, martin, alanb, shade

! src/share/classes/java/util/concurrent/ThreadLocalRandom.java

Changeset: 7246a6e4dd5a
Author:    juh
Date:      2013-02-28 16:36 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7246a6e4dd5a

8006853: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout < 0
Reviewed-by: mullan

! src/share/classes/sun/security/provider/certpath/OCSP.java

Changeset: def2e05299b7
Author:    xuelei
Date:      2013-03-01 02:34 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/def2e05299b7

7030966: Support AEAD CipherSuites
Reviewed-by: weijun, wetmore, valeriep

! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
! src/share/classes/sun/security/internal/spec/TlsKeyMaterialParameterSpec.java
! src/share/classes/sun/security/internal/spec/TlsKeyMaterialSpec.java
! src/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java
+ src/share/classes/sun/security/ssl/Authenticator.java
! src/share/classes/sun/security/ssl/CipherBox.java
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/EngineInputRecord.java
! src/share/classes/sun/security/ssl/EngineOutputRecord.java
! src/share/classes/sun/security/ssl/EngineWriter.java
! src/share/classes/sun/security/ssl/Handshaker.java
! src/share/classes/sun/security/ssl/InputRecord.java
! src/share/classes/sun/security/ssl/JsseJce.java
! src/share/classes/sun/security/ssl/MAC.java
! src/share/classes/sun/security/ssl/OutputRecord.java
! src/share/classes/sun/security/ssl/Record.java
! src/share/classes/sun/security/ssl/SSLEngineImpl.java
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
! test/sun/security/ec/TestEC.java
! test/sun/security/pkcs11/fips/CipherTest.java
! test/sun/security/pkcs11/sslecc/CipherTest.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java
+ test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKeyGCM.java
! test/sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java
! test/sun/security/ssl/sanity/interop/CipherTest.java
! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java

Changeset: 1652ac7b4bfd
Author:    mullan
Date:      2013-03-01 16:12 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1652ac7b4bfd

8008908: Access denied when invoking Subject.doAsPrivileged()
Summary: wildcard principal names are not processed correctly
Reviewed-by: xuelei

! src/share/classes/sun/security/provider/PolicyFile.java
+ test/sun/security/provider/PolicyFile/WildcardPrincipalName.java
+ test/sun/security/provider/PolicyFile/wildcard.policy

Changeset: 1ca712765acb
Author:    mullan
Date:      2013-03-01 16:15 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ca712765acb

Merge


Changeset: 30e30ef6077e
Author:    dxu
Date:      2013-03-01 14:12 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/30e30ef6077e

8006645: TEST_BUG: java/nio/file/Files/CopyAndMove.java failing intermittently (sol)
Summary: Fix test failures and update java doc of Files.move
Reviewed-by: alanb, chegar

! src/share/classes/java/nio/file/Files.java
! test/java/nio/file/Files/CopyAndMove.java

Changeset: f08ad5938709
Author:    chegar
Date:      2013-03-02 08:54 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f08ad5938709

8008378: FJP.commonPool support parallelism 0, add awaitQuiescence
Reviewed-by: chegar
Contributed-by: Doug Lea 
, Chris Hegarty 

! src/share/classes/java/util/concurrent/ForkJoinPool.java
! src/share/classes/java/util/concurrent/ForkJoinTask.java
+ test/java/util/concurrent/forkjoin/ThreadLessCommon.java
+ test/java/util/concurrent/forkjoin/ThrowingRunnable.java

Changeset: df76ba760eec
Author:    ksrini
Date:      2013-03-03 20:52 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/df76ba760eec

8007297: [pack200] allow opcodes with InterfaceMethodRefs
Reviewed-by: jrose

! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java
! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java
! src/share/classes/com/sun/java/util/jar/pack/Constants.java
! src/share/classes/com/sun/java/util/jar/pack/Instruction.java
! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java
! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java
! src/share/native/com/sun/java/util/jar/pack/constants.h
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp
! test/tools/pack200/AttributeTests.java
! test/tools/pack200/InstructionTests.java
! test/tools/pack200/Utils.java

Changeset: 83e847f59fd6
Author:    darcy
Date:      2013-03-04 19:42 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/83e847f59fd6

8009267: Restore isAnnotationPresent methods in public AnnotatedElement implementations
Reviewed-by: jjg

! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/Package.java
! src/share/classes/java/lang/reflect/AccessibleObject.java
+ test/java/lang/reflect/OldenCompilingWithDefaults.java

Changeset: 1a2e59d19d3e
Author:    naoto
Date:      2013-03-04 20:46 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1a2e59d19d3e

8004240: Return value from getAdapterPrefence() can be modified
Reviewed-by: okutsu

! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java
+ test/java/util/Locale/Bug8004240.java

Changeset: 62639ca66ab9
Author:    ewang
Date:      2013-03-05 10:10 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/62639ca66ab9

8009259: TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently
Reviewed-by: chegar, alanb

! test/sun/misc/Cleaner/ExitOnThrow.java
! test/sun/misc/Cleaner/exitOnThrow.sh

Changeset: b5bef1f71de6
Author:    jzavgren
Date:      2013-03-05 14:30 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b5bef1f71de6

8008804: file descriptor leak in src/windows/native/java/net/DualStackPlainSocketImpl.c
Reviewed-by: alanb, chegar, dsamersoff

! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c

Changeset: be79440b8026
Author:    jzavgren
Date:      2013-03-05 09:50 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/be79440b8026

4880778: URL final class has protected methods
Summary: The two set() methods have been defined to be package private.
Reviewed-by: alanb, chegar, khazra

! src/share/classes/java/net/URL.java
! src/share/classes/java/net/URLStreamHandler.java

Changeset: f960a34f05ce
Author:    lana
Date:      2013-03-05 11:49 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f960a34f05ce

Merge

! makefiles/Images.gmk

Changeset: 34372bb9115d
Author:    sla
Date:      2013-03-05 19:25 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/34372bb9115d

8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket
Reviewed-by: alanb

! src/share/back/transport.c
! src/share/demo/jvmti/hprof/hprof_init.c
! src/solaris/back/linker_md.c
! src/solaris/demo/jvmti/hprof/hprof_md.c
! src/windows/back/linker_md.c
! src/windows/demo/jvmti/hprof/hprof_md.c

Changeset: 38e1821c4472
Author:    jfranck
Date:      2013-03-06 18:35 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/38e1821c4472

8007808: Missing method: Executable.getAnnotatedReturnType()
Reviewed-by: darcy, forax

! src/share/classes/java/lang/reflect/Constructor.java
! src/share/classes/java/lang/reflect/Executable.java
! src/share/classes/java/lang/reflect/Method.java

Changeset: 14e49a70729a
Author:    martin
Date:      2013-03-06 17:43 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/14e49a70729a

8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
Summary: Define FILES_m to force use of linker script
Reviewed-by: sherman, alanb, ohair

! make/java/zip/Makefile
! src/share/native/java/util/zip/Inflater.c

Changeset: cf54f6be3e9e
Author:    weijun
Date:      2013-03-07 11:32 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cf54f6be3e9e

8009604: old make images failed: JarBASE64Encoder class not found
Reviewed-by: xuelei, wetmore

! make/common/Release.gmk

Changeset: 48b7295f02f8
Author:    chegar
Date:      2013-03-07 10:07 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/48b7295f02f8

6370908: Add support for HTTP_CONNECT proxy in Socket class
Reviewed-by: chegar
Contributed-by: Damjan Jovanovic , Chris Hegarty 

+ src/share/classes/java/net/HttpConnectSocketImpl.java
! src/share/classes/java/net/Socket.java
+ test/java/net/Socket/HttpProxy.java

Changeset: 98cf76df3e6e
Author:    alanb
Date:      2013-03-08 12:03 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/98cf76df3e6e

8006000: TEST_BUG: java/lang/invoke/lambda/LambdaAccessControlTest.java fails intermittently
Reviewed-by: chegar

+ test/java/lang/invoke/lambda/LUtils.java
! test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java
! test/java/lang/invoke/lambda/LambdaAccessControlTest.java

Changeset: 01908630df14
Author:    alanb
Date:      2013-03-08 19:51 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01908630df14

8009645: ClassFileTransformer hooks in ClassLoader no longer required
Reviewed-by: mchung, iris

! src/share/classes/java/lang/ClassLoader.java
! src/share/classes/sun/misc/ClassFileTransformer.java

Changeset: e38b46041049
Author:    mduigou
Date:      2013-03-08 15:45 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e38b46041049

8001667: Comparator combinators and extension methods
Reviewed-by: mduigou, briangoetz
Contributed-by: henry.jen at oracle.com

! make/java/java/FILES_java.gmk
! src/share/classes/java/util/Collections.java
! src/share/classes/java/util/Comparator.java
+ src/share/classes/java/util/Comparators.java
! test/java/util/Collections/ReverseOrder.java
+ test/java/util/ComparatorsTest.java

Changeset: 230bafd05509
Author:    weijun
Date:      2013-03-09 17:27 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/230bafd05509

8000653: SPNEGO tests fail at context.getDelegCred().getRemainingInitLifetime(mechOid)
Reviewed-by: valeriep

! src/share/classes/sun/security/jgss/GSSCredentialImpl.java
! src/share/classes/sun/security/jgss/spnego/SpNegoCredElement.java
! test/sun/security/krb5/auto/Context.java
+ test/sun/security/krb5/auto/SpnegoLifeTime.java

Changeset: 334ddf3b101f
Author:    coleenp
Date:      2013-03-12 10:35 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/334ddf3b101f

7154889: Non-zero padding is still not allowed in the tableswitch/lookupswitch instructions.
Summary: Do not check that the padding bytes are zero if class file format version >=51.
Reviewed-by: dholmes, coleenp, mullan, kvn
Contributed-by: harold.seigel at oracle.com

! src/share/native/common/check_code.c

Changeset: 6379415d8fca
Author:    wetmore
Date:      2013-03-12 15:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6379415d8fca

8009925: Back out AEAD CipherSuites temporarily
Reviewed-by: valeriep

! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
! src/share/classes/sun/security/internal/spec/TlsKeyMaterialParameterSpec.java
! src/share/classes/sun/security/internal/spec/TlsKeyMaterialSpec.java
! src/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java
- src/share/classes/sun/security/ssl/Authenticator.java
! src/share/classes/sun/security/ssl/CipherBox.java
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/EngineInputRecord.java
! src/share/classes/sun/security/ssl/EngineOutputRecord.java
! src/share/classes/sun/security/ssl/EngineWriter.java
! src/share/classes/sun/security/ssl/Handshaker.java
! src/share/classes/sun/security/ssl/InputRecord.java
! src/share/classes/sun/security/ssl/JsseJce.java
! src/share/classes/sun/security/ssl/MAC.java
! src/share/classes/sun/security/ssl/OutputRecord.java
! src/share/classes/sun/security/ssl/Record.java
! src/share/classes/sun/security/ssl/SSLEngineImpl.java
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
! test/sun/security/ec/TestEC.java
! test/sun/security/pkcs11/fips/CipherTest.java
! test/sun/security/pkcs11/sslecc/CipherTest.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java
- test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKeyGCM.java
! test/sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java
! test/sun/security/ssl/sanity/interop/CipherTest.java
! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java

Changeset: 5880bfd30db1
Author:    lana
Date:      2013-03-12 16:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5880bfd30db1

Merge

- make/tools/javazic/Makefile
- make/tools/src/build/tools/javazic/BackEnd.java
- make/tools/src/build/tools/javazic/Checksum.java
- make/tools/src/build/tools/javazic/DayOfWeek.java
- make/tools/src/build/tools/javazic/Gen.java
- make/tools/src/build/tools/javazic/GenDoc.java
- make/tools/src/build/tools/javazic/Main.java
- make/tools/src/build/tools/javazic/Mappings.java
- make/tools/src/build/tools/javazic/Month.java
- make/tools/src/build/tools/javazic/Rule.java
- make/tools/src/build/tools/javazic/RuleDay.java
- make/tools/src/build/tools/javazic/RuleRec.java
- make/tools/src/build/tools/javazic/Simple.java
- make/tools/src/build/tools/javazic/Time.java
- make/tools/src/build/tools/javazic/Timezone.java
- make/tools/src/build/tools/javazic/Zone.java
- make/tools/src/build/tools/javazic/ZoneRec.java
- make/tools/src/build/tools/javazic/Zoneinfo.java
- src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java
- src/share/classes/java/util/function/Block.java
- src/share/classes/java/util/function/DoubleBlock.java
- src/share/classes/java/util/function/IntBlock.java
- src/share/classes/java/util/function/LongBlock.java
- test/javax/script/RhinoExceptionTest.java

Changeset: 72ffb2bc15bb
Author:    lana
Date:      2013-03-12 18:12 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/72ffb2bc15bb

Merge

- make/tools/javazic/Makefile
- make/tools/src/build/tools/javazic/BackEnd.java
- make/tools/src/build/tools/javazic/Checksum.java
- make/tools/src/build/tools/javazic/DayOfWeek.java
- make/tools/src/build/tools/javazic/Gen.java
- make/tools/src/build/tools/javazic/GenDoc.java
- make/tools/src/build/tools/javazic/Main.java
- make/tools/src/build/tools/javazic/Mappings.java
- make/tools/src/build/tools/javazic/Month.java
- make/tools/src/build/tools/javazic/Rule.java
- make/tools/src/build/tools/javazic/RuleDay.java
- make/tools/src/build/tools/javazic/RuleRec.java
- make/tools/src/build/tools/javazic/Simple.java
- make/tools/src/build/tools/javazic/Time.java
- make/tools/src/build/tools/javazic/Timezone.java
- make/tools/src/build/tools/javazic/Zone.java
- make/tools/src/build/tools/javazic/ZoneRec.java
- make/tools/src/build/tools/javazic/Zoneinfo.java
- src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java
- src/share/classes/java/util/function/Block.java
- src/share/classes/java/util/function/DoubleBlock.java
- src/share/classes/java/util/function/IntBlock.java
- src/share/classes/java/util/function/LongBlock.java
! test/ProblemList.txt
- test/javax/script/RhinoExceptionTest.java

Changeset: 66a892bb28b7
Author:    anthony
Date:      2012-10-12 15:51 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/66a892bb28b7

7173145: Improve in-memory representation of splashscreens
Reviewed-by: bae, mschoene

! src/share/native/sun/awt/splashscreen/splashscreen_jpeg.c

Changeset: 85bf51db473c
Author:    xuelei
Date:      2012-10-15 07:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/85bf51db473c

7192393: Better Checking of order of TLS Messages
Summary: Also reviewed by Andrew Gross
Reviewed-by: weijun

! src/share/classes/sun/security/ssl/ClientHandshaker.java
! src/share/classes/sun/security/ssl/ServerHandshaker.java

Changeset: 24a3eb2f0553
Author:    malenkov
Date:      2012-10-15 19:00 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/24a3eb2f0553

7200493: Improve cache handling
Reviewed-by: art, ahgross

! src/share/classes/com/sun/beans/finder/MethodFinder.java

Changeset: c7c39320bc6c
Author:    rupashka
Date:      2012-10-16 14:13 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c7c39320bc6c

7186948: Improve Swing data validation
Reviewed-by: art, ahgross

! src/share/classes/javax/swing/UIDefaults.java

Changeset: 3c8d0085b094
Author:    ksrini
Date:      2012-10-16 12:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3c8d0085b094

7186945: Unpack200 improvement
Reviewed-by: jrose, jjh, mschoene

! src/share/native/com/sun/java/util/jar/pack/jni.cpp

Changeset: 01f67953c057
Author:    ksrini
Date:      2012-10-16 12:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01f67953c057

7186957: Improve Pack200 data validation
Reviewed-by: jrose, jjh, mschoene

! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java
! src/share/native/com/sun/java/util/jar/pack/bands.cpp
! src/share/native/com/sun/java/util/jar/pack/bands.h
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp

Changeset: b0bf41ba1cf8
Author:    ksrini
Date:      2012-10-16 12:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b0bf41ba1cf8

7186946: Refine unpacker resource usage
Reviewed-by: jrose, jjh, mschoene

! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java
! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java
! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java
! src/share/native/com/sun/java/util/jar/pack/jni.cpp
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp

Changeset: f0bc5a6dff2b
Author:    ksrini
Date:      2012-10-16 16:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f0bc5a6dff2b

7200499: Better data validation for options
Reviewed-by: darcy, jjh, mschoene

! src/share/bin/jli_util.h
! src/windows/bin/java_md.c

Changeset: 7e19ab4ff5d3
Author:    ksrini
Date:      2012-10-16 10:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7e19ab4ff5d3

7200500: Launcher better input validation
Reviewed-by: darcy, jjh, mschoene

! src/share/bin/parse_manifest.c

Changeset: 62f3270f03fa
Author:    dholmes
Date:      2012-08-22 21:40 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/62f3270f03fa

6776941: Improve thread pool shutdown
Reviewed-by: dl, skoivu

! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java

Changeset: e7cce63bf293
Author:    xuelei
Date:      2012-10-22 07:28 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e7cce63bf293

7192392: Better validation of client keys
Summary: Also reviewed by Andrew Gross
Reviewed-by: vinnie

! src/share/classes/com/sun/crypto/provider/DHKeyAgreement.java
! src/share/classes/sun/security/pkcs11/P11KeyAgreement.java
! src/share/classes/sun/security/ssl/ClientHandshaker.java
! src/share/classes/sun/security/ssl/DHClientKeyExchange.java
! src/share/classes/sun/security/ssl/DHCrypt.java
! src/share/classes/sun/security/ssl/HandshakeMessage.java
! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java
! src/share/classes/sun/security/ssl/ServerHandshaker.java
! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java
! src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
- src/share/classes/sun/security/util/KeyLength.java
+ src/share/classes/sun/security/util/KeyUtil.java
! test/sun/security/mscapi/ShortRSAKeyWithinTLS.java

Changeset: 091dd6eb30aa
Author:    khazra
Date:      2012-10-22 11:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/091dd6eb30aa

7186954: Improve connection performance
Reviewed-by: chegar, skoivu

! src/share/classes/sun/net/httpserver/ChunkedInputStream.java
! src/share/classes/sun/net/www/http/ChunkedInputStream.java

Changeset: c26d42a92bd8
Author:    weijun
Date:      2012-09-19 12:58 +0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c26d42a92bd8

8000210: Improve JarFile code quality
Reviewed-by: ahgross, xuelei, mschoene

! src/share/classes/java/util/jar/JarFile.java
! src/share/classes/sun/security/util/DerIndefLenConverter.java

Changeset: a54b61ae6f12
Author:    mullan
Date:      2012-10-26 15:21 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a54b61ae6f12

7201068: Better handling of UI elements
Reviewed-by: xuelei

! src/share/lib/security/java.security
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows

Changeset: 71ab8d79c6b4
Author:    asaha
Date:      2012-10-26 10:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/71ab8d79c6b4

Merge

- src/macosx/classes/sun/awt/SunToolkitSubclass.java
! src/share/classes/java/io/FilePermission.java
! src/share/classes/java/lang/invoke/MethodHandleImpl.java
! src/share/classes/java/lang/invoke/MethodHandleStatics.java
! src/share/classes/java/util/ServiceLoader.java
! src/share/classes/sun/invoke/util/ValueConversions.java
- src/share/classes/sun/management/LockDataConverter.java
- src/share/classes/sun/management/LockDataConverterMXBean.java
! src/share/classes/sun/security/ssl/HandshakeMessage.java
- src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java
- src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java
- src/share/classes/sun/util/xml/XMLUtils.java
- src/share/test/pack200/pack.conf
- test/sun/misc/URLClassPath/ClassnameCharTest.sh
- test/sun/net/www/httptest/HttpServer.java
- test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java

Changeset: be07910b3fad
Author:    asaha
Date:      2012-10-26 13:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/be07910b3fad

Merge


Changeset: e14221289076
Author:    dsamersoff
Date:      2012-10-30 17:05 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e14221289076

8000539: JMX implementation allows invocation of methods of a system class
Summary: Added extra packageAccess check call
Reviewed-by: ahgross, dfuchs
Contributed-by: jaroslav.bachorik at oracle.com

! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java

Changeset: 64440cc2ea8b
Author:    mchung
Date:      2012-11-02 16:50 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/64440cc2ea8b

7197546: (proxy) Reflect about creating reflective proxies
Reviewed-by: alanb, jdn, jrose

! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/invoke/MethodHandleProxies.java
! src/share/classes/java/lang/reflect/Proxy.java
! src/share/classes/sun/reflect/misc/ReflectUtil.java
! test/java/rmi/server/RMIClassLoader/loadProxyClasses/security.policy

Changeset: f936be5be1e7
Author:    rupashka
Date:      2012-11-06 15:30 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f936be5be1e7

7200491: Tighten up JTable layout code
Reviewed-by: art, skoivu

! src/share/classes/javax/swing/JTable.java
! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java

Changeset: 3069b91ff041
Author:    chegar
Date:      2012-11-07 14:26 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3069b91ff041

7201071: InetSocketAddress serialization issue
Reviewed-by: alanb, michaelm, skoivu

! src/share/classes/java/net/InetSocketAddress.java
! src/share/classes/sun/nio/ch/DatagramChannelImpl.java
! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java
! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java
! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c
! src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c
! src/windows/native/sun/nio/ch/DatagramChannelImpl.c
! test/java/nio/channels/DatagramChannel/SendToUnresolved.java

Changeset: 69fd15e0437d
Author:    smarks
Date:      2012-11-08 15:41 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/69fd15e0437d

7201070: Serialization to conform to protocol
Reviewed-by: dmocek, ahgross, skoivu

! src/share/classes/java/io/ObjectInputStream.java

Changeset: 9097b6ec0ecd
Author:    ksrini
Date:      2012-11-09 14:36 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9097b6ec0ecd

8002091: tools/launcher/ToolsOpts.java test started to fail since 7u11 b01 on Windows
Reviewed-by: darcy, jjh, mschoene

! src/share/bin/jli_util.h
! src/windows/bin/java_md.c
! test/tools/launcher/ToolsOpts.java

Changeset: 7bc8d5a63d9e
Author:    bagiras
Date:      2012-11-15 23:03 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7bc8d5a63d9e

7192977: Issue in toolkit thread
Reviewed-by: skoivu, rupashka, art

! src/share/classes/java/awt/EventQueue.java
! src/share/classes/java/awt/Window.java
! src/share/classes/javax/swing/RepaintManager.java
! src/share/classes/sun/applet/AppletPanel.java
! src/share/classes/sun/awt/AWTAccessor.java
! src/windows/classes/sun/awt/windows/WComponentPeer.java
! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java

Changeset: 09e2dcd476cf
Author:    bae
Date:      2012-11-16 11:05 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/09e2dcd476cf

8001972: Improve image processing
Reviewed-by: prr, ahgross

! src/share/classes/sun/awt/image/ByteComponentRaster.java
! src/share/classes/sun/awt/image/ByteInterleavedRaster.java
! src/share/classes/sun/awt/image/ShortComponentRaster.java
! src/share/classes/sun/awt/image/ShortInterleavedRaster.java
! src/share/native/sun/awt/image/awt_parseImage.c
! src/share/native/sun/awt/medialib/safe_alloc.h

Changeset: 1b616e1ca09c
Author:    dmocek
Date:      2012-11-19 13:54 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1b616e1ca09c

6563318: RMI data sanitization
Reviewed-by: ahgross, hawtin, mchung, smarks

! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java
! test/java/rmi/testlibrary/JavaVM.java

Changeset: aa8717a5c9cd
Author:    dmocek
Date:      2012-11-19 15:38 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/aa8717a5c9cd

8001242: Improve RMI HTTP conformance
Reviewed-by: ahgross, mchung, smarks

! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java
! src/share/classes/sun/rmi/transport/proxy/HttpInputStream.java

Changeset: ecedf46ae7db
Author:    bae
Date:      2012-11-20 11:46 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ecedf46ae7db

8002325: Improve management of images
Reviewed-by: prr, ahgross

! src/share/native/sun/awt/image/awt_parseImage.c
! src/share/native/sun/awt/image/awt_parseImage.h

Changeset: eda84d5738e3
Author:    denis
Date:      2012-11-26 20:49 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eda84d5738e3

7186952: Improve clipboard access
Reviewed-by: serb, ahgross

! src/share/classes/java/awt/TextComponent.java
! src/windows/native/sun/windows/awt_TextComponent.cpp
! src/windows/native/sun/windows/awt_TextComponent.h

Changeset: d1668eca22bf
Author:    mchung
Date:      2012-11-26 22:49 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d1668eca22bf

6664509: Add logging context
6664528: Find log level matching its name or value given at construction time
Reviewed-by: alanb, ahgross, jgish, hawtin

! src/share/classes/java/util/logging/Level.java
! src/share/classes/java/util/logging/LogManager.java
! src/share/classes/java/util/logging/Logger.java
! src/share/classes/java/util/logging/Logging.java
! src/share/classes/java/util/logging/LoggingProxyImpl.java
! src/share/classes/java/util/logging/SimpleFormatter.java
! src/share/classes/sun/awt/AppContext.java
! src/share/classes/sun/misc/JavaAWTAccess.java
! src/share/lib/security/java.security

Changeset: b8ee2e9ff7e3
Author:    denis
Date:      2012-11-30 15:51 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b8ee2e9ff7e3

7201064: Better dialogue checking
Reviewed-by: serb, skoivu

! src/share/classes/java/awt/Dialog.java

Changeset: 90bbdae7aaa4
Author:    ewendeli
Date:      2013-02-03 23:25 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/90bbdae7aaa4

Merge

! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java
! src/share/classes/java/awt/Dialog.java
! src/share/classes/java/awt/TextComponent.java
! src/share/classes/java/awt/Window.java
! src/share/classes/java/io/FilePermission.java
! src/share/classes/java/io/ObjectInputStream.java
! src/share/classes/java/lang/Class.java
! src/share/classes/java/lang/invoke/MethodHandleProxies.java
! src/share/classes/java/lang/invoke/MethodHandleStatics.java
! src/share/classes/java/lang/reflect/Proxy.java
! src/share/classes/java/util/logging/LogManager.java
! src/share/classes/java/util/logging/Logger.java
! src/share/classes/java/util/logging/Logging.java
! src/share/classes/java/util/logging/LoggingProxyImpl.java
! src/share/classes/java/util/logging/SimpleFormatter.java
! src/share/classes/javax/swing/JTable.java
! src/share/classes/sun/awt/AWTAccessor.java
! src/share/classes/sun/invoke/util/ValueConversions.java
! src/share/classes/sun/reflect/misc/ReflectUtil.java
! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java
! src/share/classes/sun/rmi/transport/proxy/HttpInputStream.java
! src/share/classes/sun/security/ssl/ClientHandshaker.java
! src/share/classes/sun/security/ssl/DHClientKeyExchange.java
! src/share/classes/sun/security/ssl/HandshakeMessage.java
! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java
! src/share/classes/sun/security/ssl/ServerHandshaker.java
! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java
- src/share/classes/sun/security/util/KeyLength.java
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
! src/share/native/com/sun/java/util/jar/pack/bands.cpp
! src/share/native/com/sun/java/util/jar/pack/bands.h
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp
! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java
! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java
! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c
! src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c
! src/windows/native/sun/nio/ch/DatagramChannelImpl.c
! test/java/rmi/testlibrary/JavaVM.java

Changeset: cc2057f84eb7
Author:    mchung
Date:      2012-12-05 14:02 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cc2057f84eb7

8004175: Restricted packages added in java.security are missing in java.security-{macosx, solaris, windows}
Reviewed-by: alanb, ahgross, mullan

! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows

Changeset: 89e43b8940c9
Author:    dsamersoff
Date:      2012-12-07 22:49 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/89e43b8940c9

8000537: Contextualize RequiredModelMBean class
Summary: Contextualize RequiredModelMBean class
Reviewed-by: asaha
Contributed-by: jaroslav.bachorik at oracle.com

! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java

Changeset: 7933c80c162a
Author:    denis
Date:      2012-12-12 21:08 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7933c80c162a

8004341: Two JCK tests fails with 7u11 b06
Reviewed-by: serb, skoivu

! src/share/classes/java/awt/Dialog.java

Changeset: ed08394e1a15
Author:    mullan
Date:      2012-12-18 13:48 -0500
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ed08394e1a15

8004302: javax/xml/soap/Test7013971.java fails since jdk6u39b01
Reviewed-by: vinnie, skoivu, mgrebac, ohair, tbell

! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
! test/Makefile

Changeset: 32cd4975d2d6
Author:    mchung
Date:      2013-01-10 19:43 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/32cd4975d2d6

8005615: Java Logger fails to load tomcat logger implementation (JULI)
Reviewed-by: alanb, ahgross

! src/share/classes/java/util/logging/LogManager.java
! src/share/classes/java/util/logging/Logger.java
+ test/java/util/logging/CustomLogManager.java
+ test/java/util/logging/CustomLogManagerTest.java
+ test/java/util/logging/SimpleLogManager.java

Changeset: c0fbd737aef0
Author:    ewendeli
Date:      2013-01-28 11:07 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c0fbd737aef0

8006864: Update java.security-linux to include changes in java.security
Reviewed-by: mchung, mullan

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows

Changeset: 12491fa16985
Author:    ewendeli
Date:      2013-02-05 15:35 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/12491fa16985

Merge

! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java
! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java
! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java
! src/share/classes/java/lang/Class.java
- src/share/classes/sun/security/util/KeyLength.java

Changeset: de419ea8ed8f
Author:    mchung
Date:      2013-01-28 15:53 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/de419ea8ed8f

8006882: Proxy generated classes in sun.proxy package breaks JMockit
Reviewed-by: alanb, ahgross

! src/share/classes/java/lang/reflect/Proxy.java
! src/share/classes/sun/reflect/misc/ReflectUtil.java
! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows

Changeset: 8effe3b7489d
Author:    dfuchs
Date:      2013-01-30 11:33 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8effe3b7489d

8006446: Restrict MBeanServer access
Reviewed-by: alanb, mchung, darcy, jrose, ahgross, skoivu

! src/share/classes/com/sun/jmx/mbeanserver/ClassLoaderRepositorySupport.java
! src/share/classes/com/sun/jmx/mbeanserver/JmxMBeanServer.java
! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java
! src/share/classes/com/sun/jmx/mbeanserver/MBeanSupport.java
! src/share/classes/java/lang/management/ManagementFactory.java
! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-macosx
! src/share/lib/security/java.security-solaris
! src/share/lib/security/java.security-windows
! test/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation2Test.java
! test/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation3Test.java

Changeset: ebfb0bb58428
Author:    mchung
Date:      2013-01-24 16:45 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ebfb0bb58428

8004937: Improve proxy construction
Reviewed-by: jrose, ahgross

! src/share/classes/java/lang/invoke/MethodHandleNatives.java
! src/share/classes/java/lang/invoke/MethodHandleProxies.java

Changeset: af11c227a91e
Author:    mchung
Date:      2013-02-05 22:56 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/af11c227a91e

8007393: Possible race condition after JDK-6664509
Reviewed-by: alanb, jgish

! src/share/classes/java/util/logging/LogManager.java

Changeset: 1143bb5e7064
Author:    mchung
Date:      2013-02-07 09:41 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1143bb5e7064

8007611: logging behavior in applet changed
Reviewed-by: alanb, jgish

! src/share/classes/java/util/logging/LogManager.java

Changeset: 5925630b7a7d
Author:    xuelei
Date:      2013-02-07 16:05 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5925630b7a7d

8006777: Improve TLS handling of invalid messages
Reviewed-by: wetmore, ahgross

! src/share/classes/sun/security/ssl/CipherBox.java
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/EngineInputRecord.java
! src/share/classes/sun/security/ssl/EngineOutputRecord.java
! src/share/classes/sun/security/ssl/InputRecord.java
! src/share/classes/sun/security/ssl/MAC.java
! src/share/classes/sun/security/ssl/OutputRecord.java
! src/share/classes/sun/security/ssl/SSLEngineImpl.java
! src/share/classes/sun/security/ssl/SSLSocketImpl.java

Changeset: d57363ff612f
Author:    valeriep
Date:      2013-02-07 16:03 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d57363ff612f

8007688: Blacklist known bad certificate
Summary: Added two known bad certs to the blacklist certs.
Reviewed-by: mullan

! src/share/classes/sun/security/util/UntrustedCertificates.java

Changeset: c18aeb4ca957
Author:    ewendeli
Date:      2013-02-19 21:48 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c18aeb4ca957

Merge

! src/share/bin/parse_manifest.c
! src/share/classes/java/lang/Class.java
- src/share/classes/sun/security/util/KeyLength.java
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp
! src/share/native/sun/awt/image/awt_parseImage.c
! test/Makefile

Changeset: f7fb3de623ba
Author:    ewendeli
Date:      2013-02-19 21:53 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f7fb3de623ba

Merge


Changeset: f686c8e3c8e0
Author:    ewendeli
Date:      2013-02-25 08:44 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f686c8e3c8e0

Merge

! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! src/share/classes/java/util/jar/JarFile.java
! src/share/classes/java/util/logging/LogManager.java
- src/share/classes/sun/security/util/KeyLength.java
! src/share/native/com/sun/java/util/jar/pack/bands.cpp
! src/share/native/com/sun/java/util/jar/pack/bands.h
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp

Changeset: e3cac5962e32
Author:    vlivanov
Date:      2013-02-22 03:00 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e3cac5962e32

8006439: Improve MethodHandles coverage
Reviewed-by: jrose, twisti

! src/share/classes/java/lang/invoke/MethodHandleImpl.java
! src/share/classes/java/lang/invoke/MethodHandleNatives.java
! src/share/classes/java/lang/invoke/MethodHandles.java

Changeset: 62be74f35886
Author:    vlivanov
Date:      2013-02-22 03:00 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/62be74f35886

8006179: JSR292 MethodHandles lookup with interface using findVirtual()
Reviewed-by: jrose, twisti

! src/share/classes/java/lang/invoke/DirectMethodHandle.java

Changeset: 9995881dfb4e
Author:    vlivanov
Date:      2013-02-22 02:59 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9995881dfb4e

8006125: Update MethodHandles library interactions
Reviewed-by: jrose

! src/share/classes/sun/reflect/misc/MethodUtil.java

Changeset: 0807820fca96
Author:    vlivanov
Date:      2013-02-22 02:58 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0807820fca96

8004933: Improve MethodHandle interaction with libraries
Reviewed-by: jrose

! src/share/classes/java/lang/invoke/MethodHandleNatives.java

Changeset: ae1fed8d80e1
Author:    ewendeli
Date:      2013-02-26 06:47 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ae1fed8d80e1

Merge

- src/share/classes/sun/security/util/KeyLength.java

Changeset: 5e4c2d7f3b67
Author:    ewendeli
Date:      2013-02-26 20:36 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5e4c2d7f3b67

Merge

! src/share/classes/java/lang/invoke/DirectMethodHandle.java
! src/share/classes/java/lang/invoke/MethodHandleImpl.java
! src/share/classes/java/lang/invoke/MethodHandles.java
- src/share/classes/sun/security/util/KeyLength.java

Changeset: 4d4848124bff
Author:    ewendeli
Date:      2013-02-27 09:28 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4d4848124bff

Merge

- src/share/classes/sun/security/util/KeyLength.java

Changeset: 36ff48ae6ffe
Author:    ewendeli
Date:      2013-02-27 18:13 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/36ff48ae6ffe

Merge

- src/share/classes/sun/security/util/KeyLength.java

Changeset: 931fb59eae26
Author:    lana
Date:      2013-03-12 19:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/931fb59eae26

Merge

! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java
! src/share/classes/java/awt/EventQueue.java
! src/share/classes/java/lang/Class.java
! src/share/classes/sun/security/ssl/CipherBox.java
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/EngineInputRecord.java
! src/share/classes/sun/security/ssl/EngineOutputRecord.java
! src/share/classes/sun/security/ssl/InputRecord.java
! src/share/classes/sun/security/ssl/MAC.java
! src/share/classes/sun/security/ssl/OutputRecord.java
! src/share/classes/sun/security/ssl/SSLEngineImpl.java
! src/share/classes/sun/security/ssl/SSLSocketImpl.java
- src/share/classes/sun/security/util/KeyLength.java
! src/share/native/com/sun/java/util/jar/pack/unpack.cpp
! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java

Changeset: 9528e88f8d53
Author:    lana
Date:      2013-03-13 23:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9528e88f8d53

Merge

- make/tools/javazic/Makefile
- make/tools/src/build/tools/javazic/BackEnd.java
- make/tools/src/build/tools/javazic/Checksum.java
- make/tools/src/build/tools/javazic/DayOfWeek.java
- make/tools/src/build/tools/javazic/Gen.java
- make/tools/src/build/tools/javazic/GenDoc.java
- make/tools/src/build/tools/javazic/Main.java
- make/tools/src/build/tools/javazic/Mappings.java
- make/tools/src/build/tools/javazic/Month.java
- make/tools/src/build/tools/javazic/Rule.java
- make/tools/src/build/tools/javazic/RuleDay.java
- make/tools/src/build/tools/javazic/RuleRec.java
- make/tools/src/build/tools/javazic/Simple.java
- make/tools/src/build/tools/javazic/Time.java
- make/tools/src/build/tools/javazic/Timezone.java
- make/tools/src/build/tools/javazic/Zone.java
- make/tools/src/build/tools/javazic/ZoneRec.java
- make/tools/src/build/tools/javazic/Zoneinfo.java
! makefiles/CompileNativeLibraries.gmk
! makefiles/Images.gmk
- src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java
- src/share/classes/java/util/function/Block.java
- src/share/classes/java/util/function/DoubleBlock.java
- src/share/classes/java/util/function/IntBlock.java
- src/share/classes/java/util/function/LongBlock.java
- src/share/classes/sun/security/util/KeyLength.java
- test/javax/script/RhinoExceptionTest.java

Changeset: f282190e931a
Author:    lana
Date:      2013-03-14 19:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f282190e931a

Merge


Changeset: 624bcb480006
Author:    omajid
Date:      2013-03-18 10:46 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/624bcb480006

8010030: Allow configure to detect if EC implementation is present
Reviewed-by: andrew, dholmes

! makefiles/CompileNativeLibraries.gmk

Changeset: cdcd4512c6f1
Author:    katleman
Date:      2013-03-21 10:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cdcd4512c6f1

Added tag jdk8-b82 for changeset 624bcb480006

! .hgtags


From john.coomes at oracle.com  Fri Mar 22 02:46:03 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 22 Mar 2013 09:46:03 +0000
Subject: hg: hsx/hotspot-rt/langtools: 58 new changesets
Message-ID: <20130322094843.1060D48330@hg.openjdk.java.net>

Changeset: 58289451d9ed
Author:    katleman
Date:      2013-03-14 15:00 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/58289451d9ed

Added tag jdk8-b81 for changeset ed69d087fdfd

! .hgtags

Changeset: 63872da94576
Author:    darcy
Date:      2013-02-13 23:05 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/63872da94576

8001457: New tests needed for library-side changes for repeating annotations
Reviewed-by: darcy
Contributed-by: sonali.goel at oracle.com

! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java
+ test/tools/javac/annotations/repeatingAnnotations/combo/ReflectionTest.java
+ test/tools/javac/annotations/repeatingAnnotations/combo/expectedFiles/ExpectedBase.java
+ test/tools/javac/annotations/repeatingAnnotations/combo/expectedFiles/ExpectedContainer.java

Changeset: 88286a36bb34
Author:    mchung
Date:      2013-02-14 09:43 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/88286a36bb34

8006225: tools/jdeps/Basic.java failes with AssertionError
Reviewed-by: alanb

+ src/share/classes/com/sun/tools/jdeps/Analyzer.java
! src/share/classes/com/sun/tools/jdeps/Archive.java
! src/share/classes/com/sun/tools/jdeps/JdepsTask.java
! test/tools/jdeps/Basic.java

Changeset: 040f02711b73
Author:    jjg
Date:      2013-02-15 08:28 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/040f02711b73

8007052: javap should include the descriptor for a method in verbose mode
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javap/ClassWriter.java
! src/share/classes/com/sun/tools/javap/JavapTask.java
! src/share/classes/com/sun/tools/javap/Options.java
+ test/tools/javap/DescriptorTest.java

Changeset: 0baaae675b19
Author:    mcimadamore
Date:      2013-02-15 16:28 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/0baaae675b19

8006749: compiler does not allow Object protected methods to be used in lambda
Summary: Check.checkFunctionalInterface should take into account 'fake' override
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
+ test/tools/javac/lambda/LambdaConv26.java

Changeset: f6e667f52af4
Author:    mcimadamore
Date:      2013-02-15 16:28 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f6e667f52af4

8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
Summary: Missing abstractness check on super rmethod references
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
+ test/tools/javac/lambda/MethodReference62.java
+ test/tools/javac/lambda/MethodReference62.out

Changeset: 4ff468de829d
Author:    mcimadamore
Date:      2013-02-15 16:29 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4ff468de829d

8007462: Fix provisional applicability for method references
Summary: Add speculative arity-based check to rule out potential candidates when stuck reference is passed to method
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/tools/javac/diags/examples/IncompatibleArgTypesInMethodRef.java
+ test/tools/javac/lambda/TargetType60.java
+ test/tools/javac/lambda/TargetType60.out

Changeset: 3cd997b9fd84
Author:    mcimadamore
Date:      2013-02-15 16:30 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3cd997b9fd84

8007535: Compiler crashes on @FunctionalInterface used on interface with two inherited methods with same signatures
Summary: Bad check in Types.interfaceCandidates
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
+ test/tools/javac/lambda/FunctionalInterfaceAnno02.java

Changeset: 186023614cd3
Author:    mcimadamore
Date:      2013-02-15 16:31 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/186023614cd3

8007427: Annotation element as '_' gives compiler error instead of a warning
8007401: Write test to check for generation of warnings when '_' is used as an identifier
Summary: Extended identifier production not used in annotation values
Reviewed-by: jjg
Contributed-by: sonali.goel at oracle.com

! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
+ test/tools/javac/lambda/IdentifierTest.java
+ test/tools/javac/lambda/IdentifierTest.out

Changeset: 258c72fa7fa2
Author:    mcimadamore
Date:      2013-02-15 16:37 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/258c72fa7fa2

Merge


Changeset: da2f7dd53915
Author:    mcimadamore
Date:      2013-02-15 18:13 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/da2f7dd53915

8008309: TargetType60 fails because of bad golden file
Summary: bad golden file
Reviewed-by: jjg

! test/tools/javac/lambda/TargetType60.out

Changeset: 9fb4f223a90d
Author:    jjg
Date:      2013-02-15 11:26 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/9fb4f223a90d

8008313: 8007052 breaks test/tools/javap/MethodParameters.java
Reviewed-by: darcy

! test/tools/javap/MethodParameters.java

Changeset: f1f605f85850
Author:    rfield
Date:      2013-02-15 18:40 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f1f605f85850

8004969: Generate $deserializeLambda$ method
8006763: super in method reference used in anonymous class - ClassFormatError is produced
8005632: Inner classes within lambdas cause build failures
8005653: Lambdas containing inner classes referencing external type variables do not correctly parameterize the inner classes
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/util/Names.java
+ test/tools/javac/lambda/LambdaInnerTypeVarArgs.java
+ test/tools/javac/lambda/LambdaInnerTypeVarReflect.java
+ test/tools/javac/lambda/MethodReference61.java

Changeset: 2620c953e9fe
Author:    vromero
Date:      2013-02-18 14:33 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2620c953e9fe

6563143: javac should issue a warning for overriding equals without hashCode
Reviewed-by: jjg, mcimadamore

! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/share/classes/com/sun/tools/javac/code/Lint.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java
+ test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.java
+ test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.out
! test/tools/javac/diags/examples.not-yet.txt

Changeset: 87884cd0fea3
Author:    jjg
Date:      2013-02-18 14:29 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/87884cd0fea3

8008339: Test TargetAnnoCombo.java is broken
Reviewed-by: jjh

! test/tools/javac/annotations/repeatingAnnotations/combo/TargetAnnoCombo.java

Changeset: 011cf7e0a148
Author:    darcy
Date:      2013-02-19 00:31 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/011cf7e0a148

8008267: Add @Supported annotation to com.sun.source types
Reviewed-by: jjg

! src/share/classes/com/sun/source/doctree/AttributeTree.java
! src/share/classes/com/sun/source/doctree/AuthorTree.java
! src/share/classes/com/sun/source/doctree/BlockTagTree.java
! src/share/classes/com/sun/source/doctree/CommentTree.java
! src/share/classes/com/sun/source/doctree/DeprecatedTree.java
! src/share/classes/com/sun/source/doctree/DocCommentTree.java
! src/share/classes/com/sun/source/doctree/DocRootTree.java
! src/share/classes/com/sun/source/doctree/DocTree.java
! src/share/classes/com/sun/source/doctree/DocTreeVisitor.java
! src/share/classes/com/sun/source/doctree/EndElementTree.java
! src/share/classes/com/sun/source/doctree/EntityTree.java
! src/share/classes/com/sun/source/doctree/ErroneousTree.java
! src/share/classes/com/sun/source/doctree/IdentifierTree.java
! src/share/classes/com/sun/source/doctree/InheritDocTree.java
! src/share/classes/com/sun/source/doctree/InlineTagTree.java
! src/share/classes/com/sun/source/doctree/LinkTree.java
! src/share/classes/com/sun/source/doctree/LiteralTree.java
! src/share/classes/com/sun/source/doctree/ParamTree.java
! src/share/classes/com/sun/source/doctree/ReferenceTree.java
! src/share/classes/com/sun/source/doctree/ReturnTree.java
! src/share/classes/com/sun/source/doctree/SeeTree.java
! src/share/classes/com/sun/source/doctree/SerialDataTree.java
! src/share/classes/com/sun/source/doctree/SerialFieldTree.java
! src/share/classes/com/sun/source/doctree/SerialTree.java
! src/share/classes/com/sun/source/doctree/SinceTree.java
! src/share/classes/com/sun/source/doctree/StartElementTree.java
! src/share/classes/com/sun/source/doctree/TextTree.java
! src/share/classes/com/sun/source/doctree/ThrowsTree.java
! src/share/classes/com/sun/source/doctree/UnknownBlockTagTree.java
! src/share/classes/com/sun/source/doctree/UnknownInlineTagTree.java
! src/share/classes/com/sun/source/doctree/ValueTree.java
! src/share/classes/com/sun/source/doctree/VersionTree.java
! src/share/classes/com/sun/source/doctree/package-info.java
! src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java
! src/share/classes/com/sun/source/tree/AnnotationTree.java
! src/share/classes/com/sun/source/tree/ArrayAccessTree.java
! src/share/classes/com/sun/source/tree/ArrayTypeTree.java
! src/share/classes/com/sun/source/tree/AssertTree.java
! src/share/classes/com/sun/source/tree/AssignmentTree.java
! src/share/classes/com/sun/source/tree/BinaryTree.java
! src/share/classes/com/sun/source/tree/BlockTree.java
! src/share/classes/com/sun/source/tree/BreakTree.java
! src/share/classes/com/sun/source/tree/CaseTree.java
! src/share/classes/com/sun/source/tree/CatchTree.java
! src/share/classes/com/sun/source/tree/ClassTree.java
! src/share/classes/com/sun/source/tree/CompilationUnitTree.java
! src/share/classes/com/sun/source/tree/CompoundAssignmentTree.java
! src/share/classes/com/sun/source/tree/ConditionalExpressionTree.java
! src/share/classes/com/sun/source/tree/ContinueTree.java
! src/share/classes/com/sun/source/tree/DoWhileLoopTree.java
! src/share/classes/com/sun/source/tree/EmptyStatementTree.java
! src/share/classes/com/sun/source/tree/EnhancedForLoopTree.java
! src/share/classes/com/sun/source/tree/ErroneousTree.java
! src/share/classes/com/sun/source/tree/ExpressionStatementTree.java
! src/share/classes/com/sun/source/tree/ExpressionTree.java
! src/share/classes/com/sun/source/tree/ForLoopTree.java
! src/share/classes/com/sun/source/tree/IdentifierTree.java
! src/share/classes/com/sun/source/tree/IfTree.java
! src/share/classes/com/sun/source/tree/ImportTree.java
! src/share/classes/com/sun/source/tree/InstanceOfTree.java
! src/share/classes/com/sun/source/tree/IntersectionTypeTree.java
! src/share/classes/com/sun/source/tree/LabeledStatementTree.java
! src/share/classes/com/sun/source/tree/LambdaExpressionTree.java
! src/share/classes/com/sun/source/tree/LineMap.java
! src/share/classes/com/sun/source/tree/LiteralTree.java
! src/share/classes/com/sun/source/tree/MemberReferenceTree.java
! src/share/classes/com/sun/source/tree/MemberSelectTree.java
! src/share/classes/com/sun/source/tree/MethodInvocationTree.java
! src/share/classes/com/sun/source/tree/MethodTree.java
! src/share/classes/com/sun/source/tree/ModifiersTree.java
! src/share/classes/com/sun/source/tree/NewArrayTree.java
! src/share/classes/com/sun/source/tree/NewClassTree.java
! src/share/classes/com/sun/source/tree/ParameterizedTypeTree.java
! src/share/classes/com/sun/source/tree/ParenthesizedTree.java
! src/share/classes/com/sun/source/tree/PrimitiveTypeTree.java
! src/share/classes/com/sun/source/tree/ReturnTree.java
! src/share/classes/com/sun/source/tree/Scope.java
! src/share/classes/com/sun/source/tree/StatementTree.java
! src/share/classes/com/sun/source/tree/SwitchTree.java
! src/share/classes/com/sun/source/tree/SynchronizedTree.java
! src/share/classes/com/sun/source/tree/ThrowTree.java
! src/share/classes/com/sun/source/tree/Tree.java
! src/share/classes/com/sun/source/tree/TreeVisitor.java
! src/share/classes/com/sun/source/tree/TryTree.java
! src/share/classes/com/sun/source/tree/TypeCastTree.java
! src/share/classes/com/sun/source/tree/TypeParameterTree.java
! src/share/classes/com/sun/source/tree/UnaryTree.java
! src/share/classes/com/sun/source/tree/UnionTypeTree.java
! src/share/classes/com/sun/source/tree/VariableTree.java
! src/share/classes/com/sun/source/tree/WhileLoopTree.java
! src/share/classes/com/sun/source/tree/WildcardTree.java
! src/share/classes/com/sun/source/tree/package-info.java
! src/share/classes/com/sun/source/util/DocTreeScanner.java
! src/share/classes/com/sun/source/util/DocTrees.java
! src/share/classes/com/sun/source/util/JavacTask.java
! src/share/classes/com/sun/source/util/Plugin.java
! src/share/classes/com/sun/source/util/SimpleDocTreeVisitor.java
! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java
! src/share/classes/com/sun/source/util/SourcePositions.java
! src/share/classes/com/sun/source/util/TaskEvent.java
! src/share/classes/com/sun/source/util/TaskListener.java
! src/share/classes/com/sun/source/util/TreePath.java
! src/share/classes/com/sun/source/util/TreePathScanner.java
! src/share/classes/com/sun/source/util/TreeScanner.java
! src/share/classes/com/sun/source/util/Trees.java
! src/share/classes/com/sun/source/util/package-info.java
! src/share/classes/com/sun/tools/javac/Main.java
! src/share/classes/com/sun/tools/javac/Server.java

Changeset: dc8b7aa7cef3
Author:    vromero
Date:      2013-02-19 17:53 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/dc8b7aa7cef3

8006212: javac, convert jtreg tests from shell script to java
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java
! src/share/classes/com/sun/tools/javac/util/ArrayUtils.java
+ test/tools/apt/Basics/CheckAptIsRemovedTest.java
- test/tools/apt/Basics/NullAPF.java
- test/tools/apt/Basics/apt.sh
- test/tools/apt/verifyVariables.sh
+ test/tools/javac/4846262/CheckEBCDICLocaleTest.java
- test/tools/javac/4846262/Test.java
- test/tools/javac/4846262/Test.out
- test/tools/javac/4846262/Test.sh
+ test/tools/javac/6302184/HiddenOptionsShouldUseGivenEncodingTest.java
- test/tools/javac/6302184/T6302184.sh
+ test/tools/javac/ClassPathTest/ClassPathTest.java
- test/tools/javac/ClassPathTest/ClassPathTest.sh
- test/tools/javac/ClassPathTest/ClassPathTest1.java
- test/tools/javac/ClassPathTest/ClassPathTest2.java
- test/tools/javac/ClassPathTest/ClassPathTest3.java
- test/tools/javac/ClassPathTest/bar/pkg/ClassPathTestAux2.java
- test/tools/javac/ClassPathTest/foo/pkg/ClassPathTestAux1.java
- test/tools/javac/ClassPathTest/pkg/ClassPathTestAux3.java
+ test/tools/javac/ExtDirs/ExtDirTest.java
- test/tools/javac/ExtDirs/ExtDirTest_1.java
- test/tools/javac/ExtDirs/ExtDirTest_2.java
- test/tools/javac/ExtDirs/ExtDirTest_3.java
- test/tools/javac/ExtDirs/ExtDirs.sh
- test/tools/javac/MissingInclude.java
- test/tools/javac/MissingInclude.sh
+ test/tools/javac/MissingInclude/MissingIncludeTest.java
- test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh
- test/tools/javac/ProtectedInnerClass/ProtectedInnerClass_2.java
+ test/tools/javac/ProtectedInnerClass/ProtectedInnerClassesTest.java
- test/tools/javac/ProtectedInnerClass/p1/ProtectedInnerClass1.java
- test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass2.java
- test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass3.java
+ test/tools/javac/T5090006/AssertionFailureTest.java
- test/tools/javac/T5090006/T5090006.java
- test/tools/javac/T5090006/compiler.sh
- test/tools/javac/constDebug/ConstDebug.java
- test/tools/javac/constDebug/ConstDebug.sh
+ test/tools/javac/constDebug/ConstDebugTest.java
- test/tools/javac/fatalErrors/NoJavaLang.java
- test/tools/javac/fatalErrors/NoJavaLang.out
- test/tools/javac/fatalErrors/NoJavaLang.sh
+ test/tools/javac/fatalErrors/NoJavaLangTest.java
- test/tools/javac/innerClassFile/Driver.sh
+ test/tools/javac/innerClassFile/InnerClassFileTest.java
- test/tools/javac/innerClassFile/x/B.java
- test/tools/javac/innerClassFile/x/C.java
- test/tools/javac/innerClassFile/y/Main.java
- test/tools/javac/innerClassFile/y/R1.java
- test/tools/javac/innerClassFile/y/R2.java
- test/tools/javac/innerClassFile/y/R3.java
- test/tools/javac/javazip/A.java
+ test/tools/javac/javazip/JavaZipTest.java
- test/tools/javac/javazip/Test.sh
- test/tools/javac/javazip/bad/B.java
- test/tools/javac/javazip/good/B.java
+ test/tools/javac/lib/ToolBox.java
+ test/tools/javac/links/LinksTest.java
- test/tools/javac/links/T.java
- test/tools/javac/links/b/B.java
- test/tools/javac/links/links.sh
+ test/tools/javac/newlines/NewLineTest.java
- test/tools/javac/newlines/Newlines.sh
+ test/tools/javac/stackmap/StackMapTest.java
- test/tools/javac/stackmap/T4955930.java
- test/tools/javac/stackmap/T4955930.sh
! test/tools/javac/unicode/SupplementaryJavaID6.java
- test/tools/javac/unicode/SupplementaryJavaID6.sh
+ test/tools/javah/6257087/T6257087.java
- test/tools/javah/6257087/foo.java
- test/tools/javah/6257087/foo.sh
- test/tools/javah/6257087/foo_bar.h
- test/tools/javah/ConstMacroTest.sh
- test/tools/javah/MissingParamClassException.java
- test/tools/javah/MissingParamClassTest.sh
- test/tools/javah/ParamClassTest.java
- test/tools/javah/SubClassConsts.java
- test/tools/javah/SubClassConsts.out
- test/tools/javah/SubClassConsts.win
- test/tools/javah/SuperClassConsts.java
+ test/tools/javah/T4942232/MissingParamClassTest.java
+ test/tools/javah/constMacroTest/ConstMacroTest.java
+ test/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java
+ test/tools/javap/4866831/PublicInterfaceTest.java
- test/tools/javap/NotPackagePrivateInterface.java
- test/tools/javap/PublicInterfaceTest.sh
- test/tools/javap/pathsep.sh
+ test/tools/javap/stackmap/StackmapTest.java
- test/tools/javap/stackmap/T6271292.java
- test/tools/javap/stackmap/T6271292.out
- test/tools/javap/stackmap/T6271292.sh

Changeset: 9345394ac8fe
Author:    ksrini
Date:      2013-02-19 17:19 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/9345394ac8fe

8006948: Update javac for MethodParameters format change
Reviewed-by: ksrini, forax
Contributed-by: eric.mccorkle at oracle.com

! src/share/classes/com/sun/tools/classfile/ClassWriter.java
! src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java

Changeset: 4cf6e84f844f
Author:    lana
Date:      2013-02-19 20:53 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4cf6e84f844f

Merge


Changeset: 267225edc1fe
Author:    strarup
Date:      2013-02-20 15:47 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/267225edc1fe

8006582: Test for parameter names feature
Reviewed-by: jjg, darcy, emc

- test/tools/javac/MethodParameters.java
+ test/tools/javac/MethodParameters/AnnotationTest.java
+ test/tools/javac/MethodParameters/AnonymousClass.java
+ test/tools/javac/MethodParameters/AttributeVisitor.java
+ test/tools/javac/MethodParameters/ClassFileVisitor.java
+ test/tools/javac/MethodParameters/Constructors.java
+ test/tools/javac/MethodParameters/EnumTest.java
+ test/tools/javac/MethodParameters/InstanceMethods.java
+ test/tools/javac/MethodParameters/LambdaTest.java
+ test/tools/javac/MethodParameters/LocalClassTest.java
+ test/tools/javac/MethodParameters/MemberClassTest.java
+ test/tools/javac/MethodParameters/ReflectionVisitor.java
+ test/tools/javac/MethodParameters/StaticMethods.java
+ test/tools/javac/MethodParameters/Tester.java
+ test/tools/javac/MethodParameters/UncommonParamNames.java
+ test/tools/javac/MethodParametersTest.java

Changeset: d686d8a7eb78
Author:    mcimadamore
Date:      2013-02-21 15:19 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d686d8a7eb78

8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler
Summary: Disentangle cyclic dependency between static-ness of synthetic lambda method and static-ness of classes nested within lambdas
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/LambdaConv27.java

Changeset: 3a39d123d33a
Author:    mcimadamore
Date:      2013-02-21 15:21 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3a39d123d33a

8008276: assertion error in com.sun.tools.javac.comp.TransTypes.visitApply
Summary: DiagnosticFilter used during speculative attribution is too broad
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java
+ test/tools/javac/lambda/speculative/MissingError.java
+ test/tools/javac/lambda/speculative/MissingError.out

Changeset: f4fdd53f8b3e
Author:    mcimadamore
Date:      2013-02-21 15:23 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f4fdd53f8b3e

8005183: Missing accessor for constructor reference pointing to private inner class ctor
Summary: Compiler should add bridges when translating private constructor reference
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/MethodReference63.java

Changeset: 7ac9242d2ca6
Author:    mcimadamore
Date:      2013-02-21 15:25 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7ac9242d2ca6

8008293: Declared bounds not considered when functional interface containing unbound wildcards is instantiated
Summary: Wildcards inference should re-use some of the bounds info generated during capture conversion
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
+ test/tools/javac/lambda/TargetType64.java

Changeset: 9f0ec00514b6
Author:    mcimadamore
Date:      2013-02-21 15:26 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/9f0ec00514b6

8007461: Regression: bad overload resolution when inner class and outer class have method with same name
Summary: Fix regression in varargs method resolution introduced by bad refactoring
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! test/tools/javac/resolve/Pos.java
+ test/tools/javac/resolve/tests/InnerOverOuter.java

Changeset: 3fef0cae83b3
Author:    mcimadamore
Date:      2013-02-21 15:27 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3fef0cae83b3

8008444: Inherited generic functional descriptors are merged incorrectly
Summary: Missing call to Types.createMethodWithThrownTypes
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
+ test/tools/javac/lambda/LambdaConv25.java
+ test/tools/javac/lambda/LambdaConv25.out

Changeset: cd7340a84bb8
Author:    rfield
Date:      2013-02-21 14:43 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/cd7340a84bb8

8008405: Now that metafactory is in place, add javac lambda serialization tests
Summary: Tests part of original langtools serialization review.
Reviewed-by: mcimadamore

+ test/tools/javac/T8004969.java
+ test/tools/javac/lambda/LambdaInnerTypeVarArgsSerialize.java
+ test/tools/javac/lambda/LambdaInnerTypeVarSerialize.java

Changeset: dabb36173c63
Author:    ksrini
Date:      2013-02-21 12:23 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/dabb36173c63

8008658: Four new method param jtreg tests fail in nightly tests
Reviewed-by: jjg, ksrini, mcimadamore
Contributed-by: eric.mccorkle at oracle.com

! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! test/tools/javac/MethodParameters/EnumTest.java
! test/tools/javac/MethodParameters/LocalClassTest.java
! test/tools/javac/MethodParameters/MemberClassTest.java

Changeset: 6118072811e5
Author:    lana
Date:      2013-02-21 17:49 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6118072811e5

Merge

! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java
! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties

Changeset: 8e82e4f225e4
Author:    mcimadamore
Date:      2013-02-22 13:31 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8e82e4f225e4

8008337: Write test to check for compiler error when static method in interface is called via super()
Reviewed-by: mcimadamore
Contributed-by: sonali.goel at oracle.com

+ test/tools/javac/lambda/StaticMethodNegTest.java
+ test/tools/javac/lambda/StaticMethodNegTest.out

Changeset: 94e67bed460d
Author:    mcimadamore
Date:      2013-02-22 18:19 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/94e67bed460d

8008708: Regression: separate compilation causes crash in wildcards inference logic
Summary: Invalid use of WildcardType.bound in Types.removeWildcards
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
+ test/tools/javac/lambda/separate/Foo.java
+ test/tools/javac/lambda/separate/Test.java

Changeset: ccbe7ffdd867
Author:    jjg
Date:      2013-02-24 11:36 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ccbe7ffdd867

7112427: The doclet needs to be able to generate JavaFX documentation.
Reviewed-by: jjg
Contributed-by: jan.valenta at oracle.com

! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java
+ src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java
+ src/share/classes/com/sun/tools/doclets/internal/toolkit/PropertyWriter.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java
+ src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PropertyBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml
! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties
+ src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java
+ src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java
+ src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertyGetterTaglet.java
+ src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertySetterTaglet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java
+ test/com/sun/javadoc/testJavaFX/C.java
+ test/com/sun/javadoc/testJavaFX/D.java
+ test/com/sun/javadoc/testJavaFX/TestJavaFX.java
! test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java

Changeset: bd49e0304281
Author:    vromero
Date:      2013-02-26 09:04 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bd49e0304281

8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
Reviewed-by: jjg, mcimadamore

! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.java
! test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.out

Changeset: 133a0a0c2cbc
Author:    mcimadamore
Date:      2013-02-28 14:00 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/133a0a0c2cbc

8008723: Graph Inference: bad graph calculation leads to assertion error
Summary: Dependencies are not propagated correctly through merged nodes during inference graph initialization
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Infer.java
+ test/tools/javac/lambda/TargetType65.java

Changeset: 332f23993353
Author:    mcimadamore
Date:      2013-02-28 14:05 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/332f23993353

8008813: Structural most specific fails when method reference is passed to overloaded method
Summary: Bad logic for checking most specific method reference type
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Resolve.java
+ test/tools/javac/lambda/MostSpecific08.java

Changeset: 08782b8b03ce
Author:    mcimadamore
Date:      2013-02-28 14:05 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/08782b8b03ce

8008537: Missing method reference lookup error when unbound search finds a static method
Summary: Static-ness check should be applied after member reference resolution
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java
+ test/tools/javac/diags/examples/StaticMethodInUnboundLookup.java
! test/tools/javac/lambda/MethodReference22.java
! test/tools/javac/lambda/MethodReference22.out
! test/tools/javac/lambda/MethodReference28.out
! test/tools/javac/lambda/MethodReference51.out
! test/tools/javac/lambda/TargetType60.java
! test/tools/javac/lambda/TargetType60.out

Changeset: 6f988040a1c8
Author:    jjg
Date:      2013-03-01 10:47 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6f988040a1c8

8008949: javadoc stopped copying doc-files
Reviewed-by: bpatel

! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java
+ test/com/sun/javadoc/testDocFiles/TestDocFiles.java
+ test/com/sun/javadoc/testDocFiles/pkg/Test.java
+ test/com/sun/javadoc/testDocFiles/pkg/doc-files/test.txt

Changeset: 69cd2bfd4a31
Author:    mcimadamore
Date:      2013-03-05 14:04 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/69cd2bfd4a31

8004962: Code generation crash with lambda and local classes
Summary: Translation info should be propagated from LambdaToMethod to Lower
Reviewed-by: jjg, rfield

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
+ test/tools/javac/lambda/LambdaCapture07.java

Changeset: d2a98dde7ecc
Author:    mcimadamore
Date:      2013-03-05 14:12 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d2a98dde7ecc

8009227: Certain diagnostics should not be deferred
Summary: Add new diagnostic flag to mark non deferrable diagnostics
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java
! src/share/classes/com/sun/tools/javac/util/Log.java
+ test/tools/javac/lambda/abort/CompletionFailure.java

Changeset: a708c5f1da06
Author:    mcimadamore
Date:      2013-03-05 14:16 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a708c5f1da06

8009154: Missing cast in method reference bridge leads to NoSuchMethodError
Summary: Missing cast in generated method reference bridge
Reviewed-by: rfield, jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/MethodReference65.java

Changeset: 12202e6ab78a
Author:    mcimadamore
Date:      2013-03-05 14:19 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/12202e6ab78a

8009129: Illegal access error when calling method reference
Summary: Javac generates method handle referencing non public type
Reviewed-by: jjg, rfield

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
+ test/tools/javac/diags/examples/NotDefPublicCantAccessFragment/NotDefPublicCantAccessFragment.java
+ test/tools/javac/diags/examples/NotDefPublicCantAccessFragment/p/C.java
+ test/tools/javac/lambda/inaccessibleMref01/InaccessibleMref01.java
+ test/tools/javac/lambda/inaccessibleMref01/InaccessibleMref01.out
+ test/tools/javac/lambda/inaccessibleMref01/p1/C.java
+ test/tools/javac/lambda/inaccessibleMref02/InaccessibleMref02.java
+ test/tools/javac/lambda/inaccessibleMref02/p1/C.java

Changeset: 188a07a0a7a0
Author:    lana
Date:      2013-03-05 11:51 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/188a07a0a7a0

Merge


Changeset: d0178bd8125c
Author:    mcimadamore
Date:      2013-03-06 15:29 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d0178bd8125c

8009299: Javac crashes when compiling method reference to static interface method
Summary: Assertion in Check.checMethod is too strict
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/jvm/Pool.java
+ test/tools/javac/lambda/MethodReference66.java

Changeset: 8a78243291ef
Author:    mcimadamore
Date:      2013-03-06 15:33 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8a78243291ef

8009459: Wrong behavior of diamond finder with source level 7
Summary: Diamond finder doesn't take into account different inference behaviors
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
+ test/tools/javac/generics/diamond/6939780/T6939780.java
+ test/tools/javac/generics/diamond/6939780/T6939780_7.out
+ test/tools/javac/generics/diamond/6939780/T6939780_8.out
- test/tools/javac/generics/diamond/T6939780.java
- test/tools/javac/generics/diamond/T6939780.out

Changeset: c98b3e96c726
Author:    mcimadamore
Date:      2013-03-06 15:33 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c98b3e96c726

8009391: Synthetic name of serializable lambda methods should not contain negative numbers
Summary: Use hex representation of method signature hashcode to avoid negative numbers
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

Changeset: 3806171b52d8
Author:    vromero
Date:      2013-03-07 10:04 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3806171b52d8

8009138: javac, equals-hashCode warning tuning
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/tools/javac/6563143/EqualsHashCodeWarningTest.java
+ test/tools/javac/6563143/EqualsHashCodeWarningTest.out
- test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.java
- test/tools/javac/6563143/OverridesEqualsButNotHashCodeTest.out

Changeset: 823fb9229724
Author:    vromero
Date:      2013-03-07 10:12 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/823fb9229724

8009170: Regression: javac generates redundant bytecode in assignop involving arrays
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Lower.java
! test/tools/javac/7167125/DiffResultAfterSameOperationInnerClasses.java
+ test/tools/javac/8009170/RedundantByteCodeInArrayTest.java

Changeset: a02c3ddc182b
Author:    rfield
Date:      2013-03-07 08:26 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a02c3ddc182b

8009582: Method reference generic constructor gives: IllegalArgumentException: Invalid lambda deserialization
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/GenericMethodRefImplClass.java

Changeset: c61add6bf8ac
Author:    vromero
Date:      2013-03-11 15:35 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c61add6bf8ac

6181889: Empty try/finally results in bytecodes being generated
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/Lower.java
+ test/tools/javac/T6181889/EmptyFinallyTest.java

Changeset: d0ae21e3a382
Author:    rfield
Date:      2013-03-11 10:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d0ae21e3a382

8009742: Bad lambda name for lambda in a static initializer or ctor
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/SerializedLambdaInInit.java

Changeset: fbb6e470079d
Author:    ohrstrom
Date:      2013-03-11 19:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/fbb6e470079d

8009843: sjavac should accept -cp as synonym for -classpath
Reviewed-by: jjg

! src/share/classes/com/sun/tools/sjavac/Main.java

Changeset: 7fe9b9d29095
Author:    jfranck
Date:      2013-03-12 11:16 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7fe9b9d29095

8005205: tests missing bugid for repeating annotation change
Reviewed-by: jjg, ssides

! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.java
! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java

Changeset: 6db9a3b1a93f
Author:    mcimadamore
Date:      2013-03-12 16:02 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6db9a3b1a93f

8008540: Constructor reference to non-reifiable array should be rejected
8008539: Spurious error when constructor reference mention an interface type
8008538: Constructor reference accepts wildcard parameterized types
Summary: Overhaul of Check.checkConstructorRefType
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Check.java
! test/tools/javac/lambda/MethodReference38.out
+ test/tools/javac/lambda/MethodReference64.java
+ test/tools/javac/lambda/MethodReference64.out

Changeset: 5ddecb91d843
Author:    mcimadamore
Date:      2013-03-12 16:02 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/5ddecb91d843

8009545: Graph inference: dependencies between inference variables should be set during incorporation
Summary: Move all transitivity checks into the incorporation round
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! test/tools/javac/lambda/TargetType28.out

Changeset: f427043f8c65
Author:    jfranck
Date:      2013-03-12 17:39 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f427043f8c65

7196531: Duplicate error messages on repeating annotations
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Annotate.java
+ test/tools/javac/annotations/repeatingAnnotations/DuplicateErrors.java
+ test/tools/javac/annotations/repeatingAnnotations/DuplicateErrors.out
! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out
! test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out
! test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.out

Changeset: 39f8eb897ec6
Author:    lana
Date:      2013-03-12 16:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/39f8eb897ec6

Merge

- test/tools/apt/Basics/NullAPF.java
- test/tools/apt/Basics/apt.sh
- test/tools/apt/verifyVariables.sh
- test/tools/javac/4846262/Test.java
- test/tools/javac/4846262/Test.out
- test/tools/javac/4846262/Test.sh
- test/tools/javac/6302184/T6302184.sh
- test/tools/javac/ClassPathTest/ClassPathTest.sh
- test/tools/javac/ClassPathTest/ClassPathTest1.java
- test/tools/javac/ClassPathTest/ClassPathTest2.java
- test/tools/javac/ClassPathTest/ClassPathTest3.java
- test/tools/javac/ClassPathTest/bar/pkg/ClassPathTestAux2.java
- test/tools/javac/ClassPathTest/foo/pkg/ClassPathTestAux1.java
- test/tools/javac/ClassPathTest/pkg/ClassPathTestAux3.java
- test/tools/javac/ExtDirs/ExtDirTest_1.java
- test/tools/javac/ExtDirs/ExtDirTest_2.java
- test/tools/javac/ExtDirs/ExtDirTest_3.java
- test/tools/javac/ExtDirs/ExtDirs.sh
- test/tools/javac/MethodParameters.java
- test/tools/javac/MissingInclude.java
- test/tools/javac/MissingInclude.sh
- test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh
- test/tools/javac/ProtectedInnerClass/ProtectedInnerClass_2.java
- test/tools/javac/ProtectedInnerClass/p1/ProtectedInnerClass1.java
- test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass2.java
- test/tools/javac/ProtectedInnerClass/p2/ProtectedInnerClass3.java
- test/tools/javac/T5090006/T5090006.java
- test/tools/javac/T5090006/compiler.sh
- test/tools/javac/constDebug/ConstDebug.java
- test/tools/javac/constDebug/ConstDebug.sh
- test/tools/javac/fatalErrors/NoJavaLang.java
- test/tools/javac/fatalErrors/NoJavaLang.out
- test/tools/javac/fatalErrors/NoJavaLang.sh
- test/tools/javac/generics/diamond/T6939780.java
- test/tools/javac/generics/diamond/T6939780.out
- test/tools/javac/innerClassFile/Driver.sh
- test/tools/javac/innerClassFile/x/B.java
- test/tools/javac/innerClassFile/x/C.java
- test/tools/javac/innerClassFile/y/Main.java
- test/tools/javac/innerClassFile/y/R1.java
- test/tools/javac/innerClassFile/y/R2.java
- test/tools/javac/innerClassFile/y/R3.java
- test/tools/javac/javazip/A.java
- test/tools/javac/javazip/Test.sh
- test/tools/javac/javazip/bad/B.java
- test/tools/javac/javazip/good/B.java
- test/tools/javac/links/T.java
- test/tools/javac/links/b/B.java
- test/tools/javac/links/links.sh
- test/tools/javac/newlines/Newlines.sh
- test/tools/javac/stackmap/T4955930.java
- test/tools/javac/stackmap/T4955930.sh
- test/tools/javac/unicode/SupplementaryJavaID6.sh
- test/tools/javah/6257087/foo.java
- test/tools/javah/6257087/foo.sh
- test/tools/javah/6257087/foo_bar.h
- test/tools/javah/ConstMacroTest.sh
- test/tools/javah/MissingParamClassException.java
- test/tools/javah/MissingParamClassTest.sh
- test/tools/javah/ParamClassTest.java
- test/tools/javah/SubClassConsts.java
- test/tools/javah/SubClassConsts.out
- test/tools/javah/SubClassConsts.win
- test/tools/javah/SuperClassConsts.java
- test/tools/javap/NotPackagePrivateInterface.java
- test/tools/javap/PublicInterfaceTest.sh
- test/tools/javap/pathsep.sh
- test/tools/javap/stackmap/T6271292.java
- test/tools/javap/stackmap/T6271292.out
- test/tools/javap/stackmap/T6271292.sh

Changeset: 825da6847791
Author:    lana
Date:      2013-03-14 19:33 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/825da6847791

Merge


Changeset: 22ba3f92d4ae
Author:    katleman
Date:      2013-03-21 10:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/22ba3f92d4ae

Added tag jdk8-b82 for changeset 825da6847791

! .hgtags


From john.coomes at oracle.com  Fri Mar 22 02:48:59 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 22 Mar 2013 09:48:59 +0000
Subject: hg: hsx/hotspot-rt/nashorn: 134 new changesets
Message-ID: <20130322095017.301F448331@hg.openjdk.java.net>

Changeset: b8a1b238c77c
Author:    duke
Date:      2007-12-01 00:00 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b8a1b238c77c

Initial load

+ .hgignore
+ .jcheck/conf

Changeset: 6031a0bc0ae2
Author:    jcoomes
Date:      2012-12-20 14:16 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6031a0bc0ae2

8005364: initial hg tags for nashorn repo
Reviewed-by: amurillo

+ .hgtags

Changeset: da1e581c933b
Author:    jlaskey
Date:      2012-12-21 16:36 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/da1e581c933b

8005403: Open-source Nashorn
Reviewed-by: attila, hannesw, lagergren, sundar
Contributed-by: james.laskey at oracle.com, akhil.arora at oracle.com, andreas.woess at jku.at, attila.szegedi at oracle.com, hannes.wallnoefer at oracle.com, henry.jen at oracle.com, marcus.lagergren at oracle.com, pavel.semenov at oracle.com, pavel.stepanov at oracle.com, petr.hejl at oracle.com, petr.pisl at oracle.com, sundararajan.athijegannathan at oracle.com

! .hgignore
+ ASSEMBLY_EXCEPTION
+ LICENSE
+ README
+ RELEASE_README
+ THIRD_PARTY_README
+ bin/checkintest.sh
+ bin/fixorphantests.sh
+ bin/fixwhitespace.sh
+ bin/jjs
+ bin/jjs.bat
+ bin/jjssecure
+ bin/jjssecure.bat
+ bin/nashorn
+ bin/nashorn.bat
+ bin/rm-non-tracked.sh
+ bin/verbose_octane.bat
+ bin/verbose_octane.sh
+ buildtools/nasgen/README
+ buildtools/nasgen/build.xml
+ buildtools/nasgen/nasgen.iml
+ buildtools/nasgen/project.properties
+ buildtools/nasgen/src/META-INF/MANIFEST.MF
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/Main.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MemberInfo.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/NullVisitor.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfo.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfoCollector.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java
+ buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java
+ docs/DEVELOPER_README
+ docs/genshelldoc.js
+ make/Makefile
+ make/build-benchmark.xml
+ make/build-nasgen.xml
+ make/build.xml
+ make/nbproject/ide-file-targets.xml
+ make/nbproject/ide-targets.xml
+ make/nbproject/jdk.xml
+ make/nbproject/nbjdk.properties
+ make/nbproject/nbjdk.xml
+ make/nbproject/project.xml
+ make/project.properties
+ samples/counters.js
+ samples/letter.js
+ samples/parser.js
+ samples/shell.js
+ samples/test.js
+ samples/uniq.js
+ src/META-INF/MANIFEST.MF
+ src/META-INF/services/javax.script.ScriptEngineFactory
+ src/jdk/nashorn/api/scripting/NashornException.java
+ src/jdk/nashorn/api/scripting/NashornScriptEngine.java
+ src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java
+ src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
+ src/jdk/nashorn/api/scripting/package-info.java
+ src/jdk/nashorn/api/scripting/resources/engine.js
+ src/jdk/nashorn/internal/codegen/AccessSpecializer.java
+ src/jdk/nashorn/internal/codegen/BranchOptimizer.java
+ src/jdk/nashorn/internal/codegen/ClassEmitter.java
+ src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ src/jdk/nashorn/internal/codegen/CompileUnit.java
+ src/jdk/nashorn/internal/codegen/Compiler.java
+ src/jdk/nashorn/internal/codegen/CompilerConstants.java
+ src/jdk/nashorn/internal/codegen/ConstantData.java
+ src/jdk/nashorn/internal/codegen/Emitter.java
+ src/jdk/nashorn/internal/codegen/Frame.java
+ src/jdk/nashorn/internal/codegen/FunctionSignature.java
+ src/jdk/nashorn/internal/codegen/Lower.java
+ src/jdk/nashorn/internal/codegen/MethodEmitter.java
+ src/jdk/nashorn/internal/codegen/Namespace.java
+ src/jdk/nashorn/internal/codegen/RuntimeCallSite.java
+ src/jdk/nashorn/internal/codegen/SharedScopeCall.java
+ src/jdk/nashorn/internal/codegen/Splitter.java
+ src/jdk/nashorn/internal/codegen/Transform.java
+ src/jdk/nashorn/internal/codegen/WeighNodes.java
+ src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java
+ src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java
+ src/jdk/nashorn/internal/codegen/objects/MapCreator.java
+ src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java
+ src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java
+ src/jdk/nashorn/internal/codegen/objects/ObjectMapCreator.java
+ src/jdk/nashorn/internal/codegen/types/ArrayType.java
+ src/jdk/nashorn/internal/codegen/types/BitwiseType.java
+ src/jdk/nashorn/internal/codegen/types/BooleanType.java
+ src/jdk/nashorn/internal/codegen/types/BytecodeArrayOps.java
+ src/jdk/nashorn/internal/codegen/types/BytecodeBitwiseOps.java
+ src/jdk/nashorn/internal/codegen/types/BytecodeNumericOps.java
+ src/jdk/nashorn/internal/codegen/types/BytecodeOps.java
+ src/jdk/nashorn/internal/codegen/types/IntType.java
+ src/jdk/nashorn/internal/codegen/types/LongType.java
+ src/jdk/nashorn/internal/codegen/types/NumberType.java
+ src/jdk/nashorn/internal/codegen/types/NumericType.java
+ src/jdk/nashorn/internal/codegen/types/ObjectType.java
+ src/jdk/nashorn/internal/codegen/types/Type.java
+ src/jdk/nashorn/internal/ir/AccessNode.java
+ src/jdk/nashorn/internal/ir/Assignment.java
+ src/jdk/nashorn/internal/ir/BaseNode.java
+ src/jdk/nashorn/internal/ir/BinaryNode.java
+ src/jdk/nashorn/internal/ir/Block.java
+ src/jdk/nashorn/internal/ir/BreakNode.java
+ src/jdk/nashorn/internal/ir/BreakableNode.java
+ src/jdk/nashorn/internal/ir/CallNode.java
+ src/jdk/nashorn/internal/ir/CaseNode.java
+ src/jdk/nashorn/internal/ir/CatchNode.java
+ src/jdk/nashorn/internal/ir/ContinueNode.java
+ src/jdk/nashorn/internal/ir/DoWhileNode.java
+ src/jdk/nashorn/internal/ir/EmptyNode.java
+ src/jdk/nashorn/internal/ir/ExecuteNode.java
+ src/jdk/nashorn/internal/ir/ForNode.java
+ src/jdk/nashorn/internal/ir/FunctionCall.java
+ src/jdk/nashorn/internal/ir/FunctionNode.java
+ src/jdk/nashorn/internal/ir/IdentNode.java
+ src/jdk/nashorn/internal/ir/IfNode.java
+ src/jdk/nashorn/internal/ir/IndexNode.java
+ src/jdk/nashorn/internal/ir/LabelNode.java
+ src/jdk/nashorn/internal/ir/LabeledNode.java
+ src/jdk/nashorn/internal/ir/LineNumberNode.java
+ src/jdk/nashorn/internal/ir/LiteralNode.java
+ src/jdk/nashorn/internal/ir/Location.java
+ src/jdk/nashorn/internal/ir/Node.java
+ src/jdk/nashorn/internal/ir/ObjectNode.java
+ src/jdk/nashorn/internal/ir/PropertyKey.java
+ src/jdk/nashorn/internal/ir/PropertyNode.java
+ src/jdk/nashorn/internal/ir/ReferenceNode.java
+ src/jdk/nashorn/internal/ir/ReturnNode.java
+ src/jdk/nashorn/internal/ir/RuntimeNode.java
+ src/jdk/nashorn/internal/ir/SplitNode.java
+ src/jdk/nashorn/internal/ir/SwitchNode.java
+ src/jdk/nashorn/internal/ir/Symbol.java
+ src/jdk/nashorn/internal/ir/TernaryNode.java
+ src/jdk/nashorn/internal/ir/ThrowNode.java
+ src/jdk/nashorn/internal/ir/TryNode.java
+ src/jdk/nashorn/internal/ir/TypeOverride.java
+ src/jdk/nashorn/internal/ir/UnaryNode.java
+ src/jdk/nashorn/internal/ir/VarNode.java
+ src/jdk/nashorn/internal/ir/WhileNode.java
+ src/jdk/nashorn/internal/ir/WithNode.java
+ src/jdk/nashorn/internal/ir/annotations/ChildNode.java
+ src/jdk/nashorn/internal/ir/annotations/Ignore.java
+ src/jdk/nashorn/internal/ir/annotations/ParentNode.java
+ src/jdk/nashorn/internal/ir/annotations/Reference.java
+ src/jdk/nashorn/internal/ir/debug/ASTWriter.java
+ src/jdk/nashorn/internal/ir/debug/JSONWriter.java
+ src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
+ src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
+ src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
+ src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java
+ src/jdk/nashorn/internal/objects/ArrayBufferView.java
+ src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java
+ src/jdk/nashorn/internal/objects/DateParser.java
+ src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java
+ src/jdk/nashorn/internal/objects/Global.java
+ src/jdk/nashorn/internal/objects/NativeArguments.java
+ src/jdk/nashorn/internal/objects/NativeArray.java
+ src/jdk/nashorn/internal/objects/NativeArrayBuffer.java
+ src/jdk/nashorn/internal/objects/NativeBoolean.java
+ src/jdk/nashorn/internal/objects/NativeDate.java
+ src/jdk/nashorn/internal/objects/NativeDebug.java
+ src/jdk/nashorn/internal/objects/NativeError.java
+ src/jdk/nashorn/internal/objects/NativeEvalError.java
+ src/jdk/nashorn/internal/objects/NativeFloat32Array.java
+ src/jdk/nashorn/internal/objects/NativeFloat64Array.java
+ src/jdk/nashorn/internal/objects/NativeFunction.java
+ src/jdk/nashorn/internal/objects/NativeInt16Array.java
+ src/jdk/nashorn/internal/objects/NativeInt32Array.java
+ src/jdk/nashorn/internal/objects/NativeInt8Array.java
+ src/jdk/nashorn/internal/objects/NativeJSAdapter.java
+ src/jdk/nashorn/internal/objects/NativeJSON.java
+ src/jdk/nashorn/internal/objects/NativeJava.java
+ src/jdk/nashorn/internal/objects/NativeJavaImporter.java
+ src/jdk/nashorn/internal/objects/NativeMath.java
+ src/jdk/nashorn/internal/objects/NativeNumber.java
+ src/jdk/nashorn/internal/objects/NativeObject.java
+ src/jdk/nashorn/internal/objects/NativeRangeError.java
+ src/jdk/nashorn/internal/objects/NativeReferenceError.java
+ src/jdk/nashorn/internal/objects/NativeRegExp.java
+ src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java
+ src/jdk/nashorn/internal/objects/NativeStrictArguments.java
+ src/jdk/nashorn/internal/objects/NativeString.java
+ src/jdk/nashorn/internal/objects/NativeSyntaxError.java
+ src/jdk/nashorn/internal/objects/NativeTypeError.java
+ src/jdk/nashorn/internal/objects/NativeURIError.java
+ src/jdk/nashorn/internal/objects/NativeUint16Array.java
+ src/jdk/nashorn/internal/objects/NativeUint32Array.java
+ src/jdk/nashorn/internal/objects/NativeUint8Array.java
+ src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java
+ src/jdk/nashorn/internal/objects/PrototypeObject.java
+ src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ src/jdk/nashorn/internal/objects/annotations/Attribute.java
+ src/jdk/nashorn/internal/objects/annotations/Constructor.java
+ src/jdk/nashorn/internal/objects/annotations/Function.java
+ src/jdk/nashorn/internal/objects/annotations/Getter.java
+ src/jdk/nashorn/internal/objects/annotations/Property.java
+ src/jdk/nashorn/internal/objects/annotations/ScriptClass.java
+ src/jdk/nashorn/internal/objects/annotations/Setter.java
+ src/jdk/nashorn/internal/objects/annotations/SpecializedConstructor.java
+ src/jdk/nashorn/internal/objects/annotations/SpecializedFunction.java
+ src/jdk/nashorn/internal/objects/annotations/Where.java
+ src/jdk/nashorn/internal/objects/package-info.java
+ src/jdk/nashorn/internal/parser/AbstractParser.java
+ src/jdk/nashorn/internal/parser/JSONParser.java
+ src/jdk/nashorn/internal/parser/Lexer.java
+ src/jdk/nashorn/internal/parser/Parser.java
+ src/jdk/nashorn/internal/parser/RegExp.java
+ src/jdk/nashorn/internal/parser/RegExpScanner.java
+ src/jdk/nashorn/internal/parser/Scanner.java
+ src/jdk/nashorn/internal/parser/Token.java
+ src/jdk/nashorn/internal/parser/TokenKind.java
+ src/jdk/nashorn/internal/parser/TokenLookup.java
+ src/jdk/nashorn/internal/parser/TokenStream.java
+ src/jdk/nashorn/internal/parser/TokenType.java
+ src/jdk/nashorn/internal/runtime/AccessorProperty.java
+ src/jdk/nashorn/internal/runtime/BitVector.java
+ src/jdk/nashorn/internal/runtime/CodeInstaller.java
+ src/jdk/nashorn/internal/runtime/ConsString.java
+ src/jdk/nashorn/internal/runtime/Context.java
+ src/jdk/nashorn/internal/runtime/Debug.java
+ src/jdk/nashorn/internal/runtime/DebugLogger.java
+ src/jdk/nashorn/internal/runtime/DefaultPropertyAccess.java
+ src/jdk/nashorn/internal/runtime/ECMAErrors.java
+ src/jdk/nashorn/internal/runtime/ECMAException.java
+ src/jdk/nashorn/internal/runtime/ErrorManager.java
+ src/jdk/nashorn/internal/runtime/FindProperty.java
+ src/jdk/nashorn/internal/runtime/FunctionScope.java
+ src/jdk/nashorn/internal/runtime/GlobalFunctions.java
+ src/jdk/nashorn/internal/runtime/GlobalObject.java
+ src/jdk/nashorn/internal/runtime/JSErrorType.java
+ src/jdk/nashorn/internal/runtime/JSType.java
+ src/jdk/nashorn/internal/runtime/Logging.java
+ src/jdk/nashorn/internal/runtime/NashornLoader.java
+ src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
+ src/jdk/nashorn/internal/runtime/NumberToString.java
+ src/jdk/nashorn/internal/runtime/ParserException.java
+ src/jdk/nashorn/internal/runtime/Property.java
+ src/jdk/nashorn/internal/runtime/PropertyAccess.java
+ src/jdk/nashorn/internal/runtime/PropertyDescriptor.java
+ src/jdk/nashorn/internal/runtime/PropertyHashMap.java
+ src/jdk/nashorn/internal/runtime/PropertyListener.java
+ src/jdk/nashorn/internal/runtime/PropertyListenerManager.java
+ src/jdk/nashorn/internal/runtime/PropertyMap.java
+ src/jdk/nashorn/internal/runtime/QuotedStringTokenizer.java
+ src/jdk/nashorn/internal/runtime/RegExpMatch.java
+ src/jdk/nashorn/internal/runtime/Scope.java
+ src/jdk/nashorn/internal/runtime/ScriptFunction.java
+ src/jdk/nashorn/internal/runtime/ScriptLoader.java
+ src/jdk/nashorn/internal/runtime/ScriptObject.java
+ src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
+ src/jdk/nashorn/internal/runtime/Source.java
+ src/jdk/nashorn/internal/runtime/SpillProperty.java
+ src/jdk/nashorn/internal/runtime/StructureLoader.java
+ src/jdk/nashorn/internal/runtime/URIUtils.java
+ src/jdk/nashorn/internal/runtime/Undefined.java
+ src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
+ src/jdk/nashorn/internal/runtime/Version.java
+ src/jdk/nashorn/internal/runtime/WithObject.java
+ src/jdk/nashorn/internal/runtime/arrays/ArrayData.java
+ src/jdk/nashorn/internal/runtime/arrays/ArrayFilter.java
+ src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java
+ src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java
+ src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java
+ src/jdk/nashorn/internal/runtime/arrays/EmptyArrayLikeIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java
+ src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java
+ src/jdk/nashorn/internal/runtime/arrays/InvalidArrayIndexException.java
+ src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java
+ src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java
+ src/jdk/nashorn/internal/runtime/arrays/MapIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/NoTypeArrayData.java
+ src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java
+ src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java
+ src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java
+ src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java
+ src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
+ src/jdk/nashorn/internal/runtime/arrays/UndefinedArrayFilter.java
+ src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
+ src/jdk/nashorn/internal/runtime/linker/InvokeByName.java
+ src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java
+ src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
+ src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
+ src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
+ src/jdk/nashorn/internal/runtime/linker/Lookup.java
+ src/jdk/nashorn/internal/runtime/linker/Mangler.java
+ src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java
+ src/jdk/nashorn/internal/runtime/linker/MethodHandleFunctionality.java
+ src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
+ src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java
+ src/jdk/nashorn/internal/runtime/linker/NashornGuardedInvocation.java
+ src/jdk/nashorn/internal/runtime/linker/NashornGuards.java
+ src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
+ src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java
+ src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
+ src/jdk/nashorn/internal/runtime/options/KeyValueOption.java
+ src/jdk/nashorn/internal/runtime/options/Option.java
+ src/jdk/nashorn/internal/runtime/options/OptionTemplate.java
+ src/jdk/nashorn/internal/runtime/options/Options.java
+ src/jdk/nashorn/internal/runtime/options/ValueOption.java
+ src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ src/jdk/nashorn/internal/runtime/resources/Options.properties
+ src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ src/jdk/nashorn/internal/runtime/resources/parser.js
+ src/jdk/nashorn/internal/runtime/resources/version.properties-template
+ src/jdk/nashorn/internal/scripts/JO$.java
+ src/jdk/nashorn/internal/scripts/JS$.java
+ src/jdk/nashorn/tools/Shell.java
+ src/jdk/nashorn/tools/resources/Shell.properties
+ src/jdk/nashorn/tools/resources/shell.js
+ src/netscape/javascript/JSObject.java
+ src/overview.html
+ test/README
+ test/examples/dual-fields-micro.js
+ test/examples/innerbench.js
+ test/examples/typechain.js
+ test/lib/benchmark.js
+ test/opt/add.js
+ test/opt/add_constant.js
+ test/opt/add_reuse_callsite.js
+ test/opt/add_revert2.js
+ test/opt/cascade_specialize.js
+ test/script/assert.js
+ test/script/basic/NASHORN-100.js
+ test/script/basic/NASHORN-100.js.EXPECTED
+ test/script/basic/NASHORN-101.js
+ test/script/basic/NASHORN-101.js.EXPECTED
+ test/script/basic/NASHORN-102.js
+ test/script/basic/NASHORN-102.js.EXPECTED
+ test/script/basic/NASHORN-103.js
+ test/script/basic/NASHORN-104.js
+ test/script/basic/NASHORN-104.js.EXPECTED
+ test/script/basic/NASHORN-105.js
+ test/script/basic/NASHORN-105.js.EXPECTED
+ test/script/basic/NASHORN-106.js
+ test/script/basic/NASHORN-106.js.EXPECTED
+ test/script/basic/NASHORN-107.js
+ test/script/basic/NASHORN-108.js
+ test/script/basic/NASHORN-108.js.EXPECTED
+ test/script/basic/NASHORN-109.js
+ test/script/basic/NASHORN-109.js.EXPECTED
+ test/script/basic/NASHORN-11.js
+ test/script/basic/NASHORN-11.js.EXPECTED
+ test/script/basic/NASHORN-111.js
+ test/script/basic/NASHORN-111.js.EXPECTED
+ test/script/basic/NASHORN-113.js
+ test/script/basic/NASHORN-113.js.EXPECTED
+ test/script/basic/NASHORN-114.js
+ test/script/basic/NASHORN-115.js
+ test/script/basic/NASHORN-115.js.EXPECTED
+ test/script/basic/NASHORN-117.js
+ test/script/basic/NASHORN-118.js
+ test/script/basic/NASHORN-118.js.EXPECTED
+ test/script/basic/NASHORN-119.js
+ test/script/basic/NASHORN-119.js.EXPECTED
+ test/script/basic/NASHORN-12.js
+ test/script/basic/NASHORN-120.js
+ test/script/basic/NASHORN-122.js
+ test/script/basic/NASHORN-122.js.EXPECTED
+ test/script/basic/NASHORN-126.js
+ test/script/basic/NASHORN-126.js.EXPECTED
+ test/script/basic/NASHORN-127.js
+ test/script/basic/NASHORN-127.js.EXPECTED
+ test/script/basic/NASHORN-130.js
+ test/script/basic/NASHORN-132.js
+ test/script/basic/NASHORN-132.js.EXPECTED
+ test/script/basic/NASHORN-133.js
+ test/script/basic/NASHORN-133.js.EXPECTED
+ test/script/basic/NASHORN-135.js
+ test/script/basic/NASHORN-136.js
+ test/script/basic/NASHORN-136.js.EXPECTED
+ test/script/basic/NASHORN-14.js
+ test/script/basic/NASHORN-14.js.EXPECTED
+ test/script/basic/NASHORN-148.js
+ test/script/basic/NASHORN-148.js.EXPECTED
+ test/script/basic/NASHORN-15.js
+ test/script/basic/NASHORN-15.js.EXPECTED
+ test/script/basic/NASHORN-153.js
+ test/script/basic/NASHORN-156.js
+ test/script/basic/NASHORN-157.js
+ test/script/basic/NASHORN-163.js
+ test/script/basic/NASHORN-163.js.EXPECTED
+ test/script/basic/NASHORN-164.js
+ test/script/basic/NASHORN-165.js
+ test/script/basic/NASHORN-166.js
+ test/script/basic/NASHORN-168.js
+ test/script/basic/NASHORN-168.js.EXPECTED
+ test/script/basic/NASHORN-169.js
+ test/script/basic/NASHORN-172.js
+ test/script/basic/NASHORN-173.js
+ test/script/basic/NASHORN-173.js.EXPECTED
+ test/script/basic/NASHORN-174.js
+ test/script/basic/NASHORN-175.js
+ test/script/basic/NASHORN-176.js
+ test/script/basic/NASHORN-177.js
+ test/script/basic/NASHORN-177.js.EXPECTED
+ test/script/basic/NASHORN-178.js
+ test/script/basic/NASHORN-178.js.EXPECTED
+ test/script/basic/NASHORN-179.js
+ test/script/basic/NASHORN-18.js
+ test/script/basic/NASHORN-18.js.EXPECTED
+ test/script/basic/NASHORN-181.js
+ test/script/basic/NASHORN-182.js
+ test/script/basic/NASHORN-183.js
+ test/script/basic/NASHORN-184.js
+ test/script/basic/NASHORN-184.js.EXPECTED
+ test/script/basic/NASHORN-185.js
+ test/script/basic/NASHORN-185.js.EXPECTED
+ test/script/basic/NASHORN-187.js
+ test/script/basic/NASHORN-188.js
+ test/script/basic/NASHORN-188.js.EXPECTED
+ test/script/basic/NASHORN-19.js
+ test/script/basic/NASHORN-19.js.EXPECTED
+ test/script/basic/NASHORN-190.js
+ test/script/basic/NASHORN-192.js
+ test/script/basic/NASHORN-194.js
+ test/script/basic/NASHORN-196.js
+ test/script/basic/NASHORN-198.js
+ test/script/basic/NASHORN-20.js
+ test/script/basic/NASHORN-20.js.EXPECTED
+ test/script/basic/NASHORN-201.js
+ test/script/basic/NASHORN-202.js
+ test/script/basic/NASHORN-203.js
+ test/script/basic/NASHORN-204.js
+ test/script/basic/NASHORN-205.js
+ test/script/basic/NASHORN-206.js
+ test/script/basic/NASHORN-207.js
+ test/script/basic/NASHORN-207_2.js
+ test/script/basic/NASHORN-208.js
+ test/script/basic/NASHORN-208.js.EXPECTED
+ test/script/basic/NASHORN-209.js
+ test/script/basic/NASHORN-209.js.EXPECTED
+ test/script/basic/NASHORN-21.js
+ test/script/basic/NASHORN-21.js.EXPECTED
+ test/script/basic/NASHORN-211.js
+ test/script/basic/NASHORN-212.js
+ test/script/basic/NASHORN-213.js
+ test/script/basic/NASHORN-215.js
+ test/script/basic/NASHORN-215.js.EXPECTED
+ test/script/basic/NASHORN-216.js
+ test/script/basic/NASHORN-217.js
+ test/script/basic/NASHORN-217.js.EXPECTED
+ test/script/basic/NASHORN-219.js
+ test/script/basic/NASHORN-219.js.EXPECTED
+ test/script/basic/NASHORN-22.js
+ test/script/basic/NASHORN-22.js.EXPECTED
+ test/script/basic/NASHORN-221.js
+ test/script/basic/NASHORN-222.js
+ test/script/basic/NASHORN-223.js
+ test/script/basic/NASHORN-225.js
+ test/script/basic/NASHORN-226.js
+ test/script/basic/NASHORN-227.js
+ test/script/basic/NASHORN-228.js
+ test/script/basic/NASHORN-229.js
+ test/script/basic/NASHORN-229_subtest.js
+ test/script/basic/NASHORN-23.js
+ test/script/basic/NASHORN-23.js.EXPECTED
+ test/script/basic/NASHORN-232.js
+ test/script/basic/NASHORN-234.js
+ test/script/basic/NASHORN-235.js
+ test/script/basic/NASHORN-236.js
+ test/script/basic/NASHORN-237.js
+ test/script/basic/NASHORN-239.js
+ test/script/basic/NASHORN-24.js
+ test/script/basic/NASHORN-24.js.EXPECTED
+ test/script/basic/NASHORN-241.js
+ test/script/basic/NASHORN-242.js
+ test/script/basic/NASHORN-245.js
+ test/script/basic/NASHORN-247.js
+ test/script/basic/NASHORN-25.js
+ test/script/basic/NASHORN-25.js.EXPECTED
+ test/script/basic/NASHORN-251.js
+ test/script/basic/NASHORN-252.js
+ test/script/basic/NASHORN-253.js
+ test/script/basic/NASHORN-256.js
+ test/script/basic/NASHORN-258.js
+ test/script/basic/NASHORN-258.js.EXPECTED
+ test/script/basic/NASHORN-26.js
+ test/script/basic/NASHORN-26.js.EXPECTED
+ test/script/basic/NASHORN-260.js
+ test/script/basic/NASHORN-261.js
+ test/script/basic/NASHORN-262.js
+ test/script/basic/NASHORN-263.js
+ test/script/basic/NASHORN-264.js
+ test/script/basic/NASHORN-265.js
+ test/script/basic/NASHORN-265.js.EXPECTED
+ test/script/basic/NASHORN-266.js
+ test/script/basic/NASHORN-269.js
+ test/script/basic/NASHORN-27.js
+ test/script/basic/NASHORN-27.js.EXPECTED
+ test/script/basic/NASHORN-270.js
+ test/script/basic/NASHORN-271.js
+ test/script/basic/NASHORN-275.js
+ test/script/basic/NASHORN-276.js
+ test/script/basic/NASHORN-277.js
+ test/script/basic/NASHORN-278.js
+ test/script/basic/NASHORN-28.js
+ test/script/basic/NASHORN-28.js.EXPECTED
+ test/script/basic/NASHORN-281.js
+ test/script/basic/NASHORN-284.js
+ test/script/basic/NASHORN-284.js.EXPECTED
+ test/script/basic/NASHORN-285.js
+ test/script/basic/NASHORN-285.js.EXPECTED
+ test/script/basic/NASHORN-288.js
+ test/script/basic/NASHORN-29.js
+ test/script/basic/NASHORN-29.js.EXPECTED
+ test/script/basic/NASHORN-293.js
+ test/script/basic/NASHORN-293.js.EXPECTED
+ test/script/basic/NASHORN-294.js
+ test/script/basic/NASHORN-296.js
+ test/script/basic/NASHORN-297.js
+ test/script/basic/NASHORN-30.js
+ test/script/basic/NASHORN-30.js.EXPECTED
+ test/script/basic/NASHORN-300.js
+ test/script/basic/NASHORN-301.js
+ test/script/basic/NASHORN-301.js.EXPECTED
+ test/script/basic/NASHORN-304.js
+ test/script/basic/NASHORN-310.js
+ test/script/basic/NASHORN-310.js.EXPECTED
+ test/script/basic/NASHORN-318.js
+ test/script/basic/NASHORN-318.js.EXPECTED
+ test/script/basic/NASHORN-32.js
+ test/script/basic/NASHORN-32.js.EXPECTED
+ test/script/basic/NASHORN-321.js
+ test/script/basic/NASHORN-321.js.EXPECTED
+ test/script/basic/NASHORN-323.js
+ test/script/basic/NASHORN-323.js.EXPECTED
+ test/script/basic/NASHORN-324.js
+ test/script/basic/NASHORN-33.js
+ test/script/basic/NASHORN-33.js.EXPECTED
+ test/script/basic/NASHORN-331.js
+ test/script/basic/NASHORN-331.js.EXPECTED
+ test/script/basic/NASHORN-337.js
+ test/script/basic/NASHORN-337.js.EXPECTED
+ test/script/basic/NASHORN-34.js
+ test/script/basic/NASHORN-34.js.EXPECTED
+ test/script/basic/NASHORN-340.js
+ test/script/basic/NASHORN-340.js.EXPECTED
+ test/script/basic/NASHORN-349.js
+ test/script/basic/NASHORN-354.js
+ test/script/basic/NASHORN-354.js.EXPECTED
+ test/script/basic/NASHORN-355.js
+ test/script/basic/NASHORN-355.js.EXPECTED
+ test/script/basic/NASHORN-36.js
+ test/script/basic/NASHORN-36.js.EXPECTED
+ test/script/basic/NASHORN-365.js
+ test/script/basic/NASHORN-366.js
+ test/script/basic/NASHORN-366.js.EXPECTED
+ test/script/basic/NASHORN-368.js
+ test/script/basic/NASHORN-368.js.EXPECTED
+ test/script/basic/NASHORN-37.js
+ test/script/basic/NASHORN-37.js.EXPECTED
+ test/script/basic/NASHORN-375.js
+ test/script/basic/NASHORN-376.js
+ test/script/basic/NASHORN-377.js
+ test/script/basic/NASHORN-377.js.EXPECTED
+ test/script/basic/NASHORN-378.js
+ test/script/basic/NASHORN-38.js
+ test/script/basic/NASHORN-38.js.EXPECTED
+ test/script/basic/NASHORN-380.js
+ test/script/basic/NASHORN-380.js.EXPECTED
+ test/script/basic/NASHORN-381.js
+ test/script/basic/NASHORN-382.js
+ test/script/basic/NASHORN-383.js
+ test/script/basic/NASHORN-384.js
+ test/script/basic/NASHORN-384.js.EXPECTED
+ test/script/basic/NASHORN-385.js
+ test/script/basic/NASHORN-385.js.EXPECTED
+ test/script/basic/NASHORN-389.js
+ test/script/basic/NASHORN-389.js.EXPECTED
+ test/script/basic/NASHORN-393.js
+ test/script/basic/NASHORN-393.js.EXPECTED
+ test/script/basic/NASHORN-394.js
+ test/script/basic/NASHORN-394.js.EXPECTED
+ test/script/basic/NASHORN-396.js
+ test/script/basic/NASHORN-397.js
+ test/script/basic/NASHORN-398.js
+ test/script/basic/NASHORN-40.js
+ test/script/basic/NASHORN-40.js.EXPECTED
+ test/script/basic/NASHORN-400.js
+ test/script/basic/NASHORN-400.js.EXPECTED
+ test/script/basic/NASHORN-401.js
+ test/script/basic/NASHORN-401.js.EXPECTED
+ test/script/basic/NASHORN-402.js
+ test/script/basic/NASHORN-402.js.EXPECTED
+ test/script/basic/NASHORN-404.js
+ test/script/basic/NASHORN-405.js
+ test/script/basic/NASHORN-405.js.EXPECTED
+ test/script/basic/NASHORN-406.js
+ test/script/basic/NASHORN-408.js
+ test/script/basic/NASHORN-408.js.EXPECTED
+ test/script/basic/NASHORN-415.js
+ test/script/basic/NASHORN-415.js.EXPECTED
+ test/script/basic/NASHORN-416.js
+ test/script/basic/NASHORN-417.js
+ test/script/basic/NASHORN-418.js
+ test/script/basic/NASHORN-420.js
+ test/script/basic/NASHORN-421.js
+ test/script/basic/NASHORN-423.js
+ test/script/basic/NASHORN-423.js.EXPECTED
+ test/script/basic/NASHORN-423a.js
+ test/script/basic/NASHORN-424.js
+ test/script/basic/NASHORN-424.js.EXPECTED
+ test/script/basic/NASHORN-425.js
+ test/script/basic/NASHORN-425.js.EXPECTED
+ test/script/basic/NASHORN-426.js
+ test/script/basic/NASHORN-427.js
+ test/script/basic/NASHORN-428.js
+ test/script/basic/NASHORN-429.js
+ test/script/basic/NASHORN-432.js
+ test/script/basic/NASHORN-433.js
+ test/script/basic/NASHORN-434.js
+ test/script/basic/NASHORN-435.js
+ test/script/basic/NASHORN-437.js
+ test/script/basic/NASHORN-44.js
+ test/script/basic/NASHORN-44.js.EXPECTED
+ test/script/basic/NASHORN-441.js
+ test/script/basic/NASHORN-441.js.EXPECTED
+ test/script/basic/NASHORN-442.js
+ test/script/basic/NASHORN-443.js
+ test/script/basic/NASHORN-444.js
+ test/script/basic/NASHORN-444.js.EXPECTED
+ test/script/basic/NASHORN-445.js
+ test/script/basic/NASHORN-446.js
+ test/script/basic/NASHORN-447.js
+ test/script/basic/NASHORN-448.js
+ test/script/basic/NASHORN-449.js
+ test/script/basic/NASHORN-449.js.EXPECTED
+ test/script/basic/NASHORN-45.js
+ test/script/basic/NASHORN-45.js.EXPECTED
+ test/script/basic/NASHORN-450.js
+ test/script/basic/NASHORN-452.js
+ test/script/basic/NASHORN-459.js
+ test/script/basic/NASHORN-46.js
+ test/script/basic/NASHORN-46.js.EXPECTED
+ test/script/basic/NASHORN-462.js
+ test/script/basic/NASHORN-463.js
+ test/script/basic/NASHORN-468.js
+ test/script/basic/NASHORN-47.js
+ test/script/basic/NASHORN-473.js
+ test/script/basic/NASHORN-473.js.EXPECTED
+ test/script/basic/NASHORN-474.js
+ test/script/basic/NASHORN-474.js.EXPECTED
+ test/script/basic/NASHORN-478.js
+ test/script/basic/NASHORN-48.js
+ test/script/basic/NASHORN-48.js.EXPECTED
+ test/script/basic/NASHORN-481.js
+ test/script/basic/NASHORN-481.js.EXPECTED
+ test/script/basic/NASHORN-482.js
+ test/script/basic/NASHORN-484.js
+ test/script/basic/NASHORN-484.js.EXPECTED
+ test/script/basic/NASHORN-486.js
+ test/script/basic/NASHORN-487.js
+ test/script/basic/NASHORN-488.js
+ test/script/basic/NASHORN-49.js
+ test/script/basic/NASHORN-49.js.EXPECTED
+ test/script/basic/NASHORN-490.js
+ test/script/basic/NASHORN-494.js
+ test/script/basic/NASHORN-497.js
+ test/script/basic/NASHORN-498.js
+ test/script/basic/NASHORN-499.js
+ test/script/basic/NASHORN-50.js
+ test/script/basic/NASHORN-50.js.EXPECTED
+ test/script/basic/NASHORN-500.js
+ test/script/basic/NASHORN-503.js
+ test/script/basic/NASHORN-503.js.EXPECTED
+ test/script/basic/NASHORN-51.js
+ test/script/basic/NASHORN-51.js.EXPECTED
+ test/script/basic/NASHORN-511.js
+ test/script/basic/NASHORN-515.js
+ test/script/basic/NASHORN-515.js.EXPECTED
+ test/script/basic/NASHORN-516.js
+ test/script/basic/NASHORN-52.js
+ test/script/basic/NASHORN-534.js
+ test/script/basic/NASHORN-534.js.EXPECTED
+ test/script/basic/NASHORN-535.js
+ test/script/basic/NASHORN-535.js.EXPECTED
+ test/script/basic/NASHORN-544.js
+ test/script/basic/NASHORN-55.js
+ test/script/basic/NASHORN-554.js
+ test/script/basic/NASHORN-554.js.EXPECTED
+ test/script/basic/NASHORN-556.js
+ test/script/basic/NASHORN-556.js.EXPECTED
+ test/script/basic/NASHORN-56.js
+ test/script/basic/NASHORN-56.js.EXPECTED
+ test/script/basic/NASHORN-562.js
+ test/script/basic/NASHORN-565.js
+ test/script/basic/NASHORN-565.js.EXPECTED
+ test/script/basic/NASHORN-575.js
+ test/script/basic/NASHORN-575.js.EXPECTED
+ test/script/basic/NASHORN-58.js
+ test/script/basic/NASHORN-58.js.EXPECTED
+ test/script/basic/NASHORN-59.js
+ test/script/basic/NASHORN-59.js.EXPECTED
+ test/script/basic/NASHORN-592.js
+ test/script/basic/NASHORN-592.js.EXPECTED
+ test/script/basic/NASHORN-597.js
+ test/script/basic/NASHORN-597.js.EXPECTED
+ test/script/basic/NASHORN-60.js
+ test/script/basic/NASHORN-60.js.EXPECTED
+ test/script/basic/NASHORN-609.js
+ test/script/basic/NASHORN-609.js.EXPECTED
+ test/script/basic/NASHORN-61.js
+ test/script/basic/NASHORN-61.js.EXPECTED
+ test/script/basic/NASHORN-62.js
+ test/script/basic/NASHORN-62.js.EXPECTED
+ test/script/basic/NASHORN-620.js
+ test/script/basic/NASHORN-620.js.EXPECTED
+ test/script/basic/NASHORN-623.js
+ test/script/basic/NASHORN-623.js.EXPECTED
+ test/script/basic/NASHORN-627.js
+ test/script/basic/NASHORN-627.js.EXPECTED
+ test/script/basic/NASHORN-63.js
+ test/script/basic/NASHORN-631.js.EXPECTED
+ test/script/basic/NASHORN-637.js
+ test/script/basic/NASHORN-637.js.EXPECTED
+ test/script/basic/NASHORN-638.js
+ test/script/basic/NASHORN-638.js.EXPECTED
+ test/script/basic/NASHORN-639.js
+ test/script/basic/NASHORN-64.js
+ test/script/basic/NASHORN-642.js
+ test/script/basic/NASHORN-642.js.EXPECTED
+ test/script/basic/NASHORN-646.js
+ test/script/basic/NASHORN-653.js
+ test/script/basic/NASHORN-658.js
+ test/script/basic/NASHORN-659.js
+ test/script/basic/NASHORN-66.js
+ test/script/basic/NASHORN-66.js.EXPECTED
+ test/script/basic/NASHORN-664.js
+ test/script/basic/NASHORN-665.js
+ test/script/basic/NASHORN-67.js
+ test/script/basic/NASHORN-67.js.EXPECTED
+ test/script/basic/NASHORN-678.js
+ test/script/basic/NASHORN-68.js
+ test/script/basic/NASHORN-68.js.EXPECTED
+ test/script/basic/NASHORN-689.js
+ test/script/basic/NASHORN-689.js.EXPECTED
+ test/script/basic/NASHORN-69.js
+ test/script/basic/NASHORN-69.js.EXPECTED
+ test/script/basic/NASHORN-691.js
+ test/script/basic/NASHORN-691.js.EXPECTED
+ test/script/basic/NASHORN-694.js
+ test/script/basic/NASHORN-694.js.EXPECTED
+ test/script/basic/NASHORN-697.js
+ test/script/basic/NASHORN-703.js
+ test/script/basic/NASHORN-703.js.EXPECTED
+ test/script/basic/NASHORN-703a.js
+ test/script/basic/NASHORN-703a.js.EXPECTED
+ test/script/basic/NASHORN-705.js
+ test/script/basic/NASHORN-71.js
+ test/script/basic/NASHORN-71.js.EXPECTED
+ test/script/basic/NASHORN-710.js
+ test/script/basic/NASHORN-711.js
+ test/script/basic/NASHORN-711.js.EXPECTED
+ test/script/basic/NASHORN-72.js
+ test/script/basic/NASHORN-72.js.EXPECTED
+ test/script/basic/NASHORN-722.js
+ test/script/basic/NASHORN-73.js
+ test/script/basic/NASHORN-73.js.EXPECTED
+ test/script/basic/NASHORN-737.js
+ test/script/basic/NASHORN-737.js.EXPECTED
+ test/script/basic/NASHORN-74.js
+ test/script/basic/NASHORN-74.js.EXPECTED
+ test/script/basic/NASHORN-740.js
+ test/script/basic/NASHORN-740.js.EXPECTED
+ test/script/basic/NASHORN-75.js
+ test/script/basic/NASHORN-75.js.EXPECTED
+ test/script/basic/NASHORN-758.js
+ test/script/basic/NASHORN-759.js
+ test/script/basic/NASHORN-759.js.EXPECTED
+ test/script/basic/NASHORN-760.js
+ test/script/basic/NASHORN-768.js
+ test/script/basic/NASHORN-778.js
+ test/script/basic/NASHORN-78.js
+ test/script/basic/NASHORN-79.js
+ test/script/basic/NASHORN-79.js.EXPECTED
+ test/script/basic/NASHORN-792.js
+ test/script/basic/NASHORN-792.js.EXPECTED
+ test/script/basic/NASHORN-80.js
+ test/script/basic/NASHORN-80.js.EXPECTED
+ test/script/basic/NASHORN-81.js
+ test/script/basic/NASHORN-833.js
+ test/script/basic/NASHORN-833.js.EXPECTED
+ test/script/basic/NASHORN-85.js
+ test/script/basic/NASHORN-85.js.EXPECTED
+ test/script/basic/NASHORN-86.js
+ test/script/basic/NASHORN-87.js
+ test/script/basic/NASHORN-89.js
+ test/script/basic/NASHORN-90.js
+ test/script/basic/NASHORN-90.js.EXPECTED
+ test/script/basic/NASHORN-91.js
+ test/script/basic/NASHORN-91.js.EXPECTED
+ test/script/basic/NASHORN-92.js
+ test/script/basic/NASHORN-92.js.EXPECTED
+ test/script/basic/NASHORN-93.js
+ test/script/basic/NASHORN-95.js
+ test/script/basic/NASHORN-95.js.EXPECTED
+ test/script/basic/NASHORN-96.js
+ test/script/basic/NASHORN-96.js.EXPECTED
+ test/script/basic/NASHORN-97.js
+ test/script/basic/NASHORN-98.js
+ test/script/basic/NASHORN-98.js.EXPECTED
+ test/script/basic/NASHORN-99.js
+ test/script/basic/addition.js
+ test/script/basic/addition.js.EXPECTED
+ test/script/basic/allgettersetters.js
+ test/script/basic/andor.js
+ test/script/basic/andor.js.EXPECTED
+ test/script/basic/anonrecur.js
+ test/script/basic/anonrecur.js.EXPECTED
+ test/script/basic/applycall.js
+ test/script/basic/applycall.js.EXPECTED
+ test/script/basic/args.js
+ test/script/basic/args.js.EXPECTED
+ test/script/basic/arity.js
+ test/script/basic/arity.js.EXPECTED
+ test/script/basic/arrayprotoclass.js
+ test/script/basic/arrayprotoclass.js.EXPECTED
+ test/script/basic/arrays.js
+ test/script/basic/arrays.js.EXPECTED
+ test/script/basic/arrays2.js
+ test/script/basic/arrays2.js.EXPECTED
+ test/script/basic/arraysIntKey.js
+ test/script/basic/arraysIntKey.js.EXPECTED
+ test/script/basic/arrayset.js
+ test/script/basic/arrayset.js.EXPECTED
+ test/script/basic/arrayundefined.js
+ test/script/basic/arrayundefined.js.EXPECTED
+ test/script/basic/assign.js
+ test/script/basic/assign.js.EXPECTED
+ test/script/basic/bitwise_and.js
+ test/script/basic/bitwise_and.js.EXPECTED
+ test/script/basic/booleangetter.js
+ test/script/basic/booleangetter.js.EXPECTED
+ test/script/basic/builtin.js
+ test/script/basic/builtin.js.EXPECTED
+ test/script/basic/builtin_assign.js
+ test/script/basic/builtin_assign.js.EXPECTED
+ test/script/basic/builtinchain.js
+ test/script/basic/builtinchain.js.EXPECTED
+ test/script/basic/calllink.js
+ test/script/basic/calllink.js.EXPECTED
+ test/script/basic/closure.js
+ test/script/basic/closure.js.EXPECTED
+ test/script/basic/commandargs.js
+ test/script/basic/commandargs.js.EXPECTED
+ test/script/basic/compile-octane.js
+ test/script/basic/compile-octane.js.EXPECTED
+ test/script/basic/condassign.js
+ test/script/basic/condassign.js.EXPECTED
+ test/script/basic/construct.js
+ test/script/basic/construct.js.EXPECTED
+ test/script/basic/constructorname.js
+ test/script/basic/constructorname.js.EXPECTED
+ test/script/basic/date.js
+ test/script/basic/date.js.EXPECTED
+ test/script/basic/dateparse.js
+ test/script/basic/dateparse.js.EXPECTED
+ test/script/basic/decinc.js
+ test/script/basic/decinc.js.EXPECTED
+ test/script/basic/delete.js
+ test/script/basic/delete.js.EXPECTED
+ test/script/basic/delete2.js
+ test/script/basic/delete2.js.EXPECTED
+ test/script/basic/dotpropname.js
+ test/script/basic/dotpropname.js.EXPECTED
+ test/script/basic/doublecache.js
+ test/script/basic/doublecache.js.EXPECTED
+ test/script/basic/enumeration.js
+ test/script/basic/enumeration.js.EXPECTED
+ test/script/basic/errors.js
+ test/script/basic/errors.js.EXPECTED
+ test/script/basic/errorstack.js
+ test/script/basic/errorstack.js.EXPECTED
+ test/script/basic/eval.js
+ test/script/basic/eval.js.EXPECTED
+ test/script/basic/evalreturn.js
+ test/script/basic/evalreturn.js.EXPECTED
+ test/script/basic/exprclosure.js
+ test/script/basic/exprclosure.js.EXPECTED
+ test/script/basic/extensibility.js
+ test/script/basic/extensibility.js.EXPECTED
+ test/script/basic/fileline.js
+ test/script/basic/fileline.js.EXPECTED
+ test/script/basic/finally-catchalls.js
+ test/script/basic/finally-catchalls.js.EXPECTED
+ test/script/basic/finallyreturn.js
+ test/script/basic/finallyreturn.js.EXPECTED
+ test/script/basic/forin.js
+ test/script/basic/forin.js.EXPECTED
+ test/script/basic/forin2.js
+ test/script/basic/forin2.js.EXPECTED
+ test/script/basic/funcarray.js
+ test/script/basic/funcarray.js.EXPECTED
+ test/script/basic/funcbind.js
+ test/script/basic/funcbind.js.EXPECTED
+ test/script/basic/funcconstructor.js
+ test/script/basic/funcconstructor.js.EXPECTED
+ test/script/basic/getclassname.js
+ test/script/basic/getenv.js
+ test/script/basic/getenv.js.EXPECTED
+ test/script/basic/getter_callsite.js
+ test/script/basic/getter_callsite.js.EXPECTED
+ test/script/basic/gettercalls.js
+ test/script/basic/gettercalls.js.EXPECTED
+ test/script/basic/getterfunc.js
+ test/script/basic/getterfunc.js.EXPECTED
+ test/script/basic/gettersetter.js
+ test/script/basic/gettersetter.js.EXPECTED
+ test/script/basic/globalaccess.js
+ test/script/basic/globalaccess.js.EXPECTED
+ test/script/basic/globals.js
+ test/script/basic/globals.js.EXPECTED
+ test/script/basic/globalscope.js
+ test/script/basic/globalscope.js.EXPECTED
+ test/script/basic/hello.js
+ test/script/basic/hello.js.EXPECTED
+ test/script/basic/herestr_operator.js
+ test/script/basic/herestr_operator.js.EXPECTED
+ test/script/basic/illegaljavaname.js
+ test/script/basic/illegaljavaname.js.EXPECTED
+ test/script/basic/incheck.js
+ test/script/basic/incheck.js.EXPECTED
+ test/script/basic/indexedcall.js
+ test/script/basic/indexedcall.js.EXPECTED
+ test/script/basic/info.js
+ test/script/basic/info.js.EXPECTED
+ test/script/basic/inherited_nonwritable.js
+ test/script/basic/instanceof.js
+ test/script/basic/instanceof.js.EXPECTED
+ test/script/basic/instanceof2.js
+ test/script/basic/instanceof2.js.EXPECTED
+ test/script/basic/interfaces.js
+ test/script/basic/interfaces.js.EXPECTED
+ test/script/basic/iterator.js
+ test/script/basic/iterator.js.EXPECTED
+ test/script/basic/java.js
+ test/script/basic/java.js.EXPECTED
+ test/script/basic/javaarray.js
+ test/script/basic/javaarray.js.EXPECTED
+ test/script/basic/javaarrayconversion.js
+ test/script/basic/javaarrayconversion.js.EXPECTED
+ test/script/basic/javaexceptions.js
+ test/script/basic/javaexceptions.js.EXPECTED
+ test/script/basic/javaimporter.js
+ test/script/basic/javaimporter.js.EXPECTED
+ test/script/basic/javainnerclasses.js
+ test/script/basic/javainnerclasses.js.EXPECTED
+ test/script/basic/javasigcall.js
+ test/script/basic/javasigcall.js.EXPECTED
+ test/script/basic/jquery.js
+ test/script/basic/jquery.js.EXPECTED
+ test/script/basic/jsadapter.js
+ test/script/basic/jsadapter.js.EXPECTED
+ test/script/basic/jsadapterlink.js
+ test/script/basic/jsadapterlink.js.EXPECTED
+ test/script/basic/json.js
+ test/script/basic/json.js.EXPECTED
+ test/script/basic/list.js
+ test/script/basic/list.js.EXPECTED
+ test/script/basic/literal.js
+ test/script/basic/literal.js.EXPECTED
+ test/script/basic/load.js
+ test/script/basic/load.js.EXPECTED
+ test/script/basic/loadedfile.js
+ test/script/basic/localundef.js
+ test/script/basic/localundef.js.EXPECTED
+ test/script/basic/map.js
+ test/script/basic/map.js.EXPECTED
+ test/script/basic/math.js
+ test/script/basic/math.js.EXPECTED
+ test/script/basic/minuszero.js
+ test/script/basic/minuszero.js.EXPECTED
+ test/script/basic/module.js
+ test/script/basic/moduleload.js
+ test/script/basic/moduleload.js.EXPECTED
+ test/script/basic/nashorn2.js
+ test/script/basic/nashorn2.js.EXPECTED
+ test/script/basic/natives.js
+ test/script/basic/natives.js.EXPECTED
+ test/script/basic/new.js
+ test/script/basic/new.js.EXPECTED
+ test/script/basic/newexpr.js
+ test/script/basic/newexpr.js.EXPECTED
+ test/script/basic/newnew.js
+ test/script/basic/newnew.js.EXPECTED
+ test/script/basic/nonconstructors.js
+ test/script/basic/nonconstructors.js.EXPECTED
+ test/script/basic/nosuchmethod.js
+ test/script/basic/nosuchmethod.js.EXPECTED
+ test/script/basic/nosuchproperty.js
+ test/script/basic/nosuchproperty.js.EXPECTED
+ test/script/basic/number.js
+ test/script/basic/number.js.EXPECTED
+ test/script/basic/numberstring.js
+ test/script/basic/numberstring.js.EXPECTED
+ test/script/basic/objectprops.js
+ test/script/basic/objectprops.js.EXPECTED
+ test/script/basic/objects.js
+ test/script/basic/objects.js.EXPECTED
+ test/script/basic/options.js
+ test/script/basic/options.js.EXPECTED
+ test/script/basic/propchange.js
+ test/script/basic/propchange.js.EXPECTED
+ test/script/basic/propertycheck.js
+ test/script/basic/propertycheck.js.EXPECTED
+ test/script/basic/proto.js.EXPECTED
+ test/script/basic/prototype.js
+ test/script/basic/prototype.js.EXPECTED
+ test/script/basic/pushpull.js
+ test/script/basic/pushpull.js.EXPECTED
+ test/script/basic/regex.js
+ test/script/basic/regex.js.EXPECTED
+ test/script/basic/regexp_flags.js
+ test/script/basic/run-octane.js
+ test/script/basic/runsunspider.js
+ test/script/basic/runsunspider.js.EXPECTED
+ test/script/basic/samfunc.js
+ test/script/basic/samfunc.js.EXPECTED
+ test/script/basic/scripting.js
+ test/script/basic/scripting.js.EXPECTED
+ test/script/basic/sealfreeze.js
+ test/script/basic/sealfreeze.js.EXPECTED
+ test/script/basic/setlength.js
+ test/script/basic/setlength.js.EXPECTED
+ test/script/basic/stdin.js
+ test/script/basic/stdin.js.EXPECTED
+ test/script/basic/strings.js
+ test/script/basic/strings.js.EXPECTED
+ test/script/basic/throws.js
+ test/script/basic/throws.js.EXPECTED
+ test/script/basic/tosource.js
+ test/script/basic/tosource.js.EXPECTED
+ test/script/basic/tostring.js
+ test/script/basic/tostring.js.EXPECTED
+ test/script/basic/try.js
+ test/script/basic/try.js.EXPECTED
+ test/script/basic/trybreakcont.js
+ test/script/basic/trybreakcont.js.EXPECTED
+ test/script/basic/trycatch.js
+ test/script/basic/trycatch.js.EXPECTED
+ test/script/basic/trycatchfor.js
+ test/script/basic/trycatchfor.js.EXPECTED
+ test/script/basic/tryfinallyreturn.js
+ test/script/basic/tryfinallyreturn.js.EXPECTED
+ test/script/basic/tryforbreak.js
+ test/script/basic/tryforbreak.js.EXPECTED
+ test/script/basic/typechange.js
+ test/script/basic/typechange.js.EXPECTED
+ test/script/basic/typeof.js
+ test/script/basic/typeof.js.EXPECTED
+ test/script/basic/typeof2.js
+ test/script/basic/typeof2.js.EXPECTED
+ test/script/basic/undefined.js
+ test/script/basic/undefined.js.EXPECTED
+ test/script/basic/underscore.js
+ test/script/basic/underscore.js.EXPECTED
+ test/script/basic/varargs.js
+ test/script/basic/varargs.js.EXPECTED
+ test/script/basic/void.js
+ test/script/basic/void.js.EXPECTED
+ test/script/basic/with.js
+ test/script/basic/with.js.EXPECTED
+ test/script/basic/withprimitive.js
+ test/script/basic/withprimitive.js.EXPECTED
+ test/script/basic/writable_relink.js
+ test/script/basic/writable_relink.js.EXPECTED
+ test/script/basic/xmlStrings.js.EXPECTED
+ test/script/basic/xorassign.js
+ test/script/basic/xorassign.js.EXPECTED
+ test/script/basic/yui.js
+ test/script/basic/yui.js.EXPECTED
+ test/script/error/NASHORN-154/README
+ test/script/error/NASHORN-154/function_mult_params_in_strict.js
+ test/script/error/NASHORN-154/function_mult_params_in_strict.js.EXPECTED
+ test/script/error/NASHORN-154/improper_return_break_continue.js
+ test/script/error/NASHORN-154/improper_return_break_continue.js.EXPECTED
+ test/script/error/NASHORN-154/invalid_lvalue.js
+ test/script/error/NASHORN-154/invalid_lvalue.js.EXPECTED
+ test/script/error/NASHORN-154/literal_data_and_accessor.js
+ test/script/error/NASHORN-154/literal_data_and_accessor.js.EXPECTED
+ test/script/error/NASHORN-154/literal_mult_getters.js
+ test/script/error/NASHORN-154/literal_mult_getters.js.EXPECTED
+ test/script/error/NASHORN-154/literal_mult_prop_in_strict.js
+ test/script/error/NASHORN-154/literal_mult_prop_in_strict.js.EXPECTED
+ test/script/error/NASHORN-154/with_in_strict.js
+ test/script/error/NASHORN-154/with_in_strict.js.EXPECTED
+ test/script/error/NASHORN-214.js
+ test/script/error/NASHORN-214.js.EXPECTED
+ test/script/error/NASHORN-35.js
+ test/script/error/NASHORN-35.js.EXPECTED
+ test/script/error/NASHORN-39.js
+ test/script/error/NASHORN-39.js.EXPECTED
+ test/script/error/NASHORN-568.js
+ test/script/error/NASHORN-568.js.EXPECTED
+ test/script/error/NASHORN-57.js
+ test/script/error/NASHORN-57.js.EXPECTED
+ test/script/error/NASHORN-668.js
+ test/script/error/NASHORN-668.js.EXPECTED
+ test/script/error/quotemissing.js
+ test/script/error/quotemissing.js.EXPECTED
+ test/script/error/strictmode.js
+ test/script/error/strictmode.js.EXPECTED
+ test/script/representations/NASHORN-592a.js
+ test/script/sandbox/NASHORN-525.js
+ test/script/sandbox/README
+ test/script/sandbox/classloader.js
+ test/script/sandbox/classloader.js.EXPECTED
+ test/script/sandbox/doprivileged.js
+ test/script/sandbox/doprivileged.js.EXPECTED
+ test/script/sandbox/exit.js
+ test/script/sandbox/exit.js.EXPECTED
+ test/script/sandbox/file.js
+ test/script/sandbox/file.js.EXPECTED
+ test/script/sandbox/javaextend.js
+ test/script/sandbox/javaextend.js.EXPECTED
+ test/script/sandbox/loadLibrary.js
+ test/script/sandbox/net.js
+ test/script/sandbox/net.js.EXPECTED
+ test/script/sandbox/property.js
+ test/script/sandbox/property.js.EXPECTED
+ test/script/sandbox/reflection.js
+ test/script/sandbox/reflection.js.EXPECTED
+ test/script/sandbox/runnable.js
+ test/script/sandbox/runnable.js.EXPECTED
+ test/script/sandbox/unsafe.js
+ test/script/sandbox/unsafe.js.EXPECTED
+ test/script/test262.js
+ test/script/test262_single.js
+ test/src/UnnamedPackageTestCallback.java
+ test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java
+ test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java
+ test/src/jdk/nashorn/api/scripting/Window.java
+ test/src/jdk/nashorn/api/scripting/WindowEventHandler.java
+ test/src/jdk/nashorn/internal/access/BooleanAccessTest.java
+ test/src/jdk/nashorn/internal/access/MethodAccessTest.java
+ test/src/jdk/nashorn/internal/access/NumberAccessTest.java
+ test/src/jdk/nashorn/internal/access/NumberBoxingTest.java
+ test/src/jdk/nashorn/internal/access/ObjectAccessTest.java
+ test/src/jdk/nashorn/internal/access/Person.java
+ test/src/jdk/nashorn/internal/access/SharedObject.java
+ test/src/jdk/nashorn/internal/access/StringAccessTest.java
+ test/src/jdk/nashorn/internal/codegen/CompilerTest.java
+ test/src/jdk/nashorn/internal/parser/ParserTest.java
+ test/src/jdk/nashorn/internal/performance/AuroraWrapper.java
+ test/src/jdk/nashorn/internal/performance/OctaneTest.java
+ test/src/jdk/nashorn/internal/performance/PerformanceWrapper.java
+ test/src/jdk/nashorn/internal/performance/SplayTest.java
+ test/src/jdk/nashorn/internal/runtime/ContextTest.java
+ test/src/jdk/nashorn/internal/runtime/JSTypeTest.java
+ test/src/jdk/nashorn/internal/runtime/Nashorn401TestSubject.java
+ test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java
+ test/src/jdk/nashorn/internal/test/framework/JSJUnitReportReporter.java
+ test/src/jdk/nashorn/internal/test/framework/OrphanTestFinder.java
+ test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java
+ test/src/jdk/nashorn/internal/test/framework/ScriptEvaluator.java
+ test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java
+ test/src/jdk/nashorn/internal/test/framework/ScriptTest.java
+ test/src/jdk/nashorn/internal/test/framework/SeparateContextEvaluator.java
+ test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java
+ test/src/jdk/nashorn/internal/test/framework/TestConfig.java
+ test/src/jdk/nashorn/internal/test/framework/TestFinder.java
+ test/src/jdk/nashorn/internal/test/framework/TestHelper.java
+ test/src/jdk/nashorn/internal/test/framework/TestReorderInterceptor.java
+ test/src/jdk/nashorn/internal/test/models/ConstructorWithArgument.java
+ test/src/jdk/nashorn/internal/test/models/FinalClass.java
+ test/src/jdk/nashorn/internal/test/models/NoAccessibleConstructorClass.java
+ test/src/jdk/nashorn/internal/test/models/NonPublicClass.java
+ test/src/jdk/nashorn/internal/test/models/OuterClass.java
+ test/src/jdk/nashorn/internal/test/models/OverloadedSam.java
+ test/src/jdk/nashorn/internal/test/models/OverrideObject.java

Changeset: b4b05457b8b2
Author:    jlaskey
Date:      2012-12-22 08:49 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b4b05457b8b2

8005440: Improve .hgignore filtering for Nashorn repo
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! .hgignore

Changeset: 3a7e1580bc0a
Author:    jlaskey
Date:      2013-01-04 09:58 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3a7e1580bc0a

8005666: Add webrev to .hgignore
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! .hgignore

Changeset: c6e194450af7
Author:    jlaskey
Date:      2013-01-04 09:58 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c6e194450af7

8005665: JavaDoc should only display public interfaces
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! make/build.xml

Changeset: 5a1b0714df0e
Author:    jlaskey
Date:      2013-01-04 09:58 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5a1b0714df0e

8005663: Update copyright year to 2013
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! bin/checkintest.sh
! bin/fixorphantests.sh
! bin/fixwhitespace.sh
! bin/jjs
! bin/jjs.bat
! bin/jjssecure
! bin/jjssecure.bat
! bin/nashorn
! bin/nashorn.bat
! bin/rm-non-tracked.sh
! bin/verbose_octane.bat
! bin/verbose_octane.sh
! buildtools/nasgen/build.xml
! buildtools/nasgen/nasgen.iml
! buildtools/nasgen/project.properties
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/Main.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MemberInfo.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/NullVisitor.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfo.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInfoCollector.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java
! docs/genshelldoc.js
! make/Makefile
! make/build-benchmark.xml
! make/build-nasgen.xml
! make/build.xml
! make/nbproject/ide-file-targets.xml
! make/nbproject/ide-targets.xml
! make/nbproject/jdk.xml
! make/nbproject/nbjdk.properties
! make/nbproject/nbjdk.xml
! make/nbproject/project.xml
! make/project.properties
! samples/counters.js
! samples/letter.js
! samples/parser.js
! samples/shell.js
! samples/test.js
! samples/uniq.js
! src/META-INF/services/javax.script.ScriptEngineFactory
! src/jdk/nashorn/api/scripting/NashornException.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/api/scripting/package-info.java
! src/jdk/nashorn/api/scripting/resources/engine.js
! src/jdk/nashorn/internal/codegen/AccessSpecializer.java
! src/jdk/nashorn/internal/codegen/BranchOptimizer.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompileUnit.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/ConstantData.java
! src/jdk/nashorn/internal/codegen/Emitter.java
! src/jdk/nashorn/internal/codegen/Frame.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/Namespace.java
! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java
! src/jdk/nashorn/internal/codegen/SharedScopeCall.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/Transform.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java
! src/jdk/nashorn/internal/codegen/objects/MapCreator.java
! src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java
! src/jdk/nashorn/internal/codegen/objects/ObjectMapCreator.java
! src/jdk/nashorn/internal/codegen/types/ArrayType.java
! src/jdk/nashorn/internal/codegen/types/BitwiseType.java
! src/jdk/nashorn/internal/codegen/types/BooleanType.java
! src/jdk/nashorn/internal/codegen/types/BytecodeArrayOps.java
! src/jdk/nashorn/internal/codegen/types/BytecodeBitwiseOps.java
! src/jdk/nashorn/internal/codegen/types/BytecodeNumericOps.java
! src/jdk/nashorn/internal/codegen/types/BytecodeOps.java
! src/jdk/nashorn/internal/codegen/types/IntType.java
! src/jdk/nashorn/internal/codegen/types/LongType.java
! src/jdk/nashorn/internal/codegen/types/NumberType.java
! src/jdk/nashorn/internal/codegen/types/NumericType.java
! src/jdk/nashorn/internal/codegen/types/ObjectType.java
! src/jdk/nashorn/internal/codegen/types/Type.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/Assignment.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
! src/jdk/nashorn/internal/ir/DoWhileNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionCall.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
! src/jdk/nashorn/internal/ir/LabeledNode.java
! src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Location.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/PropertyKey.java
! src/jdk/nashorn/internal/ir/PropertyNode.java
! src/jdk/nashorn/internal/ir/ReferenceNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/TypeOverride.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
! src/jdk/nashorn/internal/ir/annotations/ChildNode.java
! src/jdk/nashorn/internal/ir/annotations/Ignore.java
! src/jdk/nashorn/internal/ir/annotations/ParentNode.java
! src/jdk/nashorn/internal/ir/annotations/Reference.java
! src/jdk/nashorn/internal/ir/debug/ASTWriter.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/ArrayBufferView.java
! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/DateParser.java
! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeEvalError.java
! src/jdk/nashorn/internal/objects/NativeFloat32Array.java
! src/jdk/nashorn/internal/objects/NativeFloat64Array.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeInt16Array.java
! src/jdk/nashorn/internal/objects/NativeInt32Array.java
! src/jdk/nashorn/internal/objects/NativeInt8Array.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/objects/NativeJavaImporter.java
! src/jdk/nashorn/internal/objects/NativeMath.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/objects/NativeRangeError.java
! src/jdk/nashorn/internal/objects/NativeReferenceError.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java
! src/jdk/nashorn/internal/objects/NativeStrictArguments.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/objects/NativeSyntaxError.java
! src/jdk/nashorn/internal/objects/NativeTypeError.java
! src/jdk/nashorn/internal/objects/NativeURIError.java
! src/jdk/nashorn/internal/objects/NativeUint16Array.java
! src/jdk/nashorn/internal/objects/NativeUint32Array.java
! src/jdk/nashorn/internal/objects/NativeUint8Array.java
! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java
! src/jdk/nashorn/internal/objects/PrototypeObject.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/objects/annotations/Attribute.java
! src/jdk/nashorn/internal/objects/annotations/Constructor.java
! src/jdk/nashorn/internal/objects/annotations/Function.java
! src/jdk/nashorn/internal/objects/annotations/Getter.java
! src/jdk/nashorn/internal/objects/annotations/Property.java
! src/jdk/nashorn/internal/objects/annotations/ScriptClass.java
! src/jdk/nashorn/internal/objects/annotations/Setter.java
! src/jdk/nashorn/internal/objects/annotations/SpecializedConstructor.java
! src/jdk/nashorn/internal/objects/annotations/SpecializedFunction.java
! src/jdk/nashorn/internal/objects/annotations/Where.java
! src/jdk/nashorn/internal/objects/package-info.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/JSONParser.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/parser/RegExp.java
! src/jdk/nashorn/internal/parser/RegExpScanner.java
! src/jdk/nashorn/internal/parser/Scanner.java
! src/jdk/nashorn/internal/parser/Token.java
! src/jdk/nashorn/internal/parser/TokenKind.java
! src/jdk/nashorn/internal/parser/TokenLookup.java
! src/jdk/nashorn/internal/parser/TokenStream.java
! src/jdk/nashorn/internal/parser/TokenType.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/BitVector.java
! src/jdk/nashorn/internal/runtime/CodeInstaller.java
! src/jdk/nashorn/internal/runtime/ConsString.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/Debug.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/DefaultPropertyAccess.java
! src/jdk/nashorn/internal/runtime/ECMAErrors.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! src/jdk/nashorn/internal/runtime/ErrorManager.java
! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/FunctionScope.java
! src/jdk/nashorn/internal/runtime/GlobalFunctions.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/JSErrorType.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/Logging.java
! src/jdk/nashorn/internal/runtime/NashornLoader.java
! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
! src/jdk/nashorn/internal/runtime/NumberToString.java
! src/jdk/nashorn/internal/runtime/ParserException.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/PropertyAccess.java
! src/jdk/nashorn/internal/runtime/PropertyDescriptor.java
! src/jdk/nashorn/internal/runtime/PropertyHashMap.java
! src/jdk/nashorn/internal/runtime/PropertyListener.java
! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/QuotedStringTokenizer.java
! src/jdk/nashorn/internal/runtime/RegExpMatch.java
! src/jdk/nashorn/internal/runtime/Scope.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptLoader.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/Source.java
! src/jdk/nashorn/internal/runtime/SpillProperty.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java
! src/jdk/nashorn/internal/runtime/URIUtils.java
! src/jdk/nashorn/internal/runtime/Undefined.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
! src/jdk/nashorn/internal/runtime/Version.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java
! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/EmptyArrayLikeIterator.java
! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/InvalidArrayIndexException.java
! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java
! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java
! src/jdk/nashorn/internal/runtime/arrays/NoTypeArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java
! src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java
! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java
! src/jdk/nashorn/internal/runtime/arrays/UndefinedArrayFilter.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java
! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/internal/runtime/linker/Lookup.java
! src/jdk/nashorn/internal/runtime/linker/Mangler.java
! src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java
! src/jdk/nashorn/internal/runtime/linker/MethodHandleFunctionality.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java
! src/jdk/nashorn/internal/runtime/linker/NashornGuardedInvocation.java
! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
! src/jdk/nashorn/internal/runtime/options/KeyValueOption.java
! src/jdk/nashorn/internal/runtime/options/Option.java
! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/internal/runtime/options/ValueOption.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
! src/jdk/nashorn/internal/runtime/resources/Options.properties
! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
! src/jdk/nashorn/internal/runtime/resources/parser.js
! src/jdk/nashorn/internal/runtime/resources/version.properties-template
! src/jdk/nashorn/internal/scripts/JO$.java
! src/jdk/nashorn/internal/scripts/JS$.java
! src/jdk/nashorn/tools/Shell.java
! src/jdk/nashorn/tools/resources/Shell.properties
! src/jdk/nashorn/tools/resources/shell.js
! src/netscape/javascript/JSObject.java
! src/overview.html
! test/examples/dual-fields-micro.js
! test/examples/innerbench.js
! test/examples/typechain.js
! test/lib/benchmark.js
! test/opt/add.js
! test/opt/add_constant.js
! test/opt/add_reuse_callsite.js
! test/opt/add_revert2.js
! test/opt/cascade_specialize.js
! test/script/assert.js
! test/script/basic/NASHORN-100.js
! test/script/basic/NASHORN-101.js
! test/script/basic/NASHORN-102.js
! test/script/basic/NASHORN-103.js
! test/script/basic/NASHORN-104.js
! test/script/basic/NASHORN-105.js
! test/script/basic/NASHORN-106.js
! test/script/basic/NASHORN-107.js
! test/script/basic/NASHORN-108.js
! test/script/basic/NASHORN-109.js
! test/script/basic/NASHORN-11.js
! test/script/basic/NASHORN-111.js
! test/script/basic/NASHORN-113.js
! test/script/basic/NASHORN-114.js
! test/script/basic/NASHORN-115.js
! test/script/basic/NASHORN-117.js
! test/script/basic/NASHORN-118.js
! test/script/basic/NASHORN-119.js
! test/script/basic/NASHORN-12.js
! test/script/basic/NASHORN-120.js
! test/script/basic/NASHORN-122.js
! test/script/basic/NASHORN-126.js
! test/script/basic/NASHORN-127.js
! test/script/basic/NASHORN-130.js
! test/script/basic/NASHORN-132.js
! test/script/basic/NASHORN-133.js
! test/script/basic/NASHORN-135.js
! test/script/basic/NASHORN-136.js
! test/script/basic/NASHORN-14.js
! test/script/basic/NASHORN-148.js
! test/script/basic/NASHORN-15.js
! test/script/basic/NASHORN-153.js
! test/script/basic/NASHORN-156.js
! test/script/basic/NASHORN-157.js
! test/script/basic/NASHORN-163.js
! test/script/basic/NASHORN-164.js
! test/script/basic/NASHORN-165.js
! test/script/basic/NASHORN-166.js
! test/script/basic/NASHORN-168.js
! test/script/basic/NASHORN-169.js
! test/script/basic/NASHORN-172.js
! test/script/basic/NASHORN-173.js
! test/script/basic/NASHORN-174.js
! test/script/basic/NASHORN-175.js
! test/script/basic/NASHORN-176.js
! test/script/basic/NASHORN-177.js
! test/script/basic/NASHORN-178.js
! test/script/basic/NASHORN-179.js
! test/script/basic/NASHORN-18.js
! test/script/basic/NASHORN-181.js
! test/script/basic/NASHORN-182.js
! test/script/basic/NASHORN-183.js
! test/script/basic/NASHORN-184.js
! test/script/basic/NASHORN-185.js
! test/script/basic/NASHORN-187.js
! test/script/basic/NASHORN-188.js
! test/script/basic/NASHORN-19.js
! test/script/basic/NASHORN-190.js
! test/script/basic/NASHORN-192.js
! test/script/basic/NASHORN-194.js
! test/script/basic/NASHORN-196.js
! test/script/basic/NASHORN-198.js
! test/script/basic/NASHORN-20.js
! test/script/basic/NASHORN-201.js
! test/script/basic/NASHORN-202.js
! test/script/basic/NASHORN-203.js
! test/script/basic/NASHORN-204.js
! test/script/basic/NASHORN-205.js
! test/script/basic/NASHORN-206.js
! test/script/basic/NASHORN-207.js
! test/script/basic/NASHORN-207_2.js
! test/script/basic/NASHORN-208.js
! test/script/basic/NASHORN-209.js
! test/script/basic/NASHORN-21.js
! test/script/basic/NASHORN-211.js
! test/script/basic/NASHORN-212.js
! test/script/basic/NASHORN-213.js
! test/script/basic/NASHORN-215.js
! test/script/basic/NASHORN-216.js
! test/script/basic/NASHORN-217.js
! test/script/basic/NASHORN-219.js
! test/script/basic/NASHORN-22.js
! test/script/basic/NASHORN-221.js
! test/script/basic/NASHORN-222.js
! test/script/basic/NASHORN-223.js
! test/script/basic/NASHORN-225.js
! test/script/basic/NASHORN-226.js
! test/script/basic/NASHORN-227.js
! test/script/basic/NASHORN-228.js
! test/script/basic/NASHORN-229.js
! test/script/basic/NASHORN-229_subtest.js
! test/script/basic/NASHORN-23.js
! test/script/basic/NASHORN-232.js
! test/script/basic/NASHORN-234.js
! test/script/basic/NASHORN-235.js
! test/script/basic/NASHORN-236.js
! test/script/basic/NASHORN-237.js
! test/script/basic/NASHORN-239.js
! test/script/basic/NASHORN-24.js
! test/script/basic/NASHORN-241.js
! test/script/basic/NASHORN-242.js
! test/script/basic/NASHORN-245.js
! test/script/basic/NASHORN-247.js
! test/script/basic/NASHORN-25.js
! test/script/basic/NASHORN-251.js
! test/script/basic/NASHORN-252.js
! test/script/basic/NASHORN-253.js
! test/script/basic/NASHORN-256.js
! test/script/basic/NASHORN-258.js
! test/script/basic/NASHORN-26.js
! test/script/basic/NASHORN-260.js
! test/script/basic/NASHORN-261.js
! test/script/basic/NASHORN-262.js
! test/script/basic/NASHORN-263.js
! test/script/basic/NASHORN-264.js
! test/script/basic/NASHORN-265.js
! test/script/basic/NASHORN-266.js
! test/script/basic/NASHORN-269.js
! test/script/basic/NASHORN-27.js
! test/script/basic/NASHORN-270.js
! test/script/basic/NASHORN-271.js
! test/script/basic/NASHORN-275.js
! test/script/basic/NASHORN-276.js
! test/script/basic/NASHORN-277.js
! test/script/basic/NASHORN-278.js
! test/script/basic/NASHORN-28.js
! test/script/basic/NASHORN-281.js
! test/script/basic/NASHORN-284.js
! test/script/basic/NASHORN-285.js
! test/script/basic/NASHORN-288.js
! test/script/basic/NASHORN-29.js
! test/script/basic/NASHORN-293.js
! test/script/basic/NASHORN-294.js
! test/script/basic/NASHORN-296.js
! test/script/basic/NASHORN-297.js
! test/script/basic/NASHORN-30.js
! test/script/basic/NASHORN-300.js
! test/script/basic/NASHORN-301.js
! test/script/basic/NASHORN-304.js
! test/script/basic/NASHORN-310.js
! test/script/basic/NASHORN-318.js
! test/script/basic/NASHORN-32.js
! test/script/basic/NASHORN-321.js
! test/script/basic/NASHORN-323.js
! test/script/basic/NASHORN-324.js
! test/script/basic/NASHORN-33.js
! test/script/basic/NASHORN-331.js
! test/script/basic/NASHORN-337.js
! test/script/basic/NASHORN-34.js
! test/script/basic/NASHORN-340.js
! test/script/basic/NASHORN-349.js
! test/script/basic/NASHORN-354.js
! test/script/basic/NASHORN-355.js
! test/script/basic/NASHORN-36.js
! test/script/basic/NASHORN-365.js
! test/script/basic/NASHORN-366.js
! test/script/basic/NASHORN-368.js
! test/script/basic/NASHORN-37.js
! test/script/basic/NASHORN-375.js
! test/script/basic/NASHORN-376.js
! test/script/basic/NASHORN-377.js
! test/script/basic/NASHORN-378.js
! test/script/basic/NASHORN-38.js
! test/script/basic/NASHORN-380.js
! test/script/basic/NASHORN-381.js
! test/script/basic/NASHORN-382.js
! test/script/basic/NASHORN-383.js
! test/script/basic/NASHORN-384.js
! test/script/basic/NASHORN-385.js
! test/script/basic/NASHORN-389.js
! test/script/basic/NASHORN-393.js
! test/script/basic/NASHORN-394.js
! test/script/basic/NASHORN-396.js
! test/script/basic/NASHORN-397.js
! test/script/basic/NASHORN-398.js
! test/script/basic/NASHORN-40.js
! test/script/basic/NASHORN-400.js
! test/script/basic/NASHORN-401.js
! test/script/basic/NASHORN-402.js
! test/script/basic/NASHORN-404.js
! test/script/basic/NASHORN-405.js
! test/script/basic/NASHORN-406.js
! test/script/basic/NASHORN-408.js
! test/script/basic/NASHORN-415.js
! test/script/basic/NASHORN-416.js
! test/script/basic/NASHORN-417.js
! test/script/basic/NASHORN-418.js
! test/script/basic/NASHORN-420.js
! test/script/basic/NASHORN-421.js
! test/script/basic/NASHORN-423.js
! test/script/basic/NASHORN-423a.js
! test/script/basic/NASHORN-424.js
! test/script/basic/NASHORN-425.js
! test/script/basic/NASHORN-426.js
! test/script/basic/NASHORN-427.js
! test/script/basic/NASHORN-428.js
! test/script/basic/NASHORN-429.js
! test/script/basic/NASHORN-432.js
! test/script/basic/NASHORN-433.js
! test/script/basic/NASHORN-434.js
! test/script/basic/NASHORN-435.js
! test/script/basic/NASHORN-437.js
! test/script/basic/NASHORN-44.js
! test/script/basic/NASHORN-441.js
! test/script/basic/NASHORN-442.js
! test/script/basic/NASHORN-443.js
! test/script/basic/NASHORN-444.js
! test/script/basic/NASHORN-445.js
! test/script/basic/NASHORN-446.js
! test/script/basic/NASHORN-447.js
! test/script/basic/NASHORN-448.js
! test/script/basic/NASHORN-449.js
! test/script/basic/NASHORN-45.js
! test/script/basic/NASHORN-450.js
! test/script/basic/NASHORN-452.js
! test/script/basic/NASHORN-459.js
! test/script/basic/NASHORN-46.js
! test/script/basic/NASHORN-462.js
! test/script/basic/NASHORN-463.js
! test/script/basic/NASHORN-468.js
! test/script/basic/NASHORN-47.js
! test/script/basic/NASHORN-473.js
! test/script/basic/NASHORN-474.js
! test/script/basic/NASHORN-478.js
! test/script/basic/NASHORN-48.js
! test/script/basic/NASHORN-481.js
! test/script/basic/NASHORN-482.js
! test/script/basic/NASHORN-484.js
! test/script/basic/NASHORN-486.js
! test/script/basic/NASHORN-487.js
! test/script/basic/NASHORN-488.js
! test/script/basic/NASHORN-49.js
! test/script/basic/NASHORN-490.js
! test/script/basic/NASHORN-494.js
! test/script/basic/NASHORN-497.js
! test/script/basic/NASHORN-498.js
! test/script/basic/NASHORN-499.js
! test/script/basic/NASHORN-50.js
! test/script/basic/NASHORN-500.js
! test/script/basic/NASHORN-503.js
! test/script/basic/NASHORN-51.js
! test/script/basic/NASHORN-511.js
! test/script/basic/NASHORN-515.js
! test/script/basic/NASHORN-516.js
! test/script/basic/NASHORN-52.js
! test/script/basic/NASHORN-534.js
! test/script/basic/NASHORN-535.js
! test/script/basic/NASHORN-544.js
! test/script/basic/NASHORN-55.js
! test/script/basic/NASHORN-554.js
! test/script/basic/NASHORN-556.js
! test/script/basic/NASHORN-56.js
! test/script/basic/NASHORN-562.js
! test/script/basic/NASHORN-565.js
! test/script/basic/NASHORN-575.js
! test/script/basic/NASHORN-58.js
! test/script/basic/NASHORN-59.js
! test/script/basic/NASHORN-592.js
! test/script/basic/NASHORN-597.js
! test/script/basic/NASHORN-60.js
! test/script/basic/NASHORN-609.js
! test/script/basic/NASHORN-61.js
! test/script/basic/NASHORN-62.js
! test/script/basic/NASHORN-620.js
! test/script/basic/NASHORN-623.js
! test/script/basic/NASHORN-627.js
! test/script/basic/NASHORN-63.js
! test/script/basic/NASHORN-637.js
! test/script/basic/NASHORN-638.js
! test/script/basic/NASHORN-639.js
! test/script/basic/NASHORN-64.js
! test/script/basic/NASHORN-642.js
! test/script/basic/NASHORN-646.js
! test/script/basic/NASHORN-653.js
! test/script/basic/NASHORN-658.js
! test/script/basic/NASHORN-659.js
! test/script/basic/NASHORN-66.js
! test/script/basic/NASHORN-664.js
! test/script/basic/NASHORN-665.js
! test/script/basic/NASHORN-67.js
! test/script/basic/NASHORN-678.js
! test/script/basic/NASHORN-68.js
! test/script/basic/NASHORN-689.js
! test/script/basic/NASHORN-69.js
! test/script/basic/NASHORN-691.js
! test/script/basic/NASHORN-694.js
! test/script/basic/NASHORN-697.js
! test/script/basic/NASHORN-703.js
! test/script/basic/NASHORN-703a.js
! test/script/basic/NASHORN-705.js
! test/script/basic/NASHORN-71.js
! test/script/basic/NASHORN-710.js
! test/script/basic/NASHORN-711.js
! test/script/basic/NASHORN-72.js
! test/script/basic/NASHORN-722.js
! test/script/basic/NASHORN-73.js
! test/script/basic/NASHORN-737.js
! test/script/basic/NASHORN-74.js
! test/script/basic/NASHORN-740.js
! test/script/basic/NASHORN-75.js
! test/script/basic/NASHORN-758.js
! test/script/basic/NASHORN-759.js
! test/script/basic/NASHORN-760.js
! test/script/basic/NASHORN-768.js
! test/script/basic/NASHORN-778.js
! test/script/basic/NASHORN-78.js
! test/script/basic/NASHORN-79.js
! test/script/basic/NASHORN-792.js
! test/script/basic/NASHORN-80.js
! test/script/basic/NASHORN-81.js
! test/script/basic/NASHORN-833.js
! test/script/basic/NASHORN-85.js
! test/script/basic/NASHORN-86.js
! test/script/basic/NASHORN-87.js
! test/script/basic/NASHORN-89.js
! test/script/basic/NASHORN-90.js
! test/script/basic/NASHORN-91.js
! test/script/basic/NASHORN-92.js
! test/script/basic/NASHORN-93.js
! test/script/basic/NASHORN-95.js
! test/script/basic/NASHORN-96.js
! test/script/basic/NASHORN-97.js
! test/script/basic/NASHORN-98.js
! test/script/basic/NASHORN-99.js
! test/script/basic/addition.js
! test/script/basic/allgettersetters.js
! test/script/basic/andor.js
! test/script/basic/anonrecur.js
! test/script/basic/applycall.js
! test/script/basic/args.js
! test/script/basic/arity.js
! test/script/basic/arrayprotoclass.js
! test/script/basic/arrays.js
! test/script/basic/arrays2.js
! test/script/basic/arraysIntKey.js
! test/script/basic/arrayset.js
! test/script/basic/arrayundefined.js
! test/script/basic/assign.js
! test/script/basic/bitwise_and.js
! test/script/basic/booleangetter.js
! test/script/basic/builtin.js
! test/script/basic/builtin_assign.js
! test/script/basic/builtinchain.js
! test/script/basic/calllink.js
! test/script/basic/closure.js
! test/script/basic/commandargs.js
! test/script/basic/compile-octane.js
! test/script/basic/condassign.js
! test/script/basic/construct.js
! test/script/basic/constructorname.js
! test/script/basic/date.js
! test/script/basic/dateparse.js
! test/script/basic/decinc.js
! test/script/basic/delete.js
! test/script/basic/delete2.js
! test/script/basic/dotpropname.js
! test/script/basic/doublecache.js
! test/script/basic/enumeration.js
! test/script/basic/errors.js
! test/script/basic/errorstack.js
! test/script/basic/eval.js
! test/script/basic/evalreturn.js
! test/script/basic/exprclosure.js
! test/script/basic/extensibility.js
! test/script/basic/fileline.js
! test/script/basic/finally-catchalls.js
! test/script/basic/finallyreturn.js
! test/script/basic/forin.js
! test/script/basic/forin2.js
! test/script/basic/funcarray.js
! test/script/basic/funcbind.js
! test/script/basic/funcconstructor.js
! test/script/basic/getclassname.js
! test/script/basic/getenv.js
! test/script/basic/getter_callsite.js
! test/script/basic/gettercalls.js
! test/script/basic/getterfunc.js
! test/script/basic/gettersetter.js
! test/script/basic/globalaccess.js
! test/script/basic/globals.js
! test/script/basic/globalscope.js
! test/script/basic/hello.js
! test/script/basic/herestr_operator.js
! test/script/basic/illegaljavaname.js
! test/script/basic/incheck.js
! test/script/basic/indexedcall.js
! test/script/basic/info.js
! test/script/basic/inherited_nonwritable.js
! test/script/basic/instanceof.js
! test/script/basic/instanceof2.js
! test/script/basic/interfaces.js
! test/script/basic/iterator.js
! test/script/basic/java.js
! test/script/basic/javaarray.js
! test/script/basic/javaarrayconversion.js
! test/script/basic/javaexceptions.js
! test/script/basic/javaimporter.js
! test/script/basic/javainnerclasses.js
! test/script/basic/javasigcall.js
! test/script/basic/jquery.js
! test/script/basic/jsadapter.js
! test/script/basic/jsadapterlink.js
! test/script/basic/json.js
! test/script/basic/list.js
! test/script/basic/literal.js
! test/script/basic/load.js
! test/script/basic/loadedfile.js
! test/script/basic/localundef.js
! test/script/basic/map.js
! test/script/basic/math.js
! test/script/basic/minuszero.js
! test/script/basic/module.js
! test/script/basic/moduleload.js
! test/script/basic/nashorn2.js
! test/script/basic/natives.js
! test/script/basic/new.js
! test/script/basic/newexpr.js
! test/script/basic/newnew.js
! test/script/basic/nonconstructors.js
! test/script/basic/nosuchmethod.js
! test/script/basic/nosuchproperty.js
! test/script/basic/number.js
! test/script/basic/numberstring.js
! test/script/basic/objectprops.js
! test/script/basic/objects.js
! test/script/basic/options.js
! test/script/basic/propchange.js
! test/script/basic/propertycheck.js
! test/script/basic/prototype.js
! test/script/basic/pushpull.js
! test/script/basic/regex.js
! test/script/basic/regexp_flags.js
! test/script/basic/run-octane.js
! test/script/basic/runsunspider.js
! test/script/basic/samfunc.js
! test/script/basic/scripting.js
! test/script/basic/scripting.js.EXPECTED
! test/script/basic/sealfreeze.js
! test/script/basic/setlength.js
! test/script/basic/stdin.js
! test/script/basic/strings.js
! test/script/basic/throws.js
! test/script/basic/tosource.js
! test/script/basic/tostring.js
! test/script/basic/try.js
! test/script/basic/trybreakcont.js
! test/script/basic/trycatch.js
! test/script/basic/trycatchfor.js
! test/script/basic/tryfinallyreturn.js
! test/script/basic/tryforbreak.js
! test/script/basic/typechange.js
! test/script/basic/typeof.js
! test/script/basic/typeof2.js
! test/script/basic/undefined.js
! test/script/basic/underscore.js
! test/script/basic/varargs.js
! test/script/basic/void.js
! test/script/basic/with.js
! test/script/basic/withprimitive.js
! test/script/basic/writable_relink.js
! test/script/basic/xorassign.js
! test/script/basic/yui.js
! test/script/error/NASHORN-154/function_mult_params_in_strict.js
! test/script/error/NASHORN-154/improper_return_break_continue.js
! test/script/error/NASHORN-154/invalid_lvalue.js
! test/script/error/NASHORN-154/literal_data_and_accessor.js
! test/script/error/NASHORN-154/literal_mult_getters.js
! test/script/error/NASHORN-154/literal_mult_prop_in_strict.js
! test/script/error/NASHORN-154/with_in_strict.js
! test/script/error/NASHORN-214.js
! test/script/error/NASHORN-35.js
! test/script/error/NASHORN-39.js
! test/script/error/NASHORN-568.js
! test/script/error/NASHORN-57.js
! test/script/error/NASHORN-668.js
! test/script/error/quotemissing.js
! test/script/error/strictmode.js
! test/script/representations/NASHORN-592a.js
! test/script/sandbox/NASHORN-525.js
! test/script/sandbox/classloader.js
! test/script/sandbox/doprivileged.js
! test/script/sandbox/exit.js
! test/script/sandbox/file.js
! test/script/sandbox/javaextend.js
! test/script/sandbox/loadLibrary.js
! test/script/sandbox/net.js
! test/script/sandbox/property.js
! test/script/sandbox/reflection.js
! test/script/sandbox/runnable.js
! test/script/sandbox/unsafe.js
! test/script/test262.js
! test/script/test262_single.js
! test/src/UnnamedPackageTestCallback.java
! test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java
! test/src/jdk/nashorn/api/scripting/Window.java
! test/src/jdk/nashorn/api/scripting/WindowEventHandler.java
! test/src/jdk/nashorn/internal/access/BooleanAccessTest.java
! test/src/jdk/nashorn/internal/access/MethodAccessTest.java
! test/src/jdk/nashorn/internal/access/NumberAccessTest.java
! test/src/jdk/nashorn/internal/access/NumberBoxingTest.java
! test/src/jdk/nashorn/internal/access/ObjectAccessTest.java
! test/src/jdk/nashorn/internal/access/Person.java
! test/src/jdk/nashorn/internal/access/SharedObject.java
! test/src/jdk/nashorn/internal/access/StringAccessTest.java
! test/src/jdk/nashorn/internal/codegen/CompilerTest.java
! test/src/jdk/nashorn/internal/parser/ParserTest.java
! test/src/jdk/nashorn/internal/performance/AuroraWrapper.java
! test/src/jdk/nashorn/internal/performance/OctaneTest.java
! test/src/jdk/nashorn/internal/performance/PerformanceWrapper.java
! test/src/jdk/nashorn/internal/performance/SplayTest.java
! test/src/jdk/nashorn/internal/runtime/ContextTest.java
! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java
! test/src/jdk/nashorn/internal/runtime/Nashorn401TestSubject.java
! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java
! test/src/jdk/nashorn/internal/test/framework/JSJUnitReportReporter.java
! test/src/jdk/nashorn/internal/test/framework/OrphanTestFinder.java
! test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java
! test/src/jdk/nashorn/internal/test/framework/ScriptEvaluator.java
! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java
! test/src/jdk/nashorn/internal/test/framework/ScriptTest.java
! test/src/jdk/nashorn/internal/test/framework/SeparateContextEvaluator.java
! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java
! test/src/jdk/nashorn/internal/test/framework/TestConfig.java
! test/src/jdk/nashorn/internal/test/framework/TestFinder.java
! test/src/jdk/nashorn/internal/test/framework/TestHelper.java
! test/src/jdk/nashorn/internal/test/framework/TestReorderInterceptor.java
! test/src/jdk/nashorn/internal/test/models/ConstructorWithArgument.java
! test/src/jdk/nashorn/internal/test/models/FinalClass.java
! test/src/jdk/nashorn/internal/test/models/NoAccessibleConstructorClass.java
! test/src/jdk/nashorn/internal/test/models/NonPublicClass.java
! test/src/jdk/nashorn/internal/test/models/OuterClass.java
! test/src/jdk/nashorn/internal/test/models/OverloadedSam.java
! test/src/jdk/nashorn/internal/test/models/OverrideObject.java

Changeset: 1e3f411f47bf
Author:    lagergren
Date:      2013-01-07 19:31 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1e3f411f47bf

8005789: Forgot to document -Dnashorn.unstable.relink.threshold
Summary: Added documentation to DEVELOPER_README, fixed code convention warnings
Reviewed-by: attila

! docs/DEVELOPER_README
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/options/Options.java

Changeset: 41c7093477ae
Author:    jlaskey
Date:      2013-01-07 14:41 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/41c7093477ae

8005703: Offsets miscalculated for blocks
Reviewed-by: lagergren
Contributed-by: petr.hejl at oracle.com

! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Parser.java

Changeset: d14da0d0c577
Author:    sundar
Date:      2013-01-08 08:51 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d14da0d0c577

8005782: get rid of javadoc errors, warnings in nashorn build
Reviewed-by: lagergren

! make/build.xml
! make/project.properties
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/runtime/ECMAErrors.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 0e7da548ef6a
Author:    lagergren
Date:      2013-01-08 09:59 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/0e7da548ef6a

8005788: Loggers and their corresponding system properties not working correctly
Summary: 1-1 mapping now maintained. Used Context err instead of System.err in several places (after bootstrapping Context). Problematic closing of err stream replaced by @SuppressWarnings("resource")
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! src/jdk/nashorn/internal/runtime/ErrorManager.java
! src/jdk/nashorn/internal/runtime/Logging.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/tools/Shell.java

Changeset: 5f2db2d8a7fa
Author:    sundar
Date:      2013-01-08 15:02 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5f2db2d8a7fa

8005835: NASHORN-668 output fails to compare with the corresponding .EXPECTED file
Reviewed-by: lagergren, hannesw

! test/script/error/NASHORN-668.js.EXPECTED

Changeset: d8e4d66f1a06
Author:    lagergren
Date:      2013-01-08 10:52 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d8e4d66f1a06

8005843: refSymbols lookup of unbound variable could cause NullPointerException in Lower
Reviewed-by: hannesw, attila

! src/jdk/nashorn/internal/codegen/Lower.java
+ test/script/basic/NASHORN-837.js

Changeset: c5a321205f49
Author:    attila
Date:      2013-01-08 13:50 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c5a321205f49

8005846: Remove Mangler in favor of Dynalink's NameCodec
Reviewed-by: jlaskey, sundar

! src/jdk/nashorn/internal/codegen/Compiler.java

Changeset: 4620ac94e7dc
Author:    attila
Date:      2013-01-08 14:14 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/4620ac94e7dc

8005801: Refactor findSetMethod
Summary: findSetMethod() was a very large single method, very unreadable and unmaintainable. It was broken into easy-to-understand pieces. The refactoring required introduction of a comand-object like entity, SetMethodCreator, to contain the nontrivial transient state of the algorithm that made the original big method so resistant to refactoring in the first place.
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/SpillProperty.java
- src/jdk/nashorn/internal/runtime/linker/Mangler.java

Changeset: 69a4f0363d0f
Author:    lagergren
Date:      2013-01-08 15:20 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/69a4f0363d0f

8005842: Loops in ASTWriter. Corrected @Reference and @Ignore node annotation for IR nodes
Reviewed-by: hannesw, sundar

! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
! src/jdk/nashorn/internal/ir/LabeledNode.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/ReferenceNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/debug/ASTWriter.java

Changeset: 548587cfb065
Author:    sundar
Date:      2013-01-08 21:16 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/548587cfb065

8005848: assigning to global toString variable affects Object.prototype.toString
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK_8005848.js

Changeset: 812b9963b1c7
Author:    attila
Date:      2013-01-09 15:02 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/812b9963b1c7

8005777: Bug in the FacetIntrospector of Dynalink - non-public class should search super
Reviewed-by: lagergren, sundar

! make/project.properties

Changeset: 4cd65798ec70
Author:    sundar
Date:      2013-01-09 22:32 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/4cd65798ec70

8005940: provide ant targets to get and update external test scripts
Reviewed-by: jlaskey, lagergren

! bin/verbose_octane.bat
! bin/verbose_octane.sh
! make/Makefile
! make/build-benchmark.xml
! make/build.xml
! make/project.properties
! test/script/basic/run-octane.js
! test/script/basic/runsunspider.js
! test/src/jdk/nashorn/internal/codegen/CompilerTest.java
! test/src/jdk/nashorn/internal/parser/ParserTest.java

Changeset: 9f59ba5090f2
Author:    lagergren
Date:      2013-01-10 10:28 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9f59ba5090f2

8005971: runsunspider.js should check results of benchmarks
Reviewed-by: attila, hannesw

! test/script/basic/runsunspider.js

Changeset: a7f177d6639c
Author:    sundar
Date:      2013-01-10 19:03 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a7f177d6639c

8005987: ant octane tries to run non-benchmark scripts
Reviewed-by: lagergren, attila, jlaskey

! make/build-benchmark.xml
! make/project.properties

Changeset: 0362d36d3dd6
Author:    sundar
Date:      2013-01-10 19:55 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/0362d36d3dd6

8005982: NASHORN-71.js failing in nightlys
Reviewed-by: attila, lagergren, jlaskey

! test/script/basic/NASHORN-71.js
- test/script/basic/NASHORN-71.js.EXPECTED

Changeset: 2a5c2258827b
Author:    attila
Date:      2013-01-10 15:28 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2a5c2258827b

8005983: JavaAdapterFactory generated proxy classes should take extra constructor arguments at the end
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! test/script/sandbox/javaextend.js
! test/script/sandbox/javaextend.js.EXPECTED

Changeset: 2a4769fcd13f
Author:    lagergren
Date:      2013-01-11 10:40 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2a4769fcd13f

8005976: Break out AccessSpecializer into one pass before CodeGenerator instead of iterative applications from CodeGenerator
Summary: Now scope and slot information is guaranteed to be fixed AND NOT CHANGE before CodeGeneration. We want to keep it that way to build future type specializations and bring all type work out of CodeGenerator.
Reviewed-by: attila, hannesw

+ bin/dump_octane_code.sh
! bin/verbose_octane.sh
! docs/DEVELOPER_README
! src/jdk/nashorn/internal/codegen/AccessSpecializer.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/Splitter.java
- src/jdk/nashorn/internal/codegen/Transform.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java

Changeset: f67bf56495ca
Author:    sundar
Date:      2013-01-11 18:26 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f67bf56495ca

8006082: Provide option to run octane benchmarks in separate processes
Reviewed-by: lagergren, jlaskey

! make/build-benchmark.xml
! make/project.properties

Changeset: 8a5922638ff0
Author:    sundar
Date:      2013-01-11 20:34 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8a5922638ff0

8006093: Add a makefile target to run all tests (test, test262, perf tests)
Reviewed-by: attila, hannesw

! make/Makefile
! make/build.xml

Changeset: eda69555239a
Author:    attila
Date:      2013-01-14 16:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/eda69555239a

8006168: ability to generate multi-type Java adapters
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
! test/script/sandbox/javaextend.js
! test/script/sandbox/javaextend.js.EXPECTED
+ test/src/jdk/nashorn/internal/test/models/DessertTopping.java
+ test/src/jdk/nashorn/internal/test/models/DessertToppingFloorWaxDriver.java
+ test/src/jdk/nashorn/internal/test/models/FloorWax.java
+ test/src/jdk/nashorn/internal/test/models/Toothpaste.java

Changeset: 3c6db5ea0ecc
Author:    sundar
Date:      2013-01-14 21:30 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3c6db5ea0ecc

8006181: nashorn script engine does not run jrunscript's initialization script
Reviewed-by: lagergren, jlaskey
Contributed-by: rieberandreas at gmail.com

+ src/jdk/nashorn/api/scripting/Formatter.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/resources/engine.js
+ src/jdk/nashorn/api/scripting/resources/init.js

Changeset: 1d0307c2bb4c
Author:    attila
Date:      2013-01-15 13:10 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1d0307c2bb4c

8006293: Reduce ScriptObject.findCallMethodMethod
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java
! src/jdk/nashorn/internal/runtime/linker/MethodHandleFunctionality.java

Changeset: ee73d7378e3e
Author:    attila
Date:      2013-01-15 17:09 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ee73d7378e3e

8005958: invoking a function through INVOKESTATIC with more arguments than it declares resulted in malformed bytecode being generated
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8005958.js

Changeset: 9088170e68df
Author:    attila
Date:      2013-01-15 18:08 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9088170e68df

8006337: Discarded arguments for INVOKESTATIC must still be evaluated for side effects
Reviewed-by: hannesw, jlaskey, sundar

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8006337.js
+ test/script/basic/JDK-8006337.js.EXPECTED

Changeset: 617313881c55
Author:    jlaskey
Date:      2013-01-16 07:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/617313881c55

8006304: Remove pre-population of maps for constructor produced maps
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! .hgignore
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java
+ test/script/basic/JDK-8006304.js
+ test/script/basic/JDK-8006304.js.EXPECTED

Changeset: 80447df16322
Author:    sundar
Date:      2013-01-16 17:58 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/80447df16322

8006412: Improve toString method of ScriptObjectMirror class
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: cd5b684ce7b2
Author:    sundar
Date:      2013-01-16 21:26 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/cd5b684ce7b2

8006424: Passing null or undefined to adapter class constructors results in NPE or ClassCastException
Reviewed-by: attila, hannesw, jlaskey

! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
+ test/script/basic/JDK-8006424.js

Changeset: 4acebfe9e504
Author:    jlaskey
Date:      2013-01-17 10:33 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/4acebfe9e504

8006517: PropertyHashMap.Element.equals() compares to Property
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/runtime/PropertyHashMap.java

Changeset: f8136c060914
Author:    sundar
Date:      2013-01-18 08:45 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f8136c060914

8006527: nashorn jsr223 engine does not work in sandbox
Reviewed-by: jlaskey, attila, lagergren

+ bin/nashornsecure
+ bin/nashornsecure.bat
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/resources/init.js
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
+ test/script/sandbox/engine.js
+ test/script/sandbox/engine.js.EXPECTED
+ test/script/sandbox/jsadapter.js

Changeset: 4361e8cd6a02
Author:    sundar
Date:      2013-01-18 17:55 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/4361e8cd6a02

8006562: findOwnMH in nashorn "objects" package should be cleaned up
Reviewed-by: jlaskey, lagergren

! make/project.properties
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeStrictArguments.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/objects/PrototypeObject.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java

Changeset: c887baec012a
Author:    sundar
Date:      2013-01-19 09:14 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c887baec012a

8006584: improve variable handling in NashornScriptEngine
Reviewed-by: jlaskey, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: a8966074d4e9
Author:    sundar
Date:      2013-01-19 22:35 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a8966074d4e9

8006557: JDK8/Lambda build clashes on Map.replace()
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/runtime/ScriptObject.java
! test/src/jdk/nashorn/internal/runtime/ContextTest.java

Changeset: 0cee498b330d
Author:    attila
Date:      2013-01-21 11:03 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/0cee498b330d

8006525: Give StaticClass objects their own linker
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java
+ src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java

Changeset: 8b3cc4ad1810
Author:    sundar
Date:      2013-01-21 21:17 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8b3cc4ad1810

8006635: Reduce access levels as much as possible
Reviewed-by: jlaskey, lagergren, attila

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
+ src/jdk/nashorn/internal/runtime/OptionsObject.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/tools/Shell.java
! test/src/jdk/nashorn/internal/access/BooleanAccessTest.java
! test/src/jdk/nashorn/internal/codegen/CompilerTest.java
! test/src/jdk/nashorn/internal/parser/ParserTest.java
! test/src/jdk/nashorn/internal/runtime/ContextTest.java
! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java
! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java

Changeset: 935dcec38e9a
Author:    hannesw
Date:      2013-01-22 14:14 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/935dcec38e9a

8006570: This-value for non-strict functions should be converted to object
Reviewed-by: jlaskey, lagergren, attila

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/linker/NashornGuardedInvocation.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
+ test/script/basic/JDK-8006570.js
+ test/script/basic/JDK-8006570.js.EXPECTED

Changeset: e43d1013d871
Author:    attila
Date:      2013-01-22 14:36 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e43d1013d871

8006677: Remove unused FunctionNode flags
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/parser/Parser.java

Changeset: e62dba3ce52b
Author:    sundar
Date:      2013-01-22 22:07 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e62dba3ce52b

8006678: Avoid too many Context.getGlobal() calls
Reviewed-by: lagergren, jlaskey

! make/project.properties
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ECMAErrors.java
! src/jdk/nashorn/internal/runtime/ErrorManager.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/ParserException.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/URIUtils.java
! src/jdk/nashorn/internal/runtime/Undefined.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java
! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java
! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
! src/jdk/nashorn/internal/runtime/linker/Lookup.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java

Changeset: 0dbcb7350595
Author:    sundar
Date:      2013-01-23 17:04 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/0dbcb7350595

8006736: nashorn script engine should support the usage multiple global objects with same engine instance
Reviewed-by: lagergren, jlaskey, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: d4a968ca8953
Author:    sundar
Date:      2013-01-24 16:21 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d4a968ca8953

8006575: Error in codegen for element access on primitive value
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8006575.js

Changeset: 3f528769aee1
Author:    sundar
Date:      2013-01-24 17:49 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3f528769aee1

8006755: Functions inside with statements dont get correct scope
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8006755.js

Changeset: edfa73d9fde7
Author:    hannesw
Date:      2013-01-24 14:55 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/edfa73d9fde7

8006408: Clean up and specialize NativeString
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/objects/NativeString.java
+ test/examples/string-micro.js

Changeset: f336aee22e85
Author:    jlaskey
Date:      2013-01-24 12:15 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f336aee22e85

8006852: Move tests from JIRA for prepopulated map failures
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

+ test/script/basic/JDK-8006852a.js
+ test/script/basic/JDK-8006852a.js.EXPECTED
+ test/script/basic/JDK-8006852b.js

Changeset: bff7087396d7
Author:    sundar
Date:      2013-01-24 22:38 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/bff7087396d7

8006857: ClassCastException when interface implementing function uses arguments object
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8006857.js
+ test/script/basic/JDK-8006857.js.EXPECTED

Changeset: f52d7294536f
Author:    hannesw
Date:      2013-01-25 17:35 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f52d7294536f

8006766: Array-like access to characters of a string is slow
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeJavaImporter.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java

Changeset: 8f7a86f82376
Author:    sundar
Date:      2013-01-28 18:10 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8f7a86f82376

8006983: Introduce a command line option to switch off syntactic extensions of nashorn
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/resources/Options.properties
+ test/script/basic/JDK-8006983.js
! test/script/basic/scripting.js
! test/script/basic/scripting.js.EXPECTED

Changeset: 265c46dbcf43
Author:    sundar
Date:      2013-01-28 21:29 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/265c46dbcf43

8007004: nashorn script engine should not use thread context class loader as script 'application loader'
Reviewed-by: attila, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java

Changeset: b6c69beebde6
Author:    jlaskey
Date:      2013-01-28 16:22 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b6c69beebde6

8006676: Integrate Nashorn into new build system
Reviewed-by: jlaskey
Contributed-by: james.laskey at oracle.com

! make/Makefile
+ makefiles/BuildNashorn.gmk
+ makefiles/Makefile

Changeset: 333748665588
Author:    sundar
Date:      2013-01-29 19:57 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/333748665588

8007091: Provide private API to pass application class loader for nashorn script engine
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 755404d7d189
Author:    jlaskey
Date:      2013-01-29 14:25 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/755404d7d189

8007094: Apply version to nashorn.jar manifest
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! makefiles/BuildNashorn.gmk

Changeset: 59970b70ebb5
Author:    lagergren
Date:      2013-01-30 12:26 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/59970b70ebb5

8007062: Split Lower up into Lower/Attr/FinalizeTypes. Integrate AccessSpecalizer into FinalizeTypes.
Summary: Lower suffered from being a "God class" trying to do everything at once.  As Nashorn code generation has grown, so has Lower. It does several post processing passes, tries to do several things at once even though all type information isn't in place, adjusting state afterwards and so on. It also performs control flow analysis, type attribution and constant folding, and  everything else code generation related before byte code emission. I have now separated the compilation process into Lower (create low level nodes from high level ones, copy code such as finally block inlining etc), Attr (assign types and symbols to all nodes - freeze slot and scope information) and FinalizeTypes (insert explicit casts, specialize invoke dynamic types for scope accesses). I've removed the kludgy AccessSpecializer, as this now integrates naturally with typing. Everything is now much easier to read and each module performs only one thing. I have added separate loggers for the separate ti
 ers. In the process I have also fixed: (1) problems with type coercion (see test/script/basic/typecoercion.js, basically our coercion was too late and our symbol inference was erroneous. This only manifested itself in very rare occasions where toNumber coercion has side effects, such as for example when valueOf is overridden)  (2) copying literal nodes (literal copy did not use the superclass copy, which made all the Node specific fields not to be copied  (3) erroneous literal tokenization (literals shouldn't always just inherit token information from whatever node that creates them) (4) splitter weighnodes - unary nodes were considered weightless  (4) removed the hateful and kludgy "VarNode.shouldAppend", which really isn't needed when we have an attribution phase that determines self reference symbols (the only thing it was used for) (5) duplicate line number issues in the parser (6) convert bug in CodeGenerator for intermediate results of scope accesses (see test/script/b
 asic/access-specializer.js) ... Several of these things just stopped being problems with the new architecture "can't happen anymore" and are not bug fixes per se. All tests run. No performance regressions exist that I've been able to measure. Some increases in performance were measured, but in the statistical margin of error (which is very wide as HotSpot currently has warmup issues with LambdaForms/invoke dynamic). Compile speed has not measurably increased.
Reviewed-by: jlaskey, attila

! docs/DEVELOPER_README
! src/jdk/nashorn/api/scripting/Formatter.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
- src/jdk/nashorn/internal/codegen/AccessSpecializer.java
+ src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Compiler.java
+ src/jdk/nashorn/internal/codegen/FinalizeTypes.java
+ src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/SharedScopeCall.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/debug/ASTWriter.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/parser/TokenType.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/OptionsObject.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java
! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java
! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/tools/Shell.java
+ test/script/basic/access-specializer.js
! test/script/basic/compile-octane.js.EXPECTED
! test/script/basic/run-octane.js
+ test/script/basic/typecoerce.js
+ test/script/basic/typecoerce.js.EXPECTED

Changeset: ca6d5e4b8170
Author:    sundar
Date:      2013-01-30 17:52 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ca6d5e4b8170

8007132: Java objects returned from constructor functions are lost
Reviewed-by: hannesw, lagergren, attila

! src/jdk/nashorn/internal/runtime/ScriptFunction.java
+ test/script/basic/JDK-8007132.js

Changeset: 9f913c1843c8
Author:    hannesw
Date:      2013-01-30 14:57 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9f913c1843c8

8007109: Regression: String(ConsString) does not flatten argument to String
Reviewed-by: sundar, lagergren

! src/jdk/nashorn/internal/objects/NativeString.java
+ test/script/basic/consstring.js
+ test/src/jdk/nashorn/internal/test/models/StringArgs.java

Changeset: c04f54d5b672
Author:    sundar
Date:      2013-01-30 21:15 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c04f54d5b672

8007140: Java.extend crashes when attempting to extend java.lang.Object
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! test/script/basic/JDK-8006424.js
+ test/script/basic/JDK-8007140.js

Changeset: 9c1e7ae975db
Author:    sundar
Date:      2013-01-31 20:07 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9c1e7ae975db

8007286: Add JavaAdapter and importPackage to compatibility script
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/api/scripting/NashornException.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/resources/engine.js
! src/jdk/nashorn/internal/parser/TokenLookup.java
! src/jdk/nashorn/internal/parser/TokenType.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! src/jdk/nashorn/internal/runtime/PropertyHashMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ test/script/basic/importpackage.js
+ test/script/basic/javaadapter.js

Changeset: f7825c1a11d3
Author:    attila
Date:      2013-01-31 18:34 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f7825c1a11d3

8006529: Methods always get callee - it should be conditional
Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145.
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java
! src/jdk/nashorn/internal/codegen/types/Type.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/parser/Parser.java
+ src/jdk/nashorn/internal/runtime/ArgumentSetter.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ test/script/basic/JDK-8006529-b.js
+ test/script/basic/JDK-8006529-b.js.EXPECTED
+ test/script/basic/JDK-8006529.js
+ test/src/jdk/nashorn/internal/codegen/CompilerAccess.java

Changeset: 697f700d90c0
Author:    hannesw
Date:      2013-02-01 02:24 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/697f700d90c0

8007060: Primitive wrap filter throws ClassCastException in test262parallel
Reviewed-by: sundar, jlaskey, lagergren

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
- src/jdk/nashorn/internal/runtime/linker/NashornGuardedInvocation.java
! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
+ test/script/basic/JDK-8007060.js
+ test/script/basic/JDK-8007060.js.EXPECTED

Changeset: a704700470fb
Author:    jlaskey
Date:      2013-02-04 08:13 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a704700470fb

8007455: Extraneous $(ECHO) in make/Makefile
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! make/Makefile

Changeset: bb86bf840f9f
Author:    attila
Date:      2013-02-04 15:59 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/bb86bf840f9f

8007460: var assignment to a parameter in a varargs method causes compilation error
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
+ test/script/basic/JDK-8007460.js
+ test/script/basic/JDK-8007460.js.EXPECTED

Changeset: bee7c8a45a04
Author:    lagergren
Date:      2013-02-04 16:20 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/bee7c8a45a04

8007215: Varargs broken for the case of passing more than the arg limit arguments.
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/api/scripting/NashornException.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java
! src/jdk/nashorn/internal/codegen/SharedScopeCall.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8007215.js
+ test/script/basic/JDK-8007215.js.EXPECTED

Changeset: 6f58c28c4faa
Author:    jlaskey
Date:      2013-02-04 14:48 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6f58c28c4faa

8006191: `cmd` -> exec("cmd") in script mode
Reviewed-by: sundar, lagergren, hannesw
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/parser/TokenType.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/OptionsObject.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
+ test/script/basic/JDK-8006191.js
+ test/script/basic/JDK-8006191.js.EXPECTED

Changeset: 5c2ed5d89524
Author:    sundar
Date:      2013-02-05 09:11 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5c2ed5d89524

8007452: add scripting programmers doc changes for nashorn
Reviewed-by: jlaskey, hannesw

+ docs/JavaScriptingProgrammersGuide.html
+ docs/source/EvalFile.java
+ docs/source/EvalScript.java
+ docs/source/InvokeScriptFunction.java
+ docs/source/InvokeScriptMethod.java
+ docs/source/MultiScopes.java
+ docs/source/RunnableImpl.java
+ docs/source/RunnableImplObject.java
+ docs/source/ScriptVars.java
+ docs/source/importpackageclass.js
+ docs/source/javaarray.js
+ docs/source/javaextend.js
+ docs/source/javaimporter.js
+ docs/source/javatypes.js
+ docs/source/overload.js
+ docs/source/runnable.js
+ docs/source/samfunc.js
+ docs/source/test.js
! src/jdk/nashorn/internal/objects/NativeJava.java

Changeset: c48e8a28da90
Author:    sundar
Date:      2013-02-05 18:44 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c48e8a28da90

8007521: $ENV should be undefined when security manager is present
Reviewed-by: hannesw, jlaskey

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
- test/script/basic/JDK-8006191.js
- test/script/basic/JDK-8006191.js.EXPECTED
+ test/script/currently-failing/JDK-8006191.js
+ test/script/currently-failing/JDK-8006191.js.EXPECTED
+ test/script/sandbox/env.js
+ test/script/sandbox/exec.js

Changeset: 819b5485949d
Author:    sundar
Date:      2013-02-05 21:00 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/819b5485949d

8007522: IllegalStateException thrown from String.prototype.search function
Reviewed-by: jlaskey

! src/jdk/nashorn/internal/objects/NativeRegExp.java
+ test/script/basic/JDK-8007522.js

Changeset: f05d4dae30f7
Author:    sundar
Date:      2013-02-05 22:07 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f05d4dae30f7

8007523: VerifyError on script that uses regular expression literals with ternary operator
Reviewed-by: lagergren

! src/jdk/nashorn/internal/ir/LiteralNode.java
! test/script/basic/JDK-8007522.js
+ test/script/basic/JDK-8007523.js

Changeset: f6fae6de6f4f
Author:    hannesw
Date:      2013-02-06 10:31 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f6fae6de6f4f

8007273: Creation of ScriptFunctions can be refactored
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java
! src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
+ src/jdk/nashorn/internal/runtime/ScriptFunctionData.java

Changeset: fcf541418304
Author:    sundar
Date:      2013-02-06 17:56 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/fcf541418304

8007619: Add support for deprecated properties of RegExp constructor
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8007619.js
+ test/script/basic/JDK-8007619.js.EXPECTED

Changeset: ec4d59c9b8d2
Author:    jlaskey
Date:      2013-02-06 08:42 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ec4d59c9b8d2

8007545: jjs input evalinput need to be NOT_ENUMERABLE
Reviewed-by: sundar, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/tools/resources/shell.js

Changeset: 2ca25bf25d0c
Author:    jlaskey
Date:      2013-02-06 11:57 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2ca25bf25d0c

8007629: Remove extraneous quit from shell.js
Reviewed-by: sundar, hannesw
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/api/scripting/resources/init.js
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/tools/resources/shell.js

Changeset: 02f810c26ff9
Author:    jlaskey
Date:      2013-02-06 12:51 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/02f810c26ff9

8007643: Add testing for quit and exit
Reviewed-by: sundar
Contributed-by: james.laskey at oracle.com

! test/script/sandbox/exit.js
! test/script/sandbox/exit.js.EXPECTED

Changeset: d7e83be6e7aa
Author:    sundar
Date:      2013-02-07 17:17 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d7e83be6e7aa

8007715: Make sure that not all tests run with AllPermission
Reviewed-by: lagergren, attila

! make/build.xml
! make/project.properties
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
+ test/script/README
- test/script/basic/JDK-8006424.js
- test/script/basic/JDK-8006529.js
- test/script/basic/NASHORN-638.js
- test/script/basic/NASHORN-638.js.EXPECTED
- test/script/basic/NASHORN-653.js
! test/script/basic/NASHORN-758.js
- test/script/basic/getenv.js
- test/script/basic/getenv.js.EXPECTED
! test/script/basic/javaexceptions.js
! test/script/basic/newexpr.js
+ test/script/sandbox/interfaceimpl.js
+ test/script/sandbox/loadcompat.js
+ test/script/trusted/JDK-8006424.js
+ test/script/trusted/JDK-8006529.js
+ test/script/trusted/NASHORN-638.js
+ test/script/trusted/NASHORN-638.js.EXPECTED
+ test/script/trusted/NASHORN-653.js
+ test/script/trusted/README
+ test/script/trusted/getenv.js
+ test/script/trusted/getenv.js.EXPECTED
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java
! test/src/jdk/nashorn/internal/runtime/ContextTest.java

Changeset: bca3a64a4a82
Author:    hannesw
Date:      2013-02-07 14:58 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/bca3a64a4a82

8007627: Support @Getter annotation on constructor
Reviewed-by: attila, lagergren

! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java

Changeset: d5130a5803d1
Author:    hannesw
Date:      2013-02-07 15:33 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d5130a5803d1

8007718: Make static RegExp properties fully compatible to other engines
Reviewed-by: lagergren, sundar

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/runtime/RegExpMatch.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
+ test/script/basic/JDK-8007718.js
+ test/script/basic/JDK-8007718.js.EXPECTED

Changeset: 8742be332c8a
Author:    jlaskey
Date:      2013-02-08 09:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8742be332c8a

8006222: Move slot from SpillProperty to Property
Reviewed-by: hannesw, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/objects/MapCreator.java
! src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/SpillProperty.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
! src/jdk/nashorn/internal/runtime/linker/Lookup.java

Changeset: 5ead5333fa59
Author:    attila
Date:      2013-02-09 16:58 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5ead5333fa59

8006943: Fix order of function method arguments to be (callee, thisObject)
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/types/ObjectType.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java

Changeset: abea4ba28901
Author:    sundar
Date:      2013-02-11 21:26 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/abea4ba28901

8007915: Nashorn IR, codegen, parser packages and Context instance should be inaccessible to user code
Reviewed-by: lagergren, jlaskey, attila

! bin/jjssecure
! bin/jjssecure.bat
! bin/nashornsecure
! bin/nashornsecure.bat
! make/Makefile
! make/build.xml
+ make/java.security.override
! make/project.properties
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java
! src/jdk/nashorn/internal/objects/NativeDebug.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeEvalError.java
! src/jdk/nashorn/internal/objects/NativeFloat32Array.java
! src/jdk/nashorn/internal/objects/NativeFloat64Array.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeInt16Array.java
! src/jdk/nashorn/internal/objects/NativeInt32Array.java
! src/jdk/nashorn/internal/objects/NativeInt8Array.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/objects/NativeJavaImporter.java
! src/jdk/nashorn/internal/objects/NativeRangeError.java
! src/jdk/nashorn/internal/objects/NativeReferenceError.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/objects/NativeSyntaxError.java
! src/jdk/nashorn/internal/objects/NativeTypeError.java
! src/jdk/nashorn/internal/objects/NativeURIError.java
! src/jdk/nashorn/internal/objects/NativeUint16Array.java
! src/jdk/nashorn/internal/objects/NativeUint32Array.java
! src/jdk/nashorn/internal/objects/NativeUint8Array.java
! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Lexer.java
- src/jdk/nashorn/internal/parser/RegExp.java
- src/jdk/nashorn/internal/parser/RegExpScanner.java
! src/jdk/nashorn/internal/runtime/ArgumentSetter.java
! src/jdk/nashorn/internal/runtime/BitVector.java
! src/jdk/nashorn/internal/runtime/ConsString.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/Debug.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/GlobalFunctions.java
+ src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/Logging.java
! src/jdk/nashorn/internal/runtime/NashornLoader.java
! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
+ src/jdk/nashorn/internal/runtime/RegExp.java
+ src/jdk/nashorn/internal/runtime/RegExpScanner.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptLoader.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/arrays/EmptyArrayLikeIterator.java
! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/resources/parser.js
+ test/script/sandbox/nashorninternals.js
! test/script/trusted/JDK-8006529.js
+ test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java
+ test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java
+ test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java
+ test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java
+ test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java
+ test/src/jdk/nashorn/api/javaaccess/Person.java
+ test/src/jdk/nashorn/api/javaaccess/SharedObject.java
+ test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java
- test/src/jdk/nashorn/internal/access/BooleanAccessTest.java
- test/src/jdk/nashorn/internal/access/MethodAccessTest.java
- test/src/jdk/nashorn/internal/access/NumberAccessTest.java
- test/src/jdk/nashorn/internal/access/NumberBoxingTest.java
- test/src/jdk/nashorn/internal/access/ObjectAccessTest.java
- test/src/jdk/nashorn/internal/access/Person.java
- test/src/jdk/nashorn/internal/access/SharedObject.java
- test/src/jdk/nashorn/internal/access/StringAccessTest.java
- test/src/jdk/nashorn/internal/codegen/CompilerAccess.java

Changeset: 774a0f349cc0
Author:    hannesw
Date:      2013-02-12 13:55 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/774a0f349cc0

8007956: Wrong or obsolete system properties in docs/DEVELOPER_README
Reviewed-by: attila, jlaskey

! docs/DEVELOPER_README

Changeset: d50e1752f59b
Author:    attila
Date:      2013-02-12 12:47 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d50e1752f59b

8007900: Function binding is inefficient
Reviewed-by: jlaskey, lagergren

+ src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeStrictArguments.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/ArgumentSetter.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ src/jdk/nashorn/internal/runtime/SpecializedMethodChooser.java
+ test/script/basic/funcbind2.js
+ test/script/basic/funcbind2.js.EXPECTED
+ test/script/basic/funcbind3.js
+ test/script/basic/funcbind3.js.EXPECTED

Changeset: a3dc1b180ce7
Author:    hannesw
Date:      2013-02-13 13:30 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a3dc1b180ce7

8008096: TokenStream buffer should grow exponentially
Reviewed-by: attila, lagergren, sundar

! src/jdk/nashorn/internal/parser/TokenStream.java

Changeset: 38c44687e4bd
Author:    sundar
Date:      2013-02-13 19:59 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/38c44687e4bd

8008103: Source object should maintain URL of the script source as a private field
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/Source.java
! src/jdk/nashorn/tools/Shell.java
! test/src/jdk/nashorn/internal/codegen/CompilerTest.java
! test/src/jdk/nashorn/internal/runtime/ContextTest.java
! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java

Changeset: 222b9f32b674
Author:    sundar
Date:      2013-02-14 09:14 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/222b9f32b674

8008193: test262 tests should be run with security manager enabled
Reviewed-by: jlaskey

! make/build.xml

Changeset: 8c72a2bec1be
Author:    sundar
Date:      2013-02-14 14:16 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8c72a2bec1be

8008197: Cross script engine function calls do not work as expected
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
+ test/script/basic/JDK-8008197.js
! test/script/basic/jquery.js

Changeset: 43e32b36153c
Author:    lagergren
Date:      2013-02-14 13:01 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/43e32b36153c

8008199: Lazy compilation and trampoline implementation
Summary: The code pipeline now supports lazy compilation, which can be used to only compile certain FunctionNodes and leave others be, saving startup time. When these uncompiled nodes are hit, a trampoline will force them to be recompiled. This can also be used to specialize compilation fixing parameter types and return types to a callsite specific compilation. This will give performance.
Reviewed-by: attila, sundar

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/CompileUnit.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/ConstantData.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/SharedScopeCall.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
- src/jdk/nashorn/internal/codegen/objects/FunctionObjectCreator.java
! src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/CodeInstaller.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/DebugLogger.java
! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/tools/Shell.java
! test/script/trusted/JDK-8006529.js
! test/src/jdk/nashorn/internal/parser/ParserTest.java
! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java

Changeset: 5a820fb11814
Author:    attila
Date:      2013-02-14 13:22 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5a820fb11814

8008085: Integrate Dynalink source code into Nashorn codebase
Reviewed-by: jlaskey, lagergren, sundar

! THIRD_PARTY_README
! make/build.xml
! make/nbproject/project.xml
! make/project.properties
+ src/jdk/internal/dynalink/CallSiteDescriptor.java
+ src/jdk/internal/dynalink/ChainedCallSite.java
+ src/jdk/internal/dynalink/DefaultBootstrapper.java
+ src/jdk/internal/dynalink/DynamicLinker.java
+ src/jdk/internal/dynalink/DynamicLinkerFactory.java
+ src/jdk/internal/dynalink/MonomorphicCallSite.java
+ src/jdk/internal/dynalink/NoSuchDynamicMethodException.java
+ src/jdk/internal/dynalink/RelinkableCallSite.java
+ src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
+ src/jdk/internal/dynalink/beans/AccessibleMembersLookup.java
+ src/jdk/internal/dynalink/beans/ApplicableOverloadedMethods.java
+ src/jdk/internal/dynalink/beans/BeanIntrospector.java
+ src/jdk/internal/dynalink/beans/BeanLinker.java
+ src/jdk/internal/dynalink/beans/BeansLinker.java
+ src/jdk/internal/dynalink/beans/CheckRestrictedPackage.java
+ src/jdk/internal/dynalink/beans/CheckRestrictedPackageInternal.java
+ src/jdk/internal/dynalink/beans/ClassLinker.java
+ src/jdk/internal/dynalink/beans/ClassString.java
+ src/jdk/internal/dynalink/beans/DynamicMethod.java
+ src/jdk/internal/dynalink/beans/DynamicMethodLinker.java
+ src/jdk/internal/dynalink/beans/FacetIntrospector.java
+ src/jdk/internal/dynalink/beans/GuardedInvocationComponent.java
+ src/jdk/internal/dynalink/beans/MaximallySpecific.java
+ src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java
+ src/jdk/internal/dynalink/beans/OverloadedMethod.java
+ src/jdk/internal/dynalink/beans/RestrictedPackageTester.java
+ src/jdk/internal/dynalink/beans/SimpleDynamicMethod.java
+ src/jdk/internal/dynalink/beans/StaticClass.java
+ src/jdk/internal/dynalink/beans/StaticClassIntrospector.java
+ src/jdk/internal/dynalink/beans/StaticClassLinker.java
+ src/jdk/internal/dynalink/beans/messages.properties
+ src/jdk/internal/dynalink/beans/package.html
+ src/jdk/internal/dynalink/linker/ConversionComparator.java
+ src/jdk/internal/dynalink/linker/GuardedInvocation.java
+ src/jdk/internal/dynalink/linker/GuardingDynamicLinker.java
+ src/jdk/internal/dynalink/linker/GuardingTypeConverterFactory.java
+ src/jdk/internal/dynalink/linker/LinkRequest.java
+ src/jdk/internal/dynalink/linker/LinkerServices.java
+ src/jdk/internal/dynalink/linker/TypeBasedGuardingDynamicLinker.java
+ src/jdk/internal/dynalink/linker/package.html
+ src/jdk/internal/dynalink/package.html
+ src/jdk/internal/dynalink/support/AbstractCallSiteDescriptor.java
+ src/jdk/internal/dynalink/support/AbstractRelinkableCallSite.java
+ src/jdk/internal/dynalink/support/AutoDiscovery.java
+ src/jdk/internal/dynalink/support/Backport.java
+ src/jdk/internal/dynalink/support/BottomGuardingDynamicLinker.java
+ src/jdk/internal/dynalink/support/CallSiteDescriptorFactory.java
+ src/jdk/internal/dynalink/support/ClassMap.java
+ src/jdk/internal/dynalink/support/CompositeGuardingDynamicLinker.java
+ src/jdk/internal/dynalink/support/CompositeTypeBasedGuardingDynamicLinker.java
+ src/jdk/internal/dynalink/support/DefaultCallSiteDescriptor.java
+ src/jdk/internal/dynalink/support/Guards.java
+ src/jdk/internal/dynalink/support/LinkRequestImpl.java
+ src/jdk/internal/dynalink/support/LinkerServicesImpl.java
+ src/jdk/internal/dynalink/support/Lookup.java
+ src/jdk/internal/dynalink/support/LookupCallSiteDescriptor.java
+ src/jdk/internal/dynalink/support/NameCodec.java
+ src/jdk/internal/dynalink/support/NamedDynCallSiteDescriptor.java
+ src/jdk/internal/dynalink/support/RuntimeContextLinkRequestImpl.java
+ src/jdk/internal/dynalink/support/TypeConverterFactory.java
+ src/jdk/internal/dynalink/support/TypeUtilities.java
+ src/jdk/internal/dynalink/support/UnnamedDynCallSiteDescriptor.java
+ src/jdk/internal/dynalink/support/messages.properties
+ src/jdk/internal/dynalink/support/package.html
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/objects/NativeJavaImporter.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/runtime/GlobalObject.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptLoader.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java
! src/jdk/nashorn/internal/runtime/Undefined.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java
! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! test/script/sandbox/nashorninternals.js
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java
! test/src/jdk/nashorn/internal/runtime/ContextTest.java
! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java

Changeset: d086c3eead6b
Author:    lagergren
Date:      2013-02-14 13:52 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d086c3eead6b

8008206: The allInteger case for SwitchNode generation in CodeGenerator assumes integer LITERALS only.
Reviewed-by: sundar, jlaskey

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ test/script/basic/JDK-8008206.js
+ test/script/basic/JDK-8008206.js.EXPECTED

Changeset: 3df0a0d62d60
Author:    attila
Date:      2013-02-14 13:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3df0a0d62d60

8007990: No access to interface methods on a restricted class
Reviewed-by: jlaskey, lagergren, sundar

! make/build.xml
+ test/script/basic/JDK-8007990.js
+ test/script/basic/JDK-8007990.js.EXPECTED

Changeset: d1ce4e09e4ba
Author:    hannesw
Date:      2013-02-14 14:07 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d1ce4e09e4ba

8008198: java.lang.AssertionError: Invalid break target class jdk.nashorn.internal.ir.TryNode
Reviewed-by: attila, jlaskey

! src/jdk/nashorn/internal/ir/LabelNode.java
! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8008198.js
+ test/script/basic/JDK-8008198.js.EXPECTED

Changeset: d41d7cf9ab8b
Author:    jlaskey
Date:      2013-02-14 11:32 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d41d7cf9ab8b

8008231: Fix build system to accommodate integration of dynalink
Reviewed-by: jlaskey
Contributed-by: james.laskey at oracle.com

! makefiles/BuildNashorn.gmk

Changeset: 36065e5ea3d1
Author:    hannesw
Date:      2013-02-15 09:18 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/36065e5ea3d1

8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/parser/Parser.java
+ test/script/basic/JDK-8008215.js
+ test/script/basic/JDK-8008215.js.EXPECTED

Changeset: e478708faa22
Author:    lagergren
Date:      2013-02-15 09:44 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e478708faa22

8008239: Unpublicized parts of the code generator package that were only package internal.
Reviewed-by: hannesw, attila

! src/jdk/nashorn/internal/codegen/BranchOptimizer.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
+ src/jdk/nashorn/internal/codegen/Condition.java
+ src/jdk/nashorn/internal/codegen/FieldObjectCreator.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
+ src/jdk/nashorn/internal/codegen/Label.java
+ src/jdk/nashorn/internal/codegen/MapCreator.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
+ src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
+ src/jdk/nashorn/internal/codegen/ObjectCreator.java
! src/jdk/nashorn/internal/codegen/SharedScopeCall.java
! src/jdk/nashorn/internal/codegen/Splitter.java
- src/jdk/nashorn/internal/codegen/objects/FieldObjectCreator.java
- src/jdk/nashorn/internal/codegen/objects/MapCreator.java
- src/jdk/nashorn/internal/codegen/objects/ObjectClassGenerator.java
- src/jdk/nashorn/internal/codegen/objects/ObjectCreator.java
- src/jdk/nashorn/internal/codegen/objects/ObjectMapCreator.java
! src/jdk/nashorn/internal/codegen/types/BooleanType.java
! src/jdk/nashorn/internal/codegen/types/IntType.java
! src/jdk/nashorn/internal/codegen/types/LongType.java
! src/jdk/nashorn/internal/codegen/types/NumberType.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/BreakableNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
! src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/Property.java
! src/jdk/nashorn/internal/runtime/Scope.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/StructureLoader.java

Changeset: 757a49aaad02
Author:    sundar
Date:      2013-02-15 18:30 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/757a49aaad02

8008291: Add more tests for better coverage of objects, scripting and parser packages
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Scanner.java
! src/jdk/nashorn/internal/runtime/BitVector.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/QuotedStringTokenizer.java
! src/jdk/nashorn/internal/runtime/RegExpScanner.java
! src/jdk/nashorn/internal/runtime/Source.java
! src/jdk/nashorn/tools/Shell.java
! test/script/basic/NASHORN-401.js
! test/script/basic/NASHORN-401.js.EXPECTED
+ test/script/basic/assign_builtin_func_props.js
+ test/script/basic/debugger.js
+ test/script/basic/yield.js
! test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java
! test/src/jdk/nashorn/api/scripting/Window.java
! test/src/jdk/nashorn/internal/parser/ParserTest.java

Changeset: 5851c5dac260
Author:    sundar
Date:      2013-02-15 20:40 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5851c5dac260

8008298: Add tests to cover specialized versions of Math functions.
Reviewed-by: jlaskey, lagergren

+ test/script/basic/JDK-8008298.js

Changeset: d5f74bd2dc20
Author:    sundar
Date:      2013-02-18 14:41 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d5f74bd2dc20

8008305: ScriptEngine.eval should offer the ability to provide a codebase
Reviewed-by: lagergren, hannesw, attila

! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
+ src/jdk/nashorn/api/scripting/URLReader.java
+ test/script/trusted/JDK-8008305.js
+ test/script/trusted/JDK-8008305_subtest.js
+ test/script/trusted/urlreader.js

Changeset: 3245e174fe3a
Author:    hannesw
Date:      2013-02-18 10:36 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3245e174fe3a

8008351: Avoid using String.replace(String, String) in codegen
Reviewed-by: sundar, attila

! src/jdk/nashorn/internal/codegen/Condition.java
! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java

Changeset: f8221ce53c2e
Author:    attila
Date:      2013-02-18 16:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f8221ce53c2e

8008371: Fix Dynalink compiler warnings and whitespace
Reviewed-by: jlaskey, sundar

! src/jdk/internal/dynalink/CallSiteDescriptor.java
! src/jdk/internal/dynalink/ChainedCallSite.java
! src/jdk/internal/dynalink/DefaultBootstrapper.java
! src/jdk/internal/dynalink/DynamicLinker.java
! src/jdk/internal/dynalink/DynamicLinkerFactory.java
! src/jdk/internal/dynalink/MonomorphicCallSite.java
! src/jdk/internal/dynalink/NoSuchDynamicMethodException.java
! src/jdk/internal/dynalink/RelinkableCallSite.java
! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/beans/ApplicableOverloadedMethods.java
! src/jdk/internal/dynalink/beans/BeanLinker.java
! src/jdk/internal/dynalink/beans/BeansLinker.java
! src/jdk/internal/dynalink/beans/CheckRestrictedPackageInternal.java
! src/jdk/internal/dynalink/beans/ClassLinker.java
! src/jdk/internal/dynalink/beans/ClassString.java
! src/jdk/internal/dynalink/beans/DynamicMethod.java
! src/jdk/internal/dynalink/beans/DynamicMethodLinker.java
! src/jdk/internal/dynalink/beans/FacetIntrospector.java
! src/jdk/internal/dynalink/beans/GuardedInvocationComponent.java
! src/jdk/internal/dynalink/beans/MaximallySpecific.java
! src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java
! src/jdk/internal/dynalink/beans/OverloadedMethod.java
! src/jdk/internal/dynalink/beans/SimpleDynamicMethod.java
! src/jdk/internal/dynalink/beans/StaticClass.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
! src/jdk/internal/dynalink/linker/GuardedInvocation.java
! src/jdk/internal/dynalink/linker/GuardingDynamicLinker.java
! src/jdk/internal/dynalink/linker/GuardingTypeConverterFactory.java
! src/jdk/internal/dynalink/linker/LinkRequest.java
! src/jdk/internal/dynalink/linker/LinkerServices.java
! src/jdk/internal/dynalink/support/AbstractCallSiteDescriptor.java
! src/jdk/internal/dynalink/support/AbstractRelinkableCallSite.java
! src/jdk/internal/dynalink/support/AutoDiscovery.java
! src/jdk/internal/dynalink/support/BottomGuardingDynamicLinker.java
! src/jdk/internal/dynalink/support/CallSiteDescriptorFactory.java
! src/jdk/internal/dynalink/support/CompositeGuardingDynamicLinker.java
! src/jdk/internal/dynalink/support/CompositeTypeBasedGuardingDynamicLinker.java
! src/jdk/internal/dynalink/support/DefaultCallSiteDescriptor.java
! src/jdk/internal/dynalink/support/Guards.java
! src/jdk/internal/dynalink/support/LinkRequestImpl.java
! src/jdk/internal/dynalink/support/LinkerServicesImpl.java
! src/jdk/internal/dynalink/support/Lookup.java
! src/jdk/internal/dynalink/support/LookupCallSiteDescriptor.java
! src/jdk/internal/dynalink/support/NamedDynCallSiteDescriptor.java
! src/jdk/internal/dynalink/support/RuntimeContextLinkRequestImpl.java
! src/jdk/internal/dynalink/support/TypeConverterFactory.java
! src/jdk/internal/dynalink/support/TypeUtilities.java
! src/jdk/internal/dynalink/support/UnnamedDynCallSiteDescriptor.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/Context.java

Changeset: 4738de1bd57f
Author:    sundar
Date:      2013-02-18 20:41 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/4738de1bd57f

8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker
Reviewed-by: lagergren, jlaskey, hannesw

! src/jdk/internal/dynalink/beans/BeansLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
+ test/script/basic/javamethodcallerrors.js
+ test/script/basic/jsobject.js

Changeset: b6798a83dbd4
Author:    jlaskey
Date:      2013-02-19 09:46 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b6798a83dbd4

8008420: Tweaks to make all NEWBUILD=false round 2
Reviewed-by: jjh
Contributed-by: james.laskey at oracle.com

! make/Makefile

Changeset: b228e3cdbfc3
Author:    jlaskey
Date:      2013-02-19 09:47 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b228e3cdbfc3

Merge


Changeset: b632446ba138
Author:    sundar
Date:      2013-02-19 20:33 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b632446ba138

8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter
Reviewed-by: jlaskey, attila

! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
+ test/script/basic/JDK-8008448.js

Changeset: 58eea0e8f369
Author:    sundar
Date:      2013-02-20 17:08 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/58eea0e8f369

8008207: Make constants array and source fields private
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/Compiler.java

Changeset: 671852e35ced
Author:    lagergren
Date:      2013-02-20 16:43 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/671852e35ced

8008166: URL handling was broken on windows, causing "load" to malfunction
Reviewed-by: attila, jlaskey
Contributed-by: klara.ward at oracle.com

! make/build.xml
! src/jdk/nashorn/internal/runtime/Context.java

Changeset: a971adb68f38
Author:    lagergren
Date:      2013-02-21 16:57 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a971adb68f38

8008648: Lazy JIT scope and callee semantics bugfixes. Broke out wallclock timer.
Reviewed-by: attila, hannesw

! src/jdk/internal/dynalink/beans/BeansLinker.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
+ src/jdk/nashorn/internal/codegen/CompilationException.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/NashornLoader.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
+ src/jdk/nashorn/internal/runtime/Timing.java
! test/script/trusted/JDK-8006529.js

Changeset: ae1c9716685b
Author:    jlaskey
Date:      2013-02-21 15:24 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ae1c9716685b

8008447: Tweaks to make all NEWBUILD=false round 3
Reviewed-by: jjh, sundar
Contributed-by: james.laskey at oracle.com

! make/Makefile

Changeset: 678da59a29b3
Author:    lagergren
Date:      2013-02-22 08:57 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/678da59a29b3

8008554: load was broken for URLs
Reviewed-by: attila, sundar

! src/jdk/nashorn/internal/runtime/Context.java
+ test/script/basic/JDK-8008554.js

Changeset: 230a711062c1
Author:    lagergren
Date:      2013-02-22 11:27 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/230a711062c1

8008575: Re-integrate code coverage
Reviewed-by: attila, hannesw
Contributed-by: eugene.drobitko at oracle.com, ilya.dergalin at oracle.com

! make/build.xml
+ make/code_coverage.xml
! make/project.properties

Changeset: 267cc4c85160
Author:    lagergren
Date:      2013-02-22 12:22 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/267cc4c85160

8007002: Replace implicit exception throwing methods with explicit throws - simplify control flow and remove useless code
Reviewed-by: attila, hannesw

! src/jdk/nashorn/api/scripting/NashornException.java
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
! src/jdk/nashorn/api/scripting/URLReader.java
! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeArray.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeFunction.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeJSON.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeObject.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
! src/jdk/nashorn/internal/parser/Lexer.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ECMAErrors.java
! src/jdk/nashorn/internal/runtime/ECMAException.java
! src/jdk/nashorn/internal/runtime/ErrorManager.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
! src/jdk/nashorn/internal/runtime/JSType.java
! src/jdk/nashorn/internal/runtime/ParserException.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/URIUtils.java
! src/jdk/nashorn/internal/runtime/Undefined.java
! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java
! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java
! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
! src/jdk/nashorn/internal/runtime/linker/Lookup.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java

Changeset: 3f0ff84aaf36
Author:    jlaskey
Date:      2013-02-22 10:39 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3f0ff84aaf36

8008721: Tweaks to make all NEWBUILD=false round 4
Reviewed-by: jjh
Contributed-by: james.laskey at oracle.com

! makefiles/BuildNashorn.gmk

Changeset: 508da3c7fc3a
Author:    hannesw
Date:      2013-02-22 16:31 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/508da3c7fc3a

8008093: Make RegExp engine pluggable
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeRegExp.java
! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/parser/AbstractParser.java
- src/jdk/nashorn/internal/runtime/RegExp.java
- src/jdk/nashorn/internal/runtime/RegExpMatch.java
- src/jdk/nashorn/internal/runtime/RegExpScanner.java
+ src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java
+ src/jdk/nashorn/internal/runtime/regexp/RegExp.java
+ src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java
+ src/jdk/nashorn/internal/runtime/regexp/RegExpMatcher.java
+ src/jdk/nashorn/internal/runtime/regexp/RegExpResult.java
+ src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java

Changeset: e42fd1640ff9
Author:    hannesw
Date:      2013-02-22 17:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e42fd1640ff9

8006028: Integrate Joni regexp engine with Nashorn
Reviewed-by: lagergren, attila

! THIRD_PARTY_README
! docs/DEVELOPER_README
+ src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java
! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ApplyCaseFold.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ApplyCaseFoldArg.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/BitSet.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/BitStatus.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Compiler.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Config.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Matcher.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/MatcherFactory.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/MinMaxLen.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/NodeOptInfo.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/OptAnchorInfo.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/OptEnvironment.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/OptExactInfo.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/OptMapInfo.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Option.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Region.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/SearchAlgorithm.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/StackEntry.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/StackMachine.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Syntax.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Token.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/WarnCallback.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/Warnings.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/AnchorNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/AnyCharNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/BackRefNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/ConsAltNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/EncloseNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/Node.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/ast/StringNode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/AnchorType.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/Arguments.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/AsmConstants.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/CCSTATE.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/CCVALTYPE.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/EncloseType.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/MetaChar.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/NodeStatus.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/NodeType.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPSize.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/RegexState.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/StackPopLevel.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/StackType.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/StringType.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/SyntaxProperties.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/TargetInfo.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/TokenType.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/constants/Traverse.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/encoding/CharacterType.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/encoding/IntHolder.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/encoding/ObjPtr.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/exception/ErrorMessages.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/exception/InternalException.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/exception/JOniException.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/exception/SyntaxException.java
+ src/jdk/nashorn/internal/runtime/regexp/joni/exception/ValueException.java

Changeset: 7f5b7c6859d7
Author:    sundar
Date:      2013-02-22 22:39 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/7f5b7c6859d7

8008729: Make sure that we can run basic jsr223 tests using jtreg
Reviewed-by: jlaskey, hannesw, lagergren

+ test/TEST.ROOT
! test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java
+ test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 5452f82eb2ce
Author:    jlaskey
Date:      2013-02-22 23:33 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5452f82eb2ce

8008776: Revise BuildNashorn.gmk for changes in new build system
Reviewed-by: jjh
Contributed-by: james.laskey at oracle.com

! makefiles/BuildNashorn.gmk

Changeset: 927fba6785b0
Author:    sundar
Date:      2013-02-25 16:58 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/927fba6785b0

8008731: Separate configuration environment (options, error/output writer etc.) from Context
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeDate.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/CodeInstaller.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/JSONFunctions.java
- src/jdk/nashorn/internal/runtime/OptionsObject.java
+ src/jdk/nashorn/internal/runtime/ScriptEnvironment.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/tools/Shell.java
! test/script/trusted/JDK-8006529.js
! test/src/jdk/nashorn/internal/parser/ParserTest.java
! test/src/jdk/nashorn/internal/test/framework/SharedContextEvaluator.java

Changeset: 5610ac25d8ff
Author:    sundar
Date:      2013-02-25 18:13 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5610ac25d8ff

8008789: Enable java access and nashorn runtime tests for jtreg
Reviewed-by: lagergren, jlaskey, hannesw

! make/build.xml
! test/TEST.ROOT
! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java
! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java
! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java
! test/src/jdk/nashorn/internal/runtime/ContextTest.java
! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java
+ test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java

Changeset: 1654918e0612
Author:    attila
Date:      2013-02-25 16:51 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1654918e0612

8006984: Introducing local into a function inside with statement confuses its scope
Reviewed-by: jlaskey, lagergren, sundar

! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/WithObject.java
+ test/script/basic/JDK-8006984.js
+ test/script/basic/JDK-8006984.js.EXPECTED

Changeset: a90094ae5be3
Author:    sundar
Date:      2013-02-26 22:57 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a90094ae5be3

8009021: nasgen should be run on boot jdk rather than currenly built jdk
Reviewed-by: jlaskey

! makefiles/BuildNashorn.gmk

Changeset: 1d3dca059b3e
Author:    alanb
Date:      2013-02-27 14:12 +0000
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1d3dca059b3e

8008950: jdk8/tl failing with SetupJavaCompilation BUILD_NASGEN contains missing directory -c on Windows
Reviewed-by: chegar, sundar

! makefiles/BuildNashorn.gmk

Changeset: 071e859b371e
Author:    attila
Date:      2013-02-27 15:20 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/071e859b371e

8009143: Eliminate Dynalink dependency on java.beans
Reviewed-by: jlaskey, lagergren, sundar

! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
! src/jdk/internal/dynalink/beans/BeansLinker.java

Changeset: 928ea3d8faf0
Author:    attila
Date:      2013-02-27 15:49 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/928ea3d8faf0

8009146: Eliminate some dead code in preparation for immutable AST
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/ir/Assignment.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java

Changeset: 1da9e37697f6
Author:    attila
Date:      2013-02-27 16:25 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1da9e37697f6

8009150: Previous dead code elimination was incomplete
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/ir/BinaryNode.java

Changeset: 1e03be240534
Author:    sundar
Date:      2013-02-28 20:31 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1e03be240534

8009229: ant makefile default target should be "test"
Reviewed-by: lagergren, jlaskey

! make/build.xml

Changeset: 037e1de7ab1a
Author:    hannesw
Date:      2013-02-28 22:59 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/037e1de7ab1a

8009240: RegExpScanner code is inefficient and too complex
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java
! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java
! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java

Changeset: 7e9fbe621d87
Author:    sundar
Date:      2013-03-01 15:58 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/7e9fbe621d87

8009263: Fix all javadoc errors in nashorn code
Reviewed-by: hannesw, lagergren

! make/project.properties
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/objects/DateParser.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeJava.java
! src/jdk/nashorn/internal/runtime/CodeInstaller.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptRuntime.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java
! src/jdk/nashorn/internal/runtime/options/Options.java
! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java

Changeset: 3b222c90b7de
Author:    jlaskey
Date:      2013-03-02 11:26 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3b222c90b7de

Merge


Changeset: f90810d79b57
Author:    hannesw
Date:      2013-03-04 11:44 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f90810d79b57

8008370: coffee script compiler doesn't work with Nashorn
Reviewed-by: lagergren, attila

! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java
+ test/script/basic/JDK-8008370.js
+ test/script/basic/JDK-8008370.js.EXPECTED

Changeset: fe5211fc3114
Author:    jlaskey
Date:      2013-03-04 11:01 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/fe5211fc3114

8009379: Remove $ from generated class names
Reviewed-by: attila, lagergren
Contributed-by: james.laskey at oracle.com

! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/MapCreator.java
! src/jdk/nashorn/internal/codegen/ObjectCreator.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/ECMAErrors.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java
- src/jdk/nashorn/internal/scripts/JO$.java
+ src/jdk/nashorn/internal/scripts/JO.java
- src/jdk/nashorn/internal/scripts/JS$.java
+ src/jdk/nashorn/internal/scripts/JS.java

Changeset: 3d57f57acd9c
Author:    sundar
Date:      2013-03-06 22:38 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3d57f57acd9c

8009553: Object.create(Array.prototype) doesn't respect reset length
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/objects/Global.java
+ test/script/basic/JDK-8009553.js

Changeset: 5759f600fcf7
Author:    sundar
Date:      2013-03-09 21:49 +0530
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5759f600fcf7

8009559: clean up method handle lookup code.
Reviewed-by: ahgross, jlaskey, attila, sundar

! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java
! make/java.security.override
! src/jdk/internal/dynalink/beans/CheckRestrictedPackage.java
- src/jdk/internal/dynalink/beans/CheckRestrictedPackageInternal.java
! src/jdk/internal/dynalink/beans/FacetIntrospector.java
- src/jdk/internal/dynalink/beans/RestrictedPackageTester.java
+ src/jdk/internal/dynalink/beans/SafeUnreflector.java
+ src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java
+ src/jdk/internal/dynalink/beans/SandboxClassLoader.java
! src/jdk/internal/dynalink/beans/StaticClassLinker.java
+ src/jdk/internal/dynalink/beans/sandbox/Unreflector.java
! src/jdk/nashorn/internal/codegen/CompilerConstants.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java
! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java
+ src/jdk/nashorn/internal/lookup/Lookup.java
+ src/jdk/nashorn/internal/lookup/MethodHandleFactory.java
+ src/jdk/nashorn/internal/lookup/MethodHandleFunctionality.java
! src/jdk/nashorn/internal/objects/Global.java
! src/jdk/nashorn/internal/objects/NativeArguments.java
! src/jdk/nashorn/internal/objects/NativeBoolean.java
! src/jdk/nashorn/internal/objects/NativeError.java
! src/jdk/nashorn/internal/objects/NativeJSAdapter.java
! src/jdk/nashorn/internal/objects/NativeNumber.java
! src/jdk/nashorn/internal/objects/NativeStrictArguments.java
! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/objects/PrototypeObject.java
! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
! src/jdk/nashorn/internal/objects/ScriptFunctionTrampolineImpl.java
! src/jdk/nashorn/internal/runtime/AccessorProperty.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/FindProperty.java
! src/jdk/nashorn/internal/runtime/GlobalFunctions.java
! src/jdk/nashorn/internal/runtime/ScriptFunction.java
! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java
! src/jdk/nashorn/internal/runtime/ScriptObject.java
! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java
! src/jdk/nashorn/internal/runtime/SetMethodCreator.java
! src/jdk/nashorn/internal/runtime/SpillProperty.java
! src/jdk/nashorn/internal/runtime/Undefined.java
! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java
! src/jdk/nashorn/internal/runtime/WithObject.java
! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java
! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java
! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java
! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java
- src/jdk/nashorn/internal/runtime/linker/Lookup.java
- src/jdk/nashorn/internal/runtime/linker/MethodHandleFactory.java
- src/jdk/nashorn/internal/runtime/linker/MethodHandleFunctionality.java
! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornGuards.java
! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornPrimitiveLinker.java
! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
+ test/script/currently-failing/JDK-8006529.js
- test/script/trusted/JDK-8006529.js

Changeset: 053d7c55dc82
Author:    katleman
Date:      2013-03-21 10:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/053d7c55dc82

Added tag jdk8-b82 for changeset 5759f600fcf7

! .hgtags


From weijun.wang at oracle.com  Fri Mar 22 05:05:58 2013
From: weijun.wang at oracle.com (weijun.wang at oracle.com)
Date: Fri, 22 Mar 2013 12:05:58 +0000
Subject: hg: jdk8/tl/jdk: 8010531: Add BadKdc* tests to problem list for
	solaris-sparcv9
Message-ID: <20130322120610.2CBEA48337@hg.openjdk.java.net>

Changeset: 93cd7052d306
Author:    weijun
Date:      2013-03-22 19:59 +0800
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93cd7052d306

8010531: Add BadKdc* tests to problem list for solaris-sparcv9
Reviewed-by: alanb

! test/ProblemList.txt


From maurizio.cimadamore at oracle.com  Fri Mar 22 05:45:45 2013
From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com)
Date: Fri, 22 Mar 2013 12:45:45 +0000
Subject: hg: jdk8/tl/langtools: 5 new changesets
Message-ID: <20130322124559.BDE3D48338@hg.openjdk.java.net>

Changeset: cc38a6723663
Author:    mcimadamore
Date:      2013-03-22 12:38 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc38a6723663

8009649: Lambda back-end should generate invokespecial for method handles referring to private instance methods
Summary: Private lambda methods should be accessed through invokespecial
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
+ test/tools/javac/lambda/bytecode/TestLambdaBytecode.java

Changeset: f3814edefb33
Author:    mcimadamore
Date:      2013-03-22 12:39 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3814edefb33

8010101: Intersection type cast issues redundant unchecked warning
Summary: Code for checking intersection type cast is incorrectly swapping operands, leading to spurious warnings
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
+ test/tools/javac/lambda/Intersection02.java
+ test/tools/javac/lambda/Intersection02.out

Changeset: b6cf07c54c29
Author:    mcimadamore
Date:      2013-03-22 12:41 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b6cf07c54c29

8009820: AssertionError when compiling java code with two identical static imports
Summary: Speculative attribution is carried out twice with same method symbol in case of static imports
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
+ test/tools/javac/lambda/DoubleStaticImport.java

Changeset: c6728c9addff
Author:    mcimadamore
Date:      2013-03-22 12:43 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c6728c9addff

8010303: Graph inference: missing incorporation step causes spurious inference error
Summary: Multiple equality constraints on inference vars are not used to generate new inference constraints
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! test/tools/javac/lambda/TargetType28.out
+ test/tools/javac/lambda/TargetType67.java
+ test/tools/javac/lambda/TargetType68.java
+ test/tools/javac/lambda/TargetType69.java

Changeset: 5da12e8a59ba
Author:    mcimadamore
Date:      2013-03-22 12:44 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5da12e8a59ba

8010387: Javac crashes when diagnostic mentions anonymous inner class' type variables
Summary: Rich formatter doesn't preprocess supertypes of an anonymous inner class
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java
+ test/tools/javac/Diagnostics/8010387/T8010387.java
+ test/tools/javac/Diagnostics/8010387/T8010387.out


From stefan.karlsson at oracle.com  Fri Mar 22 06:54:32 2013
From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com)
Date: Fri, 22 Mar 2013 13:54:32 +0000
Subject: hg: jdk8/tl/jdk: 2 new changesets
Message-ID: <20130322135510.0F76C4833B@hg.openjdk.java.net>

Changeset: 470232a8e89d
Author:    stefank
Date:      2013-03-22 15:01 +0100
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/470232a8e89d

8005116: NPG: Rename -permstat option for jmap in jdk8 to -clstats
Reviewed-by: jmasa, sla
Contributed-by: Erik Helin 

! src/share/classes/sun/tools/jmap/JMap.java

Changeset: 518d6087e01f
Author:    stefank
Date:      2013-03-22 15:01 +0100
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f

8004172: Update jstat counter names to reflect metaspace changes
Reviewed-by: mchung
Contributed-by: Erik Helin 

! src/share/classes/sun/tools/jstat/resources/jstat_options
! test/sun/tools/jstat/gcCapacityOutput1.awk
! test/sun/tools/jstat/gcCauseOutput1.awk
+ test/sun/tools/jstat/gcMetaCapacityOutput1.awk
! test/sun/tools/jstat/gcOldOutput1.awk
! test/sun/tools/jstat/gcOutput1.awk
- test/sun/tools/jstat/gcPermCapacityOutput1.awk
+ test/sun/tools/jstat/jstatGcMetaCapacityOutput1.sh
- test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh
! test/sun/tools/jstat/lineCounts1.awk
! test/sun/tools/jstat/lineCounts2.awk
! test/sun/tools/jstat/lineCounts3.awk
! test/sun/tools/jstat/lineCounts4.awk
! test/sun/tools/jstat/options1.out
! test/sun/tools/jstat/options2.out
! test/sun/tools/jstat/timeStamp1.awk
! test/sun/tools/jstatd/jstatGcutilOutput1.awk


From erik.helin at oracle.com  Fri Mar 22 07:53:31 2013
From: erik.helin at oracle.com (Erik Helin)
Date: Fri, 22 Mar 2013 15:53:31 +0100
Subject: RFR (XS): 8009427: Re-enable tests that were disable to ease
	complicated push
Message-ID: <514C706B.8000508@oracle.com>

Hi all,

the tests for jstat can be re-enabled now that jstat and the tests for 
jstat have been updated to account for metaspace changes [0].

This change removes the jstat tests (and one jstatd test) from 
ProblemList.txt.

Webrev:
http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/

Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009427

Thanks,
Erik

[0]: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f

From joe.darcy at oracle.com  Fri Mar 22 10:09:00 2013
From: joe.darcy at oracle.com (joe.darcy at oracle.com)
Date: Fri, 22 Mar 2013 17:09:00 +0000
Subject: hg: jdk8/tl/langtools: 7080464: langtools regression test failures
	when assertions are enabled
Message-ID: <20130322170906.1F92948345@hg.openjdk.java.net>

Changeset: f4500abff1fd
Author:    darcy
Date:      2013-03-22 10:08 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f4500abff1fd

7080464: langtools regression test failures when assertions are enabled
Reviewed-by: jjg

! test/tools/javac/api/TestJavacTaskScanner.java
! test/tools/javac/diags/MessageFile.java
! test/tools/javac/diags/MessageInfo.java


From Alan.Bateman at oracle.com  Fri Mar 22 11:18:30 2013
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Fri, 22 Mar 2013 18:18:30 +0000
Subject: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR:
	transport library missing onLoad entry: private_dt_socket
In-Reply-To: <6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com>
References: <2A1F6D24-22FC-4CB4-84FD-05E8ECDDC9BF@oracle.com>
	<513646F9.3060601@oracle.com>
	
	<51379D88.6080807@oracle.com>
	<6E926A33-CBCE-46C9-86A4-2C3F57E058CB@oracle.com>
Message-ID: <514CA076.6060600@oracle.com>

On 07/03/2013 11:54, Staffan Larsen wrote:
> Here is a webrev for fixing this problem. I actually removed all of our own tokenization code in dll_build_name() and replaced it with calls to strtok_r (strtok_s on windows) instead. I think this should be more robust, at the cost of an extra memory allocation. I've also added the const qualifier to some of the parameters.
>
> http://cr.openjdk.java.net/~sla/8009558/webrev.02/
>
> All of the jdi and hprof tests passes with this change.
>
> Thanks,
> /Staffan
>
This looks good to me too.

A minor nit is that probably should put a space in "while(path = ..." in 
all of the dll_build_name implementation. Ignore this comment if you've 
already created the change-set are ready to push of course.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130322/39b4d6bc/attachment.html 

From zhengyu.gu at oracle.com  Fri Mar 22 15:19:12 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Fri, 22 Mar 2013 22:19:12 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8010389: After fix for 7107135 a failed
	dlopen() call results in a VM crash
Message-ID: <20130322221917.9E3444835D@hg.openjdk.java.net>

Changeset: 14509df4cd63
Author:    iklam
Date:      2013-03-21 20:46 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/14509df4cd63

8010389: After fix for 7107135 a failed dlopen() call results in a VM crash
Summary: Call dlerror() in VM thread as necessary.
Reviewed-by: coleenp, dholmes

! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp
+ test/runtime/8010389/VMThreadDlopen.java


From weijun.wang at oracle.com  Fri Mar 22 20:50:00 2013
From: weijun.wang at oracle.com (weijun.wang at oracle.com)
Date: Sat, 23 Mar 2013 03:50:00 +0000
Subject: hg: jdk8/tl/jdk: 2 new changesets
Message-ID: <20130323035033.632B54836B@hg.openjdk.java.net>

Changeset: 3470101fae58
Author:    weijun
Date:      2013-03-23 11:49 +0800
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3470101fae58

8009970: Several LoginModule classes need extra permission to load AuthResources
Reviewed-by: mullan

! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java
! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java
! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java

Changeset: ed63cace1d30
Author:    weijun
Date:      2013-03-23 11:49 +0800
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ed63cace1d30

8009875: Provide a default udp_preference_limit for krb5.conf
Reviewed-by: valeriep

! src/share/classes/sun/security/krb5/KdcComm.java
! src/share/classes/sun/security/krb5/internal/Krb5.java
! test/sun/security/krb5/auto/KDC.java
+ test/sun/security/krb5/config/DefUdpLimit.java


From daniel.daugherty at oracle.com  Sun Mar 24 01:10:58 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Sun, 24 Mar 2013 08:10:58 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 46 new changesets
Message-ID: <20130324081233.219CC4838B@hg.openjdk.java.net>

Changeset: 9960dce2024f
Author:    kmo
Date:      2013-03-14 13:22 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9960dce2024f

8010116: Abstract_VM_Version::internal_vm_info_string() should recognize VS2010 and VS2012
Summary: add cases for _MSC_VER == 1600 and 1700
Reviewed-by: zgu

! src/share/vm/runtime/vm_version.cpp

Changeset: a40807924950
Author:    kmo
Date:      2013-03-14 16:17 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a40807924950

Merge


Changeset: f3d486462d36
Author:    morris
Date:      2013-03-15 18:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f3d486462d36

Merge


Changeset: 96ef09c26978
Author:    morris
Date:      2013-03-16 07:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/96ef09c26978

8009166: [parfait] Null pointer deference in hotspot/src/share/vm/opto/type.cpp
Summary: add guarantee() to as_instance_type()
Reviewed-by: kvn, twisti

! src/share/vm/opto/type.cpp

Changeset: 8b4ce9870fd6
Author:    morris
Date:      2013-03-16 07:39 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8b4ce9870fd6

8009156: [parfait] Null pointer deference in hotspot/src/share/vm/services/memoryService.cpp
Summary: add guarantee() to add_generation_memory_pool()
Reviewed-by: kvn, twisti

! src/share/vm/services/memoryService.cpp

Changeset: 0a2deac0bbfb
Author:    morris
Date:      2013-03-16 07:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0a2deac0bbfb

8008328: [partfait] Null pointer defererence in hotspot/src/cpu/x86/vm/frame_x86.inline.hpp
Summary: add guarantee() to oop_result inlines
Reviewed-by: kvn, twisti

! src/cpu/x86/vm/frame_x86.inline.hpp

Changeset: 9ef47379df20
Author:    morris
Date:      2013-03-16 07:41 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9ef47379df20

8010144: [parfait] Null pointer deference in hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
Summary: add null check to signal handler
Reviewed-by: dcubed

! src/os_cpu/linux_x86/vm/os_linux_x86.cpp

Changeset: 8552f0992748
Author:    kmo
Date:      2013-03-15 22:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8552f0992748

8008796: SA: Oop.iterateFields() should support CompressedKlassPointers again
Summary: add a missing change from JDK-7054512 so that Oop.iterateFields() works with UseCompressedKlassPointers
Reviewed-by: coleenp, roland
Contributed-by: yunda.mly at taobao.com

! agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java

Changeset: 592f9722c72e
Author:    kmo
Date:      2013-03-16 21:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/592f9722c72e

Merge


Changeset: 4efac99a998b
Author:    iignatyev
Date:      2013-03-18 04:29 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4efac99a998b

8008211: Some of WB tests on compiler fail
Reviewed-by: kvn, vlivanov

! test/compiler/whitebox/CompilerWhiteBoxTest.java
! test/compiler/whitebox/DeoptimizeAllTest.java
! test/compiler/whitebox/DeoptimizeMethodTest.java
! test/compiler/whitebox/IsMethodCompilableTest.java
! test/compiler/whitebox/MakeMethodNotCompilableTest.java

Changeset: a5de0cc2f91c
Author:    roland
Date:      2013-03-18 13:19 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a5de0cc2f91c

8008555: Debugging code in compiled method sometimes leaks memory
Summary: support for strings that have same life-time as code that uses them.
Reviewed-by: kvn, twisti

! src/cpu/sparc/vm/macroAssembler_sparc.cpp
! src/cpu/x86/vm/macroAssembler_x86.cpp
! src/share/vm/asm/assembler.cpp
! src/share/vm/asm/assembler.hpp
! src/share/vm/asm/codeBuffer.cpp
! src/share/vm/asm/codeBuffer.hpp
! src/share/vm/code/codeBlob.cpp
! src/share/vm/code/codeBlob.hpp
! src/share/vm/code/icBuffer.hpp
! src/share/vm/code/stubs.cpp
! src/share/vm/code/stubs.hpp
! src/share/vm/compiler/disassembler.cpp
! src/share/vm/compiler/disassembler.hpp
! src/share/vm/interpreter/interpreter.cpp
! src/share/vm/interpreter/interpreter.hpp
! src/share/vm/runtime/stubCodeGenerator.cpp

Changeset: 578d9044c463
Author:    roland
Date:      2013-03-18 09:08 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/578d9044c463

Merge


Changeset: be4d5c6c1f79
Author:    neliasso
Date:      2013-03-19 10:31 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be4d5c6c1f79

8010121: Remove definition of ShouldNotReachHere2(msg)
Reviewed-by: kvn, stefank, rbackman, twisti
Contributed-by: niclas.adlertz at oracle.com

! src/share/vm/memory/sharedHeap.cpp
! src/share/vm/oops/fieldInfo.hpp
! src/share/vm/utilities/debug.cpp
! src/share/vm/utilities/debug.hpp

Changeset: f15df3af32c5
Author:    morris
Date:      2013-03-19 07:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f15df3af32c5

8009172: [parfait] Null pointer deference in hotspot/src/share/vm/opto/output.cpp
Summary: add guarantee() to DoScheduling()
Reviewed-by: twisti, kvn

! src/share/vm/opto/output.cpp

Changeset: 75a28f465a12
Author:    morris
Date:      2013-03-19 07:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/75a28f465a12

8008663: [parfait] Null pointer deference in hotspot/src/share/vm/compiler/compileBroker.cpp
Summary: add NULL checks for compiler name
Reviewed-by: twisti, kvn

! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/compiler/compileBroker.hpp

Changeset: 80208f353616
Author:    kvn
Date:      2013-03-19 10:56 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/80208f353616

8010222: 8007439 disabled inlining of cold accessor methods
Summary: added missing parenthesis
Reviewed-by: jrose

! src/share/vm/opto/bytecodeInfo.cpp

Changeset: 2eef6d34833b
Author:    morris
Date:      2013-03-19 11:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2eef6d34833b

8009022: [parfait] Null pointer deference in hotspot/src/share/vm/oops/generateOopMap.cpp
Summary: add guarantee() checks to merge_state_into_bb()
Reviewed-by: kvn

! src/share/vm/oops/generateOopMap.cpp

Changeset: 3b9368710f08
Author:    morris
Date:      2013-03-19 12:15 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3b9368710f08

8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
Summary: add guarantee() checks
Reviewed-by: kvn

! src/share/vm/opto/loopnode.hpp
! src/share/vm/opto/loopopts.cpp

Changeset: 1275835a4ccc
Author:    morris
Date:      2013-03-19 16:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1275835a4ccc

Merge


Changeset: 41340544e182
Author:    morris
Date:      2013-03-20 06:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/41340544e182

8009248: [parfait] Null pointer deference in hotspot/src/share/vm/code/compiledIC.cpp
Summary: add guarantee() to set_to_interpreted()
Reviewed-by: kvn

! src/share/vm/code/compiledIC.cpp

Changeset: 2dec1d9bfbe1
Author:    morris
Date:      2013-03-20 06:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2dec1d9bfbe1

8009565: [partfait] Null pointer deference in hotspot/src/share/vm/ci/ciEnv.cpp
Summary: add guarantee() to get_instance_klass_for_declared_method_holder()
Reviewed-by: kvn

! src/share/vm/ci/ciEnv.cpp

Changeset: 653d0346aa80
Author:    morris
Date:      2013-03-20 06:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/653d0346aa80

8009578: [parfait] Null pointer deference in hotspot/src/share/vm/classfile/defaultMethods.cpp
Summary: add guarantee() to disqualify_method()
Reviewed-by: kvn

! src/share/vm/classfile/defaultMethods.cpp

Changeset: a59625d96f71
Author:    morris
Date:      2013-03-20 07:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a59625d96f71

8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
Summary: add guarantee() to insert_pre_post_loops()
Reviewed-by: kvn

! src/share/vm/opto/loopTransform.cpp

Changeset: 98f3af397705
Author:    twisti
Date:      2013-03-20 17:04 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/98f3af397705

8006965: remove test_gamma and add dedicated test_* targets instead
Reviewed-by: kvn, jcoomes

! make/Makefile
! make/bsd/Makefile
! make/bsd/makefiles/buildtree.make
! make/defs.make
! make/linux/Makefile
! make/linux/makefiles/buildtree.make
! make/solaris/Makefile
! make/solaris/makefiles/buildtree.make
- make/test/Queens.java

Changeset: 589aa23334ea
Author:    morris
Date:      2013-03-21 10:11 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/589aa23334ea

8009584: [parfait] Null pointer deference in hotspot/src/cpu/x86/vm/relocInfo_x86.cpp
Summary: added guarantee() to pd_address_in_code()
Reviewed-by: kvn

! src/cpu/x86/vm/relocInfo_x86.cpp

Changeset: c3c64a973559
Author:    morris
Date:      2013-03-21 10:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c3c64a973559

8009593: [parfait] Null pointer deference in hotspot/src/share/vm/oops/constantPool.cpp
Summary: added guarantee() to print_entry_on()
Reviewed-by: kvn

! src/share/vm/oops/constantPool.cpp

Changeset: 3536ea6bc4df
Author:    morris
Date:      2013-03-21 21:48 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3536ea6bc4df

Merge

- make/test/Queens.java

Changeset: 79af1312fc2c
Author:    mgerdin
Date:      2013-03-14 10:54 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/79af1312fc2c

8005602: NPG: classunloading does not happen while CMS GC with -XX:+CMSClassUnloadingEnabled is used
Summary: Call purge() on CLDG after sweep(), reorder purge() call in GenCollectedHeap
Reviewed-by: jmasa, stefank

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/metaspace.cpp

Changeset: 3c226052f7dc
Author:    tschatzl
Date:      2013-03-14 09:37 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3c226052f7dc

6733980: par compact - TraceGen1Time always shows 0.0000 seconds
Summary: Use the correct collector to retrieve accumulated gen1 trace time
Reviewed-by: johnc, jmasa

! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp

Changeset: 19f9fabd94cc
Author:    stefank
Date:      2013-03-18 09:34 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/19f9fabd94cc

Merge

! src/share/vm/memory/metaspace.cpp

Changeset: fa08949fe0cb
Author:    johnc
Date:      2013-03-18 11:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fa08949fe0cb

8009536: G1: Apache Lucene hang during reference processing
Summary: In CMTask::do_marking_step(), Skip offering termination and entering the first and second synchronization barriers if called from a serial context, i.e. the VM thread.
Reviewed-by: brutisso, tschatzl

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp

Changeset: e864cc14ca75
Author:    johnc
Date:      2013-03-19 00:57 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e864cc14ca75

8009940: G1: assert(_finger == _heap_end) failed, concurrentMark.cpp:809
Summary: Skip reference processing if the global marking stack overflows during remark. Refactor and rename set_phase(); move code that sets the concurrency level into its own routine. Do not call set_phase() from within parallel reference processing; use the concurrency level routine instead. The marking state should only set reset by CMTask[0] during the concurrent phase of the marking cycle; if an overflow occurs at any stage during the remark, the marking state will be reset after reference processing.
Reviewed-by: brutisso, jmasa

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp

Changeset: 1179172e9ec9
Author:    johnc
Date:      2013-03-19 09:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1179172e9ec9

8008301: G1: guarantee(satb_mq_set.completed_buffers_num() == 0) failure
Summary: If the marking stack overflows while the marking tasks are draining the SATB buffers, remark will exit with some SATB buffers left unprocessed. Relax the guarantee to allow for overflow.
Reviewed-by: jmasa, brutisso

! src/share/vm/gc_implementation/g1/concurrentMark.cpp

Changeset: 7f0cb32dd233
Author:    mgerdin
Date:      2013-03-21 09:07 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7f0cb32dd233

8004241: NPG: Metaspace occupies more memory than specified by -XX:MaxMetaspaceSize option
Summary: Enforce MaxMetaspaceSize for both metaspace parts, check MaxMetaspaceSize against "reserved", not "capacity"
Reviewed-by: jmasa, johnc

! src/share/vm/memory/metaspace.cpp

Changeset: 47902e9acb3a
Author:    stefank
Date:      2013-03-22 10:32 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/47902e9acb3a

Merge

! src/share/vm/memory/metaspace.cpp

Changeset: 5855e849c7e6
Author:    stefank
Date:      2013-03-22 12:32 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5855e849c7e6

Merge


Changeset: 499ccc15bbc8
Author:    bpittore
Date:      2013-03-15 15:20 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/499ccc15bbc8

8005716: Enhance JNI specification to allow support of static JNI libraries in Embedded JREs
Reviewed-by: dlong, alanb, mduigou

! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jni.h
! src/share/vm/runtime/thread.cpp

Changeset: 9e62e72c59cc
Author:    bobv
Date:      2013-03-17 06:30 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9e62e72c59cc

Merge


Changeset: 3be6a41ad358
Author:    dholmes
Date:      2013-03-18 19:34 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3be6a41ad358

8008783: Modifications needed to JPRT to allow for building hard float abi and new bundle changes
Reviewed-by: twisti, collins, bobv, jwilhelm

! make/jprt.properties

Changeset: 804663118c1f
Author:    jprovino
Date:      2013-03-22 10:09 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/804663118c1f

Merge


Changeset: aca25026e2a4
Author:    vladidan
Date:      2013-03-22 17:23 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aca25026e2a4

Merge


Changeset: 4f7380dca47e
Author:    katleman
Date:      2013-03-21 10:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4f7380dca47e

Added tag jdk8-b82 for changeset 3db4ab0e12f4

! .hgtags

Changeset: e3a41fc02348
Author:    amurillo
Date:      2013-03-23 01:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e3a41fc02348

Merge

- make/test/Queens.java

Changeset: 1c8db54ee9f3
Author:    amurillo
Date:      2013-03-23 01:47 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1c8db54ee9f3

Added tag hs25-b24 for changeset e3a41fc02348

! .hgtags

Changeset: 59a41e1357ab
Author:    amurillo
Date:      2013-03-23 10:06 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/59a41e1357ab

8010498: new hotspot build - hs25-b25
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 6574f999e0cf
Author:    dcubed
Date:      2013-03-23 22:35 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6574f999e0cf

Merge

! src/share/vm/memory/metaspace.cpp


From christian.tornqvist at oracle.com  Sun Mar 24 03:04:43 2013
From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com)
Date: Sun, 24 Mar 2013 10:04:43 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130324100459.8E0954838C@hg.openjdk.java.net>

Changeset: c342fbdf8a70
Author:    ctornqvi
Date:      2013-03-24 09:11 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c342fbdf8a70

8008454: test/runtime/NMT/PrintNMTStatistics is broken
Summary: Added @run tag so that it actually runs the test, also fixed broken command line and incorrect parsing. Also reviewed by gerard.ziemski at oracle.com
Reviewed-by: mgerdin, zgu

! test/runtime/NMT/PrintNMTStatistics.java

Changeset: 9c8e53c7bed0
Author:    ctornqvi
Date:      2013-03-24 09:21 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9c8e53c7bed0

Merge

- make/test/Queens.java


From sundararajan.athijegannathan at oracle.com  Sun Mar 24 23:42:40 2013
From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com)
Date: Mon, 25 Mar 2013 06:42:40 +0000
Subject: hg: jdk8/tl/nashorn: 3 new changesets
Message-ID: <20130325064243.334A64839B@hg.openjdk.java.net>

Changeset: 3b0a0d9d51f0
Author:    sundar
Date:      2013-03-18 21:03 +0530
URL:       http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3b0a0d9d51f0

8010199: javax.script.Invocable implementation for nashorn does not return null when matching functions are missing
Reviewed-by: lagergren, jlaskey

! bin/jjs
! bin/jjssecure
! bin/nashorn
! bin/nashornsecure
! src/jdk/nashorn/api/scripting/NashornScriptEngine.java
+ test/script/basic/JDK-8010199.js
! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java

Changeset: 606a1946e3e2
Author:    jlaskey
Date:      2013-03-19 11:03 -0300
URL:       http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/606a1946e3e2

8009969: CodeCoverage should use template
Reviewed-by: jlaskey, sundar
Contributed-by: pavel.stepanov at oracle.com

! make/build.xml
! make/code_coverage.xml
! make/project.properties

Changeset: 4be452026847
Author:    attila
Date:      2013-03-23 00:58 +0100
URL:       http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4be452026847

8010652: Eliminate non-child references in Block/FunctionNode, and make few node types immutable
Reviewed-by: jlaskey, lagergren

! make/project.properties
! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/codegen/ClassEmitter.java
! src/jdk/nashorn/internal/codegen/CodeGenerator.java
! src/jdk/nashorn/internal/codegen/CompilationPhase.java
! src/jdk/nashorn/internal/codegen/Compiler.java
! src/jdk/nashorn/internal/codegen/FinalizeTypes.java
! src/jdk/nashorn/internal/codegen/FoldConstants.java
! src/jdk/nashorn/internal/codegen/FunctionSignature.java
! src/jdk/nashorn/internal/codegen/Lower.java
! src/jdk/nashorn/internal/codegen/MethodEmitter.java
! src/jdk/nashorn/internal/codegen/Splitter.java
! src/jdk/nashorn/internal/codegen/WeighNodes.java
! src/jdk/nashorn/internal/ir/AccessNode.java
! src/jdk/nashorn/internal/ir/Assignment.java
! src/jdk/nashorn/internal/ir/BaseNode.java
! src/jdk/nashorn/internal/ir/BinaryNode.java
! src/jdk/nashorn/internal/ir/Block.java
! src/jdk/nashorn/internal/ir/BreakNode.java
! src/jdk/nashorn/internal/ir/CallNode.java
! src/jdk/nashorn/internal/ir/CaseNode.java
! src/jdk/nashorn/internal/ir/CatchNode.java
! src/jdk/nashorn/internal/ir/ContinueNode.java
! src/jdk/nashorn/internal/ir/DoWhileNode.java
! src/jdk/nashorn/internal/ir/EmptyNode.java
! src/jdk/nashorn/internal/ir/ExecuteNode.java
! src/jdk/nashorn/internal/ir/ForNode.java
! src/jdk/nashorn/internal/ir/FunctionNode.java
! src/jdk/nashorn/internal/ir/IdentNode.java
! src/jdk/nashorn/internal/ir/IfNode.java
! src/jdk/nashorn/internal/ir/IndexNode.java
! src/jdk/nashorn/internal/ir/LabelNode.java
+ src/jdk/nashorn/internal/ir/LexicalContext.java
! src/jdk/nashorn/internal/ir/LineNumberNode.java
! src/jdk/nashorn/internal/ir/LiteralNode.java
! src/jdk/nashorn/internal/ir/Location.java
! src/jdk/nashorn/internal/ir/Node.java
! src/jdk/nashorn/internal/ir/ObjectNode.java
! src/jdk/nashorn/internal/ir/PropertyNode.java
- src/jdk/nashorn/internal/ir/ReferenceNode.java
! src/jdk/nashorn/internal/ir/ReturnNode.java
! src/jdk/nashorn/internal/ir/RuntimeNode.java
! src/jdk/nashorn/internal/ir/SplitNode.java
! src/jdk/nashorn/internal/ir/SwitchNode.java
! src/jdk/nashorn/internal/ir/Symbol.java
! src/jdk/nashorn/internal/ir/TernaryNode.java
! src/jdk/nashorn/internal/ir/ThrowNode.java
! src/jdk/nashorn/internal/ir/TryNode.java
! src/jdk/nashorn/internal/ir/TypeOverride.java
! src/jdk/nashorn/internal/ir/UnaryNode.java
! src/jdk/nashorn/internal/ir/VarNode.java
! src/jdk/nashorn/internal/ir/WhileNode.java
! src/jdk/nashorn/internal/ir/WithNode.java
! src/jdk/nashorn/internal/ir/debug/JSONWriter.java
! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java
! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java
! src/jdk/nashorn/internal/parser/Parser.java
! src/jdk/nashorn/internal/runtime/Context.java
! src/jdk/nashorn/internal/runtime/resources/Messages.properties
! test/script/basic/JDK-8006755.js
! test/script/basic/NASHORN-837.js
! test/src/jdk/nashorn/internal/codegen/CompilerTest.java


From rickard.backman at oracle.com  Mon Mar 25 04:13:23 2013
From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=)
Date: Mon, 25 Mar 2013 12:13:23 +0100
Subject: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub()
	|| sender_blob->is_nmethod()) failed: Impossible call chain
In-Reply-To: <788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com>
References: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com>
	<788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com>
Message-ID: 

Hi,

trying again, can I please have two reviews on this change?
Some small changes after offline discussion. 

The webrev is available here:
http://cr.openjdk.java.net/~rbackman/8008357.u1/

Thanks
/R

On Mar 5, 2013, at 8:07 AM, Rickard B?ckman wrote:

> Anyone have time to look at this?
> 
> Thanks
> /R
> 
> On Mar 1, 2013, at 10:27 AM, Rickard B?ckman wrote:
> 
>> Hi all,
>> 
>> here comes another update to frame.safe_for_sender. 
>> If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. 
>> In this case we read one that pointed into the Safepoint blob. 
>> 
>> We now pretty much guarded for all kind of blobs in safe_for_sender,
>> so I've changed the method to not assert in the end but to do it the same was as the frame_sparc.cpp did it. Everything that is not
>> a nmethod at the end of the method is not safe. 
>> 
>> I've also changed another check for a frame_size == 0 to frame_size <= 0 to make it somewhat more safer.
>> 
>> The bug: http://bugs.sun.com/view_bug.do?bug_id=8008357
>> Webrev: http://cr.openjdk.java.net/~rbackman/8008357/
>> 
>> This webrev is for HS24.
>> 
>> Thanks
>> /R
> 


From staffan.larsen at oracle.com  Mon Mar 25 04:43:01 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Mon, 25 Mar 2013 12:43:01 +0100
Subject: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub()
	|| sender_blob->is_nmethod()) failed: Impossible call chain
In-Reply-To: 
References: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com>
	<788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com>
	
Message-ID: 

Looks good to me - not a Reviewer.

/Staffan

On 25 mar 2013, at 12:13, Rickard B?ckman  wrote:

> Hi,
> 
> trying again, can I please have two reviews on this change?
> Some small changes after offline discussion. 
> 
> The webrev is available here:
> http://cr.openjdk.java.net/~rbackman/8008357.u1/
> 
> Thanks
> /R
> 
> On Mar 5, 2013, at 8:07 AM, Rickard B?ckman wrote:
> 
>> Anyone have time to look at this?
>> 
>> Thanks
>> /R
>> 
>> On Mar 1, 2013, at 10:27 AM, Rickard B?ckman wrote:
>> 
>>> Hi all,
>>> 
>>> here comes another update to frame.safe_for_sender. 
>>> If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. 
>>> In this case we read one that pointed into the Safepoint blob. 
>>> 
>>> We now pretty much guarded for all kind of blobs in safe_for_sender,
>>> so I've changed the method to not assert in the end but to do it the same was as the frame_sparc.cpp did it. Everything that is not
>>> a nmethod at the end of the method is not safe. 
>>> 
>>> I've also changed another check for a frame_size == 0 to frame_size <= 0 to make it somewhat more safer.
>>> 
>>> The bug: http://bugs.sun.com/view_bug.do?bug_id=8008357
>>> Webrev: http://cr.openjdk.java.net/~rbackman/8008357/
>>> 
>>> This webrev is for HS24.
>>> 
>>> Thanks
>>> /R
>> 
> 


From sundararajan.athijegannathan at oracle.com  Mon Mar 25 06:55:29 2013
From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com)
Date: Mon, 25 Mar 2013 13:55:29 +0000
Subject: hg: jdk8/tl/jdk: 8010704: The test
	closed/java/lang/SecurityManager/CheckPackageDefinition.java
	failed after fix for 8009869
Message-ID: <20130325135608.10B40483A9@hg.openjdk.java.net>

Changeset: d92a96dcbfe1
Author:    sundar
Date:      2013-03-25 19:25 +0530
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d92a96dcbfe1

8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java failed after fix for 8009869
Reviewed-by: lagergren, hannesw

! src/share/lib/security/java.security-linux
! src/share/lib/security/java.security-solaris


From chris.hegarty at oracle.com  Mon Mar 25 07:30:18 2013
From: chris.hegarty at oracle.com (chris.hegarty at oracle.com)
Date: Mon, 25 Mar 2013 14:30:18 +0000
Subject: hg: jdk8/tl/jdk: 8010668: builtin JNI libraries should not be unloaded
Message-ID: <20130325143042.9F4E2483AB@hg.openjdk.java.net>

Changeset: 5d0c891264bf
Author:    chegar
Date:      2013-03-25 14:29 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d0c891264bf

8010668: builtin JNI libraries should not be unloaded
Reviewed-by: chegar, alanb
Contributed-by: Bill Pittore 

! src/share/native/java/lang/ClassLoader.c


From harold.seigel at oracle.com  Mon Mar 25 09:07:35 2013
From: harold.seigel at oracle.com (harold.seigel at oracle.com)
Date: Mon, 25 Mar 2013 16:07:35 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8010667: Non-zero padding is not allowed
	in splitverifier for tableswitch/lookupswitch instructions.
Message-ID: <20130325160742.E781D483AD@hg.openjdk.java.net>

Changeset: 729be16a470b
Author:    hseigel
Date:      2013-03-25 08:37 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/729be16a470b

8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
Summary: Don't check the padding bits if class file version is >= 51.
Reviewed-by: kvn, dholmes, coleenp

! src/share/vm/classfile/verifier.cpp


From erik.gahlin at oracle.com  Mon Mar 25 13:13:44 2013
From: erik.gahlin at oracle.com (Erik Gahlin)
Date: Mon, 25 Mar 2013 21:13:44 +0100
Subject: RFR(XXS): 8007150 Event based tracing is missing truncated field
	in stack trace content type
Message-ID: <5150AFF8.6090600@oracle.com>

Hi,

Could you please review this small change to the metadata for StackTrace 
content type, used by the event tracing framework. A boolean flag has 
been added so it's possible to see if a stack trace has been truncated 
(not all frames included).

http://cr.openjdk.java.net/~egahlin/8007150_1/

The fix is targeted for hs24.

Thanks
Erik

From erik.gahlin at oracle.com  Mon Mar 25 14:17:54 2013
From: erik.gahlin at oracle.com (Erik Gahlin)
Date: Mon, 25 Mar 2013 22:17:54 +0100
Subject: RFR(XXS): 8008391: Incorrect metadata for event based tracing
In-Reply-To: <5150AFF8.6090600@oracle.com>
References: <5150AFF8.6090600@oracle.com>
Message-ID: <5150BF02.4080702@oracle.com>

Hi,

Could you please review these small metadata changes for the event 
tracing framework:

- Promotion Failed -> objectCount has the datatype BYTES64, which 
implies that it is a size. It is not, and the type should be an unsigned 
long.

- Thread Park, Java Monitor Enter and Java Monitor wait should have 
relational ids, so it's possible to see that the information is related 
("java/monitor/address")

- The field "caller" in ExecuteVMOperation should not have a TO field 
but a FROM field, indicating from which thread the "transition" came from.

The reason the review for 8007150 is handled seperately is because it 
modifies the structure of the data,  while these changes are strictly 
cosmetical.

http://cr.openjdk.java.net/~egahlin/8008391_1/

Thanks
Erik

From mandy.chung at oracle.com  Mon Mar 25 17:22:00 2013
From: mandy.chung at oracle.com (mandy.chung at oracle.com)
Date: Tue, 26 Mar 2013 00:22:00 +0000
Subject: hg: jdk8/tl/jdk: 8007703: Remove com.sun.servicetag API
Message-ID: <20130326002227.A2616483BD@hg.openjdk.java.net>

Changeset: 5e383a73386a
Author:    mchung
Date:      2013-03-25 17:19 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e383a73386a

8007703: Remove com.sun.servicetag API
Reviewed-by: dholmes, alanb, erikj

! make/com/sun/Makefile
! make/common/Release.gmk
! makefiles/CopyFiles.gmk
! makefiles/CopyIntoClasses.gmk
! makefiles/CreateJars.gmk
! makefiles/GensrcProperties.gmk
! makefiles/profile-includes.txt
! makefiles/profile-rtjar-includes.txt
! test/Makefile


From bharadwaj.yadavalli at oracle.com  Mon Mar 25 17:57:01 2013
From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com)
Date: Tue, 26 Mar 2013 00:57:01 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8009552:
	test/vm/verifier/TestStaticIF.java failing with hs25.0-b
Message-ID: <20130326005703.A438D483BE@hg.openjdk.java.net>

Changeset: b8deb3205b51
Author:    bharadwaj
Date:      2013-03-25 09:36 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b8deb3205b51

8009552: test/vm/verifier/TestStaticIF.java failing with hs25.0-b
Summary: Remove support for verification of class files with version 52 and above from type inference verifier.
Reviewed-by: acorn, hseigel

! src/share/vm/classfile/verifier.cpp
- test/runtime/8007736/TestStaticIF.java


From mandy.chung at oracle.com  Mon Mar 25 18:17:13 2013
From: mandy.chung at oracle.com (mandy.chung at oracle.com)
Date: Tue, 26 Mar 2013 01:17:13 +0000
Subject: hg: jdk8/tl/jdk: 8010787: changeset for 8007703 is missing the
	deleted files
Message-ID: <20130326011748.B254C483C1@hg.openjdk.java.net>

Changeset: 335d2156222e
Author:    mchung
Date:      2013-03-25 18:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/335d2156222e

8010787: changeset for 8007703 is missing the deleted files
Reviewed-by: dholmes, alanb, erikj

- make/com/sun/servicetag/Makefile
- src/share/classes/com/sun/servicetag/BrowserSupport.java
- src/share/classes/com/sun/servicetag/Installer.java
- src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java
- src/share/classes/com/sun/servicetag/RegistrationData.java
- src/share/classes/com/sun/servicetag/RegistrationDocument.java
- src/share/classes/com/sun/servicetag/Registry.java
- src/share/classes/com/sun/servicetag/ServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java
- src/share/classes/com/sun/servicetag/SunConnection.java
- src/share/classes/com/sun/servicetag/SystemEnvironment.java
- src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java
- src/share/classes/com/sun/servicetag/Util.java
- src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java
- src/share/classes/com/sun/servicetag/package.html
- src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt
- src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties
- src/share/classes/com/sun/servicetag/resources/jdk_header.png
- src/share/classes/com/sun/servicetag/resources/product_registration.xsd
- src/share/classes/com/sun/servicetag/resources/register.html
- src/share/classes/com/sun/servicetag/resources/register_ja.html
- src/share/classes/com/sun/servicetag/resources/register_zh_CN.html
- test/com/sun/servicetag/DeleteServiceTag.java
- test/com/sun/servicetag/DuplicateNotFound.java
- test/com/sun/servicetag/FindServiceTags.java
- test/com/sun/servicetag/InstanceUrnCheck.java
- test/com/sun/servicetag/InvalidRegistrationData.java
- test/com/sun/servicetag/InvalidServiceTag.java
- test/com/sun/servicetag/JavaServiceTagTest.java
- test/com/sun/servicetag/JavaServiceTagTest1.java
- test/com/sun/servicetag/NewRegistrationData.java
- test/com/sun/servicetag/SvcTagClient.java
- test/com/sun/servicetag/SystemRegistryTest.java
- test/com/sun/servicetag/TestLoadFromXML.java
- test/com/sun/servicetag/UpdateServiceTagTest.java
- test/com/sun/servicetag/Util.java
- test/com/sun/servicetag/ValidRegistrationData.java
- test/com/sun/servicetag/environ.properties
- test/com/sun/servicetag/missing-environ-field.xml
- test/com/sun/servicetag/newer-registry-version.xml
- test/com/sun/servicetag/registration.xml
- test/com/sun/servicetag/servicetag1.properties
- test/com/sun/servicetag/servicetag2.properties
- test/com/sun/servicetag/servicetag3.properties
- test/com/sun/servicetag/servicetag4.properties
- test/com/sun/servicetag/servicetag5.properties


From michael.fang at oracle.com  Mon Mar 25 19:10:35 2013
From: michael.fang at oracle.com (michael.fang at oracle.com)
Date: Tue, 26 Mar 2013 02:10:35 +0000
Subject: hg: jdk8/tl/corba: 2 new changesets
Message-ID: <20130326021037.A6553483C4@hg.openjdk.java.net>

Changeset: c3ec80715805
Author:    mfang
Date:      2013-03-25 16:53 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/corba/rev/c3ec80715805

8010521: jdk8 l10n resource file translation update 2
Reviewed-by: naoto, yhuang

! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_de.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_es.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_fr.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_it.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ja.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ko.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_pt_BR.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_sv.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_CN.properties
! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_TW.properties
! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp
! src/share/classes/com/sun/tools/corba/se/idl/idl_zh_CN.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_ja.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_zh_CN.prp

Changeset: 910af9c3f338
Author:    mfang
Date:      2013-03-25 18:03 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/corba/rev/910af9c3f338

Merge



From michael.fang at oracle.com  Mon Mar 25 19:14:22 2013
From: michael.fang at oracle.com (michael.fang at oracle.com)
Date: Tue, 26 Mar 2013 02:14:22 +0000
Subject: hg: jdk8/tl/langtools: 2 new changesets
Message-ID: <20130326021430.20979483C5@hg.openjdk.java.net>

Changeset: fdf30b225e1c
Author:    mfang
Date:      2013-03-25 16:55 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fdf30b225e1c

8010521: jdk8 l10n resource file translation update 2
Reviewed-by: naoto, yhuang

! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_ja.properties
! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_zh_CN.properties
! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_ja.properties
! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_zh_CN.properties
! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties
! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
! src/share/classes/com/sun/tools/javac/resources/javac_ja.properties
! src/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties
! src/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties
! src/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties
! src/share/classes/com/sun/tools/javah/resources/l10n_ja.properties
! src/share/classes/com/sun/tools/javah/resources/l10n_zh_CN.properties

Changeset: 65e1ca8dcdc7
Author:    mfang
Date:      2013-03-25 18:08 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/65e1ca8dcdc7

Merge



From serguei.spitsyn at oracle.com  Tue Mar 26 01:37:16 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 26 Mar 2013 01:37:16 -0700
Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs to
	methods must be updated at class redefinition
In-Reply-To: <513E8B88.6070904@oracle.com>
References: <513E8B88.6070904@oracle.com>
Message-ID: <51515E3C.7040307@oracle.com>


Please, review the following fix.
The fix was preliminarily reviewed by Coleen, Christian
and John but still a final and open jdk review is needed.
So that, everyone is welcome to review the fix!

This is open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/

The CR is:
   http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
   https://jbs.oracle.com/bugs/browse/JDK-8008511


The problem is that the old version of the bootstrap method is re-invoked
after a popframe from the bootstrap method execution.
It is because the MemberName keeps a stale reference to the old method 
version.

The solution (suggested by John Rose) is to lazily create and keep 
up-to-date a MemberNameTable
which plays a role of MemberName cache assosiated with the InstanceKlass.
Then, at the Class redefinition, this cache is used to replace the old 
method
references in the MemberName's with the new method references.

The MemberNameTable is based on the GrowableArray.
A C_HEAP array is allocated at the first call to 
InstanceKlass::add_member_name().
It is released in the InstanceKlass::release_C_heap_structures().

A global week reference to member name oop is stored in the MemberNameTable.
It allowed to avoid having the oops_do() in the MemberNameTable.
Also, the MemberNameTable won't hold member name oops in memory.

The MemberNameTable_lock mutex is added to serialize MemberNameTable's 
updates.

The following No_Safepoint_Verifier has been disabled:
*  src/share/vm/prims/methodHandles.cpp*:

    799 int MethodHandles::find_MemberNames(Klass* k,
    . . .
    803 DEBUG_ONLY(No_Safepoint_Verifier nsv);

     It is probably Ok, but, please, let me know if it is not.
     The assert related to locking is fired if it is not disabled.

Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms 
(32 vs 64-bit too).
The testing looks good so far.


Thanks,
Serguei


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130326/7a13d8d1/attachment-0001.html 

From staffan.larsen at oracle.com  Tue Mar 26 01:59:33 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Tue, 26 Mar 2013 09:59:33 +0100
Subject: RFR(XXS): 8008391: Incorrect metadata for event based tracing
In-Reply-To: <5150BF02.4080702@oracle.com>
References: <5150AFF8.6090600@oracle.com> <5150BF02.4080702@oracle.com>
Message-ID: <518436F4-1CE9-4824-9650-DE54A57ABAE1@oracle.com>

Looks good!

/Staffan

On 25 mar 2013, at 22:17, Erik Gahlin  wrote:

> Hi,
> 
> Could you please review these small metadata changes for the event tracing framework:
> 
> - Promotion Failed -> objectCount has the datatype BYTES64, which implies that it is a size. It is not, and the type should be an unsigned long.
> 
> - Thread Park, Java Monitor Enter and Java Monitor wait should have relational ids, so it's possible to see that the information is related ("java/monitor/address")
> 
> - The field "caller" in ExecuteVMOperation should not have a TO field but a FROM field, indicating from which thread the "transition" came from.
> 
> The reason the review for 8007150 is handled seperately is because it modifies the structure of the data,  while these changes are strictly cosmetical.
> 
> http://cr.openjdk.java.net/~egahlin/8008391_1/
> 
> Thanks
> Erik


From david.holmes at oracle.com  Tue Mar 26 02:17:33 2013
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 26 Mar 2013 19:17:33 +1000
Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs
	to methods must be updated at class redefinition
In-Reply-To: <51515E3C.7040307@oracle.com>
References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com>
Message-ID: <515167AD.5040606@oracle.com>

Hi Serguei,

The removal of the NoSafepointVerifier could be problematic. If that 
method is never meant to be on the stack when you block for a safepoint 
then the method is atomic with respect to the safepoint - and so can not 
suffer interference from actions that occur at a safepoint (like class 
unloading (?) ). Now I presume that somewhere from that method you end 
up taking the mutex and so can block at a safepoint (or block on the 
lock and so still allow a safepoint to occur) - which might invalidate 
assumptions the method has about "safepoint atomicity".

You need to understand why the NSV was put there in the first place.

David
------

On 26/03/2013 6:37 PM, serguei.spitsyn at oracle.com wrote:
>
> Please, review the following fix.
> The fix was preliminarily reviewed by Coleen, Christian
> and John but still a final and open jdk review is needed.
> So that, everyone is welcome to review the fix!
>
> This is open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/
>
> The CR is:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
> https://jbs.oracle.com/bugs/browse/JDK-8008511
>
>
> The problem is that the old version of the bootstrap method is re-invoked
> after a popframe from the bootstrap method execution.
> It is because the MemberName keeps a stale reference to the old method
> version.
>
> The solution (suggested by John Rose) is to lazily create and keep
> up-to-date a MemberNameTable
> which plays a role of MemberName cache assosiated with the InstanceKlass.
> Then, at the Class redefinition, this cache is used to replace the old
> method
> references in the MemberName's with the new method references.
>
> The MemberNameTable is based on the GrowableArray.
> A C_HEAP array is allocated at the first call to
> InstanceKlass::add_member_name().
> It is released in the InstanceKlass::release_C_heap_structures().
>
> A global week reference to member name oop is stored in the MemberNameTable.
> It allowed to avoid having the oops_do() in the MemberNameTable.
> Also, the MemberNameTable won't hold member name oops in memory.
>
> The MemberNameTable_lock mutex is added to serialize MemberNameTable's
> updates.
>
> The following No_Safepoint_Verifier has been disabled:
> *  src/share/vm/prims/methodHandles.cpp*:
>
>     799 int MethodHandles::find_MemberNames(Klass* k,
>     . . .
>     803 DEBUG_ONLY(No_Safepoint_Verifier nsv);
>
>      It is probably Ok, but, please, let me know if it is not.
>      The assert related to locking is fired if it is not disabled.
>
> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms
> (32 vs 64-bit too).
> The testing looks good so far.
>
>
> Thanks,
> Serguei
>
>

From erik.helin at oracle.com  Tue Mar 26 04:29:50 2013
From: erik.helin at oracle.com (Erik Helin)
Date: Tue, 26 Mar 2013 12:29:50 +0100
Subject: RFR (XS): 8009427: Re-enable tests that were disable to ease
	complicated push
In-Reply-To: <514C706B.8000508@oracle.com>
References: <514C706B.8000508@oracle.com>
Message-ID: <515186AE.7040003@oracle.com>

Anyone?

It is a very small change and I would really like these tests to start 
running again in the nightly testing.

Thanks,
Erik

On 03/22/2013 03:53 PM, Erik Helin wrote:
> Hi all,
>
> the tests for jstat can be re-enabled now that jstat and the tests for
> jstat have been updated to account for metaspace changes [0].
>
> This change removes the jstat tests (and one jstatd test) from
> ProblemList.txt.
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/
>
> Bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009427
>
> Thanks,
> Erik
>
> [0]: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f


From staffan.larsen at oracle.com  Tue Mar 26 05:09:08 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Tue, 26 Mar 2013 13:09:08 +0100
Subject: RFR (XS): 8009427: Re-enable tests that were disable to ease
	complicated push
In-Reply-To: <515186AE.7040003@oracle.com>
References: <514C706B.8000508@oracle.com> <515186AE.7040003@oracle.com>
Message-ID: <450B5B73-6486-419E-AEFC-4C4F1CB6BCA8@oracle.com>

Looks good!

On 26 mar 2013, at 12:29, Erik Helin  wrote:

> Anyone?
> 
> It is a very small change and I would really like these tests to start running again in the nightly testing.
> 
> Thanks,
> Erik
> 
> On 03/22/2013 03:53 PM, Erik Helin wrote:
>> Hi all,
>> 
>> the tests for jstat can be re-enabled now that jstat and the tests for
>> jstat have been updated to account for metaspace changes [0].
>> 
>> This change removes the jstat tests (and one jstatd test) from
>> ProblemList.txt.
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/
>> 
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009427
>> 
>> Thanks,
>> Erik
>> 
>> [0]: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f
> 


From erik.helin at oracle.com  Tue Mar 26 05:29:41 2013
From: erik.helin at oracle.com (Erik Helin)
Date: Tue, 26 Mar 2013 13:29:41 +0100
Subject: RFR (XS): 8009427: Re-enable tests that were disable to ease
	complicated push
In-Reply-To: <450B5B73-6486-419E-AEFC-4C4F1CB6BCA8@oracle.com>
References: <514C706B.8000508@oracle.com> <515186AE.7040003@oracle.com>
	<450B5B73-6486-419E-AEFC-4C4F1CB6BCA8@oracle.com>
Message-ID: <515194B5.6000701@oracle.com>

Hi Staffan,

thanks for the review! Now I just need a JDK reviewer to take a look at 
this.

Erik

On 03/26/2013 01:09 PM, Staffan Larsen wrote:
> Looks good!
>
> On 26 mar 2013, at 12:29, Erik Helin  wrote:
>
>> Anyone?
>>
>> It is a very small change and I would really like these tests to start running again in the nightly testing.
>>
>> Thanks,
>> Erik
>>
>> On 03/22/2013 03:53 PM, Erik Helin wrote:
>>> Hi all,
>>>
>>> the tests for jstat can be re-enabled now that jstat and the tests for
>>> jstat have been updated to account for metaspace changes [0].
>>>
>>> This change removes the jstat tests (and one jstatd test) from
>>> ProblemList.txt.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/
>>>
>>> Bug:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009427
>>>
>>> Thanks,
>>> Erik
>>>
>>> [0]: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f
>>
>


From daniel.daugherty at oracle.com  Tue Mar 26 06:15:16 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Tue, 26 Mar 2013 07:15:16 -0600
Subject: RFR (XS): 8009427: Re-enable tests that were disable to ease
	complicated push
In-Reply-To: <515186AE.7040003@oracle.com>
References: <514C706B.8000508@oracle.com> <515186AE.7040003@oracle.com>
Message-ID: <51519F64.2000804@oracle.com>

The HotSpot changes were included in HSX-25-B22 which was
included in JDK8-B81 which is promoted. Have you rerun the
tests to make sure that they either pass or that the remaining
failure modes (if any) are covered by an open bug or bugs?

Thumbs up for the ProblemList.txt change.

Dan


On 3/26/13 5:29 AM, Erik Helin wrote:
> Anyone?
>
> It is a very small change and I would really like these tests to start 
> running again in the nightly testing.
>
> Thanks,
> Erik
>
> On 03/22/2013 03:53 PM, Erik Helin wrote:
>> Hi all,
>>
>> the tests for jstat can be re-enabled now that jstat and the tests for
>> jstat have been updated to account for metaspace changes [0].
>>
>> This change removes the jstat tests (and one jstatd test) from
>> ProblemList.txt.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/
>>
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009427
>>
>> Thanks,
>> Erik
>>
>> [0]: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f
>


From rickard.backman at oracle.com  Tue Mar 26 07:03:13 2013
From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=)
Date: Tue, 26 Mar 2013 15:03:13 +0100
Subject: RFR(S): 8008357: [sampling] assert(sender_blob->is_runtime_stub()
	|| sender_blob->is_nmethod()) failed: Impossible call chain
In-Reply-To: 
References: <14A7B4EE-3FC5-4DC1-814A-D66F9558B2D0@oracle.com>
	<788CA82B-72E4-4470-BF0C-0A75315138ED@oracle.com>
	
	
Message-ID: 

Still need a Reviewer?

Thanks
/R

On Mar 25, 2013, at 12:43 PM, Staffan Larsen wrote:

> Looks good to me - not a Reviewer.
> 
> /Staffan
> 
> On 25 mar 2013, at 12:13, Rickard B?ckman  wrote:
> 
>> Hi,
>> 
>> trying again, can I please have two reviews on this change?
>> Some small changes after offline discussion. 
>> 
>> The webrev is available here:
>> http://cr.openjdk.java.net/~rbackman/8008357.u1/
>> 
>> Thanks
>> /R
>> 
>> On Mar 5, 2013, at 8:07 AM, Rickard B?ckman wrote:
>> 
>>> Anyone have time to look at this?
>>> 
>>> Thanks
>>> /R
>>> 
>>> On Mar 1, 2013, at 10:27 AM, Rickard B?ckman wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> here comes another update to frame.safe_for_sender. 
>>>> If the PC at a place where the stack doesn't match the _frame_size we sometimes read an invalid return PC. 
>>>> In this case we read one that pointed into the Safepoint blob. 
>>>> 
>>>> We now pretty much guarded for all kind of blobs in safe_for_sender,
>>>> so I've changed the method to not assert in the end but to do it the same was as the frame_sparc.cpp did it. Everything that is not
>>>> a nmethod at the end of the method is not safe. 
>>>> 
>>>> I've also changed another check for a frame_size == 0 to frame_size <= 0 to make it somewhat more safer.
>>>> 
>>>> The bug: http://bugs.sun.com/view_bug.do?bug_id=8008357
>>>> Webrev: http://cr.openjdk.java.net/~rbackman/8008357/
>>>> 
>>>> This webrev is for HS24.
>>>> 
>>>> Thanks
>>>> /R
>>> 
>> 
> 


From sundararajan.athijegannathan at oracle.com  Tue Mar 26 07:04:34 2013
From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com)
Date: Tue, 26 Mar 2013 14:04:34 +0000
Subject: hg: jdk8/tl/nashorn: 4 new changesets
Message-ID: <20130326140438.14F29483DB@hg.openjdk.java.net>

Changeset: ae4ef3102d9c
Author:    lagergren
Date:      2013-03-25 12:01 +0100
URL:       http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae4ef3102d9c

8017010: index evaluation to a temporary location for index operator much change temporaries to slots, but never scoped vars
Reviewed-by: hannesw, sundar

! src/jdk/nashorn/internal/codegen/Attr.java
! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java
! src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java
+ test/script/basic/JDK-8017010.js
+ test/script/basic/JDK-8017010.js.EXPECTED
! test/script/basic/NASHORN-258.js
! test/script/basic/NASHORN-258.js.EXPECTED

Changeset: 15dac7439921
Author:    sundar
Date:      2013-03-25 18:20 +0530
URL:       http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/15dac7439921

8010709: org on the top level doesn't resolve
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/Global.java
+ test/script/basic/JDK-8010709.js

Changeset: 43e40c08e7f8
Author:    lagergren
Date:      2013-03-26 08:42 +0100
URL:       http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/43e40c08e7f8

8010706: -Dnashorn.args system property to create command lines to wrapped nashorn.jar:s
Reviewed-by: hannesw, sundar

! docs/DEVELOPER_README
! src/jdk/nashorn/internal/runtime/options/Options.java

Changeset: ed60078f0a80
Author:    sundar
Date:      2013-03-26 18:26 +0530
URL:       http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ed60078f0a80

8010720: Linkage problem with java.lang.String.length()
Reviewed-by: hannesw, lagergren

! src/jdk/nashorn/internal/objects/NativeString.java
! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java
+ test/script/basic/JDK-8010720.js


From erik.helin at oracle.com  Tue Mar 26 07:07:56 2013
From: erik.helin at oracle.com (Erik Helin)
Date: Tue, 26 Mar 2013 15:07:56 +0100
Subject: RFR (XS): 8009427: Re-enable tests that were disable to ease
	complicated push
In-Reply-To: <51519F64.2000804@oracle.com>
References: <514C706B.8000508@oracle.com> <515186AE.7040003@oracle.com>
	<51519F64.2000804@oracle.com>
Message-ID: <5151ABBC.2050906@oracle.com>

Hi Dan,

thanks for the review!

On 03/26/2013 02:15 PM, Daniel D. Daugherty wrote:
> The HotSpot changes were included in HSX-25-B22 which was
> included in JDK8-B81 which is promoted. Have you rerun the
> tests to make sure that they either pass or that the remaining
> failure modes (if any) are covered by an open bug or bugs?

I have run the tests locally on my computer, and they all pass. The 
tests are platform independent, so they should (famous last words?) pass 
on all platforms. This is also why I want to enable the tests, to see 
that they work on all platforms.

On 03/26/2013 02:15 PM, Daniel D. Daugherty wrote:
> Thumbs up for the ProblemList.txt change.

Thanks!

Erik

> Dan
>
>
> On 3/26/13 5:29 AM, Erik Helin wrote:
>> Anyone?
>>
>> It is a very small change and I would really like these tests to start
>> running again in the nightly testing.
>>
>> Thanks,
>> Erik
>>
>> On 03/22/2013 03:53 PM, Erik Helin wrote:
>>> Hi all,
>>>
>>> the tests for jstat can be re-enabled now that jstat and the tests for
>>> jstat have been updated to account for metaspace changes [0].
>>>
>>> This change removes the jstat tests (and one jstatd test) from
>>> ProblemList.txt.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/
>>>
>>> Bug:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009427
>>>
>>> Thanks,
>>> Erik
>>>
>>> [0]: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f
>>
>


From staffan.larsen at oracle.com  Tue Mar 26 09:01:34 2013
From: staffan.larsen at oracle.com (Staffan Larsen)
Date: Tue, 26 Mar 2013 17:01:34 +0100
Subject: RFR(XXS): 8007150 Event based tracing is missing truncated field
	in stack trace content type
In-Reply-To: <5150AFF8.6090600@oracle.com>
References: <5150AFF8.6090600@oracle.com>
Message-ID: <876117C6-15AB-4682-92EF-BD324B1B837D@oracle.com>

Looks good.

/Staffan

On 25 mar 2013, at 21:13, Erik Gahlin  wrote:

> Hi,
> 
> Could you please review this small change to the metadata for StackTrace content type, used by the event tracing framework. A boolean flag has been added so it's possible to see if a stack trace has been truncated (not all frames included).
> 
> http://cr.openjdk.java.net/~egahlin/8007150_1/
> 
> The fix is targeted for hs24.
> 
> Thanks
> Erik


From serguei.spitsyn at oracle.com  Tue Mar 26 10:09:05 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 26 Mar 2013 10:09:05 -0700
Subject: hs25 review request: 8008511 JSR 292: MemberName vmtarget refs
	to methods must be updated at class redefinition
In-Reply-To: <515167AD.5040606@oracle.com>
References: <513E8B88.6070904@oracle.com> <51515E3C.7040307@oracle.com>
	<515167AD.5040606@oracle.com>
Message-ID: <5151D631.107@oracle.com>

Hi David,

Thank you for your opinion and concern on this!

The removal of the NoSafepointVerifier is the biggest concern in this fix.
It was raised in the preliminary review and already discussed a little bit.
Now I hope to clear it up during the open code review.
John wanted to look at it more closely but did not have enough time yet.

Thanks,
Serguei


On 3/26/13 2:17 AM, David Holmes wrote:
> Hi Serguei,
>
> The removal of the NoSafepointVerifier could be problematic. If that 
> method is never meant to be on the stack when you block for a 
> safepoint then the method is atomic with respect to the safepoint - 
> and so can not suffer interference from actions that occur at a 
> safepoint (like class unloading (?) ). Now I presume that somewhere 
> from that method you end up taking the mutex and so can block at a 
> safepoint (or block on the lock and so still allow a safepoint to 
> occur) - which might invalidate assumptions the method has about 
> "safepoint atomicity".
>
> You need to understand why the NSV was put there in the first place.
>
> David
> ------
>
> On 26/03/2013 6:37 PM, serguei.spitsyn at oracle.com wrote:
>>
>> Please, review the following fix.
>> The fix was preliminarily reviewed by Coleen, Christian
>> and John but still a final and open jdk review is needed.
>> So that, everyone is welcome to review the fix!
>>
>> This is open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8008511-JVMTI-JSR292.1/ 
>>
>>
>> The CR is:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008511
>> https://jbs.oracle.com/bugs/browse/JDK-8008511
>>
>>
>> The problem is that the old version of the bootstrap method is 
>> re-invoked
>> after a popframe from the bootstrap method execution.
>> It is because the MemberName keeps a stale reference to the old method
>> version.
>>
>> The solution (suggested by John Rose) is to lazily create and keep
>> up-to-date a MemberNameTable
>> which plays a role of MemberName cache assosiated with the 
>> InstanceKlass.
>> Then, at the Class redefinition, this cache is used to replace the old
>> method
>> references in the MemberName's with the new method references.
>>
>> The MemberNameTable is based on the GrowableArray.
>> A C_HEAP array is allocated at the first call to
>> InstanceKlass::add_member_name().
>> It is released in the InstanceKlass::release_C_heap_structures().
>>
>> A global week reference to member name oop is stored in the 
>> MemberNameTable.
>> It allowed to avoid having the oops_do() in the MemberNameTable.
>> Also, the MemberNameTable won't hold member name oops in memory.
>>
>> The MemberNameTable_lock mutex is added to serialize MemberNameTable's
>> updates.
>>
>> The following No_Safepoint_Verifier has been disabled:
>> *  src/share/vm/prims/methodHandles.cpp*:
>>
>>     799 int MethodHandles::find_MemberNames(Klass* k,
>>     . . .
>>     803 DEBUG_ONLY(No_Safepoint_Verifier nsv);
>>
>>      It is probably Ok, but, please, let me know if it is not.
>>      The assert related to locking is fired if it is not disabled.
>>
>> Test coverage: vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms
>> (32 vs 64-bit too).
>> The testing looks good so far.
>>
>>
>> Thanks,
>> Serguei
>>
>>


From rickard.backman at oracle.com  Tue Mar 26 12:39:27 2013
From: rickard.backman at oracle.com (rickard.backman at oracle.com)
Date: Tue, 26 Mar 2013 19:39:27 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8009382: Add
	JVM_Get{Field|Method}TypeAnnotations
Message-ID: <20130326193931.2BB94483EB@hg.openjdk.java.net>

Changeset: 1916ca1dec2f
Author:    rbackman
Date:      2013-03-26 15:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1916ca1dec2f

8009382: Add JVM_Get{Field|Method}TypeAnnotations
Reviewed-by: dcubed, rbackman
Contributed-by: Joel Borggren-Franck 

! make/bsd/makefiles/mapfile-vers-debug
! make/bsd/makefiles/mapfile-vers-product
! make/linux/makefiles/mapfile-vers-debug
! make/linux/makefiles/mapfile-vers-product
! make/solaris/makefiles/mapfile-vers
! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvm.h


From martinrb at google.com  Tue Mar 26 13:41:30 2013
From: martinrb at google.com (martinrb at google.com)
Date: Tue, 26 Mar 2013 20:41:30 +0000
Subject: hg: jdk8/tl/jdk: 2 new changesets
Message-ID: <20130326204203.53C25483EF@hg.openjdk.java.net>

Changeset: 3b56ef8e1ce1
Author:    martin
Date:      2013-03-26 13:34 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b56ef8e1ce1

8007905: To add a system property to create zip file without using ZIP64 end table when entry count > 64k
Summary: Provide a system property to inhibit ZIP64 mode for >64k entries
Reviewed-by: alanb, sherman

! src/share/classes/java/util/zip/ZipOutputStream.java
+ test/java/util/zip/EntryCount64k.java

Changeset: 266b43683a2c
Author:    martin
Date:      2013-03-26 13:36 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/266b43683a2c

8010316: Improve handling of char sequences containing surrogates
Summary: Fix and optimize codePointAt, codePointBefore and similar methods
Reviewed-by: sherman, okutsu, ulfzibis, kizune

! src/share/classes/java/lang/AbstractStringBuilder.java
! src/share/classes/java/lang/Character.java
! test/java/lang/StringBuilder/Supplementary.java


From mandy.chung at oracle.com  Tue Mar 26 14:46:48 2013
From: mandy.chung at oracle.com (Mandy Chung)
Date: Tue, 26 Mar 2013 14:46:48 -0700
Subject: RFR (XS): 8009427: Re-enable tests that were disable to ease
	complicated push
In-Reply-To: <515186AE.7040003@oracle.com>
References: <514C706B.8000508@oracle.com> <515186AE.7040003@oracle.com>
Message-ID: <51521748.4050608@oracle.com>

Thumbs up.

Mandy

On 3/26/13 4:29 AM, Erik Helin wrote:
> Anyone?
>
> It is a very small change and I would really like these tests to start 
> running again in the nightly testing.
>
> Thanks,
> Erik
>
> On 03/22/2013 03:53 PM, Erik Helin wrote:
>> Hi all,
>>
>> the tests for jstat can be re-enabled now that jstat and the tests for
>> jstat have been updated to account for metaspace changes [0].
>>
>> This change removes the jstat tests (and one jstatd test) from
>> ProblemList.txt.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/
>>
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009427
>>
>> Thanks,
>> Erik
>>
>> [0]: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/518d6087e01f
>


From harold.seigel at oracle.com  Tue Mar 26 15:12:08 2013
From: harold.seigel at oracle.com (harold.seigel at oracle.com)
Date: Tue, 26 Mar 2013 22:12:08 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130326221214.1C43F483F5@hg.openjdk.java.net>

Changeset: 36376b540a98
Author:    hseigel
Date:      2013-03-26 09:06 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/36376b540a98

8009595: The UseSplitVerifier option needs to be deprecated.
Summary: Put UseSplitVerifier option on the deprecated list.
Reviewed-by: dcubed, kmo, acorn

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/verifier.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: a8016373a893
Author:    hseigel
Date:      2013-03-26 12:43 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a8016373a893

Merge



From coleen.phillimore at oracle.com  Tue Mar 26 15:11:46 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 26 Mar 2013 18:11:46 -0400
Subject: RFR (s): 8009531: Crash when redefining class with annotated method
Message-ID: <51521D22.4060508@oracle.com>

Summary: Neglected to copy the annotations in clone_with_new_data when 
they were moved to ConstMethod.

open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531

Also. please review JDK test modified to test that this crash is fixed 
(will check in in two weeks).

open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk

Thanks,
Coleen







From karen.kinnear at oracle.com  Tue Mar 26 15:37:25 2013
From: karen.kinnear at oracle.com (Karen Kinnear)
Date: Tue, 26 Mar 2013 15:37:25 -0700 (PDT)
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51521D22.4060508@oracle.com>
References: <51521D22.4060508@oracle.com>
Message-ID: 

Coleen,

Looks good.

thanks,
Karen

On Mar 26, 2013, at 6:11 PM, Coleen Phillimore wrote:

> Summary: Neglected to copy the annotations in clone_with_new_data when they were moved to ConstMethod.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
> 
> Also. please review JDK test modified to test that this crash is fixed (will check in in two weeks).
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
> 
> Thanks,
> Coleen
> 
> 
> 
> 
> 
> 


From serguei.spitsyn at oracle.com  Tue Mar 26 16:00:15 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 26 Mar 2013 16:00:15 -0700 (PDT)
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51521D22.4060508@oracle.com>
References: <51521D22.4060508@oracle.com>
Message-ID: <5152287F.9040801@oracle.com>

Coleen,

This does not look like a clone or copy, it just sets the value?

  366 void ConstMethod::copy_annotations(ConstMethod* cm) {
  367   if (cm->has_method_annotations()) {
  368     assert(has_method_annotations(), "should be allocated already");
  369     set_method_annotations(cm->method_annotations());
  370   }
  ...

Do we have to actually clone the annotations?
If not, then the name "copy_annotations" is wrong.
It must be "set_annotations".

The test fixes look Ok.

Thanks,
Serguei


On 3/26/13 3:11 PM, Coleen Phillimore wrote:
> Summary: Neglected to copy the annotations in clone_with_new_data when 
> they were moved to ConstMethod.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>
> Also. please review JDK test modified to test that this crash is fixed 
> (will check in in two weeks).
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
>
> Thanks,
> Coleen
>
>
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130326/9f964c9b/attachment.html 

From coleen.phillimore at oracle.com  Tue Mar 26 15:58:48 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 26 Mar 2013 18:58:48 -0400
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <5152287F.9040801@oracle.com>
References: <51521D22.4060508@oracle.com> <5152287F.9040801@oracle.com>
Message-ID: <51522828.6020003@oracle.com>


It copies the pointers.  I can't change it to set_annotations because 
there are already set_ functions.  O could change to 
copy_annotation_pointers() if you insist.

Coleen

On 03/26/2013 07:00 PM, serguei.spitsyn at oracle.com wrote:
> Coleen,
>
> This does not look like a clone or copy, it just sets the value?
>   366 void ConstMethod::copy_annotations(ConstMethod* cm) {
>   367   if (cm->has_method_annotations()) {
>   368     assert(has_method_annotations(), "should be allocated already");
>   369     set_method_annotations(cm->method_annotations());
>   370   }
>   ...
>
> Do we have to actually clone the annotations?
> If not, then the name "copy_annotations" is wrong.
> It must be "set_annotations".
>
> The test fixes look Ok.
>
> Thanks,
> Serguei
>
>
> On 3/26/13 3:11 PM, Coleen Phillimore wrote:
>> Summary: Neglected to copy the annotations in clone_with_new_data 
>> when they were moved to ConstMethod.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>>
>> Also. please review JDK test modified to test that this crash is 
>> fixed (will check in in two weeks).
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
>>
>> Thanks,
>> Coleen
>>
>>
>>
>>
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130326/094f0201/attachment-0001.html 

From serguei.spitsyn at oracle.com  Tue Mar 26 16:24:28 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 26 Mar 2013 16:24:28 -0700
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51522828.6020003@oracle.com>
References: <51521D22.4060508@oracle.com> <5152287F.9040801@oracle.com>
	<51522828.6020003@oracle.com>
Message-ID: <51522E2C.5010206@oracle.com>

Copy usually means copying values by pointers.
Not clear what's wrong with the "set_annotations" as there is no such 
function yet.
Probably, you find it confusing too.
But I'm not insisting on the copy_annotation_pointers() either. :)
Let's keep it as it is.

Thanks,
Serguei


On 3/26/13 3:58 PM, Coleen Phillimore wrote:
>
> It copies the pointers.  I can't change it to set_annotations because 
> there are already set_ functions.  O could change to 
> copy_annotation_pointers() if you insist.
>
> Coleen
>
> On 03/26/2013 07:00 PM, serguei.spitsyn at oracle.com wrote:
>> Coleen,
>>
>> This does not look like a clone or copy, it just sets the value?
>>   366 void ConstMethod::copy_annotations(ConstMethod* cm) {
>>   367   if (cm->has_method_annotations()) {
>>   368     assert(has_method_annotations(), "should be allocated already");
>>   369     set_method_annotations(cm->method_annotations());
>>   370   }
>>   ...
>>
>> Do we have to actually clone the annotations?
>> If not, then the name "copy_annotations" is wrong.
>> It must be "set_annotations".
>>
>> The test fixes look Ok.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 3/26/13 3:11 PM, Coleen Phillimore wrote:
>>> Summary: Neglected to copy the annotations in clone_with_new_data 
>>> when they were moved to ConstMethod.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>>>
>>> Also. please review JDK test modified to test that this crash is 
>>> fixed (will check in in two weeks).
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
>>>
>>> Thanks,
>>> Coleen
>>>
>>>
>>>
>>>
>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130326/15a3b919/attachment.html 

From joe.darcy at oracle.com  Tue Mar 26 17:17:33 2013
From: joe.darcy at oracle.com (joe.darcy at oracle.com)
Date: Wed, 27 Mar 2013 00:17:33 +0000
Subject: hg: jdk8/tl/langtools: 7041251: Use j.u.Objects utility methods in
	langtools
Message-ID: <20130327001738.A090C48400@hg.openjdk.java.net>

Changeset: 330b35b27e68
Author:    darcy
Date:      2013-03-26 17:17 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/330b35b27e68

7041251: Use j.u.Objects utility methods in langtools
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/Pair.java
! src/share/classes/javax/annotation/processing/AbstractProcessor.java


From coleen.phillimore at oracle.com  Tue Mar 26 17:17:07 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Tue, 26 Mar 2013 20:17:07 -0400
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51522E2C.5010206@oracle.com>
References: <51521D22.4060508@oracle.com> <5152287F.9040801@oracle.com>
	<51522828.6020003@oracle.com> <51522E2C.5010206@oracle.com>
Message-ID: <51523A83.1070703@oracle.com>


On 03/26/2013 07:24 PM, serguei.spitsyn at oracle.com wrote:
> Copy usually means copying values by pointers.
> Not clear what's wrong with the "set_annotations" as there is no such 
> function yet.


There are set_x_annotations and I wouldn't want someone to think 
set_annotations just sets one sort.  I don't know, it's just opinion.

> Probably, you find it confusing too.
> But I'm not insisting on the copy_annotation_pointers() either. :)
> Let's keep it as it is.

Thanks for the code review!
Coleen

>
> Thanks,
> Serguei
>
>
> On 3/26/13 3:58 PM, Coleen Phillimore wrote:
>>
>> It copies the pointers.  I can't change it to set_annotations because 
>> there are already set_ functions.  O could change to 
>> copy_annotation_pointers() if you insist.
>>
>> Coleen
>>
>> On 03/26/2013 07:00 PM, serguei.spitsyn at oracle.com wrote:
>>> Coleen,
>>>
>>> This does not look like a clone or copy, it just sets the value?
>>>   366 void ConstMethod::copy_annotations(ConstMethod* cm) {
>>>   367   if (cm->has_method_annotations()) {
>>>   368     assert(has_method_annotations(), "should be allocated already");
>>>   369     set_method_annotations(cm->method_annotations());
>>>   370   }
>>>   ...
>>>
>>> Do we have to actually clone the annotations?
>>> If not, then the name "copy_annotations" is wrong.
>>> It must be "set_annotations".
>>>
>>> The test fixes look Ok.
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>> On 3/26/13 3:11 PM, Coleen Phillimore wrote:
>>>> Summary: Neglected to copy the annotations in clone_with_new_data 
>>>> when they were moved to ConstMethod.
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>>>>
>>>> Also. please review JDK test modified to test that this crash is 
>>>> fixed (will check in in two weeks).
>>>>
>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
>>>>
>>>> Thanks,
>>>> Coleen
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130326/6ecd4cd8/attachment.html 

From serguei.spitsyn at oracle.com  Tue Mar 26 17:27:54 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Tue, 26 Mar 2013 17:27:54 -0700
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51523A83.1070703@oracle.com>
References: <51521D22.4060508@oracle.com> <5152287F.9040801@oracle.com>
	<51522828.6020003@oracle.com> <51522E2C.5010206@oracle.com>
	<51523A83.1070703@oracle.com>
Message-ID: <51523D0A.4020604@oracle.com>

On 3/26/13 5:17 PM, Coleen Phillimore wrote:
>
> On 03/26/2013 07:24 PM, serguei.spitsyn at oracle.com wrote:
>> Copy usually means copying values by pointers.
>> Not clear what's wrong with the "set_annotations" as there is no such 
>> function yet.
>
>
> There are set_x_annotations and I wouldn't want someone to think 
> set_annotations just sets one sort.  I don't know, it's just opinion.

Agreed, it'd be confusing too.
Thank you for the clarification!

Thanks,
Serguei

>
>> Probably, you find it confusing too.
>> But I'm not insisting on the copy_annotation_pointers() either. :)
>> Let's keep it as it is.
>
> Thanks for the code review!
> Coleen
>
>>
>> Thanks,
>> Serguei
>>
>>
>> On 3/26/13 3:58 PM, Coleen Phillimore wrote:
>>>
>>> It copies the pointers.  I can't change it to set_annotations 
>>> because there are already set_ functions.  O could change to 
>>> copy_annotation_pointers() if you insist.
>>>
>>> Coleen
>>>
>>> On 03/26/2013 07:00 PM, serguei.spitsyn at oracle.com wrote:
>>>> Coleen,
>>>>
>>>> This does not look like a clone or copy, it just sets the value?
>>>>   366 void ConstMethod::copy_annotations(ConstMethod* cm) {
>>>>   367   if (cm->has_method_annotations()) {
>>>>   368     assert(has_method_annotations(), "should be allocated already");
>>>>   369     set_method_annotations(cm->method_annotations());
>>>>   370   }
>>>>   ...
>>>>
>>>> Do we have to actually clone the annotations?
>>>> If not, then the name "copy_annotations" is wrong.
>>>> It must be "set_annotations".
>>>>
>>>> The test fixes look Ok.
>>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>>
>>>> On 3/26/13 3:11 PM, Coleen Phillimore wrote:
>>>>> Summary: Neglected to copy the annotations in clone_with_new_data 
>>>>> when they were moved to ConstMethod.
>>>>>
>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
>>>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>>>>>
>>>>> Also. please review JDK test modified to test that this crash is 
>>>>> fixed (will check in in two weeks).
>>>>>
>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
>>>>>
>>>>> Thanks,
>>>>> Coleen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130326/809b26c2/attachment-0001.html 

From joe.darcy at oracle.com  Tue Mar 26 18:15:34 2013
From: joe.darcy at oracle.com (joe.darcy at oracle.com)
Date: Wed, 27 Mar 2013 01:15:34 +0000
Subject: hg: jdk8/tl/langtools: 7059170: Assume availablility of
	URLClassLoader.close
Message-ID: <20130327011539.80B7848402@hg.openjdk.java.net>

Changeset: 33b6a52f0037
Author:    darcy
Date:      2013-03-26 18:15 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33b6a52f0037

7059170: Assume availablility of URLClassLoader.close
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java
- src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java


From daniel.daugherty at oracle.com  Tue Mar 26 18:18:36 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Tue, 26 Mar 2013 19:18:36 -0600
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51521D22.4060508@oracle.com>
References: <51521D22.4060508@oracle.com>
Message-ID: <515248EC.6030700@oracle.com>

On 3/26/13 4:11 PM, Coleen Phillimore wrote:
> Summary: Neglected to copy the annotations in clone_with_new_data when 
> they were moved to ConstMethod.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/

Thumbs up! Only a comment suggestion and a naming heckle :-)

src/share/vm/oops/constMethod.cpp
     One line comment on the function:
     // copy annotations from 'cm' to 'this'

src/share/vm/oops/constMethod.hpp
     Perhaps I've been reading too much Java code lately, but
     seemed like the function should be name 'copy_annotations_from()

src/share/vm/oops/method.cpp
     No comments.


> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>
> Also. please review JDK test modified to test that this crash is fixed 
> (will check in in two weeks).
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
>
> Thanks,
> Coleen
>
>
>
>
>
>


From daniel.daugherty at oracle.com  Tue Mar 26 18:27:25 2013
From: daniel.daugherty at oracle.com (Daniel D. Daugherty)
Date: Tue, 26 Mar 2013 19:27:25 -0600
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51521D22.4060508@oracle.com>
References: <51521D22.4060508@oracle.com>
Message-ID: <51524AFD.1080300@oracle.com>

Forgot to comment on the test...


On 3/26/13 4:11 PM, Coleen Phillimore wrote:
> Summary: Neglected to copy the annotations in clone_with_new_data when 
> they were moved to ConstMethod.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>
> Also. please review JDK test modified to test that this crash is fixed 
> (will check in in two weeks).
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
test/java/lang/instrument/RedefineMethodWithAnnotations.sh
     No comments.

test/java/lang/instrument/RedefineMethodWithAnnotationsTarget.java
     The comment says:

     25  * The first version of this class. The second version is in
     26  * RedefineMethodWithAnnotationsTarget_2.java.

     The code says:

     31         System.out.println("Second version of 
annotatedMethod(String)");
     36         System.out.println("Second version of 
annotatedMethod(int)");

     Seems backwards, perhaps just to me.

test/java/lang/instrument/RedefineMethodWithAnnotationsTarget_2.java
     The comment says:

     25  * This is the second version of this class. The first version is in
     26  * RedefineMethodWithAnnotationsTarget.java.

     The code says:

     33         System.out.println("First version of annotatedMethod(int)");
     38         System.out.println("First version of 
annotatedMethod(String)");

     Also seems backwards.

Dan


From zhengyu.gu at oracle.com  Tue Mar 26 18:51:30 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Wed, 27 Mar 2013 01:51:30 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets
Message-ID: <20130327015138.31BF148407@hg.openjdk.java.net>

Changeset: 6b748c9e1845
Author:    zgu
Date:      2013-03-26 14:11 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b748c9e1845

8010651: create.bat still builds the kernel
Summary: Remove old kernel build targets and VS C++ projects created by create.bat on Windows
Reviewed-by: coleenp, sla

! make/windows/build.make
! make/windows/create.bat
! make/windows/makefiles/compile.make
! make/windows/makefiles/product.make
! make/windows/makefiles/vm.make
- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw
! src/share/tools/ProjectCreator/BuildConfig.java
! src/share/tools/ProjectCreator/WinGammaPlatform.java

Changeset: 85192022ba8c
Author:    zgu
Date:      2013-03-26 11:40 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/85192022ba8c

Merge

- test/runtime/8007736/TestStaticIF.java

Changeset: 23f2d309e855
Author:    zgu
Date:      2013-03-26 15:20 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/23f2d309e855

Merge

- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw


From coleen.phillimore at oracle.com  Wed Mar 27 05:11:53 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 27 Mar 2013 08:11:53 -0400
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <515248EC.6030700@oracle.com>
References: <51521D22.4060508@oracle.com> <515248EC.6030700@oracle.com>
Message-ID: <5152E209.70305@oracle.com>

On 3/26/2013 9:18 PM, Daniel D. Daugherty wrote:
> On 3/26/13 4:11 PM, Coleen Phillimore wrote:
>> Summary: Neglected to copy the annotations in clone_with_new_data 
>> when they were moved to ConstMethod.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
>
> Thumbs up! Only a comment suggestion and a naming heckle :-)

Ok!  I like copy_annotations_from so I changed the name and added the 
comment.  Thanks!
Coleen
>
> src/share/vm/oops/constMethod.cpp
>     One line comment on the function:
>     // copy annotations from 'cm' to 'this'
>
> src/share/vm/oops/constMethod.hpp
>     Perhaps I've been reading too much Java code lately, but
>     seemed like the function should be name 'copy_annotations_from()
>
> src/share/vm/oops/method.cpp
>     No comments.
>
>
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>>
>> Also. please review JDK test modified to test that this crash is 
>> fixed (will check in in two weeks).
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
>>
>> Thanks,
>> Coleen
>>
>>
>>
>>
>>
>>
>


From coleen.phillimore at oracle.com  Wed Mar 27 05:12:24 2013
From: coleen.phillimore at oracle.com (Coleen Phillimore)
Date: Wed, 27 Mar 2013 08:12:24 -0400
Subject: RFR (s): 8009531: Crash when redefining class with annotated
	method
In-Reply-To: <51524AFD.1080300@oracle.com>
References: <51521D22.4060508@oracle.com> <51524AFD.1080300@oracle.com>
Message-ID: <5152E228.8@oracle.com>

On 3/26/2013 9:27 PM, Daniel D. Daugherty wrote:
> Forgot to comment on the test...
>
>
> On 3/26/13 4:11 PM, Coleen Phillimore wrote:
>> Summary: Neglected to copy the annotations in clone_with_new_data 
>> when they were moved to ConstMethod.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>>
>> Also. please review JDK test modified to test that this crash is 
>> fixed (will check in in two weeks).
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
> test/java/lang/instrument/RedefineMethodWithAnnotations.sh
>     No comments.
>
> test/java/lang/instrument/RedefineMethodWithAnnotationsTarget.java
>     The comment says:
>
>     25  * The first version of this class. The second version is in
>     26  * RedefineMethodWithAnnotationsTarget_2.java.
>
>     The code says:
>
>     31         System.out.println("Second version of 
> annotatedMethod(String)");
>     36         System.out.println("Second version of 
> annotatedMethod(int)");
>
>     Seems backwards, perhaps just to me.
>
> test/java/lang/instrument/RedefineMethodWithAnnotationsTarget_2.java
>     The comment says:
>
>     25  * This is the second version of this class. The first version 
> is in
>     26  * RedefineMethodWithAnnotationsTarget.java.
>
>     The code says:
>
>     33         System.out.println("First version of 
> annotatedMethod(int)");
>     38         System.out.println("First version of 
> annotatedMethod(String)");
>
>     Also seems backwards.

Oops.  Fixed.
Thanks!
Coleen
>
> Dan
>


From stefan.karlsson at oracle.com  Wed Mar 27 07:23:38 2013
From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com)
Date: Wed, 27 Mar 2013 14:23:38 +0000
Subject: hg: jdk8/tl/jdk: 8009427: Re-enable tests that were disable to ease
	complicated push
Message-ID: <20130327142359.A5C2F48416@hg.openjdk.java.net>

Changeset: caafe6dca35d
Author:    ehelin
Date:      2013-03-21 20:35 +0100
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/caafe6dca35d

8009427: Re-enable tests that were disable to ease complicated push
Reviewed-by: sla, mchung, dcubed
Contributed-by: Erik Helin 

! test/ProblemList.txt


From dan.xu at oracle.com  Wed Mar 27 09:02:17 2013
From: dan.xu at oracle.com (dan.xu at oracle.com)
Date: Wed, 27 Mar 2013 16:02:17 +0000
Subject: hg: jdk8/tl/jdk: 8010837: FileInputStream.available() throw
	IOException when encountering negative available values
Message-ID: <20130327160234.87FFE4841B@hg.openjdk.java.net>

Changeset: 49602f599c08
Author:    dxu
Date:      2013-03-27 09:00 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49602f599c08

8010837: FileInputStream.available() throw IOException when encountering negative available values
Summary: Remove the check in the native code to allow negative values
Reviewed-by: mchung

! src/solaris/native/java/io/io_util_md.c
+ test/java/io/FileInputStream/NegativeAvailable.java


From peter.allwin at oracle.com  Wed Mar 27 09:29:29 2013
From: peter.allwin at oracle.com (Peter Allwin)
Date: Wed, 27 Mar 2013 17:29:29 +0100
Subject: Review Request: 8002118: WindbgDebuggerLocal should not try to load
	64-bit debug libraries for 32-bit JVM
Message-ID: <51531E69.7040000@oracle.com>

Webrev:
http://cr.openjdk.java.net/~sla/peter/8002118/webrev.01/

CR:
http://bugs.sun.com/view_bug.do?bug_id=8002118
https://jbs.oracle.com/bugs/browse/JDK-8002118


Problem is that on Windows we probe for dbghelp.dll on a number of 
different places, and that list always included \Program Files\Debugging 
Tools for Windows (x64) even if we're running x86, leading to an 
UnsatisfiedLinkError during load.

Fix is to add the ...(x64) path only if we're on amd64, and ...(x86) 
only if we're on x86. The affected tests have been verified to work with 
this fix.


Thanks to Staffan for helping out and hosting the webrev!

Regards,

/peter



From joe.darcy at oracle.com  Wed Mar 27 09:39:26 2013
From: joe.darcy at oracle.com (joe.darcy at oracle.com)
Date: Wed, 27 Mar 2013 16:39:26 +0000
Subject: hg: jdk8/tl/jdk: 7185456: (ann) Optimize Annotation handling in
	java/sun.reflect.* code for small number of annotations
Message-ID: <20130327163947.9634348424@hg.openjdk.java.net>

Changeset: ae03282ba501
Author:    darcy
Date:      2013-03-27 09:38 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae03282ba501

7185456: (ann) Optimize Annotation handling in java/sun.reflect.* code for small number of annotations
Reviewed-by: mduigou, jfranck

! src/share/classes/sun/reflect/annotation/AnnotationType.java


From karen.kinnear at oracle.com  Wed Mar 27 10:58:32 2013
From: karen.kinnear at oracle.com (karen.kinnear at oracle.com)
Date: Wed, 27 Mar 2013 17:58:32 +0000
Subject: hg: jdk8/tl/jdk: 8010846: Update the corresponding test in
	test/vm/verifier/TestStaticIF.java
Message-ID: <20130327175853.38B7248427@hg.openjdk.java.net>

Changeset: d254a5f9b93f
Author:    acorn
Date:      2013-03-27 13:40 -0400
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d254a5f9b93f

8010846: Update the corresponding test in test/vm/verifier/TestStaticIF.java
Summary: Remove test flag -XX:-UseSplitVerifier, not supported classfile 52
Reviewed-by: acorn, hseigel

! test/vm/verifier/TestStaticIF.java


From serguei.spitsyn at oracle.com  Wed Mar 27 11:32:29 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Wed, 27 Mar 2013 11:32:29 -0700
Subject: Review Request: 8002118: WindbgDebuggerLocal should not try to
	load 64-bit debug libraries for 32-bit JVM
In-Reply-To: <51531E69.7040000@oracle.com>
References: <51531E69.7040000@oracle.com>
Message-ID: <51533B3D.8000503@oracle.com>

Hi Peter,

The fix looks good.

Thanks,
Serguei

On 3/27/13 9:29 AM, Peter Allwin wrote:
> Webrev:
> http://cr.openjdk.java.net/~sla/peter/8002118/webrev.01/
>
> CR:
> http://bugs.sun.com/view_bug.do?bug_id=8002118
> https://jbs.oracle.com/bugs/browse/JDK-8002118
>
>
> Problem is that on Windows we probe for dbghelp.dll on a number of 
> different places, and that list always included \Program 
> Files\Debugging Tools for Windows (x64) even if we're running x86, 
> leading to an UnsatisfiedLinkError during load.
>
> Fix is to add the ...(x64) path only if we're on amd64, and ...(x86) 
> only if we're on x86. The affected tests have been verified to work 
> with this fix.
>
>
> Thanks to Staffan for helping out and hosting the webrev!
>
> Regards,
>
> /peter
>
>


From coleen.phillimore at oracle.com  Wed Mar 27 13:19:26 2013
From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com)
Date: Wed, 27 Mar 2013 20:19:26 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8009531: Crash when redefining class with
	annotated method
Message-ID: <20130327201930.6A96D4842D@hg.openjdk.java.net>

Changeset: 0c3ee6f1fa23
Author:    coleenp
Date:      2013-03-27 08:19 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0c3ee6f1fa23

8009531: Crash when redefining class with annotated method
Summary: Neglected to copy the annotations in clone_with_new_data when they were moved to ConstMethod.
Reviewed-by: acorn, sspitsyn, dcubed

! src/share/vm/oops/constMethod.cpp
! src/share/vm/oops/constMethod.hpp
! src/share/vm/oops/method.cpp


From christian.tornqvist at oracle.com  Wed Mar 27 14:52:12 2013
From: christian.tornqvist at oracle.com (Christian Tornqvist)
Date: Wed, 27 Mar 2013 22:52:12 +0100
Subject: Review Request: 8002118: WindbgDebuggerLocal should not try to
	load	64-bit debug libraries for 32-bit JVM
In-Reply-To: <51531E69.7040000@oracle.com>
References: <51531E69.7040000@oracle.com>
Message-ID: <015101ce2b35$57bcdfe0$07369fa0$@tornqvist@oracle.com>

I'm quite certain there will never be a \Program Files (x64)\. On 64bit systems there's \Program Files\ and \Program Files (x86)\, on a 32bit systems there will only be a \Program Files\. So it would make sense to add \Program Files (x86)\ if we're running a 32bit JVM since we might be on a 64bit version of Windows.

Thanks,
Christian

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Peter Allwin
Sent: den 27 mars 2013 17:29
To: serviceability-dev at openjdk.java.net; hotspot-dev at openjdk.java.net
Subject: Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM

Webrev:
http://cr.openjdk.java.net/~sla/peter/8002118/webrev.01/

CR:
http://bugs.sun.com/view_bug.do?bug_id=8002118
https://jbs.oracle.com/bugs/browse/JDK-8002118


Problem is that on Windows we probe for dbghelp.dll on a number of different places, and that list always included \Program Files\Debugging Tools for Windows (x64) even if we're running x86, leading to an UnsatisfiedLinkError during load.

Fix is to add the ...(x64) path only if we're on amd64, and ...(x86) only if we're on x86. The affected tests have been verified to work with this fix.


Thanks to Staffan for helping out and hosting the webrev!

Regards,

/peter




From harold.seigel at oracle.com  Wed Mar 27 16:24:38 2013
From: harold.seigel at oracle.com (harold.seigel at oracle.com)
Date: Wed, 27 Mar 2013 23:24:38 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130327232445.97DC848439@hg.openjdk.java.net>

Changeset: aa758f0c5b1c
Author:    hseigel
Date:      2013-03-27 11:41 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa758f0c5b1c

8010833: Test7116786.java is failing on most configs after fix for 8010667
Summary: Update test to recognize that non-zero pad bytes for lookupswitch/tablewsitch opcodes are now valid.
Reviewed-by: dcubed, twisti, kvn, coleenp, dholmes

! test/runtime/7116786/Test7116786.java

Changeset: b601102d00c8
Author:    hseigel
Date:      2013-03-27 13:26 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b601102d00c8

Merge



From serguei.spitsyn at oracle.com  Wed Mar 27 16:45:04 2013
From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com)
Date: Wed, 27 Mar 2013 16:45:04 -0700
Subject: hs25 review request: 8007037 JSR 292: the
	VM_RedefineClasses::append_entry()
	should do cross-checks with indy operands
Message-ID: <51538480.4010504@oracle.com>

Please, review the hs25 fix below.

Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.1/

CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007037
https://jbs.oracle.com/bugs/browse/JDK-8007037


References from INDY bootstrap method specifier operands to CP entries
and back must be correctly merged at class redefinition.

Some background.

An invokedynamic bytecode spec:
http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.5.invokedynamic

A invokedynamic instruction has an argument which is an index to the 
*Constant Pool* item.
That index must be a symbolic reference to a *call-site specifier*:
http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4.10

A CP item of the type *CONSTANT_InvokeDynamic_inf* has an index into
the *bootstrap method attribute* of the class file:
http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.21

The *|BootstrapMethods|* attribute elements normally have references to 
other *Constant Pool* items.

In VM the *bootstrap method attribute* is represented by the *operands* 
array of the *ConstantPool*.

The problem is is that all the force and back cross links between 
*ConstantPool* elements
and *operands* array elements must be correctly merged at class 
redefinition.

Test coverage:
   vm.mlvm, nsk.jvmti, nsk.jdi tests on multiple platforms (32 vs 64-bit 
too).
   The testing looks good so far.
   One difficulty is that new vm.mlvm tests are currently failed because 
of multiple reasons.


Thanks,
Serguei


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130327/e2bc57f8/attachment.html 

From karen.kinnear at oracle.com  Wed Mar 27 22:00:36 2013
From: karen.kinnear at oracle.com (karen.kinnear at oracle.com)
Date: Thu, 28 Mar 2013 05:00:36 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130328050044.3889E4844F@hg.openjdk.java.net>

Changeset: cd3089a56438
Author:    acorn
Date:      2013-03-27 14:10 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd3089a56438

8009731: Confusing error message for loader constraint violation
Summary: Fix text, overwritten type and holder for resolved method
Reviewed-by: coleenp, dcubed, minqi, dholmes

! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/interpreter/linkResolver.cpp
! src/share/vm/oops/klassVtable.cpp

Changeset: 53f4040e809c
Author:    acorn
Date:      2013-03-27 16:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/53f4040e809c

Merge



From zhengyu.gu at oracle.com  Thu Mar 28 00:38:10 2013
From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com)
Date: Thu, 28 Mar 2013 07:38:10 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets
Message-ID: <20130328073819.9191D48456@hg.openjdk.java.net>

Changeset: b5bae74160b7
Author:    zgu
Date:      2013-03-27 15:41 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5bae74160b7

8010474: [parfait] Undefined return value of the functions in hotspot/src/share/vm/services/memTracker.hpp
Summary: Fixed functions that miss return values
Reviewed-by: coleenp, acorn, kvn

! src/share/vm/services/memTracker.hpp

Changeset: 26e0c03da92c
Author:    zgu
Date:      2013-03-27 13:07 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/26e0c03da92c

Merge

- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw

Changeset: f044c45bee68
Author:    zgu
Date:      2013-03-27 22:05 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f044c45bee68

Merge



From sundararajan.athijegannathan at oracle.com  Thu Mar 28 02:06:59 2013
From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com)
Date: Thu, 28 Mar 2013 09:06:59 +0000
Subject: hg: jdk8/tl/jdk: 8010991: Enable
	test/javax/script/GetInterfaceTest.java again
Message-ID: <20130328090857.B19F448458@hg.openjdk.java.net>

Changeset: 811c771acf65
Author:    sundar
Date:      2013-03-28 14:36 +0530
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/811c771acf65

8010991: Enable test/javax/script/GetInterfaceTest.java again
Reviewed-by: lagergren, hannesw

! test/javax/script/GetInterfaceTest.java


From yumin.qi at oracle.com  Thu Mar 28 03:42:06 2013
From: yumin.qi at oracle.com (yumin.qi at oracle.com)
Date: Thu, 28 Mar 2013 10:42:06 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets
Message-ID: <20130328104228.36DCF48465@hg.openjdk.java.net>

Changeset: 1b90c7607451
Author:    minqi
Date:      2013-03-27 17:03 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1b90c7607451

2178143: JVM crashes if the number of bound CPUs changed during runtime
Summary: Supply a new flag -XX:+AssumeMP to workaround the problem. With the flag is turned on, assume VM run on MP platform so is_MP() will return true that sync calls will not skip away.
Reviewed-by: dholmes, acorn, dcubed, jmasa
Contributed-by: yumin.qi at oracle.com

! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp
! src/share/vm/runtime/os.hpp

Changeset: d7adf726b18a
Author:    minqi
Date:      2013-03-28 00:44 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d7adf726b18a

Merge



From maurizio.cimadamore at oracle.com  Thu Mar 28 04:40:18 2013
From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com)
Date: Thu, 28 Mar 2013 11:40:18 +0000
Subject: hg: jdk8/tl/langtools: 2 new changesets
Message-ID: <20130328114024.08FB148466@hg.openjdk.java.net>

Changeset: 7bebe17ff323
Author:    mcimadamore
Date:      2013-03-28 11:38 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bebe17ff323

8010469: Bad assertion in LambdaToMethod
Summary: Add assertion in LambdaToMethod.serializedLambdaName
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

Changeset: a200d8ccfe47
Author:    mcimadamore
Date:      2013-03-28 11:39 +0000
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a200d8ccfe47

8010490: FindBugs: double assignments in LambdaToMethod.visitIdent
Summary: Remove dead code from LambdaToMethod
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java


From weijun.wang at oracle.com  Thu Mar 28 05:28:44 2013
From: weijun.wang at oracle.com (weijun.wang at oracle.com)
Date: Thu, 28 Mar 2013 12:28:44 +0000
Subject: hg: jdk8/tl/jdk: 8010125: keytool -importkeystore could create a
	pkcs12 keystore with different storepass and keypass
Message-ID: <20130328122907.EE76A48467@hg.openjdk.java.net>

Changeset: a87fac00915e
Author:    weijun
Date:      2013-03-28 20:27 +0800
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a87fac00915e

8010125: keytool -importkeystore could create a pkcs12 keystore with different storepass and keypass
Reviewed-by: vinnie

! src/share/classes/sun/security/tools/keytool/Main.java
! src/share/classes/sun/security/tools/keytool/Resources.java
+ test/sun/security/tools/keytool/p12importks.sh


From brian.goetz at oracle.com  Thu Mar 28 08:34:23 2013
From: brian.goetz at oracle.com (Brian Goetz)
Date: Thu, 28 Mar 2013 08:34:23 -0700
Subject: hg: jdk8/tl/jdk: 8001642: Add Optional, OptionalDouble,
	OptionalInt, OptionalLong
In-Reply-To: 
References: <20130319231031.7F46B48272@hg.openjdk.java.net>
	
Message-ID: 

> Has the optional classes been verified to serialize/deserialize correctly?
> 
They are not serializable.  
> Finally, are these utilities critical to some other part JDK 8 that they were pushed out now as opposed to JDK 9?
> 
> 
They are part of the libraries being added by JSR-335 / Project Lambda.  There is extensive discussion on Optional on lambda-dev and the JSR 335 EG lists.  


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130328/593b9a39/attachment.html 

From jonathan.gibbons at oracle.com  Thu Mar 28 10:49:57 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Thu, 28 Mar 2013 17:49:57 +0000
Subject: hg: jdk8/tl/langtools: 8006346: doclint should make allowance for
	headers generated by standard doclet
Message-ID: <20130328175002.0B94F48470@hg.openjdk.java.net>

Changeset: 991f11e13598
Author:    jjg
Date:      2013-03-28 10:49 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/991f11e13598

8006346: doclint should make allowance for headers generated by standard doclet
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/doclint/Checker.java
! src/share/classes/com/sun/tools/doclint/DocLint.java
! src/share/classes/com/sun/tools/doclint/Env.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/sun/tools/javadoc/DocEnv.java
+ test/tools/javac/doclint/ImplicitHeadersTest.java
+ test/tools/javadoc/doclint/ImplicitHeadersTest.java


From jonathan.gibbons at oracle.com  Thu Mar 28 10:59:01 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Thu, 28 Mar 2013 17:59:01 +0000
Subject: hg: jdk8/tl/langtools: 8010511: Tests are creating files in /tmp
Message-ID: <20130328175906.7F55348471@hg.openjdk.java.net>

Changeset: d3648557391b
Author:    jjg
Date:      2013-03-28 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d3648557391b

8010511: Tests are creating files in /tmp
Reviewed-by: darcy

! test/tools/javac/T6558476.java
! test/tools/javac/T6900149.java
! test/tools/javac/diags/CheckExamples.java
! test/tools/javac/diags/RunExamples.java


From mandy.chung at oracle.com  Thu Mar 28 13:16:32 2013
From: mandy.chung at oracle.com (mandy.chung at oracle.com)
Date: Thu, 28 Mar 2013 20:16:32 +0000
Subject: hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable
	performance by direct mapping from an integer to Level
Message-ID: <20130328201656.E120C48477@hg.openjdk.java.net>

Changeset: e433ed08b733
Author:    mchung
Date:      2013-03-28 13:14 -0700
URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e433ed08b733

8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level
Reviewed-by: mchung
Contributed-by: peter.levart at gmail.com, bourges.laurent at gmail.com

! src/share/classes/sun/util/logging/PlatformLogger.java
! test/sun/util/logging/PlatformLoggerTest.java


From john.coomes at oracle.com  Thu Mar 28 20:58:46 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 29 Mar 2013 03:58:46 +0000
Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b83 for changeset
	a45bb25a67c7
Message-ID: <20130329035849.1ACCC484A9@hg.openjdk.java.net>

Changeset: 14f1babaf548
Author:    katleman
Date:      2013-03-28 10:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/14f1babaf548

Added tag jdk8-b83 for changeset a45bb25a67c7

! .hgtags


From john.coomes at oracle.com  Thu Mar 28 20:59:11 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 29 Mar 2013 03:59:11 +0000
Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b83 for changeset
	a1dcc0d83da1
Message-ID: <20130329035916.27ADA484AB@hg.openjdk.java.net>

Changeset: 54c29eb352e7
Author:    katleman
Date:      2013-03-28 10:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/54c29eb352e7

Added tag jdk8-b83 for changeset a1dcc0d83da1

! .hgtags


From john.coomes at oracle.com  Thu Mar 28 20:58:42 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 29 Mar 2013 03:58:42 +0000
Subject: hg: hsx/hotspot-rt: Added tag jdk8-b83 for changeset 466685ba01bf
Message-ID: <20130329035842.25B75484A8@hg.openjdk.java.net>

Changeset: d409b4cdb74f
Author:    katleman
Date:      2013-03-28 10:53 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/rev/d409b4cdb74f

Added tag jdk8-b83 for changeset 466685ba01bf

! .hgtags


From john.coomes at oracle.com  Thu Mar 28 20:58:54 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 29 Mar 2013 03:58:54 +0000
Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b83 for changeset a46d69a1a8ec
Message-ID: <20130329035905.36958484AA@hg.openjdk.java.net>

Changeset: f5f40094ffcc
Author:    katleman
Date:      2013-03-28 10:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/f5f40094ffcc

Added tag jdk8-b83 for changeset a46d69a1a8ec

! .hgtags


From john.coomes at oracle.com  Thu Mar 28 21:02:32 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 29 Mar 2013 04:02:32 +0000
Subject: hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b83 for changeset
	053d7c55dc82
Message-ID: <20130329040234.10F83484AE@hg.openjdk.java.net>

Changeset: fbbdef940138
Author:    katleman
Date:      2013-03-28 10:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/fbbdef940138

Added tag jdk8-b83 for changeset 053d7c55dc82

! .hgtags


From john.coomes at oracle.com  Thu Mar 28 20:59:25 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 29 Mar 2013 03:59:25 +0000
Subject: hg: hsx/hotspot-rt/jdk: 3 new changesets
Message-ID: <20130329040108.3D5A4484AC@hg.openjdk.java.net>

Changeset: 6782f2c46bca
Author:    wetmore
Date:      2013-03-21 16:31 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6782f2c46bca

8009517: new code changes causing errors in old build (-Werror) environment
Reviewed-by: mduigou

! make/com/sun/org/apache/xml/Makefile
! make/javax/others/Makefile

Changeset: ac519af51769
Author:    dcherepanov
Date:      2013-03-27 08:32 +0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ac519af51769

Merge


Changeset: 8cc500af2454
Author:    katleman
Date:      2013-03-28 10:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8cc500af2454

Added tag jdk8-b83 for changeset ac519af51769

! .hgtags


From john.coomes at oracle.com  Thu Mar 28 21:02:15 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 29 Mar 2013 04:02:15 +0000
Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b83 for changeset
	22ba3f92d4ae
Message-ID: <20130329040226.C013E484AD@hg.openjdk.java.net>

Changeset: 35cef52b0023
Author:    katleman
Date:      2013-03-28 10:55 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/35cef52b0023

Added tag jdk8-b83 for changeset 22ba3f92d4ae

! .hgtags


From daniel.daugherty at oracle.com  Fri Mar 29 15:45:01 2013
From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com)
Date: Fri, 29 Mar 2013 22:45:01 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 14 new changesets
Message-ID: <20130329224531.3E08D484C9@hg.openjdk.java.net>

Changeset: 7f16d1812865
Author:    tamao
Date:      2013-03-20 12:27 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7f16d1812865

7196080: assert(max_heap >= InitialHeapSize) in arguments.cpp
Summary: Remove the related assertions becasue they do not hold here.
Reviewed-by: jmasa, tschatzl
Contributed-by: tamao 

! src/share/vm/runtime/arguments.cpp

Changeset: dbd5837b342f
Author:    ehelin
Date:      2013-03-22 16:10 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dbd5837b342f

8000754: NPG: Implement a MemoryPool MXBean for Metaspace
Reviewed-by: jmasa, stefank

! src/share/vm/memory/metaspace.hpp
! src/share/vm/memory/universe.cpp
! src/share/vm/services/memoryManager.cpp
! src/share/vm/services/memoryManager.hpp
! src/share/vm/services/memoryPool.cpp
! src/share/vm/services/memoryPool.hpp
! src/share/vm/services/memoryService.cpp
! src/share/vm/services/memoryService.hpp
+ test/gc/metaspace/TestMetaspaceMemoryPools.java

Changeset: 338b3a9e29b5
Author:    stefank
Date:      2013-03-25 11:00 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/338b3a9e29b5

Merge

! src/share/vm/services/memoryService.cpp

Changeset: 42e370795a39
Author:    ehelin
Date:      2013-03-27 10:55 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/42e370795a39

8010818: NPG: Remove metaspace memory pools
Reviewed-by: mgerdin, stefank

! src/share/vm/memory/metaspace.hpp
! src/share/vm/memory/universe.cpp
! src/share/vm/services/memoryManager.cpp
! src/share/vm/services/memoryManager.hpp
! src/share/vm/services/memoryPool.cpp
! src/share/vm/services/memoryPool.hpp
! src/share/vm/services/memoryService.cpp
! src/share/vm/services/memoryService.hpp
- test/gc/metaspace/TestMetaspaceMemoryPools.java

Changeset: aeb22fdaa14c
Author:    brutisso
Date:      2013-03-28 09:07 +0100
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aeb22fdaa14c

Merge

! src/share/vm/runtime/arguments.cpp

Changeset: 728b89404e34
Author:    jprovino
Date:      2013-03-21 10:18 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/728b89404e34

8009904: jvmtiClassFileReconstituter.cpp needs to be excluded from the minimal jvm
Summary: jvmtiClassFileReconstituter.cpp needs to be added to the list of files to exclude when JVMTI is excluded from the jvm
Reviewed-by: dholmes, sspitsyn

! make/excludeSrc.make

Changeset: 7ca101eef24a
Author:    jprovino
Date:      2013-03-23 14:59 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7ca101eef24a

Merge


Changeset: 04d6d4322c6a
Author:    collins
Date:      2013-03-27 09:49 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/04d6d4322c6a

8009152: A number of jtreg tests need review/improvement
Summary: Added a new test_env.txt file to capture common shell variable. Added concept of COMPILEJAVA for use when TESTJAVA is a JRE. If COMPILEJAVA not set then TESTJAVA will be the default with assumption it is a JDK.
Reviewed-by: kvn, brutisso, coleenp

! test/compiler/5091921/Test6890943.sh
! test/compiler/5091921/Test7005594.sh
! test/compiler/6857159/Test6857159.sh
! test/compiler/7068051/Test7068051.sh
! test/compiler/7070134/Test7070134.sh
! test/compiler/7200264/Test7200264.sh
! test/gc/6941923/test6941923.sh
! test/runtime/6626217/Test6626217.sh
! test/runtime/6878713/Test6878713.sh
! test/runtime/6929067/Test6929067.sh
! test/runtime/7020373/Test7020373.sh
! test/runtime/7051189/Xchecksig.sh
! test/runtime/7107135/Test7107135.sh
! test/runtime/7110720/Test7110720.sh
! test/runtime/7158804/Test7158804.sh
! test/runtime/7162488/Test7162488.sh
+ test/test_env.sh

Changeset: d1897e7e0488
Author:    collins
Date:      2013-03-28 15:42 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d1897e7e0488

Merge

! test/runtime/6878713/Test6878713.sh

Changeset: e614fc564ded
Author:    katleman
Date:      2013-03-28 10:54 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e614fc564ded

Added tag jdk8-b83 for changeset 1c8db54ee9f3

! .hgtags

Changeset: 8d0f263a370c
Author:    amurillo
Date:      2013-03-28 19:01 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8d0f263a370c

Merge

- make/windows/projectfiles/kernel/Makefile
- make/windows/projectfiles/kernel/vm.def
- make/windows/projectfiles/kernel/vm.dsw
- test/runtime/8007736/TestStaticIF.java

Changeset: af788b85010e
Author:    amurillo
Date:      2013-03-28 19:02 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/af788b85010e

Added tag hs25-b25 for changeset 8d0f263a370c

! .hgtags

Changeset: d26674db4d91
Author:    amurillo
Date:      2013-03-28 19:13 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d26674db4d91

8011022: new hotspot build - hs25-b26
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: c0f9217203b2
Author:    dcubed
Date:      2013-03-29 08:38 -0700
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c0f9217203b2

Merge

! src/share/vm/runtime/arguments.cpp


From coleen.phillimore at oracle.com  Sun Mar 31 21:36:58 2013
From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com)
Date: Mon, 01 Apr 2013 04:36:58 +0000
Subject: hg: hsx/hotspot-rt/hotspot: 8010723: fatal error: acquiring lock
	Metaspace allocation lock/5 out of order
Message-ID: <20130401043703.373C5484F7@hg.openjdk.java.net>

Changeset: d886ac1dfd36
Author:    coleenp
Date:      2013-03-31 21:43 -0400
URL:       http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d886ac1dfd36

8010723: fatal error: acquiring lock Metaspace allocation lock/5 out of order
Summary: Avoid holding SystemDictionary_lock while calling Klass::remove_unshareable_info
Reviewed-by: coleenp, acorn
Contributed-by: ioi.lam at oracle.com

! src/share/vm/classfile/systemDictionary.cpp