Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM

[Christian Tornqvist]

I'm quite certain there will never be a \Program Files (x64)\. On 64bit systems there's \Program Files\ and \Program Files (x86)\, on a 32bit systems there will only be a \Program Files\. So it would make sense to add \Program Files (x86)\ if we're running a 32bit JVM since we might be on a 64bit version of Windows.

Thanks,
Christian

-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Peter Allwin
Sent: den 27 mars 2013 17:29
To: serviceability-dev at openjdk.java.net; hotspot-dev at openjdk.java.net
Subject: Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM

Webrev:
http://cr.openjdk.java.net/~sla/peter/8002118/webrev.01/

CR:
http://bugs.sun.com/view_bug.do?bug_id=8002118
https://jbs.oracle.com/bugs/browse/JDK-8002118


Problem is that on Windows we probe for dbghelp.dll on a number of different places, and that list always included \Program Files\Debugging Tools for Windows (x64) even if we're running x86, leading to an UnsatisfiedLinkError during load.

Fix is to add the ...(x64) path only if we're on amd64, and ...(x86) only if we're on x86. The affected tests have been verified to work with this fix.


Thanks to Staffan for helping out and hosting the webrev!

Regards,

/peter