From chris.hegarty at oracle.com Wed May 1 02:05:22 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 01 May 2013 09:05:22 +0000 Subject: hg: jdk8/tl/jdk: 6594296: NetworkInterface.getHardwareAddress returns zero length byte array Message-ID: <20130501090606.88DF148727@hg.openjdk.java.net> Changeset: dddd17cf61ff Author: chegar Date: 2013-05-01 10:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dddd17cf61ff 6594296: NetworkInterface.getHardwareAddress returns zero length byte array Reviewed-by: alanb ! src/windows/native/java/net/NetworkInterface_winXP.c ! test/java/net/NetworkInterface/Test.java From chris.hegarty at oracle.com Wed May 1 03:16:55 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 01 May 2013 10:16:55 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130501101742.C20AA4872A@hg.openjdk.java.net> Changeset: 73793f2af80a Author: msheppar Date: 2013-04-30 16:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73793f2af80a 8007799: Base64.getEncoder(0, byte[]) returns an encoder that unexpectedly inserts line separators Reviewed-by: sherman, iris ! src/share/classes/java/util/Base64.java + test/java/util/Base64/Base64GetEncoderTest.java Changeset: 5941f7c9c76a Author: chegar Date: 2013-05-01 11:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5941f7c9c76a 8013723: ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt From weijun.wang at oracle.com Wed May 1 06:11:40 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 01 May 2013 13:11:40 +0000 Subject: hg: jdk8/tl/jdk: 8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt Message-ID: <20130501131206.472EC4872D@hg.openjdk.java.net> Changeset: ae4a82e69da2 Author: weijun Date: 2013-05-01 21:05 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae4a82e69da2 8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt Reviewed-by: vinnie ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java + test/sun/security/krb5/auto/SaslGSS.java From mike.duigou at oracle.com Wed May 1 08:37:19 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 01 May 2013 15:37:19 +0000 Subject: hg: jdk8/tl/jdk: 8012665: add CharSequence.chars, CharSequence.codePoints Message-ID: <20130501153732.3B74448732@hg.openjdk.java.net> Changeset: c6aef650e615 Author: mduigou Date: 2013-05-01 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6aef650e615 8012665: add CharSequence.chars, CharSequence.codePoints Reviewed-by: martin, alanb, ulfzibis, mduigou Contributed-by: Stuart Marks , Henry Jen ! src/share/classes/java/lang/CharSequence.java + test/java/lang/CharSequence/DefaultTest.java ! test/java/lang/StringBuffer/TestSynchronization.java From vladimir.danushevsky at oracle.com Wed May 1 08:45:46 2013 From: vladimir.danushevsky at oracle.com (vladimir.danushevsky at oracle.com) Date: Wed, 01 May 2013 15:45:46 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130501154550.807CA4873A@hg.openjdk.java.net> Changeset: b4081e9714ec Author: vladidan Date: 2013-04-30 17:36 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b4081e9714ec 8013398: Adjust number of stack guard pages on systems with large memory page size Summary: Auto adjust number of stack guard pages on systems with large memory page size Reviewed-by: bobv, coleenp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 1847df492437 Author: vladidan Date: 2013-05-01 10:10 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1847df492437 Merge From robert.field at oracle.com Wed May 1 08:46:50 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 01 May 2013 15:46:50 +0000 Subject: hg: jdk8/tl/langtools: 8011591: BootstrapMethodError when capturing constructor ref to local classes Message-ID: <20130501154653.7F0E64873C@hg.openjdk.java.net> Changeset: 8e27e84de2e9 Author: rfield Date: 2013-05-01 08:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e27e84de2e9 8011591: BootstrapMethodError when capturing constructor ref to local classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInnerImplicitArgs.java From bharadwaj.yadavalli at oracle.com Wed May 1 13:23:00 2013 From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com) Date: Wed, 01 May 2013 20:23:00 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130501202305.1724C48752@hg.openjdk.java.net> Changeset: 08236d966eea Author: bharadwaj Date: 2013-05-01 08:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/08236d966eea 8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87 Summary: Do not treat static methods as miranda methods. Reviewed-by: dholmes, acorn ! src/share/vm/oops/klassVtable.cpp + test/runtime/lambda-features/PublicStaticInterfaceMethodHandling.java Changeset: 8fe2542bdc8d Author: bharadwaj Date: 2013-05-01 09:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8fe2542bdc8d Merge From yunda.mly at taobao.com Wed May 1 20:04:43 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 2 May 2013 03:04:43 +0000 Subject: [PATCH]"classes" command of CLHSDB doesn't work References: <51599F75.8020901@oracle.com> Message-ID: Hi all, Could anyone give me some advice on the test code or just push this for me, please? Regards, Yunda From: ??(Yunda) Sent: Wednesday, April 03, 2013 3:34 PM To: 'Coleen Phillimore' Cc: serviceability-dev at openjdk.java.net Subject: RE: [PATCH]"classes" command of CLHSDB doesn't work Coleen, I think the bug can be caused only by executing the "classes" command of CLHSDB since the code is for registering the command. So I don?t know how to test it other than executing the command itself and I don?t find such kind of test that executes CLHSDB commands in current test code(not sure about that and hope someone in Serviceability team could confirm). Regards, Yunda From: Coleen Phillimore [mailto:coleen.phillimore at oracle.com] Sent: Monday, April 01, 2013 10:54 PM To: ??(Yunda) Cc: serviceability-dev at openjdk.java.net Subject: Re: [PATCH]"classes" command of CLHSDB doesn't work Yes, I am sure we missed this with permgen elimination. We didn't test the serviceability agent that thorougly, except for our automated tests. Should there be a test that we can add with this patch? Thanks, Coleen On 04/01/2013 05:54 AM, ??(Yunda) wrote: Hi all, I find that the "classes" command of CLHSDB doesn't work: hsdb> classes Error: java.lang.RuntimeException: javax.script.ScriptException: sun.org.mozilla.javascript.internal.WrappedException: Wrapped java.lang.reflect.UndeclaredThrowableException (sa.js#493) in sa.js at line number 493 So I made a patch to fix this( against the latest hotspot-rt): diff -r c0f9217203b2 agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js --- a/agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js Fri Mar 29 08:38:00 2013 -0700 +++ b/agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js Mon Apr 01 10:52:29 2013 +0800 @@ -235,7 +235,7 @@ this.jclasses = function() { forEachKlass(function (clazz) { - writeln(clazz.getName().asString() + " @" + clazz.getHandle().toString()); + writeln(clazz.getName().asString() + " @" + clazz.getAddress().toString()); }); } registerCommand("classes", "classes", "jclasses"); I think it?s a missed change of NPG, since the same change was made in line 226 in chagetset 3601(JDK-6964458), the main NPG changeset( So I cc-ed Coleen ): 223 if (typeof(name) == "string") { 224 var clazz = sapkg.utilities.SystemDictionaryHelper.findInstanceKlass(name); 225 if (clazz) { 226 writeln(clazz.getName().asString() + " @" + clazz.getAddress().toString()); 227 } else { 228 writeln("class not found: " + name); 229 } Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)????????????????????????????????????????????????????? ????????????????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/7b53f6a3/attachment.html From yunda.mly at taobao.com Wed May 1 20:07:59 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 2 May 2013 03:07:59 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together Message-ID: Could anyone review this for me, please? Regards, Yunda From: ??(Yunda) Sent: Friday, April 19, 2013 4:26 PM To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi all, I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] TLAB Size = 24607080] Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] TLAB Size = 25054480] Allocation in new TLAB: [Class = [CTLAB Size = 24607080] Allocation Size = 72, Class = [C, TLAB Size = 24159728] , Allocation Size = 32, TLAB Size = 23712288] It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 @@ -132,6 +132,7 @@ void writeEvent(void) { ResourceMark rm; HandleMark hm; + ttyLocker ttyl; TraceStream ts(*tty); ts.print(": ["); I searched before sending this mail I didn't find anyone who covering this? Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/a5430e07/attachment-0001.html From rickard.backman at oracle.com Wed May 1 22:11:36 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Thu, 2 May 2013 07:11:36 +0200 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: Message-ID: <858D0DD2-7623-4530-BE77-46357C66DB15@oracle.com> Yunda, the change looks good (not a Reviewer). /R On May 2, 2013, at 5:07 AM, ??(Yunda) wrote: > Could anyone review this for me, please? > > Regards, > Yunda > > From: ??(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net > Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together > > Hi all, > > I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > TLAB Size = 24607080] > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] > TLAB Size = 25054480] > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > , Allocation Size = 32, TLAB Size = 23712288] > > It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(againsthttp://hg.openjdk.java.net/hsx/hsx24/hotspot/): > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 > @@ -132,6 +132,7 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + ttyLocker ttyl; > TraceStream ts(*tty); > ts.print(": ["); > > > > I searched before sending this mail I didn't find anyone who covering thisJ > > Regards, > Yunda > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? From staffan.larsen at oracle.com Thu May 2 01:50:56 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 2 May 2013 10:50:56 +0200 Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes Message-ID: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. Thanks, /Staffan From staffan.larsen at oracle.com Thu May 2 01:51:05 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 2 May 2013 10:51:05 +0200 Subject: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods Message-ID: JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't part of the original class. webrev: http://cr.openjdk.java.net/~sla/8008453/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008453 (not available yet) Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. Thanks, /Staffan From markus.gronlund at oracle.com Thu May 2 01:59:07 2013 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Thu, 2 May 2013 01:59:07 -0700 (PDT) Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes In-Reply-To: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> References: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> Message-ID: Looks good Staffan (not a reviewer). Cheers Markus -----Original Message----- From: Staffan Larsen Sent: den 2 maj 2013 10:51 To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. Thanks, /Staffan From serguei.spitsyn at oracle.com Thu May 2 03:24:50 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 02 May 2013 03:24:50 -0700 Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes In-Reply-To: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> References: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> Message-ID: <51823EF2.9010101@oracle.com> This looks good. Thank you for discovering and fixing it! A couple of cosmetic comments: 352 //} Indent for "}" is needed 376 u2 bootstrap_arguments = cpool()->operand_argument_index_at(n, arg); It is about one argument. Should the variable name be: "bootstrap_argument" ? Thanks, Serguei On 5/2/13 1:50 AM, Staffan Larsen wrote: > JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. > > webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 > > Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist > > I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/4744801a/attachment.html From jaroslav.bachorik at oracle.com Thu May 2 03:39:29 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 02 May 2013 12:39:29 +0200 Subject: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar In-Reply-To: <51794290.7050806@oracle.com> References: <50D302B1.7080203@oracle.com> <50D86A01.2060703@oracle.com> <51793F3B.9020303@oracle.com> <51794290.7050806@oracle.com> Message-ID: <51824261.9060100@oracle.com> On ?t?25.?duben?2013,?16:49:52?CEST, Alan Bateman wrote: > On 25/04/2013 15:35, Jaroslav Bachorik wrote: >> Reviving the review process. >> >> I still need an official openjdk reviewer for this. >> >> Thanks, >> >> -JB- > Just so I understand, the issue is that RemoteServer.getClientHost is > returning a String with an IPv6 literal address so you need to enclose > it in [] when building the connection id. That seems reasonable to me. Exactly. > A minor comment on the wording of the comment it that it would be > clear if there was a comma after "package description". Fixed. > > The test looks okay to me although I had to read it a few times to > understand that :// was being removed from s. I've improved the client address detection - in addition to being more readable it handles properly the : form of the IPv4 address. Update webrev @ http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.02 -JB- > > -Alan. > > From Alan.Bateman at oracle.com Thu May 2 03:48:06 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 02 May 2013 11:48:06 +0100 Subject: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar In-Reply-To: <51824261.9060100@oracle.com> References: <50D302B1.7080203@oracle.com> <50D86A01.2060703@oracle.com> <51793F3B.9020303@oracle.com> <51794290.7050806@oracle.com> <51824261.9060100@oracle.com> Message-ID: <51824466.2020905@oracle.com> On 02/05/2013 11:39, Jaroslav Bachorik wrote: > On ?t 25. duben 2013, 16:49:52 CEST, Alan Bateman wrote: >> On 25/04/2013 15:35, Jaroslav Bachorik wrote: >>> Reviving the review process. >>> >>> I still need an official openjdk reviewer for this. >>> >>> Thanks, >>> >>> -JB- >> Just so I understand, the issue is that RemoteServer.getClientHost is >> returning a String with an IPv6 literal address so you need to enclose >> it in [] when building the connection id. That seems reasonable to me. > Exactly. > >> A minor comment on the wording of the comment it that it would be >> clear if there was a comma after "package description". > Fixed. > >> The test looks okay to me although I had to read it a few times to >> understand that:// was being removed from s. > I've improved the client address detection - in addition to being more > readable it handles properly the: form of the IPv4 > address. > > Update webrev @ > http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.02 > This looks okay to me. A minor comment on the test is that we usually put the "final" after the "private static". Also constants are usually in upper case. -Alan. From jaroslav.bachorik at oracle.com Thu May 2 03:52:33 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 02 May 2013 12:52:33 +0200 Subject: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar In-Reply-To: <51824466.2020905@oracle.com> References: <50D302B1.7080203@oracle.com> <50D86A01.2060703@oracle.com> <51793F3B.9020303@oracle.com> <51794290.7050806@oracle.com> <51824261.9060100@oracle.com> <51824466.2020905@oracle.com> Message-ID: <51824571.6010702@oracle.com> On ?t?2.?kv?ten?2013,?12:48:06?CEST, Alan Bateman wrote: > On 02/05/2013 11:39, Jaroslav Bachorik wrote: >> On ?t 25. duben 2013, 16:49:52 CEST, Alan Bateman wrote: >>> On 25/04/2013 15:35, Jaroslav Bachorik wrote: >>>> Reviving the review process. >>>> >>>> I still need an official openjdk reviewer for this. >>>> >>>> Thanks, >>>> >>>> -JB- >>> Just so I understand, the issue is that RemoteServer.getClientHost is >>> returning a String with an IPv6 literal address so you need to enclose >>> it in [] when building the connection id. That seems reasonable to me. >> Exactly. >> >>> A minor comment on the wording of the comment it that it would be >>> clear if there was a comma after "package description". >> Fixed. >> >>> The test looks okay to me although I had to read it a few times to >>> understand that:// was being removed from s. >> I've improved the client address detection - in addition to being more >> readable it handles properly the: form of the IPv4 >> address. >> >> Update webrev @ >> http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.02 >> > This looks okay to me. A minor comment on the test is that we usually > put the "final" after the "private static". Also constants are usually > in upper case. Thanks Alan, the comments are addressed in http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.03 -JB- > > -Alan. From Alan.Bateman at oracle.com Thu May 2 03:54:38 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 02 May 2013 11:54:38 +0100 Subject: jmx-dev [PING] Re: [PATCH] JDK-7199324: IPv6 JMXConnectorServer.getConnectionIDs() return IDs contradicting address grammar In-Reply-To: <51824571.6010702@oracle.com> References: <50D302B1.7080203@oracle.com> <50D86A01.2060703@oracle.com> <51793F3B.9020303@oracle.com> <51794290.7050806@oracle.com> <51824261.9060100@oracle.com> <51824466.2020905@oracle.com> <51824571.6010702@oracle.com> Message-ID: <518245EE.4050407@oracle.com> On 02/05/2013 11:52, Jaroslav Bachorik wrote: > : > Thanks Alan, the comments are addressed in > http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.03 > > -JB- > Looks good to me. -Alan From serguei.spitsyn at oracle.com Thu May 2 03:58:55 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 02 May 2013 03:58:55 -0700 Subject: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods In-Reply-To: References: Message-ID: <518246EF.9040207@oracle.com> If I understand correctly, the default methods are generated by the VM and have no presence in class file. Is that right? Then the fix looks good. A typo - "be included": 631 // and should not b included in the total count Thanks, Serguei On 5/2/13 1:51 AM, Staffan Larsen wrote: > JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't part of the original class. > > webrev: http://cr.openjdk.java.net/~sla/8008453/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008453 (not available yet) > > Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist > > I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/3fa8d6f6/attachment.html From staffan.larsen at oracle.com Thu May 2 04:06:23 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 2 May 2013 13:06:23 +0200 Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes In-Reply-To: <51823EF2.9010101@oracle.com> References: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> <51823EF2.9010101@oracle.com> Message-ID: <27EC1F98-2906-4AEA-B4FE-67B61DB98935@oracle.com> Thanks Serguei! I'll fix both of these before pushing. /Staffan On 2 maj 2013, at 12:24, serguei.spitsyn at oracle.com wrote: > This looks good. > Thank you for discovering and fixing it! > > A couple of cosmetic comments: > 352 //} > Indent for "}" is needed > > 376 u2 bootstrap_arguments = cpool()->operand_argument_index_at(n, arg); > It is about one argument. > Should the variable name be: "bootstrap_argument" ? > > > Thanks, > Serguei > > > On 5/2/13 1:50 AM, Staffan Larsen wrote: >> JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. >> >> webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 >> >> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist >> >> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/e5782bac/attachment.html From staffan.larsen at oracle.com Thu May 2 04:08:10 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 2 May 2013 13:08:10 +0200 Subject: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods In-Reply-To: <518246EF.9040207@oracle.com> References: <518246EF.9040207@oracle.com> Message-ID: <5BDC908F-E234-4C41-A1FC-5F7A9D1D1792@oracle.com> On 2 maj 2013, at 12:58, serguei.spitsyn at oracle.com wrote: > > If I understand correctly, the default methods are generated by the VM and have no presence in class file. > Is that right? Yes, that is my understanding. > Then the fix looks good. Thanks! > A typo - "be included": > 631 // and should not b included in the total count I'll fix before pushing. /Staffan > > Thanks, > Serguei > > > On 5/2/13 1:51 AM, Staffan Larsen wrote: >> JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't part of the original class. >> >> webrev: http://cr.openjdk.java.net/~sla/8008453/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008453 (not available yet) >> >> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist >> >> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/aa0ab068/attachment.html From kumar.x.srinivasan at oracle.com Thu May 2 05:49:58 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 02 May 2013 12:49:58 +0000 Subject: hg: jdk8/tl/jdk: 8013225: Refresh jdk's private ASM to the latest. Message-ID: <20130502125032.62CF048777@hg.openjdk.java.net> Changeset: 167d2dcaeeee Author: ksrini Date: 2013-05-01 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/167d2dcaeeee 8013225: Refresh jdk's private ASM to the latest. Reviewed-by: mduigou, sundar ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java ! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Context.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handler.java ! src/share/classes/jdk/internal/org/objectweb/asm/Item.java ! src/share/classes/jdk/internal/org/objectweb/asm/Label.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java ! src/share/classes/jdk/internal/org/objectweb/asm/Type.java + src/share/classes/jdk/internal/org/objectweb/asm/TypePath.java + src/share/classes/jdk/internal/org/objectweb/asm/TypeReference.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/ParameterNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/version.txt From staffan.larsen at oracle.com Thu May 2 05:52:31 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 2 May 2013 14:52:31 +0200 Subject: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException In-Reply-To: <517FF943.6020906@oracle.com> References: <517FF943.6020906@oracle.com> Message-ID: <66B0ED9A-7A2B-4E58-98AF-DC29941A23E2@oracle.com> I think this looks good. Thanks for doing this. /Staffan On 30 apr 2013, at 19:02, Kevin Walls wrote: > Hi, > > I'd like some review of this suggestion to fix: > 6313816 SA windows unaligned address exception > > webrev: > http://cr.openjdk.java.net/~kevinw/6313816/webrev/ > > This bug is a long-standing annoyance, mainly shown by using jstack -m > > Already fixed on Linux with additional sanity checks on ebp/rbp values in > e.g. LinuxX86CFrame.sender() > > On Windows there isn't such a convenient place to put these checks, as they > call getAddressValue() which is only part of the specific debugger interfaces > such as LinuxDebugger, WindbgDebugger, etc.. and on Windows we use > X86CFrame and AMD64CFrame. These are constructed with only a > CDebugger, there is no "WinXXXFrame" class - perhaps there should be! > > That's what I've tried here, by renaming e.g. X86CFrame to WinX86CFrame, > and adding the extra sanity checks as we already have in LinuxX86CFrame. > > As files have move thed diff isn't obvious, but in common with some previous changes > the new bits are x86 and x64 versions of these: > > + // Check alignment of rbp > + if ( dbg.getAddressValue(rbp) % ADDRESS_SIZE != 0) { > + return null; > + } > + > > and > > - if (nextRBP == null) { > + if (nextRBP == null || nextRBP.lessThanOrEqual(rbp)) { > > > This additional symmetry between the platforms seems to make sense, and > should help any future changes. > > Thanks > Kevin > From staffan.larsen at oracle.com Thu May 2 05:57:26 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 2 May 2013 14:57:26 +0200 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: Message-ID: <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com> Looks good. (not a reviewer) /Staffan On 2 maj 2013, at 05:07, ??(Yunda) wrote: > Could anyone review this for me, please? > > Regards, > Yunda > > From: ??(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net > Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together > > Hi all, > > I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > TLAB Size = 24607080] > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] > TLAB Size = 25054480] > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > , Allocation Size = 32, TLAB Size = 23712288] > > It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 > @@ -132,6 +132,7 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + ttyLocker ttyl; > TraceStream ts(*tty); > ts.print(": ["); > > > > I searched before sending this mail I didn't find anyone who covering thisJ > > Regards, > Yunda > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/6be850ac/attachment.html From kirk at kodewerk.com Thu May 2 06:05:16 2013 From: kirk at kodewerk.com (Kirk Pepperdine) Date: Thu, 2 May 2013 15:05:16 +0200 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com> References: <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com> Message-ID: <568A762D-EF28-457B-82FD-B775D485BCA7@kodewerk.com> What effect with this have on the other mixed up log files? Regards, Kirk On 2013-05-02, at 2:57 PM, Staffan Larsen wrote: > Looks good. (not a reviewer) > > /Staffan > > On 2 maj 2013, at 05:07, ??(Yunda) wrote: > >> Could anyone review this for me, please? >> >> Regards, >> Yunda >> >> From: ??(Yunda) >> Sent: Friday, April 19, 2013 4:26 PM >> To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net >> Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together >> >> Hi all, >> >> I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: >> >> Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] >> Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] >> TLAB Size = 24607080] >> Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] >> TLAB Size = 25054480] >> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] >> Allocation Size = 72, Class = [C, TLAB Size = 24159728] >> , Allocation Size = 32, TLAB Size = 23712288] >> >> It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): >> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl >> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 >> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 >> @@ -132,6 +132,7 @@ >> void writeEvent(void) { >> ResourceMark rm; >> HandleMark hm; >> + ttyLocker ttyl; >> TraceStream ts(*tty); >> ts.print(": ["); >> >> >> >> I searched before sending this mail I didn't find anyone who covering thisJ >> >> Regards, >> Yunda >> >> >> >> This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. >> >> ???(??????)?????????????????????????????????????????????????????????????????????? > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/7aeb1bbd/attachment-0001.html From peter.allwin at oracle.com Thu May 2 06:11:41 2013 From: peter.allwin at oracle.com (Peter Allwin) Date: Thu, 02 May 2013 15:11:41 +0200 Subject: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException In-Reply-To: <517FF943.6020906@oracle.com> References: <517FF943.6020906@oracle.com> Message-ID: <5182660D.8010105@oracle.com> Hi Kevin, Looks good! I've been looking into improving the quality of native stack traces on Windows using IDebugControl::GetStackTrace. This has the advantage of handling some FPO frames on x86 (a common source of these exceptions), as well as supporting AMD64 (walking the stack using RBP does not work at all on Windows/X64). There are still some issues to iron out before this change is ready, but your fix is a good start to what I'd like to accomplish. Thanks, Peter > ------------------------------------------------------------------------ > > Kevin Walls > Tuesday, April 30, 2013 7:02 PM > > > Hi, > > I'd like some review of this suggestion to fix: > 6313816 SA windows unaligned address exception > > webrev: > http://cr.openjdk.java.net/~kevinw/6313816/webrev/ > > This bug is a long-standing annoyance, mainly shown by using jstack -m > > Already fixed on Linux with additional sanity checks on ebp/rbp values in > e.g. LinuxX86CFrame.sender() > > On Windows there isn't such a convenient place to put these checks, as > they > call getAddressValue() which is only part of the specific debugger > interfaces > such as LinuxDebugger, WindbgDebugger, etc.. and on Windows we use > X86CFrame and AMD64CFrame. These are constructed with only a > CDebugger, there is no "WinXXXFrame" class - perhaps there should be! > > That's what I've tried here, by renaming e.g. X86CFrame to WinX86CFrame, > and adding the extra sanity checks as we already have in LinuxX86CFrame. > > As files have move thed diff isn't obvious, but in common with some > previous changes > the new bits are x86 and x64 versions of these: > > + // Check alignment of rbp > + if ( dbg.getAddressValue(rbp) % ADDRESS_SIZE != 0) { > + return null; > + } > + > > and > > - if (nextRBP == null) { > + if (nextRBP == null || nextRBP.lessThanOrEqual(rbp)) { > > > This additional symmetry between the platforms seems to make sense, and > should help any future changes. > > Thanks > Kevin > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/ef254309/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/ef254309/compose-unknown-contact.jpg From yunda.mly at taobao.com Thu May 2 06:42:40 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 2 May 2013 13:42:40 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <568A762D-EF28-457B-82FD-B775D485BCA7@kodewerk.com> References: <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com>, <568A762D-EF28-457B-82FD-B775D485BCA7@kodewerk.com> Message-ID: Kirk, I'm not quite clear what "the other mixed up log files" means, since when using EnableTracing the output uses stdout by default. Regards, Yunda ________________________________________ From: Kirk Pepperdine [kirk at kodewerk.com] Sent: Thursday, May 02, 2013 21:05 To: Staffan Larsen Cc: ??(Yunda); serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together What effect with this have on the other mixed up log files? Regards, Kirk On 2013-05-02, at 2:57 PM, Staffan Larsen > wrote: Looks good. (not a reviewer) /Staffan On 2 maj 2013, at 05:07, ??(Yunda) > wrote: Could anyone review this for me, please? Regards, Yunda From: ??(Yunda) Sent: Friday, April 19, 2013 4:26 PM To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi all, I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] TLAB Size = 24607080] Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] TLAB Size = 25054480] Allocation in new TLAB: [Class = [CTLAB Size = 24607080] Allocation Size = 72, Class = [C, TLAB Size = 24159728] , Allocation Size = 32, TLAB Size = 23712288] It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 @@ -132,6 +132,7 @@ void writeEvent(void) { ResourceMark rm; HandleMark hm; + ttyLocker ttyl; TraceStream ts(*tty); ts.print(": ["); I searched before sending this mail I didn't find anyone who covering this? Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From yunda.mly at taobao.com Thu May 2 06:48:53 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 2 May 2013 13:48:53 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com> References: , <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com> Message-ID: Staffan, Thanks! Regards, Yunda ________________________________________ From: Staffan Larsen [staffan.larsen at oracle.com] Sent: Thursday, May 02, 2013 20:57 To: ??(Yunda) Cc: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together Looks good. (not a reviewer) /Staffan On 2 maj 2013, at 05:07, ??(Yunda) > wrote: Could anyone review this for me, please? Regards, Yunda From: ??(Yunda) Sent: Friday, April 19, 2013 4:26 PM To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi all, I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] TLAB Size = 24607080] Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] TLAB Size = 25054480] Allocation in new TLAB: [Class = [CTLAB Size = 24607080] Allocation Size = 72, Class = [C, TLAB Size = 24159728] , Allocation Size = 32, TLAB Size = 23712288] It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 @@ -132,6 +132,7 @@ void writeEvent(void) { ResourceMark rm; HandleMark hm; + ttyLocker ttyl; TraceStream ts(*tty); ts.print(": ["); I searched before sending this mail I didn't find anyone who covering this? Regards, Yunda ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From kirk at kodewerk.com Thu May 2 06:49:11 2013 From: kirk at kodewerk.com (Kirk Pepperdine) Date: Thu, 2 May 2013 15:49:11 +0200 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com>, <568A762D-EF28-457B-82FD-B775D485BCA7@kodewerk.com> Message-ID: Hi Yunda, Sorry for not being clear about this. The CMS collector injects records into the middle of young gen (ParNew/DefNew) collections. Sorry for the noise but this is due to a different issue in how logging is performed. Regards, Kirk On 2013-05-02, at 3:42 PM, ??(Yunda) wrote: > Kirk, > > I'm not quite clear what "the other mixed up log files" means, since when using EnableTracing the output uses stdout by default. > > > Regards, > Yunda > ________________________________________ > From: Kirk Pepperdine [kirk at kodewerk.com] > Sent: Thursday, May 02, 2013 21:05 > To: Staffan Larsen > Cc: ??(Yunda); serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together > > What effect with this have on the other mixed up log files? > > Regards, > Kirk > > On 2013-05-02, at 2:57 PM, Staffan Larsen > wrote: > > Looks good. (not a reviewer) > > /Staffan > > On 2 maj 2013, at 05:07, ??(Yunda) > wrote: > > Could anyone review this for me, please? > > Regards, > Yunda > > From: ??(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net > Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together > > Hi all, > > I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > TLAB Size = 24607080] > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] > TLAB Size = 25054480] > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > , Allocation Size = 32, TLAB Size = 23712288] > > It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 > @@ -132,6 +132,7 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + ttyLocker ttyl; > TraceStream ts(*tty); > ts.print(": ["); > > > > I searched before sending this mail I didn't find anyone who covering this? > > Regards, > Yunda > > > ________________________________ > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? > > From yunda.mly at taobao.com Thu May 2 06:49:58 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 2 May 2013 13:49:58 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <858D0DD2-7623-4530-BE77-46357C66DB15@oracle.com> References: , <858D0DD2-7623-4530-BE77-46357C66DB15@oracle.com> Message-ID: Rickard, Thanks for the review! Regards, Yunda ________________________________________ From: Rickard B?ckman [rickard.backman at oracle.com] Sent: Thursday, May 02, 2013 13:11 To: ??(Yunda) Cc: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together Yunda, the change looks good (not a Reviewer). /R On May 2, 2013, at 5:07 AM, ??(Yunda) wrote: > Could anyone review this for me, please? > > Regards, > Yunda > > From: ??(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net > Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together > > Hi all, > > I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > TLAB Size = 24607080] > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] > TLAB Size = 25054480] > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > , Allocation Size = 32, TLAB Size = 23712288] > > It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(againsthttp://hg.openjdk.java.net/hsx/hsx24/hotspot/): > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 > @@ -132,6 +132,7 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + ttyLocker ttyl; > TraceStream ts(*tty); > ts.print(": ["); > > > > I searched before sending this mail I didn't find anyone who covering thisJ > > Regards, > Yunda > > > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? From yunda.mly at taobao.com Thu May 2 07:23:18 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 2 May 2013 14:23:18 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <4A3E186E-A4DD-4B8B-8D80-B291D6FC600B@oracle.com>, <568A762D-EF28-457B-82FD-B775D485BCA7@kodewerk.com> , Message-ID: Hi Kirk, Now I understand you. The situation you mentioned happens in the "gc.log" file. My fix won't affect it because EnableTracing doesn't change things already there. It just adds event records. At least I think so. Regards, Yunda ________________________________________ From: Kirk Pepperdine [kirk at kodewerk.com] Sent: Thursday, May 02, 2013 21:49 To: ??(Yunda) Cc: Staffan Larsen; serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together Hi Yunda, Sorry for not being clear about this. The CMS collector injects records into the middle of young gen (ParNew/DefNew) collections. Sorry for the noise but this is due to a different issue in how logging is performed. Regards, Kirk On 2013-05-02, at 3:42 PM, ??(Yunda) wrote: > Kirk, > > I'm not quite clear what "the other mixed up log files" means, since when using EnableTracing the output uses stdout by default. > > > Regards, > Yunda > ________________________________________ > From: Kirk Pepperdine [kirk at kodewerk.com] > Sent: Thursday, May 02, 2013 21:05 > To: Staffan Larsen > Cc: ??(Yunda); serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed together > > What effect with this have on the other mixed up log files? > > Regards, > Kirk > > On 2013-05-02, at 2:57 PM, Staffan Larsen > wrote: > > Looks good. (not a reviewer) > > /Staffan > > On 2 maj 2013, at 05:07, ??(Yunda) > wrote: > > Could anyone review this for me, please? > > Regards, > Yunda > > From: ??(Yunda) > Sent: Friday, April 19, 2013 4:26 PM > To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net > Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together > > Hi all, > > I found that the output from multiple threads may be mixed together when using EnableTracing. It happens many times in my test case like this: > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > TLAB Size = 24607080] > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB Size = 25054480] > TLAB Size = 25054480] > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > , Allocation Size = 32, TLAB Size = 23712288] > > It's very confusing and it's even not easy to tell how many events there are. I think the reason is that the writeEvent() method of each Event* class output the fields of event one by one without using any lock. So I made a small patch which add ttyLocker to writeEvent() method and after applying this patch there's no output mixed together in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 +0800 > @@ -132,6 +132,7 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + ttyLocker ttyl; > TraceStream ts(*tty); > ts.print(": ["); > > > > I searched before sending this mail I didn't find anyone who covering this? > > Regards, > Yunda > > > ________________________________ > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? > > From robert.field at oracle.com Thu May 2 07:33:20 2013 From: robert.field at oracle.com (Robert Field) Date: Thu, 02 May 2013 07:33:20 -0700 Subject: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods In-Reply-To: <5BDC908F-E234-4C41-A1FC-5F7A9D1D1792@oracle.com> References: <518246EF.9040207@oracle.com> <5BDC908F-E234-4C41-A1FC-5F7A9D1D1792@oracle.com> Message-ID: <51827930.7090003@oracle.com> On 05/02/13 04:08, Staffan Larsen wrote: > > On 2 maj 2013, at 12:58, serguei.spitsyn at oracle.com > wrote: > >> >> If I understand correctly, the default methods are generated by the >> VM and have no presence in class file. >> Is that right? > > Yes, that is my understanding. Hmmm, maybe this is what you are saying, but, default methods most certainly have a presence in class files. The overpass methods, however, are internally generated by the VM. -Robert > >> Then the fix looks good. > > Thanks! > >> A typo - "be included": >> 631 // and should not b included in the total count > > I'll fix before pushing. > > /Staffan > > >> >> Thanks, >> Serguei >> >> >> On 5/2/13 1:51 AM, Staffan Larsen wrote: >>> JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't part of the original class. >>> >>> webrev:http://cr.openjdk.java.net/~sla/8008453/webrev.00/ >>> bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008453 (not available yet) >>> >>> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist >>> >>> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. >>> >>> Thanks, >>> /Staffan >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/919b2c8c/attachment.html From staffan.larsen at oracle.com Thu May 2 08:26:46 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 2 May 2013 17:26:46 +0200 Subject: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods In-Reply-To: <51827930.7090003@oracle.com> References: <518246EF.9040207@oracle.com> <5BDC908F-E234-4C41-A1FC-5F7A9D1D1792@oracle.com> <51827930.7090003@oracle.com> Message-ID: <19DBF987-8FEB-4B36-90C1-0C18CAD75F24@oracle.com> On 2 maj 2013, at 16:33, Robert Field wrote: > On 05/02/13 04:08, Staffan Larsen wrote: >> >> On 2 maj 2013, at 12:58, serguei.spitsyn at oracle.com wrote: >> >>> >>> If I understand correctly, the default methods are generated by the VM and have no presence in class file. >>> Is that right? >> >> Yes, that is my understanding. > > Hmmm, maybe this is what you are saying, but, default methods most certainly have a presence in class files. The overpass methods, however, are internally generated by the VM. Yes, I think what I meant is that the default methods are not present in the class that implements the interface, but they are present in the interface class. /Staffan > > -Robert > >> >>> Then the fix looks good. >> >> Thanks! >> >>> A typo - "be included": >>> 631 // and should not b included in the total count >> >> I'll fix before pushing. >> >> /Staffan >> >> >>> >>> Thanks, >>> Serguei >>> >>> >>> On 5/2/13 1:51 AM, Staffan Larsen wrote: >>>> JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't part of the original class. >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/8008453/webrev.00/ >>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008453 (not available yet) >>>> >>>> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist >>>> >>>> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. >>>> >>>> Thanks, >>>> /Staffan >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/428aa67e/attachment-0001.html From mike.duigou at oracle.com Thu May 2 09:25:01 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 02 May 2013 16:25:01 +0000 Subject: hg: jdk8/tl/jdk: 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile Message-ID: <20130502162514.B703948781@hg.openjdk.java.net> Changeset: 5045eb04a579 Author: mduigou Date: 2013-05-02 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5045eb04a579 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile Reviewed-by: mduigou, henryjen, alanb, martin, psandoz Contributed-by: akhil.arora at oracle.com, brian.goetz at oracle.com ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/zip/ZipFile.java + test/java/util/BitSet/BitSetStreamTest.java + test/java/util/Random/RandomStreamTest.java + test/java/util/zip/ZipFile/StreamZipEntriesTest.java From Karen.Kinnear at oracle.com Thu May 2 09:37:35 2013 From: Karen.Kinnear at oracle.com (Karen Kinnear) Date: Thu, 2 May 2013 12:37:35 -0400 Subject: RFR: 7150256/8004095: Add back Remote Diagnostic Commands In-Reply-To: <517FF0C2.4040208@oracle.com> References: <517FF0C2.4040208@oracle.com> Message-ID: Frederic, Code looks good - actually it looks very clean. Ship it. Couple of minor comments that don't require re-review: 1. nmtDCmd.hpp/cpp - copyrights 2012 -> 2012, 2013 2. jmm.h line 213: "True is" -> "True if" 3. diagnosticFramework.hpp Thank you for the comments! line 298 "rational" -> "rationale" 4. diagnosticCommand.cpp lines 105/109 - what prints if p._name is null? thanks, Karen On Apr 30, 2013, at 12:26 PM, frederic parain wrote: > Hi all, > > This is a second request for review to add back > Remote Diagnostic Commands. > > This work adds a new platform MBean providing > remote access to the diagnostic command framework > via JMX (already accessible locally with the jcmd > tool). > > There's two CR number because this work is made of two > parts pushed to two different repositories. > > JDK changeset CR 7150256 > http://cr.openjdk.java.net/~fparain/7150256/webrev.06/ > > HotSpot changeset: CR 8004095 > http://cr.openjdk.java.net/~fparain/8004095/webrev.06/ > > Questions from previous review have been answered > in initial review threads. Changesets also include > some minor changes coming from internal audit and > feedback sent in private e-mails. > > However, one issue is still pending: some unit tests > use a hard coded port number, which could cause test > failures if several instances of the same test are > run on the same machine. I propose to postpone the > fix of this issue after the JDK8 feature freeze > (leaving for vacations soon, I won't have time to > fix tests before the feature freeze). > > Thanks, > > Fred > > -- > Frederic Parain - Oracle > Grenoble Engineering Center - France > Phone: +33 4 76 18 81 17 > Email: Frederic.Parain at oracle.com From serguei.spitsyn at oracle.com Thu May 2 10:39:53 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 02 May 2013 10:39:53 -0700 Subject: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods In-Reply-To: <19DBF987-8FEB-4B36-90C1-0C18CAD75F24@oracle.com> References: <518246EF.9040207@oracle.com> <5BDC908F-E234-4C41-A1FC-5F7A9D1D1792@oracle.com> <51827930.7090003@oracle.com> <19DBF987-8FEB-4B36-90C1-0C18CAD75F24@oracle.com> Message-ID: <5182A4E9.2040201@oracle.com> On 5/2/13 8:26 AM, Staffan Larsen wrote: > > On 2 maj 2013, at 16:33, Robert Field > wrote: > >> On 05/02/13 04:08, Staffan Larsen wrote: >>> >>> On 2 maj 2013, at 12:58, serguei.spitsyn at oracle.com >>> wrote: >>> >>>> >>>> If I understand correctly, the default methods are generated by the >>>> VM and have no presence in class file. >>>> Is that right? >>> >>> Yes, that is my understanding. >> >> Hmmm, maybe this is what you are saying, but, default methods most >> certainly have a presence in class files. The overpass methods, >> however, are internally generated by the VM. > > Yes, I think what I meant is that the default methods are not present > in the class that implements the interface, but they are present in > the interface class. Good, it is more clear now. Robert, thank you for the comment! Thanks, Serguei > > /Staffan > >> >> -Robert >> >>> >>>> Then the fix looks good. >>> >>> Thanks! >>> >>>> A typo - "be included": >>>> 631 // and should not b included in the total count >>> >>> I'll fix before pushing. >>> >>> /Staffan >>> >>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 5/2/13 1:51 AM, Staffan Larsen wrote: >>>>> JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't part of the original class. >>>>> >>>>> webrev:http://cr.openjdk.java.net/~sla/8008453/webrev.00/ >>>>> bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008453 (not available yet) >>>>> >>>>> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist >>>>> >>>>> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. >>>>> >>>>> Thanks, >>>>> /Staffan >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/44d2e8fa/attachment.html From alexander.zuev at oracle.com Thu May 2 10:24:16 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Thu, 02 May 2013 17:24:16 +0000 Subject: hg: jdk8/tl/jdk: 8013155: [pack200] improve performance of pack200 Message-ID: <20130502172428.6F15048787@hg.openjdk.java.net> Changeset: a6ff4a823164 Author: kizune Date: 2013-05-02 21:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6ff4a823164 8013155: [pack200] improve performance of pack200 Reviewed-by: ksrini, jrose ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java From frederic.parain at oracle.com Thu May 2 11:27:23 2013 From: frederic.parain at oracle.com (frederic parain) Date: Thu, 02 May 2013 20:27:23 +0200 Subject: RFR: 7150256/8004095: Add back Remote Diagnostic Commands In-Reply-To: References: <517FF0C2.4040208@oracle.com> Message-ID: <5182B00B.9030007@oracle.com> Karen, Thank you for the review. 1. 2. and 3. have been fixed. Regarding 4. Most (all?) permissions have a name argument. However, if p._name is null, the string "(null)" is printed. This is not wrong, but not very pretty: Permission: MyPermission((null)). I've changed the code (both 105 and 109) with a short conditional: ... p._name == NULL ? "null" : p._name ... which gives a better output: Permission: MyPermission(null) Fred On 02/05/2013 18:37, Karen Kinnear wrote: > Frederic, > > Code looks good - actually it looks very clean. Ship it. > > Couple of minor comments that don't require re-review: > > 1. nmtDCmd.hpp/cpp - copyrights 2012 -> 2012, 2013 > > 2. jmm.h > line 213: "True is" -> "True if" > > 3. diagnosticFramework.hpp > Thank you for the comments! > line 298 "rational" -> "rationale" > > 4. diagnosticCommand.cpp > lines 105/109 - what prints if p._name is null? > > thanks, > Karen > > On Apr 30, 2013, at 12:26 PM, frederic parain wrote: > >> Hi all, >> >> This is a second request for review to add back >> Remote Diagnostic Commands. >> >> This work adds a new platform MBean providing >> remote access to the diagnostic command framework >> via JMX (already accessible locally with the jcmd >> tool). >> >> There's two CR number because this work is made of two >> parts pushed to two different repositories. >> >> JDK changeset CR 7150256 >> http://cr.openjdk.java.net/~fparain/7150256/webrev.06/ >> >> HotSpot changeset: CR 8004095 >> http://cr.openjdk.java.net/~fparain/8004095/webrev.06/ >> >> Questions from previous review have been answered >> in initial review threads. Changesets also include >> some minor changes coming from internal audit and >> feedback sent in private e-mails. >> >> However, one issue is still pending: some unit tests >> use a hard coded port number, which could cause test >> failures if several instances of the same test are >> run on the same machine. I propose to postpone the >> fix of this issue after the JDK8 feature freeze >> (leaving for vacations soon, I won't have time to >> fix tests before the feature freeze). >> >> Thanks, >> >> Fred >> >> -- >> Frederic Parain - Oracle >> Grenoble Engineering Center - France >> Phone: +33 4 76 18 81 17 >> Email: Frederic.Parain at oracle.com > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From karen.kinnear at oracle.com Thu May 2 12:32:42 2013 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 2 May 2013 15:32:42 -0400 Subject: RFR: 8008453: JvmtiClassFileReconstituter does not recognize default methods In-Reply-To: <5182A4E9.2040201@oracle.com> References: <518246EF.9040207@oracle.com> <5BDC908F-E234-4C41-A1FC-5F7A9D1D1792@oracle.com> <51827930.7090003@oracle.com> <19DBF987-8FEB-4B36-90C1-0C18CAD75F24@oracle.com> <5182A4E9.2040201@oracle.com> Message-ID: <41C96ED1-0938-44C3-8B45-DAA7432BC966@oracle.com> Staffan, Code looks good. Many thanks for fixing this - sorry we missed this when adding the default method handling. thanks, Karen On May 2, 2013, at 1:39 PM, serguei.spitsyn at oracle.com wrote: > On 5/2/13 8:26 AM, Staffan Larsen wrote: >> >> On 2 maj 2013, at 16:33, Robert Field wrote: >> >>> On 05/02/13 04:08, Staffan Larsen wrote: >>>> >>>> On 2 maj 2013, at 12:58, serguei.spitsyn at oracle.com wrote: >>>> >>>>> >>>>> If I understand correctly, the default methods are generated by the VM and have no presence in class file. >>>>> Is that right? >>>> >>>> Yes, that is my understanding. >>> >>> Hmmm, maybe this is what you are saying, but, default methods most certainly have a presence in class files. The overpass methods, however, are internally generated by the VM. >> >> Yes, I think what I meant is that the default methods are not present in the class that implements the interface, but they are present in the interface class. > > Good, it is more clear now. > Robert, thank you for the comment! > > Thanks, > Serguei > >> >> /Staffan >> >>> >>> -Robert >>> >>>> >>>>> Then the fix looks good. >>>> >>>> Thanks! >>>> >>>>> A typo - "be included": >>>>> 631 // and should not b included in the total count >>>> >>>> I'll fix before pushing. >>>> >>>> /Staffan >>>> >>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> On 5/2/13 1:51 AM, Staffan Larsen wrote: >>>>>> JvmtiClassFileReconstituter does not recognize some methods as generated default methods when re-creating a class for retransformation. The new default methods are handled by generating overpass methods inside the JVM, when reconstituting a class, these methods should be skipped as they aren't part of the original class. >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~sla/8008453/webrev.00/ >>>>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008453 (not available yet) >>>>>> >>>>>> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist >>>>>> >>>>>> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130502/6c4b44fc/attachment.html From kurchi.subhra.hazra at oracle.com Thu May 2 14:17:51 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Thu, 02 May 2013 21:17:51 +0000 Subject: hg: jdk8/tl/jdk: 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name Message-ID: <20130502211812.21CA248793@hg.openjdk.java.net> Changeset: 3062bf908281 Author: khazra Date: 2013-05-02 14:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3062bf908281 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name Summary: Remove buffer overruns in native code Reviewed-by: alanb, chegar ! src/solaris/native/java/net/NetworkInterface.c From weijun.wang at oracle.com Thu May 2 19:44:40 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 03 May 2013 02:44:40 +0000 Subject: hg: jdk8/tl/jdk: 8013855: DigestMD5Client has not checked RealmChoiceCallback value Message-ID: <20130503024453.7B540487AC@hg.openjdk.java.net> Changeset: 81be41c7323f Author: weijun Date: 2013-05-03 10:43 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81be41c7323f 8013855: DigestMD5Client has not checked RealmChoiceCallback value Reviewed-by: xuelei, mullan ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java + test/com/sun/security/sasl/digest/AuthRealmChoices.java From jaroslav.bachorik at oracle.com Thu May 2 23:24:33 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Fri, 03 May 2013 06:24:33 +0000 Subject: hg: jdk8/tl/jdk: 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification Message-ID: <20130503062446.788CD487BA@hg.openjdk.java.net> Changeset: 470f19b6bfdd Author: jbachorik Date: 2013-05-02 13:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/470f19b6bfdd 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification Summary: RemoteServer.getClientHost is returning a String with an IPv6 literal address and we need to enclose it in [] when building the connection id Reviewed-by: alanb, sjiang ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! test/javax/management/remote/mandatory/connection/ConnectionTest.java From kevin.walls at oracle.com Fri May 3 01:32:25 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 03 May 2013 09:32:25 +0100 Subject: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException In-Reply-To: <5182660D.8010105@oracle.com> References: <517FF943.6020906@oracle.com> <5182660D.8010105@oracle.com> Message-ID: <51837619.500@oracle.com> Thanks Staffan, thanks Peter! On 02/05/13 14:11, Peter Allwin wrote: > Hi Kevin, > > Looks good! > > I've been looking into improving the quality of native stack traces on > Windows using IDebugControl::GetStackTrace. This has the advantage of > handling some FPO frames on x86 (a common source of these exceptions), > as well as supporting AMD64 (walking the stack using RBP does not work > at all on Windows/X64). There are still some issues to iron out before > this change is ready, but your fix is a good start to what I'd like to > accomplish. > > > Thanks, > > Peter > >> ------------------------------------------------------------------------ >> >> Kevin Walls >> Tuesday, April 30, 2013 7:02 PM >> >> >> Hi, >> >> I'd like some review of this suggestion to fix: >> 6313816 SA windows unaligned address exception >> >> webrev: >> http://cr.openjdk.java.net/~kevinw/6313816/webrev/ >> >> This bug is a long-standing annoyance, mainly shown by using jstack -m >> >> Already fixed on Linux with additional sanity checks on ebp/rbp >> values in >> e.g. LinuxX86CFrame.sender() >> >> On Windows there isn't such a convenient place to put these checks, >> as they >> call getAddressValue() which is only part of the specific debugger >> interfaces >> such as LinuxDebugger, WindbgDebugger, etc.. and on Windows we use >> X86CFrame and AMD64CFrame. These are constructed with only a >> CDebugger, there is no "WinXXXFrame" class - perhaps there should be! >> >> That's what I've tried here, by renaming e.g. X86CFrame to >> WinX86CFrame, >> and adding the extra sanity checks as we already have in LinuxX86CFrame. >> >> As files have move thed diff isn't obvious, but in common with some >> previous changes >> the new bits are x86 and x64 versions of these: >> >> + // Check alignment of rbp >> + if ( dbg.getAddressValue(rbp) % ADDRESS_SIZE != 0) { >> + return null; >> + } >> + >> >> and >> >> - if (nextRBP == null) { >> + if (nextRBP == null || nextRBP.lessThanOrEqual(rbp)) { >> >> >> This additional symmetry between the platforms seems to make sense, and >> should help any future changes. >> >> Thanks >> Kevin >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130503/215ef0e9/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130503/215ef0e9/compose-unknown-contact-0001.jpg From john.coomes at oracle.com Fri May 3 02:13:59 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 03 May 2013 09:13:59 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b88 for changeset 4e3a881ebb1e Message-ID: <20130503091401.DBDEF487DC@hg.openjdk.java.net> Changeset: 1f13a798d1b8 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/1f13a798d1b8 Added tag jdk8-b88 for changeset 4e3a881ebb1e ! .hgtags From john.coomes at oracle.com Fri May 3 02:13:55 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 03 May 2013 09:13:55 +0000 Subject: hg: hsx/hotspot-rt: 6 new changesets Message-ID: <20130503091355.9416E487DB@hg.openjdk.java.net> Changeset: 1dfcc874461e Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1dfcc874461e 8013480: fix zero build on arm Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in Changeset: 7e7582e961ba Author: jwilhelm Date: 2013-04-25 16:00 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/7e7582e961ba 7074926: create Solaris Studio IDE (Netbeans) project for hotspot sources Summary: Project files for hotspot delevopment in Solaris Studio and NetBeans. Also reviewed by vladimir.voskresensky at oracle.com Reviewed-by: erikj, dsamersoff + common/nb_native/nbproject/configurations.xml + common/nb_native/nbproject/project.xml Changeset: b9bf111a9547 Author: katleman Date: 2013-04-30 14:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b9bf111a9547 Merge Changeset: e404d321abc6 Author: erikj Date: 2013-05-02 15:46 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e404d321abc6 8013786: JDK-8013480 broke configure on solaris Reviewed-by: tbell ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/toolchain.m4 Changeset: e1a929afcfc4 Author: erikj Date: 2013-05-02 15:56 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e1a929afcfc4 8011687: Support correct dependencies from header files on windows and solaris Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/makefiles/NativeCompilation.gmk Changeset: 8fb91165e596 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8fb91165e596 Added tag jdk8-b88 for changeset e1a929afcfc4 ! .hgtags From john.coomes at oracle.com Fri May 3 02:14:07 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 03 May 2013 09:14:07 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b88 for changeset 7122f7bb0fcc Message-ID: <20130503091414.C76CF487DD@hg.openjdk.java.net> Changeset: 21f75e572cb3 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/21f75e572cb3 Added tag jdk8-b88 for changeset 7122f7bb0fcc ! .hgtags From john.coomes at oracle.com Fri May 3 02:14:19 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 03 May 2013 09:14:19 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b88 for changeset 24fa5452e5d4 Message-ID: <20130503091424.D6C66487DE@hg.openjdk.java.net> Changeset: 88838e08e4ef Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/88838e08e4ef Added tag jdk8-b88 for changeset 24fa5452e5d4 ! .hgtags From john.coomes at oracle.com Fri May 3 02:14:38 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 03 May 2013 09:14:38 +0000 Subject: hg: hsx/hotspot-rt/jdk: 8 new changesets Message-ID: <20130503091800.8ABB5487DF@hg.openjdk.java.net> Changeset: 78d08fc2dd12 Author: mullan Date: 2013-04-25 11:18 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/78d08fc2dd12 8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/OCSP.java Changeset: 3e282678a885 Author: mullan Date: 2013-04-25 15:48 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3e282678a885 8013228: Create new system properties to control allowable OCSP clock skew and CRL connection timeout Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/CertPathHelper.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java Changeset: 7c4eb715c5e8 Author: ngthomas Date: 2013-04-30 21:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7c4eb715c5e8 Merge Changeset: 12af7c32c648 Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/12af7c32c648 8013480: fix zero build on arm Reviewed-by: erikj ! makefiles/GensrcX11Wrappers.gmk Changeset: 7a96ead5ea89 Author: katleman Date: 2013-04-30 14:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7a96ead5ea89 Merge Changeset: 55c7b90fe57e Author: katleman Date: 2013-05-01 14:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/55c7b90fe57e Merge Changeset: 8dbb4b159e04 Author: erikj Date: 2013-05-02 15:59 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8dbb4b159e04 8013552: Add build support for different man pages for OpenJDK and OracleJDK Reviewed-by: tbell, omajid ! makefiles/Images.gmk Changeset: 1daef88acff2 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1daef88acff2 Added tag jdk8-b88 for changeset 8dbb4b159e04 ! .hgtags From john.coomes at oracle.com Fri May 3 02:19:32 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 03 May 2013 09:19:32 +0000 Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b88 for changeset a1e10f3adc47 Message-ID: <20130503091947.75410487E0@hg.openjdk.java.net> Changeset: adec2a5d510a Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/adec2a5d510a Added tag jdk8-b88 for changeset a1e10f3adc47 ! .hgtags From john.coomes at oracle.com Fri May 3 02:19:53 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 03 May 2013 09:19:53 +0000 Subject: hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b88 for changeset 40c107d1ae6f Message-ID: <20130503091957.18678487E1@hg.openjdk.java.net> Changeset: 501bc4aeb1b1 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/501bc4aeb1b1 Added tag jdk8-b88 for changeset 40c107d1ae6f ! .hgtags From staffan.larsen at oracle.com Fri May 3 05:14:11 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 03 May 2013 12:14:11 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130503121415.AAA3A487E6@hg.openjdk.java.net> Changeset: c456f4510385 Author: sla Date: 2013-05-03 12:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c456f4510385 8008453: JvmtiClassFileReconstituter does not recognize default methods Reviewed-by: acorn, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 0380df7c3cd0 Author: sla Date: 2013-05-03 12:26 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0380df7c3cd0 8013785: Respect EXTRA_CFLAGS on windows Reviewed-by: mgronlun, rbackman, kvn ! make/windows/makefiles/compile.make ! make/windows/makefiles/defs.make From jaroslav.bachorik at oracle.com Fri May 3 06:41:16 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 03 May 2013 15:41:16 +0200 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <511529DA.3050901@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> Message-ID: <5183BE7C.5060708@oracle.com> Please re-review the updated webrev http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 I've replaced the shell script with the plain java test. The javac API is used to compile the the auxiliary classes as was recommended. This allowed to simplify the test. The test does not check for a certain string in the standard output anymore - it turns out that it is possible to count the number of all the received JMX notifications (even though some notifications can be lost, we receive a special notification with the number of the lost regular notifications). It is then possible to match the actual number of processed notifications (received + lost) against the expected number - different numbers mean that the notification processing thread had been interrupted unexpectedly. Thanks, -JB- On 8.2.2013 17:37, Chris Hegarty wrote: > >> Jon Gibbons suggested invoking the compiler API directly from java >> instead of writing a shell script. Doing this seems fairly simple, and I >> think it would be advantageous to keep things entirely in Java. I may >> attempt to rewrite the defaultSVID test using the compiler API. > > Here's a test that does just that. > > http://hg.openjdk.java.net/jdk8/tl/jdk/file/2de8c6c2d652/test/sun/misc/JarIndex/metaInfFilenames/Basic.java > > > -Chris. From daniel.fuchs at oracle.com Fri May 3 07:16:53 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Fri, 03 May 2013 16:16:53 +0200 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <5183BE7C.5060708@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> Message-ID: <5183C6D5.8070302@oracle.com> Hi Jaroslav, In Client.java - you could consider replacing the AtomicLong with a CountDownLatch. This would allow you to remove the various Thread.sleep() in the code (in particular the one at the end). You could use CountDownLatch.await(long timeout, TimeUnit unit) to avoid waiting for ever in case of bugs, and the advantage is that the test would be able to exit as soon as the count down latch reaches 0, without having to wait for an arbitrary timeout. Very nice to see a shell test go away :-) -- daniel On 5/3/13 3:41 PM, Jaroslav Bachorik wrote: > Please re-review the updated webrev > http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 > > I've replaced the shell script with the plain java test. The javac API > is used to compile the the auxiliary classes as was recommended. This > allowed to simplify the test. > > The test does not check for a certain string in the standard output > anymore - it turns out that it is possible to count the number of all > the received JMX notifications (even though some notifications can be > lost, we receive a special notification with the number of the lost > regular notifications). It is then possible to match the actual number > of processed notifications (received + lost) against the expected number > - different numbers mean that the notification processing thread had > been interrupted unexpectedly. > > Thanks, > > -JB- > > On 8.2.2013 17:37, Chris Hegarty wrote: >> >>> Jon Gibbons suggested invoking the compiler API directly from java >>> instead of writing a shell script. Doing this seems fairly simple, and I >>> think it would be advantageous to keep things entirely in Java. I may >>> attempt to rewrite the defaultSVID test using the compiler API. >> >> Here's a test that does just that. >> >> http://hg.openjdk.java.net/jdk8/tl/jdk/file/2de8c6c2d652/test/sun/misc/JarIndex/metaInfFilenames/Basic.java >> >> >> -Chris. > From frederic.parain at oracle.com Fri May 3 09:43:13 2013 From: frederic.parain at oracle.com (frederic parain) Date: Fri, 03 May 2013 18:43:13 +0200 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <51783B80.5010807@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> Message-ID: <5183E921.7020209@oracle.com> Hi all, After an intense work with Mandy, here's a new webrev which fix the issue with the PlatformManagedObject specification. The DiagnosticCommandMBean is not a PlatformManagedObject anymore, it's just a DynamicMBean registered to the platform MBean server. Many smaller fixes have also been done based on provided feedback. http://cr.openjdk.java.net/~fparain/7150256/webrev.07/ Thanks, Fred On 24/04/2013 22:07, Mandy Chung wrote: > Hi Frederic, > > I reviewed the jdk webrev that is looking good. I reviewed > com.sun.management.DiagnosticCommandMBean spec almost half a year ago. > Reviewing it now with a fresh memory has some benefit that I have a few > comments on the spec. > > java.lang.management.PlatformManagedObject is specified as JMX MXBean > while dynamic mbean is not a MXBean. You have modified > ManagementFactory.getPlatformManagementInterfaces() to return the > DiagnosticCommandMBean which I agree it is the right thing to do. > > The PlatformManagedObject spec should be revised to cover dynamic mbeans > for this extension. The primary requirement for the platform mbeans is > to be interoperable so that a JMX client can access the platform mbeans > in a JVM running with a different JRE version (old or new) in which the > types are not required to be present in the JMX client. > > ManagementFactory.getPlatformMXBean(DiagnosticCommandMBean.class) and > the getPlatformMXBeans method should throw IAE. I think the existing > implementation already does that correctly but better to have a test to > catch that. The spec says @throws IAE if the mxbeaninterface is not a > platform management interface. The method name is very explict about > MXBean and so the @throws javadoc should be clarified it's not a > platform MXBean. > > What will be the way to obtain DiagnosticCommandMBean? > > Your DiagnosticCommandAsPlatformMBeanTest calls > ManagementFactory.getPlatformMXBean(DiagnosticCommandMBean.class) and > expect it to work. I think it should throw IAE instead. Nit: the > HOTSPOT_DIAGNOSTIC_MXBEAN_NAME field was leftover from your previous > version and should be removed. > > DiagnosticCommandMBean specifies the meta-data of the diagnostic command > and the option/argument the command takes. Have you considering > defining interfaces/abstract class for DiagnosticCommandInfo and > DiagnosticCommandArgumentInfo for a client to implement for parsing the > meta-data and maybeproviding factory methods? It's very easy to make > mistake without any API support. The spec is definitely not easy to > read :) > > dcmd.arg.type may be non-Java type. What are the examples? For Java > types, I suggest to use the type signatures as defined in JNI and > consistent with the standard representation: > http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp276 > > > dcmdArgInfo.position - would it be better to define a value (e.g. -1) if > dcmdArgInfo.option is set to true so that assertion can be added if > desired. > > dcmd.permissionClass - s/class name/fully-qualified class name > > The comment on java.lang.management spec needs to be addressed for this > change. As for the comments on DiagnosticCommandMBean, it's fine with > me to integrate your current DiagnosticCommandMBean and follow up to > make the spec enhancement, if appropriate, as a separate changeset. > > Is DiagnosticCommandMBean target for 7u? It has @since 8. > > The javadoc for DiagnosticCommandMBean should include more links such as > platform mbeanserver > (java.lang.management.ManagementFactory.getPlatformMBeanServer) > descriptor, parameter, etc, and the methods such as getName, > getDescription, etc > "jmx.mbean.info.changed" (MBeanInfo) > > replace .. with {@code ..} > line 32: It is a management interface. Perhaps the first sentence > should be: > Management interface for the diagnostic commands for the HotSpot > Virtual Machine. > > Here are my comments on the implementation: > sun/management/ManagementFactoryHelper.java > line 380: missing space between 'if' and '(' > > sun/management/DiagnosticCommandImpl.java > set/getAttribute(s) methods should throw AttributeNotFoundException > instead of UOE? > > line 164-181: can replace the if-statement by using ?: shorthand > > line 445-447: space around the binary operators '==', '?', '"' in the > 4th argument of the MBeanOperationInfo constructor. > > sun/management/VMManagement.java, VMManagementImpl.java and > VMManagementImpl.c > 108 // Diagnostic Commands support > 109 public String[] getDiagnosticCommands(); > 110 public DiagnosticCommandInfo[] > getDiagnosticCommandInfo(String[] commands); > 111 public String executeDiagnosticCommand(String command); > > These native methods are more appropriate to belong in > DiagnosticCommandImpl which already has one native method. > > In the native methods getDiagnosticCommandInfo, executeDiagnosticCommand, > getDiagnosticCommandArgumentInfoArray, you check if rdcmd_support is > supported and throws UOE if not. A running VM supporting the remote > diagnostic command will not change during its lifetime, right? Then I > suggest to check it in the Java level first calls > VMManagement.isRemoteDiagnosticCommandsSupported before calling the > native method. GetOptionalSupport is called during class initialization > to cache the values in Java to avoid fetching the value multiple time. > > test/java/lang/management/MXBean/MXBeanBehavior.java > line 39: diamond operator > Since the test is for MXBeans, it's more appropriate to exclude > non-MXBean from this test or rename the test to cover the new platform > mbeans. > > > On 4/18/2013 7:23 AM, frederic parain wrote: >>> >>> DiagnosticCommandImpl.Wrapper class >>> If there is any issue initializing the diagnostic command, it >>> ignores the exception. That makes it very hard to diagnose when things >>> go wrong. This exports diagnostic commands supported by the running JVM >>> and so I would think any error would be a bug. >> >> An exception when creating the Wrapper doesn't necessarily mean a bug. >> The call to get the list of diagnostic commands and the call to get >> the descriptions of these commands cannot be performed in an atomic >> way. Because the diagnostic command framework allows dynamic >> addition and removal of commands, a command might "disappear" between >> the two calls. In this case, the creation of the wrapper for this >> command will fail, but this shouldn't be considered as a bug. >> > > Can you add the comment there describing why the exception is ignored. > I'm not sure under what circumstances the exception is expected or not. > > The Wrapper constructor throws InstantiationException when it fails to > initialize the permission class but getMBeanInfo() ignores > InstantiationException. It seems a bug in the implementation to me? If > IAE and UOE during initiatizing the diagnostic commands, it returns an > empty one that seems okay. Comments to explain that would help. > >> >>> The new tests hardcode the port number that is unreliable and may fail >>> in nightly/jprt testing (e.g. the port is occupied by another test >>> run). Some management tests have the same reliability issue and I'm >>> not sure what the state is right now. It'd be good if the new tests can >>> avoid using hardcode port number. >> >> I don't know how to avoid the hardcoding of the port without wrapping >> the test in a shell scripts. Is there a template available to do >> dynamic port allocation? > > I skimmed on some existing tests but not able to find the example. I > think it's still a clean up task to be done. It's fine with me if you > do this test cleanup later and we probably need to write a test library > to help this. > > Mandy -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From jonathan.gibbons at oracle.com Fri May 3 09:57:40 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 03 May 2013 16:57:40 +0000 Subject: hg: jdk8/tl/langtools: 8012728: Normalize @ignore comments on langtools tests Message-ID: <20130503165746.D12F5487F0@hg.openjdk.java.net> Changeset: abd153854f16 Author: jjg Date: 2013-05-03 09:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abd153854f16 8012728: Normalize @ignore comments on langtools tests Reviewed-by: vromero, mcimadamore ! test/com/sun/javadoc/_template/Template.java ! test/com/sun/javadoc/_template/TemplateComplete.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java ! test/tools/javac/generics/7034511/T7034511a.java ! test/tools/javac/generics/7034511/T7034511b.java ! test/tools/javac/generics/OverrideBridge.java ! test/tools/javac/lambda/TargetType36.java ! test/tools/javac/lambda/TargetType53.java ! test/tools/javac/lambda/TargetType54.java ! test/tools/javac/lambda/TargetType58.java ! test/tools/javac/lambda/TargetType59.java ! test/tools/javac/lambda/TargetType62.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/output/Tester.java From jonathan.gibbons at oracle.com Fri May 3 10:17:25 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 03 May 2013 17:17:25 +0000 Subject: hg: jdk8/tl/langtools: 8002387: Improve rendered HTML formatting for {@code} Message-ID: <20130503171727.C503F487F1@hg.openjdk.java.net> Changeset: 38c4bade0ec1 Author: jjg Date: 2013-05-03 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38c4bade0ec1 8002387: Improve rendered HTML formatting for {@code} Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javadoc/Comment.java + test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java + test/com/sun/javadoc/testLiteralCodeInPre/pkg/Test.java From mandy.chung at oracle.com Fri May 3 11:02:51 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 03 May 2013 11:02:51 -0700 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <5183E921.7020209@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> Message-ID: <5183FBCB.2030902@oracle.com> Frederic, This looks good. Thanks for the update and also move the native method and implementations to DiagnosticCommandImpl.c and removing the check for rdcmd_support which is much cleaner. Minor comment: DiagnosticCommandImpl.Wrapper constructor - it'd be good to catch the exception causing the instantiation of permission instance to fail and set it to the cause of InstantiationException. Looks like InstantiationException doesn't take cause in the constructor and you would have to call initCause() before throwing it. No need to generate the new webrev for this minor fix. Ship it when you're ready. As we discussed offline, you will file bugs to follow up the following issues: 1. PlatformManagedObject should be updated to include DynamicMBean as a platform mbean and DiagnosticCommandMBean will implement PlatformManagedObject. ManagementFactory may provide new method to obtain platform dynamic mbean. 2. Investigate what DiagnosticCommandImpl.getAttributes and setAttributes should do per DynamicMBean spec. The current implementation throws UOE which seem to be okay. It's good to confirm what is specified or not specified per DynamicMBean spec Thanks Mandy On 5/3/2013 9:43 AM, frederic parain wrote: > Hi all, > > After an intense work with Mandy, here's a new webrev which > fix the issue with the PlatformManagedObject specification. > The DiagnosticCommandMBean is not a PlatformManagedObject > anymore, it's just a DynamicMBean registered to the platform > MBean server. Many smaller fixes have also been done based > on provided feedback. > > http://cr.openjdk.java.net/~fparain/7150256/webrev.07/ > > Thanks, > > Fred > > On 24/04/2013 22:07, Mandy Chung wrote: >> Hi Frederic, >> >> I reviewed the jdk webrev that is looking good. I reviewed >> com.sun.management.DiagnosticCommandMBean spec almost half a year ago. >> Reviewing it now with a fresh memory has some benefit that I have a few >> comments on the spec. >> >> java.lang.management.PlatformManagedObject is specified as JMX MXBean >> while dynamic mbean is not a MXBean. You have modified >> ManagementFactory.getPlatformManagementInterfaces() to return the >> DiagnosticCommandMBean which I agree it is the right thing to do. >> >> The PlatformManagedObject spec should be revised to cover dynamic mbeans >> for this extension. The primary requirement for the platform mbeans is >> to be interoperable so that a JMX client can access the platform mbeans >> in a JVM running with a different JRE version (old or new) in which the >> types are not required to be present in the JMX client. >> >> ManagementFactory.getPlatformMXBean(DiagnosticCommandMBean.class) and >> the getPlatformMXBeans method should throw IAE. I think the existing >> implementation already does that correctly but better to have a test to >> catch that. The spec says @throws IAE if the mxbeaninterface is not a >> platform management interface. The method name is very explict about >> MXBean and so the @throws javadoc should be clarified it's not a >> platform MXBean. >> >> What will be the way to obtain DiagnosticCommandMBean? >> >> Your DiagnosticCommandAsPlatformMBeanTest calls >> ManagementFactory.getPlatformMXBean(DiagnosticCommandMBean.class) and >> expect it to work. I think it should throw IAE instead. Nit: the >> HOTSPOT_DIAGNOSTIC_MXBEAN_NAME field was leftover from your previous >> version and should be removed. >> >> DiagnosticCommandMBean specifies the meta-data of the diagnostic command >> and the option/argument the command takes. Have you considering >> defining interfaces/abstract class for DiagnosticCommandInfo and >> DiagnosticCommandArgumentInfo for a client to implement for parsing the >> meta-data and maybeproviding factory methods? It's very easy to make >> mistake without any API support. The spec is definitely not easy to >> read :) >> >> dcmd.arg.type may be non-Java type. What are the examples? For Java >> types, I suggest to use the type signatures as defined in JNI and >> consistent with the standard representation: >> http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp276 >> >> >> >> dcmdArgInfo.position - would it be better to define a value (e.g. -1) if >> dcmdArgInfo.option is set to true so that assertion can be added if >> desired. >> >> dcmd.permissionClass - s/class name/fully-qualified class name >> >> The comment on java.lang.management spec needs to be addressed for this >> change. As for the comments on DiagnosticCommandMBean, it's fine with >> me to integrate your current DiagnosticCommandMBean and follow up to >> make the spec enhancement, if appropriate, as a separate changeset. >> >> Is DiagnosticCommandMBean target for 7u? It has @since 8. >> >> The javadoc for DiagnosticCommandMBean should include more links such as >> platform mbeanserver >> (java.lang.management.ManagementFactory.getPlatformMBeanServer) >> descriptor, parameter, etc, and the methods such as getName, >> getDescription, etc >> "jmx.mbean.info.changed" (MBeanInfo) >> >> replace .. with {@code ..} >> line 32: It is a management interface. Perhaps the first sentence >> should be: >> Management interface for the diagnostic commands for the HotSpot >> Virtual Machine. >> >> Here are my comments on the implementation: >> sun/management/ManagementFactoryHelper.java >> line 380: missing space between 'if' and '(' >> >> sun/management/DiagnosticCommandImpl.java >> set/getAttribute(s) methods should throw AttributeNotFoundException >> instead of UOE? >> >> line 164-181: can replace the if-statement by using ?: shorthand >> >> line 445-447: space around the binary operators '==', '?', '"' in the >> 4th argument of the MBeanOperationInfo constructor. >> >> sun/management/VMManagement.java, VMManagementImpl.java and >> VMManagementImpl.c >> 108 // Diagnostic Commands support >> 109 public String[] getDiagnosticCommands(); >> 110 public DiagnosticCommandInfo[] >> getDiagnosticCommandInfo(String[] commands); >> 111 public String executeDiagnosticCommand(String command); >> >> These native methods are more appropriate to belong in >> DiagnosticCommandImpl which already has one native method. >> >> In the native methods getDiagnosticCommandInfo, >> executeDiagnosticCommand, >> getDiagnosticCommandArgumentInfoArray, you check if rdcmd_support is >> supported and throws UOE if not. A running VM supporting the remote >> diagnostic command will not change during its lifetime, right? Then I >> suggest to check it in the Java level first calls >> VMManagement.isRemoteDiagnosticCommandsSupported before calling the >> native method. GetOptionalSupport is called during class initialization >> to cache the values in Java to avoid fetching the value multiple time. >> >> test/java/lang/management/MXBean/MXBeanBehavior.java >> line 39: diamond operator >> Since the test is for MXBeans, it's more appropriate to exclude >> non-MXBean from this test or rename the test to cover the new platform >> mbeans. >> >> >> On 4/18/2013 7:23 AM, frederic parain wrote: >>>> >>>> DiagnosticCommandImpl.Wrapper class >>>> If there is any issue initializing the diagnostic command, it >>>> ignores the exception. That makes it very hard to diagnose when >>>> things >>>> go wrong. This exports diagnostic commands supported by the >>>> running JVM >>>> and so I would think any error would be a bug. >>> >>> An exception when creating the Wrapper doesn't necessarily mean a bug. >>> The call to get the list of diagnostic commands and the call to get >>> the descriptions of these commands cannot be performed in an atomic >>> way. Because the diagnostic command framework allows dynamic >>> addition and removal of commands, a command might "disappear" between >>> the two calls. In this case, the creation of the wrapper for this >>> command will fail, but this shouldn't be considered as a bug. >>> >> >> Can you add the comment there describing why the exception is ignored. >> I'm not sure under what circumstances the exception is expected or not. >> >> The Wrapper constructor throws InstantiationException when it fails to >> initialize the permission class but getMBeanInfo() ignores >> InstantiationException. It seems a bug in the implementation to me? If >> IAE and UOE during initiatizing the diagnostic commands, it returns an >> empty one that seems okay. Comments to explain that would help. >> >>> >>>> The new tests hardcode the port number that is unreliable and may fail >>>> in nightly/jprt testing (e.g. the port is occupied by another test >>>> run). Some management tests have the same reliability issue and I'm >>>> not sure what the state is right now. It'd be good if the new >>>> tests can >>>> avoid using hardcode port number. >>> >>> I don't know how to avoid the hardcoding of the port without wrapping >>> the test in a shell scripts. Is there a template available to do >>> dynamic port allocation? >> >> I skimmed on some existing tests but not able to find the example. I >> think it's still a clean up task to be done. It's fine with me if you >> do this test cleanup later and we probably need to write a test library >> to help this. >> >> Mandy > From daniel.fuchs at oracle.com Fri May 3 11:19:54 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Fri, 03 May 2013 20:19:54 +0200 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <5183FBCB.2030902@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> <5183FBCB.2030902@oracle.com> Message-ID: <5183FFCA.1090108@oracle.com> Hi, On 5/3/13 8:02 PM, Mandy Chung wrote: > 2. Investigate what DiagnosticCommandImpl.getAttributes and > setAttributes should do per DynamicMBean spec. The current > implementation throws UOE which seem to be okay. It's good to confirm > what is specified or not specified per DynamicMBean spec By analogy with what the MBeanServerConnection says and what the StandardMBean class does, I'd say that the expected behavior would be to return an empty AttributeList for both methods. See: and -- daniel > > Thanks > Mandy From mandy.chung at oracle.com Fri May 3 11:30:24 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 03 May 2013 11:30:24 -0700 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <5183FFCA.1090108@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> <5183FBCB.2030902@oracle.com> <5183FFCA.1090108@oracle.com> Message-ID: <51840240.4060705@oracle.com> On 5/3/2013 11:19 AM, Daniel Fuchs wrote: > Hi, > > On 5/3/13 8:02 PM, Mandy Chung wrote: >> 2. Investigate what DiagnosticCommandImpl.getAttributes and >> setAttributes should do per DynamicMBean spec. The current >> implementation throws UOE which seem to be okay. It's good to confirm >> what is specified or not specified per DynamicMBean spec > > By analogy with what the MBeanServerConnection says and what > the StandardMBean class does, I'd say that the expected behavior > would be to return an empty AttributeList for both methods. Thanks Daniel. I initially thought that these 2 methods should return an empty AttributeList. MBeanServerConnection specifies clearly that missing attribute will be omitted and the caller will use the returned value to determine any missing attribute. It makes sense to expect DynamicMBean.get/setAttributes the same behavior as MBS forwards the call to the mbeans. Frederic - you can simply fix this to return an empty AttributeList. Can you also file a bug for DynamicMBean to clarify the expected behavior in the specification? Thanks Mandy > > See: > > > > and > > > > -- daniel > >> >> Thanks >> Mandy > From frederic.parain at oracle.com Fri May 3 11:31:45 2013 From: frederic.parain at oracle.com (frederic parain) Date: Fri, 03 May 2013 20:31:45 +0200 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <5183FBCB.2030902@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> <5183FBCB.2030902@oracle.com> Message-ID: <51840291.8020506@oracle.com> Thank you Mandy, I'll file the bugs and fix the exception cause. Fred On 03/05/2013 20:02, Mandy Chung wrote: > Frederic, > > This looks good. Thanks for the update and also move the native method > and implementations to DiagnosticCommandImpl.c and removing the check > for rdcmd_support which is much cleaner. > > Minor comment: > DiagnosticCommandImpl.Wrapper constructor - it'd be good to catch the > exception causing the instantiation of permission instance to fail and > set it to the cause of InstantiationException. Looks like > InstantiationException doesn't take cause in the constructor and you > would have to call initCause() before throwing it. > > No need to generate the new webrev for this minor fix. Ship it when > you're ready. > > As we discussed offline, you will file bugs to follow up the following > issues: > 1. PlatformManagedObject should be updated to include DynamicMBean as a > platform mbean and DiagnosticCommandMBean will implement > PlatformManagedObject. ManagementFactory may provide new method to > obtain platform dynamic mbean. > > 2. Investigate what DiagnosticCommandImpl.getAttributes and > setAttributes should do per DynamicMBean spec. The current > implementation throws UOE which seem to be okay. It's good to confirm > what is specified or not specified per DynamicMBean spec > > Thanks > Mandy > > On 5/3/2013 9:43 AM, frederic parain wrote: >> Hi all, >> >> After an intense work with Mandy, here's a new webrev which >> fix the issue with the PlatformManagedObject specification. >> The DiagnosticCommandMBean is not a PlatformManagedObject >> anymore, it's just a DynamicMBean registered to the platform >> MBean server. Many smaller fixes have also been done based >> on provided feedback. >> >> http://cr.openjdk.java.net/~fparain/7150256/webrev.07/ >> >> Thanks, >> >> Fred >> >> On 24/04/2013 22:07, Mandy Chung wrote: >>> Hi Frederic, >>> >>> I reviewed the jdk webrev that is looking good. I reviewed >>> com.sun.management.DiagnosticCommandMBean spec almost half a year ago. >>> Reviewing it now with a fresh memory has some benefit that I have a few >>> comments on the spec. >>> >>> java.lang.management.PlatformManagedObject is specified as JMX MXBean >>> while dynamic mbean is not a MXBean. You have modified >>> ManagementFactory.getPlatformManagementInterfaces() to return the >>> DiagnosticCommandMBean which I agree it is the right thing to do. >>> >>> The PlatformManagedObject spec should be revised to cover dynamic mbeans >>> for this extension. The primary requirement for the platform mbeans is >>> to be interoperable so that a JMX client can access the platform mbeans >>> in a JVM running with a different JRE version (old or new) in which the >>> types are not required to be present in the JMX client. >>> >>> ManagementFactory.getPlatformMXBean(DiagnosticCommandMBean.class) and >>> the getPlatformMXBeans method should throw IAE. I think the existing >>> implementation already does that correctly but better to have a test to >>> catch that. The spec says @throws IAE if the mxbeaninterface is not a >>> platform management interface. The method name is very explict about >>> MXBean and so the @throws javadoc should be clarified it's not a >>> platform MXBean. >>> >>> What will be the way to obtain DiagnosticCommandMBean? >>> >>> Your DiagnosticCommandAsPlatformMBeanTest calls >>> ManagementFactory.getPlatformMXBean(DiagnosticCommandMBean.class) and >>> expect it to work. I think it should throw IAE instead. Nit: the >>> HOTSPOT_DIAGNOSTIC_MXBEAN_NAME field was leftover from your previous >>> version and should be removed. >>> >>> DiagnosticCommandMBean specifies the meta-data of the diagnostic command >>> and the option/argument the command takes. Have you considering >>> defining interfaces/abstract class for DiagnosticCommandInfo and >>> DiagnosticCommandArgumentInfo for a client to implement for parsing the >>> meta-data and maybeproviding factory methods? It's very easy to make >>> mistake without any API support. The spec is definitely not easy to >>> read :) >>> >>> dcmd.arg.type may be non-Java type. What are the examples? For Java >>> types, I suggest to use the type signatures as defined in JNI and >>> consistent with the standard representation: >>> http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp276 >>> >>> >>> >>> dcmdArgInfo.position - would it be better to define a value (e.g. -1) if >>> dcmdArgInfo.option is set to true so that assertion can be added if >>> desired. >>> >>> dcmd.permissionClass - s/class name/fully-qualified class name >>> >>> The comment on java.lang.management spec needs to be addressed for this >>> change. As for the comments on DiagnosticCommandMBean, it's fine with >>> me to integrate your current DiagnosticCommandMBean and follow up to >>> make the spec enhancement, if appropriate, as a separate changeset. >>> >>> Is DiagnosticCommandMBean target for 7u? It has @since 8. >>> >>> The javadoc for DiagnosticCommandMBean should include more links such as >>> platform mbeanserver >>> (java.lang.management.ManagementFactory.getPlatformMBeanServer) >>> descriptor, parameter, etc, and the methods such as getName, >>> getDescription, etc >>> "jmx.mbean.info.changed" (MBeanInfo) >>> >>> replace .. with {@code ..} >>> line 32: It is a management interface. Perhaps the first sentence >>> should be: >>> Management interface for the diagnostic commands for the HotSpot >>> Virtual Machine. >>> >>> Here are my comments on the implementation: >>> sun/management/ManagementFactoryHelper.java >>> line 380: missing space between 'if' and '(' >>> >>> sun/management/DiagnosticCommandImpl.java >>> set/getAttribute(s) methods should throw AttributeNotFoundException >>> instead of UOE? >>> >>> line 164-181: can replace the if-statement by using ?: shorthand >>> >>> line 445-447: space around the binary operators '==', '?', '"' in the >>> 4th argument of the MBeanOperationInfo constructor. >>> >>> sun/management/VMManagement.java, VMManagementImpl.java and >>> VMManagementImpl.c >>> 108 // Diagnostic Commands support >>> 109 public String[] getDiagnosticCommands(); >>> 110 public DiagnosticCommandInfo[] >>> getDiagnosticCommandInfo(String[] commands); >>> 111 public String executeDiagnosticCommand(String command); >>> >>> These native methods are more appropriate to belong in >>> DiagnosticCommandImpl which already has one native method. >>> >>> In the native methods getDiagnosticCommandInfo, >>> executeDiagnosticCommand, >>> getDiagnosticCommandArgumentInfoArray, you check if rdcmd_support is >>> supported and throws UOE if not. A running VM supporting the remote >>> diagnostic command will not change during its lifetime, right? Then I >>> suggest to check it in the Java level first calls >>> VMManagement.isRemoteDiagnosticCommandsSupported before calling the >>> native method. GetOptionalSupport is called during class initialization >>> to cache the values in Java to avoid fetching the value multiple time. >>> >>> test/java/lang/management/MXBean/MXBeanBehavior.java >>> line 39: diamond operator >>> Since the test is for MXBeans, it's more appropriate to exclude >>> non-MXBean from this test or rename the test to cover the new platform >>> mbeans. >>> >>> >>> On 4/18/2013 7:23 AM, frederic parain wrote: >>>>> >>>>> DiagnosticCommandImpl.Wrapper class >>>>> If there is any issue initializing the diagnostic command, it >>>>> ignores the exception. That makes it very hard to diagnose when >>>>> things >>>>> go wrong. This exports diagnostic commands supported by the >>>>> running JVM >>>>> and so I would think any error would be a bug. >>>> >>>> An exception when creating the Wrapper doesn't necessarily mean a bug. >>>> The call to get the list of diagnostic commands and the call to get >>>> the descriptions of these commands cannot be performed in an atomic >>>> way. Because the diagnostic command framework allows dynamic >>>> addition and removal of commands, a command might "disappear" between >>>> the two calls. In this case, the creation of the wrapper for this >>>> command will fail, but this shouldn't be considered as a bug. >>>> >>> >>> Can you add the comment there describing why the exception is ignored. >>> I'm not sure under what circumstances the exception is expected or not. >>> >>> The Wrapper constructor throws InstantiationException when it fails to >>> initialize the permission class but getMBeanInfo() ignores >>> InstantiationException. It seems a bug in the implementation to me? If >>> IAE and UOE during initiatizing the diagnostic commands, it returns an >>> empty one that seems okay. Comments to explain that would help. >>> >>>> >>>>> The new tests hardcode the port number that is unreliable and may fail >>>>> in nightly/jprt testing (e.g. the port is occupied by another test >>>>> run). Some management tests have the same reliability issue and I'm >>>>> not sure what the state is right now. It'd be good if the new >>>>> tests can >>>>> avoid using hardcode port number. >>>> >>>> I don't know how to avoid the hardcoding of the port without wrapping >>>> the test in a shell scripts. Is there a template available to do >>>> dynamic port allocation? >>> >>> I skimmed on some existing tests but not able to find the example. I >>> think it's still a clean up task to be done. It's fine with me if you >>> do this test cleanup later and we probably need to write a test library >>> to help this. >>> >>> Mandy >> > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From frederic.parain at oracle.com Fri May 3 11:32:59 2013 From: frederic.parain at oracle.com (frederic parain) Date: Fri, 03 May 2013 20:32:59 +0200 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <51840240.4060705@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> <5183FBCB.2030902@oracle.com> <5183FFCA.1090108@oracle.com> <51840240.4060705@oracle.com> Message-ID: <518402DB.8040407@oracle.com> I'll fix it and file a new bug. Fred On 03/05/2013 20:30, Mandy Chung wrote: > On 5/3/2013 11:19 AM, Daniel Fuchs wrote: >> Hi, >> >> On 5/3/13 8:02 PM, Mandy Chung wrote: >>> 2. Investigate what DiagnosticCommandImpl.getAttributes and >>> setAttributes should do per DynamicMBean spec. The current >>> implementation throws UOE which seem to be okay. It's good to confirm >>> what is specified or not specified per DynamicMBean spec >> >> By analogy with what the MBeanServerConnection says and what >> the StandardMBean class does, I'd say that the expected behavior >> would be to return an empty AttributeList for both methods. > > Thanks Daniel. I initially thought that these 2 methods should return > an empty AttributeList. MBeanServerConnection specifies clearly that > missing attribute will be omitted and the caller will use the returned > value to determine any missing attribute. It makes sense to expect > DynamicMBean.get/setAttributes the same behavior as MBS forwards the > call to the mbeans. > > Frederic - you can simply fix this to return an empty AttributeList. Can > you also file a bug for DynamicMBean to clarify the expected behavior in > the specification? > > Thanks > Mandy > >> >> See: >> >> >> >> and >> >> >> > >> -- daniel >> >>> >>> Thanks >>> Mandy >> > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From frederic.parain at oracle.com Fri May 3 11:40:08 2013 From: frederic.parain at oracle.com (frederic parain) Date: Fri, 03 May 2013 20:40:08 +0200 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <5183FFCA.1090108@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> <5183FBCB.2030902@oracle.com> <5183FFCA.1090108@oracle.com> Message-ID: <51840488.3060604@oracle.com> MBeanServer.setAttributes() returns an AttributeList but the return type of DynamicMBean.setAttributes() is void. Does it mean that in our case, setAttributes() should simply be a no-op method? Fred On 03/05/2013 20:19, Daniel Fuchs wrote: > Hi, > > On 5/3/13 8:02 PM, Mandy Chung wrote: >> 2. Investigate what DiagnosticCommandImpl.getAttributes and >> setAttributes should do per DynamicMBean spec. The current >> implementation throws UOE which seem to be okay. It's good to confirm >> what is specified or not specified per DynamicMBean spec > > By analogy with what the MBeanServerConnection says and what > the StandardMBean class does, I'd say that the expected behavior > would be to return an empty AttributeList for both methods. > > See: > > > > and > > > > -- daniel > >> >> Thanks >> Mandy > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From mandy.chung at oracle.com Fri May 3 11:53:59 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 03 May 2013 11:53:59 -0700 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <51840488.3060604@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> <5183FBCB.2030902@oracle.com> <5183FFCA.1090108@oracle.com> <51840488.3060604@oracle.com> Message-ID: <518407C7.8050204@oracle.com> DynamicMBean: public AttributeList setAttributes(AttributeList attributes); Maybe you looked at setAttribute method. It's easily misread with and without 's'. On 5/3/2013 11:40 AM, frederic parain wrote: > MBeanServer.setAttributes() returns an AttributeList > but the return type of DynamicMBean.setAttributes() is > void. Does it mean that in our case, setAttributes() > should simply be a no-op method? > > Fred > > On 03/05/2013 20:19, Daniel Fuchs wrote: >> Hi, >> >> On 5/3/13 8:02 PM, Mandy Chung wrote: >>> 2. Investigate what DiagnosticCommandImpl.getAttributes and >>> setAttributes should do per DynamicMBean spec. The current >>> implementation throws UOE which seem to be okay. It's good to confirm >>> what is specified or not specified per DynamicMBean spec >> >> By analogy with what the MBeanServerConnection says and what >> the StandardMBean class does, I'd say that the expected behavior >> would be to return an empty AttributeList for both methods. >> >> See: >> >> >> >> >> and >> >> >> >> >> -- daniel >> >>> >>> Thanks >>> Mandy >> > From frederic.parain at oracle.com Fri May 3 12:07:28 2013 From: frederic.parain at oracle.com (frederic parain) Date: Fri, 03 May 2013 21:07:28 +0200 Subject: RFR: 7150256: Add back Diagnostic Command JMX API In-Reply-To: <518407C7.8050204@oracle.com> References: <50CF0187.6080001@oracle.com> <50CF1A31.7020106@oracle.com> <50CF3311.7020606@oracle.com> <50D3A1DD.4040703@oracle.com> <517001CD.2080109@oracle.com> <51783B80.5010807@oracle.com> <5183E921.7020209@oracle.com> <5183FBCB.2030902@oracle.com> <5183FFCA.1090108@oracle.com> <51840488.3060604@oracle.com> <518407C7.8050204@oracle.com> Message-ID: <51840AF0.5020707@oracle.com> You're right. I'll update setAttributes() to return an empty AttributeList. Fred On 03/05/2013 20:53, Mandy Chung wrote: > DynamicMBean: > public AttributeList setAttributes(AttributeList attributes); > > Maybe you looked at setAttribute method. It's easily misread with and > without 's'. > > On 5/3/2013 11:40 AM, frederic parain wrote: >> MBeanServer.setAttributes() returns an AttributeList >> but the return type of DynamicMBean.setAttributes() is >> void. Does it mean that in our case, setAttributes() >> should simply be a no-op method? >> >> Fred >> >> On 03/05/2013 20:19, Daniel Fuchs wrote: >>> Hi, >>> >>> On 5/3/13 8:02 PM, Mandy Chung wrote: >>>> 2. Investigate what DiagnosticCommandImpl.getAttributes and >>>> setAttributes should do per DynamicMBean spec. The current >>>> implementation throws UOE which seem to be okay. It's good to confirm >>>> what is specified or not specified per DynamicMBean spec >>> >>> By analogy with what the MBeanServerConnection says and what >>> the StandardMBean class does, I'd say that the expected behavior >>> would be to return an empty AttributeList for both methods. >>> >>> See: >>> >>> >>> >>> >>> and >>> >>> >>> >>> >>> -- daniel >>> >>>> >>>> Thanks >>>> Mandy >>> >> > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From frederic.parain at oracle.com Fri May 3 12:55:18 2013 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Fri, 03 May 2013 19:55:18 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130503195525.34D4F487FB@hg.openjdk.java.net> Changeset: 31a4e55f8c9d Author: fparain Date: 2013-05-03 05:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/31a4e55f8c9d 8004095: Add support for JMX interface to Diagnostic Framework and Commands Reviewed-by: acorn, sla ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/serviceThread.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/nmtDCmd.cpp ! src/share/vm/services/nmtDCmd.hpp Changeset: 39fba0d6d9ad Author: fparain Date: 2013-05-03 05:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/39fba0d6d9ad Merge From mike.duigou at oracle.com Fri May 3 14:33:27 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 03 May 2013 21:33:27 +0000 Subject: hg: jdk8/tl/jdk: 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Message-ID: <20130503213340.41D60487FF@hg.openjdk.java.net> Changeset: fc156b925259 Author: mduigou Date: 2013-05-03 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc156b925259 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Reviewed-by: martin, alanb, chegar, plevart ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java + test/sun/misc/JavaLangAccess/NewUnsafeString.java From jason.uh at oracle.com Fri May 3 15:05:11 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Fri, 03 May 2013 22:05:11 +0000 Subject: hg: jdk8/tl/jdk: 8005922: TEST_BUG: There is no /tmp directory for windows system. Message-ID: <20130503220525.0E4E348800@hg.openjdk.java.net> Changeset: d7f3d5659c46 Author: juh Date: 2013-05-03 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7f3d5659c46 8005922: TEST_BUG: There is no /tmp directory for windows system. Reviewed-by: weijun ! test/sun/security/tools/policytool/ChangeUI.html ! test/sun/security/tools/policytool/UpdatePermissions.html ! test/sun/security/tools/policytool/i18n.html From jonathan.gibbons at oracle.com Fri May 3 15:11:26 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 03 May 2013 22:11:26 +0000 Subject: hg: jdk8/tl/langtools: 8000407: remove @GenerateNativeHeader Message-ID: <20130503221128.F392D48801@hg.openjdk.java.net> Changeset: a2889739cf21 Author: jjg Date: 2013-05-03 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a2889739cf21 8000407: remove @GenerateNativeHeader Reviewed-by: vromero, darcy ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java ! test/tools/javac/nativeHeaders/NativeHeaderTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java From zhengyu.gu at oracle.com Fri May 3 15:22:17 2013 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Fri, 03 May 2013 22:22:17 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130503222221.B229548802@hg.openjdk.java.net> Changeset: bf089b838c9e Author: ccheung Date: 2013-05-02 16:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bf089b838c9e 8012641: Perf_CreateLong creates perf counter of incorrect type Reviewed-by: mchung, hseigel, coleenp ! src/share/vm/prims/perf.cpp Changeset: a55b7b8c34af Author: zgu Date: 2013-05-03 13:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a55b7b8c34af Merge From jonathan.gibbons at oracle.com Fri May 3 17:46:41 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 04 May 2013 00:46:41 +0000 Subject: hg: jdk8/tl/langtools: 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Message-ID: <20130504004644.180ED48807@hg.openjdk.java.net> Changeset: d918b63a5509 Author: jjg Date: 2013-05-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d918b63a5509 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Reviewed-by: jjg, mduigou Contributed-by: jonathan.gibbons at oracle.com, mike.duigou at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java + test/com/sun/javadoc/InheritDocForUserTags/DocTest.java + test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java + test/com/sun/javadoc/testSimpleTagInherit/p/BaseClass.java + test/com/sun/javadoc/testSimpleTagInherit/p/TestClass.java From daniel.daugherty at oracle.com Fri May 3 18:39:04 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sat, 04 May 2013 01:39:04 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 46 new changesets Message-ID: <20130504014031.BB0BC4880A@hg.openjdk.java.net> Changeset: a6e09d6dd8e5 Author: dlong Date: 2013-04-24 20:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a6e09d6dd8e5 8003853: specify offset of IC load in java_to_interp stub Summary: refactored code to allow platform-specific differences Reviewed-by: dlong, twisti Contributed-by: Goetz Lindenmaier + src/cpu/sparc/vm/compiledIC_sparc.cpp ! src/cpu/sparc/vm/sparc.ad + src/cpu/x86/vm/compiledIC_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad + src/cpu/zero/vm/compiledIC_zero.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/opto/output.cpp Changeset: e10e43e58e92 Author: dlong Date: 2013-04-24 21:11 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e10e43e58e92 Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/share/vm/opto/output.cpp - test/gc/6941923/test6941923.sh - test/gc/TestVerifyBeforeGCDuringStartup.java - test/runtime/NMT/AllocTestType.java Changeset: 3c0584fec1e6 Author: dholmes Date: 2013-04-28 18:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3c0584fec1e6 8010428: Special -agentpath checks needed with minimal VM to produce proper error message Reviewed-by: dholmes, alanb, cjplummer, olagneau Contributed-by: Carlos Lucasius ! src/share/vm/runtime/arguments.cpp Changeset: 78603aa58b1e Author: jiangli Date: 2013-04-26 16:58 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/78603aa58b1e Merge ! src/cpu/x86/vm/x86_64.ad Changeset: e01e02a9fcb6 Author: jiangli Date: 2013-04-29 01:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e01e02a9fcb6 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 052caeaeb771 Author: jiangli Date: 2013-05-02 12:16 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/052caeaeb771 Merge Changeset: 8f9fae155577 Author: jiangli Date: 2013-05-02 13:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8f9fae155577 Merge Changeset: c23dbf0e8ab7 Author: jmasa Date: 2013-03-01 10:19 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c23dbf0e8ab7 8011268: NPG: Free unused VirtualSpaceNodes Reviewed-by: mgerdin, coleenp, johnc ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: bfe3be9ebd6c Author: kevinw Date: 2013-04-18 17:02 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bfe3be9ebd6c 7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line Reviewed-by: mgerdin ! test/gc/7072527/TestFullGCCount.java Changeset: 12927badda81 Author: kevinw Date: 2013-04-19 05:14 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/12927badda81 Merge Changeset: d391427ddc29 Author: mgerdin Date: 2013-04-22 10:10 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d391427ddc29 Merge Changeset: a08c80e9e1e5 Author: stefank Date: 2013-04-22 20:27 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a08c80e9e1e5 8012687: Remove unused is_root checks and closures Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp Changeset: ebded0261dfc Author: jmasa Date: 2013-04-22 22:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ebded0261dfc 8012111: Remove warning about CMS generation shrinking. Reviewed-by: johnc, brutisso, stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/GuardShrinkWarning.java Changeset: 1cb4795305b9 Author: mgerdin Date: 2013-04-23 08:39 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1cb4795305b9 8011802: NPG: init_dependencies in class loader data graph can cause invalid CLD Summary: Restructure initialization of ClassLoaderData to not add a new instance if init_dependencies fail Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp Changeset: 5c93c1f61226 Author: johnc Date: 2013-04-18 10:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5c93c1f61226 8011724: G1: Stack allocate instances of HeapRegionRemSetIterator Summary: Stack allocate instances of HeapRegionRemSetIterator during RSet scanning. Reviewed-by: brutisso, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp Changeset: 868d87ed63c8 Author: jmasa Date: 2013-02-12 14:15 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/868d87ed63c8 8008966: NPG: Inefficient Metaspace counter functions cause large young GC regressions Reviewed-by: mgerdin, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 9d75bcd7c890 Author: mgerdin Date: 2013-04-24 19:55 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9d75bcd7c890 8013136: NPG: Parallel class loading tests fail after fix for JDK-8011802 Summary: Move initialization of dependencies to before allocation of CLD Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp Changeset: d50cc62e94ff Author: johnc Date: 2013-04-24 14:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d50cc62e94ff 8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime. Reviewed-by: twisti, johnc Contributed-by: Martin Doerr ! src/share/vm/opto/graphKit.cpp Changeset: b06ac540229e Author: stefank Date: 2013-04-24 20:13 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b06ac540229e 8013132: Add a flag to turn off the output of the verbose verification code Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vm_operations.hpp Changeset: b294421fa3c5 Author: brutisso Date: 2013-04-26 09:53 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b294421fa3c5 8012915: ReservedSpace::align_reserved_region() broken on Windows Summary: remove unused constructors and helper methods for ReservedHeapSpace and ReservedSpace Reviewed-by: mgerdin, jmasa, johnc, tschatzl ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 2f50bc369470 Author: stefank Date: 2013-04-26 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2f50bc369470 8013160: NPG: Remove unnecessary mark stack draining after CodeCache::do_unloading Reviewed-by: coleenp, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: 3edf23423bb2 Author: johnc Date: 2013-04-26 10:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3edf23423bb2 8011898: gc/TestVerifyBeforeGCDuringStartup.java: java.lang.RuntimeException: '[Verifying' missing from stdout/stderr: [Error: Could not find or load main class] Summary: System.getProperty("test.java.opts") can return NULL, which gets converted to to the empty string, and the child java command then interprets that as the name of the main class. Reviewed-by: jmasa, brutisso ! test/gc/TestVerifyDuringStartup.java Changeset: caac22686b17 Author: mgerdin Date: 2013-04-29 09:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/caac22686b17 Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/runtime/thread.cpp Changeset: 601183f604b2 Author: mgerdin Date: 2013-04-29 13:07 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/601183f604b2 8013129: Possible deadlock with Metaspace locks due to mixed usage of safepoint aware and non-safepoint aware locking Summary: Change Metaspace::deallocate to take lock with _no_safepoint_check_flag Reviewed-by: coleenp, jmasa, dholmes ! src/share/vm/memory/metaspace.cpp Changeset: 9075044ed66b Author: ehelin Date: 2013-04-30 16:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9075044ed66b 8008541: Remove old code in HotSpot that supported the jmap -permstat functionality Reviewed-by: sla, brutisso ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java Changeset: d58c62b7447d Author: mgerdin Date: 2013-05-02 19:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d58c62b7447d Merge ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp Changeset: cbd4ce58f1f3 Author: mgerdin Date: 2013-05-02 16:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbd4ce58f1f3 Merge Changeset: e12c9b3740db Author: vlivanov Date: 2013-04-25 11:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e12c9b3740db 8012260: ciReplay: Include PID into the name of replay data file Reviewed-by: kvn, twisti ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/vmError.cpp Changeset: dc7db03f5aa2 Author: iignatyev Date: 2013-04-25 11:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dc7db03f5aa2 8012337: Change Whitebox implementation to make absence of method in Whitebox.class not fatal Reviewed-by: kvn, vlivanov ! src/share/vm/prims/whitebox.cpp + test/sanity/WhiteBox.java Changeset: 7b23cb975cf2 Author: iignatyev Date: 2013-04-25 11:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7b23cb975cf2 8011675: adding compilation level to replay data Reviewed-by: kvn, vlivanov - agent/doc/c2replay.html + agent/doc/cireplay.html ! agent/doc/clhsdb.html ! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/ciReplay/TestSA.sh + test/compiler/ciReplay/TestVM.sh + test/compiler/ciReplay/TestVM_no_comp_level.sh + test/compiler/ciReplay/common.sh Changeset: 247342108a11 Author: neliasso Date: 2013-04-23 13:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/247342108a11 8010332: removed unused method: ciMethod::uses_monitors Reviewed-by: twisti, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/ci/ciMethod.hpp Changeset: a5c95fcf7cb7 Author: neliasso Date: 2013-04-23 18:06 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a5c95fcf7cb7 8012157: removed unused code in SharedRuntime::handle_wrong_method Reviewed-by: kvn, roland, rbackman Contributed-by: albert.noll at oracle.com ! src/share/vm/runtime/sharedRuntime.cpp Changeset: d1c9384eecb4 Author: iignatyev Date: 2013-04-26 07:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d1c9384eecb4 8012322: Tiered: CompilationPolicy::can_be_compiled(CompLevel_all) mistakenly return false Reviewed-by: kvn, vlivanov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java Changeset: 93b8272814cf Author: vlivanov Date: 2013-04-26 08:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/93b8272814cf Merge Changeset: 0b55a78c6be5 Author: bharadwaj Date: 2013-04-26 10:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0b55a78c6be5 Merge - agent/doc/c2replay.html ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fd49109d0d88 Author: bharadwaj Date: 2013-04-26 14:50 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fd49109d0d88 Merge Changeset: 487d442ef257 Author: jiangli Date: 2013-04-26 16:21 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/487d442ef257 8013036: vm/runtime/simpleThresholdPolicy.cpp: assert(mcs != NULL). Summary: Change the assert to if check as MethodCounters could be NULL under TieredCompilation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 62b683108582 Author: jiangli Date: 2013-04-26 14:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/62b683108582 Merge Changeset: 0cfa93c2fcc4 Author: neliasso Date: 2013-04-29 13:20 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0cfa93c2fcc4 8012547: Code cache flushing can get stuck reclaming of memory Summary: Keep sweeping regardless of if we are flushing Reviewed-by: kvn, twisti ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: e4e131b15d5c Author: roland Date: 2013-05-02 10:27 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e4e131b15d5c 8013532: Remove unused parameter "compiler" from DTRACE_METHOD_COMPILE* macros Summary: remove unused parameter in dtrace macros Reviewed-by: kvn, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/compiler/compileBroker.cpp Changeset: 9ce110b1d14a Author: kvn Date: 2013-05-02 18:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9ce110b1d14a Merge - agent/doc/c2replay.html ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/vmError.cpp Changeset: d0081bfc425c Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d0081bfc425c Added tag jdk8-b88 for changeset 8482058e74bc ! .hgtags Changeset: 4ec913499722 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ec913499722 Merge - agent/doc/c2replay.html Changeset: 9c1fe0b419b4 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9c1fe0b419b4 Added tag hs25-b31 for changeset 4ec913499722 ! .hgtags Changeset: 625ddb0052e1 Author: amurillo Date: 2013-05-03 08:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/625ddb0052e1 8013800: new hotspot build - hs25-b32 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9c8e2f44228d Author: dcubed Date: 2013-05-03 15:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9c8e2f44228d Merge From dag.wanvik at oracle.com Sun May 5 21:06:13 2013 From: dag.wanvik at oracle.com (dag.wanvik at oracle.com) Date: Mon, 06 May 2013 04:06:13 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130506040646.ADA004882A@hg.openjdk.java.net> Changeset: d8f01bfb1da4 Author: dwanvik Date: 2013-05-06 05:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8f01bfb1da4 8013403: Update JDK8 with Java DB 10.10.1.1. Summary: Drop Java DB 10.10.1.1 bits into JDK 8 and update image builds Reviewed-by: tbell ! make/common/Release.gmk ! makefiles/CompileDemos.gmk ! makefiles/Images.gmk Changeset: 398fe07f530f Author: dwanvik Date: 2013-05-06 06:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/398fe07f530f Merge - test/sun/reflect/CallerSensitive/MethodFinder.java From joe.darcy at oracle.com Sun May 5 21:05:14 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 06 May 2013 04:05:14 +0000 Subject: hg: jdk8/tl/langtools: 8013909: Fix doclint issues in javax.lang.model Message-ID: <20130506040520.B9DF648829@hg.openjdk.java.net> Changeset: e8987ce7fb4b Author: darcy Date: 2013-05-05 21:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e8987ce7fb4b 8013909: Fix doclint issues in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/SupportedAnnotationTypes.java ! src/share/classes/javax/annotation/processing/SupportedOptions.java ! src/share/classes/javax/annotation/processing/SupportedSourceVersion.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/element/NestingKind.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/Elements.java ! src/share/classes/javax/lang/model/util/Types.java From staffan.larsen at oracle.com Mon May 6 00:26:38 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 6 May 2013 09:26:38 +0200 Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes In-Reply-To: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> References: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> Message-ID: Can I have a second review of this change, please? /Staffan On 2 maj 2013, at 10:50, Staffan Larsen wrote: > JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. > > webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 > > Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist > > I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. > > Thanks, > /Staffan From jaroslav.bachorik at oracle.com Mon May 6 02:04:04 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 06 May 2013 11:04:04 +0200 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <5183C6D5.8070302@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> <5183C6D5.8070302@oracle.com> Message-ID: <51877204.8000104@oracle.com> On P??3.?kv?ten?2013,?16:16:53?CEST, Daniel Fuchs wrote: > Hi Jaroslav, > > In Client.java - you could consider replacing the AtomicLong > with a CountDownLatch. > > This would allow you to remove the various Thread.sleep() in the > code (in particular the one at the end). > > You could use CountDownLatch.await(long timeout, TimeUnit unit) to > avoid waiting for ever in case of bugs, and the advantage is that > the test would be able to exit as soon as the count down latch > reaches 0, without having to wait for an arbitrary timeout. Great, thanks for the pointer! I've changed the test to use the CountDownLatch. http://cr.openjdk.java.net/~jbachorik/8005472/webrev.08/ -JB- > > Very nice to see a shell test go away :-) > > -- daniel > > > On 5/3/13 3:41 PM, Jaroslav Bachorik wrote: >> Please re-review the updated webrev >> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 >> >> I've replaced the shell script with the plain java test. The javac API >> is used to compile the the auxiliary classes as was recommended. This >> allowed to simplify the test. >> >> The test does not check for a certain string in the standard output >> anymore - it turns out that it is possible to count the number of all >> the received JMX notifications (even though some notifications can be >> lost, we receive a special notification with the number of the lost >> regular notifications). It is then possible to match the actual number >> of processed notifications (received + lost) against the expected number >> - different numbers mean that the notification processing thread had >> been interrupted unexpectedly. >> >> Thanks, >> >> -JB- >> >> On 8.2.2013 17:37, Chris Hegarty wrote: >>> >>>> Jon Gibbons suggested invoking the compiler API directly from java >>>> instead of writing a shell script. Doing this seems fairly simple, >>>> and I >>>> think it would be advantageous to keep things entirely in Java. I may >>>> attempt to rewrite the defaultSVID test using the compiler API. >>> >>> Here's a test that does just that. >>> >>> http://hg.openjdk.java.net/jdk8/tl/jdk/file/2de8c6c2d652/test/sun/misc/JarIndex/metaInfFilenames/Basic.java >>> >>> >>> >>> -Chris. >> > From vladimir.x.ivanov at oracle.com Mon May 6 06:53:17 2013 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Mon, 06 May 2013 17:53:17 +0400 Subject: Some of j.l.Math::* functions can't be redefined (dynamically instrumented): is it expected? In-Reply-To: <517FE467.1090708@oracle.com> References: <517FC45B.7020602@oracle.com> <517FE467.1090708@oracle.com> Message-ID: <5187B5CD.6090609@oracle.com> Vladimir K., You are right, I overlooked that peculiarity. I've filed 8013931 [1] to track the issue with j.l.Math instrumentation. Best regards, Vladimir Ivanov [1] https://jbs.oracle.com/bugs/browse/JDK-8013931 On 4/30/13 7:33 PM, Vladimir Kozlov wrote: > > Shouldn't StrictMath counterparts be intrinsified instead? At least, > > when class redefinition is allowed. > > No, we can't do that. Think about StrictMath as reference implementation > in java which produces exactly the same results on all platforms. Where > non-strict math is for using hardware instructions to get best > performance and may produce not the same result (but with variation not > bigger then in java specification). > > "Unlike some of the numeric methods of class StrictMath, all > implementations of the equivalent functions of class Math are not > defined to return the bit-for-bit same results. This relaxation permits > better-performing implementations where strict reproducibility is not > required. > > By default many of the Math methods simply call the equivalent method in > StrictMath for their implementation. Code generators are encouraged to > use platform-specific native libraries or microprocessor instructions, > where available, to provide higher-performance implementations of Math > methods. Such higher-performance implementations still must conform to > the specification for Math." > > http://docs.oracle.com/javase/7/docs/api/java/lang/Math.html > > Vladimir K > > On 4/30/13 6:17 AM, Vladimir Ivanov wrote: >> Hi, >> >> I stumbled upon a fact that some of Math.* functions, though they are >> written in Java, can't be instrumented/redefined (using >> j.l.i.Instrumentation or JVMTI RedefineClasses). >> >> Looking at the code, I see that the interpreter handles such functions >> specially: >> src/share/vm/interpreter/interpreter.cpp: >> ... >> 184 AbstractInterpreter::MethodKind >> AbstractInterpreter::method_kind(methodHandle m) { >> ... >> 228 switch (m->intrinsic_id()) { >> 229 case vmIntrinsics::_dsin : return java_lang_math_sin ; >> ... >> >> but >> >> src/share/classes/java/lang/Math.java: >> ... >> 138 public static double sin(double a) { >> 139 return StrictMath.sin(a); // default impl. delegates to >> StrictMath >> 140 } >> ... >> >> and >> >> src/share/classes/java/lang/StrictMath.java: >> ... >> 110 public static native double sin(double a); >> ... >> >> Shouldn't StrictMath counterparts be intrinsified instead? At least, >> when class redefinition is allowed. >> Best regards, >> Vladimir Ivanov From staffan.larsen at oracle.com Mon May 6 08:17:43 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 6 May 2013 17:17:43 +0200 Subject: RFR: Update to test java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java Message-ID: <27635A0E-EDAD-4097-AA8E-F0F38CDB50E6@oracle.com> This test had a number of problems reported against it: http://bugs.sun.com/view_bug.do?bug_id=7148492 http://bugs.sun.com/view_bug.do?bug_id=6980985 http://bugs.sun.com/view_bug.do?bug_id=7181907 This overhaul of the test tries to address all of these and improve the test robustness. The changes I have done are: - Make sure the allocated large object is not easy to optimize away by storing it in a public field. - Removed the dynamic calculation of the large object's size since this sometimes caused problems. - Added GC configuration parameters to make sure the large object is allocated in the old gen. - Added GC configuration parameters to run the test with all GC algorithms. - Changed the printMemoryUsage() method to take MemoryUsages as parameters so it prints the same values as were used for comparisons. - Changed some incorrect '>' to '<' in printouts. - Removed the assumption that peak usage after the GC should be the same as before the GC. This is not true since "stuff" may have been moved from younger generations into the old gen thereby increasing the heap. webrev: http://cr.openjdk.java.net/~sla/7148492/webrev.00/ I've been running the test through JPRT a couple of times to try to ensure that it always passes. Thanks, /Staffan From harold.seigel at oracle.com Mon May 6 08:45:35 2013 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Mon, 06 May 2013 15:45:35 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8013648: Guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive Message-ID: <20130506154537.3430D48837@hg.openjdk.java.net> Changeset: 800078be49d2 Author: hseigel Date: 2013-05-06 09:10 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/800078be49d2 8013648: Guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive Summary: Fix code to call correct version of function find_class(). Reviewed-by: coleenp, rdurbin, dcubed ! src/share/vm/classfile/systemDictionary.cpp From zhengyu.gu at oracle.com Mon May 6 12:21:47 2013 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Mon, 06 May 2013 19:21:47 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130506192155.BAE9448846@hg.openjdk.java.net> Changeset: c18152e0554e Author: zgu Date: 2013-05-06 11:15 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c18152e0554e 8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check Summary: Fixed NMT to deal with releasing virtual memory region when there are still committed regions within it Reviewed-by: acorn, coleenp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/services/memSnapshot.cpp + test/runtime/NMT/ReleaseCommittedMemory.java Changeset: da4d87770781 Author: zgu Date: 2013-05-06 08:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/da4d87770781 Merge From mandy.chung at oracle.com Mon May 6 12:30:31 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 06 May 2013 12:30:31 -0700 Subject: RFR: Update to test java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java In-Reply-To: <27635A0E-EDAD-4097-AA8E-F0F38CDB50E6@oracle.com> References: <27635A0E-EDAD-4097-AA8E-F0F38CDB50E6@oracle.com> Message-ID: <518804D7.7000105@oracle.com> On 5/6/13 8:17 AM, Staffan Larsen wrote: > webrev: http://cr.openjdk.java.net/~sla/7148492/webrev.00/ > Looks good. It's good to run ResetPeakMemoryUsage with all different collectors. There are several shell tests in the test/java/lang/management/MemoryMXBean that can simply be replaced by adding @run in the java test and it'll be something good for the future cleanup. Mandy From dan.xu at oracle.com Mon May 6 14:18:54 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Mon, 06 May 2013 21:18:54 +0000 Subject: hg: jdk8/tl/jdk: 8003992: File and other classes in java.io do not handle embedded nulls properly Message-ID: <20130506211907.94A234884E@hg.openjdk.java.net> Changeset: bd118033e44c Author: dxu Date: 2013-05-06 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd118033e44c 8003992: File and other classes in java.io do not handle embedded nulls properly Summary: Have every file operation done with File, FileInputStream, FileOutputStream, or RandomAccessFile that involves a file path containing NUL fail. Also reviewed by fweimer at redhat.com Reviewed-by: alanb, sherman, ahgross, mduigou, dholmes, aph, plevart, martin ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java + test/java/io/File/NulFile.java From john.r.rose at oracle.com Mon May 6 14:58:23 2013 From: john.r.rose at oracle.com (John Rose) Date: Mon, 6 May 2013 14:58:23 -0700 Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes In-Reply-To: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> References: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> Message-ID: On May 2, 2013, at 1:50 AM, Staffan Larsen wrote: > JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. > > webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 > > Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist > > I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. Good. And I agree with Serguei's comments. One more typo: write_boostrapmethod_attribute should be write_bootstrapmethod_attribute. "Boostrap" sounds like it has to do with astronaut rappers, or maybe ghost trappers. ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130506/806f257c/attachment.html From karen.kinnear at oracle.com Mon May 6 16:20:50 2013 From: karen.kinnear at oracle.com (karen.kinnear at oracle.com) Date: Mon, 06 May 2013 23:20:50 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets Message-ID: <20130506232059.6439348852@hg.openjdk.java.net> Changeset: d9b08d62b95e Author: acorn Date: 2013-05-02 10:58 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d9b08d62b95e 8010783: assert(s->refcount() != 0) failed: for create_overpasses Reviewed-by: kvn, dcubed ! src/share/vm/classfile/bytecodeAssembler.cpp Changeset: b7f3bf2ba33b Author: acorn Date: 2013-05-06 10:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b7f3bf2ba33b Merge - agent/doc/c2replay.html Changeset: f916d5986c86 Author: acorn Date: 2013-05-06 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f916d5986c86 Merge From staffan.larsen at oracle.com Mon May 6 18:00:50 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 07 May 2013 01:00:50 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130507010054.3A76B48855@hg.openjdk.java.net> Changeset: 187154b7a226 Author: sla Date: 2013-05-06 19:49 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/187154b7a226 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes Reviewed-by: coleenp, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: 3ecc6b9940de Author: sla Date: 2013-05-07 01:25 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3ecc6b9940de Merge From david.holmes at oracle.com Mon May 6 19:38:53 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 07 May 2013 12:38:53 +1000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: Message-ID: <5188693D.8000304@oracle.com> Hi Yunda, There is a potential problem with using a ttyLocker here, depending on exactly what events are being traced and from where - you must always be in code where it is both safe to acquire the lock, and safe to block waiting for the lock if it is not available. I think I would prefer to see unlocked tracing by default with a flag to use locked-tracing if requested. David On 19/04/2013 6:26 PM, ??(Yunda) wrote: > Hi all, > > I found that the output from multiple threads may be mixed together when > using EnableTracing. It happens many times in my test case like this: > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new > TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: > [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = > java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = > java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, > Allocation in new TLAB: [Allocation Size = 192] > > Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, > Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > > TLAB Size = 24607080] > > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, TLAB > Size = 25054480] > > TLAB Size = 25054480] > > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > > , Allocation Size = 32, TLAB Size = 23712288] > > It's very confusing and it's even not easy to tell how many events there > are. I think the reason is that the writeEvent() method of each Event* > class output the fields of event one by one without using any lock. So I > made a small patch which add ttyLocker to writeEvent() method and after > applying this patch there's no output mixed together in my test > case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 > 2013 -0700 > > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 2013 > +0800 > > @@ -132,6 +132,7 @@ > > void writeEvent(void) { > > ResourceMark rm; > > HandleMark hm; > > + ttyLocker ttyl; > > TraceStream ts(*tty); > > ts.print(": ["); > > > > I searched before sending this mail I didn't find anyone who covering thisJ > > Regards, > > Yunda > > > ------------------------------------------------------------------------ > > This email (including any attachments) is confidential and may be > legally privileged. If you received this email in error, please delete > it immediately and do not copy it or use it for any purpose or disclose > its contents to any other person. Thank you. > > ???(??????)?????????????????????????? > ???????????????????????????????????? > ???????? From mike.duigou at oracle.com Mon May 6 20:56:18 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 07 May 2013 03:56:18 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20130507035652.E8C7F4885D@hg.openjdk.java.net> Changeset: e13cf31e5a96 Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e13cf31e5a96 8013712: Add Objects.nonNull and Objects.isNull Reviewed-by: mchung, darcy ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: 3cbb65d9af9e Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cbb65d9af9e 8013150: Iterator.remove and forEachRemaining relationship not specified Reviewed-by: mduigou Contributed-by: Akhil Arora ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Vector.java + test/java/util/Iterator/IteratorDefaults.java Changeset: 8221c421490f Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8221c421490f 8003258: BufferedReader.lines() Reviewed-by: alanb, mduigou, psandoz Contributed-by: Brian Goetz , Henry Jen ! src/share/classes/java/io/BufferedReader.java + src/share/classes/java/io/UncheckedIOException.java + test/java/io/BufferedReader/Lines.java From xueming.shen at oracle.com Mon May 6 21:25:15 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 07 May 2013 04:25:15 +0000 Subject: hg: jdk8/tl/jdk: 8013252: Regex Matcher .start and .end should be accessible by group name; ... Message-ID: <20130507042526.D8ED64885E@hg.openjdk.java.net> Changeset: b4a013f4eff4 Author: sherman Date: 2013-05-06 21:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4a013f4eff4 8013252: Regex Matcher .start and .end should be accessible by group name 8013254: Constructor \w need update to add the support of \p{Join_Control} Summary: added the requested methods and updated the \w constructor Reviewed-by: mchung, alanb ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/regex/UnicodeProp.java ! test/java/util/regex/POSIX_Unicode.java ! test/java/util/regex/RegExTest.java From weijun.wang at oracle.com Mon May 6 21:32:02 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 07 May 2013 04:32:02 +0000 Subject: hg: jdk8/tl/jdk: 8010192: Enable native JGSS provider on Mac Message-ID: <20130507043213.AB25048861@hg.openjdk.java.net> Changeset: 814dcc08df52 Author: weijun Date: 2013-05-07 12:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/814dcc08df52 8010192: Enable native JGSS provider on Mac Reviewed-by: valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/native/sun/security/jgss/wrapper/gssapi.h ! test/sun/security/krb5/runNameEquals.sh From staffan.larsen at oracle.com Mon May 6 22:50:33 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 7 May 2013 07:50:33 +0200 Subject: RFR: Update to test java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java In-Reply-To: <518804D7.7000105@oracle.com> References: <27635A0E-EDAD-4097-AA8E-F0F38CDB50E6@oracle.com> <518804D7.7000105@oracle.com> Message-ID: <58A784B9-4338-4983-9A89-A074DD01E9EA@oracle.com> Thanks Mandy! On 6 maj 2013, at 21:30, Mandy Chung wrote: > On 5/6/13 8:17 AM, Staffan Larsen wrote: >> webrev: http://cr.openjdk.java.net/~sla/7148492/webrev.00/ >> > Looks good. It's good to run ResetPeakMemoryUsage with all different collectors. There are several shell tests in the test/java/lang/management/MemoryMXBean that can simply be replaced by adding @run in the java test and it'll be something good for the future cleanup. > > Mandy From jonathan.gibbons at oracle.com Mon May 6 22:52:07 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 07 May 2013 05:52:07 +0000 Subject: hg: jdk8/tl/langtools: 8009724: Enhance the DocTree API with DocTreePath Message-ID: <20130507055210.2F0D948865@hg.openjdk.java.net> Changeset: a7ff36d06fa2 Author: jlahoda Date: 2013-05-06 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a7ff36d06fa2 8009724: Enhance the DocTree API with DocTreePath Summary: Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner, respectively Reviewed-by: jjg Contributed-by: Ralph Benjamin Ruijs , Jan Lahoda + src/share/classes/com/sun/source/util/DocTreePath.java + src/share/classes/com/sun/source/util/DocTreePathScanner.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java + test/tools/javac/doctree/DocTreePathScannerTest.java ! test/tools/javac/doctree/ReferenceTest.java From staffan.larsen at oracle.com Mon May 6 22:58:36 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 7 May 2013 07:58:36 +0200 Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes In-Reply-To: References: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> Message-ID: <54FD10D3-DA1E-464F-A30E-CA22B39E2482@oracle.com> On 6 maj 2013, at 23:58, John Rose wrote: > On May 2, 2013, at 1:50 AM, Staffan Larsen wrote: > >> JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file. >> >> webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 >> >> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist >> >> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test. > > Good. And I agree with Serguei's comments. > > One more typo: write_boostrapmethod_attribute should be write_bootstrapmethod_attribute. "Boostrap" sounds like it has to do with astronaut rappers, or maybe ghost trappers. Oops. I had already pushed the change. Here is an additional webrev for the spelling error (found one more as well). http://cr.openjdk.java.net/~sla/8014044/webrev.00/ Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130507/e5e95140/attachment.html From serguei.spitsyn at oracle.com Mon May 6 23:17:42 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 06 May 2013 23:17:42 -0700 Subject: RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes In-Reply-To: <54FD10D3-DA1E-464F-A30E-CA22B39E2482@oracle.com> References: <1C9E875E-BF51-4CA5-A7E6-3DB7566787B9@oracle.com> <54FD10D3-DA1E-464F-A30E-CA22B39E2482@oracle.com> Message-ID: <51889C86.7060202@oracle.com> Looks good. I've overlooked it too. :( Thanks, Serguei On 5/6/13 10:58 PM, Staffan Larsen wrote: > > On 6 maj 2013, at 23:58, John Rose > wrote: > >> On May 2, 2013, at 1:50 AM, Staffan Larsen > > wrote: >> >>> JvmtiClassFileReconstituter does not create BootstrapMethod >>> attributes when re-creating a class for retransformation. This fix >>> uses the operands in the constant pool to re-create the >>> BootstrapMethod attributes in the class file. >>> >>> webrev:http://cr.openjdk.java.net/~sla/8009615/webrev.00/ >>> >>> bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615 >>> >>> Testing done: java/lang/instrument, com/sun/jdi, >>> nsk.quick-jvmti.testlist >>> >>> I have not written a regression test since this was found by running >>> the existing java/lang/instrument/IsModifiableClassAgent.java test. >> >> Good. And I agree with Serguei's comments. >> >> One more typo: write_boostrapmethod_attribute should >> be write_bootstrapmethod_attribute. "Boostrap" sounds like it has to >> do with astronaut rappers, or maybe ghost trappers. > > Oops. I had already pushed the change. Here is an additional webrev > for the spelling error (found one more as well). > > http://cr.openjdk.java.net/~sla/8014044/webrev.00/ > > > Thanks, > /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130506/aefc26e2/attachment-0001.html From joel.franck at oracle.com Tue May 7 01:00:33 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 07 May 2013 08:00:33 +0000 Subject: hg: jdk8/tl/jdk: 8013541: Revise javadoc for Executable.getAnnotatedReturnType() Message-ID: <20130507080055.CBAA04886A@hg.openjdk.java.net> Changeset: 9c9b2385c1b0 Author: jfranck Date: 2013-05-07 09:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c9b2385c1b0 8013541: Revise javadoc for Executable.getAnnotatedReturnType() Reviewed-by: abuckley, darcy ! src/share/classes/java/lang/reflect/Executable.java From staffan.larsen at oracle.com Tue May 7 01:02:32 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 7 May 2013 10:02:32 +0200 Subject: RFR(S): 8005038 remove crufty '_g' support from SA Message-ID: Please review this little fix to remove the _g support from the SA files. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038 webrev: http://cr.openjdk.java.net/~sla/8005038/webrev.00/ Thanks, /Staffan From rickard.backman at oracle.com Tue May 7 01:43:15 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 7 May 2013 10:43:15 +0200 Subject: RFR(S): 8005038 remove crufty '_g' support from SA In-Reply-To: References: Message-ID: Staffan, this looks good to me (not a Reviewer). /R On May 7, 2013, at 10:02 AM, Staffan Larsen wrote: > Please review this little fix to remove the _g support from the SA files. > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038 > webrev: http://cr.openjdk.java.net/~sla/8005038/webrev.00/ > > Thanks, > /Staffan From yunda.mly at taobao.com Tue May 7 02:43:44 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Tue, 7 May 2013 09:43:44 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <5188693D.8000304@oracle.com> References: <5188693D.8000304@oracle.com> Message-ID: Hi David, Thanks for the review and I see your concern. Please see the updated change below: diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 +0800 @@ -3634,7 +3634,10 @@ "Include GC cause in GC logging") \ \ product(bool, EnableTracing, false, \ - "Enable event-based tracing") + "Enable event-based tracing") \ + \ + product(bool, UseLockedTracing, false, \ + "Use locked-tracing when doing event-based tracing") /* * Macros for factoring of globals diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 -0700 +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 2013 +0800 @@ -132,6 +132,9 @@ void writeEvent(void) { ResourceMark rm; HandleMark hm; + if (UseLockedTracing) { + ttyLocker ttyl; + } TraceStream ts(*tty); ts.print(": ["); Regards, Yunda > -----Original Message----- > From: David Holmes [mailto:david.holmes at oracle.com] > Sent: Tuesday, May 07, 2013 10:39 AM > To: ??(Yunda) > Cc: hotspot-runtime-dev at openjdk.java.net; > serviceability-dev at openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > Hi Yunda, > > There is a potential problem with using a ttyLocker here, depending on exactly > what events are being traced and from where - you must always be in code > where it is both safe to acquire the lock, and safe to block waiting for the lock if > it is not available. > > I think I would prefer to see unlocked tracing by default with a flag to use > locked-tracing if requested. > > David > > On 19/04/2013 6:26 PM, ??(Yunda) wrote: > > Hi all, > > > > I found that the output from multiple threads may be mixed together > > when using EnableTracing. It happens many times in my test case like this: > > > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new > > TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: > > [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = > > java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = > > java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, > > Allocation in new TLAB: [Allocation Size = 192] > > > > Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, > > Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > > > > TLAB Size = 24607080] > > > > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, > > TLAB Size = 25054480] > > > > TLAB Size = 25054480] > > > > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > > > > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > > > > , Allocation Size = 32, TLAB Size = 23712288] > > > > It's very confusing and it's even not easy to tell how many events > > there are. I think the reason is that the writeEvent() method of each > > Event* class output the fields of event one by one without using any > > lock. So I made a small patch which add ttyLocker to writeEvent() > > method and after applying this patch there's no output mixed together > > in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > > > > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > > > > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 > > 2013 -0700 > > > > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 > > +++ 2013 > > +0800 > > > > @@ -132,6 +132,7 @@ > > > > void writeEvent(void) { > > > > ResourceMark rm; > > > > HandleMark hm; > > > > + ttyLocker ttyl; > > > > TraceStream ts(*tty); > > > > ts.print(": ["); > > > > > > > > I searched before sending this mail I didn't find anyone who covering > > thisJ > > > > Regards, > > > > Yunda > > > > > > ---------------------------------------------------------------------- > > -- > > > > This email (including any attachments) is confidential and may be > > legally privileged. If you received this email in error, please delete > > it immediately and do not copy it or use it for any purpose or > > disclose its contents to any other person. Thank you. > > > > ???(??????)?????????????????????? > ???? > > ??????????????????????????????? > ????? > > ???????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From yunda.mly at taobao.com Tue May 7 02:47:39 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Tue, 7 May 2013 09:47:39 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together References: <5188693D.8000304@oracle.com> Message-ID: David, I've made a stupid mistake and please ignore it... Regards, Yunda > -----Original Message----- > From: ??(Yunda) > Sent: Tuesday, May 07, 2013 5:44 PM > To: 'David Holmes' > Cc: hotspot-runtime-dev at openjdk.java.net; > serviceability-dev at openjdk.java.net > Subject: RE: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > Hi David, > > Thanks for the review and I see your concern. Please see the updated change > below: > > diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 > +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 +0800 > @@ -3634,7 +3634,10 @@ > "Include GC cause in GC logging") > \ > > \ > product(bool, EnableTracing, false, > \ > - "Enable event-based tracing") > + "Enable event-based tracing") > \ > + > \ > + product(bool, UseLockedTracing, false, > \ > + "Use locked-tracing when doing event-based tracing") > > /* > * Macros for factoring of globals > diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 > -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 2013 > +0800 > @@ -132,6 +132,9 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + if (UseLockedTracing) { > + ttyLocker ttyl; > + } > TraceStream ts(*tty); > ts.print(": ["); select="value|structvalue" mode="write-data"/> > > Regards, > Yunda > > > -----Original Message----- > > From: David Holmes [mailto:david.holmes at oracle.com] > > Sent: Tuesday, May 07, 2013 10:39 AM > > To: ??(Yunda) > > Cc: hotspot-runtime-dev at openjdk.java.net; > > serviceability-dev at openjdk.java.net > > Subject: Re: [PATCH] EnableTracing: output from multiple threads may > > be mixed together > > > > Hi Yunda, > > > > There is a potential problem with using a ttyLocker here, depending on > > exactly what events are being traced and from where - you must always > > be in code where it is both safe to acquire the lock, and safe to > > block waiting for the lock if it is not available. > > > > I think I would prefer to see unlocked tracing by default with a flag > > to use locked-tracing if requested. > > > > David > > > > On 19/04/2013 6:26 PM, ??(Yunda) wrote: > > > Hi all, > > > > > > I found that the output from multiple threads may be mixed together > > > when using EnableTracing. It happens many times in my test case like this: > > > > > > Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new > > > TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: > > > [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = > > > java/lang/String, Allocation Size = 24, Allocation Size = 24, Class > > > = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, > > > Allocation in new TLAB: [Allocation Size = 192] > > > > > > Class = > > > com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, > > > Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > > > > > > TLAB Size = 24607080] > > > > > > Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, > > > TLAB Size = 25054480] > > > > > > TLAB Size = 25054480] > > > > > > Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > > > > > > Allocation Size = 72, Class = [C, TLAB Size = 24159728] > > > > > > , Allocation Size = 32, TLAB Size = 23712288] > > > > > > It's very confusing and it's even not easy to tell how many events > > > there are. I think the reason is that the writeEvent() method of > > > each > > > Event* class output the fields of event one by one without using any > > > lock. So I made a small patch which add ttyLocker to writeEvent() > > > method and after applying this patch there's no output mixed > > > together in my test case(against > http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > > > > > > diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > > > > > > --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 > > > 2013 -0700 > > > > > > +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 > > > +++ 2013 > > > +0800 > > > > > > @@ -132,6 +132,7 @@ > > > > > > void writeEvent(void) { > > > > > > ResourceMark rm; > > > > > > HandleMark hm; > > > > > > + ttyLocker ttyl; > > > > > > TraceStream ts(*tty); > > > > > > ts.print(": ["); > > > > > > > > > > > > I searched before sending this mail I didn't find anyone who > > > covering thisJ > > > > > > Regards, > > > > > > Yunda > > > > > > > > > -------------------------------------------------------------------- > > > -- > > > -- > > > > > > This email (including any attachments) is confidential and may be > > > legally privileged. If you received this email in error, please > > > delete it immediately and do not copy it or use it for any purpose > > > or disclose its contents to any other person. Thank you. > > > > > > ???(??????)????????????????????? > ? > > ???? > > > ??????????????????????????????? > > ????? > > > ???????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From david.holmes at oracle.com Tue May 7 02:50:01 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 07 May 2013 19:50:01 +1000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <5188693D.8000304@oracle.com> Message-ID: <5188CE49.3020103@oracle.com> On 7/05/2013 7:43 PM, ??(Yunda) wrote: > Hi David, > > Thanks for the review and I see your concern. Please see the updated change below: > > diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 > +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 +0800 > @@ -3634,7 +3634,10 @@ > "Include GC cause in GC logging") \ > \ > product(bool, EnableTracing, false, \ > - "Enable event-based tracing") > + "Enable event-based tracing") \ > + \ > + product(bool, UseLockedTracing, false, \ > + "Use locked-tracing when doing event-based tracing") > > /* > * Macros for factoring of globals > diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 2013 +0800 > @@ -132,6 +132,9 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + if (UseLockedTracing) { > + ttyLocker ttyl; > + } Ah that doesn't work - the ttyLocker is block-scoped by the if statement so it will be created, grab the lock, then immediately be destructed and the lock released. David ----- > TraceStream ts(*tty); > ts.print(": ["); > > > Regards, > Yunda > >> -----Original Message----- >> From: David Holmes [mailto:david.holmes at oracle.com] >> Sent: Tuesday, May 07, 2013 10:39 AM >> To: ??(Yunda) >> Cc: hotspot-runtime-dev at openjdk.java.net; >> serviceability-dev at openjdk.java.net >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed >> together >> >> Hi Yunda, >> >> There is a potential problem with using a ttyLocker here, depending on exactly >> what events are being traced and from where - you must always be in code >> where it is both safe to acquire the lock, and safe to block waiting for the lock if >> it is not available. >> >> I think I would prefer to see unlocked tracing by default with a flag to use >> locked-tracing if requested. >> >> David >> >> On 19/04/2013 6:26 PM, ??(Yunda) wrote: >>> Hi all, >>> >>> I found that the output from multiple threads may be mixed together >>> when using EnableTracing. It happens many times in my test case like this: >>> >>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new >>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: >>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = >>> java/lang/String, Allocation Size = 24, Allocation Size = 24, Class = >>> java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, >>> Allocation in new TLAB: [Allocation Size = 192] >>> >>> Class = com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, >>> Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] >>> >>> TLAB Size = 24607080] >>> >>> Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, >>> TLAB Size = 25054480] >>> >>> TLAB Size = 25054480] >>> >>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] >>> >>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] >>> >>> , Allocation Size = 32, TLAB Size = 23712288] >>> >>> It's very confusing and it's even not easy to tell how many events >>> there are. I think the reason is that the writeEvent() method of each >>> Event* class output the fields of event one by one without using any >>> lock. So I made a small patch which add ttyLocker to writeEvent() >>> method and after applying this patch there's no output mixed together >>> in my test case(against http://hg.openjdk.java.net/hsx/hsx24/hotspot/): >>> >>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl >>> >>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 >>> 2013 -0700 >>> >>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 >>> +++ 2013 >>> +0800 >>> >>> @@ -132,6 +132,7 @@ >>> >>> void writeEvent(void) { >>> >>> ResourceMark rm; >>> >>> HandleMark hm; >>> >>> + ttyLocker ttyl; >>> >>> TraceStream ts(*tty); >>> >>> ts.print(": ["); >>> >>> >>> >>> I searched before sending this mail I didn't find anyone who covering >>> thisJ >>> >>> Regards, >>> >>> Yunda >>> >>> >>> ---------------------------------------------------------------------- >>> -- >>> >>> This email (including any attachments) is confidential and may be >>> legally privileged. If you received this email in error, please delete >>> it immediately and do not copy it or use it for any purpose or >>> disclose its contents to any other person. Thank you. >>> >>> ???(??????)?????????????????????? >> ???? >>> ??????????????????????????????? >> ????? >>> ???????? > > ________________________________ > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? > From daniel.fuchs at oracle.com Tue May 7 02:58:24 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 07 May 2013 09:58:24 +0000 Subject: hg: jdk8/tl/jaxp: 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Message-ID: <20130507095833.BA0374886F@hg.openjdk.java.net> Changeset: 452e1a182907 Author: dfuchs Date: 2013-05-06 18:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/452e1a182907 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb ! src/com/sun/org/apache/xml/internal/serializer/Encodings.java From daniel.fuchs at oracle.com Tue May 7 02:59:09 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 07 May 2013 09:59:09 +0000 Subject: hg: jdk8/tl/jdk: 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Message-ID: <20130507100036.C35C948870@hg.openjdk.java.net> Changeset: 2602eab5f086 Author: dfuchs Date: 2013-05-07 11:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2602eab5f086 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb + test/javax/xml/jaxp/Encodings/CheckEncodingPropertiesFile.java From bengt.rutisson at oracle.com Tue May 7 04:24:04 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 07 May 2013 13:24:04 +0200 Subject: RFR: Update to test java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java In-Reply-To: <27635A0E-EDAD-4097-AA8E-F0F38CDB50E6@oracle.com> References: <27635A0E-EDAD-4097-AA8E-F0F38CDB50E6@oracle.com> Message-ID: <5188E454.2070506@oracle.com> Hi Staffan, I think this looks good. Two minor comments about the @run commands. Both of these will use the SerialOld collector and since the test really only test the old generation I think one is enough: * @run main/othervm -XX:+UseSerialGC -Xmn8m ResetPeakMemoryUsage * @run main/othervm -XX:+UseParNewGC -Xmn8m ResetPeakMemoryUsage I would suggest to keep the SerialGC version. Also, I think the G1 @run command should work with the same settings as the other GCs. To be on the safe side it might be worth setting the region size to make sure it matches the young gen size. So: * @run main/othervm -XX:+UseG1GC -Xmn8m -XX:G1HeapRegionSize=1m ResetPeakMemoryUsage Thanks, Bengt On 5/6/13 5:17 PM, Staffan Larsen wrote: > This test had a number of problems reported against it: > > http://bugs.sun.com/view_bug.do?bug_id=7148492 > http://bugs.sun.com/view_bug.do?bug_id=6980985 > http://bugs.sun.com/view_bug.do?bug_id=7181907 > > This overhaul of the test tries to address all of these and improve the test robustness. The changes I have done are: > > - Make sure the allocated large object is not easy to optimize away by storing it in a public field. > - Removed the dynamic calculation of the large object's size since this sometimes caused problems. > - Added GC configuration parameters to make sure the large object is allocated in the old gen. > - Added GC configuration parameters to run the test with all GC algorithms. > - Changed the printMemoryUsage() method to take MemoryUsages as parameters so it prints the same values as were used for comparisons. > - Changed some incorrect '>' to '<' in printouts. > - Removed the assumption that peak usage after the GC should be the same as before the GC. This is not true since "stuff" may have been moved from younger generations into the old gen thereby increasing the heap. > > webrev: http://cr.openjdk.java.net/~sla/7148492/webrev.00/ > > I've been running the test through JPRT a couple of times to try to ensure that it always passes. > > Thanks, > /Staffan From staffan.larsen at oracle.com Tue May 7 04:49:42 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 7 May 2013 13:49:42 +0200 Subject: RFR: Update to test java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java In-Reply-To: <5188E454.2070506@oracle.com> References: <27635A0E-EDAD-4097-AA8E-F0F38CDB50E6@oracle.com> <5188E454.2070506@oracle.com> Message-ID: <46D8A3E7-799B-4C1C-AB3F-339467C6A0CD@oracle.com> Thanks Bengt. I'll make those changes before pushing the fix. /Staffan On 7 maj 2013, at 13:24, Bengt Rutisson wrote: > > Hi Staffan, > > I think this looks good. > > Two minor comments about the @run commands. > > Both of these will use the SerialOld collector and since the test really only test the old generation I think one is enough: > > * @run main/othervm -XX:+UseSerialGC -Xmn8m ResetPeakMemoryUsage > * @run main/othervm -XX:+UseParNewGC -Xmn8m ResetPeakMemoryUsage > > I would suggest to keep the SerialGC version. > > Also, I think the G1 @run command should work with the same settings as the other GCs. To be on the safe side it might be worth setting the region size to make sure it matches the young gen size. So: > > * @run main/othervm -XX:+UseG1GC -Xmn8m -XX:G1HeapRegionSize=1m ResetPeakMemoryUsage > > Thanks, > Bengt > > > On 5/6/13 5:17 PM, Staffan Larsen wrote: >> This test had a number of problems reported against it: >> >> http://bugs.sun.com/view_bug.do?bug_id=7148492 >> http://bugs.sun.com/view_bug.do?bug_id=6980985 >> http://bugs.sun.com/view_bug.do?bug_id=7181907 >> >> This overhaul of the test tries to address all of these and improve the test robustness. The changes I have done are: >> >> - Make sure the allocated large object is not easy to optimize away by storing it in a public field. >> - Removed the dynamic calculation of the large object's size since this sometimes caused problems. >> - Added GC configuration parameters to make sure the large object is allocated in the old gen. >> - Added GC configuration parameters to run the test with all GC algorithms. >> - Changed the printMemoryUsage() method to take MemoryUsages as parameters so it prints the same values as were used for comparisons. >> - Changed some incorrect '>' to '<' in printouts. >> - Removed the assumption that peak usage after the GC should be the same as before the GC. This is not true since "stuff" may have been moved from younger generations into the old gen thereby increasing the heap. >> >> webrev: http://cr.openjdk.java.net/~sla/7148492/webrev.00/ >> >> I've been running the test through JPRT a couple of times to try to ensure that it always passes. >> >> Thanks, >> /Staffan > From kevin.walls at oracle.com Tue May 7 05:06:08 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 07 May 2013 13:06:08 +0100 Subject: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException In-Reply-To: <51837619.500@oracle.com> References: <517FF943.6020906@oracle.com> <5182660D.8010105@oracle.com> <51837619.500@oracle.com> Message-ID: <5188EE30.4010005@oracle.com> Hi - I'd like to get another review from an openjdk user/reviewer/... Thanks Kevin On 03/05/13 09:32, Kevin Walls wrote: > Thanks Staffan, thanks Peter! > > > On 02/05/13 14:11, Peter Allwin wrote: >> Hi Kevin, >> >> Looks good! >> >> I've been looking into improving the quality of native stack traces >> on Windows using IDebugControl::GetStackTrace. This has the advantage >> of handling some FPO frames on x86 (a common source of these >> exceptions), as well as supporting AMD64 (walking the stack using RBP >> does not work at all on Windows/X64). There are still some issues to >> iron out before this change is ready, but your fix is a good start to >> what I'd like to accomplish. >> >> >> Thanks, >> >> Peter >> >>> ------------------------------------------------------------------------ >>> >>> Kevin Walls >>> Tuesday, April 30, 2013 7:02 PM >>> >>> >>> Hi, >>> >>> I'd like some review of this suggestion to fix: >>> 6313816 SA windows unaligned address exception >>> >>> webrev: >>> http://cr.openjdk.java.net/~kevinw/6313816/webrev/ >>> >>> This bug is a long-standing annoyance, mainly shown by using jstack -m >>> >>> Already fixed on Linux with additional sanity checks on ebp/rbp >>> values in >>> e.g. LinuxX86CFrame.sender() >>> >>> On Windows there isn't such a convenient place to put these checks, >>> as they >>> call getAddressValue() which is only part of the specific debugger >>> interfaces >>> such as LinuxDebugger, WindbgDebugger, etc.. and on Windows we use >>> X86CFrame and AMD64CFrame. These are constructed with only a >>> CDebugger, there is no "WinXXXFrame" class - perhaps there should be! >>> >>> That's what I've tried here, by renaming e.g. X86CFrame to >>> WinX86CFrame, >>> and adding the extra sanity checks as we already have in >>> LinuxX86CFrame. >>> >>> As files have move thed diff isn't obvious, but in common with some >>> previous changes >>> the new bits are x86 and x64 versions of these: >>> >>> + // Check alignment of rbp >>> + if ( dbg.getAddressValue(rbp) % ADDRESS_SIZE != 0) { >>> + return null; >>> + } >>> + >>> >>> and >>> >>> - if (nextRBP == null) { >>> + if (nextRBP == null || nextRBP.lessThanOrEqual(rbp)) { >>> >>> >>> This additional symmetry between the platforms seems to make sense, and >>> should help any future changes. >>> >>> Thanks >>> Kevin >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130507/ed173277/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130507/ed173277/compose-unknown-contact-0001.jpg From markus.gronlund at oracle.com Tue May 7 05:27:10 2013 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Tue, 7 May 2013 05:27:10 -0700 (PDT) Subject: RFR(S): 8005038 remove crufty '_g' support from SA In-Reply-To: References: Message-ID: <7816c504-35c9-40f9-a128-4ac00b14a5c6@default> Looks good. /Markus -----Original Message----- From: Staffan Larsen Sent: den 7 maj 2013 10:03 To: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: RFR(S): 8005038 remove crufty '_g' support from SA Please review this little fix to remove the _g support from the SA files. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038 webrev: http://cr.openjdk.java.net/~sla/8005038/webrev.00/ Thanks, /Staffan From yunda.mly at taobao.com Tue May 7 05:33:55 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Tue, 7 May 2013 12:33:55 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <5188CE49.3020103@oracle.com> References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> Message-ID: David, Sorry about the stupid mistake. And please see the tested change below. Since I don't find an elegant way to define a ttyLocker object, I use the static methods of ttyLocker instead. diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 +0800 @@ -3634,7 +3634,10 @@ "Include GC cause in GC logging") \ \ product(bool, EnableTracing, false, \ - "Enable event-based tracing") + "Enable event-based tracing") \ + \ + product(bool, UseLockedTracing, false, \ + "Use locked-tracing when doing event-based tracing") /* * Macros for factoring of globals diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 -0700 +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 2013 +0800 @@ -132,10 +132,17 @@ void writeEvent(void) { ResourceMark rm; HandleMark hm; + int holder; + if (UseLockedTracing) { + holder = ttyLocker::hold_tty(); + } TraceStream ts(*tty); ts.print(": ["); ts.print("]\n"); + if (UseLockedTracing) { + ttyLocker::release_tty(holder); + } } }; Regards, Yunda > -----Original Message----- > From: David Holmes [mailto:david.holmes at oracle.com] > Sent: Tuesday, May 07, 2013 5:50 PM > To: ??(Yunda) > Cc: hotspot-runtime-dev at openjdk.java.net; > serviceability-dev at openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > On 7/05/2013 7:43 PM, ??(Yunda) wrote: > > Hi David, > > > > Thanks for the review and I see your concern. Please see the updated change > below: > > > > diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > > --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 > > +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 +0800 > > @@ -3634,7 +3634,10 @@ > > "Include GC cause in GC logging") > \ > > > \ > > product(bool, EnableTracing, false, > \ > > - "Enable event-based tracing") > > + "Enable event-based tracing") > \ > > + > \ > > + product(bool, UseLockedTracing, false, > \ > > + "Use locked-tracing when doing event-based > > + tracing") > > > > /* > > * Macros for factoring of globals > > diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > > --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 > > 2013 -0700 > > +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 > > +++ 2013 +0800 > > @@ -132,6 +132,9 @@ > > void writeEvent(void) { > > ResourceMark rm; > > HandleMark hm; > > + if (UseLockedTracing) { > > + ttyLocker ttyl; > > + } > > Ah that doesn't work - the ttyLocker is block-scoped by the if statement so it > will be created, grab the lock, then immediately be destructed and the lock > released. > > David > ----- > > > TraceStream ts(*tty); > > ts.print(": ["); > > > > > > Regards, > > Yunda > > > >> -----Original Message----- > >> From: David Holmes [mailto:david.holmes at oracle.com] > >> Sent: Tuesday, May 07, 2013 10:39 AM > >> To: ??(Yunda) > >> Cc: hotspot-runtime-dev at openjdk.java.net; > >> serviceability-dev at openjdk.java.net > >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may > >> be mixed together > >> > >> Hi Yunda, > >> > >> There is a potential problem with using a ttyLocker here, depending > >> on exactly what events are being traced and from where - you must > >> always be in code where it is both safe to acquire the lock, and safe > >> to block waiting for the lock if it is not available. > >> > >> I think I would prefer to see unlocked tracing by default with a flag > >> to use locked-tracing if requested. > >> > >> David > >> > >> On 19/04/2013 6:26 PM, ??(Yunda) wrote: > >>> Hi all, > >>> > >>> I found that the output from multiple threads may be mixed together > >>> when using EnableTracing. It happens many times in my test case like this: > >>> > >>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new > >>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: > >>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = > >>> java/lang/String, Allocation Size = 24, Allocation Size = 24, Class > >>> = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, > >>> Allocation in new TLAB: [Allocation Size = 192] > >>> > >>> Class = > >>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, > >>> Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > >>> > >>> TLAB Size = 24607080] > >>> > >>> Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, > >>> TLAB Size = 25054480] > >>> > >>> TLAB Size = 25054480] > >>> > >>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > >>> > >>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] > >>> > >>> , Allocation Size = 32, TLAB Size = 23712288] > >>> > >>> It's very confusing and it's even not easy to tell how many events > >>> there are. I think the reason is that the writeEvent() method of > >>> each > >>> Event* class output the fields of event one by one without using any > >>> lock. So I made a small patch which add ttyLocker to writeEvent() > >>> method and after applying this patch there's no output mixed > >>> together in my test case(against > http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > >>> > >>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > >>> > >>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 > >>> 2013 -0700 > >>> > >>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 > >>> +++ 2013 > >>> +0800 > >>> > >>> @@ -132,6 +132,7 @@ > >>> > >>> void writeEvent(void) { > >>> > >>> ResourceMark rm; > >>> > >>> HandleMark hm; > >>> > >>> + ttyLocker ttyl; > >>> > >>> TraceStream ts(*tty); > >>> > >>> ts.print(": ["); > >>> > >>> > >>> > >>> I searched before sending this mail I didn't find anyone who > >>> covering thisJ > >>> > >>> Regards, > >>> > >>> Yunda > >>> > >>> > >>> -------------------------------------------------------------------- > >>> -- > >>> -- > >>> > >>> This email (including any attachments) is confidential and may be > >>> legally privileged. If you received this email in error, please > >>> delete it immediately and do not copy it or use it for any purpose > >>> or disclose its contents to any other person. Thank you. > >>> > >>> ???(??????)????????????????????? > ? > >> ???? > >>> ??????????????????????????????? > >> ????? > >>> ???????? > > > > ________________________________ > > > > This email (including any attachments) is confidential and may be legally > privileged. If you received this email in error, please delete it immediately and > do not copy it or use it for any purpose or disclose its contents to any other > person. Thank you. > > > > > ???(??????)?????????????????????? > ???????????????????????????????? > ????? > > ??????????? > > ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From staffan.larsen at oracle.com Tue May 7 05:43:19 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 7 May 2013 14:43:19 +0200 Subject: RFR: 8004007 : test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Message-ID: This is an old fix that fell between the cracks. Before JDK-7175133 was fixed, jinfo/Basic.sh was modified so that it wouldn't use SA. Now that JDK-7175133 is fixed, we can return to using SA. webrev: http://cr.openjdk.java.net/~sla/8004007/webrev.00/test/sun/tools/jinfo/Basic.sh.sdiff.html bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004007 testing: jdk_tools in JPRT Thanks, /Staffan From Alan.Bateman at oracle.com Tue May 7 05:57:46 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 07 May 2013 13:57:46 +0100 Subject: RFR: 8004007 : test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true In-Reply-To: References: Message-ID: <5188FA4A.9070803@oracle.com> On 07/05/2013 13:43, Staffan Larsen wrote: > This is an old fix that fell between the cracks. Before JDK-7175133 was fixed, jinfo/Basic.sh was modified so that it wouldn't use SA. Now that JDK-7175133 is fixed, we can return to using SA. > > webrev: http://cr.openjdk.java.net/~sla/8004007/webrev.00/test/sun/tools/jinfo/Basic.sh.sdiff.html > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004007 > > testing: jdk_tools in JPRT > > Thanks, > /Staffan Looks good to me. -Alan From dmitry.samersoff at oracle.com Tue May 7 05:57:55 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 07 May 2013 16:57:55 +0400 Subject: RFR: 8004007 : test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true In-Reply-To: References: Message-ID: <5188FA53.1030609@oracle.com> Looks good for me. On 2013-05-07 16:43, Staffan Larsen wrote: > This is an old fix that fell between the cracks. Before JDK-7175133 was fixed, jinfo/Basic.sh was modified so that it wouldn't use SA. Now that JDK-7175133 is fixed, we can return to using SA. > > webrev: http://cr.openjdk.java.net/~sla/8004007/webrev.00/test/sun/tools/jinfo/Basic.sh.sdiff.html > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004007 > > testing: jdk_tools in JPRT > > Thanks, > /Staffan > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From robert.field at oracle.com Tue May 7 06:40:47 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 07 May 2013 13:40:47 +0000 Subject: hg: jdk8/tl/langtools: 8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails Message-ID: <20130507134050.5103F48876@hg.openjdk.java.net> Changeset: 68142e69cafb Author: rfield Date: 2013-05-07 06:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/68142e69cafb 8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReference/TreeMakerParamsIsGoofy.java From jesper.wilhelmsson at oracle.com Tue May 7 06:54:28 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 07 May 2013 15:54:28 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <5188FA86.4010608@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> Message-ID: <51890794.1090501@oracle.com> Hi, Please check with the serviceability team (CC:ed) before adding a flag to control the threshold. I suspect that they would prefer some tracing specific way to configure these thresholds. /Jesper Erik Helin skrev 7/5/13 2:58 PM: > Hi Bengt, > > thanks for the review! > > On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >> >> Hi Erik, >> >> Looks good. >> >> Two minor nits: >> >> Could we make 0.05 into a flag or at least a declared constant? > > Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. > > On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >> Could we rename _used_heap_in_words to something like >> _total_size_in_words or _base_size_in_words since it is not really the >> used count for the heap? > > Agree, I renamed it to _total_size_in_words. > > Please see new webrev at: > http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ > > Thanks, > Erik > >> Thanks, >> Bengt >> >> On 5/7/13 10:14 AM, Erik Helin wrote: >>> Hi all, >>> >>> this change makes sure that we only send the trace event >>> vm/gc/detailed/object_count_after_gc if the total size of all the >>> instances of a class occupies more than 0.5% of the used heap. >>> >>> Webrev: >>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>> >>> Testing: >>> JPRT >>> >>> Thanks, >>> Erik >> >> > From staffan.larsen at oracle.com Tue May 7 08:05:52 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 07 May 2013 15:05:52 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014044: Spelling error in JDK-8009615: boostrapmethod Message-ID: <20130507150557.99B884887A@hg.openjdk.java.net> Changeset: b5fef8013a95 Author: sla Date: 2013-05-07 14:04 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5fef8013a95 8014044: Spelling error in JDK-8009615: boostrapmethod Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp From staffan.larsen at oracle.com Tue May 7 10:58:16 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 07 May 2013 17:58:16 +0000 Subject: hg: jdk8/tl/jdk: 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1; ... Message-ID: <20130507175848.2F40E48885@hg.openjdk.java.net> Changeset: 7b40394ad944 Author: sla Date: 2013-05-07 19:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b40394ad944 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1 7181907: TEST_BUG: j/l/management/MemoryMXBean/ResetPeakMemoryUsage fails with NegativeArraySizeException 7148492: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java failing since update to hs23-b15 or b16 Reviewed-by: mchung, brutisso ! test/ProblemList.txt ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java From staffan.larsen at oracle.com Tue May 7 11:02:05 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 07 May 2013 18:02:05 +0000 Subject: hg: jdk8/tl/jdk: 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Message-ID: <20130507180217.528FF48886@hg.openjdk.java.net> Changeset: 100027950b05 Author: sla Date: 2013-05-07 20:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/100027950b05 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Reviewed-by: alanb, dsamersoff ! test/sun/tools/jinfo/Basic.sh From naoto.sato at oracle.com Tue May 7 11:31:45 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 07 May 2013 18:31:45 +0000 Subject: hg: jdk8/tl/jdk: 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied Message-ID: <20130507183159.253EB48896@hg.openjdk.java.net> Changeset: e30396e22c6f Author: naoto Date: 2013-05-07 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e30396e22c6f 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From staffan.larsen at oracle.com Tue May 7 12:04:14 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 07 May 2013 19:04:14 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8005038: remove crufty '_g' support from SA Message-ID: <20130507190419.49C5448898@hg.openjdk.java.net> Changeset: f6a055fcf47d Author: sla Date: 2013-05-07 14:33 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6a055fcf47d 8005038: remove crufty '_g' support from SA Reviewed-by: coleenp, mgronlun, rbackman ! agent/src/os/bsd/ps_core.c ! agent/src/os/linux/ps_core.c ! agent/src/os/solaris/proc/saproc.cpp ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/LinuxVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java From mike.duigou at oracle.com Tue May 7 12:06:45 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 07 May 2013 19:06:45 +0000 Subject: hg: jdk8/tl/jdk: 4802647: Throw required NPEs from removeAll()/retainAll() Message-ID: <20130507190659.5BB8D4889A@hg.openjdk.java.net> Changeset: fe4e9bc2186f Author: mduigou Date: 2013-05-07 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe4e9bc2186f 4802647: Throw required NPEs from removeAll()/retainAll() Reviewed-by: mduigou, chegar, dholmes Contributed-by: Brandon Passanisi ! src/share/classes/java/util/AbstractCollection.java ! src/share/classes/java/util/AbstractSet.java ! src/share/classes/java/util/ArrayList.java ! test/java/util/Collection/MOAT.java From erik.helin at oracle.com Tue May 7 12:28:32 2013 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 07 May 2013 21:28:32 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <51890794.1090501@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> Message-ID: <518955E0.9000500@oracle.com> Jesper, I've changed the flag to be an experimental flag instead of a product flag. Please see new webrev at: http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ Thanks, Erik On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: > Hi, > > Please check with the serviceability team (CC:ed) before adding a flag > to control the threshold. I suspect that they would prefer some tracing > specific way to configure these thresholds. > /Jesper > > > Erik Helin skrev 7/5/13 2:58 PM: >> Hi Bengt, >> >> thanks for the review! >> >> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>> >>> Hi Erik, >>> >>> Looks good. >>> >>> Two minor nits: >>> >>> Could we make 0.05 into a flag or at least a declared constant? >> >> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >> >> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>> Could we rename _used_heap_in_words to something like >>> _total_size_in_words or _base_size_in_words since it is not really the >>> used count for the heap? >> >> Agree, I renamed it to _total_size_in_words. >> >> Please see new webrev at: >> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >> >> Thanks, >> Erik >> >>> Thanks, >>> Bengt >>> >>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>> Hi all, >>>> >>>> this change makes sure that we only send the trace event >>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>> instances of a class occupies more than 0.5% of the used heap. >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>> >>>> Testing: >>>> JPRT >>>> >>>> Thanks, >>>> Erik >>> >>> >> From jesper.wilhelmsson at oracle.com Tue May 7 12:52:15 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 07 May 2013 21:52:15 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <518955E0.9000500@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> <518955E0.9000500@oracle.com> Message-ID: <51895B6F.1090106@oracle.com> Erik Helin skrev 7/5/13 9:28 PM: > Jesper, > > I've changed the flag to be an experimental flag instead of a product flag. Thanks! > Please see new webrev at: > http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ If you want to change the description of the flag to say "... to generate a trace event.", I think it would read better. But either way I'm fine with this change. /Jesper > > Thanks, > Erik > > On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: >> Hi, >> >> Please check with the serviceability team (CC:ed) before adding a flag >> to control the threshold. I suspect that they would prefer some tracing >> specific way to configure these thresholds. >> /Jesper >> >> >> Erik Helin skrev 7/5/13 2:58 PM: >>> Hi Bengt, >>> >>> thanks for the review! >>> >>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>> >>>> Hi Erik, >>>> >>>> Looks good. >>>> >>>> Two minor nits: >>>> >>>> Could we make 0.05 into a flag or at least a declared constant? >>> >>> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >>> >>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>> Could we rename _used_heap_in_words to something like >>>> _total_size_in_words or _base_size_in_words since it is not really the >>>> used count for the heap? >>> >>> Agree, I renamed it to _total_size_in_words. >>> >>> Please see new webrev at: >>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >>> >>> Thanks, >>> Erik >>> >>>> Thanks, >>>> Bengt >>>> >>>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>>> Hi all, >>>>> >>>>> this change makes sure that we only send the trace event >>>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>>> instances of a class occupies more than 0.5% of the used heap. >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>>> >>>>> Testing: >>>>> JPRT >>>>> >>>>> Thanks, >>>>> Erik >>>> >>>> >>> > From kellyohair at gmail.com Tue May 7 13:09:21 2013 From: kellyohair at gmail.com (Kelly O'Hair) Date: Tue, 7 May 2013 13:09:21 -0700 Subject: RFR(S): 8005038 remove crufty '_g' support from SA In-Reply-To: References: Message-ID: Hurrah, the wicked _g witch is dead! If my review is worth anything, looks good. I started the _g removal so long ago, glad to see this being done. -kto P.S. People probably thought I was run over by a truck or something, but I am lurking around still. :) On May 7, 2013, at 1:02 AM, Staffan Larsen wrote: > Please review this little fix to remove the _g support from the SA files. > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038 > webrev: http://cr.openjdk.java.net/~sla/8005038/webrev.00/ > > Thanks, > /Staffan From daniel.daugherty at oracle.com Tue May 7 13:28:11 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 07 May 2013 14:28:11 -0600 Subject: RFR(S): 8005038 remove crufty '_g' support from SA In-Reply-To: References: Message-ID: <518963DB.5030307@oracle.com> On 5/7/13 2:09 PM, Kelly O'Hair wrote: > Hurrah, the wicked _g witch is dead! Close, but not quite there: JDK-8005073 remove crufty '_g' support from HS tests http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005073 https://jbs.oracle.com/bugs/browse/JDK-8005073 Just one left to go (IIRC)... > If my review is worth anything, looks good. Your reviews are always appreciated, but the changeset has already pushed. > I started the _g removal so long ago, glad to see this being done. Don'cha mean 'redone' ... :-) > > -kto > > P.S. People probably thought I was run over by a truck or something, but I am lurking around still. :) Glad you're still around and chiming in! Dan > > On May 7, 2013, at 1:02 AM, Staffan Larsen wrote: > >> Please review this little fix to remove the _g support from the SA files. >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038 >> webrev: http://cr.openjdk.java.net/~sla/8005038/webrev.00/ >> >> Thanks, >> /Staffan From ron.durbin at oracle.com Tue May 7 14:08:16 2013 From: ron.durbin at oracle.com (Ron Durbin) Date: Tue, 7 May 2013 14:08:16 -0700 (PDT) Subject: RFR(S): 8005038 remove crufty '_g' support from SA In-Reply-To: <518963DB.5030307@oracle.com> References: <518963DB.5030307@oracle.com> Message-ID: Dan you are so correct, JDK-8005073 is not a hard one just needs to be done. A good starter bug. > -----Original Message----- > From: Daniel D. Daugherty > Sent: Tuesday, May 07, 2013 2:28 PM > To: Kelly O'Hair > Cc: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-runtime- > dev at openjdk.java.net > Subject: Re: RFR(S): 8005038 remove crufty '_g' support from SA > > On 5/7/13 2:09 PM, Kelly O'Hair wrote: > > Hurrah, the wicked _g witch is dead! > > Close, but not quite there: > > JDK-8005073 remove crufty '_g' support from HS tests > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005073 > https://jbs.oracle.com/bugs/browse/JDK-8005073 > > Just one left to go (IIRC)... > > > > If my review is worth anything, looks good. > > Your reviews are always appreciated, but the changeset has already pushed. > > > > I started the _g removal so long ago, glad to see this being done. > > Don'cha mean 'redone' ... :-) > > > > > > -kto > > > > P.S. People probably thought I was run over by a truck or something, but I am lurking around still. > :) > > Glad you're still around and chiming in! > > Dan > > > > > > On May 7, 2013, at 1:02 AM, Staffan Larsen wrote: > > > >> Please review this little fix to remove the _g support from the SA files. > >> > >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005038 > >> webrev: http://cr.openjdk.java.net/~sla/8005038/webrev.00/ > >> > >> Thanks, > >> /Staffan > From christian.tornqvist at oracle.com Tue May 7 14:26:58 2013 From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com) Date: Tue, 07 May 2013 21:26:58 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8009577: Test test/closed/runtime/classunload broken Message-ID: <20130507212700.D3070488A0@hg.openjdk.java.net> Changeset: 33bcd9ead1d5 Author: ctornqvi Date: 2013-05-07 21:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/33bcd9ead1d5 8009577: Test test/closed/runtime/classunload broken Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with where custom classloader got the classes from Reviewed-by: collins, mgerdin, zgu + test/runtime/ClassUnload/KeepAliveClass.java + test/runtime/ClassUnload/KeepAliveClassLoader.java + test/runtime/ClassUnload/KeepAliveObject.java + test/runtime/ClassUnload/KeepAliveSoftReference.java + test/runtime/ClassUnload/UnloadTest.java + test/runtime/ClassUnload/classes/test/Empty.java + test/runtime/testlibrary/ClassUnloadCommon.java From jonathan.gibbons at oracle.com Tue May 7 14:28:36 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 07 May 2013 21:28:36 +0000 Subject: hg: jdk8/tl/langtools: 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Message-ID: <20130507212839.A34B0488A1@hg.openjdk.java.net> Changeset: 43c2f7cb9c76 Author: jjg Date: 2013-05-07 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/43c2f7cb9c76 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + src/share/classes/com/sun/tools/javac/util/ServiceLoader.java ! test/tools/javac/plugin/showtype/Test.java From mike.duigou at oracle.com Tue May 7 16:19:54 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 07 May 2013 23:19:54 +0000 Subject: hg: jdk8/tl/jdk: 8012664: Add tests for java.util.stream and lambda translation Message-ID: <20130507232015.C328D488B7@hg.openjdk.java.net> Changeset: 6feee75b0a8b Author: briangoetz Date: 2013-05-06 11:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6feee75b0a8b 8012664: Add tests for java.util.stream and lambda translation Reviewed-by: mduigou, briangoetz Contributed-by: Brian Goetz , Paul Sandoz , Mike Duigou , Robert Field , Jim Gish ! test/Makefile + test/java/util/concurrent/atomic/AtomicReferenceTest.java + test/java/util/stream/bootlib/TEST.properties + test/java/util/stream/bootlib/java/util/stream/CollectorOps.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/FlagDeclaringOp.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/IntermediateTestOp.java + test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/OpTestCase.java + test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StatefulTestOp.java + test/java/util/stream/bootlib/java/util/stream/StatelessTestOp.java + test/java/util/stream/bootlib/java/util/stream/StreamOpFlagTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/TestData.java + test/java/util/stream/bootlib/java/util/stream/TestFlagExpectedOp.java + test/java/util/stream/boottest/TEST.properties + test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java + test/java/util/stream/boottest/java/util/stream/FlagOpTest.java + test/java/util/stream/boottest/java/util/stream/IntNodeTest.java + test/java/util/stream/boottest/java/util/stream/LongNodeTest.java + test/java/util/stream/boottest/java/util/stream/NodeBuilderTest.java + test/java/util/stream/boottest/java/util/stream/NodeTest.java + test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java + test/java/util/stream/boottest/java/util/stream/StreamFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamOpFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamReuseTest.java + test/java/util/stream/boottest/java/util/stream/UnorderedTest.java + test/java/util/stream/test/TEST.properties + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/DeserializeMethodTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/MHProxiesTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/NullArgsTestCase.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/CollectionAndMapModifyStreamTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DoublePrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FilterOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindAnyOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindFirstOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntUniqOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/LongPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MinMaxTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveAverageOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveSumTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamParSeqTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SummaryStatisticsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TeeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java + test/jdk/lambda/ArrayCtorRefTest.java + test/jdk/lambda/FDTest.java + test/jdk/lambda/LambdaTranslationCompoundSamTest.java + test/jdk/lambda/LambdaTranslationInInterface.java + test/jdk/lambda/LambdaTranslationInnerConstructor.java + test/jdk/lambda/LambdaTranslationTest1.java + test/jdk/lambda/LambdaTranslationTest2.java + test/jdk/lambda/MethodReferenceTestFDCCE.java + test/jdk/lambda/MethodReferenceTestInnerDefault.java + test/jdk/lambda/MethodReferenceTestInnerInstance.java + test/jdk/lambda/MethodReferenceTestInnerVarArgsThis.java + test/jdk/lambda/MethodReferenceTestInstance.java + test/jdk/lambda/MethodReferenceTestInstanceMethod.java + test/jdk/lambda/MethodReferenceTestKinds.java + test/jdk/lambda/MethodReferenceTestNew.java + test/jdk/lambda/MethodReferenceTestNewInner.java + test/jdk/lambda/MethodReferenceTestSueCase1.java + test/jdk/lambda/MethodReferenceTestSueCase2.java + test/jdk/lambda/MethodReferenceTestSueCase4.java + test/jdk/lambda/MethodReferenceTestSuper.java + test/jdk/lambda/MethodReferenceTestSuperDefault.java + test/jdk/lambda/MethodReferenceTestTypeConversion.java + test/jdk/lambda/MethodReferenceTestVarArgs.java + test/jdk/lambda/MethodReferenceTestVarArgsExt.java + test/jdk/lambda/MethodReferenceTestVarArgsSuper.java + test/jdk/lambda/MethodReferenceTestVarArgsSuperDefault.java + test/jdk/lambda/MethodReferenceTestVarArgsThis.java + test/jdk/lambda/TEST.properties + test/jdk/lambda/TestInnerCtorRef.java + test/jdk/lambda/TestPrivateCtorRef.java + test/jdk/lambda/separate/AttributeInjector.java + test/jdk/lambda/separate/ClassFile.java + test/jdk/lambda/separate/ClassFilePreprocessor.java + test/jdk/lambda/separate/ClassToInterfaceConverter.java + test/jdk/lambda/separate/Compiler.java + test/jdk/lambda/separate/DirectedClassLoader.java + test/jdk/lambda/separate/SourceModel.java + test/jdk/lambda/separate/TestHarness.java + test/jdk/lambda/shapegen/ClassCase.java + test/jdk/lambda/shapegen/Hierarchy.java + test/jdk/lambda/shapegen/HierarchyGenerator.java + test/jdk/lambda/shapegen/Rule.java + test/jdk/lambda/shapegen/RuleGroup.java + test/jdk/lambda/shapegen/TTNode.java + test/jdk/lambda/shapegen/TTParser.java + test/jdk/lambda/shapegen/TTShape.java + test/jdk/lambda/vm/DefaultMethodRegressionTests.java + test/jdk/lambda/vm/DefaultMethodsTest.java + test/jdk/lambda/vm/InterfaceAccessFlagsTest.java + test/jdk/lambda/vm/StrictfpDefault.java From stuart.marks at oracle.com Tue May 7 16:50:22 2013 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 07 May 2013 16:50:22 -0700 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <51877204.8000104@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> <5183C6D5.8070302@oracle.com> <51877204.8000104@oracle.com> Message-ID: <5189933E.40702@oracle.com> Hi Jaroslav, Great to see this shell test get rewritten! Looks like you're avoiding multiple JVM processes as well, by loading the different versions of the classes into different classloaders. It looks like a bit of trouble, but probably less than the amount of trouble caused by the shell script. I have a couple minor points. The timeout value of one second seems quite low. Under normal operation, spawning a couple threads and should proceed very quickly. However, our testing environment is quite hostile, and things that seem like they ought to proceed quickly often take considerably longer than one might think. Since you're counting notifications, and in normal operation they all come in, we don't wait for the actual timeout unless there's a failure. So it might make sense to raise the timeout to 10 or perhaps 30 seconds. On the other hand, I have a question about whether counting the number of notifications is correct. Would it be possible for there to be a bug where an extra notification is sent? If so, this might mean that the test would exit prematurely, indicating success? s'marks On 5/6/13 2:04 AM, Jaroslav Bachorik wrote: > On P? 3. kv?ten 2013, 16:16:53 CEST, Daniel Fuchs wrote: >> Hi Jaroslav, >> >> In Client.java - you could consider replacing the AtomicLong >> with a CountDownLatch. >> >> This would allow you to remove the various Thread.sleep() in the >> code (in particular the one at the end). >> >> You could use CountDownLatch.await(long timeout, TimeUnit unit) to >> avoid waiting for ever in case of bugs, and the advantage is that >> the test would be able to exit as soon as the count down latch >> reaches 0, without having to wait for an arbitrary timeout. > > Great, thanks for the pointer! I've changed the test to use the > CountDownLatch. > > http://cr.openjdk.java.net/~jbachorik/8005472/webrev.08/ > > -JB- > >> >> Very nice to see a shell test go away :-) >> >> -- daniel >> >> >> On 5/3/13 3:41 PM, Jaroslav Bachorik wrote: >>> Please re-review the updated webrev >>> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 >>> >>> I've replaced the shell script with the plain java test. The javac API >>> is used to compile the the auxiliary classes as was recommended. This >>> allowed to simplify the test. >>> >>> The test does not check for a certain string in the standard output >>> anymore - it turns out that it is possible to count the number of all >>> the received JMX notifications (even though some notifications can be >>> lost, we receive a special notification with the number of the lost >>> regular notifications). It is then possible to match the actual number >>> of processed notifications (received + lost) against the expected number >>> - different numbers mean that the notification processing thread had >>> been interrupted unexpectedly. >>> >>> Thanks, >>> >>> -JB- >>> >>> On 8.2.2013 17:37, Chris Hegarty wrote: >>>> >>>>> Jon Gibbons suggested invoking the compiler API directly from java >>>>> instead of writing a shell script. Doing this seems fairly simple, >>>>> and I >>>>> think it would be advantageous to keep things entirely in Java. I may >>>>> attempt to rewrite the defaultSVID test using the compiler API. >>>> >>>> Here's a test that does just that. >>>> >>>> http://hg.openjdk.java.net/jdk8/tl/jdk/file/2de8c6c2d652/test/sun/misc/JarIndex/metaInfFilenames/Basic.java >>>> >>>> >>>> >>>> -Chris. >>> >> > > From weijun.wang at oracle.com Tue May 7 17:26:14 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 08 May 2013 00:26:14 +0000 Subject: hg: jdk8/tl/jdk: 8012679: Let allow_weak_crypto default to false Message-ID: <20130508002627.168F2488BB@hg.openjdk.java.net> Changeset: 7d89b0dd973c Author: weijun Date: 2013-05-08 08:25 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d89b0dd973c 8012679: Let allow_weak_crypto default to false Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! test/sun/security/krb5/auto/DupEtypes.java ! test/sun/security/krb5/etype/WeakCrypto.java From david.holmes at oracle.com Tue May 7 17:41:42 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 08 May 2013 10:41:42 +1000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> Message-ID: <51899F46.1090800@oracle.com> On 7/05/2013 10:33 PM, ??(Yunda) wrote: > David, > > Sorry about the stupid mistake. And please see the tested change below. Since I don't find an elegant way to define a ttyLocker object, I use the static methods of ttyLocker instead. Yeah there's no elegant solution when you need to conditionalize things. :( This looks fine to me but the serviceability folk should chime back in. Thanks, David > diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 > +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 +0800 > @@ -3634,7 +3634,10 @@ > "Include GC cause in GC logging") \ > \ > product(bool, EnableTracing, false, \ > - "Enable event-based tracing") > + "Enable event-based tracing") \ > + \ > + product(bool, UseLockedTracing, false, \ > + "Use locked-tracing when doing event-based tracing") > > /* > * Macros for factoring of globals > diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 2013 +0800 > @@ -132,10 +132,17 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + int holder; > + if (UseLockedTracing) { > + holder = ttyLocker::hold_tty(); > + } > TraceStream ts(*tty); > ts.print(": ["); > > ts.print("]\n"); > + if (UseLockedTracing) { > + ttyLocker::release_tty(holder); > + } > } > }; > > > Regards, > Yunda > > >> -----Original Message----- >> From: David Holmes [mailto:david.holmes at oracle.com] >> Sent: Tuesday, May 07, 2013 5:50 PM >> To: ??(Yunda) >> Cc: hotspot-runtime-dev at openjdk.java.net; >> serviceability-dev at openjdk.java.net >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed >> together >> >> On 7/05/2013 7:43 PM, ??(Yunda) wrote: >>> Hi David, >>> >>> Thanks for the review and I see your concern. Please see the updated change >> below: >>> >>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 >>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 +0800 >>> @@ -3634,7 +3634,10 @@ >>> "Include GC cause in GC logging") >> \ >>> >> \ >>> product(bool, EnableTracing, false, >> \ >>> - "Enable event-based tracing") >>> + "Enable event-based tracing") >> \ >>> + >> \ >>> + product(bool, UseLockedTracing, false, >> \ >>> + "Use locked-tracing when doing event-based >>> + tracing") >>> >>> /* >>> * Macros for factoring of globals >>> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl >>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>> 2013 -0700 >>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 >>> +++ 2013 +0800 >>> @@ -132,6 +132,9 @@ >>> void writeEvent(void) { >>> ResourceMark rm; >>> HandleMark hm; >>> + if (UseLockedTracing) { >>> + ttyLocker ttyl; >>> + } >> >> Ah that doesn't work - the ttyLocker is block-scoped by the if statement so it >> will be created, grab the lock, then immediately be destructed and the lock >> released. >> >> David >> ----- >> >>> TraceStream ts(*tty); >>> ts.print(": ["); >>> >>> >>> Regards, >>> Yunda >>> >>>> -----Original Message----- >>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>> Sent: Tuesday, May 07, 2013 10:39 AM >>>> To: ??(Yunda) >>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>> serviceability-dev at openjdk.java.net >>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads may >>>> be mixed together >>>> >>>> Hi Yunda, >>>> >>>> There is a potential problem with using a ttyLocker here, depending >>>> on exactly what events are being traced and from where - you must >>>> always be in code where it is both safe to acquire the lock, and safe >>>> to block waiting for the lock if it is not available. >>>> >>>> I think I would prefer to see unlocked tracing by default with a flag >>>> to use locked-tracing if requested. >>>> >>>> David >>>> >>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: >>>>> Hi all, >>>>> >>>>> I found that the output from multiple threads may be mixed together >>>>> when using EnableTracing. It happens many times in my test case like this: >>>>> >>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new >>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: >>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = >>>>> java/lang/String, Allocation Size = 24, Allocation Size = 24, Class >>>>> = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, >>>>> Allocation in new TLAB: [Allocation Size = 192] >>>>> >>>>> Class = >>>>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, >>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] >>>>> >>>>> TLAB Size = 24607080] >>>>> >>>>> Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, >>>>> TLAB Size = 25054480] >>>>> >>>>> TLAB Size = 25054480] >>>>> >>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] >>>>> >>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] >>>>> >>>>> , Allocation Size = 32, TLAB Size = 23712288] >>>>> >>>>> It's very confusing and it's even not easy to tell how many events >>>>> there are. I think the reason is that the writeEvent() method of >>>>> each >>>>> Event* class output the fields of event one by one without using any >>>>> lock. So I made a small patch which add ttyLocker to writeEvent() >>>>> method and after applying this patch there's no output mixed >>>>> together in my test case(against >> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): >>>>> >>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl >>>>> >>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 >>>>> 2013 -0700 >>>>> >>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 >>>>> +++ 2013 >>>>> +0800 >>>>> >>>>> @@ -132,6 +132,7 @@ >>>>> >>>>> void writeEvent(void) { >>>>> >>>>> ResourceMark rm; >>>>> >>>>> HandleMark hm; >>>>> >>>>> + ttyLocker ttyl; >>>>> >>>>> TraceStream ts(*tty); >>>>> >>>>> ts.print(": ["); >>>>> >>>>> >>>>> >>>>> I searched before sending this mail I didn't find anyone who >>>>> covering thisJ >>>>> >>>>> Regards, >>>>> >>>>> Yunda >>>>> >>>>> >>>>> -------------------------------------------------------------------- >>>>> -- >>>>> -- >>>>> >>>>> This email (including any attachments) is confidential and may be >>>>> legally privileged. If you received this email in error, please >>>>> delete it immediately and do not copy it or use it for any purpose >>>>> or disclose its contents to any other person. Thank you. >>>>> >>>>> ???(??????)????????????????????? >> ? >>>> ???? >>>>> ??????????????????????????????? >>>> ????? >>>>> ???????? >>> >>> ________________________________ >>> >>> This email (including any attachments) is confidential and may be legally >> privileged. If you received this email in error, please delete it immediately and >> do not copy it or use it for any purpose or disclose its contents to any other >> person. Thank you. >> >>> >>> ???(??????)?????????????????????? >> ???????????????????????????????? >> ????? >>> ??????????? >>> > > ________________________________ > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? > From coleen.phillimore at oracle.com Tue May 7 18:41:12 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 08 May 2013 01:41:12 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130508014118.83DEE488BE@hg.openjdk.java.net> Changeset: 58bb870a0cbd Author: emc Date: 2013-05-07 13:45 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/58bb870a0cbd 8009729: Refix hotspot jni_.h JNIEXPORT and JNIIMPORT definitions to match jdk version Summary: Update JNIEXPORT and JNIIMPORT to work with other compilers that don't necessarily have the __attribute__ type qualifier Reviewed-by: dholmes, dcubed, coleenp ! src/cpu/sparc/vm/jni_sparc.h ! src/cpu/x86/vm/jni_x86.h ! src/cpu/zero/vm/jni_zero.h Changeset: 7243490a6847 Author: coleenp Date: 2013-05-07 14:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7243490a6847 Merge From coleen.phillimore at oracle.com Tue May 7 23:09:56 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 08 May 2013 06:09:56 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 4 new changesets Message-ID: <20130508061004.0AD9D488CE@hg.openjdk.java.net> Changeset: 712a1e9c91f3 Author: coleenp Date: 2013-05-07 09:46 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/712a1e9c91f3 8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on os::free Summary: Clear out class_file_bytes so they aren't deallocated twice Reviewed-by: dcubed, sspitsyn ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 4674e409a9e6 Author: coleenp Date: 2013-05-07 18:51 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4674e409a9e6 8014024: NPG: keep compiled ic methods from being deallocated in redefine classes Summary: Walk the compiledIC relocation records to keep Method* from being deallocated. Reviewed-by: dlong, kvn ! src/share/vm/code/nmethod.cpp Changeset: a1cc1d1e7ce5 Author: coleenp Date: 2013-05-07 16:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1cc1d1e7ce5 Merge Changeset: 28ae1d38d296 Author: coleenp Date: 2013-05-07 18:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/28ae1d38d296 Merge From rickard.backman at oracle.com Wed May 8 00:02:51 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Wed, 8 May 2013 09:02:51 +0200 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <51899F46.1090800@oracle.com> References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> <51899F46.1090800@oracle.com> Message-ID: <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> One option could be to move the content of writeEvent() to its own method (maybe writeEventContent()) and just do if (UseLockedTracing) { ttyLocker lock; writeEventContent(); } else { writeEventContent(); } I think it makes it easier to read. /R On May 8, 2013, at 2:41 AM, David Holmes wrote: > On 7/05/2013 10:33 PM, ??(Yunda) wrote: >> David, >> >> Sorry about the stupid mistake. And please see the tested change below. Since I don't find an elegant way to define a ttyLocker object, I use the static methods of ttyLocker instead. > > Yeah there's no elegant solution when you need to conditionalize things. :( > > This looks fine to me but the serviceability folk should chime back in. > > Thanks, > David > >> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 >> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 +0800 >> @@ -3634,7 +3634,10 @@ >> "Include GC cause in GC logging") \ >> \ >> product(bool, EnableTracing, false, \ >> - "Enable event-based tracing") >> + "Enable event-based tracing") \ >> + \ >> + product(bool, UseLockedTracing, false, \ >> + "Use locked-tracing when doing event-based tracing") >> >> /* >> * Macros for factoring of globals >> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl >> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 -0700 >> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 2013 +0800 >> @@ -132,10 +132,17 @@ >> void writeEvent(void) { >> ResourceMark rm; >> HandleMark hm; >> + int holder; >> + if (UseLockedTracing) { >> + holder = ttyLocker::hold_tty(); >> + } >> TraceStream ts(*tty); >> ts.print(": ["); >> >> ts.print("]\n"); >> + if (UseLockedTracing) { >> + ttyLocker::release_tty(holder); >> + } >> } >> }; >> >> >> Regards, >> Yunda >> >> >>> -----Original Message----- >>> From: David Holmes [mailto:david.holmes at oracle.com] >>> Sent: Tuesday, May 07, 2013 5:50 PM >>> To: ??(Yunda) >>> Cc: hotspot-runtime-dev at openjdk.java.net; >>> serviceability-dev at openjdk.java.net >>> Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed >>> together >>> >>> On 7/05/2013 7:43 PM, ??(Yunda) wrote: >>>> Hi David, >>>> >>>> Thanks for the review and I see your concern. Please see the updated change >>> below: >>>> >>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 >>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 +0800 >>>> @@ -3634,7 +3634,10 @@ >>>> "Include GC cause in GC logging") >>> \ >>>> >>> \ >>>> product(bool, EnableTracing, false, >>> \ >>>> - "Enable event-based tracing") >>>> + "Enable event-based tracing") >>> \ >>>> + >>> \ >>>> + product(bool, UseLockedTracing, false, >>> \ >>>> + "Use locked-tracing when doing event-based >>>> + tracing") >>>> >>>> /* >>>> * Macros for factoring of globals >>>> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl >>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>>> 2013 -0700 >>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 >>>> +++ 2013 +0800 >>>> @@ -132,6 +132,9 @@ >>>> void writeEvent(void) { >>>> ResourceMark rm; >>>> HandleMark hm; >>>> + if (UseLockedTracing) { >>>> + ttyLocker ttyl; >>>> + } >>> >>> Ah that doesn't work - the ttyLocker is block-scoped by the if statement so it >>> will be created, grab the lock, then immediately be destructed and the lock >>> released. >>> >>> David >>> ----- >>> >>>> TraceStream ts(*tty); >>>> ts.print(": ["); >>>> >>>> >>>> Regards, >>>> Yunda >>>> >>>>> -----Original Message----- >>>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>>> Sent: Tuesday, May 07, 2013 10:39 AM >>>>> To: ??(Yunda) >>>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>>> serviceability-dev at openjdk.java.net >>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads may >>>>> be mixed together >>>>> >>>>> Hi Yunda, >>>>> >>>>> There is a potential problem with using a ttyLocker here, depending >>>>> on exactly what events are being traced and from where - you must >>>>> always be in code where it is both safe to acquire the lock, and safe >>>>> to block waiting for the lock if it is not available. >>>>> >>>>> I think I would prefer to see unlocked tracing by default with a flag >>>>> to use locked-tracing if requested. >>>>> >>>>> David >>>>> >>>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: >>>>>> Hi all, >>>>>> >>>>>> I found that the output from multiple threads may be mixed together >>>>>> when using EnableTracing. It happens many times in my test case like this: >>>>>> >>>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation in new >>>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: >>>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = >>>>>> java/lang/String, Allocation Size = 24, Allocation Size = 24, Class >>>>>> = java/lang/String, Class = [I, Allocation in new TLAB: [Class = [C, >>>>>> Allocation in new TLAB: [Allocation Size = 192] >>>>>> >>>>>> Class = >>>>>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, >>>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] >>>>>> >>>>>> TLAB Size = 24607080] >>>>>> >>>>>> Allocation Size = 24, Monitor Class = java/lang/ref/Reference$Lock, >>>>>> TLAB Size = 25054480] >>>>>> >>>>>> TLAB Size = 25054480] >>>>>> >>>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] >>>>>> >>>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] >>>>>> >>>>>> , Allocation Size = 32, TLAB Size = 23712288] >>>>>> >>>>>> It's very confusing and it's even not easy to tell how many events >>>>>> there are. I think the reason is that the writeEvent() method of >>>>>> each >>>>>> Event* class output the fields of event one by one without using any >>>>>> lock. So I made a small patch which add ttyLocker to writeEvent() >>>>>> method and after applying this patch there's no output mixed >>>>>> together in my test case(against >>> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): >>>>>> >>>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl >>>>>> >>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 13:50:58 >>>>>> 2013 -0700 >>>>>> >>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 16:12:38 >>>>>> +++ 2013 >>>>>> +0800 >>>>>> >>>>>> @@ -132,6 +132,7 @@ >>>>>> >>>>>> void writeEvent(void) { >>>>>> >>>>>> ResourceMark rm; >>>>>> >>>>>> HandleMark hm; >>>>>> >>>>>> + ttyLocker ttyl; >>>>>> >>>>>> TraceStream ts(*tty); >>>>>> >>>>>> ts.print(": ["); >>>>>> >>>>>> >>>>>> >>>>>> I searched before sending this mail I didn't find anyone who >>>>>> covering thisJ >>>>>> >>>>>> Regards, >>>>>> >>>>>> Yunda >>>>>> >>>>>> >>>>>> -------------------------------------------------------------------- >>>>>> -- >>>>>> -- >>>>>> >>>>>> This email (including any attachments) is confidential and may be >>>>>> legally privileged. If you received this email in error, please >>>>>> delete it immediately and do not copy it or use it for any purpose >>>>>> or disclose its contents to any other person. Thank you. >>>>>> >>>>>> ???(??????)????????????????????? >>> ? >>>>> ???? >>>>>> ??????????????????????????????? >>>>> ????? >>>>>> ???????? >>>> >>>> ________________________________ >>>> >>>> This email (including any attachments) is confidential and may be legally >>> privileged. If you received this email in error, please delete it immediately and >>> do not copy it or use it for any purpose or disclose its contents to any other >>> person. Thank you. >>> >>>> >>>> ???(??????)?????????????????????? >>> ???????????????????????????????? >>> ????? >>>> ??????????? >>>> >> >> ________________________________ >> >> This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. >> >> ???(??????)?????????????????????????????????????????????????????????????????????? >> From bengt.rutisson at oracle.com Wed May 8 00:27:28 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 08 May 2013 09:27:28 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <518955E0.9000500@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> <518955E0.9000500@oracle.com> Message-ID: <5189FE60.3000005@oracle.com> Erik, Looks good! Bengt On 5/7/13 9:28 PM, Erik Helin wrote: > Jesper, > > I've changed the flag to be an experimental flag instead of a product > flag. > > Please see new webrev at: > http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ > > Thanks, > Erik > > On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: >> Hi, >> >> Please check with the serviceability team (CC:ed) before adding a flag >> to control the threshold. I suspect that they would prefer some tracing >> specific way to configure these thresholds. >> /Jesper >> >> >> Erik Helin skrev 7/5/13 2:58 PM: >>> Hi Bengt, >>> >>> thanks for the review! >>> >>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>> >>>> Hi Erik, >>>> >>>> Looks good. >>>> >>>> Two minor nits: >>>> >>>> Could we make 0.05 into a flag or at least a declared constant? >>> >>> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >>> >>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>> Could we rename _used_heap_in_words to something like >>>> _total_size_in_words or _base_size_in_words since it is not really the >>>> used count for the heap? >>> >>> Agree, I renamed it to _total_size_in_words. >>> >>> Please see new webrev at: >>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >>> >>> Thanks, >>> Erik >>> >>>> Thanks, >>>> Bengt >>>> >>>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>>> Hi all, >>>>> >>>>> this change makes sure that we only send the trace event >>>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>>> instances of a class occupies more than 0.5% of the used heap. >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>>> >>>>> Testing: >>>>> JPRT >>>>> >>>>> Thanks, >>>>> Erik >>>> >>>> >>> > From erik.helin at oracle.com Wed May 8 01:00:31 2013 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 08 May 2013 10:00:31 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <51895B6F.1090106@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> <518955E0.9000500@oracle.com> <51895B6F.1090106@oracle.com> Message-ID: <518A061F.6050304@oracle.com> Jesper, On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: > Erik Helin skrev 7/5/13 9:28 PM: >> Jesper, >> >> I've changed the flag to be an experimental flag instead of a product >> flag. > > Thanks! > >> Please see new webrev at: >> http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ > > If you want to change the description of the flag to say "... to > generate a trace event.", I think it would read better. But either way > I'm fine with this change. I think that an even better description would be "... to generate a possible trace event", since even if the instances of the class takes up more than ObjectCountCutOffPercent of the used heap, there is no guarantee that an event will be sent (the event might be turned off). What do you think? Thanks, Erik > /Jesper > > >> >> Thanks, >> Erik >> >> On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: >>> Hi, >>> >>> Please check with the serviceability team (CC:ed) before adding a flag >>> to control the threshold. I suspect that they would prefer some tracing >>> specific way to configure these thresholds. >>> /Jesper >>> >>> >>> Erik Helin skrev 7/5/13 2:58 PM: >>>> Hi Bengt, >>>> >>>> thanks for the review! >>>> >>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>> >>>>> Hi Erik, >>>>> >>>>> Looks good. >>>>> >>>>> Two minor nits: >>>>> >>>>> Could we make 0.05 into a flag or at least a declared constant? >>>> >>>> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >>>> >>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>> Could we rename _used_heap_in_words to something like >>>>> _total_size_in_words or _base_size_in_words since it is not really the >>>>> used count for the heap? >>>> >>>> Agree, I renamed it to _total_size_in_words. >>>> >>>> Please see new webrev at: >>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >>>> >>>> Thanks, >>>> Erik >>>> >>>>> Thanks, >>>>> Bengt >>>>> >>>>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>>>> Hi all, >>>>>> >>>>>> this change makes sure that we only send the trace event >>>>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>>>> instances of a class occupies more than 0.5% of the used heap. >>>>>> >>>>>> Webrev: >>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>>>> >>>>>> Testing: >>>>>> JPRT >>>>>> >>>>>> Thanks, >>>>>> Erik >>>>> >>>>> >>>> >> From staffan.larsen at oracle.com Wed May 8 01:17:06 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 8 May 2013 10:17:06 +0200 Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly Message-ID: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change. The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated. The fix is to check for null and return 0 as the counter value. webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591 Thanks, /Staffan From jesper.wilhelmsson at oracle.com Wed May 8 01:20:33 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 08 May 2013 10:20:33 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <518A061F.6050304@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> <518955E0.9000500@oracle.com> <51895B6F.1090106@oracle.com> <518A061F.6050304@oracle.com> Message-ID: <518A0AD1.5080202@oracle.com> Erik Helin skrev 8/5/13 10:00 AM: > Jesper, > > On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: >> Erik Helin skrev 7/5/13 9:28 PM: >>> Jesper, >>> >>> I've changed the flag to be an experimental flag instead of a product >>> flag. >> >> Thanks! >> >>> Please see new webrev at: >>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ >> >> If you want to change the description of the flag to say "... to >> generate a trace event.", I think it would read better. But either way >> I'm fine with this change. > > I think that an even better description would be "... to generate a possible > trace event", since even if the instances of the class takes up more than > ObjectCountCutOffPercent of the used heap, there is no guarantee that an event > will be sent (the event might be turned off). > > What do you think? I think that the fact that the event might be turned off is unrelated to this flag and that the description would look better without the "possible". /Jesper > > Thanks, > Erik > >> /Jesper >> >> >>> >>> Thanks, >>> Erik >>> >>> On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: >>>> Hi, >>>> >>>> Please check with the serviceability team (CC:ed) before adding a flag >>>> to control the threshold. I suspect that they would prefer some tracing >>>> specific way to configure these thresholds. >>>> /Jesper >>>> >>>> >>>> Erik Helin skrev 7/5/13 2:58 PM: >>>>> Hi Bengt, >>>>> >>>>> thanks for the review! >>>>> >>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>> >>>>>> Hi Erik, >>>>>> >>>>>> Looks good. >>>>>> >>>>>> Two minor nits: >>>>>> >>>>>> Could we make 0.05 into a flag or at least a declared constant? >>>>> >>>>> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >>>>> >>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>> Could we rename _used_heap_in_words to something like >>>>>> _total_size_in_words or _base_size_in_words since it is not really the >>>>>> used count for the heap? >>>>> >>>>> Agree, I renamed it to _total_size_in_words. >>>>> >>>>> Please see new webrev at: >>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >>>>> >>>>> Thanks, >>>>> Erik >>>>> >>>>>> Thanks, >>>>>> Bengt >>>>>> >>>>>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> this change makes sure that we only send the trace event >>>>>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>>>>> instances of a class occupies more than 0.5% of the used heap. >>>>>>> >>>>>>> Webrev: >>>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>>>>> >>>>>>> Testing: >>>>>>> JPRT >>>>>>> >>>>>>> Thanks, >>>>>>> Erik >>>>>> >>>>>> >>>>> >>> > From david.holmes at oracle.com Wed May 8 01:46:49 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 08 May 2013 18:46:49 +1000 Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly In-Reply-To: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com> References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com> Message-ID: <518A10F9.9020103@oracle.com> Looks good to me Staffan! (Those methods should have been called getXXXCount not Counter though :( ) David On 8/05/2013 6:17 PM, Staffan Larsen wrote: > When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change. > > The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated. > > The fix is to check for null and return 0 as the counter value. > > webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591 > > Thanks, > /Staffan > From staffan.larsen at oracle.com Wed May 8 01:58:13 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 8 May 2013 10:58:13 +0200 Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly In-Reply-To: <518A10F9.9020103@oracle.com> References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com> <518A10F9.9020103@oracle.com> Message-ID: On 8 maj 2013, at 10:46, David Holmes wrote: > Looks good to me Staffan! Thanks. > (Those methods should have been called getXXXCount not Counter though :( ) We can fix that at the same time: http://cr.openjdk.java.net/~sla/8013591/webrev.01/ /Staffan > > David > > On 8/05/2013 6:17 PM, Staffan Larsen wrote: >> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change. >> >> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated. >> >> The fix is to check for null and return 0 as the counter value. >> >> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591 >> >> Thanks, >> /Staffan >> From rickard.backman at oracle.com Wed May 8 03:37:53 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Wed, 8 May 2013 12:37:53 +0200 Subject: RFR(S): 8013591 compiler/ciReplay/TestSA.sh fails in nightly In-Reply-To: References: <5DD5C851-4E13-4815-8138-F291AF685419@oracle.com> <518A10F9.9020103@oracle.com> Message-ID: Looks good! /R On May 8, 2013, at 10:58 AM, Staffan Larsen wrote: > > On 8 maj 2013, at 10:46, David Holmes wrote: > >> Looks good to me Staffan! > > Thanks. > >> (Those methods should have been called getXXXCount not Counter though :( ) > > We can fix that at the same time: http://cr.openjdk.java.net/~sla/8013591/webrev.01/ > > /Staffan > >> >> David >> >> On 8/05/2013 6:17 PM, Staffan Larsen wrote: >>> When JDK-8010862 (Method counter fields used for profiling can be allocated lazily) was fixed, SA was not updated to reflect this change. >>> >>> The problem is with Method.getInvocationCounter() and Method.getBackedgeCounter() which do not handle the case where MethodCounters are not allocated. >>> >>> The fix is to check for null and return 0 as the counter value. >>> >>> webrev: http://cr.openjdk.java.net/~sla/8013591/webrev.00/ >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013591 >>> >>> Thanks, >>> /Staffan >>> > From erik.helin at oracle.com Wed May 8 04:00:41 2013 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 08 May 2013 13:00:41 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <518A0AD1.5080202@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> <518955E0.9000500@oracle.com> <51895B6F.1090106@oracle.com> <518A061F.6050304@oracle.com> <518A0AD1.5080202@oracle.com> Message-ID: <518A3059.30301@oracle.com> Jesper, On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote: > Erik Helin skrev 8/5/13 10:00 AM: >> Jesper, >> >> On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: >>> Erik Helin skrev 7/5/13 9:28 PM: >>>> Jesper, >>>> >>>> I've changed the flag to be an experimental flag instead of a product >>>> flag. >>> >>> Thanks! >>> >>>> Please see new webrev at: >>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ >>> >>> If you want to change the description of the flag to say "... to >>> generate a trace event.", I think it would read better. But either way >>> I'm fine with this change. >> >> I think that an even better description would be "... to generate a >> possible >> trace event", since even if the instances of the class takes up more than >> ObjectCountCutOffPercent of the used heap, there is no guarantee that >> an event >> will be sent (the event might be turned off). >> >> What do you think? > > I think that the fact that the event might be turned off is unrelated to > this flag and that the description would look better without the > "possible". Ok sure, I will remove "possible" before pushing the change :) All good? Thanks, Erik > /Jesper > >> >> Thanks, >> Erik >> >>> /Jesper >>> >>> >>>> >>>> Thanks, >>>> Erik >>>> >>>> On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: >>>>> Hi, >>>>> >>>>> Please check with the serviceability team (CC:ed) before adding a flag >>>>> to control the threshold. I suspect that they would prefer some >>>>> tracing >>>>> specific way to configure these thresholds. >>>>> /Jesper >>>>> >>>>> >>>>> Erik Helin skrev 7/5/13 2:58 PM: >>>>>> Hi Bengt, >>>>>> >>>>>> thanks for the review! >>>>>> >>>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>>> >>>>>>> Hi Erik, >>>>>>> >>>>>>> Looks good. >>>>>>> >>>>>>> Two minor nits: >>>>>>> >>>>>>> Could we make 0.05 into a flag or at least a declared constant? >>>>>> >>>>>> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >>>>>> >>>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>>> Could we rename _used_heap_in_words to something like >>>>>>> _total_size_in_words or _base_size_in_words since it is not >>>>>>> really the >>>>>>> used count for the heap? >>>>>> >>>>>> Agree, I renamed it to _total_size_in_words. >>>>>> >>>>>> Please see new webrev at: >>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >>>>>> >>>>>> Thanks, >>>>>> Erik >>>>>> >>>>>>> Thanks, >>>>>>> Bengt >>>>>>> >>>>>>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> this change makes sure that we only send the trace event >>>>>>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>>>>>> instances of a class occupies more than 0.5% of the used heap. >>>>>>>> >>>>>>>> Webrev: >>>>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>>>>>> >>>>>>>> Testing: >>>>>>>> JPRT >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Erik >>>>>>> >>>>>>> >>>>>> >>>> >> From rickard.backman at oracle.com Wed May 8 04:08:57 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Wed, 8 May 2013 13:08:57 +0200 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return Message-ID: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> Hi, please review this small change. The change adds a check to see the result of a malloc() and aborts the VM with an out of memory error. Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 Thanks /R From jesper.wilhelmsson at oracle.com Wed May 8 04:29:47 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 08 May 2013 13:29:47 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <518A3059.30301@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> <518955E0.9000500@oracle.com> <51895B6F.1090106@oracle.com> <518A061F.6050304@oracle.com> <518A0AD1.5080202@oracle.com> <518A3059.30301@oracle.com> Message-ID: <518A372B.2000908@oracle.com> Erik Helin skrev 8/5/13 1:00 PM: > Jesper, > > On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote: >> Erik Helin skrev 8/5/13 10:00 AM: >>> Jesper, >>> >>> On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: >>>> Erik Helin skrev 7/5/13 9:28 PM: >>>>> Jesper, >>>>> >>>>> I've changed the flag to be an experimental flag instead of a product >>>>> flag. >>>> >>>> Thanks! >>>> >>>>> Please see new webrev at: >>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ >>>> >>>> If you want to change the description of the flag to say "... to >>>> generate a trace event.", I think it would read better. But either way >>>> I'm fine with this change. >>> >>> I think that an even better description would be "... to generate a >>> possible >>> trace event", since even if the instances of the class takes up more than >>> ObjectCountCutOffPercent of the used heap, there is no guarantee that >>> an event >>> will be sent (the event might be turned off). >>> >>> What do you think? >> >> I think that the fact that the event might be turned off is unrelated to >> this flag and that the description would look better without the >> "possible". > > Ok sure, I will remove "possible" before pushing the change :) > > All good? Yes, ship it! :-) Thanks for fixing this! /Jesper > > Thanks, > Erik > >> /Jesper >> >>> >>> Thanks, >>> Erik >>> >>>> /Jesper >>>> >>>> >>>>> >>>>> Thanks, >>>>> Erik >>>>> >>>>> On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: >>>>>> Hi, >>>>>> >>>>>> Please check with the serviceability team (CC:ed) before adding a flag >>>>>> to control the threshold. I suspect that they would prefer some >>>>>> tracing >>>>>> specific way to configure these thresholds. >>>>>> /Jesper >>>>>> >>>>>> >>>>>> Erik Helin skrev 7/5/13 2:58 PM: >>>>>>> Hi Bengt, >>>>>>> >>>>>>> thanks for the review! >>>>>>> >>>>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>>>> >>>>>>>> Hi Erik, >>>>>>>> >>>>>>>> Looks good. >>>>>>>> >>>>>>>> Two minor nits: >>>>>>>> >>>>>>>> Could we make 0.05 into a flag or at least a declared constant? >>>>>>> >>>>>>> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >>>>>>> >>>>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>>>> Could we rename _used_heap_in_words to something like >>>>>>>> _total_size_in_words or _base_size_in_words since it is not >>>>>>>> really the >>>>>>>> used count for the heap? >>>>>>> >>>>>>> Agree, I renamed it to _total_size_in_words. >>>>>>> >>>>>>> Please see new webrev at: >>>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >>>>>>> >>>>>>> Thanks, >>>>>>> Erik >>>>>>> >>>>>>>> Thanks, >>>>>>>> Bengt >>>>>>>> >>>>>>>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> this change makes sure that we only send the trace event >>>>>>>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>>>>>>> instances of a class occupies more than 0.5% of the used heap. >>>>>>>>> >>>>>>>>> Webrev: >>>>>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>>>>>>> >>>>>>>>> Testing: >>>>>>>>> JPRT >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Erik >>>>>>>> >>>>>>>> >>>>>>> >>>>> >>> > From joel.franck at oracle.com Wed May 8 05:12:25 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Wed, 08 May 2013 12:12:25 +0000 Subject: hg: jdk8/tl/langtools: 8013485: javac can't handle annotations with a from a previous compilation unit Message-ID: <20130508121228.4FF20488D6@hg.openjdk.java.net> Changeset: 780014a234fa Author: jfranck Date: 2013-05-08 14:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/780014a234fa 8013485: javac can't handle annotations with a from a previous compilation unit Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/clinit/AnnoWithClinit1.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.out From staffan.larsen at oracle.com Wed May 8 05:17:14 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 8 May 2013 14:17:14 +0200 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> Message-ID: <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> Looks good. /Staffan On 8 maj 2013, at 13:08, Rickard B?ckman wrote: > Hi, > > please review this small change. > The change adds a check to see the result of a malloc() and aborts the VM with an out of memory error. > > Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ > Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 > > Thanks > /R > From rickard.backman at oracle.com Wed May 8 05:17:58 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Wed, 8 May 2013 14:17:58 +0200 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> Message-ID: <0FED3257-310A-41C6-A6C2-20D3F481737F@oracle.com> Thank you, Staffan /R On May 8, 2013, at 2:17 PM, Staffan Larsen wrote: > Looks good. > > /Staffan > > On 8 maj 2013, at 13:08, Rickard B?ckman wrote: > >> Hi, >> >> please review this small change. >> The change adds a check to see the result of a malloc() and aborts the VM with an out of memory error. >> >> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ >> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 >> >> Thanks >> /R >> > From ron.durbin at oracle.com Wed May 8 05:31:22 2013 From: ron.durbin at oracle.com (Ron Durbin) Date: Wed, 8 May 2013 05:31:22 -0700 (PDT) Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> Message-ID: <16aa7d51-1709-48e5-b194-ce24f19d9a06@default> Change looks good, can tell me what tests were run? Were able create a unit test that triggers the failure ? Thx Ron > -----Original Message----- > From: Staffan Larsen > Sent: Wednesday, May 08, 2013 6:17 AM > To: Rickard B?ckman > Cc: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-runtime- > dev at openjdk.java.net > Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return > > Looks good. > > /Staffan > > On 8 maj 2013, at 13:08, Rickard B?ckman wrote: > > > Hi, > > > > please review this small change. > > The change adds a check to see the result of a malloc() and aborts the VM with an out of memory > error. > > > > Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 > > > > Thanks > > /R > > > From rickard.backman at oracle.com Wed May 8 05:33:55 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Wed, 8 May 2013 14:33:55 +0200 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <16aa7d51-1709-48e5-b194-ce24f19d9a06@default> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> <16aa7d51-1709-48e5-b194-ce24f19d9a06@default> Message-ID: <64EA72B4-AA8F-4762-9323-B5D17BC4A3DB@oracle.com> Ron, Thanks for the review. I ran the change through JPRT. Creating a specific test for this seems rather problematic as we need to make sure that a specific malloc() fails. /R On May 8, 2013, at 2:31 PM, Ron Durbin wrote: > Change looks good, can tell me what tests were run? > Were able create a unit test that triggers the failure ? > > Thx Ron > >> -----Original Message----- >> From: Staffan Larsen >> Sent: Wednesday, May 08, 2013 6:17 AM >> To: Rickard B?ckman >> Cc: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-runtime- >> dev at openjdk.java.net >> Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return >> >> Looks good. >> >> /Staffan >> >> On 8 maj 2013, at 13:08, Rickard B?ckman wrote: >> >>> Hi, >>> >>> please review this small change. >>> The change adds a check to see the result of a malloc() and aborts the VM with an out of memory >> error. >>> >>> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ >>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 >>> >>> Thanks >>> /R >>> >> From david.holmes at oracle.com Wed May 8 05:42:35 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 08 May 2013 22:42:35 +1000 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <16aa7d51-1709-48e5-b194-ce24f19d9a06@default> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> <16aa7d51-1709-48e5-b194-ce24f19d9a06@default> Message-ID: <518A483B.2080608@oracle.com> Ron, On 8/05/2013 10:31 PM, Ron Durbin wrote: > Change looks good, can tell me what tests were run? This kind of change requires very limited testing - JPRT testing will suffice. Adding a NULL check with a vm_exit_out_of_memory is not something that needs extensive testing applied. > Were able create a unit test that triggers the failure ? You would need a modified VM to trigger a malloc failure at any particular allocation site. David > Thx Ron > >> -----Original Message----- >> From: Staffan Larsen >> Sent: Wednesday, May 08, 2013 6:17 AM >> To: Rickard B?ckman >> Cc: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-runtime- >> dev at openjdk.java.net >> Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return >> >> Looks good. >> >> /Staffan >> >> On 8 maj 2013, at 13:08, Rickard B?ckman wrote: >> >>> Hi, >>> >>> please review this small change. >>> The change adds a check to see the result of a malloc() and aborts the VM with an out of memory >> error. >>> >>> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ >>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 >>> >>> Thanks >>> /R >>> >> From david.holmes at oracle.com Wed May 8 05:44:15 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 08 May 2013 22:44:15 +1000 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> Message-ID: <518A489F.8050605@oracle.com> Looks fine to me. As we discussed in the bug report there's no reasonable way to report the error so an abort is the only way out. David On 8/05/2013 9:08 PM, Rickard B?ckman wrote: > Hi, > > please review this small change. > The change adds a check to see the result of a malloc() and aborts the VM with an out of memory error. > > Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ > Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 > > Thanks > /R > From ron.durbin at oracle.com Wed May 8 05:49:00 2013 From: ron.durbin at oracle.com (Ron Durbin) Date: Wed, 8 May 2013 05:49:00 -0700 (PDT) Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <64EA72B4-AA8F-4762-9323-B5D17BC4A3DB@oracle.com> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> <8AE1DA76-89D7-4873-ACB2-26178FDF2EC2@oracle.com> <16aa7d51-1709-48e5-b194-ce24f19d9a06@default> <64EA72B4-AA8F-4762-9323-B5D17BC4A3DB@oracle.com> Message-ID: <7c3899ff-b92e-4c3c-aff1-d411f4386e8b@default> Rickard I glad to hear that you did run it through JPRT. The fixes for bugs like this one I have needed a test hook that forces the code execution into the fixed Code path. Ron > -----Original Message----- > From: Rickard B?ckman > Sent: Wednesday, May 08, 2013 6:34 AM > To: Ron Durbin > Cc: Staffan Larsen; serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot- > runtime-dev at openjdk.java.net > Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return > > Ron, > > Thanks for the review. > > I ran the change through JPRT. > Creating a specific test for this seems rather problematic as we need to make sure that a specific > malloc() fails. > > /R > > On May 8, 2013, at 2:31 PM, Ron Durbin wrote: > > > Change looks good, can tell me what tests were run? > > Were able create a unit test that triggers the failure ? > > > > Thx Ron > > > >> -----Original Message----- > >> From: Staffan Larsen > >> Sent: Wednesday, May 08, 2013 6:17 AM > >> To: Rickard B?ckman > >> Cc: serviceability-dev at openjdk.java.net > >> serviceability-dev at openjdk.java.net; hotspot-runtime- > >> dev at openjdk.java.net > >> Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does > >> not check malloc() return > >> > >> Looks good. > >> > >> /Staffan > >> > >> On 8 maj 2013, at 13:08, Rickard B?ckman wrote: > >> > >>> Hi, > >>> > >>> please review this small change. > >>> The change adds a check to see the result of a malloc() and aborts > >>> the VM with an out of memory > >> error. > >>> > >>> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ > >>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 > >>> > >>> Thanks > >>> /R > >>> > >> > From rickard.backman at oracle.com Wed May 8 05:52:51 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Wed, 8 May 2013 14:52:51 +0200 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <518A489F.8050605@oracle.com> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> <518A489F.8050605@oracle.com> Message-ID: Thank you David /R On May 8, 2013, at 2:44 PM, David Holmes wrote: > Looks fine to me. As we discussed in the bug report there's no reasonable way to report the error so an abort is the only way out. > > David > > On 8/05/2013 9:08 PM, Rickard B?ckman wrote: >> Hi, >> >> please review this small change. >> The change adds a check to see the result of a malloc() and aborts the VM with an out of memory error. >> >> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ >> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 >> >> Thanks >> /R >> From daniel.daugherty at oracle.com Wed May 8 05:57:34 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 08 May 2013 06:57:34 -0600 Subject: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return In-Reply-To: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> References: <938EFF7B-F5A3-4144-B7FB-75A24FDC887D@oracle.com> Message-ID: <518A4BBE.40603@oracle.com> On 5/8/13 5:08 AM, Rickard B?ckman wrote: > Hi, > > please review this small change. > The change adds a check to see the result of a malloc() and aborts the VM with an out of memory error. > > Webrev: http://cr.openjdk.java.net/~rbackman/8008255/ > Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255 src/share/vm/prims/jvmtiExport.cpp No comments. Thumbs up. Nice discussion about the alternatives in the bug report. BTW, there is one more option, but you don't want to go down that road. You could go ahead and post the event, but not cache the class bytes. However, there are implications about not caching the class bytes for the semantics of JVM/TI RetransformClasses() and I don't think you want to wander down that path. Dan > > Thanks > /R > From erik.helin at oracle.com Wed May 8 06:35:24 2013 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 08 May 2013 15:35:24 +0200 Subject: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap In-Reply-To: <518A372B.2000908@oracle.com> References: <5188B800.4080708@oracle.com> <5188CC98.6040505@oracle.com> <5188FA86.4010608@oracle.com> <51890794.1090501@oracle.com> <518955E0.9000500@oracle.com> <51895B6F.1090106@oracle.com> <518A061F.6050304@oracle.com> <518A0AD1.5080202@oracle.com> <518A3059.30301@oracle.com> <518A372B.2000908@oracle.com> Message-ID: <518A549C.7040606@oracle.com> Thanks! Erik On 05/08/2013 01:29 PM, Jesper Wilhelmsson wrote: > Erik Helin skrev 8/5/13 1:00 PM: >> Jesper, >> >> On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote: >>> Erik Helin skrev 8/5/13 10:00 AM: >>>> Jesper, >>>> >>>> On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: >>>>> Erik Helin skrev 7/5/13 9:28 PM: >>>>>> Jesper, >>>>>> >>>>>> I've changed the flag to be an experimental flag instead of a product >>>>>> flag. >>>>> >>>>> Thanks! >>>>> >>>>>> Please see new webrev at: >>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ >>>>> >>>>> If you want to change the description of the flag to say "... to >>>>> generate a trace event.", I think it would read better. But either way >>>>> I'm fine with this change. >>>> >>>> I think that an even better description would be "... to generate a >>>> possible >>>> trace event", since even if the instances of the class takes up more >>>> than >>>> ObjectCountCutOffPercent of the used heap, there is no guarantee that >>>> an event >>>> will be sent (the event might be turned off). >>>> >>>> What do you think? >>> >>> I think that the fact that the event might be turned off is unrelated to >>> this flag and that the description would look better without the >>> "possible". >> >> Ok sure, I will remove "possible" before pushing the change :) >> >> All good? > > Yes, ship it! :-) > > Thanks for fixing this! > /Jesper > > >> >> Thanks, >> Erik >> >>> /Jesper >>> >>>> >>>> Thanks, >>>> Erik >>>> >>>>> /Jesper >>>>> >>>>> >>>>>> >>>>>> Thanks, >>>>>> Erik >>>>>> >>>>>> On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: >>>>>>> Hi, >>>>>>> >>>>>>> Please check with the serviceability team (CC:ed) before adding a >>>>>>> flag >>>>>>> to control the threshold. I suspect that they would prefer some >>>>>>> tracing >>>>>>> specific way to configure these thresholds. >>>>>>> /Jesper >>>>>>> >>>>>>> >>>>>>> Erik Helin skrev 7/5/13 2:58 PM: >>>>>>>> Hi Bengt, >>>>>>>> >>>>>>>> thanks for the review! >>>>>>>> >>>>>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>>>>> >>>>>>>>> Hi Erik, >>>>>>>>> >>>>>>>>> Looks good. >>>>>>>>> >>>>>>>>> Two minor nits: >>>>>>>>> >>>>>>>>> Could we make 0.05 into a flag or at least a declared constant? >>>>>>>> >>>>>>>> Good suggestion, I've turned into a flag: ObjectCountCutOffPercent. >>>>>>>> >>>>>>>> On 05/07/2013 11:42 AM, Bengt Rutisson wrote: >>>>>>>>> Could we rename _used_heap_in_words to something like >>>>>>>>> _total_size_in_words or _base_size_in_words since it is not >>>>>>>>> really the >>>>>>>>> used count for the heap? >>>>>>>> >>>>>>>> Agree, I renamed it to _total_size_in_words. >>>>>>>> >>>>>>>> Please see new webrev at: >>>>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.01/ >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Erik >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Bengt >>>>>>>>> >>>>>>>>> On 5/7/13 10:14 AM, Erik Helin wrote: >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> this change makes sure that we only send the trace event >>>>>>>>>> vm/gc/detailed/object_count_after_gc if the total size of all the >>>>>>>>>> instances of a class occupies more than 0.5% of the used heap. >>>>>>>>>> >>>>>>>>>> Webrev: >>>>>>>>>> http://cr.openjdk.java.net/~ehelin/8012086/webrev.00/ >>>>>>>>>> >>>>>>>>>> Testing: >>>>>>>>>> JPRT >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Erik >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>> >> From harold.seigel at oracle.com Wed May 8 07:10:58 2013 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Wed, 08 May 2013 14:10:58 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8007018: RFE: -XX:+UseLargePages does not work with CDS Message-ID: <20130508141100.425F0488D9@hg.openjdk.java.net> Changeset: 64340da5b68c Author: hseigel Date: 2013-05-08 08:20 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/64340da5b68c 8007018: RFE: -XX:+UseLargePages does not work with CDS Summary: Remove command line restriction. It should just work. Reviewed-by: ctornqvi, coleenp, dholmes ! src/share/vm/runtime/arguments.cpp From staffan.larsen at oracle.com Wed May 8 09:01:04 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 08 May 2013 16:01:04 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130508160110.7E9CC488DE@hg.openjdk.java.net> Changeset: cbfe859bd244 Author: sla Date: 2013-05-08 15:37 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbfe859bd244 8013591: compiler/ciReplay/TestSA.sh fails in nightly Reviewed-by: coleenp, rbackman, dholmes ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java Changeset: 0dc028fd5101 Author: sla Date: 2013-05-08 10:14 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0dc028fd5101 Merge From alan.bateman at oracle.com Wed May 8 10:03:43 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 08 May 2013 17:03:43 +0000 Subject: hg: jdk8/tl/jdk: 8013652: (profiles) Add javax.script to compact1 Message-ID: <20130508170355.73850488E2@hg.openjdk.java.net> Changeset: c8f47674d105 Author: alanb Date: 2013-05-08 18:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8f47674d105 8013652: (profiles) Add javax.script to compact1 Reviewed-by: mchung, dholmes ! makefiles/profile-rtjar-includes.txt From bharadwaj.yadavalli at oracle.com Wed May 8 18:04:01 2013 From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com) Date: Thu, 09 May 2013 01:04:01 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8013875: Incorrect vtable index being set during methodHandle creation for static Message-ID: <20130509010406.3B5E44890D@hg.openjdk.java.net> Changeset: 39ead0411f07 Author: bharadwaj Date: 2013-05-08 14:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/39ead0411f07 8013875: Incorrect vtable index being set during methodHandle creation for static Summary: Set vtable index as appropriate for static interface methods and for interface methods invoked via invokespecial. To be improved in a later enhancement to CallInfo. Reviewed-by: jrose, twisti ! src/share/vm/prims/methodHandles.cpp From david.holmes at oracle.com Wed May 8 20:15:41 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 09 May 2013 03:15:41 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets Message-ID: <20130509031548.CA6DD4891A@hg.openjdk.java.net> Changeset: 711016f146fd Author: dholmes Date: 2013-05-08 19:28 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/711016f146fd 8006997: ContendedPaddingWidth should be range-checked Summary: Constrain between zero and 8K Reviewed-by: dholmes, rbackman Contributed-by: Aleksey Shipilev ! src/share/vm/runtime/arguments.cpp Changeset: 9b77ca4ce35e Author: dholmes Date: 2013-05-08 19:38 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9b77ca4ce35e Merge ! src/share/vm/runtime/arguments.cpp Changeset: c272092594bd Author: dholmes Date: 2013-05-08 21:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c272092594bd Merge From mike.duigou at oracle.com Wed May 8 21:43:23 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 09 May 2013 04:43:23 +0000 Subject: hg: jdk8/tl: 8014269: Add missing .PHONY targets to Main.gmk Message-ID: <20130509044323.7ECAC4891F@hg.openjdk.java.net> Changeset: e2eb6bc06621 Author: mduigou Date: 2013-05-08 21:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e2eb6bc06621 8014269: Add missing .PHONY targets to Main.gmk Reviewed-by: mchung, tbell ! common/makefiles/Main.gmk From huizhe.wang at oracle.com Wed May 8 23:38:54 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 09 May 2013 06:38:54 +0000 Subject: hg: jdk8/tl/jaxp: 8011653: Upgrade JDK8 to JAXP 1.5 Message-ID: <20130509063858.C4C2148920@hg.openjdk.java.net> Changeset: 1e8d98012ab8 Author: joehw Date: 2013-05-08 23:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1e8d98012ab8 8011653: Upgrade JDK8 to JAXP 1.5 Reviewed-by: alanb, dfuchs ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java ! src/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java ! src/com/sun/xml/internal/stream/StaxXMLInputSource.java ! src/javax/xml/XMLConstants.java ! src/javax/xml/parsers/DocumentBuilderFactory.java ! src/javax/xml/parsers/SAXParser.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/transform/TransformerFactory.java ! src/javax/xml/validation/SchemaFactory.java ! src/javax/xml/validation/Validator.java From yunda.mly at taobao.com Wed May 8 23:38:17 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Thu, 9 May 2013 06:38:17 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> <51899F46.1090800@oracle.com> <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> Message-ID: Rickard, Actually I've considered the option and I just thought it's less elegant. But just as you said, it's clearer and easier to read. The updated and tested change: diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 +++ b/src/share/vm/runtime/globals.hpp Thu May 09 14:36:35 2013 +0800 @@ -3634,7 +3634,10 @@ "Include GC cause in GC logging") \ \ product(bool, EnableTracing, false, \ - "Enable event-based tracing") + "Enable event-based tracing") \ + \ + product(bool, UseLockedTracing, false, \ + "Use locked-tracing when doing event-based tracing") /* * Macros for factoring of globals diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 -0700 +++ b/src/share/vm/trace/traceEventClasses.xsl Thu May 09 14:36:35 2013 +0800 @@ -132,6 +132,15 @@ void writeEvent(void) { ResourceMark rm; HandleMark hm; + if (UseLockedTracing) { + ttyLocker lock; + writeEventContent(); + } else { + writeEventContent(); + } + } + + void writeEventContent() { TraceStream ts(*tty); ts.print(": ["); Regards, Yunda > -----Original Message----- > From: Rickard B?ckman [mailto:rickard.backman at oracle.com] > Sent: Wednesday, May 08, 2013 3:03 PM > To: David Holmes > Cc: ??(Yunda); serviceability-dev at openjdk.java.net; > hotspot-runtime-dev at openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > One option could be to move the content of writeEvent() to its own method > (maybe writeEventContent()) and just do > > if (UseLockedTracing) { > ttyLocker lock; > writeEventContent(); > } else { > writeEventContent(); > } > > I think it makes it easier to read. > > /R > > On May 8, 2013, at 2:41 AM, David Holmes wrote: > > > On 7/05/2013 10:33 PM, ??(Yunda) wrote: > >> David, > >> > >> Sorry about the stupid mistake. And please see the tested change below. > Since I don't find an elegant way to define a ttyLocker object, I use the static > methods of ttyLocker instead. > > > > Yeah there's no elegant solution when you need to conditionalize > > things. :( > > > > This looks fine to me but the serviceability folk should chime back in. > > > > Thanks, > > David > > > >> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > >> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 > >> -0700 > >> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 > >> +++ +0800 > >> @@ -3634,7 +3634,10 @@ > >> "Include GC cause in GC logging") > \ > >> > \ > >> product(bool, EnableTracing, false, > \ > >> - "Enable event-based tracing") > >> + "Enable event-based tracing") > \ > >> + > \ > >> + product(bool, UseLockedTracing, false, > \ > >> + "Use locked-tracing when doing event-based > >> + tracing") > >> > >> /* > >> * Macros for factoring of globals > >> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > >> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 > >> 2013 -0700 > >> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 > >> +++ 2013 +0800 > >> @@ -132,10 +132,17 @@ > >> void writeEvent(void) { > >> ResourceMark rm; > >> HandleMark hm; > >> + int holder; > >> + if (UseLockedTracing) { > >> + holder = ttyLocker::hold_tty(); > >> + } > >> TraceStream ts(*tty); > >> ts.print(": ["); > >> > >> ts.print("]\n"); > >> + if (UseLockedTracing) { > >> + ttyLocker::release_tty(holder); > >> + } > >> } > >> }; > >> > >> > >> Regards, > >> Yunda > >> > >> > >>> -----Original Message----- > >>> From: David Holmes [mailto:david.holmes at oracle.com] > >>> Sent: Tuesday, May 07, 2013 5:50 PM > >>> To: ??(Yunda) > >>> Cc: hotspot-runtime-dev at openjdk.java.net; > >>> serviceability-dev at openjdk.java.net > >>> Subject: Re: [PATCH] EnableTracing: output from multiple threads may > >>> be mixed together > >>> > >>> On 7/05/2013 7:43 PM, ??(Yunda) wrote: > >>>> Hi David, > >>>> > >>>> Thanks for the review and I see your concern. Please see the > >>>> updated change > >>> below: > >>>> > >>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > >>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 > >>>> -0700 > >>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 > >>>> +++ +0800 > >>>> @@ -3634,7 +3634,10 @@ > >>>> "Include GC cause in GC logging") > >>> \ > >>>> > >>> \ > >>>> product(bool, EnableTracing, false, > >>> \ > >>>> - "Enable event-based tracing") > >>>> + "Enable event-based tracing") > >>> \ > >>>> + > >>> \ > >>>> + product(bool, UseLockedTracing, false, > >>> \ > >>>> + "Use locked-tracing when doing event-based > >>>> + tracing") > >>>> > >>>> /* > >>>> * Macros for factoring of globals diff -r 627cf9e9ea31 > >>>> src/share/vm/trace/traceEventClasses.xsl > >>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 > >>>> 2013 -0700 > >>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 > >>>> +++ 2013 +0800 > >>>> @@ -132,6 +132,9 @@ > >>>> void writeEvent(void) { > >>>> ResourceMark rm; > >>>> HandleMark hm; > >>>> + if (UseLockedTracing) { > >>>> + ttyLocker ttyl; > >>>> + } > >>> > >>> Ah that doesn't work - the ttyLocker is block-scoped by the if > >>> statement so it will be created, grab the lock, then immediately be > >>> destructed and the lock released. > >>> > >>> David > >>> ----- > >>> > >>>> TraceStream ts(*tty); > >>>> ts.print(": ["); > >>>> >>>> mode="write-data"/> > >>>> > >>>> Regards, > >>>> Yunda > >>>> > >>>>> -----Original Message----- > >>>>> From: David Holmes [mailto:david.holmes at oracle.com] > >>>>> Sent: Tuesday, May 07, 2013 10:39 AM > >>>>> To: ??(Yunda) > >>>>> Cc: hotspot-runtime-dev at openjdk.java.net; > >>>>> serviceability-dev at openjdk.java.net > >>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads > >>>>> may be mixed together > >>>>> > >>>>> Hi Yunda, > >>>>> > >>>>> There is a potential problem with using a ttyLocker here, > >>>>> depending on exactly what events are being traced and from where - > >>>>> you must always be in code where it is both safe to acquire the > >>>>> lock, and safe to block waiting for the lock if it is not available. > >>>>> > >>>>> I think I would prefer to see unlocked tracing by default with a > >>>>> flag to use locked-tracing if requested. > >>>>> > >>>>> David > >>>>> > >>>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: > >>>>>> Hi all, > >>>>>> > >>>>>> I found that the output from multiple threads may be mixed > >>>>>> together when using EnableTracing. It happens many times in my test > case like this: > >>>>>> > >>>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation in > >>>>>> new > >>>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: > >>>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = > >>>>>> java/lang/String, Allocation Size = 24, Allocation Size = 24, > >>>>>> Class = java/lang/String, Class = [I, Allocation in new TLAB: > >>>>>> [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > >>>>>> > >>>>>> Class = > >>>>>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, > >>>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] > >>>>>> > >>>>>> TLAB Size = 24607080] > >>>>>> > >>>>>> Allocation Size = 24, Monitor Class = > >>>>>> java/lang/ref/Reference$Lock, TLAB Size = 25054480] > >>>>>> > >>>>>> TLAB Size = 25054480] > >>>>>> > >>>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > >>>>>> > >>>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] > >>>>>> > >>>>>> , Allocation Size = 32, TLAB Size = 23712288] > >>>>>> > >>>>>> It's very confusing and it's even not easy to tell how many > >>>>>> events there are. I think the reason is that the writeEvent() > >>>>>> method of each > >>>>>> Event* class output the fields of event one by one without using > >>>>>> any lock. So I made a small patch which add ttyLocker to > >>>>>> writeEvent() method and after applying this patch there's no > >>>>>> output mixed together in my test case(against > >>> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > >>>>>> > >>>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > >>>>>> > >>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 > 13:50:58 > >>>>>> 2013 -0700 > >>>>>> > >>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 > >>>>>> +++ 16:12:38 > >>>>>> +++ 2013 > >>>>>> +0800 > >>>>>> > >>>>>> @@ -132,6 +132,7 @@ > >>>>>> > >>>>>> void writeEvent(void) { > >>>>>> > >>>>>> ResourceMark rm; > >>>>>> > >>>>>> HandleMark hm; > >>>>>> > >>>>>> + ttyLocker ttyl; > >>>>>> > >>>>>> TraceStream ts(*tty); > >>>>>> > >>>>>> ts.print(": ["); > >>>>>> > >>>>>> >>>>>> mode="write-data"/> > >>>>>> > >>>>>> I searched before sending this mail I didn't find anyone who > >>>>>> covering thisJ > >>>>>> > >>>>>> Regards, > >>>>>> > >>>>>> Yunda > >>>>>> > >>>>>> > >>>>>> ----------------------------------------------------------------- > >>>>>> --- > >>>>>> -- > >>>>>> -- > >>>>>> > >>>>>> This email (including any attachments) is confidential and may be > >>>>>> legally privileged. If you received this email in error, please > >>>>>> delete it immediately and do not copy it or use it for any > >>>>>> purpose or disclose its contents to any other person. Thank you. > >>>>>> > >>>>>> ???(??????)??????????????????? > ?? > >>> ? > >>>>> ???? > >>>>>> ????????????????????????????? > ?? > >>>>> ????? > >>>>>> ???????? > >>>> > >>>> ________________________________ > >>>> > >>>> This email (including any attachments) is confidential and may be > >>>> legally > >>> privileged. If you received this email in error, please delete it > >>> immediately and do not copy it or use it for any purpose or disclose > >>> its contents to any other person. Thank you. > >>> > >>>> > >>>> ???(??????)???????????????????? > ?? > >>> ?????????????????????????????? > ?? > >>> ????? > >>>> ??????????? > >>>> > >> > >> ________________________________ > >> > >> This email (including any attachments) is confidential and may be legally > privileged. If you received this email in error, please delete it immediately and > do not copy it or use it for any purpose or disclose its contents to any other > person. Thank you. > >> > >> ???(??????)????????????????????? > ???????????????????????????????? > ????? > >> ???????????? > >> ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From rickard.backman at oracle.com Thu May 9 01:52:34 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Thu, 9 May 2013 10:52:34 +0200 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> <51899F46.1090800@oracle.com> <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> Message-ID: Looks good to me! /R On May 9, 2013, at 8:38 AM, ??(Yunda) wrote: > Rickard, > > Actually I've considered the option and I just thought it's less elegant. But just as you said, it's clearer and easier to read. The updated and tested change: > > diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 > +++ b/src/share/vm/runtime/globals.hpp Thu May 09 14:36:35 2013 +0800 > @@ -3634,7 +3634,10 @@ > "Include GC cause in GC logging") \ > \ > product(bool, EnableTracing, false, \ > - "Enable event-based tracing") > + "Enable event-based tracing") \ > + \ > + product(bool, UseLockedTracing, false, \ > + "Use locked-tracing when doing event-based tracing") > > /* > * Macros for factoring of globals > diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 2013 -0700 > +++ b/src/share/vm/trace/traceEventClasses.xsl Thu May 09 14:36:35 2013 +0800 > @@ -132,6 +132,15 @@ > void writeEvent(void) { > ResourceMark rm; > HandleMark hm; > + if (UseLockedTracing) { > + ttyLocker lock; > + writeEventContent(); > + } else { > + writeEventContent(); > + } > + } > + > + void writeEventContent() { > TraceStream ts(*tty); > ts.print(": ["); > > > > Regards, > Yunda > >> -----Original Message----- >> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] >> Sent: Wednesday, May 08, 2013 3:03 PM >> To: David Holmes >> Cc: ??(Yunda); serviceability-dev at openjdk.java.net; >> hotspot-runtime-dev at openjdk.java.net >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed >> together >> >> One option could be to move the content of writeEvent() to its own method >> (maybe writeEventContent()) and just do >> >> if (UseLockedTracing) { >> ttyLocker lock; >> writeEventContent(); >> } else { >> writeEventContent(); >> } >> >> I think it makes it easier to read. >> >> /R >> >> On May 8, 2013, at 2:41 AM, David Holmes wrote: >> >>> On 7/05/2013 10:33 PM, ??(Yunda) wrote: >>>> David, >>>> >>>> Sorry about the stupid mistake. And please see the tested change below. >> Since I don't find an elegant way to define a ttyLocker object, I use the static >> methods of ttyLocker instead. >>> >>> Yeah there's no elegant solution when you need to conditionalize >>> things. :( >>> >>> This looks fine to me but the serviceability folk should chime back in. >>> >>> Thanks, >>> David >>> >>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 >>>> -0700 >>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 >>>> +++ +0800 >>>> @@ -3634,7 +3634,10 @@ >>>> "Include GC cause in GC logging") >> \ >>>> >> \ >>>> product(bool, EnableTracing, false, >> \ >>>> - "Enable event-based tracing") >>>> + "Enable event-based tracing") >> \ >>>> + >> \ >>>> + product(bool, UseLockedTracing, false, >> \ >>>> + "Use locked-tracing when doing event-based >>>> + tracing") >>>> >>>> /* >>>> * Macros for factoring of globals >>>> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl >>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>>> 2013 -0700 >>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 >>>> +++ 2013 +0800 >>>> @@ -132,10 +132,17 @@ >>>> void writeEvent(void) { >>>> ResourceMark rm; >>>> HandleMark hm; >>>> + int holder; >>>> + if (UseLockedTracing) { >>>> + holder = ttyLocker::hold_tty(); >>>> + } >>>> TraceStream ts(*tty); >>>> ts.print(": ["); >>>> >>>> ts.print("]\n"); >>>> + if (UseLockedTracing) { >>>> + ttyLocker::release_tty(holder); >>>> + } >>>> } >>>> }; >>>> >>>> >>>> Regards, >>>> Yunda >>>> >>>> >>>>> -----Original Message----- >>>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>>> Sent: Tuesday, May 07, 2013 5:50 PM >>>>> To: ??(Yunda) >>>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>>> serviceability-dev at openjdk.java.net >>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads may >>>>> be mixed together >>>>> >>>>> On 7/05/2013 7:43 PM, ??(Yunda) wrote: >>>>>> Hi David, >>>>>> >>>>>> Thanks for the review and I see your concern. Please see the >>>>>> updated change >>>>> below: >>>>>> >>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 >>>>>> -0700 >>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 >>>>>> +++ +0800 >>>>>> @@ -3634,7 +3634,10 @@ >>>>>> "Include GC cause in GC logging") >>>>> \ >>>>>> >>>>> \ >>>>>> product(bool, EnableTracing, false, >>>>> \ >>>>>> - "Enable event-based tracing") >>>>>> + "Enable event-based tracing") >>>>> \ >>>>>> + >>>>> \ >>>>>> + product(bool, UseLockedTracing, false, >>>>> \ >>>>>> + "Use locked-tracing when doing event-based >>>>>> + tracing") >>>>>> >>>>>> /* >>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 >>>>>> src/share/vm/trace/traceEventClasses.xsl >>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>>>>> 2013 -0700 >>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 17:38:58 >>>>>> +++ 2013 +0800 >>>>>> @@ -132,6 +132,9 @@ >>>>>> void writeEvent(void) { >>>>>> ResourceMark rm; >>>>>> HandleMark hm; >>>>>> + if (UseLockedTracing) { >>>>>> + ttyLocker ttyl; >>>>>> + } >>>>> >>>>> Ah that doesn't work - the ttyLocker is block-scoped by the if >>>>> statement so it will be created, grab the lock, then immediately be >>>>> destructed and the lock released. >>>>> >>>>> David >>>>> ----- >>>>> >>>>>> TraceStream ts(*tty); >>>>>> ts.print(": ["); >>>>>> >>>>> mode="write-data"/> >>>>>> >>>>>> Regards, >>>>>> Yunda >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>>>>> Sent: Tuesday, May 07, 2013 10:39 AM >>>>>>> To: ??(Yunda) >>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>>>>> serviceability-dev at openjdk.java.net >>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads >>>>>>> may be mixed together >>>>>>> >>>>>>> Hi Yunda, >>>>>>> >>>>>>> There is a potential problem with using a ttyLocker here, >>>>>>> depending on exactly what events are being traced and from where - >>>>>>> you must always be in code where it is both safe to acquire the >>>>>>> lock, and safe to block waiting for the lock if it is not available. >>>>>>> >>>>>>> I think I would prefer to see unlocked tracing by default with a >>>>>>> flag to use locked-tracing if requested. >>>>>>> >>>>>>> David >>>>>>> >>>>>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> I found that the output from multiple threads may be mixed >>>>>>>> together when using EnableTracing. It happens many times in my test >> case like this: >>>>>>>> >>>>>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation in >>>>>>>> new >>>>>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: >>>>>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class = >>>>>>>> java/lang/String, Allocation Size = 24, Allocation Size = 24, >>>>>>>> Class = java/lang/String, Class = [I, Allocation in new TLAB: >>>>>>>> [Class = [C, Allocation in new TLAB: [Allocation Size = 192] >>>>>>>> >>>>>>>> Class = >>>>>>>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, >>>>>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = 23712280] >>>>>>>> >>>>>>>> TLAB Size = 24607080] >>>>>>>> >>>>>>>> Allocation Size = 24, Monitor Class = >>>>>>>> java/lang/ref/Reference$Lock, TLAB Size = 25054480] >>>>>>>> >>>>>>>> TLAB Size = 25054480] >>>>>>>> >>>>>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] >>>>>>>> >>>>>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] >>>>>>>> >>>>>>>> , Allocation Size = 32, TLAB Size = 23712288] >>>>>>>> >>>>>>>> It's very confusing and it's even not easy to tell how many >>>>>>>> events there are. I think the reason is that the writeEvent() >>>>>>>> method of each >>>>>>>> Event* class output the fields of event one by one without using >>>>>>>> any lock. So I made a small patch which add ttyLocker to >>>>>>>> writeEvent() method and after applying this patch there's no >>>>>>>> output mixed together in my test case(against >>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): >>>>>>>> >>>>>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl >>>>>>>> >>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 >> 13:50:58 >>>>>>>> 2013 -0700 >>>>>>>> >>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 >>>>>>>> +++ 16:12:38 >>>>>>>> +++ 2013 >>>>>>>> +0800 >>>>>>>> >>>>>>>> @@ -132,6 +132,7 @@ >>>>>>>> >>>>>>>> void writeEvent(void) { >>>>>>>> >>>>>>>> ResourceMark rm; >>>>>>>> >>>>>>>> HandleMark hm; >>>>>>>> >>>>>>>> + ttyLocker ttyl; >>>>>>>> >>>>>>>> TraceStream ts(*tty); >>>>>>>> >>>>>>>> ts.print(": ["); >>>>>>>> >>>>>>>> >>>>>>> mode="write-data"/> >>>>>>>> >>>>>>>> I searched before sending this mail I didn't find anyone who >>>>>>>> covering thisJ >>>>>>>> >>>>>>>> Regards, >>>>>>>> >>>>>>>> Yunda >>>>>>>> >>>>>>>> >>>>>>>> ----------------------------------------------------------------- >>>>>>>> --- >>>>>>>> -- >>>>>>>> -- >>>>>>>> >>>>>>>> This email (including any attachments) is confidential and may be >>>>>>>> legally privileged. If you received this email in error, please >>>>>>>> delete it immediately and do not copy it or use it for any >>>>>>>> purpose or disclose its contents to any other person. Thank you. >>>>>>>> >>>>>>>> ???(??????)??????????????????? >> ?? >>>>> ? >>>>>>> ???? >>>>>>>> ????????????????????????????? >> ?? >>>>>>> ????? >>>>>>>> ???????? >>>>>> >>>>>> ________________________________ >>>>>> >>>>>> This email (including any attachments) is confidential and may be >>>>>> legally >>>>> privileged. If you received this email in error, please delete it >>>>> immediately and do not copy it or use it for any purpose or disclose >>>>> its contents to any other person. Thank you. >>>>> >>>>>> >>>>>> ???(??????)???????????????????? >> ?? >>>>> ?????????????????????????????? >> ?? >>>>> ????? >>>>>> ??????????? >>>>>> >>>> >>>> ________________________________ >>>> >>>> This email (including any attachments) is confidential and may be legally >> privileged. If you received this email in error, please delete it immediately and >> do not copy it or use it for any purpose or disclose its contents to any other >> person. Thank you. >>>> >>>> ???(??????)????????????????????? >> ???????????????????????????????? >> ????? >>>> ???????????? >>>> > > > ________________________________ > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? From jaroslav.bachorik at oracle.com Thu May 9 02:25:32 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 09 May 2013 11:25:32 +0200 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <5189933E.40702@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> <5183C6D5.8070302@oracle.com> <51877204.8000104@oracle.com> <5189933E.40702@oracle.com> Message-ID: <518B6B8C.2080506@oracle.com> Hi Stuart, On St 8. kv?ten 2013, 01:50:22 CEST, Stuart Marks wrote: > Hi Jaroslav, > > Great to see this shell test get rewritten! > > Looks like you're avoiding multiple JVM processes as well, by loading > the different versions of the classes into different classloaders. It > looks like a bit of trouble, but probably less than the amount of > trouble caused by the shell script. > > I have a couple minor points. > > The timeout value of one second seems quite low. Under normal > operation, spawning a couple threads and should proceed very quickly. > However, our testing environment is quite hostile, and things that > seem like they ought to proceed quickly often take considerably longer > than one might think. Since you're counting notifications, and in > normal operation they all come in, we don't wait for the actual > timeout unless there's a failure. So it might make sense to raise the > timeout to 10 or perhaps 30 seconds. I've adjusted the timeout for 30 seconds. Hopefully, it will be enough. > > On the other hand, I have a question about whether counting the number > of notifications is correct. Would it be possible for there to be a > bug where an extra notification is sent? If so, this might mean that > the test would exit prematurely, indicating success? It would be a severe error in the notification system implementation. However, I've added a check for duplicated notifications (each notification carries its sequence number) which makes the test fail in case of duplication. But I don't expect it to happen. The updated webrev is at http://cr.openjdk.java.net/~jbachorik/8005472/webrev.09 -JB- > > s'marks > > On 5/6/13 2:04 AM, Jaroslav Bachorik wrote: >> On P? 3. kv?ten 2013, 16:16:53 CEST, Daniel Fuchs wrote: >>> Hi Jaroslav, >>> >>> In Client.java - you could consider replacing the AtomicLong >>> with a CountDownLatch. >>> >>> This would allow you to remove the various Thread.sleep() in the >>> code (in particular the one at the end). >>> >>> You could use CountDownLatch.await(long timeout, TimeUnit unit) to >>> avoid waiting for ever in case of bugs, and the advantage is that >>> the test would be able to exit as soon as the count down latch >>> reaches 0, without having to wait for an arbitrary timeout. >> >> Great, thanks for the pointer! I've changed the test to use the >> CountDownLatch. >> >> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.08/ >> >> -JB- >> >>> >>> Very nice to see a shell test go away :-) >>> >>> -- daniel >>> >>> >>> On 5/3/13 3:41 PM, Jaroslav Bachorik wrote: >>>> Please re-review the updated webrev >>>> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 >>>> >>>> I've replaced the shell script with the plain java test. The javac API >>>> is used to compile the the auxiliary classes as was recommended. This >>>> allowed to simplify the test. >>>> >>>> The test does not check for a certain string in the standard output >>>> anymore - it turns out that it is possible to count the number of all >>>> the received JMX notifications (even though some notifications can be >>>> lost, we receive a special notification with the number of the lost >>>> regular notifications). It is then possible to match the actual number >>>> of processed notifications (received + lost) against the expected >>>> number >>>> - different numbers mean that the notification processing thread had >>>> been interrupted unexpectedly. >>>> >>>> Thanks, >>>> >>>> -JB- >>>> >>>> On 8.2.2013 17:37, Chris Hegarty wrote: >>>>> >>>>>> Jon Gibbons suggested invoking the compiler API directly from java >>>>>> instead of writing a shell script. Doing this seems fairly simple, >>>>>> and I >>>>>> think it would be advantageous to keep things entirely in Java. I >>>>>> may >>>>>> attempt to rewrite the defaultSVID test using the compiler API. >>>>> >>>>> Here's a test that does just that. >>>>> >>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/file/2de8c6c2d652/test/sun/misc/JarIndex/metaInfFilenames/Basic.java >>>>> >>>>> >>>>> >>>>> >>>>> -Chris. >>>> >>> >> >> From daniel.daugherty at oracle.com Thu May 9 06:55:38 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 09 May 2013 07:55:38 -0600 Subject: RFR 8005056: NPG: Crash after redefining java.lang.Object In-Reply-To: <518B0F34.5080101@oracle.com> References: <518B0F34.5080101@oracle.com> Message-ID: <518BAADA.1000402@oracle.com> Adding Serviceability to this review thread since this concerns JVM/TI RedefineClasses(). Coleen, this will take a bit of time to review. Dan On 5/8/13 8:51 PM, Coleen Phillimore wrote: > Summary: Need to walk array class vtables replacing old methods too if > j.l.o is redefined > > Array methods aren't in the SystemDictionary and the code that was > there didn't walk the basic type array classes defined in universe. > It also walked the same classes more than once. Use the > ClassLoaderDataGraph class walking instead. > > open webrev at http://cr.openjdk.java.net/~coleenp/8005056/ > bug link at http://bugs.sun.com/view_bug.do?bug_id=8005056 > > Tested with all redefine classes tests, jdk java/lang/instrument > tests, hotspot jtreg tests. > > Thanks, > Coleen > From coleen.phillimore at oracle.com Thu May 9 07:22:14 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 09 May 2013 10:22:14 -0400 Subject: RFR 8005056: NPG: Crash after redefining java.lang.Object In-Reply-To: <518BAADA.1000402@oracle.com> References: <518B0F34.5080101@oracle.com> <518BAADA.1000402@oracle.com> Message-ID: <518BB116.70401@oracle.com> Dan, Thank you for adding serviceability. I'll provide more detail on the change if needed. Here's some additional detail. What I did was added a closure to pass to ClassLoaderDataGraph::classes_do() function. This function walks all the loaded classes, which includes the array classes. The SystemDicitonary walk only walks loaded InstanceKlasses. The array classes created are linked from the InstanceKlass in _array_klasses and the code used to walk them separately. The code for switching to the new methods from the old methods didn't change very much. The reason we have to change the vtables in array classes is because array classes are inherited from java/lang/Object class and have this vtable. We had missed the ones for arrays of basic types created in universe. The old code never fixed these entries but it didn't crash because the methodOops were followed with the basic type array classes in their vtable so wouldn't go away. With permgen removal, we explicitly delete unreferenced Method objects so these ones have to be replaced. And it's more correct because you don't want to call the old Method. Coleen On 05/09/2013 09:55 AM, Daniel D. Daugherty wrote: > Adding Serviceability to this review thread since this concerns > JVM/TI RedefineClasses(). > > Coleen, this will take a bit of time to review. > > Dan > > > On 5/8/13 8:51 PM, Coleen Phillimore wrote: >> Summary: Need to walk array class vtables replacing old methods too >> if j.l.o is redefined >> >> Array methods aren't in the SystemDictionary and the code that was >> there didn't walk the basic type array classes defined in universe. >> It also walked the same classes more than once. Use the >> ClassLoaderDataGraph class walking instead. >> >> open webrev at http://cr.openjdk.java.net/~coleenp/8005056/ >> bug link at http://bugs.sun.com/view_bug.do?bug_id=8005056 >> >> Tested with all redefine classes tests, jdk java/lang/instrument >> tests, hotspot jtreg tests. >> >> Thanks, >> Coleen >> > From coleen.phillimore at oracle.com Thu May 9 07:27:12 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 09 May 2013 10:27:12 -0400 Subject: RFR 8005056: NPG: Crash after redefining java.lang.Object In-Reply-To: <518B0F34.5080101@oracle.com> References: <518B0F34.5080101@oracle.com> Message-ID: <518BB240.4030700@oracle.com> I forgot to mention: thanks to Christian Tornqvist for writing the test for me. Coleen On 05/08/2013 10:51 PM, Coleen Phillimore wrote: > Summary: Need to walk array class vtables replacing old methods too if > j.l.o is redefined > > Array methods aren't in the SystemDictionary and the code that was > there didn't walk the basic type array classes defined in universe. > It also walked the same classes more than once. Use the > ClassLoaderDataGraph class walking instead. > > open webrev at http://cr.openjdk.java.net/~coleenp/8005056/ > bug link at http://bugs.sun.com/view_bug.do?bug_id=8005056 > > Tested with all redefine classes tests, jdk java/lang/instrument > tests, hotspot jtreg tests. > > Thanks, > Coleen > From kumar.x.srinivasan at oracle.com Thu May 9 08:10:16 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 09 May 2013 15:10:16 +0000 Subject: hg: jdk8/tl/jdk: 8013736: [launcher] cleanup code for correctness; ... Message-ID: <20130509151028.762904892B@hg.openjdk.java.net> Changeset: 3fd83f282c61 Author: ksrini Date: 2013-05-07 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fd83f282c61 8013736: [launcher] cleanup code for correctness 8005735: [parfait] False positive integer overflow in jdk/src/solaris/bin/jexec.c 8009873: [parfait] Memory leak at jdk/src/share/bin/wildcard.c 8005807: [parfait] Undefined return value at jdk/src/share/bin/java.c Reviewed-by: alanb, martin ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/wildcard.c ! src/solaris/bin/jexec.c From jason.uh at oracle.com Thu May 9 12:02:00 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Thu, 09 May 2013 19:02:00 +0000 Subject: hg: jdk8/tl/jdk: 8007699: Move some tests from test/sun/security/provider/certpath/X509CertPath to closed repo Message-ID: <20130509190224.0881348939@hg.openjdk.java.net> Changeset: bb9cdfac1a7d Author: juh Date: 2013-05-09 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb9cdfac1a7d 8007699: Move some tests from test/sun/security/provider/certpath/X509CertPath to closed repo Reviewed-by: mullan - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java From mike.duigou at oracle.com Thu May 9 14:18:50 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 09 May 2013 21:18:50 +0000 Subject: hg: jdk8/tl/jdk: 8012646: Pattern.splitAsStream Message-ID: <20130509211915.77F494894C@hg.openjdk.java.net> Changeset: 498ea4c3a4c6 Author: psandoz Date: 2013-05-01 18:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/498ea4c3a4c6 8012646: Pattern.splitAsStream Reviewed-by: forax, plevart, alanb Contributed-by: Ben Evans , Paul Sandoz ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java From lana.steuck at oracle.com Thu May 9 16:22:19 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:19 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130509232223.5EDBE48971@hg.openjdk.java.net> Changeset: 1f13a798d1b8 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1f13a798d1b8 Added tag jdk8-b88 for changeset 4e3a881ebb1e ! .hgtags Changeset: fe4150590ee5 Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/fe4150590ee5 Merge From lana.steuck at oracle.com Thu May 9 16:22:21 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:21 +0000 Subject: hg: jdk8/tl: 8 new changesets Message-ID: <20130509232222.9079848970@hg.openjdk.java.net> Changeset: 1dfcc874461e Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1dfcc874461e 8013480: fix zero build on arm Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in Changeset: 7e7582e961ba Author: jwilhelm Date: 2013-04-25 16:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7e7582e961ba 7074926: create Solaris Studio IDE (Netbeans) project for hotspot sources Summary: Project files for hotspot delevopment in Solaris Studio and NetBeans. Also reviewed by vladimir.voskresensky at oracle.com Reviewed-by: erikj, dsamersoff + common/nb_native/nbproject/configurations.xml + common/nb_native/nbproject/project.xml Changeset: b9bf111a9547 Author: katleman Date: 2013-04-30 14:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9bf111a9547 Merge Changeset: e404d321abc6 Author: erikj Date: 2013-05-02 15:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e404d321abc6 8013786: JDK-8013480 broke configure on solaris Reviewed-by: tbell ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/toolchain.m4 Changeset: e1a929afcfc4 Author: erikj Date: 2013-05-02 15:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e1a929afcfc4 8011687: Support correct dependencies from header files on windows and solaris Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/makefiles/NativeCompilation.gmk Changeset: 8fb91165e596 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8fb91165e596 Added tag jdk8-b88 for changeset e1a929afcfc4 ! .hgtags Changeset: 892a0196d10c Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/892a0196d10c Merge ! common/makefiles/NativeCompilation.gmk Changeset: 49ea9293fa49 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/49ea9293fa49 Merge From lana.steuck at oracle.com Thu May 9 16:22:19 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:19 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b88 for changeset 24fa5452e5d4 Message-ID: <20130509232229.8D32B48972@hg.openjdk.java.net> Changeset: 88838e08e4ef Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/88838e08e4ef Added tag jdk8-b88 for changeset 24fa5452e5d4 ! .hgtags From lana.steuck at oracle.com Thu May 9 16:22:23 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:23 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20130509232240.7620248974@hg.openjdk.java.net> Changeset: 21f75e572cb3 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/21f75e572cb3 Added tag jdk8-b88 for changeset 7122f7bb0fcc ! .hgtags Changeset: 893d2ba8bbea Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/893d2ba8bbea Merge Changeset: 6976616f5753 Author: lana Date: 2013-05-08 22:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6976616f5753 Merge Changeset: 9e4dfe933ba9 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9e4dfe933ba9 Merge From lana.steuck at oracle.com Thu May 9 16:22:27 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:27 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20130509232230.915E148973@hg.openjdk.java.net> Changeset: 501bc4aeb1b1 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/501bc4aeb1b1 Added tag jdk8-b88 for changeset 40c107d1ae6f ! .hgtags Changeset: 45ce27fbe272 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/45ce27fbe272 Merge - src/jdk/nashorn/internal/codegen/Frame.java - src/jdk/nashorn/internal/ir/DoWhileNode.java - src/jdk/nashorn/internal/ir/LabeledNode.java From lana.steuck at oracle.com Thu May 9 16:22:27 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:27 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130509232242.33B1148975@hg.openjdk.java.net> Changeset: adec2a5d510a Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/adec2a5d510a Added tag jdk8-b88 for changeset a1e10f3adc47 ! .hgtags Changeset: ec434cfd2752 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec434cfd2752 Merge - make/Makefile-classic Changeset: c68834236058 Author: lana Date: 2013-05-08 23:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c68834236058 Merge From lana.steuck at oracle.com Thu May 9 16:23:06 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:23:06 +0000 Subject: hg: jdk8/tl/hotspot: 66 new changesets Message-ID: <20130509232912.050B148978@hg.openjdk.java.net> Changeset: d0081bfc425c Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0081bfc425c Added tag jdk8-b88 for changeset 8482058e74bc ! .hgtags Changeset: 57ac6a688ae6 Author: amurillo Date: 2013-04-26 00:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/57ac6a688ae6 8013227: new hotspot build - hs25-b31 Reviewed-by: jcoomes ! make/hotspot_version Changeset: cc70cbbd422e Author: hseigel Date: 2013-04-24 09:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cc70cbbd422e 8012695: Assertion message displays %u and %s text instead of actual values Summary: USe err_msg() to create a proper assertion message. Reviewed-by: twisti, coleenp, iklam ! src/share/vm/classfile/classFileParser.hpp Changeset: fbca7eaeac2e Author: zgu Date: 2013-04-24 14:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fbca7eaeac2e 8011218: Kitchensink hanged, likely NMT is to blame Summary: Made NMT query safepoint aware. Reviewed-by: dholmes, coleenp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/services/memTracker.cpp Changeset: d587a5c30bd8 Author: coleenp Date: 2013-04-24 16:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d587a5c30bd8 8011803: release_C_heap_structures is never called for anonymous classes. Summary: Call this function from the ClassLoaderData destructor instead of the system dictionary walk. Reviewed-by: stefank, mgerdin ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: d66a24adbe3f Author: coleenp Date: 2013-04-24 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d66a24adbe3f Merge Changeset: 15a99ca4ee34 Author: sspitsyn Date: 2013-04-25 03:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/15a99ca4ee34 8007037: JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands Summary: References from operands to CP entries and back must be correct after CP merge Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: c115fac239eb Author: iklam Date: 2013-04-25 12:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c115fac239eb 8008962: NPG: Memory regression: One extra Monitor per ConstantPool Summary: Re-use InstanceKlass::_init_lock locking ConstantPool as well. Reviewed-by: dholmes, coleenp, acorn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiEnv.cpp Changeset: 3c9b7ef92c61 Author: dcubed Date: 2013-04-26 08:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c9b7ef92c61 Merge Changeset: d1644a010f52 Author: emc Date: 2013-04-26 07:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1644a010f52 8007154: Remove support for u4 MethodParameter flags fields Summary: Remove support for parsing class files with four-byte flags fields in MethodParameters attributes Reviewed-by: jrose, coleenp ! src/share/vm/classfile/classFileParser.cpp Changeset: f258c5828eb8 Author: hseigel Date: 2013-04-29 16:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f258c5828eb8 8011773: Some tests on Interned String crashed JVM with OOM Summary: Instead of terminating the VM, throw OutOfMemoryError exceptions. Reviewed-by: coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/oops/oop.cpp ! src/share/vm/prims/whitebox.cpp Changeset: c53e49efe6a8 Author: hseigel Date: 2013-04-29 16:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c53e49efe6a8 Merge Changeset: f32b6c267d2e Author: mikael Date: 2013-04-29 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f32b6c267d2e 8012015: Use PROT_NONE when reserving memory Summary: Reserved memory had PROT_READ+PROT_WRITE access on Linux/bsd, now changed to PROT_NONE. Reviewed-by: dholmes, ctornqvi ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/share/vm/prims/whitebox.cpp + test/runtime/memory/ReserveMemory.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 9f96b7a853bc Author: sla Date: 2013-04-30 10:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9f96b7a853bc 8013466: SA crashes when attaching to a process on OS X Reviewed-by: coleenp, rbackman, minqi ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: 409d4b59e095 Author: sla Date: 2013-04-30 02:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/409d4b59e095 Merge Changeset: ed5a590835a4 Author: zgu Date: 2013-04-30 09:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed5a590835a4 8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6' Summary: Grab and drop SR_lock to get the thread to honor the safepoint protocol Reviewed-by: dcubed, coleenp ! src/share/vm/services/memBaseline.cpp Changeset: 746b070f5022 Author: ccheung Date: 2013-04-30 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/746b070f5022 8011661: Insufficient memory message says "malloc" when sometimes it should say "mmap" Reviewed-by: coleenp, zgu, hseigel ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/blockOffsetTable.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp ! src/share/vm/utilities/workgroup.cpp Changeset: e4614b063fe1 Author: sla Date: 2013-04-30 21:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4614b063fe1 8013364: SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause Reviewed-by: coleenp, rbackman ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: 376ff861f611 Author: sla Date: 2013-05-01 01:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/376ff861f611 Merge Changeset: b4081e9714ec Author: vladidan Date: 2013-04-30 17:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4081e9714ec 8013398: Adjust number of stack guard pages on systems with large memory page size Summary: Auto adjust number of stack guard pages on systems with large memory page size Reviewed-by: bobv, coleenp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 1847df492437 Author: vladidan Date: 2013-05-01 10:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1847df492437 Merge Changeset: 08236d966eea Author: bharadwaj Date: 2013-05-01 08:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/08236d966eea 8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87 Summary: Do not treat static methods as miranda methods. Reviewed-by: dholmes, acorn ! src/share/vm/oops/klassVtable.cpp + test/runtime/lambda-features/PublicStaticInterfaceMethodHandling.java Changeset: 8fe2542bdc8d Author: bharadwaj Date: 2013-05-01 09:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8fe2542bdc8d Merge Changeset: a6e09d6dd8e5 Author: dlong Date: 2013-04-24 20:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6e09d6dd8e5 8003853: specify offset of IC load in java_to_interp stub Summary: refactored code to allow platform-specific differences Reviewed-by: dlong, twisti Contributed-by: Goetz Lindenmaier + src/cpu/sparc/vm/compiledIC_sparc.cpp ! src/cpu/sparc/vm/sparc.ad + src/cpu/x86/vm/compiledIC_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad + src/cpu/zero/vm/compiledIC_zero.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/opto/output.cpp Changeset: e10e43e58e92 Author: dlong Date: 2013-04-24 21:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e10e43e58e92 Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/share/vm/opto/output.cpp - test/gc/6941923/test6941923.sh - test/gc/TestVerifyBeforeGCDuringStartup.java - test/runtime/NMT/AllocTestType.java Changeset: 3c0584fec1e6 Author: dholmes Date: 2013-04-28 18:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c0584fec1e6 8010428: Special -agentpath checks needed with minimal VM to produce proper error message Reviewed-by: dholmes, alanb, cjplummer, olagneau Contributed-by: Carlos Lucasius ! src/share/vm/runtime/arguments.cpp Changeset: 78603aa58b1e Author: jiangli Date: 2013-04-26 16:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78603aa58b1e Merge ! src/cpu/x86/vm/x86_64.ad Changeset: e01e02a9fcb6 Author: jiangli Date: 2013-04-29 01:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e01e02a9fcb6 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 052caeaeb771 Author: jiangli Date: 2013-05-02 12:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/052caeaeb771 Merge Changeset: 8f9fae155577 Author: jiangli Date: 2013-05-02 13:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f9fae155577 Merge Changeset: c23dbf0e8ab7 Author: jmasa Date: 2013-03-01 10:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c23dbf0e8ab7 8011268: NPG: Free unused VirtualSpaceNodes Reviewed-by: mgerdin, coleenp, johnc ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: bfe3be9ebd6c Author: kevinw Date: 2013-04-18 17:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bfe3be9ebd6c 7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line Reviewed-by: mgerdin ! test/gc/7072527/TestFullGCCount.java Changeset: 12927badda81 Author: kevinw Date: 2013-04-19 05:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/12927badda81 Merge Changeset: d391427ddc29 Author: mgerdin Date: 2013-04-22 10:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d391427ddc29 Merge Changeset: a08c80e9e1e5 Author: stefank Date: 2013-04-22 20:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a08c80e9e1e5 8012687: Remove unused is_root checks and closures Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp Changeset: ebded0261dfc Author: jmasa Date: 2013-04-22 22:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ebded0261dfc 8012111: Remove warning about CMS generation shrinking. Reviewed-by: johnc, brutisso, stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/GuardShrinkWarning.java Changeset: 1cb4795305b9 Author: mgerdin Date: 2013-04-23 08:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1cb4795305b9 8011802: NPG: init_dependencies in class loader data graph can cause invalid CLD Summary: Restructure initialization of ClassLoaderData to not add a new instance if init_dependencies fail Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp Changeset: 5c93c1f61226 Author: johnc Date: 2013-04-18 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c93c1f61226 8011724: G1: Stack allocate instances of HeapRegionRemSetIterator Summary: Stack allocate instances of HeapRegionRemSetIterator during RSet scanning. Reviewed-by: brutisso, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp Changeset: 868d87ed63c8 Author: jmasa Date: 2013-02-12 14:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/868d87ed63c8 8008966: NPG: Inefficient Metaspace counter functions cause large young GC regressions Reviewed-by: mgerdin, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 9d75bcd7c890 Author: mgerdin Date: 2013-04-24 19:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d75bcd7c890 8013136: NPG: Parallel class loading tests fail after fix for JDK-8011802 Summary: Move initialization of dependencies to before allocation of CLD Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp Changeset: d50cc62e94ff Author: johnc Date: 2013-04-24 14:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d50cc62e94ff 8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime. Reviewed-by: twisti, johnc Contributed-by: Martin Doerr ! src/share/vm/opto/graphKit.cpp Changeset: b06ac540229e Author: stefank Date: 2013-04-24 20:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b06ac540229e 8013132: Add a flag to turn off the output of the verbose verification code Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vm_operations.hpp Changeset: b294421fa3c5 Author: brutisso Date: 2013-04-26 09:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b294421fa3c5 8012915: ReservedSpace::align_reserved_region() broken on Windows Summary: remove unused constructors and helper methods for ReservedHeapSpace and ReservedSpace Reviewed-by: mgerdin, jmasa, johnc, tschatzl ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 2f50bc369470 Author: stefank Date: 2013-04-26 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f50bc369470 8013160: NPG: Remove unnecessary mark stack draining after CodeCache::do_unloading Reviewed-by: coleenp, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: 3edf23423bb2 Author: johnc Date: 2013-04-26 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3edf23423bb2 8011898: gc/TestVerifyBeforeGCDuringStartup.java: java.lang.RuntimeException: '[Verifying' missing from stdout/stderr: [Error: Could not find or load main class] Summary: System.getProperty("test.java.opts") can return NULL, which gets converted to to the empty string, and the child java command then interprets that as the name of the main class. Reviewed-by: jmasa, brutisso ! test/gc/TestVerifyDuringStartup.java Changeset: caac22686b17 Author: mgerdin Date: 2013-04-29 09:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/caac22686b17 Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/runtime/thread.cpp Changeset: 601183f604b2 Author: mgerdin Date: 2013-04-29 13:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/601183f604b2 8013129: Possible deadlock with Metaspace locks due to mixed usage of safepoint aware and non-safepoint aware locking Summary: Change Metaspace::deallocate to take lock with _no_safepoint_check_flag Reviewed-by: coleenp, jmasa, dholmes ! src/share/vm/memory/metaspace.cpp Changeset: 9075044ed66b Author: ehelin Date: 2013-04-30 16:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9075044ed66b 8008541: Remove old code in HotSpot that supported the jmap -permstat functionality Reviewed-by: sla, brutisso ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java Changeset: d58c62b7447d Author: mgerdin Date: 2013-05-02 19:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d58c62b7447d Merge ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp Changeset: cbd4ce58f1f3 Author: mgerdin Date: 2013-05-02 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbd4ce58f1f3 Merge Changeset: e12c9b3740db Author: vlivanov Date: 2013-04-25 11:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e12c9b3740db 8012260: ciReplay: Include PID into the name of replay data file Reviewed-by: kvn, twisti ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/vmError.cpp Changeset: dc7db03f5aa2 Author: iignatyev Date: 2013-04-25 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc7db03f5aa2 8012337: Change Whitebox implementation to make absence of method in Whitebox.class not fatal Reviewed-by: kvn, vlivanov ! src/share/vm/prims/whitebox.cpp + test/sanity/WhiteBox.java Changeset: 7b23cb975cf2 Author: iignatyev Date: 2013-04-25 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7b23cb975cf2 8011675: adding compilation level to replay data Reviewed-by: kvn, vlivanov - agent/doc/c2replay.html + agent/doc/cireplay.html ! agent/doc/clhsdb.html ! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/ciReplay/TestSA.sh + test/compiler/ciReplay/TestVM.sh + test/compiler/ciReplay/TestVM_no_comp_level.sh + test/compiler/ciReplay/common.sh Changeset: 247342108a11 Author: neliasso Date: 2013-04-23 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/247342108a11 8010332: removed unused method: ciMethod::uses_monitors Reviewed-by: twisti, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/ci/ciMethod.hpp Changeset: a5c95fcf7cb7 Author: neliasso Date: 2013-04-23 18:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a5c95fcf7cb7 8012157: removed unused code in SharedRuntime::handle_wrong_method Reviewed-by: kvn, roland, rbackman Contributed-by: albert.noll at oracle.com ! src/share/vm/runtime/sharedRuntime.cpp Changeset: d1c9384eecb4 Author: iignatyev Date: 2013-04-26 07:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1c9384eecb4 8012322: Tiered: CompilationPolicy::can_be_compiled(CompLevel_all) mistakenly return false Reviewed-by: kvn, vlivanov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java Changeset: 93b8272814cf Author: vlivanov Date: 2013-04-26 08:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/93b8272814cf Merge Changeset: 0b55a78c6be5 Author: bharadwaj Date: 2013-04-26 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b55a78c6be5 Merge - agent/doc/c2replay.html ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fd49109d0d88 Author: bharadwaj Date: 2013-04-26 14:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd49109d0d88 Merge Changeset: 487d442ef257 Author: jiangli Date: 2013-04-26 16:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/487d442ef257 8013036: vm/runtime/simpleThresholdPolicy.cpp: assert(mcs != NULL). Summary: Change the assert to if check as MethodCounters could be NULL under TieredCompilation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 62b683108582 Author: jiangli Date: 2013-04-26 14:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/62b683108582 Merge Changeset: 0cfa93c2fcc4 Author: neliasso Date: 2013-04-29 13:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0cfa93c2fcc4 8012547: Code cache flushing can get stuck reclaming of memory Summary: Keep sweeping regardless of if we are flushing Reviewed-by: kvn, twisti ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: e4e131b15d5c Author: roland Date: 2013-05-02 10:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4e131b15d5c 8013532: Remove unused parameter "compiler" from DTRACE_METHOD_COMPILE* macros Summary: remove unused parameter in dtrace macros Reviewed-by: kvn, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/compiler/compileBroker.cpp Changeset: 9ce110b1d14a Author: kvn Date: 2013-05-02 18:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ce110b1d14a Merge - agent/doc/c2replay.html ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/vmError.cpp Changeset: 4ec913499722 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4ec913499722 Merge - agent/doc/c2replay.html Changeset: 9c1fe0b419b4 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c1fe0b419b4 Added tag hs25-b31 for changeset 4ec913499722 ! .hgtags From lana.steuck at oracle.com Thu May 9 16:26:02 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:26:02 +0000 Subject: hg: jdk8/tl/jdk: 30 new changesets Message-ID: <20130509233415.263C54897B@hg.openjdk.java.net> Changeset: 78d08fc2dd12 Author: mullan Date: 2013-04-25 11:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78d08fc2dd12 8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/OCSP.java Changeset: 3e282678a885 Author: mullan Date: 2013-04-25 15:48 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e282678a885 8013228: Create new system properties to control allowable OCSP clock skew and CRL connection timeout Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/CertPathHelper.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java Changeset: 7c4eb715c5e8 Author: ngthomas Date: 2013-04-30 21:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c4eb715c5e8 Merge Changeset: 12af7c32c648 Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12af7c32c648 8013480: fix zero build on arm Reviewed-by: erikj ! makefiles/GensrcX11Wrappers.gmk Changeset: 7a96ead5ea89 Author: katleman Date: 2013-04-30 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a96ead5ea89 Merge Changeset: 55c7b90fe57e Author: katleman Date: 2013-05-01 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55c7b90fe57e Merge Changeset: 8dbb4b159e04 Author: erikj Date: 2013-05-02 15:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8dbb4b159e04 8013552: Add build support for different man pages for OpenJDK and OracleJDK Reviewed-by: tbell, omajid ! makefiles/Images.gmk Changeset: 1daef88acff2 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1daef88acff2 Added tag jdk8-b88 for changeset 8dbb4b159e04 ! .hgtags Changeset: b0c41789f500 Author: jgodinez Date: 2013-04-25 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0c41789f500 8009199: Printed text become garbage on Mac OSX Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: f4aa34a7a44d Author: jchen Date: 2013-04-29 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4aa34a7a44d 8005302: [findbugs] public methods return internal arrays; may be private Reviewed-by: bae, prr ! src/share/classes/sun/java2d/pipe/AAShapePipe.java Changeset: 46686202aa23 Author: lana Date: 2013-04-30 22:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46686202aa23 Merge Changeset: c70346f4c0a9 Author: pchelko Date: 2013-04-18 15:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c70346f4c0a9 8011686: AWT accidentally disables the NSApplicationDelegate of SWT, causing loss of OS X integration functionality Reviewed-by: anthony, serb Contributed-by: Markus Persson ! src/macosx/native/sun/awt/awt.m Changeset: ac92ac05dde4 Author: kshefov Date: 2013-04-22 18:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac92ac05dde4 8011230: [TEST_BUG] java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java failed on solaris Reviewed-by: serb, anthony ! test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh Changeset: 578fb8766200 Author: leonidr Date: 2013-04-22 19:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/578fb8766200 8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTEvent.h ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 0894b8476a49 Author: lana Date: 2013-04-23 15:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0894b8476a49 Merge - src/share/classes/java/time/chrono/HijrahDeviationReader.java - src/share/classes/java/time/format/DateTimeBuilder.java - src/share/classes/java/time/format/DateTimeFormatStyleProvider.java - src/share/classes/java/time/temporal/Adjusters.java - src/share/classes/java/time/temporal/Queries.java - src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM - src/share/native/java/lang/ResourceBundle.c - test/java/time/tck/java/time/TestChronology.java - test/java/time/tck/java/time/chrono/TestChronoLocalDate.java - test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java - test/java/time/tck/java/time/chrono/TestHijrahChronology.java - test/java/time/tck/java/time/chrono/TestJapaneseChronology.java - test/java/time/tck/java/time/chrono/TestMinguoChronology.java - test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java - test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java - test/java/time/tck/java/time/temporal/TestChronoLocalDate.java - test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java - test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java - test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java - test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java - test/java/util/ComparatorsTest.java Changeset: 7103434eefe2 Author: kshefov Date: 2013-04-24 11:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7103434eefe2 8011186: [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8 Reviewed-by: anthony, serb, ant - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java + test/java/awt/Focus/SimpleWindowActivationTest/SimpleWindowActivationTest.java Changeset: 854f60ec4bfb Author: anthony Date: 2013-04-26 18:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/854f60ec4bfb 8012586: [x11] Modal dialogs for fullscreen window may show behind its owner Summary: Use the _NET_WM_WINDOW_TYPE_DIALOG type for owned windows Reviewed-by: anthony, art, serb Contributed-by: Vladimir Kravets ! src/solaris/classes/sun/awt/X11/XWindowPeer.java + test/java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java Changeset: e76f3e8e653f Author: malenkov Date: 2013-04-29 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e76f3e8e653f 8007458: [findbugs] One more beans issue, with ReflectionUtils Reviewed-by: art, alexsch ! src/share/classes/java/beans/MetaData.java - src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/beans/XMLEncoder.java ! test/java/beans/XMLEncoder/AbstractTest.java ! test/java/beans/XMLEncoder/BeanValidator.java ! test/java/beans/XMLEncoder/Test4631471.java ! test/java/beans/XMLEncoder/Test4679556.java ! test/java/beans/XMLEncoder/java_awt_BorderLayout.java + test/java/beans/XMLEncoder/java_awt_CardLayout.java + test/java/beans/XMLEncoder/java_awt_GridBagLayout.java ! test/java/beans/XMLEncoder/javax_swing_DefaultCellEditor.java Changeset: 358acb00cb2d Author: mcherkas Date: 2013-04-30 13:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/358acb00cb2d 8012004: JInternalFrame not being finalized after closing Reviewed-by: alexsch, alexp ! src/share/classes/javax/swing/JDesktopPane.java + test/javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java Changeset: 31e111f82993 Author: serb Date: 2013-04-30 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31e111f82993 7166296: closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36 Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: caeedce39396 Author: serb Date: 2013-05-01 12:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/caeedce39396 8009012: [macosx] DisplayChangedListener is not implemented in LWWindowPeer/CGraphicsEnvironment Reviewed-by: anthony, bae ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/CGraphicsEnv.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: c357c11f076f Author: lana Date: 2013-05-01 09:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c357c11f076f Merge Changeset: 920ad6c95d93 Author: lana Date: 2013-05-01 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/920ad6c95d93 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: f6f2802f980c Author: lana Date: 2013-05-01 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6f2802f980c Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 336a110f1196 Author: lana Date: 2013-05-06 11:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/336a110f1196 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 88125d32eb06 Author: andrew Date: 2013-05-04 17:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88125d32eb06 8011366: Enable debug info on all libraries for OpenJDK builds Summary: The build should not be turning off debugging if it has been requested. Reviewed-by: erikj, dholmes ! makefiles/CompileNativeLibraries.gmk Changeset: 7ba77fff0ef6 Author: katleman Date: 2013-05-07 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ba77fff0ef6 Merge Changeset: 845025546e35 Author: katleman Date: 2013-05-07 13:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/845025546e35 Merge Changeset: 573a593379cb Author: lana Date: 2013-05-08 23:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/573a593379cb Merge ! makefiles/CompileNativeLibraries.gmk ! makefiles/Images.gmk - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: 2023e3d573eb Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2023e3d573eb Merge - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java From yunda.mly at taobao.com Thu May 9 19:32:29 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Fri, 10 May 2013 02:32:29 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> <51899F46.1090800@oracle.com> <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> Message-ID: Thanks for looking at this, Rickard. David, do you like this option which is easier to read, too :) Regards, Yunda > -----Original Message----- > From: Rickard B?ckman [mailto:rickard.backman at oracle.com] > Sent: Thursday, May 09, 2013 4:53 PM > To: ??(Yunda) > Cc: David Holmes; serviceability-dev at openjdk.java.net; > hotspot-runtime-dev at openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > Looks good to me! > > /R > > On May 9, 2013, at 8:38 AM, ??(Yunda) wrote: > > > Rickard, > > > > Actually I've considered the option and I just thought it's less elegant. But just > as you said, it's clearer and easier to read. The updated and tested change: > > > > diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > > --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 > > +++ b/src/share/vm/runtime/globals.hpp Thu May 09 14:36:35 2013 +0800 > > @@ -3634,7 +3634,10 @@ > > "Include GC cause in GC logging") > \ > > > \ > > product(bool, EnableTracing, false, > \ > > - "Enable event-based tracing") > > + "Enable event-based tracing") > \ > > + > \ > > + product(bool, UseLockedTracing, false, > \ > > + "Use locked-tracing when doing event-based > > + tracing") > > > > /* > > * Macros for factoring of globals > > diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > > --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 > > 2013 -0700 > > +++ b/src/share/vm/trace/traceEventClasses.xsl Thu May 09 14:36:35 > > +++ 2013 +0800 > > @@ -132,6 +132,15 @@ > > void writeEvent(void) { > > ResourceMark rm; > > HandleMark hm; > > + if (UseLockedTracing) { > > + ttyLocker lock; > > + writeEventContent(); > > + } else { > > + writeEventContent(); > > + } > > + } > > + > > + void writeEventContent() { > > TraceStream ts(*tty); > > ts.print(": ["); > > > > > > > > Regards, > > Yunda > > > >> -----Original Message----- > >> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] > >> Sent: Wednesday, May 08, 2013 3:03 PM > >> To: David Holmes > >> Cc: ??(Yunda); serviceability-dev at openjdk.java.net; > >> hotspot-runtime-dev at openjdk.java.net > >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may > >> be mixed together > >> > >> One option could be to move the content of writeEvent() to its own > >> method (maybe writeEventContent()) and just do > >> > >> if (UseLockedTracing) { > >> ttyLocker lock; > >> writeEventContent(); > >> } else { > >> writeEventContent(); > >> } > >> > >> I think it makes it easier to read. > >> > >> /R > >> > >> On May 8, 2013, at 2:41 AM, David Holmes wrote: > >> > >>> On 7/05/2013 10:33 PM, ??(Yunda) wrote: > >>>> David, > >>>> > >>>> Sorry about the stupid mistake. And please see the tested change below. > >> Since I don't find an elegant way to define a ttyLocker object, I use > >> the static methods of ttyLocker instead. > >>> > >>> Yeah there's no elegant solution when you need to conditionalize > >>> things. :( > >>> > >>> This looks fine to me but the serviceability folk should chime back in. > >>> > >>> Thanks, > >>> David > >>> > >>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > >>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 > >>>> -0700 > >>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 > >>>> +++ +0800 > >>>> @@ -3634,7 +3634,10 @@ > >>>> "Include GC cause in GC logging") > >> \ > >>>> > >> \ > >>>> product(bool, EnableTracing, false, > >> \ > >>>> - "Enable event-based tracing") > >>>> + "Enable event-based tracing") > >> \ > >>>> + > >> \ > >>>> + product(bool, UseLockedTracing, false, > >> \ > >>>> + "Use locked-tracing when doing event-based > >>>> + tracing") > >>>> > >>>> /* > >>>> * Macros for factoring of globals diff -r 627cf9e9ea31 > >>>> src/share/vm/trace/traceEventClasses.xsl > >>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 > >>>> 2013 -0700 > >>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 > >>>> +++ 2013 +0800 > >>>> @@ -132,10 +132,17 @@ > >>>> void writeEvent(void) { > >>>> ResourceMark rm; > >>>> HandleMark hm; > >>>> + int holder; > >>>> + if (UseLockedTracing) { > >>>> + holder = ttyLocker::hold_tty(); > >>>> + } > >>>> TraceStream ts(*tty); > >>>> ts.print(": ["); > >>>> > >>>> ts.print("]\n"); > >>>> + if (UseLockedTracing) { > >>>> + ttyLocker::release_tty(holder); > >>>> + } > >>>> } > >>>> }; > >>>> > >>>> > >>>> Regards, > >>>> Yunda > >>>> > >>>> > >>>>> -----Original Message----- > >>>>> From: David Holmes [mailto:david.holmes at oracle.com] > >>>>> Sent: Tuesday, May 07, 2013 5:50 PM > >>>>> To: ??(Yunda) > >>>>> Cc: hotspot-runtime-dev at openjdk.java.net; > >>>>> serviceability-dev at openjdk.java.net > >>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads > >>>>> may be mixed together > >>>>> > >>>>> On 7/05/2013 7:43 PM, ??(Yunda) wrote: > >>>>>> Hi David, > >>>>>> > >>>>>> Thanks for the review and I see your concern. Please see the > >>>>>> updated change > >>>>> below: > >>>>>> > >>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > >>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 > >>>>>> -0700 > >>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 > >>>>>> +++ +0800 > >>>>>> @@ -3634,7 +3634,10 @@ > >>>>>> "Include GC cause in GC logging") > >>>>> \ > >>>>>> > >>>>> \ > >>>>>> product(bool, EnableTracing, false, > >>>>> \ > >>>>>> - "Enable event-based tracing") > >>>>>> + "Enable event-based tracing") > >>>>> \ > >>>>>> + > >>>>> \ > >>>>>> + product(bool, UseLockedTracing, false, > >>>>> \ > >>>>>> + "Use locked-tracing when doing event-based > >>>>>> + tracing") > >>>>>> > >>>>>> /* > >>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 > >>>>>> src/share/vm/trace/traceEventClasses.xsl > >>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 > >>>>>> 10:29:49 > >>>>>> 2013 -0700 > >>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 > >>>>>> +++ 17:38:58 > >>>>>> +++ 2013 +0800 > >>>>>> @@ -132,6 +132,9 @@ > >>>>>> void writeEvent(void) { > >>>>>> ResourceMark rm; > >>>>>> HandleMark hm; > >>>>>> + if (UseLockedTracing) { > >>>>>> + ttyLocker ttyl; > >>>>>> + } > >>>>> > >>>>> Ah that doesn't work - the ttyLocker is block-scoped by the if > >>>>> statement so it will be created, grab the lock, then immediately > >>>>> be destructed and the lock released. > >>>>> > >>>>> David > >>>>> ----- > >>>>> > >>>>>> TraceStream ts(*tty); > >>>>>> ts.print(": ["); > >>>>>> >>>>>> mode="write-data"/> > >>>>>> > >>>>>> Regards, > >>>>>> Yunda > >>>>>> > >>>>>>> -----Original Message----- > >>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] > >>>>>>> Sent: Tuesday, May 07, 2013 10:39 AM > >>>>>>> To: ??(Yunda) > >>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; > >>>>>>> serviceability-dev at openjdk.java.net > >>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads > >>>>>>> may be mixed together > >>>>>>> > >>>>>>> Hi Yunda, > >>>>>>> > >>>>>>> There is a potential problem with using a ttyLocker here, > >>>>>>> depending on exactly what events are being traced and from where > >>>>>>> - you must always be in code where it is both safe to acquire > >>>>>>> the lock, and safe to block waiting for the lock if it is not available. > >>>>>>> > >>>>>>> I think I would prefer to see unlocked tracing by default with a > >>>>>>> flag to use locked-tracing if requested. > >>>>>>> > >>>>>>> David > >>>>>>> > >>>>>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: > >>>>>>>> Hi all, > >>>>>>>> > >>>>>>>> I found that the output from multiple threads may be mixed > >>>>>>>> together when using EnableTracing. It happens many times in my > >>>>>>>> test > >> case like this: > >>>>>>>> > >>>>>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation > >>>>>>>> in new > >>>>>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: > >>>>>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class > >>>>>>>> = java/lang/String, Allocation Size = 24, Allocation Size = 24, > >>>>>>>> Class = java/lang/String, Class = [I, Allocation in new TLAB: > >>>>>>>> [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > >>>>>>>> > >>>>>>>> Class = > >>>>>>>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, > >>>>>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = > >>>>>>>> 23712280] > >>>>>>>> > >>>>>>>> TLAB Size = 24607080] > >>>>>>>> > >>>>>>>> Allocation Size = 24, Monitor Class = > >>>>>>>> java/lang/ref/Reference$Lock, TLAB Size = 25054480] > >>>>>>>> > >>>>>>>> TLAB Size = 25054480] > >>>>>>>> > >>>>>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > >>>>>>>> > >>>>>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] > >>>>>>>> > >>>>>>>> , Allocation Size = 32, TLAB Size = 23712288] > >>>>>>>> > >>>>>>>> It's very confusing and it's even not easy to tell how many > >>>>>>>> events there are. I think the reason is that the writeEvent() > >>>>>>>> method of each > >>>>>>>> Event* class output the fields of event one by one without > >>>>>>>> using any lock. So I made a small patch which add ttyLocker to > >>>>>>>> writeEvent() method and after applying this patch there's no > >>>>>>>> output mixed together in my test case(against > >>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > >>>>>>>> > >>>>>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > >>>>>>>> > >>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 > >> 13:50:58 > >>>>>>>> 2013 -0700 > >>>>>>>> > >>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 > >>>>>>>> +++ 16:12:38 > >>>>>>>> +++ 2013 > >>>>>>>> +0800 > >>>>>>>> > >>>>>>>> @@ -132,6 +132,7 @@ > >>>>>>>> > >>>>>>>> void writeEvent(void) { > >>>>>>>> > >>>>>>>> ResourceMark rm; > >>>>>>>> > >>>>>>>> HandleMark hm; > >>>>>>>> > >>>>>>>> + ttyLocker ttyl; > >>>>>>>> > >>>>>>>> TraceStream ts(*tty); > >>>>>>>> > >>>>>>>> ts.print(": ["); > >>>>>>>> > >>>>>>>> >>>>>>>> mode="write-data"/> > >>>>>>>> > >>>>>>>> I searched before sending this mail I didn't find anyone who > >>>>>>>> covering thisJ > >>>>>>>> > >>>>>>>> Regards, > >>>>>>>> > >>>>>>>> Yunda > >>>>>>>> > >>>>>>>> > >>>>>>>> --------------------------------------------------------------- > >>>>>>>> -- > >>>>>>>> --- > >>>>>>>> -- > >>>>>>>> -- > >>>>>>>> > >>>>>>>> This email (including any attachments) is confidential and may > >>>>>>>> be legally privileged. If you received this email in error, > >>>>>>>> please delete it immediately and do not copy it or use it for > >>>>>>>> any purpose or disclose its contents to any other person. Thank you. > >>>>>>>> > >>>>>>>> ???(??????)?????????????????? > ? > >> ?? > >>>>> ? > >>>>>>> ???? > >>>>>>>> ???????????????????????????? > ? > >> ?? > >>>>>>> ????? > >>>>>>>> ???????? > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> This email (including any attachments) is confidential and may be > >>>>>> legally > >>>>> privileged. If you received this email in error, please delete it > >>>>> immediately and do not copy it or use it for any purpose or > >>>>> disclose its contents to any other person. Thank you. > >>>>> > >>>>>> > >>>>>> ???(??????)??????????????????? > ? > >> ?? > >>>>> ????????????????????????????? > ? > >> ?? > >>>>> ????? > >>>>>> ??????????? > >>>>>> > >>>> > >>>> ________________________________ > >>>> > >>>> This email (including any attachments) is confidential and may be > >>>> legally > >> privileged. If you received this email in error, please delete it > >> immediately and do not copy it or use it for any purpose or disclose > >> its contents to any other person. Thank you. > >>>> > >>>> ???(??????)???????????????????? > ? > >> ??????????????????????????????? > ? > >> ????? > >>>> ???????????? > >>>> > > > > > > ________________________________ > > > > This email (including any attachments) is confidential and may be legally > privileged. If you received this email in error, please delete it immediately and > do not copy it or use it for any purpose or disclose its contents to any other > person. Thank you. > > > > > ???(??????)?????????????????????? > ???????????????????????????????? > ????? > > ??????????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From david.holmes at oracle.com Thu May 9 20:31:31 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 10 May 2013 13:31:31 +1000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> <51899F46.1090800@oracle.com> <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> Message-ID: <518C6A13.5040805@oracle.com> On 10/05/2013 12:32 PM, ??(Yunda) wrote: > Thanks for looking at this, Rickard. David, do you like this option which is easier to read, too :) Sure. David ----- > > Regards, > Yunda > >> -----Original Message----- >> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] >> Sent: Thursday, May 09, 2013 4:53 PM >> To: ??(Yunda) >> Cc: David Holmes; serviceability-dev at openjdk.java.net; >> hotspot-runtime-dev at openjdk.java.net >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed >> together >> >> Looks good to me! >> >> /R >> >> On May 9, 2013, at 8:38 AM, ??(Yunda) wrote: >> >>> Rickard, >>> >>> Actually I've considered the option and I just thought it's less elegant. But just >> as you said, it's clearer and easier to read. The updated and tested change: >>> >>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 >>> +++ b/src/share/vm/runtime/globals.hpp Thu May 09 14:36:35 2013 +0800 >>> @@ -3634,7 +3634,10 @@ >>> "Include GC cause in GC logging") >> \ >>> >> \ >>> product(bool, EnableTracing, false, >> \ >>> - "Enable event-based tracing") >>> + "Enable event-based tracing") >> \ >>> + >> \ >>> + product(bool, UseLockedTracing, false, >> \ >>> + "Use locked-tracing when doing event-based >>> + tracing") >>> >>> /* >>> * Macros for factoring of globals >>> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl >>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>> 2013 -0700 >>> +++ b/src/share/vm/trace/traceEventClasses.xsl Thu May 09 14:36:35 >>> +++ 2013 +0800 >>> @@ -132,6 +132,15 @@ >>> void writeEvent(void) { >>> ResourceMark rm; >>> HandleMark hm; >>> + if (UseLockedTracing) { >>> + ttyLocker lock; >>> + writeEventContent(); >>> + } else { >>> + writeEventContent(); >>> + } >>> + } >>> + >>> + void writeEventContent() { >>> TraceStream ts(*tty); >>> ts.print(": ["); >>> >>> >>> >>> Regards, >>> Yunda >>> >>>> -----Original Message----- >>>> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] >>>> Sent: Wednesday, May 08, 2013 3:03 PM >>>> To: David Holmes >>>> Cc: ??(Yunda); serviceability-dev at openjdk.java.net; >>>> hotspot-runtime-dev at openjdk.java.net >>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads may >>>> be mixed together >>>> >>>> One option could be to move the content of writeEvent() to its own >>>> method (maybe writeEventContent()) and just do >>>> >>>> if (UseLockedTracing) { >>>> ttyLocker lock; >>>> writeEventContent(); >>>> } else { >>>> writeEventContent(); >>>> } >>>> >>>> I think it makes it easier to read. >>>> >>>> /R >>>> >>>> On May 8, 2013, at 2:41 AM, David Holmes wrote: >>>> >>>>> On 7/05/2013 10:33 PM, ??(Yunda) wrote: >>>>>> David, >>>>>> >>>>>> Sorry about the stupid mistake. And please see the tested change below. >>>> Since I don't find an elegant way to define a ttyLocker object, I use >>>> the static methods of ttyLocker instead. >>>>> >>>>> Yeah there's no elegant solution when you need to conditionalize >>>>> things. :( >>>>> >>>>> This looks fine to me but the serviceability folk should chime back in. >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 >>>>>> -0700 >>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 >>>>>> +++ +0800 >>>>>> @@ -3634,7 +3634,10 @@ >>>>>> "Include GC cause in GC logging") >>>> \ >>>>>> >>>> \ >>>>>> product(bool, EnableTracing, false, >>>> \ >>>>>> - "Enable event-based tracing") >>>>>> + "Enable event-based tracing") >>>> \ >>>>>> + >>>> \ >>>>>> + product(bool, UseLockedTracing, false, >>>> \ >>>>>> + "Use locked-tracing when doing event-based >>>>>> + tracing") >>>>>> >>>>>> /* >>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 >>>>>> src/share/vm/trace/traceEventClasses.xsl >>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>>>>> 2013 -0700 >>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 >>>>>> +++ 2013 +0800 >>>>>> @@ -132,10 +132,17 @@ >>>>>> void writeEvent(void) { >>>>>> ResourceMark rm; >>>>>> HandleMark hm; >>>>>> + int holder; >>>>>> + if (UseLockedTracing) { >>>>>> + holder = ttyLocker::hold_tty(); >>>>>> + } >>>>>> TraceStream ts(*tty); >>>>>> ts.print(": ["); >>>>>> >>>>>> ts.print("]\n"); >>>>>> + if (UseLockedTracing) { >>>>>> + ttyLocker::release_tty(holder); >>>>>> + } >>>>>> } >>>>>> }; >>>>>> >>>>>> >>>>>> Regards, >>>>>> Yunda >>>>>> >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>>>>> Sent: Tuesday, May 07, 2013 5:50 PM >>>>>>> To: ??(Yunda) >>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>>>>> serviceability-dev at openjdk.java.net >>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads >>>>>>> may be mixed together >>>>>>> >>>>>>> On 7/05/2013 7:43 PM, ??(Yunda) wrote: >>>>>>>> Hi David, >>>>>>>> >>>>>>>> Thanks for the review and I see your concern. Please see the >>>>>>>> updated change >>>>>>> below: >>>>>>>> >>>>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>>>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 >>>>>>>> -0700 >>>>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 >>>>>>>> +++ +0800 >>>>>>>> @@ -3634,7 +3634,10 @@ >>>>>>>> "Include GC cause in GC logging") >>>>>>> \ >>>>>>>> >>>>>>> \ >>>>>>>> product(bool, EnableTracing, false, >>>>>>> \ >>>>>>>> - "Enable event-based tracing") >>>>>>>> + "Enable event-based tracing") >>>>>>> \ >>>>>>>> + >>>>>>> \ >>>>>>>> + product(bool, UseLockedTracing, false, >>>>>>> \ >>>>>>>> + "Use locked-tracing when doing event-based >>>>>>>> + tracing") >>>>>>>> >>>>>>>> /* >>>>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 >>>>>>>> src/share/vm/trace/traceEventClasses.xsl >>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 >>>>>>>> 10:29:49 >>>>>>>> 2013 -0700 >>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 >>>>>>>> +++ 17:38:58 >>>>>>>> +++ 2013 +0800 >>>>>>>> @@ -132,6 +132,9 @@ >>>>>>>> void writeEvent(void) { >>>>>>>> ResourceMark rm; >>>>>>>> HandleMark hm; >>>>>>>> + if (UseLockedTracing) { >>>>>>>> + ttyLocker ttyl; >>>>>>>> + } >>>>>>> >>>>>>> Ah that doesn't work - the ttyLocker is block-scoped by the if >>>>>>> statement so it will be created, grab the lock, then immediately >>>>>>> be destructed and the lock released. >>>>>>> >>>>>>> David >>>>>>> ----- >>>>>>> >>>>>>>> TraceStream ts(*tty); >>>>>>>> ts.print(": ["); >>>>>>>> >>>>>>> mode="write-data"/> >>>>>>>> >>>>>>>> Regards, >>>>>>>> Yunda >>>>>>>> >>>>>>>>> -----Original Message----- >>>>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>>>>>>> Sent: Tuesday, May 07, 2013 10:39 AM >>>>>>>>> To: ??(Yunda) >>>>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>>>>>>> serviceability-dev at openjdk.java.net >>>>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads >>>>>>>>> may be mixed together >>>>>>>>> >>>>>>>>> Hi Yunda, >>>>>>>>> >>>>>>>>> There is a potential problem with using a ttyLocker here, >>>>>>>>> depending on exactly what events are being traced and from where >>>>>>>>> - you must always be in code where it is both safe to acquire >>>>>>>>> the lock, and safe to block waiting for the lock if it is not available. >>>>>>>>> >>>>>>>>> I think I would prefer to see unlocked tracing by default with a >>>>>>>>> flag to use locked-tracing if requested. >>>>>>>>> >>>>>>>>> David >>>>>>>>> >>>>>>>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> I found that the output from multiple threads may be mixed >>>>>>>>>> together when using EnableTracing. It happens many times in my >>>>>>>>>> test >>>> case like this: >>>>>>>>>> >>>>>>>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation >>>>>>>>>> in new >>>>>>>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: >>>>>>>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class >>>>>>>>>> = java/lang/String, Allocation Size = 24, Allocation Size = 24, >>>>>>>>>> Class = java/lang/String, Class = [I, Allocation in new TLAB: >>>>>>>>>> [Class = [C, Allocation in new TLAB: [Allocation Size = 192] >>>>>>>>>> >>>>>>>>>> Class = >>>>>>>>>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, >>>>>>>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = >>>>>>>>>> 23712280] >>>>>>>>>> >>>>>>>>>> TLAB Size = 24607080] >>>>>>>>>> >>>>>>>>>> Allocation Size = 24, Monitor Class = >>>>>>>>>> java/lang/ref/Reference$Lock, TLAB Size = 25054480] >>>>>>>>>> >>>>>>>>>> TLAB Size = 25054480] >>>>>>>>>> >>>>>>>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] >>>>>>>>>> >>>>>>>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] >>>>>>>>>> >>>>>>>>>> , Allocation Size = 32, TLAB Size = 23712288] >>>>>>>>>> >>>>>>>>>> It's very confusing and it's even not easy to tell how many >>>>>>>>>> events there are. I think the reason is that the writeEvent() >>>>>>>>>> method of each >>>>>>>>>> Event* class output the fields of event one by one without >>>>>>>>>> using any lock. So I made a small patch which add ttyLocker to >>>>>>>>>> writeEvent() method and after applying this patch there's no >>>>>>>>>> output mixed together in my test case(against >>>>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): >>>>>>>>>> >>>>>>>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl >>>>>>>>>> >>>>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 >>>> 13:50:58 >>>>>>>>>> 2013 -0700 >>>>>>>>>> >>>>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 >>>>>>>>>> +++ 16:12:38 >>>>>>>>>> +++ 2013 >>>>>>>>>> +0800 >>>>>>>>>> >>>>>>>>>> @@ -132,6 +132,7 @@ >>>>>>>>>> >>>>>>>>>> void writeEvent(void) { >>>>>>>>>> >>>>>>>>>> ResourceMark rm; >>>>>>>>>> >>>>>>>>>> HandleMark hm; >>>>>>>>>> >>>>>>>>>> + ttyLocker ttyl; >>>>>>>>>> >>>>>>>>>> TraceStream ts(*tty); >>>>>>>>>> >>>>>>>>>> ts.print(": ["); >>>>>>>>>> >>>>>>>>>> >>>>>>>>> mode="write-data"/> >>>>>>>>>> >>>>>>>>>> I searched before sending this mail I didn't find anyone who >>>>>>>>>> covering thisJ >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> >>>>>>>>>> Yunda >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> --------------------------------------------------------------- >>>>>>>>>> -- >>>>>>>>>> --- >>>>>>>>>> -- >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> This email (including any attachments) is confidential and may >>>>>>>>>> be legally privileged. If you received this email in error, >>>>>>>>>> please delete it immediately and do not copy it or use it for >>>>>>>>>> any purpose or disclose its contents to any other person. Thank you. >>>>>>>>>> >>>>>>>>>> ???(??????)?????????????????? >> ? >>>> ?? >>>>>>> ? >>>>>>>>> ???? >>>>>>>>>> ???????????????????????????? >> ? >>>> ?? >>>>>>>>> ????? >>>>>>>>>> ???????? >>>>>>>> >>>>>>>> ________________________________ >>>>>>>> >>>>>>>> This email (including any attachments) is confidential and may be >>>>>>>> legally >>>>>>> privileged. If you received this email in error, please delete it >>>>>>> immediately and do not copy it or use it for any purpose or >>>>>>> disclose its contents to any other person. Thank you. >>>>>>> >>>>>>>> >>>>>>>> ???(??????)??????????????????? >> ? >>>> ?? >>>>>>> ????????????????????????????? >> ? >>>> ?? >>>>>>> ????? >>>>>>>> ??????????? >>>>>>>> >>>>>> >>>>>> ________________________________ >>>>>> >>>>>> This email (including any attachments) is confidential and may be >>>>>> legally >>>> privileged. If you received this email in error, please delete it >>>> immediately and do not copy it or use it for any purpose or disclose >>>> its contents to any other person. Thank you. >>>>>> >>>>>> ???(??????)???????????????????? >> ? >>>> ??????????????????????????????? >> ? >>>> ????? >>>>>> ???????????? >>>>>> >>> >>> >>> ________________________________ >>> >>> This email (including any attachments) is confidential and may be legally >> privileged. If you received this email in error, please delete it immediately and >> do not copy it or use it for any purpose or disclose its contents to any other >> person. Thank you. >> >>> >>> ???(??????)?????????????????????? >> ???????????????????????????????? >> ????? >>> ??????????? > > > ________________________________ > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? > From rickard.backman at oracle.com Fri May 10 00:29:24 2013 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Fri, 10 May 2013 07:29:24 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return Message-ID: <20130510072928.D0B42489A3@hg.openjdk.java.net> Changeset: 0b7f78069732 Author: rbackman Date: 2013-05-08 11:21 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0b7f78069732 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return Reviewed-by: coleenp, dholmes, sla ! src/share/vm/prims/jvmtiExport.cpp From joel.franck at oracle.com Fri May 10 02:06:56 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Fri, 10 May 2013 09:06:56 +0000 Subject: hg: jdk8/tl/jdk: 8007073: Implement Core Reflection for Type Annotations on parameters Message-ID: <20130510090725.83EF1489A7@hg.openjdk.java.net> Changeset: ba74cd79e4f6 Author: jfranck Date: 2013-05-10 10:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba74cd79e4f6 8007073: Implement Core Reflection for Type Annotations on parameters Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java ! test/java/lang/annotation/TypeAnnotationReflection.java From alan.bateman at oracle.com Fri May 10 06:56:10 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 10 May 2013 13:56:10 +0000 Subject: hg: jdk8/tl/jdk: 8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248 characters long Message-ID: <20130510135635.C1221489AC@hg.openjdk.java.net> Changeset: 09a3b08c986f Author: alanb Date: 2013-05-10 14:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09a3b08c986f 8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248 characters long Reviewed-by: khazra, chegar ! src/windows/classes/sun/nio/fs/WindowsFileCopy.java ! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java ! src/windows/classes/sun/nio/fs/WindowsPath.java + test/java/nio/file/Files/NameLimits.java From alan.bateman at oracle.com Fri May 10 08:15:09 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 10 May 2013 15:15:09 +0000 Subject: hg: jdk8/tl/langtools: 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1 Message-ID: <20130510151517.4C2C5489AD@hg.openjdk.java.net> Changeset: ce7e1674eb73 Author: alanb Date: 2013-05-10 16:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ce7e1674eb73 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1 Reviewed-by: mchung ! test/tools/javac/profiles/ProfileOptionTest.java From joe.darcy at oracle.com Fri May 10 08:56:31 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 15:56:31 +0000 Subject: hg: jdk8/tl/jdk: 8014249: Add Modifer.parameterModifiers() Message-ID: <20130510155653.EED71489B2@hg.openjdk.java.net> Changeset: ece61e21782d Author: darcy Date: 2013-05-10 08:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ece61e21782d 8014249: Add Modifer.parameterModifiers() Reviewed-by: mduigou, mchung ! src/share/classes/java/lang/reflect/Modifier.java From joe.darcy at oracle.com Fri May 10 09:07:16 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 16:07:16 +0000 Subject: hg: jdk8/tl/jdk: 8014296: DivModTests should not compare pointers Message-ID: <20130510160728.8CBAC489B3@hg.openjdk.java.net> Changeset: c26e0d29249a Author: rriggs Date: 2013-05-10 09:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c26e0d29249a 8014296: DivModTests should not compare pointers Reviewed-by: darcy ! test/java/lang/Math/DivModTests.java From huizhe.wang at oracle.com Fri May 10 09:24:11 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 10 May 2013 16:24:11 +0000 Subject: hg: jdk8/tl/jaxp: 8014333: javadoc error in JAXP 1.5 patch Message-ID: <20130510162417.DA3C9489B5@hg.openjdk.java.net> Changeset: a229726149b4 Author: joehw Date: 2013-05-10 09:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a229726149b4 8014333: javadoc error in JAXP 1.5 patch Reviewed-by: lancea ! src/javax/xml/stream/XMLInputFactory.java From daniel.daugherty at oracle.com Fri May 10 09:49:06 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 10 May 2013 10:49:06 -0600 Subject: RFR 8005056: NPG: Crash after redefining java.lang.Object In-Reply-To: <518BB116.70401@oracle.com> References: <518B0F34.5080101@oracle.com> <518BAADA.1000402@oracle.com> <518BB116.70401@oracle.com> Message-ID: <518D2502.5080809@oracle.com> > open webrev at http://cr.openjdk.java.net/~coleenp/8005056/ Thumbs up. Minor nits/questions below. Very nicely done. Adding a test to retransform java.lang.Object will do a nice job of detecting potential breakages in this area. src/share/vm/classfile/dictionary.cpp No comments. src/share/vm/classfile/dictionary.hpp No comments. src/share/vm/classfile/systemDictionary.cpp No comments. src/share/vm/classfile/systemDictionary.hpp No comments. src/share/vm/oops/klass.hpp No comments. src/share/vm/prims/jvmtiRedefineClasses.cpp line 3547: // print error if old methods are found. We fail a guarantee here also so this is more than "print error". line 3551 } else { Indent is off by one space (not your change, but...) src/share/vm/prims/jvmtiRedefineClasses.hpp No comments. test/testlibrary/ClassFileInstaller.java line 43: String pathName = arg.replace('.', '/').concat(".class"); line 48: if (pathName.contains("/")) { Should these be System.getProperty("path.separator")? Or maybe this is something already queried and cached in this testing harness? test/runtime/RedefineObject/Agent.java line 56: for (int i = 0; i< 1000 ; i++) { Space before '<'. test/runtime/RedefineObject/MANIFEST.MF No comments (agree with Christian that this can be deleted) test/runtime/RedefineObject/Test.java No comments (agree with Christian that this should be renamed). Dan On 5/9/13 8:22 AM, Coleen Phillimore wrote: > > Dan, > > Thank you for adding serviceability. I'll provide more detail on the > change if needed. Here's some additional detail. > > What I did was added a closure to pass to > ClassLoaderDataGraph::classes_do() function. This function walks all > the loaded classes, which includes the array classes. The > SystemDicitonary walk only walks loaded InstanceKlasses. The array > classes created are linked from the InstanceKlass in _array_klasses > and the code used to walk them separately. The code for switching to > the new methods from the old methods didn't change very much. > > The reason we have to change the vtables in array classes is because > array classes are inherited from java/lang/Object class and have this > vtable. We had missed the ones for arrays of basic types created in > universe. The old code never fixed these entries but it didn't crash > because the methodOops were followed with the basic type array classes > in their vtable so wouldn't go away. With permgen removal, we > explicitly delete unreferenced Method objects so these ones have to be > replaced. And it's more correct because you don't want to call the > old Method. > > Coleen > > On 05/09/2013 09:55 AM, Daniel D. Daugherty wrote: >> Adding Serviceability to this review thread since this concerns >> JVM/TI RedefineClasses(). >> >> Coleen, this will take a bit of time to review. >> >> Dan >> >> >> On 5/8/13 8:51 PM, Coleen Phillimore wrote: >>> Summary: Need to walk array class vtables replacing old methods too >>> if j.l.o is redefined >>> >>> Array methods aren't in the SystemDictionary and the code that was >>> there didn't walk the basic type array classes defined in >>> universe. It also walked the same classes more than once. Use the >>> ClassLoaderDataGraph class walking instead. >>> >>> open webrev at http://cr.openjdk.java.net/~coleenp/8005056/ >>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8005056 >>> >>> Tested with all redefine classes tests, jdk java/lang/instrument >>> tests, hotspot jtreg tests. >>> >>> Thanks, >>> Coleen >>> >> > From mike.duigou at oracle.com Fri May 10 10:13:33 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 10 May 2013 17:13:33 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130510171357.D0F0C489D3@hg.openjdk.java.net> Changeset: 2490769abdfa Author: mduigou Date: 2013-05-10 09:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2490769abdfa 8014316: Use Method Refs in j.u.stream.MatchOps Reviewed-by: dholmes ! src/share/classes/java/util/stream/MatchOps.java Changeset: 9891e4d7d5b3 Author: mduigou Date: 2013-05-10 10:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9891e4d7d5b3 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java From joe.darcy at oracle.com Fri May 10 12:25:50 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 19:25:50 +0000 Subject: hg: jdk8/tl/jdk: 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.* Message-ID: <20130510192612.8D50F489E7@hg.openjdk.java.net> Changeset: f84b5498b2bb Author: darcy Date: 2013-05-10 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f84b5498b2bb 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.* Reviewed-by: mchung ! src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java From joe.darcy at oracle.com Fri May 10 14:32:00 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 21:32:00 +0000 Subject: hg: jdk8/tl/langtools: 8014365: Restore Objects.requireNonNull(T, Supplier) Message-ID: <20130510213206.719BD489F4@hg.openjdk.java.net> Changeset: 1c43236f6d69 Author: darcy Date: 2013-05-10 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1c43236f6d69 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: jjg ! makefiles/BuildLangtools.gmk From dmitry.degrave at oracle.com Sun May 12 07:54:37 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Sun, 12 May 2013 14:54:37 +0000 Subject: hg: jdk8/tl/jdk: 7021870: GzipInputStream closes underlying stream during reading Message-ID: <20130512145515.EF53A48A18@hg.openjdk.java.net> Changeset: 90f715cceaae Author: dmeetry Date: 2013-05-10 23:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90f715cceaae 7021870: GzipInputStream closes underlying stream during reading Reviewed-by: mduigou Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/java/util/zip/GZIPInputStream.java + test/java/util/zip/GZIP/GZIPInZip.java From jonathan.gibbons at oracle.com Sun May 12 18:19:58 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 13 May 2013 01:19:58 +0000 Subject: hg: jdk8/tl/langtools: 8014363: javac test class ToolTester handles classpath incorrectly Message-ID: <20130513012005.3FE4948A1E@hg.openjdk.java.net> Changeset: e39669aea0bd Author: jjg Date: 2013-05-12 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39669aea0bd 8014363: javac test class ToolTester handles classpath incorrectly Reviewed-by: ksrini ! test/tools/javac/api/6406133/T6406133.java ! test/tools/javac/api/6410643/T6410643.java ! test/tools/javac/api/6411310/T6411310.java ! test/tools/javac/api/6411333/T6411333.java ! test/tools/javac/api/6412656/T6412656.java ! test/tools/javac/api/6415780/T6415780.java ! test/tools/javac/api/6418694/T6418694.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6421756/T6421756.java ! test/tools/javac/api/6422215/T6422215.java ! test/tools/javac/api/6422327/T6422327.java ! test/tools/javac/api/6423003/T6423003.java ! test/tools/javac/api/6431257/T6431257.java ! test/tools/javac/api/6437349/T6437349.java ! test/tools/javac/api/6437999/T6437999.java ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/6440528/T6440528.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/6731573/T6731573.java ! test/tools/javac/api/6733837/T6733837.java ! test/tools/javac/api/TestJavacTaskScanner.java ! test/tools/javac/api/guide/Test.java ! test/tools/javac/api/lib/ToolTester.java From xuelei.fan at oracle.com Mon May 13 05:43:32 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 13 May 2013 12:43:32 +0000 Subject: hg: jdk8/tl/jdk: 8005535: SSLSessionImpl should have protected finalize() Message-ID: <20130513124354.6003748A28@hg.openjdk.java.net> Changeset: 76998d11a643 Author: xuelei Date: 2013-05-13 05:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76998d11a643 8005535: SSLSessionImpl should have protected finalize() Reviewed-by: weijun, wetmore ! src/share/classes/sun/security/ssl/SSLSessionImpl.java From markus.gronlund at oracle.com Mon May 13 05:51:27 2013 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Mon, 13 May 2013 05:51:27 -0700 (PDT) Subject: RFR(XXS): 8014411: Decrease lock order rank for event tracing locks - HS24 Message-ID: <4a6db571-33d5-493d-9a64-4379bfd8a404@default> Greetings, ? Kindly asking for reviews for this very small change for putback to HS24. ? Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014411 ? Webrev: http://cr.openjdk.java.net/~mgronlun/8014411/webrev01/ ? ? Thanks Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130513/d778534e/attachment.html From xuelei.fan at oracle.com Mon May 13 06:07:03 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 13 May 2013 13:07:03 +0000 Subject: hg: jdk8/tl/jdk: 8005598: (reopened) Need to clone array of input/output parameters Message-ID: <20130513130715.CBCE148A2C@hg.openjdk.java.net> Changeset: 46db0e633240 Author: xuelei Date: 2013-05-13 06:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46db0e633240 8005598: (reopened) Need to clone array of input/output parameters Reviewed-by: weijun ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java From nils.loodin at oracle.com Mon May 13 06:36:08 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 13 May 2013 15:36:08 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link Message-ID: <5190EC48.1000202@oracle.com> Simple change of link in resource files: https://jbs.oracle.com/bugs/browse/JDK-8014048 Regards, Nils Loodin From nils.loodin at oracle.com Mon May 13 06:36:50 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 13 May 2013 15:36:50 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <5190EC48.1000202@oracle.com> References: <5190EC48.1000202@oracle.com> Message-ID: <5190EC72.1070207@oracle.com> On 05/13/2013 03:36 PM, Nils Loodin wrote: > Simple change of link in resource files: > > https://jbs.oracle.com/bugs/browse/JDK-8014048 > > Regards, > Nils Loodin Also, with webrev link (might come in handy): http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ From peter.allwin at oracle.com Mon May 13 07:06:18 2013 From: peter.allwin at oracle.com (Peter Allwin) Date: Mon, 13 May 2013 16:06:18 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <5190EC72.1070207@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> Message-ID: <5190F35A.3080001@oracle.com> Looks good! /peter > ------------------------------------------------------------------------ > > Nils Loodin > Monday, May 13, 2013 3:36 PM > > > > > > Also, with webrev link (might come in handy): > http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ > ------------------------------------------------------------------------ > > Nils Loodin > Monday, May 13, 2013 3:36 PM > > > Simple change of link in resource files: > > https://jbs.oracle.com/bugs/browse/JDK-8014048 > > Regards, > Nils Loodin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130513/0594a4f5/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130513/0594a4f5/compose-unknown-contact.jpg From serguei.spitsyn at oracle.com Mon May 13 09:50:30 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 13 May 2013 09:50:30 -0700 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <5190EC72.1070207@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> Message-ID: <519119D6.2020302@oracle.com> It looks good. Thank you for doing this! Should the bug's "Affects Version's" field also include 6u45? Thanks, Serguei On 5/13/13 6:36 AM, Nils Loodin wrote: > On 05/13/2013 03:36 PM, Nils Loodin wrote: >> Simple change of link in resource files: >> >> https://jbs.oracle.com/bugs/browse/JDK-8014048 >> >> Regards, >> Nils Loodin > > > Also, with webrev link (might come in handy): > http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ From sundararajan.athijegannathan at oracle.com Mon May 13 10:13:06 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 13 May 2013 17:13:06 +0000 Subject: hg: jdk8/tl/jdk: 8012975: Remove rhino from jdk8 Message-ID: <20130513171327.CD6EB48A31@hg.openjdk.java.net> Changeset: 536678dffa97 Author: sundar Date: 2013-05-13 22:23 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/536678dffa97 8012975: Remove rhino from jdk8 Reviewed-by: alanb, tbell ! make/com/sun/Makefile - make/com/sun/script/Makefile ! make/sun/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile ! make/tools/src/build/tools/deps/refs.allowed ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/profile-rtjar-includes.txt - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java From rickard.backman at oracle.com Mon May 13 10:57:36 2013 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Mon, 13 May 2013 17:57:36 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 20 new changesets Message-ID: <20130513175824.81C9648A32@hg.openjdk.java.net> Changeset: e60b3fce2b02 Author: jiangli Date: 2013-05-06 19:57 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e60b3fce2b02 8013067: Zero builds are broken after 8010862. Summary: Fixed broken Zero build. Reviewed-by: twisti, coleenp, kvn ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/method.hpp Changeset: 27d2d456cd96 Author: jiangli Date: 2013-05-06 20:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/27d2d456cd96 Merge Changeset: 6b388e7d4905 Author: bpittore Date: 2013-05-07 10:19 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b388e7d4905 8013633: Cleanup platform ifdefs in unsafe.cpp Summary: Replace ifdefs with SUPPORTS_NATIVE_CX8 set in platform include file Reviewed-by: dholmes, dlong ! src/cpu/sparc/vm/globalDefinitions_sparc.hpp ! src/cpu/x86/vm/globalDefinitions_x86.hpp ! src/share/vm/prims/unsafe.cpp Changeset: a258a8351528 Author: vladidan Date: 2013-05-07 10:36 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a258a8351528 Merge - agent/doc/c2replay.html Changeset: d3c98423c146 Author: jiangli Date: 2013-05-09 16:27 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d3c98423c146 Merge Changeset: 1d0fba8a2a6d Author: brutisso Date: 2013-05-02 22:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1d0fba8a2a6d 8013574: PrintMalloc conflicts with the command line parsing Summary: Make sure that _num_jvm_args is not updated until the new entry to _jvm_args_array has been added Reviewed-by: johnc, tamao, tschatzl ! src/share/vm/runtime/arguments.cpp Changeset: f14063dcd52a Author: brutisso Date: 2013-05-06 09:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f14063dcd52a 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment Summary: Make sure max alignemnt is at least as large as min alignment Reviewed-by: johnc, jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp + test/gc/g1/TestRegionAlignment.java Changeset: 30860066ae8f Author: jwilhelm Date: 2013-05-06 13:03 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/30860066ae8f Merge ! src/share/vm/runtime/arguments.cpp Changeset: d17700c82d7d Author: tschatzl Date: 2013-05-06 17:19 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d17700c82d7d 8006088: Incompatible heap size flags accepted by VM Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing. Reviewed-by: johnc, jwilhelm, tamao ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: b0d20fa374b4 Author: brutisso Date: 2013-05-06 21:30 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b0d20fa374b4 8013872: G1: HeapRegionSeq::shrink_by() has invalid assert Summary: Refactored shrink_by() to only use region counts and not byte sizes Reviewed-by: johnc, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp + test/gc/g1/TestShrinkToOneRegion.java Changeset: a9d568b7df60 Author: jmasa Date: 2013-05-08 16:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a9d568b7df60 8013032: CMS: assert(used() == used_after_gc && used_after_gc <= capacity()) failed: used: 0 used_after_gc: 292080 capacity: 1431699456 Reviewed-by: tschatzl, mgerdin, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java Changeset: 06ab37f08701 Author: jmasa Date: 2013-05-08 17:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/06ab37f08701 8013184: CMS: Call reset_after_compaction() only if a compaction has been done Reviewed-by: mgerdin, johnc, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp + test/gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java Changeset: 923ac8d1df95 Author: jwilhelm Date: 2013-05-09 12:23 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/923ac8d1df95 Merge Changeset: 194f52aa2f23 Author: johnc Date: 2013-05-09 11:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/194f52aa2f23 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap Summary: Refactor G1's hot card cache and card counts table into their own files. Simplify the card counts table, including removing the encoding of the card index in each entry. The card counts table now has a 1:1 correspondence with the cards spanned by heap. Space for the card counts table is reserved from virtual memory (rather than C heap) during JVM startup and is committed/expanded when the heap is expanded. Changes were also reviewed-by Vitaly Davidovich. Reviewed-by: tschatzl, jmasa ! make/excludeSrc.make ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp + src/share/vm/gc_implementation/g1/g1CardCounts.cpp + src/share/vm/gc_implementation/g1/g1CardCounts.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp + src/share/vm/gc_implementation/g1/g1HotCardCache.cpp + src/share/vm/gc_implementation/g1/g1HotCardCache.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 73652d89e7c4 Author: stefank Date: 2013-05-10 09:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/73652d89e7c4 Merge Changeset: 7d56b68a9672 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7d56b68a9672 Added tag jdk8-b89 for changeset 9c1fe0b419b4 ! .hgtags Changeset: 69494caf5790 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/69494caf5790 Merge Changeset: 1ae0472ff3a0 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1ae0472ff3a0 Added tag hs25-b32 for changeset 69494caf5790 ! .hgtags Changeset: 6114c49b31b5 Author: amurillo Date: 2013-05-10 11:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6114c49b31b5 8014279: new hotspot build - hs25-b33 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 735c995bf1a1 Author: rbackman Date: 2013-05-13 07:53 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/735c995bf1a1 Merge ! src/share/vm/runtime/arguments.cpp From yumin.qi at oracle.com Mon May 13 12:22:42 2013 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Mon, 13 May 2013 19:22:42 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets Message-ID: <20130513192248.A438448A35@hg.openjdk.java.net> Changeset: 92ef81e2f571 Author: minqi Date: 2013-05-10 08:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/92ef81e2f571 8003557: NPG: Klass* const k should be const Klass* k. Summary: With NPG, const KlassOop klass which is in fact a definition converted to Klass* const, which is not the original intention. The right usage is converting them to const Klass*. Reviewed-by: coleenp, kvn Contributed-by: yumin.qi at oracle.com ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 1fcfc045b229 Author: minqi Date: 2013-05-10 19:30 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1fcfc045b229 Merge Changeset: 8b40495b9381 Author: minqi Date: 2013-05-13 18:08 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8b40495b9381 Merge ! src/share/vm/oops/method.hpp From jaroslav.bachorik at oracle.com Mon May 13 13:27:47 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 13 May 2013 22:27:47 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <5190EC72.1070207@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> Message-ID: <51914CC3.8080607@oracle.com> Fine with me (-not a reviewer-) -JB- On 05/13/2013 03:36 PM, Nils Loodin wrote: > On 05/13/2013 03:36 PM, Nils Loodin wrote: >> Simple change of link in resource files: >> >> https://jbs.oracle.com/bugs/browse/JDK-8014048 >> >> Regards, >> Nils Loodin > > > Also, with webrev link (might come in handy): > http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ From mike.duigou at oracle.com Mon May 13 13:29:10 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Mon, 13 May 2013 20:29:10 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130513202933.B2B9C48A3A@hg.openjdk.java.net> Changeset: 6175fe5b07aa Author: bharadwaj Date: 2013-05-13 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6175fe5b07aa 8008687: MethodHandle code: allow static and invokespecial calls to interface methods Summary: Changes to support invocation of lambda methods compiled either as static interface methods and or private instance methods. Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/MemberName.java Changeset: f7fcfb204a69 Author: mduigou Date: 2013-05-13 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fcfb204a69 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java From kurchi.subhra.hazra at oracle.com Mon May 13 13:38:48 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Mon, 13 May 2013 20:38:48 +0000 Subject: hg: jdk8/tl/jdk: 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive Message-ID: <20130513203900.39ACD48A3B@hg.openjdk.java.net> Changeset: 86c1e8c799f5 Author: khazra Date: 2013-05-13 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c1e8c799f5 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive Summary: Rearrange event-handling code to remove bottle-neck. Also reviewed by mhall at mhcomputing.net. Reviewed-by: chegar, alanb ! src/share/classes/sun/net/httpserver/ServerImpl.java From staffan.larsen at oracle.com Mon May 13 13:50:29 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 13 May 2013 22:50:29 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <5190EC72.1070207@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> Message-ID: <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> Shouldn't the link be to the oracle site that the sun site redirects to: http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html /Staffan On 13 maj 2013, at 15:36, Nils Loodin wrote: > On 05/13/2013 03:36 PM, Nils Loodin wrote: >> Simple change of link in resource files: >> >> https://jbs.oracle.com/bugs/browse/JDK-8014048 >> >> Regards, >> Nils Loodin > > > Also, with webrev link (might come in handy): > http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ From staffan.larsen at oracle.com Mon May 13 13:52:26 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 13 May 2013 22:52:26 +0200 Subject: RFR(XXS): 8014411: Decrease lock order rank for event tracing locks - HS24 In-Reply-To: <4a6db571-33d5-493d-9a64-4379bfd8a404@default> References: <4a6db571-33d5-493d-9a64-4379bfd8a404@default> Message-ID: Looks good to me! /Staffan On 13 maj 2013, at 14:51, Markus Gr?nlund wrote: > Greetings, > > Kindly asking for reviews for this very small change for putback to HS24. > > Bugid: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014411 > > Webrev: > http://cr.openjdk.java.net/~mgronlun/8014411/webrev01/ > > > Thanks > Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130513/7cb02d81/attachment.html From jonathan.gibbons at oracle.com Mon May 13 15:29:30 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 13 May 2013 22:29:30 +0000 Subject: hg: jdk8/tl/langtools: 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Message-ID: <20130513222934.CF4D748A3E@hg.openjdk.java.net> Changeset: 8dd528992c15 Author: jlahoda Date: 2013-05-10 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8dd528992c15 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Reviewed-by: jjg Contributed-by: Dusan Balek , Jan Lahoda ! src/share/classes/com/sun/tools/doclint/Env.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/api/TestGetElementReference.java + test/tools/javac/api/TestGetElementReferenceData.java From mandy.chung at oracle.com Mon May 13 16:28:57 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 13 May 2013 16:28:57 -0700 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> Message-ID: <51917739.1020200@oracle.com> On 5/13/13 1:50 PM, Staffan Larsen wrote: > Shouldn't the link be to the oracle site that the sun site redirects to: > > http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html Can you take it further to construct the link with the release version of the JRE: http://docs.oracle.com/javase/${RELEASE}/docs/technotes/guides/management/jconsole.html For jdk8, it should be "8". Mandy > /Staffan > > On 13 maj 2013, at 15:36, Nils Loodin wrote: > >> On 05/13/2013 03:36 PM, Nils Loodin wrote: >>> Simple change of link in resource files: >>> >>> https://jbs.oracle.com/bugs/browse/JDK-8014048 >>> >>> Regards, >>> Nils Loodin >> >> Also, with webrev link (might come in handy): >> http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ From coleen.phillimore at oracle.com Mon May 13 18:48:22 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 14 May 2013 01:48:22 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8005056: NPG: Crash after redefining java.lang.Object Message-ID: <20130514014837.5509448A48@hg.openjdk.java.net> Changeset: 43083e670adf Author: coleenp Date: 2013-05-13 15:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/43083e670adf 8005056: NPG: Crash after redefining java.lang.Object Summary: Need to walk array class vtables replacing old methods too if j.l.o redefined Reviewed-by: sspitsyn, dcubed, ctornqvi ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp + test/runtime/RedefineObject/Agent.java + test/runtime/RedefineObject/TestRedefineObject.java ! test/testlibrary/ClassFileInstaller.java From david.holmes at oracle.com Mon May 13 19:01:42 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 14 May 2013 12:01:42 +1000 Subject: RFR(XXS): 8014411: Decrease lock order rank for event tracing locks - HS24 In-Reply-To: <4a6db571-33d5-493d-9a64-4379bfd8a404@default> References: <4a6db571-33d5-493d-9a64-4379bfd8a404@default> Message-ID: <51919B06.2070504@oracle.com> On 13/05/2013 10:51 PM, Markus Gr?nlund wrote: > Greetings, > > Kindly asking for reviews for this very small change for putback to HS24. > > Bugid: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014411 > > Webrev: > > http://cr.openjdk.java.net/~mgronlun/8014411/webrev01/ Syntax is fine. As for semantics ... only testing will tell. David > Thanks > > Markus > From david.holmes at oracle.com Mon May 13 19:05:43 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 14 May 2013 12:05:43 +1000 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> Message-ID: <51919BF7.10408@oracle.com> On 14/05/2013 6:50 AM, Staffan Larsen wrote: > Shouldn't the link be to the oracle site that the sun site redirects to: > > http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html My thoughts exactly. :) Also a pity the URL has to be repeated so often, but that's not caused by this fix :) David > /Staffan > > On 13 maj 2013, at 15:36, Nils Loodin wrote: > >> On 05/13/2013 03:36 PM, Nils Loodin wrote: >>> Simple change of link in resource files: >>> >>> https://jbs.oracle.com/bugs/browse/JDK-8014048 >>> >>> Regards, >>> Nils Loodin >> >> >> Also, with webrev link (might come in handy): >> http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ > From xueming.shen at oracle.com Mon May 13 20:37:16 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 14 May 2013 03:37:16 +0000 Subject: hg: jdk8/tl/jdk: 8013386: (tz) Support tzdata2013c Message-ID: <20130514033738.288CA48A4A@hg.openjdk.java.net> Changeset: ae35fdbab949 Author: sherman Date: 2013-05-13 20:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae35fdbab949 8013386: (tz) Support tzdata2013c Summary: updated tz data to version 2013c Reviewed-by: peytoia, okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/Rule.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/zone.tab From joe.darcy at oracle.com Mon May 13 22:17:06 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 14 May 2013 05:17:06 +0000 Subject: hg: jdk8/tl/jdk: 8014365: Restore Objects.requireNonNull(T, Supplier) Message-ID: <20130514051719.2348548A4D@hg.openjdk.java.net> Changeset: a50bad038f31 Author: darcy Date: 2013-05-13 22:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50bad038f31 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: mduigou ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java From rickard.backman at oracle.com Mon May 13 22:35:13 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 14 May 2013 07:35:13 +0200 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> <51899F46.1090800@oracle.com> <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> Message-ID: <8A3A209E-714B-4976-8A21-7AB0C2B69B85@oracle.com> Yunda, sorry for taking a while. I created JDK-8014478 for this and I'll sponsor the change. /R On May 10, 2013, at 4:32 AM, ??(Yunda) wrote: > Thanks for looking at this, Rickard. David, do you like this option which is easier to read, too :) > > > Regards, > Yunda > >> -----Original Message----- >> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] >> Sent: Thursday, May 09, 2013 4:53 PM >> To: ??(Yunda) >> Cc: David Holmes; serviceability-dev at openjdk.java.net; >> hotspot-runtime-dev at openjdk.java.net >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed >> together >> >> Looks good to me! >> >> /R >> >> On May 9, 2013, at 8:38 AM, ??(Yunda) wrote: >> >>> Rickard, >>> >>> Actually I've considered the option and I just thought it's less elegant. But just >> as you said, it's clearer and easier to read. The updated and tested change: >>> >>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 -0700 >>> +++ b/src/share/vm/runtime/globals.hpp Thu May 09 14:36:35 2013 +0800 >>> @@ -3634,7 +3634,10 @@ >>> "Include GC cause in GC logging") >> \ >>> >> \ >>> product(bool, EnableTracing, false, >> \ >>> - "Enable event-based tracing") >>> + "Enable event-based tracing") >> \ >>> + >> \ >>> + product(bool, UseLockedTracing, false, >> \ >>> + "Use locked-tracing when doing event-based >>> + tracing") >>> >>> /* >>> * Macros for factoring of globals >>> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl >>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>> 2013 -0700 >>> +++ b/src/share/vm/trace/traceEventClasses.xsl Thu May 09 14:36:35 >>> +++ 2013 +0800 >>> @@ -132,6 +132,15 @@ >>> void writeEvent(void) { >>> ResourceMark rm; >>> HandleMark hm; >>> + if (UseLockedTracing) { >>> + ttyLocker lock; >>> + writeEventContent(); >>> + } else { >>> + writeEventContent(); >>> + } >>> + } >>> + >>> + void writeEventContent() { >>> TraceStream ts(*tty); >>> ts.print(": ["); >>> >>> >>> >>> Regards, >>> Yunda >>> >>>> -----Original Message----- >>>> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] >>>> Sent: Wednesday, May 08, 2013 3:03 PM >>>> To: David Holmes >>>> Cc: ??(Yunda); serviceability-dev at openjdk.java.net; >>>> hotspot-runtime-dev at openjdk.java.net >>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads may >>>> be mixed together >>>> >>>> One option could be to move the content of writeEvent() to its own >>>> method (maybe writeEventContent()) and just do >>>> >>>> if (UseLockedTracing) { >>>> ttyLocker lock; >>>> writeEventContent(); >>>> } else { >>>> writeEventContent(); >>>> } >>>> >>>> I think it makes it easier to read. >>>> >>>> /R >>>> >>>> On May 8, 2013, at 2:41 AM, David Holmes wrote: >>>> >>>>> On 7/05/2013 10:33 PM, ??(Yunda) wrote: >>>>>> David, >>>>>> >>>>>> Sorry about the stupid mistake. And please see the tested change below. >>>> Since I don't find an elegant way to define a ttyLocker object, I use >>>> the static methods of ttyLocker instead. >>>>> >>>>> Yeah there's no elegant solution when you need to conditionalize >>>>> things. :( >>>>> >>>>> This looks fine to me but the serviceability folk should chime back in. >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 >>>>>> -0700 >>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 >>>>>> +++ +0800 >>>>>> @@ -3634,7 +3634,10 @@ >>>>>> "Include GC cause in GC logging") >>>> \ >>>>>> >>>> \ >>>>>> product(bool, EnableTracing, false, >>>> \ >>>>>> - "Enable event-based tracing") >>>>>> + "Enable event-based tracing") >>>> \ >>>>>> + >>>> \ >>>>>> + product(bool, UseLockedTracing, false, >>>> \ >>>>>> + "Use locked-tracing when doing event-based >>>>>> + tracing") >>>>>> >>>>>> /* >>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 >>>>>> src/share/vm/trace/traceEventClasses.xsl >>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 >>>>>> 2013 -0700 >>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 20:04:24 >>>>>> +++ 2013 +0800 >>>>>> @@ -132,10 +132,17 @@ >>>>>> void writeEvent(void) { >>>>>> ResourceMark rm; >>>>>> HandleMark hm; >>>>>> + int holder; >>>>>> + if (UseLockedTracing) { >>>>>> + holder = ttyLocker::hold_tty(); >>>>>> + } >>>>>> TraceStream ts(*tty); >>>>>> ts.print(": ["); >>>>>> >>>>>> ts.print("]\n"); >>>>>> + if (UseLockedTracing) { >>>>>> + ttyLocker::release_tty(holder); >>>>>> + } >>>>>> } >>>>>> }; >>>>>> >>>>>> >>>>>> Regards, >>>>>> Yunda >>>>>> >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>>>>> Sent: Tuesday, May 07, 2013 5:50 PM >>>>>>> To: ??(Yunda) >>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>>>>> serviceability-dev at openjdk.java.net >>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads >>>>>>> may be mixed together >>>>>>> >>>>>>> On 7/05/2013 7:43 PM, ??(Yunda) wrote: >>>>>>>> Hi David, >>>>>>>> >>>>>>>> Thanks for the review and I see your concern. Please see the >>>>>>>> updated change >>>>>>> below: >>>>>>>> >>>>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp >>>>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 >>>>>>>> -0700 >>>>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 2013 >>>>>>>> +++ +0800 >>>>>>>> @@ -3634,7 +3634,10 @@ >>>>>>>> "Include GC cause in GC logging") >>>>>>> \ >>>>>>>> >>>>>>> \ >>>>>>>> product(bool, EnableTracing, false, >>>>>>> \ >>>>>>>> - "Enable event-based tracing") >>>>>>>> + "Enable event-based tracing") >>>>>>> \ >>>>>>>> + >>>>>>> \ >>>>>>>> + product(bool, UseLockedTracing, false, >>>>>>> \ >>>>>>>> + "Use locked-tracing when doing event-based >>>>>>>> + tracing") >>>>>>>> >>>>>>>> /* >>>>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 >>>>>>>> src/share/vm/trace/traceEventClasses.xsl >>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 >>>>>>>> 10:29:49 >>>>>>>> 2013 -0700 >>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 >>>>>>>> +++ 17:38:58 >>>>>>>> +++ 2013 +0800 >>>>>>>> @@ -132,6 +132,9 @@ >>>>>>>> void writeEvent(void) { >>>>>>>> ResourceMark rm; >>>>>>>> HandleMark hm; >>>>>>>> + if (UseLockedTracing) { >>>>>>>> + ttyLocker ttyl; >>>>>>>> + } >>>>>>> >>>>>>> Ah that doesn't work - the ttyLocker is block-scoped by the if >>>>>>> statement so it will be created, grab the lock, then immediately >>>>>>> be destructed and the lock released. >>>>>>> >>>>>>> David >>>>>>> ----- >>>>>>> >>>>>>>> TraceStream ts(*tty); >>>>>>>> ts.print(": ["); >>>>>>>> >>>>>>> mode="write-data"/> >>>>>>>> >>>>>>>> Regards, >>>>>>>> Yunda >>>>>>>> >>>>>>>>> -----Original Message----- >>>>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] >>>>>>>>> Sent: Tuesday, May 07, 2013 10:39 AM >>>>>>>>> To: ??(Yunda) >>>>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; >>>>>>>>> serviceability-dev at openjdk.java.net >>>>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads >>>>>>>>> may be mixed together >>>>>>>>> >>>>>>>>> Hi Yunda, >>>>>>>>> >>>>>>>>> There is a potential problem with using a ttyLocker here, >>>>>>>>> depending on exactly what events are being traced and from where >>>>>>>>> - you must always be in code where it is both safe to acquire >>>>>>>>> the lock, and safe to block waiting for the lock if it is not available. >>>>>>>>> >>>>>>>>> I think I would prefer to see unlocked tracing by default with a >>>>>>>>> flag to use locked-tracing if requested. >>>>>>>>> >>>>>>>>> David >>>>>>>>> >>>>>>>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> I found that the output from multiple threads may be mixed >>>>>>>>>> together when using EnableTracing. It happens many times in my >>>>>>>>>> test >>>> case like this: >>>>>>>>>> >>>>>>>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation >>>>>>>>>> in new >>>>>>>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: >>>>>>>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: [Class >>>>>>>>>> = java/lang/String, Allocation Size = 24, Allocation Size = 24, >>>>>>>>>> Class = java/lang/String, Class = [I, Allocation in new TLAB: >>>>>>>>>> [Class = [C, Allocation in new TLAB: [Allocation Size = 192] >>>>>>>>>> >>>>>>>>>> Class = >>>>>>>>>> com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, >>>>>>>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = >>>>>>>>>> 23712280] >>>>>>>>>> >>>>>>>>>> TLAB Size = 24607080] >>>>>>>>>> >>>>>>>>>> Allocation Size = 24, Monitor Class = >>>>>>>>>> java/lang/ref/Reference$Lock, TLAB Size = 25054480] >>>>>>>>>> >>>>>>>>>> TLAB Size = 25054480] >>>>>>>>>> >>>>>>>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] >>>>>>>>>> >>>>>>>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] >>>>>>>>>> >>>>>>>>>> , Allocation Size = 32, TLAB Size = 23712288] >>>>>>>>>> >>>>>>>>>> It's very confusing and it's even not easy to tell how many >>>>>>>>>> events there are. I think the reason is that the writeEvent() >>>>>>>>>> method of each >>>>>>>>>> Event* class output the fields of event one by one without >>>>>>>>>> using any lock. So I made a small patch which add ttyLocker to >>>>>>>>>> writeEvent() method and after applying this patch there's no >>>>>>>>>> output mixed together in my test case(against >>>>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): >>>>>>>>>> >>>>>>>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl >>>>>>>>>> >>>>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 >>>> 13:50:58 >>>>>>>>>> 2013 -0700 >>>>>>>>>> >>>>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 >>>>>>>>>> +++ 16:12:38 >>>>>>>>>> +++ 2013 >>>>>>>>>> +0800 >>>>>>>>>> >>>>>>>>>> @@ -132,6 +132,7 @@ >>>>>>>>>> >>>>>>>>>> void writeEvent(void) { >>>>>>>>>> >>>>>>>>>> ResourceMark rm; >>>>>>>>>> >>>>>>>>>> HandleMark hm; >>>>>>>>>> >>>>>>>>>> + ttyLocker ttyl; >>>>>>>>>> >>>>>>>>>> TraceStream ts(*tty); >>>>>>>>>> >>>>>>>>>> ts.print(": ["); >>>>>>>>>> >>>>>>>>>> >>>>>>>>> mode="write-data"/> >>>>>>>>>> >>>>>>>>>> I searched before sending this mail I didn't find anyone who >>>>>>>>>> covering thisJ >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> >>>>>>>>>> Yunda >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> --------------------------------------------------------------- >>>>>>>>>> -- >>>>>>>>>> --- >>>>>>>>>> -- >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> This email (including any attachments) is confidential and may >>>>>>>>>> be legally privileged. If you received this email in error, >>>>>>>>>> please delete it immediately and do not copy it or use it for >>>>>>>>>> any purpose or disclose its contents to any other person. Thank you. >>>>>>>>>> >>>>>>>>>> ???(??????)?????????????????? >> ? >>>> ?? >>>>>>> ? >>>>>>>>> ???? >>>>>>>>>> ???????????????????????????? >> ? >>>> ?? >>>>>>>>> ????? >>>>>>>>>> ???????? >>>>>>>> >>>>>>>> ________________________________ >>>>>>>> >>>>>>>> This email (including any attachments) is confidential and may be >>>>>>>> legally >>>>>>> privileged. If you received this email in error, please delete it >>>>>>> immediately and do not copy it or use it for any purpose or >>>>>>> disclose its contents to any other person. Thank you. >>>>>>> >>>>>>>> >>>>>>>> ???(??????)??????????????????? >> ? >>>> ?? >>>>>>> ????????????????????????????? >> ? >>>> ?? >>>>>>> ????? >>>>>>>> ??????????? >>>>>>>> >>>>>> >>>>>> ________________________________ >>>>>> >>>>>> This email (including any attachments) is confidential and may be >>>>>> legally >>>> privileged. If you received this email in error, please delete it >>>> immediately and do not copy it or use it for any purpose or disclose >>>> its contents to any other person. Thank you. >>>>>> >>>>>> ???(??????)???????????????????? >> ? >>>> ??????????????????????????????? >> ? >>>> ????? >>>>>> ???????????? >>>>>> >>> >>> >>> ________________________________ >>> >>> This email (including any attachments) is confidential and may be legally >> privileged. If you received this email in error, please delete it immediately and >> do not copy it or use it for any purpose or disclose its contents to any other >> person. Thank you. >> >>> >>> ???(??????)?????????????????????? >> ???????????????????????????????? >> ????? >>> ??????????? > > > ________________________________ > > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ???(??????)?????????????????????????????????????????????????????????????????????? From yunda.mly at taobao.com Mon May 13 23:15:01 2013 From: yunda.mly at taobao.com (=?utf-8?B?5LqR6L6+KFl1bmRhKQ==?=) Date: Tue, 14 May 2013 06:15:01 +0000 Subject: [PATCH] EnableTracing: output from multiple threads may be mixed together In-Reply-To: <8A3A209E-714B-4976-8A21-7AB0C2B69B85@oracle.com> References: <5188693D.8000304@oracle.com> <5188CE49.3020103@oracle.com> <51899F46.1090800@oracle.com> <0435C539-BE69-4983-BB70-CCEE00BF9B94@oracle.com> <8A3A209E-714B-4976-8A21-7AB0C2B69B85@oracle.com> Message-ID: Rickard, Thank you very much for doing this! Regards, Yunda > -----Original Message----- > From: Rickard B?ckman [mailto:rickard.backman at oracle.com] > Sent: Tuesday, May 14, 2013 1:35 PM > To: ??(Yunda) > Cc: David Holmes; serviceability-dev at openjdk.java.net; > hotspot-runtime-dev at openjdk.java.net > Subject: Re: [PATCH] EnableTracing: output from multiple threads may be mixed > together > > Yunda, > > sorry for taking a while. I created JDK-8014478 for this and I'll sponsor the > change. > > /R > > On May 10, 2013, at 4:32 AM, ??(Yunda) wrote: > > > Thanks for looking at this, Rickard. David, do you like this option > > which is easier to read, too :) > > > > > > Regards, > > Yunda > > > >> -----Original Message----- > >> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] > >> Sent: Thursday, May 09, 2013 4:53 PM > >> To: ??(Yunda) > >> Cc: David Holmes; serviceability-dev at openjdk.java.net; > >> hotspot-runtime-dev at openjdk.java.net > >> Subject: Re: [PATCH] EnableTracing: output from multiple threads may > >> be mixed together > >> > >> Looks good to me! > >> > >> /R > >> > >> On May 9, 2013, at 8:38 AM, ??(Yunda) wrote: > >> > >>> Rickard, > >>> > >>> Actually I've considered the option and I just thought it's less > >>> elegant. But just > >> as you said, it's clearer and easier to read. The updated and tested change: > >>> > >>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > >>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 > >>> -0700 > >>> +++ b/src/share/vm/runtime/globals.hpp Thu May 09 14:36:35 2013 > >>> +++ +0800 > >>> @@ -3634,7 +3634,10 @@ > >>> "Include GC cause in GC logging") > >> \ > >>> > >> \ > >>> product(bool, EnableTracing, false, > >> \ > >>> - "Enable event-based tracing") > >>> + "Enable event-based tracing") > >> \ > >>> + > >> \ > >>> + product(bool, UseLockedTracing, false, > >> \ > >>> + "Use locked-tracing when doing event-based > >>> + tracing") > >>> > >>> /* > >>> * Macros for factoring of globals > >>> diff -r 627cf9e9ea31 src/share/vm/trace/traceEventClasses.xsl > >>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 10:29:49 > >>> 2013 -0700 > >>> +++ b/src/share/vm/trace/traceEventClasses.xsl Thu May 09 14:36:35 > >>> +++ 2013 +0800 > >>> @@ -132,6 +132,15 @@ > >>> void writeEvent(void) { > >>> ResourceMark rm; > >>> HandleMark hm; > >>> + if (UseLockedTracing) { > >>> + ttyLocker lock; > >>> + writeEventContent(); > >>> + } else { > >>> + writeEventContent(); > >>> + } > >>> + } > >>> + > >>> + void writeEventContent() { > >>> TraceStream ts(*tty); > >>> ts.print(": ["); > >>> > >>> > >>> > >>> Regards, > >>> Yunda > >>> > >>>> -----Original Message----- > >>>> From: Rickard B?ckman [mailto:rickard.backman at oracle.com] > >>>> Sent: Wednesday, May 08, 2013 3:03 PM > >>>> To: David Holmes > >>>> Cc: ??(Yunda); serviceability-dev at openjdk.java.net; > >>>> hotspot-runtime-dev at openjdk.java.net > >>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads > >>>> may be mixed together > >>>> > >>>> One option could be to move the content of writeEvent() to its own > >>>> method (maybe writeEventContent()) and just do > >>>> > >>>> if (UseLockedTracing) { > >>>> ttyLocker lock; > >>>> writeEventContent(); > >>>> } else { > >>>> writeEventContent(); > >>>> } > >>>> > >>>> I think it makes it easier to read. > >>>> > >>>> /R > >>>> > >>>> On May 8, 2013, at 2:41 AM, David Holmes wrote: > >>>> > >>>>> On 7/05/2013 10:33 PM, ??(Yunda) wrote: > >>>>>> David, > >>>>>> > >>>>>> Sorry about the stupid mistake. And please see the tested change > below. > >>>> Since I don't find an elegant way to define a ttyLocker object, I > >>>> use the static methods of ttyLocker instead. > >>>>> > >>>>> Yeah there's no elegant solution when you need to conditionalize > >>>>> things. :( > >>>>> > >>>>> This looks fine to me but the serviceability folk should chime back in. > >>>>> > >>>>> Thanks, > >>>>> David > >>>>> > >>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > >>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 2013 > >>>>>> -0700 > >>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 20:04:24 2013 > >>>>>> +++ +0800 > >>>>>> @@ -3634,7 +3634,10 @@ > >>>>>> "Include GC cause in GC logging") > >>>> \ > >>>>>> > >>>> \ > >>>>>> product(bool, EnableTracing, false, > >>>> \ > >>>>>> - "Enable event-based tracing") > >>>>>> + "Enable event-based tracing") > >>>> \ > >>>>>> + > >>>> \ > >>>>>> + product(bool, UseLockedTracing, false, > >>>> \ > >>>>>> + "Use locked-tracing when doing event-based > >>>>>> + tracing") > >>>>>> > >>>>>> /* > >>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 > >>>>>> src/share/vm/trace/traceEventClasses.xsl > >>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 > >>>>>> 10:29:49 > >>>>>> 2013 -0700 > >>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 > >>>>>> +++ 20:04:24 > >>>>>> +++ 2013 +0800 > >>>>>> @@ -132,10 +132,17 @@ > >>>>>> void writeEvent(void) { > >>>>>> ResourceMark rm; > >>>>>> HandleMark hm; > >>>>>> + int holder; > >>>>>> + if (UseLockedTracing) { > >>>>>> + holder = ttyLocker::hold_tty(); > >>>>>> + } > >>>>>> TraceStream ts(*tty); > >>>>>> ts.print(": ["); > >>>>>> > >>>>>> ts.print("]\n"); > >>>>>> + if (UseLockedTracing) { > >>>>>> + ttyLocker::release_tty(holder); > >>>>>> + } > >>>>>> } > >>>>>> }; > >>>>>> > >>>>>> > >>>>>> Regards, > >>>>>> Yunda > >>>>>> > >>>>>> > >>>>>>> -----Original Message----- > >>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] > >>>>>>> Sent: Tuesday, May 07, 2013 5:50 PM > >>>>>>> To: ??(Yunda) > >>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; > >>>>>>> serviceability-dev at openjdk.java.net > >>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple threads > >>>>>>> may be mixed together > >>>>>>> > >>>>>>> On 7/05/2013 7:43 PM, ??(Yunda) wrote: > >>>>>>>> Hi David, > >>>>>>>> > >>>>>>>> Thanks for the review and I see your concern. Please see the > >>>>>>>> updated change > >>>>>>> below: > >>>>>>>> > >>>>>>>> diff -r 627cf9e9ea31 src/share/vm/runtime/globals.hpp > >>>>>>>> --- a/src/share/vm/runtime/globals.hpp Mon May 06 10:29:49 > >>>>>>>> 2013 > >>>>>>>> -0700 > >>>>>>>> +++ b/src/share/vm/runtime/globals.hpp Tue May 07 17:38:58 > >>>>>>>> +++ 2013 > >>>>>>>> +++ +0800 > >>>>>>>> @@ -3634,7 +3634,10 @@ > >>>>>>>> "Include GC cause in GC logging") > >>>>>>> \ > >>>>>>>> > >>>>>>> \ > >>>>>>>> product(bool, EnableTracing, false, > >>>>>>> \ > >>>>>>>> - "Enable event-based tracing") > >>>>>>>> + "Enable event-based tracing") > >>>>>>> \ > >>>>>>>> + > >>>>>>> \ > >>>>>>>> + product(bool, UseLockedTracing, false, > >>>>>>> \ > >>>>>>>> + "Use locked-tracing when doing event-based > >>>>>>>> + tracing") > >>>>>>>> > >>>>>>>> /* > >>>>>>>> * Macros for factoring of globals diff -r 627cf9e9ea31 > >>>>>>>> src/share/vm/trace/traceEventClasses.xsl > >>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Mon May 06 > >>>>>>>> 10:29:49 > >>>>>>>> 2013 -0700 > >>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Tue May 07 > >>>>>>>> +++ 17:38:58 > >>>>>>>> +++ 2013 +0800 > >>>>>>>> @@ -132,6 +132,9 @@ > >>>>>>>> void writeEvent(void) { > >>>>>>>> ResourceMark rm; > >>>>>>>> HandleMark hm; > >>>>>>>> + if (UseLockedTracing) { > >>>>>>>> + ttyLocker ttyl; > >>>>>>>> + } > >>>>>>> > >>>>>>> Ah that doesn't work - the ttyLocker is block-scoped by the if > >>>>>>> statement so it will be created, grab the lock, then immediately > >>>>>>> be destructed and the lock released. > >>>>>>> > >>>>>>> David > >>>>>>> ----- > >>>>>>> > >>>>>>>> TraceStream ts(*tty); > >>>>>>>> ts.print(": ["); > >>>>>>>> >>>>>>>> mode="write-data"/> > >>>>>>>> > >>>>>>>> Regards, > >>>>>>>> Yunda > >>>>>>>> > >>>>>>>>> -----Original Message----- > >>>>>>>>> From: David Holmes [mailto:david.holmes at oracle.com] > >>>>>>>>> Sent: Tuesday, May 07, 2013 10:39 AM > >>>>>>>>> To: ??(Yunda) > >>>>>>>>> Cc: hotspot-runtime-dev at openjdk.java.net; > >>>>>>>>> serviceability-dev at openjdk.java.net > >>>>>>>>> Subject: Re: [PATCH] EnableTracing: output from multiple > >>>>>>>>> threads may be mixed together > >>>>>>>>> > >>>>>>>>> Hi Yunda, > >>>>>>>>> > >>>>>>>>> There is a potential problem with using a ttyLocker here, > >>>>>>>>> depending on exactly what events are being traced and from > >>>>>>>>> where > >>>>>>>>> - you must always be in code where it is both safe to acquire > >>>>>>>>> the lock, and safe to block waiting for the lock if it is not available. > >>>>>>>>> > >>>>>>>>> I think I would prefer to see unlocked tracing by default with > >>>>>>>>> a flag to use locked-tracing if requested. > >>>>>>>>> > >>>>>>>>> David > >>>>>>>>> > >>>>>>>>> On 19/04/2013 6:26 PM, ??(Yunda) wrote: > >>>>>>>>>> Hi all, > >>>>>>>>>> > >>>>>>>>>> I found that the output from multiple threads may be mixed > >>>>>>>>>> together when using EnableTracing. It happens many times in > >>>>>>>>>> my test > >>>> case like this: > >>>>>>>>>> > >>>>>>>>>> Allocation outside TLAB: [Allocation in new TLAB: [Allocation > >>>>>>>>>> in new > >>>>>>>>>> TLAB: [Allocation in new TLAB: [Class = [C, Allocation in new TLAB: > >>>>>>>>>> [Class = [I, Allocation in new TLAB: [Java Monitor Wait: > >>>>>>>>>> [Class = java/lang/String, Allocation Size = 24, Allocation > >>>>>>>>>> Size = 24, Class = java/lang/String, Class = [I, Allocation in new > TLAB: > >>>>>>>>>> [Class = [C, Allocation in new TLAB: [Allocation Size = 192] > >>>>>>>>>> > >>>>>>>>>> Class = > >>>>>>>>>> > com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl, > >>>>>>>>>> Allocation Size = 24, Allocation Size = 24, TLAB Size = > >>>>>>>>>> 23712280] > >>>>>>>>>> > >>>>>>>>>> TLAB Size = 24607080] > >>>>>>>>>> > >>>>>>>>>> Allocation Size = 24, Monitor Class = > >>>>>>>>>> java/lang/ref/Reference$Lock, TLAB Size = 25054480] > >>>>>>>>>> > >>>>>>>>>> TLAB Size = 25054480] > >>>>>>>>>> > >>>>>>>>>> Allocation in new TLAB: [Class = [CTLAB Size = 24607080] > >>>>>>>>>> > >>>>>>>>>> Allocation Size = 72, Class = [C, TLAB Size = 24159728] > >>>>>>>>>> > >>>>>>>>>> , Allocation Size = 32, TLAB Size = 23712288] > >>>>>>>>>> > >>>>>>>>>> It's very confusing and it's even not easy to tell how many > >>>>>>>>>> events there are. I think the reason is that the writeEvent() > >>>>>>>>>> method of each > >>>>>>>>>> Event* class output the fields of event one by one without > >>>>>>>>>> using any lock. So I made a small patch which add ttyLocker > >>>>>>>>>> to > >>>>>>>>>> writeEvent() method and after applying this patch there's no > >>>>>>>>>> output mixed together in my test case(against > >>>>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot/): > >>>>>>>>>> > >>>>>>>>>> diff -r edd1619a3ae4 src/share/vm/trace/traceEventClasses.xsl > >>>>>>>>>> > >>>>>>>>>> --- a/src/share/vm/trace/traceEventClasses.xsl Thu Apr 18 > >>>> 13:50:58 > >>>>>>>>>> 2013 -0700 > >>>>>>>>>> > >>>>>>>>>> +++ b/src/share/vm/trace/traceEventClasses.xsl Fri Apr 19 > >>>>>>>>>> +++ 16:12:38 > >>>>>>>>>> +++ 2013 > >>>>>>>>>> +0800 > >>>>>>>>>> > >>>>>>>>>> @@ -132,6 +132,7 @@ > >>>>>>>>>> > >>>>>>>>>> void writeEvent(void) { > >>>>>>>>>> > >>>>>>>>>> ResourceMark rm; > >>>>>>>>>> > >>>>>>>>>> HandleMark hm; > >>>>>>>>>> > >>>>>>>>>> + ttyLocker ttyl; > >>>>>>>>>> > >>>>>>>>>> TraceStream ts(*tty); > >>>>>>>>>> > >>>>>>>>>> ts.print(": ["); > >>>>>>>>>> > >>>>>>>>>> >>>>>>>>>> mode="write-data"/> > >>>>>>>>>> > >>>>>>>>>> I searched before sending this mail I didn't find anyone who > >>>>>>>>>> covering thisJ > >>>>>>>>>> > >>>>>>>>>> Regards, > >>>>>>>>>> > >>>>>>>>>> Yunda > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> ------------------------------------------------------------- > >>>>>>>>>> -- > >>>>>>>>>> -- > >>>>>>>>>> --- > >>>>>>>>>> -- > >>>>>>>>>> -- > >>>>>>>>>> > >>>>>>>>>> This email (including any attachments) is confidential and > >>>>>>>>>> may be legally privileged. If you received this email in > >>>>>>>>>> error, please delete it immediately and do not copy it or use > >>>>>>>>>> it for any purpose or disclose its contents to any other person. > Thank you. > >>>>>>>>>> > >>>>>>>>>> ???(??????)????????????????? > ? > >> ? > >>>> ?? > >>>>>>> ? > >>>>>>>>> ???? > >>>>>>>>>> ??????????????????????????? > ? > >> ? > >>>> ?? > >>>>>>>>> ????? > >>>>>>>>>> ???????? > >>>>>>>> > >>>>>>>> ________________________________ > >>>>>>>> > >>>>>>>> This email (including any attachments) is confidential and may > >>>>>>>> be legally > >>>>>>> privileged. If you received this email in error, please delete > >>>>>>> it immediately and do not copy it or use it for any purpose or > >>>>>>> disclose its contents to any other person. Thank you. > >>>>>>> > >>>>>>>> > >>>>>>>> ???(??????)?????????????????? > ? > >> ? > >>>> ?? > >>>>>>> ???????????????????????????? > ? > >> ? > >>>> ?? > >>>>>>> ????? > >>>>>>>> ??????????? > >>>>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> > >>>>>> This email (including any attachments) is confidential and may be > >>>>>> legally > >>>> privileged. If you received this email in error, please delete it > >>>> immediately and do not copy it or use it for any purpose or > >>>> disclose its contents to any other person. Thank you. > >>>>>> > >>>>>> ???(??????)??????????????????? > ? > >> ? > >>>> ?????????????????????????????? > ? > >> ? > >>>> ????? > >>>>>> ???????????? > >>>>>> > >>> > >>> > >>> ________________________________ > >>> > >>> This email (including any attachments) is confidential and may be > >>> legally > >> privileged. If you received this email in error, please delete it > >> immediately and do not copy it or use it for any purpose or disclose > >> its contents to any other person. Thank you. > >> > >>> > >>> ???(??????)????????????????????? > ? > >> ??????????????????????????????? > ? > >> ????? > >>> ??????????? > > > > > > ________________________________ > > > > This email (including any attachments) is confidential and may be legally > privileged. If you received this email in error, please delete it immediately and > do not copy it or use it for any purpose or disclose its contents to any other > person. Thank you. > > > > > ???(??????)?????????????????????? > ???????????????????????????????? > ????? > > ??????????? ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ???(??????)?????????????????????????????????????????????????????????????????????? From david.holmes at oracle.com Tue May 14 02:58:24 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 14 May 2013 09:58:24 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014448: Purge PrintCompactFieldsSavings Message-ID: <20130514095831.3B44248A52@hg.openjdk.java.net> Changeset: a9270d9ecb13 Author: shade Date: 2013-05-14 11:34 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a9270d9ecb13 8014448: Purge PrintCompactFieldsSavings Summary: Remove obsolete debugging code. Reviewed-by: dholmes, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/globals.hpp From nils.loodin at oracle.com Tue May 14 04:20:12 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Tue, 14 May 2013 13:20:12 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <51917739.1020200@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> <51917739.1020200@oracle.com> Message-ID: <51921DEC.3010704@oracle.com> On 05/14/2013 01:28 AM, Mandy Chung wrote: > On 5/13/13 1:50 PM, Staffan Larsen wrote: >> Shouldn't the link be to the oracle site that the sun site redirects to: >> >> http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html Staffan, yes, changed this. >> > > Can you take it further to construct the link with the release version > of the JRE: > > http://docs.oracle.com/javase/${RELEASE}/docs/technotes/guides/management/jconsole.html > > > For jdk8, it should be "8". > Mandy Mandy: Is the current relased saved somewhere accessible in the jdk, or is that something you suggest also be stored in the message.properties-files? In that case it doesn't seem like we're gaining much, since that would have to be updated between releaes... Erik Gahlin also pointed out that the JConsoleResources*.java-files are stale artefacts that can be safely removed since the messages are stored in the messages*.properties-files, so that alleviates some of the pain of storing the strings everywhere. Here's an updated webrev: http://cr.openjdk.java.net/~nloodin/8014048/webrev.01/ Regards, Nils Loodin > >> /Staffan >> >> On 13 maj 2013, at 15:36, Nils Loodin wrote: >> >>> On 05/13/2013 03:36 PM, Nils Loodin wrote: >>>> Simple change of link in resource files: >>>> >>>> https://jbs.oracle.com/bugs/browse/JDK-8014048 >>>> >>>> Regards, >>>> Nils Loodin >>> >>> Also, with webrev link (might come in handy): >>> http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ > From alan.bateman at oracle.com Tue May 14 06:34:06 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 14 May 2013 13:34:06 +0000 Subject: hg: jdk8/tl/jdk: 8014500: bootcycle-images fails after upgrade to JAXP 1.5 Message-ID: <20130514133439.831AD48A64@hg.openjdk.java.net> Changeset: b315cb9a7544 Author: alanb Date: 2013-05-14 14:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b315cb9a7544 8014500: bootcycle-images fails after upgrade to JAXP 1.5 Reviewed-by: lancea ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java From harold.seigel at oracle.com Tue May 14 08:48:42 2013 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Tue, 14 May 2013 15:48:42 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014138: Add VM option to facilitate the writing of CDS tests Message-ID: <20130514154846.D7CB448A71@hg.openjdk.java.net> Changeset: f944ba972151 Author: hseigel Date: 2013-05-14 09:17 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f944ba972151 8014138: Add VM option to facilitate the writing of CDS tests Summary: Added the -XX:SharedArchiveFile option. Reviewed-by: coleenp, ccheung, acorn, dcubed, zgu ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp + test/runtime/SharedArchiveFile/SharedArchiveFile.java From alexey.utkin at oracle.com Tue May 14 09:24:25 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Tue, 14 May 2013 16:24:25 +0000 Subject: hg: jdk8/tl/jdk: 8012453: (process) Runtime.exec(String) fails if command contains spaces [win] Message-ID: <20130514162448.4EEF748A74@hg.openjdk.java.net> Changeset: 5ea5f5dfb96a Author: uta Date: 2013-05-14 20:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ea5f5dfb96a 8012453: (process) Runtime.exec(String) fails if command contains spaces [win] Reviewed-by: alanb ! src/share/classes/java/lang/ProcessBuilder.java ! src/windows/classes/java/lang/ProcessImpl.java + test/java/lang/Runtime/exec/ExecCommand.java From james.laskey at oracle.com Tue May 14 09:43:37 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 16:43:37 +0000 Subject: hg: jdk8/tl/nashorn: 17 new changesets Message-ID: <20130514164351.74D8648A78@hg.openjdk.java.net> Changeset: b754fb89367d Author: jlaskey Date: 2013-04-30 10:05 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b754fb89367d 8006220: Simplify PropertyMaps Reviewed-by: hannesw, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyHashMap.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java - src/jdk/nashorn/internal/runtime/SpillProperty.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/scripts/JO.java ! src/jdk/nashorn/tools/Shell.java Changeset: 80cb02dedc83 Author: hannesw Date: 2013-05-02 09:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80cb02dedc83 8013729: SwitchPoint invalidation not working over prototype chain Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8013729.js + test/script/basic/JDK-8013729.js.EXPECTED Changeset: 7563c56ca565 Author: jlaskey Date: 2013-05-02 13:22 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7563c56ca565 8013794: JDK-8006220 caused an octane performance regression. Reviewed-by: lagergren, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/ObjectCreator.java Changeset: 9c2376a250b6 Author: jlaskey Date: 2013-05-02 13:23 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9c2376a250b6 Merge Changeset: c8023561505b Author: jlaskey Date: 2013-05-02 15:01 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c8023561505b 8013796: load("fx:base.js") should not be in fx:bootstrap.js Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js Changeset: 5a3f7867e19c Author: lagergren Date: 2013-05-03 15:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5a3f7867e19c 8013477: Node.setSymbol needs to be copy on write - enable IR snapshots for recompilation based on callsite type specialization. [not enabled by default, hidden by a flag for now] Reviewed-by: jlaskey, hannesw ! bin/jjs ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/CompiledFunction.java ! src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java + test/script/basic/paramspec.js + test/script/basic/paramspec.js.EXPECTED ! test/script/basic/runsunspider.js + test/script/currently-failing/logcoverage.js - test/script/trusted/logcoverage.js Changeset: 829b06307fb2 Author: lagergren Date: 2013-05-03 16:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/829b06307fb2 8013871: mem usage histograms enabled with compiler logging level set to more specific than or equals to info when --print-mem-usage flag is used Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/Compiler.java + src/jdk/nashorn/internal/ir/debug/ClassHistogramElement.java + src/jdk/nashorn/internal/ir/debug/ObjectSizeCalculator.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java Changeset: c0f0033d7b08 Author: hannesw Date: 2013-05-03 22:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c0f0033d7b08 8013878: ClassCastException in Regex Reviewed-by: jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8013878.js + test/script/basic/JDK-8013878.js.EXPECTED Changeset: f98d22fa3cbc Author: hannesw Date: 2013-05-03 22:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f98d22fa3cbc 8013873: Regexp regression for escaped dash in character class Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8013873.js + test/script/basic/JDK-8013873.js.EXPECTED Changeset: f3dcb12c8439 Author: hannesw Date: 2013-05-03 22:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f3dcb12c8439 8013874: Function argument's prototype seem cached and wrongly reused Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java + test/script/basic/JDK-8013874.js + test/script/basic/JDK-8013874.js.EXPECTED Changeset: 544e17632e96 Author: lagergren Date: 2013-05-07 14:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/544e17632e96 8013913: Removed Source field from all nodes except FunctionNode in order to save footprint Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java - src/jdk/nashorn/internal/ir/Location.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java Changeset: fb1d7ea3e1b6 Author: lagergren Date: 2013-05-07 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fb1d7ea3e1b6 8013914: Removed explicit LineNumberNodes that were too brittle when code moves around, and also introduced unnecessary footprint. Introduced the Statement node and fixed dead code elimination issues that were discovered by the absense of labels for LineNumberNodes. Reviewed-by: jlaskey, attila ! make/project.properties ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java - src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java + src/jdk/nashorn/internal/ir/Statement.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/no_line_numbers.js + test/script/basic/no_line_numbers.js.EXPECTED Changeset: d28180d97c61 Author: attila Date: 2013-05-08 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d28180d97c61 8013912: Nashorn needs to reuse temporary symbols Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/Symbol.java + src/jdk/nashorn/internal/ir/TemporarySymbols.java ! src/jdk/nashorn/internal/ir/TypeOverride.java Changeset: 18ce1cd3026c Author: attila Date: 2013-05-08 16:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18ce1cd3026c 8014225: Rerun only failed 262 tests Reviewed-by: jlaskey, lagergren ! make/project.properties ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java ! test/src/jdk/nashorn/internal/test/framework/TestFinder.java Changeset: 9073bcc4307b Author: lagergren Date: 2013-05-10 13:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9073bcc4307b 8014329: Slim down the label stack structure in CodeGenerator Reviewed-by: attila, jlaskey ! .hgignore ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java Changeset: 098a4cedcaf2 Author: attila Date: 2013-05-14 12:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/098a4cedcaf2 8014492: Make NashornLinker public Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java Changeset: 264bb0af9e4e Author: jlaskey Date: 2013-05-14 09:05 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/264bb0af9e4e Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js From sundararajan.athijegannathan at oracle.com Tue May 14 10:07:18 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 14 May 2013 17:07:18 +0000 Subject: hg: jdk8/tl/jdk: 8014519: scriptpad sample does not work with nashorn Message-ID: <20130514170742.64A4448A7A@hg.openjdk.java.net> Changeset: e0135f1a8627 Author: sundar Date: 2013-05-14 22:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0135f1a8627 8014519: scriptpad sample does not work with nashorn Reviewed-by: attila, jlaskey Contributed-by: rieberandreas at gmail.com ! src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java ! src/share/sample/scripting/scriptpad/src/resources/Main.js ! src/share/sample/scripting/scriptpad/src/resources/conc.js ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/share/sample/scripting/scriptpad/src/resources/mm.js ! src/share/sample/scripting/scriptpad/src/resources/scriptpad.js ! src/share/sample/scripting/scriptpad/src/scripts/browse.js ! src/share/sample/scripting/scriptpad/src/scripts/insertfile.js ! src/share/sample/scripting/scriptpad/src/scripts/linewrap.js ! src/share/sample/scripting/scriptpad/src/scripts/mail.js ! src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.sh ! src/share/sample/scripting/scriptpad/src/scripts/textcolor.js From jonathan.gibbons at oracle.com Tue May 14 10:17:50 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 17:17:50 +0000 Subject: hg: jdk8/tl/langtools: 17 new changesets Message-ID: <20130514171841.689DE48A7C@hg.openjdk.java.net> Changeset: 8ea30d59ac41 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8ea30d59ac41 8010440: Replace int constants in LinkInfoImpl with enum Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 74cd21f2c2fe Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/74cd21f2c2fe 8011642: Remove LinkOutput in favor of direct use of Content Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java Changeset: 7a9ef837e57f Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a9ef837e57f 8011650: reduce use of RawHtml nodes in doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 6ea964c78845 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6ea964c78845 8011651: simplify LinkInfoImpl API Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java Changeset: e6c5b5ee9fac Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6c5b5ee9fac 8011662: Remove single instance of resource with HTML from doclet resource bundle Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: ce4f0769b4b2 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ce4f0769b4b2 8011668: Allow HTMLWriter.getResource to take Content args Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 4c43e51433ba Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4c43e51433ba 8011288: Erratic/inconsistent indentation of signatures Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java + test/com/sun/javadoc/testIndentation/TestIndentation.java + test/com/sun/javadoc/testIndentation/p/Indent.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java Changeset: 7af0fa419a2b Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af0fa419a2b 8012174: {@literal} and {@code} should use \"new\" Taglet, not old. Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java Changeset: 6a5288a298fd Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a5288a298fd 8012175: Convert TagletOutputImpl to use ContentBuilder instead of StringBuilder Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java Changeset: 76a691e3e961 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/76a691e3e961 8012176: reduce use of TagletOutputImpl.toString Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java Changeset: 937aa020c667 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/937aa020c667 8012177: HTMLDocletWriter methods should generate Content, not Strings Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java Changeset: bd51ca92c013 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bd51ca92c013 8012178: Cleanup use of Util.escapeHtmlChars Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: df4f44800923 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/df4f44800923 8012183: replace some uses of Configuration.getText with Configuration.getResource Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 051b728cfe90 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/051b728cfe90 8012180: Speed up removeNonInlineHtmlTags Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: 25c89a492f14 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25c89a492f14 8012295: Cleanup JavaFX features in standard doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: 081d7c72ee92 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/081d7c72ee92 8012311: Cleanup names and duplicatre code in TagletManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: ca8808c88f94 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca8808c88f94 8012308: Remove TagletOutput in favor of direct use of Content Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/BoldTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/GreenTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/UnderlineTaglet.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java From robert.field at oracle.com Tue May 14 11:11:56 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 14 May 2013 18:11:56 +0000 Subject: hg: jdk8/tl/langtools: 8012556: Implement lambda methods on interfaces as static; ... Message-ID: <20130514181201.B1A5B48A7F@hg.openjdk.java.net> Changeset: c09b7234cded Author: rfield Date: 2013-05-14 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c09b7234cded 8012556: Implement lambda methods on interfaces as static 8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface Summary: Lambdas occurring in static contexts or those not needing instance information should be generated into static methods. This has long been the case for classes. However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods. For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'. MethodHandles now support static methods on interfaces. This changeset allows lambda methods to be generated as static interface methods. An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used. This test and another test that already exposed this bug have been marked with @ignore. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaInterfaceStaticField.java ! test/tools/javac/lambda/MethodReference66.java ! test/tools/javac/lambda/bytecode/TestLambdaBytecode.java ! test/tools/javac/lambda/lambdaExecution/InInterface.java From kurchi.subhra.hazra at oracle.com Tue May 14 11:51:57 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Tue, 14 May 2013 18:51:57 +0000 Subject: hg: jdk8/tl/jdk: 6328537: Improve javadocs for Socket class by adding references to SocketOptions Message-ID: <20130514185220.F24EA48A80@hg.openjdk.java.net> Changeset: 790d292ee761 Author: khazra Date: 2013-05-14 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/790d292ee761 6328537: Improve javadocs for Socket class by adding references to SocketOptions Summary: Insert references to SocketOptions.java where applicable Reviewed-by: alanb, chegar ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java From jonathan.gibbons at oracle.com Tue May 14 12:57:22 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 19:57:22 +0000 Subject: hg: jdk8/tl/langtools: 8014461: genstubs creates default native methods Message-ID: <20130514195727.3331448A8C@hg.openjdk.java.net> Changeset: 46b9c25f7024 Author: jjg Date: 2013-05-14 12:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/46b9c25f7024 8014461: genstubs creates default native methods Reviewed-by: alanb ! make/tools/genstubs/GenStubs.java From staffan.larsen at oracle.com Tue May 14 13:10:31 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 14 May 2013 22:10:31 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <51921DEC.3010704@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> <51917739.1020200@oracle.com> <51921DEC.3010704@oracle.com> Message-ID: Looks good! /Staffan On 14 maj 2013, at 13:20, Nils Loodin wrote: > On 05/14/2013 01:28 AM, Mandy Chung wrote: >> On 5/13/13 1:50 PM, Staffan Larsen wrote: >>> Shouldn't the link be to the oracle site that the sun site redirects to: >>> >>> http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html > > Staffan, yes, changed this. > >>> >> >> Can you take it further to construct the link with the release version >> of the JRE: >> >> http://docs.oracle.com/javase/${RELEASE}/docs/technotes/guides/management/jconsole.html >> >> >> For jdk8, it should be "8". >> Mandy > > Mandy: Is the current relased saved somewhere accessible in the jdk, or is that something you suggest also be stored in the message.properties-files? In that case it doesn't seem like we're gaining much, since that would have to be updated between releaes... > > Erik Gahlin also pointed out that the JConsoleResources*.java-files are stale artefacts that can be safely removed since the messages are stored in the messages*.properties-files, so that alleviates some of the pain of storing the strings everywhere. > > Here's an updated webrev: > http://cr.openjdk.java.net/~nloodin/8014048/webrev.01/ > > Regards, > Nils Loodin > >> >>> /Staffan >>> >>> On 13 maj 2013, at 15:36, Nils Loodin wrote: >>> >>>> On 05/13/2013 03:36 PM, Nils Loodin wrote: >>>>> Simple change of link in resource files: >>>>> >>>>> https://jbs.oracle.com/bugs/browse/JDK-8014048 >>>>> >>>>> Regards, >>>>> Nils Loodin >>>> >>>> Also, with webrev link (might come in handy): >>>> http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ >> > From jonathan.gibbons at oracle.com Tue May 14 13:55:46 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 20:55:46 +0000 Subject: hg: jdk8/tl/langtools: 8014557: Mutable static field in HtmlDocletWriter Message-ID: <20130514205552.B3A5848A90@hg.openjdk.java.net> Changeset: 0384683c64be Author: jjg Date: 2013-05-14 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0384683c64be 8014557: Mutable static field in HtmlDocletWriter Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java From xueming.shen at oracle.com Tue May 14 14:11:20 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 14 May 2013 21:11:20 +0000 Subject: hg: jdk8/tl/jdk: 8012326: Deadlock occurs when Charset.availableCharsets() is called by several threads at the same time Message-ID: <20130514211142.A5B6C48A92@hg.openjdk.java.net> Changeset: 08ef70f60e0d Author: sherman Date: 2013-05-14 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08ef70f60e0d 8012326: Deadlock occurs when Charset.availableCharsets() is called by several threads at the same time Summary: removed the race condition risk from ExtendedCahrset access code Reviewed-by: mchung, alanb ! make/sun/nio/cs/Makefile ! makefiles/CreateJars.gmk ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/cs/ext/ISO2022_JP_2.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider ! src/share/classes/sun/nio/cs/ext/MSISO2022JP.java From xueming.shen at oracle.com Tue May 14 14:21:54 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 14 May 2013 21:21:54 +0000 Subject: hg: jdk8/tl/jdk: 8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit Message-ID: <20130514212206.9FF1848A93@hg.openjdk.java.net> Changeset: c70fff3db913 Author: sherman Date: 2013-05-14 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c70fff3db913 8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit Summary: to throw IOE for malformed final unit in base64 stream Reviewed-by: chegar, alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java From jonathan.gibbons at oracle.com Tue May 14 15:05:12 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 22:05:12 +0000 Subject: hg: jdk8/tl/langtools: 8013852: update reference impl for type-annotations Message-ID: <20130514220518.77FDF48A96@hg.openjdk.java.net> Changeset: ddb4a2bfcd82 Author: jjg Date: 2013-05-14 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ddb4a2bfcd82 8013852: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wdietl at gmail.com, steve.sides at oracle.com, joel.franck at oracle.com, alex.buckley at oracle.com ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest3.java ! test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java ! test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008769.java + test/tools/javac/annotations/typeAnnotations/classfile/T8010015.java + test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java ! test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java ! test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.java + test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.out ! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/T8008751.java + test/tools/javac/annotations/typeAnnotations/failures/T8009360.java + test/tools/javac/annotations/typeAnnotations/failures/T8011722.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/Lambda.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Initializers.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Test.java ! test/tools/javac/api/TestJavacTaskScanner.java + test/tools/javac/diags/examples/ArrayAndReceiver.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverName.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverType.java + test/tools/javac/diags/examples/IncorrectReceiverName.java + test/tools/javac/diags/examples/ReceiverParameterNotApplicableConstructor.java + test/tools/javac/diags/examples/VarargsAndReceiver.java ! test/tools/javac/lib/DPrinter.java + test/tools/javac/processing/model/type/BasicAnnoTests.java ! test/tools/javac/tree/SourceTreeScannerTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/typeAnnotations/NewArray.java ! test/tools/javap/typeAnnotations/Presence.java ! test/tools/javap/typeAnnotations/TypeCasts.java From stuart.marks at oracle.com Tue May 14 15:44:57 2013 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 14 May 2013 15:44:57 -0700 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <518B6B8C.2080506@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> <5183C6D5.8070302@oracle.com> <51877204.8000104@oracle.com> <5189933E.40702@oracle.com> <518B6B8C.2080506@oracle.com> Message-ID: <5192BE69.4020003@oracle.com> Hi, sorry for the delay in my reply, and thanks for the update. A timeout of 30 seconds should be sufficient. Regarding duplicates: I was just thinking, if you're expecting exactly 10 notifications, you should ensure that you receive exactly 10 notifications, and they're the right ones. But if duplicates is the only possible way that more than 10 notifications could occur, then that's probably fine. I just don't know enough about JMX to know. Now... I took a look at the Client.java implementation, and ... groan (sorry) ... I see you're using the single-element array trick to work around the inability to mutate local variables from an anonymous inner class. I strongly recommend that you avoid using this trick. I don't know what thread the notification callbacks run on. If they are on different threads, then there are inherent memory visibility problems, since array elements cannot be declared volatile. There is also potential concurrent access to seqSet, since it's accessed from both callbacks. (Hm, seqSet isn't modified anywhere. Should the notification sequence numbers be added to the set somewhere?) One approach for dealing with this is to make all the mutable data structures thread-safe, e.g. by wrapping seqSet using Collections.synchronizedSet() and using an AtomicBoolean instead of boolean[1]. Another approach would be to have the callbacks just append the notification objects to a synchronized list, and then have the main test thread do postprocessing on the list to ensure that it got the notifications it expected and that there were no duplicates. Either way is fine, in order to avoid the threading issues. Thanks, and sorry to belabor this review. s'marks On 5/9/13 2:25 AM, Jaroslav Bachorik wrote: > Hi Stuart, > > On St 8. kv?ten 2013, 01:50:22 CEST, Stuart Marks wrote: >> Hi Jaroslav, >> >> Great to see this shell test get rewritten! >> >> Looks like you're avoiding multiple JVM processes as well, by loading >> the different versions of the classes into different classloaders. It >> looks like a bit of trouble, but probably less than the amount of >> trouble caused by the shell script. >> >> I have a couple minor points. >> >> The timeout value of one second seems quite low. Under normal >> operation, spawning a couple threads and should proceed very quickly. >> However, our testing environment is quite hostile, and things that >> seem like they ought to proceed quickly often take considerably longer >> than one might think. Since you're counting notifications, and in >> normal operation they all come in, we don't wait for the actual >> timeout unless there's a failure. So it might make sense to raise the >> timeout to 10 or perhaps 30 seconds. > > I've adjusted the timeout for 30 seconds. Hopefully, it will be enough. > >> >> On the other hand, I have a question about whether counting the number >> of notifications is correct. Would it be possible for there to be a >> bug where an extra notification is sent? If so, this might mean that >> the test would exit prematurely, indicating success? > > It would be a severe error in the notification system implementation. > However, I've added a check for duplicated notifications (each > notification carries its sequence number) which makes the test fail in > case of duplication. But I don't expect it to happen. > > The updated webrev is at > http://cr.openjdk.java.net/~jbachorik/8005472/webrev.09 > > > -JB- > >> >> s'marks >> >> On 5/6/13 2:04 AM, Jaroslav Bachorik wrote: >>> On P? 3. kv?ten 2013, 16:16:53 CEST, Daniel Fuchs wrote: >>>> Hi Jaroslav, >>>> >>>> In Client.java - you could consider replacing the AtomicLong >>>> with a CountDownLatch. >>>> >>>> This would allow you to remove the various Thread.sleep() in the >>>> code (in particular the one at the end). >>>> >>>> You could use CountDownLatch.await(long timeout, TimeUnit unit) to >>>> avoid waiting for ever in case of bugs, and the advantage is that >>>> the test would be able to exit as soon as the count down latch >>>> reaches 0, without having to wait for an arbitrary timeout. >>> >>> Great, thanks for the pointer! I've changed the test to use the >>> CountDownLatch. >>> >>> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.08/ >>> >>> -JB- >>> >>>> >>>> Very nice to see a shell test go away :-) >>>> >>>> -- daniel >>>> >>>> >>>> On 5/3/13 3:41 PM, Jaroslav Bachorik wrote: >>>>> Please re-review the updated webrev >>>>> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 >>>>> >>>>> I've replaced the shell script with the plain java test. The javac API >>>>> is used to compile the the auxiliary classes as was recommended. This >>>>> allowed to simplify the test. >>>>> >>>>> The test does not check for a certain string in the standard output >>>>> anymore - it turns out that it is possible to count the number of all >>>>> the received JMX notifications (even though some notifications can be >>>>> lost, we receive a special notification with the number of the lost >>>>> regular notifications). It is then possible to match the actual number >>>>> of processed notifications (received + lost) against the expected >>>>> number >>>>> - different numbers mean that the notification processing thread had >>>>> been interrupted unexpectedly. >>>>> >>>>> Thanks, >>>>> >>>>> -JB- >>>>> >>>>> On 8.2.2013 17:37, Chris Hegarty wrote: >>>>>> >>>>>>> Jon Gibbons suggested invoking the compiler API directly from java >>>>>>> instead of writing a shell script. Doing this seems fairly simple, >>>>>>> and I >>>>>>> think it would be advantageous to keep things entirely in Java. I >>>>>>> may >>>>>>> attempt to rewrite the defaultSVID test using the compiler API. >>>>>> >>>>>> Here's a test that does just that. >>>>>> >>>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/file/2de8c6c2d652/test/sun/misc/JarIndex/metaInfFilenames/Basic.java >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -Chris. >>>>> >>>> >>> >>> > From mandy.chung at oracle.com Tue May 14 16:26:23 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 14 May 2013 16:26:23 -0700 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <51921DEC.3010704@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> <51917739.1020200@oracle.com> <51921DEC.3010704@oracle.com> Message-ID: <5192C81F.6070407@oracle.com> On 5/14/13 4:20 AM, Nils Loodin wrote: > > Mandy: Is the current relased saved somewhere accessible in the jdk It's stored in "java.version" property but it requires parsing to extract the major release number. The private API sun.misc.Version.getMajorVersion returns that. > or is that something you suggest also be stored in the > message.properties-files? Not the release version number. The user guide used to be localized but I only see the English version of jdk 7 though: http://www.oracle.com/technetwork/java/javase/documentation/api-jsp-136079.html You would need to store a string that may be localized in the resource bundle (messages.properties in this case). If you want to make the version number of the URL depending on the runtime and assuming the URL is different for different locale, you would have something like this in messages.properties: http://docs.oracle.com/javase/{0}/docs/technotes/guides/management/jconsole.html Anyway, it's minor and no big deal. What you have is fine and it's a fix for jdk7u but you need to replace 's/7/8' for jdk8 code base. Mandy > In that case it doesn't seem like we're gaining much, since that would > have to be updated between releaes... > > Erik Gahlin also pointed out that the JConsoleResources*.java-files > are stale artefacts that can be safely removed since the messages are > stored in the messages*.properties-files, so that alleviates some of > the pain of storing the strings everywhere. > > Here's an updated webrev: > http://cr.openjdk.java.net/~nloodin/8014048/webrev.01/ > > Regards, > Nils Loodin > >> >>> /Staffan >>> >>> On 13 maj 2013, at 15:36, Nils Loodin wrote: >>> >>>> On 05/13/2013 03:36 PM, Nils Loodin wrote: >>>>> Simple change of link in resource files: >>>>> >>>>> https://jbs.oracle.com/bugs/browse/JDK-8014048 >>>>> >>>>> Regards, >>>>> Nils Loodin >>>> >>>> Also, with webrev link (might come in handy): >>>> http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ >> > From yumin.qi at oracle.com Tue May 14 16:35:55 2013 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Tue, 14 May 2013 23:35:55 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130514233601.D1E7248A9B@hg.openjdk.java.net> Changeset: f9be75d21404 Author: minqi Date: 2013-05-14 09:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f9be75d21404 8012902: remove use of global operator new - take 2 Summary: The fix of 8010992, disable use of global operator new and new[] which caused failure on some tests. This takes two of the bugs also add ALLOW_OPERATOR_NEW_USAGE to prevent crash for third party code calling operator new of jvm on certain platforms. Reviewed-by: coleenp, dholmes, zgu Contributed-by: yumin.qi at oracle.com ! make/bsd/makefiles/fastdebug.make ! make/bsd/makefiles/vm.make ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/classfile/altHashing.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/memRegion.cpp ! src/share/vm/memory/memRegion.hpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/objectMonitor.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/unhandledOops.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 513a5298c1dd Author: minqi Date: 2013-05-14 17:33 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/513a5298c1dd Merge From jonathan.gibbons at oracle.com Tue May 14 18:03:21 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 15 May 2013 01:03:21 +0000 Subject: hg: jdk8/tl/langtools: 8013163: Convert 4 tools multicatch tests to jtreg format Message-ID: <20130515010324.C4E7048A9D@hg.openjdk.java.net> Changeset: 53b389eb39c1 Author: sogoel Date: 2013-05-14 18:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53b389eb39c1 8013163: Convert 4 tools multicatch tests to jtreg format Reviewed-by: jjg + test/tools/javac/multicatch/Pos11.java + test/tools/javac/multicatch/Pos12.java From jonathan.gibbons at oracle.com Tue May 14 21:10:15 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 15 May 2013 04:10:15 +0000 Subject: hg: jdk8/tl/langtools: 8014323: Add VariableTree.getNameExpression Message-ID: <20130515041020.ED5C348AA0@hg.openjdk.java.net> Changeset: 529fb3ed5d2a Author: jjg Date: 2013-05-14 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/529fb3ed5d2a 8014323: Add VariableTree.getNameExpression Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! test/tools/javac/tree/SourceTreeScannerTest.java From david.holmes at oracle.com Tue May 14 21:46:51 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 15 May 2013 04:46:51 +0000 Subject: hg: jdk8/tl/jdk: 8013395: StringBuffer.toString performance regression impacting embedded benchmarks Message-ID: <20130515044703.2C79148AA4@hg.openjdk.java.net> Changeset: a3d79a4c2a24 Author: dholmes Date: 2013-05-15 00:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3d79a4c2a24 8013395: StringBuffer.toString performance regression impacting embedded benchmarks Summary: cache a copy of the char[] to use with toString() and clear it when ever the sb content is modified Reviewed-by: alanb, plevart, mduigou, forax ! src/share/classes/java/lang/StringBuffer.java + test/java/lang/StringBuffer/ToStringCache.java From joe.darcy at oracle.com Wed May 15 00:01:03 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 15 May 2013 07:01:03 +0000 Subject: hg: jdk8/tl/langtools: 8004133: Provide javax.lang.model.* implementation backed by core reflection Message-ID: <20130515070112.226A448AA6@hg.openjdk.java.net> Changeset: bcd927639039 Author: darcy Date: 2013-05-15 00:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bcd927639039 8004133: Provide javax.lang.model.* implementation backed by core reflection Summary: Joint work by darcy and jfranck to provide sample code for JEP 119. Reviewed-by: jjg Contributed-by: joe.darcy at oracle.com, joel.franck at oracle.com + src/share/sample/language/model/CoreReflectionFactory.java From rickard.backman at oracle.com Wed May 15 02:37:57 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Wed, 15 May 2013 11:37:57 +0200 Subject: RFR(XS): 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd Message-ID: <9429B07B-0B50-4D48-8B85-09D93DD5A0D5@oracle.com> Hi all, can I please have this change reviewed? My interpretation is that this isn't really a bug, since the parameter sig_type is never set to [. The suggested change is to remove the check for [ in the if and add an assert. I also created a boolean to track handle creation to simplify cleanup. The caller of this method is InterpreterRuntime::post_field_modification which sets the sig_type to: switch(cp_entry->flag_state()) { case btos: sig_type = 'Z'; break; case ctos: sig_type = 'C'; break; case stos: sig_type = 'S'; break; case itos: sig_type = 'I'; break; case ftos: sig_type = 'F'; break; case atos: sig_type = 'L'; break; case ltos: sig_type = 'J'; break; case dtos: sig_type = 'D'; break; default: ShouldNotReachHere(); return; } Testing done: nsk.jvmti.testlist with fastdebug build. Webrev: http://cr.openjdk.java.net/~rbackman/4965252/ Thanks /R From maurizio.cimadamore at oracle.com Wed May 15 06:04:19 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 15 May 2013 13:04:19 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130515130430.BE5EE48AC0@hg.openjdk.java.net> Changeset: 05ec778794d0 Author: mcimadamore Date: 2013-05-15 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05ec778794d0 8012003: Method diagnostics resolution need to be simplified in some cases Summary: Unfold method resolution diagnostics when they mention errors in poly expressions Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/Diagnostics/compressed/T8012003a.java + test/tools/javac/Diagnostics/compressed/T8012003a.out + test/tools/javac/Diagnostics/compressed/T8012003b.java + test/tools/javac/Diagnostics/compressed/T8012003b.out + test/tools/javac/Diagnostics/compressed/T8012003c.java + test/tools/javac/Diagnostics/compressed/T8012003c.out ! test/tools/javac/diags/examples/BadArgTypesInLambda.java + test/tools/javac/diags/examples/CompressedDiags.java ! test/tools/javac/diags/examples/KindnameConstructor.java + test/tools/javac/diags/examples/ProbFoundReqFragment.java ! test/tools/javac/lambda/TargetType66.out Changeset: 33d1937af1a3 Author: mcimadamore Date: 2013-05-15 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33d1937af1a3 8012685: Spurious raw types warning when using unbound method references Summary: Spurious raw type warning when unbound method reference qualifier parameter types are inferred from target Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/MethodReference67.java + test/tools/javac/lambda/MethodReference67.out Changeset: 78717f2d00e8 Author: mcimadamore Date: 2013-05-15 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/78717f2d00e8 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types Summary: Bad warnings and position for lambda inferred parameter types Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/NoWarnOnImplicitParams.java + test/tools/javac/lambda/NoWarnOnImplicitParams.out From robert.field at oracle.com Wed May 15 06:53:42 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 15 May 2013 13:53:42 +0000 Subject: hg: jdk8/tl/langtools: 8010006: NPE in javac with interface super in lambda Message-ID: <20130515135345.9330248AC2@hg.openjdk.java.net> Changeset: 31ef33db5e0e Author: rfield Date: 2013-05-15 06:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31ef33db5e0e 8010006: NPE in javac with interface super in lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaWithInterfaceSuper.java From michael.x.mcmahon at oracle.com Wed May 15 07:02:29 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Wed, 15 May 2013 14:02:29 +0000 Subject: hg: jdk8/tl/jdk: 8010464: Evolve java networking same origin policy Message-ID: <20130515140249.4F36C48AC3@hg.openjdk.java.net> Changeset: 93a268759ec3 Author: michaelm Date: 2013-05-15 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93a268759ec3 8010464: Evolve java networking same origin policy Reviewed-by: alanb, chegar, dsamersoff, weijun ! src/share/classes/java/net/HttpURLConnection.java + src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/HttpURLPermission/HttpURLPermissionTest.java + test/java/net/HttpURLPermission/URLTest.java + test/java/net/HttpURLPermission/policy.1 + test/java/net/HttpURLPermission/policy.2 + test/java/net/HttpURLPermission/policy.3 From xueming.shen at oracle.com Wed May 15 07:50:54 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 15 May 2013 14:50:54 +0000 Subject: hg: jdk8/tl/jdk: 8013730: JSR 310 DateTime API Updates III Message-ID: <20130515145126.167A448AC6@hg.openjdk.java.net> Changeset: ef04044f77d2 Author: sherman Date: 2013-05-15 07:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef04044f77d2 8013730: JSR 310 DateTime API Updates III Summary: Integration of JSR310 Date/Time API update III Reviewed-by: naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/HijrahEra.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/JapaneseEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/MinguoEra.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistEra.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/DecimalStyle.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/format/ResolverStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/UnsupportedTemporalTypeException.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKChronologySerialization.java ! test/java/time/tck/java/time/chrono/TCKHijrahChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java + test/java/time/tck/java/time/format/TCKDecimalStyle.java + test/java/time/tck/java/time/format/TCKInstantPrinterParser.java ! test/java/time/tck/java/time/format/TCKTextStyle.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/test/java/time/chrono/TestChronologyPerf.java ! test/java/time/test/java/time/chrono/TestExampleCode.java + test/java/time/test/java/time/chrono/TestJapaneseChronology.java ! test/java/time/test/java/time/format/AbstractTestPrinterParser.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java ! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java + test/java/time/test/java/time/format/TestDecimalStyle.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java From serguei.spitsyn at oracle.com Wed May 15 07:58:03 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 15 May 2013 07:58:03 -0700 Subject: RFR(XS): 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd In-Reply-To: <9429B07B-0B50-4D48-8B85-09D93DD5A0D5@oracle.com> References: <9429B07B-0B50-4D48-8B85-09D93DD5A0D5@oracle.com> Message-ID: <5193A27B.2070304@oracle.com> Hi Rickard, I think, the fix is good. But the code that was fixed was harmless as a memory leak described in the report never really happened. It is still a nice clean up. :) Thanks, Serguei On 5/15/13 2:37 AM, Rickard B?ckman wrote: > Hi all, > > can I please have this change reviewed? > > My interpretation is that this isn't really a bug, since the parameter sig_type is never set to [. > The suggested change is to remove the check for [ in the if and add an assert. I also created a boolean > to track handle creation to simplify cleanup. > > The caller of this method is InterpreterRuntime::post_field_modification > which sets the sig_type to: > > switch(cp_entry->flag_state()) { > case btos: sig_type = 'Z'; break; > case ctos: sig_type = 'C'; break; > case stos: sig_type = 'S'; break; > case itos: sig_type = 'I'; break; > case ftos: sig_type = 'F'; break; > case atos: sig_type = 'L'; break; > case ltos: sig_type = 'J'; break; > case dtos: sig_type = 'D'; break; > default: ShouldNotReachHere(); return; > } > > Testing done: nsk.jvmti.testlist with fastdebug build. > > Webrev: http://cr.openjdk.java.net/~rbackman/4965252/ > > Thanks > /R > > > From joe.darcy at oracle.com Wed May 15 09:54:45 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 15 May 2013 16:54:45 +0000 Subject: hg: jdk8/tl/jdk: 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier) Message-ID: <20130515165503.95F7C48AD2@hg.openjdk.java.net> Changeset: bad8f5237f10 Author: darcy Date: 2013-05-15 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bad8f5237f10 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier) Reviewed-by: alanb ! src/share/classes/java/util/Objects.java From jonathan.gibbons at oracle.com Wed May 15 10:40:05 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 15 May 2013 17:40:05 +0000 Subject: hg: jdk8/tl/langtools: 8006879: Detection of windows in sjavac fails. Message-ID: <20130515174013.9F55448AD3@hg.openjdk.java.net> Changeset: 445b8b5ae9f4 Author: jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joelsson at oracle.com ! src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java From dmitry.samersoff at oracle.com Wed May 15 12:08:26 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 15 May 2013 23:08:26 +0400 Subject: RR(S): 8014420 Default JDP address does not match the one assigned by IANA Message-ID: <5193DD2A.9070806@oracle.com> Please, Review a small patch, changing defaults for JDP to one assigned by IANA. All credential belongs to Florian Weimer http://cr.openjdk.java.net/~dsamersoff/8014420.JDP/webrev.01/ -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From fweimer at redhat.com Wed May 15 12:21:03 2013 From: fweimer at redhat.com (Florian Weimer) Date: Wed, 15 May 2013 21:21:03 +0200 Subject: RR(S): 8014420 Default JDP address does not match the one assigned by IANA In-Reply-To: <5193DD2A.9070806@oracle.com> References: <5193DD2A.9070806@oracle.com> Message-ID: <5193E01F.8080005@redhat.com> On 05/15/2013 09:08 PM, Dmitry Samersoff wrote: > http://cr.openjdk.java.net/~dsamersoff/8014420.JDP/webrev.01/ There's a typo in the test script, "failing": + echo "ERROR: Test app not started. Please, check machine resources before failing a bug." I'm not sure about the comma, "Please check machine resources" might be better. I double-checked that the address and the (unchanged) port number are correct. -- Florian Weimer / Red Hat Product Security Team From dmitry.samersoff at oracle.com Wed May 15 12:20:44 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 15 May 2013 23:20:44 +0400 Subject: RR(S): 8014420 Default JDP address does not match the one assigned by IANA In-Reply-To: <5193E01F.8080005@redhat.com> References: <5193DD2A.9070806@oracle.com> <5193E01F.8080005@redhat.com> Message-ID: <5193E00C.50803@oracle.com> Florian, Thanks! -Dmitry On 2013-05-15 23:21, Florian Weimer wrote: > On 05/15/2013 09:08 PM, Dmitry Samersoff wrote: > >> http://cr.openjdk.java.net/~dsamersoff/8014420.JDP/webrev.01/ > > There's a typo in the test script, "failing": > > + echo "ERROR: Test app not started. Please, check machine resources > before failing a bug." > > I'm not sure about the comma, "Please check machine resources" might be > better. > > I double-checked that the address and the (unchanged) port number are > correct. > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From erik.gahlin at oracle.com Wed May 15 13:03:27 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 15 May 2013 22:03:27 +0200 Subject: RR(S): 8014420 Default JDP address does not match the one assigned by IANA In-Reply-To: <5193DD2A.9070806@oracle.com> References: <5193DD2A.9070806@oracle.com> Message-ID: <5193EA0F.10906@oracle.com> Looks good. /Erik Dmitry Samersoff skrev 5/15/13 9:08 PM: > Please, > > Review a small patch, changing defaults for JDP to one assigned by IANA. > > All credential belongs to Florian Weimer > > http://cr.openjdk.java.net/~dsamersoff/8014420.JDP/webrev.01/ > > -Dmitry > From jaroslav.bachorik at oracle.com Wed May 15 13:12:00 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 15 May 2013 22:12:00 +0200 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <5192BE69.4020003@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> <5183C6D5.8070302@oracle.com> <51877204.8000104@oracle.com> <5189933E.40702@oracle.com> <518B6B8C.2080506@oracle.com> <5192BE69.4020003@oracle.com> Message-ID: <5193EC10.3050705@oracle.com> On Wed 15 May 2013 12:44:57 AM CEST, Stuart Marks wrote: > Hi, sorry for the delay in my reply, and thanks for the update. > > A timeout of 30 seconds should be sufficient. > > Regarding duplicates: I was just thinking, if you're expecting exactly > 10 notifications, you should ensure that you receive exactly 10 > notifications, and they're the right ones. But if duplicates is the > only possible way that more than 10 notifications could occur, then > that's probably fine. I just don't know enough about JMX to know. According to the JMX specification you must receive each notification at most once so the duplicate check will detect a possible bug. > > Now... I took a look at the Client.java implementation, and ... groan > (sorry) ... I see you're using the single-element array trick to work > around the inability to mutate local variables from an anonymous inner > class. > > I strongly recommend that you avoid using this trick. > > I don't know what thread the notification callbacks run on. If they > are on different threads, then there are inherent memory visibility > problems, since array elements cannot be declared volatile. There is > also potential concurrent access to seqSet, since it's accessed from > both callbacks. Ok. I've changed it to use AtomicBoolean Thanks for pointing this out. Even though it's rather obvious I got so used to using the final array in anonymous inner classes that I didn't even stop and think. BTW, there are a lot of places in the tests using this idiom in potentially multithreaded environment :( > > (Hm, seqSet isn't modified anywhere. Should the notification sequence > numbers be added to the set somewhere?) Yes, my bad. Instead of *.contains() I should have used *.add(). Fixed now. > > One approach for dealing with this is to make all the mutable data > structures thread-safe, e.g. by wrapping seqSet using > Collections.synchronizedSet() and using an AtomicBoolean instead of > boolean[1]. Yep, the set is synchronized. I was thinking about ConcurrentSkipListSet but for the sakes of the test I think the Collections.synchronizedSet() is just fine. > > Another approach would be to have the callbacks just append the > notification objects to a synchronized list, and then have the main > test thread do postprocessing on the list to ensure that it got the > notifications it expected and that there were no duplicates. > > Either way is fine, in order to avoid the threading issues. > > Thanks, and sorry to belabor this review. NP. I don't want to get imperfect code to the repo either. Thanks for taking your time. Updated webrev - http://cr.openjdk.java.net/~jbachorik/8005472/webrev.10 -JB- > > s'marks > > > > On 5/9/13 2:25 AM, Jaroslav Bachorik wrote: >> Hi Stuart, >> >> On St 8. kv?ten 2013, 01:50:22 CEST, Stuart Marks wrote: >>> Hi Jaroslav, >>> >>> Great to see this shell test get rewritten! >>> >>> Looks like you're avoiding multiple JVM processes as well, by loading >>> the different versions of the classes into different classloaders. It >>> looks like a bit of trouble, but probably less than the amount of >>> trouble caused by the shell script. >>> >>> I have a couple minor points. >>> >>> The timeout value of one second seems quite low. Under normal >>> operation, spawning a couple threads and should proceed very quickly. >>> However, our testing environment is quite hostile, and things that >>> seem like they ought to proceed quickly often take considerably longer >>> than one might think. Since you're counting notifications, and in >>> normal operation they all come in, we don't wait for the actual >>> timeout unless there's a failure. So it might make sense to raise the >>> timeout to 10 or perhaps 30 seconds. >> >> I've adjusted the timeout for 30 seconds. Hopefully, it will be enough. >> >>> >>> On the other hand, I have a question about whether counting the number >>> of notifications is correct. Would it be possible for there to be a >>> bug where an extra notification is sent? If so, this might mean that >>> the test would exit prematurely, indicating success? >> >> It would be a severe error in the notification system implementation. >> However, I've added a check for duplicated notifications (each >> notification carries its sequence number) which makes the test fail in >> case of duplication. But I don't expect it to happen. >> >> The updated webrev is at >> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.09 >> >> >> -JB- >> >>> >>> s'marks >>> >>> On 5/6/13 2:04 AM, Jaroslav Bachorik wrote: >>>> On P? 3. kv?ten 2013, 16:16:53 CEST, Daniel Fuchs wrote: >>>>> Hi Jaroslav, >>>>> >>>>> In Client.java - you could consider replacing the AtomicLong >>>>> with a CountDownLatch. >>>>> >>>>> This would allow you to remove the various Thread.sleep() in the >>>>> code (in particular the one at the end). >>>>> >>>>> You could use CountDownLatch.await(long timeout, TimeUnit unit) to >>>>> avoid waiting for ever in case of bugs, and the advantage is that >>>>> the test would be able to exit as soon as the count down latch >>>>> reaches 0, without having to wait for an arbitrary timeout. >>>> >>>> Great, thanks for the pointer! I've changed the test to use the >>>> CountDownLatch. >>>> >>>> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.08/ >>>> >>>> -JB- >>>> >>>>> >>>>> Very nice to see a shell test go away :-) >>>>> >>>>> -- daniel >>>>> >>>>> >>>>> On 5/3/13 3:41 PM, Jaroslav Bachorik wrote: >>>>>> Please re-review the updated webrev >>>>>> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.06 >>>>>> >>>>>> I've replaced the shell script with the plain java test. The >>>>>> javac API >>>>>> is used to compile the the auxiliary classes as was recommended. >>>>>> This >>>>>> allowed to simplify the test. >>>>>> >>>>>> The test does not check for a certain string in the standard output >>>>>> anymore - it turns out that it is possible to count the number of >>>>>> all >>>>>> the received JMX notifications (even though some notifications >>>>>> can be >>>>>> lost, we receive a special notification with the number of the lost >>>>>> regular notifications). It is then possible to match the actual >>>>>> number >>>>>> of processed notifications (received + lost) against the expected >>>>>> number >>>>>> - different numbers mean that the notification processing thread had >>>>>> been interrupted unexpectedly. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> -JB- >>>>>> >>>>>> On 8.2.2013 17:37, Chris Hegarty wrote: >>>>>>> >>>>>>>> Jon Gibbons suggested invoking the compiler API directly from java >>>>>>>> instead of writing a shell script. Doing this seems fairly simple, >>>>>>>> and I >>>>>>>> think it would be advantageous to keep things entirely in Java. I >>>>>>>> may >>>>>>>> attempt to rewrite the defaultSVID test using the compiler API. >>>>>>> >>>>>>> Here's a test that does just that. >>>>>>> >>>>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/file/2de8c6c2d652/test/sun/misc/JarIndex/metaInfFilenames/Basic.java >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -Chris. >>>>>> >>>>> >>>> >>>> >> From jaroslav.bachorik at oracle.com Wed May 15 13:13:41 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 15 May 2013 22:13:41 +0200 Subject: RR(S): 8014420 Default JDP address does not match the one assigned by IANA In-Reply-To: <5193EA0F.10906@oracle.com> References: <5193DD2A.9070806@oracle.com> <5193EA0F.10906@oracle.com> Message-ID: <5193EC75.5070601@oracle.com> Looks fine to me. -JB- On 05/15/2013 10:03 PM, Erik Gahlin wrote: > Looks good. > > /Erik > > Dmitry Samersoff skrev 5/15/13 9:08 PM: >> Please, >> >> Review a small patch, changing defaults for JDP to one assigned by IANA. >> >> All credential belongs to Florian Weimer >> >> http://cr.openjdk.java.net/~dsamersoff/8014420.JDP/webrev.01/ >> >> -Dmitry >> > From ivan.gerasimov at oracle.com Wed May 15 14:05:39 2013 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 16 May 2013 01:05:39 +0400 Subject: RFR [8014676] Java debugger may fail to run Message-ID: <5193F8A3.3080809@oracle.com> Hello everybody! Would you please help with reviewing the fix? The fix is for jdk8. It is also applicable to jdk7 and will be proposed, if it's accepted here. WEBREV: http://cr.openjdk.java.net/~robm/8014676/webrev.01/ BUG: http://bugs.sun.com/view_bug.do?bug_id=8014676 (may not be available yet) The problem is observed when the binaries for windows are placed under a path which contains a space. Sincerely, Ivan From daniel.daugherty at oracle.com Wed May 15 14:10:40 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 15 May 2013 15:10:40 -0600 Subject: Fix for 8014669, build flags issue In-Reply-To: <5193F495.2020600@oracle.com> References: <5193F495.2020600@oracle.com> Message-ID: <5193F9D0.1030503@oracle.com> Adding Serviceability since libsaproc.so belongs to the Serviceability Team. Dan On 5/15/13 2:48 PM, BILL PITTORE wrote: > Some architecture dependent flags do not make it through to the > libjsig.so and libsaproc.so makefiles. As a result, the libs are not > compiled/linked with the correct flags for that particular variant. > Fix is to make sure EXTRA_CFLAGS propogates down correctly. > > http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/ > > bill > > From dmitry.samersoff at oracle.com Wed May 15 14:28:17 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 16 May 2013 01:28:17 +0400 Subject: RFR [8014676] Java debugger may fail to run In-Reply-To: <5193F8A3.3080809@oracle.com> References: <5193F8A3.3080809@oracle.com> Message-ID: <5193FDF1.7060700@oracle.com> Looks good for me! (not a reviewer) -Dmitry On 2013-05-16 01:05, Ivan Gerasimov wrote: > Hello everybody! > > Would you please help with reviewing the fix? > The fix is for jdk8. It is also applicable to jdk7 and will be proposed, > if it's accepted here. > > WEBREV: http://cr.openjdk.java.net/~robm/8014676/webrev.01/ > > BUG: http://bugs.sun.com/view_bug.do?bug_id=8014676 (may not be > available yet) > > The problem is observed when the binaries for windows are placed under a > path which contains a space. > > Sincerely, > Ivan -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From naoto.sato at oracle.com Wed May 15 16:49:20 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 15 May 2013 23:49:20 +0000 Subject: hg: jdk8/tl/jdk: 8013233: java/util/Locale/LocaleProviders.sh fails Message-ID: <20130515234940.4A42048AE0@hg.openjdk.java.net> Changeset: 3d9f25dc630c Author: naoto Date: 2013-05-15 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3d9f25dc630c 8013233: java/util/Locale/LocaleProviders.sh fails Reviewed-by: okutsu ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From david.holmes at oracle.com Wed May 15 17:05:47 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 16 May 2013 10:05:47 +1000 Subject: Fix for 8014669, build flags issue In-Reply-To: <5193F495.2020600@oracle.com> References: <5193F495.2020600@oracle.com> Message-ID: <519422DB.705@oracle.com> Hi Bill, (re-fixed the build-dev alias) On 16/05/2013 6:48 AM, BILL PITTORE wrote: > Some architecture dependent flags do not make it through to the > libjsig.so and libsaproc.so makefiles. As a result, the libs are not > compiled/linked with the correct flags for that particular variant. Fix > is to make sure EXTRA_CFLAGS propogates down correctly. > > http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/ I need to look closer at this. Passing all of the EXTRA_CFLAGS as link options seems wrong to me as they may not be valid linker options. That said I see that in this case we are actually using the C compiler to do the linking. But that said, in the saproc case we are also compiling C source files at the same time which means that EXTRA_CFLAGS is needed on the main command line, not tucked onto the LD flags. And the implication here is that cross-compilation of libsaproc has been broken all this time for any platform where the default gcc output would be wrong! David From david.holmes at oracle.com Wed May 15 17:43:14 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 16 May 2013 10:43:14 +1000 Subject: Fix for 8014669, build flags issue In-Reply-To: <519422DB.705@oracle.com> References: <5193F495.2020600@oracle.com> <519422DB.705@oracle.com> Message-ID: <51942BA2.4030209@oracle.com> Hi Bill, On 16/05/2013 10:05 AM, David Holmes wrote: > Hi Bill, > > (re-fixed the build-dev alias) > > On 16/05/2013 6:48 AM, BILL PITTORE wrote: >> Some architecture dependent flags do not make it through to the >> libjsig.so and libsaproc.so makefiles. As a result, the libs are not >> compiled/linked with the correct flags for that particular variant. Fix >> is to make sure EXTRA_CFLAGS propogates down correctly. >> >> http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/ > > I need to look closer at this. Passing all of the EXTRA_CFLAGS as link > options seems wrong to me as they may not be valid linker options. That > said I see that in this case we are actually using the C compiler to do > the linking. But that said, in the saproc case we are also compiling C > source files at the same time which means that EXTRA_CFLAGS is needed on > the main command line, not tucked onto the LD flags. And the implication > here is that cross-compilation of libsaproc has been broken all this > time for any platform where the default gcc output would be wrong! Given in both cases we use CC to compile and link I think the more explicit solution here is to add EXTRA_CFLAGS as a primary argument to the $(CC) invocation - see below. Thanks, David diff -r 293b99787401 make/linux/makefiles/jsig.make --- a/make/linux/makefiles/jsig.make +++ b/make/linux/makefiles/jsig.make @@ -54,7 +54,7 @@ $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) @echo Making signal interposition lib... $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) $(PICFLAG) \ - $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) -o $@ $< -ldl + $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(EXTRA_CFLAGS) -o $@ $< -ldl ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO) $(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@ diff -r 293b99787401 make/linux/makefiles/saproc.make --- a/make/linux/makefiles/saproc.make +++ b/make/linux/makefiles/saproc.make @@ -92,6 +92,7 @@ $(SASRCFILES) \ $(SA_LFLAGS) \ $(SA_DEBUG_CFLAGS) \ + $(EXTRA_CFLAGS) \ -o $@ \ -lthread_db ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) From bill.pittore at oracle.com Wed May 15 18:20:43 2013 From: bill.pittore at oracle.com (BILL PITTORE) Date: Wed, 15 May 2013 21:20:43 -0400 Subject: Fix for 8014669, build flags issue In-Reply-To: <519422DB.705@oracle.com> References: <5193F495.2020600@oracle.com> <519422DB.705@oracle.com> Message-ID: <5194346B.8080904@oracle.com> On 5/15/2013 8:05 PM, David Holmes wrote: > Hi Bill, > > (re-fixed the build-dev alias) > > On 16/05/2013 6:48 AM, BILL PITTORE wrote: >> Some architecture dependent flags do not make it through to the >> libjsig.so and libsaproc.so makefiles. As a result, the libs are not >> compiled/linked with the correct flags for that particular variant. Fix >> is to make sure EXTRA_CFLAGS propogates down correctly. >> >> http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/ > > I need to look closer at this. Passing all of the EXTRA_CFLAGS as link > options seems wrong to me as they may not be valid linker options. > That said I see that in this case we are actually using the C compiler > to do the linking. But that said, in the saproc case we are also > compiling C source files at the same time which means that > EXTRA_CFLAGS is needed on the main command line, not tucked onto the > LD flags. And the implication here is that cross-compilation of > libsaproc has been broken all this time for any platform where the > default gcc output would be wrong! Just took a look at an ARM build with and without my changes and without the changes you do not get any of the EXTRA_CFLAGS options when you compile the libjsig or libsaproc sources. You basically get the default for the cross tool gcc you are using, in this case ARM v5t. Could be different for other cross tools. We've just been lucky I guess. bill > > David > From poonam.bajaj at oracle.com Wed May 15 18:26:23 2013 From: poonam.bajaj at oracle.com (Poonam Bajaj) Date: Thu, 16 May 2013 06:56:23 +0530 Subject: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException In-Reply-To: <5188EE30.4010005@oracle.com> References: <517FF943.6020906@oracle.com> <5182660D.8010105@oracle.com> <51837619.500@oracle.com> <5188EE30.4010005@oracle.com> Message-ID: <519435BF.4000201@oracle.com> Hi Kevin, The changes look good. Thanks, Poonam On 5/7/2013 5:36 PM, Kevin Walls wrote: > Hi - > > I'd like to get another review from an openjdk user/reviewer/... > > Thanks > Kevin > > > On 03/05/13 09:32, Kevin Walls wrote: >> Thanks Staffan, thanks Peter! >> >> >> On 02/05/13 14:11, Peter Allwin wrote: >>> Hi Kevin, >>> >>> Looks good! >>> >>> I've been looking into improving the quality of native stack traces >>> on Windows using IDebugControl::GetStackTrace. This has the >>> advantage of handling some FPO frames on x86 (a common source of >>> these exceptions), as well as supporting AMD64 (walking the stack >>> using RBP does not work at all on Windows/X64). There are still some >>> issues to iron out before this change is ready, but your fix is a >>> good start to what I'd like to accomplish. >>> >>> >>> Thanks, >>> >>> Peter >>> >>>> ------------------------------------------------------------------------ >>>> >>>> Kevin Walls >>>> Tuesday, April 30, 2013 7:02 PM >>>> >>>> >>>> Hi, >>>> >>>> I'd like some review of this suggestion to fix: >>>> 6313816 SA windows unaligned address exception >>>> >>>> webrev: >>>> http://cr.openjdk.java.net/~kevinw/6313816/webrev/ >>>> >>>> This bug is a long-standing annoyance, mainly shown by using jstack -m >>>> >>>> Already fixed on Linux with additional sanity checks on ebp/rbp >>>> values in >>>> e.g. LinuxX86CFrame.sender() >>>> >>>> On Windows there isn't such a convenient place to put these checks, >>>> as they >>>> call getAddressValue() which is only part of the specific debugger >>>> interfaces >>>> such as LinuxDebugger, WindbgDebugger, etc.. and on Windows we use >>>> X86CFrame and AMD64CFrame. These are constructed with only a >>>> CDebugger, there is no "WinXXXFrame" class - perhaps there should be! >>>> >>>> That's what I've tried here, by renaming e.g. X86CFrame to >>>> WinX86CFrame, >>>> and adding the extra sanity checks as we already have in >>>> LinuxX86CFrame. >>>> >>>> As files have move thed diff isn't obvious, but in common with some >>>> previous changes >>>> the new bits are x86 and x64 versions of these: >>>> >>>> + // Check alignment of rbp >>>> + if ( dbg.getAddressValue(rbp) % ADDRESS_SIZE != 0) { >>>> + return null; >>>> + } >>>> + >>>> >>>> and >>>> >>>> - if (nextRBP == null) { >>>> + if (nextRBP == null || nextRBP.lessThanOrEqual(rbp)) { >>>> >>>> >>>> This additional symmetry between the platforms seems to make sense, >>>> and >>>> should help any future changes. >>>> >>>> Thanks >>>> Kevin >>>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130516/d2d3e90c/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130516/d2d3e90c/compose-unknown-contact-0001.jpg From bill.pittore at oracle.com Wed May 15 18:37:36 2013 From: bill.pittore at oracle.com (BILL PITTORE) Date: Wed, 15 May 2013 21:37:36 -0400 Subject: Fix for 8014669, build flags issue In-Reply-To: <51942BA2.4030209@oracle.com> References: <5193F495.2020600@oracle.com> <519422DB.705@oracle.com> <51942BA2.4030209@oracle.com> Message-ID: <51943860.3020301@oracle.com> I'm fine with these changes. I can commit if someone can do the push if you think we need to get this in tonight. bill On 5/15/2013 8:43 PM, David Holmes wrote: > Hi Bill, > > On 16/05/2013 10:05 AM, David Holmes wrote: >> Hi Bill, >> >> (re-fixed the build-dev alias) >> >> On 16/05/2013 6:48 AM, BILL PITTORE wrote: >>> Some architecture dependent flags do not make it through to the >>> libjsig.so and libsaproc.so makefiles. As a result, the libs are not >>> compiled/linked with the correct flags for that particular variant. Fix >>> is to make sure EXTRA_CFLAGS propogates down correctly. >>> >>> http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/ >> >> I need to look closer at this. Passing all of the EXTRA_CFLAGS as link >> options seems wrong to me as they may not be valid linker options. That >> said I see that in this case we are actually using the C compiler to do >> the linking. But that said, in the saproc case we are also compiling C >> source files at the same time which means that EXTRA_CFLAGS is needed on >> the main command line, not tucked onto the LD flags. And the implication >> here is that cross-compilation of libsaproc has been broken all this >> time for any platform where the default gcc output would be wrong! > > Given in both cases we use CC to compile and link I think the more > explicit solution here is to add EXTRA_CFLAGS as a primary argument to > the $(CC) invocation - see below. > > Thanks, > David > > diff -r 293b99787401 make/linux/makefiles/jsig.make > --- a/make/linux/makefiles/jsig.make > +++ b/make/linux/makefiles/jsig.make > @@ -54,7 +54,7 @@ > $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) > @echo Making signal interposition lib... > $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) > $(PICFLAG) \ > - $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) -o $@ $< > -ldl > + $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) > $(EXTRA_CFLAGS) -o $@ $< -ldl > ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) > $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO) > $(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@ > diff -r 293b99787401 make/linux/makefiles/saproc.make > --- a/make/linux/makefiles/saproc.make > +++ b/make/linux/makefiles/saproc.make > @@ -92,6 +92,7 @@ > $(SASRCFILES) \ > $(SA_LFLAGS) \ > $(SA_DEBUG_CFLAGS) \ > + $(EXTRA_CFLAGS) \ > -o $@ \ > -lthread_db > ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) > From valerie.peng at oracle.com Wed May 15 18:43:12 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Thu, 16 May 2013 01:43:12 +0000 Subject: hg: jdk8/tl/jdk: 5 new changesets Message-ID: <20130516014410.ECFD148AE4@hg.openjdk.java.net> Changeset: 2ec31660cc0e Author: valeriep Date: 2013-05-07 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ec31660cc0e 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps should be protected Summary: Change the finalize method of PKCS11 class to be protected. Reviewed-by: xuelei ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java Changeset: 991420add35d Author: valeriep Date: 2013-05-07 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/991420add35d 7196009: SunPkcs11 provider fails to parse config path containing parenthesis Summary: Enhanced to allow quoted string as library path values. Reviewed-by: weijun ! src/share/classes/sun/security/pkcs11/Config.java ! test/sun/security/pkcs11/Provider/ConfigShortPath.java + test/sun/security/pkcs11/Provider/cspQuotedPath.cfg Changeset: 804da1e9bd04 Author: ascarpino Date: 2013-05-07 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/804da1e9bd04 8001284: Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR Summary: Changed output length calculation to include incomplete blocks for CTR mode. Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! test/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java Changeset: fc70416beef3 Author: valeriep Date: 2013-05-13 16:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc70416beef3 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 59357ea7f131 Author: valeriep Date: 2013-05-15 18:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59357ea7f131 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java From david.holmes at oracle.com Wed May 15 19:34:17 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 16 May 2013 12:34:17 +1000 Subject: Fix for 8014669, build flags issue In-Reply-To: <51943860.3020301@oracle.com> References: <5193F495.2020600@oracle.com> <519422DB.705@oracle.com> <51942BA2.4030209@oracle.com> <51943860.3020301@oracle.com> Message-ID: <519445A9.1090501@oracle.com> On 16/05/2013 11:37 AM, BILL PITTORE wrote: > I'm fine with these changes. I can commit if someone can do the push if > you think we need to get this in tonight. I can push for you but I don't think this will get in "tonight" nor in time for this week's build. We also need a backport for hs24. Thanks, David > bill > > On 5/15/2013 8:43 PM, David Holmes wrote: >> Hi Bill, >> >> On 16/05/2013 10:05 AM, David Holmes wrote: >>> Hi Bill, >>> >>> (re-fixed the build-dev alias) >>> >>> On 16/05/2013 6:48 AM, BILL PITTORE wrote: >>>> Some architecture dependent flags do not make it through to the >>>> libjsig.so and libsaproc.so makefiles. As a result, the libs are not >>>> compiled/linked with the correct flags for that particular variant. Fix >>>> is to make sure EXTRA_CFLAGS propogates down correctly. >>>> >>>> http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/ >>> >>> I need to look closer at this. Passing all of the EXTRA_CFLAGS as link >>> options seems wrong to me as they may not be valid linker options. That >>> said I see that in this case we are actually using the C compiler to do >>> the linking. But that said, in the saproc case we are also compiling C >>> source files at the same time which means that EXTRA_CFLAGS is needed on >>> the main command line, not tucked onto the LD flags. And the implication >>> here is that cross-compilation of libsaproc has been broken all this >>> time for any platform where the default gcc output would be wrong! >> >> Given in both cases we use CC to compile and link I think the more >> explicit solution here is to add EXTRA_CFLAGS as a primary argument to >> the $(CC) invocation - see below. >> >> Thanks, >> David >> >> diff -r 293b99787401 make/linux/makefiles/jsig.make >> --- a/make/linux/makefiles/jsig.make >> +++ b/make/linux/makefiles/jsig.make >> @@ -54,7 +54,7 @@ >> $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) >> @echo Making signal interposition lib... >> $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) >> $(PICFLAG) \ >> - $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) -o $@ $< >> -ldl >> + $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) >> $(EXTRA_CFLAGS) -o $@ $< -ldl >> ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) >> $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO) >> $(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@ >> diff -r 293b99787401 make/linux/makefiles/saproc.make >> --- a/make/linux/makefiles/saproc.make >> +++ b/make/linux/makefiles/saproc.make >> @@ -92,6 +92,7 @@ >> $(SASRCFILES) \ >> $(SA_LFLAGS) \ >> $(SA_DEBUG_CFLAGS) \ >> + $(EXTRA_CFLAGS) \ >> -o $@ \ >> -lthread_db >> ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) >> > > From rickard.backman at oracle.com Wed May 15 21:57:10 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Thu, 16 May 2013 06:57:10 +0200 Subject: RFR(XS): 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd In-Reply-To: <5193A27B.2070304@oracle.com> References: <9429B07B-0B50-4D48-8B85-09D93DD5A0D5@oracle.com> <5193A27B.2070304@oracle.com> Message-ID: <215C7E5A-DD25-4413-97DD-0530B6BB24D2@oracle.com> Serguei, thank you for the review! /R On May 15, 2013, at 4:58 PM, serguei.spitsyn at oracle.com wrote: > Hi Rickard, > > I think, the fix is good. > But the code that was fixed was harmless as a memory leak > described in the report never really happened. > It is still a nice clean up. :) > > Thanks, > Serguei > > On 5/15/13 2:37 AM, Rickard B?ckman wrote: >> Hi all, >> >> can I please have this change reviewed? >> >> My interpretation is that this isn't really a bug, since the parameter sig_type is never set to [. >> The suggested change is to remove the check for [ in the if and add an assert. I also created a boolean >> to track handle creation to simplify cleanup. >> >> The caller of this method is InterpreterRuntime::post_field_modification >> which sets the sig_type to: >> >> switch(cp_entry->flag_state()) { >> case btos: sig_type = 'Z'; break; >> case ctos: sig_type = 'C'; break; >> case stos: sig_type = 'S'; break; >> case itos: sig_type = 'I'; break; >> case ftos: sig_type = 'F'; break; >> case atos: sig_type = 'L'; break; >> case ltos: sig_type = 'J'; break; >> case dtos: sig_type = 'D'; break; >> default: ShouldNotReachHere(); return; >> } >> >> Testing done: nsk.jvmti.testlist with fastdebug build. >> >> Webrev: http://cr.openjdk.java.net/~rbackman/4965252/ >> >> Thanks >> /R >> >> >> > From david.holmes at oracle.com Wed May 15 22:12:53 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 16 May 2013 15:12:53 +1000 Subject: RFR(XS): 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd In-Reply-To: <9429B07B-0B50-4D48-8B85-09D93DD5A0D5@oracle.com> References: <9429B07B-0B50-4D48-8B85-09D93DD5A0D5@oracle.com> Message-ID: <51946AD5.4090109@oracle.com> Hi Rickard, On 15/05/2013 7:37 PM, Rickard B?ckman wrote: > can I please have this change reviewed? > > My interpretation is that this isn't really a bug, since the parameter sig_type is never set to [. Right - it looks like a bug visually but turns out to be dead code. FYI the "sig_type == '['" was added to the if under 4639363 - no idea why. I don't see [ ever being used for sigtype. > The suggested change is to remove the check for [ in the if and add an assert. I also created a boolean > to track handle creation to simplify cleanup. Not sure the boolean was worth the effort - the existing check for L suffices. :) Even the assert seems overly conservative given the single caller :) Still trying to decide what was meant in the bug report about the lack of an "enclosing handle block" ?? Good to go if it hasn't already :) Cheers, David > > The caller of this method is InterpreterRuntime::post_field_modification > which sets the sig_type to: > > switch(cp_entry->flag_state()) { > case btos: sig_type = 'Z'; break; > case ctos: sig_type = 'C'; break; > case stos: sig_type = 'S'; break; > case itos: sig_type = 'I'; break; > case ftos: sig_type = 'F'; break; > case atos: sig_type = 'L'; break; > case ltos: sig_type = 'J'; break; > case dtos: sig_type = 'D'; break; > default: ShouldNotReachHere(); return; > } > > Testing done: nsk.jvmti.testlist with fastdebug build. > > Webrev: http://cr.openjdk.java.net/~rbackman/4965252/ > > Thanks > /R > > > From rickard.backman at oracle.com Wed May 15 22:48:45 2013 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Thu, 16 May 2013 07:48:45 +0200 Subject: RFR(XS): 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd In-Reply-To: <51946AD5.4090109@oracle.com> References: <9429B07B-0B50-4D48-8B85-09D93DD5A0D5@oracle.com> <51946AD5.4090109@oracle.com> Message-ID: <688A5CD3-E878-4A13-BDFE-E18FCB17B0A6@oracle.com> David, On May 16, 2013, at 7:12 AM, David Holmes wrote: > Hi Rickard, > > On 15/05/2013 7:37 PM, Rickard B?ckman wrote: >> can I please have this change reviewed? >> >> My interpretation is that this isn't really a bug, since the parameter sig_type is never set to [. > > Right - it looks like a bug visually but turns out to be dead code. FYI the "sig_type == '['" was added to the if under 4639363 - no idea why. I don't see [ ever being used for sigtype. +1 > >> The suggested change is to remove the check for [ in the if and add an assert. I also created a boolean >> to track handle creation to simplify cleanup. > > Not sure the boolean was worth the effort - the existing check for L suffices. :) Sure, but I like not repeating checks :) > > Even the assert seems overly conservative given the single caller :) At least it is safe. > > Still trying to decide what was meant in the bug report about the lack of an "enclosing handle block" ?? My guess was that we have tried to do { make_local() destroy_local() } I don't think this makes things clearer in this case. > > Good to go if it hasn't already :) Thank you for the review. (Too late to make it to the list though :) ) /R > > Cheers, > David > > >> >> The caller of this method is InterpreterRuntime::post_field_modification >> which sets the sig_type to: >> >> switch(cp_entry->flag_state()) { >> case btos: sig_type = 'Z'; break; >> case ctos: sig_type = 'C'; break; >> case stos: sig_type = 'S'; break; >> case itos: sig_type = 'I'; break; >> case ftos: sig_type = 'F'; break; >> case atos: sig_type = 'L'; break; >> case ltos: sig_type = 'J'; break; >> case dtos: sig_type = 'D'; break; >> default: ShouldNotReachHere(); return; >> } >> >> Testing done: nsk.jvmti.testlist with fastdebug build. >> >> Webrev: http://cr.openjdk.java.net/~rbackman/4965252/ >> >> Thanks >> /R >> >> >> From staffan.larsen at oracle.com Wed May 15 23:24:07 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 16 May 2013 08:24:07 +0200 Subject: Fix for 8014669, build flags issue In-Reply-To: <51943860.3020301@oracle.com> References: <5193F495.2020600@oracle.com> <519422DB.705@oracle.com> <51942BA2.4030209@oracle.com> <51943860.3020301@oracle.com> Message-ID: <2015F2D2-584C-4A1B-894C-64BEBCEBF66B@oracle.com> David's change looks good to me. /Staffan On 16 maj 2013, at 03:37, BILL PITTORE wrote: > I'm fine with these changes. I can commit if someone can do the push if you think we need to get this in tonight. > > bill > > On 5/15/2013 8:43 PM, David Holmes wrote: >> Hi Bill, >> >> On 16/05/2013 10:05 AM, David Holmes wrote: >>> Hi Bill, >>> >>> (re-fixed the build-dev alias) >>> >>> On 16/05/2013 6:48 AM, BILL PITTORE wrote: >>>> Some architecture dependent flags do not make it through to the >>>> libjsig.so and libsaproc.so makefiles. As a result, the libs are not >>>> compiled/linked with the correct flags for that particular variant. Fix >>>> is to make sure EXTRA_CFLAGS propogates down correctly. >>>> >>>> http://cr.openjdk.java.net/~bpittore/8014669/webrev.00/ >>> >>> I need to look closer at this. Passing all of the EXTRA_CFLAGS as link >>> options seems wrong to me as they may not be valid linker options. That >>> said I see that in this case we are actually using the C compiler to do >>> the linking. But that said, in the saproc case we are also compiling C >>> source files at the same time which means that EXTRA_CFLAGS is needed on >>> the main command line, not tucked onto the LD flags. And the implication >>> here is that cross-compilation of libsaproc has been broken all this >>> time for any platform where the default gcc output would be wrong! >> >> Given in both cases we use CC to compile and link I think the more explicit solution here is to add EXTRA_CFLAGS as a primary argument to the $(CC) invocation - see below. >> >> Thanks, >> David >> >> diff -r 293b99787401 make/linux/makefiles/jsig.make >> --- a/make/linux/makefiles/jsig.make >> +++ b/make/linux/makefiles/jsig.make >> @@ -54,7 +54,7 @@ >> $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) >> @echo Making signal interposition lib... >> $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) $(PICFLAG) \ >> - $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) -o $@ $< -ldl >> + $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(EXTRA_CFLAGS) -o $@ $< -ldl >> ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) >> $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO) >> $(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@ >> diff -r 293b99787401 make/linux/makefiles/saproc.make >> --- a/make/linux/makefiles/saproc.make >> +++ b/make/linux/makefiles/saproc.make >> @@ -92,6 +92,7 @@ >> $(SASRCFILES) \ >> $(SA_LFLAGS) \ >> $(SA_DEBUG_CFLAGS) \ >> + $(EXTRA_CFLAGS) \ >> -o $@ \ >> -lthread_db >> ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) >> > > From staffan.larsen at oracle.com Wed May 15 23:30:20 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 16 May 2013 08:30:20 +0200 Subject: RFR [8014676] Java debugger may fail to run In-Reply-To: <5193F8A3.3080809@oracle.com> References: <5193F8A3.3080809@oracle.com> Message-ID: <691FC627-2954-45E4-9A93-E85408AF0DF9@oracle.com> Looks good! /Staffan On 15 maj 2013, at 23:05, Ivan Gerasimov wrote: > Hello everybody! > > Would you please help with reviewing the fix? > The fix is for jdk8. It is also applicable to jdk7 and will be proposed, if it's accepted here. > > WEBREV: http://cr.openjdk.java.net/~robm/8014676/webrev.01/ > BUG: http://bugs.sun.com/view_bug.do?bug_id=8014676 (may not be available yet) > > The problem is observed when the binaries for windows are placed under a path which contains a space. > > Sincerely, > Ivan From kevin.walls at oracle.com Wed May 15 23:29:26 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 16 May 2013 07:29:26 +0100 Subject: RR 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException In-Reply-To: <519435BF.4000201@oracle.com> References: <517FF943.6020906@oracle.com> <5182660D.8010105@oracle.com> <51837619.500@oracle.com> <5188EE30.4010005@oracle.com> <519435BF.4000201@oracle.com> Message-ID: <51947CC6.2050607@oracle.com> Thanks Poonam! On 16/05/13 02:26, Poonam Bajaj wrote: > Hi Kevin, > > The changes look good. > > Thanks, > Poonam > > On 5/7/2013 5:36 PM, Kevin Walls wrote: >> Hi - >> >> I'd like to get another review from an openjdk user/reviewer/... >> >> Thanks >> Kevin >> >> >> On 03/05/13 09:32, Kevin Walls wrote: >>> Thanks Staffan, thanks Peter! >>> >>> >>> On 02/05/13 14:11, Peter Allwin wrote: >>>> Hi Kevin, >>>> >>>> Looks good! >>>> >>>> I've been looking into improving the quality of native stack traces >>>> on Windows using IDebugControl::GetStackTrace. This has the >>>> advantage of handling some FPO frames on x86 (a common source of >>>> these exceptions), as well as supporting AMD64 (walking the stack >>>> using RBP does not work at all on Windows/X64). There are still >>>> some issues to iron out before this change is ready, but your fix >>>> is a good start to what I'd like to accomplish. >>>> >>>> >>>> Thanks, >>>> >>>> Peter >>>> >>>>> ------------------------------------------------------------------------ >>>>> >>>>> Kevin Walls >>>>> Tuesday, April 30, 2013 7:02 PM >>>>> >>>>> >>>>> Hi, >>>>> >>>>> I'd like some review of this suggestion to fix: >>>>> 6313816 SA windows unaligned address exception >>>>> >>>>> webrev: >>>>> http://cr.openjdk.java.net/~kevinw/6313816/webrev/ >>>>> >>>>> This bug is a long-standing annoyance, mainly shown by using >>>>> jstack -m >>>>> >>>>> Already fixed on Linux with additional sanity checks on ebp/rbp >>>>> values in >>>>> e.g. LinuxX86CFrame.sender() >>>>> >>>>> On Windows there isn't such a convenient place to put these >>>>> checks, as they >>>>> call getAddressValue() which is only part of the specific debugger >>>>> interfaces >>>>> such as LinuxDebugger, WindbgDebugger, etc.. and on Windows we use >>>>> X86CFrame and AMD64CFrame. These are constructed with only a >>>>> CDebugger, there is no "WinXXXFrame" class - perhaps there should be! >>>>> >>>>> That's what I've tried here, by renaming e.g. X86CFrame to >>>>> WinX86CFrame, >>>>> and adding the extra sanity checks as we already have in >>>>> LinuxX86CFrame. >>>>> >>>>> As files have move thed diff isn't obvious, but in common with >>>>> some previous changes >>>>> the new bits are x86 and x64 versions of these: >>>>> >>>>> + // Check alignment of rbp >>>>> + if ( dbg.getAddressValue(rbp) % ADDRESS_SIZE != 0) { >>>>> + return null; >>>>> + } >>>>> + >>>>> >>>>> and >>>>> >>>>> - if (nextRBP == null) { >>>>> + if (nextRBP == null || nextRBP.lessThanOrEqual(rbp)) { >>>>> >>>>> >>>>> This additional symmetry between the platforms seems to make >>>>> sense, and >>>>> should help any future changes. >>>>> >>>>> Thanks >>>>> Kevin >>>>> >>> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130516/b4d98c16/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130516/b4d98c16/compose-unknown-contact.jpg From rickard.backman at oracle.com Wed May 15 23:59:19 2013 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Thu, 16 May 2013 06:59:19 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd Message-ID: <20130516065924.247FA48AF0@hg.openjdk.java.net> Changeset: f49e0508a38a Author: rbackman Date: 2013-05-15 11:30 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f49e0508a38a 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd Reviewed-by: coleenp, sspitsyn ! src/share/vm/prims/jvmtiExport.cpp From Alan.Bateman at oracle.com Thu May 16 01:52:29 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 16 May 2013 09:52:29 +0100 Subject: RFR [8014676] Java debugger may fail to run In-Reply-To: <5193F8A3.3080809@oracle.com> References: <5193F8A3.3080809@oracle.com> Message-ID: <51949E4D.1090002@oracle.com> On 15/05/2013 22:05, Ivan Gerasimov wrote: > Hello everybody! > > Would you please help with reviewing the fix? > The fix is for jdk8. It is also applicable to jdk7 and will be > proposed, if it's accepted here. > > WEBREV: http://cr.openjdk.java.net/~robm/8014676/webrev.01/ > > BUG: http://bugs.sun.com/view_bug.do?bug_id=8014676 (may not be > available yet) > > The problem is observed when the binaries for windows are placed under > a path which contains a space. > > Sincerely, > Ivan Looks good to me too, I assume this one was only noticed after the recent changes to the Runtime.exec implementation on Windows. -Alan From chris.hegarty at oracle.com Thu May 16 03:06:05 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 16 May 2013 10:06:05 +0000 Subject: hg: jdk8/tl/jdk: 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up Message-ID: <20130516100639.24F4548AF8@hg.openjdk.java.net> Changeset: bb01cc14223c Author: ewang Date: 2013-05-16 10:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb01cc14223c 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up Reviewed-by: alanb, dholmes, chegar ! test/java/lang/Thread/GenerifyStackTraces.java - test/java/lang/Thread/StackTraces.java From ivan.gerasimov at oracle.com Thu May 16 03:58:06 2013 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 16 May 2013 14:58:06 +0400 Subject: RFR [8014676] Java debugger may fail to run In-Reply-To: <51949E4D.1090002@oracle.com> References: <5193F8A3.3080809@oracle.com> <51949E4D.1090002@oracle.com> Message-ID: <5194BBBE.8050006@oracle.com> On 16.05.2013 12:52, Alan Bateman wrote: > On 15/05/2013 22:05, Ivan Gerasimov wrote: >> Hello everybody! >> >> Would you please help with reviewing the fix? >> The fix is for jdk8. It is also applicable to jdk7 and will be >> proposed, if it's accepted here. >> >> WEBREV: http://cr.openjdk.java.net/~robm/8014676/webrev.01/ >> >> BUG: http://bugs.sun.com/view_bug.do?bug_id=8014676 (may not be >> available yet) >> >> The problem is observed when the binaries for windows are placed >> under a path which contains a space. >> >> Sincerely, >> Ivan > Looks good to me too, I assume this one was only noticed after the > recent changes to the Runtime.exec implementation on Windows. > Correct! The regression was noticed trying to upgrade from 7u17 to 7u21. Ivan > -Alan > > From xuelei.fan at oracle.com Thu May 16 04:32:05 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 16 May 2013 11:32:05 +0000 Subject: hg: jdk8/tl/jdk: 8010814: More buffers are stored or returned without cloning Message-ID: <20130516113218.341CD48AF9@hg.openjdk.java.net> Changeset: b198389f9da4 Author: xuelei Date: 2013-05-16 04:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b198389f9da4 8010814: More buffers are stored or returned without cloning Reviewed-by: lancea ! src/share/classes/com/sun/jndi/ldap/BerDecoder.java ! src/share/classes/com/sun/jndi/ldap/BerEncoder.java ! src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java From christian.tornqvist at oracle.com Thu May 16 08:50:02 2013 From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com) Date: Thu, 16 May 2013 15:50:02 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header Message-ID: <20130516155008.4F89748B00@hg.openjdk.java.net> Changeset: 243469d929e6 Author: ctornqvi Date: 2013-05-16 15:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/243469d929e6 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header Summary: Re-wrote test in Java in addition to fixing the Copyright notice. Also reviewed by leonid.mesnik at oracle.com Reviewed-by: coleenp, ctornqvi Contributed-by: Mikhailo Seledtsov - test/runtime/7158804/Test7158804.sh + test/runtime/CommandLine/ConfigFileParsing.java From dmitry.degrave at oracle.com Thu May 16 09:30:48 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Thu, 16 May 2013 16:30:48 +0000 Subject: hg: jdk8/tl/jdk: 8014676: Java debugger may fail to run Message-ID: <20130516163105.B15E948B04@hg.openjdk.java.net> Changeset: 81c449fd18fe Author: dmeetry Date: 2013-05-16 19:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81c449fd18fe 8014676: Java debugger may fail to run Summary: The problem is observed when the binaries for windows are placed under a path which contains a space Reviewed-by: sla, alanb Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/com/sun/tools/jdi/AbstractLauncher.java ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java From michael.x.mcmahon at oracle.com Thu May 16 09:32:08 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 16 May 2013 16:32:08 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130516163231.64FEE48B05@hg.openjdk.java.net> Changeset: 74f91b7f4b66 Author: michaelm Date: 2013-05-16 17:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74f91b7f4b66 8012625: Incorrect handling of HTTP/1.1 " Expect: 100-continue " in HttpURLConnection Reviewed-by: alanb, chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/B8012625.java Changeset: d02d1b18d828 Author: michaelm Date: 2013-05-16 17:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d02d1b18d828 Merge From daniel.fuchs at oracle.com Thu May 16 09:41:20 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Thu, 16 May 2013 16:41:20 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130516164146.B2CAB48B06@hg.openjdk.java.net> Changeset: da203779cb33 Author: jgish Date: 2013-05-16 11:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da203779cb33 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java - test/java/util/logging/bundlesearch/LoadItUp.java + test/java/util/logging/bundlesearch/LoadItUp1.java + test/java/util/logging/bundlesearch/LoadItUp2.java + test/java/util/logging/bundlesearch/LoadItUp2Invoker.java ! test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java + test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java + test/java/util/logging/bundlesearch/resources/CallerSearchableResource_en.properties Changeset: df133f9cc4c9 Author: dfuchs Date: 2013-05-16 18:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df133f9cc4c9 Merge From kurchi.subhra.hazra at oracle.com Thu May 16 10:48:47 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Thu, 16 May 2013 17:48:47 +0000 Subject: hg: jdk8/tl/jdk: 7150552: network test hangs [macosx] Message-ID: <20130516174910.E623248B08@hg.openjdk.java.net> Changeset: a8be9405bb4b Author: khazra Date: 2013-05-16 10:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8be9405bb4b 7150552: network test hangs [macosx] Summary: Remove usage of test/sun/net/www/httptest Reviewed-by: chegar ! test/ProblemList.txt ! test/java/net/CookieHandler/CookieManagerTest.java ! test/sun/net/www/protocol/http/B6299712.java From kumar.x.srinivasan at oracle.com Thu May 16 11:13:57 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 16 May 2013 18:13:57 +0000 Subject: hg: jdk8/tl/jdk: 8001163: [pack200] should support attributes introduced by JSR-308 Message-ID: <20130516181409.97BD148B0A@hg.openjdk.java.net> Changeset: a13de892cefd Author: ksrini Date: 2013-05-15 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a13de892cefd 8001163: [pack200] should support attributes introduced by JSR-308 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/AttributeTests.java + test/tools/pack200/BandIntegrity.java ! test/tools/pack200/InstructionTests.java ! test/tools/pack200/Utils.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java + test/tools/pack200/typeannos/Lambda.java + test/tools/pack200/typeannos/Readme.txt + test/tools/pack200/typeannos/TargetTypes.java + test/tools/pack200/typeannos/TestTypeAnnotations.java + test/tools/pack200/typeannos/TypeUseTarget.java From christian.tornqvist at oracle.com Thu May 16 11:18:25 2013 From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com) Date: Thu, 16 May 2013 18:18:25 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014511: runtime/RedefineObject/TestRedefineObject.java has incorrect classname in @run tag Message-ID: <20130516181829.E816D48B0B@hg.openjdk.java.net> Changeset: 17db82f22f1e Author: ctornqvi Date: 2013-05-16 17:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/17db82f22f1e 8014511: runtime/RedefineObject/TestRedefineObject.java has incorrect classname in @run tag Summary: Corrected the class name Reviewed-by: coleenp, ctornqvi, hseigel Contributed-by: Mikhailo Seledtsov ! test/runtime/RedefineObject/TestRedefineObject.java From vincent.x.ryan at oracle.com Thu May 16 13:27:29 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Thu, 16 May 2013 20:27:29 +0000 Subject: hg: jdk8/tl/jdk: 6 new changesets Message-ID: <20130516202851.8AD0048B18@hg.openjdk.java.net> Changeset: 9abf5dc83823 Author: vinnie Date: 2013-05-14 18:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9abf5dc83823 7194075: Various classes of sunec.jar are duplicated in rt.jar Reviewed-by: mullan, vinnie Contributed-by: Stephen Flores ! make/sun/security/ec/Makefile ! make/sun/security/other/Makefile ! makefiles/CreateJars.gmk + src/share/classes/sun/security/ec/CurveDB.java ! src/share/classes/sun/security/ec/ECDHKeyAgreement.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/ECKeyPairGenerator.java ! src/share/classes/sun/security/ec/ECParameters.java ! src/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/share/classes/sun/security/ec/ECPublicKeyImpl.java ! src/share/classes/sun/security/ec/NamedCurve.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/classes/sun/security/pkcs11/P11KeyStore.java ! src/share/classes/sun/security/ssl/JsseJce.java + src/share/classes/sun/security/util/ECKeySizeParameterSpec.java + src/share/classes/sun/security/util/ECUtil.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/ec/TestECDH2.java ! test/sun/security/pkcs11/ec/TestECDSA2.java Changeset: fdf082cddb69 Author: vinnie Date: 2013-05-14 18:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fdf082cddb69 Merge Changeset: a399b8be56ae Author: vinnie Date: 2013-05-15 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a399b8be56ae Merge ! makefiles/CreateJars.gmk - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider Changeset: 5153f5154162 Author: vinnie Date: 2013-05-15 15:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5153f5154162 Merge Changeset: 0465f27f19f5 Author: vinnie Date: 2013-05-16 02:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0465f27f19f5 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java Changeset: 9783f07d43e6 Author: vinnie Date: 2013-05-16 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9783f07d43e6 Merge - test/java/lang/Thread/StackTraces.java - test/java/util/logging/bundlesearch/LoadItUp.java From mandy.chung at oracle.com Thu May 16 15:09:08 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 16 May 2013 22:09:08 +0000 Subject: hg: jdk8/tl/jdk: 4487672: (proxy) Proxy constructor should check for null argument Message-ID: <20130516220926.D7A1648B1C@hg.openjdk.java.net> Changeset: 5e8959ab64af Author: mchung Date: 2013-05-16 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e8959ab64af 4487672: (proxy) Proxy constructor should check for null argument Reviewed-by: alanb, lancea ! src/share/classes/java/lang/reflect/Proxy.java ! test/java/lang/reflect/Proxy/Basic1.java From kevin.walls at oracle.com Thu May 16 18:16:53 2013 From: kevin.walls at oracle.com (kevin.walls at oracle.com) Date: Fri, 17 May 2013 01:16:53 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException Message-ID: <20130517011655.44B8E48B2D@hg.openjdk.java.net> Changeset: 78332b46e604 Author: kevinw Date: 2013-05-16 12:40 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/78332b46e604 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException Reviewed-by: sla, poonam - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgCDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/windows/amd64/WindowsAMD64CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/windows/x86/WindowsX86CFrame.java ! make/sa.files From david.holmes at oracle.com Thu May 16 20:33:00 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Fri, 17 May 2013 03:33:00 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130517033304.200A548B37@hg.openjdk.java.net> Changeset: 205dd30230e1 Author: shade Date: 2013-05-17 01:43 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205dd30230e1 8012939: @Contended doesn't work correctly with inheritance Summary: Fix instance_size miscalculation. Reviewed-by: jrose, kvn ! src/share/vm/classfile/classFileParser.cpp + test/runtime/contended/Inheritance1.java Changeset: b334821dad92 Author: dholmes Date: 2013-05-16 21:19 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b334821dad92 Merge From john.coomes at oracle.com Thu May 16 22:34:25 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 17 May 2013 05:34:25 +0000 Subject: hg: hsx/hotspot-rt/corba: 6 new changesets Message-ID: <20130517053431.D592D48B53@hg.openjdk.java.net> Changeset: 8f0a461776a9 Author: dmeetry Date: 2013-04-29 16:44 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/8f0a461776a9 4504275: CORBA boolean type unions do not generate compilable code from idlj Summary: JLS doesn't allow boolean type in switch statement, hence substituted by if statement. Reviewed-by: lancea ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/UnionGen.java Changeset: 846aaf02e516 Author: dmeetry Date: 2013-04-29 16:51 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/846aaf02e516 8011986: [corba] idlj generates read/write union helper methods that throw wrong exception in some cases Reviewed-by: lancea ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/UnionGen.java Changeset: ed59110eecdb Author: lana Date: 2013-04-30 17:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/ed59110eecdb Merge Changeset: fe4150590ee5 Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/fe4150590ee5 Merge Changeset: c8286839d0df Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/c8286839d0df Added tag jdk8-b89 for changeset fe4150590ee5 ! .hgtags Changeset: 8f7ffb296385 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/8f7ffb296385 Added tag jdk8-b90 for changeset c8286839d0df ! .hgtags From john.coomes at oracle.com Thu May 16 22:34:21 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 17 May 2013 05:34:21 +0000 Subject: hg: hsx/hotspot-rt: 9 new changesets Message-ID: <20130517053422.3F2CC48B52@hg.openjdk.java.net> Changeset: e34781a0566b Author: mduigou Date: 2013-04-24 21:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e34781a0566b 8013185: Add java.util.stream to CORE_PKGS.gmk in root repo Reviewed-by: mduigou Contributed-by: Henry Jen ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: e4794ae1016e Author: mduigou Date: 2013-04-24 21:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e4794ae1016e Merge Changeset: 10775618db00 Author: aharlap Date: 2013-04-26 15:54 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/10775618db00 8011152: Precision problems on sflt builds Summary: Need to add global flag to the linker Reviewed-by: tbell, dholmes ! common/makefiles/NativeCompilation.gmk Changeset: a7a8302473d3 Author: mduigou Date: 2013-04-29 14:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/a7a8302473d3 8008632: Additional JavaDoc tags @apiNote, @implSpec and @implNote Reviewed-by: briangoetz, alanb, rriggs ! common/makefiles/javadoc/Javadoc.gmk Changeset: f171aa801ea5 Author: mduigou Date: 2013-04-29 14:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/f171aa801ea5 Merge Changeset: 1603c9216e83 Author: lana Date: 2013-04-30 17:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1603c9216e83 Merge Changeset: 892a0196d10c Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/892a0196d10c Merge ! common/makefiles/NativeCompilation.gmk Changeset: 69b773a221b9 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/69b773a221b9 Added tag jdk8-b89 for changeset 892a0196d10c ! .hgtags Changeset: 83b519cafa68 Author: katleman Date: 2013-05-16 12:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/83b519cafa68 Added tag jdk8-b90 for changeset 69b773a221b9 ! .hgtags From john.coomes at oracle.com Thu May 16 22:34:36 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 17 May 2013 05:34:36 +0000 Subject: hg: hsx/hotspot-rt/jaxp: 7 new changesets Message-ID: <20130517053456.2ECC648B54@hg.openjdk.java.net> Changeset: fad6560cb32a Author: dfuchs Date: 2013-04-17 15:23 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/fad6560cb32a 8005954: JAXP Plugability Layer should use java.util.ServiceLoader Summary: This fix replaces manual processing of files under META-INF/services in JAXP factories by calls to java.util.ServiceLoader. Reviewed-by: alanb, joehw, mchung ! src/javax/xml/datatype/DatatypeFactory.java ! src/javax/xml/datatype/FactoryFinder.java ! src/javax/xml/parsers/DocumentBuilderFactory.java ! src/javax/xml/parsers/FactoryFinder.java ! src/javax/xml/parsers/SAXParserFactory.java ! src/javax/xml/stream/FactoryFinder.java ! src/javax/xml/stream/XMLEventFactory.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/stream/XMLOutputFactory.java ! src/javax/xml/transform/FactoryFinder.java ! src/javax/xml/transform/TransformerFactory.java ! src/javax/xml/validation/SchemaFactory.java + src/javax/xml/validation/SchemaFactoryConfigurationError.java ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactory.java ! src/javax/xml/xpath/XPathFactoryFinder.java Changeset: 1c2079d11a79 Author: dfuchs Date: 2013-04-19 17:22 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/1c2079d11a79 8010495: Update JAXP NetBeans project - add support for generating javadoc Summary: Make it possible to use NetBeans to edit the jaxp sources and to generate a preview of the associated javadoc. Reviewed-by: joehw, alanb ! build.xml ! nbproject/project.xml Changeset: 6c6411a7070f Author: lana Date: 2013-04-23 15:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6c6411a7070f Merge Changeset: be5d6853d821 Author: lana Date: 2013-04-30 17:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/be5d6853d821 Merge Changeset: 893d2ba8bbea Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/893d2ba8bbea Merge Changeset: 668acc0e1034 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/668acc0e1034 Added tag jdk8-b89 for changeset 893d2ba8bbea ! .hgtags Changeset: f39d61028d2f Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/f39d61028d2f Added tag jdk8-b90 for changeset 668acc0e1034 ! .hgtags From john.coomes at oracle.com Thu May 16 22:35:00 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 17 May 2013 05:35:00 +0000 Subject: hg: hsx/hotspot-rt/jaxws: 2 new changesets Message-ID: <20130517053509.12AB648B55@hg.openjdk.java.net> Changeset: 3e5b9ea5ac35 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/3e5b9ea5ac35 Added tag jdk8-b89 for changeset 88838e08e4ef ! .hgtags Changeset: 0bb1a9fa56b0 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/0bb1a9fa56b0 Added tag jdk8-b90 for changeset 3e5b9ea5ac35 ! .hgtags From john.coomes at oracle.com Thu May 16 22:39:44 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 17 May 2013 05:39:44 +0000 Subject: hg: hsx/hotspot-rt/jdk: 81 new changesets Message-ID: <20130517055627.15BE748B56@hg.openjdk.java.net> Changeset: b0c41789f500 Author: jgodinez Date: 2013-04-25 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b0c41789f500 8009199: Printed text become garbage on Mac OSX Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: f4aa34a7a44d Author: jchen Date: 2013-04-29 10:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f4aa34a7a44d 8005302: [findbugs] public methods return internal arrays; may be private Reviewed-by: bae, prr ! src/share/classes/sun/java2d/pipe/AAShapePipe.java Changeset: 46686202aa23 Author: lana Date: 2013-04-30 22:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/46686202aa23 Merge Changeset: c70346f4c0a9 Author: pchelko Date: 2013-04-18 15:09 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c70346f4c0a9 8011686: AWT accidentally disables the NSApplicationDelegate of SWT, causing loss of OS X integration functionality Reviewed-by: anthony, serb Contributed-by: Markus Persson ! src/macosx/native/sun/awt/awt.m Changeset: ac92ac05dde4 Author: kshefov Date: 2013-04-22 18:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ac92ac05dde4 8011230: [TEST_BUG] java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java failed on solaris Reviewed-by: serb, anthony ! test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh Changeset: 578fb8766200 Author: leonidr Date: 2013-04-22 19:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/578fb8766200 8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTEvent.h ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 0894b8476a49 Author: lana Date: 2013-04-23 15:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0894b8476a49 Merge - src/share/classes/java/time/chrono/HijrahDeviationReader.java - src/share/classes/java/time/format/DateTimeBuilder.java - src/share/classes/java/time/format/DateTimeFormatStyleProvider.java - src/share/classes/java/time/temporal/Adjusters.java - src/share/classes/java/time/temporal/Queries.java - src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM - src/share/native/java/lang/ResourceBundle.c - test/java/time/tck/java/time/TestChronology.java - test/java/time/tck/java/time/chrono/TestChronoLocalDate.java - test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java - test/java/time/tck/java/time/chrono/TestHijrahChronology.java - test/java/time/tck/java/time/chrono/TestJapaneseChronology.java - test/java/time/tck/java/time/chrono/TestMinguoChronology.java - test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java - test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java - test/java/time/tck/java/time/temporal/TestChronoLocalDate.java - test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java - test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java - test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java - test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java - test/java/util/ComparatorsTest.java Changeset: 7103434eefe2 Author: kshefov Date: 2013-04-24 11:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7103434eefe2 8011186: [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8 Reviewed-by: anthony, serb, ant - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java + test/java/awt/Focus/SimpleWindowActivationTest/SimpleWindowActivationTest.java Changeset: 854f60ec4bfb Author: anthony Date: 2013-04-26 18:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/854f60ec4bfb 8012586: [x11] Modal dialogs for fullscreen window may show behind its owner Summary: Use the _NET_WM_WINDOW_TYPE_DIALOG type for owned windows Reviewed-by: anthony, art, serb Contributed-by: Vladimir Kravets ! src/solaris/classes/sun/awt/X11/XWindowPeer.java + test/java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java Changeset: e76f3e8e653f Author: malenkov Date: 2013-04-29 16:42 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e76f3e8e653f 8007458: [findbugs] One more beans issue, with ReflectionUtils Reviewed-by: art, alexsch ! src/share/classes/java/beans/MetaData.java - src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/beans/XMLEncoder.java ! test/java/beans/XMLEncoder/AbstractTest.java ! test/java/beans/XMLEncoder/BeanValidator.java ! test/java/beans/XMLEncoder/Test4631471.java ! test/java/beans/XMLEncoder/Test4679556.java ! test/java/beans/XMLEncoder/java_awt_BorderLayout.java + test/java/beans/XMLEncoder/java_awt_CardLayout.java + test/java/beans/XMLEncoder/java_awt_GridBagLayout.java ! test/java/beans/XMLEncoder/javax_swing_DefaultCellEditor.java Changeset: 358acb00cb2d Author: mcherkas Date: 2013-04-30 13:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/358acb00cb2d 8012004: JInternalFrame not being finalized after closing Reviewed-by: alexsch, alexp ! src/share/classes/javax/swing/JDesktopPane.java + test/javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java Changeset: 31e111f82993 Author: serb Date: 2013-04-30 17:27 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/31e111f82993 7166296: closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36 Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: caeedce39396 Author: serb Date: 2013-05-01 12:19 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/caeedce39396 8009012: [macosx] DisplayChangedListener is not implemented in LWWindowPeer/CGraphicsEnvironment Reviewed-by: anthony, bae ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/CGraphicsEnv.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: c357c11f076f Author: lana Date: 2013-05-01 09:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c357c11f076f Merge Changeset: 920ad6c95d93 Author: lana Date: 2013-05-01 11:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/920ad6c95d93 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: 296c9ec816c6 Author: alanb Date: 2013-04-18 11:13 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/296c9ec816c6 8011536: (fs) BasicFileAttributes.creationTime() should return birth time (mac) Reviewed-by: chegar ! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/solaris/classes/sun/nio/fs/UnixChannelFactory.java ! src/solaris/classes/sun/nio/fs/UnixCopyFile.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java + test/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java Changeset: 3c8724085cf7 Author: alanb Date: 2013-04-18 12:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3c8724085cf7 8009648: Tests fail in -agentvm -concurrency mode Reviewed-by: alanb Contributed-by: roger.riggs at oracle.com ! test/Makefile ! test/java/time/TEST.properties Changeset: 3cc833b1fd0c Author: dxu Date: 2013-04-18 10:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3cc833b1fd0c 8011946: java.util.Currency javadoc has broken link to iso.org Reviewed-by: mduigou ! src/share/classes/java/util/Currency.java Changeset: 32c3a580812b Author: mchung Date: 2013-04-18 11:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/32c3a580812b 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt Reviewed-by: lancea, alanb ! test/ProblemList.txt Changeset: 3b81fac25d26 Author: mchung Date: 2013-04-18 13:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3b81fac25d26 8011934: sun.misc.PerfCounter calls Perf.createLong with incorrect parameters Reviewed-by: mchung Contributed-by: Yasumasa Suenaga ! src/share/classes/sun/misc/PerfCounter.java Changeset: 3e4a0fddeb00 Author: jgish Date: 2013-04-18 16:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3e4a0fddeb00 8012005: LogManager needs test to ensure stack trace is not being done to find bundle Reviewed-by: mchung + test/java/util/logging/bundlesearch/ClassPathTestBundle_en.properties + test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java + test/java/util/logging/bundlesearch/LoadItUp.java + test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java + test/java/util/logging/bundlesearch/resources/ContextClassLoaderTestBundle_en.properties + test/java/util/logging/bundlesearch/resources/StackSearchableResource_en.properties Changeset: 7bdb3e186497 Author: xuelei Date: 2013-04-18 22:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7bdb3e186497 8006935: Need to take care of long secret keys in HMAC/PRF compuation Reviewed-by: valeriep ! src/share/classes/com/sun/crypto/provider/TlsPrfGenerator.java Changeset: 778b16225d85 Author: weijun Date: 2013-04-19 15:41 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/778b16225d85 8009636: JARSigner including TimeStamp PolicyID (TSAPolicyID) as defined in RFC3161 Reviewed-by: mullan ! src/share/classes/com/sun/jarsigner/ContentSignerParameters.java ! src/share/classes/sun/security/pkcs/PKCS7.java ! src/share/classes/sun/security/timestamp/TSRequest.java ! src/share/classes/sun/security/timestamp/TimestampToken.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/tools/jarsigner/Resources.java ! src/share/classes/sun/security/tools/jarsigner/TimestampedSigner.java ! test/sun/security/tools/jarsigner/TimestampCheck.java ! test/sun/security/tools/jarsigner/ts.sh Changeset: 90b03f9a2e77 Author: jzavgren Date: 2013-04-17 11:47 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/90b03f9a2e77 8010505: HTTP DIGEST implementation incorrectly quotes header values, fails auth Summary: The extraneous quotes were removed. Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java Changeset: 6139f8fb0137 Author: mduigou Date: 2013-04-16 22:50 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6139f8fb0137 8008670: Initial java.util.stream putback -- internal API classes Reviewed-by: mduigou, dholmes Contributed-by: Brian Goetz , Doug Lea
, Paul Sandoz + src/share/classes/java/util/stream/AbstractShortCircuitTask.java + src/share/classes/java/util/stream/AbstractTask.java + src/share/classes/java/util/stream/FindOps.java + src/share/classes/java/util/stream/ForEachOps.java + src/share/classes/java/util/stream/MatchOps.java + src/share/classes/java/util/stream/Node.java + src/share/classes/java/util/stream/PipelineHelper.java + src/share/classes/java/util/stream/Sink.java + src/share/classes/java/util/stream/StreamOpFlag.java + src/share/classes/java/util/stream/StreamShape.java + src/share/classes/java/util/stream/TerminalOp.java + src/share/classes/java/util/stream/TerminalSink.java + src/share/classes/java/util/stream/Tripwire.java Changeset: e8f1dc6d0c0c Author: jgish Date: 2013-04-19 16:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e8f1dc6d0c0c 8010939: Deadlock in LogManager Summary: re-order locks to avoid deadlock Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java + test/java/util/logging/DrainFindDeadlockTest.java Changeset: 22a27dfd0510 Author: weijun Date: 2013-04-22 11:39 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/22a27dfd0510 8005527: [TEST_BUG] console.sh failed Automatically with exit code 1. Reviewed-by: xuelei ! test/sun/security/tools/keytool/console.sh Changeset: 3ca33647db95 Author: akhil Date: 2013-04-22 09:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3ca33647db95 8001647: default methods for Collections - forEach, removeIf, replaceAll, sort Reviewed-by: alanb, dholmes, mduigou, psandoz, smarks Contributed-by: Akhil Arora , Arne Siegel , Brian Goetz ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/List.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java + test/java/util/Collection/CollectionDefaults.java + test/java/util/Collection/ListDefaults.java + test/java/util/Collection/testlibrary/CollectionAsserts.java + test/java/util/Collection/testlibrary/CollectionSupplier.java Changeset: 2a78d8f1fec1 Author: briangoetz Date: 2013-04-17 14:39 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2a78d8f1fec1 8008682: Inital Streams public API Reviewed-by: mduigou, dholmes, darcy Contributed-by: Brian Goetz , Mike Duigou , Paul Sandoz , JSR-335 EG + src/share/classes/java/util/stream/BaseStream.java + src/share/classes/java/util/stream/CloseableStream.java + src/share/classes/java/util/stream/Collector.java + src/share/classes/java/util/stream/DelegatingStream.java + src/share/classes/java/util/stream/DoubleStream.java + src/share/classes/java/util/stream/IntStream.java + src/share/classes/java/util/stream/LongStream.java + src/share/classes/java/util/stream/Stream.java + src/share/classes/java/util/stream/package-info.java Changeset: 98a7bb7baa76 Author: psandoz Date: 2013-04-17 11:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/98a7bb7baa76 8011426: java.util collection Spliterator implementations Summary: Spliterator implementations for collection classes in java.util. Reviewed-by: mduigou, briangoetz Contributed-by: Doug Lea
, Paul Sandoz ! src/share/classes/java/util/ArrayDeque.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/HashSet.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/LinkedHashSet.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/WeakHashMap.java ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java Changeset: 62fb9e2b5da1 Author: naoto Date: 2013-04-22 13:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/62fb9e2b5da1 8010666: Implement Currency/LocaleNameProvider in Windows Host LocaleProviderAdapter Reviewed-by: okutsu ! src/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: 8b07b318f713 Author: alanb Date: 2013-04-23 15:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8b07b318f713 8012930: (fs) Eliminate recursion from FileTreeWalker Reviewed-by: chegar ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/walkFileTree/CreateFileTree.java ! test/java/nio/file/Files/walkFileTree/MaxDepth.java ! test/java/nio/file/Files/walkFileTree/SkipSiblings.java + test/java/nio/file/Files/walkFileTree/SkipSubtree.java ! test/java/nio/file/Files/walkFileTree/TerminateWalk.java + test/java/nio/file/Files/walkFileTree/find.sh - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh Changeset: b456f25c2075 Author: lancea Date: 2013-04-23 11:17 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b456f25c2075 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans Reviewed-by: chegar ! make/netbeans/common/shared.xml + make/netbeans/jdbc/README + make/netbeans/jdbc/build.properties + make/netbeans/jdbc/build.xml + make/netbeans/jdbc/nbproject/project.xml Changeset: 57b02a7558f3 Author: lana Date: 2013-04-23 15:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/57b02a7558f3 Merge - src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM Changeset: 754c9bb4f085 Author: sla Date: 2013-04-24 14:49 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/754c9bb4f085 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c Reviewed-by: sla, rbackman, alanb, dholmes, rdurbin Contributed-by: peter.allwin at oracle.com ! src/solaris/native/com/sun/management/UnixOperatingSystem_md.c Changeset: bbcebf893b83 Author: alanb Date: 2013-04-24 19:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bbcebf893b83 8005555: TEST_BUG: java/io/Serializable/accessConstants/AccessConstants.java should be removed Reviewed-by: chegar - test/java/io/Serializable/accessConstants/AccessConstants.java Changeset: 8c06a38aa2c5 Author: sherman Date: 2013-04-24 21:27 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8c06a38aa2c5 8012638: test/java/time/test/java/util/TestFormatter fails in UTC TZ Summary: updated the offending test case Reviewed-by: alanb ! test/java/time/test/java/util/TestFormatter.java Changeset: 4da1d43f5843 Author: darcy Date: 2013-04-25 09:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4da1d43f5843 8012044: Give more information about self-suppression from Throwable.addSuppressed Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/Throwable.java ! test/java/lang/Throwable/SuppressedExceptions.java Changeset: ca0957f0d408 Author: emc Date: 2013-04-25 14:23 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ca0957f0d408 8012937: Correct errors in javadoc comments. Summary: Correct some errors in the javadoc comments for parameter reflection. Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Parameter.java Changeset: 5871d7b1673c Author: coffeys Date: 2013-04-25 21:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5871d7b1673c 8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z and z pattern letters Reviewed-by: okutsu ! src/share/classes/java/text/CalendarBuilder.java ! src/share/classes/java/text/SimpleDateFormat.java ! test/java/text/Format/DateFormat/Bug7130335.java Changeset: b600d637ef77 Author: wetmore Date: 2013-04-25 17:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b600d637ef77 8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing Reviewed-by: wetmore Contributed-by: alan.bateman at oracle.com ! test/sun/security/provider/SecureRandom/StrongSeedReader.java Changeset: a8da4e516bc3 Author: akhil Date: 2013-04-23 11:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a8da4e516bc3 8005051: optimized defaults for Iterator.forEachRemaining Reviewed-by: alanb, mduigou, psandoz, ulfzibis Contributed-by: Akhil Arora ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java Changeset: ceeed0fcb371 Author: jgish Date: 2013-04-02 18:41 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ceeed0fcb371 5015163: (str) String merge/join that is the inverse of String.split() 7172553: A utility class that forms the basis of a String.join() operation Summary: Integrate StringJoiner changes from lambda Reviewed-by: alanb, mduigou ! make/java/java/FILES_java.gmk ! src/share/classes/java/lang/String.java + src/share/classes/java/util/StringJoiner.java + test/java/lang/String/StringJoinTest.java + test/java/util/StringJoiner/StringJoinerTest.java Changeset: 2cb55846c9bb Author: mduigou Date: 2013-04-24 16:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2cb55846c9bb 8011920: Main streams implementation 8012542: Stream methods on Collection Reviewed-by: dholmes, mduigou Contributed-by: Brian Goetz , Mike Duigou , Paul Sandoz ! make/docs/CORE_PKGS.gmk ! src/share/classes/java/util/Collection.java + src/share/classes/java/util/stream/AbstractPipeline.java + src/share/classes/java/util/stream/AbstractSpinedBuffer.java + src/share/classes/java/util/stream/DistinctOps.java + src/share/classes/java/util/stream/DoublePipeline.java + src/share/classes/java/util/stream/IntPipeline.java + src/share/classes/java/util/stream/LongPipeline.java + src/share/classes/java/util/stream/Nodes.java + src/share/classes/java/util/stream/ReduceOps.java + src/share/classes/java/util/stream/ReferencePipeline.java + src/share/classes/java/util/stream/SliceOps.java + src/share/classes/java/util/stream/SortedOps.java + src/share/classes/java/util/stream/SpinedBuffer.java + src/share/classes/java/util/stream/StreamSpliterators.java + src/share/classes/java/util/stream/StreamSupport.java Changeset: 5144db7f0f88 Author: sherman Date: 2013-04-26 13:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5144db7f0f88 8007395: StringIndexOutofBoundsException in Match.find() when input String contains surrogate UTF-16 characters Summary: updated GroupCurly.match0() to backtrack correctly Reviewed-by: mchung ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: f5fbd8065920 Author: mfang Date: 2013-03-25 16:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f5fbd8065920 8010521: jdk8 l10n resource file translation update 2 Reviewed-by: naoto, yhuang + src/macosx/classes/com/apple/laf/resources/aqua_de.properties + src/macosx/classes/com/apple/laf/resources/aqua_es.properties + src/macosx/classes/com/apple/laf/resources/aqua_fr.properties + src/macosx/classes/com/apple/laf/resources/aqua_it.properties + src/macosx/classes/com/apple/laf/resources/aqua_ja.properties + src/macosx/classes/com/apple/laf/resources/aqua_ko.properties + src/macosx/classes/com/apple/laf/resources/aqua_pt_BR.properties + src/macosx/classes/com/apple/laf/resources/aqua_sv.properties + src/macosx/classes/com/apple/laf/resources/aqua_zh_CN.properties + src/macosx/classes/com/apple/laf/resources/aqua_zh_TW.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_es.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_fr.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_it.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ja.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ko.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_sv.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_es.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_fr.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_it.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_ja.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_ko.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_pt_BR.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_sv.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_CN.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_de.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_ja.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_pt_BR.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_sv.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java ! src/share/classes/sun/awt/resources/awt_de.properties ! src/share/classes/sun/awt/resources/awt_es.properties ! src/share/classes/sun/awt/resources/awt_pt_BR.properties ! src/share/classes/sun/awt/resources/awt_zh_CN.properties ! src/share/classes/sun/launcher/resources/launcher_de.properties ! src/share/classes/sun/launcher/resources/launcher_es.properties ! src/share/classes/sun/launcher/resources/launcher_fr.properties ! src/share/classes/sun/launcher/resources/launcher_it.properties ! src/share/classes/sun/launcher/resources/launcher_ja.properties ! src/share/classes/sun/launcher/resources/launcher_ko.properties ! src/share/classes/sun/launcher/resources/launcher_pt_BR.properties ! src/share/classes/sun/launcher/resources/launcher_sv.properties ! src/share/classes/sun/launcher/resources/launcher_zh_CN.properties ! src/share/classes/sun/launcher/resources/launcher_zh_TW.properties ! src/share/classes/sun/management/resources/agent_de.properties ! src/share/classes/sun/management/resources/agent_es.properties ! src/share/classes/sun/management/resources/agent_fr.properties ! src/share/classes/sun/management/resources/agent_it.properties ! src/share/classes/sun/management/resources/agent_ja.properties ! src/share/classes/sun/management/resources/agent_ko.properties ! src/share/classes/sun/management/resources/agent_pt_BR.properties ! src/share/classes/sun/management/resources/agent_sv.properties ! src/share/classes/sun/management/resources/agent_zh_CN.properties ! src/share/classes/sun/management/resources/agent_zh_TW.properties ! src/share/classes/sun/misc/resources/Messages_de.java ! src/share/classes/sun/misc/resources/Messages_es.java ! src/share/classes/sun/misc/resources/Messages_fr.java ! src/share/classes/sun/misc/resources/Messages_it.java ! src/share/classes/sun/misc/resources/Messages_ja.java ! src/share/classes/sun/misc/resources/Messages_ko.java ! src/share/classes/sun/misc/resources/Messages_pt_BR.java ! src/share/classes/sun/misc/resources/Messages_sv.java ! src/share/classes/sun/misc/resources/Messages_zh_CN.java ! src/share/classes/sun/misc/resources/Messages_zh_TW.java ! src/share/classes/sun/print/resources/serviceui_de.properties ! src/share/classes/sun/print/resources/serviceui_es.properties ! src/share/classes/sun/print/resources/serviceui_fr.properties ! src/share/classes/sun/print/resources/serviceui_it.properties ! src/share/classes/sun/print/resources/serviceui_ja.properties ! src/share/classes/sun/print/resources/serviceui_ko.properties ! src/share/classes/sun/print/resources/serviceui_pt_BR.properties ! src/share/classes/sun/print/resources/serviceui_sv.properties ! src/share/classes/sun/print/resources/serviceui_zh_CN.properties ! src/share/classes/sun/print/resources/serviceui_zh_TW.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_de.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_es.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_fr.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_it.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_ja.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_ko.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_pt_BR.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_sv.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_CN.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_TW.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_ja.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_zh_CN.properties ! src/share/classes/sun/rmi/server/resources/rmid_de.properties ! src/share/classes/sun/rmi/server/resources/rmid_es.properties ! src/share/classes/sun/rmi/server/resources/rmid_fr.properties ! src/share/classes/sun/rmi/server/resources/rmid_it.properties ! src/share/classes/sun/rmi/server/resources/rmid_ja.properties ! src/share/classes/sun/rmi/server/resources/rmid_ko.properties ! src/share/classes/sun/rmi/server/resources/rmid_pt_BR.properties ! src/share/classes/sun/rmi/server/resources/rmid_sv.properties ! src/share/classes/sun/rmi/server/resources/rmid_zh_CN.properties ! src/share/classes/sun/rmi/server/resources/rmid_zh_TW.properties ! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java ! src/share/classes/sun/security/tools/jarsigner/Resources_zh_CN.java ! src/share/classes/sun/security/util/AuthResources_pt_BR.java ! src/share/classes/sun/security/util/AuthResources_zh_TW.java ! src/share/classes/sun/security/util/Resources_es.java ! src/share/classes/sun/security/util/Resources_pt_BR.java ! src/share/classes/sun/tools/jar/resources/jar_de.properties ! src/share/classes/sun/tools/jar/resources/jar_es.properties ! src/share/classes/sun/tools/jar/resources/jar_fr.properties ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/share/classes/sun/tools/jar/resources/jar_ko.properties ! src/share/classes/sun/tools/jar/resources/jar_pt_BR.properties ! src/share/classes/sun/tools/jar/resources/jar_sv.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_TW.properties ! src/share/classes/sun/tools/jconsole/resources/messages_ja.properties ! src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties ! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_ja.java ! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_zh_CN.java ! src/share/demo/jfc/Notepad/resources/Notepad_ja.properties ! src/share/demo/jfc/Notepad/resources/Notepad_zh_CN.properties Changeset: 6d8cd4f28a2f Author: mfang Date: 2013-04-22 23:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6d8cd4f28a2f Merge - make/com/sun/servicetag/Makefile - src/share/classes/com/sun/servicetag/BrowserSupport.java - src/share/classes/com/sun/servicetag/Installer.java - src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java - src/share/classes/com/sun/servicetag/RegistrationData.java - src/share/classes/com/sun/servicetag/RegistrationDocument.java - src/share/classes/com/sun/servicetag/Registry.java - src/share/classes/com/sun/servicetag/ServiceTag.java - src/share/classes/com/sun/servicetag/SolarisServiceTag.java - src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java - src/share/classes/com/sun/servicetag/SunConnection.java - src/share/classes/com/sun/servicetag/SystemEnvironment.java - src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java - src/share/classes/com/sun/servicetag/Util.java - src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java - src/share/classes/com/sun/servicetag/package.html - src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt - src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties - src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties - src/share/classes/com/sun/servicetag/resources/jdk_header.png - src/share/classes/com/sun/servicetag/resources/product_registration.xsd - src/share/classes/com/sun/servicetag/resources/register.html - src/share/classes/com/sun/servicetag/resources/register_ja.html - src/share/classes/com/sun/servicetag/resources/register_zh_CN.html - src/share/classes/java/time/chrono/HijrahDeviationReader.java - src/share/classes/java/time/format/DateTimeBuilder.java - src/share/classes/java/time/format/DateTimeFormatStyleProvider.java - src/share/classes/java/time/temporal/Adjusters.java - src/share/classes/java/time/temporal/Queries.java ! src/share/classes/sun/security/ssl/Authenticator.java - src/share/classes/sun/security/util/KeyLength.java - src/share/native/java/lang/ResourceBundle.c - test/com/sun/servicetag/DeleteServiceTag.java - test/com/sun/servicetag/DuplicateNotFound.java - test/com/sun/servicetag/FindServiceTags.java - test/com/sun/servicetag/InstanceUrnCheck.java - test/com/sun/servicetag/InvalidRegistrationData.java - test/com/sun/servicetag/InvalidServiceTag.java - test/com/sun/servicetag/JavaServiceTagTest.java - test/com/sun/servicetag/JavaServiceTagTest1.java - test/com/sun/servicetag/NewRegistrationData.java - test/com/sun/servicetag/SvcTagClient.java - test/com/sun/servicetag/SystemRegistryTest.java - test/com/sun/servicetag/TestLoadFromXML.java - test/com/sun/servicetag/UpdateServiceTagTest.java - test/com/sun/servicetag/Util.java - test/com/sun/servicetag/ValidRegistrationData.java - test/com/sun/servicetag/environ.properties - test/com/sun/servicetag/missing-environ-field.xml - test/com/sun/servicetag/newer-registry-version.xml - test/com/sun/servicetag/registration.xml - test/com/sun/servicetag/servicetag1.properties - test/com/sun/servicetag/servicetag2.properties - test/com/sun/servicetag/servicetag3.properties - test/com/sun/servicetag/servicetag4.properties - test/com/sun/servicetag/servicetag5.properties - test/java/time/tck/java/time/TestChronology.java - test/java/time/tck/java/time/chrono/TestChronoLocalDate.java - test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java - test/java/time/tck/java/time/chrono/TestHijrahChronology.java - test/java/time/tck/java/time/chrono/TestJapaneseChronology.java - test/java/time/tck/java/time/chrono/TestMinguoChronology.java - test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java - test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java - test/java/time/tck/java/time/temporal/TestChronoLocalDate.java - test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java - test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java - test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java - test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java - test/java/util/ComparatorsTest.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKeyGCM.java - test/sun/tools/jstat/gcPermCapacityOutput1.awk - test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh Changeset: a6781797ae53 Author: mfang Date: 2013-04-26 09:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a6781797ae53 Merge Changeset: 890485cafb8b Author: mfang Date: 2013-04-26 14:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/890485cafb8b Merge Changeset: 5e7ae178b24d Author: plevart Date: 2013-04-26 16:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5e7ae178b24d 7123493: (proxy) Proxy.getProxyClass doesn't scale under high load Reviewed-by: mchung ! src/share/classes/java/lang/reflect/Proxy.java + src/share/classes/java/lang/reflect/WeakCache.java Changeset: 964b95a59656 Author: weijun Date: 2013-04-27 18:25 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/964b95a59656 8005523: Unbound krb5 for TLS Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java ! src/share/classes/sun/security/ssl/Krb5Helper.java ! src/share/classes/sun/security/ssl/Krb5Proxy.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/krb5/KerberosClientKeyExchangeImpl.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java ! test/sun/security/krb5/auto/SSL.java Changeset: c5d7bdee8c64 Author: alanb Date: 2013-04-28 21:06 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c5d7bdee8c64 8013413: javadoc warnings Reviewed-by: lancea, chegar ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/util/Spliterator.java Changeset: 94b05be10eec Author: alanb Date: 2013-04-29 10:28 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/94b05be10eec 8013415: Changes for JDK-8005523 requires updates to refs.allowed Reviewed-by: chegar ! make/tools/src/build/tools/deps/refs.allowed Changeset: 138f767b8eff Author: dholmes Date: 2013-04-29 07:40 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/138f767b8eff 8010280: jvm.cfg needs updating for non-server builds Summary: Generate jvm.cfg based on chosen VMs for non-"standard" builds and remove legacy entries from committed jvm.cfg files Reviewed-by: mduigou, tbell ! makefiles/CopyFiles.gmk ! src/macosx/bin/x86_64/jvm.cfg ! src/solaris/bin/amd64/jvm.cfg ! src/solaris/bin/arm/jvm.cfg ! src/solaris/bin/i586/jvm.cfg ! src/solaris/bin/ia64/jvm.cfg ! src/solaris/bin/ppc/jvm.cfg ! src/solaris/bin/sparc/jvm.cfg ! src/solaris/bin/sparcv9/jvm.cfg ! src/solaris/bin/zero/jvm.cfg ! src/windows/bin/amd64/jvm.cfg ! src/windows/bin/i586/jvm.cfg ! src/windows/bin/ia64/jvm.cfg Changeset: 9d324d667bb3 Author: jzavgren Date: 2013-04-29 08:17 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9d324d667bb3 8012108: Memory leak in jdk/src/windows/native/java/net/NetworkInterface_winXP.c Summary: Modified code to fix this leak and then proactively fixed improper calls to realloc() in the windows native code that can also cause leaks. Reviewed-by: chegar, khazra, dsamersoff ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/sun/net/dns/ResolverConfigurationImpl.c Changeset: b013d7433184 Author: chegar Date: 2013-04-29 18:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b013d7433184 Merge Changeset: 7857129859bd Author: briangoetz Date: 2013-04-20 18:53 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7857129859bd 8012650: Arrays streams methods 8011918: java.util.stream.Streams Reviewed-by: alanb, mduigou, darcy, henryjen Contributed-by: brian.goetz at oracle.com, paul.sandoz at oracle.com ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java + src/share/classes/java/util/stream/StreamBuilder.java + src/share/classes/java/util/stream/Streams.java + test/java/util/Arrays/SetAllTest.java Changeset: 46ddd9d272b5 Author: mduigou Date: 2013-04-29 22:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/46ddd9d272b5 8011917: Add java.util.stream.Collectors utilities Reviewed-by: darcy, mduigou Contributed-by: Brian Goetz + src/share/classes/java/util/stream/Collectors.java Changeset: fff665e54df0 Author: sla Date: 2013-04-30 10:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fff665e54df0 8003671: [findbugs] sun.management.AgentConfigurationError.getParams() may expose internal representation by returning AgentConfigurationError.params Reviewed-by: mchung, rbackman, jbachorik ! src/share/classes/sun/management/AgentConfigurationError.java Changeset: 49d6596100db Author: msheppar Date: 2013-04-29 23:07 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/49d6596100db 8007373: Inet6Address serialization incompatibility Reviewed-by: alanb, chegar ! src/share/classes/java/net/Inet6Address.java + test/java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java Changeset: ac3e189c9099 Author: lancea Date: 2013-04-30 14:44 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ac3e189c9099 8010416: Add a way for java.sql.Driver to be notified when it is deregistered Reviewed-by: alanb, ulfzibis ! src/share/classes/java/sql/Driver.java + src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/SQLPermission.java Changeset: 0e6f412f5536 Author: mduigou Date: 2013-04-30 12:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0e6f412f5536 8011814: Add testng.jar to Netbeans projects test compile classpath 8013271: Add MacOS sources to J2SE Netbeans project 8013272: JDK Netbeans projects should use ASCII encoding for sources Reviewed-by: lancea ! make/netbeans/common/closed-share-sources.ent ! make/netbeans/common/demo-view.ent ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent ! make/netbeans/common/jtreg-view.ent + make/netbeans/common/macosx-sources.ent + make/netbeans/common/macosx-view.ent ! make/netbeans/common/properties.ent ! make/netbeans/common/sample-view.ent ! make/netbeans/common/share-sources.ent ! make/netbeans/common/unix-sources.ent ! make/netbeans/common/windows-sources.ent ! make/netbeans/j2se/nbproject/project.xml ! make/netbeans/world/nbproject/project.xml Changeset: 2fba6ae13ed8 Author: mduigou Date: 2013-04-30 12:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2fba6ae13ed8 Merge Changeset: 1432a6247ac9 Author: ksrini Date: 2013-04-30 13:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1432a6247ac9 8009389: Unpack200 native library should be removed from profiles Reviewed-by: alanb, bobv, jrose ! makefiles/profile-includes.txt ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java Changeset: eda99449ab26 Author: alanb Date: 2013-04-30 21:19 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eda99449ab26 8013647: JPRT unable to clean-up after tests that leave file trees with loops Reviewed-by: chegar, tbell ! test/java/nio/file/Files/walkFileTree/MaxDepth.java ! test/java/nio/file/Files/walkFileTree/SkipSiblings.java ! test/java/nio/file/Files/walkFileTree/SkipSubtree.java ! test/java/nio/file/Files/walkFileTree/TerminateWalk.java Changeset: 4a82d2b86c75 Author: mchung Date: 2013-04-30 15:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4a82d2b86c75 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references Reviewed-by: alanb ! test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java - test/sun/reflect/CallerSensitive/MethodFinder.java ! test/sun/reflect/CallerSensitive/MissingCallerSensitive.java Changeset: 4550ba263cbf Author: lana Date: 2013-04-30 17:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4550ba263cbf Merge Changeset: dddd17cf61ff Author: chegar Date: 2013-05-01 10:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/dddd17cf61ff 6594296: NetworkInterface.getHardwareAddress returns zero length byte array Reviewed-by: alanb ! src/windows/native/java/net/NetworkInterface_winXP.c ! test/java/net/NetworkInterface/Test.java Changeset: 73793f2af80a Author: msheppar Date: 2013-04-30 16:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/73793f2af80a 8007799: Base64.getEncoder(0, byte[]) returns an encoder that unexpectedly inserts line separators Reviewed-by: sherman, iris ! src/share/classes/java/util/Base64.java + test/java/util/Base64/Base64GetEncoderTest.java Changeset: 5941f7c9c76a Author: chegar Date: 2013-05-01 11:15 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5941f7c9c76a 8013723: ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: ae4a82e69da2 Author: weijun Date: 2013-05-01 21:05 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ae4a82e69da2 8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt Reviewed-by: vinnie ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java + test/sun/security/krb5/auto/SaslGSS.java Changeset: c6aef650e615 Author: mduigou Date: 2013-05-01 08:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c6aef650e615 8012665: add CharSequence.chars, CharSequence.codePoints Reviewed-by: martin, alanb, ulfzibis, mduigou Contributed-by: Stuart Marks , Henry Jen ! src/share/classes/java/lang/CharSequence.java + test/java/lang/CharSequence/DefaultTest.java ! test/java/lang/StringBuffer/TestSynchronization.java Changeset: f6f2802f980c Author: lana Date: 2013-05-01 11:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f6f2802f980c Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 336a110f1196 Author: lana Date: 2013-05-06 11:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/336a110f1196 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 88125d32eb06 Author: andrew Date: 2013-05-04 17:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88125d32eb06 8011366: Enable debug info on all libraries for OpenJDK builds Summary: The build should not be turning off debugging if it has been requested. Reviewed-by: erikj, dholmes ! makefiles/CompileNativeLibraries.gmk Changeset: 7ba77fff0ef6 Author: katleman Date: 2013-05-07 10:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7ba77fff0ef6 Merge Changeset: 845025546e35 Author: katleman Date: 2013-05-07 13:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/845025546e35 Merge Changeset: b8e7d145abc2 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b8e7d145abc2 Added tag jdk8-b89 for changeset 845025546e35 ! .hgtags Changeset: 1f1699686504 Author: katleman Date: 2013-05-09 15:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1f1699686504 8014289: JDK8 b89 source with GPL header errors Reviewed-by: mchung, mduigou, tbell, dsamersoff ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/StringJoiner.java ! test/java/lang/CharSequence/DefaultTest.java ! test/java/util/StringJoiner/StringJoinerTest.java Changeset: c63eda8f6300 Author: katleman Date: 2013-05-14 12:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c63eda8f6300 Merge Changeset: 08c28cdacd7b Author: katleman Date: 2013-05-16 12:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/08c28cdacd7b Added tag jdk8-b90 for changeset c63eda8f6300 ! .hgtags From john.coomes at oracle.com Thu May 16 23:00:51 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 17 May 2013 06:00:51 +0000 Subject: hg: hsx/hotspot-rt/nashorn: 40 new changesets Message-ID: <20130517060120.C838B48B59@hg.openjdk.java.net> Changeset: aa8170c0dec9 Author: sundar Date: 2013-04-15 20:12 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/aa8170c0dec9 8012240: Array.prototype.map.call({length: -1, get 0(){throw 0}}, function(){}).length does not throw error Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java + test/script/basic/JDK-8012240.js Changeset: 486d92559c37 Author: sundar Date: 2013-04-17 16:52 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/486d92559c37 8012457: Function.prototype.apply should accept any array-like argument for function arguments Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeFunction.java + test/script/basic/JDK-8012457.js Changeset: d4468316fe73 Author: jlaskey Date: 2013-04-17 08:48 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d4468316fe73 Merge Changeset: 04b36c02c0e2 Author: jlaskey Date: 2013-04-17 15:36 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/04b36c02c0e2 8012529: Remove -esa from testing jvmargs Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/project.properties Changeset: 2bb3b22392d7 Author: sundar Date: 2013-04-18 15:47 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2bb3b22392d7 Merge Changeset: ac309d492b8d Author: sundar Date: 2013-04-18 15:50 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ac309d492b8d 8012462: Date.prototype.toJSON does not handle non-Date 'this' as per the spec. Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/objects/NativeDate.java + test/script/basic/JDK-8012462.js Changeset: d1d564f5cf82 Author: hannesw Date: 2013-04-18 14:25 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d1d564f5cf82 8012460: RegExp regression Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java + test/script/basic/JDK-8012460.js + test/script/basic/JDK-8012460.js.EXPECTED Changeset: bc251a7b5103 Author: sundar Date: 2013-04-19 17:46 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/bc251a7b5103 8012612: Compile failed Reviewed-by: hannesw, jlaskey, attila ! src/jdk/nashorn/internal/runtime/Context.java Changeset: c8460f668d0c Author: sundar Date: 2013-04-19 18:23 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c8460f668d0c 8012593: JSAdapter overrides impacts strongly construction time Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java Changeset: 3a209cbd1d8f Author: lagergren Date: 2013-04-19 16:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3a209cbd1d8f 8010701: Immutable nodes - final iteration Reviewed-by: sundar, hannesw, jlaskey ! bin/verbose_octane.sh ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java - src/jdk/nashorn/internal/codegen/Frame.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Namespace.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java + src/jdk/nashorn/internal/codegen/SplitMethodEmitter.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java + src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java - src/jdk/nashorn/internal/ir/DoWhileNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java + src/jdk/nashorn/internal/ir/Flags.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java - src/jdk/nashorn/internal/ir/LabeledNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java + src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Location.java + src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java + src/jdk/nashorn/internal/ir/annotations/Immutable.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/lookup/MethodHandleFactory.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/linker/ClassAndLoader.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/try2.js + test/script/basic/try2.js.EXPECTED Changeset: e599a1cad89a Author: jlaskey Date: 2013-04-20 08:54 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e599a1cad89a 8011578: -Dnashorn.unstable.relink.threshold=1 causes tests to fail. Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/WithObject.java + test/script/basic/JDK-8011578.js + test/script/basic/JDK-8011578.js.EXPECTED Changeset: ead94bc57939 Author: sundar Date: 2013-04-22 18:09 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ead94bc57939 8012673: Nashorn's package name vs class name inferring logic is wrong Reviewed-by: hannesw, jlaskey, attila ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java Changeset: 812e9cc70320 Author: jlaskey Date: 2013-04-22 10:37 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/812e9cc70320 8012919: findMegaMorphicSetMethod should not cast result type Reviewed-by: attila, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/WithObject.java Changeset: cfda59f3d827 Author: sundar Date: 2013-04-22 19:57 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/cfda59f3d827 Merge - src/jdk/nashorn/internal/codegen/Frame.java - src/jdk/nashorn/internal/ir/DoWhileNode.java - src/jdk/nashorn/internal/ir/LabeledNode.java Changeset: 08143fa6b3da Author: lana Date: 2013-04-23 15:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/08143fa6b3da Merge Changeset: 0547a1c76259 Author: attila Date: 2013-04-23 12:52 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/0547a1c76259 8011065: Problems when script implements an interface with variadic methods Reviewed-by: jlaskey, hannesw, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java + test/src/jdk/nashorn/api/scripting/VariableArityTestInterface.java Changeset: 32036918585d Author: attila Date: 2013-04-23 16:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/32036918585d 8010731: Don't expose internal symbols to scripts Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java Changeset: a6c53280343d Author: hannesw Date: 2013-04-24 13:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a6c53280343d 8012334: ToUint32, ToInt32, and ToUint16 don't conform to spec Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java + test/examples/int-micro.js + test/script/basic/JDK-8012334.js + test/script/basic/JDK-8012334.js.EXPECTED ! test/src/jdk/nashorn/internal/runtime/JSTypeTest.java Changeset: 3974ce844f17 Author: hannesw Date: 2013-04-24 13:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3974ce844f17 8012931: NativeDate.safeToString() throws RangeError for invalid date Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/objects/NativeDate.java + test/script/basic/JDK-8012931.js + test/script/basic/JDK-8012931.js.EXPECTED Changeset: e959c7969f3b Author: hannesw Date: 2013-04-24 13:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e959c7969f3b 8008238: Labeled break in finally causes stack overflow in Node copy Reviewed-by: lagergren, attila + test/script/basic/JDK-8008238.js Changeset: c0a10bbf6752 Author: jlaskey Date: 2013-04-24 14:25 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c0a10bbf6752 8012251: jjs should support -fx option Reviewed-by: sundar, attila, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + src/jdk/nashorn/internal/runtime/resources/fx/base.js + src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js + src/jdk/nashorn/internal/runtime/resources/fx/controls.js + src/jdk/nashorn/internal/runtime/resources/fx/fxml.js + src/jdk/nashorn/internal/runtime/resources/fx/graphics.js + src/jdk/nashorn/internal/runtime/resources/fx/media.js + src/jdk/nashorn/internal/runtime/resources/fx/swing.js + src/jdk/nashorn/internal/runtime/resources/fx/swt.js + src/jdk/nashorn/internal/runtime/resources/fx/web.js ! src/jdk/nashorn/tools/Shell.java ! tools/fxshell/jdk/nashorn/tools/FXShell.java Changeset: 9ad1ebb44c86 Author: hannesw Date: 2013-04-25 14:20 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9ad1ebb44c86 8013131: Various compatibility issues in String.prototype.split() Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeString.java + test/script/basic/JDK-8013131.js + test/script/basic/JDK-8013131.js.EXPECTED Changeset: ff1e4655a57f Author: attila Date: 2013-04-25 14:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ff1e4655a57f 8013203: A collection of smaller speedups to compilation pipeline Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java Changeset: fd0b969a6d07 Author: attila Date: 2013-04-25 15:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/fd0b969a6d07 8013167: Vararg constructor not found Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java + test/script/basic/JDK-8013167.js + test/script/basic/JDK-8013167.js.EXPECTED + test/src/jdk/nashorn/test/models/VarArgConstructor.java Changeset: 215d9b042cb6 Author: sundar Date: 2013-04-26 12:17 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/215d9b042cb6 8013295: ScriptEngineTest.java fails with compilation error when running under jtreg Reviewed-by: attila, hannesw ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 7917ef020898 Author: attila Date: 2013-04-26 09:20 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/7917ef020898 8013325: function named 'arguments' should set DEFINES_ARGUMENTS flag in its parent, not itself Reviewed-by: hannesw, sundar ! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8013325.js + test/script/basic/JDK-8013325.js.EXPECTED Changeset: 5c98cc846f92 Author: jlaskey Date: 2013-04-26 09:48 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5c98cc846f92 8013208: Octane performance regression Reviewed-by: hannesw, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java Changeset: b532eeab085f Author: sundar Date: 2013-04-26 18:31 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b532eeab085f 8013337: Issues with Date.prototype's get, set functions Reviewed-by: jlaskey, hannesw, lagergren ! src/jdk/nashorn/internal/objects/NativeDate.java + test/script/basic/JDK-8013337.js + test/script/basic/JDK-8013337.js.EXPECTED Changeset: c62144b08c65 Author: hannesw Date: 2013-04-26 17:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c62144b08c65 8006559: Octane:pdfjs leaks memory, runs slower iteration to iteration Reviewed-by: attila, sundar, jlaskey ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java ! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java Changeset: 241904013024 Author: sundar Date: 2013-04-26 22:29 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/241904013024 8013369: nashorn build failure with jdk8 b84 Reviewed-by: hannesw ! make/build-nasgen.xml Changeset: ef4c1f3aa9ed Author: jlaskey Date: 2013-04-26 15:13 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ef4c1f3aa9ed 8013360: Should be using JavaFX 8 classes for -fx support Reviewed-by: hannesw, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/base.js ! src/jdk/nashorn/internal/runtime/resources/fx/controls.js ! src/jdk/nashorn/internal/runtime/resources/fx/fxml.js ! src/jdk/nashorn/internal/runtime/resources/fx/graphics.js ! src/jdk/nashorn/internal/runtime/resources/fx/media.js ! src/jdk/nashorn/internal/runtime/resources/fx/swing.js ! src/jdk/nashorn/internal/runtime/resources/fx/swt.js ! src/jdk/nashorn/internal/runtime/resources/fx/web.js Changeset: e8d7298f29a1 Author: attila Date: 2013-04-29 13:21 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e8d7298f29a1 8013419: Streamline handling of with and eval Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java Changeset: ada2ca9aeac5 Author: sundar Date: 2013-04-29 18:40 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ada2ca9aeac5 8013444: JSON.parse does not invoke "reviver" callback as per spec. Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/JSONFunctions.java + test/script/basic/JDK-8013444.js + test/script/basic/JDK-8013444.js.EXPECTED Changeset: 630372cb8f2a Author: attila Date: 2013-04-29 23:22 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/630372cb8f2a 8008814: Configurable ignore/warning/error behavior for function declaration as statement Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/JDK-8008814-3.js + test/script/basic/JDK-8008814-3.js.EXPECTED + test/script/basic/JDK-8008814-4.js + test/script/basic/JDK-8008814-4.js.EXPECTED + test/script/error/JDK-8008814-1.js + test/script/error/JDK-8008814-1.js.EXPECTED + test/script/error/JDK-8008814-2.js + test/script/error/JDK-8008814-2.js.EXPECTED Changeset: 3f339ab2d050 Author: jlaskey Date: 2013-04-29 21:38 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3f339ab2d050 Merge Changeset: ad28f2b52b12 Author: lagergren Date: 2013-04-30 09:42 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ad28f2b52b12 8013533: Increase code coverage report for types and logging Reviewed-by: hannesw, sundar ! src/jdk/nashorn/internal/codegen/types/BooleanType.java ! src/jdk/nashorn/internal/codegen/types/IntType.java ! src/jdk/nashorn/internal/codegen/types/LongType.java ! src/jdk/nashorn/internal/codegen/types/NumberType.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! test/script/error/JDK-8008814-1.js.EXPECTED ! test/script/error/JDK-8008814-2.js.EXPECTED + test/script/trusted/logcoverage.js + test/script/trusted/logcoverage.js.EXPECTED Changeset: 9fee4992f796 Author: lana Date: 2013-04-30 17:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9fee4992f796 Merge Changeset: 45ce27fbe272 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/45ce27fbe272 Merge - src/jdk/nashorn/internal/codegen/Frame.java - src/jdk/nashorn/internal/ir/DoWhileNode.java - src/jdk/nashorn/internal/ir/LabeledNode.java Changeset: 67ca019e3713 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/67ca019e3713 Added tag jdk8-b89 for changeset 45ce27fbe272 ! .hgtags Changeset: 4ce88eec5078 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/4ce88eec5078 Added tag jdk8-b90 for changeset 67ca019e3713 ! .hgtags From john.coomes at oracle.com Thu May 16 22:59:48 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 17 May 2013 05:59:48 +0000 Subject: hg: hsx/hotspot-rt/langtools: 17 new changesets Message-ID: <20130517060040.401EB48B58@hg.openjdk.java.net> Changeset: ed918a442b83 Author: jlahoda Date: 2013-04-17 15:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ed918a442b83 8008174: DocTree API should provide start and end positions for tree nodes Summary: Adding DocSourcePositions to allow access to DocTree starting/ending position Reviewed-by: jjg, darcy Contributed-by: Ralph Benjamin Ruijs , Jan Lahoda + src/share/classes/com/sun/source/util/DocSourcePositions.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/SourcePositions.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/tree/DCTree.java + test/tools/javac/doctree/positions/TestPosition.java + test/tools/javac/doctree/positions/TestPosition.out + test/tools/javac/doctree/positions/TestPositionSource.java Changeset: 891b88acf47a Author: jjg Date: 2013-04-18 19:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/891b88acf47a 8012658: Change default langtools source level to 7 Reviewed-by: darcy ! make/netbeans/langtools/nbproject/project.xml Changeset: 95d29b99e5b3 Author: jjg Date: 2013-04-18 20:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/95d29b99e5b3 8012656: cache frequently used name strings for DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java Changeset: a3655c24e232 Author: jfranck Date: 2013-04-19 11:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a3655c24e232 8012681: Commit for JDK-8012656 breaks tl build Reviewed-by: vromero, chegar, alanb ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java Changeset: d59730bd3162 Author: jjg Date: 2013-04-19 11:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d59730bd3162 8012661: remove langtools Makefile-classic Reviewed-by: erikj, tbell - make/Makefile-classic Changeset: bae8387d16aa Author: jfranck Date: 2013-04-22 10:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bae8387d16aa 8011027: Type parameter annotations not passed through to javax.lang.model Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java + test/tools/javac/processing/model/element/TestTypeParameterAnnotations.java Changeset: da0bd69335d4 Author: lana Date: 2013-04-23 15:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/da0bd69335d4 Merge Changeset: 4b0038f66d66 Author: jjg Date: 2013-04-25 17:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4b0038f66d66 8013256: javac test failing after Lambda changes to java.util.List Reviewed-by: mduigou ! test/tools/javac/api/TestJavacTaskScanner.java Changeset: 3c02d2f1a421 Author: vromero Date: 2013-04-26 10:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3c02d2f1a421 8012723: strictfp interface misses strictfp modifer on default method Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/defaultMethods/CheckACC_STRICTFlagOnDefaultMethodTest.java Changeset: 2ca9e7d50136 Author: vromero Date: 2013-04-26 10:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2ca9e7d50136 8008562: javac, a refactoring to Bits is necessary in order to provide a change history Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/util/Bits.java Changeset: f3f3ac1273e8 Author: vromero Date: 2013-04-26 15:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f3f3ac1273e8 8010304: javac should detect all mutable implicit static fields in langtools using a plugin Reviewed-by: jjg ! make/build.xml + make/tools/crules/AbstractCodingRulesAnalyzer.java + make/tools/crules/MutableFieldsAnalyzer.java + make/tools/crules/resources/crules.properties Changeset: 57648bad3287 Author: mchung Date: 2013-04-30 15:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/57648bad3287 8013531: Provide a utility class in com.sun.tools.classfile to find field/method references Reviewed-by: alanb ! src/share/classes/com/sun/tools/classfile/Dependencies.java + src/share/classes/com/sun/tools/classfile/ReferenceFinder.java Changeset: 260013a710ef Author: lana Date: 2013-04-30 17:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/260013a710ef Merge Changeset: 8e27e84de2e9 Author: rfield Date: 2013-05-01 08:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8e27e84de2e9 8011591: BootstrapMethodError when capturing constructor ref to local classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInnerImplicitArgs.java Changeset: ec434cfd2752 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ec434cfd2752 Merge - make/Makefile-classic Changeset: e19283cd30a4 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e19283cd30a4 Added tag jdk8-b89 for changeset ec434cfd2752 ! .hgtags Changeset: 9717b9523d46 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/9717b9523d46 Added tag jdk8-b90 for changeset e19283cd30a4 ! .hgtags From david.holmes at oracle.com Fri May 17 00:21:38 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Fri, 17 May 2013 07:21:38 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets Message-ID: <20130517072147.5B4EA48B5D@hg.openjdk.java.net> Changeset: 50e9396d5257 Author: shade Date: 2013-05-17 01:58 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/50e9396d5257 8014509: @Contended: explicit default value behaves differently from the implicit value Summary: Treat the empty string as the default value tag Reviewed-by: kvn, twisti ! src/share/vm/classfile/classFileParser.cpp + test/runtime/contended/DefaultValue.java Changeset: 074ba6269cf4 Author: dholmes Date: 2013-05-16 22:11 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/074ba6269cf4 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java Changeset: 1ba508fcd3e2 Author: dholmes Date: 2013-05-16 23:40 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1ba508fcd3e2 Merge From daniel.fuchs at oracle.com Fri May 17 03:22:15 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Fri, 17 May 2013 10:22:15 +0000 Subject: hg: jdk8/tl/jdk: 8013900: More warnings compiling jaxp. Message-ID: <20130517102228.AD98548B64@hg.openjdk.java.net> Changeset: 68209420aac2 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68209420aac2 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw + test/javax/xml/jaxp/PrecisionDecimalDV/XPrecisionDecimalToString.java From daniel.fuchs at oracle.com Fri May 17 03:21:54 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Fri, 17 May 2013 10:21:54 +0000 Subject: hg: jdk8/tl/jaxp: 8013900: More warnings compiling jaxp. Message-ID: <20130517102159.5ACAF48B63@hg.openjdk.java.net> Changeset: 6443f5627744 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6443f5627744 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw ! src/com/sun/org/apache/bcel/internal/generic/BasicType.java ! src/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java ! src/com/sun/org/apache/bcel/internal/generic/CodeExceptionGen.java ! src/com/sun/org/apache/bcel/internal/generic/LineNumberGen.java ! src/com/sun/org/apache/bcel/internal/generic/LocalVariableGen.java ! src/com/sun/org/apache/bcel/internal/generic/ReturnaddressType.java ! src/com/sun/org/apache/bcel/internal/generic/Select.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRefBase.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/AbstractDateTimeDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/DecimalDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/PrecisionDecimalDV.java ! src/com/sun/org/apache/xerces/internal/util/URI.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java ! src/com/sun/org/apache/xml/internal/serializer/utils/URI.java ! src/com/sun/org/apache/xml/internal/utils/URI.java ! src/com/sun/org/apache/xpath/internal/Arg.java From nils.loodin at oracle.com Fri May 17 07:04:14 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 17 May 2013 16:04:14 +0200 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <5192C81F.6070407@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> <51917739.1020200@oracle.com> <51921DEC.3010704@oracle.com> <5192C81F.6070407@oracle.com> Message-ID: <519638DE.6070906@oracle.com> Updated webrev: http://cr.openjdk.java.net/~nloodin/8014048/webrev.03/src/ On 05/15/2013 01:26 AM, Mandy Chung wrote: > On 5/14/13 4:20 AM, Nils Loodin wrote: >> >> Mandy: Is the current relased saved somewhere accessible in the jdk > > It's stored in "java.version" property but it requires parsing to > extract the major release number. The private API > sun.misc.Version.getMajorVersion returns that. > >> or is that something you suggest also be stored in the >> message.properties-files? > > Not the release version number. > > The user guide used to be localized but I only see the English version > of jdk 7 though: > http://www.oracle.com/technetwork/java/javase/documentation/api-jsp-136079.html Yes, only found the english one, so I haven't used a separate url in > Anyway, it's minor and no big deal. What you have is fine and it's a fix > for jdk7u but you need to replace 's/7/8' for jdk8 code base. These docs aren't up yet though, but I guess I'll check it in and eventually the docs will be there. Regards Nils Loodin > > Mandy > >> In that case it doesn't seem like we're gaining much, since that would >> have to be updated between releaes... >> >> Erik Gahlin also pointed out that the JConsoleResources*.java-files >> are stale artefacts that can be safely removed since the messages are >> stored in the messages*.properties-files, so that alleviates some of >> the pain of storing the strings everywhere. >> >> Here's an updated webrev: >> http://cr.openjdk.java.net/~nloodin/8014048/webrev.01/ >> >> Regards, >> Nils Loodin >> >>> >>>> /Staffan >>>> >>>> On 13 maj 2013, at 15:36, Nils Loodin wrote: >>>> >>>>> On 05/13/2013 03:36 PM, Nils Loodin wrote: >>>>>> Simple change of link in resource files: >>>>>> >>>>>> https://jbs.oracle.com/bugs/browse/JDK-8014048 >>>>>> >>>>>> Regards, >>>>>> Nils Loodin >>>>> >>>>> Also, with webrev link (might come in handy): >>>>> http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/ >>> >> > From chris.hegarty at oracle.com Fri May 17 07:22:39 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 17 May 2013 14:22:39 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130517142318.6ED9548B6D@hg.openjdk.java.net> Changeset: 3981ad7ec458 Author: chegar Date: 2013-05-17 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3981ad7ec458 8014791: More ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: fab0e4b682e8 Author: chegar Date: 2013-05-17 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fab0e4b682e8 Merge ! test/ProblemList.txt - test/java/util/logging/bundlesearch/LoadItUp.java From chris.hegarty at oracle.com Fri May 17 08:46:14 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 17 May 2013 15:46:14 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130517154656.85C3548B6F@hg.openjdk.java.net> Changeset: 222da3d4692a Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/222da3d4692a 8014783: java/net/HttpURLPermission/HttpURLPermissionTest.java leaves files open Reviewed-by: michaelm ! test/java/net/HttpURLPermission/HttpURLPermissionTest.java Changeset: fed779a87670 Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fed779a87670 Merge - test/java/util/logging/bundlesearch/LoadItUp.java From dan.xu at oracle.com Fri May 17 12:04:51 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 17 May 2013 19:04:51 +0000 Subject: hg: jdk8/tl/jdk: 8011136: FileInputStream.available and skip inconsistencies Message-ID: <20130517190511.F304148B7B@hg.openjdk.java.net> Changeset: 3b1450ee2bb9 Author: dxu Date: 2013-05-17 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b1450ee2bb9 8011136: FileInputStream.available and skip inconsistencies Summary: Correct the behavior of available() and update related java specs for available() and skip() in InputStream and FileInputStream classes. Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/InputStream.java ! src/share/native/java/io/FileInputStream.c ! test/java/io/FileInputStream/LargeFileAvailable.java ! test/java/io/FileInputStream/NegativeAvailable.java From jonathan.gibbons at oracle.com Fri May 17 13:49:09 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 17 May 2013 20:49:09 +0000 Subject: hg: jdk8/tl/langtools: 6885876: add comments to javac/util/Convert.java Message-ID: <20130517204912.98CB448B82@hg.openjdk.java.net> Changeset: 0928f2cfbf8e Author: jjg Date: 2013-05-17 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0928f2cfbf8e 6885876: add comments to javac/util/Convert.java Reviewed-by: mduigou ! src/share/classes/com/sun/tools/javac/util/Convert.java From mandy.chung at oracle.com Fri May 17 14:38:59 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 17 May 2013 14:38:59 -0700 Subject: RFR: JDK-8014048 - Online user guide of jconsole points incorrect link In-Reply-To: <519638DE.6070906@oracle.com> References: <5190EC48.1000202@oracle.com> <5190EC72.1070207@oracle.com> <948CEED2-A9CE-4670-8CEC-E30DAD9A899A@oracle.com> <51917739.1020200@oracle.com> <51921DEC.3010704@oracle.com> <5192C81F.6070407@oracle.com> <519638DE.6070906@oracle.com> Message-ID: <5196A373.9040902@oracle.com> On 5/17/2013 7:04 AM, Nils Loodin wrote: > Updated webrev: > http://cr.openjdk.java.net/~nloodin/8014048/webrev.03/src/ Looks good. Mandy From stuart.marks at oracle.com Fri May 17 17:09:49 2013 From: stuart.marks at oracle.com (Stuart Marks) Date: Fri, 17 May 2013 17:09:49 -0700 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <5193EC10.3050705@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> <5183C6D5.8070302@oracle.com> <51877204.8000104@oracle.com> <5189933E.40702@oracle.com> <518B6B8C.2080506@oracle.com> <5192BE69.4020003@oracle.com> <5193EC10.3050705@oracle.com> Message-ID: <5196C6CD.3070209@oracle.com> On 5/15/13 1:12 PM, Jaroslav Bachorik wrote: > Ok. I've changed it to use AtomicBoolean Thanks for pointing this out. > Even though it's rather obvious I got so used to using the final array > in anonymous inner classes that I didn't even stop and think. BTW, > there are a lot of places in the tests using this idiom in potentially > multithreaded environment :( Hrrm. OK, well, let's fix one test at a time. :-) > Updated webrev - > http://cr.openjdk.java.net/~jbachorik/8005472/webrev.10 Thanks for the update. I took a quick look at it seems fine now. I think Chris may need to be the OpenJDK Reviewer on this one. s'marks From daniel.daugherty at oracle.com Fri May 17 17:41:08 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sat, 18 May 2013 00:41:08 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130518004119.58E9348B8C@hg.openjdk.java.net> Changeset: 6ce351ac7339 Author: rdurbin Date: 2013-05-17 08:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6ce351ac7339 7145527: sscanf must use a length in the format string Summary: Remove dead code containing last call to scanf with no string length specifier Reviewed-by: dcubed, coleenp ! src/share/vm/utilities/debug.cpp Changeset: a250c89cf9e3 Author: dcubed Date: 2013-05-17 08:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a250c89cf9e3 Merge From weijun.wang at oracle.com Fri May 17 19:16:13 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Sat, 18 May 2013 02:16:13 +0000 Subject: hg: jdk8/tl/jdk: 8012261: update policytool to support java.net.HttpURLPermission Message-ID: <20130518021637.F2CF848B91@hg.openjdk.java.net> Changeset: 0f7aaabed25f Author: weijun Date: 2013-05-18 10:15 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f7aaabed25f 8012261: update policytool to support java.net.HttpURLPermission Reviewed-by: mullan ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/tools/policytool/Resources.java From daniel.daugherty at oracle.com Fri May 17 20:33:10 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sat, 18 May 2013 03:33:10 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 28 new changesets Message-ID: <20130518033405.527B748B92@hg.openjdk.java.net> Changeset: d15464bfd4d0 Author: roland Date: 2013-05-03 09:32 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d15464bfd4d0 8012037: Test8009761.java "Failed: init recursive calls: 7224. After deopt 58824" Summary: test shouldn't be run with a modified CompileThreshold Reviewed-by: kvn ! test/compiler/8009761/Test8009761.java Changeset: e76dd894b984 Author: roland Date: 2013-04-24 14:26 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e76dd894b984 8012292: optimized build with GCC broken Summary: Some #ifndef PRODUCT should be #ifdef ASSERT Reviewed-by: kvn, twisti Contributed-by: gdub ! make/jprt.properties ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: d73c88e524ff Author: kvn Date: 2013-05-03 15:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d73c88e524ff Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: f0bc60565ba8 Author: twisti Date: 2013-05-06 13:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f0bc60565ba8 7196277: JSR 292: Two jck/runtime tests crash on java.lang.invoke.MethodHandle.invokeExact Reviewed-by: jrose, kvn ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: aabf54ccedb1 Author: twisti Date: 2013-05-06 19:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aabf54ccedb1 8008772: remove gamma launcher Reviewed-by: kvn, neliasso, ctornqvi ! make/Makefile ! make/bsd/makefiles/buildtree.make - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make + make/hotspot.script ! make/linux/makefiles/buildtree.make - make/linux/makefiles/launcher.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make - make/solaris/makefiles/launcher.make ! make/solaris/makefiles/vm.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make - make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/projectfiles/common/Makefile - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h Changeset: 6f3fd5150b67 Author: kvn Date: 2013-05-08 15:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6f3fd5150b67 6934604: enable parts of EliminateAutoBox by default Summary: Resurrected autobox elimination code and enabled part of it by default. Reviewed-by: roland, twisti ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/multnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phase.cpp ! src/share/vm/opto/phase.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/6934604/TestByteBoxing.java + test/compiler/6934604/TestDoubleBoxing.java + test/compiler/6934604/TestFloatBoxing.java + test/compiler/6934604/TestIntBoxing.java + test/compiler/6934604/TestLongBoxing.java + test/compiler/6934604/TestShortBoxing.java Changeset: 70120f47d403 Author: kvn Date: 2013-05-09 17:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/70120f47d403 8014189: JVM crash with SEGV in ConnectionGraph::record_for_escape_analysis() Summary: Add NULL checks and asserts for Type::make_ptr() returned value. Reviewed-by: twisti ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/subnode.cpp Changeset: 8bcfd9ce2c6b Author: twisti Date: 2013-05-13 12:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8bcfd9ce2c6b Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 1da5d70655e9 Author: kvn Date: 2013-05-13 14:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1da5d70655e9 8014286: failed java/lang/Math/DivModTests.java after 6934604 changes Summary: Corrected escape state for the result of boxing method. Added force inlining executed boxing methods. Reviewed-by: twisti ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/escape.cpp Changeset: cd6f6fccd287 Author: iignatyev Date: 2013-05-15 22:44 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd6f6fccd287 8014068: TEST_BUG: compiler/ciReplay/TestSA.sh fails on Windows: core wasn't generated Reviewed-by: kvn ! test/compiler/ciReplay/TestSA.sh ! test/compiler/ciReplay/common.sh Changeset: e484fe2abebd Author: twisti Date: 2013-05-16 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e484fe2abebd Merge - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: 7a95933197d0 Author: tschatzl Date: 2013-05-13 09:45 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7a95933197d0 8014058: Regression tests for 8006088 Summary: The patch for 8006088 misses regression tests after a merge error, this CR provides them. Reviewed-by: jwilhelm, tamao, jmasa ! src/share/vm/memory/collectorPolicy.cpp + test/gc/arguments/TestCMSHeapSizeFlags.java + test/gc/arguments/TestG1HeapSizeFlags.java + test/gc/arguments/TestMaxHeapSizeTools.java + test/gc/arguments/TestMinInitialErgonomics.java + test/gc/arguments/TestParallelHeapSizeFlags.java + test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 4868caa99ecf Author: brutisso Date: 2013-05-13 14:09 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4868caa99ecf 8014339: Improve assert and remove some dead code from parMarkBitMap.hpp/cpp Reviewed-by: stefank, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Changeset: 0a2986f36965 Author: tschatzl Date: 2013-05-14 17:08 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0a2986f36965 8014489: tests/gc/arguments/Test(Serial|CMS|Parallel|G1)HeapSizeFlags jtreg tests invoke wrong class Summary: Some jtreg tests reference unknown classes in the @run and @build lines. This change fixes them. Reviewed-by: stefank, ehelin ! test/gc/arguments/TestCMSHeapSizeFlags.java ! test/gc/arguments/TestG1HeapSizeFlags.java ! test/gc/arguments/TestParallelHeapSizeFlags.java ! test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 12f651e29f6b Author: tschatzl Date: 2013-05-15 11:05 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/12f651e29f6b 6843347: Boundary values in some public GC options cause crashes Summary: Setting some public integer options to specific values causes crashes or undefined GC behavior. This patchset adds the necessary argument checking for these options. Reviewed-by: jmasa, brutisso ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: eba99d16dc6f Author: tamao Date: 2013-05-15 10:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/eba99d16dc6f 8007763: Refactoring: split up compute_generation_free_space() into two functions for class PSAdaptiveSizePolicy Summary: split up compute_generation_free_space() into two functions: compute_eden_space_size() + compute_old_gen_free_space(), each of which (if needed) can be reused without executing an overhead of the other. Reviewed-by: jmasa, tschatzl Contributed-by: tamao ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Changeset: bed55d125e37 Author: johnc Date: 2013-05-15 22:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bed55d125e37 8014408: G1: crashes with assert assert(prev_committed_card_num == _committed_max_card_num) failed Summary: Mismatch in the card number calculation between next and previous committed sizes of the card counts table. Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CardCounts.hpp Changeset: 05a17f270c7e Author: tschatzl Date: 2013-05-16 13:02 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/05a17f270c7e 8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo Summary: Improve the output of G1PrintRegionLivenessInfo by adding a per-region remembered set size information column Reviewed-by: jwilhelm, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp + test/gc/g1/TestPrintRegionRememberedSetInfo.java Changeset: 48391ab0687e Author: johnc Date: 2013-05-16 09:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/48391ab0687e 8010738: G1: Output for full GCs with +PrintGCDetails should contain perm gen size/meta data change info Summary: Include metaspace information (used, allocated, reserved) in the PrintGCDetails output for full GCs. Reviewed-by: poonam, jmasa, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp + test/gc/g1/TestPrintGCDetails.java Changeset: acac2b03a07f Author: tschatzl Date: 2013-05-16 23:51 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/acac2b03a07f 8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set Summary: The VM exits when the condition in the subject line applies. The fix sets InitialTenuringThreshold to MaxTenuringThreshold if it is larger than MaxTenuringThreshold and InitialTenuringThreshold has not been set (is default). Reviewed-by: jwilhelm, jmasa, brutisso, johnc ! src/share/vm/runtime/arguments.cpp + test/gc/arguments/TestInitialTenuringThreshold.java Changeset: 2958af1d8c5a Author: jwilhelm Date: 2013-05-17 06:01 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2958af1d8c5a Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2f9ac66165e6 Author: jwilhelm Date: 2013-05-17 08:00 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2f9ac66165e6 Merge - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 1cdbd42c3e49 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1cdbd42c3e49 Added tag jdk8-b90 for changeset 1ae0472ff3a0 ! .hgtags Changeset: b19517cecc2e Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b19517cecc2e Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp Changeset: 7cbdf0e3725c Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7cbdf0e3725c Added tag hs25-b33 for changeset b19517cecc2e ! .hgtags Changeset: 7ec426e29e4c Author: amurillo Date: 2013-05-17 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7ec426e29e4c 8014760: new hotspot build - hs25-b34 Reviewed-by: jcoomes ! make/hotspot_version Changeset: b5be63340698 Author: dcubed Date: 2013-05-17 11:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5be63340698 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java ! src/share/vm/classfile/classFileParser.cpp - test/runtime/7158804/Test7158804.sh Changeset: 386b77bf6427 Author: dcubed Date: 2013-05-17 17:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/386b77bf6427 Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp From mike.duigou at oracle.com Sat May 18 18:58:34 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Sun, 19 May 2013 01:58:34 +0000 Subject: hg: jdk8/tl/jdk: 5 new changesets Message-ID: <20130519020304.C0B5148B9F@hg.openjdk.java.net> Changeset: e8b40b034fcd Author: psandoz Date: 2013-05-15 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8b40b034fcd 8013334: Spliterator behavior for LinkedList contradicts Spliterator.trySplit Summary: this changeset also contains some minor, non spec, related fixes to tidy up other areas of the JavaDoc. Reviewed-by: plevart, darcy Contributed-by: John Rose , Mike Duigou , Paul Sandoz ! src/share/classes/java/util/Spliterator.java Changeset: 6bbc2816d936 Author: psandoz Date: 2013-05-15 10:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6bbc2816d936 8014133: Spliterator.OfPrimitive Reviewed-by: mduigou, forax Contributed-by: Paul Sandoz , Brian Goetz ! src/share/classes/java/util/Spliterator.java Changeset: dc5cf74c8c9c Author: mduigou Date: 2013-05-17 10:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc5cf74c8c9c 8004015: Additional static and instance utils for functional interfaces. 8011010: Spec j.u.f.Predicate doesn't specify NPEs thrown by the SE8's Reference Implementation Reviewed-by: briangoetz, dholmes, chegar ! src/share/classes/java/util/function/BiConsumer.java ! src/share/classes/java/util/function/BiFunction.java ! src/share/classes/java/util/function/BiPredicate.java ! src/share/classes/java/util/function/BooleanSupplier.java ! src/share/classes/java/util/function/Consumer.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java ! src/share/classes/java/util/function/DoubleConsumer.java ! src/share/classes/java/util/function/DoubleFunction.java ! src/share/classes/java/util/function/DoublePredicate.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java ! src/share/classes/java/util/function/IntConsumer.java ! src/share/classes/java/util/function/IntFunction.java ! src/share/classes/java/util/function/IntPredicate.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java ! src/share/classes/java/util/function/LongConsumer.java ! src/share/classes/java/util/function/LongFunction.java ! src/share/classes/java/util/function/LongPredicate.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongUnaryOperator.java ! src/share/classes/java/util/function/ObjDoubleConsumer.java ! src/share/classes/java/util/function/ObjIntConsumer.java ! src/share/classes/java/util/function/ObjLongConsumer.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/java/util/function/Supplier.java ! src/share/classes/java/util/function/ToDoubleBiFunction.java ! src/share/classes/java/util/function/ToDoubleFunction.java ! src/share/classes/java/util/function/ToIntBiFunction.java ! src/share/classes/java/util/function/ToIntFunction.java ! src/share/classes/java/util/function/ToLongBiFunction.java ! src/share/classes/java/util/function/ToLongFunction.java ! src/share/classes/java/util/function/UnaryOperator.java Changeset: 23e75751554a Author: henryjen Date: 2013-05-09 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23e75751554a 8006884: (fs) Add Files.list, lines and find Reviewed-by: briangoetz, mduigou Contributed-by: alan.bateman at oracle.com, henry.jen at oracle.com + src/share/classes/java/nio/file/FileTreeIterator.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java + test/java/nio/file/Files/FaultyFileSystem.java ! test/java/nio/file/Files/PassThroughFileSystem.java + test/java/nio/file/Files/StreamTest.java Changeset: b9b26b424bfc Author: mduigou Date: 2013-05-18 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9b26b424bfc Merge From ioi.lam at oracle.com Sat May 18 23:50:04 2013 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Sun, 19 May 2013 06:50:04 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014262: PrintStringTableStatistics should include more footprint info Message-ID: <20130519065009.6C64348BA2@hg.openjdk.java.net> Changeset: a5d6f0c3585f Author: iklam Date: 2013-05-18 20:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a5d6f0c3585f 8014262: PrintStringTableStatistics should include more footprint info Summary: Added info for the string/symbol objects and the hash entries Reviewed-by: coleenp, rbackman ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/utilities/hashtable.cpp ! src/share/vm/utilities/hashtable.hpp From david.holmes at oracle.com Sun May 19 20:58:45 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 20 May 2013 03:58:45 +0000 Subject: hg: jdk8/tl/jdk: 8014477: (str) Race condition in String.contentEquals when comparing with StringBuffer Message-ID: <20130520035909.51B0A48BAE@hg.openjdk.java.net> Changeset: 08ebdb2b53cc Author: plevart Date: 2013-05-17 14:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08ebdb2b53cc 8014477: (str) Race condition in String.contentEquals when comparing with StringBuffer Reviewed-by: alanb, mduigou, dholmes ! src/share/classes/java/lang/String.java + test/java/lang/String/StringContentEqualsBug.java From sundararajan.athijegannathan at oracle.com Mon May 20 06:56:42 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 20 May 2013 13:56:42 +0000 Subject: hg: jdk8/tl/nashorn: 15 new changesets Message-ID: <20130520135653.CBBAA48BB9@hg.openjdk.java.net> Changeset: 80d4db063d5a Author: jlaskey Date: 2013-05-14 11:15 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80d4db063d5a 8014512: Exclude testing and infrastructure packages from code coverage Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/code_coverage.xml Changeset: eeed4db61215 Author: jlaskey Date: 2013-05-14 11:16 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eeed4db61215 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - test/script/trusted/logcoverage.js Changeset: fc20983ef38e Author: attila Date: 2013-05-14 19:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fc20983ef38e 8011718: binding already bound function with extra arguments fails Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java + test/script/basic/JDK-8011718.js + test/script/basic/JDK-8011718.js.EXPECTED Changeset: f88a4818a4dc Author: lagergren Date: 2013-05-14 19:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f88a4818a4dc 8014426: Original exception no longer thrown away when a finally rethrows Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8014426.js + test/script/basic/JDK-8014426.js.EXPECTED Changeset: 64ef1aeaeb4e Author: attila Date: 2013-05-15 10:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/64ef1aeaeb4e 8014639: Remove debug flag from test runs Reviewed-by: hannesw, lagergren ! make/project.properties Changeset: b37eb709ae27 Author: attila Date: 2013-05-15 14:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b37eb709ae27 8014646: Update the Java interop documentation in the Java Scripting Programmer's Guide Reviewed-by: jlaskey, hannesw, lagergren ! docs/JavaScriptingProgrammersGuide.html Changeset: 1eaa542cc8e2 Author: sundar Date: 2013-05-15 19:45 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1eaa542cc8e2 8012305: Function.bind can't be called on prototype function inside constructor Reviewed-by: lagergren, attila + test/script/basic/JDK-8012305.js + test/script/basic/JDK-8012305.js.EXPECTED Changeset: 6344644b81ec Author: jlaskey Date: 2013-05-15 12:09 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6344644b81ec 8014648: Exclude testing and infrastructure packages from code coverage, round two Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/code_coverage.xml ! src/jdk/nashorn/internal/runtime/options/Option.java ! src/jdk/nashorn/internal/runtime/options/Options.java - src/jdk/nashorn/internal/runtime/options/ValueOption.java ! test/script/basic/allgettersetters.js Changeset: 19e9cd9c7010 Author: attila Date: 2013-05-15 20:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/19e9cd9c7010 8014647: Allow class-based overrides to be initialized with a ScriptFunction Reviewed-by: hannesw, jlaskey, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/basic/JDK-8014647.js + test/script/basic/JDK-8014647.js.EXPECTED Changeset: ac14a1fb0cab Author: sundar Date: 2013-05-16 14:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ac14a1fb0cab 8009141: Avoid netscape.javascript.JSObject in nashorn code Reviewed-by: lagergren, hannesw + src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java - src/netscape/javascript/JSObject.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 4c67a692ef97 Author: lagergren Date: 2013-05-16 13:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4c67a692ef97 8013919: Original exception no longer thrown away when a finally rethrows Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/FunctionNode.java + test/script/basic/JDK-8013919.js + test/script/basic/JDK-8013919.js.EXPECTED Changeset: 98798a6336de Author: hannesw Date: 2013-05-16 19:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/98798a6336de 8012359: Increase code coverage in Joni Reviewed-by: jlaskey, lagergren ! make/build.xml - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java + src/jdk/nashorn/internal/runtime/regexp/JdkRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/BitSet.java ! src/jdk/nashorn/internal/runtime/regexp/joni/BitStatus.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Compiler.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Config.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Matcher.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Region.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/StackMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Syntax.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/EncloseNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java ! src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java ! src/jdk/nashorn/internal/runtime/regexp/joni/encoding/ObjPtr.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java ! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ErrorMessages.java ! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ValueException.java + test/src/jdk/nashorn/internal/runtime/regexp/JdkRegExpTest.java + test/src/jdk/nashorn/internal/runtime/regexp/joni/JoniTest.java Changeset: aa1b6e8c51a0 Author: jlaskey Date: 2013-05-17 14:30 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa1b6e8c51a0 8012694: Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read") Reviewed-by: jlaskey Contributed-by: konstantin.shefov at oracle.com Changeset: a92be4c0063b Author: jlaskey Date: 2013-05-17 16:12 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a92be4c0063b Merge - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java - src/netscape/javascript/JSObject.java Changeset: 1d5a8f1f416e Author: jlaskey Date: 2013-05-17 16:44 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1d5a8f1f416e 8014823: Reprise - Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read") Reviewed-by: jlaskey Contributed-by: konstantin.shefov at oracle.com ! test/script/basic/JDK-8008554.js From david.holmes at oracle.com Mon May 20 08:13:23 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 20 May 2013 15:13:23 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014871: Move @Contended regression tests to the same place Message-ID: <20130520151327.9751048BBF@hg.openjdk.java.net> Changeset: 5e3573e08a83 Author: shade Date: 2013-05-20 15:43 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5e3573e08a83 8014871: Move @Contended regression tests to the same place Summary: Move the missing test to appropriate location. Reviewed-by: dholmes, sla - test/runtime/8003985/Test8003985.java + test/runtime/contended/Basic.java From xueming.shen at oracle.com Mon May 20 11:59:29 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 20 May 2013 18:59:29 +0000 Subject: hg: jdk8/tl/jdk: 8004789: (zipfs) zip provider doesn't work correctly with file systems providers rather than the default Message-ID: <20130520185952.A40F548BC7@hg.openjdk.java.net> Changeset: 6a9148865139 Author: sherman Date: 2013-05-20 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a9148865139 8004789: (zipfs) zip provider doesn't work correctly with file systems providers rather than the default Summary: to use Files.createTempFile(...) to create the temp file on the same fs as the targeted path. Reviewed-by: alanb, sherman Contributed-by: philippe.marschall at gmail.com ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java From coleen.phillimore at oracle.com Mon May 20 15:39:27 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Mon, 20 May 2013 18:39:27 -0400 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror Message-ID: <519AA61F.6010507@oracle.com> Summary: Inject protection_domain, signers, init_lock into java_lang_Class Net footprint change is zero except that these fields are in Java heap rather than metaspace. This helps a little with InstanceKlass size which is in fixed size space with UseCompressedKlassPointers. Included serviceability because there were SA changes to code that I don't know is used. Future work is to remove the signers field and the unused SetProtectionDomain function. open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 Tested with vm.quick.testlist, JPRT, jtreg java/security tests and jck8 tests. Thanks, Coleen From huizhe.wang at oracle.com Mon May 20 16:12:35 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Mon, 20 May 2013 23:12:35 +0000 Subject: hg: jdk8/tl/jaxp: 8014891: Redundant setting of external access properties in setFeatures Message-ID: <20130520231237.47F0948BD0@hg.openjdk.java.net> Changeset: a7cec93e4682 Author: joehw Date: 2013-05-20 16:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a7cec93e4682 8014891: Redundant setting of external access properties in setFeatures Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java From dean.long at oracle.com Mon May 20 17:42:32 2013 From: dean.long at oracle.com (Dean Long) Date: Mon, 20 May 2013 17:42:32 -0700 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AA61F.6010507@oracle.com> References: <519AA61F.6010507@oracle.com> Message-ID: <519AC2F8.2060207@oracle.com> It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. dl On 05/20/2013 03:39 PM, Coleen Phillimore wrote: > Summary: Inject protection_domain, signers, init_lock into > java_lang_Class > > Net footprint change is zero except that these fields are in Java heap > rather than metaspace. This helps a little with InstanceKlass size > which is in fixed size space with UseCompressedKlassPointers. Included > serviceability because there were SA changes to code that I don't know > is used. > > Future work is to remove the signers field and the unused > SetProtectionDomain function. > > open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ > bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 > > Tested with vm.quick.testlist, JPRT, jtreg java/security tests and > jck8 tests. > > Thanks, > Coleen From david.holmes at oracle.com Mon May 20 19:34:43 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 May 2013 12:34:43 +1000 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519A751A.5090604@oracle.com> References: <519A751A.5090604@oracle.com> Message-ID: <519ADD43.1030601@oracle.com> Hi Joe, As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? Thanks, David On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: > The change is to include forte.cpp in the minimal jvm but to > conditionalize the code so that > only AsyncGetCallTrace() is defined with the minimal jvm. > > Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ > > * JDK-8013461 There is > a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in > minimal/libjvm.a when DEBUG_LEVEL == release > > > Thanks. > > joe > > From coleen.phillimore at oracle.com Mon May 20 19:50:27 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Mon, 20 May 2013 22:50:27 -0400 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AC2F8.2060207@oracle.com> References: <519AA61F.6010507@oracle.com> <519AC2F8.2060207@oracle.com> Message-ID: <519AE0F3.1070006@oracle.com> On 5/20/2013 8:42 PM, Dean Long wrote: > It seems like you could take this opportunity to make these declared > fields of java.lang.Class, > allowing, for example, getProtectionDomain0() to be a simple Java > method instead of a native method. We actually use the protection domain and init_lock from within the vm, so we want to be able to see it. Signers can be moved out eventually though. Thanks, Coleen > > dl > > On 05/20/2013 03:39 PM, Coleen Phillimore wrote: >> Summary: Inject protection_domain, signers, init_lock into >> java_lang_Class >> >> Net footprint change is zero except that these fields are in Java >> heap rather than metaspace. This helps a little with InstanceKlass >> size which is in fixed size space with UseCompressedKlassPointers. >> Included serviceability because there were SA changes to code that I >> don't know is used. >> >> Future work is to remove the signers field and the unused >> SetProtectionDomain function. >> >> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >> >> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and >> jck8 tests. >> >> Thanks, >> Coleen > From david.holmes at oracle.com Mon May 20 20:39:29 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 May 2013 13:39:29 +1000 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AA61F.6010507@oracle.com> References: <519AA61F.6010507@oracle.com> Message-ID: <519AEC71.3020804@oracle.com> Hi Coleen, On 21/05/2013 8:39 AM, Coleen Phillimore wrote: > Summary: Inject protection_domain, signers, init_lock into java_lang_Class Basic VM changes look fine to me. > Net footprint change is zero except that these fields are in Java heap > rather than metaspace. This helps a little with InstanceKlass size > which is in fixed size space with UseCompressedKlassPointers. Included > serviceability because there were SA changes to code that I don't know > is used. Unsure about the SA changes. Basically you just removed access to the pd and signers, rather than changing it to allow access via the new path. That said I don't know SA so don't know whether it makes sense for SA to access things that are logically part of java.lang.Class; or whether it can access them more directly anyway because they are logically part of java.lang.Class. Thanks, David ----- > Future work is to remove the signers field and the unused > SetProtectionDomain function. > > open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ > bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 > > Tested with vm.quick.testlist, JPRT, jtreg java/security tests and jck8 > tests. > > Thanks, > Coleen From dean.long at oracle.com Mon May 20 20:41:49 2013 From: dean.long at oracle.com (Dean Long) Date: Mon, 20 May 2013 20:41:49 -0700 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AE0F3.1070006@oracle.com> References: <519AA61F.6010507@oracle.com> <519AC2F8.2060207@oracle.com> <519AE0F3.1070006@oracle.com> Message-ID: <519AECFD.7080009@oracle.com> On 5/20/2013 7:50 PM, Coleen Phillimore wrote: > On 5/20/2013 8:42 PM, Dean Long wrote: >> It seems like you could take this opportunity to make these declared >> fields of java.lang.Class, >> allowing, for example, getProtectionDomain0() to be a simple Java >> method instead of a native method. > > We actually use the protection domain and init_lock from within the > vm, so we want to be able to see it. Signers can be moved out > eventually though. > The VM can already see Java fields. You would just need to initialize _protection_domain_offset using compute_offset() like we do for other fields. Java fields would also have the advantage of working with the new @Contended annotation, which probably doesn't work for injected fields. However for backwards compatability with an older class library you could use compute_optional_offset() and inject the field only if it's missing. dl > Thanks, > Coleen > >> >> dl >> >> On 05/20/2013 03:39 PM, Coleen Phillimore wrote: >>> Summary: Inject protection_domain, signers, init_lock into >>> java_lang_Class >>> >>> Net footprint change is zero except that these fields are in Java >>> heap rather than metaspace. This helps a little with InstanceKlass >>> size which is in fixed size space with UseCompressedKlassPointers. >>> Included serviceability because there were SA changes to code that I >>> don't know is used. >>> >>> Future work is to remove the signers field and the unused >>> SetProtectionDomain function. >>> >>> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >>> >>> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and >>> jck8 tests. >>> >>> Thanks, >>> Coleen >> > From david.holmes at oracle.com Mon May 20 20:42:51 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 May 2013 13:42:51 +1000 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AE0F3.1070006@oracle.com> References: <519AA61F.6010507@oracle.com> <519AC2F8.2060207@oracle.com> <519AE0F3.1070006@oracle.com> Message-ID: <519AED3B.3050903@oracle.com> On 21/05/2013 12:50 PM, Coleen Phillimore wrote: > On 5/20/2013 8:42 PM, Dean Long wrote: >> It seems like you could take this opportunity to make these declared >> fields of java.lang.Class, >> allowing, for example, getProtectionDomain0() to be a simple Java >> method instead of a native method. > > We actually use the protection domain and init_lock from within the vm, > so we want to be able to see it. Signers can be moved out eventually > though. But you can access those fields from the VM regardless - just as we access a bunch of fields in the Java level objects. That said having these as injected fields hides them in the VM, so no issue with reflective access etc. David > > Thanks, > Coleen > >> >> dl >> >> On 05/20/2013 03:39 PM, Coleen Phillimore wrote: >>> Summary: Inject protection_domain, signers, init_lock into >>> java_lang_Class >>> >>> Net footprint change is zero except that these fields are in Java >>> heap rather than metaspace. This helps a little with InstanceKlass >>> size which is in fixed size space with UseCompressedKlassPointers. >>> Included serviceability because there were SA changes to code that I >>> don't know is used. >>> >>> Future work is to remove the signers field and the unused >>> SetProtectionDomain function. >>> >>> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >>> >>> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and >>> jck8 tests. >>> >>> Thanks, >>> Coleen >> > From ioi.lam at oracle.com Mon May 20 21:02:07 2013 From: ioi.lam at oracle.com (Ioi Lam) Date: Mon, 20 May 2013 21:02:07 -0700 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AC2F8.2060207@oracle.com> References: <519AA61F.6010507@oracle.com> <519AC2F8.2060207@oracle.com> Message-ID: <519AF1BF.10708@oracle.com> But if you move these fields into Class.java (in JDK8), then hsx25 will not run on JDK7 anymore, unless these fields are also added in Class.java in JDK7. - Ioi On 05/20/2013 05:42 PM, Dean Long wrote: > It seems like you could take this opportunity to make these declared > fields of java.lang.Class, > allowing, for example, getProtectionDomain0() to be a simple Java > method instead of a native method. > > dl > > On 05/20/2013 03:39 PM, Coleen Phillimore wrote: >> Summary: Inject protection_domain, signers, init_lock into >> java_lang_Class >> >> Net footprint change is zero except that these fields are in Java >> heap rather than metaspace. This helps a little with InstanceKlass >> size which is in fixed size space with UseCompressedKlassPointers. >> Included serviceability because there were SA changes to code that I >> don't know is used. >> >> Future work is to remove the signers field and the unused >> SetProtectionDomain function. >> >> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >> >> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and >> jck8 tests. >> >> Thanks, >> Coleen > From vladimir.kozlov at oracle.com Mon May 20 21:31:33 2013 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Tue, 21 May 2013 04:31:33 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014878: Clean up class field layout code Message-ID: <20130521043137.D4F3C48BD9@hg.openjdk.java.net> Changeset: bbddfb08190f Author: shade Date: 2013-05-20 23:41 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bbddfb08190f 8014878: Clean up class field layout code Summary: rename/remove local variables, re-arrange instance_size calculation, more comments. Reviewed-by: kvn, coleenp ! src/share/vm/classfile/classFileParser.cpp From dean.long at oracle.com Mon May 20 21:50:34 2013 From: dean.long at oracle.com (Dean Long) Date: Mon, 20 May 2013 21:50:34 -0700 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AF1BF.10708@oracle.com> References: <519AA61F.6010507@oracle.com> <519AC2F8.2060207@oracle.com> <519AF1BF.10708@oracle.com> Message-ID: <519AFD1A.9080301@oracle.com> Right, unless there is a way to inject them conditionally. dl On 5/20/2013 9:02 PM, Ioi Lam wrote: > But if you move these fields into Class.java (in JDK8), then hsx25 > will not run on JDK7 anymore, unless these fields are also added in > Class.java in JDK7. > > - Ioi > > On 05/20/2013 05:42 PM, Dean Long wrote: >> It seems like you could take this opportunity to make these declared >> fields of java.lang.Class, >> allowing, for example, getProtectionDomain0() to be a simple Java >> method instead of a native method. >> >> dl >> >> On 05/20/2013 03:39 PM, Coleen Phillimore wrote: >>> Summary: Inject protection_domain, signers, init_lock into >>> java_lang_Class >>> >>> Net footprint change is zero except that these fields are in Java >>> heap rather than metaspace. This helps a little with InstanceKlass >>> size which is in fixed size space with UseCompressedKlassPointers. >>> Included serviceability because there were SA changes to code that I >>> don't know is used. >>> >>> Future work is to remove the signers field and the unused >>> SetProtectionDomain function. >>> >>> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >>> >>> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and >>> jck8 tests. >>> >>> Thanks, >>> Coleen >> > From david.holmes at oracle.com Mon May 20 22:12:24 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 May 2013 15:12:24 +1000 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AFD1A.9080301@oracle.com> References: <519AA61F.6010507@oracle.com> <519AC2F8.2060207@oracle.com> <519AF1BF.10708@oracle.com> <519AFD1A.9080301@oracle.com> Message-ID: <519B0238.7000006@oracle.com> On 21/05/2013 2:50 PM, Dean Long wrote: > Right, unless there is a way to inject them conditionally. You can inject them conditionally based on the JRE version, but then why bother moving to the Java level if you will still need the code in the VM ? > On 5/20/2013 9:02 PM, Ioi Lam wrote: >> But if you move these fields into Class.java (in JDK8), then hsx25 >> will not run on JDK7 anymore, unless these fields are also added in >> Class.java in JDK7. As I understand it hs25 is already limited in the versions of jdk7 that it can run in. David ----- >> >> - Ioi >> >> On 05/20/2013 05:42 PM, Dean Long wrote: >>> It seems like you could take this opportunity to make these declared >>> fields of java.lang.Class, >>> allowing, for example, getProtectionDomain0() to be a simple Java >>> method instead of a native method. >>> >>> dl >>> >>> On 05/20/2013 03:39 PM, Coleen Phillimore wrote: >>>> Summary: Inject protection_domain, signers, init_lock into >>>> java_lang_Class >>>> >>>> Net footprint change is zero except that these fields are in Java >>>> heap rather than metaspace. This helps a little with InstanceKlass >>>> size which is in fixed size space with UseCompressedKlassPointers. >>>> Included serviceability because there were SA changes to code that I >>>> don't know is used. >>>> >>>> Future work is to remove the signers field and the unused >>>> SetProtectionDomain function. >>>> >>>> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >>>> >>>> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and >>>> jck8 tests. >>>> >>>> Thanks, >>>> Coleen >>> >> > From david.holmes at oracle.com Mon May 20 22:18:38 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 21 May 2013 05:18:38 +0000 Subject: hg: jdk8/tl/jdk: 8014857: Enable ergonomic VM selection in arm/jvm.cfg Message-ID: <20130521051851.0FA6348BDB@hg.openjdk.java.net> Changeset: 1baf3d7fe2f1 Author: dholmes Date: 2013-05-21 01:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1baf3d7fe2f1 8014857: Enable ergonomic VM selection in arm/jvm.cfg Reviewed-by: darcy ! src/solaris/bin/arm/jvm.cfg From staffan.larsen at oracle.com Mon May 20 23:49:17 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 21 May 2013 08:49:17 +0200 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519ADD43.1030601@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> Message-ID: On 21 maj 2013, at 04:34, David Holmes wrote: > > > Hi Joe, > > As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. > > Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. /Staffan > > Thanks, > David > > On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >> The change is to include forte.cpp in the minimal jvm but to >> conditionalize the code so that >> only AsyncGetCallTrace() is defined with the minimal jvm. >> >> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >> >> * JDK-8013461 There is >> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >> minimal/libjvm.a when DEBUG_LEVEL == release >> >> >> Thanks. >> >> joe >> >> From huizhe.wang at oracle.com Mon May 20 23:47:43 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 21 May 2013 06:47:43 +0000 Subject: hg: jdk8/tl/jaxp: 8012683: Remove unused, obsolete ObjectFactory classes Message-ID: <20130521064745.7E3E248BDF@hg.openjdk.java.net> Changeset: 37b73984640a Author: joehw Date: 2013-05-20 23:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/37b73984640a 8012683: Remove unused, obsolete ObjectFactory classes Reviewed-by: lancea - src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java From david.holmes at oracle.com Tue May 21 00:06:06 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 May 2013 17:06:06 +1000 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> Message-ID: <519B1CDE.4090507@oracle.com> Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrote: > > On 21 maj 2013, at 04:34, David Holmes wrote: > >> >> >> Hi Joe, >> >> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >> >> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? > > Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). > I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. > > As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. I guess we need to try and run it to find out. Thanks, David > /Staffan > >> >> Thanks, >> David >> >> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>> The change is to include forte.cpp in the minimal jvm but to >>> conditionalize the code so that >>> only AsyncGetCallTrace() is defined with the minimal jvm. >>> >>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>> >>> * JDK-8013461 There is >>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>> minimal/libjvm.a when DEBUG_LEVEL == release >>> >>> >>> Thanks. >>> >>> joe >>> >>> > From sundararajan.athijegannathan at oracle.com Tue May 21 00:27:37 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 21 May 2013 07:27:37 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20130521072740.0FC5B48BE0@hg.openjdk.java.net> Changeset: 92164a5742db Author: lagergren Date: 2013-05-20 16:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/92164a5742db 8006069: Range analysis first iteration, runtime specializations Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + src/jdk/nashorn/internal/codegen/RangeAnalyzer.java + src/jdk/nashorn/internal/codegen/types/Range.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/runtime/CompiledFunction.java ! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/ranges_disabled.js + test/script/basic/ranges_disabled.js.EXPECTED + test/script/basic/ranges_enabled.js + test/script/basic/ranges_enabled.js.EXPECTED + test/script/basic/ranges_payload.js Changeset: b558e19d5de5 Author: sundar Date: 2013-05-20 23:04 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b558e19d5de5 8014909: ant test compilation error with JoniTest.java Reviewed-by: jlaskey ! make/build.xml Changeset: 1fd18f40ab52 Author: attila Date: 2013-05-20 21:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1fd18f40ab52 8014797: rename Java.toJavaArray/toJavaScriptArray to Java.to/from, respectively. Reviewed-by: jlaskey, sundar ! docs/JavaScriptingProgrammersGuide.html ! docs/source/javaarray.js ! src/jdk/nashorn/api/scripting/resources/engine.js ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! test/script/basic/NASHORN-556.js ! test/script/basic/javaarrayconversion.js ! test/script/currently-failing/logcoverage.js ! test/script/trusted/NASHORN-638.js ! test/script/trusted/NASHORN-653.js From alan.bateman at oracle.com Tue May 21 00:58:57 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 21 May 2013 07:58:57 +0000 Subject: hg: jdk8/tl/jdk: 8014892: More ProblemList.txt updates (5/2013) Message-ID: <20130521075910.6E4FC48BE3@hg.openjdk.java.net> Changeset: 20925206aef8 Author: alanb Date: 2013-05-21 08:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20925206aef8 8014892: More ProblemList.txt updates (5/2013) Reviewed-by: alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt From yong.huang at oracle.com Tue May 21 01:53:42 2013 From: yong.huang at oracle.com (yong.huang at oracle.com) Date: Tue, 21 May 2013 08:53:42 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130521085406.EFDE748BE7@hg.openjdk.java.net> Changeset: 63c7e92e5e6d Author: yhuang Date: 2013-05-20 23:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63c7e92e5e6d 7074882: Locale data needs correction (Month names for Maltese language) Reviewed-by: naoto ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 1fba35ef4360 Author: yhuang Date: 2013-05-21 01:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fba35ef4360 Merge From stefan.karlsson at oracle.com Tue May 21 02:11:14 2013 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Tue, 21 May 2013 11:11:14 +0200 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AA61F.6010507@oracle.com> References: <519AA61F.6010507@oracle.com> Message-ID: <519B3A32.1010705@oracle.com> Hi Coleen, Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes Some comments below: On 05/21/2013 12:39 AM, Coleen Phillimore wrote: > Summary: Inject protection_domain, signers, init_lock into > java_lang_Class > > Net footprint change is zero except that these fields are in Java heap > rather than metaspace. There should be some memory saved since we now use compressed oops for the embedded fields. > This helps a little with InstanceKlass size which is in fixed size > space with UseCompressedKlassPointers. Included serviceability because > there were SA changes to code that I don't know is used. > > Future work is to remove the signers field and the unused > SetProtectionDomain function. > > open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ > bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.hpp.patch // protection domain - oop protection_domain() { return _protection_domain; } - void set_protection_domain(oop pd) { klass_oop_store(&_protection_domain, pd); } + oop protection_domain() const; + void set_protection_domain(Handle pd); ... // signers - objArrayOop signers() const { return _signers; } - void set_signers(objArrayOop s) { klass_oop_store((oop*)&_signers, s); } + objArrayOop signers() const; + void set_signers(objArrayOop s); You don't really need the setters on the InstanceKlass anymore. They are only used in jvm.cpp where they take a couple of unnecessary indirections: mirror -> IK -> mirror->set_protection_domain/set_signers. http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/arrayKlass.cpp.udiff.html - java_lang_Class::create_mirror(k, CHECK); + java_lang_Class::create_mirror(k, Handle(NULL), CHECK); You use NULL here since typeArrays always return a NULL pd, and objArrays always returns the pd of the bottom klass? http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.cpp.patch -void InstanceKlass::oops_do(OopClosure* cl) { - Klass::oops_do(cl); - - cl->do_oop(adr_protection_domain()); - cl->do_oop(adr_signers()); - cl->do_oop(adr_init_lock()); - - // Don't walk the arrays since they are walked from the ClassLoaderData objects. -} If we could move ArrayKlass::_component_mirror into the j.l.Class, then _java_mirror would be the only oop in the klasses and we could make Klass::oops_do non-virtual ... Another thing. If we could direct-allocate the java mirrors in the old gen, then we wouldn't have to walk all the klasses during the young GCs. This would make the GCs a bit less complicated and we could get rid of these fields in Klass: // Remembered sets support for the oops in the klasses. jbyte _modified_oops; // Card Table Equivalent (YC/CMS support) jbyte _accumulated_modified_oops; // Mod Union Equivalent (CMS support) thanks, StefanK > > Tested with vm.quick.testlist, JPRT, jtreg java/security tests and > jck8 tests. > > Thanks, > Coleen From joel.franck at oracle.com Tue May 21 03:02:59 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 21 May 2013 10:02:59 +0000 Subject: hg: jdk8/tl/langtools: 8013180: Qualified type reference with annotations in throws list crashes compiler Message-ID: <20130521100302.A893E48BE8@hg.openjdk.java.net> Changeset: 67cbd6d756f4 Author: jfranck Date: 2013-05-21 12:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67cbd6d756f4 8013180: Qualified type reference with annotations in throws list crashes compiler Reviewed-by: jjg + test/tools/javac/annotations/typeAnnotations/8013180/QualifiedName.java From vicente.romero at oracle.com Tue May 21 03:42:05 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 10:42:05 +0000 Subject: hg: jdk8/tl/langtools: 7177168: Redundant array copy in UnsharedNameTable Message-ID: <20130521104209.7400548BEB@hg.openjdk.java.net> Changeset: 824932ecdbc8 Author: vromero Date: 2013-05-21 11:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/824932ecdbc8 7177168: Redundant array copy in UnsharedNameTable Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java From vicente.romero at oracle.com Tue May 21 04:18:20 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 11:18:20 +0000 Subject: hg: jdk8/tl/langtools: 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir Message-ID: <20130521111823.EE51348BEC@hg.openjdk.java.net> Changeset: 3d9750039fff Author: vromero Date: 2013-05-21 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d9750039fff 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java From coleen.phillimore at oracle.com Tue May 21 05:27:35 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 21 May 2013 08:27:35 -0400 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519AEC71.3020804@oracle.com> References: <519AA61F.6010507@oracle.com> <519AEC71.3020804@oracle.com> Message-ID: <519B6837.3020407@oracle.com> On 05/20/2013 11:39 PM, David Holmes wrote: > Hi Coleen, > > On 21/05/2013 8:39 AM, Coleen Phillimore wrote: >> Summary: Inject protection_domain, signers, init_lock into >> java_lang_Class > > Basic VM changes look fine to me. Thanks! > >> Net footprint change is zero except that these fields are in Java heap >> rather than metaspace. This helps a little with InstanceKlass size >> which is in fixed size space with UseCompressedKlassPointers. Included >> serviceability because there were SA changes to code that I don't know >> is used. > > Unsure about the SA changes. Basically you just removed access to the > pd and signers, rather than changing it to allow access via the new > path. That said I don't know SA so don't know whether it makes sense > for SA to access things that are logically part of java.lang.Class; or > whether it can access them more directly anyway because they are > logically part of java.lang.Class. > I did remove these from instanceKlass. It doesn't appear in the SA that it digs into the java mirror so there was nowhere to put these fields. The code that I took out was in places that may not be used and may be bit rotted. I added serviceability team to the review request so someone could comment. I already asked Staffan about this. Thanks, Coleen > Thanks, > David > ----- > >> Future work is to remove the signers field and the unused >> SetProtectionDomain function. >> >> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >> >> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and jck8 >> tests. >> >> Thanks, >> Coleen From vicente.romero at oracle.com Tue May 21 05:51:37 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 12:51:37 +0000 Subject: hg: jdk8/tl/langtools: 8005207: test has 2 @bug tags Message-ID: <20130521125141.2FAA948BF3@hg.openjdk.java.net> Changeset: 37295244f534 Author: vromero Date: 2013-05-21 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37295244f534 8005207: test has 2 @bug tags Reviewed-by: mcimadamore ! test/tools/doclint/RunTest.java ! test/tools/javac/5045412/Bar.java ! test/tools/javac/5045412/Foo.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/mandatoryWarnings/deprecated/Test.java ! test/tools/javac/mandatoryWarnings/unchecked/Test.java ! test/tools/javac/policy/test3/Test.java From coleen.phillimore at oracle.com Tue May 21 05:52:27 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 21 May 2013 08:52:27 -0400 Subject: Need help with change Message-ID: <519B6E0B.1030402@oracle.com> I found during code review comment editing for my change that removes signers and protection domain from the InstanceKlass, that JVMTI code seems to have some sort of call back and knowledge of these fields in instanceKlass. Reference from a class to its signers array. Reference from a class to its protection domain. If I remove these, will it cause incompatibilities? It's used during jvmtiTagMap.cpp (whatever that's doing). Thanks, Coleen From staffan.larsen at oracle.com Tue May 21 06:18:44 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 21 May 2013 15:18:44 +0200 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519B6837.3020407@oracle.com> References: <519AA61F.6010507@oracle.com> <519AEC71.3020804@oracle.com> <519B6837.3020407@oracle.com> Message-ID: >>> Net footprint change is zero except that these fields are in Java heap >>> rather than metaspace. This helps a little with InstanceKlass size >>> which is in fixed size space with UseCompressedKlassPointers. Included >>> serviceability because there were SA changes to code that I don't know >>> is used. >> >> Unsure about the SA changes. Basically you just removed access to the pd and signers, rather than changing it to allow access via the new path. That said I don't know SA so don't know whether it makes sense for SA to access things that are logically part of java.lang.Class; or whether it can access them more directly anyway because they are logically part of java.lang.Class. >> > > I did remove these from instanceKlass. It doesn't appear in the SA that it digs into the java mirror so there was nowhere to put these fields. The code that I took out was in places that may not be used and may be bit rotted. I added serviceability team to the review request so someone could comment. I already asked Staffan about this. Reading this in more detail, I'm a little worried about the change in hprof output. The change in HeapHprofBinWriter actually breaks the hprof binary format, leading to unparseable files. Granted, this is hprof output when invoked either in SA or with "jmap -F" so it won't be used by very many people and I can't find any tests that do this. I think we need to find a way to add this information back. /Staffan From staffan.larsen at oracle.com Tue May 21 06:29:16 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 21 May 2013 15:29:16 +0200 Subject: Need help with change In-Reply-To: <519B6E0B.1030402@oracle.com> References: <519B6E0B.1030402@oracle.com> Message-ID: When doing heap iteration with JVMTI, the spec requires callbacks from the VM to the agent identifying the signers and protection domain references. This is what tagMap does, see jvmtiTagMap.cpp:2464. As long as it it still possible for JVMTI to find these references (with ik->protection_domain() and ik->signers()), I think it's ok. /Staffan On 21 maj 2013, at 14:52, Coleen Phillimore wrote: > > I found during code review comment editing for my change that removes signers and protection domain from the InstanceKlass, that JVMTI code seems to have some sort of call back and knowledge of these fields in instanceKlass. > > > > Reference from a class to its signers array. > > > Reference from a class to its protection domain. > > > If I remove these, will it cause incompatibilities? It's used during jvmtiTagMap.cpp (whatever that's doing). > > Thanks, > Coleen From vicente.romero at oracle.com Tue May 21 06:33:41 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 13:33:41 +0000 Subject: hg: jdk8/tl/langtools: 7164114: Two jtreg tests are not run due to no file extension on the test files Message-ID: <20130521133343.D6F9F48BF5@hg.openjdk.java.net> Changeset: 08daea43a7f8 Author: vromero Date: 2013-05-21 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/08daea43a7f8 7164114: Two jtreg tests are not run due to no file extension on the test files Reviewed-by: mcimadamore - test/tools/javac/HiddenAbstractMethod/Test + test/tools/javac/HiddenAbstractMethod/Test.java - test/tools/javac/NonAmbiguousField/Test + test/tools/javac/NonAmbiguousField/Test.java ! test/tools/javac/NonAmbiguousField/two/Child2.java From coleen.phillimore at oracle.com Tue May 21 06:56:56 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 21 May 2013 09:56:56 -0400 Subject: Need help with change In-Reply-To: References: <519B6E0B.1030402@oracle.com> Message-ID: <519B7D28.7000505@oracle.com> On 05/21/2013 09:29 AM, Staffan Larsen wrote: > When doing heap iteration with JVMTI, the spec requires callbacks from the VM to the agent identifying the signers and protection domain references. This is what tagMap does, see jvmtiTagMap.cpp:2464. > > As long as it it still possible for JVMTI to find these references (with ik->protection_domain() and ik->signers()), I think it's ok. Okay. Thanks for the quick answer. I was going to rip this out (rats, now I can't). I can get to both protection domain and signers through the mirror. We are working on moving the signers completely to the jdk and not having the jvm know about them at all. Then we can't find the signers through this interface. Should we file a CCC request to change the JVMTI spec then? Thanks, Coleen > > /Staffan > > > On 21 maj 2013, at 14:52, Coleen Phillimore wrote: > >> I found during code review comment editing for my change that removes signers and protection domain from the InstanceKlass, that JVMTI code seems to have some sort of call back and knowledge of these fields in instanceKlass. >> >> >> >> Reference from a class to its signers array. >> >> >> Reference from a class to its protection domain. >> >> >> If I remove these, will it cause incompatibilities? It's used during jvmtiTagMap.cpp (whatever that's doing). >> >> Thanks, >> Coleen From coleen.phillimore at oracle.com Tue May 21 07:12:44 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 21 May 2013 10:12:44 -0400 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519B3A32.1010705@oracle.com> References: <519AA61F.6010507@oracle.com> <519B3A32.1010705@oracle.com> Message-ID: <519B80DC.8060803@oracle.com> On 05/21/2013 05:11 AM, Stefan Karlsson wrote: > Hi Coleen, > > Good to see all these oops moving to the mirrors. I think the changes > look good. I let someone else review the SA changes Yes, I'm hoping for someone to review the SA changes. > > Some comments below: > > On 05/21/2013 12:39 AM, Coleen Phillimore wrote: >> Summary: Inject protection_domain, signers, init_lock into >> java_lang_Class >> >> Net footprint change is zero except that these fields are in Java >> heap rather than metaspace. > > There should be some memory saved since we now use compressed oops for > the embedded fields. That's right. > >> This helps a little with InstanceKlass size which is in fixed size >> space with UseCompressedKlassPointers. Included serviceability >> because there were SA changes to code that I don't know is used. >> >> Future work is to remove the signers field and the unused >> SetProtectionDomain function. >> >> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 > > http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.hpp.patch > > > // protection domain > - oop protection_domain() { return > _protection_domain; } > - void set_protection_domain(oop pd) { > klass_oop_store(&_protection_domain, pd); } > + oop protection_domain() const; > + void set_protection_domain(Handle pd); > ... > // signers > - objArrayOop signers() const { return _signers; } > - void set_signers(objArrayOop s) { > klass_oop_store((oop*)&_signers, s); } > + objArrayOop signers() const; > + void set_signers(objArrayOop s); > > You don't really need the setters on the InstanceKlass anymore. They > are only used in jvm.cpp where they take a couple of unnecessary > indirections: mirror -> IK -> mirror->set_protection_domain/set_signers. > I left these accessor functions in with a comment that JVMTI spec defined these fields in InstanceKlass and we have to simulate that they are still there for compatibility. > http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/arrayKlass.cpp.udiff.html > > > - java_lang_Class::create_mirror(k, CHECK); > + java_lang_Class::create_mirror(k, Handle(NULL), CHECK); > > You use NULL here since typeArrays always return a NULL pd, and > objArrays always returns the pd of the bottom klass? > Yes. > http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.cpp.patch > > > -void InstanceKlass::oops_do(OopClosure* cl) { > - Klass::oops_do(cl); > - > - cl->do_oop(adr_protection_domain()); > - cl->do_oop(adr_signers()); > - cl->do_oop(adr_init_lock()); > - > - // Don't walk the arrays since they are walked from the > ClassLoaderData objects. > -} > > If we could move ArrayKlass::_component_mirror into the j.l.Class, > then _java_mirror would be the only oop in the klasses and we could > make Klass::oops_do non-virtual ... > That would add a field to all mirrors though. It's a bit harder but it would be nice to have smaller mirrors for array klasses vs. instanceKlasses. > Another thing. If we could direct-allocate the java mirrors in the old > gen, then we wouldn't have to walk all the klasses during the young > GCs. This would make the GCs a bit less complicated and we could get > rid of these fields in Klass: > > // Remembered sets support for the oops in the klasses. > jbyte _modified_oops; // Card Table Equivalent (YC/CMS > support) > jbyte _accumulated_modified_oops; // Mod Union Equivalent (CMS support) > Yes, we want to move in this direction! Not with this change though. Coleen > thanks, > StefanK > >> >> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and >> jck8 tests. >> >> Thanks, >> Coleen > From stefan.karlsson at oracle.com Tue May 21 07:38:49 2013 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Tue, 21 May 2013 16:38:49 +0200 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: <519B80DC.8060803@oracle.com> References: <519AA61F.6010507@oracle.com> <519B3A32.1010705@oracle.com> <519B80DC.8060803@oracle.com> Message-ID: On 21 maj 2013, at 16:12, Coleen Phillimore wrote: > > On 05/21/2013 05:11 AM, Stefan Karlsson wrote: >> Hi Coleen, >> >> Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes > > Yes, I'm hoping for someone to review the SA changes. >> >> Some comments below: >> >> On 05/21/2013 12:39 AM, Coleen Phillimore wrote: >>> Summary: Inject protection_domain, signers, init_lock into java_lang_Class >>> >>> Net footprint change is zero except that these fields are in Java heap rather than metaspace. >> >> There should be some memory saved since we now use compressed oops for the embedded fields. > > That's right. >> >>> This helps a little with InstanceKlass size which is in fixed size space with UseCompressedKlassPointers. Included serviceability because there were SA changes to code that I don't know is used. >>> >>> Future work is to remove the signers field and the unused SetProtectionDomain function. >>> >>> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >> >> http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.hpp.patch >> >> // protection domain >> - oop protection_domain() { return _protection_domain; } >> - void set_protection_domain(oop pd) { klass_oop_store(&_protection_domain, pd); } >> + oop protection_domain() const; >> + void set_protection_domain(Handle pd); >> ... >> // signers >> - objArrayOop signers() const { return _signers; } >> - void set_signers(objArrayOop s) { klass_oop_store((oop*)&_signers, s); } >> + objArrayOop signers() const; >> + void set_signers(objArrayOop s); >> >> You don't really need the setters on the InstanceKlass anymore. They are only used in jvm.cpp where they take a couple of unnecessary indirections: mirror -> IK -> mirror->set_protection_domain/set_signers. > > I left these accessor functions in with a comment that JVMTI spec defined these fields in InstanceKlass and we have to simulate that they are still there for compatibility. Where in the spec does it mention InstanceKlasses? I still see no reason to keep the setters. > >> http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/arrayKlass.cpp.udiff.html >> >> - java_lang_Class::create_mirror(k, CHECK); >> + java_lang_Class::create_mirror(k, Handle(NULL), CHECK); >> >> You use NULL here since typeArrays always return a NULL pd, and objArrays always returns the pd of the bottom klass? > > Yes. >> http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.cpp.patch >> >> -void InstanceKlass::oops_do(OopClosure* cl) { >> - Klass::oops_do(cl); >> - >> - cl->do_oop(adr_protection_domain()); >> - cl->do_oop(adr_signers()); >> - cl->do_oop(adr_init_lock()); >> - >> - // Don't walk the arrays since they are walked from the ClassLoaderData objects. >> -} >> >> If we could move ArrayKlass::_component_mirror into the j.l.Class, then _java_mirror would be the only oop in the klasses and we could make Klass::oops_do non-virtual ... > > That would add a field to all mirrors though. Unless we reuse the pd field, which isn't used for the arrays. But that's a hack. > It's a bit harder but it would be nice to have smaller mirrors for array klasses vs. instanceKlasses. The size of the mirrors are already of variable size, because of the static fields, so this would probably be a good idea. Something for the Embedded team to pursue maybe? > > >> Another thing. If we could direct-allocate the java mirrors in the old gen, then we wouldn't have to walk all the klasses during the young GCs. This would make the GCs a bit less complicated and we could get rid of these fields in Klass: >> >> // Remembered sets support for the oops in the klasses. >> jbyte _modified_oops; // Card Table Equivalent (YC/CMS support) >> jbyte _accumulated_modified_oops; // Mod Union Equivalent (CMS support) > > Yes, we want to move in this direction! Not with this change though. Of course. I'm fine with your current changes as they are. StefanK > > Coleen >> thanks, >> StefanK >> >>> >>> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and jck8 tests. >>> >>> Thanks, >>> Coleen > From coleen.phillimore at oracle.com Tue May 21 07:41:59 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 21 May 2013 10:41:59 -0400 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: References: <519AA61F.6010507@oracle.com> <519B3A32.1010705@oracle.com> <519B80DC.8060803@oracle.com> Message-ID: <519B87B7.2010702@oracle.com> Thanks Stefan, I have 2 small comments. On 05/21/2013 10:38 AM, Stefan Karlsson wrote: > On 21 maj 2013, at 16:12, Coleen Phillimore wrote: > >> On 05/21/2013 05:11 AM, Stefan Karlsson wrote: >>> Hi Coleen, >>> >>> Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes >> Yes, I'm hoping for someone to review the SA changes. >>> Some comments below: >>> >>> On 05/21/2013 12:39 AM, Coleen Phillimore wrote: >>>> Summary: Inject protection_domain, signers, init_lock into java_lang_Class >>>> >>>> Net footprint change is zero except that these fields are in Java heap rather than metaspace. >>> There should be some memory saved since we now use compressed oops for the embedded fields. >> That's right. >>>> This helps a little with InstanceKlass size which is in fixed size space with UseCompressedKlassPointers. Included serviceability because there were SA changes to code that I don't know is used. >>>> >>>> Future work is to remove the signers field and the unused SetProtectionDomain function. >>>> >>>> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/ >>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421 >>> http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.hpp.patch >>> >>> // protection domain >>> - oop protection_domain() { return _protection_domain; } >>> - void set_protection_domain(oop pd) { klass_oop_store(&_protection_domain, pd); } >>> + oop protection_domain() const; >>> + void set_protection_domain(Handle pd); >>> ... >>> // signers >>> - objArrayOop signers() const { return _signers; } >>> - void set_signers(objArrayOop s) { klass_oop_store((oop*)&_signers, s); } >>> + objArrayOop signers() const; >>> + void set_signers(objArrayOop s); >>> >>> You don't really need the setters on the InstanceKlass anymore. They are only used in jvm.cpp where they take a couple of unnecessary indirections: mirror -> IK -> mirror->set_protection_domain/set_signers. >> I left these accessor functions in with a comment that JVMTI spec defined these fields in InstanceKlass and we have to simulate that they are still there for compatibility. > Where in the spec does it mention InstanceKlasses? The hprof format and jvmtiTagMap spec assumes they are dumped and the callbacks are there. > > I still see no reason to keep the setters. Oh, yes, I deleted them. Thanks. > >>> http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/arrayKlass.cpp.udiff.html >>> >>> - java_lang_Class::create_mirror(k, CHECK); >>> + java_lang_Class::create_mirror(k, Handle(NULL), CHECK); >>> >>> You use NULL here since typeArrays always return a NULL pd, and objArrays always returns the pd of the bottom klass? >> Yes. >>> http://cr.openjdk.java.net/~coleenp/8003421/src/share/vm/oops/instanceKlass.cpp.patch >>> >>> -void InstanceKlass::oops_do(OopClosure* cl) { >>> - Klass::oops_do(cl); >>> - >>> - cl->do_oop(adr_protection_domain()); >>> - cl->do_oop(adr_signers()); >>> - cl->do_oop(adr_init_lock()); >>> - >>> - // Don't walk the arrays since they are walked from the ClassLoaderData objects. >>> -} >>> >>> If we could move ArrayKlass::_component_mirror into the j.l.Class, then _java_mirror would be the only oop in the klasses and we could make Klass::oops_do non-virtual ... >> That would add a field to all mirrors though. > Unless we reuse the pd field, which isn't used for the arrays. But that's a hack. > >> It's a bit harder but it would be nice to have smaller mirrors for array klasses vs. instanceKlasses. > The size of the mirrors are already of variable size, because of the static fields, so this would probably be a good idea. Something for the Embedded team to pursue maybe? Yes, or a separate change for runtime. > >> >>> Another thing. If we could direct-allocate the java mirrors in the old gen, then we wouldn't have to walk all the klasses during the young GCs. This would make the GCs a bit less complicated and we could get rid of these fields in Klass: >>> >>> // Remembered sets support for the oops in the klasses. >>> jbyte _modified_oops; // Card Table Equivalent (YC/CMS support) >>> jbyte _accumulated_modified_oops; // Mod Union Equivalent (CMS support) >> Yes, we want to move in this direction! Not with this change though. > Of course. I'm fine with your current changes as they are. Thanks! I've made some changes so am retesting. I also changed the SA code, so I have to send out another review. Coleen > StefanK > >> Coleen >>> thanks, >>> StefanK >>> >>>> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and jck8 tests. >>>> >>>> Thanks, >>>> Coleen From coleen.phillimore at oracle.com Tue May 21 08:01:20 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Tue, 21 May 2013 11:01:20 -0400 Subject: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror In-Reply-To: References: <519AA61F.6010507@oracle.com> <519AEC71.3020804@oracle.com> <519B6837.3020407@oracle.com> Message-ID: <519B8C40.6010503@oracle.com> On 05/21/2013 09:18 AM, Staffan Larsen wrote: >>>> Net footprint change is zero except that these fields are in Java heap >>>> rather than metaspace. This helps a little with InstanceKlass size >>>> which is in fixed size space with UseCompressedKlassPointers. Included >>>> serviceability because there were SA changes to code that I don't know >>>> is used. >>> Unsure about the SA changes. Basically you just removed access to the pd and signers, rather than changing it to allow access via the new path. That said I don't know SA so don't know whether it makes sense for SA to access things that are logically part of java.lang.Class; or whether it can access them more directly anyway because they are logically part of java.lang.Class. >>> >> I did remove these from instanceKlass. It doesn't appear in the SA that it digs into the java mirror so there was nowhere to put these fields. The code that I took out was in places that may not be used and may be bit rotted. I added serviceability team to the review request so someone could comment. I already asked Staffan about this. > Reading this in more detail, I'm a little worried about the change in hprof output. The change in HeapHprofBinWriter actually breaks the hprof binary format, leading to unparseable files. Granted, this is hprof output when invoked either in SA or with "jmap -F" so it won't be used by very many people and I can't find any tests that do this. > > I think we need to find a way to add this information back. Hi, I didn't want to break the hprof format so I added it back to return null for protection domain and signers. There doesn't seem to be a way in SA to read from the mirror but I posted suggested code once this sort of thing is implemented. See: http://cr.openjdk.java.net/~coleenp/8003421_2/agent/src/share/classes/sun/jvm/hotspot/utilities/HeapGXLWriter.java.udiff.html http://cr.openjdk.java.net/~coleenp/8003421_2/agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java.udiff.html I can file a bug against the SA to get the correct information or decide whether this is something you need to support in this manner. thanks, Coleen > > /Staffan From joseph.provino at oracle.com Tue May 21 08:26:48 2013 From: joseph.provino at oracle.com (JOSEPH PROVINO) Date: Tue, 21 May 2013 11:26:48 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519ADD43.1030601@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> Message-ID: <519B9238.5030601@oracle.com> On 5/20/2013 10:34 PM, David Holmes wrote: > > > Hi Joe, > > As I have previously stated you copied the struct definitions instead > of moving them outside the ifdef. I fixed this and will send out a new webrev. joe > > Serviceability folk: we are particularly interested in whether the use > of ticks_no_class_load is deemed appropriate in this situation. Who > will be consuming this value? > > Thanks, > David > > On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >> The change is to include forte.cpp in the minimal jvm but to >> conditionalize the code so that >> only AsyncGetCallTrace() is defined with the minimal jvm. >> >> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >> >> * JDK-8013461 There is >> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >> minimal/libjvm.a when DEBUG_LEVEL == release >> >> >> Thanks. >> >> joe >> >> From joseph.provino at oracle.com Tue May 21 08:33:19 2013 From: joseph.provino at oracle.com (JOSEPH PROVINO) Date: Tue, 21 May 2013 11:33:19 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> Message-ID: <519B93BF.4030309@oracle.com> On 5/21/2013 2:49 AM, Staffan Larsen wrote: > On 21 maj 2013, at 04:34, David Holmes wrote: > >> >> >> Hi Joe, >> >> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >> >> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? > Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. Okay, it sounds like I should abandon this approach and look into removing the symbol from the symbol files. > > As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. Sounds like returning an error isn't a good idea... joe > > /Staffan > >> Thanks, >> David >> >> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>> The change is to include forte.cpp in the minimal jvm but to >>> conditionalize the code so that >>> only AsyncGetCallTrace() is defined with the minimal jvm. >>> >>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>> >>> * JDK-8013461 There is >>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>> minimal/libjvm.a when DEBUG_LEVEL == release >>> >>> >>> Thanks. >>> >>> joe >>> >>> From joseph.provino at oracle.com Tue May 21 08:35:14 2013 From: joseph.provino at oracle.com (JOSEPH PROVINO) Date: Tue, 21 May 2013 11:35:14 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519B1CDE.4090507@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> Message-ID: <519B9432.50808@oracle.com> On 5/21/2013 3:06 AM, David Holmes wrote: > Hi Staffan, > > On 21/05/2013 4:49 PM, Staffan Larsen wrote: >> >> On 21 maj 2013, at 04:34, David Holmes wrote: >> >>> >>> >>> Hi Joe, >>> >>> As I have previously stated you copied the struct definitions >>> instead of moving them outside the ifdef. >>> >>> Serviceability folk: we are particularly interested in whether the >>> use of ticks_no_class_load is deemed appropriate in this situation. >>> Who will be consuming this value? >> >> Since you have opted for the simple fix of having an exported but >> non-functional AsyncGetCallTrace instead of actually removing the >> symbol from the symbol files (which is the proposed solution in the >> bug report), > > That would be a simpler solution semantically but the only way I can > see to do that is to use a text replacement mechanism in the build > files - as is done for the dynamic vtable symbols. I find that less > appealing than simply exporting an interface that is configured to > report an error (which is essentially what all the optional interfaces > do under the minimal VM). > >> I would like you to include a comment about this in the source. Right >> now it's very unclear why there is an exported function that only >> returns an error. >> >> As to the appropriate return value, I don't know. The only caller >> should be the Sun Studio profiler, and I'm not sure how it will >> handle this case if ever run. The possible return values aren't very >> well documented. > > I guess we need to try and run it to find out. Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? joe > > Thanks, > David > >> /Staffan >> >>> >>> Thanks, >>> David >>> >>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>> The change is to include forte.cpp in the minimal jvm but to >>>> conditionalize the code so that >>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>> >>>> Webrev is here: >>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>> >>>> * JDK-8013461 >>>> There is >>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not >>>> exist in >>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>> >>>> >>>> Thanks. >>>> >>>> joe >>>> >>>> >> From kellyohair at gmail.com Tue May 21 09:33:22 2013 From: kellyohair at gmail.com (Kelly O'Hair) Date: Tue, 21 May 2013 09:33:22 -0700 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519B9432.50808@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> Message-ID: <365E7794-6CAD-4FB8-A6F8-7A5424BFE378@gmail.com> http://jeremymanson.blogspot.com/2007/05/profiling-with-jvmtijvmpi-sigprof-and.html http://stackoverflow.com/questions/3426537/how-to-properly-write-a-sigprof-handler-that-invokes-asyncgetcalltrace http://hiroshiyamauchi.blogspot.com/2008/12/stabilizing-asyncgetcalltrace.html The AsyncGetCallTrace symbol is a public extern symbol, unfortunately. So there may be third party shared libraries dependent on the extern, and optionally calling it. Removing the symbol will prevent those libraries from linking into the VM, even if they don't call it. Just FYI... -kto On May 21, 2013, at 8:35 AM, JOSEPH PROVINO wrote: > > On 5/21/2013 3:06 AM, David Holmes wrote: >> Hi Staffan, >> >> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>> >>> On 21 maj 2013, at 04:34, David Holmes wrote: >>> >>>> >>>> >>>> Hi Joe, >>>> >>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >>>> >>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? >>> >>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), >> >> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). >> >>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. >>> >>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. >> >> I guess we need to try and run it to find out. > > Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? > > joe > >> >> Thanks, >> David >> >>> /Staffan >>> >>>> >>>> Thanks, >>>> David >>>> >>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>> The change is to include forte.cpp in the minimal jvm but to >>>>> conditionalize the code so that >>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>> >>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>> >>>>> * JDK-8013461 There is >>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>> >>>>> >>>>> Thanks. >>>>> >>>>> joe >>>>> >>>>> >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130521/12fd3241/attachment-0001.html From staffan.larsen at oracle.com Tue May 21 11:21:27 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 21 May 2013 20:21:27 +0200 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <365E7794-6CAD-4FB8-A6F8-7A5424BFE378@gmail.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <365E7794-6CAD-4FB8-A6F8-7A5424BFE378@gmail.com> Message-ID: <1D9DF5EB-89CA-4DDF-9B5A-4DA0B2851E23@oracle.com> On 21 maj 2013, at 18:33, Kelly O'Hair wrote: > http://jeremymanson.blogspot.com/2007/05/profiling-with-jvmtijvmpi-sigprof-and.html > http://stackoverflow.com/questions/3426537/how-to-properly-write-a-sigprof-handler-that-invokes-asyncgetcalltrace > http://hiroshiyamauchi.blogspot.com/2008/12/stabilizing-asyncgetcalltrace.html > > The AsyncGetCallTrace symbol is a public extern symbol, unfortunately. > So there may be third party shared libraries dependent on the extern, and optionally calling it. > Removing the symbol will prevent those libraries from linking into the VM, even if they don't call it. I'm willing to break this compatibility for the minimal JVM, given that it's never been supported or official in any way. /Staffan > > Just FYI... > > -kto > > On May 21, 2013, at 8:35 AM, JOSEPH PROVINO wrote: > >> >> On 5/21/2013 3:06 AM, David Holmes wrote: >>> Hi Staffan, >>> >>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>> >>>> On 21 maj 2013, at 04:34, David Holmes wrote: >>>> >>>>> >>>>> >>>>> Hi Joe, >>>>> >>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >>>>> >>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? >>>> >>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), >>> >>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). >>> >>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. >>>> >>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. >>> >>> I guess we need to try and run it to find out. >> >> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? >> >> joe >> >>> >>> Thanks, >>> David >>> >>>> /Staffan >>>> >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>> conditionalize the code so that >>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>> >>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>> >>>>>> * JDK-8013461 There is >>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>> >>>>>> >>>>>> Thanks. >>>>>> >>>>>> joe >>>>>> >>>>>> >>>> >> > From staffan.larsen at oracle.com Tue May 21 11:23:51 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 21 May 2013 20:23:51 +0200 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519B9432.50808@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> Message-ID: <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: > > On 5/21/2013 3:06 AM, David Holmes wrote: >> Hi Staffan, >> >> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>> >>> On 21 maj 2013, at 04:34, David Holmes wrote: >>> >>>> >>>> >>>> Hi Joe, >>>> >>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >>>> >>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? >>> >>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), >> >> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). >> >>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. >>> >>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. >> >> I guess we need to try and run it to find out. > > Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? No, I don't feel strongly either way, but a comment in the code would be nice. Thanks, /Staffan > > joe > >> >> Thanks, >> David >> >>> /Staffan >>> >>>> >>>> Thanks, >>>> David >>>> >>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>> The change is to include forte.cpp in the minimal jvm but to >>>>> conditionalize the code so that >>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>> >>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>> >>>>> * JDK-8013461 There is >>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>> >>>>> >>>>> Thanks. >>>>> >>>>> joe >>>>> >>>>> >>> > From joseph.provino at oracle.com Tue May 21 11:26:29 2013 From: joseph.provino at oracle.com (JOSEPH PROVINO) Date: Tue, 21 May 2013 14:26:29 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> Message-ID: <519BBC55.706@oracle.com> On 5/21/2013 2:23 PM, Staffan Larsen wrote: > On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: > >> On 5/21/2013 3:06 AM, David Holmes wrote: >>> Hi Staffan, >>> >>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>> On 21 maj 2013, at 04:34, David Holmes wrote: >>>> >>>>> >>>>> >>>>> Hi Joe, >>>>> >>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >>>>> >>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? >>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), >>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). >>> >>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. >>>> >>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, Does anyone know where to find instructions on how to run the collector which would get the error return value? >>>> and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. >>> I guess we need to try and run it to find out. >> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? > No, I don't feel strongly either way, but a comment in the code would be nice. How much effort should I put into finding out what Sun Studio profiler does when it gets -1? joe > > Thanks, > /Staffan > > >> joe >> >>> Thanks, >>> David >>> >>>> /Staffan >>>> >>>>> Thanks, >>>>> David >>>>> >>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>> conditionalize the code so that >>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>> >>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>> >>>>>> * JDK-8013461 There is >>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>> >>>>>> >>>>>> Thanks. >>>>>> >>>>>> joe >>>>>> >>>>>> From serguei.spitsyn at oracle.com Tue May 21 12:08:21 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 21 May 2013 12:08:21 -0700 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> Message-ID: <519BC625.3050801@oracle.com> On 5/21/13 11:23 AM, Staffan Larsen wrote: > On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: > >> On 5/21/2013 3:06 AM, David Holmes wrote: >>> Hi Staffan, >>> >>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>> On 21 maj 2013, at 04:34, David Holmes wrote: >>>> >>>>> >>>>> >>>>> Hi Joe, >>>>> >>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >>>>> >>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? >>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), >>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). >>> >>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. >>>> >>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. >>> I guess we need to try and run it to find out. >> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? > No, I don't feel strongly either way, but a comment in the code would be nice. I do not have a strong preference too, but returning an error looks acceptable to me. Thanks, Serguei > > Thanks, > /Staffan > > >> joe >> >>> Thanks, >>> David >>> >>>> /Staffan >>>> >>>>> Thanks, >>>>> David >>>>> >>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>> conditionalize the code so that >>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>> >>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>> >>>>>> * JDK-8013461 There is >>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>> >>>>>> >>>>>> Thanks. >>>>>> >>>>>> joe >>>>>> >>>>>> From serguei.spitsyn at oracle.com Tue May 21 12:16:09 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 21 May 2013 12:16:09 -0700 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519BBC55.706@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> Message-ID: <519BC7F9.4080904@oracle.com> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: > > On 5/21/2013 2:23 PM, Staffan Larsen wrote: >> On 21 maj 2013, at 17:35, JOSEPH PROVINO >> wrote: >> >>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>> Hi Staffan, >>>> >>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>> On 21 maj 2013, at 04:34, David Holmes >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> Hi Joe, >>>>>> >>>>>> As I have previously stated you copied the struct definitions >>>>>> instead of moving them outside the ifdef. >>>>>> >>>>>> Serviceability folk: we are particularly interested in whether >>>>>> the use of ticks_no_class_load is deemed appropriate in this >>>>>> situation. Who will be consuming this value? >>>>> Since you have opted for the simple fix of having an exported but >>>>> non-functional AsyncGetCallTrace instead of actually removing the >>>>> symbol from the symbol files (which is the proposed solution in >>>>> the bug report), >>>> That would be a simpler solution semantically but the only way I >>>> can see to do that is to use a text replacement mechanism in the >>>> build files - as is done for the dynamic vtable symbols. I find >>>> that less appealing than simply exporting an interface that is >>>> configured to report an error (which is essentially what all the >>>> optional interfaces do under the minimal VM). >>>> >>>>> I would like you to include a comment about this in the source. >>>>> Right now it's very unclear why there is an exported function that >>>>> only returns an error. >>>>> >>>>> As to the appropriate return value, I don't know. The only caller >>>>> should be the Sun Studio profiler, > Does anyone know where to find instructions on how to run the > collector which would get the error return value? >>>>> and I'm not sure how it will handle this case if ever run. The >>>>> possible return values aren't very well documented. >>>> I guess we need to try and run it to find out. >>> Okay, do either of you feel strongly about how this should be fixed >>> -- return an error or remove the symbol? >> No, I don't feel strongly either way, but a comment in the code would >> be nice. > How much effort should I put into finding out what Sun Studio profiler > does when it gets -1? Let's ask the Solaris Studio guys directly. I'm adding Oleg to the mailing list. Oleg, Could you, please, share your view on this problem? Thanks, Serguei > > joe > >> >> Thanks, >> /Staffan >> >> >>> joe >>> >>>> Thanks, >>>> David >>>> >>>>> /Staffan >>>>> >>>>>> Thanks, >>>>>> David >>>>>> >>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>> conditionalize the code so that >>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>> >>>>>>> Webrev is here: >>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>> >>>>>>> * JDK-8013461 >>>>>>> There is >>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not >>>>>>> exist in >>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>> >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> joe >>>>>>> >>>>>>> > From joseph.provino at oracle.com Tue May 21 12:19:04 2013 From: joseph.provino at oracle.com (JOSEPH PROVINO) Date: Tue, 21 May 2013 15:19:04 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519BC7F9.4080904@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> Message-ID: <519BC8A8.5060909@oracle.com> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: > On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >> >> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>> On 21 maj 2013, at 17:35, JOSEPH PROVINO >>> wrote: >>> >>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>> Hi Staffan, >>>>> >>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>> On 21 maj 2013, at 04:34, David Holmes >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> Hi Joe, >>>>>>> >>>>>>> As I have previously stated you copied the struct definitions >>>>>>> instead of moving them outside the ifdef. >>>>>>> >>>>>>> Serviceability folk: we are particularly interested in whether >>>>>>> the use of ticks_no_class_load is deemed appropriate in this >>>>>>> situation. Who will be consuming this value? >>>>>> Since you have opted for the simple fix of having an exported but >>>>>> non-functional AsyncGetCallTrace instead of actually removing the >>>>>> symbol from the symbol files (which is the proposed solution in >>>>>> the bug report), >>>>> That would be a simpler solution semantically but the only way I >>>>> can see to do that is to use a text replacement mechanism in the >>>>> build files - as is done for the dynamic vtable symbols. I find >>>>> that less appealing than simply exporting an interface that is >>>>> configured to report an error (which is essentially what all the >>>>> optional interfaces do under the minimal VM). >>>>> >>>>>> I would like you to include a comment about this in the source. >>>>>> Right now it's very unclear why there is an exported function >>>>>> that only returns an error. >>>>>> >>>>>> As to the appropriate return value, I don't know. The only caller >>>>>> should be the Sun Studio profiler, >> Does anyone know where to find instructions on how to run the >> collector which would get the error return value? >>>>>> and I'm not sure how it will handle this case if ever run. The >>>>>> possible return values aren't very well documented. >>>>> I guess we need to try and run it to find out. >>>> Okay, do either of you feel strongly about how this should be fixed >>>> -- return an error or remove the symbol? >>> No, I don't feel strongly either way, but a comment in the code >>> would be nice. >> How much effort should I put into finding out what Sun Studio >> profiler does when it gets -1? > > Let's ask the Solaris Studio guys directly. > I'm adding Oleg to the mailing list. > > Oleg, > > Could you, please, share your view on this problem? In particular what will the Sun Studio Profiler collector do if it gets the error trace->num_frames = ticks_no_class_load; // -1 Thanks. joe > > > Thanks, > Serguei > > > > >> >> joe >> >>> >>> Thanks, >>> /Staffan >>> >>> >>>> joe >>>> >>>>> Thanks, >>>>> David >>>>> >>>>>> /Staffan >>>>>> >>>>>>> Thanks, >>>>>>> David >>>>>>> >>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>> conditionalize the code so that >>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>> >>>>>>>> Webrev is here: >>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>> >>>>>>>> * JDK-8013461 >>>>>>>> There is >>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not >>>>>>>> exist in >>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>> >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> joe >>>>>>>> >>>>>>>> >> > From kellyohair at gmail.com Tue May 21 12:27:25 2013 From: kellyohair at gmail.com (Kelly O'Hair) Date: Tue, 21 May 2013 12:27:25 -0700 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519BC8A8.5060909@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> Message-ID: On May 21, 2013, at 12:19 PM, JOSEPH PROVINO wrote: >> >> Let's ask the Solaris Studio guys directly. >> I'm adding Oleg to the mailing list. >> >> Oleg, >> >> Could you, please, share your view on this problem? > > In particular what will the Sun Studio Profiler collector do if it gets the error > > trace->num_frames = ticks_no_class_load; // -1 > > Thanks. > > joe I am pretty sure you want to keep the symbol in the library and have it return an error code, rather than remove the symbol entirely. Most tools will not necessarily know what kind of jdk/jre is being used, and getting a runtime linker error means the tool can't get off the ground, unless the tool library is doing a dlsym() to see if the symbol exists or not first, and I kind of doubt they would do that in all cases, but maybe. Kind of depends on what JDK implementations that they might expect their tool to run on. Hard to tell. The tools will have many different features, and maybe the need for this symbol is only part of one feature, and the other features might work fine in a minimal environment. Granted, I'm speaking with very limited knowledge if this detailed discussion, but removing symbols from shared libraries can be a very disruptive thing to tool vendors. Just a warning. -kto -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130521/82863069/attachment.html From oleg.mazurov at oracle.com Tue May 21 13:00:16 2013 From: oleg.mazurov at oracle.com (Oleg Mazurov) Date: Tue, 21 May 2013 13:00:16 -0700 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519BC8A8.5060909@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> Message-ID: <519BD250.10302@oracle.com> Though formally not part of the Solaris Studio team any more here is my opinion based on my recollection of how I implemented interaction with the JVM via AsyncGetCallTrace. It's looked up using dlsym. If the symbol is not there Java callstack collection is shut down. I understand in your case even JVMTI is not there so the dlsym call will not be made. From that perspective there is no difference whether the symbol is present and returns an error code or not present at all. -- Oleg On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: > > On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>> >>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO >>>> wrote: >>>> >>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>> Hi Staffan, >>>>>> >>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>> On 21 maj 2013, at 04:34, David Holmes >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Hi Joe, >>>>>>>> >>>>>>>> As I have previously stated you copied the struct definitions >>>>>>>> instead of moving them outside the ifdef. >>>>>>>> >>>>>>>> Serviceability folk: we are particularly interested in whether >>>>>>>> the use of ticks_no_class_load is deemed appropriate in this >>>>>>>> situation. Who will be consuming this value? >>>>>>> Since you have opted for the simple fix of having an exported >>>>>>> but non-functional AsyncGetCallTrace instead of actually >>>>>>> removing the symbol from the symbol files (which is the proposed >>>>>>> solution in the bug report), >>>>>> That would be a simpler solution semantically but the only way I >>>>>> can see to do that is to use a text replacement mechanism in the >>>>>> build files - as is done for the dynamic vtable symbols. I find >>>>>> that less appealing than simply exporting an interface that is >>>>>> configured to report an error (which is essentially what all the >>>>>> optional interfaces do under the minimal VM). >>>>>> >>>>>>> I would like you to include a comment about this in the source. >>>>>>> Right now it's very unclear why there is an exported function >>>>>>> that only returns an error. >>>>>>> >>>>>>> As to the appropriate return value, I don't know. The only >>>>>>> caller should be the Sun Studio profiler, >>> Does anyone know where to find instructions on how to run the >>> collector which would get the error return value? >>>>>>> and I'm not sure how it will handle this case if ever run. The >>>>>>> possible return values aren't very well documented. >>>>>> I guess we need to try and run it to find out. >>>>> Okay, do either of you feel strongly about how this should be >>>>> fixed -- return an error or remove the symbol? >>>> No, I don't feel strongly either way, but a comment in the code >>>> would be nice. >>> How much effort should I put into finding out what Sun Studio >>> profiler does when it gets -1? >> >> Let's ask the Solaris Studio guys directly. >> I'm adding Oleg to the mailing list. >> >> Oleg, >> >> Could you, please, share your view on this problem? > > In particular what will the Sun Studio Profiler collector do if it > gets the error > > trace->num_frames = ticks_no_class_load; // -1 > > Thanks. > > joe > >> >> >> Thanks, >> Serguei >> >> >> >> >>> >>> joe >>> >>>> >>>> Thanks, >>>> /Staffan >>>> >>>> >>>>> joe >>>>> >>>>>> Thanks, >>>>>> David >>>>>> >>>>>>> /Staffan >>>>>>> >>>>>>>> Thanks, >>>>>>>> David >>>>>>>> >>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>> conditionalize the code so that >>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>> >>>>>>>>> Webrev is here: >>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>> >>>>>>>>> * JDK-8013461 >>>>>>>>> There is >>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not >>>>>>>>> exist in >>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> joe >>>>>>>>> >>>>>>>>> >>> >> > From joseph.provino at oracle.com Tue May 21 13:52:21 2013 From: joseph.provino at oracle.com (JOSEPH PROVINO) Date: Tue, 21 May 2013 16:52:21 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519BD250.10302@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com> Message-ID: <519BDE85.6000005@oracle.com> On 5/21/2013 4:00 PM, Oleg Mazurov wrote: > Though formally not part of the Solaris Studio team any more here is > my opinion based on my recollection of how I implemented interaction > with the JVM via AsyncGetCallTrace. > It's looked up using dlsym. If the symbol is not there Java callstack > collection is shut down. I understand in your case even JVMTI is not > there so the dlsym call will not be made. > From that perspective there is no difference whether the symbol is > present and returns an error code or not present at all. Oleg, then it sounds like what we have will work. Thanks for the quick reply. joe > > -- Oleg > > On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: >> >> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>>> >>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO >>>>> wrote: >>>>> >>>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>>> Hi Staffan, >>>>>>> >>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>>> On 21 maj 2013, at 04:34, David Holmes >>>>>>>> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Hi Joe, >>>>>>>>> >>>>>>>>> As I have previously stated you copied the struct definitions >>>>>>>>> instead of moving them outside the ifdef. >>>>>>>>> >>>>>>>>> Serviceability folk: we are particularly interested in whether >>>>>>>>> the use of ticks_no_class_load is deemed appropriate in this >>>>>>>>> situation. Who will be consuming this value? >>>>>>>> Since you have opted for the simple fix of having an exported >>>>>>>> but non-functional AsyncGetCallTrace instead of actually >>>>>>>> removing the symbol from the symbol files (which is the >>>>>>>> proposed solution in the bug report), >>>>>>> That would be a simpler solution semantically but the only way I >>>>>>> can see to do that is to use a text replacement mechanism in the >>>>>>> build files - as is done for the dynamic vtable symbols. I find >>>>>>> that less appealing than simply exporting an interface that is >>>>>>> configured to report an error (which is essentially what all the >>>>>>> optional interfaces do under the minimal VM). >>>>>>> >>>>>>>> I would like you to include a comment about this in the source. >>>>>>>> Right now it's very unclear why there is an exported function >>>>>>>> that only returns an error. >>>>>>>> >>>>>>>> As to the appropriate return value, I don't know. The only >>>>>>>> caller should be the Sun Studio profiler, >>>> Does anyone know where to find instructions on how to run the >>>> collector which would get the error return value? >>>>>>>> and I'm not sure how it will handle this case if ever run. >>>>>>>> The possible return values aren't very well documented. >>>>>>> I guess we need to try and run it to find out. >>>>>> Okay, do either of you feel strongly about how this should be >>>>>> fixed -- return an error or remove the symbol? >>>>> No, I don't feel strongly either way, but a comment in the code >>>>> would be nice. >>>> How much effort should I put into finding out what Sun Studio >>>> profiler does when it gets -1? >>> >>> Let's ask the Solaris Studio guys directly. >>> I'm adding Oleg to the mailing list. >>> >>> Oleg, >>> >>> Could you, please, share your view on this problem? >> >> In particular what will the Sun Studio Profiler collector do if it >> gets the error >> >> trace->num_frames = ticks_no_class_load; // -1 >> >> Thanks. >> >> joe >> >>> >>> >>> Thanks, >>> Serguei >>> >>> >>> >>> >>>> >>>> joe >>>> >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> >>>>>> joe >>>>>> >>>>>>> Thanks, >>>>>>> David >>>>>>> >>>>>>>> /Staffan >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> David >>>>>>>>> >>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>>> conditionalize the code so that >>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>>> >>>>>>>>>> Webrev is here: >>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>>> >>>>>>>>>> * JDK-8013461 >>>>>>>>>> There is >>>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does >>>>>>>>>> not exist in >>>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> joe >>>>>>>>>> >>>>>>>>>> >>>> >>> >> > From bharadwaj.yadavalli at oracle.com Tue May 21 19:42:03 2013 From: bharadwaj.yadavalli at oracle.com (bharadwaj.yadavalli at oracle.com) Date: Wed, 22 May 2013 02:42:03 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014059: JSR292: Failed to reject invalid class cplmhl00201m28n Message-ID: <20130522024208.74A4848C23@hg.openjdk.java.net> Changeset: ccdecfece956 Author: bharadwaj Date: 2013-05-21 16:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ccdecfece956 8014059: JSR292: Failed to reject invalid class cplmhl00201m28n Summary: Restrict reference of interface methods by invokestatic and invokespecial to classfile version 52 or later. Reviewed-by: kvn, hseigel ! src/share/vm/classfile/classFileParser.cpp From david.holmes at oracle.com Tue May 21 21:35:40 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 22 May 2013 14:35:40 +1000 Subject: Need help with change In-Reply-To: <519B7D28.7000505@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> Message-ID: <519C4B1C.40702@oracle.com> On 21/05/2013 11:56 PM, Coleen Phillimore wrote: > > On 05/21/2013 09:29 AM, Staffan Larsen wrote: >> When doing heap iteration with JVMTI, the spec requires callbacks from >> the VM to the agent identifying the signers and protection domain >> references. This is what tagMap does, see jvmtiTagMap.cpp:2464. >> >> As long as it it still possible for JVMTI to find these references >> (with ik->protection_domain() and ik->signers()), I think it's ok. > > Okay. Thanks for the quick answer. I was going to rip this out (rats, > now I can't). I can get to both protection domain and signers through > the mirror. > > We are working on moving the signers completely to the jdk and not > having the jvm know about them at all. Then we can't find the signers > through this interface. Should we file a CCC request to change the > JVMTI spec then? You can access any Java object field from the JVM - you just need to add it to java_classes.cpp :) I don't think you can just rip this out of the JVMTI spec. David ----- > > Thanks, > Coleen > >> >> /Staffan >> >> >> On 21 maj 2013, at 14:52, Coleen Phillimore >> wrote: >> >>> I found during code review comment editing for my change that removes >>> signers and protection domain from the InstanceKlass, that JVMTI code >>> seems to have some sort of call back and knowledge of these fields in >>> instanceKlass. >>> >>> >>> >>> Reference from a class to its signers array. >>> >>> >>> Reference from a class to its protection domain. >>> >>> >>> If I remove these, will it cause incompatibilities? It's used >>> during jvmtiTagMap.cpp (whatever that's doing). >>> >>> Thanks, >>> Coleen > From david.holmes at oracle.com Tue May 21 21:51:07 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 22 May 2013 14:51:07 +1000 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> Message-ID: <519C4EBB.5070306@oracle.com> Hi Kelly, On 22/05/2013 5:27 AM, Kelly O'Hair wrote: > I am pretty sure you want to keep the symbol in the library and have it > return an error code, rather than remove the symbol entirely. > Most tools will not necessarily know what kind of jdk/jre is being used, > and getting a runtime linker > error means the tool can't get off the ground, unless the tool library > is doing a dlsym() to see if the > symbol exists or not first, and I kind of doubt they would do that in > all cases, but maybe. Kind of > depends on what JDK implementations that they might expect their tool to > run on. Hard to tell. > > The tools will have many different features, and maybe the need for this > symbol is only part of one > feature, and the other features might work fine in a minimal environment. > > Granted, I'm speaking with very limited knowledge if this detailed > discussion, but removing symbols > from shared libraries can be a very disruptive thing to tool vendors. > Just a warning. FYI the minimalVM doesn't provide any optional VM interfaces. This means that most of the JVM/TI functions are not even present in the binaries (just those needed to ask the question "do you have JVM/TI"). So we're already well done the path of removing symbols. David ----- > -kto From david.holmes at oracle.com Tue May 21 22:25:40 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 22 May 2013 05:25:40 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130522052546.AA0CD48C26@hg.openjdk.java.net> Changeset: f54c85acc043 Author: mikael Date: 2013-05-21 09:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f54c85acc043 8013726: runtime/memory/ReserveMemory.java fails due to 'assert(bytes % os::vm_allocation_granularity() == 0) failed: reserve block size' Summary: Fix regression test to work on all platforms Reviewed-by: ctornqvi, dholmes ! src/share/vm/prims/whitebox.cpp ! test/runtime/memory/ReserveMemory.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 1a07e086ff28 Author: dholmes Date: 2013-05-21 19:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1a07e086ff28 Merge From staffan.larsen at oracle.com Wed May 22 00:04:18 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 22 May 2013 09:04:18 +0200 Subject: Need help with change In-Reply-To: <519C4B1C.40702@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> <519C4B1C.40702@oracle.com> Message-ID: <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> On 22 maj 2013, at 06:35, David Holmes wrote: > On 21/05/2013 11:56 PM, Coleen Phillimore wrote: >> >> On 05/21/2013 09:29 AM, Staffan Larsen wrote: >>> When doing heap iteration with JVMTI, the spec requires callbacks from >>> the VM to the agent identifying the signers and protection domain >>> references. This is what tagMap does, see jvmtiTagMap.cpp:2464. >>> >>> As long as it it still possible for JVMTI to find these references >>> (with ik->protection_domain() and ik->signers()), I think it's ok. >> >> Okay. Thanks for the quick answer. I was going to rip this out (rats, >> now I can't). I can get to both protection domain and signers through >> the mirror. >> >> We are working on moving the signers completely to the jdk and not >> having the jvm know about them at all. Then we can't find the signers >> through this interface. Should we file a CCC request to change the >> JVMTI spec then? > > You can access any Java object field from the JVM - you just need to add it to java_classes.cpp :) I don't think you can just rip this out of the JVMTI spec. I agree with David here - changing the JVMTI spec is not the solution. /Staffan > > David > ----- > >> >> Thanks, >> Coleen >> >>> >>> /Staffan >>> >>> >>> On 21 maj 2013, at 14:52, Coleen Phillimore >>> wrote: >>> >>>> I found during code review comment editing for my change that removes >>>> signers and protection domain from the InstanceKlass, that JVMTI code >>>> seems to have some sort of call back and knowledge of these fields in >>>> instanceKlass. >>>> >>>> >>>> >>>> Reference from a class to its signers array. >>>> >>>> >>>> Reference from a class to its protection domain. >>>> >>>> >>>> If I remove these, will it cause incompatibilities? It's used >>>> during jvmtiTagMap.cpp (whatever that's doing). >>>> >>>> Thanks, >>>> Coleen >> From coleen.phillimore at oracle.com Wed May 22 04:18:36 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Wed, 22 May 2013 07:18:36 -0400 Subject: Need help with change In-Reply-To: <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> <519C4B1C.40702@oracle.com> <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> Message-ID: <519CA98C.4020303@oracle.com> On 5/22/2013 3:04 AM, Staffan Larsen wrote: > On 22 maj 2013, at 06:35, David Holmes wrote: > >> On 21/05/2013 11:56 PM, Coleen Phillimore wrote: >>> On 05/21/2013 09:29 AM, Staffan Larsen wrote: >>>> When doing heap iteration with JVMTI, the spec requires callbacks from >>>> the VM to the agent identifying the signers and protection domain >>>> references. This is what tagMap does, see jvmtiTagMap.cpp:2464. >>>> >>>> As long as it it still possible for JVMTI to find these references >>>> (with ik->protection_domain() and ik->signers()), I think it's ok. >>> Okay. Thanks for the quick answer. I was going to rip this out (rats, >>> now I can't). I can get to both protection domain and signers through >>> the mirror. >>> >>> We are working on moving the signers completely to the jdk and not >>> having the jvm know about them at all. Then we can't find the signers >>> through this interface. Should we file a CCC request to change the >>> JVMTI spec then? >> You can access any Java object field from the JVM - you just need to add it to java_classes.cpp :) I don't think you can just rip this out of the JVMTI spec. > I agree with David here - changing the JVMTI spec is not the solution. But there won't be a field in the mirror or anywhere for signers. We can get the value from protection_domain.getCertificates() from the jdk but the jvm doesn't currently do the upcall to java. Why does the jvmti spec dictate implementation? Coleen > > /Staffan > > >> David >> ----- >> >>> Thanks, >>> Coleen >>> >>>> /Staffan >>>> >>>> >>>> On 21 maj 2013, at 14:52, Coleen Phillimore >>>> wrote: >>>> >>>>> I found during code review comment editing for my change that removes >>>>> signers and protection domain from the InstanceKlass, that JVMTI code >>>>> seems to have some sort of call back and knowledge of these fields in >>>>> instanceKlass. >>>>> >>>>> >>>>> >>>>> Reference from a class to its signers array. >>>>> >>>>> >>>>> Reference from a class to its protection domain. >>>>> >>>>> >>>>> If I remove these, will it cause incompatibilities? It's used >>>>> during jvmtiTagMap.cpp (whatever that's doing). >>>>> >>>>> Thanks, >>>>> Coleen From david.holmes at oracle.com Wed May 22 04:34:54 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 22 May 2013 21:34:54 +1000 Subject: Need help with change In-Reply-To: <519CA98C.4020303@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> <519C4B1C.40702@oracle.com> <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> <519CA98C.4020303@oracle.com> Message-ID: <519CAD5E.4070409@oracle.com> On 22/05/2013 9:18 PM, Coleen Phillimore wrote: > On 5/22/2013 3:04 AM, Staffan Larsen wrote: >> On 22 maj 2013, at 06:35, David Holmes wrote: >> >>> On 21/05/2013 11:56 PM, Coleen Phillimore wrote: >>>> On 05/21/2013 09:29 AM, Staffan Larsen wrote: >>>>> When doing heap iteration with JVMTI, the spec requires callbacks from >>>>> the VM to the agent identifying the signers and protection domain >>>>> references. This is what tagMap does, see jvmtiTagMap.cpp:2464. >>>>> >>>>> As long as it it still possible for JVMTI to find these references >>>>> (with ik->protection_domain() and ik->signers()), I think it's ok. >>>> Okay. Thanks for the quick answer. I was going to rip this out >>>> (rats, >>>> now I can't). I can get to both protection domain and signers through >>>> the mirror. >>>> >>>> We are working on moving the signers completely to the jdk and not >>>> having the jvm know about them at all. Then we can't find the signers >>>> through this interface. Should we file a CCC request to change the >>>> JVMTI spec then? >>> You can access any Java object field from the JVM - you just need to >>> add it to java_classes.cpp :) I don't think you can just rip this out >>> of the JVMTI spec. >> I agree with David here - changing the JVMTI spec is not the solution. > > But there won't be a field in the mirror or anywhere for signers. We can > get the value from protection_domain.getCertificates() from the jdk but > the jvm doesn't currently do the upcall to java. Why does the jvmti > spec dictate implementation? I don't understand. AFAICS the JVMTI spec just says you have to be able to get to these things from the Class object. So if the fields are in Class then we just need to access them - no need for an upcall. David ----- > Coleen > >> >> /Staffan >> >> >>> David >>> ----- >>> >>>> Thanks, >>>> Coleen >>>> >>>>> /Staffan >>>>> >>>>> >>>>> On 21 maj 2013, at 14:52, Coleen Phillimore >>>>> wrote: >>>>> >>>>>> I found during code review comment editing for my change that removes >>>>>> signers and protection domain from the InstanceKlass, that JVMTI code >>>>>> seems to have some sort of call back and knowledge of these fields in >>>>>> instanceKlass. >>>>>> >>>>>> >>>>>> >>>>>> Reference from a class to its signers array. >>>>>> >>>>>> >>>>>> Reference from a class to its protection domain. >>>>>> >>>>>> >>>>>> If I remove these, will it cause incompatibilities? It's used >>>>>> during jvmtiTagMap.cpp (whatever that's doing). >>>>>> >>>>>> Thanks, >>>>>> Coleen > From staffan.larsen at oracle.com Wed May 22 04:35:24 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 22 May 2013 13:35:24 +0200 Subject: Need help with change In-Reply-To: <519CA98C.4020303@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> <519C4B1C.40702@oracle.com> <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> <519CA98C.4020303@oracle.com> Message-ID: <5F87BD97-D3F4-4B47-ADE7-D0C10821385F@oracle.com> On 22 maj 2013, at 13:18, Coleen Phillimore wrote: > On 5/22/2013 3:04 AM, Staffan Larsen wrote: >> On 22 maj 2013, at 06:35, David Holmes wrote: >> >>> On 21/05/2013 11:56 PM, Coleen Phillimore wrote: >>>> On 05/21/2013 09:29 AM, Staffan Larsen wrote: >>>>> When doing heap iteration with JVMTI, the spec requires callbacks from >>>>> the VM to the agent identifying the signers and protection domain >>>>> references. This is what tagMap does, see jvmtiTagMap.cpp:2464. >>>>> >>>>> As long as it it still possible for JVMTI to find these references >>>>> (with ik->protection_domain() and ik->signers()), I think it's ok. >>>> Okay. Thanks for the quick answer. I was going to rip this out (rats, >>>> now I can't). I can get to both protection domain and signers through >>>> the mirror. >>>> >>>> We are working on moving the signers completely to the jdk and not >>>> having the jvm know about them at all. Then we can't find the signers >>>> through this interface. Should we file a CCC request to change the >>>> JVMTI spec then? >>> You can access any Java object field from the JVM - you just need to add it to java_classes.cpp :) I don't think you can just rip this out of the JVMTI spec. >> I agree with David here - changing the JVMTI spec is not the solution. > > But there won't be a field in the mirror or anywhere for signers. We can get the value from protection_domain.getCertificates() from the jdk but the jvm doesn't currently do the upcall to java. Why does the jvmti spec dictate implementation? I don't know the reasons for the JVMTI design here, but from a Java perspective there is a method Class.getSigners() and it is this relationship that JVMTI tries to capture. If this hasn't historically been a field in Class, then to only way to get this from JVMTI would have been something like the current design. So the JVMTI spec may have worked around a previous implementation limitation, and now we are stuck there. /Staffan From coleen.phillimore at oracle.com Wed May 22 04:47:34 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Wed, 22 May 2013 07:47:34 -0400 Subject: Need help with change In-Reply-To: <519CAD5E.4070409@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> <519C4B1C.40702@oracle.com> <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> <519CA98C.4020303@oracle.com> <519CAD5E.4070409@oracle.com> Message-ID: <519CB056.4000806@oracle.com> On 5/22/2013 7:34 AM, David Holmes wrote: > I don't understand. AFAICS the JVMTI spec just says you have to be > able to get to these things from the Class object. So if the fields > are in Class then we just need to access them - no need for an upcall. We're moving the signers field out of Class also, with another change. It is unnecessary and wastes space. The java code in the jdk can just call pd.getCertificates() instead and we can remove all knowledge of signers in the jvm. Or we can implement the jvmti version of getSigners in the jvm to make a Java upcall. Or we could add the layout of protection domain to javaClasses and see if certificates is a field and get that. Or something to avoid the upcall. This could be tricky. I wish we could change the jvmti spec or not support callbacks for the signers object. It's really odd. I don't know what this is for. Coleen From staffan.larsen at oracle.com Wed May 22 05:32:27 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 22 May 2013 14:32:27 +0200 Subject: Need help with change In-Reply-To: <519CB056.4000806@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> <519C4B1C.40702@oracle.com> <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> <519CA98C.4020303@oracle.com> <519CAD5E.4070409@oracle.com> <519CB056.4000806@oracle.com> Message-ID: On 22 maj 2013, at 13:47, Coleen Phillimore wrote: > On 5/22/2013 7:34 AM, David Holmes wrote: >> I don't understand. AFAICS the JVMTI spec just says you have to be able to get to these things from the Class object. So if the fields are in Class then we just need to access them - no need for an upcall. > > We're moving the signers field out of Class also, with another change. It is unnecessary and wastes space. The java code in the jdk can just call pd.getCertificates() instead and we can remove all knowledge of signers in the jvm. Then, the JVMTI code in the JVM will have to call pd.getCertificatesI() as well. > Or we can implement the jvmti version of getSigners in the jvm to make a Java upcall. Or we could add the layout of protection domain to javaClasses and see if certificates is a field and get that. Or something to avoid the upcall. This could be tricky. I wish we could change the jvmti spec or not support callbacks for the signers object. It's really odd. I don't know what this is for. Perhaps Robert Field can remember the history? Thanks, /Staffan From david.holmes at oracle.com Wed May 22 05:52:53 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 22 May 2013 22:52:53 +1000 Subject: Need help with change In-Reply-To: <519CB056.4000806@oracle.com> References: <519B6E0B.1030402@oracle.com> <519B7D28.7000505@oracle.com> <519C4B1C.40702@oracle.com> <0B8D0E44-D830-4555-B512-35277E28A0AB@oracle.com> <519CA98C.4020303@oracle.com> <519CAD5E.4070409@oracle.com> <519CB056.4000806@oracle.com> Message-ID: <519CBFA5.3000002@oracle.com> On 22/05/2013 9:47 PM, Coleen Phillimore wrote: > On 5/22/2013 7:34 AM, David Holmes wrote: >> I don't understand. AFAICS the JVMTI spec just says you have to be >> able to get to these things from the Class object. So if the fields >> are in Class then we just need to access them - no need for an upcall. > > We're moving the signers field out of Class also, with another change. > It is unnecessary and wastes space. The java code in the jdk can just > call pd.getCertificates() instead and we can remove all knowledge of > signers in the jvm. So what happens to Class.getSigners() ? > Or we can implement the jvmti version of getSigners in the jvm to make a > Java upcall. Or we could add the layout of protection domain to > javaClasses and see if certificates is a field and get that. Or > something to avoid the upcall. This could be tricky. I wish we could > change the jvmti spec or not support callbacks for the signers object. > It's really odd. I don't know what this is for. AFAIK JVMTI is just exposing what would be available at the Java level. If we are redefining the notion of "signers" then it may well be appropriate to update the JVM/TI spec to reflect that change. David ----- > Coleen From chris.hegarty at oracle.com Wed May 22 05:52:14 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 22 May 2013 12:52:14 +0000 Subject: hg: jdk8/tl/jdk: 8010182: Thread safety of Thread get/setName() Message-ID: <20130522125238.761DE48C39@hg.openjdk.java.net> Changeset: 48e8a6e0c805 Author: chegar Date: 2013-05-22 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48e8a6e0c805 8010182: Thread safety of Thread get/setName() Reviewed-by: dholmes, alanb, mduigou ! src/share/classes/java/lang/Thread.java From mike.duigou at oracle.com Wed May 22 10:01:19 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 22 May 2013 17:01:19 +0000 Subject: hg: jdk8/tl/jdk: 8014819: set max size for jtreg testvms Message-ID: <20130522170130.DB0FB48C45@hg.openjdk.java.net> Changeset: 4b555b53dc57 Author: mduigou Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b555b53dc57 8014819: set max size for jtreg testvms Reviewed-by: alanb, darcy ! test/Makefile From lana.steuck at oracle.com Wed May 22 12:10:35 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:35 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130522191041.2549C48C48@hg.openjdk.java.net> Changeset: c8286839d0df Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c8286839d0df Added tag jdk8-b89 for changeset fe4150590ee5 ! .hgtags Changeset: 8f7ffb296385 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8f7ffb296385 Added tag jdk8-b90 for changeset c8286839d0df ! .hgtags From lana.steuck at oracle.com Wed May 22 12:10:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:46 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20130522191052.83F2548C4A@hg.openjdk.java.net> Changeset: 67ca019e3713 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/67ca019e3713 Added tag jdk8-b89 for changeset 45ce27fbe272 ! .hgtags Changeset: 4ce88eec5078 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4ce88eec5078 Added tag jdk8-b90 for changeset 67ca019e3713 ! .hgtags Changeset: 6b9f41203800 Author: lana Date: 2013-05-17 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6b9f41203800 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js Changeset: e955e64fd15d Author: lana Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e955e64fd15d Merge From lana.steuck at oracle.com Wed May 22 12:10:39 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:39 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20130522191052.0425148C49@hg.openjdk.java.net> Changeset: 3e5b9ea5ac35 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/3e5b9ea5ac35 Added tag jdk8-b89 for changeset 88838e08e4ef ! .hgtags Changeset: 0bb1a9fa56b0 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/0bb1a9fa56b0 Added tag jdk8-b90 for changeset 3e5b9ea5ac35 ! .hgtags From lana.steuck at oracle.com Wed May 22 12:10:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:36 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20130522191037.28CF948C47@hg.openjdk.java.net> Changeset: 69b773a221b9 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/69b773a221b9 Added tag jdk8-b89 for changeset 892a0196d10c ! .hgtags Changeset: 83b519cafa68 Author: katleman Date: 2013-05-16 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/83b519cafa68 Added tag jdk8-b90 for changeset 69b773a221b9 ! .hgtags Changeset: 40bba0507f76 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/40bba0507f76 Merge From lana.steuck at oracle.com Wed May 22 12:10:43 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:43 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20130522191101.4839A48C4B@hg.openjdk.java.net> Changeset: 668acc0e1034 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/668acc0e1034 Added tag jdk8-b89 for changeset 893d2ba8bbea ! .hgtags Changeset: f39d61028d2f Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f39d61028d2f Added tag jdk8-b90 for changeset 668acc0e1034 ! .hgtags Changeset: e3065fb07877 Author: lana Date: 2013-05-17 10:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e3065fb07877 Merge Changeset: 0765806dcc58 Author: lana Date: 2013-05-22 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0765806dcc58 Merge From lana.steuck at oracle.com Wed May 22 12:11:05 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:11:05 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20130522191126.05AF248C4C@hg.openjdk.java.net> Changeset: e19283cd30a4 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e19283cd30a4 Added tag jdk8-b89 for changeset ec434cfd2752 ! .hgtags Changeset: 9717b9523d46 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9717b9523d46 Added tag jdk8-b90 for changeset e19283cd30a4 ! .hgtags Changeset: 997c0fae2b12 Author: lana Date: 2013-05-17 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/997c0fae2b12 Merge - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java Changeset: 31344e8e3343 Author: lana Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31344e8e3343 Merge From lana.steuck at oracle.com Wed May 22 12:11:40 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:11:40 +0000 Subject: hg: jdk8/tl/hotspot: 86 new changesets Message-ID: <20130522191500.B5E4848C4D@hg.openjdk.java.net> Changeset: 7d56b68a9672 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7d56b68a9672 Added tag jdk8-b89 for changeset 9c1fe0b419b4 ! .hgtags Changeset: 625ddb0052e1 Author: amurillo Date: 2013-05-03 08:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/625ddb0052e1 8013800: new hotspot build - hs25-b32 Reviewed-by: jcoomes ! make/hotspot_version Changeset: c456f4510385 Author: sla Date: 2013-05-03 12:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c456f4510385 8008453: JvmtiClassFileReconstituter does not recognize default methods Reviewed-by: acorn, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 0380df7c3cd0 Author: sla Date: 2013-05-03 12:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0380df7c3cd0 8013785: Respect EXTRA_CFLAGS on windows Reviewed-by: mgronlun, rbackman, kvn ! make/windows/makefiles/compile.make ! make/windows/makefiles/defs.make Changeset: 31a4e55f8c9d Author: fparain Date: 2013-05-03 05:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/31a4e55f8c9d 8004095: Add support for JMX interface to Diagnostic Framework and Commands Reviewed-by: acorn, sla ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/serviceThread.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/nmtDCmd.cpp ! src/share/vm/services/nmtDCmd.hpp Changeset: 39fba0d6d9ad Author: fparain Date: 2013-05-03 05:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/39fba0d6d9ad Merge Changeset: bf089b838c9e Author: ccheung Date: 2013-05-02 16:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf089b838c9e 8012641: Perf_CreateLong creates perf counter of incorrect type Reviewed-by: mchung, hseigel, coleenp ! src/share/vm/prims/perf.cpp Changeset: a55b7b8c34af Author: zgu Date: 2013-05-03 13:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a55b7b8c34af Merge Changeset: 9c8e2f44228d Author: dcubed Date: 2013-05-03 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c8e2f44228d Merge Changeset: 800078be49d2 Author: hseigel Date: 2013-05-06 09:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/800078be49d2 8013648: Guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive Summary: Fix code to call correct version of function find_class(). Reviewed-by: coleenp, rdurbin, dcubed ! src/share/vm/classfile/systemDictionary.cpp Changeset: c18152e0554e Author: zgu Date: 2013-05-06 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c18152e0554e 8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check Summary: Fixed NMT to deal with releasing virtual memory region when there are still committed regions within it Reviewed-by: acorn, coleenp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/services/memSnapshot.cpp + test/runtime/NMT/ReleaseCommittedMemory.java Changeset: da4d87770781 Author: zgu Date: 2013-05-06 08:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da4d87770781 Merge Changeset: d9b08d62b95e Author: acorn Date: 2013-05-02 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d9b08d62b95e 8010783: assert(s->refcount() != 0) failed: for create_overpasses Reviewed-by: kvn, dcubed ! src/share/vm/classfile/bytecodeAssembler.cpp Changeset: b7f3bf2ba33b Author: acorn Date: 2013-05-06 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b7f3bf2ba33b Merge - agent/doc/c2replay.html Changeset: f916d5986c86 Author: acorn Date: 2013-05-06 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f916d5986c86 Merge Changeset: 187154b7a226 Author: sla Date: 2013-05-06 19:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/187154b7a226 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes Reviewed-by: coleenp, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: 3ecc6b9940de Author: sla Date: 2013-05-07 01:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3ecc6b9940de Merge Changeset: b5fef8013a95 Author: sla Date: 2013-05-07 14:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5fef8013a95 8014044: Spelling error in JDK-8009615: boostrapmethod Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: f6a055fcf47d Author: sla Date: 2013-05-07 14:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f6a055fcf47d 8005038: remove crufty '_g' support from SA Reviewed-by: coleenp, mgronlun, rbackman ! agent/src/os/bsd/ps_core.c ! agent/src/os/linux/ps_core.c ! agent/src/os/solaris/proc/saproc.cpp ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/LinuxVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java Changeset: 33bcd9ead1d5 Author: ctornqvi Date: 2013-05-07 21:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/33bcd9ead1d5 8009577: Test test/closed/runtime/classunload broken Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with where custom classloader got the classes from Reviewed-by: collins, mgerdin, zgu + test/runtime/ClassUnload/KeepAliveClass.java + test/runtime/ClassUnload/KeepAliveClassLoader.java + test/runtime/ClassUnload/KeepAliveObject.java + test/runtime/ClassUnload/KeepAliveSoftReference.java + test/runtime/ClassUnload/UnloadTest.java + test/runtime/ClassUnload/classes/test/Empty.java + test/runtime/testlibrary/ClassUnloadCommon.java Changeset: 58bb870a0cbd Author: emc Date: 2013-05-07 13:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/58bb870a0cbd 8009729: Refix hotspot jni_.h JNIEXPORT and JNIIMPORT definitions to match jdk version Summary: Update JNIEXPORT and JNIIMPORT to work with other compilers that don't necessarily have the __attribute__ type qualifier Reviewed-by: dholmes, dcubed, coleenp ! src/cpu/sparc/vm/jni_sparc.h ! src/cpu/x86/vm/jni_x86.h ! src/cpu/zero/vm/jni_zero.h Changeset: 7243490a6847 Author: coleenp Date: 2013-05-07 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7243490a6847 Merge Changeset: e60b3fce2b02 Author: jiangli Date: 2013-05-06 19:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e60b3fce2b02 8013067: Zero builds are broken after 8010862. Summary: Fixed broken Zero build. Reviewed-by: twisti, coleenp, kvn ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/method.hpp Changeset: 27d2d456cd96 Author: jiangli Date: 2013-05-06 20:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/27d2d456cd96 Merge Changeset: 6b388e7d4905 Author: bpittore Date: 2013-05-07 10:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6b388e7d4905 8013633: Cleanup platform ifdefs in unsafe.cpp Summary: Replace ifdefs with SUPPORTS_NATIVE_CX8 set in platform include file Reviewed-by: dholmes, dlong ! src/cpu/sparc/vm/globalDefinitions_sparc.hpp ! src/cpu/x86/vm/globalDefinitions_x86.hpp ! src/share/vm/prims/unsafe.cpp Changeset: a258a8351528 Author: vladidan Date: 2013-05-07 10:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a258a8351528 Merge - agent/doc/c2replay.html Changeset: d3c98423c146 Author: jiangli Date: 2013-05-09 16:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d3c98423c146 Merge Changeset: 1d0fba8a2a6d Author: brutisso Date: 2013-05-02 22:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1d0fba8a2a6d 8013574: PrintMalloc conflicts with the command line parsing Summary: Make sure that _num_jvm_args is not updated until the new entry to _jvm_args_array has been added Reviewed-by: johnc, tamao, tschatzl ! src/share/vm/runtime/arguments.cpp Changeset: f14063dcd52a Author: brutisso Date: 2013-05-06 09:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f14063dcd52a 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment Summary: Make sure max alignemnt is at least as large as min alignment Reviewed-by: johnc, jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp + test/gc/g1/TestRegionAlignment.java Changeset: 30860066ae8f Author: jwilhelm Date: 2013-05-06 13:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/30860066ae8f Merge ! src/share/vm/runtime/arguments.cpp Changeset: d17700c82d7d Author: tschatzl Date: 2013-05-06 17:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d17700c82d7d 8006088: Incompatible heap size flags accepted by VM Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing. Reviewed-by: johnc, jwilhelm, tamao ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: b0d20fa374b4 Author: brutisso Date: 2013-05-06 21:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b0d20fa374b4 8013872: G1: HeapRegionSeq::shrink_by() has invalid assert Summary: Refactored shrink_by() to only use region counts and not byte sizes Reviewed-by: johnc, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp + test/gc/g1/TestShrinkToOneRegion.java Changeset: a9d568b7df60 Author: jmasa Date: 2013-05-08 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a9d568b7df60 8013032: CMS: assert(used() == used_after_gc && used_after_gc <= capacity()) failed: used: 0 used_after_gc: 292080 capacity: 1431699456 Reviewed-by: tschatzl, mgerdin, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java Changeset: 06ab37f08701 Author: jmasa Date: 2013-05-08 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/06ab37f08701 8013184: CMS: Call reset_after_compaction() only if a compaction has been done Reviewed-by: mgerdin, johnc, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp + test/gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java Changeset: 923ac8d1df95 Author: jwilhelm Date: 2013-05-09 12:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/923ac8d1df95 Merge Changeset: 194f52aa2f23 Author: johnc Date: 2013-05-09 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/194f52aa2f23 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap Summary: Refactor G1's hot card cache and card counts table into their own files. Simplify the card counts table, including removing the encoding of the card index in each entry. The card counts table now has a 1:1 correspondence with the cards spanned by heap. Space for the card counts table is reserved from virtual memory (rather than C heap) during JVM startup and is committed/expanded when the heap is expanded. Changes were also reviewed-by Vitaly Davidovich. Reviewed-by: tschatzl, jmasa ! make/excludeSrc.make ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp + src/share/vm/gc_implementation/g1/g1CardCounts.cpp + src/share/vm/gc_implementation/g1/g1CardCounts.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp + src/share/vm/gc_implementation/g1/g1HotCardCache.cpp + src/share/vm/gc_implementation/g1/g1HotCardCache.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 73652d89e7c4 Author: stefank Date: 2013-05-10 09:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/73652d89e7c4 Merge Changeset: 69494caf5790 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/69494caf5790 Merge Changeset: 1ae0472ff3a0 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1ae0472ff3a0 Added tag hs25-b32 for changeset 69494caf5790 ! .hgtags Changeset: 1cdbd42c3e49 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1cdbd42c3e49 Added tag jdk8-b90 for changeset 1ae0472ff3a0 ! .hgtags Changeset: 6114c49b31b5 Author: amurillo Date: 2013-05-10 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6114c49b31b5 8014279: new hotspot build - hs25-b33 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 712a1e9c91f3 Author: coleenp Date: 2013-05-07 09:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/712a1e9c91f3 8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on os::free Summary: Clear out class_file_bytes so they aren't deallocated twice Reviewed-by: dcubed, sspitsyn ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 4674e409a9e6 Author: coleenp Date: 2013-05-07 18:51 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4674e409a9e6 8014024: NPG: keep compiled ic methods from being deallocated in redefine classes Summary: Walk the compiledIC relocation records to keep Method* from being deallocated. Reviewed-by: dlong, kvn ! src/share/vm/code/nmethod.cpp Changeset: a1cc1d1e7ce5 Author: coleenp Date: 2013-05-07 16:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a1cc1d1e7ce5 Merge Changeset: 28ae1d38d296 Author: coleenp Date: 2013-05-07 18:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28ae1d38d296 Merge Changeset: 64340da5b68c Author: hseigel Date: 2013-05-08 08:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/64340da5b68c 8007018: RFE: -XX:+UseLargePages does not work with CDS Summary: Remove command line restriction. It should just work. Reviewed-by: ctornqvi, coleenp, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: cbfe859bd244 Author: sla Date: 2013-05-08 15:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbfe859bd244 8013591: compiler/ciReplay/TestSA.sh fails in nightly Reviewed-by: coleenp, rbackman, dholmes ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java Changeset: 0dc028fd5101 Author: sla Date: 2013-05-08 10:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0dc028fd5101 Merge Changeset: 39ead0411f07 Author: bharadwaj Date: 2013-05-08 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/39ead0411f07 8013875: Incorrect vtable index being set during methodHandle creation for static Summary: Set vtable index as appropriate for static interface methods and for interface methods invoked via invokespecial. To be improved in a later enhancement to CallInfo. Reviewed-by: jrose, twisti ! src/share/vm/prims/methodHandles.cpp Changeset: 711016f146fd Author: dholmes Date: 2013-05-08 19:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/711016f146fd 8006997: ContendedPaddingWidth should be range-checked Summary: Constrain between zero and 8K Reviewed-by: dholmes, rbackman Contributed-by: Aleksey Shipilev ! src/share/vm/runtime/arguments.cpp Changeset: 9b77ca4ce35e Author: dholmes Date: 2013-05-08 19:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9b77ca4ce35e Merge ! src/share/vm/runtime/arguments.cpp Changeset: c272092594bd Author: dholmes Date: 2013-05-08 21:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c272092594bd Merge Changeset: 0b7f78069732 Author: rbackman Date: 2013-05-08 11:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b7f78069732 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return Reviewed-by: coleenp, dholmes, sla ! src/share/vm/prims/jvmtiExport.cpp Changeset: 735c995bf1a1 Author: rbackman Date: 2013-05-13 07:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/735c995bf1a1 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 92ef81e2f571 Author: minqi Date: 2013-05-10 08:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/92ef81e2f571 8003557: NPG: Klass* const k should be const Klass* k. Summary: With NPG, const KlassOop klass which is in fact a definition converted to Klass* const, which is not the original intention. The right usage is converting them to const Klass*. Reviewed-by: coleenp, kvn Contributed-by: yumin.qi at oracle.com ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 1fcfc045b229 Author: minqi Date: 2013-05-10 19:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1fcfc045b229 Merge Changeset: 8b40495b9381 Author: minqi Date: 2013-05-13 18:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8b40495b9381 Merge ! src/share/vm/oops/method.hpp Changeset: 43083e670adf Author: coleenp Date: 2013-05-13 15:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/43083e670adf 8005056: NPG: Crash after redefining java.lang.Object Summary: Need to walk array class vtables replacing old methods too if j.l.o redefined Reviewed-by: sspitsyn, dcubed, ctornqvi ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp + test/runtime/RedefineObject/Agent.java + test/runtime/RedefineObject/TestRedefineObject.java ! test/testlibrary/ClassFileInstaller.java Changeset: a9270d9ecb13 Author: shade Date: 2013-05-14 11:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a9270d9ecb13 8014448: Purge PrintCompactFieldsSavings Summary: Remove obsolete debugging code. Reviewed-by: dholmes, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/globals.hpp Changeset: f944ba972151 Author: hseigel Date: 2013-05-14 09:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f944ba972151 8014138: Add VM option to facilitate the writing of CDS tests Summary: Added the -XX:SharedArchiveFile option. Reviewed-by: coleenp, ccheung, acorn, dcubed, zgu ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp + test/runtime/SharedArchiveFile/SharedArchiveFile.java Changeset: f9be75d21404 Author: minqi Date: 2013-05-14 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9be75d21404 8012902: remove use of global operator new - take 2 Summary: The fix of 8010992, disable use of global operator new and new[] which caused failure on some tests. This takes two of the bugs also add ALLOW_OPERATOR_NEW_USAGE to prevent crash for third party code calling operator new of jvm on certain platforms. Reviewed-by: coleenp, dholmes, zgu Contributed-by: yumin.qi at oracle.com ! make/bsd/makefiles/fastdebug.make ! make/bsd/makefiles/vm.make ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/classfile/altHashing.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/memRegion.cpp ! src/share/vm/memory/memRegion.hpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/objectMonitor.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/unhandledOops.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 513a5298c1dd Author: minqi Date: 2013-05-14 17:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/513a5298c1dd Merge Changeset: d15464bfd4d0 Author: roland Date: 2013-05-03 09:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d15464bfd4d0 8012037: Test8009761.java "Failed: init recursive calls: 7224. After deopt 58824" Summary: test shouldn't be run with a modified CompileThreshold Reviewed-by: kvn ! test/compiler/8009761/Test8009761.java Changeset: e76dd894b984 Author: roland Date: 2013-04-24 14:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e76dd894b984 8012292: optimized build with GCC broken Summary: Some #ifndef PRODUCT should be #ifdef ASSERT Reviewed-by: kvn, twisti Contributed-by: gdub ! make/jprt.properties ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: d73c88e524ff Author: kvn Date: 2013-05-03 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d73c88e524ff Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: f0bc60565ba8 Author: twisti Date: 2013-05-06 13:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f0bc60565ba8 7196277: JSR 292: Two jck/runtime tests crash on java.lang.invoke.MethodHandle.invokeExact Reviewed-by: jrose, kvn ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: aabf54ccedb1 Author: twisti Date: 2013-05-06 19:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aabf54ccedb1 8008772: remove gamma launcher Reviewed-by: kvn, neliasso, ctornqvi ! make/Makefile ! make/bsd/makefiles/buildtree.make - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make + make/hotspot.script ! make/linux/makefiles/buildtree.make - make/linux/makefiles/launcher.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make - make/solaris/makefiles/launcher.make ! make/solaris/makefiles/vm.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make - make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/projectfiles/common/Makefile - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h Changeset: 6f3fd5150b67 Author: kvn Date: 2013-05-08 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f3fd5150b67 6934604: enable parts of EliminateAutoBox by default Summary: Resurrected autobox elimination code and enabled part of it by default. Reviewed-by: roland, twisti ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/multnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phase.cpp ! src/share/vm/opto/phase.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/6934604/TestByteBoxing.java + test/compiler/6934604/TestDoubleBoxing.java + test/compiler/6934604/TestFloatBoxing.java + test/compiler/6934604/TestIntBoxing.java + test/compiler/6934604/TestLongBoxing.java + test/compiler/6934604/TestShortBoxing.java Changeset: 70120f47d403 Author: kvn Date: 2013-05-09 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/70120f47d403 8014189: JVM crash with SEGV in ConnectionGraph::record_for_escape_analysis() Summary: Add NULL checks and asserts for Type::make_ptr() returned value. Reviewed-by: twisti ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/subnode.cpp Changeset: 8bcfd9ce2c6b Author: twisti Date: 2013-05-13 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8bcfd9ce2c6b Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 1da5d70655e9 Author: kvn Date: 2013-05-13 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1da5d70655e9 8014286: failed java/lang/Math/DivModTests.java after 6934604 changes Summary: Corrected escape state for the result of boxing method. Added force inlining executed boxing methods. Reviewed-by: twisti ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/escape.cpp Changeset: cd6f6fccd287 Author: iignatyev Date: 2013-05-15 22:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd6f6fccd287 8014068: TEST_BUG: compiler/ciReplay/TestSA.sh fails on Windows: core wasn't generated Reviewed-by: kvn ! test/compiler/ciReplay/TestSA.sh ! test/compiler/ciReplay/common.sh Changeset: e484fe2abebd Author: twisti Date: 2013-05-16 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e484fe2abebd Merge - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: 7a95933197d0 Author: tschatzl Date: 2013-05-13 09:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7a95933197d0 8014058: Regression tests for 8006088 Summary: The patch for 8006088 misses regression tests after a merge error, this CR provides them. Reviewed-by: jwilhelm, tamao, jmasa ! src/share/vm/memory/collectorPolicy.cpp + test/gc/arguments/TestCMSHeapSizeFlags.java + test/gc/arguments/TestG1HeapSizeFlags.java + test/gc/arguments/TestMaxHeapSizeTools.java + test/gc/arguments/TestMinInitialErgonomics.java + test/gc/arguments/TestParallelHeapSizeFlags.java + test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 4868caa99ecf Author: brutisso Date: 2013-05-13 14:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4868caa99ecf 8014339: Improve assert and remove some dead code from parMarkBitMap.hpp/cpp Reviewed-by: stefank, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Changeset: 0a2986f36965 Author: tschatzl Date: 2013-05-14 17:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0a2986f36965 8014489: tests/gc/arguments/Test(Serial|CMS|Parallel|G1)HeapSizeFlags jtreg tests invoke wrong class Summary: Some jtreg tests reference unknown classes in the @run and @build lines. This change fixes them. Reviewed-by: stefank, ehelin ! test/gc/arguments/TestCMSHeapSizeFlags.java ! test/gc/arguments/TestG1HeapSizeFlags.java ! test/gc/arguments/TestParallelHeapSizeFlags.java ! test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 12f651e29f6b Author: tschatzl Date: 2013-05-15 11:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/12f651e29f6b 6843347: Boundary values in some public GC options cause crashes Summary: Setting some public integer options to specific values causes crashes or undefined GC behavior. This patchset adds the necessary argument checking for these options. Reviewed-by: jmasa, brutisso ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: eba99d16dc6f Author: tamao Date: 2013-05-15 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eba99d16dc6f 8007763: Refactoring: split up compute_generation_free_space() into two functions for class PSAdaptiveSizePolicy Summary: split up compute_generation_free_space() into two functions: compute_eden_space_size() + compute_old_gen_free_space(), each of which (if needed) can be reused without executing an overhead of the other. Reviewed-by: jmasa, tschatzl Contributed-by: tamao ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Changeset: bed55d125e37 Author: johnc Date: 2013-05-15 22:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bed55d125e37 8014408: G1: crashes with assert assert(prev_committed_card_num == _committed_max_card_num) failed Summary: Mismatch in the card number calculation between next and previous committed sizes of the card counts table. Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CardCounts.hpp Changeset: 05a17f270c7e Author: tschatzl Date: 2013-05-16 13:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/05a17f270c7e 8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo Summary: Improve the output of G1PrintRegionLivenessInfo by adding a per-region remembered set size information column Reviewed-by: jwilhelm, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp + test/gc/g1/TestPrintRegionRememberedSetInfo.java Changeset: 48391ab0687e Author: johnc Date: 2013-05-16 09:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48391ab0687e 8010738: G1: Output for full GCs with +PrintGCDetails should contain perm gen size/meta data change info Summary: Include metaspace information (used, allocated, reserved) in the PrintGCDetails output for full GCs. Reviewed-by: poonam, jmasa, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp + test/gc/g1/TestPrintGCDetails.java Changeset: acac2b03a07f Author: tschatzl Date: 2013-05-16 23:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/acac2b03a07f 8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set Summary: The VM exits when the condition in the subject line applies. The fix sets InitialTenuringThreshold to MaxTenuringThreshold if it is larger than MaxTenuringThreshold and InitialTenuringThreshold has not been set (is default). Reviewed-by: jwilhelm, jmasa, brutisso, johnc ! src/share/vm/runtime/arguments.cpp + test/gc/arguments/TestInitialTenuringThreshold.java Changeset: 2958af1d8c5a Author: jwilhelm Date: 2013-05-17 06:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2958af1d8c5a Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2f9ac66165e6 Author: jwilhelm Date: 2013-05-17 08:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f9ac66165e6 Merge - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/runtime/arguments.cpp Changeset: b19517cecc2e Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b19517cecc2e Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp Changeset: 7cbdf0e3725c Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7cbdf0e3725c Added tag hs25-b33 for changeset b19517cecc2e ! .hgtags From lana.steuck at oracle.com Wed May 22 12:12:58 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:12:58 +0000 Subject: hg: jdk8/tl/jdk: 23 new changesets Message-ID: <20130522191804.C371B48C4E@hg.openjdk.java.net> Changeset: b8e7d145abc2 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8e7d145abc2 Added tag jdk8-b89 for changeset 845025546e35 ! .hgtags Changeset: 1f1699686504 Author: katleman Date: 2013-05-09 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f1699686504 8014289: JDK8 b89 source with GPL header errors Reviewed-by: mchung, mduigou, tbell, dsamersoff ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/StringJoiner.java ! test/java/lang/CharSequence/DefaultTest.java ! test/java/util/StringJoiner/StringJoinerTest.java Changeset: c63eda8f6300 Author: katleman Date: 2013-05-14 12:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c63eda8f6300 Merge Changeset: 08c28cdacd7b Author: katleman Date: 2013-05-16 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08c28cdacd7b Added tag jdk8-b90 for changeset c63eda8f6300 ! .hgtags Changeset: 4dd6f7bb8bbd Author: simonis Date: 2013-05-06 12:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4dd6f7bb8bbd 7191872: Xrender: No text displayed using 64 bit JDK on solaris11-sparc Reviewed-by: prr, ceisserer ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/GlyphList.java ! src/solaris/classes/sun/font/XRGlyphCacheEntry.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 23f7ff502a89 Author: jgodinez Date: 2013-05-07 09:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23f7ff502a89 8011069: Printing: NullPointerException since jdk8 b82 showing native Page Setup Dialog. Reviewed-by: bae, prr ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 8a995d335d59 Author: lana Date: 2013-05-09 19:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a995d335d59 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 103f492d8ce7 Author: vadim Date: 2013-05-17 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/103f492d8ce7 4892259: GIF ImageReader does not call passComplete in IIOReadUpdateListener Reviewed-by: prr, bae ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java + test/javax/imageio/plugins/gif/GIFPassListenerTest.java Changeset: 4ee85e865a83 Author: vadim Date: 2013-05-17 14:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ee85e865a83 8000936: Enable Java2D D3D pipeline on newer Intel chipsets : Intel HD and later Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 51f5e544c88b Author: lana Date: 2013-05-17 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51f5e544c88b Merge Changeset: 90b67c9a7eb2 Author: serb Date: 2013-05-06 16:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90b67c9a7eb2 7161575: [macosx] On MacOSX port java.awt.Toolkit.is/setDynamicLayout() are not consistent Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWToolkit.java Changeset: 7982299cd11c Author: serb Date: 2013-05-08 15:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7982299cd11c 8013841: [macosx] Animations not disabled for CALayers used via JAWT Reviewed-by: anthony, alexsch ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: 5fe0a4da863d Author: lana Date: 2013-05-09 18:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fe0a4da863d Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: a466a4192fea Author: pchelko Date: 2013-05-14 16:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a466a4192fea 8002045: Auto failed and threw exception:java.lang.UnsatisfiedLinkError: Reviewed-by: serb, anthony ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-bsd ! make/sun/awt/mapfile-vers-linux ! makefiles/mapfiles/libawt/mapfile-vers ! makefiles/mapfiles/libawt/mapfile-vers-linux Changeset: b1a7cc79f13d Author: serb Date: 2013-05-14 17:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1a7cc79f13d 8014423: [macosx] The scrollbar's block increment performs incorrectly Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java Changeset: 722ee3129ce0 Author: ant Date: 2013-05-15 16:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/722ee3129ce0 8014227: JLightweightFrame needs another synchronization policy Reviewed-by: art ! src/share/classes/sun/swing/JLightweightFrame.java Changeset: 7a8a8e31a126 Author: pchelko Date: 2013-05-17 11:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8a8e31a126 7079254: Toolkit eventListener leaks memory Reviewed-by: serb, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java + test/java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java Changeset: e944b78812a8 Author: kshefov Date: 2013-05-17 14:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e944b78812a8 8014721: TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException Reviewed-by: anthony, serb ! test/java/awt/TrayIcon/DragEventSource/DragEventSource.java Changeset: 281add053efe Author: kshefov Date: 2013-05-17 14:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/281add053efe 8013426: TEST_BUG: java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java fails with "RuntimeException: The data should be available" on Linux Reviewed-by: anthony, serb ! test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java Changeset: 49871f1581b8 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49871f1581b8 Merge Changeset: 30101f69e66f Author: lana Date: 2013-05-17 10:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30101f69e66f Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/util/Base64.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/lang/Thread/StackTraces.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java - test/java/util/logging/bundlesearch/LoadItUp.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: bcfab7056195 Author: lana Date: 2013-05-22 09:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcfab7056195 Merge Changeset: 760d4187597a Author: lana Date: 2013-05-22 12:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/760d4187597a Merge From joseph.provino at oracle.com Wed May 22 12:27:12 2013 From: joseph.provino at oracle.com (Joseph Provino) Date: Wed, 22 May 2013 15:27:12 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519BDE85.6000005@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com> <519BDE85.6000005@oracle.com> Message-ID: <519D1C10.90302@oracle.com> Is there a consensus what is in the webrev is okay? The change is to include forte.cpp in the minimal jvm but to conditionalize the code so that only AsyncGetCallTrace() is defined with the minimal jvm. Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01 JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release joe On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote: > > On 5/21/2013 4:00 PM, Oleg Mazurov wrote: >> Though formally not part of the Solaris Studio team any more here is >> my opinion based on my recollection of how I implemented interaction >> with the JVM via AsyncGetCallTrace. >> It's looked up using dlsym. If the symbol is not there Java callstack >> collection is shut down. I understand in your case even JVMTI is not >> there so the dlsym call will not be made. >> From that perspective there is no difference whether the symbol is >> present and returns an error code or not present at all. > > Oleg, then it sounds like what we have will work. > > Thanks for the quick reply. > > joe > >> >> -- Oleg >> >> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: >>> >>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>>>> >>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO >>>>>> wrote: >>>>>> >>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>>>> Hi Staffan, >>>>>>>> >>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>>>> On 21 maj 2013, at 04:34, David Holmes >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Hi Joe, >>>>>>>>>> >>>>>>>>>> As I have previously stated you copied the struct definitions >>>>>>>>>> instead of moving them outside the ifdef. >>>>>>>>>> >>>>>>>>>> Serviceability folk: we are particularly interested in >>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate >>>>>>>>>> in this situation. Who will be consuming this value? >>>>>>>>> Since you have opted for the simple fix of having an exported >>>>>>>>> but non-functional AsyncGetCallTrace instead of actually >>>>>>>>> removing the symbol from the symbol files (which is the >>>>>>>>> proposed solution in the bug report), >>>>>>>> That would be a simpler solution semantically but the only way >>>>>>>> I can see to do that is to use a text replacement mechanism in >>>>>>>> the build files - as is done for the dynamic vtable symbols. I >>>>>>>> find that less appealing than simply exporting an interface >>>>>>>> that is configured to report an error (which is essentially >>>>>>>> what all the optional interfaces do under the minimal VM). >>>>>>>> >>>>>>>>> I would like you to include a comment about this in the >>>>>>>>> source. Right now it's very unclear why there is an exported >>>>>>>>> function that only returns an error. >>>>>>>>> >>>>>>>>> As to the appropriate return value, I don't know. The only >>>>>>>>> caller should be the Sun Studio profiler, >>>>> Does anyone know where to find instructions on how to run the >>>>> collector which would get the error return value? >>>>>>>>> and I'm not sure how it will handle this case if ever run. >>>>>>>>> The possible return values aren't very well documented. >>>>>>>> I guess we need to try and run it to find out. >>>>>>> Okay, do either of you feel strongly about how this should be >>>>>>> fixed -- return an error or remove the symbol? >>>>>> No, I don't feel strongly either way, but a comment in the code >>>>>> would be nice. >>>>> How much effort should I put into finding out what Sun Studio >>>>> profiler does when it gets -1? >>>> >>>> Let's ask the Solaris Studio guys directly. >>>> I'm adding Oleg to the mailing list. >>>> >>>> Oleg, >>>> >>>> Could you, please, share your view on this problem? >>> >>> In particular what will the Sun Studio Profiler collector do if it >>> gets the error >>> >>> trace->num_frames = ticks_no_class_load; // -1 >>> >>> Thanks. >>> >>> joe >>> >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> >>>> >>>>> >>>>> joe >>>>> >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>>> >>>>>> >>>>>>> joe >>>>>>> >>>>>>>> Thanks, >>>>>>>> David >>>>>>>> >>>>>>>>> /Staffan >>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> David >>>>>>>>>> >>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>>>> conditionalize the code so that >>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>>>> >>>>>>>>>>> Webrev is here: >>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>>>> >>>>>>>>>>> * JDK-8013461 >>>>>>>>>>> There is >>>>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does >>>>>>>>>>> not exist in >>>>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks. >>>>>>>>>>> >>>>>>>>>>> joe >>>>>>>>>>> >>>>>>>>>>> >>>>> >>>> >>> >> > From bob.vandette at oracle.com Wed May 22 13:27:45 2013 From: bob.vandette at oracle.com (Bob Vandette) Date: Wed, 22 May 2013 16:27:45 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519D1C10.90302@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com> <519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com> Message-ID: Joe, I'm ok with this approach. Bob. On May 22, 2013, at 3:27 PM, Joseph Provino wrote: > Is there a consensus what is in the webrev is okay? > > The change is to include forte.cpp in the minimal jvm but to > conditionalize the code so that only AsyncGetCallTrace() > is defined with the minimal jvm. > > Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01 > > JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461 > There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in > minimal/libjvm.a when DEBUG_LEVEL == release > > joe > > On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote: >> >> On 5/21/2013 4:00 PM, Oleg Mazurov wrote: >>> Though formally not part of the Solaris Studio team any more here is my opinion based on my recollection of how I implemented interaction with the JVM via AsyncGetCallTrace. >>> It's looked up using dlsym. If the symbol is not there Java callstack collection is shut down. I understand in your case even JVMTI is not there so the dlsym call will not be made. >>> From that perspective there is no difference whether the symbol is present and returns an error code or not present at all. >> >> Oleg, then it sounds like what we have will work. >> >> Thanks for the quick reply. >> >> joe >> >>> >>> -- Oleg >>> >>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: >>>> >>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>>>>> >>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: >>>>>>> >>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>>>>> Hi Staffan, >>>>>>>>> >>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi Joe, >>>>>>>>>>> >>>>>>>>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >>>>>>>>>>> >>>>>>>>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? >>>>>>>>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), >>>>>>>>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). >>>>>>>>> >>>>>>>>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. >>>>>>>>>> >>>>>>>>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, >>>>>> Does anyone know where to find instructions on how to run the collector which would get the error return value? >>>>>>>>>> and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. >>>>>>>>> I guess we need to try and run it to find out. >>>>>>>> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? >>>>>>> No, I don't feel strongly either way, but a comment in the code would be nice. >>>>>> How much effort should I put into finding out what Sun Studio profiler does when it gets -1? >>>>> >>>>> Let's ask the Solaris Studio guys directly. >>>>> I'm adding Oleg to the mailing list. >>>>> >>>>> Oleg, >>>>> >>>>> Could you, please, share your view on this problem? >>>> >>>> In particular what will the Sun Studio Profiler collector do if it gets the error >>>> >>>> trace->num_frames = ticks_no_class_load; // -1 >>>> >>>> Thanks. >>>> >>>> joe >>>> >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> joe >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>>> >>>>>>> >>>>>>>> joe >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> David >>>>>>>>> >>>>>>>>>> /Staffan >>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> David >>>>>>>>>>> >>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>>>>> conditionalize the code so that >>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>>>>> >>>>>>>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>>>>> >>>>>>>>>>>> * JDK-8013461 There is >>>>>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>>>>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks. >>>>>>>>>>>> >>>>>>>>>>>> joe >>>>>>>>>>>> >>>>>>>>>>>> >>>>>> >>>>> >>>> >>> >> > From joe.darcy at oracle.com Wed May 22 13:34:18 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 22 May 2013 20:34:18 +0000 Subject: hg: jdk8/tl/langtools: 8010680: Clarify "present" and annotation ordering in javax.lang.model Message-ID: <20130522203421.0DEDA48C59@hg.openjdk.java.net> Changeset: 3bd22f99d408 Author: darcy Date: 2013-05-22 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3bd22f99d408 8010680: Clarify "present" and annotation ordering in javax.lang.model Reviewed-by: abuckley, jjg ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/util/Elements.java From serguei.spitsyn at oracle.com Wed May 22 14:32:40 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 22 May 2013 14:32:40 -0700 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519D1C10.90302@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com> <519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com> Message-ID: <519D3978.7000008@oracle.com> The fix is good. Thanks, Serguei On 5/22/13 12:27 PM, Joseph Provino wrote: > Is there a consensus what is in the webrev is okay? > > The change is to include forte.cpp in the minimal jvm but to > conditionalize the code so that only AsyncGetCallTrace() > is defined with the minimal jvm. > > Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01 > > JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461 > There is a symbol AsyncGetCallTrace in libjvm.symbols that does > not exist in > minimal/libjvm.a when DEBUG_LEVEL == release > > joe > > On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote: >> >> On 5/21/2013 4:00 PM, Oleg Mazurov wrote: >>> Though formally not part of the Solaris Studio team any more here is >>> my opinion based on my recollection of how I implemented interaction >>> with the JVM via AsyncGetCallTrace. >>> It's looked up using dlsym. If the symbol is not there Java >>> callstack collection is shut down. I understand in your case even >>> JVMTI is not there so the dlsym call will not be made. >>> From that perspective there is no difference whether the symbol is >>> present and returns an error code or not present at all. >> >> Oleg, then it sounds like what we have will work. >> >> Thanks for the quick reply. >> >> joe >> >>> >>> -- Oleg >>> >>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: >>>> >>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>>>>> >>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO >>>>>>> wrote: >>>>>>> >>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>>>>> Hi Staffan, >>>>>>>>> >>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi Joe, >>>>>>>>>>> >>>>>>>>>>> As I have previously stated you copied the struct >>>>>>>>>>> definitions instead of moving them outside the ifdef. >>>>>>>>>>> >>>>>>>>>>> Serviceability folk: we are particularly interested in >>>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate >>>>>>>>>>> in this situation. Who will be consuming this value? >>>>>>>>>> Since you have opted for the simple fix of having an exported >>>>>>>>>> but non-functional AsyncGetCallTrace instead of actually >>>>>>>>>> removing the symbol from the symbol files (which is the >>>>>>>>>> proposed solution in the bug report), >>>>>>>>> That would be a simpler solution semantically but the only way >>>>>>>>> I can see to do that is to use a text replacement mechanism in >>>>>>>>> the build files - as is done for the dynamic vtable symbols. I >>>>>>>>> find that less appealing than simply exporting an interface >>>>>>>>> that is configured to report an error (which is essentially >>>>>>>>> what all the optional interfaces do under the minimal VM). >>>>>>>>> >>>>>>>>>> I would like you to include a comment about this in the >>>>>>>>>> source. Right now it's very unclear why there is an exported >>>>>>>>>> function that only returns an error. >>>>>>>>>> >>>>>>>>>> As to the appropriate return value, I don't know. The only >>>>>>>>>> caller should be the Sun Studio profiler, >>>>>> Does anyone know where to find instructions on how to run the >>>>>> collector which would get the error return value? >>>>>>>>>> and I'm not sure how it will handle this case if ever run. >>>>>>>>>> The possible return values aren't very well documented. >>>>>>>>> I guess we need to try and run it to find out. >>>>>>>> Okay, do either of you feel strongly about how this should be >>>>>>>> fixed -- return an error or remove the symbol? >>>>>>> No, I don't feel strongly either way, but a comment in the code >>>>>>> would be nice. >>>>>> How much effort should I put into finding out what Sun Studio >>>>>> profiler does when it gets -1? >>>>> >>>>> Let's ask the Solaris Studio guys directly. >>>>> I'm adding Oleg to the mailing list. >>>>> >>>>> Oleg, >>>>> >>>>> Could you, please, share your view on this problem? >>>> >>>> In particular what will the Sun Studio Profiler collector do if it >>>> gets the error >>>> >>>> trace->num_frames = ticks_no_class_load; // -1 >>>> >>>> Thanks. >>>> >>>> joe >>>> >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> joe >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>>> >>>>>>> >>>>>>>> joe >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> David >>>>>>>>> >>>>>>>>>> /Staffan >>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> David >>>>>>>>>>> >>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>>>>> conditionalize the code so that >>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>>>>> >>>>>>>>>>>> Webrev is here: >>>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>>>>> >>>>>>>>>>>> * JDK-8013461 >>>>>>>>>>>> There is >>>>>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does >>>>>>>>>>>> not exist in >>>>>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks. >>>>>>>>>>>> >>>>>>>>>>>> joe >>>>>>>>>>>> >>>>>>>>>>>> >>>>>> >>>>> >>>> >>> >> > From naoto.sato at oracle.com Wed May 22 16:43:48 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 22 May 2013 23:43:48 +0000 Subject: hg: jdk8/tl/jdk: 7056126: DateFormatSymbols documentation has incorrect description about DateFormat; ... Message-ID: <20130522234408.E489648C66@hg.openjdk.java.net> Changeset: 50fde3eeb48c Author: naoto Date: 2013-05-22 16:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50fde3eeb48c 7056126: DateFormatSymbols documentation has incorrect description about DateFormat 7083668: Sample code in ListResourceBundle is still not correct Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/util/ListResourceBundle.java From david.holmes at oracle.com Wed May 22 17:09:36 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 23 May 2013 10:09:36 +1000 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519D1C10.90302@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com> <519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com> Message-ID: <519D5E40.3010407@oracle.com> Joe, On 23/05/2013 5:27 AM, Joseph Provino wrote: > Is there a consensus what is in the webrev is okay? Yes I am now okay with it. I found this in 4889433: "AsyncGetCallTrace() requires the CLASS_LOAD event to be enabled because that causes jmethodID's to be created for the methods at class load time. This increases the likelyhood of being able to get the jmethodID for a frame during a stackwalk. Since AsyncGetCallTrace() cannot block, it uses a special routine to the get the jmethodID that does not block if the jmethodID is not available immediately. So while CLASS_LOAD events are not strictly required, the data gathered during the stackwalk would be pretty useless." So reporting the ticks_no_class_load value seems quite reasonable and the clients of this interface should be expecting it. Thanks, David > The change is to include forte.cpp in the minimal jvm but to > conditionalize the code so that only AsyncGetCallTrace() > is defined with the minimal jvm. > > Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01 > > JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461 > There is a symbol AsyncGetCallTrace in libjvm.symbols that does not > exist in > minimal/libjvm.a when DEBUG_LEVEL == release > > joe > > On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote: >> >> On 5/21/2013 4:00 PM, Oleg Mazurov wrote: >>> Though formally not part of the Solaris Studio team any more here is >>> my opinion based on my recollection of how I implemented interaction >>> with the JVM via AsyncGetCallTrace. >>> It's looked up using dlsym. If the symbol is not there Java callstack >>> collection is shut down. I understand in your case even JVMTI is not >>> there so the dlsym call will not be made. >>> From that perspective there is no difference whether the symbol is >>> present and returns an error code or not present at all. >> >> Oleg, then it sounds like what we have will work. >> >> Thanks for the quick reply. >> >> joe >> >>> >>> -- Oleg >>> >>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: >>>> >>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>>>>> >>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO >>>>>>> wrote: >>>>>>> >>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>>>>> Hi Staffan, >>>>>>>>> >>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi Joe, >>>>>>>>>>> >>>>>>>>>>> As I have previously stated you copied the struct definitions >>>>>>>>>>> instead of moving them outside the ifdef. >>>>>>>>>>> >>>>>>>>>>> Serviceability folk: we are particularly interested in >>>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate >>>>>>>>>>> in this situation. Who will be consuming this value? >>>>>>>>>> Since you have opted for the simple fix of having an exported >>>>>>>>>> but non-functional AsyncGetCallTrace instead of actually >>>>>>>>>> removing the symbol from the symbol files (which is the >>>>>>>>>> proposed solution in the bug report), >>>>>>>>> That would be a simpler solution semantically but the only way >>>>>>>>> I can see to do that is to use a text replacement mechanism in >>>>>>>>> the build files - as is done for the dynamic vtable symbols. I >>>>>>>>> find that less appealing than simply exporting an interface >>>>>>>>> that is configured to report an error (which is essentially >>>>>>>>> what all the optional interfaces do under the minimal VM). >>>>>>>>> >>>>>>>>>> I would like you to include a comment about this in the >>>>>>>>>> source. Right now it's very unclear why there is an exported >>>>>>>>>> function that only returns an error. >>>>>>>>>> >>>>>>>>>> As to the appropriate return value, I don't know. The only >>>>>>>>>> caller should be the Sun Studio profiler, >>>>>> Does anyone know where to find instructions on how to run the >>>>>> collector which would get the error return value? >>>>>>>>>> and I'm not sure how it will handle this case if ever run. >>>>>>>>>> The possible return values aren't very well documented. >>>>>>>>> I guess we need to try and run it to find out. >>>>>>>> Okay, do either of you feel strongly about how this should be >>>>>>>> fixed -- return an error or remove the symbol? >>>>>>> No, I don't feel strongly either way, but a comment in the code >>>>>>> would be nice. >>>>>> How much effort should I put into finding out what Sun Studio >>>>>> profiler does when it gets -1? >>>>> >>>>> Let's ask the Solaris Studio guys directly. >>>>> I'm adding Oleg to the mailing list. >>>>> >>>>> Oleg, >>>>> >>>>> Could you, please, share your view on this problem? >>>> >>>> In particular what will the Sun Studio Profiler collector do if it >>>> gets the error >>>> >>>> trace->num_frames = ticks_no_class_load; // -1 >>>> >>>> Thanks. >>>> >>>> joe >>>> >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> joe >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>>> >>>>>>> >>>>>>>> joe >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> David >>>>>>>>> >>>>>>>>>> /Staffan >>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> David >>>>>>>>>>> >>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>>>>> conditionalize the code so that >>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>>>>> >>>>>>>>>>>> Webrev is here: >>>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>>>>> >>>>>>>>>>>> * JDK-8013461 >>>>>>>>>>>> There is >>>>>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does >>>>>>>>>>>> not exist in >>>>>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks. >>>>>>>>>>>> >>>>>>>>>>>> joe >>>>>>>>>>>> >>>>>>>>>>>> >>>>>> >>>>> >>>> >>> >> > From david.holmes at oracle.com Wed May 22 17:22:14 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 23 May 2013 00:22:14 +0000 Subject: hg: jdk8/tl/jdk: 8014814: (str) StringBuffer "null" is not appended Message-ID: <20130523002227.DFDD648C67@hg.openjdk.java.net> Changeset: a1a8e71e130a Author: dholmes Date: 2013-05-22 20:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1a8e71e130a 8014814: (str) StringBuffer "null" is not appended Reviewed-by: alanb ! src/share/classes/java/lang/StringBuffer.java ! test/java/lang/StringBuffer/ToStringCache.java From joe.darcy at oracle.com Wed May 22 20:04:11 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 23 May 2013 03:04:11 +0000 Subject: hg: jdk8/tl/jdk: 8014836: Have GenericDeclaration extend AnnotatedElement Message-ID: <20130523030435.BAA4248C7C@hg.openjdk.java.net> Changeset: e764bb01567e Author: darcy Date: 2013-05-22 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e764bb01567e 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: abuckley, jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/GenericDeclaration.java From coleen.phillimore at oracle.com Wed May 22 22:31:52 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Thu, 23 May 2013 05:31:52 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8003421: NPG: Move oops out of InstanceKlass into mirror Message-ID: <20130523053154.5F58F48C81@hg.openjdk.java.net> Changeset: 6bd680e9ea35 Author: coleenp Date: 2013-05-22 14:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6bd680e9ea35 8003421: NPG: Move oops out of InstanceKlass into mirror Summary: Inject protection_domain, signers, init_lock into java_lang_Class Reviewed-by: stefank, dholmes, sla ! agent/src/share/classes/sun/jvm/hotspot/memory/DictionaryEntry.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapGXLWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaInstanceKlass.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/vmStructs.cpp From dmitry.samersoff at oracle.com Thu May 23 00:12:09 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 23 May 2013 11:12:09 +0400 Subject: Still need a reviewer please! Re: RR(S): 8014420 Default JDP address does not match the one assigned by IANA In-Reply-To: <5193DD2A.9070806@oracle.com> References: <5193DD2A.9070806@oracle.com> Message-ID: <519DC149.3070006@oracle.com> On 2013-05-15 23:08, Dmitry Samersoff wrote: > Please, > > Review a small patch, changing defaults for JDP to one assigned by IANA. > > All credential belongs to Florian Weimer > > http://cr.openjdk.java.net/~dsamersoff/8014420.JDP/webrev.01/ > > -Dmitry > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the source code. From staffan.larsen at oracle.com Thu May 23 00:33:43 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 23 May 2013 09:33:43 +0200 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519D1C10.90302@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com> <519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com> Message-ID: Ok! /Staffan On 22 maj 2013, at 21:27, Joseph Provino wrote: > Is there a consensus what is in the webrev is okay? > > The change is to include forte.cpp in the minimal jvm but to > conditionalize the code so that only AsyncGetCallTrace() > is defined with the minimal jvm. > > Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01 > > JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461 > There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in > minimal/libjvm.a when DEBUG_LEVEL == release > > joe > > On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote: >> >> On 5/21/2013 4:00 PM, Oleg Mazurov wrote: >>> Though formally not part of the Solaris Studio team any more here is my opinion based on my recollection of how I implemented interaction with the JVM via AsyncGetCallTrace. >>> It's looked up using dlsym. If the symbol is not there Java callstack collection is shut down. I understand in your case even JVMTI is not there so the dlsym call will not be made. >>> From that perspective there is no difference whether the symbol is present and returns an error code or not present at all. >> >> Oleg, then it sounds like what we have will work. >> >> Thanks for the quick reply. >> >> joe >> >>> >>> -- Oleg >>> >>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: >>>> >>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>>>>> >>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: >>>>>>> >>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>>>>> Hi Staffan, >>>>>>>>> >>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi Joe, >>>>>>>>>>> >>>>>>>>>>> As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. >>>>>>>>>>> >>>>>>>>>>> Serviceability folk: we are particularly interested in whether the use of ticks_no_class_load is deemed appropriate in this situation. Who will be consuming this value? >>>>>>>>>> Since you have opted for the simple fix of having an exported but non-functional AsyncGetCallTrace instead of actually removing the symbol from the symbol files (which is the proposed solution in the bug report), >>>>>>>>> That would be a simpler solution semantically but the only way I can see to do that is to use a text replacement mechanism in the build files - as is done for the dynamic vtable symbols. I find that less appealing than simply exporting an interface that is configured to report an error (which is essentially what all the optional interfaces do under the minimal VM). >>>>>>>>> >>>>>>>>>> I would like you to include a comment about this in the source. Right now it's very unclear why there is an exported function that only returns an error. >>>>>>>>>> >>>>>>>>>> As to the appropriate return value, I don't know. The only caller should be the Sun Studio profiler, >>>>>> Does anyone know where to find instructions on how to run the collector which would get the error return value? >>>>>>>>>> and I'm not sure how it will handle this case if ever run. The possible return values aren't very well documented. >>>>>>>>> I guess we need to try and run it to find out. >>>>>>>> Okay, do either of you feel strongly about how this should be fixed -- return an error or remove the symbol? >>>>>>> No, I don't feel strongly either way, but a comment in the code would be nice. >>>>>> How much effort should I put into finding out what Sun Studio profiler does when it gets -1? >>>>> >>>>> Let's ask the Solaris Studio guys directly. >>>>> I'm adding Oleg to the mailing list. >>>>> >>>>> Oleg, >>>>> >>>>> Could you, please, share your view on this problem? >>>> >>>> In particular what will the Sun Studio Profiler collector do if it gets the error >>>> >>>> trace->num_frames = ticks_no_class_load; // -1 >>>> >>>> Thanks. >>>> >>>> joe >>>> >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> joe >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>>> >>>>>>> >>>>>>>> joe >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> David >>>>>>>>> >>>>>>>>>> /Staffan >>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> David >>>>>>>>>>> >>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>>>>> conditionalize the code so that >>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>>>>> >>>>>>>>>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>>>>> >>>>>>>>>>>> * JDK-8013461 There is >>>>>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in >>>>>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks. >>>>>>>>>>>> >>>>>>>>>>>> joe >>>>>>>>>>>> >>>>>>>>>>>> >>>>>> >>>>> >>>> >>> >> > From david.holmes at oracle.com Thu May 23 02:25:13 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 23 May 2013 19:25:13 +1000 Subject: Still need a reviewer please! Re: RR(S): 8014420 Default JDP address does not match the one assigned by IANA In-Reply-To: <519DC149.3070006@oracle.com> References: <5193DD2A.9070806@oracle.com> <519DC149.3070006@oracle.com> Message-ID: <519DE079.5080509@oracle.com> Hi Dmitry, This looks fine to me. Thanks, and sorry for the delay :) David On 23/05/2013 5:12 PM, Dmitry Samersoff wrote: > On 2013-05-15 23:08, Dmitry Samersoff wrote: >> Please, >> >> Review a small patch, changing defaults for JDP to one assigned by IANA. >> >> All credential belongs to Florian Weimer >> >> http://cr.openjdk.java.net/~dsamersoff/8014420.JDP/webrev.01/ >> >> -Dmitry >> > > From kevin.walls at oracle.com Thu May 23 03:00:10 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 23 May 2013 11:00:10 +0100 Subject: RFR: 8010278 SA: provide mechanism for using an alternative SA debugger back-end. Message-ID: <519DE8AA.6070401@oracle.com> Hi, As the Serviceability Agent has been _the_ new and interesting way to find things post-mortem in the JVM [1], I'd like to propose an update which continues that tradition. 8010278 SA: provide mechanism for using an alternative SA debugger back-end. https://jbs.oracle.com/bugs/browse/JDK-8010278 http://cr.openjdk.java.net/~kevinw/8010278/webrev.00/ This is about making the SA more flexible, so we aren't tied to the given native libraries to open cores/memory dumps. Given this change, a 3rd party debugger or tool can interact freely with the SA tools (StackTrace, ObjectHistogram, etc...) and provide its own backend implementation to actually open a core/memory dump. Primarily for platform-independent core file debugging. If you ever had to open a "foreign" core, find the right hardware, etc... this is relevant. I'm thinking of https://java.net/projects/kjdb which can serve as a proof of concept. The changes are: The main redirection is in HotSpotAgent.java, where we respect a property (i.e. -Dsa.altHotSpotAgent=...) to name an alternate debugger. Remove calls to System.exit. Tool classes (and CLHSDB) should have a constructor that takes a JVMDebugger, to remove the assumption that a Tool's JVM will only ever contain one debugee. It doesn't address that VM is a singleton and if a tool opens multiple sessions then they would need to be from the same JVM version. Thanks Kevin [1] If you weren't in a circa 1.4.2 demo of the SA when all you had previously was a few fragile dbx macros, that got you a few very specific details, the night vs. day comparison of no SA vs. SA could be missed. 8-) From james.laskey at oracle.com Thu May 23 05:54:03 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 12:54:03 +0000 Subject: hg: jdk8/tl/nashorn: 9 new changesets Message-ID: <20130523125410.DE26E48C9B@hg.openjdk.java.net> Changeset: 833a9a584b64 Author: attila Date: 2013-05-21 13:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/833a9a584b64 8014953: Have NativeJavaPackage throw a ClassNotFoundException when invoked Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java + test/script/basic/JDK-8014953.js + test/script/basic/JDK-8014953.js.EXPECTED Changeset: 288ff54da2a5 Author: jlaskey Date: 2013-05-21 10:17 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/288ff54da2a5 8014827: readLine should accept a prompt as an argument Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java Changeset: 07cefc062032 Author: sundar Date: 2013-05-22 16:39 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/07cefc062032 8008947: ScriptEnvironment ctor should be public Reviewed-by: lagergren, attila ! .hgignore ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java Changeset: 66685c69bdb3 Author: sundar Date: 2013-05-22 19:33 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/66685c69bdb3 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java + test/script/basic/JDK-8014735.js + test/script/basic/JDK-8014735.js.EXPECTED ! test/script/basic/NASHORN-377.js Changeset: 8f7553df4503 Author: hannesw Date: 2013-05-22 16:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8f7553df4503 8010804: Review long and integer usage conventions Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/runtime/JSType.java + test/script/basic/JDK-8010804.js + test/script/basic/JDK-8010804.js.EXPECTED Changeset: 1c1453863ea8 Author: attila Date: 2013-05-23 12:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1c1453863ea8 8015267: Allow conversion of JS arrays to Java List/Deque Reviewed-by: lagergren, sundar ! make/build.xml ! src/jdk/nashorn/internal/objects/NativeJava.java + src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8015267.js + test/script/basic/JDK-8015267.js.EXPECTED Changeset: f7eb4436410e Author: lagergren Date: 2013-05-23 13:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f7eb4436410e 8012083: Array literal constant folding issue Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java + test/script/basic/JDK-8012083.js + test/script/basic/JDK-8012083.js.EXPECTED Changeset: 704bc91a0c41 Author: attila Date: 2013-05-23 13:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/704bc91a0c41 8015278: Revert accidental changes to build.xml Reviewed-by: jlaskey, lagergren ! make/build.xml Changeset: 8af550dee961 Author: jlaskey Date: 2013-05-23 09:49 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8af550dee961 Merge From kevin.walls at oracle.com Thu May 23 06:23:00 2013 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 23 May 2013 14:23:00 +0100 Subject: RFR: 8010278 SA: provide mechanism for using an alternative SA debugger back-end. In-Reply-To: <519DE8AA.6070401@oracle.com> References: <519DE8AA.6070401@oracle.com> Message-ID: <519E1834.5040401@oracle.com> Forgot to mention: I moved the ClassDump Tool around a little so it was usable via a route other than calling main(), and added the constructor that takes a String for the pkgList, which saves using the system property to communicate what classes you want to dump (sun.jvm.hotspot.tools.jcore.PackageNameFilter has that constructor already). Actually, considering the package filter name is always going to be sun.jvm.hotspot.tools.jcore.PackageNameFilter, let's have that as a default value when we call getProperty. Similarly the getProperty for outputDir, and at that point I stop tweaking. A little indenting was off also and I added a comment, so I redid the webrev: http://cr.openjdk.java.net/~kevinw/8010278/webrev.01/ Thanks Kevin On 23/05/13 11:00, Kevin Walls wrote: > Hi, > > As the Serviceability Agent has been _the_ new and interesting way to > find things post-mortem in the JVM [1], I'd like to propose an update > which continues that tradition. > > 8010278 SA: provide mechanism for using an alternative SA debugger > back-end. > https://jbs.oracle.com/bugs/browse/JDK-8010278 > http://cr.openjdk.java.net/~kevinw/8010278/webrev.00/ > > This is about making the SA more flexible, so we aren't tied to the > given native libraries to open cores/memory dumps. Given this change, > a 3rd party debugger or tool can interact freely with the SA tools > (StackTrace, ObjectHistogram, etc...) and provide its own backend > implementation to actually open a core/memory dump. > > Primarily for platform-independent core file debugging. If you ever > had to open a "foreign" core, find the right hardware, etc... this is > relevant. I'm thinking of https://java.net/projects/kjdb which can > serve as a proof of concept. > > The changes are: > > The main redirection is in HotSpotAgent.java, where we respect a > property (i.e. -Dsa.altHotSpotAgent=...) to name an alternate debugger. > > Remove calls to System.exit. > > Tool classes (and CLHSDB) should have a constructor that takes a > JVMDebugger, to remove the assumption that a Tool's JVM will only ever > contain one debugee. It doesn't address that VM is a singleton and if > a tool opens multiple sessions then they would need to be from the > same JVM version. > > > Thanks > Kevin > > [1] If you weren't in a circa 1.4.2 demo of the SA when all you had > previously was a few fragile dbx macros, that got you a few very > specific details, the night vs. day comparison of no SA vs. SA could > be missed. 8-) > > From nils.loodin at oracle.com Thu May 23 06:54:01 2013 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Thu, 23 May 2013 13:54:01 +0000 Subject: hg: jdk8/tl/jdk: 8014048: Online user guide of jconsole points incorrect link Message-ID: <20130523135413.A8A2B48CA9@hg.openjdk.java.net> Changeset: 0da6485cf656 Author: nloodin Date: 2013-05-23 15:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0da6485cf656 8014048: Online user guide of jconsole points incorrect link Reviewed-by: mchung, sla, jbachorik ! src/share/classes/sun/tools/jconsole/AboutDialog.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties ! src/share/classes/sun/tools/jconsole/resources/messages_ja.properties ! src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties From joseph.provino at oracle.com Thu May 23 07:52:53 2013 From: joseph.provino at oracle.com (Joseph Provino) Date: Thu, 23 May 2013 10:52:53 -0400 Subject: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release In-Reply-To: <519D5E40.3010407@oracle.com> References: <519A751A.5090604@oracle.com> <519ADD43.1030601@oracle.com> <519B1CDE.4090507@oracle.com> <519B9432.50808@oracle.com> <5CF10DF3-F735-4644-8AE1-2A4A22DFC754@oracle.com> <519BBC55.706@oracle.com> <519BC7F9.4080904@oracle.com> <519BC8A8.5060909@oracle.com> <519BD250.10302@oracle.com> <519BDE85.6000005@oracle.com> <519D1C10.90302@oracle.com> <519D5E40.3010407@oracle.com> Message-ID: <519E2D45.3050502@oracle.com> David, thanks for finding that! joe On 05/22/2013 08:09 PM, David Holmes wrote: > Joe, > > On 23/05/2013 5:27 AM, Joseph Provino wrote: >> Is there a consensus what is in the webrev is okay? > > Yes I am now okay with it. I found this in 4889433: > > "AsyncGetCallTrace() requires the CLASS_LOAD event > to be enabled because that causes jmethodID's to be created for the > methods at class load time. This increases the likelyhood of being > able to get the jmethodID for a frame during a stackwalk. Since > AsyncGetCallTrace() cannot block, it uses a special routine to the > get the jmethodID that does not block if the jmethodID is not available > immediately. So while CLASS_LOAD events are not strictly required, the > data gathered during the stackwalk would be pretty useless." > > So reporting the ticks_no_class_load value seems quite reasonable and > the clients of this interface should be expecting it. > > Thanks, > David > >> The change is to include forte.cpp in the minimal jvm but to >> conditionalize the code so that only AsyncGetCallTrace() >> is defined with the minimal jvm. >> >> Webrev is here: http://cr.openjdk.java.net/~jprovino/8013461/webrev.01 >> >> JDK-8013461 https://jbs.oracle.com/bugs/browse/JDK-8013461 >> There is a symbol AsyncGetCallTrace in libjvm.symbols that does not >> exist in >> minimal/libjvm.a when DEBUG_LEVEL == release >> >> joe >> >> On 05/21/2013 04:52 PM, JOSEPH PROVINO wrote: >>> >>> On 5/21/2013 4:00 PM, Oleg Mazurov wrote: >>>> Though formally not part of the Solaris Studio team any more here is >>>> my opinion based on my recollection of how I implemented interaction >>>> with the JVM via AsyncGetCallTrace. >>>> It's looked up using dlsym. If the symbol is not there Java callstack >>>> collection is shut down. I understand in your case even JVMTI is not >>>> there so the dlsym call will not be made. >>>> From that perspective there is no difference whether the symbol is >>>> present and returns an error code or not present at all. >>> >>> Oleg, then it sounds like what we have will work. >>> >>> Thanks for the quick reply. >>> >>> joe >>> >>>> >>>> -- Oleg >>>> >>>> On 5/21/2013 12:19 PM, JOSEPH PROVINO wrote: >>>>> >>>>> On 5/21/2013 3:16 PM, serguei.spitsyn at oracle.com wrote: >>>>>> On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: >>>>>>> >>>>>>> On 5/21/2013 2:23 PM, Staffan Larsen wrote: >>>>>>>> On 21 maj 2013, at 17:35, JOSEPH PROVINO >>>>>>>> wrote: >>>>>>>> >>>>>>>>> On 5/21/2013 3:06 AM, David Holmes wrote: >>>>>>>>>> Hi Staffan, >>>>>>>>>> >>>>>>>>>> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>>>>>>>>>> On 21 maj 2013, at 04:34, David Holmes >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Hi Joe, >>>>>>>>>>>> >>>>>>>>>>>> As I have previously stated you copied the struct definitions >>>>>>>>>>>> instead of moving them outside the ifdef. >>>>>>>>>>>> >>>>>>>>>>>> Serviceability folk: we are particularly interested in >>>>>>>>>>>> whether the use of ticks_no_class_load is deemed appropriate >>>>>>>>>>>> in this situation. Who will be consuming this value? >>>>>>>>>>> Since you have opted for the simple fix of having an exported >>>>>>>>>>> but non-functional AsyncGetCallTrace instead of actually >>>>>>>>>>> removing the symbol from the symbol files (which is the >>>>>>>>>>> proposed solution in the bug report), >>>>>>>>>> That would be a simpler solution semantically but the only way >>>>>>>>>> I can see to do that is to use a text replacement mechanism in >>>>>>>>>> the build files - as is done for the dynamic vtable symbols. I >>>>>>>>>> find that less appealing than simply exporting an interface >>>>>>>>>> that is configured to report an error (which is essentially >>>>>>>>>> what all the optional interfaces do under the minimal VM). >>>>>>>>>> >>>>>>>>>>> I would like you to include a comment about this in the >>>>>>>>>>> source. Right now it's very unclear why there is an exported >>>>>>>>>>> function that only returns an error. >>>>>>>>>>> >>>>>>>>>>> As to the appropriate return value, I don't know. The only >>>>>>>>>>> caller should be the Sun Studio profiler, >>>>>>> Does anyone know where to find instructions on how to run the >>>>>>> collector which would get the error return value? >>>>>>>>>>> and I'm not sure how it will handle this case if ever run. >>>>>>>>>>> The possible return values aren't very well documented. >>>>>>>>>> I guess we need to try and run it to find out. >>>>>>>>> Okay, do either of you feel strongly about how this should be >>>>>>>>> fixed -- return an error or remove the symbol? >>>>>>>> No, I don't feel strongly either way, but a comment in the code >>>>>>>> would be nice. >>>>>>> How much effort should I put into finding out what Sun Studio >>>>>>> profiler does when it gets -1? >>>>>> >>>>>> Let's ask the Solaris Studio guys directly. >>>>>> I'm adding Oleg to the mailing list. >>>>>> >>>>>> Oleg, >>>>>> >>>>>> Could you, please, share your view on this problem? >>>>> >>>>> In particular what will the Sun Studio Profiler collector do if it >>>>> gets the error >>>>> >>>>> trace->num_frames = ticks_no_class_load; // -1 >>>>> >>>>> Thanks. >>>>> >>>>> joe >>>>> >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> joe >>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> /Staffan >>>>>>>> >>>>>>>> >>>>>>>>> joe >>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> David >>>>>>>>>> >>>>>>>>>>> /Staffan >>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> David >>>>>>>>>>>> >>>>>>>>>>>> On 21/05/2013 5:10 AM, JOSEPH PROVINO wrote: >>>>>>>>>>>>> The change is to include forte.cpp in the minimal jvm but to >>>>>>>>>>>>> conditionalize the code so that >>>>>>>>>>>>> only AsyncGetCallTrace() is defined with the minimal jvm. >>>>>>>>>>>>> >>>>>>>>>>>>> Webrev is here: >>>>>>>>>>>>> http://cr.openjdk.java.net/~jprovino/8013461/webrev.00/ >>>>>>>>>>>>> >>>>>>>>>>>>> * JDK-8013461 >>>>>>>>>>>>> There is >>>>>>>>>>>>> a symbol AsyncGetCallTrace in libjvm.symbols that does >>>>>>>>>>>>> not exist in >>>>>>>>>>>>> minimal/libjvm.a when DEBUG_LEVEL == release >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks. >>>>>>>>>>>>> >>>>>>>>>>>>> joe >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> From chris.hegarty at oracle.com Thu May 23 10:36:06 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 23 May 2013 17:36:06 +0000 Subject: hg: jdk8/tl/jdk: 8014076: Arrays parallel and serial sorting improvements Message-ID: <20130523173631.03B9748CB0@hg.openjdk.java.net> Changeset: 3b23e3529ab3 Author: dl Date: 2013-05-23 18:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b23e3529ab3 8014076: Arrays parallel and serial sorting improvements Reviewed-by: chegar, mduigou ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/ArraysParallelSortHelpers.java ! src/share/classes/java/util/ComparableTimSort.java ! src/share/classes/java/util/DualPivotQuicksort.java ! src/share/classes/java/util/TimSort.java ! test/java/util/Arrays/ParallelSorting.java From christian.tornqvist at oracle.com Thu May 23 10:39:59 2013 From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com) Date: Thu, 23 May 2013 17:39:59 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8009576: Test returns ClassNotFoundException Message-ID: <20130523174002.12D8248CB2@hg.openjdk.java.net> Changeset: 699d9df07e59 Author: ctornqvi Date: 2013-05-23 17:39 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/699d9df07e59 8009576: Test returns ClassNotFoundException Summary: Small classpath fix and move tests into open Reviewed-by: mgerdin, zgu + test/runtime/Metaspace/FragmentMetaspace.java + test/runtime/Metaspace/FragmentMetaspaceSimple.java + test/runtime/Metaspace/classes/test/Empty.java + test/runtime/testlibrary/GeneratedClassLoader.java From serguei.spitsyn at oracle.com Thu May 23 16:19:00 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 23 May 2013 16:19:00 -0700 Subject: Review Request (S) 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes Message-ID: <519EA3E4.2040900@oracle.com> Please, review the fix for: bug: http://bugs.sun.com/view_bug.do?bug_id=8014288 jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ Summary: The fix of the 8008511 introduced a performance regression for the Nashorn tests. The fix is to use method_idnum() for direct indexing into the MemberNameTable that replaces a linear search caused the regression. No new regression test is needed as the Nashorn tests show the performance is back to normal. Testing: The vm/mlvm and Nashorn tests Thanks, Serguei From christian.thalinger at oracle.com Thu May 23 16:50:07 2013 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Thu, 23 May 2013 16:50:07 -0700 Subject: Review Request (S) 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes In-Reply-To: <519EA3E4.2040900@oracle.com> References: <519EA3E4.2040900@oracle.com> Message-ID: <6AB83B9C-5C47-4A67-AF71-5187A6AA2EBA@oracle.com> Looks good. -- Chris On May 23, 2013, at 4:19 PM, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8014288 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ > > Summary: > The fix of the 8008511 introduced a performance regression for the Nashorn tests. > The fix is to use method_idnum() for direct indexing into the MemberNameTable > that replaces a linear search caused the regression. > No new regression test is needed as the Nashorn tests show the performance is back to normal. > > Testing: > The vm/mlvm and Nashorn tests > > Thanks, > Serguei From vladimir.kozlov at oracle.com Thu May 23 16:56:42 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 23 May 2013 16:56:42 -0700 Subject: Review Request (S) 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes In-Reply-To: <519EA3E4.2040900@oracle.com> References: <519EA3E4.2040900@oracle.com> Message-ID: <519EACBA.4050508@oracle.com> This is good. thanks, Vladimir On 5/23/13 4:19 PM, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8014288 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ > > > Summary: > The fix of the 8008511 introduced a performance regression for the > Nashorn tests. > The fix is to use method_idnum() for direct indexing into the > MemberNameTable > that replaces a linear search caused the regression. > No new regression test is needed as the Nashorn tests show the > performance is back to normal. > > Testing: > The vm/mlvm and Nashorn tests > > Thanks, > Serguei From serguei.spitsyn at oracle.com Thu May 23 17:04:13 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 23 May 2013 17:04:13 -0700 Subject: Review Request (S) 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes In-Reply-To: <519EACBA.4050508@oracle.com> References: <519EA3E4.2040900@oracle.com> <519EACBA.4050508@oracle.com> Message-ID: <519EAE7D.4010304@oracle.com> Vladimir and Christian, Thank you for the reviews, Serguei On 5/23/13 4:56 PM, Vladimir Kozlov wrote: > This is good. > > thanks, > Vladimir > > On 5/23/13 4:19 PM, serguei.spitsyn at oracle.com wrote: >> Please, review the fix for: >> bug: http://bugs.sun.com/view_bug.do?bug_id=8014288 >> jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ >> >> >> >> Summary: >> The fix of the 8008511 introduced a performance regression for the >> Nashorn tests. >> The fix is to use method_idnum() for direct indexing into the >> MemberNameTable >> that replaces a linear search caused the regression. >> No new regression test is needed as the Nashorn tests show the >> performance is back to normal. >> >> Testing: >> The vm/mlvm and Nashorn tests >> >> Thanks, >> Serguei From david.holmes at oracle.com Thu May 23 17:15:33 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 24 May 2013 10:15:33 +1000 Subject: Review Request (S) 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes In-Reply-To: <519EA3E4.2040900@oracle.com> References: <519EA3E4.2040900@oracle.com> Message-ID: <519EB125.5090007@oracle.com> Hi Serguei, I have two queries: In MemberNameTable::add_member_name why do you not have assert_locked_or_safepoint(MemberNameTable_lock) ? In MethodHandles::init_field_MemberName you deleted: 304 InstanceKlass::cast(field_holder())->add_member_name(mname); apart from this seeming to be unrelated to the rest of the fix, does its removal make the previous 8 lines of comment unnecessary? (I confess I don't understand the relationship between the comment and the code anyway.) Thanks, David On 24/05/2013 9:19 AM, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8014288 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ > > > Summary: > The fix of the 8008511 introduced a performance regression for the > Nashorn tests. > The fix is to use method_idnum() for direct indexing into the > MemberNameTable > that replaces a linear search caused the regression. > No new regression test is needed as the Nashorn tests show the > performance is back to normal. > > Testing: > The vm/mlvm and Nashorn tests > > Thanks, > Serguei From serguei.spitsyn at oracle.com Thu May 23 17:37:19 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 23 May 2013 17:37:19 -0700 Subject: Review Request (S) 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes In-Reply-To: <519EB125.5090007@oracle.com> References: <519EA3E4.2040900@oracle.com> <519EB125.5090007@oracle.com> Message-ID: <519EB63F.3050403@oracle.com> Hi David, On 5/23/13 5:15 PM, David Holmes wrote: > Hi Serguei, > > I have two queries: > > In MemberNameTable::add_member_name why do you not have > assert_locked_or_safepoint(MemberNameTable_lock) ? Nice catch, thanks. It has to be there but I accidentally removed it. Will fix it. > > In MethodHandles::init_field_MemberName you deleted: > > 304 InstanceKlass::cast(field_holder())->add_member_name(mname); > > apart from this seeming to be unrelated to the rest of the fix, does > its removal make the previous 8 lines of comment unnecessary? (I > confess I don't understand the relationship between the comment and > the code anyway.) It is not related to the removed line. I think, it is for the return value. The line was removed because we decided to skip caching the field MemberName's for now as they are not used yet. Thanks, Serguei > > Thanks, > David > > On 24/05/2013 9:19 AM, serguei.spitsyn at oracle.com wrote: >> Please, review the fix for: >> bug: http://bugs.sun.com/view_bug.do?bug_id=8014288 >> jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014288-JVMTI-JSR292.1/ >> >> >> >> Summary: >> The fix of the 8008511 introduced a performance regression for the >> Nashorn tests. >> The fix is to use method_idnum() for direct indexing into the >> MemberNameTable >> that replaces a linear search caused the regression. >> No new regression test is needed as the Nashorn tests show the >> performance is back to normal. >> >> Testing: >> The vm/mlvm and Nashorn tests >> >> Thanks, >> Serguei From john.coomes at oracle.com Thu May 23 22:55:51 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 24 May 2013 05:55:51 +0000 Subject: hg: hsx/hotspot-rt/jaxp: 8 new changesets Message-ID: <20130524055617.04CBA48CFC@hg.openjdk.java.net> Changeset: 452e1a182907 Author: dfuchs Date: 2013-05-06 18:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/452e1a182907 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb ! src/com/sun/org/apache/xml/internal/serializer/Encodings.java Changeset: 1e8d98012ab8 Author: joehw Date: 2013-05-08 23:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/1e8d98012ab8 8011653: Upgrade JDK8 to JAXP 1.5 Reviewed-by: alanb, dfuchs ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java ! src/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java ! src/com/sun/xml/internal/stream/StaxXMLInputSource.java ! src/javax/xml/XMLConstants.java ! src/javax/xml/parsers/DocumentBuilderFactory.java ! src/javax/xml/parsers/SAXParser.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/transform/TransformerFactory.java ! src/javax/xml/validation/SchemaFactory.java ! src/javax/xml/validation/Validator.java Changeset: 6976616f5753 Author: lana Date: 2013-05-08 22:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6976616f5753 Merge Changeset: 9e4dfe933ba9 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/9e4dfe933ba9 Merge Changeset: a229726149b4 Author: joehw Date: 2013-05-10 09:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/a229726149b4 8014333: javadoc error in JAXP 1.5 patch Reviewed-by: lancea ! src/javax/xml/stream/XMLInputFactory.java Changeset: 6443f5627744 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6443f5627744 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw ! src/com/sun/org/apache/bcel/internal/generic/BasicType.java ! src/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java ! src/com/sun/org/apache/bcel/internal/generic/CodeExceptionGen.java ! src/com/sun/org/apache/bcel/internal/generic/LineNumberGen.java ! src/com/sun/org/apache/bcel/internal/generic/LocalVariableGen.java ! src/com/sun/org/apache/bcel/internal/generic/ReturnaddressType.java ! src/com/sun/org/apache/bcel/internal/generic/Select.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRefBase.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/AbstractDateTimeDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/DecimalDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/PrecisionDecimalDV.java ! src/com/sun/org/apache/xerces/internal/util/URI.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java ! src/com/sun/org/apache/xml/internal/serializer/utils/URI.java ! src/com/sun/org/apache/xml/internal/utils/URI.java ! src/com/sun/org/apache/xpath/internal/Arg.java Changeset: e3065fb07877 Author: lana Date: 2013-05-17 10:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/e3065fb07877 Merge Changeset: 827b59af45f3 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/827b59af45f3 Added tag jdk8-b91 for changeset e3065fb07877 ! .hgtags From john.coomes at oracle.com Thu May 23 22:55:39 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 24 May 2013 05:55:39 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b91 for changeset 8f7ffb296385 Message-ID: <20130524055542.49BFC48CFB@hg.openjdk.java.net> Changeset: 717aa26f8e0a Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/717aa26f8e0a Added tag jdk8-b91 for changeset 8f7ffb296385 ! .hgtags From john.coomes at oracle.com Thu May 23 22:56:21 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 24 May 2013 05:56:21 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b91 for changeset 0bb1a9fa56b0 Message-ID: <20130524055629.16F2948CFD@hg.openjdk.java.net> Changeset: a0f604766ca1 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/a0f604766ca1 Added tag jdk8-b91 for changeset 0bb1a9fa56b0 ! .hgtags From john.coomes at oracle.com Thu May 23 22:55:35 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 24 May 2013 05:55:35 +0000 Subject: hg: hsx/hotspot-rt: 7 new changesets Message-ID: <20130524055536.867F148CFA@hg.openjdk.java.net> Changeset: e2eb6bc06621 Author: mduigou Date: 2013-05-08 21:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e2eb6bc06621 8014269: Add missing .PHONY targets to Main.gmk Reviewed-by: mchung, tbell ! common/makefiles/Main.gmk Changeset: 49ea9293fa49 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/49ea9293fa49 Merge Changeset: 40bba0507f76 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/40bba0507f76 Merge Changeset: eea249c1ecee Author: erikj Date: 2013-05-21 13:18 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/eea249c1ecee 8014508: Fix log levels in make Reviewed-by: tbell ! NewMakefile.gmk ! common/autoconf/spec.gmk.in Changeset: e83abb0a04ab Author: katleman Date: 2013-05-21 12:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e83abb0a04ab Merge Changeset: cb51fb4789ac Author: andrew Date: 2013-05-22 13:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/cb51fb4789ac 8015087: Provide debugging information for programs Summary: Enable debugging info on programs in OpenJDK builds Reviewed-by: erikj ! common/makefiles/NativeCompilation.gmk Changeset: f089df41bff5 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/f089df41bff5 Added tag jdk8-b91 for changeset cb51fb4789ac ! .hgtags From john.coomes at oracle.com Thu May 23 22:59:51 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 24 May 2013 05:59:51 +0000 Subject: hg: hsx/hotspot-rt/jdk: 106 new changesets Message-ID: <20130524062224.2E26348CFE@hg.openjdk.java.net> Changeset: 4dd6f7bb8bbd Author: simonis Date: 2013-05-06 12:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4dd6f7bb8bbd 7191872: Xrender: No text displayed using 64 bit JDK on solaris11-sparc Reviewed-by: prr, ceisserer ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/GlyphList.java ! src/solaris/classes/sun/font/XRGlyphCacheEntry.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 23f7ff502a89 Author: jgodinez Date: 2013-05-07 09:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/23f7ff502a89 8011069: Printing: NullPointerException since jdk8 b82 showing native Page Setup Dialog. Reviewed-by: bae, prr ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 8a995d335d59 Author: lana Date: 2013-05-09 19:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a995d335d59 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 103f492d8ce7 Author: vadim Date: 2013-05-17 17:19 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/103f492d8ce7 4892259: GIF ImageReader does not call passComplete in IIOReadUpdateListener Reviewed-by: prr, bae ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java + test/javax/imageio/plugins/gif/GIFPassListenerTest.java Changeset: 4ee85e865a83 Author: vadim Date: 2013-05-17 14:18 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4ee85e865a83 8000936: Enable Java2D D3D pipeline on newer Intel chipsets : Intel HD and later Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 51f5e544c88b Author: lana Date: 2013-05-17 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/51f5e544c88b Merge Changeset: 90b67c9a7eb2 Author: serb Date: 2013-05-06 16:23 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/90b67c9a7eb2 7161575: [macosx] On MacOSX port java.awt.Toolkit.is/setDynamicLayout() are not consistent Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWToolkit.java Changeset: 7982299cd11c Author: serb Date: 2013-05-08 15:58 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7982299cd11c 8013841: [macosx] Animations not disabled for CALayers used via JAWT Reviewed-by: anthony, alexsch ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: 5fe0a4da863d Author: lana Date: 2013-05-09 18:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5fe0a4da863d Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: a466a4192fea Author: pchelko Date: 2013-05-14 16:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a466a4192fea 8002045: Auto failed and threw exception:java.lang.UnsatisfiedLinkError: Reviewed-by: serb, anthony ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-bsd ! make/sun/awt/mapfile-vers-linux ! makefiles/mapfiles/libawt/mapfile-vers ! makefiles/mapfiles/libawt/mapfile-vers-linux Changeset: b1a7cc79f13d Author: serb Date: 2013-05-14 17:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b1a7cc79f13d 8014423: [macosx] The scrollbar's block increment performs incorrectly Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java Changeset: 722ee3129ce0 Author: ant Date: 2013-05-15 16:49 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/722ee3129ce0 8014227: JLightweightFrame needs another synchronization policy Reviewed-by: art ! src/share/classes/sun/swing/JLightweightFrame.java Changeset: 7a8a8e31a126 Author: pchelko Date: 2013-05-17 11:02 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7a8a8e31a126 7079254: Toolkit eventListener leaks memory Reviewed-by: serb, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java + test/java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java Changeset: e944b78812a8 Author: kshefov Date: 2013-05-17 14:08 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e944b78812a8 8014721: TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException Reviewed-by: anthony, serb ! test/java/awt/TrayIcon/DragEventSource/DragEventSource.java Changeset: 281add053efe Author: kshefov Date: 2013-05-17 14:11 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/281add053efe 8013426: TEST_BUG: java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java fails with "RuntimeException: The data should be available" on Linux Reviewed-by: anthony, serb ! test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java Changeset: 49871f1581b8 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/49871f1581b8 Merge Changeset: 167d2dcaeeee Author: ksrini Date: 2013-05-01 15:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/167d2dcaeeee 8013225: Refresh jdk's private ASM to the latest. Reviewed-by: mduigou, sundar ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java ! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Context.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handler.java ! src/share/classes/jdk/internal/org/objectweb/asm/Item.java ! src/share/classes/jdk/internal/org/objectweb/asm/Label.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java ! src/share/classes/jdk/internal/org/objectweb/asm/Type.java + src/share/classes/jdk/internal/org/objectweb/asm/TypePath.java + src/share/classes/jdk/internal/org/objectweb/asm/TypeReference.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/ParameterNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/version.txt Changeset: 5045eb04a579 Author: mduigou Date: 2013-05-02 09:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5045eb04a579 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile Reviewed-by: mduigou, henryjen, alanb, martin, psandoz Contributed-by: akhil.arora at oracle.com, brian.goetz at oracle.com ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/zip/ZipFile.java + test/java/util/BitSet/BitSetStreamTest.java + test/java/util/Random/RandomStreamTest.java + test/java/util/zip/ZipFile/StreamZipEntriesTest.java Changeset: a6ff4a823164 Author: kizune Date: 2013-05-02 21:23 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a6ff4a823164 8013155: [pack200] improve performance of pack200 Reviewed-by: ksrini, jrose ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java Changeset: 3062bf908281 Author: khazra Date: 2013-05-02 14:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3062bf908281 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name Summary: Remove buffer overruns in native code Reviewed-by: alanb, chegar ! src/solaris/native/java/net/NetworkInterface.c Changeset: 81be41c7323f Author: weijun Date: 2013-05-03 10:43 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/81be41c7323f 8013855: DigestMD5Client has not checked RealmChoiceCallback value Reviewed-by: xuelei, mullan ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java + test/com/sun/security/sasl/digest/AuthRealmChoices.java Changeset: 470f19b6bfdd Author: jbachorik Date: 2013-05-02 13:21 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/470f19b6bfdd 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification Summary: RemoteServer.getClientHost is returning a String with an IPv6 literal address and we need to enclose it in [] when building the connection id Reviewed-by: alanb, sjiang ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! test/javax/management/remote/mandatory/connection/ConnectionTest.java Changeset: fc156b925259 Author: mduigou Date: 2013-05-03 10:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fc156b925259 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Reviewed-by: martin, alanb, chegar, plevart ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java + test/sun/misc/JavaLangAccess/NewUnsafeString.java Changeset: d7f3d5659c46 Author: juh Date: 2013-05-03 15:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d7f3d5659c46 8005922: TEST_BUG: There is no /tmp directory for windows system. Reviewed-by: weijun ! test/sun/security/tools/policytool/ChangeUI.html ! test/sun/security/tools/policytool/UpdatePermissions.html ! test/sun/security/tools/policytool/i18n.html Changeset: d8f01bfb1da4 Author: dwanvik Date: 2013-05-06 05:51 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d8f01bfb1da4 8013403: Update JDK8 with Java DB 10.10.1.1. Summary: Drop Java DB 10.10.1.1 bits into JDK 8 and update image builds Reviewed-by: tbell ! make/common/Release.gmk ! makefiles/CompileDemos.gmk ! makefiles/Images.gmk Changeset: 398fe07f530f Author: dwanvik Date: 2013-05-06 06:05 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/398fe07f530f Merge - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: bd118033e44c Author: dxu Date: 2013-05-06 14:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bd118033e44c 8003992: File and other classes in java.io do not handle embedded nulls properly Summary: Have every file operation done with File, FileInputStream, FileOutputStream, or RandomAccessFile that involves a file path containing NUL fail. Also reviewed by fweimer at redhat.com Reviewed-by: alanb, sherman, ahgross, mduigou, dholmes, aph, plevart, martin ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java + test/java/io/File/NulFile.java Changeset: e13cf31e5a96 Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e13cf31e5a96 8013712: Add Objects.nonNull and Objects.isNull Reviewed-by: mchung, darcy ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: 3cbb65d9af9e Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3cbb65d9af9e 8013150: Iterator.remove and forEachRemaining relationship not specified Reviewed-by: mduigou Contributed-by: Akhil Arora ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Vector.java + test/java/util/Iterator/IteratorDefaults.java Changeset: 8221c421490f Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8221c421490f 8003258: BufferedReader.lines() Reviewed-by: alanb, mduigou, psandoz Contributed-by: Brian Goetz , Henry Jen ! src/share/classes/java/io/BufferedReader.java + src/share/classes/java/io/UncheckedIOException.java + test/java/io/BufferedReader/Lines.java Changeset: b4a013f4eff4 Author: sherman Date: 2013-05-06 21:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b4a013f4eff4 8013252: Regex Matcher .start and .end should be accessible by group name 8013254: Constructor \w need update to add the support of \p{Join_Control} Summary: added the requested methods and updated the \w constructor Reviewed-by: mchung, alanb ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/regex/UnicodeProp.java ! test/java/util/regex/POSIX_Unicode.java ! test/java/util/regex/RegExTest.java Changeset: 814dcc08df52 Author: weijun Date: 2013-05-07 12:30 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/814dcc08df52 8010192: Enable native JGSS provider on Mac Reviewed-by: valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/native/sun/security/jgss/wrapper/gssapi.h ! test/sun/security/krb5/runNameEquals.sh Changeset: 9c9b2385c1b0 Author: jfranck Date: 2013-05-07 09:52 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9c9b2385c1b0 8013541: Revise javadoc for Executable.getAnnotatedReturnType() Reviewed-by: abuckley, darcy ! src/share/classes/java/lang/reflect/Executable.java Changeset: 2602eab5f086 Author: dfuchs Date: 2013-05-07 11:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2602eab5f086 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb + test/javax/xml/jaxp/Encodings/CheckEncodingPropertiesFile.java Changeset: 7b40394ad944 Author: sla Date: 2013-05-07 19:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7b40394ad944 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1 7181907: TEST_BUG: j/l/management/MemoryMXBean/ResetPeakMemoryUsage fails with NegativeArraySizeException 7148492: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java failing since update to hs23-b15 or b16 Reviewed-by: mchung, brutisso ! test/ProblemList.txt ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java Changeset: 100027950b05 Author: sla Date: 2013-05-07 20:00 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/100027950b05 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Reviewed-by: alanb, dsamersoff ! test/sun/tools/jinfo/Basic.sh Changeset: e30396e22c6f Author: naoto Date: 2013-05-07 11:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e30396e22c6f 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: fe4e9bc2186f Author: mduigou Date: 2013-05-07 12:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fe4e9bc2186f 4802647: Throw required NPEs from removeAll()/retainAll() Reviewed-by: mduigou, chegar, dholmes Contributed-by: Brandon Passanisi ! src/share/classes/java/util/AbstractCollection.java ! src/share/classes/java/util/AbstractSet.java ! src/share/classes/java/util/ArrayList.java ! test/java/util/Collection/MOAT.java Changeset: 6feee75b0a8b Author: briangoetz Date: 2013-05-06 11:43 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6feee75b0a8b 8012664: Add tests for java.util.stream and lambda translation Reviewed-by: mduigou, briangoetz Contributed-by: Brian Goetz , Paul Sandoz , Mike Duigou , Robert Field , Jim Gish ! test/Makefile + test/java/util/concurrent/atomic/AtomicReferenceTest.java + test/java/util/stream/bootlib/TEST.properties + test/java/util/stream/bootlib/java/util/stream/CollectorOps.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/FlagDeclaringOp.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/IntermediateTestOp.java + test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/OpTestCase.java + test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StatefulTestOp.java + test/java/util/stream/bootlib/java/util/stream/StatelessTestOp.java + test/java/util/stream/bootlib/java/util/stream/StreamOpFlagTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/TestData.java + test/java/util/stream/bootlib/java/util/stream/TestFlagExpectedOp.java + test/java/util/stream/boottest/TEST.properties + test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java + test/java/util/stream/boottest/java/util/stream/FlagOpTest.java + test/java/util/stream/boottest/java/util/stream/IntNodeTest.java + test/java/util/stream/boottest/java/util/stream/LongNodeTest.java + test/java/util/stream/boottest/java/util/stream/NodeBuilderTest.java + test/java/util/stream/boottest/java/util/stream/NodeTest.java + test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java + test/java/util/stream/boottest/java/util/stream/StreamFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamOpFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamReuseTest.java + test/java/util/stream/boottest/java/util/stream/UnorderedTest.java + test/java/util/stream/test/TEST.properties + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/DeserializeMethodTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/MHProxiesTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/NullArgsTestCase.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/CollectionAndMapModifyStreamTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DoublePrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FilterOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindAnyOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindFirstOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntUniqOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/LongPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MinMaxTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveAverageOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveSumTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamParSeqTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SummaryStatisticsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TeeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java + test/jdk/lambda/ArrayCtorRefTest.java + test/jdk/lambda/FDTest.java + test/jdk/lambda/LambdaTranslationCompoundSamTest.java + test/jdk/lambda/LambdaTranslationInInterface.java + test/jdk/lambda/LambdaTranslationInnerConstructor.java + test/jdk/lambda/LambdaTranslationTest1.java + test/jdk/lambda/LambdaTranslationTest2.java + test/jdk/lambda/MethodReferenceTestFDCCE.java + test/jdk/lambda/MethodReferenceTestInnerDefault.java + test/jdk/lambda/MethodReferenceTestInnerInstance.java + test/jdk/lambda/MethodReferenceTestInnerVarArgsThis.java + test/jdk/lambda/MethodReferenceTestInstance.java + test/jdk/lambda/MethodReferenceTestInstanceMethod.java + test/jdk/lambda/MethodReferenceTestKinds.java + test/jdk/lambda/MethodReferenceTestNew.java + test/jdk/lambda/MethodReferenceTestNewInner.java + test/jdk/lambda/MethodReferenceTestSueCase1.java + test/jdk/lambda/MethodReferenceTestSueCase2.java + test/jdk/lambda/MethodReferenceTestSueCase4.java + test/jdk/lambda/MethodReferenceTestSuper.java + test/jdk/lambda/MethodReferenceTestSuperDefault.java + test/jdk/lambda/MethodReferenceTestTypeConversion.java + test/jdk/lambda/MethodReferenceTestVarArgs.java + test/jdk/lambda/MethodReferenceTestVarArgsExt.java + test/jdk/lambda/MethodReferenceTestVarArgsSuper.java + test/jdk/lambda/MethodReferenceTestVarArgsSuperDefault.java + test/jdk/lambda/MethodReferenceTestVarArgsThis.java + test/jdk/lambda/TEST.properties + test/jdk/lambda/TestInnerCtorRef.java + test/jdk/lambda/TestPrivateCtorRef.java + test/jdk/lambda/separate/AttributeInjector.java + test/jdk/lambda/separate/ClassFile.java + test/jdk/lambda/separate/ClassFilePreprocessor.java + test/jdk/lambda/separate/ClassToInterfaceConverter.java + test/jdk/lambda/separate/Compiler.java + test/jdk/lambda/separate/DirectedClassLoader.java + test/jdk/lambda/separate/SourceModel.java + test/jdk/lambda/separate/TestHarness.java + test/jdk/lambda/shapegen/ClassCase.java + test/jdk/lambda/shapegen/Hierarchy.java + test/jdk/lambda/shapegen/HierarchyGenerator.java + test/jdk/lambda/shapegen/Rule.java + test/jdk/lambda/shapegen/RuleGroup.java + test/jdk/lambda/shapegen/TTNode.java + test/jdk/lambda/shapegen/TTParser.java + test/jdk/lambda/shapegen/TTShape.java + test/jdk/lambda/vm/DefaultMethodRegressionTests.java + test/jdk/lambda/vm/DefaultMethodsTest.java + test/jdk/lambda/vm/InterfaceAccessFlagsTest.java + test/jdk/lambda/vm/StrictfpDefault.java Changeset: 7d89b0dd973c Author: weijun Date: 2013-05-08 08:25 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7d89b0dd973c 8012679: Let allow_weak_crypto default to false Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! test/sun/security/krb5/auto/DupEtypes.java ! test/sun/security/krb5/etype/WeakCrypto.java Changeset: c8f47674d105 Author: alanb Date: 2013-05-08 18:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c8f47674d105 8013652: (profiles) Add javax.script to compact1 Reviewed-by: mchung, dholmes ! makefiles/profile-rtjar-includes.txt Changeset: 3fd83f282c61 Author: ksrini Date: 2013-05-07 13:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3fd83f282c61 8013736: [launcher] cleanup code for correctness 8005735: [parfait] False positive integer overflow in jdk/src/solaris/bin/jexec.c 8009873: [parfait] Memory leak at jdk/src/share/bin/wildcard.c 8005807: [parfait] Undefined return value at jdk/src/share/bin/java.c Reviewed-by: alanb, martin ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/wildcard.c ! src/solaris/bin/jexec.c Changeset: bb9cdfac1a7d Author: juh Date: 2013-05-09 12:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bb9cdfac1a7d 8007699: Move some tests from test/sun/security/provider/certpath/X509CertPath to closed repo Reviewed-by: mullan - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 498ea4c3a4c6 Author: psandoz Date: 2013-05-01 18:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/498ea4c3a4c6 8012646: Pattern.splitAsStream Reviewed-by: forax, plevart, alanb Contributed-by: Ben Evans , Paul Sandoz ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 573a593379cb Author: lana Date: 2013-05-08 23:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/573a593379cb Merge ! makefiles/CompileNativeLibraries.gmk ! makefiles/Images.gmk - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: 2023e3d573eb Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2023e3d573eb Merge - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: ba74cd79e4f6 Author: jfranck Date: 2013-05-10 10:20 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ba74cd79e4f6 8007073: Implement Core Reflection for Type Annotations on parameters Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java ! test/java/lang/annotation/TypeAnnotationReflection.java Changeset: 09a3b08c986f Author: alanb Date: 2013-05-10 14:53 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/09a3b08c986f 8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248 characters long Reviewed-by: khazra, chegar ! src/windows/classes/sun/nio/fs/WindowsFileCopy.java ! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java ! src/windows/classes/sun/nio/fs/WindowsPath.java + test/java/nio/file/Files/NameLimits.java Changeset: ece61e21782d Author: darcy Date: 2013-05-10 08:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ece61e21782d 8014249: Add Modifer.parameterModifiers() Reviewed-by: mduigou, mchung ! src/share/classes/java/lang/reflect/Modifier.java Changeset: c26e0d29249a Author: rriggs Date: 2013-05-10 09:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c26e0d29249a 8014296: DivModTests should not compare pointers Reviewed-by: darcy ! test/java/lang/Math/DivModTests.java Changeset: 2490769abdfa Author: mduigou Date: 2013-05-10 09:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2490769abdfa 8014316: Use Method Refs in j.u.stream.MatchOps Reviewed-by: dholmes ! src/share/classes/java/util/stream/MatchOps.java Changeset: 9891e4d7d5b3 Author: mduigou Date: 2013-05-10 10:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9891e4d7d5b3 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: f84b5498b2bb Author: darcy Date: 2013-05-10 12:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f84b5498b2bb 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.* Reviewed-by: mchung ! src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java Changeset: 90f715cceaae Author: dmeetry Date: 2013-05-10 23:56 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/90f715cceaae 7021870: GzipInputStream closes underlying stream during reading Reviewed-by: mduigou Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/java/util/zip/GZIPInputStream.java + test/java/util/zip/GZIP/GZIPInZip.java Changeset: 76998d11a643 Author: xuelei Date: 2013-05-13 05:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/76998d11a643 8005535: SSLSessionImpl should have protected finalize() Reviewed-by: weijun, wetmore ! src/share/classes/sun/security/ssl/SSLSessionImpl.java Changeset: 46db0e633240 Author: xuelei Date: 2013-05-13 06:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/46db0e633240 8005598: (reopened) Need to clone array of input/output parameters Reviewed-by: weijun ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: 536678dffa97 Author: sundar Date: 2013-05-13 22:23 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/536678dffa97 8012975: Remove rhino from jdk8 Reviewed-by: alanb, tbell ! make/com/sun/Makefile - make/com/sun/script/Makefile ! make/sun/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile ! make/tools/src/build/tools/deps/refs.allowed ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/profile-rtjar-includes.txt - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java Changeset: 6175fe5b07aa Author: bharadwaj Date: 2013-05-13 12:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6175fe5b07aa 8008687: MethodHandle code: allow static and invokespecial calls to interface methods Summary: Changes to support invocation of lambda methods compiled either as static interface methods and or private instance methods. Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/MemberName.java Changeset: f7fcfb204a69 Author: mduigou Date: 2013-05-13 13:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f7fcfb204a69 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java Changeset: 86c1e8c799f5 Author: khazra Date: 2013-05-13 13:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/86c1e8c799f5 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive Summary: Rearrange event-handling code to remove bottle-neck. Also reviewed by mhall at mhcomputing.net. Reviewed-by: chegar, alanb ! src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: ae35fdbab949 Author: sherman Date: 2013-05-13 20:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ae35fdbab949 8013386: (tz) Support tzdata2013c Summary: updated tz data to version 2013c Reviewed-by: peytoia, okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/Rule.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/zone.tab Changeset: a50bad038f31 Author: darcy Date: 2013-05-13 22:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a50bad038f31 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: mduigou ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: b315cb9a7544 Author: alanb Date: 2013-05-14 14:32 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b315cb9a7544 8014500: bootcycle-images fails after upgrade to JAXP 1.5 Reviewed-by: lancea ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java Changeset: 5ea5f5dfb96a Author: uta Date: 2013-05-14 20:16 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5ea5f5dfb96a 8012453: (process) Runtime.exec(String) fails if command contains spaces [win] Reviewed-by: alanb ! src/share/classes/java/lang/ProcessBuilder.java ! src/windows/classes/java/lang/ProcessImpl.java + test/java/lang/Runtime/exec/ExecCommand.java Changeset: e0135f1a8627 Author: sundar Date: 2013-05-14 22:36 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e0135f1a8627 8014519: scriptpad sample does not work with nashorn Reviewed-by: attila, jlaskey Contributed-by: rieberandreas at gmail.com ! src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java ! src/share/sample/scripting/scriptpad/src/resources/Main.js ! src/share/sample/scripting/scriptpad/src/resources/conc.js ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/share/sample/scripting/scriptpad/src/resources/mm.js ! src/share/sample/scripting/scriptpad/src/resources/scriptpad.js ! src/share/sample/scripting/scriptpad/src/scripts/browse.js ! src/share/sample/scripting/scriptpad/src/scripts/insertfile.js ! src/share/sample/scripting/scriptpad/src/scripts/linewrap.js ! src/share/sample/scripting/scriptpad/src/scripts/mail.js ! src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.sh ! src/share/sample/scripting/scriptpad/src/scripts/textcolor.js Changeset: 790d292ee761 Author: khazra Date: 2013-05-14 12:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/790d292ee761 6328537: Improve javadocs for Socket class by adding references to SocketOptions Summary: Insert references to SocketOptions.java where applicable Reviewed-by: alanb, chegar ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java Changeset: 08ef70f60e0d Author: sherman Date: 2013-05-14 14:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/08ef70f60e0d 8012326: Deadlock occurs when Charset.availableCharsets() is called by several threads at the same time Summary: removed the race condition risk from ExtendedCahrset access code Reviewed-by: mchung, alanb ! make/sun/nio/cs/Makefile ! makefiles/CreateJars.gmk ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/cs/ext/ISO2022_JP_2.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider ! src/share/classes/sun/nio/cs/ext/MSISO2022JP.java Changeset: c70fff3db913 Author: sherman Date: 2013-05-14 14:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c70fff3db913 8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit Summary: to throw IOE for malformed final unit in base64 stream Reviewed-by: chegar, alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: a3d79a4c2a24 Author: dholmes Date: 2013-05-15 00:36 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a3d79a4c2a24 8013395: StringBuffer.toString performance regression impacting embedded benchmarks Summary: cache a copy of the char[] to use with toString() and clear it when ever the sb content is modified Reviewed-by: alanb, plevart, mduigou, forax ! src/share/classes/java/lang/StringBuffer.java + test/java/lang/StringBuffer/ToStringCache.java Changeset: 93a268759ec3 Author: michaelm Date: 2013-05-15 15:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/93a268759ec3 8010464: Evolve java networking same origin policy Reviewed-by: alanb, chegar, dsamersoff, weijun ! src/share/classes/java/net/HttpURLConnection.java + src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/HttpURLPermission/HttpURLPermissionTest.java + test/java/net/HttpURLPermission/URLTest.java + test/java/net/HttpURLPermission/policy.1 + test/java/net/HttpURLPermission/policy.2 + test/java/net/HttpURLPermission/policy.3 Changeset: ef04044f77d2 Author: sherman Date: 2013-05-15 07:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ef04044f77d2 8013730: JSR 310 DateTime API Updates III Summary: Integration of JSR310 Date/Time API update III Reviewed-by: naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/HijrahEra.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/JapaneseEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/MinguoEra.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistEra.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/DecimalStyle.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/format/ResolverStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/UnsupportedTemporalTypeException.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKChronologySerialization.java ! test/java/time/tck/java/time/chrono/TCKHijrahChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java + test/java/time/tck/java/time/format/TCKDecimalStyle.java + test/java/time/tck/java/time/format/TCKInstantPrinterParser.java ! test/java/time/tck/java/time/format/TCKTextStyle.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/test/java/time/chrono/TestChronologyPerf.java ! test/java/time/test/java/time/chrono/TestExampleCode.java + test/java/time/test/java/time/chrono/TestJapaneseChronology.java ! test/java/time/test/java/time/format/AbstractTestPrinterParser.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java ! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java + test/java/time/test/java/time/format/TestDecimalStyle.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java Changeset: bad8f5237f10 Author: darcy Date: 2013-05-15 09:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bad8f5237f10 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier) Reviewed-by: alanb ! src/share/classes/java/util/Objects.java Changeset: 3d9f25dc630c Author: naoto Date: 2013-05-15 16:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3d9f25dc630c 8013233: java/util/Locale/LocaleProviders.sh fails Reviewed-by: okutsu ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: 2ec31660cc0e Author: valeriep Date: 2013-05-07 14:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2ec31660cc0e 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps should be protected Summary: Change the finalize method of PKCS11 class to be protected. Reviewed-by: xuelei ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java Changeset: 991420add35d Author: valeriep Date: 2013-05-07 14:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/991420add35d 7196009: SunPkcs11 provider fails to parse config path containing parenthesis Summary: Enhanced to allow quoted string as library path values. Reviewed-by: weijun ! src/share/classes/sun/security/pkcs11/Config.java ! test/sun/security/pkcs11/Provider/ConfigShortPath.java + test/sun/security/pkcs11/Provider/cspQuotedPath.cfg Changeset: 804da1e9bd04 Author: ascarpino Date: 2013-05-07 14:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/804da1e9bd04 8001284: Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR Summary: Changed output length calculation to include incomplete blocks for CTR mode. Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! test/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java Changeset: fc70416beef3 Author: valeriep Date: 2013-05-13 16:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fc70416beef3 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 59357ea7f131 Author: valeriep Date: 2013-05-15 18:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/59357ea7f131 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java Changeset: bb01cc14223c Author: ewang Date: 2013-05-16 10:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bb01cc14223c 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up Reviewed-by: alanb, dholmes, chegar ! test/java/lang/Thread/GenerifyStackTraces.java - test/java/lang/Thread/StackTraces.java Changeset: b198389f9da4 Author: xuelei Date: 2013-05-16 04:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b198389f9da4 8010814: More buffers are stored or returned without cloning Reviewed-by: lancea ! src/share/classes/com/sun/jndi/ldap/BerDecoder.java ! src/share/classes/com/sun/jndi/ldap/BerEncoder.java ! src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java Changeset: 81c449fd18fe Author: dmeetry Date: 2013-05-16 19:28 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/81c449fd18fe 8014676: Java debugger may fail to run Summary: The problem is observed when the binaries for windows are placed under a path which contains a space Reviewed-by: sla, alanb Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/com/sun/tools/jdi/AbstractLauncher.java ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java Changeset: 74f91b7f4b66 Author: michaelm Date: 2013-05-16 17:28 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/74f91b7f4b66 8012625: Incorrect handling of HTTP/1.1 " Expect: 100-continue " in HttpURLConnection Reviewed-by: alanb, chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/B8012625.java Changeset: d02d1b18d828 Author: michaelm Date: 2013-05-16 17:31 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d02d1b18d828 Merge Changeset: da203779cb33 Author: jgish Date: 2013-05-16 11:19 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/da203779cb33 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java - test/java/util/logging/bundlesearch/LoadItUp.java + test/java/util/logging/bundlesearch/LoadItUp1.java + test/java/util/logging/bundlesearch/LoadItUp2.java + test/java/util/logging/bundlesearch/LoadItUp2Invoker.java ! test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java + test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java + test/java/util/logging/bundlesearch/resources/CallerSearchableResource_en.properties Changeset: df133f9cc4c9 Author: dfuchs Date: 2013-05-16 18:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/df133f9cc4c9 Merge Changeset: a8be9405bb4b Author: khazra Date: 2013-05-16 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a8be9405bb4b 7150552: network test hangs [macosx] Summary: Remove usage of test/sun/net/www/httptest Reviewed-by: chegar ! test/ProblemList.txt ! test/java/net/CookieHandler/CookieManagerTest.java ! test/sun/net/www/protocol/http/B6299712.java Changeset: a13de892cefd Author: ksrini Date: 2013-05-15 18:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a13de892cefd 8001163: [pack200] should support attributes introduced by JSR-308 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/AttributeTests.java + test/tools/pack200/BandIntegrity.java ! test/tools/pack200/InstructionTests.java ! test/tools/pack200/Utils.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java + test/tools/pack200/typeannos/Lambda.java + test/tools/pack200/typeannos/Readme.txt + test/tools/pack200/typeannos/TargetTypes.java + test/tools/pack200/typeannos/TestTypeAnnotations.java + test/tools/pack200/typeannos/TypeUseTarget.java Changeset: 9abf5dc83823 Author: vinnie Date: 2013-05-14 18:08 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9abf5dc83823 7194075: Various classes of sunec.jar are duplicated in rt.jar Reviewed-by: mullan, vinnie Contributed-by: Stephen Flores ! make/sun/security/ec/Makefile ! make/sun/security/other/Makefile ! makefiles/CreateJars.gmk + src/share/classes/sun/security/ec/CurveDB.java ! src/share/classes/sun/security/ec/ECDHKeyAgreement.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/ECKeyPairGenerator.java ! src/share/classes/sun/security/ec/ECParameters.java ! src/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/share/classes/sun/security/ec/ECPublicKeyImpl.java ! src/share/classes/sun/security/ec/NamedCurve.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/classes/sun/security/pkcs11/P11KeyStore.java ! src/share/classes/sun/security/ssl/JsseJce.java + src/share/classes/sun/security/util/ECKeySizeParameterSpec.java + src/share/classes/sun/security/util/ECUtil.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/ec/TestECDH2.java ! test/sun/security/pkcs11/ec/TestECDSA2.java Changeset: fdf082cddb69 Author: vinnie Date: 2013-05-14 18:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fdf082cddb69 Merge Changeset: a399b8be56ae Author: vinnie Date: 2013-05-15 14:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a399b8be56ae Merge ! makefiles/CreateJars.gmk - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider Changeset: 5153f5154162 Author: vinnie Date: 2013-05-15 15:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5153f5154162 Merge Changeset: 0465f27f19f5 Author: vinnie Date: 2013-05-16 02:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0465f27f19f5 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java Changeset: 9783f07d43e6 Author: vinnie Date: 2013-05-16 13:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9783f07d43e6 Merge - test/java/lang/Thread/StackTraces.java - test/java/util/logging/bundlesearch/LoadItUp.java Changeset: 5e8959ab64af Author: mchung Date: 2013-05-16 15:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5e8959ab64af 4487672: (proxy) Proxy constructor should check for null argument Reviewed-by: alanb, lancea ! src/share/classes/java/lang/reflect/Proxy.java ! test/java/lang/reflect/Proxy/Basic1.java Changeset: 68209420aac2 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/68209420aac2 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw + test/javax/xml/jaxp/PrecisionDecimalDV/XPrecisionDecimalToString.java Changeset: 3981ad7ec458 Author: chegar Date: 2013-05-17 15:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3981ad7ec458 8014791: More ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: fab0e4b682e8 Author: chegar Date: 2013-05-17 15:18 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fab0e4b682e8 Merge ! test/ProblemList.txt - test/java/util/logging/bundlesearch/LoadItUp.java Changeset: 222da3d4692a Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/222da3d4692a 8014783: java/net/HttpURLPermission/HttpURLPermissionTest.java leaves files open Reviewed-by: michaelm ! test/java/net/HttpURLPermission/HttpURLPermissionTest.java Changeset: fed779a87670 Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fed779a87670 Merge - test/java/util/logging/bundlesearch/LoadItUp.java Changeset: 30101f69e66f Author: lana Date: 2013-05-17 10:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/30101f69e66f Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/util/Base64.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/lang/Thread/StackTraces.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java - test/java/util/logging/bundlesearch/LoadItUp.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 2868607646a0 Author: erikj Date: 2013-05-21 17:02 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2868607646a0 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist Reviewed-by: dholmes, tbell, naoto ! makefiles/GensrcSwing.gmk Changeset: b61632814be2 Author: katleman Date: 2013-05-21 12:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b61632814be2 Merge Changeset: f559fadbf491 Author: andrew Date: 2013-05-22 13:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f559fadbf491 8015087: Provide debugging information for programs Summary: Add missing debug info to unpack200 and jexec Reviewed-by: erikj ! makefiles/CompileLaunchers.gmk Changeset: 88d6a20672ac Author: erikj Date: 2013-05-22 10:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88d6a20672ac 8014970: Use open man pages for non commercial builds Reviewed-by: omajid, tbell ! makefiles/Images.gmk Changeset: 169451cf0cc5 Author: erikj Date: 2013-05-22 15:00 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/169451cf0cc5 Merge Changeset: fbd926b20201 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fbd926b20201 Added tag jdk8-b91 for changeset 169451cf0cc5 ! .hgtags From john.coomes at oracle.com Thu May 23 23:28:40 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 24 May 2013 06:28:40 +0000 Subject: hg: hsx/hotspot-rt/nashorn: 19 new changesets Message-ID: <20130524062855.C993548D00@hg.openjdk.java.net> Changeset: b754fb89367d Author: jlaskey Date: 2013-04-30 10:05 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b754fb89367d 8006220: Simplify PropertyMaps Reviewed-by: hannesw, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyHashMap.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java - src/jdk/nashorn/internal/runtime/SpillProperty.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/scripts/JO.java ! src/jdk/nashorn/tools/Shell.java Changeset: 80cb02dedc83 Author: hannesw Date: 2013-05-02 09:19 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/80cb02dedc83 8013729: SwitchPoint invalidation not working over prototype chain Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8013729.js + test/script/basic/JDK-8013729.js.EXPECTED Changeset: 7563c56ca565 Author: jlaskey Date: 2013-05-02 13:22 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/7563c56ca565 8013794: JDK-8006220 caused an octane performance regression. Reviewed-by: lagergren, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/ObjectCreator.java Changeset: 9c2376a250b6 Author: jlaskey Date: 2013-05-02 13:23 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9c2376a250b6 Merge Changeset: c8023561505b Author: jlaskey Date: 2013-05-02 15:01 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c8023561505b 8013796: load("fx:base.js") should not be in fx:bootstrap.js Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js Changeset: 5a3f7867e19c Author: lagergren Date: 2013-05-03 15:33 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5a3f7867e19c 8013477: Node.setSymbol needs to be copy on write - enable IR snapshots for recompilation based on callsite type specialization. [not enabled by default, hidden by a flag for now] Reviewed-by: jlaskey, hannesw ! bin/jjs ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/CompiledFunction.java ! src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java + test/script/basic/paramspec.js + test/script/basic/paramspec.js.EXPECTED ! test/script/basic/runsunspider.js + test/script/currently-failing/logcoverage.js - test/script/trusted/logcoverage.js Changeset: 829b06307fb2 Author: lagergren Date: 2013-05-03 16:01 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/829b06307fb2 8013871: mem usage histograms enabled with compiler logging level set to more specific than or equals to info when --print-mem-usage flag is used Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/Compiler.java + src/jdk/nashorn/internal/ir/debug/ClassHistogramElement.java + src/jdk/nashorn/internal/ir/debug/ObjectSizeCalculator.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java Changeset: c0f0033d7b08 Author: hannesw Date: 2013-05-03 22:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c0f0033d7b08 8013878: ClassCastException in Regex Reviewed-by: jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8013878.js + test/script/basic/JDK-8013878.js.EXPECTED Changeset: f98d22fa3cbc Author: hannesw Date: 2013-05-03 22:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f98d22fa3cbc 8013873: Regexp regression for escaped dash in character class Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8013873.js + test/script/basic/JDK-8013873.js.EXPECTED Changeset: f3dcb12c8439 Author: hannesw Date: 2013-05-03 22:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f3dcb12c8439 8013874: Function argument's prototype seem cached and wrongly reused Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java + test/script/basic/JDK-8013874.js + test/script/basic/JDK-8013874.js.EXPECTED Changeset: 544e17632e96 Author: lagergren Date: 2013-05-07 14:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/544e17632e96 8013913: Removed Source field from all nodes except FunctionNode in order to save footprint Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java - src/jdk/nashorn/internal/ir/Location.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java Changeset: fb1d7ea3e1b6 Author: lagergren Date: 2013-05-07 14:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/fb1d7ea3e1b6 8013914: Removed explicit LineNumberNodes that were too brittle when code moves around, and also introduced unnecessary footprint. Introduced the Statement node and fixed dead code elimination issues that were discovered by the absense of labels for LineNumberNodes. Reviewed-by: jlaskey, attila ! make/project.properties ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java - src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java + src/jdk/nashorn/internal/ir/Statement.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/no_line_numbers.js + test/script/basic/no_line_numbers.js.EXPECTED Changeset: d28180d97c61 Author: attila Date: 2013-05-08 15:51 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d28180d97c61 8013912: Nashorn needs to reuse temporary symbols Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/Symbol.java + src/jdk/nashorn/internal/ir/TemporarySymbols.java ! src/jdk/nashorn/internal/ir/TypeOverride.java Changeset: 18ce1cd3026c Author: attila Date: 2013-05-08 16:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/18ce1cd3026c 8014225: Rerun only failed 262 tests Reviewed-by: jlaskey, lagergren ! make/project.properties ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java ! test/src/jdk/nashorn/internal/test/framework/TestFinder.java Changeset: 9073bcc4307b Author: lagergren Date: 2013-05-10 13:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9073bcc4307b 8014329: Slim down the label stack structure in CodeGenerator Reviewed-by: attila, jlaskey ! .hgignore ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java Changeset: 098a4cedcaf2 Author: attila Date: 2013-05-14 12:39 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/098a4cedcaf2 8014492: Make NashornLinker public Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java Changeset: 264bb0af9e4e Author: jlaskey Date: 2013-05-14 09:05 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/264bb0af9e4e Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js Changeset: 6b9f41203800 Author: lana Date: 2013-05-17 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6b9f41203800 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js Changeset: dee23cce5235 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/dee23cce5235 Added tag jdk8-b91 for changeset 6b9f41203800 ! .hgtags From john.coomes at oracle.com Thu May 23 23:26:16 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 24 May 2013 06:26:16 +0000 Subject: hg: hsx/hotspot-rt/langtools: 45 new changesets Message-ID: <20130524062828.145E148CFF@hg.openjdk.java.net> Changeset: abd153854f16 Author: jjg Date: 2013-05-03 09:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/abd153854f16 8012728: Normalize @ignore comments on langtools tests Reviewed-by: vromero, mcimadamore ! test/com/sun/javadoc/_template/Template.java ! test/com/sun/javadoc/_template/TemplateComplete.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java ! test/tools/javac/generics/7034511/T7034511a.java ! test/tools/javac/generics/7034511/T7034511b.java ! test/tools/javac/generics/OverrideBridge.java ! test/tools/javac/lambda/TargetType36.java ! test/tools/javac/lambda/TargetType53.java ! test/tools/javac/lambda/TargetType54.java ! test/tools/javac/lambda/TargetType58.java ! test/tools/javac/lambda/TargetType59.java ! test/tools/javac/lambda/TargetType62.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/output/Tester.java Changeset: 38c4bade0ec1 Author: jjg Date: 2013-05-03 10:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/38c4bade0ec1 8002387: Improve rendered HTML formatting for {@code} Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javadoc/Comment.java + test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java + test/com/sun/javadoc/testLiteralCodeInPre/pkg/Test.java Changeset: a2889739cf21 Author: jjg Date: 2013-05-03 15:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a2889739cf21 8000407: remove @GenerateNativeHeader Reviewed-by: vromero, darcy ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java ! test/tools/javac/nativeHeaders/NativeHeaderTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java Changeset: d918b63a5509 Author: jjg Date: 2013-05-03 17:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d918b63a5509 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Reviewed-by: jjg, mduigou Contributed-by: jonathan.gibbons at oracle.com, mike.duigou at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java + test/com/sun/javadoc/InheritDocForUserTags/DocTest.java + test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java + test/com/sun/javadoc/testSimpleTagInherit/p/BaseClass.java + test/com/sun/javadoc/testSimpleTagInherit/p/TestClass.java Changeset: e8987ce7fb4b Author: darcy Date: 2013-05-05 21:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e8987ce7fb4b 8013909: Fix doclint issues in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/SupportedAnnotationTypes.java ! src/share/classes/javax/annotation/processing/SupportedOptions.java ! src/share/classes/javax/annotation/processing/SupportedSourceVersion.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/element/NestingKind.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/Elements.java ! src/share/classes/javax/lang/model/util/Types.java Changeset: a7ff36d06fa2 Author: jlahoda Date: 2013-05-06 16:22 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a7ff36d06fa2 8009724: Enhance the DocTree API with DocTreePath Summary: Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner, respectively Reviewed-by: jjg Contributed-by: Ralph Benjamin Ruijs , Jan Lahoda + src/share/classes/com/sun/source/util/DocTreePath.java + src/share/classes/com/sun/source/util/DocTreePathScanner.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java + test/tools/javac/doctree/DocTreePathScannerTest.java ! test/tools/javac/doctree/ReferenceTest.java Changeset: 68142e69cafb Author: rfield Date: 2013-05-07 06:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/68142e69cafb 8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReference/TreeMakerParamsIsGoofy.java Changeset: 43c2f7cb9c76 Author: jjg Date: 2013-05-07 14:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/43c2f7cb9c76 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + src/share/classes/com/sun/tools/javac/util/ServiceLoader.java ! test/tools/javac/plugin/showtype/Test.java Changeset: 780014a234fa Author: jfranck Date: 2013-05-08 14:10 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/780014a234fa 8013485: javac can't handle annotations with a from a previous compilation unit Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/clinit/AnnoWithClinit1.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.out Changeset: c68834236058 Author: lana Date: 2013-05-08 23:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c68834236058 Merge Changeset: ce7e1674eb73 Author: alanb Date: 2013-05-10 16:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ce7e1674eb73 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1 Reviewed-by: mchung ! test/tools/javac/profiles/ProfileOptionTest.java Changeset: 1c43236f6d69 Author: darcy Date: 2013-05-10 14:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1c43236f6d69 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: jjg ! makefiles/BuildLangtools.gmk Changeset: e39669aea0bd Author: jjg Date: 2013-05-12 18:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e39669aea0bd 8014363: javac test class ToolTester handles classpath incorrectly Reviewed-by: ksrini ! test/tools/javac/api/6406133/T6406133.java ! test/tools/javac/api/6410643/T6410643.java ! test/tools/javac/api/6411310/T6411310.java ! test/tools/javac/api/6411333/T6411333.java ! test/tools/javac/api/6412656/T6412656.java ! test/tools/javac/api/6415780/T6415780.java ! test/tools/javac/api/6418694/T6418694.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6421756/T6421756.java ! test/tools/javac/api/6422215/T6422215.java ! test/tools/javac/api/6422327/T6422327.java ! test/tools/javac/api/6423003/T6423003.java ! test/tools/javac/api/6431257/T6431257.java ! test/tools/javac/api/6437349/T6437349.java ! test/tools/javac/api/6437999/T6437999.java ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/6440528/T6440528.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/6731573/T6731573.java ! test/tools/javac/api/6733837/T6733837.java ! test/tools/javac/api/TestJavacTaskScanner.java ! test/tools/javac/api/guide/Test.java ! test/tools/javac/api/lib/ToolTester.java Changeset: 8dd528992c15 Author: jlahoda Date: 2013-05-10 15:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8dd528992c15 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Reviewed-by: jjg Contributed-by: Dusan Balek , Jan Lahoda ! src/share/classes/com/sun/tools/doclint/Env.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/api/TestGetElementReference.java + test/tools/javac/api/TestGetElementReferenceData.java Changeset: 8ea30d59ac41 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8ea30d59ac41 8010440: Replace int constants in LinkInfoImpl with enum Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 74cd21f2c2fe Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/74cd21f2c2fe 8011642: Remove LinkOutput in favor of direct use of Content Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java Changeset: 7a9ef837e57f Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7a9ef837e57f 8011650: reduce use of RawHtml nodes in doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 6ea964c78845 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6ea964c78845 8011651: simplify LinkInfoImpl API Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java Changeset: e6c5b5ee9fac Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e6c5b5ee9fac 8011662: Remove single instance of resource with HTML from doclet resource bundle Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: ce4f0769b4b2 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ce4f0769b4b2 8011668: Allow HTMLWriter.getResource to take Content args Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 4c43e51433ba Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4c43e51433ba 8011288: Erratic/inconsistent indentation of signatures Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java + test/com/sun/javadoc/testIndentation/TestIndentation.java + test/com/sun/javadoc/testIndentation/p/Indent.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java Changeset: 7af0fa419a2b Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7af0fa419a2b 8012174: {@literal} and {@code} should use \"new\" Taglet, not old. Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java Changeset: 6a5288a298fd Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6a5288a298fd 8012175: Convert TagletOutputImpl to use ContentBuilder instead of StringBuilder Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java Changeset: 76a691e3e961 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/76a691e3e961 8012176: reduce use of TagletOutputImpl.toString Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java Changeset: 937aa020c667 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/937aa020c667 8012177: HTMLDocletWriter methods should generate Content, not Strings Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java Changeset: bd51ca92c013 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bd51ca92c013 8012178: Cleanup use of Util.escapeHtmlChars Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: df4f44800923 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/df4f44800923 8012183: replace some uses of Configuration.getText with Configuration.getResource Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 051b728cfe90 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/051b728cfe90 8012180: Speed up removeNonInlineHtmlTags Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: 25c89a492f14 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/25c89a492f14 8012295: Cleanup JavaFX features in standard doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: 081d7c72ee92 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/081d7c72ee92 8012311: Cleanup names and duplicatre code in TagletManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: ca8808c88f94 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ca8808c88f94 8012308: Remove TagletOutput in favor of direct use of Content Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/BoldTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/GreenTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/UnderlineTaglet.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java Changeset: c09b7234cded Author: rfield Date: 2013-05-14 11:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c09b7234cded 8012556: Implement lambda methods on interfaces as static 8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface Summary: Lambdas occurring in static contexts or those not needing instance information should be generated into static methods. This has long been the case for classes. However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods. For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'. MethodHandles now support static methods on interfaces. This changeset allows lambda methods to be generated as static interface methods. An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used. This test and another test that already exposed this bug have been marked with @ignore. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaInterfaceStaticField.java ! test/tools/javac/lambda/MethodReference66.java ! test/tools/javac/lambda/bytecode/TestLambdaBytecode.java ! test/tools/javac/lambda/lambdaExecution/InInterface.java Changeset: 46b9c25f7024 Author: jjg Date: 2013-05-14 12:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/46b9c25f7024 8014461: genstubs creates default native methods Reviewed-by: alanb ! make/tools/genstubs/GenStubs.java Changeset: 0384683c64be Author: jjg Date: 2013-05-14 13:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/0384683c64be 8014557: Mutable static field in HtmlDocletWriter Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java Changeset: ddb4a2bfcd82 Author: jjg Date: 2013-05-14 15:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ddb4a2bfcd82 8013852: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wdietl at gmail.com, steve.sides at oracle.com, joel.franck at oracle.com, alex.buckley at oracle.com ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest3.java ! test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java ! test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008769.java + test/tools/javac/annotations/typeAnnotations/classfile/T8010015.java + test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java ! test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java ! test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.java + test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.out ! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/T8008751.java + test/tools/javac/annotations/typeAnnotations/failures/T8009360.java + test/tools/javac/annotations/typeAnnotations/failures/T8011722.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/Lambda.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Initializers.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Test.java ! test/tools/javac/api/TestJavacTaskScanner.java + test/tools/javac/diags/examples/ArrayAndReceiver.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverName.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverType.java + test/tools/javac/diags/examples/IncorrectReceiverName.java + test/tools/javac/diags/examples/ReceiverParameterNotApplicableConstructor.java + test/tools/javac/diags/examples/VarargsAndReceiver.java ! test/tools/javac/lib/DPrinter.java + test/tools/javac/processing/model/type/BasicAnnoTests.java ! test/tools/javac/tree/SourceTreeScannerTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/typeAnnotations/NewArray.java ! test/tools/javap/typeAnnotations/Presence.java ! test/tools/javap/typeAnnotations/TypeCasts.java Changeset: 53b389eb39c1 Author: sogoel Date: 2013-05-14 18:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/53b389eb39c1 8013163: Convert 4 tools multicatch tests to jtreg format Reviewed-by: jjg + test/tools/javac/multicatch/Pos11.java + test/tools/javac/multicatch/Pos12.java Changeset: 529fb3ed5d2a Author: jjg Date: 2013-05-14 21:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/529fb3ed5d2a 8014323: Add VariableTree.getNameExpression Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! test/tools/javac/tree/SourceTreeScannerTest.java Changeset: bcd927639039 Author: darcy Date: 2013-05-15 00:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bcd927639039 8004133: Provide javax.lang.model.* implementation backed by core reflection Summary: Joint work by darcy and jfranck to provide sample code for JEP 119. Reviewed-by: jjg Contributed-by: joe.darcy at oracle.com, joel.franck at oracle.com + src/share/sample/language/model/CoreReflectionFactory.java Changeset: 05ec778794d0 Author: mcimadamore Date: 2013-05-15 14:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/05ec778794d0 8012003: Method diagnostics resolution need to be simplified in some cases Summary: Unfold method resolution diagnostics when they mention errors in poly expressions Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/Diagnostics/compressed/T8012003a.java + test/tools/javac/Diagnostics/compressed/T8012003a.out + test/tools/javac/Diagnostics/compressed/T8012003b.java + test/tools/javac/Diagnostics/compressed/T8012003b.out + test/tools/javac/Diagnostics/compressed/T8012003c.java + test/tools/javac/Diagnostics/compressed/T8012003c.out ! test/tools/javac/diags/examples/BadArgTypesInLambda.java + test/tools/javac/diags/examples/CompressedDiags.java ! test/tools/javac/diags/examples/KindnameConstructor.java + test/tools/javac/diags/examples/ProbFoundReqFragment.java ! test/tools/javac/lambda/TargetType66.out Changeset: 33d1937af1a3 Author: mcimadamore Date: 2013-05-15 14:02 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/33d1937af1a3 8012685: Spurious raw types warning when using unbound method references Summary: Spurious raw type warning when unbound method reference qualifier parameter types are inferred from target Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/MethodReference67.java + test/tools/javac/lambda/MethodReference67.out Changeset: 78717f2d00e8 Author: mcimadamore Date: 2013-05-15 14:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/78717f2d00e8 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types Summary: Bad warnings and position for lambda inferred parameter types Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/NoWarnOnImplicitParams.java + test/tools/javac/lambda/NoWarnOnImplicitParams.out Changeset: 31ef33db5e0e Author: rfield Date: 2013-05-15 06:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/31ef33db5e0e 8010006: NPE in javac with interface super in lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaWithInterfaceSuper.java Changeset: 445b8b5ae9f4 Author: jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joelsson at oracle.com ! src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java Changeset: 997c0fae2b12 Author: lana Date: 2013-05-17 10:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/997c0fae2b12 Merge - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java Changeset: 4830d661c4f9 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4830d661c4f9 Added tag jdk8-b91 for changeset 997c0fae2b12 ! .hgtags From serguei.spitsyn at oracle.com Fri May 24 02:00:17 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 24 May 2013 09:00:17 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes Message-ID: <20130524090025.9315048D05@hg.openjdk.java.net> Changeset: b7fa10a3a69a Author: sspitsyn Date: 2013-05-23 23:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b7fa10a3a69a 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes Summary: The fix of perf regression is to use method_idnum() for direct indexing into NMT Reviewed-by: twisti, kvn, coleenp, dholmes Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp From serguei.spitsyn at oracle.com Fri May 24 02:29:27 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 24 May 2013 02:29:27 -0700 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock Message-ID: <519F32F7.6070900@oracle.com> Please, review the fix for: bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ Summary: CMS calls InstanceKlass::release_C_heap_structures() concurrently. The "delete mnt" needs to take MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint(). Testing: The vm/mlvm and Nashorn tests, the tests listed in the bug report Thanks, Serguei From weijun.wang at oracle.com Fri May 24 02:34:50 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 24 May 2013 09:34:50 +0000 Subject: hg: jdk8/tl/jdk: 8014196: ktab creates a file with zero kt_vno Message-ID: <20130524093523.B5AC848D07@hg.openjdk.java.net> Changeset: 6816afd70a68 Author: weijun Date: 2013-05-24 17:15 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6816afd70a68 8014196: ktab creates a file with zero kt_vno Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/windows/classes/sun/security/krb5/internal/tools/Ktab.java + test/sun/security/krb5/tools/KtabZero.java + test/sun/security/krb5/tools/ktzero.sh From staffan.larsen at oracle.com Fri May 24 03:22:46 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 24 May 2013 12:22:46 +0200 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <519F32F7.6070900@oracle.com> References: <519F32F7.6070900@oracle.com> Message-ID: <4A2AC0E6-20B3-4405-915E-2A3BFD04FCEA@oracle.com> Looks good! /Staffan On 24 maj 2013, at 11:29, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ > > Summary: > CMS calls InstanceKlass::release_C_heap_structures() concurrently. > The "delete mnt" needs to take MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint(). > > Testing: > The vm/mlvm and Nashorn tests, the tests listed in the bug report > > Thanks, > Serguei From serguei.spitsyn at oracle.com Fri May 24 03:29:46 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 24 May 2013 03:29:46 -0700 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <4A2AC0E6-20B3-4405-915E-2A3BFD04FCEA@oracle.com> References: <519F32F7.6070900@oracle.com> <4A2AC0E6-20B3-4405-915E-2A3BFD04FCEA@oracle.com> Message-ID: <519F411A.5050408@oracle.com> Thanks, Staffan! Serguei On 5/24/13 3:22 AM, Staffan Larsen wrote: > Looks good! > > /Staffan > > On 24 maj 2013, at 11:29, serguei.spitsyn at oracle.com wrote: > >> Please, review the fix for: >> bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 >> jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ >> >> Summary: >> CMS calls InstanceKlass::release_C_heap_structures() concurrently. >> The "delete mnt" needs to take MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint(). >> >> Testing: >> The vm/mlvm and Nashorn tests, the tests listed in the bug report >> >> Thanks, >> Serguei From mikael.gerdin at oracle.com Fri May 24 03:29:59 2013 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Fri, 24 May 2013 12:29:59 +0200 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <519F32F7.6070900@oracle.com> References: <519F32F7.6070900@oracle.com> Message-ID: <519F4127.3040804@oracle.com> Serguei, On 2013-05-24 11:29, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ I agree with the semantic change but I'm not that fond of the duplication. Instead of duplicating the code you could have a: MutexLockerEx ml( ( SafepointSynchronize::is_at_safepoint() ? NULL : MemberNameTable_lock ), Mutex::_no_safepoint_check_flag ); Or maybe Mutex* mutex_or_null = SafepointSynchronize::is_at_safepoint() ? NULL : MemberNameTable_lock; MutexLockerEx ml(mutex_or_null, Mutex::_no_safepoint_check_flag); MutexLockerEx already has a null-check in both constructor and destructor. /Mikael > > > Summary: > CMS calls InstanceKlass::release_C_heap_structures() concurrently. > The "delete mnt" needs to take MemberNameTable_lock if > !SafepointSynchronize::is_at_safepoint(). > > Testing: > The vm/mlvm and Nashorn tests, the tests listed in the bug report > > Thanks, > Serguei From serguei.spitsyn at oracle.com Fri May 24 03:53:29 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 24 May 2013 03:53:29 -0700 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <519F4127.3040804@oracle.com> References: <519F32F7.6070900@oracle.com> <519F4127.3040804@oracle.com> Message-ID: <519F46A9.4000204@oracle.com> Mikael, I like your suggestion, will send new webrev tomorrow. Thank you for the review! Serguei On 5/24/13 3:29 AM, Mikael Gerdin wrote: > Serguei, > > On 2013-05-24 11:29, serguei.spitsyn at oracle.com wrote: >> Please, review the fix for: >> bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 >> jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ >> > > I agree with the semantic change but I'm not that fond of the > duplication. > Instead of duplicating the code you could have a: > > MutexLockerEx ml( ( SafepointSynchronize::is_at_safepoint() ? NULL : > MemberNameTable_lock ), Mutex::_no_safepoint_check_flag ); > > Or maybe > > Mutex* mutex_or_null = SafepointSynchronize::is_at_safepoint() ? NULL > : MemberNameTable_lock; > MutexLockerEx ml(mutex_or_null, Mutex::_no_safepoint_check_flag); > > MutexLockerEx already has a null-check in both constructor and > destructor. > > /Mikael > >> >> >> Summary: >> CMS calls InstanceKlass::release_C_heap_structures() concurrently. >> The "delete mnt" needs to take MemberNameTable_lock if >> !SafepointSynchronize::is_at_safepoint(). >> >> Testing: >> The vm/mlvm and Nashorn tests, the tests listed in the bug report >> >> Thanks, >> Serguei From david.holmes at oracle.com Fri May 24 03:54:11 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 24 May 2013 20:54:11 +1000 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <519F32F7.6070900@oracle.com> References: <519F32F7.6070900@oracle.com> Message-ID: <519F46D3.7030304@oracle.com> Hi Serguei, You can avoid the code duplication if you use the safepoint check to assign either the MemberNameTable_lock or NULL to a Mutex variable: Mutex* lock = (atsafepoint ? NULL : MemberNameTable_lock); { MutexLockerEx ml(lock, ...); ... } David On 24/05/2013 7:29 PM, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ > > > Summary: > CMS calls InstanceKlass::release_C_heap_structures() concurrently. > The "delete mnt" needs to take MemberNameTable_lock if > !SafepointSynchronize::is_at_safepoint(). > > Testing: > The vm/mlvm and Nashorn tests, the tests listed in the bug report > > Thanks, > Serguei From david.holmes at oracle.com Fri May 24 03:56:08 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 24 May 2013 20:56:08 +1000 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <519F46D3.7030304@oracle.com> References: <519F32F7.6070900@oracle.com> <519F46D3.7030304@oracle.com> Message-ID: <519F4748.4070701@oracle.com> Sorry just saw Mikael already suggested this. :) David On 24/05/2013 8:54 PM, David Holmes wrote: > Hi Serguei, > > You can avoid the code duplication if you use the safepoint check to > assign either the MemberNameTable_lock or NULL to a Mutex variable: > > Mutex* lock = (atsafepoint ? NULL : MemberNameTable_lock); > { > MutexLockerEx ml(lock, ...); > ... > } > > David > > On 24/05/2013 7:29 PM, serguei.spitsyn at oracle.com wrote: >> Please, review the fix for: >> bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 >> jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ >> >> >> >> Summary: >> CMS calls InstanceKlass::release_C_heap_structures() concurrently. >> The "delete mnt" needs to take MemberNameTable_lock if >> !SafepointSynchronize::is_at_safepoint(). >> >> Testing: >> The vm/mlvm and Nashorn tests, the tests listed in the bug report >> >> Thanks, >> Serguei From nils.loodin at oracle.com Fri May 24 07:13:36 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 24 May 2013 16:13:36 +0200 Subject: RFR 6470730: Disconnect button leads to wrong popup message Message-ID: <519F7590.5020700@oracle.com> Simple fix not to add a confusing dialog. Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 Webrev: http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ Regards, Nils Loodin From nils.loodin at oracle.com Fri May 24 07:20:54 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 24 May 2013 16:20:54 +0200 Subject: RFR 6470730: Disconnect button leads to wrong popup message In-Reply-To: <519F7590.5020700@oracle.com> References: <519F7590.5020700@oracle.com> Message-ID: <519F7746.6090006@oracle.com> Wrong link: On 05/24/2013 04:13 PM, Nils Loodin wrote: > Simple fix not to add a confusing dialog. > > Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 This should be http://bugs.sun.com/view_bug.do?bug_id=6470730 > > Webrev: > http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ > > Regards, > Nils Loodin From maurizio.cimadamore at oracle.com Fri May 24 07:29:32 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 24 May 2013 14:29:32 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130524142952.35A1E48D10@hg.openjdk.java.net> Changeset: 58329d9f6b68 Author: mcimadamore Date: 2013-05-24 15:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58329d9f6b68 8014643: Parser regression in JDK 8 when compiling super.x Summary: Fixed latent bug in JavacParser.analyzeParens() Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/parser/8014643/T8014643.java Changeset: 97a9b4b3e63a Author: mcimadamore Date: 2013-05-24 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97a9b4b3e63a 8014649: Regression: bug in Resolve.resolveOperator Summary: Missing curly braces causes Resolve.findMethod to be called spuriously Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/resolve/ResolveHarness.java + test/tools/javac/resolve/tests/PrimitiveBinopOverload.java Changeset: 6e5076af4660 Author: mcimadamore Date: 2013-05-24 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e5076af4660 8014494: javac crashes when varargs element of a method reference is inferred from the context Summary: varargs element is not refreshed after type-inference Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/TargetType73.java From mikael.auno at oracle.com Fri May 24 07:43:32 2013 From: mikael.auno at oracle.com (Mikael Auno) Date: Fri, 24 May 2013 16:43:32 +0200 Subject: RFR 6470730: Disconnect button leads to wrong popup message In-Reply-To: <519F7590.5020700@oracle.com> References: <519F7590.5020700@oracle.com> Message-ID: <519F7C94.1000302@oracle.com> On 2013-05-24 16:13, Nils Loodin wrote: > Simple fix not to add a confusing dialog. > > Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 > > Webrev: > http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ Fix looks simple and good to me. However, I don't have my OpenJDK username yet, so this might not carry that much weight. Mikael From erik.gahlin at oracle.com Fri May 24 07:57:57 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Fri, 24 May 2013 16:57:57 +0200 Subject: RFR 6470730: Disconnect button leads to wrong popup message In-Reply-To: <519F7590.5020700@oracle.com> References: <519F7590.5020700@oracle.com> Message-ID: <519F7FF5.2080109@oracle.com> Looks good! (not a reviewer) Nils Loodin skrev 2013-05-24 16:13: > Simple fix not to add a confusing dialog. > > Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 > > Webrev: > http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ > > Regards, > Nils Loodin From staffan.larsen at oracle.com Fri May 24 09:33:19 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 24 May 2013 18:33:19 +0200 Subject: RFR 6470730: Disconnect button leads to wrong popup message In-Reply-To: <519F7590.5020700@oracle.com> References: <519F7590.5020700@oracle.com> Message-ID: <22B1E7D2-3F7B-47CB-B474-5C7E4C31B6FB@oracle.com> Looks good, but the indentation is wrong in one place. /Staffan On 24 maj 2013, at 16:13, Nils Loodin wrote: > Simple fix not to add a confusing dialog. > > Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 > > Webrev: > http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ > > Regards, > Nils Loodin From serguei.spitsyn at oracle.com Fri May 24 10:05:15 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 24 May 2013 10:05:15 -0700 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <519F4748.4070701@oracle.com> References: <519F32F7.6070900@oracle.com> <519F46D3.7030304@oracle.com> <519F4748.4070701@oracle.com> Message-ID: <519F9DCB.7010907@oracle.com> Ok, thank you for the review! Serguei On 5/24/13 3:56 AM, David Holmes wrote: > Sorry just saw Mikael already suggested this. :) > > David > > On 24/05/2013 8:54 PM, David Holmes wrote: >> Hi Serguei, >> >> You can avoid the code duplication if you use the safepoint check to >> assign either the MemberNameTable_lock or NULL to a Mutex variable: >> >> Mutex* lock = (atsafepoint ? NULL : MemberNameTable_lock); >> { >> MutexLockerEx ml(lock, ...); >> ... >> } >> >> David >> >> On 24/05/2013 7:29 PM, serguei.spitsyn at oracle.com wrote: >>> Please, review the fix for: >>> bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 >>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 >>> >>> Open webrev: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ >>> >>> >>> >>> >>> Summary: >>> CMS calls InstanceKlass::release_C_heap_structures() concurrently. >>> The "delete mnt" needs to take MemberNameTable_lock if >>> !SafepointSynchronize::is_at_safepoint(). >>> >>> Testing: >>> The vm/mlvm and Nashorn tests, the tests listed in the bug report >>> >>> Thanks, >>> Serguei From serguei.spitsyn at oracle.com Fri May 24 10:39:42 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 24 May 2013 10:39:42 -0700 Subject: Review Request (S) 8013945: CMS fatal error: must own lock MemberNameTable_lock In-Reply-To: <519F32F7.6070900@oracle.com> References: <519F32F7.6070900@oracle.com> Message-ID: <519FA5DE.6060303@oracle.com> Webrev with the fix suggested by Mikael G. : http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.2/ I'm going to integrate it after testing, but a couple of extra eyes to double-check it would be nice. Thanks, Serguei On 5/24/13 2:29 AM, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8013945 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8013945-JVMTI-JSR292.1/ > > > Summary: > CMS calls InstanceKlass::release_C_heap_structures() concurrently. > The "delete mnt" needs to take MemberNameTable_lock if > !SafepointSynchronize::is_at_safepoint(). > > Testing: > The vm/mlvm and Nashorn tests, the tests listed in the bug report > > Thanks, > Serguei From joe.darcy at oracle.com Fri May 24 11:26:28 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 24 May 2013 18:26:28 +0000 Subject: hg: jdk8/tl/langtools: 8014836: Have GenericDeclaration extend AnnotatedElement Message-ID: <20130524182635.1F03048D20@hg.openjdk.java.net> Changeset: 0f8e9a0e5d9a Author: darcy Date: 2013-05-24 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f8e9a0e5d9a 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: jfranck ! src/share/sample/language/model/CoreReflectionFactory.java From daniel.daugherty at oracle.com Fri May 24 17:24:47 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Sat, 25 May 2013 00:24:47 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 26 new changesets Message-ID: <20130525002541.60E5948D2A@hg.openjdk.java.net> Changeset: 293b99787401 Author: dholmes Date: 2013-05-14 07:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/293b99787401 8014460: Need to check for non-empty EXT_LIBS_PATH before using it Reviewed-by: tbell, collins, sla, coleenp ! make/bsd/makefiles/arm.make ! make/linux/makefiles/arm.make Changeset: 26579ac80ce9 Author: bpittore Date: 2013-05-15 23:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/26579ac80ce9 8014669: arch specific flags not passed to some link commands Summary: EXTRA_CFLAGS does not propagate to saproc and jsig makefiles Reviewed-by: dholmes, tbell, collins ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make Changeset: f8c833eb2a5f Author: jiangli Date: 2013-05-20 13:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f8c833eb2a5f Merge Changeset: c838b672691c Author: jiangli Date: 2013-05-23 13:40 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c838b672691c Merge Changeset: 91eba9f82325 Author: anoll Date: 2013-05-16 15:46 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/91eba9f82325 8012371: Adjust Tiered compile threshold according to available space in code cache Summary: Added command line parameter to define a threshold at which C1 compilation threshold for is increased. Reviewed-by: kvn, iveresov ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ec922e5c545a Author: anoll Date: 2013-05-22 10:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ec922e5c545a 8012312: hsdis fails to compile with binutils-2.23.2 Summary: added to header file to make hsdis compile with binutils 2.23.* Reviewed-by: kvn, twisti ! src/share/tools/hsdis/hsdis.c Changeset: b4907b24ed48 Author: twisti Date: 2013-05-22 11:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b4907b24ed48 Merge Changeset: 1682bec79205 Author: kvn Date: 2013-05-22 09:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1682bec79205 8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed Summary: Stop current iteration of loop opts if partial_peel() failed and it created node clones outside processed loop. Reviewed-by: roland ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp Changeset: 71a2d06b9c2b Author: kvn Date: 2013-05-22 17:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/71a2d06b9c2b Merge Changeset: 3f281b313240 Author: kvn Date: 2013-05-22 18:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3f281b313240 8010927: Kitchensink crashed with SIGSEGV, Problematic frame: v ~StubRoutines::checkcast_arraycopy Summary: Changed gen_write_ref_array_post_barrier() code on x64 to pass start address and number of copied oop elements. In generate_checkcast_copy() skip post barrier code if no elements are copied. Reviewed-by: roland ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp + test/compiler/8010927/Test8010927.java Changeset: 01e51113b4f5 Author: anoll Date: 2013-05-23 14:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/01e51113b4f5 8014430: JRE crashes instead of stop compilation on full Code Cache. Internal Error (c1_Compiler.cpp:87) Summary: Disable client compiler and switch to interpreter if there is not enough free space in the code cache. Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_Compiler.hpp Changeset: 59e18b573605 Author: twisti Date: 2013-05-23 15:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/59e18b573605 Merge Changeset: 001ec9515f84 Author: ehelin Date: 2013-05-17 11:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/001ec9515f84 8014277: Remove ObjectClosure as base class for BoolObjectClosure Reviewed-by: brutisso, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/jniHandles.cpp Changeset: 2138a2c14831 Author: jwilhelm Date: 2013-05-19 20:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2138a2c14831 Merge ! src/share/vm/gc_implementation/shared/markSweep.cpp Changeset: 10f759898d40 Author: tamao Date: 2013-05-20 10:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/10f759898d40 7186737: Unable to allocate bit maps or card tables for parallel gc for the requested heap Summary: Print helpful error message when VM aborts due to inability of allocating bit maps or card tables Reviewed-by: jmasa, stefank Contributed-by: tamao ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: 2b1a9d972fc2 Author: jmasa Date: 2013-05-20 22:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2b1a9d972fc2 8014862: Add fast Metasapce capacity and used per MetadataType Reviewed-by: ehelin, stefank ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: 28e53b8db94f Author: brutisso Date: 2013-05-21 08:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/28e53b8db94f 7066063: CMS: "Conservation Principle" assert failed Summary: Add call to coalBirth() in CompactibleFreeListSpace::reset() Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp Changeset: 5ed122fbd0ef Author: brutisso Date: 2013-05-21 10:39 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ed122fbd0ef Merge Changeset: 6702da6b6082 Author: tschatzl Date: 2013-05-21 11:30 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6702da6b6082 8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes Summary: Instead of using a simple sizeof(), ask the PerRegionTable class about its size when iterating over the free list. Reviewed-by: jwilhelm, brutisso ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/prims/jni.cpp Changeset: 7c5a1b62f53d Author: brutisso Date: 2013-05-22 08:04 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7c5a1b62f53d 8014971: Minor code cleanup of the freelist management Reviewed-by: jwilhelm, jmasa, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp Changeset: 62890ed7e2a8 Author: jwilhelm Date: 2013-05-24 09:29 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/62890ed7e2a8 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java - test/runtime/7158804/Test7158804.sh - test/runtime/8003985/Test8003985.java Changeset: ad47de214f0c Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ad47de214f0c Added tag jdk8-b91 for changeset 7cbdf0e3725c ! .hgtags Changeset: 38da9f4f6709 Author: amurillo Date: 2013-05-24 09:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/38da9f4f6709 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java - test/runtime/7158804/Test7158804.sh - test/runtime/8003985/Test8003985.java Changeset: 092018493d3b Author: amurillo Date: 2013-05-24 09:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/092018493d3b Added tag hs25-b34 for changeset 38da9f4f6709 ! .hgtags Changeset: 194b27b865bc Author: amurillo Date: 2013-05-24 09:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/194b27b865bc 8015305: new hotspot build - hs25-b35 Reviewed-by: jcoomes ! make/hotspot_version Changeset: cd83e1d98347 Author: dcubed Date: 2013-05-24 10:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd83e1d98347 Merge From kumar.x.srinivasan at oracle.com Fri May 24 18:54:53 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sat, 25 May 2013 01:54:53 +0000 Subject: hg: jdk8/tl/jdk: 8007333: [launcher] removes multiple back slashes Message-ID: <20130525015529.0B9A248D30@hg.openjdk.java.net> Changeset: 5e769206f036 Author: ksrini Date: 2013-05-24 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e769206f036 8007333: [launcher] removes multiple back slashes Reviewed-by: alanb, akhil ! src/windows/bin/cmdtoargs.c ! test/tools/launcher/Arrrghs.java From serguei.spitsyn at oracle.com Fri May 24 20:45:43 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Sat, 25 May 2013 03:45:43 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8013945: CMS fatal error: must own lock MemberNameTable_lock Message-ID: <20130525034547.32C6A48D32@hg.openjdk.java.net> Changeset: 6c138b9851fb Author: sspitsyn Date: 2013-05-24 17:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6c138b9851fb 8013945: CMS fatal error: must own lock MemberNameTable_lock Summary: The "delete mnt" needs to grab MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint() Reviewed-by: sla, mgerdin, dholmes, jmasa Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/instanceKlass.cpp From sundararajan.athijegannathan at oracle.com Mon May 27 01:21:17 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 27 May 2013 08:21:17 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20130527082121.4BF8A48D51@hg.openjdk.java.net> Changeset: 6fc7b51e83d6 Author: lagergren Date: 2013-05-23 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6fc7b51e83d6 8012522: Clean up lexical contexts - split out stack based functionality in CodeGenerator and generify NodeVisitors based on their LexicalContext type to avoid casts Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + src/jdk/nashorn/internal/codegen/CodeGeneratorLexicalContext.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/RangeAnalyzer.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java Changeset: fdfb4edd78d6 Author: hannesw Date: 2013-05-24 13:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fdfb4edd78d6 8011630: JSON parsing performance issue Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java Changeset: 4d2eca4d4d66 Author: sundar Date: 2013-05-24 18:39 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4d2eca4d4d66 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/Property.java + test/script/basic/JDK-8015354.js Changeset: 751cfefff5eb Author: sundar Date: 2013-05-24 23:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/751cfefff5eb 8015351: Nashorn shell does not start with Turkish locale Reviewed-by: jlaskey ! make/project.properties ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java From alex.schenkman at oracle.com Mon May 27 01:25:11 2013 From: alex.schenkman at oracle.com (Alex Schenkman) Date: Mon, 27 May 2013 10:25:11 +0200 Subject: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature Message-ID: <51A31867.9080602@oracle.com> Please review these tests for the Jdp protocol. There are three cases: 1) Jdp is off. 2) Jdp is on and using default address and port. 3) Jdp is on using custom address and port. Tests: http://cr.openjdk.java.net/~nloodin/8014506/webrev.00/ Jdp feature enhancement: https://jbs.oracle.com/bugs/browse/JDK-8002048 JDK CCC: http://ccc.us.oracle.com/8002048 Thanks in advance! -- Alex Schenkman Java VM SQE Stockholm -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130527/dae4fbca/attachment.html From chris.hegarty at oracle.com Mon May 27 03:05:20 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 27 May 2013 11:05:20 +0100 Subject: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows In-Reply-To: <5196C6CD.3070209@oracle.com> References: <50E16BA8.40203@oracle.com> <682D734D-2021-48DE-844D-C55A52D27EBD@oracle.com> <50EAB014.30805@oracle.com> <50EE813A.1020501@oracle.com> <50EEDC23.5080005@oracle.com> <50EF3622.9050500@oracle.com> <511119DA.5060806@oracle.com> <51118BEC.7000204@oracle.com> <511529DA.3050901@oracle.com> <5183BE7C.5060708@oracle.com> <5183C6D5.8070302@oracle.com> <51877204.8000104@oracle.com> <5189933E.40702@oracle.com> <518B6B8C.2080506@oracle.com> <5192BE69.4020003@oracle.com> <5193EC10.3050705@oracle.com> <5196C6CD.3070209@oracle.com> Message-ID: <51A32FE0.9030302@oracle.com> On 18/05/2013 01:09, Stuart Marks wrote: > On 5/15/13 1:12 PM, Jaroslav Bachorik wrote: >> Ok. I've changed it to use AtomicBoolean Thanks for pointing this out. >> Even though it's rather obvious I got so used to using the final array >> in anonymous inner classes that I didn't even stop and think. BTW, >> there are a lot of places in the tests using this idiom in potentially >> multithreaded environment :( > > Hrrm. OK, well, let's fix one test at a time. :-) > >> Updated webrev - >> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.10 > > Thanks for the update. I took a quick look at it seems fine now. > > I think Chris may need to be the OpenJDK Reviewer on this one. I've been over the archives to re-read the complete review thread on this. All in all, it is a thumbs up from me too. -Chris. > > s'marks From alexey.utkin at oracle.com Mon May 27 04:26:54 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Mon, 27 May 2013 11:26:54 +0000 Subject: hg: jdk8/tl/jdk: 8014394: (fs) WatchService failing when watching \\server\$d Message-ID: <20130527112721.034A448D58@hg.openjdk.java.net> Changeset: d78f91ab0e96 Author: uta Date: 2013-05-27 15:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d78f91ab0e96 8014394: (fs) WatchService failing when watching \\server\$d Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/classes/sun/nio/fs/WindowsWatchService.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c From david.holmes at oracle.com Mon May 27 04:34:19 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 27 May 2013 11:34:19 +0000 Subject: hg: jdk8/tl/jdk: 7038914: VM could throw uncaught OOME in ReferenceHandler thread Message-ID: <20130527113433.001D348D5A@hg.openjdk.java.net> Changeset: 0b8dab7fec54 Author: plevart Date: 2013-05-27 09:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b8dab7fec54 7038914: VM could throw uncaught OOME in ReferenceHandler thread Summary: Catch OutOfMemoryError in reference handler thread if caused by allocation of an InterruptedException Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/ref/Reference.java + test/java/lang/ref/OOMEInReferenceHandler.java From vicente.romero at oracle.com Mon May 27 05:44:46 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 27 May 2013 12:44:46 +0000 Subject: hg: jdk8/tl/langtools: 7030476: Fix conflicting use of JCTree/JCExpression Message-ID: <20130527124449.5A3AB48D5F@hg.openjdk.java.net> Changeset: b391ecea538e Author: vromero Date: 2013-05-27 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b391ecea538e 7030476: Fix conflicting use of JCTree/JCExpression Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java From nils.loodin at oracle.com Mon May 27 07:04:53 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 27 May 2013 16:04:53 +0200 Subject: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads In-Reply-To: <516E9DB9.8020009@oracle.com> References: <516E9DB9.8020009@oracle.com> Message-ID: <51A36805.6050001@oracle.com> I think this looks excellent. I can sponsor the change. Regards, Nils Loodin On 04/17/2013 03:03 PM, Mikael Auno wrote: > Hi, I'd like some reviews on > http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 > (http://bugs.sun.com/view_bug.do?bug_id=8009681). > > The issue here is that when MethodExitReturnValuesTest hooks into > MethodExit events through JDI it uses an exclude list to filter out > classes from which it is not interested in these events. This is bound > to break over and over again as new features are added to the JDK. I've > changed the test to use an include list instead, containing only the > handful of classes the test is actually interested in. > > Thanks, > Mikael From chris.hegarty at oracle.com Mon May 27 07:26:11 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 27 May 2013 14:26:11 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130527142657.20B0548D61@hg.openjdk.java.net> Changeset: a2dc42667df3 Author: chegar Date: 2013-05-27 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2dc42667df3 8015439: Minor/sync/cleanup of ConcurrentHashMap Reviewed-by: chegar Contributed-by: Doug Lea
, Chris Hegarty ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: 9bbf2237071e Author: chegar Date: 2013-05-27 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bbf2237071e Merge From nils.loodin at oracle.com Mon May 27 07:34:30 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 27 May 2013 16:34:30 +0200 Subject: RFR 6470730: Disconnect button leads to wrong popup message In-Reply-To: <22B1E7D2-3F7B-47CB-B474-5C7E4C31B6FB@oracle.com> References: <519F7590.5020700@oracle.com> <22B1E7D2-3F7B-47CB-B474-5C7E4C31B6FB@oracle.com> Message-ID: <51A36EF6.7050401@oracle.com> Could you please chime in? :) /Nisse On 05/24/2013 06:33 PM, Staffan Larsen wrote: > Looks good, but the indentation is wrong in one place. > > /Staffan > > On 24 maj 2013, at 16:13, Nils Loodin wrote: > >> Simple fix not to add a confusing dialog. >> >> Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 >> >> Webrev: >> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ >> >> Regards, >> Nils Loodin > From daniel.daugherty at oracle.com Mon May 27 07:47:48 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Mon, 27 May 2013 08:47:48 -0600 Subject: RFR 6470730: Disconnect button leads to wrong popup message In-Reply-To: <51A36EF6.7050401@oracle.com> References: <519F7590.5020700@oracle.com> <22B1E7D2-3F7B-47CB-B474-5C7E4C31B6FB@oracle.com> <51A36EF6.7050401@oracle.com> Message-ID: <51A37214.1080105@oracle.com> Sure! Chime!!! > http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ src/share/classes/sun/tools/jconsole/VMPanel.java No comments (presuming you fix the indentation on lines 458-459) Thumbs up! FYI: Mandy Chung is the person to ping if/when you have a more complicated jconsole fix... Dan On 5/27/13 8:34 AM, Nils Loodin wrote: > Could you please chime in? :) > > /Nisse > > On 05/24/2013 06:33 PM, Staffan Larsen wrote: >> Looks good, but the indentation is wrong in one place. >> >> /Staffan >> >> On 24 maj 2013, at 16:13, Nils Loodin wrote: >> >>> Simple fix not to add a confusing dialog. >>> >>> Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ >>> >>> Regards, >>> Nils Loodin >> > From nils.loodin at oracle.com Mon May 27 08:18:33 2013 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Mon, 27 May 2013 15:18:33 +0000 Subject: hg: jdk8/tl/jdk: 6470730: Disconnect button leads to wrong popup message Message-ID: <20130527151845.4F89448D64@hg.openjdk.java.net> Changeset: bbf6e6222726 Author: nloodin Date: 2013-05-27 17:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbf6e6222726 6470730: Disconnect button leads to wrong popup message Reviewed-by: dcubed, sla, egahlin ! src/share/classes/sun/tools/jconsole/VMPanel.java From daniel.daugherty at oracle.com Mon May 27 15:44:57 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Mon, 27 May 2013 22:44:57 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8015270: @Contended: fix multiple issues in the layout code Message-ID: <20130527224500.108AA48D6E@hg.openjdk.java.net> Changeset: 3970971c91e0 Author: shade Date: 2013-05-27 12:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3970971c91e0 8015270: @Contended: fix multiple issues in the layout code Summary: field count handling fixed, has_nonstatic_fields invariant fixed, oop map overrun fixed; new asserts Reviewed-by: kvn, dcubed, coleenp ! src/share/vm/classfile/classFileParser.cpp + test/runtime/contended/HasNonStatic.java + test/runtime/contended/OopMaps.java From mandy.chung at oracle.com Mon May 27 15:54:17 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 27 May 2013 15:54:17 -0700 Subject: RFR 6470730: Disconnect button leads to wrong popup message In-Reply-To: <51A37214.1080105@oracle.com> References: <519F7590.5020700@oracle.com> <22B1E7D2-3F7B-47CB-B474-5C7E4C31B6FB@oracle.com> <51A36EF6.7050401@oracle.com> <51A37214.1080105@oracle.com> Message-ID: <51A3E419.5060807@oracle.com> Looks good to me too except the indentation as Staffan pointed out (line 458-459) Mandy On 5/27/2013 7:47 AM, Daniel D. Daugherty wrote: > Sure! Chime!!! > > > http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ > > src/share/classes/sun/tools/jconsole/VMPanel.java > No comments (presuming you fix the indentation on lines 458-459) > > Thumbs up! > > FYI: Mandy Chung is the person to ping if/when you have a more > complicated jconsole fix... > > Dan > > > > On 5/27/13 8:34 AM, Nils Loodin wrote: >> Could you please chime in? :) >> >> /Nisse >> >> On 05/24/2013 06:33 PM, Staffan Larsen wrote: >>> Looks good, but the indentation is wrong in one place. >>> >>> /Staffan >>> >>> On 24 maj 2013, at 16:13, Nils Loodin wrote: >>> >>>> Simple fix not to add a confusing dialog. >>>> >>>> Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ >>>> >>>> Regards, >>>> Nils Loodin >>> >> > From staffan.larsen at oracle.com Mon May 27 23:46:30 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 28 May 2013 08:46:30 +0200 Subject: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads In-Reply-To: <516E9DB9.8020009@oracle.com> References: <516E9DB9.8020009@oracle.com> Message-ID: <62E7E237-46A6-46A7-8682-BE332F296F3D@oracle.com> Looks good. You could optimize it a bit by not doing the Arrays.asList() on every methodExit event. /Staffan On 17 apr 2013, at 15:03, Mikael Auno wrote: > Hi, I'd like some reviews on http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 (http://bugs.sun.com/view_bug.do?bug_id=8009681). > > The issue here is that when MethodExitReturnValuesTest hooks into MethodExit events through JDI it uses an exclude list to filter out classes from which it is not interested in these events. This is bound to break over and over again as new features are added to the JDK. I've changed the test to use an include list instead, containing only the handful of classes the test is actually interested in. > > Thanks, > Mikael From staffan.larsen at oracle.com Tue May 28 01:11:49 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 28 May 2013 10:11:49 +0200 Subject: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Message-ID: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> Please review the following fix: webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compacted the "usage" is returned as a higher-than-expect value. This can be changed with -XX:MarkSweepAlwaysCompactCount=1. Testing: I have rerun the test on a machine where it failed to make sure that it runs correctly with the extra flag. Thanks, /Staffan From nils.loodin at oracle.com Tue May 28 01:20:07 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Tue, 28 May 2013 10:20:07 +0200 Subject: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException In-Reply-To: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> References: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> Message-ID: <51A468B7.7060609@oracle.com> Looks good. /Nisse On 05/28/2013 10:11 AM, Staffan Larsen wrote: > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 > > The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compacted the "usage" is returned as a higher-than-expect value. This can be changed with -XX:MarkSweepAlwaysCompactCount=1. > > Testing: I have rerun the test on a machine where it failed to make sure that it runs correctly with the extra flag. > > Thanks, > /Staffan > From bengt.rutisson at oracle.com Tue May 28 01:34:05 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 28 May 2013 10:34:05 +0200 Subject: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException In-Reply-To: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> References: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> Message-ID: <51A46BFD.2030908@oracle.com> Staffan, Looks good. One minor question: Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount into the existing comment section rather than adding a new section for it? I think it might increase the chances that someone reads the comment if it is closer to the @run command. Not an important thing to fix. I'll leave it up to you how to do it. Thanks, Bengt On 5/28/13 10:11 AM, Staffan Larsen wrote: > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 > > The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compacted the "usage" is returned as a higher-than-expect value. This can be changed with -XX:MarkSweepAlwaysCompactCount=1. > > Testing: I have rerun the test on a machine where it failed to make sure that it runs correctly with the extra flag. > > Thanks, > /Staffan From peter.allwin at oracle.com Tue May 28 01:42:11 2013 From: peter.allwin at oracle.com (Peter Allwin) Date: Tue, 28 May 2013 01:42:11 -0700 (PDT) Subject: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Message-ID: <40b0622b-e65a-4349-84e2-e1a74fb67a9e@default> Looking good to me. /peter ----- Original Message ----- From: nils.loodin at oracle.com To: serviceability-dev at openjdk.java.net Sent: Tuesday, May 28, 2013 10:36:20 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Looks good. /Nisse On 05/28/2013 10:11 AM, Staffan Larsen wrote: > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 > > The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compacted the "usage" is returned as a higher-than-expect value. This can be changed with -XX:MarkSweepAlwaysCompactCount=1. > > Testing: I have rerun the test on a machine where it failed to make sure that it runs correctly with the extra flag. > > Thanks, > /Staffan > From staffan.larsen at oracle.com Tue May 28 01:56:13 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 28 May 2013 10:56:13 +0200 Subject: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException In-Reply-To: <51A46BFD.2030908@oracle.com> References: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> <51A46BFD.2030908@oracle.com> Message-ID: <917926ED-D590-42BD-8169-62B7926FDF10@oracle.com> On 28 maj 2013, at 10:34, Bengt Rutisson wrote: > > Staffan, > > Looks good. > > One minor question: > > Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount into the existing comment section rather than adding a new section for it? I think it might increase the chances that someone reads the comment if it is closer to the @run command. Yeah, I wanted it right before the @run tag, but jtreg got all confused so I moved it to a separate section. /Staffan > > Not an important thing to fix. I'll leave it up to you how to do it. > > Thanks, > Bengt > > On 5/28/13 10:11 AM, Staffan Larsen wrote: >> Please review the following fix: >> >> webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 >> >> The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compacted the "usage" is returned as a higher-than-expect value. This can be changed with -XX:MarkSweepAlwaysCompactCount=1. >> >> Testing: I have rerun the test on a machine where it failed to make sure that it runs correctly with the extra flag. >> >> Thanks, >> /Staffan > From bengt.rutisson at oracle.com Tue May 28 02:14:44 2013 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 28 May 2013 11:14:44 +0200 Subject: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException In-Reply-To: <917926ED-D590-42BD-8169-62B7926FDF10@oracle.com> References: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> <51A46BFD.2030908@oracle.com> <917926ED-D590-42BD-8169-62B7926FDF10@oracle.com> Message-ID: <51A47584.3030803@oracle.com> On 5/28/13 10:56 AM, Staffan Larsen wrote: > On 28 maj 2013, at 10:34, Bengt Rutisson wrote: > >> Staffan, >> >> Looks good. >> >> One minor question: >> >> Would it make sense to move the comment regarding MarkSweepAlwaysCompactCount into the existing comment section rather than adding a new section for it? I think it might increase the chances that someone reads the comment if it is closer to the @run command. > Yeah, I wanted it right before the @run tag, but jtreg got all confused so I moved it to a separate section. OK. Thanks for trying. Ship it! Bengt > > /Staffan > >> Not an important thing to fix. I'll leave it up to you how to do it. >> >> Thanks, >> Bengt >> >> On 5/28/13 10:11 AM, Staffan Larsen wrote: >>> Please review the following fix: >>> >>> webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 >>> >>> The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compacted the "usage" is returned as a higher-than-expect value. This can be changed with -XX:MarkSweepAlwaysCompactCount=1. >>> >>> Testing: I have rerun the test on a machine where it failed to make sure that it runs correctly with the extra flag. >>> >>> Thanks, >>> /Staffan From vicente.romero at oracle.com Tue May 28 04:46:48 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 28 May 2013 11:46:48 +0000 Subject: hg: jdk8/tl/langtools: 6970173: Debug pointer at bad position Message-ID: <20130528114652.D07EF48D80@hg.openjdk.java.net> Changeset: c6df5b20f9eb Author: vromero Date: 2013-05-28 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c6df5b20f9eb 6970173: Debug pointer at bad position Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T6970173/DebugPointerAtBadPositionTest.java From jaroslav.bachorik at oracle.com Tue May 28 06:13:34 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 28 May 2013 15:13:34 +0200 Subject: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object Message-ID: <51A4AD7E.3080701@oracle.com> Please, review the fix for JDK-8002307. The fix assures the immutability by cloning the provided arrays in the constructor and then cloning them again in the getters. The constructors are fixed in the javax/management/MBeanInfo.java and the arrays used in getters are cloned using an already existing functionality in the same class. http://cr.openjdk.java.net/~jbachorik/8002307/webrev.01 Thanks, -JB- From jaroslav.bachorik at oracle.com Tue May 28 07:06:25 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Tue, 28 May 2013 14:06:25 +0000 Subject: hg: jdk8/tl/jdk: 8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows Message-ID: <20130528140637.E54C248D8B@hg.openjdk.java.net> Changeset: 7d9fab5d86cd Author: jbachorik Date: 2013-05-28 15:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d9fab5d86cd 8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows Reviewed-by: chegar, smarks, dfuchs ! test/ProblemList.txt ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh From jaroslav.bachorik at oracle.com Tue May 28 07:22:16 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 28 May 2013 16:22:16 +0200 Subject: RFR: 8010285 Enforce the requirement of Management Interfaces being public Message-ID: <51A4BD98.1040704@oracle.com> The fix enforces the management interfaces (read MBean and MXBean interfaces) being public. While this is defined in the specification it was not enforced in any way and it was allowed to create MBeans for eg. private MBean interfaces. The fix adds checks when creating and registering MBeans and throws javax.management.NotCompliantMBeanException when a user tries to create an MBean with non-public management interface. Since this change can cause problems for users having non-public management interfaces a system property is introduced that will revert to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). Thanks, -JB- From dmitry.samersoff at oracle.com Tue May 28 07:47:20 2013 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Tue, 28 May 2013 14:47:20 +0000 Subject: hg: jdk8/tl/jdk: 8014420: Default JDP address does not match the one assigned by IANA Message-ID: <20130528144753.CA50E48D8D@hg.openjdk.java.net> Changeset: 7d7bfce34a79 Author: dsamersoff Date: 2013-05-28 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7bfce34a79 8014420: Default JDP address does not match the one assigned by IANA Summary: JDP protocol defaults changed to IANA assigned values Reviewed-by: dholmes, jbachorik, hirt Contributed-by: fweimer at redhat.com ! src/share/classes/sun/management/Agent.java ! src/share/classes/sun/management/jdp/package-info.java ! test/sun/management/jdp/JdpTest.sh From peter.allwin at oracle.com Tue May 28 08:03:26 2013 From: peter.allwin at oracle.com (Peter Allwin) Date: Tue, 28 May 2013 08:03:26 -0700 (PDT) Subject: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object Message-ID: <4c77d660-2a57-4e36-b944-26b43567e9be@default> Hi Jaroslav, Just one comment, should we get rid of the static empty arrays in ModelMBeanInfoSupport.java now that they're not in use? 343 private static final ModelMBeanAttributeInfo[] NO_ATTRIBUTES = 344 new ModelMBeanAttributeInfo[0]; 345 private static final ModelMBeanConstructorInfo[] NO_CONSTRUCTORS = 346 new ModelMBeanConstructorInfo[0]; 347 private static final ModelMBeanNotificationInfo[] NO_NOTIFICATIONS = 348 new ModelMBeanNotificationInfo[0]; 349 private static final ModelMBeanOperationInfo[] NO_OPERATIONS = 350 new ModelMBeanOperationInfo[0]; Other than that it looks good to me! Thanks! /peter ----- Original Message ----- From: jaroslav.bachorik at oracle.com To: serviceability-dev at openjdk.java.net Sent: Tuesday, May 28, 2013 3:29:17 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object Please, review the fix for JDK-8002307. The fix assures the immutability by cloning the provided arrays in the constructor and then cloning them again in the getters. The constructors are fixed in the javax/management/MBeanInfo.java and the arrays used in getters are cloned using an already existing functionality in the same class. http://cr.openjdk.java.net/~jbachorik/8002307/webrev.01 Thanks, -JB- From rob.mckenna at oracle.com Tue May 28 08:35:11 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 28 May 2013 15:35:11 +0000 Subject: hg: jdk8/tl/jdk: 7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys Message-ID: <20130528153537.D27B148D8F@hg.openjdk.java.net> Changeset: b16a8b4ae6b4 Author: robm Date: 2013-05-28 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16a8b4ae6b4 7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys Reviewed-by: alanb ! src/windows/native/java/io/WinNTFileSystem_md.c ! test/java/io/File/IsHidden.java From christian.tornqvist at oracle.com Tue May 28 08:51:07 2013 From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com) Date: Tue, 28 May 2013 15:51:07 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8015329: Print reason for failed MiniDumpWriteDump() call Message-ID: <20130528155117.5D09448D91@hg.openjdk.java.net> Changeset: a213d425d87a Author: ctornqvi Date: 2013-05-28 15:08 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a213d425d87a 8015329: Print reason for failed MiniDumpWriteDump() call Summary: Printing both result from GetLastError and text representation of error. Also changed so that we produce dumps by default on client versions of Windows when running with a debug build. Also reviewed by peter.allwin at oracle.com Reviewed-by: sla, dholmes ! src/os/windows/vm/os_windows.cpp From vicente.romero at oracle.com Tue May 28 09:40:30 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 28 May 2013 16:40:30 +0000 Subject: hg: jdk8/tl/langtools: 8012333: javac, ClassFile should have a read(Path) method Message-ID: <20130528164037.CB39048D96@hg.openjdk.java.net> Changeset: d042cba65eab Author: vromero Date: 2013-05-28 17:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d042cba65eab 8012333: javac, ClassFile should have a read(Path) method Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/ClassFile.java From xueming.shen at oracle.com Tue May 28 10:45:00 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 28 May 2013 17:45:00 +0000 Subject: hg: jdk8/tl/jdk: 8001750: CharsetDecoder.replacement should not be changeable except via replaceWith method Message-ID: <20130528174551.2A37B48D9A@hg.openjdk.java.net> Changeset: 7fa2d1dcb8f6 Author: sherman Date: 2013-05-28 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fa2d1dcb8f6 8001750: CharsetDecoder.replacement should not be changeable except via replaceWith method Summary: to make defensive copy for set/get replacement byte array Reviewed-by: martin ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! src/share/classes/sun/nio/cs/ext/HKSCS.java From mandy.chung at oracle.com Tue May 28 10:57:06 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 28 May 2013 10:57:06 -0700 Subject: RFR (S): 8015440 java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException In-Reply-To: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> References: <97E7FD85-81F0-4F29-B487-3704312E868F@oracle.com> Message-ID: <51A4EFF2.8050002@oracle.com> Good catch. Looks good. There are other j.l.management tests that force GC to happen and I'm not sure if any of them requires similar fix. Might be worth to check if any of them has similar assumption. Mandy On 5/28/13 1:11 AM, Staffan Larsen wrote: > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sla/8015440/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015440 > > The problem is that serial gc does not compact the heap at every full gc but only every 4th full gc (by default). When the heap isn't compacted the "usage" is returned as a higher-than-expect value. This can be changed with -XX:MarkSweepAlwaysCompactCount=1. > > Testing: I have rerun the test on a machine where it failed to make sure that it runs correctly with the extra flag. > > Thanks, > /Staffan From zhengyu.gu at oracle.com Tue May 28 11:30:11 2013 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Tue, 28 May 2013 18:30:11 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130528183017.F057F48D9B@hg.openjdk.java.net> Changeset: 51af5fae397d Author: ccheung Date: 2013-05-24 17:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/51af5fae397d 8015265: revise the fix for 8007037 Reviewed-by: sspitsyn, dholmes, dcubed ! src/share/vm/oops/constantPool.cpp Changeset: 4cc7d4d5dc92 Author: zgu Date: 2013-05-28 08:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4cc7d4d5dc92 Merge From jaroslav.bachorik at oracle.com Tue May 28 12:32:35 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 28 May 2013 21:32:35 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A4BD98.1040704@oracle.com> References: <51A4BD98.1040704@oracle.com> Message-ID: <51A50653.9080901@oracle.com> And the webrev would come handy, of course. http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ -JB- On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: > The fix enforces the management interfaces (read MBean and MXBean > interfaces) being public. While this is defined in the specification it > was not enforced in any way and it was allowed to create MBeans for eg. > private MBean interfaces. > > The fix adds checks when creating and registering MBeans and throws > javax.management.NotCompliantMBeanException when a user tries to create > an MBean with non-public management interface. > > Since this change can cause problems for users having non-public > management interfaces a system property is introduced that will revert > to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). > > Thanks, > > -JB- > From daniel.daugherty at oracle.com Tue May 28 13:58:17 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Tue, 28 May 2013 20:58:17 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20130528205831.CC1BA48DA5@hg.openjdk.java.net> Changeset: 01c2bdd24bb5 Author: shade Date: 2013-05-28 19:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/01c2bdd24bb5 8015493: runtime/contended/OopMaps.java fails with OutOfMemory Summary: limit the memory footprint to dodge OutOfMemory errors. Reviewed-by: dcubed, ctornqvi, iignatyev ! test/runtime/contended/OopMaps.java Changeset: 9ea643afcaaf Author: dcubed Date: 2013-05-28 11:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9ea643afcaaf Merge From naoto.sato at oracle.com Tue May 28 14:03:16 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 28 May 2013 21:03:16 +0000 Subject: hg: jdk8/tl/jdk: 6251788: (rb) PropertyResourceBundle doesn't document exceptions Message-ID: <20130528210343.3E15D48DA6@hg.openjdk.java.net> Changeset: b99d56d1aa3f Author: naoto Date: 2013-05-28 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b99d56d1aa3f 6251788: (rb) PropertyResourceBundle doesn't document exceptions Reviewed-by: okutsu ! src/share/classes/java/util/PropertyResourceBundle.java From xuelei.fan at oracle.com Tue May 28 18:48:31 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 29 May 2013 01:48:31 +0000 Subject: hg: jdk8/tl/jdk: 8010815: some constructors issues in com.sun.jndi.toolkit Message-ID: <20130529014906.C8A5548DBA@hg.openjdk.java.net> Changeset: 1652a22cf6e7 Author: xuelei Date: 2013-05-28 18:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1652a22cf6e7 8010815: some constructors issues in com.sun.jndi.toolkit Reviewed-by: alanb ! src/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java ! src/share/classes/com/sun/jndi/toolkit/dir/LazySearchEnumerationImpl.java ! src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java From david.holmes at oracle.com Tue May 28 19:08:31 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 29 May 2013 12:08:31 +1000 Subject: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object In-Reply-To: <51A4AD7E.3080701@oracle.com> References: <51A4AD7E.3080701@oracle.com> Message-ID: <51A5631F.6020801@oracle.com> On 28/05/2013 11:13 PM, Jaroslav Bachorik wrote: > Please, review the fix for JDK-8002307. > > The fix assures the immutability by cloning the provided arrays in the > constructor and then cloning them again in the getters. This fix has the same problems/issues as 8010815: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/016930.html It is not obvious that the specification of these classes allows for cloning, nor that people using this won't expect external changes to the arrays to be passed through. The use of "immutability" in the spec for MBeanInfo is ambiguous. It might just mean that the references to the arrays never change. It need not imply/require "deep" immutability. If we want to do this aggressive defensive copying to placate FindBugs (which is simply flagging things to pay attention to, not that are necessarily incorrect) then I think spec updates may also be required. David ----- > The constructors are fixed in the javax/management/MBeanInfo.java and > the arrays used in getters are cloned using an already existing > functionality in the same class. > > http://cr.openjdk.java.net/~jbachorik/8002307/webrev.01 > > Thanks, > > -JB- > From ioi.lam at oracle.com Tue May 28 19:47:55 2013 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Wed, 29 May 2013 02:47:55 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014912: Restore PrintSharedSpaces functionality after NPG Message-ID: <20130529024800.0934948DBB@hg.openjdk.java.net> Changeset: a1ebd310d5c1 Author: iklam Date: 2013-05-28 16:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1ebd310d5c1 8014912: Restore PrintSharedSpaces functionality after NPG Summary: Added dumping of object sizes in CDS archive, sorted by MetaspaceObj::Type Reviewed-by: coleenp, acorn ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/methodCounters.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/symbol.cpp ! src/share/vm/utilities/array.hpp From dan.xu at oracle.com Tue May 28 22:25:24 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Wed, 29 May 2013 05:25:24 +0000 Subject: hg: jdk8/tl/jdk: 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently Message-ID: <20130529052537.1FE4848DBF@hg.openjdk.java.net> Changeset: e59d7f0f36f7 Author: ewang Date: 2013-05-28 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e59d7f0f36f7 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently Reviewed-by: dxu, alanb Contributed-by: yiming.wang at oracle.com ! test/java/io/pathNames/General.java ! test/java/io/pathNames/GeneralWin32.java From staffan.larsen at oracle.com Wed May 29 00:43:11 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 29 May 2013 07:43:11 +0000 Subject: hg: jdk8/tl/jdk: 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Message-ID: <20130529074332.6E97C48DC3@hg.openjdk.java.net> Changeset: bd6d3801347b Author: sla Date: 2013-05-29 09:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6d3801347b 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Summary: Make sure serial gc compacts heap every time Reviewed-by: mchung, brutisso, nloodin ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java From david.holmes at oracle.com Wed May 29 01:09:38 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 29 May 2013 18:09:38 +1000 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A50653.9080901@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A50653.9080901@oracle.com> Message-ID: <51A5B7C2.1050009@oracle.com> Hi Jaroslav, Just wondering why this needs to be public: + public static void testComplianceMBeanInterface(Class interfaceClass) + throws NotCompliantMBeanException{ + StandardMBeanIntrospector.getInstance().getAnalyzer(interfaceClass); + } Same question goes for the existing testComplianceMXBeanInterface. These are public methods on public classes but have no specification written for them. ??? David On 29/05/2013 5:32 AM, Jaroslav Bachorik wrote: > And the webrev would come handy, of course. > > http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ > > -JB- > > On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >> The fix enforces the management interfaces (read MBean and MXBean >> interfaces) being public. While this is defined in the specification it >> was not enforced in any way and it was allowed to create MBeans for eg. >> private MBean interfaces. >> >> The fix adds checks when creating and registering MBeans and throws >> javax.management.NotCompliantMBeanException when a user tries to create >> an MBean with non-public management interface. >> >> Since this change can cause problems for users having non-public >> management interfaces a system property is introduced that will revert >> to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >> >> Thanks, >> >> -JB- >> > From erik.helin at oracle.com Wed May 29 01:44:31 2013 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 29 May 2013 10:44:31 +0200 Subject: RFR: 8013590: NPG: Add a memory pool MXBean for Metaspace Message-ID: <20130529084430.GD1956@ehelin-thinkpad> Hi all, this want sent to hotspot-gc-dev at openjdk.java.net, sending to serviceability-dev at openjdk.java.net as well since the change is about memory pools. This change adds two memory pools for metaspace, one for Metaspace and one for compressed klass space. The memory pool for compressed klass space will only have valus that differ from 0 or -1 (undefined) if compressed klass pointers are used. Question: Should I use an empty pool when compressed klass pointers are *not* used or should I just not expose the pool? This change also adds a manager for the pools: Metaspace Manager. I have also added a test that checks that the metaspace manager is present and that the two pools are present. The test also verifies that the compressed klass space pool act correct according to the UseCompressedKlass flag. The last time I added metaspace memory pools, it triggered some unforeseen bugs: - Two asserts in jmm_GetMemoryUsage that asserted that a memory pool was either of heap type or had an undefined init/max size. - The jdk/test/java/lang/management/MemoryMXBean/MemoryTest.java failed - The service lock was taken out of order with the metaspace locks These bugs have all been fixed: - The asserts have been removed since they are no longer true - The test has been updated but is not part of this change since it is a JDK change - This change does not make use of functions requiring the metaspace lock. I had to remove some verification code in free_chunks_total to ensure this. Webrev: http://cr.openjdk.java.net/~ehelin/8013590/webrev.00/ Testing: - One new jtreg test - JPRT - All the tests that failed in nighly testing last time now pass Thanks, Erik From jaroslav.bachorik at oracle.com Wed May 29 02:04:06 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 29 May 2013 11:04:06 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A5B7C2.1050009@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A50653.9080901@oracle.com> <51A5B7C2.1050009@oracle.com> Message-ID: <51A5C486.9010502@oracle.com> On Wed 29 May 2013 10:09:38 AM CEST, David Holmes wrote: > Hi Jaroslav, > > Just wondering why this needs to be public: > > + public static void testComplianceMBeanInterface(Class > interfaceClass) > + throws NotCompliantMBeanException{ > + StandardMBeanIntrospector.getInstance().getAnalyzer(interfaceClass); > + } > > Same question goes for the existing testComplianceMXBeanInterface. > These are public methods on public classes but have no specification > written for them. ??? The problem is that those methods need to be accessible from javax.management.JMX - the package private access would not work. Even though they are not meant to be used outside of the JDK code we can not prevent it and adding javadocs to them is definitely needed. -JB- > > David > > On 29/05/2013 5:32 AM, Jaroslav Bachorik wrote: >> And the webrev would come handy, of course. >> >> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ >> >> -JB- >> >> On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >>> The fix enforces the management interfaces (read MBean and MXBean >>> interfaces) being public. While this is defined in the specification it >>> was not enforced in any way and it was allowed to create MBeans for eg. >>> private MBean interfaces. >>> >>> The fix adds checks when creating and registering MBeans and throws >>> javax.management.NotCompliantMBeanException when a user tries to create >>> an MBean with non-public management interface. >>> >>> Since this change can cause problems for users having non-public >>> management interfaces a system property is introduced that will revert >>> to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >>> >>> Thanks, >>> >>> -JB- >>> >> From alan.bateman at oracle.com Wed May 29 02:28:15 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 29 May 2013 09:28:15 +0000 Subject: hg: jdk8/tl/jdk: 8014928: (fs) Files.readAllBytes() copies content to new array when content completely read Message-ID: <20130529092901.8F87148DCF@hg.openjdk.java.net> Changeset: 2b3242a69a44 Author: alanb Date: 2013-05-29 10:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b3242a69a44 8014928: (fs) Files.readAllBytes() copies content to new array when content completely read Reviewed-by: martin ! src/share/classes/java/nio/file/Files.java From vicente.romero at oracle.com Wed May 29 02:58:03 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 29 May 2013 09:58:03 +0000 Subject: hg: jdk8/tl/langtools: 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Message-ID: <20130529095809.94FF848DD1@hg.openjdk.java.net> Changeset: 92e420e9807d Author: vromero Date: 2013-05-29 10:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92e420e9807d 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/T7053059/VerifyErrorWithDoubleAssignmentTest.java From shanliang.jiang at oracle.com Wed May 29 04:18:50 2013 From: shanliang.jiang at oracle.com (shanliang) Date: Wed, 29 May 2013 13:18:50 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A50653.9080901@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A50653.9080901@oracle.com> Message-ID: <51A5E41A.7010601@oracle.com> Jaroslav, Introspector.java --------------------- Line 496 - 515 It is good to do check: (Modifier.isPublic(c.getModifiers()) || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) but it is not necessary if an interface is not equal to clMBeanName. is it possible to simplify the method as: private static Class implementsMBean(Class c, String clName) { Class ret = null; try { Class clMBeanClass = Class.forName(clName + "MBean"); List list = Arrays.asList(c.getInterfaces()); if (list.contains(clMBeanClass) && (Modifier.isPublic(clMBeanClass.getModifiers()) || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN)) { ret = clMBeanClass; } } catch (ClassNotFoundException cne) { // clMBeanClass does not exist? } return ret; } Is there any special reason to not have a unit test? Shanliang Jaroslav Bachorik wrote: > And the webrev would come handy, of course. > > http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ > > -JB- > > On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: > >> The fix enforces the management interfaces (read MBean and MXBean >> interfaces) being public. While this is defined in the specification it >> was not enforced in any way and it was allowed to create MBeans for eg. >> private MBean interfaces. >> >> The fix adds checks when creating and registering MBeans and throws >> javax.management.NotCompliantMBeanException when a user tries to create >> an MBean with non-public management interface. >> >> Since this change can cause problems for users having non-public >> management interfaces a system property is introduced that will revert >> to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >> >> Thanks, >> >> -JB- >> >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130529/17c0f066/attachment.html From jaroslav.bachorik at oracle.com Wed May 29 05:53:50 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 29 May 2013 14:53:50 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A5E41A.7010601@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A50653.9080901@oracle.com> <51A5E41A.7010601@oracle.com> Message-ID: <51A5FA5E.8060403@oracle.com> On Wed 29 May 2013 01:18:50 PM CEST, shanliang wrote: > Jaroslav, > > Introspector.java > --------------------- > Line 496 - 515 > It is good to do check: > (Modifier.isPublic(c.getModifiers()) || > MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) > but it is not necessary if an interface is not equal to clMBeanName. This is being checked within the same condition. > > is it possible to simplify the method as: > private static Class implementsMBean(Class c, > String clName) { > Class ret = null; > > try { > Class clMBeanClass = Class.forName(clName + "MBean"); > List list = Arrays.asList(c.getInterfaces()); > > if (list.contains(clMBeanClass) > && (Modifier.isPublic(clMBeanClass.getModifiers()) > || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN)) { > ret = clMBeanClass; > } > } catch (ClassNotFoundException cne) { > // clMBeanClass does not exist? > } > > return ret; > } > This would not be the best for the current situation - when I took a closer look at the code it seems to contain a bug that makes searching for an associate MBean interface much more complex than necessary (getStandardMBeanInterface() walks up the class hierarchy and calls findMBeanInterface() which does its own hierarchy crawl for the same classes). I will try to fix and optimize the code - the Class.forName() seems to be a rather good approach. > Is there any special reason to not have a unit test? Nope. They were not finished - they will be the part of the next update to the webrev. -JB- > > Shanliang > > > Jaroslav Bachorik wrote: >> And the webrev would come handy, of course. >> >> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ >> >> -JB- >> >> On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >> >>> The fix enforces the management interfaces (read MBean and MXBean >>> interfaces) being public. While this is defined in the specification it >>> was not enforced in any way and it was allowed to create MBeans for eg. >>> private MBean interfaces. >>> >>> The fix adds checks when creating and registering MBeans and throws >>> javax.management.NotCompliantMBeanException when a user tries to create >>> an MBean with non-public management interface. >>> >>> Since this change can cause problems for users having non-public >>> management interfaces a system property is introduced that will revert >>> to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >>> >>> Thanks, >>> >>> -JB- >>> >>> >> >> > From daniel.fuchs at oracle.com Wed May 29 06:38:59 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 29 May 2013 15:38:59 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A5E41A.7010601@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A50653.9080901@oracle.com> <51A5E41A.7010601@oracle.com> Message-ID: <51A604F3.8040207@oracle.com> On 5/29/13 1:18 PM, shanliang wrote: > Jaroslav, > > Introspector.java > --------------------- > Line 496 - 515 > It is good to do check: > (Modifier.isPublic(c.getModifiers()) || > MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) > but it is not necessary if an interface is not equal to clMBeanName. > > is it possible to simplify the method as: > private static Class implementsMBean(Class c, > String clName) { > Class ret = null; > > try { > Class clMBeanClass = Class.forName(clName + "MBean"); Hi Shanliang, I 'm not sure whether that would actually simplify anything. Is attempting to load a class (which BTW would require to pass the appropriate ClassLoader to Class.forName) faster or simpler than using the current algorithm? But you're right - in isMBeanInterface the first check should probably be c.getName().equals(clMBeanName). -- daniel > List list = Arrays.asList(c.getInterfaces()); > > if (list.contains(clMBeanClass) > && (Modifier.isPublic(clMBeanClass.getModifiers()) > || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN)) { > ret = clMBeanClass; > } > } catch (ClassNotFoundException cne) { > // clMBeanClass does not exist? > } > > return ret; > } > > Is there any special reason to not have a unit test? > > Shanliang > > > Jaroslav Bachorik wrote: >> And the webrev would come handy, of course. >> >> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ >> >> -JB- >> >> On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >> >>> The fix enforces the management interfaces (read MBean and MXBean >>> interfaces) being public. While this is defined in the specification it >>> was not enforced in any way and it was allowed to create MBeans for eg. >>> private MBean interfaces. >>> >>> The fix adds checks when creating and registering MBeans and throws >>> javax.management.NotCompliantMBeanException when a user tries to create >>> an MBean with non-public management interface. >>> >>> Since this change can cause problems for users having non-public >>> management interfaces a system property is introduced that will revert >>> to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >>> >>> Thanks, >>> >>> -JB- >>> >>> >> >> > From vincent.x.ryan at oracle.com Wed May 29 06:59:02 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Wed, 29 May 2013 13:59:02 +0000 Subject: hg: jdk8/tl/jdk: 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate Message-ID: <20130529135914.E179548DDF@hg.openjdk.java.net> Changeset: 00ad19610e75 Author: vinnie Date: 2013-05-29 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00ad19610e75 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java From jaroslav.bachorik at oracle.com Wed May 29 07:44:49 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 29 May 2013 16:44:49 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A604F3.8040207@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A50653.9080901@oracle.com> <51A5E41A.7010601@oracle.com> <51A604F3.8040207@oracle.com> Message-ID: <51A61461.1050903@oracle.com> On Wed 29 May 2013 03:38:59 PM CEST, Daniel Fuchs wrote: > On 5/29/13 1:18 PM, shanliang wrote: >> Jaroslav, >> >> Introspector.java >> --------------------- >> Line 496 - 515 >> It is good to do check: >> (Modifier.isPublic(c.getModifiers()) || >> MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) >> but it is not necessary if an interface is not equal to clMBeanName. >> >> is it possible to simplify the method as: >> private static Class implementsMBean(Class c, >> String clName) { >> Class ret = null; >> >> try { >> Class clMBeanClass = Class.forName(clName + "MBean"); > > Hi Shanliang, > > I 'm not sure whether that would actually simplify anything. > Is attempting to load a class (which BTW would require to pass > the appropriate ClassLoader to Class.forName) faster or simpler > than using the current algorithm? Well, it seems to simplify the algorithm a bit. Currently, the run includes walking up the class hierarchy, retrieving all the interfaces for a class being inspected and the superinterfaces of the interfaces recursively, to check if any of them complies with the MBean interface naming. This can turn out to be a quite expensive process. Additionally, the current implementation seems to go through only 2 levels of interfaces (the interfaces implemented by the inspected class and their direct super interfaces) and it can fail to resolve an MBean interface in some corner cases. On the other hand, when using the Class.forName() it is enough to walk up the super class hierarchy, try to load a MBean class for each inspected class and determine whether such interface exists and is a valid MBean interface. I am not sure how expensive is trying to load a non-existent class but Class.getInterfaces() is a native method as well as Class.forName0() generating the same JNI overhead. -JB- > > But you're right - in isMBeanInterface the first check should > probably be c.getName().equals(clMBeanName). > > -- daniel > >> List list = Arrays.asList(c.getInterfaces()); >> >> if (list.contains(clMBeanClass) >> && (Modifier.isPublic(clMBeanClass.getModifiers()) >> || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN)) { >> ret = clMBeanClass; >> } >> } catch (ClassNotFoundException cne) { >> // clMBeanClass does not exist? >> } >> >> return ret; >> } >> >> Is there any special reason to not have a unit test? >> >> Shanliang >> >> >> Jaroslav Bachorik wrote: >>> And the webrev would come handy, of course. >>> >>> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ >>> >>> -JB- >>> >>> On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >>> >>>> The fix enforces the management interfaces (read MBean and MXBean >>>> interfaces) being public. While this is defined in the >>>> specification it >>>> was not enforced in any way and it was allowed to create MBeans for >>>> eg. >>>> private MBean interfaces. >>>> >>>> The fix adds checks when creating and registering MBeans and throws >>>> javax.management.NotCompliantMBeanException when a user tries to >>>> create >>>> an MBean with non-public management interface. >>>> >>>> Since this change can cause problems for users having non-public >>>> management interfaces a system property is introduced that will revert >>>> to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >>>> >>>> Thanks, >>>> >>>> -JB- >>>> >>>> >>> >>> >> > From jaroslav.bachorik at oracle.com Wed May 29 07:56:30 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 29 May 2013 16:56:30 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A4BD98.1040704@oracle.com> References: <51A4BD98.1040704@oracle.com> Message-ID: <51A6171E.8040606@oracle.com> Updated webrev - http://cr.openjdk.java.net/~jbachorik/8010285/webrev.01 It adds regtests and takes care of the comments from David and Shanliang. -JB- On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: > The fix enforces the management interfaces (read MBean and MXBean > interfaces) being public. While this is defined in the specification it > was not enforced in any way and it was allowed to create MBeans for eg. > private MBean interfaces. > > The fix adds checks when creating and registering MBeans and throws > javax.management.NotCompliantMBeanException when a user tries to create > an MBean with non-public management interface. > > Since this change can cause problems for users having non-public > management interfaces a system property is introduced that will revert > to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). > > Thanks, > > -JB- > From daniel.fuchs at oracle.com Wed May 29 08:03:47 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 29 May 2013 17:03:47 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A61461.1050903@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A50653.9080901@oracle.com> <51A5E41A.7010601@oracle.com> <51A604F3.8040207@oracle.com> <51A61461.1050903@oracle.com> Message-ID: <51A618D3.6070200@oracle.com> On 5/29/13 4:44 PM, Jaroslav Bachorik wrote: > On Wed 29 May 2013 03:38:59 PM CEST, Daniel Fuchs wrote: >> On 5/29/13 1:18 PM, shanliang wrote: >>> Jaroslav, >>> >>> Introspector.java >>> --------------------- >>> Line 496 - 515 >>> It is good to do check: >>> (Modifier.isPublic(c.getModifiers()) || >>> MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN) >>> but it is not necessary if an interface is not equal to clMBeanName. >>> >>> is it possible to simplify the method as: >>> private static Class implementsMBean(Class c, >>> String clName) { >>> Class ret = null; >>> >>> try { >>> Class clMBeanClass = Class.forName(clName + "MBean"); >> >> Hi Shanliang, >> >> I 'm not sure whether that would actually simplify anything. >> Is attempting to load a class (which BTW would require to pass >> the appropriate ClassLoader to Class.forName) faster or simpler >> than using the current algorithm? > > Well, it seems to simplify the algorithm a bit. Currently, the run > includes walking up the class hierarchy, retrieving all the interfaces > for a class being inspected and the superinterfaces of the interfaces > recursively, to check if any of them complies with the MBean interface > naming. This can turn out to be a quite expensive process. > Additionally, the current implementation seems to go through only 2 > levels of interfaces (the interfaces implemented by the inspected class > and their direct super interfaces) and it can fail to resolve an MBean > interface in some corner cases. > > On the other hand, when using the Class.forName() it is enough to walk > up the super class hierarchy, try to load a MBean class for > each inspected class and determine whether such interface exists and is > a valid MBean interface. I am not sure how expensive is trying to load > a non-existent class but Class.getInterfaces() is a native method as > well as Class.forName0() generating the same JNI overhead. > > -JB- I would be wary of changing this code without extensive testing. You will have to read the spec in details and make sure that you haven't forgotten anything. For a given implementation class there may be several interfaces that match the MBean interface pattern - and the spec clearly defines which should have precedence. For instance if you have: a.AImpl extends a.A extends b.BImpl extends b.B extends c.C implements a.AMBean { } with c.C implements c.CMBean, b.BMBean { } then which is the MBean interface for a.AImpl? I think it's b.BMBean - although I would have to read the spec twice to be really sure ;-) -- daniel > >> >> But you're right - in isMBeanInterface the first check should >> probably be c.getName().equals(clMBeanName). >> >> -- daniel >> >>> List list = Arrays.asList(c.getInterfaces()); >>> >>> if (list.contains(clMBeanClass) >>> && (Modifier.isPublic(clMBeanClass.getModifiers()) >>> || MBeanAnalyzer.ALLOW_NONPUBLIC_MBEAN)) { >>> ret = clMBeanClass; >>> } >>> } catch (ClassNotFoundException cne) { >>> // clMBeanClass does not exist? >>> } >>> >>> return ret; >>> } >>> >>> Is there any special reason to not have a unit test? >>> >>> Shanliang >>> >>> >>> Jaroslav Bachorik wrote: >>>> And the webrev would come handy, of course. >>>> >>>> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.00/ >>>> >>>> -JB- >>>> >>>> On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >>>> >>>>> The fix enforces the management interfaces (read MBean and MXBean >>>>> interfaces) being public. While this is defined in the >>>>> specification it >>>>> was not enforced in any way and it was allowed to create MBeans for >>>>> eg. >>>>> private MBean interfaces. >>>>> >>>>> The fix adds checks when creating and registering MBeans and throws >>>>> javax.management.NotCompliantMBeanException when a user tries to >>>>> create >>>>> an MBean with non-public management interface. >>>>> >>>>> Since this change can cause problems for users having non-public >>>>> management interfaces a system property is introduced that will revert >>>>> to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >>>>> >>>>> Thanks, >>>>> >>>>> -JB- >>>>> >>>>> >>>> >>>> >>> >> > > From eamonn at mcmanus.net Wed May 29 08:33:21 2013 From: eamonn at mcmanus.net (Eamonn McManus) Date: Wed, 29 May 2013 08:33:21 -0700 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A6171E.8040606@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A6171E.8040606@oracle.com> Message-ID: I would recommend against changing the code to do additional calls to Class.forName during MBean introspection. As I recall we made the opposite change some years ago, both because Class.forName can be slow (it may call out to a user ClassLoader) and because it is a potential source of security problems. ?amonn 2013/5/29 Jaroslav Bachorik > Updated webrev - http://cr.openjdk.java.net/~jbachorik/8010285/webrev.01 > > It adds regtests and takes care of the comments from David and Shanliang. > > -JB- > > On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: > > The fix enforces the management interfaces (read MBean and MXBean > > interfaces) being public. While this is defined in the specification it > > was not enforced in any way and it was allowed to create MBeans for eg. > > private MBean interfaces. > > > > The fix adds checks when creating and registering MBeans and throws > > javax.management.NotCompliantMBeanException when a user tries to create > > an MBean with non-public management interface. > > > > Since this change can cause problems for users having non-public > > management interfaces a system property is introduced that will revert > > to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). > > > > Thanks, > > > > -JB- > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130529/a219eadc/attachment.html From james.laskey at oracle.com Wed May 29 09:24:52 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 29 May 2013 16:24:52 +0000 Subject: hg: jdk8/tl/nashorn: 9 new changesets Message-ID: <20130529162459.4942D48DE8@hg.openjdk.java.net> Changeset: 0bf451c0678d Author: hannesw Date: 2013-05-27 12:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0bf451c0678d 8015348: RegExp("[") results in StackOverflowError Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8015348.js + test/script/basic/JDK-8015348.js.EXPECTED Changeset: 1f57afd14cc1 Author: lagergren Date: 2013-05-27 13:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1f57afd14cc1 8014219: Make the run-octane harness more deterministic by not measuring elapsed time every iteration. Also got rid of most of the run logic in base.js and call benchmarks directly for the same purpose Reviewed-by: jlaskey, attila ! make/build-benchmark.xml ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! test/script/basic/compile-octane.js.EXPECTED ! test/script/basic/run-octane.js Changeset: 910fd2849c4c Author: lagergren Date: 2013-05-27 13:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/910fd2849c4c Merge Changeset: 343fd0450802 Author: sundar Date: 2013-05-27 20:41 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/343fd0450802 8015352: "i".toUpperCase() => currently returns "??", but should be "I" (with Turkish locale) Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/JDK-8015352.js Changeset: e6193dcfe36c Author: lagergren Date: 2013-05-27 17:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e6193dcfe36c 8015447: Octane harness fixes for rhino and entire test runs: ant octane, ant octane-v8, ant octane-rhino Reviewed-by: sundar, jlaskey ! make/build-benchmark.xml ! test/script/basic/run-octane.js Changeset: d56168970de1 Author: sundar Date: 2013-05-28 16:37 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d56168970de1 8015459: Octane test run fails on Turkish locale Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/DateParser.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java Changeset: f472f7046ec9 Author: sundar Date: 2013-05-29 15:41 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f472f7046ec9 8005979: A lot of tests are named "runTest" in reports Reviewed-by: jlaskey ! make/project.properties Changeset: f69e76417211 Author: lagergren Date: 2013-05-29 14:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f69e76417211 8011023: Math round didn't conform to ECMAScript 5 spec Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/objects/NativeMath.java + test/script/basic/JDK-8011023.js + test/script/basic/JDK-8011023.js.EXPECTED Changeset: a2e2797392b3 Author: sundar Date: 2013-05-29 21:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a2e2797392b3 8015349: "abc".lastIndexOf("a",-1) should evaluate to 0 and not -1 Reviewed-by: lagergren, attila, jlaskey ! src/jdk/nashorn/internal/objects/NativeString.java + test/script/basic/JDK-8015349.js + test/script/basic/JDK-8015349.js.EXPECTED From jaroslav.bachorik at oracle.com Wed May 29 10:17:35 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 29 May 2013 19:17:35 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: References: <51A4BD98.1040704@oracle.com> <51A6171E.8040606@oracle.com> Message-ID: <51A6382F.3000204@oracle.com> On Wed 29 May 2013 05:33:21 PM CEST, Eamonn McManus wrote: > I would recommend against changing the code to do additional calls to > Class.forName during MBean introspection. As I recall we made the > opposite change some years ago, both because Class.forName can be slow > (it may call out to a user ClassLoader) and because it is a potential > source of security problems. Thanks. I was trying to dig some history from mercurial but couldn't. Walking through all the related interfaces is equally acceptable - I've tried both of the solutions and they test well with the regtests. I am still puzzled by the current implementation which will fail to locate the correct MBean interface in eg. <> extends <> extends <> ClassA extends Service implements <> as the process would stop on <> (checks the superclass of the ClassA, checks all the interfaces implemented by the Service class, checks all the interfaces extended by <>) which plainly does not conform to the MBean interface naming convention and would miss the <> interface. -JB- > > ?amonn > > > 2013/5/29 Jaroslav Bachorik > > > Updated webrev - > http://cr.openjdk.java.net/~jbachorik/8010285/webrev.01 > > It adds regtests and takes care of the comments from David and > Shanliang. > > -JB- > > On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: > > The fix enforces the management interfaces (read MBean and MXBean > > interfaces) being public. While this is defined in the > specification it > > was not enforced in any way and it was allowed to create MBeans > for eg. > > private MBean interfaces. > > > > The fix adds checks when creating and registering MBeans and throws > > javax.management.NotCompliantMBeanException when a user tries to > create > > an MBean with non-public management interface. > > > > Since this change can cause problems for users having non-public > > management interfaces a system property is introduced that will > revert > > to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). > > > > Thanks, > > > > -JB- > > > > From daniel.fuchs at oracle.com Wed May 29 10:44:34 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 29 May 2013 19:44:34 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A6382F.3000204@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A6171E.8040606@oracle.com> <51A6382F.3000204@oracle.com> Message-ID: <51A63E82.4050505@oracle.com> On 5/29/13 7:17 PM, Jaroslav Bachorik wrote: > On Wed 29 May 2013 05:33:21 PM CEST, Eamonn McManus wrote: >> I would recommend against changing the code to do additional calls to >> Class.forName during MBean introspection. As I recall we made the >> opposite change some years ago, both because Class.forName can be slow >> (it may call out to a user ClassLoader) and because it is a potential >> source of security problems. > > Thanks. I was trying to dig some history from mercurial but couldn't. > Walking through all the related interfaces is equally acceptable - I've > tried both of the solutions and they test well with the regtests. > > I am still puzzled by the current implementation which will fail to > locate the correct MBean interface in eg. > > <> extends <> extends <> > > ClassA extends Service implements <> > > as the process would stop on <> (checks the superclass of > the ClassA, checks all the interfaces implemented by the Service class, > checks all the interfaces extended by <>) which plainly > does not conform to the MBean interface naming convention and would > miss the <> interface. Hi Jaroslav, <> would have to implement <> either directly or indirectly. So the current implementation is correct. If <> is not assignable from <> then <> is not an MBean interface for ClassA. You can work around that by wrapping an instance of ClassA in an instance of javax.management.StandardMBean, and by specifying <>.class as the MBean interface in the constructor. Hope this helps, -- daniel > > -JB- > >> >> ?amonn >> >> >> 2013/5/29 Jaroslav Bachorik > > >> >> Updated webrev - >> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.01 >> >> It adds regtests and takes care of the comments from David and >> Shanliang. >> >> -JB- >> >> On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >> > The fix enforces the management interfaces (read MBean and MXBean >> > interfaces) being public. While this is defined in the >> specification it >> > was not enforced in any way and it was allowed to create MBeans >> for eg. >> > private MBean interfaces. >> > >> > The fix adds checks when creating and registering MBeans and throws >> > javax.management.NotCompliantMBeanException when a user tries to >> create >> > an MBean with non-public management interface. >> > >> > Since this change can cause problems for users having non-public >> > management interfaces a system property is introduced that will >> revert >> > to the old behaviour when set (com.sun.jmx.mbeans.allowNonPublic). >> > >> > Thanks, >> > >> > -JB- >> > >> >> > > From jonathan.gibbons at oracle.com Wed May 29 15:42:33 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 29 May 2013 22:42:33 +0000 Subject: hg: jdk8/tl/langtools: 8015641: genstubs needs to cope with static interface methods Message-ID: <20130529224240.5958B48E07@hg.openjdk.java.net> Changeset: d685b12b62a4 Author: jjg Date: 2013-05-29 15:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d685b12b62a4 8015641: genstubs needs to cope with static interface methods Reviewed-by: ksrini ! make/tools/genstubs/GenStubs.java From xueming.shen at oracle.com Wed May 29 19:53:10 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 30 May 2013 02:53:10 +0000 Subject: hg: jdk8/tl/jdk: 4759491: method ZipEntry.setTime(long) works incorrectly; ... Message-ID: <20130530025333.AE19648E12@hg.openjdk.java.net> Changeset: 90df6756406f Author: sherman Date: 2013-05-29 19:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90df6756406f 4759491: method ZipEntry.setTime(long) works incorrectly 6303183: Support NTFS and Unix-style timestamps for entries in Zip files 7012856: (zipfs) Newly created entry in zip file system should set all file times non-null values. 7012868: (zipfs) file times of entry in zipfs should always be the same regardless of TimeZone. Summary: to add suuport of Info-ZIP extended timestamp in extra data fields Reviewed-by: martin, alanb ! src/share/classes/java/util/zip/ZipConstants.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java + src/share/classes/java/util/zip/ZipUtils.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh ! test/java/util/jar/TestExtra.java ! test/java/util/zip/StoredCRC.java + test/java/util/zip/TestExtraTime.java ! test/java/util/zip/ZipFile/Assortment.java From serguei.spitsyn at oracle.com Wed May 29 21:08:45 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 29 May 2013 21:08:45 -0700 Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds Message-ID: <51A6D0CD.1000503@oracle.com> Please, review the fix and unit test for: bug: http://bugs.sun.com/view_bug.do?bug_id=8015436 jbs: https://jbs.oracle.com/bugs/browse/JDK-8015436 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 Summary: The InstanceKlass _initial_method_idnum value must be adjusted as necessary if the overpass methods are added. I guess, it is Ok to integrate a unit test covering the fix under the same bug id. Testing: Newly added hotspot unit test: compiler/8015436/Test8015436.java The originally failed test: compiler/ciReplay/TestSA.sh The vm/mlvm tests Thanks, Serguei From jaroslav.bachorik at oracle.com Thu May 30 00:32:17 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 30 May 2013 09:32:17 +0200 Subject: jmx-dev RFR: 8010285 Enforce the requirement of Management Interfaces being public In-Reply-To: <51A63E82.4050505@oracle.com> References: <51A4BD98.1040704@oracle.com> <51A6171E.8040606@oracle.com> <51A6382F.3000204@oracle.com> <51A63E82.4050505@oracle.com> Message-ID: <51A70081.5050203@oracle.com> On Wed 29 May 2013 07:44:34 PM CEST, Daniel Fuchs wrote: > On 5/29/13 7:17 PM, Jaroslav Bachorik wrote: >> On Wed 29 May 2013 05:33:21 PM CEST, Eamonn McManus wrote: >>> I would recommend against changing the code to do additional calls to >>> Class.forName during MBean introspection. As I recall we made the >>> opposite change some years ago, both because Class.forName can be slow >>> (it may call out to a user ClassLoader) and because it is a potential >>> source of security problems. >> >> Thanks. I was trying to dig some history from mercurial but couldn't. >> Walking through all the related interfaces is equally acceptable - I've >> tried both of the solutions and they test well with the regtests. >> >> I am still puzzled by the current implementation which will fail to >> locate the correct MBean interface in eg. >> >> <> extends <> extends <> >> >> ClassA extends Service implements <> >> >> as the process would stop on <> (checks the superclass of >> the ClassA, checks all the interfaces implemented by the Service class, >> checks all the interfaces extended by <>) which plainly >> does not conform to the MBean interface naming convention and would >> miss the <> interface. > > Hi Jaroslav, > > <> would have to implement <> either > directly or indirectly. > > So the current implementation is correct. > > If <> is not assignable from <> then > <> is not an MBean interface for ClassA. Actually, when you do ClassA extends Service implements <> the Introspector will return <> as the standard mbean interface for ClassA. I've just tried it on a simple project to make sure I understand the code correctly. The puzzle is which behaviour is correct? Either all the levels of the interface hierarchy should be checked for the [className]MBean interfaces or none, I guess. However, I can not find anything in the spec related to this case. -JB- > > You can work around that by wrapping an instance of ClassA > in an instance of javax.management.StandardMBean, and by > specifying <>.class as the MBean interface > in the constructor. > > Hope this helps, > > -- daniel > >> >> -JB- >> >>> >>> ?amonn >>> >>> >>> 2013/5/29 Jaroslav Bachorik >> > >>> >>> Updated webrev - >>> http://cr.openjdk.java.net/~jbachorik/8010285/webrev.01 >>> >>> It adds regtests and takes care of the comments from David and >>> Shanliang. >>> >>> -JB- >>> >>> On 05/28/2013 04:22 PM, Jaroslav Bachorik wrote: >>> > The fix enforces the management interfaces (read MBean and >>> MXBean >>> > interfaces) being public. While this is defined in the >>> specification it >>> > was not enforced in any way and it was allowed to create MBeans >>> for eg. >>> > private MBean interfaces. >>> > >>> > The fix adds checks when creating and registering MBeans and >>> throws >>> > javax.management.NotCompliantMBeanException when a user tries to >>> create >>> > an MBean with non-public management interface. >>> > >>> > Since this change can cause problems for users having non-public >>> > management interfaces a system property is introduced that will >>> revert >>> > to the old behaviour when set >>> (com.sun.jmx.mbeans.allowNonPublic). >>> > >>> > Thanks, >>> > >>> > -JB- >>> > >>> >>> >> >> > From chris.hegarty at oracle.com Thu May 30 04:21:39 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 30 May 2013 11:21:39 +0000 Subject: hg: jdk8/tl/jdk: 8015299: Memory leak in jdk/src/solaris/bin/java_md_solinux.c Message-ID: <20130530112205.4794848E23@hg.openjdk.java.net> Changeset: 6df9b071b04d Author: jzavgren Date: 2013-05-30 12:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6df9b071b04d 8015299: Memory leak in jdk/src/solaris/bin/java_md_solinux.c Reviewed-by: martin, dholmes, chegar, ksrini ! src/solaris/bin/java_md_solinux.c From jaroslav.bachorik at oracle.com Thu May 30 04:42:32 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 30 May 2013 13:42:32 +0200 Subject: RFR: 8015627 Message-ID: <51A73B28.9050600@oracle.com> JMX related tests have hard time running in "agentvm" mode because they need a set of privileges which are not granted by the default security manager. For this reason all the tests from javax/management are forced to run in "othervm" mode. com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java must also be forced to run in "othervm" mode. Webrev: http://cr.openjdk.java.net/~jbachorik/8015627/webrev.00 -JB- From Alan.Bateman at oracle.com Thu May 30 04:44:59 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 30 May 2013 12:44:59 +0100 Subject: RFR: 8015627 In-Reply-To: <51A73B28.9050600@oracle.com> References: <51A73B28.9050600@oracle.com> Message-ID: <51A73BBB.5030805@oracle.com> On 30/05/2013 12:42, Jaroslav Bachorik wrote: > JMX related tests have hard time running in "agentvm" mode because they > need a set of privileges which are not granted by the default security > manager. For this reason all the tests from javax/management are forced > to run in "othervm" mode. > > com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java > must also be forced to run in "othervm" mode. > > Webrev: http://cr.openjdk.java.net/~jbachorik/8015627/webrev.00 > > -JB- Thanks, this looks fine. -Alan. From chris.hegarty at oracle.com Thu May 30 04:54:22 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 30 May 2013 12:54:22 +0100 Subject: RFR: 8015627 In-Reply-To: <51A73B28.9050600@oracle.com> References: <51A73B28.9050600@oracle.com> Message-ID: <51A73DEE.2070208@oracle.com> Looks ok to me. -Chris. On 05/30/2013 12:42 PM, Jaroslav Bachorik wrote: > JMX related tests have hard time running in "agentvm" mode because they > need a set of privileges which are not granted by the default security > manager. For this reason all the tests from javax/management are forced > to run in "othervm" mode. > > com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java > must also be forced to run in "othervm" mode. > > Webrev: http://cr.openjdk.java.net/~jbachorik/8015627/webrev.00 > > -JB- > From jaroslav.bachorik at oracle.com Thu May 30 04:59:00 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 30 May 2013 11:59:00 +0000 Subject: hg: jdk8/tl/jdk: 8015627: test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails in agentvm mode Message-ID: <20130530115914.63A4F48E25@hg.openjdk.java.net> Changeset: dc22b7241a70 Author: jbachorik Date: 2013-05-30 13:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc22b7241a70 8015627: test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails in agentvm mode Reviewed-by: alanb, chegar ! test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java From paul.sandoz at oracle.com Thu May 30 07:26:18 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 30 May 2013 14:26:18 +0000 Subject: hg: jdk8/tl/jdk: 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder Message-ID: <20130530142644.D115248E2A@hg.openjdk.java.net> Changeset: 156ee44cd456 Author: psandoz Date: 2013-05-30 16:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/156ee44cd456 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder Summary: Also fixes documentation on StreamBuilder.OfDouble Reviewed-by: alanb, chegar, mduigou ! src/share/classes/java/util/stream/StreamBuilder.java From paul.sandoz at oracle.com Thu May 30 07:34:17 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 30 May 2013 14:34:17 +0000 Subject: hg: jdk8/tl/jdk: 8014393: Minor typo in the spec for j.u.stream.Stream.findFirst() Message-ID: <20130530143434.2119C48E2D@hg.openjdk.java.net> Changeset: b4742d038100 Author: psandoz Date: 2013-05-28 15:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4742d038100 8014393: Minor typo in the spec for j.u.stream.Stream.findFirst() Reviewed-by: alanb, chegar ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java From christian.thalinger at oracle.com Thu May 30 08:41:11 2013 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Thu, 30 May 2013 08:41:11 -0700 Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds In-Reply-To: <51A6D0CD.1000503@oracle.com> References: <51A6D0CD.1000503@oracle.com> Message-ID: Looks good. -- Chris On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote: > Please, review the fix and unit test for: > bug: http://bugs.sun.com/view_bug.do?bug_id=8015436 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8015436 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 > > Summary: > The InstanceKlass _initial_method_idnum value must be adjusted as necessary if the overpass methods are added. > I guess, it is Ok to integrate a unit test covering the fix under the same bug id. > > Testing: > Newly added hotspot unit test: compiler/8015436/Test8015436.java > The originally failed test: compiler/ciReplay/TestSA.sh > The vm/mlvm tests > > Thanks, > Serguei From serguei.spitsyn at oracle.com Thu May 30 10:29:23 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 30 May 2013 10:29:23 -0700 Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds In-Reply-To: References: <51A6D0CD.1000503@oracle.com> Message-ID: <51A78C73.20109@oracle.com> Thanks, Chris! Serguei On 5/30/13 8:41 AM, Christian Thalinger wrote: > Looks good. -- Chris > > On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote: > >> Please, review the fix and unit test for: >> bug: http://bugs.sun.com/view_bug.do?bug_id=8015436 >> jbs: https://jbs.oracle.com/bugs/browse/JDK-8015436 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 >> >> Summary: >> The InstanceKlass _initial_method_idnum value must be adjusted as necessary if the overpass methods are added. >> I guess, it is Ok to integrate a unit test covering the fix under the same bug id. >> >> Testing: >> Newly added hotspot unit test: compiler/8015436/Test8015436.java >> The originally failed test: compiler/ciReplay/TestSA.sh >> The vm/mlvm tests >> >> Thanks, >> Serguei From vladimir.kozlov at oracle.com Thu May 30 11:10:51 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 30 May 2013 11:10:51 -0700 Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds In-Reply-To: <51A78C73.20109@oracle.com> References: <51A6D0CD.1000503@oracle.com> <51A78C73.20109@oracle.com> Message-ID: <51A7962B.10308@oracle.com> Sergey, The fix is good. You don't need to show the failure output in the test sources since you have bugid in it. Also you don't need /othervm if you don't have command line flags. Vladimir On 5/30/13 10:29 AM, serguei.spitsyn at oracle.com wrote: > > Thanks, Chris! > Serguei > > On 5/30/13 8:41 AM, Christian Thalinger wrote: >> Looks good. -- Chris >> >> On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote: >> >>> Please, review the fix and unit test for: >>> bug: http://bugs.sun.com/view_bug.do?bug_id=8015436 >>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8015436 >>> >>> Open webrev: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 >>> >>> >>> Summary: >>> The InstanceKlass _initial_method_idnum value must be adjusted as >>> necessary if the overpass methods are added. >>> I guess, it is Ok to integrate a unit test covering the fix under >>> the same bug id. >>> >>> Testing: >>> Newly added hotspot unit test: compiler/8015436/Test8015436.java >>> The originally failed test: compiler/ciReplay/TestSA.sh >>> The vm/mlvm tests >>> >>> Thanks, >>> Serguei > From serguei.spitsyn at oracle.com Thu May 30 11:18:04 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 30 May 2013 11:18:04 -0700 Subject: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds In-Reply-To: <51A7962B.10308@oracle.com> References: <51A6D0CD.1000503@oracle.com> <51A78C73.20109@oracle.com> <51A7962B.10308@oracle.com> Message-ID: <51A797DC.10109@oracle.com> Hi Vladimir, Thank you for the review! I'll update the test according to your suggestion before the push. Thanks, Serguei On 5/30/13 11:10 AM, Vladimir Kozlov wrote: > Sergey, > > The fix is good. > > You don't need to show the failure output in the test sources since > you have bugid in it. > > Also you don't need /othervm if you don't have command line flags. > > Vladimir > > On 5/30/13 10:29 AM, serguei.spitsyn at oracle.com wrote: >> >> Thanks, Chris! >> Serguei >> >> On 5/30/13 8:41 AM, Christian Thalinger wrote: >>> Looks good. -- Chris >>> >>> On May 29, 2013, at 9:08 PM, serguei.spitsyn at oracle.com wrote: >>> >>>> Please, review the fix and unit test for: >>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8015436 >>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8015436 >>>> >>>> Open webrev: >>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 >>>> >>>> >>>> >>>> Summary: >>>> The InstanceKlass _initial_method_idnum value must be adjusted as >>>> necessary if the overpass methods are added. >>>> I guess, it is Ok to integrate a unit test covering the fix under >>>> the same bug id. >>>> >>>> Testing: >>>> Newly added hotspot unit test: compiler/8015436/Test8015436.java >>>> The originally failed test: compiler/ciReplay/TestSA.sh >>>> The vm/mlvm tests >>>> >>>> Thanks, >>>> Serguei >> From xueming.shen at oracle.com Thu May 30 14:50:30 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 30 May 2013 21:50:30 +0000 Subject: hg: jdk8/tl/jdk: 8015271: Conversion table for EUC-KR is incorrect Message-ID: <20130530215045.E507448E36@hg.openjdk.java.net> Changeset: b588955b7e5b Author: sherman Date: 2013-05-30 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b588955b7e5b 8015271: Conversion table for EUC-KR is incorrect Summary: to add the requested postal code mark character u+327e Reviewed-by: alanb ! make/tools/CharsetMapping/EUC_KR.map From xuelei.fan at oracle.com Thu May 30 22:03:51 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:03:51 +0000 Subject: hg: jdk8/tl/jdk: 8014618: Need to strip leading zeros in TlsPremasterSecret of DHKeyAgreement Message-ID: <20130531050404.EA02048E4B@hg.openjdk.java.net> Changeset: 6407106f1b1c Author: xuelei Date: 2013-05-30 22:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6407106f1b1c 8014618: Need to strip leading zeros in TlsPremasterSecret of DHKeyAgreement Reviewed-by: xuelei Contributed-by: Pasi Eronen ! src/share/classes/com/sun/crypto/provider/DHKeyAgreement.java ! src/share/classes/sun/security/pkcs11/P11KeyAgreement.java ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/P11Util.java ! src/share/classes/sun/security/util/KeyUtil.java + test/com/sun/crypto/provider/TLS/TestLeadingZeroes.java + test/sun/security/pkcs11/tls/TestLeadingZeroesP11.java From xuelei.fan at oracle.com Thu May 30 22:21:24 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:21:24 +0000 Subject: hg: jdk8/tl/jdk: 7160837: DigestOutputStream does not turn off digest calculation when "close()" is called Message-ID: <20130531052135.DD0F348E4D@hg.openjdk.java.net> Changeset: 8402ef8fabde Author: ascarpino Date: 2013-05-30 22:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8402ef8fabde 7160837: DigestOutputStream does not turn off digest calculation when "close()" is called Reviewed-by: mullan, xuelei ! src/share/classes/java/security/DigestOutputStream.java ! src/share/classes/javax/crypto/CipherInputStream.java ! src/share/classes/javax/crypto/CipherOutputStream.java + test/javax/crypto/Cipher/CipherStreamClose.java From xuelei.fan at oracle.com Thu May 30 22:26:24 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:26:24 +0000 Subject: hg: jdk8/tl/jdk: 8013069: javax.crypto tests fail with new PBE algorithm names Message-ID: <20130531052636.127B448E4E@hg.openjdk.java.net> Changeset: 6cb09d3cd309 Author: valeriep Date: 2013-05-29 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cb09d3cd309 8013069: javax.crypto tests fail with new PBE algorithm names Summary: Shouldn't auto-generate default parameters for MAC objects. Reviewed-by: vinnie ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! test/com/sun/crypto/provider/Mac/HmacPBESHA1.java ! test/com/sun/crypto/provider/Mac/MacClone.java From xuelei.fan at oracle.com Thu May 30 22:36:11 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:36:11 +0000 Subject: hg: jdk8/tl/jdk: 6750584: Cipher.wrap/unwrap methods should define UnsupportedOperationException Message-ID: <20130531053622.DB15D48E4F@hg.openjdk.java.net> Changeset: 918d9ac17740 Author: ascarpino Date: 2013-05-30 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/918d9ac17740 6750584: Cipher.wrap/unwrap methods should define UnsupportedOperationException Reviewed-by: mullan ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CipherSpi.java From serguei.spitsyn at oracle.com Thu May 30 23:06:58 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 31 May 2013 06:06:58 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds Message-ID: <20130531060703.78E7648E50@hg.openjdk.java.net> Changeset: fe00365c8f31 Author: sspitsyn Date: 2013-05-30 11:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fe00365c8f31 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds Summary: The InstanceKlass _initial_method_idnum value must be adjusted if overpass methods are added. Reviewed-by: twisti, kvn Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/classfile/defaultMethods.cpp + test/compiler/8015436/Test8015436.java From serguei.spitsyn at oracle.com Thu May 30 23:19:25 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 30 May 2013 23:19:25 -0700 Subject: Review Request (S) 8014052: JSR292: assert(end_offset == next_offset) failed: matched ending Message-ID: <51A840ED.7030501@oracle.com> Please, review the fix for: bug: https://jbs.oracle.com/bugs/browse/JDK-8014052 jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014052-JVMTI-JSR292.1 Summary: A call to the finalize_operands_merge() must be unconditional. Otherwise, the merge of the bootstrap method operands is not completed correctly. Testing: vm/mlvm, nsk/jvmti, nsk/jdi, nsk/jdwp Thanks, Serguei From paul.sandoz at oracle.com Fri May 31 01:03:03 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 31 May 2013 08:03:03 +0000 Subject: hg: jdk8/tl/jdk: 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown Message-ID: <20130531080318.5C1D448E53@hg.openjdk.java.net> Changeset: b47044426bcd Author: psandoz Date: 2013-05-31 09:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b47044426bcd 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown Summary: A minor documentation issue (not a spec issue). Reviewed-by: chegar, dl ! src/share/classes/java/util/Spliterator.java From chris.hegarty at oracle.com Fri May 31 01:32:00 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 31 May 2013 08:32:00 +0000 Subject: hg: jdk8/tl/jdk: 7107883: getNetworkPrefixLength() does not return correct prefix length Message-ID: <20130531083225.EF21548E58@hg.openjdk.java.net> Changeset: dcf42861b5b1 Author: chegar Date: 2013-05-31 09:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcf42861b5b1 7107883: getNetworkPrefixLength() does not return correct prefix length Reviewed-by: alanb, michaelm ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/InterfaceAddress/NetworkPrefixLength.java From john.coomes at oracle.com Fri May 31 01:56:29 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 31 May 2013 08:56:29 +0000 Subject: hg: hsx/hotspot-rt: 4 new changesets Message-ID: <20130531085629.8DA9348E72@hg.openjdk.java.net> Changeset: e247ee3924d5 Author: erikj Date: 2013-05-22 17:26 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e247ee3924d5 8014514: Fix jvm args for sjavac Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/build-performance.m4 ! common/autoconf/generated-configure.sh Changeset: e7c09a983c3c Author: erikj Date: 2013-05-28 08:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e7c09a983c3c 8007129: build-infra Add configure --with-jtreg option for location of JTREG Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: 3a36c926a7aa Author: katleman Date: 2013-05-28 17:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/3a36c926a7aa Merge Changeset: 46be9eb242d1 Author: katleman Date: 2013-05-30 10:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/46be9eb242d1 Added tag jdk8-b92 for changeset 3a36c926a7aa ! .hgtags From john.coomes at oracle.com Fri May 31 01:56:38 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 31 May 2013 08:56:38 +0000 Subject: hg: hsx/hotspot-rt/jaxp: 2 new changesets Message-ID: <20130531085652.8397A48E74@hg.openjdk.java.net> Changeset: 1ab5d8d6eab8 Author: katleman Date: 2013-05-29 10:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/1ab5d8d6eab8 8015525: JDK8 b91 source with GPL header errors Reviewed-by: dholmes, lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java Changeset: a6596a06e10b Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/a6596a06e10b Added tag jdk8-b92 for changeset 1ab5d8d6eab8 ! .hgtags From john.coomes at oracle.com Fri May 31 01:56:32 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 31 May 2013 08:56:32 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b92 for changeset 717aa26f8e0a Message-ID: <20130531085634.8285B48E73@hg.openjdk.java.net> Changeset: 8dc9d7ccbb2d Author: katleman Date: 2013-05-30 10:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/8dc9d7ccbb2d Added tag jdk8-b92 for changeset 717aa26f8e0a ! .hgtags From john.coomes at oracle.com Fri May 31 01:57:03 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 31 May 2013 08:57:03 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b92 for changeset a0f604766ca1 Message-ID: <20130531085709.14AC648E75@hg.openjdk.java.net> Changeset: 7386eca865e1 Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/7386eca865e1 Added tag jdk8-b92 for changeset a0f604766ca1 ! .hgtags From john.coomes at oracle.com Fri May 31 01:57:19 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 31 May 2013 08:57:19 +0000 Subject: hg: hsx/hotspot-rt/jdk: 2 new changesets Message-ID: <20130531085832.B829848E76@hg.openjdk.java.net> Changeset: a2a2a91075ad Author: katleman Date: 2013-05-29 10:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a2a2a91075ad 8015525: JDK8 b91 source with GPL header errors Reviewed-by: dholmes, lancea ! test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java ! test/jdk/lambda/MethodReferenceTestInstanceMethod.java ! test/jdk/lambda/MethodReferenceTestKinds.java ! test/jdk/lambda/MethodReferenceTestSueCase1.java ! test/jdk/lambda/MethodReferenceTestSueCase2.java ! test/jdk/lambda/MethodReferenceTestSueCase4.java ! test/jdk/lambda/separate/AttributeInjector.java ! test/jdk/lambda/separate/ClassFile.java ! test/jdk/lambda/separate/ClassFilePreprocessor.java ! test/jdk/lambda/separate/ClassToInterfaceConverter.java ! test/jdk/lambda/separate/Compiler.java ! test/jdk/lambda/separate/DirectedClassLoader.java ! test/jdk/lambda/separate/SourceModel.java ! test/jdk/lambda/separate/TestHarness.java ! test/jdk/lambda/vm/DefaultMethodRegressionTests.java ! test/jdk/lambda/vm/DefaultMethodsTest.java ! test/jdk/lambda/vm/InterfaceAccessFlagsTest.java Changeset: 3c08c9ebd1fb Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3c08c9ebd1fb Added tag jdk8-b92 for changeset a2a2a91075ad ! .hgtags From john.coomes at oracle.com Fri May 31 02:00:02 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 31 May 2013 09:00:02 +0000 Subject: hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b92 for changeset dee23cce5235 Message-ID: <20130531090004.CC18448E78@hg.openjdk.java.net> Changeset: 1c7481ac7fe0 Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1c7481ac7fe0 Added tag jdk8-b92 for changeset dee23cce5235 ! .hgtags From john.coomes at oracle.com Fri May 31 01:59:35 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 31 May 2013 08:59:35 +0000 Subject: hg: hsx/hotspot-rt/langtools: 4 new changesets Message-ID: <20130531085955.0453148E77@hg.openjdk.java.net> Changeset: 58eace4d997f Author: erikj Date: 2013-05-28 08:49 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/58eace4d997f 8012566: Replace find, rm, printf and similar with their proper variables Reviewed-by: tbell ! makefiles/BuildLangtools.gmk Changeset: 3597773628a4 Author: katleman Date: 2013-05-28 17:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3597773628a4 Merge Changeset: 149890642a0e Author: katleman Date: 2013-05-29 10:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/149890642a0e 8015525: JDK8 b91 source with GPL header errors Reviewed-by: dholmes, lancea ! test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java Changeset: 023e9a614d26 Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/023e9a614d26 Added tag jdk8-b92 for changeset 149890642a0e ! .hgtags From vicente.romero at oracle.com Fri May 31 02:05:52 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 31 May 2013 09:05:52 +0000 Subject: hg: jdk8/tl/langtools: 7179353: try-with-resources fails to compile with generic exception parameters Message-ID: <20130531090604.168F148E79@hg.openjdk.java.net> Changeset: 9f11c7676cd5 Author: vromero Date: 2013-05-31 10:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f11c7676cd5 7179353: try-with-resources fails to compile with generic exception parameters Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/T7179353/GenericsAndTWRCompileErrorTest.java From alan.bateman at oracle.com Fri May 31 04:22:33 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 31 May 2013 11:22:33 +0000 Subject: hg: jdk8/tl/jdk: 8014854: (bf) CharBuffer.chars too slow with default implementation Message-ID: <20130531112303.ED0E148E83@hg.openjdk.java.net> Changeset: 243cd682c47b Author: alanb Date: 2013-05-31 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/243cd682c47b 8014854: (bf) CharBuffer.chars too slow with default implementation Reviewed-by: erikj, briangoetz, henryjen, psandoz, mduigou ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcBuffer.gmk ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template + src/share/classes/java/nio/CharBufferSpliterator.java ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/share/classes/java/nio/Heap-X-Buffer.java.template ! src/share/classes/java/nio/StringCharBuffer.java ! src/share/classes/java/nio/X-Buffer.java.template + test/java/nio/Buffer/Chars.java From mikael.gerdin at oracle.com Fri May 31 05:09:41 2013 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Fri, 31 May 2013 14:09:41 +0200 Subject: RFR: 8013590: NPG: Add a memory pool MXBean for Metaspace In-Reply-To: <20130529084430.GD1956@ehelin-thinkpad> References: <20130529084430.GD1956@ehelin-thinkpad> Message-ID: <51A89305.3070005@oracle.com> (merging the gc-dev and svc-dev threads) Hi Erik, On 2013-05-29 10:44, Erik Helin wrote: > Hi all, > > this want sent to hotspot-gc-dev at openjdk.java.net, sending to > serviceability-dev at openjdk.java.net as well since the change is about > memory pools. > > This change adds two memory pools for metaspace, one for Metaspace and > one for compressed klass space. The memory pool for compressed klass > space will only have valus that differ from 0 or -1 (undefined) if > compressed klass pointers are used. > > Question: Should I use an empty pool when compressed klass pointers are > *not* used or should I just not expose the pool? > > This change also adds a manager for the pools: Metaspace Manager. > > I have also added a test that checks that the metaspace manager is > present and that the two pools are present. The test also verifies that > the compressed klass space pool act correct according to the > UseCompressedKlass flag. > > The last time I added metaspace memory pools, it triggered some > unforeseen bugs: > - Two asserts in jmm_GetMemoryUsage that asserted that a memory pool was > either of heap type or had an undefined init/max size. > - The jdk/test/java/lang/management/MemoryMXBean/MemoryTest.java failed > - The service lock was taken out of order with the metaspace locks > > These bugs have all been fixed: > - The asserts have been removed since they are no longer true > - The test has been updated but is not part of this change since it is a > JDK change > - This change does not make use of functions requiring the metaspace > lock. I had to remove some verification code in free_chunks_total to > ensure this. > > Webrev: > http://cr.openjdk.java.net/~ehelin/8013590/webrev.00/ Overall I think your fix looks good but I disagree with your choice of exposing an EmptyCompressedKlassSpacePool for the case of -UseCompressedClassPointers. Given the dynamic nature of the MemoryManagerMXBeans and MemoryPoolMXBeans it seems more true to the intentions of the API to ony expose a MemoryPool if it contains interesting information. Generally I don't think users of the management APIs can (or should) depend on the exact set of MemoryManagerMXBeans and MemoryPoolMXBeans available in a given VM instance. /Mikael > > Testing: > - One new jtreg test > - JPRT > - All the tests that failed in nighly testing last time now pass > > Thanks, > Erik > From nils.loodin at oracle.com Fri May 31 05:59:40 2013 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 31 May 2013 14:59:40 +0200 Subject: RFR - 6526682: JConsole shows negative CPU Usage Message-ID: <51A89EBC.9080303@oracle.com> Simple fix to not show negative CPU usage in JConsole: http://cr.openjdk.java.net/~nloodin/6526682/webrev.00/ Regards, Nils Loodin From Alan.Bateman at oracle.com Fri May 31 06:48:49 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 31 May 2013 14:48:49 +0100 Subject: RFR - 6526682: JConsole shows negative CPU Usage In-Reply-To: <51A89EBC.9080303@oracle.com> References: <51A89EBC.9080303@oracle.com> Message-ID: <51A8AA41.3020805@oracle.com> On 31/05/2013 13:59, Nils Loodin wrote: > Simple fix to not show negative CPU usage in JConsole: > > http://cr.openjdk.java.net/~nloodin/6526682/webrev.00/ Looks okay to me. -Alan. From rickard.backman at oracle.com Fri May 31 08:54:56 2013 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Fri, 31 May 2013 15:54:56 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8014709: Constructor.getAnnotatedReturnType() returns empty AnnotatedType Message-ID: <20130531155502.7D43D48E90@hg.openjdk.java.net> Changeset: a589c78a8811 Author: rbackman Date: 2013-05-31 13:02 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a589c78a8811 8014709: Constructor.getAnnotatedReturnType() returns empty AnnotatedType Reviewed-by: stefank, rbackman Contributed-by: Joel Borggren-Franck ! src/share/vm/runtime/reflection.cpp ! test/runtime/8007320/ConstMethodTest.java From mandy.chung at oracle.com Fri May 31 10:03:30 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 31 May 2013 10:03:30 -0700 Subject: RFR - 6526682: JConsole shows negative CPU Usage In-Reply-To: <51A89EBC.9080303@oracle.com> References: <51A89EBC.9080303@oracle.com> Message-ID: <51A8D7E2.5000701@oracle.com> On 5/31/2013 5:59 AM, Nils Loodin wrote: > Simple fix to not show negative CPU usage in JConsole: > > http://cr.openjdk.java.net/~nloodin/6526682/webrev.00/ > Looks okay. Mandy > Regards, > Nils Loodin From vladimir.kozlov at oracle.com Fri May 31 10:03:55 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 31 May 2013 10:03:55 -0700 Subject: Review Request (S) 8014052: JSR292: assert(end_offset == next_offset) failed: matched ending In-Reply-To: <51A840ED.7030501@oracle.com> References: <51A840ED.7030501@oracle.com> Message-ID: <51A8D7FB.1070906@oracle.com> Good. Vladimir On 5/30/13 11:19 PM, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > bug: https://jbs.oracle.com/bugs/browse/JDK-8014052 > jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052 > > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014052-JVMTI-JSR292.1 > > > Summary: > A call to the finalize_operands_merge() must be unconditional. > Otherwise, the merge of the bootstrap method operands is not > completed correctly. > > > Testing: vm/mlvm, nsk/jvmti, nsk/jdi, nsk/jdwp > > Thanks, > Serguei From serguei.spitsyn at oracle.com Fri May 31 10:29:32 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 31 May 2013 10:29:32 -0700 (PDT) Subject: Review Request (S) 8014052: JSR292: assert(end_offset == next_offset) failed: matched ending In-Reply-To: <51A8D7FB.1070906@oracle.com> References: <51A840ED.7030501@oracle.com> <51A8D7FB.1070906@oracle.com> Message-ID: <51A8DDFC.7000107@oracle.com> Thanks, Vladimir! Serguei On 5/31/13 10:03 AM, Vladimir Kozlov wrote: > Good. > > Vladimir > > On 5/30/13 11:19 PM, serguei.spitsyn at oracle.com wrote: >> Please, review the fix for: >> bug: https://jbs.oracle.com/bugs/browse/JDK-8014052 >> jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052 >> >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8014052-JVMTI-JSR292.1 >> >> >> >> Summary: >> A call to the finalize_operands_merge() must be unconditional. >> Otherwise, the merge of the bootstrap method operands is not >> completed correctly. >> >> >> Testing: vm/mlvm, nsk/jvmti, nsk/jdi, nsk/jdwp >> >> Thanks, >> Serguei From naoto.sato at oracle.com Fri May 31 11:21:40 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 31 May 2013 18:21:40 +0000 Subject: hg: jdk8/tl/jdk: 7006052: awt_InputMethod.c cleanup is needed Message-ID: <20130531182153.1C22F48E95@hg.openjdk.java.net> Changeset: 933b1338b99c Author: naoto Date: 2013-05-31 11:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/933b1338b99c 7006052: awt_InputMethod.c cleanup is needed Reviewed-by: anthony ! src/solaris/native/sun/awt/awt_InputMethod.c From christian.tornqvist at oracle.com Fri May 31 13:25:21 2013 From: christian.tornqvist at oracle.com (christian.tornqvist at oracle.com) Date: Fri, 31 May 2013 20:25:21 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 6726963: multi_allocate() call does not CHECK_NULL and causes crash in fastdebug bits Message-ID: <20130531202526.5425248E99@hg.openjdk.java.net> Changeset: efe8b7d64424 Author: ctornqvi Date: 2013-05-31 20:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/efe8b7d64424 6726963: multi_allocate() call does not CHECK_NULL and causes crash in fastdebug bits Summary: Using CHECK_NULL when calling multi_allocate() from the corresponding reflection code; added test for this condition Reviewed-by: dholmes, minqi Contributed-by: Mikhailo Seledtsov ! src/share/vm/runtime/reflection.cpp + test/runtime/memory/MultiAllocateNullCheck.java From dan.xu at oracle.com Fri May 31 13:35:00 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 31 May 2013 20:35:00 +0000 Subject: hg: jdk8/tl/jdk: 8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java Message-ID: <20130531203521.796F148E9A@hg.openjdk.java.net> Changeset: f522bbdf2859 Author: dxu Date: 2013-05-31 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f522bbdf2859 8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java Reviewed-by: alanb ! test/java/io/pathNames/General.java ! test/java/io/pathNames/GeneralWin32.java From kurchi.subhra.hazra at oracle.com Fri May 31 13:59:32 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Fri, 31 May 2013 20:59:32 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130531205955.2370E48E9D@hg.openjdk.java.net> Changeset: 11cdcf87ad5d Author: jzavgren Date: 2013-05-31 15:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11cdcf87ad5d 8008972: Memory leak: Java_java_net_TwoStacksPlainDatagramSocketImpl_receive0 [parfait] Summary: Modified the code so that "jumbo frames" are truncated before buffer allocation is considered. This makes the buffer length a reliable indication that a buffer has been allocated, and it can then be used during clean up. Reviewed-by: chegar, khazra, alanb Contributed-by: john.zavgren at oracle.com ! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c Changeset: f6e6c27c19f3 Author: jzavgren Date: 2013-05-31 15:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6e6c27c19f3 7188517: Check on '$' character is missing in the HttpCookie class constructor Summary: Modified the constructor code so that the cookie names are examined for leading dollar signs and if they do, an illegal argument exception is thrown. Reviewed-by: chegar, khazra, michaelm Contributed-by: john.zavgren at oracle.com ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/TestHttpCookie.java From mike.duigou at oracle.com Fri May 31 17:32:07 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Sat, 01 Jun 2013 00:32:07 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130601003239.7507A48EA2@hg.openjdk.java.net> Changeset: fc0b3e86fdcf Author: mduigou Date: 2013-05-31 11:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0b3e86fdcf 8015686: {Int|Long}SummaryStatistics toString() throws IllegalFormatConversionException Reviewed-by: dholmes, alanb, psandoz ! src/share/classes/java/util/IntSummaryStatistics.java ! src/share/classes/java/util/LongSummaryStatistics.java Changeset: 198de8103df2 Author: mduigou Date: 2013-05-31 17:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/198de8103df2 Merge