RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return

[Ron Durbin]

Rickard

I glad to hear that you did run it through JPRT.
The fixes for bugs like this one I have needed a test hook that forces the code execution into the fixed
Code path.

Ron


> -----Original Message-----
> From: Rickard Bäckman
> Sent: Wednesday, May 08, 2013 6:34 AM
> To: Ron Durbin
> Cc: Staffan Larsen; serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-
> runtime-dev at openjdk.java.net
> Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return
> 
> Ron,
> 
> Thanks for the review.
> 
> I ran the change through JPRT.
> Creating a specific test for this seems rather problematic as we need to make sure that a specific
> malloc() fails.
> 
> /R
> 
> On May 8, 2013, at 2:31 PM, Ron Durbin wrote:
> 
> > Change looks good, can tell me what tests were run?
> > Were able create a unit test that triggers the failure ?
> >
> > Thx Ron
> >
> >> -----Original Message-----
> >> From: Staffan Larsen
> >> Sent: Wednesday, May 08, 2013 6:17 AM
> >> To: Rickard Bäckman
> >> Cc: serviceability-dev at openjdk.java.net
> >> serviceability-dev at openjdk.java.net; hotspot-runtime-
> >> dev at openjdk.java.net
> >> Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does
> >> not check malloc() return
> >>
> >> Looks good.
> >>
> >> /Staffan
> >>
> >> On 8 maj 2013, at 13:08, Rickard Bäckman <rickard.backman at oracle.com> wrote:
> >>
> >>> Hi,
> >>>
> >>> please review this small change.
> >>> The change adds a check to see the result of a malloc() and aborts
> >>> the VM with an out of memory
> >> error.
> >>>
> >>> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/
> >>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255
> >>>
> >>> Thanks
> >>> /R
> >>>
> >>
>