RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed May 8 05:57:34 PDT 2013


On 5/8/13 5:08 AM, Rickard Bäckman wrote:
> Hi,
>
> please review this small change.
> The change adds a check to see the result of a malloc() and aborts the VM with an out of memory error.
>
> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255

src/share/vm/prims/jvmtiExport.cpp
     No comments.

Thumbs up. Nice discussion about the alternatives in the bug report.

BTW, there is one more option, but you don't want to go down that
road. You could go ahead and post the event, but not cache the class
bytes. However, there are implications about not caching the class
bytes for the semantics of JVM/TI RetransformClasses() and I don't
think you want to wander down that path.

Dan

>
> Thanks
> /R
>



More information about the serviceability-dev mailing list