RFR: JDK-8014048 - Online user guide of jconsole points incorrect link
Staffan Larsen
staffan.larsen at oracle.com
Tue May 14 13:10:31 PDT 2013
Looks good!
/Staffan
On 14 maj 2013, at 13:20, Nils Loodin <nils.loodin at oracle.com> wrote:
> On 05/14/2013 01:28 AM, Mandy Chung wrote:
>> On 5/13/13 1:50 PM, Staffan Larsen wrote:
>>> Shouldn't the link be to the oracle site that the sun site redirects to:
>>>
>>> http://docs.oracle.com/javase/7/docs/technotes/guides/management/jconsole.html
>
> Staffan, yes, changed this.
>
>>>
>>
>> Can you take it further to construct the link with the release version
>> of the JRE:
>>
>> http://docs.oracle.com/javase/${RELEASE}/docs/technotes/guides/management/jconsole.html
>>
>>
>> For jdk8, it should be "8".
>> Mandy
>
> Mandy: Is the current relased saved somewhere accessible in the jdk, or is that something you suggest also be stored in the message.properties-files? In that case it doesn't seem like we're gaining much, since that would have to be updated between releaes...
>
> Erik Gahlin also pointed out that the JConsoleResources*.java-files are stale artefacts that can be safely removed since the messages are stored in the messages*.properties-files, so that alleviates some of the pain of storing the strings everywhere.
>
> Here's an updated webrev:
> http://cr.openjdk.java.net/~nloodin/8014048/webrev.01/
>
> Regards,
> Nils Loodin
>
>>
>>> /Staffan
>>>
>>> On 13 maj 2013, at 15:36, Nils Loodin<nils.loodin at oracle.com> wrote:
>>>
>>>> On 05/13/2013 03:36 PM, Nils Loodin wrote:
>>>>> Simple change of link in resource files:
>>>>>
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8014048
>>>>>
>>>>> Regards,
>>>>> Nils Loodin
>>>>
>>>> Also, with webrev link (might come in handy):
>>>> http://cr.openjdk.java.net/~nloodin/8014048/webrev.00/
>>
>
More information about the serviceability-dev
mailing list