RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

David Holmes david.holmes at oracle.com
Mon May 20 20:39:29 PDT 2013


Hi Coleen,

On 21/05/2013 8:39 AM, Coleen Phillimore wrote:
> Summary: Inject protection_domain, signers, init_lock into java_lang_Class

Basic VM changes look fine to me.

> Net footprint change is zero except that these fields are in Java heap
> rather than metaspace.  This helps a little with InstanceKlass size
> which is in fixed size space with UseCompressedKlassPointers. Included
> serviceability because there were SA changes to code that I don't know
> is used.

Unsure about the SA changes. Basically you just removed access to the pd 
and signers, rather than changing it to allow access via the new path. 
That said I don't know SA so don't know whether it makes sense for SA to 
access things that are logically part of java.lang.Class; or whether it 
can access them more directly anyway because they are logically part of 
java.lang.Class.

Thanks,
David
-----

> Future work is to remove the signers field and the unused
> SetProtectionDomain function.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8003421/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=8003421
>
> Tested with vm.quick.testlist, JPRT, jtreg java/security tests and jck8
> tests.
>
> Thanks,
> Coleen


More information about the serviceability-dev mailing list