jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows

[Chris Hegarty]

On 18/05/2013 01:09, Stuart Marks wrote:
> On 5/15/13 1:12 PM, Jaroslav Bachorik wrote:
>> Ok. I've changed it to use AtomicBoolean Thanks for pointing this out.
>> Even though it's rather obvious I got so used to using the final array
>> in anonymous inner classes that I didn't even stop and think. BTW,
>> there are a lot of places in the tests using this idiom in potentially
>> multithreaded environment :(
>
> Hrrm. OK, well, let's fix one test at a time. :-)
>
>> Updated webrev -
>> http://cr.openjdk.java.net/~jbachorik/8005472/webrev.10
>
> Thanks for the update. I took a quick look at it seems fine now.
>
> I think Chris may need to be the OpenJDK Reviewer on this one.

I've been over the archives to re-read the complete review thread on 
this. All in all, it is a thumbs up from me too.

-Chris.

>
> s'marks