From staffan.larsen at oracle.com Fri Nov 1 01:43:24 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 1 Nov 2013 09:43:24 +0100 Subject: RFR(XS): 8027692 Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Message-ID: When JDK-7196801 was fixed, the test wasn't removed from the ProblemList.txt. Thanks, /Staffan diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -128,9 +128,6 @@ # 7067973 java/lang/management/MemoryMXBean/CollectionUsageThreshold.java generic-all -# 7196801 -java/lang/management/MemoryMXBean/LowMemoryTest2.sh generic-all - # 8021230 java/lang/ThreadLocal/ThreadLocalSupplierTest.java generic-all From stefan.karlsson at oracle.com Fri Nov 1 02:00:44 2013 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Fri, 01 Nov 2013 10:00:44 +0100 Subject: RFR(XS): 8027692 Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt In-Reply-To: References: Message-ID: <52736DBC.90800@oracle.com> On 2013-11-01 09:43, Staffan Larsen wrote: > When JDK-7196801 was fixed, the test wasn't removed from the ProblemList.txt. Yes. We had to wait for some HotSpot changes to propagate up to the master repository. Thanks for reenabling the test. Looks good. StefanK > > Thanks, > /Staffan > > > diff --git a/test/ProblemList.txt b/test/ProblemList.txt > --- a/test/ProblemList.txt > +++ b/test/ProblemList.txt > @@ -128,9 +128,6 @@ > # 7067973 > java/lang/management/MemoryMXBean/CollectionUsageThreshold.java generic-all > > -# 7196801 > -java/lang/management/MemoryMXBean/LowMemoryTest2.sh generic-all > - > # 8021230 > java/lang/ThreadLocal/ThreadLocalSupplierTest.java generic-all From Alan.Bateman at oracle.com Fri Nov 1 02:02:00 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 01 Nov 2013 09:02:00 +0000 Subject: RFR(XS): 8027692 Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt In-Reply-To: References: Message-ID: <52736E08.5050204@oracle.com> On 01/11/2013 08:43, Staffan Larsen wrote: > When JDK-7196801 was fixed, the test wasn't removed from the ProblemList.txt. > > Thanks, > /Staffan > Looks okay, assuming the test is passing and stable now. -Alan. From staffan.larsen at oracle.com Fri Nov 1 02:08:46 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 1 Nov 2013 10:08:46 +0100 Subject: RFR(XS): 8027692 Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt In-Reply-To: <52736E08.5050204@oracle.com> References: <52736E08.5050204@oracle.com> Message-ID: <644E8A41-EA0C-40A7-BFC0-FC5D9E9B3E2B@oracle.com> Alan, Stefan: Thanks for the quick review! On 1 nov 2013, at 10:02, Alan Bateman wrote: > On 01/11/2013 08:43, Staffan Larsen wrote: >> When JDK-7196801 was fixed, the test wasn't removed from the ProblemList.txt. >> >> Thanks, >> /Staffan >> > Looks okay, assuming the test is passing and stable now. > > -Alan. From staffan.larsen at oracle.com Fri Nov 1 02:09:04 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 01 Nov 2013 09:09:04 +0000 Subject: hg: jdk8/tl/jdk: 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Message-ID: <20131101090942.EDA7B628D9@hg.openjdk.java.net> Changeset: c35f6df5bce9 Author: sla Date: 2013-11-01 10:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c35f6df5bce9 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Reviewed-by: stefank, alanb ! test/ProblemList.txt From staffan.larsen at oracle.com Fri Nov 1 03:31:59 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 1 Nov 2013 11:31:59 +0100 Subject: RFR(S): 7145419 com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. In-Reply-To: <52724F7E.1020100@oracle.com> References: <5270DCAB.6060608@oracle.com> <5270F729.2030501@oracle.com> <4F85D8F8-9E95-41D9-832F-2A9AB92CD5EE@oracle.com> <471CCA60-8F04-4C29-BBC4-80AD5DEA085B@oracle.com> <52724F7E.1020100@oracle.com> Message-ID: Here is new version that lets the program print the thread id which the test will pick up and use: webrev: http://cr.openjdk.java.net/~sla/7145419/webrev.01/ Thanks, /Staffan On 31 okt 2013, at 13:39, Daniel D. Daugherty wrote: > I stand corrected. Only the thread name is in the prompt. > I think I've been away from 'jdb' too long... > > Filtering the output of this might help: > > $ jdb Hello > Initializing jdb ... > > stop in Hello.main > Deferring breakpoint Hello.main. > It will be set after the class is loaded. > > run > run Hello > Set uncaught java.lang.Throwable > Set deferred uncaught java.lang.Throwable > > > VM Started: Set deferred breakpoint Hello.main > > Breakpoint hit: "thread=main", Hello.main(), line=3 bci=0 > 3 System.out.println("Hello World!"); > > main[1] threads > Group system: > (java.lang.ref.Reference$ReferenceHandler)0x141 Reference Handler cond. waiting > (java.lang.ref.Finalizer$FinalizerThread)0x140 Finalizer cond. waiting > (java.lang.Thread)0x13f Signal Dispatcher running > Group main: > (java.lang.Thread)0x1 main running (at breakpoint) > (java.lang.Thread)0x260 Thread-1 running > main[1] > > but is definitely more work. > > Dan > > > > On 10/30/13 8:53 AM, Staffan Larsen wrote: >> I think the number in the prompt is the current frame number: >> >> main[1] where >> [1] JdbMethodExitTest.bkpt (JdbMethodExitTest.java:84) >> [2] JdbMethodExitTest.main (JdbMethodExitTest.java:118) >> main[1] up >> main[2] where >> [2] JdbMethodExitTest.main (JdbMethodExitTest.java:118) >> >> >> On 30 okt 2013, at 13:26, Staffan Larsen wrote: >> >>> But that does not seem to work correctly: >>> >>> Initializing jdb ... >>>> stop in JdbMethodExitTest.bkpt() >>> Deferring breakpoint JdbMethodExitTest.bkpt(). >>> It will be set after the class is loaded. >>>> run >>> run JdbMethodExitTest >>> Set uncaught java.lang.Throwable >>> Set deferred uncaught java.lang.Throwable >>> VM Started: Set deferred breakpoint JdbMethodExitTest.bkpt() >>> >>> Breakpoint hit: "thread=main", JdbMethodExitTest.bkpt(), line=84 bci=0 >>> 84 int i = 0; //@1 breakpoint >>> >>> main[1] threads >>> Group system: >>> (java.lang.ref.Reference$ReferenceHandler)0x17c Reference Handler cond. waiting >>> (java.lang.ref.Finalizer$FinalizerThread)0x17b Finalizer cond. waiting >>> (java.lang.Thread)0x17a Signal Dispatcher running >>> Group main: >>> (java.lang.Thread)0x1 main running (at breakpoint) >>> main[1] thread 0x17a >>> Signal Dispatcher[1] >>> >>> >>> If the thread number was part of the prompt, I would have expected that last line to say "Signal Dispatcher[17a]". >>> >>> /Staffan >>> >>> >>> On 30 okt 2013, at 13:10, Daniel D. Daugherty wrote: >>> >>>> The current thread number is part of the jdb prompt. >>>> So something like this: >>>> >>>> $ jdb Hello >>>> Initializing jdb ... >>>>> stop in Hello.main >>>> Deferring breakpoint Hello.main. >>>> It will be set after the class is loaded. >>>>> run >>>> run Hello >>>> Set uncaught java.lang.Throwable >>>> Set deferred uncaught java.lang.Throwable >>>> VM Started: Set deferred breakpoint Hello.main >>>> >>>> Breakpoint hit: "thread=main", Hello.main(), line=3 bci=0 >>>> 3 System.out.println("Hello World!"); >>>> >>>> main[1] >>>> >>>> where you feed these cmds to jdb: >>>> >>>> stop in Hello.main >>>> run >>>> >>>> and your script checks for >>>> >>>> Breakpoint hit: "thread=main" >>>> >>>> and then pulls the number out of the prompt that follows: >>>> >>>> main[1] >>>> >>>> Dan >>>> >>>> >>>> >>>> On 10/30/13 7:10 AM, Staffan Larsen wrote: >>>>> I tried, that, but couldn't find what the jdb command for getting the current thread is. Anyone? >>>>> >>>>> /Staffan >>>>> >>>>> On 30 okt 2013, at 11:17, Mikael Auno wrote: >>>>> >>>>>> On 2013-10-29 15:41, Staffan Larsen wrote: >>>>>>> This test fails if there are background threads that run while the >>>>>>> test is running. I've modified the test to use the "trace" commands >>>>>>> in jdb with the extra thread parameter. I have assumed that the main >>>>>>> thread has thread id 1. "trace" with thread id behaves a little bit >>>>>>> different so a couple of extra "cont" were needed. >>>>>>> >>>>>>> webrev: http://cr.openjdk.java.net/~sla/7145419/webrev.00/ >>>>>> Would it be possible to set a breakpoint in main (or some other known location) to determine the thread id (as we do in some of the JDI tests) to make sure we have the right one before continuing with the rest of the test? >>>>>> >>>>>> Mikael > From daniel.daugherty at oracle.com Fri Nov 1 05:44:56 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 01 Nov 2013 08:44:56 -0400 Subject: RFR(S): 7145419 com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. In-Reply-To: References: <5270DCAB.6060608@oracle.com> <5270F729.2030501@oracle.com> <4F85D8F8-9E95-41D9-832F-2A9AB92CD5EE@oracle.com> <471CCA60-8F04-4C29-BBC4-80AD5DEA085B@oracle.com> <52724F7E.1020100@oracle.com> Message-ID: <5273A248.3070100@oracle.com> On 11/1/13 6:31 AM, Staffan Larsen wrote: > Here is new version that lets the program print the thread id Hey, that's cheating! :-) > which the test will pick up and use: > > webrev: http://cr.openjdk.java.net/~sla/7145419/webrev.01/ test/com/sun/jdi/JdbMethodExitTest.sh No comments. test/com/sun/jdi/ShellScaffold.sh line 1048: echo "apa $res" Debug output? Thumbs up. Dan > > Thanks, > /Staffan > > On 31 okt 2013, at 13:39, Daniel D. Daugherty wrote: > >> I stand corrected. Only the thread name is in the prompt. >> I think I've been away from 'jdb' too long... >> >> Filtering the output of this might help: >> >> $ jdb Hello >> Initializing jdb ... >>> stop in Hello.main >> Deferring breakpoint Hello.main. >> It will be set after the class is loaded. >>> run >> run Hello >> Set uncaught java.lang.Throwable >> Set deferred uncaught java.lang.Throwable >> VM Started: Set deferred breakpoint Hello.main >> >> Breakpoint hit: "thread=main", Hello.main(), line=3 bci=0 >> 3 System.out.println("Hello World!"); >> >> main[1] threads >> Group system: >> (java.lang.ref.Reference$ReferenceHandler)0x141 Reference Handler cond. waiting >> (java.lang.ref.Finalizer$FinalizerThread)0x140 Finalizer cond. waiting >> (java.lang.Thread)0x13f Signal Dispatcher running >> Group main: >> (java.lang.Thread)0x1 main running (at breakpoint) >> (java.lang.Thread)0x260 Thread-1 running >> main[1] >> >> but is definitely more work. >> >> Dan >> >> >> >> On 10/30/13 8:53 AM, Staffan Larsen wrote: >>> I think the number in the prompt is the current frame number: >>> >>> main[1] where >>> [1] JdbMethodExitTest.bkpt (JdbMethodExitTest.java:84) >>> [2] JdbMethodExitTest.main (JdbMethodExitTest.java:118) >>> main[1] up >>> main[2] where >>> [2] JdbMethodExitTest.main (JdbMethodExitTest.java:118) >>> >>> >>> On 30 okt 2013, at 13:26, Staffan Larsen wrote: >>> >>>> But that does not seem to work correctly: >>>> >>>> Initializing jdb ... >>>>> stop in JdbMethodExitTest.bkpt() >>>> Deferring breakpoint JdbMethodExitTest.bkpt(). >>>> It will be set after the class is loaded. >>>>> run >>>> run JdbMethodExitTest >>>> Set uncaught java.lang.Throwable >>>> Set deferred uncaught java.lang.Throwable >>>> VM Started: Set deferred breakpoint JdbMethodExitTest.bkpt() >>>> >>>> Breakpoint hit: "thread=main", JdbMethodExitTest.bkpt(), line=84 bci=0 >>>> 84 int i = 0; //@1 breakpoint >>>> >>>> main[1] threads >>>> Group system: >>>> (java.lang.ref.Reference$ReferenceHandler)0x17c Reference Handler cond. waiting >>>> (java.lang.ref.Finalizer$FinalizerThread)0x17b Finalizer cond. waiting >>>> (java.lang.Thread)0x17a Signal Dispatcher running >>>> Group main: >>>> (java.lang.Thread)0x1 main running (at breakpoint) >>>> main[1] thread 0x17a >>>> Signal Dispatcher[1] >>>> >>>> >>>> If the thread number was part of the prompt, I would have expected that last line to say "Signal Dispatcher[17a]". >>>> >>>> /Staffan >>>> >>>> >>>> On 30 okt 2013, at 13:10, Daniel D. Daugherty wrote: >>>> >>>>> The current thread number is part of the jdb prompt. >>>>> So something like this: >>>>> >>>>> $ jdb Hello >>>>> Initializing jdb ... >>>>>> stop in Hello.main >>>>> Deferring breakpoint Hello.main. >>>>> It will be set after the class is loaded. >>>>>> run >>>>> run Hello >>>>> Set uncaught java.lang.Throwable >>>>> Set deferred uncaught java.lang.Throwable >>>>> VM Started: Set deferred breakpoint Hello.main >>>>> >>>>> Breakpoint hit: "thread=main", Hello.main(), line=3 bci=0 >>>>> 3 System.out.println("Hello World!"); >>>>> >>>>> main[1] >>>>> >>>>> where you feed these cmds to jdb: >>>>> >>>>> stop in Hello.main >>>>> run >>>>> >>>>> and your script checks for >>>>> >>>>> Breakpoint hit: "thread=main" >>>>> >>>>> and then pulls the number out of the prompt that follows: >>>>> >>>>> main[1] >>>>> >>>>> Dan >>>>> >>>>> >>>>> >>>>> On 10/30/13 7:10 AM, Staffan Larsen wrote: >>>>>> I tried, that, but couldn't find what the jdb command for getting the current thread is. Anyone? >>>>>> >>>>>> /Staffan >>>>>> >>>>>> On 30 okt 2013, at 11:17, Mikael Auno wrote: >>>>>> >>>>>>> On 2013-10-29 15:41, Staffan Larsen wrote: >>>>>>>> This test fails if there are background threads that run while the >>>>>>>> test is running. I've modified the test to use the "trace" commands >>>>>>>> in jdb with the extra thread parameter. I have assumed that the main >>>>>>>> thread has thread id 1. "trace" with thread id behaves a little bit >>>>>>>> different so a couple of extra "cont" were needed. >>>>>>>> >>>>>>>> webrev: http://cr.openjdk.java.net/~sla/7145419/webrev.00/ >>>>>>> Would it be possible to set a breakpoint in main (or some other known location) to determine the thread id (as we do in some of the JDI tests) to make sure we have the right one before continuing with the rest of the test? >>>>>>> >>>>>>> Mikael From staffan.larsen at oracle.com Fri Nov 1 06:15:00 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 1 Nov 2013 14:15:00 +0100 Subject: RFR(S): 7145419 com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. In-Reply-To: <5273A248.3070100@oracle.com> References: <5270DCAB.6060608@oracle.com> <5270F729.2030501@oracle.com> <4F85D8F8-9E95-41D9-832F-2A9AB92CD5EE@oracle.com> <471CCA60-8F04-4C29-BBC4-80AD5DEA085B@oracle.com> <52724F7E.1020100@oracle.com> <5273A248.3070100@oracle.com> Message-ID: <5E74D591-20A9-4980-B0C3-75C87395507F@oracle.com> On 1 nov 2013, at 13:44, Daniel D. Daugherty wrote: > On 11/1/13 6:31 AM, Staffan Larsen wrote: >> Here is new version that lets the program print the thread id > > Hey, that's cheating! :-) > > >> which the test will pick up and use: >> >> webrev: http://cr.openjdk.java.net/~sla/7145419/webrev.01/ > > test/com/sun/jdi/JdbMethodExitTest.sh > No comments. > > test/com/sun/jdi/ShellScaffold.sh > line 1048: echo "apa $res" > Debug output? Oops. I'll remove that before pushing. Thanks, /Staffan > > Thumbs up. > > Dan > > >> >> Thanks, >> /Staffan >> >> On 31 okt 2013, at 13:39, Daniel D. Daugherty wrote: >> >>> I stand corrected. Only the thread name is in the prompt. >>> I think I've been away from 'jdb' too long... >>> >>> Filtering the output of this might help: >>> >>> $ jdb Hello >>> Initializing jdb ... >>>> stop in Hello.main >>> Deferring breakpoint Hello.main. >>> It will be set after the class is loaded. >>>> run >>> run Hello >>> Set uncaught java.lang.Throwable >>> Set deferred uncaught java.lang.Throwable >>> VM Started: Set deferred breakpoint Hello.main >>> >>> Breakpoint hit: "thread=main", Hello.main(), line=3 bci=0 >>> 3 System.out.println("Hello World!"); >>> >>> main[1] threads >>> Group system: >>> (java.lang.ref.Reference$ReferenceHandler)0x141 Reference Handler cond. waiting >>> (java.lang.ref.Finalizer$FinalizerThread)0x140 Finalizer cond. waiting >>> (java.lang.Thread)0x13f Signal Dispatcher running >>> Group main: >>> (java.lang.Thread)0x1 main running (at breakpoint) >>> (java.lang.Thread)0x260 Thread-1 running >>> main[1] >>> >>> but is definitely more work. >>> >>> Dan >>> >>> >>> >>> On 10/30/13 8:53 AM, Staffan Larsen wrote: >>>> I think the number in the prompt is the current frame number: >>>> >>>> main[1] where >>>> [1] JdbMethodExitTest.bkpt (JdbMethodExitTest.java:84) >>>> [2] JdbMethodExitTest.main (JdbMethodExitTest.java:118) >>>> main[1] up >>>> main[2] where >>>> [2] JdbMethodExitTest.main (JdbMethodExitTest.java:118) >>>> >>>> >>>> On 30 okt 2013, at 13:26, Staffan Larsen wrote: >>>> >>>>> But that does not seem to work correctly: >>>>> >>>>> Initializing jdb ... >>>>>> stop in JdbMethodExitTest.bkpt() >>>>> Deferring breakpoint JdbMethodExitTest.bkpt(). >>>>> It will be set after the class is loaded. >>>>>> run >>>>> run JdbMethodExitTest >>>>> Set uncaught java.lang.Throwable >>>>> Set deferred uncaught java.lang.Throwable >>>>> VM Started: Set deferred breakpoint JdbMethodExitTest.bkpt() >>>>> >>>>> Breakpoint hit: "thread=main", JdbMethodExitTest.bkpt(), line=84 bci=0 >>>>> 84 int i = 0; //@1 breakpoint >>>>> >>>>> main[1] threads >>>>> Group system: >>>>> (java.lang.ref.Reference$ReferenceHandler)0x17c Reference Handler cond. waiting >>>>> (java.lang.ref.Finalizer$FinalizerThread)0x17b Finalizer cond. waiting >>>>> (java.lang.Thread)0x17a Signal Dispatcher running >>>>> Group main: >>>>> (java.lang.Thread)0x1 main running (at breakpoint) >>>>> main[1] thread 0x17a >>>>> Signal Dispatcher[1] >>>>> >>>>> >>>>> If the thread number was part of the prompt, I would have expected that last line to say "Signal Dispatcher[17a]". >>>>> >>>>> /Staffan >>>>> >>>>> >>>>> On 30 okt 2013, at 13:10, Daniel D. Daugherty wrote: >>>>> >>>>>> The current thread number is part of the jdb prompt. >>>>>> So something like this: >>>>>> >>>>>> $ jdb Hello >>>>>> Initializing jdb ... >>>>>>> stop in Hello.main >>>>>> Deferring breakpoint Hello.main. >>>>>> It will be set after the class is loaded. >>>>>>> run >>>>>> run Hello >>>>>> Set uncaught java.lang.Throwable >>>>>> Set deferred uncaught java.lang.Throwable >>>>>> VM Started: Set deferred breakpoint Hello.main >>>>>> >>>>>> Breakpoint hit: "thread=main", Hello.main(), line=3 bci=0 >>>>>> 3 System.out.println("Hello World!"); >>>>>> >>>>>> main[1] >>>>>> >>>>>> where you feed these cmds to jdb: >>>>>> >>>>>> stop in Hello.main >>>>>> run >>>>>> >>>>>> and your script checks for >>>>>> >>>>>> Breakpoint hit: "thread=main" >>>>>> >>>>>> and then pulls the number out of the prompt that follows: >>>>>> >>>>>> main[1] >>>>>> >>>>>> Dan >>>>>> >>>>>> >>>>>> >>>>>> On 10/30/13 7:10 AM, Staffan Larsen wrote: >>>>>>> I tried, that, but couldn't find what the jdb command for getting the current thread is. Anyone? >>>>>>> >>>>>>> /Staffan >>>>>>> >>>>>>> On 30 okt 2013, at 11:17, Mikael Auno wrote: >>>>>>> >>>>>>>> On 2013-10-29 15:41, Staffan Larsen wrote: >>>>>>>>> This test fails if there are background threads that run while the >>>>>>>>> test is running. I've modified the test to use the "trace" commands >>>>>>>>> in jdb with the extra thread parameter. I have assumed that the main >>>>>>>>> thread has thread id 1. "trace" with thread id behaves a little bit >>>>>>>>> different so a couple of extra "cont" were needed. >>>>>>>>> >>>>>>>>> webrev: http://cr.openjdk.java.net/~sla/7145419/webrev.00/ >>>>>>>> Would it be possible to set a breakpoint in main (or some other known location) to determine the thread id (as we do in some of the JDI tests) to make sure we have the right one before continuing with the rest of the test? >>>>>>>> >>>>>>>> Mikael > From erik.helin at oracle.com Fri Nov 1 06:16:59 2013 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 1 Nov 2013 14:16:59 +0100 Subject: RFR 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodH,andle In-Reply-To: <5271C64A.8010001@oracle.com> References: <5271C64A.8010001@oracle.com> Message-ID: <20131101131659.GA6464@ehelin-thinkpad> Hi Coleen, this looks great, just one minor nit: could you please update the comment starting at jvmtiImpl.cpp:242 (which explains why using allow_unhandled_oop is correct) to use _class_holder instead of _class_loader? Thanks, Erik On 2013-10-30, Coleen Phillimore wrote: > 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might > not work with anonymous classes > Summary: Walk methods in breakpoints for marking on stack so they > aren't deallocated by redefine classes. Use class_holder rather > than class_loader to keep GC from reclaiming class owning the > method. > > This is two bug fixes to the same code. > > open webrev at http://cr.openjdk.java.net/~coleenp/8026946_8026948/ > bug link https://bugs.openjdk.java.net/browse/JDK-8026946 > https://bugs.openjdk.java.net/browse/JDK-8026948 > > Tested with vm.quick.testlist - and verified the jdi tests eg > nsk/jdi/BScenarios/hotswap/tc01x001 test this path. > > Thanks, > Coleen From coleen.phillimore at oracle.com Fri Nov 1 07:09:20 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Fri, 01 Nov 2013 10:09:20 -0400 Subject: RFR 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodH,andle In-Reply-To: <20131101131659.GA6464@ehelin-thinkpad> References: <5271C64A.8010001@oracle.com> <20131101131659.GA6464@ehelin-thinkpad> Message-ID: <5273B610.4040802@oracle.com> On 11/1/2013 9:16 AM, Erik Helin wrote: > Hi Coleen, > > this looks great, just one minor nit: could you please update the > comment starting at jvmtiImpl.cpp:242 (which explains why using > allow_unhandled_oop is correct) to use _class_holder instead of > _class_loader? I fixed it and the : in JvmtiBreakpoint:s. Thanks for the code review. Coleen > > Thanks, > Erik > > On 2013-10-30, Coleen Phillimore wrote: >> 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might >> not work with anonymous classes >> Summary: Walk methods in breakpoints for marking on stack so they >> aren't deallocated by redefine classes. Use class_holder rather >> than class_loader to keep GC from reclaiming class owning the >> method. >> >> This is two bug fixes to the same code. >> >> open webrev at http://cr.openjdk.java.net/~coleenp/8026946_8026948/ >> bug link https://bugs.openjdk.java.net/browse/JDK-8026946 >> https://bugs.openjdk.java.net/browse/JDK-8026948 >> >> Tested with vm.quick.testlist - and verified the jdi tests eg >> nsk/jdi/BScenarios/hotswap/tc01x001 test this path. >> >> Thanks, >> Coleen From coleen.phillimore at oracle.com Fri Nov 1 07:09:46 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Fri, 01 Nov 2013 10:09:46 -0400 Subject: RFR 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodH,andle In-Reply-To: <527288B2.2030407@oracle.com> References: <5271C64A.8010001@oracle.com> <527288B2.2030407@oracle.com> Message-ID: <5273B62A.1060904@oracle.com> On 10/31/2013 12:43 PM, serguei.spitsyn at oracle.com wrote: > Coleen, > > It looks good, thank you for fixing it! Thanks for the code review Serguei. Coleen > > Thanks, > Serguei > > On 10/30/13 7:54 PM, Coleen Phillimore wrote: >> 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might >> not work with anonymous classes >> Summary: Walk methods in breakpoints for marking on stack so they >> aren't deallocated by redefine classes. Use class_holder rather than >> class_loader to keep GC from reclaiming class owning the method. >> >> This is two bug fixes to the same code. >> >> open webrev at http://cr.openjdk.java.net/~coleenp/8026946_8026948/ >> bug link https://bugs.openjdk.java.net/browse/JDK-8026946 >> https://bugs.openjdk.java.net/browse/JDK-8026948 >> >> Tested with vm.quick.testlist - and verified the jdi tests eg >> nsk/jdi/BScenarios/hotswap/tc01x001 test this path. >> >> Thanks, >> Coleen > From staffan.larsen at oracle.com Fri Nov 1 07:14:56 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 01 Nov 2013 14:14:56 +0000 Subject: hg: jdk8/tl/jdk: 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Message-ID: <20131101141514.DF43A628DC@hg.openjdk.java.net> Changeset: c59ccad6eb72 Author: sla Date: 2013-11-01 15:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c59ccad6eb72 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Reviewed-by: dcubed ! test/com/sun/jdi/JdbMethodExitTest.sh ! test/com/sun/jdi/ShellScaffold.sh From staffan.larsen at oracle.com Fri Nov 1 07:29:00 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 1 Nov 2013 15:29:00 +0100 Subject: RFR 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodH, andle In-Reply-To: <5271C64A.8010001@oracle.com> References: <5271C64A.8010001@oracle.com> Message-ID: Looks good! Thanks, /Staffan On 31 okt 2013, at 03:54, Coleen Phillimore wrote: > 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might not work with anonymous classes > Summary: Walk methods in breakpoints for marking on stack so they aren't deallocated by redefine classes. Use class_holder rather than class_loader to keep GC from reclaiming class owning the method. > > This is two bug fixes to the same code. > > open webrev at http://cr.openjdk.java.net/~coleenp/8026946_8026948/ > bug link https://bugs.openjdk.java.net/browse/JDK-8026946 > https://bugs.openjdk.java.net/browse/JDK-8026948 > > Tested with vm.quick.testlist - and verified the jdi tests eg nsk/jdi/BScenarios/hotswap/tc01x001 test this path. > > Thanks, > Coleen From ron.durbin at oracle.com Fri Nov 1 10:06:17 2013 From: ron.durbin at oracle.com (Ron Durbin) Date: Fri, 1 Nov 2013 10:06:17 -0700 (PDT) Subject: hsx/hotspot-rt/hotspot: 8027616: Off by one error in putback for compressed oops nashorn performance improvement In-Reply-To: <<20131031212346.B75D9628B7@hg.openjdk.java.net>> References: <<20131031212346.B75D9628B7@hg.openjdk.java.net>> Message-ID: <947c369c-3983-413f-a2f5-776ea35d3703@default> Coleen Thx for fixing this. The code looks good; > -----Original Message----- > From: hotspot-runtime-dev-bounces at openjdk.java.net [mailto:hotspot-runtime-dev- > bounces at openjdk.java.net] On Behalf Of coleen.phillimore at oracle.com > Sent: Thursday, October 31, 2013 3:24 PM > To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net > Subject: hg: hsx/hotspot-rt/hotspot: 8027616: Off by one error in putback for compressed > oops nashorn performance improvement > > Changeset: c8fc12209830 > Author: coleenp > Date: 2013-10-31 14:11 -0400 > URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c8fc12209830 > > 8027616: Off by one error in putback for compressed oops nashorn performance improvement > Summary: Should compare bounds greater than or equal 4G when deciding if shift is needed or > CDS area + compressed class space are within 4G of each other. > Reviewed-by: stefank, hseigel, zgu > > ! src/share/vm/memory/metaspace.cpp From coleen.phillimore at oracle.com Fri Nov 1 10:06:15 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Fri, 01 Nov 2013 17:06:15 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodHandle; ... Message-ID: <20131101170622.E4E9E628E3@hg.openjdk.java.net> Changeset: 910026b800b8 Author: coleenp Date: 2013-11-01 10:32 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/910026b800b8 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodHandle 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might not work with anonymous classes Summary: Walk methods in breakpoints for marking on stack so they aren't deallocated by redefine classes. Use class_holder rather than class_loader to keep GC from reclaiming class owning the method. Reviewed-by: sspitsyn, ehelin, sla ! src/share/vm/classfile/metadataOnStackMark.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp From markus.gronlund at oracle.com Fri Nov 1 11:29:28 2013 From: markus.gronlund at oracle.com (markus.gronlund at oracle.com) Date: Fri, 01 Nov 2013 18:29:28 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 43 new changesets Message-ID: <20131101183058.663F8628E6@hg.openjdk.java.net> Changeset: 5c599c419c1d Author: hseigel Date: 2013-07-11 12:59 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5c599c419c1d 8016256: Make finalization final Summary: Add private methods to final methods check Reviewed-by: coleenp, acorn, ahgross Contributed-by: harold.seigel at oracle.com ! src/share/vm/classfile/classFileParser.cpp Changeset: d840f02d03b4 Author: chegar Date: 2013-07-15 11:07 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d840f02d03b4 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp Changeset: 7ec210434b3c Author: chegar Date: 2013-07-22 14:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7ec210434b3c Merge - src/share/vm/memory/klassInfoClosure.hpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: ca9029490fce Author: chegar Date: 2013-07-25 17:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ca9029490fce Merge Changeset: 8f66130f7b5c Author: chegar Date: 2013-08-02 11:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8f66130f7b5c Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: 38f9393d1847 Author: sgabdura Date: 2013-08-09 11:03 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/38f9393d1847 8020789: Disable exporting of gc.heap_dump diagnostic command Reviewed-by: fparain, ahgross ! src/share/vm/services/diagnosticCommand.cpp Changeset: ee7a7aa7c6bb Author: chegar Date: 2013-08-09 14:30 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ee7a7aa7c6bb Merge Changeset: 8f3c59225a5c Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8f3c59225a5c Merge - test/runtime/7196045/Test7196045.java - test/runtime/8000968/Test8000968.sh Changeset: 7638e35cabc6 Author: erikj Date: 2013-08-19 17:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7638e35cabc6 8015614: Update build settings Reviewed-by: tbell, dholmes, ahgross ! make/windows/makefiles/compile.make ! make/windows/makefiles/sa.make Changeset: d4fa23d6c35b Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d4fa23d6c35b Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 07b5f47d7a18 Author: chegar Date: 2013-08-30 09:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/07b5f47d7a18 Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: 98a2169ed7ac Author: iklam Date: 2013-08-24 00:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/98a2169ed7ac 8023683: Enhance class file parsing Summary: Use the value returned by REALLOC_RESOURCE_ARRAY() Reviewed-by: coleenp, ahgross ! src/share/vm/classfile/classFileParser.cpp Changeset: 8321dcc18438 Author: chegar Date: 2013-10-13 21:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8321dcc18438 Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: 1a93f2c5945a Author: lana Date: 2013-10-17 14:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1a93f2c5945a Merge ! make/windows/makefiles/compile.make ! make/windows/makefiles/sa.make ! src/share/vm/classfile/classFileParser.cpp Changeset: 4589b398ab03 Author: amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4589b398ab03 Merge - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp - test/compiler/8013496/Test8013496.sh - test/gc/7168848/HumongousAlloc.java Changeset: 4a1128861221 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4a1128861221 Added tag jdk8-b113 for changeset 4589b398ab03 ! .hgtags Changeset: 82a9cdbf683e Author: amurillo Date: 2013-10-25 13:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/82a9cdbf683e Merge ! src/share/vm/services/diagnosticCommand.cpp - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: bde83ddf920c Author: amurillo Date: 2013-10-25 13:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bde83ddf920c Added tag hs25-b56 for changeset 82a9cdbf683e ! .hgtags Changeset: f94a9f0746d8 Author: amurillo Date: 2013-10-25 13:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f94a9f0746d8 8027173: new hotspot build - hs25-b57 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 85730a185147 Author: ccheung Date: 2013-10-30 14:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/85730a185147 Merge Changeset: 292050e5d5ea Author: dholmes Date: 2013-10-24 00:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/292050e5d5ea 8026877: Error in opening JAR file when invalid jar specified with -Xbootclasspath/a on OpenJDK build Reviewed-by: coleenp, twisti ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/thread.cpp Changeset: 066778844ed9 Author: jprovino Date: 2013-10-27 14:11 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/066778844ed9 Merge Changeset: f2f9139ccde9 Author: jprovino Date: 2013-10-30 16:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f2f9139ccde9 Merge Changeset: a007575ea726 Author: vladidan Date: 2013-10-30 16:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a007575ea726 Merge Changeset: 3b3133d93fb6 Author: brutisso Date: 2013-10-28 13:27 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3b3133d93fb6 8027132: Print deprecation warning message for the flags controlling the CMS foreground collector Reviewed-by: stefank, ehelin, ysr, tschatzl ! src/share/vm/runtime/arguments.cpp + test/gc/startup_warnings/TestCMSForegroundFlags.java Changeset: 6d965678f21e Author: ehelin Date: 2013-10-31 21:20 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6d965678f21e Merge Changeset: bd3237e0e18d Author: twisti Date: 2013-10-24 16:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bd3237e0e18d 8026328: Setting a breakpoint on invokedynamic crashes the JVM Reviewed-by: jrose, roland ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/cppInterpreter.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreter.hpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/handles.cpp Changeset: cbe8ba0fb8fc Author: twisti Date: 2013-10-24 16:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cbe8ba0fb8fc Merge - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: f01788f13696 Author: adlertz Date: 2013-10-25 10:13 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f01788f13696 8026940: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc Summary: Remove input to junk phi if they also become dead during post_allocate_copy_removal Reviewed-by: roland ! src/share/vm/opto/postaloc.cpp Changeset: 7ae254fd0b3c Author: adlertz Date: 2013-10-25 12:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7ae254fd0b3c Merge Changeset: 6c2f07d1495f Author: roland Date: 2013-10-28 09:58 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6c2f07d1495f 8027140: Assertion in compiler when running bigapps/Kitchensink/stability Summary: filter() code for TypeKlassPtr not moved when permgen removal was introduced Reviewed-by: twisti, iveresov ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: bfdb530cdffa Author: roland Date: 2013-10-28 12:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bfdb530cdffa Merge Changeset: a196f1aaec86 Author: anoll Date: 2013-10-25 22:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a196f1aaec86 8026949: -Xint flag prints wrong warning: Initialization of C1 thread failed (no space to run compilers) Summary: Exit compiler threads early during startup so that wrong error message is not printed Reviewed-by: iveresov, twisti ! src/share/vm/compiler/compileBroker.cpp + test/compiler/startup/StartupOutput.java Changeset: 8c16f426dbb2 Author: iveresov Date: 2013-10-28 15:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8c16f426dbb2 Merge Changeset: fc1632f5021a Author: iveresov Date: 2013-10-28 17:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fc1632f5021a Merge Changeset: a57a165b8296 Author: rbackman Date: 2013-10-28 08:34 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a57a165b8296 8027353: Exact intrinsics: assert(n != NULL) failed: must not be null Reviewed-by: kvn, roland ! src/share/vm/opto/library_call.cpp ! test/compiler/intrinsics/mathexact/SubExactLConstantTest.java ! test/compiler/intrinsics/mathexact/SubExactLNonConstantTest.java Changeset: 60a32bb8ff99 Author: rbackman Date: 2013-10-30 13:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/60a32bb8ff99 8027444: mathExact: assert(i < _max) failed: oob: i=1, _max=1 Reviewed-by: duke ! src/share/vm/opto/loopTransform.cpp + test/compiler/intrinsics/mathexact/NestedMathExactTest.java Changeset: 4d3575d37a07 Author: iveresov Date: 2013-10-30 22:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4d3575d37a07 8026735: Stream tests throw java.lang.IncompatibleClassChangeError Summary: Put a band-aid to disable CHA-based inlining for interfaces with default methods in C1 Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp + test/compiler/inlining/InlineDefaultMethod.java Changeset: 946a8294ab15 Author: iveresov Date: 2013-10-31 04:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/946a8294ab15 8024919: G1: SPECjbb2013 crashes due to a broken object reference Summary: Pass correct new value to post_barrer() in Unsafe.getAndSetObject() C1 intrinsic Reviewed-by: kvn, roland ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp Changeset: 2dcd0bd2920d Author: iveresov Date: 2013-10-31 14:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2dcd0bd2920d Merge Changeset: 0836a3c28c6a Author: iveresov Date: 2013-10-31 15:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0836a3c28c6a Merge Changeset: 42790b7e4d48 Author: mgronlun Date: 2013-11-01 15:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/42790b7e4d48 Merge ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: f8b56489e455 Author: mgronlun Date: 2013-11-01 17:10 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f8b56489e455 Merge From vicente.romero at oracle.com Fri Nov 1 12:09:26 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 01 Nov 2013 19:09:26 +0000 Subject: hg: jdk8/tl/langtools: 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Message-ID: <20131101190930.08985628E7@hg.openjdk.java.net> Changeset: cc80c03c41e4 Author: vromero Date: 2013-11-01 19:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc80c03c41e4 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Reviewed-by: jjg Contributed-by: vicente.romero at oracle.com, jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! test/tools/javac/flow/LVTHarness.java + test/tools/javac/flow/tests/TestCaseLocalInInnerBlock.java From jan.lahoda at oracle.com Fri Nov 1 13:48:45 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Fri, 01 Nov 2013 20:48:45 +0000 Subject: hg: jdk8/tl/langtools: 8027310: Annotation Processor crashes with NPE Message-ID: <20131101204857.4FF35628F2@hg.openjdk.java.net> Changeset: 8b4e1421a9b7 Author: jlahoda Date: 2013-11-01 21:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b4e1421a9b7 8027310: Annotation Processor crashes with NPE Summary: JCAnnotation.attribute is null when annotation type is unavailable Reviewed-by: jjg, jfranck ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/processing/errors/CrashOnNonExistingAnnotation/Processor.java + test/tools/javac/processing/errors/CrashOnNonExistingAnnotation/Source.java From dan.xu at oracle.com Fri Nov 1 14:40:15 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 01 Nov 2013 21:40:15 +0000 Subject: hg: jdk8/tl/jdk: 8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again Message-ID: <20131101214044.2D64662907@hg.openjdk.java.net> Changeset: 6a6faa00acc4 Author: dxu Date: 2013-11-01 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a6faa00acc4 8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again Reviewed-by: wetmore ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java From john.coomes at oracle.com Fri Nov 1 20:03:40 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 02 Nov 2013 03:03:40 +0000 Subject: hg: hsx/hotspot-rt/corba: 24 new changesets Message-ID: <20131102030355.B001962924@hg.openjdk.java.net> Changeset: 66fc1a749867 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/66fc1a749867 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildCorba.gmk ! makefiles/Makefile Changeset: 43cec76d1d62 Author: katleman Date: 2013-10-16 11:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/43cec76d1d62 Merge Changeset: 54aa9b7d743d Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/54aa9b7d743d Added tag jdk8-b112 for changeset 43cec76d1d62 ! .hgtags Changeset: 81d694b1ab2f Author: msheppar Date: 2013-06-14 16:31 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/81d694b1ab2f 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu ! src/share/classes/com/sun/corba/se/impl/transport/SelectorImpl.java ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java Changeset: ab6eae733bce Author: chegar Date: 2013-07-15 11:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/ab6eae733bce Merge Changeset: e5ea72df9806 Author: chegar Date: 2013-07-22 13:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/e5ea72df9806 Merge Changeset: be4fdc568d73 Author: mchung Date: 2013-07-22 19:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/be4fdc568d73 8017196: Ensure Proxies are handled appropriately Reviewed-by: dfuchs, jrose, jdn, ahgross, chegar ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/InvocationHandlerFactoryImpl.java ! src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java Changeset: b0aeb77f0292 Author: chegar Date: 2013-07-25 17:32 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/b0aeb77f0292 Merge Changeset: a72f506e3058 Author: chegar Date: 2013-08-02 09:38 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/a72f506e3058 Merge Changeset: 0717fc6f2960 Author: chegar Date: 2013-08-09 14:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/0717fc6f2960 Merge Changeset: 6b5db99e194c Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/6b5db99e194c Merge - src/share/classes/com/sun/corba/se/impl/copyobject/JavaInputStream.sjava - src/share/classes/com/sun/corba/se/impl/copyobject/JavaOutputStream.sjava - src/share/classes/com/sun/corba/se/impl/interceptors/ThreadCurrentStack.sjava - src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl_save.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/transport/BufferConnectionImpl.sjava Changeset: 9c75c61d97f8 Author: msheppar Date: 2013-08-19 15:22 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/9c75c61d97f8 8022940: Enhance CORBA translations Reviewed-by: coffeys, alanb, skoivu ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl.java Changeset: 2caa37dfd7cd Author: chegar Date: 2013-08-23 22:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/2caa37dfd7cd Merge Changeset: a5788ab042dc Author: chegar Date: 2013-08-30 09:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/a5788ab042dc Merge Changeset: 118a211bb3ba Author: chegar Date: 2013-09-06 09:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/118a211bb3ba Merge Changeset: cc52d582df09 Author: chegar Date: 2013-09-14 19:40 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/cc52d582df09 Merge Changeset: 396854c032bb Author: chegar Date: 2013-10-03 19:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/396854c032bb Merge Changeset: 47513cdce4ed Author: chegar Date: 2013-10-13 22:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/47513cdce4ed Merge Changeset: 438c54c148a6 Author: erikj Date: 2013-10-16 13:49 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/438c54c148a6 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Reviewed-by: dholmes, chegar ! makefiles/BuildCorba.gmk Changeset: 1a71d800b032 Author: wetmore Date: 2013-10-16 23:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/1a71d800b032 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/BuildCorba.gmk Changeset: 1c01208087b5 Author: lana Date: 2013-10-17 14:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/1c01208087b5 Merge ! makefiles/BuildCorba.gmk Changeset: a259ff3e42d9 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/a259ff3e42d9 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 0bbccf77c23e Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/0bbccf77c23e Added tag jdk8-b113 for changeset a259ff3e42d9 ! .hgtags Changeset: d425685e0b74 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/d425685e0b74 Added tag jdk8-b114 for changeset 0bbccf77c23e ! .hgtags From john.coomes at oracle.com Fri Nov 1 20:03:29 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 02 Nov 2013 03:03:29 +0000 Subject: hg: hsx/hotspot-rt: 60 new changesets Message-ID: <20131102030334.C2AC462923@hg.openjdk.java.net> Changeset: 187a759c08ba Author: alanb Date: 2013-10-02 04:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/187a759c08ba 8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is not in the Java SE specification Reviewed-by: mduigou, tbell ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: 6b8f5030e5ad Author: bpatel Date: 2013-10-04 15:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/6b8f5030e5ad 8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8. Reviewed-by: tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: 7c0e2fd8be4d Author: lana Date: 2013-10-08 14:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/7c0e2fd8be4d Merge Changeset: 3ece65f23ed2 Author: lana Date: 2013-10-11 00:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/3ece65f23ed2 Merge Changeset: 7dea0ce25bdc Author: pbhat Date: 2013-05-30 16:00 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/7dea0ce25bdc Merge ! common/autoconf/generated-configure.sh Changeset: d081bdbf904d Author: jqzuo Date: 2013-06-10 16:15 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/d081bdbf904d Merge ! common/autoconf/generated-configure.sh Changeset: b59990653fb9 Author: pbhat Date: 2013-06-21 18:56 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b59990653fb9 Merge ! common/autoconf/generated-configure.sh Changeset: dd345e4b51fb Author: pbhat Date: 2013-07-05 11:00 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/dd345e4b51fb Merge ! common/autoconf/generated-configure.sh Changeset: 24cc2d9b0af5 Author: pbhat Date: 2013-07-18 16:49 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/24cc2d9b0af5 Merge ! common/autoconf/generated-configure.sh Changeset: 4a4c9e7bc6c9 Author: pbhat Date: 2013-07-25 17:26 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/4a4c9e7bc6c9 Merge Changeset: 63d794ade242 Author: pbhat Date: 2013-08-02 09:41 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/63d794ade242 Merge Changeset: a5485b9a2d14 Author: pbhat Date: 2013-08-09 14:54 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/a5485b9a2d14 Merge Changeset: 028ac95111b9 Author: pbhat Date: 2013-08-16 14:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/028ac95111b9 Merge Changeset: 4b686cbc32c7 Author: pbhat Date: 2013-08-23 09:45 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/4b686cbc32c7 Merge ! common/autoconf/generated-configure.sh Changeset: ec583e324aaf Author: pbhat Date: 2013-08-30 10:14 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ec583e324aaf Merge ! common/autoconf/generated-configure.sh Changeset: 96f00091b570 Author: pbhat Date: 2013-09-05 11:23 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/96f00091b570 Merge ! common/autoconf/generated-configure.sh Changeset: 69096d4b1da2 Author: pbhat Date: 2013-09-12 12:08 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/69096d4b1da2 Merge ! common/autoconf/generated-configure.sh Changeset: 5a306baf3bb7 Author: pbhat Date: 2013-09-19 14:01 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/5a306baf3bb7 Merge ! common/autoconf/generated-configure.sh Changeset: 88ca3ff9ce2d Author: billyh Date: 2013-09-25 10:50 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/88ca3ff9ce2d 8025262: new64jre/new64jdk wrappers should be removed, build 32-bit AU during windows-amd64 builds instead Reviewed-by: amenkov, jqzuo ! make/install-rules.gmk Changeset: c8066e5d7a7b Author: pbhat Date: 2013-09-26 11:20 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c8066e5d7a7b Merge Changeset: 00ae95ca1755 Author: pbhat Date: 2013-10-03 09:52 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/00ae95ca1755 Merge Changeset: 7deff16cf438 Author: jqzuo Date: 2013-10-14 18:53 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/7deff16cf438 Merge ! common/autoconf/generated-configure.sh Changeset: ec48d637778a Author: tbell Date: 2013-10-09 18:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ec48d637778a 8023611: Win32 and win64: Remove all the WARNINGS in JDK 8 builds for Windows 2008 and MSVS 2010 SP1 Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: 174a54ce39c4 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/174a54ce39c4 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! NewMakefile.gmk ! common/autoconf/autogen.sh ! common/autoconf/basics.m4 ! common/autoconf/basics_windows.m4 ! common/autoconf/boot-jdk.m4 ! common/autoconf/bootcycle-spec.gmk.in ! common/autoconf/build-aux/config.guess ! common/autoconf/build-performance.m4 ! common/autoconf/builddeps.conf.example ! common/autoconf/builddeps.conf.nfs.example ! common/autoconf/builddeps.m4 ! common/autoconf/compare.sh.in ! common/autoconf/config.h.in ! common/autoconf/configure ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/libraries.m4 ! common/autoconf/platform.m4 ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/autoconf/toolchain_windows.m4 ! common/makefiles/HotspotWrapper.gmk ! common/makefiles/IdlCompilation.gmk ! common/makefiles/JavaCompilation.gmk ! common/makefiles/Jprt.gmk ! common/makefiles/Main.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/MakeHelpers.gmk ! common/makefiles/NativeCompilation.gmk ! common/makefiles/RMICompilation.gmk ! common/makefiles/devkit/Makefile ! common/makefiles/devkit/Tools.gmk ! common/makefiles/javadoc/CORE_PKGS.gmk ! common/makefiles/javadoc/Javadoc.gmk ! common/makefiles/javadoc/NON_CORE_PKGS.gmk ! common/makefiles/javadoc/Notes.html Changeset: 6274d4cd22d3 Author: erikj Date: 2013-10-14 11:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/6274d4cd22d3 8025921: Make LOG=debug output more readable Reviewed-by: tbell, ihse ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeBase.gmk Changeset: 547316ea137d Author: katleman Date: 2013-10-16 11:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/547316ea137d Merge ! common/autoconf/generated-configure.sh ! common/makefiles/javadoc/CORE_PKGS.gmk ! common/makefiles/javadoc/Javadoc.gmk Changeset: ac748011cbbf Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ac748011cbbf Added tag jdk8-b112 for changeset 547316ea137d ! .hgtags Changeset: 4d23143c676a Author: lana Date: 2013-10-10 08:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/4d23143c676a Merge Changeset: fd3b32cc4b6e Author: lana Date: 2013-10-10 21:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/fd3b32cc4b6e Merge Changeset: 3f9873789d44 Author: mduigou Date: 2013-10-11 15:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/3f9873789d44 8025796: hgforest.sh could trigger unbuffered output from hg without complicated machinations Reviewed-by: mduigou Contributed-by: Dmitry Samersoff ! common/bin/hgforest.sh Changeset: d35943431696 Author: lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/d35943431696 Merge Changeset: af87dabb4263 Author: msheppar Date: 2013-06-14 15:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/af87dabb4263 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu ! common/makefiles/RMICompilation.gmk Changeset: ce8c63017f11 Author: chegar Date: 2013-10-13 21:37 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ce8c63017f11 Merge Changeset: 28be3d174c92 Author: chegar Date: 2013-10-15 13:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/28be3d174c92 Merge Changeset: af81988013b5 Author: erikj Date: 2013-10-16 13:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/af81988013b5 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Reviewed-by: dholmes, chegar ! common/makefiles/JavaCompilation.gmk ! common/makefiles/RMICompilation.gmk Changeset: 9ec6626d43bb Author: mduigou Date: 2013-10-17 14:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/9ec6626d43bb 8026062: webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug", -l and wxfile support Reviewed-by: weijun, dsamersoff, darcy, jrose, tbell ! make/scripts/webrev.ksh Changeset: 77473affb9c0 Author: lana Date: 2013-10-17 13:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/77473affb9c0 Merge ! common/makefiles/JavaCompilation.gmk ! common/makefiles/RMICompilation.gmk Changeset: 35c14ec3e12f Author: lana Date: 2013-10-17 15:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/35c14ec3e12f Merge Changeset: ac09e62d5e6b Author: amurillo Date: 2013-10-19 08:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ac09e62d5e6b Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/makefiles/NativeCompilation.gmk Changeset: 9d5284dfc00d Author: amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/9d5284dfc00d Merge Changeset: 5b4f14990dd1 Author: ihse Date: 2013-10-18 10:41 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/5b4f14990dd1 8001912: Improve detection of msvcr100.dll Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 ! common/autoconf/toolchain_windows.m4 Changeset: 65c1752b4c38 Author: katleman Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/65c1752b4c38 Merge Changeset: 17d195bd56fc Author: erikj Date: 2013-10-18 11:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/17d195bd56fc 8025869: make docs doesn't regenerate docs correctly after changing API doc comments in jaxp sources Reviewed-by: ihse, tbell ! common/makefiles/JavaCompilation.gmk Changeset: e27dda53d4f5 Author: erikj Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e27dda53d4f5 Merge Changeset: 1a853fac18ff Author: erikj Date: 2013-10-21 11:59 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1a853fac18ff 8026528: [build] configure does not recognize newer make in cygwin Reviewed-by: tbell, ksrini, ihse ! NewMakefile.gmk ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: dffe654ab24c Author: ihse Date: 2013-10-22 11:12 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/dffe654ab24c 8001925: Add useful help messages if freetype is not found on Windows Reviewed-by: erikj, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 Changeset: 56db38956113 Author: ihse Date: 2013-10-22 12:29 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/56db38956113 8026864: Deprecate --disable-macosx-runtime-support. Reviewed-by: erikj ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: 9e177e7fc438 Author: katleman Date: 2013-10-22 14:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/9e177e7fc438 Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/makefiles/JavaCompilation.gmk Changeset: 4293401d683b Author: katleman Date: 2013-10-22 16:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/4293401d683b 8027068: Update to NewMakefile.gmk check of MAKE_VERSION broke jdk8-build nightly builds on windows, saying 3.82.90 is too low Reviewed-by: ihse, tbell, wetmore ! NewMakefile.gmk Changeset: 269497597620 Author: tbell Date: 2013-10-22 16:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/269497597620 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 2cc1a52d37ef Author: tbell Date: 2013-10-22 16:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/2cc1a52d37ef Merge Changeset: 6f19b2440412 Author: ihse Date: 2013-10-23 13:05 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/6f19b2440412 8001922: Improve freetype handling. Reviewed-by: erikj ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/libraries.m4 ! common/autoconf/spec.gmk.in Changeset: 6ba4c7cb623e Author: erikj Date: 2013-10-23 17:03 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/6ba4c7cb623e 8026888: Licensee build failure due to wrong libs being called Reviewed-by: tbell, ihse, simonis ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: a36df87b3901 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/a36df87b3901 Added tag jdk8-b113 for changeset 6ba4c7cb623e ! .hgtags Changeset: b098ee22aa97 Author: erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b098ee22aa97 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! common/makefiles/JavaCompilation.gmk Changeset: 3c48e11c3901 Author: dholmes Date: 2013-10-24 20:45 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/3c48e11c3901 8016096: [macosx] jawt_md.h shipped with jdk is outdated Summary: Revised build system and added platform specific headers for Mac OS X Reviewed-by: ihse, erikj Contributed-by: david.dehaven at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: 72ef61df77e5 Author: ihse Date: 2013-10-25 13:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/72ef61df77e5 8027300: configure should use LIBS instead of LDFLAGS when testing freetype Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: dfbc93f26f38 Author: dcubed Date: 2013-10-25 10:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/dfbc93f26f38 8027117: adapt JDK-7165611 to new build-infra whitespace/indent policy Summary: Fix whitespace/indent issues. Reviewed-by: hseigel, coleenp, erikj, ihse ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/makefiles/NativeCompilation.gmk Changeset: 4f2011496393 Author: katleman Date: 2013-10-28 16:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/4f2011496393 Merge Changeset: b65d48f6938a Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b65d48f6938a Added tag jdk8-b114 for changeset 4f2011496393 ! .hgtags From john.coomes at oracle.com Fri Nov 1 20:04:08 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 02 Nov 2013 03:04:08 +0000 Subject: hg: hsx/hotspot-rt/jaxp: 38 new changesets Message-ID: <20131102030537.C920E62926@hg.openjdk.java.net> Changeset: 84a2b2ee6fc6 Author: aefimov Date: 2013-10-01 17:14 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/84a2b2ee6fc6 8024707: TransformerException : item() return null with node list of length != 1 Reviewed-by: joehw, lancea ! src/com/sun/org/apache/xml/internal/dtm/ref/DTMAxisIterNodeList.java Changeset: f031b2fe21cd Author: dfuchs Date: 2013-10-04 19:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/f031b2fe21cd 8025745: Clarify API documentation of JAXP factories. Summary: Clarifies usage of ServiceLoader in JAXP factories. Reviewed-by: alanb, joehw, psandoz ! src/javax/xml/datatype/DatatypeFactory.java ! src/javax/xml/parsers/DocumentBuilderFactory.java ! src/javax/xml/parsers/SAXParserFactory.java ! src/javax/xml/stream/XMLEventFactory.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/stream/XMLOutputFactory.java ! src/javax/xml/transform/TransformerFactory.java ! src/javax/xml/validation/SchemaFactory.java ! src/javax/xml/xpath/XPathFactory.java Changeset: dbecbb685503 Author: mfang Date: 2013-10-08 09:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/dbecbb685503 8025215: jdk8 l10n resource file translation update 4 Reviewed-by: joehw, yhuang ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sv.java ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_de.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_es.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_fr.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_it.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_ja.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_ko.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_pt_BR.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_sv.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_CN.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_TW.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_de.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_es.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_fr.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_it.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ja.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ko.java + src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_pt_BR.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_sv.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_CN.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_TW.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_es.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ja.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_pt_BR.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_sv.java Changeset: 1c074a0c2b97 Author: mfang Date: 2013-10-08 09:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/1c074a0c2b97 Merge Changeset: d69f4ac43d64 Author: lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/d69f4ac43d64 Merge Changeset: cdc3577cba0b Author: lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/cdc3577cba0b Merge Changeset: acae2e8a46df Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/acae2e8a46df 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJaxp.gmk ! makefiles/Makefile Changeset: c1f9158fbb9c Author: katleman Date: 2013-10-16 11:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/c1f9158fbb9c Merge Changeset: e85dd07c0eea Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/e85dd07c0eea Added tag jdk8-b112 for changeset c1f9158fbb9c ! .hgtags Changeset: b76629725522 Author: joehw Date: 2013-10-10 17:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/b76629725522 8003262: reverse translation required changes in xalan resource bundles Reviewed-by: lancea, dfuchs ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_TW.java Changeset: 2107c9baa457 Author: lana Date: 2013-10-10 10:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/2107c9baa457 Merge Changeset: cff4e3bf530a Author: lana Date: 2013-10-10 20:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/cff4e3bf530a Merge Changeset: 46ccc5fbc523 Author: lana Date: 2013-10-10 21:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/46ccc5fbc523 Merge Changeset: de8c803d4958 Author: aefimov Date: 2013-10-13 13:50 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/de8c803d4958 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc Reviewed-by: alanb, shade ! src/com/sun/org/apache/xpath/internal/XPathContext.java Changeset: 4712979714d1 Author: lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/4712979714d1 Merge Changeset: 91ae0f2045bc Author: lana Date: 2013-10-14 09:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/91ae0f2045bc Merge Changeset: eb169222d3f2 Author: joehw Date: 2013-10-14 22:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/eb169222d3f2 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Reviewed-by: lancea, alanb ! src/com/sun/org/apache/xerces/internal/impl/xpath/XPath.java Changeset: ecb66dc473c1 Author: joehw Date: 2013-07-16 14:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/ecb66dc473c1 8012425: Transform TransformerFactory Reviewed-by: alanb, dfuchs, mullan ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/parsers/AbstractSAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: 7a2014318343 Author: joehw Date: 2013-07-17 09:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/7a2014318343 8017298: Better XML support Reviewed-by: alanb, dfuchs, mullan, lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLScanner.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/models/CMNodeFactory.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/AbstractSAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/SecurityConfiguration.java - src/com/sun/org/apache/xerces/internal/util/SecurityManager.java ! src/com/sun/org/apache/xerces/internal/util/SymbolTable.java + src/com/sun/org/apache/xerces/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/xml/internal/stream/Entity.java Changeset: a59549c3ad60 Author: dfuchs Date: 2013-07-17 18:46 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/a59549c3ad60 8013502: Improve stream factories Reviewed-by: joehw, mullan, lancea ! src/javax/xml/stream/FactoryFinder.java Changeset: 4b0b2b5c4cc8 Author: chegar Date: 2013-07-22 14:02 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/4b0b2b5c4cc8 Merge Changeset: 40b8abe19642 Author: chegar Date: 2013-07-29 14:07 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/40b8abe19642 Merge ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: 720db2e27962 Author: joehw Date: 2013-07-31 00:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/720db2e27962 8014530: Better digital signature processing Reviewed-by: alanb, dfuchs, mullan, lancea ! src/com/sun/org/apache/xalan/internal/XalanConstants.java + src/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xalan/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLScanner.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/models/CMNodeFactory.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StAXValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/SecurityConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java + src/com/sun/org/apache/xerces/internal/utils/XMLLimitAnalyzer.java ! src/com/sun/org/apache/xerces/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xerces/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: cd9347628c7c Author: joehw Date: 2013-07-31 10:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/cd9347628c7c 8021366: java_util/Properties/PropertiesWithOtherEncodings fails during 7u45 nightly testing Reviewed-by: lancea, alanb, dfuchs, mullan ! src/com/sun/xml/internal/stream/Entity.java Changeset: ecbddaa85462 Author: chegar Date: 2013-08-02 11:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/ecbddaa85462 Merge Changeset: c5e80c1fa32f Author: chegar Date: 2013-08-09 14:31 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/c5e80c1fa32f Merge ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java Changeset: f952c33ebfdb Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/f952c33ebfdb Merge Changeset: ce16a5aa1507 Author: joehw Date: 2013-08-20 09:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/ce16a5aa1507 8022682: Supporting XOM Reviewed-by: alanb, chegar, lancea ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/parsers/DOMParser.java ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/parsers/XMLParser.java + src/com/sun/org/apache/xerces/internal/util/SecurityManager.java ! src/com/sun/org/apache/xerces/internal/utils/XMLLimitAnalyzer.java ! src/com/sun/org/apache/xerces/internal/utils/XMLSecurityManager.java Changeset: cc3b64366048 Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/cc3b64366048 Merge Changeset: 2b77e12ff69d Author: chegar Date: 2013-10-11 19:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/2b77e12ff69d Merge ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/util/SecurityManager.java Changeset: 6f220761f643 Author: chegar Date: 2013-10-15 14:16 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6f220761f643 Merge Changeset: 0c3f951630fe Author: joehw Date: 2013-10-17 11:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/0c3f951630fe 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/util/URI.java Changeset: 951c1f7fdb10 Author: joehw Date: 2013-10-17 16:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/951c1f7fdb10 8016500: Unlocalized warnigs. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/jaxp/DefaultValidationErrorHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java Changeset: 31c82bc71ae3 Author: lana Date: 2013-10-17 15:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/31c82bc71ae3 Merge Changeset: 2f1e1e2c2242 Author: lana Date: 2013-10-17 17:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/2f1e1e2c2242 Merge Changeset: 0046d2278204 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/0046d2278204 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 1b1e12117fe2 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/1b1e12117fe2 Added tag jdk8-b113 for changeset 0046d2278204 ! .hgtags Changeset: d3b6da1b3e25 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/d3b6da1b3e25 Added tag jdk8-b114 for changeset 1b1e12117fe2 ! .hgtags From john.coomes at oracle.com Fri Nov 1 20:05:50 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 02 Nov 2013 03:05:50 +0000 Subject: hg: hsx/hotspot-rt/jaxws: 27 new changesets Message-ID: <20131102030651.D98A762927@hg.openjdk.java.net> Changeset: b0610cd08440 Author: mkos Date: 2013-10-04 16:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/b0610cd08440 8025054: Update JAX-WS RI integration to 2.2.9-b130926.1035 Reviewed-by: chegar ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/ExternalMetadataFeature.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/WscompileMessages.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile.properties ! src/share/jaxws_classes/com/sun/tools/internal/ws/version.properties ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/Options.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsgenTool.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportOptions.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportTool.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/DOMForest.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/SchemaCache.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/DOMForest.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/AbstractExtendedComplexTypeBuilder.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/SchemaConstraintChecker.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.properties ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/SingleMapNodeProperty.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/AccessorInjector.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/Injector.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/OptimizedAccessorFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/util/XmlFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/Base64Data.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/Base64Encoder.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/Base64EncoderStream.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/ByteArrayOutputStreamEx.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/NamespaceContextEx.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/StreamingDataHandler.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/XMLStreamWriterEx.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/binary/SchemaBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DDataPattern.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DPattern.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DXMLPrinter.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DataPatternBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/GrammarBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/nc/AnyNameClass.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/nc/NameClassBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/nc/SimpleNameClass.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/parse/compact/UCode_UCodeESC_CharStream.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/parse/xml/SchemaParser.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/xml/sax/JAXPXMLReaderCreator.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaTubeHelper.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLBoundOperation.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLBoundPortType.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLExtensible.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLFault.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLModel.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLOperation.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLOutput.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPort.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPortType.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLService.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLBoundFault.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLBoundOperation.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLBoundPortType.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLFault.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLInput.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLMessage.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLModel.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLOperation.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLOutput.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLPart.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLPort.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLPortType.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLService.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/WSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/WSDLParserExtensionContext.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/binding/WebServiceFeatureList.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/MonitorRootClient.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/PortInfo.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/Stub.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/WSServiceDelegate.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/ExternalMetadataReader.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/JavaMethodImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/AbstractExtensibleImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundFaultImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundOperationImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundPortTypeImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLFaultImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLInputImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLMessageImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLModelImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLOperationImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLOutputImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPartImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPortImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPortTypeImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLProperties.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLServiceImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/PolicyWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/WsservletMessages.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/server/EndpointFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/server/WSEndpointImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/ProviderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/HttpAdapter.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/client/HttpTransportPipe.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/pipe/AbstractSchemaValidationTube.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/version.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XmlUtil.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/ActionBasedOperationFinder.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/PayloadQNameBasedOperationFinder.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/DelegatingParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/FoolProofParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/MemberSubmissionAddressingWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/RuntimeWSDLParser.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/W3CAddressingMetadataWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/W3CAddressingWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/WSDLParserExtensionContextImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/WSDLParserExtensionFacade.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/WSDLGenerator.java ! src/share/jaxws_classes/javax/annotation/PostConstruct.java ! src/share/jaxws_classes/javax/annotation/PreDestroy.java ! src/share/jaxws_classes/javax/xml/bind/JAXBException.java ! src/share/jaxws_classes/javax/xml/bind/Marshaller.java ! src/share/jaxws_classes/javax/xml/bind/TypeConstraintException.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/package.html ! src/share/jaxws_classes/javax/xml/soap/MessageFactory.java Changeset: e56be3a2287a Author: coffeys Date: 2013-10-05 08:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/e56be3a2287a 8016271: wsimport -clientjar does not create portable jars on Windows due to hardcoded backslash Reviewed-by: mkos, chegar ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportTool.java Changeset: 1d6c13d3b8de Author: lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/1d6c13d3b8de Merge Changeset: 7c0a7937f6ef Author: lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/7c0a7937f6ef Merge Changeset: 602fdd7bb765 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/602fdd7bb765 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJaxws.gmk ! makefiles/Makefile Changeset: dbdd5c762509 Author: katleman Date: 2013-10-16 11:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/dbdd5c762509 Merge Changeset: 9ca9735d9966 Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/9ca9735d9966 Added tag jdk8-b112 for changeset dbdd5c762509 ! .hgtags Changeset: da77e343f458 Author: lana Date: 2013-10-10 10:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/da77e343f458 Merge Changeset: 66a12ce67d3a Author: lana Date: 2013-10-10 21:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/66a12ce67d3a Merge Changeset: 328b8b96773b Author: lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/328b8b96773b Merge Changeset: 43240b8b995b Author: mkos Date: 2013-08-01 16:09 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/43240b8b995b 8017505: Better Client Service Reviewed-by: mullan, ahgross, mgrebac ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/AbstractInstanceResolver.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/InstanceResolver.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/MethodUtil.java + src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/MethodUtil.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/SEIStub.java + src/share/jaxws_classes/com/sun/xml/internal/ws/policy/privateutil/MethodUtil.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/privateutil/PolicyUtils.java Changeset: 358f32260d1f Author: chegar Date: 2013-08-02 11:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/358f32260d1f Merge Changeset: 5212665bea32 Author: chegar Date: 2013-08-09 14:31 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/5212665bea32 Merge Changeset: d9704ab517d5 Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/d9704ab517d5 Merge Changeset: fca8869ccfd0 Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/fca8869ccfd0 Merge Changeset: a6e2adde013e Author: chegar Date: 2013-08-30 10:15 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/a6e2adde013e Merge Changeset: f6376ba97cea Author: chegar Date: 2013-09-06 09:55 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/f6376ba97cea Merge Changeset: d3a65e8912c9 Author: chegar Date: 2013-09-14 20:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/d3a65e8912c9 Merge Changeset: da8141b6e344 Author: chegar Date: 2013-10-03 19:18 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/da8141b6e344 Merge Changeset: 2dc8ae7eb53b Author: chegar Date: 2013-10-11 19:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/2dc8ae7eb53b Merge Changeset: 01facfebe17b Author: chegar Date: 2013-10-15 13:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/01facfebe17b Merge Changeset: be7d1f874b96 Author: lana Date: 2013-10-17 16:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/be7d1f874b96 Merge Changeset: 17f1b13cd401 Author: simonis Date: 2013-10-21 15:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/17f1b13cd401 8026874: During JAXWS build the newly built JAXP classes should be in the bootclasspath (not only in the classpath) Reviewed-by: erikj ! makefiles/BuildJaxws.gmk Changeset: f20820d1582f Author: katleman Date: 2013-10-22 16:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/f20820d1582f Merge Changeset: 9261f342aa73 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/9261f342aa73 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 9ad289610fc6 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/9ad289610fc6 Added tag jdk8-b113 for changeset 9261f342aa73 ! .hgtags Changeset: e126d8eca69b Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/e126d8eca69b Added tag jdk8-b114 for changeset 9ad289610fc6 ! .hgtags From john.coomes at oracle.com Fri Nov 1 21:39:02 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 02 Nov 2013 04:39:02 +0000 Subject: hg: hsx/hotspot-rt/langtools: 76 new changesets Message-ID: <20131102044252.B9BAF6292C@hg.openjdk.java.net> Changeset: 16194509e483 Author: vromero Date: 2013-09-27 10:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/16194509e483 8024497: crash returning this-referencing lambda from default method Reviewed-by: jjg, rfield ! src/share/classes/com/sun/tools/javac/code/Symbol.java + test/tools/javac/lambda/8024497/CrashUsingReturningThisRefLambdaFromDefaultMetTest.java Changeset: b7d8b71e1658 Author: jlahoda Date: 2013-09-27 17:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b7d8b71e1658 8022765: Compiler crashes with exception on wrong usage of an annotation. Summary: Error recovery for incorrect annotation attribute values - ensure the values are always attributed appropriately Reviewed-by: jfranck, jjg ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/annotations/neg/8022765/T8022765.java + test/tools/javac/annotations/neg/8022765/T8022765.out + test/tools/javac/annotations/neg/8022765/VerifyAnnotationsAttributed.java Changeset: 2c24a04ebfb4 Author: kizune Date: 2013-09-27 21:20 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2c24a04ebfb4 6978886: javadoc shows stacktrace after print error resulting from disk full Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java Changeset: 699b86e82656 Author: sogoel Date: 2013-09-27 10:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/699b86e82656 8025537: Convert 2 javac/enumdeclarations tests in jtreg for regression ws Reviewed-by: jjg + test/tools/javac/enum/EnumAsIdentifier.java + test/tools/javac/enum/EnumAsIdentifier.out + test/tools/javac/enum/EnumAsIdentifier4.out + test/tools/javac/enum/EnumAsIdentifier5.out + test/tools/javac/enum/EnumMembersOrder.java + test/tools/javac/enum/EnumMembersOrder.out Changeset: 4ed8565fa536 Author: mduigou Date: 2013-09-27 11:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4ed8565fa536 8024842: Define ABS_TEST_OUTPUT_DIR via TEST_OUTPUT_DIR Reviewed-by: ihse, erikj, vromero ! test/Makefile Changeset: dee28dd47e12 Author: rfield Date: 2013-09-27 13:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/dee28dd47e12 8025548: langtools test tools/javac/lambda/methodReference/BridgeMethod.java incorrectly assumes no other methods generated in lambda class Reviewed-by: vromero ! test/tools/javac/lambda/methodReference/BridgeMethod.java Changeset: 82044fe8c7f7 Author: ksrini Date: 2013-09-27 16:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/82044fe8c7f7 8015073: c.s.t.javac.api.JavacTool.getTask() - more informative exception Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! test/tools/javac/api/TestJavacTask.java Changeset: 34223fc58c1a Author: lana Date: 2013-09-27 18:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/34223fc58c1a Merge Changeset: 84161510f257 Author: emc Date: 2013-09-28 13:46 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/84161510f257 8025413: NPE in Type.java due to recent change Summary: isCompound throws a NPE for noType and other types. Made it return a reasonable result instead. Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java + test/tools/javac/processing/model/type/InheritedAP.java Changeset: 1a3e8347f3dd Author: kizune Date: 2013-10-01 17:03 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1a3e8347f3dd 7118749: NPE in CreateSymbols caused by bad diagnostic Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java Changeset: de1c5dbe6c28 Author: emc Date: 2013-10-01 17:41 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/de1c5dbe6c28 8021339: Compile-time error during casting array to intersection Summary: Add ability to have arrays in intersection types. Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/ArraysInIntersections.java + test/tools/javac/InferArraysInIntersections.java ! test/tools/javac/generics/typevars/6680106/T6680106.out Changeset: 1e6088da1740 Author: vromero Date: 2013-10-02 17:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1e6088da1740 8023679: Improve error message for '_' used as a lambda parameter name Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/UnderscoreInLambdaExpression.java Changeset: c13305cf8528 Author: jlahoda Date: 2013-10-04 08:29 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c13305cf8528 8025118: Annotation processing api returns default modifier for interface without default methods Summary: TypeElement.getModifiers() should not contain Modifier.DEFAULT Reviewed-by: darcy, jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java + test/tools/javac/processing/model/element/TestTypeElement.java Changeset: c0d44b1e6b6a Author: kizune Date: 2013-10-04 19:38 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c0d44b1e6b6a 7096170: should remove unused support for enabling javac logging Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: 379c04c090cf Author: darcy Date: 2013-10-04 10:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/379c04c090cf 8025913: Rename jdk.Supported to jdk.Exported Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg ! src/share/classes/com/sun/source/doctree/AttributeTree.java ! src/share/classes/com/sun/source/doctree/AuthorTree.java ! src/share/classes/com/sun/source/doctree/BlockTagTree.java ! src/share/classes/com/sun/source/doctree/CommentTree.java ! src/share/classes/com/sun/source/doctree/DeprecatedTree.java ! src/share/classes/com/sun/source/doctree/DocCommentTree.java ! src/share/classes/com/sun/source/doctree/DocRootTree.java ! src/share/classes/com/sun/source/doctree/DocTree.java ! src/share/classes/com/sun/source/doctree/DocTreeVisitor.java ! src/share/classes/com/sun/source/doctree/EndElementTree.java ! src/share/classes/com/sun/source/doctree/EntityTree.java ! src/share/classes/com/sun/source/doctree/ErroneousTree.java ! src/share/classes/com/sun/source/doctree/IdentifierTree.java ! src/share/classes/com/sun/source/doctree/InheritDocTree.java ! src/share/classes/com/sun/source/doctree/InlineTagTree.java ! src/share/classes/com/sun/source/doctree/LinkTree.java ! src/share/classes/com/sun/source/doctree/LiteralTree.java ! src/share/classes/com/sun/source/doctree/ParamTree.java ! src/share/classes/com/sun/source/doctree/ReferenceTree.java ! src/share/classes/com/sun/source/doctree/ReturnTree.java ! src/share/classes/com/sun/source/doctree/SeeTree.java ! src/share/classes/com/sun/source/doctree/SerialDataTree.java ! src/share/classes/com/sun/source/doctree/SerialFieldTree.java ! src/share/classes/com/sun/source/doctree/SerialTree.java ! src/share/classes/com/sun/source/doctree/SinceTree.java ! src/share/classes/com/sun/source/doctree/StartElementTree.java ! src/share/classes/com/sun/source/doctree/TextTree.java ! src/share/classes/com/sun/source/doctree/ThrowsTree.java ! src/share/classes/com/sun/source/doctree/UnknownBlockTagTree.java ! src/share/classes/com/sun/source/doctree/UnknownInlineTagTree.java ! src/share/classes/com/sun/source/doctree/ValueTree.java ! src/share/classes/com/sun/source/doctree/VersionTree.java ! src/share/classes/com/sun/source/doctree/package-info.java ! src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/AnnotationTree.java ! src/share/classes/com/sun/source/tree/ArrayAccessTree.java ! src/share/classes/com/sun/source/tree/ArrayTypeTree.java ! src/share/classes/com/sun/source/tree/AssertTree.java ! src/share/classes/com/sun/source/tree/AssignmentTree.java ! src/share/classes/com/sun/source/tree/BinaryTree.java ! src/share/classes/com/sun/source/tree/BlockTree.java ! src/share/classes/com/sun/source/tree/BreakTree.java ! src/share/classes/com/sun/source/tree/CaseTree.java ! src/share/classes/com/sun/source/tree/CatchTree.java ! src/share/classes/com/sun/source/tree/ClassTree.java ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java ! src/share/classes/com/sun/source/tree/CompoundAssignmentTree.java ! src/share/classes/com/sun/source/tree/ConditionalExpressionTree.java ! src/share/classes/com/sun/source/tree/ContinueTree.java ! src/share/classes/com/sun/source/tree/DoWhileLoopTree.java ! src/share/classes/com/sun/source/tree/EmptyStatementTree.java ! src/share/classes/com/sun/source/tree/EnhancedForLoopTree.java ! src/share/classes/com/sun/source/tree/ErroneousTree.java ! src/share/classes/com/sun/source/tree/ExpressionStatementTree.java ! src/share/classes/com/sun/source/tree/ExpressionTree.java ! src/share/classes/com/sun/source/tree/ForLoopTree.java ! src/share/classes/com/sun/source/tree/IdentifierTree.java ! src/share/classes/com/sun/source/tree/IfTree.java ! src/share/classes/com/sun/source/tree/ImportTree.java ! src/share/classes/com/sun/source/tree/InstanceOfTree.java ! src/share/classes/com/sun/source/tree/IntersectionTypeTree.java ! src/share/classes/com/sun/source/tree/LabeledStatementTree.java ! src/share/classes/com/sun/source/tree/LambdaExpressionTree.java ! src/share/classes/com/sun/source/tree/LineMap.java ! src/share/classes/com/sun/source/tree/LiteralTree.java ! src/share/classes/com/sun/source/tree/MemberReferenceTree.java ! src/share/classes/com/sun/source/tree/MemberSelectTree.java ! src/share/classes/com/sun/source/tree/MethodInvocationTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/ModifiersTree.java ! src/share/classes/com/sun/source/tree/NewArrayTree.java ! src/share/classes/com/sun/source/tree/NewClassTree.java ! src/share/classes/com/sun/source/tree/ParameterizedTypeTree.java ! src/share/classes/com/sun/source/tree/ParenthesizedTree.java ! src/share/classes/com/sun/source/tree/PrimitiveTypeTree.java ! src/share/classes/com/sun/source/tree/ReturnTree.java ! src/share/classes/com/sun/source/tree/Scope.java ! src/share/classes/com/sun/source/tree/StatementTree.java ! src/share/classes/com/sun/source/tree/SwitchTree.java ! src/share/classes/com/sun/source/tree/SynchronizedTree.java ! src/share/classes/com/sun/source/tree/ThrowTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TryTree.java ! src/share/classes/com/sun/source/tree/TypeCastTree.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/tree/UnaryTree.java ! src/share/classes/com/sun/source/tree/UnionTypeTree.java ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/source/tree/WhileLoopTree.java ! src/share/classes/com/sun/source/tree/WildcardTree.java ! src/share/classes/com/sun/source/tree/package-info.java ! src/share/classes/com/sun/source/util/DocSourcePositions.java ! src/share/classes/com/sun/source/util/DocTreePath.java ! src/share/classes/com/sun/source/util/DocTreePathScanner.java ! src/share/classes/com/sun/source/util/DocTreeScanner.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/source/util/SimpleDocTreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/SourcePositions.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TaskListener.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/source/util/TreePathScanner.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/source/util/package-info.java ! src/share/classes/com/sun/tools/javac/Main.java + src/share/classes/jdk/Exported.java - src/share/classes/jdk/Supported.java Changeset: 6e186ca11ec0 Author: bpatel Date: 2013-10-04 13:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6e186ca11ec0 8008164: Invisible table captions in javadoc-generated html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + test/com/sun/javadoc/testHtmlTableStyles/TestHtmlTableStyles.java + test/com/sun/javadoc/testHtmlTableStyles/pkg1/TestTable.java + test/com/sun/javadoc/testHtmlTableStyles/pkg2/TestUse.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java Changeset: 3344ea7404b1 Author: bpatel Date: 2013-10-04 13:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3344ea7404b1 8024756: method grouping tabs are not selectable Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! test/com/sun/javadoc/JavascriptWinTitle/JavascriptWinTitle.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java Changeset: 2fa6ced325cc Author: jjg Date: 2013-10-04 13:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2fa6ced325cc 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/errors/TestBadProcessor.java Changeset: 515d54c1b063 Author: jjg Date: 2013-10-04 14:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/515d54c1b063 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/javax/tools/Diagnostic.java Changeset: 3e3c321710be Author: jjg Date: 2013-10-04 15:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3e3c321710be 8025970: Spurious characters in JavaCompiler Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: bb87db832b31 Author: ksrini Date: 2013-10-04 16:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bb87db832b31 8003537: javap use internal class name when printing bound of type variable Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/ClassWriter.java + test/tools/javap/BoundsTypeVariableTest.java Changeset: 15651a673358 Author: ksrini Date: 2013-10-04 16:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/15651a673358 8005542: jtreg test OverrideBridge.java contains @ignore Reviewed-by: jjg Contributed-by: steve.sides at oracle.com - test/tools/javac/generics/OverrideBridge.java Changeset: 4dd7ffbf01fb Author: darcy Date: 2013-10-07 16:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4dd7ffbf01fb 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element.java Changeset: 4dfcf3a6902f Author: lana Date: 2013-10-08 14:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4dfcf3a6902f Merge - src/share/classes/jdk/Supported.java - test/tools/javac/generics/OverrideBridge.java Changeset: 2f43529df42f Author: lana Date: 2013-10-11 03:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2f43529df42f Merge - src/share/classes/jdk/Supported.java - test/tools/javac/generics/OverrideBridge.java Changeset: 343aeb2033f0 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/343aeb2033f0 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildLangtools.gmk ! makefiles/Makefile Changeset: 954dd199d6ff Author: katleman Date: 2013-10-16 12:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/954dd199d6ff Merge Changeset: 8f54b4231c28 Author: cl Date: 2013-10-17 09:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8f54b4231c28 Added tag jdk8-b112 for changeset 954dd199d6ff ! .hgtags Changeset: ea000904db62 Author: alundblad Date: 2013-10-08 15:33 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ea000904db62 8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees Summary: Fixed precedence and associativity issues with pretty printing of JCConditional expressions. Reviewed-by: jfranck Contributed-by: Andreas Lundblad , Matthew Dempsky ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/T8024415.java Changeset: 0be3f1820e8b Author: jlahoda Date: 2013-10-09 13:06 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/0be3f1820e8b 8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...) Summary: Should not generate non-public $assertionsDisabled field into interfaces Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/defaultMethods/Assertions.java + test/tools/javac/defaultMethods/CannotChangeAssertionsStateAfterInitialized.java Changeset: 1b469fd31e35 Author: jlahoda Date: 2013-10-09 13:09 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1b469fd31e35 8025087: Annotation processing api returns default modifier for interface static method Summary: ClassReader must not set Flags.DEFAULT for interface static methods Reviewed-by: vromero, jjg ! make/build.xml ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/defaultMethods/BadClassfile.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/InvalidDefaultInterface/InvalidDefaultInterface.java + test/tools/javac/diags/examples/InvalidDefaultInterface/processors/CreateBadClassFile.java + test/tools/javac/diags/examples/InvalidStaticInterface/InvalidStaticInterface.java + test/tools/javac/diags/examples/InvalidStaticInterface/processors/CreateBadClassFile.java ! test/tools/javac/processing/model/element/TestExecutableElement.java Changeset: 1e7ad879f15e Author: alundblad Date: 2013-10-10 08:51 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1e7ad879f15e 8021237: clean up JavacAnnotatedConstruct Summary: Refactored the static helper methods in JavacAnnoConstructs into ordinary methods and put them in a common superclass (AnnoConstruct) of Symbol and Type. Reviewed-by: jjg, vromero, jfranck + src/share/classes/com/sun/tools/javac/code/AnnoConstruct.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java - src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java Changeset: 933ba3f81a87 Author: bpatel Date: 2013-10-10 10:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/933ba3f81a87 8025633: Fix javadoc to generate valid anchor names Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/SectionName.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java + test/com/sun/javadoc/testAnchorNames/TestAnchorNames.java + test/com/sun/javadoc/testAnchorNames/pkg1/DeprMemClass.java + test/com/sun/javadoc/testAnchorNames/pkg1/RegClass.java ! test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java ! test/com/sun/javadoc/testAnnotationTypes/TestAnnotationTypes.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java ! test/com/sun/javadoc/testNestedGenerics/TestNestedGenerics.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java Changeset: 6dcf94e32a3a Author: emc Date: 2013-10-10 13:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6dcf94e32a3a 8019461: Clean up javac diagnostics 7196553: Review error messages for repeating annotations Summary: Changes to the diagnostic messages to improve clarity and JLS coherence Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/diags/examples/DuplicateAnnotation.java + test/tools/javac/diags/examples/InterfaceOrArrayExpected.java + test/tools/javac/diags/examples/RepeatableAnnotationsNotSupported.java Changeset: b1b4a6dcc282 Author: emc Date: 2013-10-10 20:12 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b1b4a6dcc282 8008762: Type annotation on inner class in anonymous class show up as regular type annotations 8015257: type annotation with TYPE_USE and FIELD attributed differently if repeated. 8013409: test failures for type annotations Summary: Fixes to address some problems in type annotations Reviewed-by: jfranck, jjg ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/annotations/typeAnnotations/classfile/TestAnonInnerClasses.java + test/tools/javac/annotations/typeAnnotations/classfile/testanoninner.template ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java Changeset: f068d235c4f7 Author: jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy ! test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Changeset: 8f293c710369 Author: lana Date: 2013-10-10 13:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8f293c710369 Merge Changeset: bf33f4f81b40 Author: lana Date: 2013-10-10 20:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bf33f4f81b40 Merge - test/tools/javac/diags/examples/DuplicateAnnotation.java Changeset: 1ce8405af5fe Author: rfield Date: 2013-10-10 23:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1ce8405af5fe 8012557: Implement lambda methods on interfaces as private 8016320: Method reference in subinterface of type I.super::foo produces exception at runtime Summary: Now that the VM supports interface instance private methods, lambda methods and lambda bridges are always private. Access is now through invokespecial. Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java + test/tools/javac/lambda/8012557/A.java + test/tools/javac/lambda/8012557/B.java + test/tools/javac/lambda/8012557/C.java + test/tools/javac/lambda/8012557/PrivateLambdas.java + test/tools/javac/lambda/8012557/SAM.java + test/tools/javac/lambda/8016320/IllegalBridgeModifier.java Changeset: 872c4a898b38 Author: jlahoda Date: 2013-10-11 15:49 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/872c4a898b38 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type Reviewed-by: darcy, jfranck, jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/processing/errors/EnsureAnnotationTypeMismatchException/Processor.java + test/tools/javac/processing/errors/EnsureAnnotationTypeMismatchException/Source.java + test/tools/javac/processing/errors/EnsureAnnotationTypeMismatchException/Source.out Changeset: f329c374da4b Author: lana Date: 2013-10-11 23:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f329c374da4b Merge Changeset: b024fe427d24 Author: jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out Changeset: 87b5bfef7edb Author: jlahoda Date: 2013-10-14 22:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/87b5bfef7edb 8014016: javac is too late detecting invalid annotation usage Summary: Adding new queue to Annotate for validation tasks, performing annotation validation during enter Reviewed-by: jjg, emc, jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/GenerateFunctionalInterface.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/GenerateSuperInterfaceProcessor.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/Processor.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/Source.java Changeset: b9e3b55a908c Author: jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b9e3b55a908c 8026371: "tidy" issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java - src/share/classes/com/sun/javadoc/package.html + src/share/classes/com/sun/tools/classfile/package-info.java - src/share/classes/com/sun/tools/classfile/package.html + src/share/classes/com/sun/tools/doclets/formats/html/markup/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/markup/package.html + src/share/classes/com/sun/tools/doclets/formats/html/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package.html + src/share/classes/com/sun/tools/doclets/package-info.java - src/share/classes/com/sun/tools/doclets/package.html + src/share/classes/com/sun/tools/javap/package-info.java - src/share/classes/com/sun/tools/javap/package.html ! src/share/classes/javax/lang/model/overview.html ! src/share/classes/javax/tools/overview.html Changeset: 7d266a2b31b2 Author: jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java + test/tools/javadoc/8025693/Test.java Changeset: 09a414673570 Author: jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/lambda/LocalVariableTable.java Changeset: 79649bf21a92 Author: jlahoda Date: 2013-10-15 16:23 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/79649bf21a92 8026180: com.sun.source.tree.NewArrayTree refers to com.sun.tools.javac.util.List Summary: Correcting import in NewArrayTree, adding test protecting againts improper types in API signatures Reviewed-by: jjg ! src/share/classes/com/sun/source/tree/NewArrayTree.java + test/tools/javac/tree/NoPrivateTypesExported.java Changeset: bf6b11347b1a Author: bpatel Date: 2013-10-15 11:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bf6b11347b1a 8026370: javadoc creates empty Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java + test/com/sun/javadoc/testTagOutput/TestTagOutput.java + test/com/sun/javadoc/testTagOutput/pkg1/DeprecatedTag.java Changeset: 70a301b35e71 Author: vromero Date: 2013-10-15 19:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/70a301b35e71 8025816: javac crash with method reference with a type variable as the site Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/T8025816/CrashMethodReferenceWithSiteTypeVarTest.java Changeset: d8d6b58f1ebf Author: vromero Date: 2013-10-15 21:02 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d8d6b58f1ebf 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/T8024947/PotentiallyAmbiguousWarningTest.java + test/tools/javac/lambda/T8024947/PotentiallyAmbiguousWarningTest.out Changeset: 84df20dc604a Author: bpatel Date: 2013-07-24 15:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/84df20dc604a 8016675: Make Javadoc pages more robust Reviewed-by: jlaskey, ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java + test/com/sun/javadoc/testWindowTitle/TestWindowTitle.java + test/com/sun/javadoc/testWindowTitle/p1/C1.java + test/com/sun/javadoc/testWindowTitle/p2/C2.java Changeset: 8b3e2cc5f1de Author: chegar Date: 2013-07-25 19:06 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8b3e2cc5f1de Merge - test/tools/javac/generics/6723444/T6723444.out - test/tools/javac/generics/7015430/T7015430.out Changeset: 0d75d3b96477 Author: chegar Date: 2013-08-02 11:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/0d75d3b96477 Merge Changeset: 2d1a54d213c2 Author: chegar Date: 2013-08-09 14:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2d1a54d213c2 Merge Changeset: 84b6d75ff2c9 Author: chegar Date: 2013-08-15 21:34 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/84b6d75ff2c9 Merge Changeset: a540e2a926cf Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a540e2a926cf Merge Changeset: a8f0c3583a86 Author: chegar Date: 2013-08-30 10:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a8f0c3583a86 Merge - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java Changeset: 6250a7f0aba6 Author: chegar Date: 2013-09-06 10:05 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6250a7f0aba6 Merge - test/com/sun/javadoc/testNavagation/TestNavagation.java - test/com/sun/javadoc/testNavagation/pkg/A.java - test/com/sun/javadoc/testNavagation/pkg/C.java - test/com/sun/javadoc/testNavagation/pkg/E.java - test/com/sun/javadoc/testNavagation/pkg/I.java - test/tools/javac/8015701/AnonymousParameters.java Changeset: a6901af8a2e4 Author: chegar Date: 2013-09-14 20:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a6901af8a2e4 Merge Changeset: 2c13a5da6854 Author: chegar Date: 2013-10-03 19:28 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2c13a5da6854 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java - src/share/classes/com/sun/tools/javac/code/Annotations.java - test/tools/javac/diags/examples/CyclicInference.java - test/tools/javac/diags/examples/MrefStat.java.rej - test/tools/javac/diags/examples/MrefStat1.java.rej - test/tools/javac/lambda/TargetType10.out - test/tools/javac/lambda/typeInference/InferenceTest5.java - test/tools/javac/lambda/typeInference/InferenceTest_neg5.java - test/tools/javac/lambda/typeInference/InferenceTest_neg5.out Changeset: 86e57f576e65 Author: chegar Date: 2013-10-11 19:05 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/86e57f576e65 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java Changeset: 46feacb99698 Author: chegar Date: 2013-10-15 14:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/46feacb99698 Merge - src/share/classes/com/sun/javadoc/package.html - src/share/classes/com/sun/tools/classfile/package.html - src/share/classes/com/sun/tools/doclets/formats/html/markup/package.html - src/share/classes/com/sun/tools/doclets/formats/html/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package.html - src/share/classes/com/sun/tools/doclets/package.html - src/share/classes/com/sun/tools/javap/package.html Changeset: 90c9ae4bc756 Author: chegar Date: 2013-10-15 20:47 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/90c9ae4bc756 Merge Changeset: dd073728085d Author: chegar Date: 2013-10-15 21:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/dd073728085d Merge Changeset: 19e8eebfbe52 Author: jlahoda Date: 2013-10-15 22:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/19e8eebfbe52 8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing Summary: A mostly automated rename Annotate.Annotator->Annotate.Worker and enterAnnotation->run. Reviewed-by: emc, jjg ! src/share/classes/com/sun/tools/javac/code/SymbolMetadata.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: b0c086cd4520 Author: jjg Date: 2013-10-15 15:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b0c086cd4520 8026564: import changes from type-annotations forest Reviewed-by: jjg Contributed-by: wdietl at gmail.com, steve.sides at oracle.com ! make/build.properties ! make/build.xml ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/SymbolMetadata.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/T7042623.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java + test/tools/javac/annotations/typeAnnotations/classfile/Scopes.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.out ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out ! test/tools/javac/annotations/typeAnnotations/failures/BadCast.java ! test/tools/javac/annotations/typeAnnotations/failures/BadCast.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotatePackages.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotatePackages.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateScoping.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateScoping.out ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java - test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.out ! test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.java ! test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.out - test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.java - test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.out ! test/tools/javac/annotations/typeAnnotations/failures/IndexArray.java ! test/tools/javac/annotations/typeAnnotations/failures/IndexArray.out ! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out ! test/tools/javac/annotations/typeAnnotations/failures/OldArray.java + test/tools/javac/annotations/typeAnnotations/failures/OldArray.out ! test/tools/javac/annotations/typeAnnotations/failures/Scopes.java ! test/tools/javac/annotations/typeAnnotations/failures/Scopes.out ! test/tools/javac/annotations/typeAnnotations/failures/StaticFields.java ! test/tools/javac/annotations/typeAnnotations/failures/StaticFields.out - test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java - test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out ! test/tools/javac/annotations/typeAnnotations/failures/TypeVariableCycleTest.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariableMissingTA.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariableMissingTA.out - test/tools/javac/diags/examples/CantAnnotateNestedType.java + test/tools/javac/diags/examples/CantAnnotateScoping.java + test/tools/javac/diags/examples/CantAnnotateScoping1.java - test/tools/javac/diags/examples/CantAnnotateStaticClass.java ! test/tools/javac/lib/DPrinter.java ! test/tools/javac/processing/model/type/BasicAnnoTests.java Changeset: d7e155f874a7 Author: jjg Date: 2013-10-16 10:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d7e155f874a7 8026704: Build failure with --enable-debug Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java - test/tools/javac/lambda/LocalVariableTable.java Changeset: 7f6481e5fe3a Author: emc Date: 2013-10-16 16:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7f6481e5fe3a 8026286: Improper locking of annotation queues causes assertion failures. 8026063: Calls to annotate.flush() cause incorrect type annotations to be generated. Summary: Fix locking in ClassReader.java Reviewed-by: jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java + test/tools/javac/annotations/typeAnnotations/TestAnonInnerInstance1.java ! test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java Changeset: a48d3b981083 Author: mnunez Date: 2013-10-17 13:27 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a48d3b981083 8015372: Update tests for Method Parameter Reflection API to check whether a parameter is final Reviewed-by: jjg, jfranck ! test/tools/javac/MethodParameters/AnnotationTest.java + test/tools/javac/MethodParameters/AnnotationTest.out ! test/tools/javac/MethodParameters/AnonymousClass.java + test/tools/javac/MethodParameters/AnonymousClass.out ! test/tools/javac/MethodParameters/ClassFileVisitor.java ! test/tools/javac/MethodParameters/Constructors.java + test/tools/javac/MethodParameters/Constructors.out ! test/tools/javac/MethodParameters/EnumTest.java + test/tools/javac/MethodParameters/EnumTest.out ! test/tools/javac/MethodParameters/InstanceMethods.java + test/tools/javac/MethodParameters/InstanceMethods.out ! test/tools/javac/MethodParameters/LambdaTest.java + test/tools/javac/MethodParameters/LambdaTest.out ! test/tools/javac/MethodParameters/LocalClassTest.java + test/tools/javac/MethodParameters/LocalClassTest.out ! test/tools/javac/MethodParameters/MemberClassTest.java + test/tools/javac/MethodParameters/MemberClassTest.out ! test/tools/javac/MethodParameters/ReflectionVisitor.java ! test/tools/javac/MethodParameters/StaticMethods.java + test/tools/javac/MethodParameters/StaticMethods.out ! test/tools/javac/MethodParameters/Tester.java ! test/tools/javac/MethodParameters/UncommonParamNames.java + test/tools/javac/MethodParameters/UncommonParamNames.out Changeset: 4d8af6fda907 Author: mnunez Date: 2013-10-17 13:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4d8af6fda907 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest Reviewed-by: jjg, jfranck ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/ReflectionTest.java Changeset: defadd528513 Author: mchung Date: 2013-10-17 13:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/defadd528513 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb ! src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/classes/com/sun/tools/jdeps/Archive.java ! src/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/Profile.java - src/share/classes/com/sun/tools/jdeps/Profiles.java ! src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + test/tools/jdeps/APIDeps.java ! test/tools/jdeps/Basic.java ! test/tools/jdeps/Test.java + test/tools/jdeps/b/B.java + test/tools/jdeps/c/C.java + test/tools/jdeps/c/I.java + test/tools/jdeps/d/D.java + test/tools/jdeps/e/E.java + test/tools/jdeps/f/F.java + test/tools/jdeps/g/G.java + test/tools/jdeps/m/Bar.java + test/tools/jdeps/m/Foo.java + test/tools/jdeps/m/Gee.java Changeset: bca97b47f0a2 Author: lana Date: 2013-10-17 16:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/bca97b47f0a2 Merge Changeset: 127c2e74d2cf Author: tbell Date: 2013-10-22 16:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/127c2e74d2cf 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 54150586ba78 Author: katleman Date: 2013-10-23 08:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/54150586ba78 Merge Changeset: 850d2602ae98 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/850d2602ae98 Added tag jdk8-b113 for changeset 54150586ba78 ! .hgtags Changeset: fea486d30d41 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/fea486d30d41 Added tag jdk8-b114 for changeset 850d2602ae98 ! .hgtags From john.coomes at oracle.com Fri Nov 1 21:43:04 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 02 Nov 2013 04:43:04 +0000 Subject: hg: hsx/hotspot-rt/nashorn: 51 new changesets Message-ID: <20131102044353.F1EAC6292D@hg.openjdk.java.net> Changeset: 982dd6e1bf4f Author: lana Date: 2013-09-27 18:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/982dd6e1bf4f Merge Changeset: 2016a6b9e1f3 Author: hannesw Date: 2013-09-27 16:59 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2016a6b9e1f3 8025515: Performance issues with Source.getLine() Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/Source.java + test/script/basic/JDK-8025515.js Changeset: 1809c9e97c71 Author: hannesw Date: 2013-09-27 17:00 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1809c9e97c71 8025520: Array.prototype.slice should only copy defined elements Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8025520.js Changeset: efc40aacaee4 Author: hannesw Date: 2013-09-30 15:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/efc40aacaee4 8025589: Array.prototype.shift should only copy defined elements in generic mode Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8025589.js Changeset: ad5f9ce2a95b Author: jlaskey Date: 2013-09-30 10:24 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ad5f9ce2a95b Merge Changeset: 787e36fdf69a Author: jlaskey Date: 2013-09-30 12:06 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/787e36fdf69a Merge Changeset: 7272ec90f2c6 Author: sundar Date: 2013-09-30 21:33 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/7272ec90f2c6 8025629: load function should support a way to load scripts from classpath Reviewed-by: lagergren, hannesw, attila ! make/build.xml ! src/jdk/nashorn/internal/runtime/Context.java + test/script/trusted/JDK-8025629.js + test/src/jdk/nashorn/internal/runtime/resources/load_test.js Changeset: f5aefbe76cec Author: jlaskey Date: 2013-09-30 18:09 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f5aefbe76cec 8025689: fx:base.js classes not loading Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/base.js Changeset: cd7fb58043cb Author: sundar Date: 2013-10-01 14:38 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/cd7fb58043cb 8025488: Error.captureStackTrace should not format error stack Reviewed-by: hannesw, attila ! src/jdk/nashorn/internal/objects/NativeError.java + test/script/basic/JDK-8025488.js + test/script/basic/JDK-8025488.js.EXPECTED Changeset: 3470bc26128f Author: sundar Date: 2013-10-04 16:21 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3470bc26128f 8025771: Enhance Nashorn Contexts Reviewed-by: jlaskey, hannesw - make/java.security.override ! make/project.properties ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! test/script/basic/JDK-8023026.js + test/script/sandbox/arrayclass.js + test/script/sandbox/arrayclass.js.EXPECTED Changeset: 6345d08fd5de Author: hannesw Date: 2013-10-08 11:55 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6345d08fd5de 8025213: Assignment marks variable as defined too early Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java + test/script/basic/JDK-8025213.js + test/script/basic/JDK-8025213.js.EXPECTED Changeset: 8c326f8c6799 Author: sundar Date: 2013-10-08 13:02 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8c326f8c6799 8026033: Switch should load expression even when there are no cases in it Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8026033.js + test/script/basic/JDK-8026033.js.EXPECTED Changeset: 025e2ff9e91b Author: hannesw Date: 2013-10-08 13:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/025e2ff9e91b 8025965: Specialized functions with same weight replace each other in TreeSet Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/CompiledFunction.java Changeset: 19dba6637f20 Author: sundar Date: 2013-10-08 14:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/19dba6637f20 8026039: future strict names are allowed as function name and argument name of a strict function Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/error/JDK-8026039.js + test/script/error/JDK-8026039.js.EXPECTED Changeset: c9921761903b Author: hannesw Date: 2013-10-08 15:53 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/c9921761903b 8026042: FoldConstants need to guard against ArrayLiteralNode Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/ir/LiteralNode.java + test/script/basic/JDK-8026042.js + test/script/basic/JDK-8026042.js.EXPECTED Changeset: 346ba5b8a488 Author: sundar Date: 2013-10-08 16:46 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/346ba5b8a488 8026048: Function constructor should convert arguments to String before performing any syntax checks Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/objects/NativeFunction.java + test/script/basic/JDK-8026048.js Changeset: 3551855c4f40 Author: lana Date: 2013-10-08 15:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3551855c4f40 Merge - make/java.security.override Changeset: b48b719c5efc Author: lana Date: 2013-10-11 03:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b48b719c5efc Merge - make/java.security.override Changeset: 45399f3ef717 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/45399f3ef717 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildNashorn.gmk ! makefiles/Makefile Changeset: 6a4fdb3bb4e3 Author: katleman Date: 2013-10-16 12:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6a4fdb3bb4e3 Merge Changeset: 103590fc1e0a Author: cl Date: 2013-10-17 09:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/103590fc1e0a Added tag jdk8-b112 for changeset 6a4fdb3bb4e3 ! .hgtags Changeset: 8d29733ad609 Author: sundar Date: 2013-10-09 10:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8d29733ad609 8026112: Function("with(x ? 1e81 : (x2.constructor = 0.1)){}") throws AssertionError: double is not compatible with object Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8026112.js Changeset: 1e03d7caa68b Author: sundar Date: 2013-10-09 13:26 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1e03d7caa68b 8026125: Array.prototype.slice.call(Java.type("java.util.HashMap")) throws ClassCastException: jdk.internal.dynalink.beans.StaticClass cannot be cast to jdk.nashorn.internal.runtime.ScriptObject Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8026125.js Changeset: ec3094d9d5d5 Author: hannesw Date: 2013-10-09 14:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ec3094d9d5d5 8026008: Constant folding removes var statement Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/FoldConstants.java + test/script/basic/JDK-8026008.js + test/script/basic/JDK-8026008.js.EXPECTED Changeset: 03a68e7ca1d5 Author: lagergren Date: 2013-10-09 17:53 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/03a68e7ca1d5 8026137: Fix Issues with Binary Evaluation Order Reviewed-by: hannesw, jlaskey Contributed-by: marcus.lagergren at oracle.com, attila.szegedi at oracle.com ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/codegen/types/BooleanType.java ! src/jdk/nashorn/internal/codegen/types/ObjectType.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java - src/jdk/nashorn/internal/ir/TypeOverride.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/arrays/JavaArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseJavaArrayIterator.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java + test/script/basic/JDK-8026137.js + test/script/basic/JDK-8026137.js.EXPECTED Changeset: 7cc5ff16380f Author: sundar Date: 2013-10-10 11:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/7cc5ff16380f 8026167: Class cache/reuse of 'eval' scripts results in ClassCastException in some cases. Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/Context.java ! test/script/assert.js ! test/script/basic/JDK-8019508.js ! test/script/basic/JDK-8019508.js.EXPECTED ! test/script/basic/JDK-8019553.js ! test/script/basic/JDK-8019553.js.EXPECTED ! test/script/basic/JDK-8019791.js ! test/script/basic/JDK-8019791.js.EXPECTED ! test/script/basic/JDK-8019805.js ! test/script/basic/JDK-8019805.js.EXPECTED + test/script/basic/JDK-8026167.js ! test/script/basic/NASHORN-100.js ! test/script/basic/NASHORN-100.js.EXPECTED ! test/script/basic/NASHORN-293.js ! test/script/basic/NASHORN-293.js.EXPECTED ! test/script/basic/NASHORN-40.js ! test/script/basic/NASHORN-40.js.EXPECTED ! test/script/basic/NASHORN-51.js ! test/script/basic/NASHORN-51.js.EXPECTED ! test/script/basic/NASHORN-98.js ! test/script/basic/NASHORN-98.js.EXPECTED ! test/script/basic/eval.js ! test/script/basic/eval.js.EXPECTED Changeset: e60bbcf2f6b6 Author: sundar Date: 2013-10-10 13:17 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e60bbcf2f6b6 8026248: importClass has to be a varargs function Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/JDK-8026248.js + test/script/basic/JDK-8026248.js.EXPECTED Changeset: f6263ae511c2 Author: lana Date: 2013-10-10 13:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f6263ae511c2 Merge Changeset: 34f7a699cdef Author: sundar Date: 2013-10-10 14:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/34f7a699cdef 8026162: "this" in SAM adapter functions is wrong Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java + test/script/basic/JDK-8026162.js Changeset: ed3da7a574a0 Author: lagergren Date: 2013-10-10 16:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ed3da7a574a0 8026250: Logging nullpointer bugfix and javadoc warnings Reviewed-by: hannesw, jlaskey, sundar ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/WithObject.java Changeset: a781ea074521 Author: sundar Date: 2013-10-10 21:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a781ea074521 8026264: Getter, setter function name mangling issues Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java + test/script/basic/JDK-8026264.js Changeset: 375c2f2d41c8 Author: sundar Date: 2013-10-11 06:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/375c2f2d41c8 8026263: [NASHORN] Test test/script/basic/JDK-8025488.js fails in nightly builds Reviewed-by: jlaskey ! test/script/basic/JDK-8025488.js Changeset: 56be5161f0d2 Author: sundar Date: 2013-10-11 09:09 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/56be5161f0d2 Merge Changeset: 1c154cee43d9 Author: hannesw Date: 2013-10-11 10:56 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1c154cee43d9 8026292: Megamorphic setter fails with boolean value Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + test/script/basic/JDK-8026292.js Changeset: fb091f9052a6 Author: sundar Date: 2013-10-11 11:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/fb091f9052a6 8026302: source representation of getter and setter methods is wrong Reviewed-by: lagergren, hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8026302.js + test/script/basic/JDK-8026302.js.EXPECTED ! test/script/basic/objects.js.EXPECTED Changeset: 062579f50371 Author: sundar Date: 2013-10-11 14:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/062579f50371 8026317: $ in the function name results in wrong function being invoked Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/codegen/Namespace.java + test/script/basic/JDK-8026317.js + test/script/basic/JDK-8026317.js.EXPECTED Changeset: b35d175207f6 Author: sundar Date: 2013-10-11 14:13 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b35d175207f6 Merge Changeset: 1b0a71a9920a Author: lana Date: 2013-10-11 23:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1b0a71a9920a Merge Changeset: 6cb4f20d971f Author: jlaskey Date: 2013-10-11 14:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6cb4f20d971f 8026309: latest runsunspider.js tests contains several bugs Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! test/script/basic/runsunspider.js Changeset: 8c617a092d68 Author: hannesw Date: 2013-10-14 11:45 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8c617a092d68 8026016: too many relinks dominate avatar.js http benchmark Reviewed-by: sundar, jlaskey, attila ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8026016.js + test/script/basic/JDK-8026016.js.EXPECTED Changeset: d155c4a7703c Author: attila Date: 2013-10-14 12:41 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d155c4a7703c 8026113: Nashorn arrays should automatically convert to Java arrays Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java + test/src/jdk/nashorn/api/javaaccess/ArrayConversionTest.java Changeset: 64e841576c68 Author: attila Date: 2013-10-15 15:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/64e841576c68 8026397: Fix ambiguity with array conversion, including passing JS NativeArrays in Java variable arity methods' vararg array position Reviewed-by: jlaskey, sundar ! src/jdk/internal/dynalink/beans/SingleDynamicMethod.java ! src/jdk/internal/dynalink/support/Guards.java ! src/jdk/internal/dynalink/support/messages.properties ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! test/src/jdk/nashorn/api/javaaccess/ArrayConversionTest.java Changeset: aa452eb4a5d0 Author: hannesw Date: 2013-10-15 17:37 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/aa452eb4a5d0 8026367: Add a sync keyword to mozilla_compat Reviewed-by: sundar, attila, lagergren ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/JDK-8026367.js ! test/script/sandbox/loadcompat.js Changeset: b3ee112a328e Author: jlaskey Date: 2013-10-15 13:14 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b3ee112a328e 8026498: Revert: latest runsunspider.js tests contains several bugs Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! test/script/basic/runsunspider.js Changeset: 9a13e95cc40f Author: sundar Date: 2013-10-15 22:13 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/9a13e95cc40f Merge Changeset: 1899da5c71d3 Author: hannesw Date: 2013-10-16 10:12 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1899da5c71d3 8026692: eval() throws NullPointerException with --compile-only Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Lower.java + test/script/basic/JDK-8026692.js Changeset: 2d5f9f77c199 Author: hannesw Date: 2013-10-16 10:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2d5f9f77c199 8026693: getType() called on DISCARD node Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java + test/script/basic/JDK-8026693.js Changeset: adc5639fc4b9 Author: sundar Date: 2013-10-17 13:02 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/adc5639fc4b9 Merge Changeset: 676cd7bf5e09 Author: lana Date: 2013-10-17 16:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/676cd7bf5e09 Merge Changeset: 79f7b79bf97b Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/79f7b79bf97b Added tag jdk8-b113 for changeset 676cd7bf5e09 ! .hgtags Changeset: f109bb255b80 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f109bb255b80 Added tag jdk8-b114 for changeset 79f7b79bf97b ! .hgtags From john.coomes at oracle.com Fri Nov 1 20:18:17 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 02 Nov 2013 03:18:17 +0000 Subject: hg: hsx/hotspot-rt/jdk: 308 new changesets Message-ID: <20131102042031.ACFFE62928@hg.openjdk.java.net> Changeset: 8a041011b6e6 Author: jgodinez Date: 2013-09-27 13:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a041011b6e6 6870661: Setting a custom PrintService on a PrinterJob leads to a PrinterException Reviewed-by: prr, jgodinez Contributed-by: patrick at reini.net ! src/windows/classes/sun/awt/windows/WPrinterJob.java + test/java/awt/print/PrinterJob/CustomPrintService/PrintDialog.java + test/java/awt/print/PrinterJob/CustomPrintService/PrintServiceStub.java + test/java/awt/print/PrinterJob/CustomPrintService/SetPrintServiceTest.java Changeset: 31b8d4931a09 Author: prr Date: 2013-09-27 13:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/31b8d4931a09 8020190: Fatal: Bug in native code: jfieldID must match object Reviewed-by: jgodinez, vadim ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/native/sun/font/freetypeScaler.c Changeset: 6ef33b4553a4 Author: vadim Date: 2013-09-30 12:50 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6ef33b4553a4 8001119: [fingbugs] Evaluate necessity to make some arrays package protected Reviewed-by: prr, bae + src/share/classes/com/sun/imageio/plugins/bmp/BMPCompressionTypes.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPConstants.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPMetadata.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFStreamMetadata.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEG.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/share/classes/javax/imageio/plugins/bmp/BMPImageWriteParam.java Changeset: e2604b873b36 Author: prr Date: 2013-10-01 15:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e2604b873b36 8007386: On physical machine (video card is Intel Q45) the text is blank. Reviewed-by: prr, jchen ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 96ff585555f4 Author: vadim Date: 2013-10-02 10:06 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/96ff585555f4 8024343: Change different color with the "The XOR alternation color" combobox, the color of the image can not shown immediately. Reviewed-by: ceisserer, prr, bae ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java + test/sun/java2d/AcceleratedXORModeTest.java Changeset: 5f3d984d8207 Author: prr Date: 2013-10-02 11:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5f3d984d8207 8025837: Extraneous changes in the fix for 8007386 Reviewed-by: jgodinez, jchen ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: f53aeb3c7eed Author: prr Date: 2013-10-02 11:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f53aeb3c7eed 7179526: xrender : closed/sun/java2d/volatileImage/LineClipTest.java failed since jdk8b36 Reviewed-by: prr, jchen ! src/solaris/classes/sun/java2d/xr/GrowableRectArray.java ! src/solaris/classes/sun/java2d/xr/MaskTile.java ! src/solaris/classes/sun/java2d/xr/MaskTileManager.java + src/solaris/classes/sun/java2d/xr/XRDrawLine.java ! src/solaris/classes/sun/java2d/xr/XRRenderer.java + test/java/awt/Graphics/LineClipTest.java Changeset: a15cad0e12d3 Author: bae Date: 2013-10-03 11:28 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a15cad0e12d3 8022632: Reading a PNG file fails because of WBMPImageReaderSpi.canDecodeInput() Reviewed-by: prr, jgodinez ! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReaderSpi.java + test/javax/imageio/plugins/wbmp/StreamResetTest.java Changeset: 2f11a00279ec Author: jchen Date: 2013-10-03 13:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2f11a00279ec 8025280: [parfait] warnings from b107 for jdk.src.share.native.sun.java2d.loops: JNI exception pending, JNI critical region violation Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/loops/Blit.c ! src/share/native/sun/java2d/loops/BlitBg.c ! src/share/native/sun/java2d/loops/DrawPath.c ! src/share/native/sun/java2d/loops/DrawPolygons.c ! src/share/native/sun/java2d/loops/FillPath.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.c ! src/share/native/sun/java2d/loops/MaskBlit.c ! src/share/native/sun/java2d/loops/MaskFill.c ! src/share/native/sun/java2d/loops/ScaledBlit.c ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: e88d39b110dd Author: jchen Date: 2013-10-03 13:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e88d39b110dd 8025480: [parfait] "JNI exception pending" warnings from b107 for jdk.src.share.native.sun.java2d Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/Disposer.c ! src/share/native/sun/java2d/SurfaceData.c Changeset: 3c1b13ad0677 Author: jchen Date: 2013-10-03 13:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3c1b13ad0677 8025309: [parfait] JNI-related warnings from b107 for jdk.src.share.native.sun.java2d.pipe Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/pipe/BufferedRenderPipe.c ! src/share/native/sun/java2d/pipe/Region.c ! src/share/native/sun/java2d/pipe/ShapeSpanIterator.c ! src/share/native/sun/java2d/pipe/SpanClipRenderer.c Changeset: d37594b689ce Author: jchen Date: 2013-10-03 13:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d37594b689ce 8025664: [parfait] warnings from b62 for jdk.src.share.native.sun.font Reviewed-by: prr, jgodinez ! src/share/native/sun/font/freetypeScaler.c Changeset: 0ed939dc4230 Author: jchen Date: 2013-10-03 13:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0ed939dc4230 8025294: [parfait] JNI-related warnings from b107 for jdk.src.solaris.native.sun.java2d.x11 Reviewed-by: prr, jgodinez ! src/solaris/native/sun/java2d/x11/X11Renderer.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/XRBackendNative.c ! src/solaris/native/sun/java2d/x11/XRSurfaceData.c Changeset: 8fd757f31470 Author: jchen Date: 2013-10-04 16:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8fd757f31470 8025940: Windows build fails after the fix for 8025280 Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/loops/MaskBlit.c Changeset: 727b60f9c09c Author: lana Date: 2013-10-08 14:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/727b60f9c09c Merge Changeset: e4e151f6ae50 Author: yan Date: 2013-09-27 12:35 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e4e151f6ae50 8025249: [javadoc] fix some javadoc errors in javax/swing/ Reviewed-by: alexsch, yan Contributed-by: Taras Ledkov ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/share/classes/javax/swing/event/CaretEvent.java ! src/share/classes/javax/swing/event/DocumentEvent.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/javax/swing/event/ListDataEvent.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/filechooser/FileView.java ! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java ! src/share/classes/javax/swing/table/DefaultTableModel.java ! src/share/classes/javax/swing/table/JTableHeader.java ! src/share/classes/javax/swing/table/TableCellRenderer.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/AbstractWriter.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/AttributeSet.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/Element.java ! src/share/classes/javax/swing/text/View.java Changeset: ca45169cb4eb Author: pchelko Date: 2013-09-27 14:29 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ca45169cb4eb 8024122: [TEST] need test to cover JDK-7146572 Reviewed-by: anthony, yan Contributed-by: Alexander Stepanov + test/java/awt/InputMethods/InputMethodsTest/InputMethodsTest.html + test/java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java Changeset: ad7db846c951 Author: pchelko Date: 2013-09-27 17:04 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ad7db846c951 8025503: [macosx] FileDialog allows file selection with apple.awt.fileDialogForDirectories = true Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/CFileDialog.m Changeset: 260bc59ca253 Author: pchelko Date: 2013-09-27 18:35 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/260bc59ca253 8016563: Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails Reviewed-by: anthony, serb ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: bfff9e9120ec Author: malenkov Date: 2013-09-27 22:17 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bfff9e9120ec 8012716: java.beans.EventHandler.create method should check if the given listenerInterface is a public interface Reviewed-by: art, mchung ! src/share/classes/java/beans/EventHandler.java Changeset: 0042f54f65d0 Author: malenkov Date: 2013-09-27 22:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0042f54f65d0 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed Reviewed-by: anthony, serb ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java Changeset: 603cd3cefbb0 Author: malenkov Date: 2013-09-30 22:08 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/603cd3cefbb0 8025652: [macos] build failed Reviewed-by: serb ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java Changeset: cdfa2301a291 Author: serb Date: 2013-10-01 04:29 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cdfa2301a291 7150100: [macosx] "0123456789" is selected in the TextField Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java + test/java/awt/TextArea/SelectionVisible/SelectionVisible.html + test/java/awt/TextArea/SelectionVisible/SelectionVisible.java + test/java/awt/TextField/SelectionVisible/SelectionVisible.html + test/java/awt/TextField/SelectionVisible/SelectionVisible.java Changeset: 2d8418d68a3c Author: kshefov Date: 2013-10-01 13:19 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2d8418d68a3c 7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks Reviewed-by: anthony, serb Contributed-by: vera.akulova at oracle.com + test/java/awt/List/NofocusListDblClickTest/NofocusListDblClickTest.java Changeset: 329011aad090 Author: kshefov Date: 2013-10-01 13:30 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/329011aad090 8012468: [TEST_BUG] javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java doesn't release mouse button Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com ! test/javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java Changeset: 0887aad989fb Author: kshefov Date: 2013-10-01 13:38 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0887aad989fb 8012466: [TEST_BUG] javax/swing/JInternalFrame/Test6505027.java doesn't release mouse button Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com ! test/javax/swing/JInternalFrame/Test6505027.java Changeset: 1043bd1f7fca Author: kshefov Date: 2013-10-01 13:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1043bd1f7fca 8004294: [TEST_BUG] javax/swing/JSpinner/4973721/bug4973721.java failed on win2003 Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/JSpinner/4973721/bug4973721.java Changeset: 68157255f3eb Author: kshefov Date: 2013-10-01 13:45 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/68157255f3eb 8012461: [TEST_BUG] closed/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java doesn't release mouse button Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java + test/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.xml Changeset: 172405287fde Author: kshefov Date: 2013-10-01 13:46 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/172405287fde 7133545: [macosx] closed/javax/swing/JSplitPane/4514858/bug4514858.java fails on MacOS Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/JSplitPane/4514858/bug4514858.java Changeset: 291e66f4cb83 Author: kshefov Date: 2013-10-01 13:47 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/291e66f4cb83 7133532: [macosx] closed/javax/swing/JScrollBar/bug4202954/bug4202954.java fails on MacOS Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/JScrollBar/bug4202954/bug4202954.java Changeset: 560ede42bd2e Author: kshefov Date: 2013-10-01 14:38 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/560ede42bd2e 8025707: Frogot to add a file to fix for JDK-8012461 Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/plaf/synth/SynthButtonUI/6276188/red.gif Changeset: a0c28e64c049 Author: alitvinov Date: 2013-10-01 18:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a0c28e64c049 8025145: [macosx]: java 7 does not recognize tiff image on clipboard Reviewed-by: anthony, serb Contributed-by: anton.nashatyrev at oracle.com ! src/macosx/lib/flavormap.properties Changeset: 5e205645d990 Author: pchelko Date: 2013-10-02 11:18 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5e205645d990 7124363: [macosx] ClassCastException: CFileDialog cannot be cast to LWWindowPeer Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 1189f954d52f Author: pchelko Date: 2013-10-02 11:32 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1189f954d52f 8024163: [macosx] NullPointerException at javax.swing.TransferHandler$DropHandler.handleDrag since jdk8b93, 7u40b28 Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CDropTargetContextPeer.java ! src/macosx/native/sun/awt/CDropTarget.m + test/java/awt/dnd/DropTargetEnterExitTest/ExtraDragEnterTest.java + test/java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java Changeset: 01198c681710 Author: pchelko Date: 2013-10-02 11:50 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01198c681710 8024600: [macosx] code prevents use of -Xlint:auxiliaryclass,empty in jdk build Reviewed-by: anthony, serb ! src/macosx/classes/com/apple/eawt/_AppEventLegacyHandler.java + src/macosx/classes/com/apple/eawt/_OpenAppHandler.java ! src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java + src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java ! src/macosx/classes/com/apple/laf/AquaMenuBarUI.java Changeset: 287e0a7731ff Author: pchelko Date: 2013-10-02 16:58 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/287e0a7731ff 8024158: [macosx] java/awt/EventDispatchThread/LoopRobustness/LoopRobustness still failed after fix JDK-8022247; since jdk8b96 Reviewed-by: art, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 244f2ee51f31 Author: leonidr Date: 2013-10-02 17:06 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/244f2ee51f31 8023994: Right click on the icon added to the system tray for the first time, java.lang.IllegalArgumentException thrown. Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java Changeset: f40f2421c60f Author: serb Date: 2013-10-02 21:02 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f40f2421c60f 8013563: Memory leak in JFrame on Linux Reviewed-by: anthony, art ! src/share/classes/java/awt/Window.java + test/java/awt/Window/WindowsLeak/WindowsLeak.java Changeset: 1da5d306e84b Author: cl Date: 2013-10-02 11:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1da5d306e84b 8025409: Fix javadoc comments errors and warning reported by doclint report Reviewed-by: anthony, yan ! src/share/classes/java/awt/BorderLayout.java ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/CheckboxGroup.java ! src/share/classes/java/awt/CheckboxMenuItem.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Color.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/FlowLayout.java ! src/share/classes/java/awt/FontMetrics.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/GridLayout.java ! src/share/classes/java/awt/Label.java ! src/share/classes/java/awt/LinearGradientPaint.java ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/MenuBar.java ! src/share/classes/java/awt/MenuItem.java ! src/share/classes/java/awt/RadialGradientPaint.java ! src/share/classes/java/awt/Scrollbar.java ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TextArea.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/font/TextAttribute.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/awt/print/PrinterJob.java ! src/share/classes/javax/print/Doc.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/MultiDoc.java ! src/share/classes/javax/print/attribute/standard/Finishings.java ! src/share/classes/javax/print/attribute/standard/JobStateReasons.java ! src/share/classes/javax/print/attribute/standard/MediaPrintableArea.java ! src/share/classes/javax/print/attribute/standard/MultipleDocumentHandling.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java ! src/share/classes/javax/print/attribute/standard/Sides.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JScrollPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/LookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalTreeUI.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/MaskFormatter.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java Changeset: 998578a87c0e Author: bagiras Date: 2013-10-03 16:51 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/998578a87c0e 8013553: [macosx] java.awt.FileDialog removes file extensions Reviewed-by: leonidr, serb ! src/macosx/native/sun/awt/CFileDialog.m Changeset: 1533a379deb0 Author: anthony Date: 2013-10-03 18:01 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1533a379deb0 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure Summary: Load the lwawt native library on Mac regardless of the headless/headful mode. Also, some minor cleanup. Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m ! src/solaris/native/sun/awt/awt_LoadLibrary.c Changeset: 39b674405270 Author: alexsch Date: 2013-10-03 19:02 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/39b674405270 7092283: Property Window.locationByPlatform is not cleared by calling setVisible(false) Reviewed-by: anthony, serb ! src/share/classes/java/awt/Window.java + test/java/awt/Window/LocationByPlatform/LocationByPlatformTest.java Changeset: 6ffe50fe06bd Author: mcherkas Date: 2013-10-04 20:13 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6ffe50fe06bd 8020688: Broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index. Reviewed-by: anthony, alexsch ! src/macosx/classes/apple/applescript/AppleScriptEngine.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SKI.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java ! src/share/classes/java/applet/Applet.java ! src/share/classes/java/applet/AppletStub.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/DefaultFocusTraversalPolicy.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/DisplayMode.java ! src/share/classes/java/awt/FocusTraversalPolicy.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/awt/datatransfer/Transferable.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/ActionListener.java ! src/share/classes/java/awt/event/ComponentAdapter.java ! src/share/classes/java/awt/event/ComponentEvent.java ! src/share/classes/java/awt/event/ComponentListener.java ! src/share/classes/java/awt/event/ContainerAdapter.java ! src/share/classes/java/awt/event/ContainerEvent.java ! src/share/classes/java/awt/event/ContainerListener.java ! src/share/classes/java/awt/event/FocusAdapter.java ! src/share/classes/java/awt/event/FocusEvent.java ! src/share/classes/java/awt/event/FocusListener.java ! src/share/classes/java/awt/event/ItemEvent.java ! src/share/classes/java/awt/event/ItemListener.java ! src/share/classes/java/awt/event/KeyAdapter.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/java/awt/event/MouseAdapter.java ! src/share/classes/java/awt/event/MouseEvent.java ! src/share/classes/java/awt/event/MouseListener.java ! src/share/classes/java/awt/event/MouseMotionAdapter.java ! src/share/classes/java/awt/event/MouseMotionListener.java ! src/share/classes/java/awt/event/WindowAdapter.java ! src/share/classes/java/awt/event/WindowEvent.java ! src/share/classes/java/awt/event/WindowFocusListener.java ! src/share/classes/java/awt/event/WindowListener.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/BorderFactory.java ! src/share/classes/javax/swing/BoundedRangeModel.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/DefaultFocusManager.java ! src/share/classes/javax/swing/FocusManager.java ! src/share/classes/javax/swing/ImageIcon.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JCheckBox.java ! src/share/classes/javax/swing/JCheckBoxMenuItem.java ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JPanel.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JProgressBar.java ! src/share/classes/javax/swing/JRadioButton.java ! src/share/classes/javax/swing/JRadioButtonMenuItem.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JScrollPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextArea.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTextPane.java ! src/share/classes/javax/swing/JToggleButton.java ! src/share/classes/javax/swing/JToolBar.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/ProgressMonitor.java ! src/share/classes/javax/swing/ProgressMonitorInputStream.java ! src/share/classes/javax/swing/Spring.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/WindowConstants.java ! src/share/classes/javax/swing/border/Border.java ! src/share/classes/javax/swing/event/InternalFrameAdapter.java ! src/share/classes/javax/swing/event/InternalFrameEvent.java ! src/share/classes/javax/swing/event/InternalFrameListener.java ! src/share/classes/javax/swing/event/TreeExpansionEvent.java ! src/share/classes/javax/swing/event/TreeExpansionListener.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/event/TreeModelListener.java ! src/share/classes/javax/swing/event/TreeSelectionListener.java ! src/share/classes/javax/swing/event/TreeWillExpandListener.java ! src/share/classes/javax/swing/filechooser/FileFilter.java ! src/share/classes/javax/swing/filechooser/FileView.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/table/TableModel.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/ExpandVetoException.java ! src/share/classes/javax/swing/tree/TreeCellRenderer.java ! src/share/classes/javax/swing/tree/TreeModel.java ! src/share/classes/javax/swing/tree/TreeNode.java ! src/share/classes/javax/swing/tree/TreePath.java ! src/share/classes/javax/swing/tree/TreeSelectionModel.java ! src/share/classes/sun/swing/PrintingStatus.java ! src/share/classes/sun/text/normalizer/UCharacter.java ! src/share/demo/jfc/FileChooserDemo/FileChooserDemo.java Changeset: 01b40315f872 Author: alexsch Date: 2013-10-07 16:13 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01b40315f872 8025438: [macosx] right JNFCall* method should be used in JDK-8008728 fix Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 72afa269fa3b Author: alexsch Date: 2013-10-07 16:42 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/72afa269fa3b 8007219: [macosx] Frame size reverts meaning of maximized attribute if frame size close to display Reviewed-by: serb, anthony ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/native/sun/awt/CWrapper.m + test/java/awt/Frame/MaximizedToMaximized/MaximizedToMaximized.java Changeset: 546c0ebfbf56 Author: cl Date: 2013-10-07 11:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/546c0ebfbf56 8025840: Fix all the doclint warnings about trademark Reviewed-by: art ! src/share/classes/javax/swing/AbstractAction.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/AbstractCellEditor.java ! src/share/classes/javax/swing/AbstractListModel.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/CellRendererPane.java ! src/share/classes/javax/swing/DefaultBoundedRangeModel.java ! src/share/classes/javax/swing/DefaultButtonModel.java ! src/share/classes/javax/swing/DefaultCellEditor.java ! src/share/classes/javax/swing/DefaultListCellRenderer.java ! src/share/classes/javax/swing/DefaultListModel.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DefaultSingleSelectionModel.java ! src/share/classes/javax/swing/ImageIcon.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JCheckBox.java ! src/share/classes/javax/swing/JCheckBoxMenuItem.java ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFormattedTextField.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JPanel.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JProgressBar.java ! src/share/classes/javax/swing/JRadioButton.java ! src/share/classes/javax/swing/JRadioButtonMenuItem.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JScrollBar.java ! src/share/classes/javax/swing/JScrollPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextArea.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTextPane.java ! src/share/classes/javax/swing/JToggleButton.java ! src/share/classes/javax/swing/JToolBar.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/KeyStroke.java ! src/share/classes/javax/swing/OverlayLayout.java ! src/share/classes/javax/swing/ScrollPaneLayout.java ! src/share/classes/javax/swing/SizeRequirements.java ! src/share/classes/javax/swing/Spring.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/UnsupportedLookAndFeelException.java ! src/share/classes/javax/swing/ViewportLayout.java ! src/share/classes/javax/swing/border/AbstractBorder.java ! src/share/classes/javax/swing/border/BevelBorder.java ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/border/EmptyBorder.java ! src/share/classes/javax/swing/border/EtchedBorder.java ! src/share/classes/javax/swing/border/LineBorder.java ! src/share/classes/javax/swing/border/MatteBorder.java ! src/share/classes/javax/swing/border/SoftBevelBorder.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorChooserComponentFactory.java ! src/share/classes/javax/swing/colorchooser/DefaultPreviewPanel.java ! src/share/classes/javax/swing/colorchooser/DefaultSwatchChooserPanel.java ! src/share/classes/javax/swing/event/AncestorEvent.java ! src/share/classes/javax/swing/event/CaretEvent.java ! src/share/classes/javax/swing/event/ChangeEvent.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/javax/swing/event/HyperlinkEvent.java ! src/share/classes/javax/swing/event/InternalFrameEvent.java ! src/share/classes/javax/swing/event/ListDataEvent.java ! src/share/classes/javax/swing/event/ListSelectionEvent.java ! src/share/classes/javax/swing/event/MenuDragMouseEvent.java ! src/share/classes/javax/swing/event/MenuEvent.java ! src/share/classes/javax/swing/event/MenuKeyEvent.java ! src/share/classes/javax/swing/event/PopupMenuEvent.java ! src/share/classes/javax/swing/event/TableColumnModelEvent.java ! src/share/classes/javax/swing/event/TableModelEvent.java ! src/share/classes/javax/swing/event/TreeExpansionEvent.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/event/TreeSelectionEvent.java ! src/share/classes/javax/swing/event/UndoableEditEvent.java ! src/share/classes/javax/swing/plaf/BorderUIResource.java ! src/share/classes/javax/swing/plaf/ColorUIResource.java ! src/share/classes/javax/swing/plaf/DimensionUIResource.java ! src/share/classes/javax/swing/plaf/FontUIResource.java ! src/share/classes/javax/swing/plaf/IconUIResource.java ! src/share/classes/javax/swing/plaf/InsetsUIResource.java ! src/share/classes/javax/swing/plaf/basic/BasicArrowButton.java ! src/share/classes/javax/swing/plaf/basic/BasicCheckBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/basic/BasicEditorPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicIconFactory.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicListUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java ! src/share/classes/javax/swing/plaf/basic/BasicTextAreaUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextFieldUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/plaf/basic/ComboPopup.java ! src/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java ! src/share/classes/javax/swing/plaf/metal/MetalButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalCheckBoxIcon.java ! src/share/classes/javax/swing/plaf/metal/MetalCheckBoxUI.java ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxButton.java ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxEditor.java ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java ! src/share/classes/javax/swing/plaf/metal/MetalIconFactory.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalProgressBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalRadioButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalScrollButton.java ! src/share/classes/javax/swing/plaf/metal/MetalScrollPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSeparatorUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSplitPaneDivider.java ! src/share/classes/javax/swing/plaf/metal/MetalSplitPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTextFieldUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToggleButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolTipUI.java ! src/share/classes/javax/swing/plaf/multi/MultiLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java ! src/share/classes/javax/swing/table/AbstractTableModel.java ! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java ! src/share/classes/javax/swing/table/DefaultTableColumnModel.java ! src/share/classes/javax/swing/table/DefaultTableModel.java ! src/share/classes/javax/swing/table/JTableHeader.java ! src/share/classes/javax/swing/table/TableColumn.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/BadLocationException.java ! src/share/classes/javax/swing/text/DateFormatter.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultEditorKit.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultFormatterFactory.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/MaskFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/SimpleAttributeSet.java ! src/share/classes/javax/swing/text/StringContent.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/StyledEditorKit.java ! src/share/classes/javax/swing/text/TabSet.java ! src/share/classes/javax/swing/text/TabStop.java ! src/share/classes/javax/swing/text/TextAction.java ! src/share/classes/javax/swing/text/html/Option.java ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/TreePath.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/javax/swing/undo/CannotRedoException.java ! src/share/classes/javax/swing/undo/CannotUndoException.java ! src/share/classes/javax/swing/undo/UndoManager.java Changeset: bdc8abbce9c1 Author: yan Date: 2013-10-08 13:57 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bdc8abbce9c1 8025236: [javadoc] fix some errors in AWT Reviewed-by: yan, anthony Contributed-by: Dmitry Ginzburg ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/MouseEvent.java ! src/share/classes/java/awt/im/InputContext.java ! src/share/classes/java/awt/im/InputMethodHighlight.java Changeset: 01022f461570 Author: pchelko Date: 2013-10-08 15:17 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01022f461570 7158311: GraphicsDevice.setDisplayMode(...) leads to hang when DISPLAY variable points to Oracle Linux 8001463: Regression : Deadlock between AWT-XAWT thread and AWT-EventQueue-0 Thread when screen resolution changes Reviewed-by: art, serb Contributed-by: alexander.zvegintsev at oracle.com ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: a5d0730342a5 Author: pchelko Date: 2013-10-08 15:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a5d0730342a5 8025585: Win: Popups in JFXPanel do not receive MouseWheel events Reviewed-by: anthony, art ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 85a72bb00d74 Author: bagiras Date: 2013-10-08 16:04 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/85a72bb00d74 8000425: FileDialog documentation should be enhanced Reviewed-by: serb, anthony ! src/share/classes/java/awt/FileDialog.java Changeset: 01607de6265d Author: bagiras Date: 2013-10-08 16:56 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01607de6265d 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java Changeset: 184b16f4e61f Author: bagiras Date: 2013-10-08 17:00 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/184b16f4e61f 7199196: Incremental transfer is broken because of a typo Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: 42d3ea1c35b4 Author: malenkov Date: 2013-10-08 18:10 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/42d3ea1c35b4 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/sun/awt/NullComponentPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java Changeset: 6914b883c3bb Author: malenkov Date: 2013-10-08 18:19 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6914b883c3bb 7172597: java.awt.KeyboardFocusManager.clearFocusOwner() missed javadoc tag @since 1.8 Reviewed-by: art, anthony ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: a2dd2b411723 Author: alexsch Date: 2013-10-08 18:45 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a2dd2b411723 7081594: Windows owned by an always-on-top window DO NOT automatically become always-on-top Reviewed-by: art, anthony, serb ! src/share/classes/java/awt/Window.java + test/java/awt/Window/AlwaysOnTop/AlwaysOnTopFieldTest.java Changeset: 0c06c38dfc3e Author: serb Date: 2013-10-08 21:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0c06c38dfc3e 8022119: test api/javax_sound/sampled/spi/MixerProvider/indexTGF_MixerProviderTests fails Reviewed-by: art, anthony ! src/share/classes/com/sun/media/sound/JSSecurityManager.java Changeset: b218a14bdc8a Author: serb Date: 2013-10-08 23:34 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b218a14bdc8a 8025603: Unused methods in the awt text peers should be removed Reviewed-by: art, anthony ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/peer/TextComponentPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/windows/classes/sun/awt/windows/WButtonPeer.java ! src/windows/classes/sun/awt/windows/WCheckboxPeer.java ! src/windows/classes/sun/awt/windows/WChoicePeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WLabelPeer.java ! src/windows/classes/sun/awt/windows/WListPeer.java ! src/windows/classes/sun/awt/windows/WScrollbarPeer.java ! src/windows/classes/sun/awt/windows/WTextAreaPeer.java ! src/windows/classes/sun/awt/windows/WTextComponentPeer.java ! src/windows/classes/sun/awt/windows/WTextFieldPeer.java ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TextComponent.cpp ! src/windows/native/sun/windows/awt_TextField.cpp Changeset: e591ac19174f Author: leonidr Date: 2013-10-09 01:03 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e591ac19174f 8004050: [macosx] The 'ESC' key does not work with jdk8 Reviewed-by: alexsch, serb ! src/macosx/classes/com/apple/laf/AquaComboBoxUI.java ! src/macosx/classes/com/apple/laf/AquaKeyBindings.java Changeset: c1ef9ebac26a Author: lana Date: 2013-10-08 14:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c1ef9ebac26a Merge ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java Changeset: 78b4dc33e6e6 Author: twisti Date: 2013-09-26 18:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/78b4dc33e6e6 8019192: StringIndexOutOfBoundsException: in Class.getSimpleName() Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MemberName.java Changeset: eb2c81533876 Author: weijun Date: 2013-09-27 15:25 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eb2c81533876 8024861: Incomplete token triggers GSS-API NullPointerException Reviewed-by: mullan ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java + test/sun/security/jgss/spnego/MechTokenMissing.java Changeset: 95f609fcb639 Author: ehelin Date: 2013-09-26 16:23 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/95f609fcb639 8025502: Exclude tests due to JDK-8025427 Reviewed-by: ksrini ! test/ProblemList.txt Changeset: 914f8d4570df Author: mduigou Date: 2013-09-27 10:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/914f8d4570df 8025595: Remove alt-rt.jar, used by +AggressiveOps (jdk repo portion of JDK-8024826) Reviewed-by: alanb, chegar, dholmes, ksrini ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt ! test/java/util/TreeMap/Clone.java Changeset: fbe6f5dbb24f Author: mduigou Date: 2013-09-27 13:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fbe6f5dbb24f 8023339: Refined Collection.removeIf UOE conditions Reviewed-by: mduigou Contributed-by: paul.sandoz at oracle.com ! src/share/classes/java/util/Collection.java ! test/java/util/Collection/MOAT.java Changeset: 91222be67b27 Author: mduigou Date: 2013-09-27 13:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/91222be67b27 8023340: Clarify that unmodifiable List.replaceAll() may not throw UOE if there are no items to be replaced. Reviewed-by: psandoz, jjg ! src/share/classes/java/util/List.java Changeset: 754db1268be1 Author: dxu Date: 2013-09-27 17:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/754db1268be1 8025128: File.createTempFile fails if prefix is absolute path Summary: Use only the file name from the supplied prefix for backward compatibility Reviewed-by: alanb, chegar ! src/share/classes/java/io/File.java ! test/java/io/File/createTempFile/SpecialTempFile.java Changeset: d921ce805abe Author: mduigou Date: 2013-09-27 17:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d921ce805abe 8025610: Add explicit @throws NPE documentation to Optional constructor and Optional.of Reviewed-by: briangoetz, chegar, alanb ! src/share/classes/java/util/Optional.java Changeset: 0b535e920dd5 Author: lana Date: 2013-09-27 18:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0b535e920dd5 Merge Changeset: 15955d335cd0 Author: jfranck Date: 2013-09-30 11:18 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/15955d335cd0 8007072: Update Core Reflection for Type Annotations to match latest spec 8022324: j.l.Class.getAnnotatedInterfaces() for array type returns wrong value 8024915: j.l.r.Executable.getAnnotatedReceiverType() should return null for static methods Summary: Update javadoc and implementation of reflection for type annotations to match latest spec Reviewed-by: darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/AnnotatedArrayType.java ! src/share/classes/java/lang/reflect/AnnotatedParameterizedType.java ! src/share/classes/java/lang/reflect/AnnotatedType.java ! src/share/classes/java/lang/reflect/AnnotatedTypeVariable.java ! src/share/classes/java/lang/reflect/AnnotatedWildcardType.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/annotation/typeAnnotations/GetAnnotatedInterfaces.java + test/java/lang/annotation/typeAnnotations/GetAnnotatedReceiverType.java ! test/java/lang/annotation/typeAnnotations/GetAnnotatedSuperclass.java Changeset: 89174cddaec8 Author: jfranck Date: 2013-09-30 12:19 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/89174cddaec8 8009719: core reflection should get type annotation data from the VM lazily Summary: Remove typeAnnotations field from Method, Constructor, and Field, update Executable and Field to fetch data on demand. Reviewed-by: darcy, erikj ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/javavm/export/jvm.h ! src/share/native/java/lang/reflect/Executable.c + src/share/native/java/lang/reflect/Field.c Changeset: cceaad499685 Author: sla Date: 2013-09-30 12:58 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cceaad499685 8023492: jfr.jar gets loaded even though it's not used Reviewed-by: erikj, mgronlun ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java Changeset: ede1fd12e0da Author: allwin Date: 2013-09-30 14:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ede1fd12e0da 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c Reviewed-by: chegar, sla, sspitsyn, mgronlun ! src/windows/demo/jvmti/hprof/hprof_md.c Changeset: d0de46a2cbd0 Author: ascarpino Date: 2013-09-19 11:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d0de46a2cbd0 7122707: Security Providers need to have their version numbers updated for JDK8 Reviewed-by: xuelei ! src/macosx/classes/apple/security/AppleProvider.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/com/sun/security/sasl/Provider.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java ! src/share/classes/sun/security/ec/SunEC.java ! src/share/classes/sun/security/jgss/SunProvider.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/share/classes/sun/security/provider/MD4.java ! src/share/classes/sun/security/provider/Sun.java ! src/share/classes/sun/security/provider/VerificationProvider.java ! src/share/classes/sun/security/rsa/SunRsaSign.java ! src/share/classes/sun/security/smartcardio/SunPCSC.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java + test/java/security/Provider/ProviderVersionCheck.java Changeset: 2434e79fc41f Author: ascarpino Date: 2013-09-18 14:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2434e79fc41f 8004283: test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failing intermittently Reviewed-by: vinnie ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh Changeset: e4c897b33cb7 Author: ascarpino Date: 2013-09-02 09:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e4c897b33cb7 8009438: sun/security/pkcs11/Secmod tests failing on Ubuntu 12.04 Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/Secmod.java Changeset: b4c259743371 Author: naoto Date: 2013-09-30 16:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b4c259743371 8016110: Japanese char (MS932) 0x5C cannot be used as an argument when quoted Reviewed-by: ksrini, akhil ! src/windows/bin/cmdtoargs.c + test/tools/launcher/I18NArgTest.java Changeset: f8b3ab514564 Author: psandoz Date: 2013-10-01 12:19 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f8b3ab514564 8024408: Specifications for Collection/List/Set/SortedSet.spliterator() need to document if all the (subclass) instances are required to return SIZED spliterators Reviewed-by: alanb ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Set.java ! src/share/classes/java/util/SortedSet.java ! test/java/util/Spliterator/SpliteratorCharacteristics.java Changeset: bf52ea6bd9eb Author: aefimov Date: 2013-10-01 17:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bf52ea6bd9eb 8024707: TransformerException : item() return null with node list of length != 1 Reviewed-by: joehw, lancea + test/javax/xml/jaxp/parsers/8024707/TestFunc.java + test/javax/xml/jaxp/parsers/8024707/XSLT.java + test/javax/xml/jaxp/parsers/8024707/in.xml + test/javax/xml/jaxp/parsers/8024707/test.xsl Changeset: 8cfb2bddd95e Author: mduigou Date: 2013-09-30 15:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8cfb2bddd95e 7057785: Add note about optional support of recursive methods for self-referential Collection/Map Reviewed-by: scolebourne, darcy, mduigou Contributed-by: Stephen Colebourne ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Map.java Changeset: f2e2326f787b Author: mduigou Date: 2013-10-01 10:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f2e2326f787b 8025067: Unconditionally throw NPE if null op provided to Arrays.parallelPrefix Reviewed-by: henryjen, chegar, psandoz ! src/share/classes/java/util/Arrays.java ! test/java/util/Arrays/ParallelPrefix.java Changeset: c32ab940a183 Author: mduigou Date: 2013-10-01 10:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c32ab940a183 8025686: Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8 support Reviewed-by: lancea, chegar ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent Changeset: 5a7bd9825c01 Author: vlivanov Date: 2013-09-23 19:51 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5a7bd9825c01 8001107: @Stable annotation for constant folding of lazily evaluated variables Reviewed-by: twisti, kvn, rbackman Contributed-by: john.r.rose at oracle.com, vladimir.x.ivanov at oracle.com ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java + src/share/classes/java/lang/invoke/Stable.java Changeset: 1ed675532589 Author: vlivanov Date: 2013-09-18 20:12 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ed675532589 8024616: JSR292: lazily initialize core NamedFunctions used for bootstrapping Reviewed-by: jrose ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java Changeset: bf1118ab775b Author: emc Date: 2013-10-01 17:35 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bf1118ab775b 8021398: j.l.r.Parameter.getAnnotatedType().getType() for not annotated use of type returns null Summary: Fixed issue with type annotation reflection framework that would cause getType of AnnotatedTypes to be null if no annotations were present. Reviewed-by: darcy, jfranck ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/reflect/Parameter/GetAnnotatedTypeTest.java Changeset: 84e7f6685319 Author: ksrini Date: 2013-10-01 15:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/84e7f6685319 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java Reviewed-by: naoto, mfang ! src/share/classes/com/sun/java/util/jar/pack/Driver.java ! src/share/classes/com/sun/java/util/jar/pack/DriverResource.java Changeset: d90928a89af5 Author: drchase Date: 2013-09-27 13:32 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d90928a89af5 8022701: Accessibility checking: InvocationTargetException is thrown instead of IllegalAccessError Summary: Inserted code to convert specific exceptions, case-by-case, plus a test. Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + test/java/lang/invoke/8022701/BogoLoader.java + test/java/lang/invoke/8022701/InvokeSeveralWays.java + test/java/lang/invoke/8022701/Invoker.java + test/java/lang/invoke/8022701/MHIllegalAccess.java + test/java/lang/invoke/8022701/MethodSupplier.java Changeset: 3fca37c636be Author: xuelei Date: 2013-10-01 20:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3fca37c636be 8025123: SNI support in Kerberos cipher suites Reviewed-by: weijun, xuelei Contributed-by: Artem Smotrakov ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java ! src/share/classes/sun/security/ssl/krb5/KerberosClientKeyExchangeImpl.java ! test/sun/security/krb5/auto/SSL.java Changeset: 914c29c10bce Author: okutsu Date: 2013-10-02 15:31 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/914c29c10bce 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010 Reviewed-by: peytoia ! src/share/classes/java/util/GregorianCalendar.java + test/java/util/Calendar/Bug6902861.java Changeset: 368172cb6dc5 Author: coffeys Date: 2013-10-02 09:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/368172cb6dc5 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl Reviewed-by: chegar ! src/windows/classes/java/net/PlainSocketImpl.java + test/java/net/PlainSocketImpl/CustomSocketImplFactory.java Changeset: 82e3150778e0 Author: okutsu Date: 2013-10-02 17:57 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/82e3150778e0 8022666: java.util.Calendar.set(int,int,int,int,int,int) documentation typo Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java Changeset: e1b04fd49204 Author: psandoz Date: 2013-10-01 18:20 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e1b04fd49204 8025535: Unsafe typecast in java.util.stream.SortedOps Reviewed-by: mduigou, chegar ! src/share/classes/java/util/stream/SortedOps.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java Changeset: 3bb89c509d59 Author: egahlin Date: 2013-10-01 17:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3bb89c509d59 6696975: JTop plugin fails if connected readonly to target JVM Reviewed-by: mchung, jbachorik, sla, sjiang ! src/share/demo/management/JTop/JTop.java Changeset: a6ac824b463d Author: wetmore Date: 2013-10-02 09:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a6ac824b463d 8025694: Rename getStrongSecureRandom based on feedback 8014838: getStrongSecureRandom() should require at least one implementation Reviewed-by: mullan, darcy ! src/share/classes/java/security/SecureRandom.java ! src/share/lib/security/java.security-windows ! test/sun/security/provider/SecureRandom/StrongSecureRandom.java Changeset: cb8946eda85b Author: emc Date: 2013-10-02 19:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cb8946eda85b 8020981: Update methods of java.lang.reflect.Parameter to throw correct exceptions Summary: Fix behavior of parameter reflection API for malformed class files. Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java + src/share/classes/java/lang/reflect/MalformedParametersException.java ! src/share/classes/java/lang/reflect/Parameter.java + test/java/lang/reflect/Parameter/BadClassFiles.java Changeset: 811c35a6a58f Author: psandoz Date: 2013-10-02 16:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/811c35a6a58f 8025534: Unsafe typecast in java.util.stream.Streams.Nodes 8025538: Unsafe typecast in java.util.stream.SpinedBuffer 8025533: Unsafe typecast in java.util.stream.Streams.RangeIntSpliterator.splitPoint() 8025525: Unsafe typecast in java.util.stream.Node.OfPrimitive.asArray() Reviewed-by: chegar ! src/share/classes/java/util/stream/Node.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/SortedOps.java ! src/share/classes/java/util/stream/SpinedBuffer.java ! src/share/classes/java/util/stream/Streams.java Changeset: c55a7941050c Author: psandoz Date: 2013-10-03 10:59 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c55a7941050c 8025567: Mark relevant public stream tests as serialization hostile Reviewed-by: alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java Changeset: 5d6dc0cba08f Author: dsamersoff Date: 2013-10-03 16:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5d6dc0cba08f 8009213: sun/management/jdp/JdpTest.sh fails with exit code 1 Summary: There's no guarantee that the java process has executed far enough to be found by jps when we try to obtain it's pid. Reviewed-by: sla ! test/sun/management/jdp/JdpTest.sh Changeset: 9c32a9490eac Author: kizune Date: 2013-10-03 17:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9c32a9490eac 8025738: locale related test fails on langtools mac 10.7 test host Reviewed-by: ksrini ! test/tools/launcher/DiacriticTest.java Changeset: 8d8b809dd294 Author: rfield Date: 2013-10-03 10:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8d8b809dd294 8010433: Remove lambda metafactory work-around to JDK-8005119 Summary: Restore invokespecial to lambda metafactory Reviewed-by: ksrini ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java Changeset: 1b3616c4a836 Author: rfield Date: 2013-10-03 11:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1b3616c4a836 8020849: jdk/lambda/vm/DefaultMethodsTest.java Summary: Bridge generation has been removed from the VM. Fix is to remove tests that no longer make sense. Reviewed-by: ksrini ! test/jdk/lambda/vm/DefaultMethodsTest.java Changeset: 01b8604e8268 Author: rriggs Date: 2013-08-22 10:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/01b8604e8268 8024896: Refactor java.time serialization tests into separate subpackage Summary: Move serialization tests to .serial subpackage Reviewed-by: sherman Contributed-by: paul.rank at oracle.com ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java + test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDate.java + test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateTime.java + test/java/time/tck/java/time/chrono/serial/TCKChronologySerialization.java + test/java/time/tck/java/time/serial/TCKDuration.java + test/java/time/tck/java/time/serial/TCKInstant.java + test/java/time/tck/java/time/serial/TCKLocalDate.java + test/java/time/tck/java/time/serial/TCKLocalDateTime.java + test/java/time/tck/java/time/serial/TCKLocalTime.java + test/java/time/tck/java/time/serial/TCKMonthDay.java + test/java/time/tck/java/time/serial/TCKOffsetDateTime.java + test/java/time/tck/java/time/serial/TCKOffsetTime.java + test/java/time/tck/java/time/serial/TCKPeriod.java + test/java/time/tck/java/time/serial/TCKYear.java + test/java/time/tck/java/time/serial/TCKYearMonth.java + test/java/time/tck/java/time/serial/TCKZoneId.java + test/java/time/tck/java/time/serial/TCKZoneOffset.java + test/java/time/tck/java/time/serial/TCKZonedDateTime.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java + test/java/time/tck/java/time/temporal/serial/TCKWeekFields.java ! test/java/time/tck/java/time/zone/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/tck/java/time/zone/serial/TCKFixedZoneRules.java + test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransition.java + test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionRule.java + test/java/time/tck/java/time/zone/serial/TCKZoneRules.java Changeset: e813b58bd6db Author: rriggs Date: 2013-10-03 15:16 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e813b58bd6db 8024427: Missing java.time.chrono serialization tests Summary: Add tests and cleanup existing serialization tests Reviewed-by: sherman ! src/share/classes/java/time/temporal/ValueRange.java ! test/java/time/tck/java/time/AbstractTCKTest.java ! test/java/time/tck/java/time/TCKClock_Fixed.java ! test/java/time/tck/java/time/TCKClock_Offset.java ! test/java/time/tck/java/time/TCKClock_System.java ! test/java/time/tck/java/time/TCKClock_Tick.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKTestServiceLoader.java ! test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateSerialization.java < test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDate.java ! test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateTimeSerialization.java < test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateTime.java + test/java/time/tck/java/time/chrono/serial/TCKChronoZonedDateTimeSerialization.java ! test/java/time/tck/java/time/chrono/serial/TCKChronologySerialization.java + test/java/time/tck/java/time/chrono/serial/TCKCopticSerialization.java + test/java/time/tck/java/time/chrono/serial/TCKEraSerialization.java + test/java/time/tck/java/time/serial/TCKClockSerialization.java ! test/java/time/tck/java/time/serial/TCKDurationSerialization.java < test/java/time/tck/java/time/serial/TCKDuration.java ! test/java/time/tck/java/time/serial/TCKInstantSerialization.java < test/java/time/tck/java/time/serial/TCKInstant.java ! test/java/time/tck/java/time/serial/TCKLocalDateSerialization.java < test/java/time/tck/java/time/serial/TCKLocalDate.java ! test/java/time/tck/java/time/serial/TCKLocalDateTimeSerialization.java < test/java/time/tck/java/time/serial/TCKLocalDateTime.java ! test/java/time/tck/java/time/serial/TCKLocalTimeSerialization.java < test/java/time/tck/java/time/serial/TCKLocalTime.java ! test/java/time/tck/java/time/serial/TCKMonthDaySerialization.java < test/java/time/tck/java/time/serial/TCKMonthDay.java ! test/java/time/tck/java/time/serial/TCKOffsetDateTimeSerialization.java < test/java/time/tck/java/time/serial/TCKOffsetDateTime.java ! test/java/time/tck/java/time/serial/TCKOffsetTimeSerialization.java < test/java/time/tck/java/time/serial/TCKOffsetTime.java ! test/java/time/tck/java/time/serial/TCKPeriodSerialization.java < test/java/time/tck/java/time/serial/TCKPeriod.java ! test/java/time/tck/java/time/serial/TCKYearMonthSerialization.java < test/java/time/tck/java/time/serial/TCKYearMonth.java ! test/java/time/tck/java/time/serial/TCKYearSerialization.java < test/java/time/tck/java/time/serial/TCKYear.java ! test/java/time/tck/java/time/serial/TCKZoneIdSerialization.java < test/java/time/tck/java/time/serial/TCKZoneId.java ! test/java/time/tck/java/time/serial/TCKZoneOffsetSerialization.java < test/java/time/tck/java/time/serial/TCKZoneOffset.java ! test/java/time/tck/java/time/serial/TCKZonedDateTimeSerialization.java < test/java/time/tck/java/time/serial/TCKZonedDateTime.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/tck/java/time/temporal/serial/TCKChronoFieldSerialization.java + test/java/time/tck/java/time/temporal/serial/TCKChronoUnitSerialization.java + test/java/time/tck/java/time/temporal/serial/TCKJulianFieldsSerialization.java + test/java/time/tck/java/time/temporal/serial/TCKValueRangeSerialization.java ! test/java/time/tck/java/time/temporal/serial/TCKWeekFieldsSerialization.java < test/java/time/tck/java/time/temporal/serial/TCKWeekFields.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/serial/TCKFixedZoneRulesSerialization.java < test/java/time/tck/java/time/zone/serial/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionRuleSerialization.java < test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionSerialization.java < test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/serial/TCKZoneRulesSerialization.java < test/java/time/tck/java/time/zone/serial/TCKZoneRules.java ! test/java/time/test/java/time/AbstractTest.java ! test/java/time/test/java/time/TestDuration.java ! test/java/time/test/java/time/temporal/TestDateTimeValueRange.java Changeset: 77ba1e67707c Author: allwin Date: 2013-10-04 15:00 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/77ba1e67707c 8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist Reviewed-by: sla, jbachorik ! test/ProblemList.txt Changeset: b5aad88cbf12 Author: vinnie Date: 2013-10-04 16:05 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b5aad88cbf12 8008296: keytool utility doesn't support '-importpassword' command Reviewed-by: weijun ! src/share/classes/sun/security/tools/keytool/Main.java ! src/share/classes/sun/security/tools/keytool/Resources.java + test/sun/security/tools/keytool/StorePasswords.java + test/sun/security/tools/keytool/StorePasswordsByShell.sh Changeset: 1de0fac9b962 Author: rriggs Date: 2013-08-29 20:38 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1de0fac9b962 8023764: Optimize Period addition Summary: Optimise plus/minus for common cases Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/ZonedDateTime.java Changeset: 356df1b99976 Author: rriggs Date: 2013-08-30 11:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/356df1b99976 8023763: Rename ChronoDateImpl Summary: Rename ChronoDateImpl to ChronoLocalDateImpl Reviewed-by: sherman Contributed-by: scolebourne at joda.org - src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java + src/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java Changeset: 5d73f7a2db51 Author: rriggs Date: 2013-09-04 15:18 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5d73f7a2db51 8023762: Add ChronoPeriod interface and bind period to Chronology Summary: Make Period ISO-only, adding a Chronology-specific period concept Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java + src/share/classes/java/time/chrono/ChronoPeriod.java + src/share/classes/java/time/chrono/ChronoPeriodImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/temporal/Temporal.java ! test/java/time/tck/java/time/TCKPeriod.java + test/java/time/tck/java/time/chrono/TCKChronoPeriod.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKMinguoChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java Changeset: 79077f1641cc Author: rriggs Date: 2013-09-14 22:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/79077f1641cc 8024835: Change until() to accept any compatible temporal Summary: Method until(Temporal,TemporalUnit) now uses from() to convert; Enhance from() methods where necessary Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/temporal/TCKIsoFields.java Changeset: 14a187dc4ffe Author: rriggs Date: 2013-10-04 12:01 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/14a187dc4ffe 8024999: Instant.Parse typo in example Summary: javadoc only fix to correct example to use "." and "Z" Reviewed-by: sherman ! src/share/classes/java/time/Instant.java Changeset: f9c701ba04e7 Author: rriggs Date: 2013-09-14 22:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f9c701ba04e7 8024807: Add getChronlogy() to CLDT/CZDT Summary: Alternative to method is clunky and hard to find Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java Changeset: e12b912ab98e Author: rriggs Date: 2013-09-14 22:54 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e12b912ab98e 8024834: Better return type for TemporalField resolve Summary: Allow resolve method to return more than just ChronoLocalDate Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/TemporalField.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java Changeset: 7736abdf0805 Author: rfield Date: 2013-10-04 09:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7736abdf0805 8021186: jdk/lambda/vm/DefaultMethodsTest.java fails Summary: remove DefaultMethodsTest from jdk/test/problemList.txt Reviewed-by: mduigou ! test/ProblemList.txt Changeset: 66181f7991bd Author: bpatel Date: 2013-10-04 15:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/66181f7991bd 8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8. Reviewed-by: tbell ! make/docs/Makefile Changeset: 7d2112abbb1d Author: coffeys Date: 2013-10-04 16:27 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7d2112abbb1d 8016271: wsimport -clientjar does not create portable jars on Windows due to hardcoded backslash Reviewed-by: mkos, chegar + test/javax/xml/ws/clientjar/TestService.java + test/javax/xml/ws/clientjar/TestWsImport.java Changeset: 44da760eed4b Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/44da760eed4b 8024761: JSR 292 improve performance of generic invocation Summary: use a per-MH one element cache for MH.asType to speed up MH.invoke; also cache enough MH constants to cache LMF.metafactory Reviewed-by: twisti ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java - src/share/classes/java/lang/invoke/InvokeGeneric.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java Changeset: 97d5cc1e7586 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/97d5cc1e7586 8001105: findVirtual of Object[].clone produces internal error Summary: Replicate JVM logic for access control that makes Object.clone appear public when applied to an array type. Reviewed-by: twisti ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 91535ade7349 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/91535ade7349 8019417: JSR 292 javadoc should clarify method handle arity limits Summary: clarification of erroneous reading of spec. that led to 7194534 Reviewed-by: twisti, darcy ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/BigArityTest.java Changeset: d391e062b983 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d391e062b983 8001109: arity mismatch on a call to spreader method handle should elicit IllegalArgumentException Summary: Document error conditions that may occur when calling a "spreader" method handle. Use IAE in all cases. Reviewed-by: twisti, vlivanov ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/JavaDocExamplesTest.java Changeset: acdf5bf1a918 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/acdf5bf1a918 8001108: an attempt to use "" as a method name should elicit NoSuchMethodException Summary: add an explicit check for leading "<", upgrade the unit tests Reviewed-by: twisti, darcy ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: df6236da299d Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/df6236da299d 8024599: JSR 292 direct method handles need to respect initialization rules for static members Summary: Align MH semantic with bytecode behavior of constructor and static member accesses, regarding invocation. Reviewed-by: twisti, darcy, abuckley, vlivanov ! src/share/classes/java/lang/invoke/MethodHandles.java + test/java/lang/invoke/CallStaticInitOrder.java Changeset: eb3cfc69c16e Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eb3cfc69c16e 8001110: method handles should have a collectArguments transform, generalizing asCollector Summary: promote an existing private method; make unit tests on all argument positions to arity 10 with mixed types Reviewed-by: twisti, vlivanov ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: b670477bff8f Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b670477bff8f 8025112: JSR 292 spec updates for security manager and caller sensitivity Summary: align CONSTANT_MethodHandle and Lookup.find* API calls, clarify security manager & @CallerSensitive interactions Reviewed-by: mchung, twisti ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/TestPrivateMember.java Changeset: 6623c675e734 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6623c675e734 8024438: JSR 292 API specification maintenance for JDK 8 Summary: add wildcard to unreflectConstructor, various clarifications and minor edits Reviewed-by: mchung, darcy, twisti ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MutableCallSite.java ! src/share/classes/java/lang/invoke/SwitchPoint.java ! src/share/classes/sun/invoke/WrapperInstance.java ! src/share/classes/sun/invoke/util/VerifyAccess.java ! src/share/classes/sun/invoke/util/VerifyType.java ! test/java/lang/invoke/AccessControlTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/RevealDirectTest.java Changeset: 0ac9dc315071 Author: alanb Date: 2013-10-07 11:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0ac9dc315071 8025983: Typo in Javadoc of Files.isRegularFile() Reviewed-by: mchung, chegar ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java Changeset: f0ad3e2918b4 Author: henryjen Date: 2013-10-07 11:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f0ad3e2918b4 8025968: Integrate test improvements made in lambda repo Reviewed-by: psandoz ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java Changeset: 0cffe1dab0bf Author: henryjen Date: 2013-10-07 15:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0cffe1dab0bf 8026009: Changes for 8025968 break all stream tests Reviewed-by: mduigou ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java Changeset: 0d5f4f1782e8 Author: xuelei Date: 2013-10-07 18:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0d5f4f1782e8 6956398: make ephemeral DH key match the length of the certificate key Reviewed-by: weijun ! src/share/classes/sun/security/ssl/ServerHandshaker.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/DHKeyExchange/DHEKeySizing.java Changeset: b90dcd1a71bf Author: psandoz Date: 2013-10-08 11:17 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b90dcd1a71bf 8025136: SplittableRandom enchancements Reviewed-by: psandoz, martin Contributed-by: Doug Lea
, Guy Steele ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/SplittableRandom.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java Changeset: 95bb56c61276 Author: alanb Date: 2013-10-08 10:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/95bb56c61276 8024788: (fs) Files.readAllBytes uses FileChannel which may not be supported by all providers Reviewed-by: chegar ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/BytesAndLines.java Changeset: 748207aa9620 Author: lana Date: 2013-10-08 14:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/748207aa9620 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java Changeset: 575d4bc3bcae Author: lana Date: 2013-10-11 03:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/575d4bc3bcae Merge ! makefiles/CreateJars.gmk - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java Changeset: 28191d3ff921 Author: erikj Date: 2013-10-09 16:22 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/28191d3ff921 8026144: Missing mkdir in Images.gmk Reviewed-by: tbell ! makefiles/Images.gmk Changeset: 86df2e879eca Author: tbell Date: 2013-10-09 18:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/86df2e879eca 8023611: Win32 and win64: Remove all the WARNINGS in JDK 8 builds for Windows 2008 and MSVS 2010 SP1 Reviewed-by: erikj ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-versions.gmk ! make/common/shared/Sanity.gmk Changeset: 98d98ec01f07 Author: tbell Date: 2013-10-09 23:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/98d98ec01f07 Merge Changeset: 9c60860b1812 Author: ihse Date: 2013-10-10 15:06 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9c60860b1812 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJdk.gmk ! makefiles/Bundles.gmk ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CopySamples.gmk ! makefiles/CreateJars.gmk ! makefiles/GendataBreakIterator.gmk ! makefiles/GendataFontConfig.gmk ! makefiles/GendataHtml32dtd.gmk ! makefiles/GendataTZDB.gmk ! makefiles/GendataTimeZone.gmk ! makefiles/GenerateClasses.gmk ! makefiles/GenerateData.gmk ! makefiles/GenerateJavaSources.gmk ! makefiles/GensrcBuffer.gmk ! makefiles/GensrcCLDR.gmk ! makefiles/GensrcCharacterData.gmk ! makefiles/GensrcCharsetCoder.gmk ! makefiles/GensrcCharsetMapping.gmk ! makefiles/GensrcExceptions.gmk ! makefiles/GensrcIcons.gmk ! makefiles/GensrcJDWP.gmk ! makefiles/GensrcJObjC.gmk ! makefiles/GensrcLocaleDataMetaInfo.gmk ! makefiles/GensrcMisc.gmk ! makefiles/GensrcProperties.gmk ! makefiles/GensrcSwing.gmk ! makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Import.gmk ! makefiles/Makefile ! makefiles/PatchList.solaris ! makefiles/ProfileNames.gmk ! makefiles/Profiles.gmk ! makefiles/Setup.gmk ! makefiles/SignJars.gmk ! makefiles/Tools.gmk ! makefiles/jpda/jdwp/jdwp.spec ! makefiles/jprt.gmk ! makefiles/jprt.properties ! makefiles/mapfiles/libawt/mapfile-mawt-vers ! makefiles/mapfiles/libawt/mapfile-vers ! makefiles/mapfiles/libawt/mapfile-vers-linux ! makefiles/mapfiles/libawt_headless/mapfile-vers ! makefiles/mapfiles/libawt_xawt/mapfile-vers ! makefiles/mapfiles/libfontmanager/mapfile-vers ! makefiles/mapfiles/libfontmanager/mapfile-vers.openjdk ! makefiles/mapfiles/libj2pcsc/mapfile-vers ! makefiles/mapfiles/libjdga/mapfile-vers ! makefiles/mapfiles/libjli/mapfile-vers ! makefiles/mapfiles/libverify/mapfile-vers ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt ! makefiles/scripts/addNotices.sh ! makefiles/scripts/genCharsetProvider.sh ! makefiles/scripts/genExceptions.sh ! makefiles/scripts/localelist.sh ! makefiles/sun/awt/ToBin.java Changeset: cf3ee0e2c1a5 Author: erikj Date: 2013-10-14 11:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cf3ee0e2c1a5 8025612: rt.jar still has old specification value in the manifest Reviewed-by: alanb, dholmes, tbell, wetmore ! make/tools/manifest.mf Changeset: 986acae7efe9 Author: ihse Date: 2013-10-15 13:06 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/986acae7efe9 8001933: Move Gensrc*.gmk and Gendata*.gmk into separate directories. Reviewed-by: erikj, tbell ! makefiles/BuildJdk.gmk ! makefiles/CreateJars.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk ! makefiles/GenerateData.gmk - makefiles/GenerateJavaSources.gmk + makefiles/GenerateSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk + makefiles/gendata/GendataBreakIterator.gmk + makefiles/gendata/GendataFontConfig.gmk + makefiles/gendata/GendataHtml32dtd.gmk + makefiles/gendata/GendataTZDB.gmk + makefiles/gendata/GendataTimeZone.gmk + makefiles/gensrc/GensrcBuffer.gmk + makefiles/gensrc/GensrcCLDR.gmk + makefiles/gensrc/GensrcCharacterData.gmk + makefiles/gensrc/GensrcCharsetCoder.gmk + makefiles/gensrc/GensrcCharsetMapping.gmk + makefiles/gensrc/GensrcExceptions.gmk + makefiles/gensrc/GensrcIcons.gmk + makefiles/gensrc/GensrcJDWP.gmk + makefiles/gensrc/GensrcJObjC.gmk + makefiles/gensrc/GensrcLocaleDataMetaInfo.gmk + makefiles/gensrc/GensrcMisc.gmk + makefiles/gensrc/GensrcProperties.gmk + makefiles/gensrc/GensrcSwing.gmk + makefiles/gensrc/GensrcX11Wrappers.gmk Changeset: eef656e1bdeb Author: ksrini Date: 2013-10-16 07:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eef656e1bdeb 8026500: [infra] remove extraneous docs in solaris images Reviewed-by: erikj, mchung, tbell ! makefiles/Images.gmk - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 Changeset: f002f5f3a16c Author: katleman Date: 2013-10-16 12:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f002f5f3a16c Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 Changeset: bef8f6d429de Author: cl Date: 2013-10-17 09:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bef8f6d429de Added tag jdk8-b112 for changeset f002f5f3a16c ! .hgtags Changeset: f1e31376f419 Author: robm Date: 2013-10-09 00:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f1e31376f419 7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX webbugs Reviewed-by: chegar, dsamersoff ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 2ea162b2ff55 Author: alanb Date: 2013-10-09 09:20 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2ea162b2ff55 8008662: Add @jdk.Exported to JDK-specific/exported APIs Reviewed-by: chegar, vinnie, dfuchs, mchung, mullan, darcy ! src/share/classes/com/sun/jdi/AbsentInformationException.java ! src/share/classes/com/sun/jdi/Accessible.java ! src/share/classes/com/sun/jdi/ArrayReference.java ! src/share/classes/com/sun/jdi/ArrayType.java ! src/share/classes/com/sun/jdi/BooleanType.java ! src/share/classes/com/sun/jdi/BooleanValue.java ! src/share/classes/com/sun/jdi/Bootstrap.java ! src/share/classes/com/sun/jdi/ByteType.java ! src/share/classes/com/sun/jdi/ByteValue.java ! src/share/classes/com/sun/jdi/CharType.java ! src/share/classes/com/sun/jdi/CharValue.java ! src/share/classes/com/sun/jdi/ClassLoaderReference.java ! src/share/classes/com/sun/jdi/ClassNotLoadedException.java ! src/share/classes/com/sun/jdi/ClassNotPreparedException.java ! src/share/classes/com/sun/jdi/ClassObjectReference.java ! src/share/classes/com/sun/jdi/ClassType.java ! src/share/classes/com/sun/jdi/DoubleType.java ! src/share/classes/com/sun/jdi/DoubleValue.java ! src/share/classes/com/sun/jdi/Field.java ! src/share/classes/com/sun/jdi/FloatType.java ! src/share/classes/com/sun/jdi/FloatValue.java ! src/share/classes/com/sun/jdi/IncompatibleThreadStateException.java ! src/share/classes/com/sun/jdi/InconsistentDebugInfoException.java ! src/share/classes/com/sun/jdi/IntegerType.java ! src/share/classes/com/sun/jdi/IntegerValue.java ! src/share/classes/com/sun/jdi/InterfaceType.java ! src/share/classes/com/sun/jdi/InternalException.java ! src/share/classes/com/sun/jdi/InvalidCodeIndexException.java ! src/share/classes/com/sun/jdi/InvalidLineNumberException.java ! src/share/classes/com/sun/jdi/InvalidStackFrameException.java ! src/share/classes/com/sun/jdi/InvalidTypeException.java ! src/share/classes/com/sun/jdi/InvocationException.java ! src/share/classes/com/sun/jdi/JDIPermission.java ! src/share/classes/com/sun/jdi/LocalVariable.java ! src/share/classes/com/sun/jdi/Locatable.java ! src/share/classes/com/sun/jdi/Location.java ! src/share/classes/com/sun/jdi/LongType.java ! src/share/classes/com/sun/jdi/LongValue.java ! src/share/classes/com/sun/jdi/Method.java ! src/share/classes/com/sun/jdi/Mirror.java ! src/share/classes/com/sun/jdi/MonitorInfo.java ! src/share/classes/com/sun/jdi/NativeMethodException.java ! src/share/classes/com/sun/jdi/ObjectCollectedException.java ! src/share/classes/com/sun/jdi/ObjectReference.java ! src/share/classes/com/sun/jdi/PathSearchingVirtualMachine.java ! src/share/classes/com/sun/jdi/PrimitiveType.java ! src/share/classes/com/sun/jdi/PrimitiveValue.java ! src/share/classes/com/sun/jdi/ReferenceType.java ! src/share/classes/com/sun/jdi/ShortType.java ! src/share/classes/com/sun/jdi/ShortValue.java ! src/share/classes/com/sun/jdi/StackFrame.java ! src/share/classes/com/sun/jdi/StringReference.java ! src/share/classes/com/sun/jdi/ThreadGroupReference.java ! src/share/classes/com/sun/jdi/ThreadReference.java ! src/share/classes/com/sun/jdi/Type.java ! src/share/classes/com/sun/jdi/TypeComponent.java ! src/share/classes/com/sun/jdi/VMCannotBeModifiedException.java ! src/share/classes/com/sun/jdi/VMDisconnectedException.java ! src/share/classes/com/sun/jdi/VMMismatchException.java ! src/share/classes/com/sun/jdi/VMOutOfMemoryException.java ! src/share/classes/com/sun/jdi/Value.java ! src/share/classes/com/sun/jdi/VirtualMachine.java ! src/share/classes/com/sun/jdi/VirtualMachineManager.java ! src/share/classes/com/sun/jdi/VoidType.java ! src/share/classes/com/sun/jdi/VoidValue.java ! src/share/classes/com/sun/jdi/connect/AttachingConnector.java ! src/share/classes/com/sun/jdi/connect/Connector.java ! src/share/classes/com/sun/jdi/connect/IllegalConnectorArgumentsException.java ! src/share/classes/com/sun/jdi/connect/LaunchingConnector.java ! src/share/classes/com/sun/jdi/connect/ListeningConnector.java ! src/share/classes/com/sun/jdi/connect/Transport.java ! src/share/classes/com/sun/jdi/connect/TransportTimeoutException.java ! src/share/classes/com/sun/jdi/connect/VMStartException.java + src/share/classes/com/sun/jdi/connect/package-info.java - src/share/classes/com/sun/jdi/connect/package.html ! src/share/classes/com/sun/jdi/connect/spi/ClosedConnectionException.java ! src/share/classes/com/sun/jdi/connect/spi/Connection.java ! src/share/classes/com/sun/jdi/connect/spi/TransportService.java + src/share/classes/com/sun/jdi/connect/spi/package-info.java - src/share/classes/com/sun/jdi/connect/spi/package.html ! src/share/classes/com/sun/jdi/event/AccessWatchpointEvent.java ! src/share/classes/com/sun/jdi/event/BreakpointEvent.java ! src/share/classes/com/sun/jdi/event/ClassPrepareEvent.java ! src/share/classes/com/sun/jdi/event/ClassUnloadEvent.java ! src/share/classes/com/sun/jdi/event/Event.java ! src/share/classes/com/sun/jdi/event/EventIterator.java ! src/share/classes/com/sun/jdi/event/EventQueue.java ! src/share/classes/com/sun/jdi/event/EventSet.java ! src/share/classes/com/sun/jdi/event/ExceptionEvent.java ! src/share/classes/com/sun/jdi/event/LocatableEvent.java ! src/share/classes/com/sun/jdi/event/MethodEntryEvent.java ! src/share/classes/com/sun/jdi/event/MethodExitEvent.java ! src/share/classes/com/sun/jdi/event/ModificationWatchpointEvent.java ! src/share/classes/com/sun/jdi/event/MonitorContendedEnterEvent.java ! src/share/classes/com/sun/jdi/event/MonitorContendedEnteredEvent.java ! src/share/classes/com/sun/jdi/event/MonitorWaitEvent.java ! src/share/classes/com/sun/jdi/event/MonitorWaitedEvent.java ! src/share/classes/com/sun/jdi/event/StepEvent.java ! src/share/classes/com/sun/jdi/event/ThreadDeathEvent.java ! src/share/classes/com/sun/jdi/event/ThreadStartEvent.java ! src/share/classes/com/sun/jdi/event/VMDeathEvent.java ! src/share/classes/com/sun/jdi/event/VMDisconnectEvent.java ! src/share/classes/com/sun/jdi/event/VMStartEvent.java ! src/share/classes/com/sun/jdi/event/WatchpointEvent.java + src/share/classes/com/sun/jdi/event/package-info.java - src/share/classes/com/sun/jdi/event/package.html + src/share/classes/com/sun/jdi/package-info.java - src/share/classes/com/sun/jdi/package.html ! src/share/classes/com/sun/jdi/request/AccessWatchpointRequest.java ! src/share/classes/com/sun/jdi/request/BreakpointRequest.java ! src/share/classes/com/sun/jdi/request/ClassPrepareRequest.java ! src/share/classes/com/sun/jdi/request/ClassUnloadRequest.java ! src/share/classes/com/sun/jdi/request/DuplicateRequestException.java ! src/share/classes/com/sun/jdi/request/EventRequest.java ! src/share/classes/com/sun/jdi/request/EventRequestManager.java ! src/share/classes/com/sun/jdi/request/ExceptionRequest.java ! src/share/classes/com/sun/jdi/request/InvalidRequestStateException.java ! src/share/classes/com/sun/jdi/request/MethodEntryRequest.java ! src/share/classes/com/sun/jdi/request/MethodExitRequest.java ! src/share/classes/com/sun/jdi/request/ModificationWatchpointRequest.java ! src/share/classes/com/sun/jdi/request/MonitorContendedEnterRequest.java ! src/share/classes/com/sun/jdi/request/MonitorContendedEnteredRequest.java ! src/share/classes/com/sun/jdi/request/MonitorWaitRequest.java ! src/share/classes/com/sun/jdi/request/MonitorWaitedRequest.java ! src/share/classes/com/sun/jdi/request/StepRequest.java ! src/share/classes/com/sun/jdi/request/ThreadDeathRequest.java ! src/share/classes/com/sun/jdi/request/ThreadStartRequest.java ! src/share/classes/com/sun/jdi/request/VMDeathRequest.java ! src/share/classes/com/sun/jdi/request/WatchpointRequest.java + src/share/classes/com/sun/jdi/request/package-info.java - src/share/classes/com/sun/jdi/request/package.html ! src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java ! src/share/classes/com/sun/management/GarbageCollectorMXBean.java ! src/share/classes/com/sun/management/GcInfo.java ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/com/sun/management/OperatingSystemMXBean.java ! src/share/classes/com/sun/management/ThreadMXBean.java ! src/share/classes/com/sun/management/UnixOperatingSystemMXBean.java ! src/share/classes/com/sun/management/VMOption.java + src/share/classes/com/sun/management/package-info.java - src/share/classes/com/sun/management/package.html ! src/share/classes/com/sun/net/httpserver/Authenticator.java ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/com/sun/net/httpserver/Filter.java ! src/share/classes/com/sun/net/httpserver/Headers.java ! src/share/classes/com/sun/net/httpserver/HttpContext.java ! src/share/classes/com/sun/net/httpserver/HttpExchange.java ! src/share/classes/com/sun/net/httpserver/HttpHandler.java ! src/share/classes/com/sun/net/httpserver/HttpPrincipal.java ! src/share/classes/com/sun/net/httpserver/HttpServer.java ! src/share/classes/com/sun/net/httpserver/HttpsConfigurator.java ! src/share/classes/com/sun/net/httpserver/HttpsExchange.java ! src/share/classes/com/sun/net/httpserver/HttpsParameters.java ! src/share/classes/com/sun/net/httpserver/HttpsServer.java ! src/share/classes/com/sun/net/httpserver/package-info.java ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/com/sun/net/httpserver/spi/package-info.java ! src/share/classes/com/sun/nio/sctp/AbstractNotificationHandler.java ! src/share/classes/com/sun/nio/sctp/Association.java ! src/share/classes/com/sun/nio/sctp/AssociationChangeNotification.java ! src/share/classes/com/sun/nio/sctp/HandlerResult.java ! src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java ! src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java ! src/share/classes/com/sun/nio/sctp/InvalidStreamException.java ! src/share/classes/com/sun/nio/sctp/MessageInfo.java ! src/share/classes/com/sun/nio/sctp/Notification.java ! src/share/classes/com/sun/nio/sctp/NotificationHandler.java ! src/share/classes/com/sun/nio/sctp/PeerAddressChangeNotification.java ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/com/sun/nio/sctp/SctpMultiChannel.java ! src/share/classes/com/sun/nio/sctp/SctpServerChannel.java ! src/share/classes/com/sun/nio/sctp/SctpSocketOption.java ! src/share/classes/com/sun/nio/sctp/SctpStandardSocketOptions.java ! src/share/classes/com/sun/nio/sctp/SendFailedNotification.java ! src/share/classes/com/sun/nio/sctp/ShutdownNotification.java ! src/share/classes/com/sun/nio/sctp/package-info.java ! src/share/classes/com/sun/security/auth/LdapPrincipal.java ! src/share/classes/com/sun/security/auth/NTDomainPrincipal.java ! src/share/classes/com/sun/security/auth/NTNumericCredential.java ! src/share/classes/com/sun/security/auth/NTSid.java ! src/share/classes/com/sun/security/auth/NTSidDomainPrincipal.java ! src/share/classes/com/sun/security/auth/NTSidGroupPrincipal.java ! src/share/classes/com/sun/security/auth/NTSidPrimaryGroupPrincipal.java ! src/share/classes/com/sun/security/auth/NTSidUserPrincipal.java ! src/share/classes/com/sun/security/auth/NTUserPrincipal.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/PrincipalComparator.java ! src/share/classes/com/sun/security/auth/SolarisNumericGroupPrincipal.java ! src/share/classes/com/sun/security/auth/SolarisNumericUserPrincipal.java ! src/share/classes/com/sun/security/auth/SolarisPrincipal.java ! src/share/classes/com/sun/security/auth/UnixNumericGroupPrincipal.java ! src/share/classes/com/sun/security/auth/UnixNumericUserPrincipal.java ! src/share/classes/com/sun/security/auth/UnixPrincipal.java ! src/share/classes/com/sun/security/auth/UserPrincipal.java ! src/share/classes/com/sun/security/auth/X500Principal.java ! src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java ! src/share/classes/com/sun/security/auth/callback/TextCallbackHandler.java + src/share/classes/com/sun/security/auth/callback/package-info.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java + src/share/classes/com/sun/security/auth/login/package-info.java ! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java ! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/com/sun/security/auth/module/LdapLoginModule.java ! src/share/classes/com/sun/security/auth/module/NTLoginModule.java ! src/share/classes/com/sun/security/auth/module/NTSystem.java ! src/share/classes/com/sun/security/auth/module/SolarisLoginModule.java ! src/share/classes/com/sun/security/auth/module/SolarisSystem.java ! src/share/classes/com/sun/security/auth/module/UnixLoginModule.java ! src/share/classes/com/sun/security/auth/module/UnixSystem.java + src/share/classes/com/sun/security/auth/module/package-info.java + src/share/classes/com/sun/security/auth/package-info.java ! src/share/classes/com/sun/security/jgss/AuthorizationDataEntry.java ! src/share/classes/com/sun/security/jgss/ExtendedGSSContext.java ! src/share/classes/com/sun/security/jgss/ExtendedGSSCredential.java ! src/share/classes/com/sun/security/jgss/GSSUtil.java ! src/share/classes/com/sun/security/jgss/InquireSecContextPermission.java ! src/share/classes/com/sun/security/jgss/InquireType.java + src/share/classes/com/sun/security/jgss/package-info.java ! src/share/classes/com/sun/tools/attach/AgentInitializationException.java ! src/share/classes/com/sun/tools/attach/AgentLoadException.java ! src/share/classes/com/sun/tools/attach/AttachNotSupportedException.java ! src/share/classes/com/sun/tools/attach/AttachPermission.java ! src/share/classes/com/sun/tools/attach/VirtualMachine.java ! src/share/classes/com/sun/tools/attach/VirtualMachineDescriptor.java + src/share/classes/com/sun/tools/attach/package-info.java - src/share/classes/com/sun/tools/attach/package.html ! src/share/classes/com/sun/tools/attach/spi/AttachProvider.java + src/share/classes/com/sun/tools/attach/spi/package-info.java - src/share/classes/com/sun/tools/attach/spi/package.html ! src/share/classes/com/sun/tools/jconsole/JConsoleContext.java ! src/share/classes/com/sun/tools/jconsole/JConsolePlugin.java + src/share/classes/com/sun/tools/jconsole/package-info.java - src/share/classes/com/sun/tools/jconsole/package.html ! src/solaris/classes/com/sun/management/OSMBeanFactory.java Changeset: 91a752e3d50b Author: vinnie Date: 2013-10-09 10:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/91a752e3d50b 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class Reviewed-by: mullan, weijun + src/share/classes/java/security/DomainLoadStoreParameter.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/sun/security/provider/DomainKeyStore.java ! test/sun/security/provider/KeyStore/DKSTest.java Changeset: 1cd20806fd5c Author: psandoz Date: 2013-10-09 15:19 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1cd20806fd5c 8020061: Clarify reporting characteristics between splits Reviewed-by: alanb, chegar ! src/share/classes/java/util/Spliterator.java Changeset: cf6e39cfdf50 Author: mchung Date: 2013-10-09 06:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cf6e39cfdf50 8026027: Level.parse should return the custom Level instance instead of the mirrored Level Reviewed-by: dfuchs, chegar ! src/share/classes/java/util/logging/Level.java + test/java/util/logging/Level/CustomLevel.java + test/java/util/logging/Level/myresource.properties Changeset: e3b70e601c1c Author: rriggs Date: 2013-10-09 11:02 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e3b70e601c1c 8024612: java/time/tck/java/time/format/TCKDateTimeFormatters.java failed Summary: The test should be using the Locale.Category.FORMAT to verify the test data Reviewed-by: lancea ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java Changeset: 09e2a73aa1dc Author: rriggs Date: 2013-09-26 15:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/09e2a73aa1dc 8025718: Enhance error messages for parsing Summary: Add values and types to exception messages Reviewed-by: lancea Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/format/Parsed.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java Changeset: c070001c4f60 Author: henryjen Date: 2013-10-09 09:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c070001c4f60 8023524: Mechanism to dump generated lambda classes / log lambda code generation Reviewed-by: plevart, mchung, forax, jjb Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + src/share/classes/java/lang/invoke/ProxyClassesDumper.java + test/java/lang/invoke/lambda/LogGeneratedClassesTest.java Changeset: d42fe440bda8 Author: rriggs Date: 2013-10-09 13:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d42fe440bda8 8024076: Incorrect 2 -> 4 year parsing and resolution in DateTimeFormatter Summary: Add appendValueReduced method based on a ChronoLocalDate to provide context for the value Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java Changeset: b86e6700266e Author: bpb Date: 2013-10-09 11:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b86e6700266e 8016252: More defensive HashSet.readObject Summary: Add data validation checks in readObject(). Reviewed-by: alanb, mduigou, chegar Contributed-by: Brian Burkhalter ! src/share/classes/java/util/HashSet.java + test/java/util/HashSet/Serialization.java Changeset: 1597066b58ee Author: valeriep Date: 2013-10-08 11:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1597066b58ee 7196382: PKCS11 provider should support 2048-bit DH Summary: Query and enforce range checking using the values from native PKCS11 library. Reviewed-by: xuelei ! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java + test/sun/security/pkcs11/KeyPairGenerator/TestDH2048.java Changeset: 3da8be8d13bf Author: valeriep Date: 2013-10-08 11:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3da8be8d13bf 8012900: CICO ignores AAD in GCM mode Summary: Change GCM decryption to not return result until tag verification passed Reviewed-by: xuelei ! src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/CipherFeedback.java ! src/share/classes/com/sun/crypto/provider/CounterMode.java ! src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java ! src/share/classes/com/sun/crypto/provider/FeedbackCipher.java ! src/share/classes/com/sun/crypto/provider/GCTR.java ! src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src/share/classes/com/sun/crypto/provider/OutputFeedback.java ! src/share/classes/com/sun/crypto/provider/PCBC.java ! src/share/classes/javax/crypto/CipherSpi.java + test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCMAndAAD.java Changeset: f4305254f92f Author: valeriep Date: 2013-10-08 11:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f4305254f92f 8014374: Cannot initialize "AES/GCM/NoPadding" on wrap/unseal on solaris with OracleUcrypto Summary: Removed OracleUcrypto provider regression tests from OpenJDK Reviewed-by: xuelei - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java Changeset: e044b0151858 Author: valeriep Date: 2013-10-08 14:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e044b0151858 8025967: addition of -Werror broke the old build Summary: Fixed and suppressed compiler warnings on rawtypes Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/ldap/LdapCtxFactory.java ! src/share/classes/com/sun/jndi/ldap/LdapPoolManager.java ! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java ! src/share/classes/java/lang/instrument/Instrumentation.java ! src/share/classes/java/net/ContentHandler.java ! src/share/classes/javax/crypto/JceSecurityManager.java ! src/share/classes/sun/instrument/InstrumentationImpl.java ! src/share/classes/sun/net/www/content/image/gif.java ! src/share/classes/sun/net/www/content/image/jpeg.java ! src/share/classes/sun/net/www/content/image/png.java ! src/share/classes/sun/net/www/content/image/x_xbitmap.java ! src/share/classes/sun/net/www/content/image/x_xpixmap.java ! src/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/security/provider/AuthPolicyFile.java ! src/share/classes/sun/security/provider/SubjectCodeSource.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/tools/keytool/Main.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java Changeset: 7a7b73a40bb1 Author: valeriep Date: 2013-10-09 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7a7b73a40bb1 Merge - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html Changeset: 673f8045311e Author: bpb Date: 2013-10-09 17:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/673f8045311e 7189139: BigInteger's staticRandom field can be a source of bottlenecks. Summary: Use ThreadLocalRandom instead of SecureRandom. Reviewed-by: shade, psandoz Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigInteger.java Changeset: eab3c09745b6 Author: bchristi Date: 2013-10-09 12:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eab3c09745b6 8024709: TreeMap.DescendingKeyIterator 'remove' confuses iterator position Summary: Override remove() method in DescendingKeyIterator Reviewed-by: alanb, mduigou, psandoz ! src/share/classes/java/util/TreeMap.java ! test/java/util/Collection/MOAT.java Changeset: c13309f658e1 Author: darcy Date: 2013-10-09 18:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c13309f658e1 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation Reviewed-by: mduigou, briangoetz ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/stream/DoubleStream.java Changeset: e901a618dcff Author: sjiang Date: 2013-10-10 08:37 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e901a618dcff 8025207: Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java Reviewed-by: dfuchs, dholmes ! test/javax/management/monitor/CounterMonitorThresholdTest.java Changeset: e8097e1e18a7 Author: sjiang Date: 2013-10-10 08:49 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e8097e1e18a7 8025206: Intermittent test failure: javax/management/monitor/NullAttributeValueTest.java Reviewed-by: dholmes, dfuchs, jbachorik ! test/javax/management/monitor/NullAttributeValueTest.java Changeset: a30f6fd581b3 Author: sjiang Date: 2013-10-10 09:01 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a30f6fd581b3 8025205: Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java Reviewed-by: dholmes, dfuchs, jbachorik ! test/javax/management/remote/mandatory/connection/BrokenConnectionTest.java Changeset: 74b4d20769fd Author: weijun Date: 2013-10-10 15:24 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/74b4d20769fd 8026235: keytool NSS test should use 64 bit lib on Solaris Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh Changeset: 6aa637dde16e Author: sla Date: 2013-10-10 09:38 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6aa637dde16e 8025427: jstat tests fails on 32-bit platforms Reviewed-by: ehelin, dsamersoff, dholmes, sspitsyn ! src/share/classes/sun/tools/jstat/RowClosure.java ! test/ProblemList.txt ! test/sun/tools/jstat/gcCauseOutput1.awk ! test/sun/tools/jstat/lineCounts1.awk ! test/sun/tools/jstat/lineCounts2.awk ! test/sun/tools/jstat/lineCounts3.awk ! test/sun/tools/jstat/lineCounts4.awk ! test/sun/tools/jstat/timeStamp1.awk ! test/sun/tools/jstatd/jstatGcutilOutput1.awk Changeset: 998560cccefc Author: allwin Date: 2013-10-10 10:14 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/998560cccefc 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java Reviewed-by: sla, mgronlun, dholmes, jbachorik, chegar ! test/com/sun/jdi/NoLaunchOptionTest.java Changeset: 254173b48dcb Author: dholmes Date: 2013-10-10 04:57 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/254173b48dcb 8026232: Move libnpt from profile compact1 to compact3 Reviewed-by: mchung, alanb ! makefiles/profile-includes.txt Changeset: 99b7bbe0474f Author: dl Date: 2013-10-10 09:57 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/99b7bbe0474f 7011859: java/util/concurrent/Semaphore/RacingReleases.java failing Reviewed-by: alanb, dholmes ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java Changeset: 8294c49d23b3 Author: michaelm Date: 2013-10-10 12:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8294c49d23b3 7076487: (sctp) SCTP API classes does not exist in JDK for Mac Reviewed-by: alanb, chegar ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + src/macosx/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/macosx/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/macosx/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java Changeset: cab80088c671 Author: sjiang Date: 2013-10-10 17:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cab80088c671 8025204: Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java Reviewed-by: dholmes, jbachorik ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java Changeset: f25d9d8811ca Author: jfranck Date: 2013-10-10 18:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f25d9d8811ca 7044282: (reflect) Class.forName and Array.newInstance are inconsistent regarding multidimensional arrays Reviewed-by: darcy, psandoz ! src/share/classes/java/lang/reflect/Array.java + test/java/lang/Class/forName/arrayClass/Class1.java + test/java/lang/Class/forName/arrayClass/Class2.java + test/java/lang/Class/forName/arrayClass/Class3.java + test/java/lang/Class/forName/arrayClass/Class4.java + test/java/lang/Class/forName/arrayClass/ExceedMaxDim.java ! test/java/lang/reflect/Array/ExceedMaxDim.java Changeset: 4abfcbac1cb6 Author: emc Date: 2013-10-10 18:56 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4abfcbac1cb6 8026011: java.lang.reflect.MalformedParametersException introduces doclint warnings Summary: Add javadoc comments to members of MalformedParametersException Reviewed-by: darcy ! src/share/classes/java/lang/reflect/MalformedParametersException.java Changeset: a1d91e198ddf Author: lana Date: 2013-10-10 13:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a1d91e198ddf Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so ! test/sun/security/tools/keytool/autotest.sh Changeset: 1863a7e3a1c9 Author: lana Date: 2013-10-10 20:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1863a7e3a1c9 Merge Changeset: 1a067bc31098 Author: lana Date: 2013-10-10 21:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1a067bc31098 Merge Changeset: 4ad76262bac8 Author: mullan Date: 2013-10-11 08:43 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4ad76262bac8 8007292: Add JavaFX internal packages to package.access Summary: build hooks to allow closed restricted packages to be added to java.security file Reviewed-by: erikj, dholmes, tbell ! make/java/security/Makefile ! make/tools/Makefile + make/tools/addtorestrictedpkgs/Makefile + make/tools/src/build/tools/addtorestrictedpkgs/AddToRestrictedPkgs.java ! makefiles/CopyFiles.gmk ! makefiles/Tools.gmk ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 76df579c0b93 Author: mullan Date: 2013-10-11 09:17 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/76df579c0b93 Merge ! makefiles/Tools.gmk - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java Changeset: cb373cf43294 Author: dxu Date: 2013-10-11 09:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cb373cf43294 8025712: (props) Possible memory leak in java_props_md.c / ParseLocale Reviewed-by: naoto, chegar ! src/solaris/native/java/lang/java_props_md.c Changeset: d23247aa7462 Author: vinnie Date: 2013-10-11 20:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d23247aa7462 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore Reviewed-by: mullan ! src/share/classes/sun/security/provider/DomainKeyStore.java Changeset: 94493b5800bb Author: vinnie Date: 2013-10-11 20:47 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/94493b5800bb Merge Changeset: 9632de07d963 Author: alanb Date: 2013-10-11 20:47 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9632de07d963 8019526: (fs) Files.lines, etc without Charset parameter Reviewed-by: psandoz, henryjen ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/BytesAndLines.java ! test/java/nio/file/Files/StreamTest.java Changeset: 4561460bf570 Author: rfield Date: 2013-10-11 15:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4561460bf570 8026213: Reflection support for private interface methods Reviewed-by: forax, psandoz, dholmes, jfranck Contributed-by: karen.kinnear at oracle.com ! src/share/classes/sun/reflect/AccessorGenerator.java ! src/share/classes/sun/reflect/MethodAccessorGenerator.java + test/java/lang/reflect/Method/invoke/TestPrivateInterfaceMethodReflect.java Changeset: fb202a8e83c9 Author: xuelei Date: 2013-10-13 21:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fb202a8e83c9 8026119: Regression test DHEKeySizing.java failing intermittently Reviewed-by: weijun ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/DHKeyExchange/DHEKeySizing.java Changeset: 9f8bfdd99129 Author: dfuchs Date: 2013-10-14 10:42 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9f8bfdd99129 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources. Reviewed-by: alanb, psandoz, mchung ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/util/ServiceLoader.java Changeset: 077237e4613f Author: tyan Date: 2013-10-14 11:47 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/077237e4613f 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost Reviewed-by: chegar, alanb ! test/java/net/Socks/SocksProxyVersion.java Changeset: f15a0087181e Author: stefank Date: 2013-10-14 14:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f15a0087181e 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2 Reviewed-by: coleenp, sla Contributed-by: stefan.karlsson at oracle.com, coleen.phillimore at oracle.com ! test/java/lang/management/MemoryMXBean/LowMemoryTest2.java ! test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh Changeset: 96644227daed Author: lana Date: 2013-10-11 23:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/96644227daed Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk Changeset: 3a5c987ff3a0 Author: lana Date: 2013-10-14 09:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3a5c987ff3a0 Merge Changeset: dd0deeb04933 Author: michaelm Date: 2013-10-14 22:09 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/dd0deeb04933 8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI Reviewed-by: alanb, chegar + src/share/classes/java/net/HostPortrange.java ! src/share/classes/java/net/HttpURLConnection.java - src/share/classes/java/net/HttpURLPermission.java + src/share/classes/java/net/URLPermission.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 + test/java/net/URLPermission/URLPermissionTest.java + test/java/net/URLPermission/URLTest.java + test/java/net/URLPermission/policy.1 + test/java/net/URLPermission/policy.2 + test/java/net/URLPermission/policy.3 Changeset: 94d4aa2fb414 Author: henryjen Date: 2013-10-14 17:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/94d4aa2fb414 8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on windows, jtreg report Fail to org.testng.SkipException Reviewed-by: chegar ! test/java/lang/invoke/lambda/LogGeneratedClassesTest.java Changeset: 50e88f25255f Author: joehw Date: 2013-10-14 22:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/50e88f25255f 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Reviewed-by: lancea, alanb + test/javax/xml/jaxp/validation/8015092/XPathWhiteSpaceTest.java + test/javax/xml/jaxp/validation/8015092/idIxpns.xsd + test/javax/xml/jaxp/validation/8015092/idIxpns1.xsd + test/javax/xml/jaxp/validation/8015092/idJ029.xsd + test/javax/xml/jaxp/validation/8015092/idJimp.xsd Changeset: abe8d432f714 Author: jbachorik Date: 2013-10-15 10:26 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/abe8d432f714 6804470: JvmstatCountersTest.java test times out on slower machines Summary: Increasing the default timeout to cater for the slower machines Reviewed-by: alanb ! test/sun/management/jmxremote/bootstrap/JvmstatCountersTest.java Changeset: 0b6632e570b0 Author: alanb Date: 2013-10-15 10:52 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0b6632e570b0 8026398: Can't load jdk.Exported, ClassNotFoundException Reviewed-by: chegar, mchung ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java Changeset: 2c16140fb515 Author: dfuchs Date: 2013-10-15 13:01 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2c16140fb515 8026404: Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup") Summary: The test 'threadGroup.getParent() == null' can sometimes throw ACE and needs to be wrapped in doPrivileged. Reviewed-by: alanb, mchung, dholmes ! src/share/classes/sun/awt/AppContext.java ! test/TEST.groups + test/java/util/logging/TestMainAppContext.java Changeset: ea422834f880 Author: rriggs Date: 2013-09-26 23:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ea422834f880 8025720: Separate temporal interface layer Summary: Remove ZoneId and Chronology from TemporalField interface Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/WeekFields.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java Changeset: 110107410393 Author: scolebourne Date: 2013-07-09 21:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/110107410393 8025719: Change Chronology to an interface Summary: Split Chronology and add AbstractChronology Reviewed-by: darcy Contributed-by: scolebourne at joda.org + src/share/classes/java/time/chrono/AbstractChronology.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! test/java/time/tck/java/time/chrono/CopticChronology.java Changeset: 087c8c1d2631 Author: rriggs Date: 2013-10-15 13:14 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/087c8c1d2631 8025722: TemporalAdjusters and TemporalQueries Summary: Move static from interfaces methods to supporting classes Reviewed-by: sherman ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/chrono/AbstractChronology.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoPeriodImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalAdjusters.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalQueries.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/util/Formatter.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/TestIsoChronology.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKIsoChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKMinguoChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java ! test/java/time/tck/java/time/format/TCKChronoPrinterParser.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java ! test/java/time/tck/java/time/format/TCKLocalizedPrinterParser.java ! test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java ! test/java/time/tck/java/time/temporal/TCKTemporalAdjusters.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java ! test/java/time/test/java/util/TestFormatter.java Changeset: b3baca585b7f Author: jbachorik Date: 2013-04-23 09:37 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b3baca585b7f 8011081: Improve jhat Summary: Properly escape HTML output Reviewed-by: alanb, mschoene, sundar ! src/share/classes/com/sun/tools/hat/internal/server/AllClassesQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/ClassQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/HttpReader.java ! src/share/classes/com/sun/tools/hat/internal/server/InstancesCountQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/OQLHelp.java ! src/share/classes/com/sun/tools/hat/internal/server/OQLQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/QueryHandler.java ! src/share/classes/com/sun/tools/hat/internal/server/RefsByTypeQuery.java Changeset: 37f6f4dbfc6d Author: ksrini Date: 2013-05-07 13:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/37f6f4dbfc6d 8013506: Better Pack200 data handling Reviewed-by: jrose, kizune, mschoene ! src/share/native/com/sun/java/util/jar/pack/zip.cpp Changeset: 139a01719eec Author: jchen Date: 2013-05-09 09:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/139a01719eec 8013510: Augment image writing code Reviewed-by: bae, prr ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c Changeset: f2068f4244a5 Author: bae Date: 2013-05-14 12:51 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f2068f4244a5 8014093: Improve parsing of images Reviewed-by: prr, jgodinez ! src/share/native/sun/awt/image/awt_parseImage.c ! src/share/native/sun/awt/image/awt_parseImage.h ! src/share/native/sun/awt/medialib/awt_ImagingLib.c Changeset: 65d5a6e53d12 Author: alexsch Date: 2013-05-20 14:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/65d5a6e53d12 8013744: Better tabling for AWT Reviewed-by: art, malenkov, skoivu ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/sun/swing/SwingLazyValue.java ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: 52be85d5149b Author: bae Date: 2013-05-20 15:26 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/52be85d5149b 8014102: Improve image conversion Reviewed-by: mschoene, prr, jgodinez ! src/share/native/sun/awt/medialib/awt_ImagingLib.c Changeset: 08b88f831dd1 Author: malenkov Date: 2013-05-20 19:49 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/08b88f831dd1 8012071: Better Building of Beans Reviewed-by: art, skoivu ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/MetaData.java Changeset: 140c474ab8b9 Author: malenkov Date: 2013-05-31 21:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/140c474ab8b9 8012277: Improve AWT DataFlavor Reviewed-by: art, skoivu ! src/share/classes/java/awt/datatransfer/DataFlavor.java Changeset: 23fe888b698d Author: weijun Date: 2013-05-08 09:21 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/23fe888b698d 8014341: Better service from Kerberos servers Summary: read incoming data safely and take care of null return value Reviewed-by: valeriep, ahgross ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/internal/NetClient.java Changeset: 532343ec60b7 Author: weijun Date: 2013-06-13 10:21 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/532343ec60b7 8013739: Better LDAP resource management Reviewed-by: ahgross, mchung, xuelei ! src/share/classes/com/sun/jndi/ldap/VersionHelper12.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/sun/misc/JavaLangAccess.java Changeset: 6d9ec6877a7f Author: weijun Date: 2013-06-13 10:31 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6d9ec6877a7f 8015731: Subject java.security.auth.subject to improvements Reviewed-by: skoivu, mullan ! src/share/classes/javax/security/auth/Subject.java Changeset: ccca37ca416a Author: jchen Date: 2013-06-13 12:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ccca37ca416a 8014098: Better profile validation Reviewed-by: bae, mschoene, prr ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c Changeset: 5a14ecd30b4e Author: msheppar Date: 2013-06-14 15:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5a14ecd30b4e 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu ! make/com/sun/jmx/Makefile ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java Changeset: 7addece3f21e Author: jbachorik Date: 2013-06-20 08:51 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7addece3f21e 8014085: Better serialization support in JMX classes Reviewed-by: alanb, dfuchs, skoivu ! src/share/classes/javax/management/MBeanNotificationInfo.java ! src/share/classes/javax/management/remote/JMXPrincipal.java ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/management/remote/NotificationResult.java ! src/share/classes/javax/management/remote/TargetedNotification.java Changeset: eb29deb3c1db Author: chegar Date: 2013-06-27 10:37 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eb29deb3c1db Merge Changeset: 0a06ec55aacd Author: bae Date: 2013-07-01 15:17 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0a06ec55aacd 8017287: Better resource disposal Reviewed-by: prr, vadim, skoivu ! src/share/classes/sun/java2d/Disposer.java Changeset: 51204df822d3 Author: erikj Date: 2013-07-03 10:14 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/51204df822d3 8012146: Improve tool support Reviewed-by: ksrini, dholmes, alanb, anthony ! makefiles/CompileLaunchers.gmk ! makefiles/Images.gmk ! test/Makefile Changeset: 888fd0ad7e1e Author: ascarpino Date: 2013-07-03 15:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/888fd0ad7e1e 8011071: Better crypto provider handling Reviewed-by: hawtin, valeriep ! src/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/share/classes/sun/security/jgss/GSSCredentialImpl.java ! src/share/classes/sun/security/pkcs/PKCS8Key.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/classes/sun/security/provider/DSAPrivateKey.java ! src/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java ! src/share/classes/sun/security/rsa/RSAPrivateKeyImpl.java Changeset: a06b764cc2d0 Author: dsamersoff Date: 2013-07-08 16:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a06b764cc2d0 8008589: Better MBean permission validation Summary: Better MBean permission validation Reviewed-by: skoivu, dfuchs, mchung, sjiang ! src/share/classes/javax/management/MBeanTrustPermission.java Changeset: 9c6de162771c Author: smarks Date: 2013-07-11 13:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9c6de162771c 8014987: Augment serialization handling Reviewed-by: alanb, coffeys, skoivu ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java Changeset: c40752886882 Author: jfranck Date: 2013-07-15 14:44 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c40752886882 8014349: (cl) Class.getDeclaredClass problematic in some class loader configurations Reviewed-by: mchung, ahgross, darcy ! src/share/classes/java/lang/Class.java ! src/share/native/java/lang/Class.c Changeset: 48548e40187a Author: mchung Date: 2013-07-15 20:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/48548e40187a 8017291: Cast Proxies Aside Reviewed-by: alanb, ahgross ! src/share/classes/java/lang/ClassLoader.java Changeset: 047c99b53994 Author: chegar Date: 2013-07-15 18:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/047c99b53994 Merge ! src/share/classes/java/lang/Thread.java - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/swing/SwingUtilities2.java - test/java/util/Comparators/BasicTest.java Changeset: 3062c96e79e0 Author: chegar Date: 2013-07-16 12:23 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3062c96e79e0 Merge Changeset: e1497f102a8a Author: malenkov Date: 2013-07-16 21:11 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e1497f102a8a 8019617: Better view of objects Reviewed-by: art, skoivu ! src/share/classes/javax/swing/text/html/ObjectView.java Changeset: 69a2dc92fefe Author: michaelm Date: 2013-07-18 18:52 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/69a2dc92fefe 8015743: Address internet addresses Reviewed-by: alanb, khazra, skoivu ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java ! src/share/native/java/net/Inet6Address.c ! src/share/native/java/net/net_util.c ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/windows/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c ! src/windows/native/java/net/net_util_md.c ! test/java/net/Inet6Address/serialize/Serialize.java Changeset: 5d8f1e697cd8 Author: okutsu Date: 2013-07-19 12:14 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5d8f1e697cd8 8001029: Add new date/time capability Reviewed-by: mchung, hawtin ! src/share/classes/java/util/TimeZone.java + test/java/util/TimeZone/SetDefaultSecurityTest.java Changeset: fe90bd20865b Author: sjiang Date: 2013-07-19 13:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fe90bd20865b 8014534: Better profiling support Summary: Validation of parameters Reviewed-by: sspitsyn, skoivu, mchung ! src/share/classes/com/sun/demo/jvmti/hprof/Tracker.java ! src/share/demo/jvmti/hprof/hprof_class.c ! src/share/demo/jvmti/hprof/hprof_event.c Changeset: 0a51ccf778b3 Author: chegar Date: 2013-07-22 14:02 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0a51ccf778b3 Merge Changeset: 3725e8a70ae9 Author: mchung Date: 2013-07-22 19:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3725e8a70ae9 8017196: Ensure Proxies are handled appropriately Reviewed-by: dfuchs, jrose, jdn, ahgross, chegar ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java Changeset: 5bde952bf23c Author: sgabdura Date: 2013-07-23 09:30 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5bde952bf23c 8016357: Update hotspot diagnostic class Summary: Add security check to HotSpotDiagnostic.dumpHeap Reviewed-by: fparain, sla, ahgross ! make/java/management/mapfile-vers ! makefiles/mapfiles/libmanagement/mapfile-vers ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/native/sun/management/HotSpotDiagnostic.c Changeset: 5bdc55e87cae Author: weijun Date: 2013-07-17 18:46 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5bdc55e87cae 8020696: Merge problem for KdcComm.java Reviewed-by: chegar ! src/share/classes/sun/security/krb5/KdcComm.java Changeset: 490c67c5d9a2 Author: jchen Date: 2013-07-24 12:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/490c67c5d9a2 8020293: JVM crash Reviewed-by: prr, jgodinez ! src/share/classes/sun/font/GlyphLayout.java ! src/share/native/sun/font/layout/SunLayoutEngine.cpp Changeset: bcce47d9d8da Author: jbachorik Date: 2013-07-19 16:29 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bcce47d9d8da 8019584: javax/management/remote/mandatory/loading/MissingClassTest.java failed in nightly against jdk7u45: java.io.InvalidObjectException: Invalid notification: null Reviewed-by: mchung, sjiang, dfuchs, ahgross ! src/share/classes/javax/management/remote/NotificationResult.java ! src/share/classes/javax/management/remote/TargetedNotification.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java Changeset: d7a0bbf526f8 Author: jbachorik Date: 2013-07-29 04:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d7a0bbf526f8 8021577: JCK test api/javax_management/jmx_serial/modelmbean/ModelMBeanNotificationInfo/serial/index.html#Input has failed since jdk 7u45 b01 Reviewed-by: alanb, dfuchs, ahgross ! src/share/classes/javax/management/MBeanNotificationInfo.java Changeset: 1a1e42c8e988 Author: chegar Date: 2013-07-25 19:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1a1e42c8e988 Merge ! src/share/classes/com/sun/crypto/provider/DHPrivateKey.java - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java - src/share/classes/java/util/stream/StreamBuilder.java ! src/share/classes/javax/security/auth/Subject.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/security/pkcs11/P11Key.java - test/java/util/Collections/EmptySortedSet.java Changeset: 446bc20447a1 Author: chegar Date: 2013-07-29 14:58 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/446bc20447a1 Merge Changeset: e537b7f5f39b Author: naoto Date: 2013-08-01 14:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e537b7f5f39b 8021286: Improve MacOS resourcing Reviewed-by: okutsu - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk ! make/sun/awt/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m Changeset: 44a063555ccd Author: chegar Date: 2013-08-02 11:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/44a063555ccd Merge Changeset: 17e1675e3d1e Author: serb Date: 2013-08-04 02:50 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/17e1675e3d1e 8021282: Better recycling of object instances Reviewed-by: art ! src/macosx/classes/com/apple/laf/AquaUtils.java Changeset: ba7566de89c6 Author: sjiang Date: 2013-08-06 10:33 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ba7566de89c6 8019292: Better Attribute Value Exceptions Reviewed-by: dfuchs, dholmes, ahgross ! src/share/classes/javax/management/BadAttributeValueExpException.java Changeset: 23476862c55b Author: malenkov Date: 2013-08-07 14:37 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/23476862c55b 8021969: The index_AccessAllowed jnlp can not load successfully with exception thrown in the log. Reviewed-by: art, skoivu ! src/share/classes/java/awt/datatransfer/DataFlavor.java Changeset: db9539b0061d Author: jbachorik Date: 2013-08-08 19:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/db9539b0061d 8021360: object not exported" on start of JMXConnectorServer for RMI-IIOP protocol with security manager Reviewed-by: alanb, ahgross, smarks, coffeys ! src/share/classes/com/sun/jmx/remote/protocol/iiop/IIOPProxyImpl.java Changeset: 077d8c2cc5f6 Author: chegar Date: 2013-08-09 14:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/077d8c2cc5f6 Merge ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java - src/share/classes/java/net/package.html ! src/share/classes/java/util/TimeZone.java ! src/share/native/java/net/net_util.c ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/medialib/awt_ImagingLib.c ! test/Makefile Changeset: e82ddcc1b2fb Author: serb Date: 2013-08-12 19:57 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e82ddcc1b2fb 8021275: Better screening for ScreenMenu Reviewed-by: art ! src/macosx/classes/com/apple/laf/ScreenMenu.java Changeset: 3e3cbd93f4f1 Author: twisti Date: 2013-08-12 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3e3cbd93f4f1 8022066: Evaluation of method reference to signature polymorphic method crashes VM Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandles.java + test/java/lang/invoke/MethodHandleConstants.java Changeset: e173b8786362 Author: ksrini Date: 2013-08-14 10:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e173b8786362 8021355: REGRESSION: Five closed/java/awt/SplashScreen tests fail since 7u45 b01 on Linux, Solaris Reviewed-by: dholmes, anthony, ahgross, erikj ! src/solaris/bin/java_md_solinux.c Changeset: 31010ca3da3e Author: chegar Date: 2013-08-15 21:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/31010ca3da3e Merge ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh Changeset: 3f85c96eafcc Author: weijun Date: 2013-08-14 15:25 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3f85c96eafcc 8022931: Enhance Kerberos exceptions Reviewed-by: xuelei, ahgross ! src/share/classes/javax/security/auth/kerberos/KeyTab.java Changeset: 50bdb9577b27 Author: erikj Date: 2013-08-19 12:30 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/50bdb9577b27 8022719: tools/launcher/RunpathTest.java fails after 8012146 Reviewed-by: chegar ! test/tools/launcher/RunpathTest.java Changeset: 0f279113c95a Author: erikj Date: 2013-08-19 14:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0f279113c95a 8023231: Remove comma from jtreg bug line Reviewed-by: alanb, chegar ! test/tools/launcher/RunpathTest.java Changeset: ad35b4b6ce8e Author: chegar Date: 2013-08-23 12:32 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ad35b4b6ce8e Merge Changeset: 29f73bc50bd4 Author: chegar Date: 2013-08-30 09:37 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/29f73bc50bd4 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java ! src/share/classes/java/net/InetAddress.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java ! src/solaris/native/java/net/NetworkInterface.c - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: a8593bc7c29d Author: chegar Date: 2013-09-06 09:41 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a8593bc7c29d Merge ! src/share/classes/java/lang/Class.java - src/share/classes/sun/misc/Compare.java - src/share/classes/sun/misc/Sort.java Changeset: 22ea25e71b4c Author: chegar Date: 2013-09-14 19:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/22ea25e71b4c Merge Changeset: 240072825ada Author: chegar Date: 2013-10-03 19:06 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/240072825ada Merge ! make/sun/awt/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/Images.gmk - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/invoke/MethodHandles.java - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java ! src/share/classes/javax/management/MBeanNotificationInfo.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/font/layout/SunLayoutEngine.cpp ! src/solaris/bin/java_md_solinux.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/util/Collection/ListDefaults.java - test/java/util/Map/CheckRandomHashSeed.java - test/java/util/Map/TreeBinSplitBackToEntries.java - test/java/util/concurrent/ConcurrentHashMap/toArray.java - test/java/util/regex/PatternTest.java - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh ! test/tools/launcher/RunpathTest.java Changeset: adbf6d61c820 Author: chegar Date: 2013-10-07 11:31 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/adbf6d61c820 8025991: tools/launcher/RunpathTest.java fails Reviewed-by: erikj ! test/tools/launcher/RunpathTest.java Changeset: 99832c718cb8 Author: chegar Date: 2013-10-15 09:27 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/99832c718cb8 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 3dbfab65c17e Author: chegar Date: 2013-10-15 13:54 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3dbfab65c17e Merge ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/lang/ClassLoader.java - src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 27ac58b9a62a Author: chegar Date: 2013-10-15 20:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/27ac58b9a62a 8026513: ProblemList.txt Updates (10/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: 78ffa90c77b2 Author: chegar Date: 2013-10-15 20:47 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/78ffa90c77b2 Merge Changeset: 3676f04e6553 Author: bpb Date: 2013-10-15 16:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3676f04e6553 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown Summary: Modify UHE exception message for EAI_AGAIN failures. Reviewed-by: alanb, chegar, michaelm, dsamersoff Contributed-by: Brian Burkhalter ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c Changeset: e33aea66caa3 Author: dholmes Date: 2013-10-15 20:54 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e33aea66caa3 8026378: TEST_BUG: Clean up TEST.groups Reviewed-by: mduigou, mchung, alanb ! test/TEST.groups Changeset: a70aab9b373e Author: weijun Date: 2013-10-16 14:39 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a70aab9b373e 8025124: InitialToken.useNullKey incorrectly applies NULL_KEY in some cases Reviewed-by: xuelei ! src/share/classes/sun/security/jgss/krb5/InitialToken.java ! src/share/classes/sun/security/krb5/KrbCred.java Changeset: 9ea6a464c147 Author: igerasim Date: 2013-10-15 21:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9ea6a464c147 8023431: Test java/util/zip/GZIP/GZIPInZip.java failed Summary: Properly close PipedStreams. Additional testing for malformed input Reviewed-by: darcy, sherman ! test/java/util/zip/GZIP/GZIPInZip.java Changeset: 76a7c0bc74fd Author: erikj Date: 2013-10-16 13:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/76a7c0bc74fd 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Reviewed-by: dholmes, chegar ! makefiles/GendataBreakIterator.gmk ! makefiles/GenerateClasses.gmk ! makefiles/Setup.gmk ! src/share/classes/sun/tools/tree/Node.java Changeset: e078fd8a78f6 Author: erikj Date: 2013-10-16 15:53 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e078fd8a78f6 Merge Changeset: d8eec0e3a023 Author: robm Date: 2013-10-16 15:06 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d8eec0e3a023 8026245: InetAddress.getLocalHost crash if IPv6 disabled (macosx) Reviewed-by: chegar, alanb ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! test/java/net/InetAddress/GetLocalHostWithSM.java ! test/java/net/Socket/GetLocalAddress.java Changeset: 445667b19e32 Author: dfuchs Date: 2013-10-16 17:19 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/445667b19e32 8011638: Remove deprecated methods in sun.util.logging.PlatformLogger Reviewed-by: psandoz, mchung, alanb, chegar ! src/share/classes/sun/font/FontUtilities.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! test/sun/util/logging/PlatformLoggerTest.java Changeset: 2ef43f3a901c Author: dfuchs Date: 2013-10-16 20:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2ef43f3a901c 8013839: Enhance Logger API for handling of resource bundles 4814565: (rb) add method to get basename from a ResourceBundle Summary: adds Logger.setResourceBundle(ResourceBundle) and ResourceBundle.getBaseBundleName() Reviewed-by: mchung, naoto ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java + test/java/util/ResourceBundle/getBaseBundleName/resources/ListBundle.java + test/java/util/ResourceBundle/getBaseBundleName/resources/ListBundle_fr.java + test/java/util/ResourceBundle/getBaseBundleName/resources/PropertyBundle.properties + test/java/util/ResourceBundle/getBaseBundleName/resources/PropertyBundle_fr.properties + test/java/util/logging/Logger/logrb/TestLogrbResourceBundle.java + test/java/util/logging/Logger/logrb/resources/ListBundle.java + test/java/util/logging/Logger/logrb/resources/ListBundle_fr.java + test/java/util/logging/Logger/logrb/resources/PropertyBundle.properties + test/java/util/logging/Logger/logrb/resources/PropertyBundle_fr.properties + test/java/util/logging/Logger/setResourceBundle/TestSetResourceBundle.java + test/java/util/logging/Logger/setResourceBundle/resources/ListBundle.java + test/java/util/logging/Logger/setResourceBundle/resources/ListBundle_fr.java + test/java/util/logging/Logger/setResourceBundle/resources/PropertyBundle.properties + test/java/util/logging/Logger/setResourceBundle/resources/PropertyBundle_fr.properties Changeset: cf9cb3d241a3 Author: mduigou Date: 2013-10-16 13:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cf9cb3d241a3 8025910: rename substream(long) -> skip and remove substream(long,long) Reviewed-by: psandoz, henryjen ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java ! test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java Changeset: 60e3cdbe8cdf Author: aefimov Date: 2013-10-13 14:19 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/60e3cdbe8cdf 8025255: (tz) Support tzdata2013g Reviewed-by: okutsu, mfang ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/etcetera ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/backward ! test/sun/util/calendar/zi/tzdata/etcetera ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/iso3166.tab ! test/sun/util/calendar/zi/tzdata/leapseconds ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/zone.tab Changeset: e2e3c2c249e2 Author: henryjen Date: 2013-10-16 21:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e2e3c2c249e2 8026768: java.util.Map.Entry comparingBy methods missing @since 1.8 Reviewed-by: dholmes ! src/share/classes/java/util/Map.java Changeset: ce266885222d Author: peytoia Date: 2013-10-17 13:57 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ce266885222d 8025703: Update LSR datafile for BCP 47 Reviewed-by: okutsu ! src/share/classes/sun/util/locale/LocaleEquivalentMaps.java + test/java/util/Locale/Bug8025703.java ! test/java/util/Locale/tools/language-subtag-registry.txt Changeset: a45acc8de0f3 Author: wetmore Date: 2013-10-16 23:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a45acc8de0f3 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/GenerateClasses.gmk Changeset: 37e3dcb798c3 Author: weijun Date: 2013-10-17 20:56 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/37e3dcb798c3 8026712: TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh Changeset: 0a6730b5e192 Author: drchase Date: 2013-10-16 17:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0a6730b5e192 8022718: Runtime accessibility checking: protected class, if extended, should be accessible from another package Summary: Modify accessibility check; it was muddled about Java vs JVM protection terminology. Reviewed-by: jrose ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/sun/invoke/util/VerifyAccess.java ! src/share/classes/sun/reflect/Reflection.java + test/java/lang/invoke/accessProtectedSuper/BogoLoader.java + test/java/lang/invoke/accessProtectedSuper/MethodInvoker.java + test/java/lang/invoke/accessProtectedSuper/Test.java + test/java/lang/invoke/accessProtectedSuper/anotherpkg/MethodSupplierOuter.java Changeset: 36fe6a9bd43e Author: rriggs Date: 2013-10-17 10:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/36fe6a9bd43e 8026516: javadoc errors in java.time Summary: Corrected links to TemporalQuery and TemporalField.resolve Reviewed-by: mduigou, darcy, lancea ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoEra.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistEra.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java Changeset: 5d866df64ae3 Author: mullan Date: 2013-10-17 10:18 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5d866df64ae3 8026346: test/java/lang/SecurityManager/CheckPackageAccess.java failing Reviewed-by: vinnie ! src/share/lib/security/java.security-macosx ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 04e8b8fc6906 Author: mullan Date: 2013-10-17 10:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/04e8b8fc6906 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/java/net/HttpURLPermission.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 85a73ad28c53 Author: mullan Date: 2013-10-17 11:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/85a73ad28c53 Merge Changeset: 456a9b199208 Author: rriggs Date: 2013-10-17 13:43 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/456a9b199208 8026183: minor documentation problems in java.lang.invoke 8015808: Typo in MethodHandle javadoc Summary: Fix typos and javadoc markup and extraneous paragraph tags Reviewed-by: lancea ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/ConstantCallSite.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java Changeset: bc04f561bb78 Author: joehw Date: 2013-10-17 11:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bc04f561bb78 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Reviewed-by: lancea + test/javax/xml/jaxp/validation/8015243/AnyURITest.java + test/javax/xml/jaxp/validation/8015243/anyURI_b006.xsd Changeset: fa38f8e0accd Author: juh Date: 2013-10-17 12:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fa38f8e0accd 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files Reviewed-by: vinnie ! test/sun/security/tools/keytool/StorePasswords.java Changeset: 64c0ac7cd936 Author: lancea Date: 2013-10-17 15:14 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/64c0ac7cd936 8026812: doclint clean up for java.sql and javax.sql Reviewed-by: mduigou ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLException.java ! src/share/classes/java/sql/SQLFeatureNotSupportedException.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLWarning.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/JoinRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java Changeset: 3735d81552a7 Author: mchung Date: 2013-10-17 13:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3735d81552a7 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb ! test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java Changeset: c1af85c48819 Author: mduigou Date: 2013-10-17 12:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c1af85c48819 8004138: ForkJoinTask leaks exceptions Reviewed-by: chegar, mduigou, psandoz, martin Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/ForkJoinTask.java + test/java/util/concurrent/forkjoin/FJExceptionTableLeak.java Changeset: e76bb2436b04 Author: bpb Date: 2013-10-17 15:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e76bb2436b04 8026832: Clean up straggling doclint warnings in java.math Summary: Fix empty paragraph tag warnings. Reviewed-by: lancea ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/RoundingMode.java Changeset: 187d5ccb5b18 Author: lana Date: 2013-10-17 15:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/187d5ccb5b18 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk ! makefiles/GenerateClasses.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Setup.gmk ! makefiles/Tools.gmk + makefiles/gendata/GendataBreakIterator.gmk ! makefiles/profile-includes.txt - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 Changeset: b73fb7920645 Author: lana Date: 2013-10-17 15:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b73fb7920645 Merge - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 Changeset: c1616a944d1c Author: weijun Date: 2013-10-18 08:57 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c1616a944d1c 7025699: Policy Tool is not accessible by keyboard Reviewed-by: alexp, weijun Contributed-by: Leif Samuelsson ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/tools/policytool/Resources.java ! test/sun/security/tools/policytool/Alias.html ! test/sun/security/tools/policytool/OpenPolicy.html ! test/sun/security/tools/policytool/UpdatePermissions.html Changeset: 969e8c6c26cc Author: amurillo Date: 2013-10-19 08:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/969e8c6c26cc Merge ! makefiles/Import.gmk ! makefiles/Tools.gmk Changeset: c4ab67d1e0ce Author: amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c4ab67d1e0ce Merge ! makefiles/Tools.gmk Changeset: a5b57fca66da Author: ihse Date: 2013-10-16 20:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a5b57fca66da 8025715: Split CompileNativeLibraries.gmk Reviewed-by: erikj ! makefiles/CompileNativeLibraries.gmk + makefiles/lib/Awt2dLibraries.gmk + makefiles/lib/CoreLibraries.gmk + makefiles/lib/NetworkingLibraries.gmk + makefiles/lib/NioLibraries.gmk + makefiles/lib/PlatformLibraries.gmk + makefiles/lib/SecurityLibraries.gmk + makefiles/lib/ServiceabilityLibraries.gmk + makefiles/lib/SoundLibraries.gmk Changeset: 1e99d539088d Author: katleman Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1e99d539088d Merge Changeset: 7ec4ddc36ad6 Author: erikj Date: 2013-10-17 16:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7ec4ddc36ad6 8019540: licensee reports a JDK8 build failure after 8005849/8005008 fixes integrated. Reviewed-by: dholmes, sla ! makefiles/CopyIntoClasses.gmk Changeset: 11e90e4167d4 Author: erikj Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/11e90e4167d4 Merge Changeset: 3a6ac3484b05 Author: cl Date: 2013-10-21 23:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3a6ac3484b05 8026974: solaris build missing java-rmi.cgi Reviewed-by: ksrini ! makefiles/CompileLaunchers.gmk Changeset: b121e84392fa Author: erikj Date: 2013-10-22 11:59 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b121e84392fa 8026966: Most native libs broken on mac in jdk8/build Reviewed-by: ihse, anthony ! makefiles/lib/PlatformLibraries.gmk Changeset: 9850efaedc50 Author: katleman Date: 2013-10-22 16:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9850efaedc50 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk + makefiles/lib/Awt2dLibraries.gmk + makefiles/lib/CoreLibraries.gmk + makefiles/lib/NetworkingLibraries.gmk + makefiles/lib/NioLibraries.gmk + makefiles/lib/PlatformLibraries.gmk + makefiles/lib/SecurityLibraries.gmk + makefiles/lib/ServiceabilityLibraries.gmk + makefiles/lib/SoundLibraries.gmk Changeset: 698937f18761 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/698937f18761 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties ! makefiles/jprt.properties Changeset: 81431a7c17cf Author: tbell Date: 2013-10-22 16:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/81431a7c17cf Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/net/HttpURLPermission.java - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: aabaae5de1ee Author: ihse Date: 2013-10-23 13:06 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/aabaae5de1ee 8001922: Improve freetype handling. Reviewed-by: erikj ! makefiles/CopyFiles.gmk ! makefiles/lib/Awt2dLibraries.gmk Changeset: ab0e61a57df7 Author: chegar Date: 2013-10-23 13:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ab0e61a57df7 8027059: (sctp) fatal warnings overly restrictive with gcc 4.8.1 Reviewed-by: mduigou, dxu, erikj, ihse ! makefiles/lib/NioLibraries.gmk Changeset: 5b4261b4b72a Author: erikj Date: 2013-10-23 17:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5b4261b4b72a 8026888: Licensee build failure due to wrong libs being called Reviewed-by: tbell, ihse, simonis ! makefiles/lib/Awt2dLibraries.gmk Changeset: b88aa723a5fa Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b88aa723a5fa Added tag jdk8-b113 for changeset 5b4261b4b72a ! .hgtags Changeset: 110c4fe4c354 Author: erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/110c4fe4c354 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! makefiles/BuildJdk.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + makefiles/CreateSecurityJars.gmk ! makefiles/SignJars.gmk Changeset: f40f639e1f52 Author: dholmes Date: 2013-10-24 20:46 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f40f639e1f52 8016096: [macosx] jawt_md.h shipped with jdk is outdated Summary: Revised build system and added platform specific headers for Mac OS X Reviewed-by: anthony, art, ihse, erikj Contributed-by: david.dehaven at oracle.com ! makefiles/CopyFiles.gmk ! makefiles/gensrc/GensrcX11Wrappers.gmk + src/macosx/javavm/export/jawt_md.h + src/macosx/javavm/export/jni_md.h + src/macosx/javavm/export/jvm_md.h ! src/macosx/native/sun/awt/AWTSurfaceLayers.h ! src/macosx/native/sun/awt/CMenuComponent.h ! src/macosx/native/sun/awt/jawt.m ! src/macosx/native/sun/font/CoreTextSupport.h ! src/share/javavm/export/jawt.h Changeset: f3c95d961557 Author: dholmes Date: 2013-10-24 20:47 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f3c95d961557 8025673: [macosx] Disable X11 AWT toolkit Summary: Disable but not completely remove the XAWT and headless toolkits on Mac OS X Reviewed-by: anthony, art, ihse, erikj Contributed-by: david.dehaven at oracle.com ! makefiles/CompileJavaClasses.gmk ! makefiles/GenerateSources.gmk ! makefiles/Tools.gmk ! makefiles/lib/Awt2dLibraries.gmk ! src/share/native/java/lang/System.c ! src/share/native/java/lang/java_props.h ! src/solaris/native/java/lang/java_props_macosx.c ! src/solaris/native/java/lang/java_props_macosx.h ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/sun/awt/fontpath.c ! test/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh Changeset: 5813af4c02e4 Author: dcubed Date: 2013-10-25 10:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5813af4c02e4 8027117: adapt JDK-7165611 to new build-infra whitespace/indent policy Summary: Fix whitespace/indent issues. Reviewed-by: hseigel, coleenp, erikj, ihse ! makefiles/Import.gmk Changeset: 1628a137edca Author: katleman Date: 2013-10-28 16:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1628a137edca Merge Changeset: f26a0c8071bd Author: erikj Date: 2013-10-29 15:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f26a0c8071bd 8027298: broken link in jdk8b113 macosx binaries Reviewed-by: dcubed, ihse ! makefiles/Import.gmk Changeset: 62982664dc72 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/62982664dc72 Added tag jdk8-b114 for changeset f26a0c8071bd ! .hgtags From Alan.Bateman at oracle.com Sat Nov 2 04:37:35 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 02 Nov 2013 11:37:35 +0000 Subject: [8] Review Request: 8027696 Incorrect copyright header in the tests In-Reply-To: <52738E00.2070806@oracle.com> References: <52738E00.2070806@oracle.com> Message-ID: <5274E3FF.3070807@oracle.com> On 01/11/2013 11:18, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk 8. > Most of tests in the sound area, and some tests in the client, > java.lang, security, jmx etc has incorrect copyright. > According to the http://openjdk.java.net/faq > "GPL v2 + the Classpath exception for the class libraries and those > parts of the virtual machine that expose public APIs" > > But currently our tests mix gpl+cp and gpl or has no header at all. > Tests with "/nodynamiccopyright/", with other company's copyright, or > other gpl templates were not updated. > > Also it would be good if in the faq we explicitly mention about > copyright of the tests. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8027696 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/8027696/webrev.00 > Thanks for doing this. I sampled a few of the files in the webrev and the changes mostly look okay. The only thing is that I'm not sure about is the dates that you've put on tests that were missing a header. For example, test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java was added in 2013 but the header proposed in the webrev has 2012. Does your script to fix up these headers look at the hg log to get the date range? I see you've changed jdk/test/Makefile to have the GPL header. I don't know what the right header is for that (as the rest of the Makefiles have the GPL + Classpath exception). One other question is whether this is a one-off effort by yourself or whether this is part of an effort to keep us in check on a continuous basis. Periodically David Katleman brings up malformed headers on jdk8-dev. I assume these are caught by something that checks the headers on a weekly or continuous basis. Maybe there is an opportunity to combine efforts and also have these scripts run on a continuous basis on jdk8/tl, jdk8/awt and the other forests that collect changes. -Alan. From markus.gronlund at oracle.com Sat Nov 2 14:07:52 2013 From: markus.gronlund at oracle.com (markus.gronlund at oracle.com) Date: Sat, 02 Nov 2013 21:07:52 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8 new changesets Message-ID: <20131102210811.B3B1F62939@hg.openjdk.java.net> Changeset: e006d2e25bc7 Author: dholmes Date: 2013-10-24 20:47 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e006d2e25bc7 8025673: [macosx] Disable X11 AWT toolkit Summary: Disable but not completely remove the XAWT and headless toolkits on Mac OS X Reviewed-by: dholmes Contributed-by: david.dehaven at oracle.com ! src/os/bsd/vm/os_bsd.cpp Changeset: 913a35723a0a Author: katleman Date: 2013-10-28 16:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/913a35723a0a Merge Changeset: 7fd913010dbb Author: katleman Date: 2013-10-29 14:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7fd913010dbb Merge Changeset: ddc3758f68db Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ddc3758f68db Added tag jdk8-b114 for changeset 7fd913010dbb ! .hgtags Changeset: 3b32d287da89 Author: amurillo Date: 2013-11-01 08:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3b32d287da89 Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: afd012c940e4 Author: amurillo Date: 2013-11-01 08:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/afd012c940e4 Added tag hs25-b57 for changeset 3b32d287da89 ! .hgtags Changeset: 5b84039ca739 Author: amurillo Date: 2013-11-01 08:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5b84039ca739 8027580: new hotspot build - hs25-b58 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 04df110c8655 Author: mgronlun Date: 2013-11-02 20:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/04df110c8655 Merge From john.r.rose at oracle.com Sun Nov 3 01:08:40 2013 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Sun, 03 Nov 2013 08:08:40 +0000 Subject: hg: jdk8/tl/jdk: 8024635: Caching MethodType's descriptor string improves lambda linkage performance Message-ID: <20131103080921.8CA856294D@hg.openjdk.java.net> Changeset: adcc01f5bc93 Author: jrose Date: 2013-11-02 20:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adcc01f5bc93 8024635: Caching MethodType's descriptor string improves lambda linkage performance Summary: Better interpreted and compiled performance of operations in MethodType important to LambdaMetafactory. Reviewed-by: jrose, twisti, mchung Contributed-by: sergey.kuksenko at oracle.com ! src/share/classes/java/lang/invoke/MethodType.java From sundararajan.athijegannathan at oracle.com Sun Nov 3 21:01:48 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 04 Nov 2013 05:01:48 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131104050151.57EF26295C@hg.openjdk.java.net> Changeset: ae5f2130c3b9 Author: sundar Date: 2013-11-01 19:54 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae5f2130c3b9 8027700: function redeclaration checks missing for declaration binding instantiation Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! test/script/basic/JDK-8015355.js + test/script/basic/JDK-8027700.js Changeset: 98bab0cdd7bf Author: attila Date: 2013-11-01 15:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/98bab0cdd7bf 8027236: Ensure ScriptObject and ConsString aren't visible to Java Reviewed-by: lagergren, sundar ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/ConsString.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaSuperAdapterLinker.java + src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java + test/script/basic/JDK-8027236.js + test/script/basic/JDK-8027236.js.EXPECTED + test/src/jdk/nashorn/api/javaaccess/ConsStringTest.java Changeset: 144861e24260 Author: sundar Date: 2013-11-04 09:29 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/144861e24260 Merge From david.holmes at oracle.com Mon Nov 4 04:01:06 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 04 Nov 2013 12:01:06 +0000 Subject: hg: jdk8/tl/jdk: 8025198: Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Message-ID: <20131104120130.640326296D@hg.openjdk.java.net> Changeset: d19ab5da83cc Author: dholmes Date: 2013-11-04 06:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d19ab5da83cc 8025198: Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Reviewed-by: martin, dholmes Contributed-by: Tristan Yan ! makefiles/CompileLaunchers.gmk ! makefiles/lib/CoreLibraries.gmk ! src/share/bin/java.c ! test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java From david.holmes at oracle.com Mon Nov 4 04:10:16 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 04 Nov 2013 22:10:16 +1000 Subject: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java In-Reply-To: References: Message-ID: <52778EA8.7020800@oracle.com> My commit pulled in a bunch of local changes that should never have been pushed (the import commit failed due to whitespace and when I re-issued the commit I didn't restrict it to the single test file). Can anyone roll this back on the actual server? Thanks, David -------- Original Message -------- Subject: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Date: Mon, 4 Nov 2013 12:03:22 +0000 (UTC) From: HG Updates (JBS) To: david.holmes at oracle.com [ https://bugs.openjdk.java.net/browse/JDK-8025198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HG Updates resolved JDK-8025198. -------------------------------- Resolved In Build: team Fix Version/s: 8 Resolution: Fixed URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d19ab5da83cc User: dholmes Date: 2013-11-04 12:01:30 +0000 > Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java > ------------------------------------------------------------------------------------- > > Key: JDK-8025198 > URL: https://bugs.openjdk.java.net/browse/JDK-8025198 > Project: JDK > Issue Type: Bug > Components: core-libs > Affects Versions: 8 > Reporter: Amy Lu > Assignee: Tristan Yan > Labels: same-binary, sqebug, teststabilization > Fix For: 8 > > > TESTFAIL:java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java > java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java failing intermittently: > #section:main > ----------messages:(3/175)---------- > command: main -XX:-UseVMInterruptibleIO ThrowingTasks > reason: User specified action: run main/othervm -XX:-UseVMInterruptibleIO ThrowingTasks > elapsed time (seconds): 480.015 > ----------System.out:(0/0)---------- > ----------System.err:(0/0)---------- > result: Error. Program `/Users/aurora/sandbox_keepme/jdk/bin/java' interrupted! (timed out?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://bugs.openjdk.java.net/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira From Alan.Bateman at oracle.com Mon Nov 4 04:35:18 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 04 Nov 2013 12:35:18 +0000 Subject: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java In-Reply-To: <52778EA8.7020800@oracle.com> References: <52778EA8.7020800@oracle.com> Message-ID: <52779486.3000609@oracle.com> On 04/11/2013 12:10, David Holmes wrote: > My commit pulled in a bunch of local changes that should never have > been pushed (the import commit failed due to whitespace and when I > re-issued the commit I didn't restrict it to the single test file). > > Can anyone roll this back on the actual server? It might be simpler to just push another change that anti-deltas the launcher/other changes. That would get jdk8/tl fixed up before too many people are impacted. -Alan. From david.holmes at oracle.com Mon Nov 4 04:37:47 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 04 Nov 2013 22:37:47 +1000 Subject: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java In-Reply-To: <52779486.3000609@oracle.com> References: <52778EA8.7020800@oracle.com> <52779486.3000609@oracle.com> Message-ID: <5277951B.1040404@oracle.com> On 4/11/2013 10:35 PM, Alan Bateman wrote: > On 04/11/2013 12:10, David Holmes wrote: >> My commit pulled in a bunch of local changes that should never have >> been pushed (the import commit failed due to whitespace and when I >> re-issued the commit I didn't restrict it to the single test file). >> >> Can anyone roll this back on the actual server? > It might be simpler to just push another change that anti-deltas the > launcher/other changes. That would get jdk8/tl fixed up before too many > people are impacted. Okay RFR sent out to core-libs. Thanks Alan. Apologies for the mess and the noise. David > -Alan. From david.holmes at oracle.com Mon Nov 4 04:41:25 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 04 Nov 2013 12:41:25 +0000 Subject: hg: jdk8/tl/jdk: 8027755: Anti-delta incorrect push for 8025198 Message-ID: <20131104124146.37BAE6296E@hg.openjdk.java.net> Changeset: 23982079ad49 Author: dholmes Date: 2013-11-04 07:39 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23982079ad49 8027755: Anti-delta incorrect push for 8025198 Reviewed-by: alanb ! makefiles/CompileLaunchers.gmk ! makefiles/lib/CoreLibraries.gmk ! src/share/bin/java.c From jaroslav.bachorik at oracle.com Mon Nov 4 05:07:10 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 04 Nov 2013 14:07:10 +0100 Subject: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support Message-ID: <52779BFE.1080704@oracle.com> Please, review the following test change: Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ Currently, the test is designed to work only on solaris-32bit. With the support removed it is necessary to adapt the test as well. This includes generating the solaris-sparcv9 and solaris-amd64 binaries for the launcher the test is using. The test itself needs changing the way it retrieves the ARCH name for sparcv9 architecture. Also, since it is forbidden to check in any files with executable permissions the test must account for this and adjust the file permissions temporarily while executing. It needs to revert to the original permissions when it's finished to prevent reporting the launcher files as modified in HG. While testing the changes the sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing intermittently (50%) when run in agentvm mode together with CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests to run in othervm mode seems to fix the problem. There is a small debugging improvement in ProcessTools.java#startProcess() method - when the phaser timesout or is interrupted all the stack traces are dumped to stderr to help diagnosing any locking situations. Thanks, -JB- From staffan.larsen at oracle.com Mon Nov 4 06:41:39 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 4 Nov 2013 09:41:39 -0500 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command Message-ID: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> This is an old one! Nothing like being bored on a plane... The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints. While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored). There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done. webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-4660158 Thanks, /Staffan From brian.burkhalter at oracle.com Mon Nov 4 08:06:07 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Mon, 04 Nov 2013 16:06:07 +0000 Subject: hg: jdk8/tl/jdk: 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size Message-ID: <20131104160626.8E14E62976@hg.openjdk.java.net> Changeset: 92fb6baaebc4 Author: bpb Date: 2013-11-04 08:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92fb6baaebc4 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size Summary: Add @run tag to specify heap size Reviewed-by: alanb, dxu ! test/java/math/BigInteger/ExtremeShiftingTests.java From mattias.tobiasson at oracle.com Mon Nov 4 04:51:07 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Mon, 4 Nov 2013 04:51:07 -0800 (PST) Subject: RFR (XS): 8023138: TEST_BUG java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Message-ID: <881e62c7-9fe3-46ab-b94f-bbaa62ff7a34@default> Hi, Could you please review this fix. The tests for java/lang/instrument/PremainClass/PremainAgent has been ported from script to java. The purpose is to make the tests more stable and easier to maintain. Thanks, Mattias Webrev: http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8023138 From michael.x.mcmahon at oracle.com Mon Nov 4 09:49:36 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 04 Nov 2013 17:49:36 +0000 Subject: hg: jdk8/tl/jdk: 8027687: The constructors of URLPermission class do not behave as described in javad Message-ID: <20131104174948.41A6662979@hg.openjdk.java.net> Changeset: 48449b5390fa Author: michaelm Date: 2013-11-04 17:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48449b5390fa 8027687: The constructors of URLPermission class do not behave as described in javad Reviewed-by: chegar, mduigou ! src/share/classes/java/net/HostPortrange.java ! src/share/classes/java/net/URLPermission.java ! test/java/net/URLPermission/URLPermissionTest.java From mark.reinhold at oracle.com Mon Nov 4 10:05:48 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 04 Nov 2013 10:05:48 -0800 Subject: hg: jdk8/tl/jdk: 8027687: The constructors of URLPermission class do not behave as described in javad In-Reply-To: <20131104174948.41A6662979@hg.openjdk.java.net> References: <20131104174948.41A6662979@hg.openjdk.java.net> Message-ID: <20131104100548.539058@eggemoggin.niobe.net> 2013/11/4 1:49 -0800, michael.x.mcmahon at oracle.com: > Changeset: 48449b5390fa > Author: michaelm > Date: 2013-11-04 17:47 +0000 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48449b5390fa > > 8027687: The constructors of URLPermission class do not behave as described in javad > Reviewed-by: chegar, mduigou What is "javad"? - Mark From robert.field at oracle.com Mon Nov 4 10:12:43 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Mon, 04 Nov 2013 18:12:43 +0000 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... Message-ID: <20131104181255.459946297B@hg.openjdk.java.net> Changeset: 51b002381b35 Author: rfield Date: 2013-11-04 10:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class 8027681: Lambda serialization fails once reflection proxy generation kicks in Reviewed-by: ksrini, briangoetz, jfranck Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java From joel.franck at oracle.com Mon Nov 4 10:48:27 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Mon, 04 Nov 2013 18:48:27 +0000 Subject: hg: jdk8/tl/jdk: 8016725: TEST_BUG: java/lang/reflect/Method/DefaultMethodModeling.java failing intermittently Message-ID: <20131104184839.09ABA6297C@hg.openjdk.java.net> Changeset: 78a0dcde6b67 Author: alundblad Date: 2013-11-04 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78a0dcde6b67 8016725: TEST_BUG: java/lang/reflect/Method/DefaultMethodModeling.java failing intermittently Summary: Moved DefaultMethodModeling.java to its own directory to avoid conflicts with Equals.java. Reviewed-by: darcy - test/java/lang/reflect/Method/DefaultMethodModeling.java + test/java/lang/reflect/Method/defaultMethodModeling/DefaultMethodModeling.java From serguei.spitsyn at oracle.com Mon Nov 4 12:08:03 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 04 Nov 2013 12:08:03 -0800 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> Message-ID: <5277FEA3.4010101@oracle.com> Staffan, This one is really old: 11+ years. :) The fix is good, I do not see any issues. Thanks, Serguei On 11/4/13 6:41 AM, Staffan Larsen wrote: > This is an old one! Nothing like being bored on a plane... > > The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints. > > While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored). > > There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done. > > webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-4660158 > > Thanks, > /Staffan From dan.xu at oracle.com Mon Nov 4 15:48:23 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Mon, 04 Nov 2013 23:48:23 +0000 Subject: hg: jdk8/tl/jdk: 8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up stage Message-ID: <20131104234835.23B0562A32@hg.openjdk.java.net> Changeset: 6d1f3ba68db2 Author: dxu Date: 2013-11-04 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d1f3ba68db2 8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up stage Reviewed-by: chegar ! test/java/io/File/MaxPathLength.java From christine.lu at oracle.com Mon Nov 4 17:39:26 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Tue, 05 Nov 2013 01:39:26 +0000 Subject: hg: jdk8/tl/langtools: 8025844: Need test to provide coverage for new DocumentationTool.Location enum Message-ID: <20131105013930.5E02C62A44@hg.openjdk.java.net> Changeset: 106b8fa32d71 Author: cl Date: 2013-11-04 17:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/106b8fa32d71 8025844: Need test to provide coverage for new DocumentationTool.Location enum Reviewed-by: jjg + test/tools/javadoc/api/basic/DocumentationToolLocationTest.java From christine.lu at oracle.com Mon Nov 4 18:05:45 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Tue, 05 Nov 2013 02:05:45 +0000 Subject: hg: jdk8/tl/langtools: 8027411: javap tonga tests cleanup: write a java program to test invalid options -h and -b Message-ID: <20131105020548.ACB8262A47@hg.openjdk.java.net> Changeset: 658861d1b36e Author: cl Date: 2013-11-04 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/658861d1b36e 8027411: javap tonga tests cleanup: write a java program to test invalid options -h and -b Reviewed-by: jjg + test/tools/javap/InvalidOptions.java From christine.lu at oracle.com Mon Nov 4 18:52:45 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Tue, 05 Nov 2013 02:52:45 +0000 Subject: hg: jdk8/tl/langtools: 8027530: javap tonga tests cleanup: test -public, -protected, -package, -private options Message-ID: <20131105025248.5695E62A4C@hg.openjdk.java.net> Changeset: 126dc007ba3f Author: cl Date: 2013-11-04 18:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/126dc007ba3f 8027530: javap tonga tests cleanup: test -public, -protected, -package, -private options Reviewed-by: jjg + test/tools/javap/AccessModifiers.java From mandy.chung at oracle.com Mon Nov 4 19:20:53 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 04 Nov 2013 19:20:53 -0800 Subject: Review request for 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java In-Reply-To: <5272F80F.4070006@oracle.com> References: <52729901.8070604@oracle.com> <52729FF3.4020506@oracle.com> <5272AB6C.5030300@oracle.com> <5272F80F.4070006@oracle.com> Message-ID: <52786415.7090205@oracle.com> David, Rereading your comment and I think you misread the switch statement (see my comments below). In any case, I revisited ThreadStateController.java and looked int the potential races and have done further cleanup. Here is the updated webrev. http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.02/ I'll let them run longer to see if it can uncover any race. How does this version look? Mandy On 10/31/2013 5:38 PM, David Holmes wrote: > Hi Mandy, > > On 1/11/2013 5:11 AM, Mandy Chung wrote: >> Updated webrev that has a new >> test/lib/testlibrary/ThreadStateController.java and also change to use >> AtomicInteger: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/ > > Sorry but I don't see how this works - and that applies to the old > version too! (Which I know I've looked at before so this is somewhat > unsettling for me :( ). > > First I found it confusing to track which thread was which in the > refactoring (which in itself is a good idea). Inside > ThreadStateController "myThread" doesn't mean anything - that comes > from the calling context - I suggest changing to refer to "this > thread" or "the current thread" as appropriate. eg "Have the current > thread wait until this thread is about to block" or whatever is needed. > > Looking at an actual test we have eg: > > myThread.goWaiting(); > ThreadStateController.checkThreadState(myThread, Thread.State.WAITING); > > First: why is checkThreadState static rather than just an instance > method? > I'm happy with the new version of ThreadStateController.java with the above cleanup. > So goWaiting is supposed to tell myThread to go to a "waiting" state > so that the main thread can then verify that. Lets assume for > arguments sake that the thread is currently RUNNABLE so it is > currently looping around in run() doing the little math exercise. > goWaiting does: > > public void goWaiting() { > System.out.println("Waiting myThread to go waiting."); > setState(WAITING); > // wait for MyThread to get to just before wait on object. > phaser.arriveAndAwaitAdvance(); > } > > and setState does: > > case WAITING: > case TIMED_WAITING: > state = newState; > synchronized (lock) { > lock.notify(); > } > break; The switch statement is looking at the current state (i.e. RUNNABLE). The above WAITING and TIMED_WAITING cases indicate that this thread is in waiting and thus the request to transition to another state has first to notify this thread so that it can proceed with the state transition. > > > so as soon as we update "state" myThread is capable of changing what > it is doing in run() to: > > case WAITING: { > synchronized (lock) { > // signal main thread. > phaser.arrive(); > System.out.println(" myThread is going to wait."); > try { > lock.wait(); > } catch (InterruptedException e) { > // ignore > interrupted.incrementAndGet(); > } > } > break; > > so now we have a race between the two threads to see who can grab the > lock first. If it is the main thread then we issue a notify when > nothing is waiting and so the subsequent wait() by myThread will > potentially wait forever. At least in that case the main thread will > see that it is waiting! > If this thread is currently in WAITING state, the main thread calls goTimedWaiting, before it notifies this thread, this thread gets waken up due to spurious wakeup or interrupt, then the race depending on who grabs the lock first as you described above will happen. > If "myThread" wins the race it will wait after signalling the phaser > and the main thread will then issue the notify allowing myThread to > proceed (and do what? process the WAITING case again??). So there is > no guarantee that myThread will be waiting when the main thread checks > the state! > > Similarly for issuing the unpark in the parking cases. > > AFAICS the basic approach here should be: > - tell myThread to go to state X > - wait until myThread should be in state X > - verify myThread is in state X That's what the test does. > - allow myThread to escape from state X Is this really needed? This would require the main thread to notify myThread the verification is done. The test currently goes to the new state for validation and it seems to me that this isn't needed. Mandy From david.holmes at oracle.com Mon Nov 4 20:42:30 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 05 Nov 2013 14:42:30 +1000 Subject: Review request for 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java In-Reply-To: <52786415.7090205@oracle.com> References: <52729901.8070604@oracle.com> <52729FF3.4020506@oracle.com> <5272AB6C.5030300@oracle.com> <5272F80F.4070006@oracle.com> <52786415.7090205@oracle.com> Message-ID: <52787736.1090904@oracle.com> Hi Mandy, On 5/11/2013 1:20 PM, Mandy Chung wrote: > David, > > Rereading your comment and I think you misread the switch statement (see Yes I did - many times - sorry. > my comments below). In any case, I revisited ThreadStateController.java > and looked int the potential races and have done further cleanup. Here > is the updated webrev. > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.02/ > > I'll let them run longer to see if it can uncover any race. How does > this version look? This looks good to me. One nit that caused me some confusion - it took me a while to realize that in transitionTo eg: 221 public void transitionTo(Thread.State tstate) throws InterruptedException { 222 switch (tstate) { 223 case RUNNABLE: 224 nextState(RUNNABLE); 225 break; The case value, eg RUNNABLE, and the arg to nextState, eg RUNNABLE, are two completely different values! Can I suggest using S_xxx for the int states (why not an enum?). Typo: awaitArrive should be awaitAdvance Thanks, David > Mandy > > On 10/31/2013 5:38 PM, David Holmes wrote: >> Hi Mandy, >> >> On 1/11/2013 5:11 AM, Mandy Chung wrote: >>> Updated webrev that has a new >>> test/lib/testlibrary/ThreadStateController.java and also change to use >>> AtomicInteger: >>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/ >> >> Sorry but I don't see how this works - and that applies to the old >> version too! (Which I know I've looked at before so this is somewhat >> unsettling for me :( ). >> >> First I found it confusing to track which thread was which in the >> refactoring (which in itself is a good idea). Inside >> ThreadStateController "myThread" doesn't mean anything - that comes >> from the calling context - I suggest changing to refer to "this >> thread" or "the current thread" as appropriate. eg "Have the current >> thread wait until this thread is about to block" or whatever is needed. >> >> Looking at an actual test we have eg: >> >> myThread.goWaiting(); >> ThreadStateController.checkThreadState(myThread, Thread.State.WAITING); >> >> First: why is checkThreadState static rather than just an instance >> method? >> > > I'm happy with the new version of ThreadStateController.java with the > above cleanup. > >> So goWaiting is supposed to tell myThread to go to a "waiting" state >> so that the main thread can then verify that. Lets assume for >> arguments sake that the thread is currently RUNNABLE so it is >> currently looping around in run() doing the little math exercise. >> goWaiting does: >> >> public void goWaiting() { >> System.out.println("Waiting myThread to go waiting."); >> setState(WAITING); >> // wait for MyThread to get to just before wait on object. >> phaser.arriveAndAwaitAdvance(); >> } >> >> and setState does: >> >> case WAITING: >> case TIMED_WAITING: >> state = newState; >> synchronized (lock) { >> lock.notify(); >> } >> break; > > The switch statement is looking at the current state (i.e. RUNNABLE). > > The above WAITING and TIMED_WAITING cases indicate that this thread is > in waiting and thus the request to transition to another state has first > to notify this thread so that it can proceed with the state transition. > > >> >> >> so as soon as we update "state" myThread is capable of changing what >> it is doing in run() to: >> >> case WAITING: { >> synchronized (lock) { >> // signal main thread. >> phaser.arrive(); >> System.out.println(" myThread is going to wait."); >> try { >> lock.wait(); >> } catch (InterruptedException e) { >> // ignore >> interrupted.incrementAndGet(); >> } >> } >> break; >> >> so now we have a race between the two threads to see who can grab the >> lock first. If it is the main thread then we issue a notify when >> nothing is waiting and so the subsequent wait() by myThread will >> potentially wait forever. At least in that case the main thread will >> see that it is waiting! >> > > If this thread is currently in WAITING state, the main thread calls > goTimedWaiting, before it notifies this thread, this thread gets waken > up due to spurious wakeup or interrupt, then the race depending on who > grabs the lock first as you described above will happen. > >> If "myThread" wins the race it will wait after signalling the phaser >> and the main thread will then issue the notify allowing myThread to >> proceed (and do what? process the WAITING case again??). So there is >> no guarantee that myThread will be waiting when the main thread checks >> the state! >> >> Similarly for issuing the unpark in the parking cases. >> >> AFAICS the basic approach here should be: >> - tell myThread to go to state X >> - wait until myThread should be in state X >> - verify myThread is in state X > > That's what the test does. > >> - allow myThread to escape from state X > > Is this really needed? This would require the main thread to notify > myThread the verification is done. The test currently goes to the new > state for validation and it seems to me that this isn't needed. > > Mandy From sundararajan.athijegannathan at oracle.com Mon Nov 4 20:39:17 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 05 Nov 2013 04:39:17 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131105043919.E62D762A4D@hg.openjdk.java.net> Changeset: dcedc753fd09 Author: sundar Date: 2013-11-04 18:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dcedc753fd09 8027753: Support ScriptObject to JSObject, ScriptObjectMirror, Map, Bindings auto-conversion as well as explicit wrap, unwrap Reviewed-by: jlaskey, hannesw, attila ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java + test/script/basic/JDK-8027753.js + test/script/basic/JDK-8027753.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/api/scripting/Window.java Changeset: b0d4ef6fb2db Author: sundar Date: 2013-11-05 09:13 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b0d4ef6fb2db Merge From peter.levart at gmail.com Tue Nov 5 00:25:57 2013 From: peter.levart at gmail.com (Peter Levart) Date: Tue, 05 Nov 2013 09:25:57 +0100 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <20131104181255.459946297B@hg.openjdk.java.net> References: <20131104181255.459946297B@hg.openjdk.java.net> Message-ID: <5278AB95.6000707@gmail.com> Hi Robert, I think this fix is not complete. When one sets the system property sun.reflect.noInflation=true, reflection proxy is still attempted to be generated for anonymous classes (see ReflectionFactory.newMethodAccessor/newConstructorAccessor). I would also restructure the Method/Constructor accessor logic differently. The check for ReflectUtil.isVMAnonymousClass() can be performed just once (in the newMethodAccessor/newConstructorAccessor methods) and based on this check, create accessor: - for classic declaring class - as is / unchanged - for anonymous declaring class - just create and return NativeMethodAccessorImpl without a parent Then in NativeMethodAccessorImpl (and same for constructor), modify the inflation checking logic: if (*parent != null && *++numInvocations > ReflectionFactory.inflationThreshold()) { MethodAccessorImpl acc = (MethodAccessorImpl) new MethodAccessorGenerator(). generateMethod(method.getDeclaringClass(), method.getName(), method.getParameterTypes(), method.getReturnType(), method.getExceptionTypes(), method.getModifiers()); parent.setDelegate(acc); } Regards, Peter On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: > Changeset: 51b002381b35 > Author: rfield > Date: 2013-11-04 10:12 -0800 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 > > 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class > 8027681: Lambda serialization fails once reflection proxy generation kicks in > Reviewed-by: ksrini, briangoetz, jfranck > Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com > > ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java > ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java > ! src/share/classes/sun/reflect/misc/ReflectUtil.java > + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java > ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java > + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131105/843ef925/attachment.html From peter.levart at gmail.com Tue Nov 5 00:55:24 2013 From: peter.levart at gmail.com (Peter Levart) Date: Tue, 05 Nov 2013 09:55:24 +0100 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <20131104181255.459946297B@hg.openjdk.java.net> References: <20131104181255.459946297B@hg.openjdk.java.net> Message-ID: <5278B27C.30303@gmail.com> On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: > Changeset: 51b002381b35 > Author: rfield > Date: 2013-11-04 10:12 -0800 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 > > 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class > 8027681: Lambda serialization fails once reflection proxy generation kicks in > Reviewed-by: ksrini, briangoetz, jfranck > Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com > > ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java > ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java > ! src/share/classes/sun/reflect/misc/ReflectUtil.java > + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java > ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java > + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java > Hi Robert, I also propose a much faster variant of: + /** + * Checks if {@code Class cls} is a VM-anonymous class + * as defined by {@link sun.misc.Unsafe#defineAnonymousClass} + * (not to be confused with a Java Language anonymous inner class). + */ + public static boolean isVMAnonymousClass(Class cls) { + return cls.getSimpleName().contains("/"); + } The following: public static boolean isVMAnonymousClassFAST(Class cls) { String name = cls.getName(); for (int i = name.length() - 1; i >= 0; i--) { char c = name.charAt(i); if (c == '.') return false; if (c == '/') return true; } return false; // root package } It's about 12..25x faster for typical class names and doesn't produce any garbage. Regards, Peter -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131105/bc633df5/attachment.html From konstantin.shefov at oracle.com Tue Nov 5 01:10:22 2013 From: konstantin.shefov at oracle.com (konstantin.shefov at oracle.com) Date: Tue, 05 Nov 2013 09:10:22 +0000 Subject: hg: jdk8/tl/nashorn: 8027708: NASHORN TEST: Create Nashorn test that draws image step-by-step using JavaFX canvas. Message-ID: <20131105091023.DAE5162A58@hg.openjdk.java.net> Changeset: bda654c6d59c Author: kshefov Date: 2013-11-05 13:09 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bda654c6d59c 8027708: NASHORN TEST: Create Nashorn test that draws image step-by-step using JavaFX canvas. Reviewed-by: jlaskey, lagergren ! make/build.xml ! make/project.properties ! test/script/jfx.js ! test/script/jfx/flyingimage.js ! test/script/jfx/flyingimage/flyingimage.png ! test/script/jfx/flyingimage/golden/linux.png ! test/script/jfx/flyingimage/golden/macosx.png ! test/script/jfx/flyingimage/golden/windows.png ! test/script/jfx/kaleidoscope.js ! test/script/jfx/kaleidoscope/golden/linux.png ! test/script/jfx/kaleidoscope/golden/macosx.png ! test/script/jfx/kaleidoscope/golden/windows.png + test/script/jfx/spread.js + test/script/jfx/spread/golden/linux.png + test/script/jfx/spread/golden/macosx.png + test/script/jfx/spread/golden/windows.png From brian.goetz at oracle.com Tue Nov 5 01:10:23 2013 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 5 Nov 2013 09:10:23 +0000 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <5278B27C.30303@gmail.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> Message-ID: <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> Ineexof(char) sounds like as fast and simpler? Sent from my iPhone On Nov 5, 2013, at 8:55 AM, Peter Levart wrote: > On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: >> Changeset: 51b002381b35 >> Author: rfield >> Date: 2013-11-04 10:12 -0800 >> URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 >> >> 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class >> 8027681: Lambda serialization fails once reflection proxy generation kicks in >> Reviewed-by: ksrini, briangoetz, jfranck >> Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com >> >> ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java >> ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java >> ! src/share/classes/sun/reflect/misc/ReflectUtil.java >> + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java >> ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java >> + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java >> > Hi Robert, > > I also propose a much faster variant of: > > + /** > + * Checks if {@code Class cls} is a VM-anonymous class > + * as defined by {@link sun.misc.Unsafe#defineAnonymousClass} > + * (not to be confused with a Java Language anonymous inner class). > + */ > + public static boolean isVMAnonymousClass(Class cls) { > + return cls.getSimpleName().contains("/"); > + } > > > The following: > > public static boolean isVMAnonymousClassFAST(Class cls) { > String name = cls.getName(); > for (int i = name.length() - 1; i >= 0; i--) { > char c = name.charAt(i); > if (c == '.') return false; > if (c == '/') return true; > } > return false; // root package > } > > It's about 12..25x faster for typical class names and doesn't produce any garbage. > > > Regards, Peter > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131105/3c6f732e/attachment.html From peter.levart at gmail.com Tue Nov 5 01:28:31 2013 From: peter.levart at gmail.com (Peter Levart) Date: Tue, 05 Nov 2013 10:28:31 +0100 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <5278B27C.30303@gmail.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> Message-ID: <5278BA3F.3070602@gmail.com> Hi John, Speaking of names, the following test: package pkg; public class Test { public static void main(String[] args) { Runnable r = () -> {}; Class c = r.getClass(); Class ac = java.lang.reflect.Array.newInstance(c, 0).getClass(); System.out.println("c: " + c.getName() + " / " + c.getSimpleName()); System.out.println("ac: " + ac.getName() + " / " + ac.getSimpleName()); } } Prints: c: pkg.Test$$Lambda$1/798154996 / Test$$Lambda$1/798154996 ac: [Lpkg.Test$$Lambda$1; / Test$$Lambda$1/798154996[] I think the array class name is missing the trailing '/798154996' just before ';' Regards, Peter On 11/05/2013 09:55 AM, Peter Levart wrote: > On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: >> Changeset: 51b002381b35 >> Author: rfield >> Date: 2013-11-04 10:12 -0800 >> URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 >> >> 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class >> 8027681: Lambda serialization fails once reflection proxy generation kicks in >> Reviewed-by: ksrini, briangoetz, jfranck >> Contributed-by:joel.franck at oracle.com,brian.goetz at oracle.com,robert.field at oracle.com >> >> ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java >> ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java >> ! src/share/classes/sun/reflect/misc/ReflectUtil.java >> + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java >> ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java >> + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java >> > Hi Robert, > > I also propose a much faster variant of: > > + /** > + * Checks if {@code Class cls} is a VM-anonymous class > + * as defined by {@link sun.misc.Unsafe#defineAnonymousClass} > + * (not to be confused with a Java Language anonymous inner class). > + */ > + public static boolean isVMAnonymousClass(Class cls) { > + return cls.getSimpleName().contains("/"); > + } > > > The following: > > public static boolean isVMAnonymousClassFAST(Class cls) { > String name = cls.getName(); > for (int i = name.length() - 1; i >= 0; i--) { > char c = name.charAt(i); > if (c == '.') return false; > if (c == '/') return true; > } > return false; // root package > } > > It's about 12..25x faster for typical class names and doesn't produce > any garbage. > > > Regards, Peter > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131105/6c9788f6/attachment-0001.html From chris.hegarty at oracle.com Tue Nov 5 02:23:09 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 05 Nov 2013 10:23:09 +0000 Subject: Review request for 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java In-Reply-To: <52786415.7090205@oracle.com> References: <52729901.8070604@oracle.com> <52729FF3.4020506@oracle.com> <5272AB6C.5030300@oracle.com> <5272F80F.4070006@oracle.com> <52786415.7090205@oracle.com> Message-ID: <5278C70D.8030207@oracle.com> On 05/11/2013 03:20, Mandy Chung wrote: > David, > > Rereading your comment and I think you misread the switch statement (see > my comments below). In any case, I revisited ThreadStateController.java > and looked int the potential races and have done further cleanup. Here > is the updated webrev. > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.02/ The latest webrev looks good to me. As the last person to touch java/lang/Thread/ThreadStateTest.java, retrofitting it with Phaser. I can only apologize for not updating java/lang/management/ThreadMXBean/ThreadStateTest.java then. Thanks for doing this now, as part of this bug. -Chris. > > I'll let them run longer to see if it can uncover any race. How does > this version look? > > Mandy > > On 10/31/2013 5:38 PM, David Holmes wrote: >> Hi Mandy, >> >> On 1/11/2013 5:11 AM, Mandy Chung wrote: >>> Updated webrev that has a new >>> test/lib/testlibrary/ThreadStateController.java and also change to use >>> AtomicInteger: >>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/ >> >> Sorry but I don't see how this works - and that applies to the old >> version too! (Which I know I've looked at before so this is somewhat >> unsettling for me :( ). >> >> First I found it confusing to track which thread was which in the >> refactoring (which in itself is a good idea). Inside >> ThreadStateController "myThread" doesn't mean anything - that comes >> from the calling context - I suggest changing to refer to "this >> thread" or "the current thread" as appropriate. eg "Have the current >> thread wait until this thread is about to block" or whatever is needed. >> >> Looking at an actual test we have eg: >> >> myThread.goWaiting(); >> ThreadStateController.checkThreadState(myThread, Thread.State.WAITING); >> >> First: why is checkThreadState static rather than just an instance >> method? >> > > I'm happy with the new version of ThreadStateController.java with the > above cleanup. > >> So goWaiting is supposed to tell myThread to go to a "waiting" state >> so that the main thread can then verify that. Lets assume for >> arguments sake that the thread is currently RUNNABLE so it is >> currently looping around in run() doing the little math exercise. >> goWaiting does: >> >> public void goWaiting() { >> System.out.println("Waiting myThread to go waiting."); >> setState(WAITING); >> // wait for MyThread to get to just before wait on object. >> phaser.arriveAndAwaitAdvance(); >> } >> >> and setState does: >> >> case WAITING: >> case TIMED_WAITING: >> state = newState; >> synchronized (lock) { >> lock.notify(); >> } >> break; > > The switch statement is looking at the current state (i.e. RUNNABLE). > > The above WAITING and TIMED_WAITING cases indicate that this thread is > in waiting and thus the request to transition to another state has first > to notify this thread so that it can proceed with the state transition. > > >> >> >> so as soon as we update "state" myThread is capable of changing what >> it is doing in run() to: >> >> case WAITING: { >> synchronized (lock) { >> // signal main thread. >> phaser.arrive(); >> System.out.println(" myThread is going to wait."); >> try { >> lock.wait(); >> } catch (InterruptedException e) { >> // ignore >> interrupted.incrementAndGet(); >> } >> } >> break; >> >> so now we have a race between the two threads to see who can grab the >> lock first. If it is the main thread then we issue a notify when >> nothing is waiting and so the subsequent wait() by myThread will >> potentially wait forever. At least in that case the main thread will >> see that it is waiting! >> > > If this thread is currently in WAITING state, the main thread calls > goTimedWaiting, before it notifies this thread, this thread gets waken > up due to spurious wakeup or interrupt, then the race depending on who > grabs the lock first as you described above will happen. > >> If "myThread" wins the race it will wait after signalling the phaser >> and the main thread will then issue the notify allowing myThread to >> proceed (and do what? process the WAITING case again??). So there is >> no guarantee that myThread will be waiting when the main thread checks >> the state! >> >> Similarly for issuing the unpark in the parking cases. >> >> AFAICS the basic approach here should be: >> - tell myThread to go to state X >> - wait until myThread should be in state X >> - verify myThread is in state X > > That's what the test does. > >> - allow myThread to escape from state X > > Is this really needed? This would require the main thread to notify > myThread the verification is done. The test currently goes to the new > state for validation and it seems to me that this isn't needed. > > Mandy From paul.sandoz at oracle.com Tue Nov 5 03:09:13 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 05 Nov 2013 11:09:13 +0000 Subject: hg: jdk8/tl/jdk: 8027712: DistinctOpTest fails for unordered test Message-ID: <20131105111041.08F5862A5C@hg.openjdk.java.net> Changeset: d5b3f83ffc40 Author: psandoz Date: 2013-11-05 12:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5b3f83ffc40 8027712: DistinctOpTest fails for unordered test Reviewed-by: henryjen, alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java From erik.gahlin at oracle.com Tue Nov 5 07:28:56 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 05 Nov 2013 16:28:56 +0100 Subject: RFR: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java, Message-ID: <52790EB8.1040907@oracle.com> Could I please have a review, fix is to run test in separate vm. I also removed warnings and allowed the exception to propagate. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/6959636_1/ Bug: https://bugs.openjdk.java.net/browse/JDK-6959636 From erik.gahlin at oracle.com Tue Nov 5 07:57:36 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 05 Nov 2013 16:57:36 +0100 Subject: RFR: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently In-Reply-To: <5271141C.3030400@oracle.com> References: <5271141C.3030400@oracle.com> Message-ID: <52791570.50602@oracle.com> Could I have a review of this intermittently failing test. Instead of doing Thread.sleep(2000) and assume principal is visible/set the test now spins until principal is available. I also cleaned up code to avoid warnings. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/8027209_3/ Bug: https://bugs.openjdk.java.net/browse/JDK-8027209 From erik.gahlin at oracle.com Tue Nov 5 08:25:47 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 05 Nov 2013 17:25:47 +0100 Subject: RFR: 6543856: MonitorVmStartTerminate.sh fails intermittently Message-ID: <52791C0B.9010101@oracle.com> Could I please have a review of this intermittently failing test. Removed Thread.sleep and instead used two count down latches. Also did some cleaning up; removed an unused import, added generics etc. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/6543856_1/ Bug: https://bugs.openjdk.java.net/browse/JDK-6543856 From jaroslav.bachorik at oracle.com Tue Nov 5 08:25:34 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 05 Nov 2013 17:25:34 +0100 Subject: RFR: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java, In-Reply-To: <52790EB8.1040907@oracle.com> References: <52790EB8.1040907@oracle.com> Message-ID: <52791BFE.4060509@oracle.com> Looks fine (not-a reviewer) -JB- On 5.11.2013 16:28, Erik Gahlin wrote: > Could I please have a review, fix is to run test in separate vm. > > I also removed warnings and allowed the exception to propagate. > > Thanks > Erik > > Webrev: > http://cr.openjdk.java.net/~egahlin/6959636_1/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6959636 > > From staffan.larsen at oracle.com Tue Nov 5 10:16:42 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 5 Nov 2013 13:16:42 -0500 Subject: RFR: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java, In-Reply-To: <52790EB8.1040907@oracle.com> References: <52790EB8.1040907@oracle.com> Message-ID: <66E97D56-9139-415C-99E2-0B6D1F760D70@oracle.com> Looks good! Thanks, /Staffan On 5 nov 2013, at 10:28, Erik Gahlin wrote: > Could I please have a review, fix is to run test in separate vm. > > I also removed warnings and allowed the exception to propagate. > > Thanks > Erik > > Webrev: > http://cr.openjdk.java.net/~egahlin/6959636_1/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6959636 > > From staffan.larsen at oracle.com Tue Nov 5 10:23:34 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 5 Nov 2013 13:23:34 -0500 Subject: jmx-dev RFR: 6543856: MonitorVmStartTerminate.sh fails intermittently In-Reply-To: <52791C0B.9010101@oracle.com> References: <52791C0B.9010101@oracle.com> Message-ID: <242E126D-BF7F-44EB-8531-9D996CBDCF5E@oracle.com> Looks good! Thanks, /Staffan On 5 nov 2013, at 11:25, Erik Gahlin wrote: > Could I please have a review of this intermittently failing test. > > Removed Thread.sleep and instead used two count down latches. Also did some cleaning up; removed an unused import, added generics etc. > > Thanks > Erik > > Webrev: > http://cr.openjdk.java.net/~egahlin/6543856_1/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6543856 From huizhe.wang at oracle.com Tue Nov 5 11:44:50 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 05 Nov 2013 19:44:50 +0000 Subject: hg: jdk8/tl/jdk: 8027860: [TEST_BUG] File not closed in javax/xml/jaxp/parsers/8022548/XOMParserTest.java Message-ID: <20131105194503.8AA7C62A6C@hg.openjdk.java.net> Changeset: a8a044db575c Author: joehw Date: 2013-11-05 11:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8a044db575c 8027860: [TEST_BUG] File not closed in javax/xml/jaxp/parsers/8022548/XOMParserTest.java Reviewed-by: alanb ! test/javax/xml/jaxp/parsers/8022548/XOMParserTest.java From mandy.chung at oracle.com Tue Nov 5 13:58:38 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 05 Nov 2013 13:58:38 -0800 Subject: Review request for 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java In-Reply-To: <52787736.1090904@oracle.com> References: <52729901.8070604@oracle.com> <52729FF3.4020506@oracle.com> <5272AB6C.5030300@oracle.com> <5272F80F.4070006@oracle.com> <52786415.7090205@oracle.com> <52787736.1090904@oracle.com> Message-ID: <52796A0E.9030709@oracle.com> On 11/4/2013 8:42 PM, David Holmes wrote: > This looks good to me. One nit that caused me some confusion - it took > me a while to realize that in transitionTo eg: > > 221 public void transitionTo(Thread.State tstate) throws > InterruptedException { > 222 switch (tstate) { > 223 case RUNNABLE: > 224 nextState(RUNNABLE); > 225 break; > > The case value, eg RUNNABLE, and the arg to nextState, eg RUNNABLE, > are two completely different values! Can I suggest using S_xxx for the > int states (why not an enum?). > Good suggestion to rename them. I considered adding an enum class that might confuse with Thread.State enum and so decided to leave them as it is. > Typo: awaitArrive should be awaitAdvance Fixed. This updated webrev also fixes ThreadMXBeanStateTest to retry getting ThreadInfo and improves the formatting of the output and include thread ID in the output: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.03/ This version has got 1000 successful runs of both tests with and without -Xcomp. thanks for the review. Mandy From david.holmes at oracle.com Tue Nov 5 16:52:37 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 06 Nov 2013 10:52:37 +1000 Subject: jmx-dev RFR: 6543856: MonitorVmStartTerminate.sh fails intermittently In-Reply-To: <242E126D-BF7F-44EB-8531-9D996CBDCF5E@oracle.com> References: <52791C0B.9010101@oracle.com> <242E126D-BF7F-44EB-8531-9D996CBDCF5E@oracle.com> Message-ID: <527992D5.50408@oracle.com> Hi Erik, From what I can see this test will no longer try to check that the number of sleepers started and terminated are valid - it will either pass or hang (because the latches do not release) - relying on the test harness to time it out (ditto for the removal of the timeout from the ss.join()). It seems to me that you could have simplified the changes (and kept the existing failure modes) if you had simply added a semaphore.acquire in main after ss.join and before listener.getStarted; with the semaphore release at the end of vmStatusChanged. But what you have isn't wrong. Aside: The CountDownLatch usage is a little odd as the typical pattern is that different threads call countDown. The same semantics could have been achieved with a Semaphore initialized to zero and using acquire(count) and release(recentlyTerminated) etc. Two minor nits: - for(Integer lvmid : list) - need space after for (line 92 and 207) - waitForSleeperToStart() should be waitForSleepersToStart (plural to match termination function). Otherwise good to go (unless you choose to revisit the approach taken :) ). Thanks, David On 6/11/2013 4:23 AM, Staffan Larsen wrote: > Looks good! > > Thanks, > /Staffan > > On 5 nov 2013, at 11:25, Erik Gahlin wrote: > >> Could I please have a review of this intermittently failing test. >> >> Removed Thread.sleep and instead used two count down latches. Also did some cleaning up; removed an unused import, added generics etc. >> >> Thanks >> Erik >> >> Webrev: >> http://cr.openjdk.java.net/~egahlin/6543856_1/ >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6543856 > From david.holmes at oracle.com Tue Nov 5 17:07:08 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 06 Nov 2013 11:07:08 +1000 Subject: Review request for 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java In-Reply-To: <52796A0E.9030709@oracle.com> References: <52729901.8070604@oracle.com> <52729FF3.4020506@oracle.com> <5272AB6C.5030300@oracle.com> <5272F80F.4070006@oracle.com> <52786415.7090205@oracle.com> <52787736.1090904@oracle.com> <52796A0E.9030709@oracle.com> Message-ID: <5279963C.7050406@oracle.com> Thanks Mandy. One minor nit: Having goSleep be an instance method on ThreadStateController makes the usage look weird: thread.goSleep(10); // actually makes current thread go sleep I suggest making it static and use static import to shorten the call site :) If you do change that, no need for re-review. David On 6/11/2013 7:58 AM, Mandy Chung wrote: > On 11/4/2013 8:42 PM, David Holmes wrote: >> This looks good to me. One nit that caused me some confusion - it took >> me a while to realize that in transitionTo eg: >> >> 221 public void transitionTo(Thread.State tstate) throws >> InterruptedException { >> 222 switch (tstate) { >> 223 case RUNNABLE: >> 224 nextState(RUNNABLE); >> 225 break; >> >> The case value, eg RUNNABLE, and the arg to nextState, eg RUNNABLE, >> are two completely different values! Can I suggest using S_xxx for the >> int states (why not an enum?). >> > > Good suggestion to rename them. I considered adding an enum class that > might confuse with Thread.State enum and so decided to leave them as it is. > >> Typo: awaitArrive should be awaitAdvance > > Fixed. > > This updated webrev also fixes ThreadMXBeanStateTest to retry getting > ThreadInfo and improves the formatting of the output and include thread > ID in the output: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.03/ > > This version has got 1000 successful runs of both tests with and without > -Xcomp. > > thanks for the review. > Mandy From mandy.chung at oracle.com Tue Nov 5 17:35:04 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 05 Nov 2013 17:35:04 -0800 Subject: Review request for 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java In-Reply-To: <5279963C.7050406@oracle.com> References: <52729901.8070604@oracle.com> <52729FF3.4020506@oracle.com> <5272AB6C.5030300@oracle.com> <5272F80F.4070006@oracle.com> <52786415.7090205@oracle.com> <52787736.1090904@oracle.com> <52796A0E.9030709@oracle.com> <5279963C.7050406@oracle.com> Message-ID: <52799CC8.2020509@oracle.com> On 11/5/2013 5:07 PM, David Holmes wrote: > Thanks Mandy. > > One minor nit: > > Having goSleep be an instance method on ThreadStateController makes > the usage look weird: > > thread.goSleep(10); // actually makes current thread go sleep > Good catch. I changed it to a static pause(long ms) method. Changeset pushed. thanks for the review. Mandy > I suggest making it static and use static import to shorten the call > site :) > > If you do change that, no need for re-review. > > David > > On 6/11/2013 7:58 AM, Mandy Chung wrote: >> On 11/4/2013 8:42 PM, David Holmes wrote: >>> This looks good to me. One nit that caused me some confusion - it took >>> me a while to realize that in transitionTo eg: >>> >>> 221 public void transitionTo(Thread.State tstate) throws >>> InterruptedException { >>> 222 switch (tstate) { >>> 223 case RUNNABLE: >>> 224 nextState(RUNNABLE); >>> 225 break; >>> >>> The case value, eg RUNNABLE, and the arg to nextState, eg RUNNABLE, >>> are two completely different values! Can I suggest using S_xxx for the >>> int states (why not an enum?). >>> >> >> Good suggestion to rename them. I considered adding an enum class that >> might confuse with Thread.State enum and so decided to leave them as >> it is. >> >>> Typo: awaitArrive should be awaitAdvance >> >> Fixed. >> >> This updated webrev also fixes ThreadMXBeanStateTest to retry getting >> ThreadInfo and improves the formatting of the output and include thread >> ID in the output: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.03/ >> >> This version has got 1000 successful runs of both tests with and without >> -Xcomp. >> >> thanks for the review. >> Mandy From mandy.chung at oracle.com Tue Nov 5 17:33:35 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 06 Nov 2013 01:33:35 +0000 Subject: hg: jdk8/tl/jdk: 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java; ... Message-ID: <20131106013347.C2A5E62A89@hg.openjdk.java.net> Changeset: 85fd2ae0a845 Author: mchung Date: 2013-11-05 17:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85fd2ae0a845 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java 6944188: ThreadMXBean/ThreadStateTest.java fails intermittently Reviewed-by: dholmes, chegar + test/java/lang/Thread/ThreadStateController.java ! test/java/lang/Thread/ThreadStateTest.java + test/java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java - test/java/lang/management/ThreadMXBean/ThreadStateTest.java From jan.lahoda at oracle.com Wed Nov 6 08:50:37 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Wed, 06 Nov 2013 16:50:37 +0000 Subject: hg: jdk8/tl/langtools: 8027281: Incorrect invokespecial generated for JCK lang EXPR/expr636/expr63602m* tests Message-ID: <20131106165047.9E584623C6@hg.openjdk.java.net> Changeset: 75c8cde12ab6 Author: jlahoda Date: 2013-11-06 17:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75c8cde12ab6 8027281: Incorrect invokespecial generated for JCK lang EXPR/expr636/expr63602m* tests Summary: When invoking interface default method via a superclass, use the direct superclass in the reference. Reviewed-by: vromero, dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/defaultMethods/super/TestDirectSuperInterfaceInvoke.java From taras.ledkov at oracle.com Wed Nov 6 06:04:29 2013 From: taras.ledkov at oracle.com (taras ledkov) Date: Wed, 06 Nov 2013 18:04:29 +0400 Subject: RFR for JDK-7195249 Some jtreg tests use hard coded ports Message-ID: <527A4C6D.8040804@oracle.com> Hi Everyone I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. Based on my colleagues' research, Root cause: hotspot/test/runtime/6294277/SourceDebugExtension.java jdk/test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.java jdk/test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java jdk/test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh jdk/test/sun/management/jmxremote/bootstrap/LocalManagementTest.java fails intermittently because of use of fixed ports. These ports could be busy at some configurations. Suggested fix: 1. My recommendation would be to convert the only shell test (SSLConfigFilePermissionTest.sh) into Java based test and re-use the dynamic port allocation solutionjdk/test/lib/testlibrary/jdk/testlibrary/Utils.getFreePort() to address the issue for JDK tests. Staffan Larsen recommends to use this solution instead of java/rmi/testlibrary/TestLibrary.getUnusedRandomPort(). 2. For hotspot tests I cannot find appropriate test utils (witch provide getFreePort() functionality). There are several options: - copy whole library jdk/test/lib/testlibrary/jdk/testlibrary/ to hotspot repository; - copy one class jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java to hotspot repository; - copy one method from class jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java (Utils.getFreePort()) to hotspot repository; - move the library jdk/test/lib/testlibrary/jdk/testlibrary/ to a place that can be shared between hotspot & jdk tests (if such place exists). 3. SourceDebugExtension test uses jtreg tag @run with hard coded port in jvm options. The test must be converted to test with java based test launcher and test application (e.g. like the test LocalManagementTest.java). Please let me know any comments or suggestions. Thank you -- With best regards, Taras Ledkov Mail-To: taras.ledkov at oracle.com skype: taras_ledkov Phone: 7(812)3346-157 From mike.duigou at oracle.com Wed Nov 6 09:50:48 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 06 Nov 2013 17:50:48 +0000 Subject: hg: jdk8/tl/jdk: 8021309: replace test/Makefile jdk_* targets with jtreg groups; ... Message-ID: <20131106175102.D607F623C9@hg.openjdk.java.net> Changeset: 9c30cbc316e9 Author: mduigou Date: 2013-11-05 19:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c30cbc316e9 8021309: replace test/Makefile jdk_* targets with jtreg groups 8015068: Use jtreg -exclude for handling problemList.txt exclusions Reviewed-by: jjg, smarks, chegar, alanb, dholmes ! .hgignore ! test/Makefile From peter.levart at gmail.com Wed Nov 6 11:30:25 2013 From: peter.levart at gmail.com (Peter Levart) Date: Wed, 06 Nov 2013 20:30:25 +0100 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> Message-ID: <527A98D1.4080906@gmail.com> On 11/05/2013 10:10 AM, Brian Goetz wrote: > Ineexof(char) sounds like as fast and simpler? Well, indexOf(char) or lastIndexOf(char) searches for a single char. We can do better searching backwards for two chars at the same time. If the "name" of VM-anonymous class is always ending with pattern: "slash followed by some decimal digits" then the following would be even faster: public static boolean isVMAnonymousClassFAST(Class cls) { String name = cls.getName(); for (int i = name.length() - 1; i >= 0; i--) { char c = name.charAt(i); if (c == '/') return true; if (c < '0' || c > '9') return false; } return false; } Regards, Peter > > Sent from my iPhone > > On Nov 5, 2013, at 8:55 AM, Peter Levart > wrote: > >> On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: >>> Changeset: 51b002381b35 >>> Author: rfield >>> Date: 2013-11-04 10:12 -0800 >>> URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 >>> >>> 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class >>> 8027681: Lambda serialization fails once reflection proxy generation kicks in >>> Reviewed-by: ksrini, briangoetz, jfranck >>> Contributed-by:joel.franck at oracle.com,brian.goetz at oracle.com,robert.field at oracle.com >>> >>> ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java >>> ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java >>> ! src/share/classes/sun/reflect/misc/ReflectUtil.java >>> + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java >>> ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java >>> + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java >>> >> Hi Robert, >> >> I also propose a much faster variant of: >> >> + /** >> + * Checks if {@code Class cls} is a VM-anonymous class >> + * as defined by {@link sun.misc.Unsafe#defineAnonymousClass} >> + * (not to be confused with a Java Language anonymous inner class). >> + */ >> + public static boolean isVMAnonymousClass(Class cls) { >> + return cls.getSimpleName().contains("/"); >> + } >> >> >> The following: >> >> public static boolean isVMAnonymousClassFAST(Class cls) { >> String name = cls.getName(); >> for (int i = name.length() - 1; i >= 0; i--) { >> char c = name.charAt(i); >> if (c == '.') return false; >> if (c == '/') return true; >> } >> return false; // root package >> } >> >> It's about 12..25x faster for typical class names and doesn't produce >> any garbage. >> >> >> Regards, Peter >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131106/af56a34a/attachment-0001.html From dan.xu at oracle.com Wed Nov 6 13:26:25 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Wed, 06 Nov 2013 21:26:25 +0000 Subject: hg: jdk8/tl/jdk: 8025698: (fs) Typo in exception thrown by encode() in UnixPath.java Message-ID: <20131106212658.DEC6E623DA@hg.openjdk.java.net> Changeset: 6ea1f9d8ec78 Author: dxu Date: 2013-11-06 13:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ea1f9d8ec78 8025698: (fs) Typo in exception thrown by encode() in UnixPath.java Reviewed-by: dxu, mduigou, henryjen, weijun Contributed-by: ajuckel at gmail.com ! src/solaris/classes/sun/nio/fs/UnixPath.java From kumar.x.srinivasan at oracle.com Wed Nov 6 15:34:56 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 06 Nov 2013 23:34:56 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131106233521.C1A77623E4@hg.openjdk.java.net> Changeset: 81cbdd5876e8 Author: ksrini Date: 2013-11-06 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81cbdd5876e8 8027227: [asm] generate CONSTANT_InterfaceMethodref for invoke{special/static) of non-abstract methods on ifaces Reviewed-by: ksrini, lagergren Contributed-by: ebruneton at free.fr, forax at univ-mlv.fr, john.r.rose at oracle.com, paul.sandoz at oracle.com ! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/version.txt Changeset: dbda97d6aa3a Author: ksrini Date: 2013-11-06 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dbda97d6aa3a 8027232: Update j.l.invoke code generating class files to use ASM enhancements for invocation of non-abstract methods on ifaces Reviewed-by: ksrini, rfield Contributed-by: john.r.rose at oracle.com, paul.sandoz at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java + test/java/lang/invoke/lambda/LambdaAsm.java From john.r.rose at oracle.com Wed Nov 6 17:20:39 2013 From: john.r.rose at oracle.com (John Rose) Date: Wed, 6 Nov 2013 17:20:39 -0800 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <527A98D1.4080906@gmail.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> <527A98D1.4080906@gmail.com> Message-ID: <5AAEA553-6A71-43FD-A7BA-A001BA2D5128@oracle.com> On Nov 6, 2013, at 11:30 AM, Peter Levart wrote: > Well, indexOf(char) or lastIndexOf(char) searches for a single char. We can do better searching backwards for two chars at the same time. > > If the "name" of VM-anonymous class is always ending with pattern: "slash followed by some decimal digits" then the following would be even faster: Although this reasoning is plausible, it is not a reliable conclusion, and should not drive edits of Java code without careful measurement. The reasoning assumes a performance model based on the interpreter and bytecode count. But performance depends on native code produced by the JIT. An optimizing JIT will usually transform the code deeply. For string scanning, for example, HotSpot has an intrinsic for String.indexOf(String) that uses totally different code from a user-coded loop. (It is not currently so for String.indexOf(int), but String.indexOf("/") is potentially very fast.) Also, with your example code, the combined loop may often be faster than two back-to-back loops, but simpler loops can sometimes be vectorized more robustly, to the point where back-to-back simple loops, if vectorized, may be competitive with a hand-fused loop. So loop complexity and method intrinsics can create surprises for those who rely on simple performance modesl Some day we will get to a world where loops are specified stream-wise, and robustly optimized without this sort of manual intervention. In the mean time, be careful about advising hand-optimizations of Java code. They can backfire, by confusing the JIT and preventing optimizations that would apply to simpler code. ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131106/d25bc1bb/attachment.html From david.holmes at oracle.com Wed Nov 6 17:43:42 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 07 Nov 2013 11:43:42 +1000 Subject: RFR for JDK-7195249 Some jtreg tests use hard coded ports In-Reply-To: <527A4C6D.8040804@oracle.com> References: <527A4C6D.8040804@oracle.com> Message-ID: <527AF04E.6070406@oracle.com> On 7/11/2013 12:04 AM, taras ledkov wrote: > Hi Everyone > > I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. > Based on my colleagues' research, > > Root cause: > hotspot/test/runtime/6294277/SourceDebugExtension.java > jdk/test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.java > jdk/test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java > jdk/test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh > jdk/test/sun/management/jmxremote/bootstrap/LocalManagementTest.java > > fails intermittently because of use of fixed ports. These ports could be > busy at some configurations. > > Suggested fix: > 1. My recommendation would be to convert the only shell test > (SSLConfigFilePermissionTest.sh) into > Java based test and re-use the dynamic port allocation > solutionjdk/test/lib/testlibrary/jdk/testlibrary/Utils.getFreePort() to > address the issue for JDK tests. Staffan Larsen recommends to use this > solution instead of java/rmi/testlibrary/TestLibrary.getUnusedRandomPort(). > > 2. For hotspot tests I cannot find appropriate test utils (witch provide > getFreePort() functionality). There are several options: > - copy whole library jdk/test/lib/testlibrary/jdk/testlibrary/ to > hotspot repository; > - copy one class jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java to > hotspot repository; > - copy one method from class > jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java > (Utils.getFreePort()) to hotspot repository; > - move the library jdk/test/lib/testlibrary/jdk/testlibrary/ to a place > that can be shared between hotspot & jdk tests (if such place exists). The issue about keeping the two versions of the testlibrary in sync and/or moving to a shared location has been raised a number of times and is beyond the scope of the current required fix. I would suggest simply adding the necessary utility class to hotspot/test/testlibrary/com/oracle/java/testlibrary/ David ----- > 3. SourceDebugExtension test uses jtreg tag @run with hard coded port in > jvm options. The test must be converted to test with java based test > launcher and test application (e.g. like the test > LocalManagementTest.java). > > > Please let me know any comments or suggestions. > > Thank you > From john.r.rose at oracle.com Wed Nov 6 20:35:05 2013 From: john.r.rose at oracle.com (John Rose) Date: Wed, 6 Nov 2013 20:35:05 -0800 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> <527A98D1.4080906@gmail.com> <5AAEA553-6A71-43FD-A7BA-A001BA2D5128@oracle.com> Message-ID: <6A6625E5-57F7-416B-B0C2-81FACE3B71FF@oracle.com> On Nov 6, 2013, at 5:32 PM, Boris Davidovich wrote: > Am I missing something? > The intrinsic would be looking at a constant string. ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131106/8cda7168/attachment.html From chris.hegarty at oracle.com Thu Nov 7 01:06:07 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 07 Nov 2013 09:06:07 +0000 Subject: hg: jdk8/tl/jdk: 8027822: ProblemList.txt Updates (11/2013) Message-ID: <20131107090621.4C161623EC@hg.openjdk.java.net> Changeset: f37d62e295c0 Author: chegar Date: 2013-11-07 08:04 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f37d62e295c0 8027822: ProblemList.txt Updates (11/2013) Reviewed-by: chegar, alanb Contributed-by: Amy Lu ! test/ProblemList.txt From chris.hegarty at oracle.com Thu Nov 7 01:24:31 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 07 Nov 2013 09:24:31 +0000 Subject: hg: jdk8/tl/jdk: 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Message-ID: <20131107092443.B985C623EF@hg.openjdk.java.net> Changeset: 82b276590b85 Author: chegar Date: 2013-11-07 08:23 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82b276590b85 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Reviewed-by: michaelm, rriggs ! src/share/native/java/net/Inet4Address.c ! src/share/native/java/net/Inet6Address.c ! src/share/native/java/net/InetAddress.c ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c From michael.x.mcmahon at oracle.com Thu Nov 7 02:43:33 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 07 Nov 2013 10:43:33 +0000 Subject: hg: jdk8/tl/jdk: 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient Message-ID: <20131107104346.E8CAB623F2@hg.openjdk.java.net> Changeset: 88d1ed05a246 Author: michaelm Date: 2013-11-07 10:22 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88d1ed05a246 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient Reviewed-by: chegar ! test/java/net/URLPermission/URLPermissionTest.java ! test/java/net/URLPermission/nstest/LookupTest.java + test/java/net/URLPermission/nstest/lookup.sh - test/java/net/URLPermission/nstest/policy From Alan.Bateman at oracle.com Thu Nov 7 03:22:24 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 07 Nov 2013 11:22:24 +0000 Subject: [8] Review Request: 8027696 Incorrect copyright header in the tests In-Reply-To: <52791C93.1060600@oracle.com> References: <52738E00.2070806@oracle.com> <5274E3FF.3070807@oracle.com> <52791C93.1060600@oracle.com> Message-ID: <527B77F0.4050109@oracle.com> On 05/11/2013 16:28, Sergey Bylokhov wrote: > Hello, > Updated version: > http://cr.openjdk.java.net/~serb/8027696/webrev.01/ > Dates and spaces were fixed. Thanks Sergey, I sampled a few and they look correct. The only thing is that I'm not sure about is test/Makefile, it's just not clear whether which header this should have. -Alan From joel.franck at oracle.com Thu Nov 7 04:35:37 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 07 Nov 2013 12:35:37 +0000 Subject: hg: jdk8/tl/jdk: 8027796: Refactor Core Reflection for Type Annotations Message-ID: <20131107123551.69603623FB@hg.openjdk.java.net> Changeset: 44fa6bf42846 Author: jfranck Date: 2013-11-07 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44fa6bf42846 8027796: Refactor Core Reflection for Type Annotations Reviewed-by: psandoz ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java From yekaterina.kantserova at oracle.com Thu Nov 7 05:02:29 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 14:02:29 +0100 Subject: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Message-ID: <527B8F65.3050108@oracle.com> Hi, Could I please have a review of this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8027752 Webrev: cr.openjdk.java.net/~ykantser/8027752/webrev.00 Thanks, Katja From jaroslav.bachorik at oracle.com Thu Nov 7 06:01:45 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 07 Nov 2013 15:01:45 +0100 Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently Message-ID: <527B9D49.5010908@oracle.com> Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 The failure was caused by the IOHandler not waiting for the actual message stating the the debugee was ready. The patch uses the library functions to start the debugee and wait for the actual message to appear. Also, it detects problems while starting the debugee and reports them instead of failing only when the debugger can not connect. Thanks, -JB- From jaroslav.bachorik at oracle.com Thu Nov 7 06:04:32 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 07 Nov 2013 15:04:32 +0100 Subject: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object In-Reply-To: <527B8F65.3050108@oracle.com> References: <527B8F65.3050108@oracle.com> Message-ID: <527B9DF0.6050204@oracle.com> Hi, the patch only detects an incorrect setup, right? -JB- On 7.11.2013 14:02, Yekaterina Kantserova wrote: > Hi, > > Could I please have a review of this fix. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8027752 > > Webrev: > cr.openjdk.java.net/~ykantser/8027752/webrev.00 > > Thanks, > Katja From yekaterina.kantserova at oracle.com Thu Nov 7 06:09:44 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 15:09:44 +0100 Subject: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Message-ID: <527B9F28.3060303@oracle.com> Hi, Could I please have a review of this fix. The following has been done: - updated OutputAnalyzer and ProcessTool with changes from hotspot/testlibrary; - added test classes AssertsTest and OutputAnalyzerReportingTest from hotspot/testlibrary; - added InputArguments class from hotspot/testlibrary (provides access to the input arguments to the VM);** - removed JdkFinder (it's replaced with JDKToolLauncher); - re-wrote JcmdBase to use JDKToolLauncher instead of JdkFinder. Bug: https://bugs.openjdk.java.net/browse/JDK-8015497 Webrev: http://cr.openjdk.java.net/~ykantser/8015497/webrev.00/ Thanks, Katja -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131107/bf597a10/attachment.html From sundararajan.athijegannathan at oracle.com Thu Nov 7 06:17:15 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 07 Nov 2013 14:17:15 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131107141717.77C2F623FE@hg.openjdk.java.net> Changeset: 2f07b4234451 Author: sundar Date: 2013-11-07 17:26 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f07b4234451 8027828: ClassCastException when converting return value of a Java method to boolean Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java + test/script/basic/JDK-8027828.js + test/script/basic/JDK-8027828.js.EXPECTED + test/script/basic/convert.js + test/script/basic/convert.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java Changeset: 3b794f364c77 Author: sundar Date: 2013-11-07 18:11 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3b794f364c77 Merge From yekaterina.kantserova at oracle.com Thu Nov 7 06:24:28 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 15:24:28 +0100 Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently In-Reply-To: <527B9D49.5010908@oracle.com> References: <527B9D49.5010908@oracle.com> Message-ID: <527BA29C.80302@oracle.com> Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary). The example how to use can be found in sun/management/jmxremote/bootstrap/LocalManagementTest.java. Thanks, Katja On 11/07/2013 03:01 PM, Jaroslav Bachorik wrote: > Please, review this test fix. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 > Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 > > The failure was caused by the IOHandler not waiting for the actual > message stating the the debugee was ready. The patch uses the library > functions to start the debugee and wait for the actual message to > appear. Also, it detects problems while starting the debugee and > reports them instead of failing only when the debugger can not connect. > > Thanks, > > -JB- From jaroslav.bachorik at oracle.com Thu Nov 7 06:29:35 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 07 Nov 2013 15:29:35 +0100 Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently In-Reply-To: <527BA29C.80302@oracle.com> References: <527B9D49.5010908@oracle.com> <527BA29C.80302@oracle.com> Message-ID: <527BA3CF.7090903@oracle.com> On 7.11.2013 15:24, Yekaterina Kantserova wrote: > Hi, > > would you like to use JDKToolLauncher instead of JdkFinder? The > JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from > hotspot/test/testlibrary to jdk/test/lib/testlibrary). > > The example how to use can be found in > sun/management/jmxremote/bootstrap/LocalManagementTest.java. Why not. But I will need to wait till your changes are in ... -JB- > > Thanks, > Katja > > > > On 11/07/2013 03:01 PM, Jaroslav Bachorik wrote: >> Please, review this test fix. >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 >> Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 >> >> The failure was caused by the IOHandler not waiting for the actual >> message stating the the debugee was ready. The patch uses the library >> functions to start the debugee and wait for the actual message to >> appear. Also, it detects problems while starting the debugee and >> reports them instead of failing only when the debugger can not connect. >> >> Thanks, >> >> -JB- > From yekaterina.kantserova at oracle.com Thu Nov 7 06:30:29 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 15:30:29 +0100 Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently In-Reply-To: <527BA29C.80302@oracle.com> References: <527B9D49.5010908@oracle.com> <527BA29C.80302@oracle.com> Message-ID: <527BA405.7020507@oracle.com> Sorry, ProcessBuilder's createJavaProcessBuilder() of course, which in turn uses JDKToolLauncher. // Katja On 11/07/2013 03:24 PM, Yekaterina Kantserova wrote: > Hi, > > would you like to use JDKToolLauncher instead of JdkFinder? The > JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from > hotspot/test/testlibrary to jdk/test/lib/testlibrary). > > The example how to use can be found in > sun/management/jmxremote/bootstrap/LocalManagementTest.java. > > Thanks, > Katja > > > > On 11/07/2013 03:01 PM, Jaroslav Bachorik wrote: >> Please, review this test fix. >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 >> Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 >> >> The failure was caused by the IOHandler not waiting for the actual >> message stating the the debugee was ready. The patch uses the library >> functions to start the debugee and wait for the actual message to >> appear. Also, it detects problems while starting the debugee and >> reports them instead of failing only when the debugger can not connect. >> >> Thanks, >> >> -JB- > From yekaterina.kantserova at oracle.com Thu Nov 7 06:34:12 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 15:34:12 +0100 Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently In-Reply-To: <527BA3CF.7090903@oracle.com> References: <527B9D49.5010908@oracle.com> <527BA29C.80302@oracle.com> <527BA3CF.7090903@oracle.com> Message-ID: <527BA4E4.7070102@oracle.com> On 11/07/2013 03:29 PM, Jaroslav Bachorik wrote: > On 7.11.2013 15:24, Yekaterina Kantserova wrote: >> Hi, >> >> would you like to use JDKToolLauncher instead of JdkFinder? The >> JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from >> hotspot/test/testlibrary to jdk/test/lib/testlibrary). >> >> The example how to use can be found in >> sun/management/jmxremote/bootstrap/LocalManagementTest.java. > > Why not. But I will need to wait till your changes are in ... Sorry, ProcessBuilder's createJavaProcessBuilder() of course, which in turn uses JDKToolLauncher. If you'll use ProcessBuilder's createJavaProcessBuilder() you don't need to wait. Before my fix it will use JdkFinder and after it JDKToolLauncher. // Katja > > -JB- > >> >> Thanks, >> Katja >> >> >> >> On 11/07/2013 03:01 PM, Jaroslav Bachorik wrote: >>> Please, review this test fix. >>> >>> Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 >>> Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 >>> >>> The failure was caused by the IOHandler not waiting for the actual >>> message stating the the debugee was ready. The patch uses the library >>> functions to start the debugee and wait for the actual message to >>> appear. Also, it detects problems while starting the debugee and >>> reports them instead of failing only when the debugger can not connect. >>> >>> Thanks, >>> >>> -JB- >> > From jaroslav.bachorik at oracle.com Thu Nov 7 06:40:24 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 07 Nov 2013 15:40:24 +0100 Subject: RFR 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c Message-ID: <527BA658.3060907@oracle.com> Please, review this simple fix in the demo code. Issue : https://bugs.openjdk.java.net/browse/JDK-8007984 Webrev: http://cr.openjdk.java.net/~jbachorik/8007984/webrev.00 In an unlikely case of providing fatal_error_handler that does not terminate the application when a fatal error is reported. The patch calls abort() regardless of whether the fatal_error_handler was invoked or not. Thanks, -JB- From yekaterina.kantserova at oracle.com Thu Nov 7 06:13:37 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 7 Nov 2013 06:13:37 -0800 (PST) Subject: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object In-Reply-To: <527B9DF0.6050204@oracle.com> References: <527B8F65.3050108@oracle.com> <527B9DF0.6050204@oracle.com> Message-ID: <527BA011.9070901@oracle.com> Hi, On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: > Hi, > > the patch only detects an incorrect setup, right? That's correct. The plan is to run test with this fix and see if we keep getting SecurityException or if something is wrong with the policy file. In the first case a new bug will be open. // Katja > > -JB- > > On 7.11.2013 14:02, Yekaterina Kantserova wrote: >> Hi, >> >> Could I please have a review of this fix. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8027752 >> >> Webrev: >> cr.openjdk.java.net/~ykantser/8027752/webrev.00 >> >> Thanks, >> Katja > From jaroslav.bachorik at oracle.com Thu Nov 7 06:45:30 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 07 Nov 2013 15:45:30 +0100 Subject: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object In-Reply-To: <527BA011.9070901@oracle.com> References: <527B8F65.3050108@oracle.com> <527B9DF0.6050204@oracle.com> <527BA011.9070901@oracle.com> Message-ID: <527BA78A.1060901@oracle.com> On 7.11.2013 15:13, Yekaterina Kantserova wrote: > Hi, > > On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: >> Hi, >> >> the patch only detects an incorrect setup, right? > > That's correct. The plan is to run test with this fix and see if we keep > getting SecurityException or if something is wrong with the policy file. > In the first case a new bug will be open. Ok. In that case I'm fine with the patch. But not a reviewer. -JB- > > // Katja > >> >> -JB- >> >> On 7.11.2013 14:02, Yekaterina Kantserova wrote: >>> Hi, >>> >>> Could I please have a review of this fix. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8027752 >>> >>> Webrev: >>> cr.openjdk.java.net/~ykantser/8027752/webrev.00 >>> >>> Thanks, >>> Katja >> > From yekaterina.kantserova at oracle.com Thu Nov 7 07:00:23 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 16:00:23 +0100 Subject: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object In-Reply-To: <527BA78A.1060901@oracle.com> References: <527B8F65.3050108@oracle.com> <527B9DF0.6050204@oracle.com> <527BA011.9070901@oracle.com> <527BA78A.1060901@oracle.com> Message-ID: <527BAB07.3000706@oracle.com> Thanks! On 11/07/2013 03:45 PM, Jaroslav Bachorik wrote: > On 7.11.2013 15:13, Yekaterina Kantserova wrote: >> Hi, >> >> On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: >>> Hi, >>> >>> the patch only detects an incorrect setup, right? >> >> That's correct. The plan is to run test with this fix and see if we keep >> getting SecurityException or if something is wrong with the policy file. >> In the first case a new bug will be open. > > Ok. In that case I'm fine with the patch. But not a reviewer. > > -JB- > >> >> // Katja >> >>> >>> -JB- >>> >>> On 7.11.2013 14:02, Yekaterina Kantserova wrote: >>>> Hi, >>>> >>>> Could I please have a review of this fix. >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-8027752 >>>> >>>> Webrev: >>>> cr.openjdk.java.net/~ykantser/8027752/webrev.00 >>>> >>>> Thanks, >>>> Katja >>> >> > From yekaterina.kantserova at oracle.com Thu Nov 7 07:14:11 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 16:14:11 +0100 Subject: RFR for JDK-7195249 Some jtreg tests use hard coded ports In-Reply-To: <527A4C6D.8040804@oracle.com> References: <527A4C6D.8040804@oracle.com> Message-ID: <527BAE43.4020902@oracle.com> Hi Taras, see my comments in-lined. On 11/06/2013 03:04 PM, taras ledkov wrote: > Hi Everyone > > I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. > Based on my colleagues' research, > > Root cause: > hotspot/test/runtime/6294277/SourceDebugExtension.java > jdk/test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.java > jdk/test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java > jdk/test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh > > jdk/test/sun/management/jmxremote/bootstrap/LocalManagementTest.java > > fails intermittently because of use of fixed ports. These ports could > be busy at some configurations. > > Suggested fix: > 1. My recommendation would be to convert the only shell test > (SSLConfigFilePermissionTest.sh) into > Java based test and re-use the dynamic port allocation > solutionjdk/test/lib/testlibrary/jdk/testlibrary/Utils.getFreePort() > to address the issue for JDK tests. Staffan Larsen recommends to use > this solution instead of > java/rmi/testlibrary/TestLibrary.getUnusedRandomPort(). > > 2. For hotspot tests I cannot find appropriate test utils (witch > provide getFreePort() functionality). There are several options: > - copy whole library jdk/test/lib/testlibrary/jdk/testlibrary/ to > hotspot repository; There is already testlibrary in the hotspot part: hotspot/test/testlibrary. The most classes from jdk/test/lib/testlibrary are already in there (package com.oracle.java.testlibrary). I've added Utils, TestThread, ProcessThread and XRun a while ago but has not yet port them to the hotspot part. > - copy one class jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java > to hotspot repository; Sounds like a good solution right now. I'll try to port the rest in the nearest future. > - copy one method from class > jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java > (Utils.getFreePort()) to hotspot repository; > - move the library jdk/test/lib/testlibrary/jdk/testlibrary/ to a > place that can be shared between hotspot & jdk tests (if such place > exists). Sounds like an even better solution but there is no such place as far as I know. But discussions are ongoing on how it can be achieved. > > 3. SourceDebugExtension test uses jtreg tag @run with hard coded port > in jvm options. The test must be converted to test with java based > test launcher and test application (e.g. like the test > LocalManagementTest.java). > > > Please let me know any comments or suggestions. > > Thank you > Thanks, Katja From staffan.larsen at oracle.com Thu Nov 7 07:40:22 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 7 Nov 2013 16:40:22 +0100 Subject: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object In-Reply-To: <527BA011.9070901@oracle.com> References: <527B8F65.3050108@oracle.com> <527B9DF0.6050204@oracle.com> <527BA011.9070901@oracle.com> Message-ID: Looks good! Thanks, /Staffan On 07 Nov 2013, at 15:13, Yekaterina Kantserova wrote: > Hi, > > On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: >> Hi, >> >> the patch only detects an incorrect setup, right? > > That's correct. The plan is to run test with this fix and see if we keep getting SecurityException or if something is wrong with the policy file. In the first case a new bug will be open. > > // Katja > >> >> -JB- >> >> On 7.11.2013 14:02, Yekaterina Kantserova wrote: >>> Hi, >>> >>> Could I please have a review of this fix. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8027752 >>> >>> Webrev: >>> cr.openjdk.java.net/~ykantser/8027752/webrev.00 >>> >>> Thanks, >>> Katja >> > From jaroslav.bachorik at oracle.com Thu Nov 7 07:41:32 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 07 Nov 2013 16:41:32 +0100 Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently In-Reply-To: <527BA4E4.7070102@oracle.com> References: <527B9D49.5010908@oracle.com> <527BA29C.80302@oracle.com> <527BA3CF.7090903@oracle.com> <527BA4E4.7070102@oracle.com> Message-ID: <527BB4AC.1050107@oracle.com> On 7.11.2013 15:34, Yekaterina Kantserova wrote: > On 11/07/2013 03:29 PM, Jaroslav Bachorik wrote: >> On 7.11.2013 15:24, Yekaterina Kantserova wrote: >>> Hi, >>> >>> would you like to use JDKToolLauncher instead of JdkFinder? The >>> JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from >>> hotspot/test/testlibrary to jdk/test/lib/testlibrary). >>> >>> The example how to use can be found in >>> sun/management/jmxremote/bootstrap/LocalManagementTest.java. >> >> Why not. But I will need to wait till your changes are in ... > > Sorry, ProcessBuilder's createJavaProcessBuilder() of course, which in > turn uses JDKToolLauncher. > > If you'll use ProcessBuilder's createJavaProcessBuilder() you don't need > to wait. Before my fix it will use JdkFinder and after it JDKToolLauncher. Ok. Switched to ProcessTools.createJavaProcessBuilder(). Thanks for the tip. http://cr.openjdk.java.net/~jbachorik/8004126/webrev.01 -JB- > > // Katja > >> >> -JB- >> >>> >>> Thanks, >>> Katja >>> >>> >>> >>> On 11/07/2013 03:01 PM, Jaroslav Bachorik wrote: >>>> Please, review this test fix. >>>> >>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 >>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 >>>> >>>> The failure was caused by the IOHandler not waiting for the actual >>>> message stating the the debugee was ready. The patch uses the library >>>> functions to start the debugee and wait for the actual message to >>>> appear. Also, it detects problems while starting the debugee and >>>> reports them instead of failing only when the debugger can not connect. >>>> >>>> Thanks, >>>> >>>> -JB- >>> >> > From yekaterina.kantserova at oracle.com Thu Nov 7 07:44:38 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 16:44:38 +0100 Subject: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object In-Reply-To: References: <527B8F65.3050108@oracle.com> <527B9DF0.6050204@oracle.com> <527BA011.9070901@oracle.com> Message-ID: <527BB566.7080305@oracle.com> Staffan, thanks for reviewing! On 11/07/2013 04:40 PM, Staffan Larsen wrote: > Looks good! > > Thanks, > /Staffan > > > On 07 Nov 2013, at 15:13, Yekaterina Kantserova wrote: > >> Hi, >> >> On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: >>> Hi, >>> >>> the patch only detects an incorrect setup, right? >> That's correct. The plan is to run test with this fix and see if we keep getting SecurityException or if something is wrong with the policy file. In the first case a new bug will be open. >> >> // Katja >> >>> -JB- >>> >>> On 7.11.2013 14:02, Yekaterina Kantserova wrote: >>>> Hi, >>>> >>>> Could I please have a review of this fix. >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-8027752 >>>> >>>> Webrev: >>>> cr.openjdk.java.net/~ykantser/8027752/webrev.00 >>>> >>>> Thanks, >>>> Katja From yekaterina.kantserova at oracle.com Thu Nov 7 07:48:40 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Thu, 07 Nov 2013 16:48:40 +0100 Subject: Fwd: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary In-Reply-To: <527B9F28.3060303@oracle.com> References: <527B9F28.3060303@oracle.com> Message-ID: <527BB658.4000208@oracle.com> Adding hotspot-dev group. -------- Original Message -------- Subject: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Date: Thu, 07 Nov 2013 15:09:44 +0100 From: Yekaterina Kantserova To: Serviceability Dev Hi, Could I please have a review of this fix. The following has been done: - updated OutputAnalyzer and ProcessTool with changes from hotspot/testlibrary; - added test classes AssertsTest and OutputAnalyzerReportingTest from hotspot/testlibrary; - added InputArguments class from hotspot/testlibrary (provides access to the input arguments to the VM); - removed JdkFinder (it's replaced with JDKToolLauncher); - re-wrote JcmdBase to use JDKToolLauncher instead of JdkFinder. Bug: https://bugs.openjdk.java.net/browse/JDK-8015497 Webrev: http://cr.openjdk.java.net/~ykantser/8015497/webrev.00/ Thanks, Katja -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131107/f062070c/attachment.html From naoto.sato at oracle.com Thu Nov 7 10:04:06 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Thu, 07 Nov 2013 18:04:06 +0000 Subject: hg: jdk8/tl/jdk: 8027930: ResourceBundle test failures in fr locale Message-ID: <20131107180439.48B1C6240F@hg.openjdk.java.net> Changeset: fb7abd509bd2 Author: naoto Date: 2013-11-07 10:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb7abd509bd2 8027930: ResourceBundle test failures in fr locale Reviewed-by: smarks ! test/java/util/ResourceBundle/ResourceBundleTest.java ! test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java From john.coomes at oracle.com Thu Nov 7 15:07:44 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 07 Nov 2013 23:07:44 +0000 Subject: hg: hsx/hotspot-rt/corba: 5 new changesets Message-ID: <20131107230748.9AEEE6244B@hg.openjdk.java.net> Changeset: 52ad44f9a3ec Author: alanb Date: 2013-10-22 11:40 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/52ad44f9a3ec 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks Contributed-by: alan.bateman at oralce.com, mark.sheppard at oracle.com ! src/share/classes/javax/rmi/CORBA/Stub.java ! src/share/classes/javax/rmi/CORBA/Util.java ! src/share/classes/javax/rmi/PortableRemoteObject.java ! src/share/classes/org/omg/CORBA/ORB.java Changeset: a90e9efa4264 Author: coffeys Date: 2013-10-23 16:45 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/a90e9efa4264 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks ! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java Changeset: 219e616a6a4f Author: lana Date: 2013-10-28 12:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/219e616a6a4f Merge Changeset: 8d07115924b7 Author: lana Date: 2013-10-31 16:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/8d07115924b7 Merge Changeset: 5fdc44652089 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/5fdc44652089 Added tag jdk8-b115 for changeset 8d07115924b7 ! .hgtags From john.coomes at oracle.com Thu Nov 7 15:07:39 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 07 Nov 2013 23:07:39 +0000 Subject: hg: hsx/hotspot-rt: 30 new changesets Message-ID: <20131107230741.234046244A@hg.openjdk.java.net> Changeset: 3dc55f0c1b6f Author: jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/3dc55f0c1b6f 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/bin/compare.sh ! common/makefiles/Main.gmk ! common/makefiles/MakeBase.gmk + make/nashorn-rules.gmk ! make/scripts/hgforest.sh Changeset: ecd447139a39 Author: jlaskey Date: 2013-02-04 17:30 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ecd447139a39 Merge ! common/autoconf/generated-configure.sh Changeset: 9ed388a04fa7 Author: jlaskey Date: 2013-02-06 13:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/9ed388a04fa7 8007666: nashorn missing from hgforest.sh Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! common/bin/hgforest.sh Changeset: 8b19b55f695d Author: jlaskey Date: 2013-02-18 19:01 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8b19b55f695d 8008420: Fix Nashorn forest to build with NEWBUILD=false Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! Makefile ! make/nashorn-rules.gmk Changeset: f9a1cb245484 Author: jlaskey Date: 2013-02-19 10:02 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/f9a1cb245484 8008446: Tweaks to make all NEWBUILD=false round 2 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! make/Defs-internal.gmk Changeset: 887fde71977e Author: jlaskey Date: 2013-02-21 15:25 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/887fde71977e 8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey at oracle.com ! make/jdk-rules.gmk ! make/sanity-rules.gmk Changeset: e877cb3eb4d6 Author: jlaskey Date: 2013-02-22 13:09 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e877cb3eb4d6 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk Changeset: 528a9984198f Author: jlaskey Date: 2013-02-22 22:58 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/528a9984198f 8008774: nashorn missing from dependencies after merge with tl Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! common/makefiles/Main.gmk Changeset: 13ddc5c3ebfc Author: jlaskey Date: 2013-03-02 10:28 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/13ddc5c3ebfc Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk ! make/nashorn-rules.gmk Changeset: 1d38d30196be Author: jlaskey Date: 2013-03-08 14:44 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1d38d30196be Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: b938d5ee29c3 Author: jlaskey Date: 2013-03-15 11:50 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b938d5ee29c3 Merge Changeset: fe5a388bf8fe Author: jlaskey Date: 2013-03-26 09:13 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/fe5a388bf8fe Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 1378ccca1c79 Author: jlaskey Date: 2013-04-09 08:35 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1378ccca1c79 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk Changeset: 8a7e97848471 Author: jlaskey Date: 2013-04-15 08:06 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8a7e97848471 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 6316aefcf716 Author: jlaskey Date: 2013-04-17 08:47 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/6316aefcf716 Merge Changeset: dd81e9b5fb38 Author: jlaskey Date: 2013-04-22 13:59 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/dd81e9b5fb38 Merge Changeset: 431d16ddfcd9 Author: jlaskey Date: 2013-04-29 21:37 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/431d16ddfcd9 Merge Changeset: 1fca390200c1 Author: jlaskey Date: 2013-05-14 09:04 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1fca390200c1 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 67b5cbe55744 Author: jlaskey Date: 2013-05-23 09:48 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/67b5cbe55744 Merge Changeset: de886178f8e6 Author: jlaskey Date: 2013-06-05 13:08 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/de886178f8e6 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in Changeset: 520fd54a7c43 Author: jlaskey Date: 2013-07-16 09:08 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/520fd54a7c43 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 67dc3d7d5b5f Author: jlaskey Date: 2013-07-24 08:23 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/67dc3d7d5b5f Merge ! common/autoconf/generated-configure.sh Changeset: 96f207364e46 Author: jlaskey Date: 2013-08-27 16:05 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/96f207364e46 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: ddf76977d04a Author: jlaskey Date: 2013-09-13 10:14 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/ddf76977d04a Merge ! common/autoconf/generated-configure.sh ! common/bin/hgforest.sh ! common/makefiles/Main.gmk Changeset: 8b92b08993a8 Author: jlaskey Date: 2013-09-30 10:23 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8b92b08993a8 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in Changeset: d832f6171acd Author: jlaskey Date: 2013-10-29 11:48 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/d832f6171acd Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk Changeset: 067355edfbf8 Author: vinnie Date: 2013-10-30 17:31 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/067355edfbf8 8027567: JDK 8 build failure: the correct version of GNU make is being rejected Reviewed-by: chegar, erikj ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: 37d2736caf46 Author: lana Date: 2013-10-30 13:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/37d2736caf46 Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in Changeset: 763ada2a1d8c Author: lana Date: 2013-10-31 16:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/763ada2a1d8c Merge Changeset: 40e892e2a4f2 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/40e892e2a4f2 Added tag jdk8-b115 for changeset 763ada2a1d8c ! .hgtags From john.coomes at oracle.com Thu Nov 7 15:07:53 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 07 Nov 2013 23:07:53 +0000 Subject: hg: hsx/hotspot-rt/jaxp: 6 new changesets Message-ID: <20131107230809.1AAFD6244C@hg.openjdk.java.net> Changeset: 390e94b9a852 Author: joehw Date: 2013-10-24 13:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/390e94b9a852 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb ! src/com/sun/org/apache/xalan/internal/XalanConstants.java + src/com/sun/org/apache/xalan/internal/utils/FeatureManager.java + src/com/sun/org/apache/xalan/internal/utils/FeaturePropertyBase.java ! src/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xalan/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xalan/internal/xsltc/cmdline/Compile.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xpath/internal/jaxp/JAXPExtensionsProvider.java ! src/com/sun/org/apache/xpath/internal/jaxp/XPathExpressionImpl.java ! src/com/sun/org/apache/xpath/internal/jaxp/XPathFactoryImpl.java ! src/com/sun/org/apache/xpath/internal/jaxp/XPathImpl.java Changeset: 96562bf197f2 Author: lana Date: 2013-10-28 12:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/96562bf197f2 Merge Changeset: 1af33ab1bc58 Author: joehw Date: 2013-10-29 14:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/1af33ab1bc58 8027484: Implementation error in SAX2DOM.java Reviewed-by: alanb, lancea ! src/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2DOM.java Changeset: 04778b00286a Author: joehw Date: 2013-10-30 08:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/04778b00286a 8024378: StAX parser shall support JAXP properties Reviewed-by: dfuchs, lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java Changeset: f610fd46463e Author: lana Date: 2013-10-31 16:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/f610fd46463e Merge Changeset: e757eb9aee3d Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/e757eb9aee3d Added tag jdk8-b115 for changeset f610fd46463e ! .hgtags From john.coomes at oracle.com Thu Nov 7 15:08:13 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 07 Nov 2013 23:08:13 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b115 for changeset e126d8eca69b Message-ID: <20131107230818.163326244D@hg.openjdk.java.net> Changeset: 587560c222a2 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/587560c222a2 Added tag jdk8-b115 for changeset e126d8eca69b ! .hgtags From mandy.chung at oracle.com Thu Nov 7 15:40:59 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 07 Nov 2013 15:40:59 -0800 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public Message-ID: <527C250B.5000507@oracle.com> com.sun.management API is an exported API [1] except com.sun.management.OSMBeanFactory class which is an implementation-specific class and it's currently annotated as @jdk.Exported(false) [2]. This patch will eliminate one use of @jdk.Exported(false). This is simply refactoring of the existing implementation: o remove com.sun.management.OSMBeanFactory o move the implementation classes to sun.management including - rename com.sun.management.UnixOperatingSystemImpl (or OperatingSystem windows version) to sun.management.OperatingSystemImpl along with its native implementation - sun.management.ManagementFactoryHelper creates the sun.management.OperatingSystemImpl instance directly (no need of the factory OSMBeanFactory method) I'm including build-dev as there are changes in the makefiles. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8025985/webrev.00/ thanks Mandy [1] http://download.java.net/jdk8/docs/jre/api/management/extension/index.html [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55 From john.coomes at oracle.com Thu Nov 7 15:20:35 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 07 Nov 2013 23:20:35 +0000 Subject: hg: hsx/hotspot-rt/jdk: 212 new changesets Message-ID: <20131108000401.92D916244F@hg.openjdk.java.net> Changeset: 180c05796c45 Author: bae Date: 2013-10-10 18:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/180c05796c45 7058618: PNG parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java Changeset: 0c2ba6a67b0d Author: morris Date: 2013-10-11 12:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0c2ba6a67b0d 7195597: ThreadStateTest gets different results with -Xcomp Reviewed-by: kvn ! test/java/lang/Thread/ThreadStateTest.java Changeset: 124bffc749ea Author: lana Date: 2013-10-12 14:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/124bffc749ea Merge - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java - test/java/util/regex/PatternTest.java Changeset: 7ed340e7d894 Author: bae Date: 2013-10-14 15:32 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7ed340e7d894 7058602: BMP parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java ! src/share/classes/com/sun/imageio/plugins/common/iio-plugin.properties ! src/share/classes/java/awt/image/ComponentSampleModel.java Changeset: cb9fa40f73f7 Author: bae Date: 2013-10-14 15:49 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cb9fa40f73f7 7058607: GIF parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java Changeset: 478f7a9b3b12 Author: bae Date: 2013-10-14 16:00 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/478f7a9b3b12 7058611: JPG parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/jpeg/MarkerSegment.java ! src/share/classes/com/sun/imageio/plugins/jpeg/SOFMarkerSegment.java Changeset: b164c8eb1295 Author: jgodinez Date: 2013-10-14 09:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b164c8eb1295 8022536: closed/javax/print/TextFlavorTest.java fails Reviewed-by: prr, jchen ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! test/java/awt/print/PrinterJob/PrintLatinCJKTest.java + test/javax/print/TextFlavorTest.java Changeset: 8a59181b3c6d Author: vadim Date: 2013-10-15 08:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a59181b3c6d 8023590: REGRESSION: large count of graphics artifacts with Java 8 on Windows 8 on Intel HD card. Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 0df5cda89a50 Author: jchen Date: 2013-10-15 14:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0df5cda89a50 8025429: [parfait] warnings from b107 for sun.java2d.cmm: JNI exception pending Reviewed-by: prr, bae ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: c9c945cea665 Author: jgodinez Date: 2013-10-15 14:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c9c945cea665 8015586: [macosx] Test closed/java/awt/print/PrinterJob/PrintToDir.java fails on MacOSX Reviewed-by: prr, jchen ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java + test/java/awt/print/PrinterJob/PrintToDir.java Changeset: 070e8ec9d82c Author: bae Date: 2013-10-16 17:13 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/070e8ec9d82c 8026702: Fix for 8025429 breaks jdk build on windows Reviewed-by: serb ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 73d212a3b2eb Author: jchen Date: 2013-10-16 14:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/73d212a3b2eb 8024461: [macosx] Java crashed on mac10.9 for swing and 2d function manual test Reviewed-by: prr, vadim, serb ! src/share/native/sun/java2d/opengl/OGLBlitLoops.c Changeset: bcf8e9a59968 Author: jgodinez Date: 2013-10-18 15:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bcf8e9a59968 8025988: [macosx] Attribute settings don't work for JobAttributes range 8025990: [macosx] Attribute settings don't work for JobAttributes setOrientationRequested, setMedia Reviewed-by: prr, jchen ! src/macosx/native/sun/awt/CPrinterJob.m ! src/share/classes/sun/print/RasterPrinterJob.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java ! test/java/awt/PrintJob/SaveDialogTitleTest.java Changeset: 2a3e21fe9d0d Author: jgodinez Date: 2013-10-21 13:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2a3e21fe9d0d 8026951: Fix for 8025988 breaks jdk build on windows Reviewed-by: prr, jchen ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 923f39485651 Author: bae Date: 2013-10-22 13:28 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/923f39485651 8026780: Crash on PPC and PPC v2 for Java_awt test suit Reviewed-by: prr, jchen ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 739ed3f0e796 Author: ceisserer Date: 2013-10-22 13:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/739ed3f0e796 8023483: sun/java2d/DirectX/TransformedPaintTest/TransformedPaintTest.java failed with jdk8 on linux platforms Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRBackend.java ! src/solaris/classes/sun/java2d/xr/XRBackendNative.java ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java ! src/solaris/classes/sun/java2d/xr/XRPaints.java ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c + test/java/awt/GradientPaint/GradientTransformTest.java + test/java/awt/GradientPaint/LinearColorSpaceGradientTest.java ! test/sun/java2d/DirectX/TransformedPaintTest/TransformedPaintTest.java Changeset: c55a8480cc27 Author: ceisserer Date: 2013-10-22 15:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c55a8480cc27 8023098: XRender : AlphaComposite test results are incorrect. Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/MaskTileManager.java ! src/solaris/classes/sun/java2d/xr/XRColor.java ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java ! src/solaris/classes/sun/java2d/xr/XRDrawImage.java ! src/solaris/classes/sun/java2d/xr/XRMaskBlit.java + src/solaris/classes/sun/java2d/xr/XRSolidSrcPict.java ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/classes/sun/java2d/xr/XRUtils.java Changeset: aca4a67e560d Author: vadim Date: 2013-10-23 08:56 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/aca4a67e560d 8001173: [findbugs] Evaluate FindBug output for sun.font.CompositeFont, sun.font.CompositeFontDescriptor Reviewed-by: prr, bae ! src/share/classes/sun/font/StandardTextSource.java ! src/share/classes/sun/font/TextLabelFactory.java ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: 92af0666c168 Author: prr Date: 2013-10-23 08:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/92af0666c168 8027169: Xrender: Cleaner version of the fix for 7159455 Nimbus scrollbar glitch Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRPMBlitLoops.java Changeset: d27525c346fa Author: lana Date: 2013-10-24 21:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d27525c346fa Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/net/HttpURLPermission.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 3371047f56f3 Author: lana Date: 2013-10-31 15:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3371047f56f3 Merge Changeset: 2e59014ef38f Author: alexsch Date: 2013-10-09 13:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2e59014ef38f 8025649: need test to cover JDK-8000423 Reviewed-by: anthony, serb Contributed-by: Alexander Stepanov + test/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.html + test/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java Changeset: 84c766f6796b Author: bagiras Date: 2013-10-09 14:12 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/84c766f6796b 8016356: Any swing frame resizes ugly. Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 929dc0915f8c Author: anthony Date: 2013-10-09 15:34 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/929dc0915f8c 7159266: [macosx] ApplicationDelegate should not be set in the headless mode Summary: Don't install ApplicationDelegate in headless mode Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m Changeset: 976e5f580124 Author: leonidr Date: 2013-10-09 20:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/976e5f580124 8019623: Lack of synchronization in AppContext.getAppContext() Reviewed-by: anthony, art ! src/share/classes/sun/awt/AppContext.java + test/sun/awt/AppContext/MultiThread/MultiThreadTest.java Changeset: fba62451d705 Author: leonidr Date: 2013-10-09 21:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fba62451d705 8016551: JMenuItem in WindowsLookAndFeel can't paint default icons Reviewed-by: alexsch, serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java + test/com/sun/java/swing/plaf/windows/8016551/bug8016551.java Changeset: cea6ca16142e Author: cl Date: 2013-10-09 14:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cea6ca16142e 8026021: more fix of javadoc errors and warnings reported by doclint, see the description Reviewed-by: anthony, serb ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/LinearGradientPaint.java ! src/share/classes/java/awt/RadialGradientPaint.java ! src/share/classes/java/awt/font/LineBreakMeasurer.java ! src/share/classes/java/awt/font/MultipleMaster.java ! src/share/classes/java/awt/font/NumericShaper.java ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/im/InputContext.java ! src/share/classes/javax/swing/Action.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java Changeset: 81ea6299230a Author: serb Date: 2013-10-10 02:35 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/81ea6299230a 7058662: AiffFileReader throws java.lang.ArithmeticException: division by zero when frame size is zero 7058666: Unexpected exception in AU parser code 7058672: Unexpected exceptions and freezes in WAV parser code Reviewed-by: prr ! src/share/classes/com/sun/media/sound/AiffFileReader.java ! src/share/classes/com/sun/media/sound/AuFileReader.java ! src/share/classes/com/sun/media/sound/WaveFileReader.java + test/javax/sound/sampled/FileReader/ReadersExceptions.java Changeset: 857d6f78f241 Author: pchelko Date: 2013-10-10 11:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/857d6f78f241 8025588: [macosx] Frozen AppKit thread in 7u40 Reviewed-by: anthony, art, serb ! src/macosx/classes/sun/lwawt/macosx/CInputMethod.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/event/InvocationEvent.java ! src/share/classes/sun/awt/AWTAccessor.java Changeset: 31a156bae7cb Author: pchelko Date: 2013-10-10 19:27 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/31a156bae7cb 8024864: [macosx] Problems with rendering of controls Reviewed-by: serb, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/java/awt/Paint/bug8024864.java Changeset: de36486eadd2 Author: pchelko Date: 2013-10-11 11:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/de36486eadd2 8026143: [macosx] Maximized state could be inconsistent between peer and frame Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Frame/MaximizedByPlatform/MaximizedByPlatform.java Changeset: d96f9a8cf89a Author: kshefov Date: 2013-10-11 15:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d96f9a8cf89a 7124338: [macosx] Selection lost if a selected item removed from a java.awt.List Reviewed-by: serb, anthony + test/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html + test/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java Changeset: 2e04843f1c1d Author: art Date: 2013-10-11 16:44 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2e04843f1c1d 8022185: Fix Raw and unchecked warnings in classes belonging to java.awt.datatransfer Reviewed-by: art, pchelko Contributed-by: Srikalyan Chandrashekar ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/awt/datatransfer/MimeTypeParameterList.java Changeset: 2f7f6995fa64 Author: pchelko Date: 2013-10-11 17:57 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2f7f6995fa64 8026262: NPE in SystemFlavorMap.getAllNativesForType - regression in jdk8 b110 by fix of #JDK-8024987 Reviewed-by: art, serb ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java Changeset: af273c9b564a Author: pchelko Date: 2013-10-11 18:04 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/af273c9b564a 8024329: [macosx] JRadioButtonMenuItem behaves like a checkbox when using the ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/classes/com/apple/laf/ScreenMenuItemCheckbox.java Changeset: f65895a2959e Author: lana Date: 2013-10-11 14:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f65895a2959e Merge - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java - test/java/util/regex/PatternTest.java Changeset: d874963706dc Author: yan Date: 2013-10-14 11:47 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d874963706dc 8025824: [cleanup] Fix tidy errors and warnings in preformatted HTML files related to 2d/awt/swing Reviewed-by: anthony, alexsch ! src/macosx/classes/com/apple/eawt/event/package.html ! src/macosx/classes/com/apple/eawt/package.html ! src/share/classes/java/awt/color/package.html ! src/share/classes/java/awt/datatransfer/package.html ! src/share/classes/java/awt/dnd/package.html ! src/share/classes/java/awt/doc-files/AWTThreadIssues.html ! src/share/classes/java/awt/doc-files/DesktopProperties.html ! src/share/classes/java/awt/doc-files/FocusSpec.html ! src/share/classes/java/awt/doc-files/Modality.html ! src/share/classes/java/awt/event/package.html ! src/share/classes/java/awt/font/package.html ! src/share/classes/java/awt/geom/package.html ! src/share/classes/java/awt/image/package.html ! src/share/classes/java/awt/image/renderable/package.html ! src/share/classes/java/awt/package.html ! src/share/classes/java/awt/print/package.html ! src/share/classes/javax/print/attribute/package.html ! src/share/classes/javax/print/attribute/standard/package.html ! src/share/classes/javax/print/event/package.html ! src/share/classes/javax/print/package.html ! src/share/classes/javax/swing/border/package.html ! src/share/classes/javax/swing/colorchooser/package.html ! src/share/classes/javax/swing/event/package.html ! src/share/classes/javax/swing/filechooser/package.html ! src/share/classes/javax/swing/plaf/basic/package.html ! src/share/classes/javax/swing/plaf/metal/package.html ! src/share/classes/javax/swing/plaf/multi/doc-files/multi_tsc.html ! src/share/classes/javax/swing/plaf/multi/package.html ! src/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html ! src/share/classes/javax/swing/plaf/nimbus/package.html ! src/share/classes/javax/swing/plaf/package.html ! src/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html ! src/share/classes/javax/swing/plaf/synth/package.html ! src/share/classes/javax/swing/table/package.html ! src/share/classes/javax/swing/text/html/package.html ! src/share/classes/javax/swing/text/html/parser/package.html ! src/share/classes/javax/swing/text/package.html ! src/share/classes/javax/swing/text/rtf/package.html ! src/share/classes/javax/swing/tree/package.html ! src/share/classes/javax/swing/undo/package.html Changeset: 69a17384fe22 Author: malenkov Date: 2013-10-14 13:22 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/69a17384fe22 7165112: Incomprehensible garbage in doc for RootPaneContainer Reviewed-by: alexsch ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/RootPaneContainer.java Changeset: 9f49b055e983 Author: malenkov Date: 2013-10-14 13:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9f49b055e983 7016396: (spec) JCK test mentioned in 6735293 is still failing Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/CompositeView.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/View.java Changeset: 54a6e22b749c Author: malenkov Date: 2013-10-14 14:13 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/54a6e22b749c 7035495: javax.swing.ImageIcon spec should be clarified Reviewed-by: alexsch ! src/share/classes/javax/swing/ImageIcon.java Changeset: 5e0ed469c36a Author: alexsch Date: 2013-10-14 18:19 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5e0ed469c36a 8005391: Floating behavior of HTMLEditorKit parser Reviewed-by: malenkov, leonidr Contributed-by: Alexander Shusherov ! src/share/classes/javax/swing/text/SimpleAttributeSet.java + test/javax/swing/text/html/8005391/bug8005391.java Changeset: 24fd0716d8d6 Author: alexsch Date: 2013-10-14 18:52 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/24fd0716d8d6 8020708: NLS mnemonics missing in SwingSet2/JInternalFrame demo Reviewed-by: malenkov, leonidr ! src/share/classes/com/sun/java/swing/plaf/motif/MotifInternalFrameTitlePane.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameTitlePane.java + test/javax/swing/JInternalFrame/8020708/bug8020708.java Changeset: 9546631f14ca Author: serb Date: 2013-10-14 20:11 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9546631f14ca 8019591: JCK: testICSEthrowing_fullScreen fails: no ICSE thrown Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java + test/java/awt/Window/WindowGCInFullScreen/WindowGCInFullScreen.java Changeset: f9548641d699 Author: serb Date: 2013-10-15 20:37 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f9548641d699 7059886: 6 JCK manual awt/Desktop tests fail with GTKLookAndFeel - GTK intialization issue Reviewed-by: anthony, art Contributed-by: alexander.zvegintsev at oracle.com + src/solaris/classes/sun/misc/GThreadHelper.java ! src/solaris/native/sun/awt/awt_UNIXToolkit.c ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/gtk2_interface.h ! src/solaris/native/sun/xawt/awt_Desktop.c Changeset: 89546b9be510 Author: serb Date: 2013-10-15 20:40 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/89546b9be510 8025225: Window.setAlwaysOnTop documentation should be updated Reviewed-by: anthony, art Contributed-by: alexander.zvegintsev at oracle.com ! src/share/classes/java/awt/Window.java Changeset: 229b10e97bd2 Author: bagiras Date: 2013-10-16 19:02 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/229b10e97bd2 2228674: Fix failed for CR 7162144 Reviewed-by: art, anthony ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java Changeset: 70242d821c66 Author: serb Date: 2013-10-17 20:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/70242d821c66 8022657: Add FunctionalInterface annotation to awt interfaces Reviewed-by: anthony, art ! src/share/classes/java/awt/KeyEventDispatcher.java ! src/share/classes/java/awt/KeyEventPostProcessor.java Changeset: 3c2d4569a6a3 Author: serb Date: 2013-10-17 21:22 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3c2d4569a6a3 8026356: [macosx] Found one Java-level deadlock:"AWT-EventQueue-0" && main Reviewed-by: anthony, art ! src/share/classes/java/awt/Component.java Changeset: 5334c651c7ba Author: yan Date: 2013-10-18 15:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5334c651c7ba 7002846: Fix for 6989505 may be incomplete Reviewed-by: anthony, art Contributed-by: Andrei Eremeev ! src/windows/classes/sun/awt/windows/WRobotPeer.java ! src/windows/native/sun/windows/awt_Robot.cpp ! src/windows/native/sun/windows/awt_Robot.h Changeset: 84ae644933b6 Author: serb Date: 2013-10-18 20:35 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/84ae644933b6 8026476: Choice does not get mouse events if it does not have enough place for popup menu Reviewed-by: anthony, serb Contributed-by: alexander.zvegintsev at oracle.com ! src/solaris/classes/sun/awt/X11/XChoicePeer.java Changeset: d72ca6dac444 Author: leonidr Date: 2013-10-22 16:45 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d72ca6dac444 8020209: [macosx] Mac OS X key event confusion for "COMMAND PLUS" Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/osxapp/NSApplicationAWT.m + test/java/awt/event/KeyEvent/8020209/bug8020209.java ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 4ad826a08e6f Author: serb Date: 2013-10-23 16:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4ad826a08e6f 8020851: java.awt.event.WindowEvent spec should state that WINDOW_CLOSED event may not be delivered under certain circumstances Reviewed-by: anthony, art ! src/share/classes/java/awt/event/WindowEvent.java Changeset: cd2e3c63ee42 Author: serb Date: 2013-10-24 14:32 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cd2e3c63ee42 7090424: TestGlyphVectorLayout failed automately with java.lang.StackOverflowError Reviewed-by: anthony, art ! src/solaris/classes/sun/awt/X11/XButtonPeer.java ! src/solaris/classes/sun/awt/X11/XCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XLabelPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java + test/java/awt/Paint/ButtonRepaint.java + test/java/awt/Paint/CheckboxRepaint.java + test/java/awt/Paint/ExposeOnEDT.java + test/java/awt/Paint/LabelRepaint.java + test/java/awt/Paint/ListRepaint.java Changeset: 7c84aff91033 Author: pchelko Date: 2013-10-24 19:23 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7c84aff91033 8027030: AWT Multiple JVM DnD Test Failing on Linux (OEL and Ubuntu) and Solaris (Sparc and x64) Reviewed-by: anthony, serb ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: c561db53a24c Author: pchelko Date: 2013-10-24 19:50 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c561db53a24c 8027025: [macosx] getLocationOnScreen returns 0 if parent invisible Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/Window/8027025/Test8027025.java Changeset: 6fe5443c3dde Author: alitvinov Date: 2013-10-25 13:41 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6fe5443c3dde 8027066: XMLDecoder in java 7 cannot properly deserialize object arrays Reviewed-by: alexsch, malenkov Contributed-by: anton.nashatyrev at oracle.com ! src/share/classes/com/sun/beans/decoder/ArrayElementHandler.java + test/java/beans/XMLEncoder/Test8027066.java Changeset: 75ae2a980db5 Author: malenkov Date: 2013-10-25 16:42 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/75ae2a980db5 8026705: [TEST_BUG] java/beans/Introspector/TestTypeResolver.java failed Reviewed-by: art, jfranck ! test/java/beans/Introspector/TestTypeResolver.java Changeset: dab1d3798016 Author: serb Date: 2013-10-25 19:51 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/dab1d3798016 7172770: Default Toolkit implementation return null value for property "awt.dynamicLayoutSupported" Reviewed-by: anthony, art ! src/share/classes/java/awt/Toolkit.java Changeset: 162c57b874d4 Author: lana Date: 2013-10-25 10:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/162c57b874d4 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html ! src/share/classes/java/awt/datatransfer/DataFlavor.java - src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/sun/awt/AppContext.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 55cab2211ae9 Author: ant Date: 2013-10-29 16:35 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/55cab2211ae9 8027157: [SwingNode] needs explicit expose for JWindow Reviewed-by: art, anthony ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WLightweightFramePeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: bedc29a6d074 Author: malenkov Date: 2013-10-29 17:01 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bedc29a6d074 8022746: List of spelling errors in API doc Reviewed-by: alexsch, smarks ! src/macosx/bundle/JavaAppLauncher/src/JVMArgs.m ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/AquaMenuPainter.java ! src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java ! src/macosx/classes/com/apple/laf/AquaTreeUI.java ! src/macosx/classes/java/net/DefaultInterface.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java ! src/macosx/classes/sun/font/CFontManager.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/CTextPipe.m ! src/share/back/commonRef.c ! src/share/back/eventFilter.c ! src/share/back/util.c ! src/share/classes/com/sun/beans/decoder/AccessorElementHandler.java ! src/share/classes/com/sun/beans/decoder/ArrayElementHandler.java ! src/share/classes/com/sun/beans/decoder/BooleanElementHandler.java ! src/share/classes/com/sun/beans/decoder/ByteElementHandler.java ! src/share/classes/com/sun/beans/decoder/CharElementHandler.java ! src/share/classes/com/sun/beans/decoder/ClassElementHandler.java ! src/share/classes/com/sun/beans/decoder/DoubleElementHandler.java ! src/share/classes/com/sun/beans/decoder/ElementHandler.java ! src/share/classes/com/sun/beans/decoder/FalseElementHandler.java ! src/share/classes/com/sun/beans/decoder/FieldElementHandler.java ! src/share/classes/com/sun/beans/decoder/FloatElementHandler.java ! src/share/classes/com/sun/beans/decoder/IntElementHandler.java ! src/share/classes/com/sun/beans/decoder/JavaElementHandler.java ! src/share/classes/com/sun/beans/decoder/LongElementHandler.java ! src/share/classes/com/sun/beans/decoder/MethodElementHandler.java ! src/share/classes/com/sun/beans/decoder/NewElementHandler.java ! src/share/classes/com/sun/beans/decoder/NullElementHandler.java ! src/share/classes/com/sun/beans/decoder/ObjectElementHandler.java ! src/share/classes/com/sun/beans/decoder/PropertyElementHandler.java ! src/share/classes/com/sun/beans/decoder/ShortElementHandler.java ! src/share/classes/com/sun/beans/decoder/StringElementHandler.java ! src/share/classes/com/sun/beans/decoder/TrueElementHandler.java ! src/share/classes/com/sun/beans/decoder/VarElementHandler.java ! src/share/classes/com/sun/beans/decoder/VoidElementHandler.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBES1Core.java ! src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java ! src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java ! src/share/classes/com/sun/imageio/plugins/common/StandardMetadataFormat.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsGraphicsUtils.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTextFieldUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTextUI.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/jdi/connect/ListeningConnector.java ! src/share/classes/com/sun/jdi/connect/spi/TransportService.java ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/TokenMgrError.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpErrorHandlerAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgentMBean.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpRequestTree.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpTableSupport.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServerMBean.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubNextRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubRequestHandler.java ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/Filter.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapName.java ! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java ! src/share/classes/com/sun/jndi/toolkit/dir/ContextEnumerator.java ! src/share/classes/com/sun/media/sound/AbstractMidiDevice.java ! src/share/classes/com/sun/media/sound/AudioSynthesizerPropertyInfo.java ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/SoftMixingSourceDataLine.java ! src/share/classes/com/sun/net/httpserver/Headers.java ! src/share/classes/com/sun/net/httpserver/HttpExchange.java ! src/share/classes/com/sun/net/ssl/internal/ssl/Provider.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/package.html ! src/share/classes/com/sun/security/auth/module/LdapLoginModule.java ! src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java ! src/share/classes/com/sun/tools/example/debug/expr/TokenMgrError.java ! src/share/classes/com/sun/tools/hat/resources/hat.js ! src/share/classes/com/sun/tools/jdi/SocketAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/SocketListeningConnector.java ! src/share/classes/com/sun/tools/jdi/ThreadListener.java ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/share/classes/java/awt/AWTEventMulticaster.java ! src/share/classes/java/awt/AlphaComposite.java ! src/share/classes/java/awt/BasicStroke.java ! src/share/classes/java/awt/BorderLayout.java ! src/share/classes/java/awt/CheckboxMenuItem.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Event.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/Graphics.java ! src/share/classes/java/awt/Graphics2D.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/MediaTracker.java ! src/share/classes/java/awt/MenuComponent.java ! src/share/classes/java/awt/MultipleGradientPaintContext.java ! src/share/classes/java/awt/Polygon.java ! src/share/classes/java/awt/PopupMenu.java ! src/share/classes/java/awt/RenderingHints.java ! src/share/classes/java/awt/ScrollPane.java ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/java/awt/Shape.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/datatransfer/FlavorMap.java ! src/share/classes/java/awt/datatransfer/MimeTypeParameterList.java ! src/share/classes/java/awt/dnd/DragGestureListener.java ! src/share/classes/java/awt/dnd/DragGestureRecognizer.java ! src/share/classes/java/awt/dnd/DragSourceContext.java ! src/share/classes/java/awt/dnd/DragSourceEvent.java ! src/share/classes/java/awt/dnd/DropTarget.java ! src/share/classes/java/awt/dnd/InvalidDnDOperationException.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/java/awt/font/FontRenderContext.java ! src/share/classes/java/awt/font/GlyphMetrics.java ! src/share/classes/java/awt/font/GlyphVector.java ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/java/awt/font/TextLayout.java ! src/share/classes/java/awt/font/TransformAttribute.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/awt/geom/Path2D.java ! src/share/classes/java/awt/geom/QuadCurve2D.java ! src/share/classes/java/awt/im/InputMethodRequests.java ! src/share/classes/java/awt/image/BandedSampleModel.java ! src/share/classes/java/awt/image/BufferStrategy.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/awt/image/ComponentColorModel.java ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/java/awt/image/ImageConsumer.java ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/java/awt/image/PixelInterleavedSampleModel.java ! src/share/classes/java/awt/image/renderable/RenderableImage.java ! src/share/classes/java/awt/image/renderable/RenderableImageOp.java ! src/share/classes/java/beans/AppletInitializer.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/PropertyEditorSupport.java ! src/share/classes/java/beans/beancontext/BeanContextChildSupport.java ! src/share/classes/java/beans/beancontext/BeanContextServiceRevokedListener.java ! src/share/classes/java/beans/beancontext/BeanContextServicesSupport.java ! src/share/classes/java/beans/beancontext/BeanContextSupport.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/ObjectStreamConstants.java ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/management/CompilationMXBean.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java ! src/share/classes/java/net/Authenticator.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/InetSocketAddress.java ! src/share/classes/java/net/InterfaceAddress.java ! src/share/classes/java/net/JarURLConnection.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/StandardSocketOptions.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/MembershipKey.java ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java ! src/share/classes/java/rmi/MarshalledObject.java ! src/share/classes/java/security/AccessControlException.java ! src/share/classes/java/security/DigestOutputStream.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/cert/CertificateRevokedException.java ! src/share/classes/java/security/spec/ECFieldF2m.java ! src/share/classes/java/sql/Array.java ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Clob.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DataTruncation.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/DriverPropertyInfo.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLException.java ! src/share/classes/java/sql/SQLFeatureNotSupportedException.java ! src/share/classes/java/sql/SQLIntegrityConstraintViolationException.java ! src/share/classes/java/sql/SQLInvalidAuthorizationSpecException.java ! src/share/classes/java/sql/SQLNonTransientConnectionException.java ! src/share/classes/java/sql/SQLNonTransientException.java ! src/share/classes/java/sql/SQLRecoverableException.java ! src/share/classes/java/sql/SQLSyntaxErrorException.java ! src/share/classes/java/sql/SQLTimeoutException.java ! src/share/classes/java/sql/SQLTransactionRollbackException.java ! src/share/classes/java/sql/SQLTransientConnectionException.java ! src/share/classes/java/sql/SQLTransientException.java ! src/share/classes/java/sql/SQLWarning.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Struct.java ! src/share/classes/java/sql/package.html ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/FieldPosition.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RuleBasedCollator.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/MissingFormatWidthException.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ExecutorCompletionService.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/share/classes/javax/accessibility/AccessibleText.java ! src/share/classes/javax/crypto/NullCipher.java ! src/share/classes/javax/crypto/NullCipherSpi.java ! src/share/classes/javax/imageio/IIOParam.java ! src/share/classes/javax/imageio/ImageIO.java ! src/share/classes/javax/imageio/ImageReader.java ! src/share/classes/javax/imageio/ImageWriteParam.java ! src/share/classes/javax/imageio/ImageWriter.java ! src/share/classes/javax/imageio/event/IIOReadProgressListener.java ! src/share/classes/javax/imageio/event/IIOReadUpdateListener.java ! src/share/classes/javax/imageio/event/IIOReadWarningListener.java ! src/share/classes/javax/imageio/event/IIOWriteWarningListener.java ! src/share/classes/javax/imageio/metadata/IIOMetadata.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormat.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormatImpl.java ! src/share/classes/javax/imageio/metadata/doc-files/standard_metadata.html ! src/share/classes/javax/imageio/spi/ImageReaderSpi.java ! src/share/classes/javax/imageio/spi/ImageReaderWriterSpi.java ! src/share/classes/javax/imageio/stream/ImageInputStream.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationServiceMBean.java ! src/share/classes/javax/management/remote/rmi/package.html ! src/share/classes/javax/naming/Binding.java ! src/share/classes/javax/naming/InsufficientResourcesException.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/net/ssl/SSLPeerUnverifiedException.java ! src/share/classes/javax/net/ssl/SSLSocket.java ! src/share/classes/javax/print/CancelablePrintJob.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/DocPrintJob.java ! src/share/classes/javax/print/MultiDoc.java ! src/share/classes/javax/print/PrintService.java ! src/share/classes/javax/print/attribute/standard/MediaTray.java ! src/share/classes/javax/print/attribute/standard/PresentationDirection.java ! src/share/classes/javax/print/attribute/standard/PrinterIsAcceptingJobs.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReason.java ! src/share/classes/javax/print/package.html ! src/share/classes/javax/script/AbstractScriptEngine.java ! src/share/classes/javax/script/CompiledScript.java ! src/share/classes/javax/script/Invocable.java ! src/share/classes/javax/script/ScriptEngine.java ! src/share/classes/javax/script/ScriptEngineFactory.java ! src/share/classes/javax/security/sasl/RealmChoiceCallback.java ! src/share/classes/javax/security/sasl/Sasl.java ! src/share/classes/javax/security/sasl/SaslClient.java ! src/share/classes/javax/security/sasl/SaslException.java ! src/share/classes/javax/smartcardio/CardChannel.java ! src/share/classes/javax/smartcardio/CardTerminal.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/MidiMessage.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/midi/ShortMessage.java ! src/share/classes/javax/sound/midi/Soundbank.java ! src/share/classes/javax/sound/midi/Synthesizer.java ! src/share/classes/javax/sound/sampled/AudioFormat.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/sound/sampled/ReverbType.java ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/JoinRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java ! src/share/classes/javax/sql/rowset/spi/TransactionalWriter.java ! src/share/classes/javax/sql/rowset/spi/XmlReader.java ! src/share/classes/javax/sql/rowset/spi/XmlWriter.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DefaultRowSorter.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JFormattedTextField.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/LookAndFeel.java ! src/share/classes/javax/swing/ProgressMonitor.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/ScrollPaneConstants.java ! src/share/classes/javax/swing/SpinnerDateModel.java ! src/share/classes/javax/swing/SpinnerModel.java ! src/share/classes/javax/swing/SpinnerNumberModel.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/ToolTipManager.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/event/DocumentEvent.java ! src/share/classes/javax/swing/event/HyperlinkEvent.java ! src/share/classes/javax/swing/event/TableModelEvent.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/filechooser/FileSystemView.java ! src/share/classes/javax/swing/plaf/ComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicBorders.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTableUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolTipUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTreeUI.java ! src/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java ! src/share/classes/javax/swing/plaf/nimbus/LoweredBorder.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html ! src/share/classes/javax/swing/table/DefaultTableColumnModel.java ! src/share/classes/javax/swing/table/JTableHeader.java ! src/share/classes/javax/swing/table/TableColumn.java ! src/share/classes/javax/swing/table/TableColumnModel.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/AbstractWriter.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/BoxView.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultHighlighter.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/DocumentFilter.java ! src/share/classes/javax/swing/text/ElementIterator.java ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/GapContent.java ! src/share/classes/javax/swing/text/GapVector.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/ParagraphView.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/WrappedPlainView.java ! src/share/classes/javax/swing/text/ZoneView.java ! src/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/share/classes/javax/swing/text/html/BlockView.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/CSSParser.java ! src/share/classes/javax/swing/text/html/FormSubmitEvent.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/FrameSetView.java ! src/share/classes/javax/swing/text/html/HTML.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/HTMLFrameHyperlinkEvent.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/javax/swing/text/html/ParagraphView.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/TableView.java ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src/share/classes/javax/swing/text/html/parser/DocumentParser.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/TreeModel.java ! src/share/classes/javax/swing/tree/TreeSelectionModel.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/javax/xml/crypto/KeySelector.java ! src/share/classes/javax/xml/crypto/MarshalException.java ! src/share/classes/javax/xml/crypto/dsig/TransformException.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignatureException.java ! src/share/classes/jdi-overview.html ! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java ! src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java ! src/share/classes/jdk/internal/util/xml/XMLStreamException.java ! src/share/classes/jdk/internal/util/xml/impl/Parser.java ! src/share/classes/org/ietf/jgss/GSSContext.java ! src/share/classes/org/ietf/jgss/GSSCredential.java ! src/share/classes/org/ietf/jgss/GSSException.java ! src/share/classes/org/ietf/jgss/GSSManager.java ! src/share/classes/org/ietf/jgss/GSSName.java ! src/share/classes/org/ietf/jgss/package.html ! src/share/classes/sun/applet/AppletSecurity.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/GlobalCursorManager.java ! src/share/classes/sun/awt/shell/ShellFolderManager.java ! src/share/classes/sun/dc/DuctusRenderingEngine.java ! src/share/classes/sun/font/ExtendedTextSourceLabel.java ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/FontRunIterator.java ! src/share/classes/sun/font/LayoutPathImpl.java ! src/share/classes/sun/font/ScriptRun.java ! src/share/classes/sun/font/StrikeCache.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/font/Type1Font.java ! src/share/classes/sun/java2d/SurfaceDataProxy.java ! src/share/classes/sun/java2d/loops/ProcessPath.java ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/pipe/BufferedMaskFill.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/BufferedTextPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/classes/sun/java2d/pipe/RenderingEngine.java ! src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventNotifier.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfDataBufferImpl.java ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/FileMonitoredVm.java ! src/share/classes/sun/management/counter/perf/InstrumentationException.java ! src/share/classes/sun/management/counter/perf/PerfDataType.java ! src/share/classes/sun/misc/CRC16.java ! src/share/classes/sun/misc/CharacterDecoder.java ! src/share/classes/sun/misc/PerformanceLogger.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/TelnetOutputStream.java ! src/share/classes/sun/net/ftp/FtpClient.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/idn/StringPrep.java ! src/share/classes/sun/net/smtp/SmtpProtocolException.java ! src/share/classes/sun/net/www/http/ChunkedInputStream.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/http/PosterOutputStream.java ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/print/PSPathGraphics.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/print/PathGraphics.java ! src/share/classes/sun/print/PrintJob2D.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/share/classes/sun/rmi/rmic/RemoteClass.java ! src/share/classes/sun/rmi/rmic/Util.java ! src/share/classes/sun/rmi/rmic/newrmic/jrmp/StubSkeletonWriter.java ! src/share/classes/sun/rmi/runtime/Log.java ! src/share/classes/sun/rmi/server/Activation.java ! src/share/classes/sun/rmi/transport/ObjectTable.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/rmi/transport/tcp/MultiplexOutputStream.java ! src/share/classes/sun/rmi/transport/tcp/TCPChannel.java ! src/share/classes/sun/security/jca/GetInstance.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5NameElement.java ! src/share/classes/sun/security/jgss/krb5/MessageToken.java ! src/share/classes/sun/security/jgss/spi/GSSContextSpi.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/internal/CredentialsUtil.java ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/share/classes/sun/security/krb5/internal/crypto/DesCbcEType.java ! src/share/classes/sun/security/pkcs11/P11DHKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java ! src/share/classes/sun/security/provider/DSA.java ! src/share/classes/sun/security/provider/certpath/AdjacencyList.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/rsa/RSAKeyPairGenerator.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/RSASignature.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/util/HostnameChecker.java ! src/share/classes/sun/security/x509/AlgIdDSA.java ! src/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/share/classes/sun/swing/plaf/synth/Paint9Painter.java ! src/share/classes/sun/text/normalizer/ReplaceableUCharacterIterator.java ! src/share/classes/sun/text/resources/th/CollationData_th.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jconsole/BorderedComponent.java ! src/share/classes/sun/tools/jconsole/inspector/XTextField.java ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jstat/ColumnFormat.java ! src/share/classes/sun/tools/jstat/resources/jstat_options ! src/share/classes/sun/tools/tree/ExprExpression.java ! src/share/classes/sun/tools/tree/FieldExpression.java ! src/share/classes/sun/util/locale/provider/RuleBasedBreakIterator.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! src/share/demo/jfc/Font2DTest/FontPanel.java ! src/share/demo/jfc/TableExample/TableExample4.java ! src/share/demo/jvmti/hprof/debug_malloc.c ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/javavm/export/jvm.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/share/native/com/sun/media/sound/PlatformMidi.h ! src/share/native/common/jni_util.h ! src/share/native/java/lang/fdlibm/src/k_rem_pio2.c ! src/share/native/java/util/zip/zip_util.c ! src/share/native/sun/awt/image/cvutils/img_dcm.h ! src/share/native/sun/awt/image/cvutils/img_replscale.h ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/image/jpeg/jpegdecoder.c ! src/share/native/sun/awt/libpng/CHANGES ! src/share/native/sun/awt/libpng/png.h ! src/share/native/sun/awt/libpng/pngconf.h ! src/share/native/sun/awt/libpng/pngpriv.h ! src/share/native/sun/awt/libpng/pngrutil.c ! src/share/native/sun/font/layout/ArabicLayoutEngine.h ! src/share/native/sun/font/layout/IndicReordering.h ! src/share/native/sun/font/layout/KhmerReordering.cpp ! src/share/native/sun/font/layout/OpenTypeLayoutEngine.h ! src/share/native/sun/font/layout/TibetanReordering.cpp ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! src/share/native/sun/java2d/cmm/lcms/cmslut.c ! src/share/native/sun/java2d/loops/ProcessPath.c ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sessmgmt.c ! src/share/sample/jmx/jmx-scandir/index.html ! src/share/sample/nio/chatserver/ClientReader.java ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/solaris/classes/java/net/DefaultInterface.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XMenuItemPeer.java ! src/solaris/classes/sun/awt/X11/XScrollbar.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/font/XMap.java ! src/solaris/classes/sun/java2d/jules/JulesAATileGenerator.java ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixUriUtils.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/demo/jni/Poller/Poller.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_BsdOS_ALSA_Ports.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_PCM.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_Utils.h ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/multiVis.c ! src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite.h ! src/windows/classes/com/sun/tools/jdi/SharedMemoryAttachingConnector.java ! src/windows/classes/com/sun/tools/jdi/SharedMemoryListeningConnector.java ! src/windows/classes/java/net/DefaultInterface.java ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java ! src/windows/native/java/io/canonicalize_md.c ! src/windows/native/java/net/DualStackPlainSocketImpl.c ! src/windows/native/java/net/icmp.h ! src/windows/native/sun/font/fontpath.c ! src/windows/native/sun/java2d/d3d/D3DTextRenderer.cpp ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp ! src/windows/native/sun/nio/ch/SocketChannelImpl.c ! src/windows/native/sun/security/krb5/NativeCreds.c ! src/windows/native/sun/windows/ThemeReader.cpp ! src/windows/native/sun/windows/awt_BitmapUtil.cpp ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Dialog.h ! src/windows/native/sun/windows/awt_DnDDS.cpp ! src/windows/native/sun/windows/awt_Font.h ! src/windows/native/sun/windows/awt_InputTextInfor.cpp ! src/windows/native/sun/windows/awt_PrintJob.cpp ! src/windows/native/sun/windows/awt_TextComponent.cpp Changeset: d4eb25382baf Author: malenkov Date: 2013-10-29 19:01 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d4eb25382baf 8027442: JDK compilation fails on MacOS Reviewed-by: alexsch, pchelko ! src/share/classes/java/awt/Component.java Changeset: a2b42e558211 Author: bagiras Date: 2013-10-29 21:46 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a2b42e558211 8027151: AWT_DnD/Basic_DnD/Automated/DnDMerlinQL/MultipleJVM failing on windows machine Reviewed-by: anthony, pchelko ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java Changeset: db2838f25a85 Author: pchelko Date: 2013-10-30 12:00 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/db2838f25a85 8027152: Regression: test closed/java/awt/Serialize/NullSerializationTest/NullSerializationTest.html fails since JDK 8 b112 Reviewed-by: art, serb ! src/share/classes/java/awt/Window.java + test/java/awt/Window/OwnedWindowsSerialization/OwnedWindowsSerialization.java Changeset: 05f04b1c5bd0 Author: leonidr Date: 2013-10-30 20:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/05f04b1c5bd0 8013581: [macosx] Key Bindings break with awt GraphicsEnvironment setFullScreenWindow Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformLWView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CWrapper.m + test/java/awt/FullScreen/8013581/bug8013581.java Changeset: 6f436140049d Author: lana Date: 2013-10-31 16:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6f436140049d Merge ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: 042a473535aa Author: mchung Date: 2013-10-17 19:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/042a473535aa 8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement API is provided Reviewed-by: alanb, forax, dholmes, twisti ! makefiles/mapfiles/libjava/mapfile-vers ! makefiles/mapfiles/libjava/reorder-sparc ! makefiles/mapfiles/libjava/reorder-sparcv9 ! makefiles/mapfiles/libjava/reorder-x86 ! src/share/classes/sun/reflect/Reflection.java ! src/share/javavm/export/jvm.h ! src/share/native/sun/reflect/Reflection.c + test/sun/reflect/Reflection/GetCallerClassWithDepth.java Changeset: 8a7b1b615100 Author: darcy Date: 2013-10-17 22:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a7b1b615100 8026840: Fix new doclint issues in javax.naming Reviewed-by: mchung ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/CompoundName.java ! src/share/classes/javax/naming/Context.java ! src/share/classes/javax/naming/InitialContext.java ! src/share/classes/javax/naming/ReferralException.java ! src/share/classes/javax/naming/directory/DirContext.java ! src/share/classes/javax/naming/event/EventContext.java ! src/share/classes/javax/naming/ldap/LdapContext.java ! src/share/classes/javax/naming/ldap/Rdn.java Changeset: 658e121bda42 Author: sherman Date: 2013-10-17 23:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/658e121bda42 8025971: Remove ZoneId.OLD_SHORT_IDS 8026197: Slow reading tzdb.dat if the JRE is on a high-latency, remote file system Summary: removed the compatiblity old short-ids mapping Reviewed-by: okutsu ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/util/Calendar/JavatimeTest.java Changeset: 8479a48d9fd4 Author: sla Date: 2013-10-18 11:52 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8479a48d9fd4 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals() Reviewed-by: alanb, sspitsyn ! src/share/back/outStream.c + test/com/sun/jdi/GetUninitializedStringValue.java Changeset: da695008417f Author: alanb Date: 2013-10-18 13:45 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/da695008417f 8026859: (fs) test/java/nio/file/Files/StreamTest.java fails to compile intermittently Reviewed-by: psandoz ! test/java/nio/file/Files/StreamTest.java Changeset: 4e065f5b4a16 Author: igerasim Date: 2013-10-18 16:06 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4e065f5b4a16 8026756: Test java/util/zip/GZIP/GZIPInZip.java failed Reviewed-by: alanb ! test/java/util/zip/GZIP/GZIPInZip.java Changeset: 329cf77821e8 Author: alanb Date: 2013-10-18 13:51 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/329cf77821e8 7050570: (fs) FileSysteProvider fails to initializes if run with file.encoding set to Cp037 Reviewed-by: sherman, ulfzibis ! src/share/classes/sun/nio/fs/Util.java ! src/solaris/classes/sun/nio/fs/GnomeFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java ! src/solaris/classes/sun/nio/fs/LinuxUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/UnixException.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileSystem.java ! src/solaris/classes/sun/nio/fs/UnixMountEntry.java ! src/solaris/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixUserPrincipals.java Changeset: 4161f17dfe2b Author: sjiang Date: 2013-10-18 16:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4161f17dfe2b 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package Reviewed-by: psandoz, dfuchs ! src/share/classes/com/sun/jmx/snmp/SnmpString.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMib.java ! src/share/classes/com/sun/jmx/snmp/daemon/CommunicatorServer.java + test/com/sun/jmx/snmp/NoInfoLeakTest.java Changeset: 602aa6fa46c6 Author: alanb Date: 2013-10-18 15:51 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/602aa6fa46c6 8026876: (fs) Build issue with src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java Reviewed-by: psandoz ! src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java Changeset: 93f4f012deaf Author: alanb Date: 2013-10-18 16:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/93f4f012deaf Merge Changeset: 8d1d5a5aeb41 Author: robm Date: 2013-10-18 16:28 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8d1d5a5aeb41 8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log open in fastdebug builds Reviewed-by: alanb Contributed-by: pavel.punegov at oracle.com ! test/java/lang/ProcessBuilder/InheritIOEHandle.java ! test/java/lang/ProcessBuilder/SiblingIOEHandle.java Changeset: 88436832cfd0 Author: dsamersoff Date: 2013-10-19 00:05 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88436832cfd0 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields Summary: Add some extra fileds to jdp packet Reviewed-by: allwin, sla, hirt ! src/share/classes/sun/management/jdp/JdpController.java ! src/share/classes/sun/management/jdp/JdpJmxPacket.java ! test/sun/management/jdp/JdpClient.java ! test/sun/management/jdp/JdpDoSomething.java ! test/sun/management/jdp/JdpTest.sh Changeset: 7a947daa8f51 Author: rriggs Date: 2013-10-18 16:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7a947daa8f51 8025828: Late binding of Chronology to appendValueReduced Summary: Add a listener to the parseContext called when the Chronology changes Reviewed-by: sherman ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! test/java/time/test/java/time/format/TestReducedParser.java Changeset: fbb7510f788d Author: vromero Date: 2013-10-19 17:53 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fbb7510f788d 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis Reviewed-by: psandoz ! src/share/classes/java/time/temporal/TemporalQueries.java Changeset: 392acefef659 Author: dsamersoff Date: 2013-10-19 20:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/392acefef659 8024071: In ManagementAgent.start it should be possible to set the jdp.name parameter. Summary: Pass one more property from Agent to JdpController Reviewed-by: jbachorik, sla ! src/share/classes/sun/management/Agent.java ! test/sun/management/jdp/JdpTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: ede89a97e80a Author: ksrini Date: 2013-10-19 15:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ede89a97e80a 8026794: Test tools/pack200/TimeStamp.java fails while opening golden.jar.native.IST on linux-ppc(v2) Reviewed-by: dholmes ! src/share/native/com/sun/java/util/jar/pack/zip.cpp Changeset: 71ecbde5e5e4 Author: rfield Date: 2013-10-20 18:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/71ecbde5e5e4 8025631: Enhance Lambda construction Reviewed-by: ksrini, ahgross ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java - src/share/classes/java/lang/invoke/MagicLambdaImpl.java Changeset: 30c46debdf0f Author: jbachorik Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/30c46debdf0f 7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has concurency issues Reviewed-by: sla, mchung ! test/java/lang/management/ThreadMXBean/ThreadBlockedCount.java Changeset: d8694ad1ed2d Author: jbachorik Date: 2013-10-21 10:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d8694ad1ed2d 8024613: javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently Summary: RMID needs a varying amount of time to start its socket server. We need to cater for it. Reviewed-by: sjiang, dfuchs, sla ! test/javax/management/remote/mandatory/connection/RMIConnector_NPETest.java Changeset: 567d47fd3fe2 Author: dfuchs Date: 2013-10-21 11:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/567d47fd3fe2 8016344: (props) Properties.storeToXML behaviour has changed from JDK 6 to 7 Summary: When storing Properties to XML only locally defined properties must be saved. Reviewed-by: psandoz, mchung, alanb ! src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java ! src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java + test/java/util/Properties/LoadAndStoreXMLWithDefaults.java Changeset: c81125493ca6 Author: dfuchs Date: 2013-10-21 12:00 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c81125493ca6 8026499: Root Logger level can be reset unexpectedly Summary: This fix prevents the logger's level to be re-initialized if it has already been initialized. Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java Changeset: 698baf22e081 Author: jbachorik Date: 2013-10-21 13:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/698baf22e081 7140929: NotSerializableNotifTest.java fails intermittently Reviewed-by: sjiang, alanb ! test/javax/management/remote/mandatory/notif/NotSerializableNotifTest.java Changeset: f0c18a5e3ae5 Author: sherman Date: 2013-10-21 11:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f0c18a5e3ae5 8026842: Remove Time-Zone IDs HST/EST/MST Summary: removed these ids from ZoneId's zid list, supported via short_ids list Reviewed-by: okutsu ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java Changeset: c1700125d041 Author: darcy Date: 2013-10-21 12:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c1700125d041 8022658: Revisit FunctionalInterface on some core libs types Reviewed-by: briangoetz, mduigou, mr ! src/share/classes/java/io/Closeable.java ! src/share/classes/java/io/Flushable.java ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Comparable.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Readable.java Changeset: e8683d5b2b0a Author: peytoia Date: 2013-10-22 06:13 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e8683d5b2b0a 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char Reviewed-by: naoto ! src/share/classes/java/lang/ConditionalSpecialCasing.java ! src/share/classes/java/lang/String.java ! test/java/lang/String/ToLowerCase.java Changeset: 3b00bf85a6f5 Author: sherman Date: 2013-10-21 18:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3b00bf85a6f5 8008386: (cs) Unmappable leading should be decoded to replacement. Summary: updated the unmappable/malformed detecting handling for db charsets Reviewed-by: naoto ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! test/sun/nio/cs/TestIBMBugs.java + test/sun/nio/cs/TestUnmappable.java Changeset: f581b72e3715 Author: sla Date: 2013-10-21 23:32 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f581b72e3715 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV Summary: Redefined class in stack trace may not be found by method_idnum so handle null. Reviewed-by: coleenp, dcubed, sspitsyn ! test/java/lang/instrument/RedefineMethodInBacktrace.sh ! test/java/lang/instrument/RedefineMethodInBacktraceApp.java + test/java/lang/instrument/RedefineMethodInBacktraceTargetB.java + test/java/lang/instrument/RedefineMethodInBacktraceTargetB_2.java Changeset: 975e3a89814e Author: darcy Date: 2013-10-21 13:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/975e3a89814e 8024603: Turn on javac lint checking for auxiliaryclass, empty, and try in jdk build Reviewed-by: erikj, ihse, chegar ! makefiles/Setup.gmk Changeset: f443d9b863cf Author: juh Date: 2013-10-21 22:05 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f443d9b863cf Merge Changeset: d0882a1deeb5 Author: juh Date: 2013-10-22 03:49 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d0882a1deeb5 Merge Changeset: 04ba97b7c2f9 Author: jfranck Date: 2013-10-22 10:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/04ba97b7c2f9 8009411: (reflect) Class.getMethods should not include static methods from interfaces Summary: Update getMethods() and getMethod() to filter out interface statics Reviewed-by: darcy Contributed-by: joel.franck at oracle.com, andreas.lundblad at oracle.com, amy.lu at oracle.com, peter.levart at gmail.com ! src/share/classes/java/lang/Class.java ! test/java/lang/reflect/DefaultStaticTest/DefaultStaticInvokeTest.java ! test/java/lang/reflect/DefaultStaticTest/DefaultStaticTestData.java + test/java/lang/reflect/Method/InterfaceStatic/StaticInterfaceMethodInWayOfDefault.java Changeset: bb2fb6be8b2a Author: ykantser Date: 2013-10-22 10:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bb2fb6be8b2a 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt Reviewed-by: sla, jbachorik ! test/ProblemList.txt Changeset: b07856d0de34 Author: alundblad Date: 2013-10-22 12:35 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b07856d0de34 8004912: Repeating annotations - getAnnotationsByType(Class) is not working as expected for few inheritance scenarios 8019420: Repeatable non-inheritable annotation types are mishandled by Core Reflection Reviewed-by: jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java + test/java/lang/annotation/repeatingAnnotations/NonInheritableContainee.java + test/java/lang/annotation/repeatingAnnotations/OrderUnitTest.java ! test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java Changeset: 6f9515a9519f Author: alanb Date: 2013-10-22 11:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6f9515a9519f 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks, mullan Contributed-by: alan.bateman at oralce.com, mark.sheppard at oracle.com ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: f15ad52cffed Author: alanb Date: 2013-10-22 12:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f15ad52cffed 8024833: (fc) FileChannel.map does not handle async close/interrupt correctly Reviewed-by: alanb Contributed-by: chris.w.dennis at gmail.com ! src/share/classes/sun/nio/ch/FileChannelImpl.java + test/java/nio/channels/FileChannel/InterruptMapDeadlock.java Changeset: 6a1989dc302d Author: igerasim Date: 2013-10-15 18:41 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6a1989dc302d 8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest jdk8 build Summary: Removing the test as it is unreliable and fails intermittently Reviewed-by: chegar - test/java/net/NetworkInterface/MemLeakTest.java Changeset: 7cafbb397683 Author: chegar Date: 2013-10-22 14:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7cafbb397683 8017779: java/net/Authenticator/B4769350.java fails Reviewed-by: chegar Contributed-by: Tristan Yan , Kurchi Subhra Hazra ! test/java/net/Authenticator/B4769350.java Changeset: 5f4aecd73caa Author: mullan Date: 2013-10-22 08:03 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5f4aecd73caa 8021191: Add isAuthorized check to limited doPrivileged methods Reviewed-by: weijun, xuelei ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessController.java Changeset: 948b390b6952 Author: mullan Date: 2013-10-22 08:17 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/948b390b6952 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/java/lang/invoke/MagicLambdaImpl.java - src/share/classes/java/net/HttpURLPermission.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 3ea9af449b36 Author: mullan Date: 2013-10-22 09:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3ea9af449b36 Merge - test/java/net/NetworkInterface/MemLeakTest.java Changeset: 54869853c06c Author: alanb Date: 2013-10-22 14:13 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/54869853c06c 7074436: (sc) SocketChannel can do short gathering writes when channel configured blocking (win) Reviewed-by: chegar ! src/windows/native/sun/nio/ch/SocketDispatcher.c ! test/java/nio/channels/SocketChannel/ShortWrite.java Changeset: 9758edb6976f Author: bpb Date: 2013-10-22 10:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9758edb6976f 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6 Summary: Check getaddrinfo return value before calling WSAGetLastError. Reviewed-by: alanb, dsamersoff ! src/windows/native/java/net/Inet6AddressImpl.c Changeset: 23b124cbf242 Author: drchase Date: 2013-10-22 12:57 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/23b124cbf242 8026818: Defmeth failures with -mode invoke Summary: Added test for IllegalAccessException -> IllegalAccessError path to check if root cause was AbstractMethodError Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 72c0f289a8cb Author: kizune Date: 2013-10-22 22:18 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/72c0f289a8cb 8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini Reviewed-by: ksrini ! test/tools/launcher/VersionCheck.java Changeset: 2be08cdd1ced Author: bpb Date: 2013-10-22 11:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2be08cdd1ced 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE 6445180: URLClassLoader does not describe the behavior of several methods with respect to null arguments Summary: Document when a NPE will be thrown by URLClassLoader constructors, newInstance(), findClass(), and getPermissions(). Reviewed-by: alanb, mduigou, chegar, dholmes, jrose ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/javax/management/remote/rmi/NoCallStackClassLoader.java ! src/share/classes/sun/applet/AppletClassLoader.java + test/java/net/URLClassLoader/NullURLTest.java Changeset: c956a5d0618f Author: juh Date: 2013-10-22 11:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c956a5d0618f 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! test/java/security/cert/PKIXRevocationChecker/UnitTest.java Changeset: 9a32af82bd1e Author: darcy Date: 2013-10-22 12:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9a32af82bd1e 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager} Reviewed-by: chegar, forax, alanb, mduigou ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/ClassValue.java ! src/share/classes/java/lang/SecurityManager.java Changeset: e2b814e68956 Author: rriggs Date: 2013-10-22 15:03 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e2b814e68956 8024686: Cleanup of java.time serialization source Summary: optimize serialized form of OffsetTime, OffsetDateTime; correct order of modifiers Reviewed-by: sherman ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/chrono/ChronoPeriodImpl.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! test/java/time/tck/java/time/serial/TCKOffsetDateTimeSerialization.java ! test/java/time/tck/java/time/serial/TCKOffsetTimeSerialization.java Changeset: d5c2b125ed0f Author: rriggs Date: 2013-10-22 15:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d5c2b125ed0f Merge Changeset: cd60848c87b2 Author: rriggs Date: 2013-10-22 15:11 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cd60848c87b2 Merge Changeset: 4bb758a77fd7 Author: rriggs Date: 2013-10-22 17:02 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4bb758a77fd7 8026982: javadoc errors in core libs Summary: Cleanup of javadoc -Xlint errors Reviewed-by: lancea, mduigou, darcy, mullan, mchung ! src/share/classes/java/io/ByteArrayInputStream.java ! src/share/classes/java/io/ByteArrayOutputStream.java ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/DataOutput.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/InputStream.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/PipedInputStream.java ! src/share/classes/java/io/PipedReader.java ! src/share/classes/java/io/RandomAccessFile.java ! src/share/classes/java/io/Serializable.java ! src/share/classes/java/io/SerializablePermission.java ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/ArrayStoreException.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassCastException.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/RuntimePermission.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/ManagementPermission.java ! src/share/classes/java/lang/management/MemoryUsage.java ! src/share/classes/java/lang/management/package.html ! src/share/classes/java/lang/reflect/ReflectPermission.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/MulticastSocket.java ! src/share/classes/java/net/NetPermission.java ! src/share/classes/java/net/Proxy.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/net/URLPermission.java ! src/share/classes/java/net/package-info.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/rmi/activation/ActivationGroup.java ! src/share/classes/java/rmi/dgc/VMID.java ! src/share/classes/java/rmi/server/UnicastRemoteObject.java ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/security/AlgorithmParameterGenerator.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/Key.java ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/Permission.java ! src/share/classes/java/security/PermissionCollection.java ! src/share/classes/java/security/SecurityPermission.java ! src/share/classes/java/security/Signature.java ! src/share/classes/java/security/SignedObject.java ! src/share/classes/java/security/acl/Acl.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/security/cert/PolicyQualifierInfo.java ! src/share/classes/java/security/cert/TrustAnchor.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/java/security/interfaces/DSAKeyPairGenerator.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/Normalizer.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Deque.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/Properties.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/Queue.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/UUID.java ! src/share/classes/java/util/concurrent/BlockingDeque.java ! src/share/classes/java/util/concurrent/BlockingQueue.java ! src/share/classes/java/util/concurrent/Future.java ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java ! src/share/classes/java/util/jar/Pack200.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/spi/LocaleServiceProvider.java Changeset: e84413f066e0 Author: mfang Date: 2013-10-22 14:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e84413f066e0 8026109: [ja] overtranslation of jarsigner in command line output Reviewed-by: naoto ! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java Changeset: 25ebb8b61371 Author: mfang Date: 2013-10-22 14:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/25ebb8b61371 6607048: clear extra l10n resource files in demo Reviewed-by: naoto, yhuang - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties Changeset: f2ddffb4b165 Author: mfang Date: 2013-10-22 14:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f2ddffb4b165 Merge Changeset: 9fbf35589211 Author: smarks Date: 2013-10-22 14:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9fbf35589211 8026427: deprecate obsolete APIs from java.rmi Reviewed-by: alanb, dfuchs ! src/share/classes/java/rmi/RMISecurityManager.java ! src/share/classes/java/rmi/activation/ActivationGroup.java ! src/share/classes/java/rmi/server/ServerRef.java ! src/share/classes/java/rmi/server/SocketSecurityException.java Changeset: 0913c3bab168 Author: henryjen Date: 2013-10-22 15:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0913c3bab168 8025909: Lambda Library Spec Updates 8024179: Document limitations and performance characteristics of stream sources and operations 8024138: (Spec clarification) Lambda Metafacory spec should state DMH constraint on implMethod Reviewed-by: mduigou Contributed-by: brian.goetz at oracle.com, paul.sandoz at oracle.com ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java ! src/share/classes/java/lang/invoke/SerializedLambda.java ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/Iterator.java ! src/share/classes/java/util/List.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/PrimitiveIterator.java ! src/share/classes/java/util/Spliterator.java ! src/share/classes/java/util/function/package-info.java ! src/share/classes/java/util/stream/BaseStream.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Node.java ! src/share/classes/java/util/stream/SpinedBuffer.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/StreamSupport.java ! src/share/classes/java/util/stream/package-info.java Changeset: fc7a6fa3589a Author: ascarpino Date: 2013-10-22 19:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fc7a6fa3589a 8025763: Provider does not override new Hashtable methods Reviewed-by: mullan ! src/share/classes/java/security/Provider.java Changeset: b065de1700d3 Author: mullan Date: 2013-10-22 19:43 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b065de1700d3 Merge - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties Changeset: d545d67e2f68 Author: weijun Date: 2013-10-23 08:32 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d545d67e2f68 8027026: Change keytool -genkeypair to use -keyalg RSA Reviewed-by: alanb, chegar, mullan ! test/ProblemList.txt ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/jar/JarInputStream/ExtraFileInMetaInf.java ! test/sun/security/pkcs12/PKCS12SameKeyId.java ! test/sun/security/tools/jarsigner/TimestampCheck.java ! test/sun/security/tools/jarsigner/checkusage.sh ! test/sun/security/tools/jarsigner/collator.sh ! test/sun/security/tools/jarsigner/crl.sh ! test/sun/security/tools/jarsigner/jvindex.sh ! test/sun/security/tools/jarsigner/newsize7.sh ! test/sun/security/tools/jarsigner/onlymanifest.sh ! test/sun/security/tools/jarsigner/passtype.sh ! test/sun/security/tools/jarsigner/samename.sh ! test/sun/security/tools/jarsigner/ts.sh ! test/sun/security/tools/keytool/CloseFile.java ! test/sun/security/tools/keytool/ListKeychainStore.sh ! test/sun/security/tools/keytool/StartDateTest.java ! test/sun/security/tools/keytool/UnknownAndUnparseable.java ! test/sun/security/tools/keytool/emptysubject.sh ! test/sun/security/tools/keytool/importreadall.sh ! test/sun/security/tools/keytool/p12importks.sh ! test/sun/security/tools/keytool/readjar.sh ! test/sun/security/tools/keytool/selfissued.sh ! test/sun/security/tools/keytool/trystore.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh Changeset: c077a2810782 Author: egahlin Date: 2013-10-23 10:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c077a2810782 7105883: JDWP: agent crash if there exists a ThreadGroup with null name Reviewed-by: sla, jbachorik ! src/share/back/ThreadGroupReferenceImpl.c + test/com/sun/jdi/NullThreadGroupNameTest.java Changeset: 1b0dfa631b6f Author: michaelm Date: 2013-10-23 11:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1b0dfa631b6f 8025734: Use literal IP address where possible in SocketPermission generated by HttpURLPermission Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/URLPermission/nstest/LookupTest.java + test/java/net/URLPermission/nstest/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/java/net/URLPermission/nstest/SimpleNameService.java + test/java/net/URLPermission/nstest/SimpleNameServiceDescriptor.java + test/java/net/URLPermission/nstest/policy Changeset: f4970c7abe93 Author: jbachorik Date: 2013-10-23 15:03 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f4970c7abe93 7112404: 2 tests in java/lang/management/ManagementFactory fails with G1 because expect non-zero pools Reviewed-by: mchung, sjiang ! test/java/lang/management/ManagementFactory/ProxyTypeMapping.java ! test/java/lang/management/ManagementFactory/ValidateOpenTypes.java Changeset: f120672b91ef Author: chegar Date: 2013-10-23 14:38 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f120672b91ef 8020758: HttpCookie constructor does not throw IAE when name contains a space Reviewed-by: michaelm, msheppar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/TestHttpCookie.java Changeset: 8c20e9ef8709 Author: sla Date: 2013-10-23 15:55 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8c20e9ef8709 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection Reviewed-by: dcubed ! test/ProblemList.txt + test/java/lang/instrument/NMTHelper.java ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java Changeset: 3cdf6ca3ef47 Author: kizune Date: 2013-10-23 18:35 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3cdf6ca3ef47 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking Reviewed-by: alanb, ksrini ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jar/resources/jar.properties + test/tools/jar/normalize/TestNormal.java Changeset: 2af3f5a61322 Author: coffeys Date: 2013-10-23 16:53 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2af3f5a61322 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks + test/com/sun/corba/5036554/JavaBug.java + test/com/sun/corba/5036554/README + test/com/sun/corba/5036554/TestCorbaBug.sh + test/com/sun/corba/5036554/bug.idl Changeset: 88acc99132e2 Author: rfield Date: 2013-10-23 11:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88acc99132e2 8027176: Remove redundant jdk/lambda/vm/DefaultMethodsTest.java Reviewed-by: ksrini - test/jdk/lambda/vm/DefaultMethodsTest.java Changeset: ee7f1c78bec7 Author: coffeys Date: 2013-10-23 20:51 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ee7f1c78bec7 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs Reviewed-by: chegar ! test/javax/xml/ws/clientjar/TestWsImport.java Changeset: f4129fcfacdc Author: mduigou Date: 2013-10-23 14:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f4129fcfacdc 8024688: further split Map and ConcurrentMap defaults eliminating looping from Map defaults, Map.merge fixes and doc fixes. Reviewed-by: psandoz, dholmes ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/concurrent/ConcurrentMap.java ! test/java/util/Map/Defaults.java Changeset: d9d3705a992f Author: rfield Date: 2013-10-23 15:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d9d3705a992f 8025868: Several lang/LMBD JCK tests fail with java.lang.BootstrapMethodError Summary: Wildcard marker interfaces can cause duplicate implemented interfaces in generated lambda class Reviewed-by: briangoetz ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/DupIntf.java Changeset: c9562ac9b812 Author: dxu Date: 2013-10-23 22:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c9562ac9b812 7122887: JDK ignores Gnome3 proxy settings Summary: Fix GConf and add to use GProxyResolver to handle network proxy resolution Reviewed-by: chegar ! src/solaris/native/sun/net/spi/DefaultProxySelector.c ! test/java/net/ProxySelector/SystemProxies.java Changeset: e6bc0dca294b Author: sla Date: 2013-10-15 12:53 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e6bc0dca294b 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads Reviewed-by: sla, allwin Contributed-by: mikael.auno at oracle.com ! test/com/sun/jdi/MethodEntryExitEvents.java ! test/com/sun/jdi/MethodExitReturnValuesTest.java Changeset: 700d62b8d9cc Author: alanb Date: 2013-10-24 13:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/700d62b8d9cc 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable Reviewed-by: rriggs, psandoz, chegar Contributed-by: dl at cs.oswego.edu, alan.bateman at oracle.com ! src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java ! src/share/classes/java/util/concurrent/atomic/DoubleAdder.java ! src/share/classes/java/util/concurrent/atomic/LongAccumulator.java ! src/share/classes/java/util/concurrent/atomic/LongAdder.java + test/java/util/concurrent/atomic/Serial.java Changeset: e2ec05b2ed94 Author: igerasim Date: 2013-10-23 15:37 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e2ec05b2ed94 8024521: (process) Async close issues with Process InputStream Reviewed-by: psandoz, martin, alanb, robm ! src/solaris/classes/java/lang/UNIXProcess.java.bsd ! src/solaris/classes/java/lang/UNIXProcess.java.linux + test/java/lang/Runtime/exec/CloseRace.java Changeset: b8927cbfb893 Author: alundblad Date: 2013-10-24 18:52 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b8927cbfb893 8027170: Annotations declared on super-super-class should be overridden by super-class. Reviewed-by: jfranck Contributed-by: andreas.lundblad at oracle.com, peter.levart at gmail.com ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java + test/java/lang/annotation/repeatingAnnotations/InheritedAssociatedAnnotations.java Changeset: 808b9ef4f667 Author: smarks Date: 2013-10-24 10:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/808b9ef4f667 8023862: deprecate HTTP proxying from RMI Reviewed-by: mchung ! src/share/classes/java/rmi/server/RMISocketFactory.java ! src/share/classes/java/rmi/server/package.html ! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java + test/sun/rmi/transport/proxy/DisableHttpDefaultValue.java Changeset: 5fa2fd782993 Author: briangoetz Date: 2013-10-24 13:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5fa2fd782993 8019646: Clarify javadoc contract of LambdaMetafactory Reviewed-by: briangoetz, rfield Contributed-by: dan.smith at oracle.com ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java Changeset: 93e696ba5923 Author: jfranck Date: 2013-10-24 19:04 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/93e696ba5923 8023651: j.l.r.Constructor.getAnnotatedReceiverType() and j.l.r.Constructor.getAnnotatedReturnType() for inner classes return incorrect result Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/annotation/typeAnnotations/ConstructorReceiverTest.java Changeset: 66884b270b44 Author: twisti Date: 2013-10-24 10:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/66884b270b44 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms Reviewed-by: iveresov, jrose ! src/share/classes/java/lang/invoke/MethodHandles.java Changeset: e7bdb2fcc7bc Author: sherman Date: 2013-10-24 11:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e7bdb2fcc7bc 8025003: Base64 should be less strict with padding Summary: updated spec and implementation of mime decoder to be lenient for padding Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/Base64GetEncoderTest.java ! test/java/util/Base64/TestBase64.java ! test/java/util/Base64/TestBase64Golden.java Changeset: 05dbf105e70f Author: joehw Date: 2013-10-24 14:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/05dbf105e70f 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb + test/javax/xml/jaxp/transform/jdk8004476/SecureProcessingTest.xml + test/javax/xml/jaxp/transform/jdk8004476/TestBase.java + test/javax/xml/jaxp/transform/jdk8004476/XPathExFuncTest.java + test/javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java + test/javax/xml/jaxp/transform/jdk8004476/tokenize.xml + test/javax/xml/jaxp/transform/jdk8004476/tokenize.xsl Changeset: e9ec0ca5bab1 Author: weijun Date: 2013-10-25 08:38 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e9ec0ca5bab1 8026929: remove accelerators from policytool resources Reviewed-by: alexp, weijun Contributed-by: Leif Samuelsson ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/tools/policytool/Resources.java Changeset: d126301ad372 Author: ewang Date: 2013-10-25 11:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d126301ad372 7079145: Remove java/net/ipv6tests/UdpTest.java from the ProblemList.txt Reviewed-by: alanb, chegar ! test/ProblemList.txt Changeset: 1153022c0a45 Author: jbachorik Date: 2013-10-25 13:01 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1153022c0a45 8004926: sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out Summary: Improve reliability by converting the test to Java Reviewed-by: dsamersoff, dholmes ! test/TEST.groups ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/lib/testlibrary/jdk/testlibrary/StreamPumper.java + test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh + test/sun/management/jmxremote/bootstrap/LocalManagementTest.java - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh ! test/sun/management/jmxremote/bootstrap/TestApplication.java ! test/sun/management/jmxremote/bootstrap/TestManager.java + test/sun/management/jmxremote/bootstrap/linux-amd64/launcher Changeset: 8ea272253285 Author: smarks Date: 2013-10-25 14:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8ea272253285 5063500: Formatter spec says "char" is not an integral type 7126305: Wrong Unicode value specified for format conversion character 'd' 8027287: incorrect example in Formatter javadoc Reviewed-by: rriggs, darcy, lancea ! src/share/classes/java/util/Formatter.java Changeset: af4dd45bc7f7 Author: dfuchs Date: 2013-10-28 10:52 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/af4dd45bc7f7 8026863: regression in anonymous Logger.setParent method Summary: restore behaviour of setParent in anonymous logger and clarifies the spec with respect to security permissions. Reviewed-by: mchung, prr ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/AnonymousLogger/TestAnonymousLogger.java Changeset: e7639b856256 Author: lana Date: 2013-10-28 12:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e7639b856256 Merge Changeset: ecba02f6be31 Author: sla Date: 2013-10-29 08:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ecba02f6be31 8027371: Add JDI tests for breakpointing and stepping in lambda code Reviewed-by: mchung, sspitsyn + test/com/sun/jdi/LambdaBreakpointTest.java + test/com/sun/jdi/LambdaStepTest.java Changeset: d34c5e860d5f Author: aefimov Date: 2013-10-24 17:23 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d34c5e860d5f 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing Reviewed-by: okutsu, mfang, alanb ! test/ProblemList.txt ! test/sun/util/resources/TimeZone/Bug6317929.java Changeset: a8bbd962f34a Author: jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a8bbd962f34a 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README ! make/launchers/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! test/tools/launcher/VersionCheck.java Changeset: 41654275896d Author: jlaskey Date: 2013-02-04 17:29 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/41654275896d Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java ! test/tools/launcher/VersionCheck.java Changeset: a174944b0c00 Author: jlaskey Date: 2013-02-21 15:25 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a174944b0c00 8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey at oracle.com ! make/launchers/Makefile Changeset: 25db7658a063 Author: jlaskey Date: 2013-02-22 10:23 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/25db7658a063 8008721: Tweaks to make all NEWBUILD=false round 4 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! make/launchers/Makefile Changeset: ea22045ce09b Author: jlaskey Date: 2013-02-22 14:05 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ea22045ce09b Merge ! makefiles/CreateJars.gmk Changeset: ff68fafd6302 Author: jlaskey Date: 2013-02-22 17:45 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ff68fafd6302 8008756: THIRD_PARTY_README contains Unicode Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README Changeset: ce82a0ee7735 Author: jlaskey Date: 2013-02-22 18:03 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ce82a0ee7735 8008757: NEWBUILD=true has separate launcher code for jjs Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! makefiles/CompileLaunchers.gmk Changeset: 20a827b22a2e Author: jlaskey Date: 2013-02-22 23:36 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/20a827b22a2e 8008775: Remove non-ascii from jdk/THIRD_PARTY_README Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README Changeset: 364e0871f7a3 Author: jlaskey Date: 2013-03-02 11:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/364e0871f7a3 Merge ! make/launchers/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk - src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java - test/javax/script/RhinoExceptionTest.java ! test/tools/launcher/VersionCheck.java Changeset: 3565c755c49f Author: jlaskey Date: 2013-03-15 11:51 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3565c755c49f Merge ! makefiles/CreateJars.gmk Changeset: 8c223a4f906a Author: jlaskey Date: 2013-03-26 09:12 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8c223a4f906a Merge ! makefiles/CreateJars.gmk Changeset: efbbcd5848cf Author: jlaskey Date: 2013-04-01 10:09 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/efbbcd5848cf Merge Changeset: 39ce82dad57d Author: jlaskey Date: 2013-04-09 08:36 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/39ce82dad57d Merge Changeset: ff9683b6854c Author: jlaskey Date: 2013-04-15 08:27 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ff9683b6854c Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk Changeset: 1cdf20da340b Author: jlaskey Date: 2013-04-17 08:47 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1cdf20da340b Merge Changeset: 72fa581a83a4 Author: jlaskey Date: 2013-04-22 14:00 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/72fa581a83a4 Merge Changeset: ead9944bbb3b Author: jlaskey Date: 2013-04-29 21:37 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ead9944bbb3b Merge Changeset: 5bde43b1e463 Author: jlaskey Date: 2013-05-14 09:04 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5bde43b1e463 Merge Changeset: efd620f8963f Author: jlaskey Date: 2013-05-23 09:48 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/efd620f8963f Merge ! makefiles/CreateJars.gmk Changeset: 193652dff077 Author: jlaskey Date: 2013-05-29 13:22 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/193652dff077 Merge Changeset: 733713d7517c Author: jlaskey Date: 2013-06-05 13:10 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/733713d7517c Merge ! makefiles/CompileLaunchers.gmk Changeset: 3b464e13a776 Author: jlaskey Date: 2013-07-16 09:09 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3b464e13a776 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! test/tools/launcher/VersionCheck.java Changeset: c0a2094aaafd Author: jlaskey Date: 2013-07-24 08:22 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c0a2094aaafd Merge - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html Changeset: 528fc8f4281b Author: jlaskey Date: 2013-08-27 16:06 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/528fc8f4281b Merge ! makefiles/CompileLaunchers.gmk Changeset: be6ca7197e0e Author: jlaskey Date: 2013-09-13 10:15 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/be6ca7197e0e Merge ! makefiles/CreateJars.gmk - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java - test/java/util/Map/CheckRandomHashSeed.java - test/java/util/Map/TreeBinSplitBackToEntries.java - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh Changeset: 74b1eb493407 Author: jlaskey Date: 2013-09-30 10:24 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/74b1eb493407 Merge ! makefiles/CreateJars.gmk Changeset: f5c9333b6129 Author: jlaskey Date: 2013-10-29 10:40 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f5c9333b6129 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! test/tools/launcher/VersionCheck.java Changeset: 121c34517841 Author: chegar Date: 2013-10-29 17:21 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/121c34517841 8027466: Revert jdk/THIRD_PARTY_README to known good version Reviewed-by: alanb ! THIRD_PARTY_README Changeset: 6fc2889fe7d0 Author: mfang Date: 2013-10-29 11:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6fc2889fe7d0 8026108: [it, ja, zh_CN] wrong translation in jar example. Reviewed-by: okutsu, yhuang ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties Changeset: 0cc9bdb22911 Author: mfang Date: 2013-10-29 11:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0cc9bdb22911 8008437: [sv] over-translation in java command line outputs Reviewed-by: okutsu, yhuang ! src/share/classes/sun/tools/jar/resources/jar_sv.properties Changeset: 331d8ced56dc Author: mfang Date: 2013-10-29 11:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/331d8ced56dc 8025646: [pt_BR] overtranslation of option in java command line output Reviewed-by: naoto, yhuang ! src/share/classes/sun/launcher/resources/launcher_pt_BR.properties Changeset: a3ac9c0b19a9 Author: jbachorik Date: 2013-10-29 21:49 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a3ac9c0b19a9 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926 Reviewed-by: alanb, egahlin ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.java Changeset: 8cfc73ad9f31 Author: mfang Date: 2013-10-29 15:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8cfc73ad9f31 8008647: [es] minor cosmetic issues in translated java command line outputs Reviewed-by: naoto ! src/share/classes/sun/tools/jar/resources/jar_es.properties Changeset: 4071c853edff Author: mfang Date: 2013-10-29 15:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4071c853edff Merge Changeset: bede752d1e3c Author: mfang Date: 2013-10-29 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bede752d1e3c 8025521: [de] mnemonic conflict in FileChooser for GTK Style feel&look Reviewed-by: naoto ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties Changeset: 5d1bda6c1fe3 Author: jbachorik Date: 2013-10-30 14:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5d1bda6c1fe3 8027058: sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh Failed to initialize connector Summary: Dynamically discover the first available port instead of hard-coding one Reviewed-by: sla, chegar, dfuchs ! test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java Changeset: 9a5048dc7c0d Author: chegar Date: 2013-10-30 14:41 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9a5048dc7c0d 8026880: NetworkInterface native initializing code should check fieldID values Reviewed-by: alanb ! src/solaris/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface.c Changeset: b04b124418d8 Author: ykantser Date: 2013-10-30 13:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b04b124418d8 8022229: Intermittent test failures in sun/tools/jstatd Reviewed-by: sla, egahlin, jbachorik, allwin + test/lib/testlibrary/jdk/testlibrary/Asserts.java + test/lib/testlibrary/jdk/testlibrary/JDKToolFinder.java + test/lib/testlibrary/jdk/testlibrary/JDKToolLauncher.java + test/lib/testlibrary/jdk/testlibrary/Platform.java + test/lib/testlibrary/jdk/testlibrary/ProcessThread.java + test/lib/testlibrary/jdk/testlibrary/TestThread.java + test/lib/testlibrary/jdk/testlibrary/Utils.java + test/lib/testlibrary/jdk/testlibrary/XRun.java + test/sun/tools/jstatd/JstatGCUtilParser.java + test/sun/tools/jstatd/JstatdTest.java + test/sun/tools/jstatd/TestJstatdDefaults.java + test/sun/tools/jstatd/TestJstatdExternalRegistry.java + test/sun/tools/jstatd/TestJstatdPort.java + test/sun/tools/jstatd/TestJstatdPortAndServer.java + test/sun/tools/jstatd/TestJstatdServer.java + test/sun/tools/jstatd/TestJstatdUsage.java - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: 550244957351 Author: mfang Date: 2013-10-30 09:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/550244957351 6192407: s10_70, ko, s1/dvd, minor misspelling under "Select Software Localizations" Reviewed-by: yhuang ! src/share/classes/sun/util/resources/ko/LocaleNames_ko.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: e45b48874ba9 Author: mfang Date: 2013-10-30 09:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e45b48874ba9 6931564: Incorrect display name of Locale for south africa Reviewed-by: yhuang ! src/share/classes/sun/util/resources/sv/LocaleNames_sv.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 2a714dabb624 Author: jbachorik Date: 2013-10-30 17:54 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2a714dabb624 8020467: Inconsistency between usage.getUsed() and isUsageThresholdExceeded() with CMS Old Gen pool Reviewed-by: mchung, brutisso ! test/java/lang/management/MemoryPoolMXBean/ThresholdTest.java Changeset: 7bc67bed3c14 Author: michaelm Date: 2013-10-30 18:37 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7bc67bed3c14 8027570: NullPointerException in URLPermission.hashCode() Reviewed-by: chegar ! src/share/classes/java/net/URLPermission.java ! test/java/net/URLPermission/URLPermissionTest.java Changeset: 281e26d7f325 Author: michaelm Date: 2013-10-30 18:38 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/281e26d7f325 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/java/lang/invoke/MagicLambdaImpl.java ! src/share/classes/java/net/URLPermission.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: 348ffbd19feb Author: lana Date: 2013-10-30 13:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/348ffbd19feb Merge ! makefiles/CreateJars.gmk + makefiles/CreateSecurityJars.gmk Changeset: ddb0b681654a Author: briangoetz Date: 2013-10-29 12:31 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ddb0b681654a 8027318: Lambda Metafactory: generate serialization-hostile read/writeObject methods for non-serializable lambdas Reviewed-by: rfield, psandoz ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java Changeset: f731d096530f Author: wetmore Date: 2013-10-30 16:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f731d096530f 8027526: CheckTipsAndVersions.java failing occasionally Reviewed-by: mullan, mchung ! test/java/security/Signature/SignatureGetAlgorithm.java Changeset: e8894e3224d9 Author: darcy Date: 2013-10-30 17:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e8894e3224d9 8005294: Consider default methods for additions to AnnotatedElement Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel ! src/share/classes/java/lang/reflect/AnnotatedElement.java + test/java/lang/reflect/AnnotatedElement/TestAnnotatedElementDefaults.java Changeset: 0734e1584d9d Author: bpb Date: 2013-10-30 17:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0734e1584d9d 6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers 8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infinity 8021204: Constructor BigInteger(String val, int radix) doesn't detect overflow 8022780: Incorrect BigInteger division because of MutableBigInteger.bitLength() overflow Summary: Prevent construction of overflowed BigIntegers. Reviewed-by: bpb, darcy, psandoz Contributed-by: Dmitry Nadezhin ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/MutableBigInteger.java + test/java/math/BigInteger/BitLengthOverflow.java + test/java/math/BigInteger/DivisionOverflow.java + test/java/math/BigInteger/DoubleValueOverflow.java ! test/java/math/BigInteger/ExtremeShiftingTests.java + test/java/math/BigInteger/StringConstructorOverflow.java + test/java/math/BigInteger/SymmetricRangeTests.java Changeset: 1ea1b24c1a04 Author: smarks Date: 2013-10-30 18:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ea1b24c1a04 8023863: deprecate support for statically-generated stubs from RMI (JRMP) 4449028: exportObject() javadoc should specify behavior for null socket factories Reviewed-by: dfuchs, darcy ! src/share/classes/java/rmi/server/RemoteStub.java ! src/share/classes/java/rmi/server/UnicastRemoteObject.java ! src/share/classes/java/rmi/server/package.html Changeset: 18c111c17231 Author: psandoz Date: 2013-10-31 11:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/18c111c17231 8027316: Distinct operation on an unordered stream should not be a barrier Reviewed-by: henryjen, mduigou, briangoetz ! src/share/classes/java/util/stream/DistinctOps.java ! src/share/classes/java/util/stream/StreamSpliterators.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java Changeset: bb4b1e1e390d Author: jbachorik Date: 2013-10-31 11:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bb4b1e1e390d 7144200: java/lang/management/ClassLoadingMXBean/LoadCounts.java failed with JFR enabled Summary: Make the test less stringent by not requiring the number of loaded classes to increase by a specific number Reviewed-by: sla ! test/ProblemList.txt ! test/java/lang/management/ClassLoadingMXBean/LoadCounts.java Changeset: 82ee370c3d7e Author: briangoetz Date: 2013-10-31 10:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/82ee370c3d7e 8024637: Lambda linkage performance - use reflection instead of ASM to manipulate parameter types 8023984: Lambda linkage performance - use a method ref to a static factory instead of a ctor ref Reviewed-by: briangoetz, rfield Contributed-by: sergey.kuksenko at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java Changeset: 9732816c9d17 Author: briangoetz Date: 2013-10-29 12:45 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9732816c9d17 8024633: Lambda linkage performance - initialize generated class earlier Reviewed-by: briangoetz, rfield Contributed-by: sergey.kuksenko at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java Changeset: e93de88661ab Author: dxu Date: 2013-10-31 11:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e93de88661ab 8027155: test/java/io/File/NulFile.java failing when test run in othervm mode Reviewed-by: mchung, alanb ! test/java/io/File/NulFile.java Changeset: c4bbd5963f9c Author: joehw Date: 2013-10-31 13:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c4bbd5963f9c 8024876: [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions Reviewed-by: chegar ! test/javax/xml/jaxp/parsers/8022548/XOMParserTest.java Changeset: f82b730c798b Author: lana Date: 2013-10-31 16:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f82b730c798b Merge - src/share/classes/java/lang/invoke/MagicLambdaImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/tools/jar/Main.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties ! src/share/javavm/export/jvm.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/solaris/classes/sun/nio/fs/UnixPath.java - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: a389b4f5723f Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a389b4f5723f Added tag jdk8-b115 for changeset f82b730c798b ! .hgtags From john.coomes at oracle.com Thu Nov 7 16:09:44 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Nov 2013 00:09:44 +0000 Subject: hg: hsx/hotspot-rt/langtools: 32 new changesets Message-ID: <20131108001124.615AF62450@hg.openjdk.java.net> Changeset: 7af634b1fc5b Author: darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java Changeset: 7de97abc4a5c Author: jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/lambda/LocalVariableTable.java Changeset: 130b8c0e570e Author: bpatel Date: 2013-10-18 16:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/130b8c0e570e 8026567: Use meaningful style names for strong and italic styles. Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/testAnnotationTypes/TestAnnotationTypes.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testClassTree/TestClassTree.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testLegacyTaglet/Check.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackageDeprecation/TestPackageDeprecation.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java ! test/com/sun/javadoc/testProfiles/TestProfilesConfiguration.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java ! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testTagOutput/TestTagOutput.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java ! test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java Changeset: c4292590fc70 Author: vromero Date: 2013-10-19 17:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c4292590fc70 8024809: javac, some lambda programs are rejected by flow analysis Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! test/tools/javac/lambda/8016081/T8016081.java ! test/tools/javac/lambda/LambdaExpr13.java + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTesta.java + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTesta.out + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTestb.java + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTestb.out ! test/tools/javac/lambda/TestSelfRef.java Changeset: e5d3cd43c85e Author: jjg Date: 2013-10-20 12:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e5d3cd43c85e 8025109: Better encapsulation for AnnotatedType Reviewed-by: jjg Contributed-by: wdietl at gmail.com ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java Changeset: ae4f5cb78ebd Author: jjg Date: 2013-10-20 12:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ae4f5cb78ebd 8026791: wrong type_path encoded for method_return on an inner class constructor Reviewed-by: jjg Contributed-by: wdietl at gmail.com ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java Changeset: 399c738e5103 Author: ksrini Date: 2013-10-20 12:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/399c738e5103 8026931: MethodParameters tests failing on Windows Reviewed-by: jjg, vromero ! test/tools/javac/MethodParameters/Tester.java Changeset: 9f876bd43f55 Author: vromero Date: 2013-10-21 15:55 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/9f876bd43f55 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change Reviewed-by: jfranck ! test/tools/javac/lambda/TargetType58.java Changeset: b82982ac3ca2 Author: darcy Date: 2013-10-21 15:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b82982ac3ca2 8026984: Clarity intended use of jdk.Exported Reviewed-by: psandoz, mr, alanb ! src/share/classes/jdk/Exported.java Changeset: ac839d6f4953 Author: jfranck Date: 2013-10-22 03:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ac839d6f4953 8026855: AnnoConstruct.getAnnotationsByType includes inherited indirectly present annotations even when containee type is not inheritable Summary: In AnnoConstruct.getAnnotationByType() check that the annotation sought after is inherited before looking on supertypes. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/AnnoConstruct.java + test/tools/javac/processing/model/element/TestNonInherited.java Changeset: 87c950ea88be Author: ksrini Date: 2013-10-21 20:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/87c950ea88be 8026758: Inefficient code in LambdaToMethod Reviewed-by: jjg, jlahoda, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java Changeset: f003f09144ff Author: jfranck Date: 2013-10-22 10:08 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f003f09144ff 8026857: AnnoConstruct.getAnnotationsByType does not search supertype for inherited annotations if @SomeContainer({}) is present Summary: An empty container should not stop javac from looking at supertypes for inherited repeating annotations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/AnnoConstruct.java + test/tools/javac/processing/model/element/TestEmptyContainer.java Changeset: 963c57175e40 Author: vromero Date: 2013-10-22 13:54 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/963c57175e40 8025290: javac implicit versus explicit lambda compilation error Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java + test/tools/javac/lambda/T8025290/ExplicitVSImplicitLambdaTest.java Changeset: 6cd16d8ed2b9 Author: rfield Date: 2013-10-22 16:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6cd16d8ed2b9 8023668: Desugar serializable lambda bodies using more robust naming scheme Summary: lambda / bridged method-reference naming overhaul Reviewed-by: ksrini, briangoetz ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! test/tools/javac/MethodParameters/LambdaTest.out ! test/tools/javac/T8019486/WrongLVTForLambdaTest.java + test/tools/javac/lambda/lambdaNaming/TestSerializedLambdaNameStability.java + test/tools/javac/lambda/lambdaNaming/after/TESTNameOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/after/TESTOrderOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/after/TESTTargetName.java + test/tools/javac/lambda/lambdaNaming/after/TESTTargetType.java + test/tools/javac/lambda/lambdaNaming/after/TESTTypesOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/after/TESTVariableAssignmentTarget.java + test/tools/javac/lambda/lambdaNaming/before/TESTNameOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/before/TESTOrderOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/before/TESTTargetName.java + test/tools/javac/lambda/lambdaNaming/before/TESTTargetType.java + test/tools/javac/lambda/lambdaNaming/before/TESTTypesOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/before/TESTVariableAssignmentTarget.java Changeset: 351d6808c1a5 Author: jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author: jjg Date: 2013-10-22 17:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/41d3ffca22ff Merge Changeset: b05db8c815e8 Author: jlahoda Date: 2013-10-23 07:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b05db8c815e8 8026508: Invokedynamic instructions don't get line number table entries Summary: Setting or correcting positions for many trees produced by LambdaToMethod. Reviewed-by: vromero, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/T8019486/WrongLNTForLambdaTest.java - test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: 32ea6ccb7607 Author: rfield Date: 2013-10-23 10:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/32ea6ccb7607 8022720: Method refeerences - private method should be accessible (nested classes) Reviewed-by: jjg, ksrini ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/privateMethodReferences/MethodInvoker.java + test/tools/javac/lambda/privateMethodReferences/MethodSupplier.java + test/tools/javac/lambda/privateMethodReferences/ThirdClass.java Changeset: 8746caa5cf80 Author: bpatel Date: 2013-10-23 13:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8746caa5cf80 8026770: javadoc creates invalid HTML in profile summary pages Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java Changeset: abc3eaccba73 Author: jlahoda Date: 2013-10-23 23:02 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/abc3eaccba73 8027191: Fix for JDK-8026861 refers to an incorrect bug number Summary: Reverting changeset b05db8c815e8, so that it can be applied again with a correct bug number Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java - test/tools/javac/T8019486/WrongLNTForLambdaTest.java + test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: 864dafc5ab7a Author: jlahoda Date: 2013-10-23 07:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/864dafc5ab7a 8026861: Wrong LineNumberTable for variable declarations in lambdas Summary: Setting or correcting positions for many trees produced by LambdaToMethod. Reviewed-by: vromero, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/T8019486/WrongLNTForLambdaTest.java - test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: 31fe30e2deac Author: ksrini Date: 2013-10-23 15:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/31fe30e2deac 8026936: Initialize LamdbaToMethod lazily and as required Reviewed-by: jjg, rfield Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: d2fa3f7e964e Author: emc Date: 2013-10-23 23:20 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d2fa3f7e964e 8006732: support correct bytecode storage of type annotations in multicatch Summary: Fix issue with annotations being added before attribution, which causes multicatch not to work right and several tests to fail. Reviewed-by: jfranck, jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.out ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java Changeset: 119747cd9f25 Author: emc Date: 2013-10-24 01:27 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/119747cd9f25 8023682: Incorrect attributes emitted for anonymous class declaration Summary: Cause javac to emit type annotations on new instruction as well as anonymous class supertype for annotated anonymous classes. Reviewed-by: jjg, jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/typeAnnotations/failures/TypeOnAnonClass.java + test/tools/javac/annotations/typeAnnotations/failures/TypeOnAnonClass.out ! test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.out ! test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java Changeset: 667843bd2193 Author: bpatel Date: 2013-10-24 11:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/667843bd2193 8006248: Since addition of -Xdoclint, javadoc ignores unknown tags Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Env.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java + test/com/sun/javadoc/testCustomTag/TagTestClass.java + test/com/sun/javadoc/testCustomTag/TestCustomTag.java + test/com/sun/javadoc/testCustomTag/taglets/CustomTag.java + test/tools/doclint/CustomTagTest.java + test/tools/doclint/CustomTagTest.out + test/tools/doclint/CustomTagTestWithOption.out ! test/tools/doclint/DocLintTester.java Changeset: 860f1d21763a Author: rfield Date: 2013-10-24 16:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/860f1d21763a 8027220: DefaultMethodsTest: Change test to match spec Reviewed-by: ksrini ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java Changeset: 44e3ba40e00c Author: lana Date: 2013-10-28 12:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/44e3ba40e00c Merge Changeset: aa91bc6e8480 Author: mchung Date: 2013-10-30 08:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/aa91bc6e8480 8027481: jdeps to handle classes with the same package name and correct profile for javax.crypto.* Reviewed-by: alanb, dfuchs ! src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/classes/com/sun/tools/jdeps/Archive.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/Profile.java ! test/tools/jdeps/Basic.java ! test/tools/jdeps/Test.java + test/tools/jdeps/javax/activity/NotCompactProfile.java + test/tools/jdeps/p/Bar.java Changeset: 537fa895fd74 Author: vromero Date: 2013-10-30 18:09 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/537fa895fd74 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo Reviewed-by: ksrini ! test/tools/javac/ExtDirs/ExtDirTest.java - test/tools/javac/ExtDirs/ext1/pkg1.jar - test/tools/javac/ExtDirs/ext2/pkg2.jar - test/tools/javac/ExtDirs/ext3/pkg1.jar - test/tools/javac/ExtDirs/ext3/pkg2.jar Changeset: 62a67e0875ff Author: briangoetz Date: 2013-10-30 14:12 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/62a67e0875ff 8024930: Re-enable disabled bridging tests Reviewed-by: psandoz, rfield ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java Changeset: 6b4d6205366c Author: lana Date: 2013-10-31 16:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6b4d6205366c Merge - test/tools/javac/ExtDirs/ext1/pkg1.jar - test/tools/javac/ExtDirs/ext2/pkg2.jar - test/tools/javac/ExtDirs/ext3/pkg1.jar - test/tools/javac/ExtDirs/ext3/pkg2.jar - test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: 3c040b04af05 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3c040b04af05 Added tag jdk8-b115 for changeset 6b4d6205366c ! .hgtags From john.coomes at oracle.com Thu Nov 7 16:11:32 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 08 Nov 2013 00:11:32 +0000 Subject: hg: hsx/hotspot-rt/nashorn: 29 new changesets Message-ID: <20131108001201.89D5E62451@hg.openjdk.java.net> Changeset: b01a10c7c7c2 Author: attila Date: 2013-10-17 12:38 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b01a10c7c7c2 8026161: Don't narrow floating-point literals in the lexer Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/runtime/JSType.java + test/script/basic/JDK-8026161.js + test/script/basic/JDK-8026161.js.EXPECTED ! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java Changeset: a2065f67857c Author: hannesw Date: 2013-10-17 17:33 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a2065f67857c 8026701: Array.prototype.splice is slow on dense arrays Reviewed-by: lagergren, sundar, jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java ! test/examples/array-micro.js + test/script/basic/JDK-8026701.js + test/script/basic/JDK-8026701.js.EXPECTED Changeset: 66d27c77b455 Author: hannesw Date: 2013-10-18 12:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/66d27c77b455 8026805: Array.prototype.length doesn't work as expected Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java + test/script/basic/JDK-8026805.js Changeset: b5b4c98b072b Author: sundar Date: 2013-10-18 18:26 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b5b4c98b072b Merge Changeset: d8aa87d292eb Author: hannesw Date: 2013-10-18 22:42 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d8aa87d292eb 8026858: Array length does not handle defined properties correctly Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8026858.js Changeset: 612886fe324d Author: sundar Date: 2013-10-21 10:09 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/612886fe324d Merge Changeset: f22742d5daa3 Author: kshefov Date: 2013-10-21 13:31 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f22742d5daa3 8026871: NASHORN TEST: Enable possibility to test Nashorn use of JavaFX canvas. Reviewed-by: jlaskey, sundar ! make/build.xml ! make/project.properties + test/script/jfx.js + test/script/jfx/flyingimage.js + test/script/jfx/flyingimage/flyingimage.png + test/script/jfx/flyingimage/golden/linux.png + test/script/jfx/flyingimage/golden/macosx.png + test/script/jfx/flyingimage/golden/windows.png + test/script/jfx/kaleidoscope.js + test/script/jfx/kaleidoscope/golden/linux.png + test/script/jfx/kaleidoscope/golden/macosx.png + test/script/jfx/kaleidoscope/golden/windows.png Changeset: d8d5b7919c57 Author: sundar Date: 2013-10-22 14:27 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d8d5b7919c57 8027016: Array.prototype.indexOf should return -1 when array is of length zero Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8027016.js Changeset: 6d339d98074e Author: hannesw Date: 2013-10-22 11:12 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6d339d98074e 8027015: AutoCloseable no longer implements @FunctionalInterface Reviewed-by: lagergren, sundar ! test/script/basic/NASHORN-397.js Changeset: d24a4fabdce1 Author: hannesw Date: 2013-10-22 11:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d24a4fabdce1 8026955: for-in should convert primitive values to object Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8026955.js + test/script/basic/JDK-8026955.js.EXPECTED Changeset: 360761288b38 Author: sundar Date: 2013-10-22 17:38 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/360761288b38 8027024: String.prototype.charAt and charCodeAt do not evaluate 'self' and 'pos' arguments in right order Reviewed-by: jlaskey, attila, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java ! src/overview.html + test/script/basic/JDK-8027024.js + test/script/basic/JDK-8027024.js.EXPECTED Changeset: d04028e6b624 Author: sundar Date: 2013-10-22 17:47 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d04028e6b624 Merge Changeset: 0ecbc0188b64 Author: attila Date: 2013-10-22 16:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/0ecbc0188b64 8027031: complete merging of loads and converts Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java Changeset: 6f19eb443a47 Author: attila Date: 2013-10-22 17:52 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/6f19eb443a47 8027037: Make ScriptObjectMirror conversions work for any JSObject Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java Changeset: eae4e4c1f613 Author: sundar Date: 2013-10-22 22:04 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/eae4e4c1f613 8027020: [regression] java.lang.VerifyError: Bad type on operand stack Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/ScriptLoader.java Changeset: 734f71f8a2c3 Author: sundar Date: 2013-10-22 22:12 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/734f71f8a2c3 Merge Changeset: 5df55690fd5b Author: sundar Date: 2013-10-23 17:30 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5df55690fd5b 8027128: jdk.nashorn.api.scripting.JSObject should be an interface Reviewed-by: hannesw, attila, jlaskey + src/jdk/nashorn/api/scripting/AbstractJSObject.java ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java ! test/script/basic/JDK-8024847.js ! test/script/basic/JDK-8024847.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/PluggableJSObjectTest.java ! test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java Changeset: f31ee3a2847d Author: sundar Date: 2013-10-23 20:15 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f31ee3a2847d 8027150: ScriptObjectListAdapter won't work as expected Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/ListAdapter.java - src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java Changeset: 640c1854f742 Author: sundar Date: 2013-10-23 20:21 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/640c1854f742 Merge - src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java Changeset: 767e85d2a1b3 Author: lana Date: 2013-10-28 12:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/767e85d2a1b3 Merge Changeset: 7985ec3782b5 Author: hannesw Date: 2013-10-25 10:20 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/7985ec3782b5 8027042: Evaluation order for binary operators can be improved Reviewed-by: lagergren, jlaskey, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Expression.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java + test/script/basic/JDK-8027042.js + test/script/basic/JDK-8027042.js.EXPECTED Changeset: 71cfb21c68dc Author: hannesw Date: 2013-10-25 15:21 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/71cfb21c68dc 8027301: Optimizations for Function.prototype.apply Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java Changeset: 406f2b672937 Author: jlaskey Date: 2013-10-29 10:40 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/406f2b672937 Merge Changeset: adab2c628923 Author: jlaskey Date: 2013-10-29 14:22 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/adab2c628923 8027447: The wrong string buffer is specified for stderr in $EXEC Reviewed-by: lagergren, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java Changeset: 645197151cc3 Author: jlaskey Date: 2013-10-30 11:28 -0300 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/645197151cc3 8027532: nashorn should only use jdk8 apis in the compact1 profile Reviewed-by: sundar, lagergren, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/ir/debug/ObjectSizeCalculator.java Changeset: a002c1bb88f9 Author: sundar Date: 2013-10-30 20:09 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/a002c1bb88f9 8027562: eval should load second and subsequent arguments for side effect Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8027562.js + test/script/basic/JDK-8027562.js.EXPECTED Changeset: 5ce78473d6c3 Author: sundar Date: 2013-10-31 12:50 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/5ce78473d6c3 Merge Changeset: f0d3ac2474ee Author: lana Date: 2013-10-31 16:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/f0d3ac2474ee Merge - src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java Changeset: 0fb1a427fbf6 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/0fb1a427fbf6 Added tag jdk8-b115 for changeset f0d3ac2474ee ! .hgtags From david.holmes at oracle.com Thu Nov 7 16:30:02 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 08 Nov 2013 10:30:02 +1000 Subject: RFR 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c In-Reply-To: <527BA658.3060907@oracle.com> References: <527BA658.3060907@oracle.com> Message-ID: <527C308A.1060504@oracle.com> Seems reasonable to me. David On 8/11/2013 12:40 AM, Jaroslav Bachorik wrote: > Please, review this simple fix in the demo code. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8007984 > Webrev: http://cr.openjdk.java.net/~jbachorik/8007984/webrev.00 > > In an unlikely case of providing fatal_error_handler that does not > terminate the application when a fatal error is reported. The patch > calls abort() regardless of whether the fatal_error_handler was invoked > or not. > > Thanks, > > -JB- From david.holmes at oracle.com Thu Nov 7 16:55:25 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 08 Nov 2013 10:55:25 +1000 Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently In-Reply-To: <527B9D49.5010908@oracle.com> References: <527B9D49.5010908@oracle.com> Message-ID: <527C367D.3040401@oracle.com> On 8/11/2013 12:01 AM, Jaroslav Bachorik wrote: > Please, review this test fix. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 > Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 > > The failure was caused by the IOHandler not waiting for the actual > message stating the the debugee was ready. So the base problem was that the initial in.read(b, 0, 100) might not actually read the message that the debuggee was ready? The cleanup seems good to me in general. Only concern I have is that where the IOHandler would print what was read (which might not be what was expected), in the new code if we don't see what we expect we just set a boolean to false and the actual output from the debugee is never shown - or is the debuggee output captured elsewhere? Thanks, David The patch uses the library > functions to start the debugee and wait for the actual message to > appear. Also, it detects problems while starting the debugee and reports > them instead of failing only when the debugger can not connect. > > Thanks, > > -JB- From roger.riggs at oracle.com Thu Nov 7 17:58:40 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 08 Nov 2013 01:58:40 +0000 Subject: hg: jdk8/tl/jdk: 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Message-ID: <20131108015854.EDA3B62455@hg.openjdk.java.net> Changeset: 04f071a95c29 Author: rriggs Date: 2013-11-07 20:56 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04f071a95c29 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Summary: fix the typo Reviewed-by: lancea, chegar, dxu ! src/share/classes/java/io/DataInput.java From joe.darcy at oracle.com Thu Nov 7 20:12:08 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 08 Nov 2013 04:12:08 +0000 Subject: hg: jdk8/tl/langtools: 8027730: Fix release-8 type visitors to support intersection types Message-ID: <20131108041211.CF47C62459@hg.openjdk.java.net> Changeset: e39bd9401ea5 Author: darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java + test/tools/javac/processing/model/util/TestIntersectionTypeVisitors.java From mandy.chung at oracle.com Thu Nov 7 20:48:59 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 04:48:59 +0000 Subject: hg: jdk8/tl/corba: 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Message-ID: <20131108044900.953AD6245A@hg.openjdk.java.net> Changeset: b99535e22efe Author: mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb, lancea ! src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java From yong.huang at oracle.com Thu Nov 7 22:34:08 2013 From: yong.huang at oracle.com (yong.huang at oracle.com) Date: Fri, 08 Nov 2013 06:34:08 +0000 Subject: hg: jdk8/tl/jdk: 8027695: There should be a space before % sign in Swedish locale Message-ID: <20131108063422.B41126245E@hg.openjdk.java.net> Changeset: e10a182c973a Author: yhuang Date: 2013-11-07 22:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e10a182c973a 8027695: There should be a space before % sign in Swedish locale Reviewed-by: naoto ! src/share/classes/sun/text/resources/sv/FormatData_sv_SE.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From jaroslav.bachorik at oracle.com Thu Nov 7 23:11:25 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 7 Nov 2013 23:11:25 -0800 (PST) Subject: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently In-Reply-To: <527C367D.3040401@oracle.com> References: <527B9D49.5010908@oracle.com> <527C367D.3040401@oracle.com> Message-ID: <527C8E9D.1030708@oracle.com> On 8.11.2013 01:55, David Holmes wrote: > On 8/11/2013 12:01 AM, Jaroslav Bachorik wrote: >> Please, review this test fix. >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 >> Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 >> >> The failure was caused by the IOHandler not waiting for the actual >> message stating the the debugee was ready. > > So the base problem was that the initial in.read(b, 0, 100) might not > actually read the message that the debuggee was ready? It would read the message. But the synchronization could get confused by an extraneous output before the "ready" message. This is only my best guess because I was not able to reproduce the error. But looking at the test this is the only path that could lead to SocketException short of the debugee application being killed immediately after it has been started. > > The cleanup seems good to me in general. Only concern I have is that > where the IOHandler would print what was read (which might not be what > was expected), in the new code if we don't see what we expect we just > set a boolean to false and the actual output from the debugee is never > shown - or is the debuggee output captured elsewhere? ProcessTools.startProcess() takes care of forwarding the stderr and stdout from the external process to the stderr and stdout of the launching app. It also adds a disambiguation prefix to the forwarded logs. -JB- > > Thanks, > David > > The patch uses the library >> functions to start the debugee and wait for the actual message to >> appear. Also, it detects problems while starting the debugee and reports >> them instead of failing only when the debugger can not connect. >> >> Thanks, >> >> -JB- From jaroslav.bachorik at oracle.com Thu Nov 7 23:48:40 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Fri, 08 Nov 2013 07:48:40 +0000 Subject: hg: jdk8/tl/jdk: 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c Message-ID: <20131108074852.ADE2362461@hg.openjdk.java.net> Changeset: b5748857ef42 Author: jbachorik Date: 2013-11-08 08:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5748857ef42 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c Reviewed-by: dholmes ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c From erik.joelsson at oracle.com Fri Nov 8 00:21:45 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 08 Nov 2013 09:21:45 +0100 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public In-Reply-To: <527C250B.5000507@oracle.com> References: <527C250B.5000507@oracle.com> Message-ID: <527C9F19.4040507@oracle.com> Reduced complexity in makefiles is always nice to see. Build part looks good to me. /Erik On 2013-11-08 00:40, Mandy Chung wrote: > com.sun.management API is an exported API [1] except > com.sun.management.OSMBeanFactory class which is an > implementation-specific class and it's currently annotated as > @jdk.Exported(false) [2]. This patch will eliminate one use of > @jdk.Exported(false). > > This is simply refactoring of the existing implementation: > o remove com.sun.management.OSMBeanFactory > o move the implementation classes to sun.management including > - rename com.sun.management.UnixOperatingSystemImpl (or > OperatingSystem windows version) to sun.management.OperatingSystemImpl > along with its native implementation > - sun.management.ManagementFactoryHelper creates the > sun.management.OperatingSystemImpl instance directly (no need of the > factory OSMBeanFactory method) > > I'm including build-dev as there are changes in the makefiles. > > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8025985/webrev.00/ > > thanks > Mandy > [1] > http://download.java.net/jdk8/docs/jre/api/management/extension/index.html > [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55 From magnus.ihse.bursie at oracle.com Fri Nov 8 00:39:38 2013 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 08 Nov 2013 09:39:38 +0100 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public In-Reply-To: <527C250B.5000507@oracle.com> References: <527C250B.5000507@oracle.com> Message-ID: <527CA34A.60004@oracle.com> On 2013-11-08 00:40, Mandy Chung wrote: > com.sun.management API is an exported API [1] except > com.sun.management.OSMBeanFactory class which is an > implementation-specific class and it's currently annotated as > @jdk.Exported(false) [2]. This patch will eliminate one use of > @jdk.Exported(false). > > This is simply refactoring of the existing implementation: > o remove com.sun.management.OSMBeanFactory > o move the implementation classes to sun.management including > - rename com.sun.management.UnixOperatingSystemImpl (or > OperatingSystem windows version) to sun.management.OperatingSystemImpl > along with its native implementation > - sun.management.ManagementFactoryHelper creates the > sun.management.OperatingSystemImpl instance directly (no need of the > factory OSMBeanFactory method) > > I'm including build-dev as there are changes in the makefiles. > > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8025985/webrev.00/ The makefile changes look good. /Magnus From jaroslav.bachorik at oracle.com Fri Nov 8 00:40:00 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 08 Nov 2013 09:40:00 +0100 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public In-Reply-To: <527C250B.5000507@oracle.com> References: <527C250B.5000507@oracle.com> Message-ID: <527CA360.8060403@oracle.com> On 8.11.2013 00:40, Mandy Chung wrote: > com.sun.management API is an exported API [1] except > com.sun.management.OSMBeanFactory class which is an > implementation-specific class and it's currently annotated as > @jdk.Exported(false) [2]. This patch will eliminate one use of > @jdk.Exported(false). > > This is simply refactoring of the existing implementation: > o remove com.sun.management.OSMBeanFactory > o move the implementation classes to sun.management including > - rename com.sun.management.UnixOperatingSystemImpl (or > OperatingSystem windows version) to sun.management.OperatingSystemImpl > along with its native implementation > - sun.management.ManagementFactoryHelper creates the > sun.management.OperatingSystemImpl instance directly (no need of the > factory OSMBeanFactory method) > > I'm including build-dev as there are changes in the makefiles. > > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8025985/webrev.00/ AbstractOperatingSystemImpl should be an abstract class as its name already indicates. The rest looks fine to me (not a reviewer, though) -JB- > > thanks > Mandy > [1] > http://download.java.net/jdk8/docs/jre/api/management/extension/index.html > [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55 From staffan.larsen at oracle.com Fri Nov 8 01:04:08 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 08 Nov 2013 09:04:08 +0000 Subject: hg: jdk8/tl/jdk: 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Message-ID: <20131108090422.B49BD62469@hg.openjdk.java.net> Changeset: 8a4405fb40ba Author: ykantser Date: 2013-11-07 16:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a4405fb40ba 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Reviewed-by: sla, jbachorik ! test/sun/tools/jstatd/JstatdTest.java From yasu at ysfactory.dip.jp Fri Nov 8 04:47:18 2013 From: yasu at ysfactory.dip.jp (Yasumasa Suenaga) Date: Fri, 08 Nov 2013 21:47:18 +0900 Subject: PING: JDK-7090324: gclog rotation via external tool In-Reply-To: <52496A21.8080608@ysfactory.dip.jp> References: <52483BDB.8040206@ysfactory.dip.jp> <52496A21.8080608@ysfactory.dip.jp> Message-ID: <527CDD56.7080106@ysfactory.dip.jp> Hi all, Did someone read my mail? I think that this RFE helps us to watch Java heap on production system. Also I think this RFE is able to be part of the JEP 158 (Unified JVM Logging) . I want to update this RFE in JDK Bug System, but I don't have account. So I've posted email at first. Thanks, Yasumasa On 2013/09/30 21:10, Yasumasa Suenaga wrote: > In previous email, I've attached new patch for this RFE. > It works fine with current hsx. > > > Yasumasa > > On 2013/09/29 23:40, Yasu wrote: >> Hi all, >> >> We are using "logrotate" tool on RHEL for various log rotation. >> Current HotSpot has gclog rotation function for log size base, >> however I need to rotate gc log synchronizing with logrotate tool. >> >> So I've created RFE as "JDK-7090324: gclog rotation via external tool" . >> And Sr. Engineering Manager in Oracle said he use the essence of my patch in one >> of the jcmd subcommands. >> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2011-September/003274.html >> >> 2 years ago, I posted a patch for this RFE. >> But this patch is too old to apply for current HotSpot. >> >> In last month, a similar discussion was appeared in ML. >> So I think it's time to discuss this RFE. >> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2013-August/008029.html >> >> >> Please cooperate. >> >> Best regards, >> Yasumasa > From Alan.Bateman at oracle.com Fri Nov 8 05:22:02 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 08 Nov 2013 13:22:02 +0000 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public In-Reply-To: <527CA360.8060403@oracle.com> References: <527C250B.5000507@oracle.com> <527CA360.8060403@oracle.com> Message-ID: <527CE57A.20808@oracle.com> On 08/11/2013 08:40, Jaroslav Bachorik wrote: > > AbstractOperatingSystemImpl should be an abstract class as its name > already indicates. Right, it probably should be something like BaseOperatingSystemImpl. Otherwise it looks good to me too. -Alan. From mattias.tobiasson at oracle.com Fri Nov 8 06:48:17 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Fri, 8 Nov 2013 06:48:17 -0800 (PST) Subject: RFR (XS): 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Message-ID: <32a27f01-bf13-4f28-ba10-7e5408611387@default> Hi, Could you please review this fix. The tests for java/lang/instrument/PremainClass/PremainAgent has been ported from script to java. The purpose is to make the tests more stable and easier to maintain. Thanks, Mattias Webrev: http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8023138 From andreas.lundblad at oracle.com Fri Nov 8 05:39:47 2013 From: andreas.lundblad at oracle.com (Andreas Lundblad) Date: Fri, 8 Nov 2013 14:39:47 +0100 Subject: Removal of sample code from tools.jar Message-ID: <20131108133947.GB3185@e6430> Regarding bug JDK-8008602: Sample code in tools.jar. Does anyone have any insight in whether or not the JPDA example code in com.sun.tools.example.** should be kept, or if should be removed altogether? AFAIK no code outside of the example package depends upon it. The build does however fail with "make[2]: *** No rule to make target `.../tl/jdk/src/share/classes/com/sun/tools/example/README', needed by `.../tl/build/linux-x86_64-normal-server-release/jdk/demo/jpda/com/sun/tools/example/README'. Stop." and I can't find the reason while browsing / grepping in the make files. Any input on the matter would be greately appreciated. best regardrs, Andreas Lundblad From mandy.chung at oracle.com Fri Nov 8 07:48:26 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 08 Nov 2013 07:48:26 -0800 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public In-Reply-To: <527CE57A.20808@oracle.com> References: <527C250B.5000507@oracle.com> <527CA360.8060403@oracle.com> <527CE57A.20808@oracle.com> Message-ID: <527D07CA.8040703@oracle.com> Thanks you all for the review. I'll rename AbstractOperatingSystemImpl before I push. Mandy On 11/8/2013 5:22 AM, Alan Bateman wrote: > On 08/11/2013 08:40, Jaroslav Bachorik wrote: >> >> AbstractOperatingSystemImpl should be an abstract class as its name >> already indicates. > Right, it probably should be something like BaseOperatingSystemImpl. > > Otherwise it looks good to me too. > > -Alan. From mandy.chung at oracle.com Fri Nov 8 07:55:05 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 15:55:05 +0000 Subject: hg: jdk8/tl/jdk: 8027351: (ref) Private finalize method invoked in preference to protected superclass method Message-ID: <20131108155536.2E54962470@hg.openjdk.java.net> Changeset: 41d7ce111bd8 Author: mchung Date: 2013-11-08 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d7ce111bd8 8027351: (ref) Private finalize method invoked in preference to protected superclass method Reviewed-by: alanb, dholmes, mr, plevart, psandoz ! makefiles/lib/CoreLibraries.gmk ! makefiles/mapfiles/libjava/mapfile-vers ! makefiles/mapfiles/libjava/reorder-sparc ! makefiles/mapfiles/libjava/reorder-sparcv9 ! makefiles/mapfiles/libjava/reorder-x86 ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/misc/VM.java + test/java/lang/ref/FinalizeOverride.java From alex.schenkman at oracle.com Fri Nov 8 08:02:10 2013 From: alex.schenkman at oracle.com (Alex Schenkman) Date: Fri, 08 Nov 2013 17:02:10 +0100 Subject: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature In-Reply-To: References: <51A31867.9080602@oracle.com> <51CAC09B.7070706@oracle.com> <7E2E50A8-1FB1-429B-8AAB-94863C215623@oracle.com> <51D56A11.5030600@oracle.com> <5214AC0A.4010603@oracle.com> <70F043F0-9F19-4761-B175-1D6652B5A146@oracle.com> <3B20B5DC-9E92-4EB6-97FF-0F2D2B4E1E10@oracle.com> <52244497.8010902@oracle.com> <5267C65A.9060602@oracle.com> <4EDB8911-E772-4B13-B0EB-AA90C729A49A@oracle.com> <526FCC02.3050308@oracle.com> Message-ID: <527D0B02.6040705@oracle.com> Hi list, Latest version is up for review here [1]. It fixes Staffan's latest comments (see below), as well as some indentation and tab/spaces nits. Thanks! [1] http://cr.openjdk.java.net/~miauno/8014506/ On 2013-10-30 16:03, Staffan Larsen wrote: > Alex, > > This looks much better! Thanks for spending the time. > > README: > nit: contribuited -> contributed > > JdpTestUtilTest.java: > Can you add a comment saying this is a test for the tests - just > like PacketTest.java and PortAlreadyInUseTest.java? > > PortFinder.java: > Please remove this and use Utils.getFreePort() since ykantser's fix > is now pushed. > > Thanks, > /Staffan > > On 29 okt 2013, at 15:53, Alex Schenkman > wrote: > >> Hi Staffan, >> >> There is a new webrev here [1], addressing your comments. >> >> The Jdp specs have changed a bit, adding three optional fields to the >> Jdp packet [2]. >> The JEP-168 [3] is not updated yet, but Dmitry will do it soon. >> This enhancement request is tracking the changes needed for SQE [4]. >> >> See inlined answers for details on your previos comments, please. >> >> Thanks! >> >> >> [1] >> http://cr.openjdk.java.net/~dsamersoff/sponsorship/aschenkman/8014506/webrev.04/ >> >> [2] https://bugs.openjdk.java.net/browse/JDK-8004213 >> [3] http://openjdk.java.net/jeps/168 >> [4] https://bugs.openjdk.java.net/browse/JDK-8027436 >> >> On 2013-10-24 10:54, Staffan Larsen wrote: >>> Alex, >>> >>> test/sun/management/jdp/README >>> Thanks for providing a README! >>> References to JDK-7169888 seem incorrect to me. >>> L8: "written by" appears twice. >>> L11: "defautl" -> "default" >>> >> Fixed. >>> test/lib/testlibrary/jdk/testlibrary/PortFinder.java >>> This should be coordinated with the review for 8022229 which >>> contains the same code in a different testlibrary class: >>> http://cr.openjdk.java.net/~ykantser/8022229/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html >>> >>> >> I made a private copy of this function, and have marked it as deprecated. >> As soon as ykanster's code is merged I can delete my private function >> and use the library. >> The reason for this is to get this patch pushed without further delay. >> >>> test/sun/management/jdp/7169888/JdpClient.java >>> test/sun/management/jdp/7169888/JdpDoSomething.java >>> test/sun/management/jdp/7169888/JdpTest.sh >>> test/sun/management/jdp/7169888/JdpUnitTest.java >>> These were moved to a subdirectory, but these tests have nothing >>> to do with bug 7169888, so why that name? In any case we should >>> avoid naming test directories after bug ids, and instead use a >>> descriptive name. >>> >> This bug number was wrong. These tests were now moved back to the jdp >> folder. >> I have expanded the README file with some details about these tests. >> >> Dmitry's shell-based are as follows: >> test_01 - basic test, check if JDP packet assembler and other >> parts of JDP is not broken >> >> test_02 - test if JDP starts with custom parameters. >> >> test_03 - test if jcmd is able to start jdp with >> custom parameters (disabled) >> >> test_04 - test if JDP starts with default parameters >> >> test_05 - test if jcmd is able to start jdp with default >> parameters (disabled) >> >> >> test_03 and test_05 are diabled becuase there is a mismatch between >> hotsport and jdk repos, according to Dmitry. These cases (jcmd) are >> not covered by this patch, and are part of the test enhacements [4]. >> >> test_01 does partly overlap with the Java-based tests, but we should >> keep it until we implement the latest enhacements [4]. >> >> >>> test/sun/management/jdp/ClientConnection.java >>> No comments. >>> >>> test/sun/management/jdp/DefaultLauncher.java >>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>> /lib/testlibrary" ? >>> >> Fixed. >>> test/sun/management/jdp/OffLauncher.java >>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>> /lib/testlibrary" ? >>> >> Fixed. >> >>> test/sun/management/jdp/SpecificJdpAddressLauncher.java >>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>> /lib/testlibrary" ? >>> >> Fixed. >>> test/sun/management/jdp/DynamicLauncher.java >>> No comments. >>> >> Fixed. >> >>> test/sun/management/jdp/JdpOffTest.java >>> For the future: it is customary that the file containing the jtreg >>> directives be named xxxTest.java, and supporting files not ending in >>> Test. >>> >> I have renamed the tests following your recomendation. >> Jtreg tests have now the test suffix. >> >>> test/sun/management/jdp/JdpOnTest.java >>> For the future: it is customary that the file containing the jtreg >>> directives be named xxxTest.java, and supporting files not ending in >>> Test. >>> >> Same as above. >>> test/sun/management/jdp/JdpTest.java >>> No comments. >>> >>> test/sun/management/jdp/JdpTestUtil.java >>> No comments. >>> >>> test/sun/management/jdp/JdpTestUtilTest.java >>> test/sun/management/jdp/PacketTest.java >>> test/sun/management/jdp/PortAlreadyInUseTest.java >>> These are tests for the tests. But where are the tests for the >>> tests for the tests? :) >>> Not reviewed. >>> >>> >>> Thanks, >>> /Staffan >>> >> > -- Alex Schenkman Java VM SQE Stockholm -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131108/e33353c9/attachment-0001.html From bill.pittore at oracle.com Fri Nov 8 08:08:53 2013 From: bill.pittore at oracle.com (bill.pittore at oracle.com) Date: Fri, 08 Nov 2013 11:08:53 -0500 Subject: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument Message-ID: <527D0C95.8050605@oracle.com> If you are running a non-minimal VM build with compact 1 or 2 JRE and you pass in -Dcom.sun.management argument, VM will exit silently with exit code 1. Fix adds an error check when attempting to load the class sun.management.Agent (missing from compact 1 and 2) and will print a message before exiting. http://cr.openjdk.java.net/~bpittore/8027914/webrev.00/ thanks, bill From chris.hegarty at oracle.com Fri Nov 8 08:13:27 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 08 Nov 2013 16:13:27 +0000 Subject: hg: jdk8/tl/jdk: 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Message-ID: <20131108161339.A426462472@hg.openjdk.java.net> Changeset: 3112729d6b74 Author: tyan Date: 2013-11-08 15:12 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3112729d6b74 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Reviewed-by: chegar ! test/java/net/MulticastSocket/TestInterfaces.java ! test/java/net/NetworkInterface/Equals.java From chris.hegarty at oracle.com Fri Nov 8 08:17:23 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 08 Nov 2013 16:17:23 +0000 Subject: hg: jdk8/tl/jdk: 8019834: InetAddress.getByName hangs for bad IPv6 literals Message-ID: <20131108161736.E58A062473@hg.openjdk.java.net> Changeset: 771c77b49bb6 Author: chegar Date: 2013-11-08 15:15 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/771c77b49bb6 8019834: InetAddress.getByName hangs for bad IPv6 literals Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java ! test/java/net/ipv6tests/BadIPv6Addresses.java From mandy.chung at oracle.com Fri Nov 8 09:44:27 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 17:44:27 +0000 Subject: hg: jdk8/tl/jdk: 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Message-ID: <20131108174442.42C5662476@hg.openjdk.java.net> Changeset: 1c9ba18198d5 Author: mchung Date: 2013-11-08 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c9ba18198d5 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Reviewed-by: alanb - src/share/native/java/lang/ref/Finalizer.c From mikael.auno at oracle.com Fri Nov 8 09:45:07 2013 From: mikael.auno at oracle.com (Mikael Auno) Date: Fri, 08 Nov 2013 18:45:07 +0100 Subject: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature In-Reply-To: <527D0B02.6040705@oracle.com> References: <51A31867.9080602@oracle.com> <51CAC09B.7070706@oracle.com> <7E2E50A8-1FB1-429B-8AAB-94863C215623@oracle.com> <51D56A11.5030600@oracle.com> <5214AC0A.4010603@oracle.com> <70F043F0-9F19-4761-B175-1D6652B5A146@oracle.com> <3B20B5DC-9E92-4EB6-97FF-0F2D2B4E1E10@oracle.com> <52244497.8010902@oracle.com> <5267C65A.9060602@oracle.com> <4EDB8911-E772-4B13-B0EB-AA90C729A49A@oracle.com> <526FCC02.3050308@oracle.com> <527D0B02.6040705@oracle.com> Message-ID: <527D2323.8080403@oracle.com> There was some unintended whitespace changes in webrev.05 that Alex had missed. I removed them and uploaded webrev.06 for him. http://cr.openjdk.java.net/~miauno/8014506/webrev.06/ Mikael On 2013-11-08 17:02, Alex Schenkman wrote: > Hi list, > > Latest version is up for review here [1]. > It fixes Staffan's latest comments (see below), as well as some > indentation and tab/spaces nits. > > Thanks! > > [1] http://cr.openjdk.java.net/~miauno/8014506/ > > > On 2013-10-30 16:03, Staffan Larsen wrote: >> Alex, >> >> This looks much better! Thanks for spending the time. >> >> README: >> nit: contribuited -> contributed >> >> JdpTestUtilTest.java: >> Can you add a comment saying this is a test for the tests - just >> like PacketTest.java and PortAlreadyInUseTest.java? >> >> PortFinder.java: >> Please remove this and use Utils.getFreePort() since ykantser's fix >> is now pushed. >> >> Thanks, >> /Staffan >> >> On 29 okt 2013, at 15:53, Alex Schenkman > > wrote: >> >>> Hi Staffan, >>> >>> There is a new webrev here [1], addressing your comments. >>> >>> The Jdp specs have changed a bit, adding three optional fields to the >>> Jdp packet [2]. >>> The JEP-168 [3] is not updated yet, but Dmitry will do it soon. >>> This enhancement request is tracking the changes needed for SQE [4]. >>> >>> See inlined answers for details on your previos comments, please. >>> >>> Thanks! >>> >>> >>> [1] >>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/aschenkman/8014506/webrev.04/ >>> >>> [2] https://bugs.openjdk.java.net/browse/JDK-8004213 >>> [3] http://openjdk.java.net/jeps/168 >>> [4] https://bugs.openjdk.java.net/browse/JDK-8027436 >>> >>> On 2013-10-24 10:54, Staffan Larsen wrote: >>>> Alex, >>>> >>>> test/sun/management/jdp/README >>>> Thanks for providing a README! >>>> References to JDK-7169888 seem incorrect to me. >>>> L8: "written by" appears twice. >>>> L11: "defautl" -> "default" >>>> >>> Fixed. >>>> test/lib/testlibrary/jdk/testlibrary/PortFinder.java >>>> This should be coordinated with the review for 8022229 which >>>> contains the same code in a different testlibrary class: >>>> http://cr.openjdk.java.net/~ykantser/8022229/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html >>>> >>>> >>> I made a private copy of this function, and have marked it as deprecated. >>> As soon as ykanster's code is merged I can delete my private function >>> and use the library. >>> The reason for this is to get this patch pushed without further delay. >>> >>>> test/sun/management/jdp/7169888/JdpClient.java >>>> test/sun/management/jdp/7169888/JdpDoSomething.java >>>> test/sun/management/jdp/7169888/JdpTest.sh >>>> test/sun/management/jdp/7169888/JdpUnitTest.java >>>> These were moved to a subdirectory, but these tests have nothing >>>> to do with bug 7169888, so why that name? In any case we should >>>> avoid naming test directories after bug ids, and instead use a >>>> descriptive name. >>>> >>> This bug number was wrong. These tests were now moved back to the jdp >>> folder. >>> I have expanded the README file with some details about these tests. >>> >>> Dmitry's shell-based are as follows: >>> test_01 - basic test, check if JDP packet assembler and other >>> parts of JDP is not broken >>> >>> test_02 - test if JDP starts with custom parameters. >>> >>> test_03 - test if jcmd is able to start jdp with >>> custom parameters (disabled) >>> >>> test_04 - test if JDP starts with default parameters >>> >>> test_05 - test if jcmd is able to start jdp with default >>> parameters (disabled) >>> >>> >>> test_03 and test_05 are diabled becuase there is a mismatch between >>> hotsport and jdk repos, according to Dmitry. These cases (jcmd) are >>> not covered by this patch, and are part of the test enhacements [4]. >>> >>> test_01 does partly overlap with the Java-based tests, but we should >>> keep it until we implement the latest enhacements [4]. >>> >>> >>>> test/sun/management/jdp/ClientConnection.java >>>> No comments. >>>> >>>> test/sun/management/jdp/DefaultLauncher.java >>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>> /lib/testlibrary" ? >>>> >>> Fixed. >>>> test/sun/management/jdp/OffLauncher.java >>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>> /lib/testlibrary" ? >>>> >>> Fixed. >>> >>>> test/sun/management/jdp/SpecificJdpAddressLauncher.java >>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>> /lib/testlibrary" ? >>>> >>> Fixed. >>>> test/sun/management/jdp/DynamicLauncher.java >>>> No comments. >>>> >>> Fixed. >>> >>>> test/sun/management/jdp/JdpOffTest.java >>>> For the future: it is customary that the file containing the jtreg >>>> directives be named xxxTest.java, and supporting files not ending in >>>> Test. >>>> >>> I have renamed the tests following your recomendation. >>> Jtreg tests have now the test suffix. >>> >>>> test/sun/management/jdp/JdpOnTest.java >>>> For the future: it is customary that the file containing the jtreg >>>> directives be named xxxTest.java, and supporting files not ending in >>>> Test. >>>> >>> Same as above. >>>> test/sun/management/jdp/JdpTest.java >>>> No comments. >>>> >>>> test/sun/management/jdp/JdpTestUtil.java >>>> No comments. >>>> >>>> test/sun/management/jdp/JdpTestUtilTest.java >>>> test/sun/management/jdp/PacketTest.java >>>> test/sun/management/jdp/PortAlreadyInUseTest.java >>>> These are tests for the tests. But where are the tests for the >>>> tests for the tests? :) >>>> Not reviewed. >>>> >>>> >>>> Thanks, >>>> /Staffan >>>> >>> >> > > -- > Alex Schenkman > Java VM SQE Stockholm > From chris.hegarty at oracle.com Fri Nov 8 10:56:10 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 08 Nov 2013 18:56:10 +0000 Subject: hg: jdk8/tl/jdk: 8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine Message-ID: <20131108185622.442AF6247A@hg.openjdk.java.net> Changeset: 46982ca895b4 Author: tyan Date: 2013-11-08 18:54 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46982ca895b4 8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6433018.java From mandy.chung at oracle.com Fri Nov 8 12:14:00 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 20:14:00 +0000 Subject: hg: jdk8/tl/jdk: 8025985: com.sun.management.OSMBeanFactory should not be public Message-ID: <20131108201413.E279E62480@hg.openjdk.java.net> Changeset: 40ca9e4866de Author: mchung Date: 2013-11-08 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40ca9e4866de 8025985: com.sun.management.OSMBeanFactory should not be public Reviewed-by: alanb, erikj, ihse, jbachorik ! makefiles/lib/ServiceabilityLibraries.gmk ! makefiles/mapfiles/libmanagement/mapfile-vers + src/share/classes/sun/management/BaseOperatingSystemImpl.java ! src/share/classes/sun/management/ManagementFactoryHelper.java - src/share/classes/sun/management/OperatingSystemImpl.java - src/solaris/classes/com/sun/management/OSMBeanFactory.java - src/solaris/classes/com/sun/management/UnixOperatingSystem.java + src/solaris/classes/sun/management/OperatingSystemImpl.java - src/solaris/native/com/sun/management/LinuxOperatingSystem.c - src/solaris/native/com/sun/management/MacosxOperatingSystem.c - src/solaris/native/com/sun/management/SolarisOperatingSystem.c - src/solaris/native/com/sun/management/UnixOperatingSystem_md.c + src/solaris/native/sun/management/LinuxOperatingSystem.c + src/solaris/native/sun/management/MacosxOperatingSystem.c + src/solaris/native/sun/management/OperatingSystemImpl.c + src/solaris/native/sun/management/SolarisOperatingSystem.c - src/windows/classes/com/sun/management/OSMBeanFactory.java - src/windows/classes/com/sun/management/OperatingSystem.java + src/windows/classes/sun/management/OperatingSystemImpl.java - src/windows/native/com/sun/management/OperatingSystem_md.c + src/windows/native/sun/management/OperatingSystemImpl.c From joe.darcy at oracle.com Fri Nov 8 12:19:39 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 08 Nov 2013 20:19:39 +0000 Subject: hg: jdk8/tl/jdk: 8028076: Correct raw type lint warnings in core reflection implementation classes Message-ID: <20131108201953.3E21B62483@hg.openjdk.java.net> Changeset: 11376ad23e21 Author: darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/repository/GenericDeclRepository.java From alan.bateman at oracle.com Fri Nov 8 13:14:47 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 08 Nov 2013 21:14:47 +0000 Subject: hg: jdk8/tl/jdk: 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f Message-ID: <20131108211501.630EE62488@hg.openjdk.java.net> Changeset: 50df04934e86 Author: alanb Date: 2013-11-08 21:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50df04934e86 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f Reviewed-by: chegar ! src/share/classes/java/net/InetAddress.java From alejandro.murillo at oracle.com Fri Nov 8 15:45:33 2013 From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com) Date: Fri, 08 Nov 2013 23:45:33 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 16 new changesets Message-ID: <20131108234606.A88476248C@hg.openjdk.java.net> Changeset: e39b138b2518 Author: acorn Date: 2013-10-19 18:32 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e39b138b2518 8026893: Push 8026365 to TL early and add test Reviewed-by: dcubed, kamg ! src/share/vm/classfile/verifier.cpp ! test/TEST.groups + test/runtime/8026365/InvokeSpecialAnonTest.java Changeset: 0e55a181cb08 Author: lana Date: 2013-10-28 12:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0e55a181cb08 Merge - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp - test/compiler/8013496/Test8013496.sh - test/gc/7168848/HumongousAlloc.java Changeset: ea1b8c643fc8 Author: lana Date: 2013-10-30 13:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ea1b8c643fc8 Merge - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: 205834867346 Author: lana Date: 2013-10-31 16:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/205834867346 Merge Changeset: 9ebaac78a8a0 Author: amurillo Date: 2013-11-05 14:06 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9ebaac78a8a0 Merge Changeset: 842b6ce4dfb4 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/842b6ce4dfb4 Added tag jdk8-b115 for changeset 9ebaac78a8a0 ! .hgtags Changeset: 208ebea980f8 Author: roland Date: 2013-11-04 21:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/208ebea980f8 8027445: SIGSEGV at TestFloatingDecimal.testAppendToDouble()I Summary: String.equals() intrinsic shouldn't use integer length input in pointer arithmetic without an i2l. Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sparc.ad + test/compiler/intrinsics/stringequals/TestStringEqualsBadLength.java Changeset: e428d5e768e3 Author: rbackman Date: 2013-11-04 10:44 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e428d5e768e3 8027622: java.time.Instant.create failing since hs25-b56 Reviewed-by: kvn, iveresov ! src/share/vm/opto/compile.cpp + test/compiler/intrinsics/mathexact/CompareTest.java Changeset: a905d33ce13a Author: iveresov Date: 2013-11-05 00:59 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a905d33ce13a 8027751: C1 crashes in Weblogic with G1 enabled Summary: Keep T_OBJECT operands in registers for logical operations on x64 Reviewed-by: kvn, roland ! src/share/vm/c1/c1_LinearScan.cpp + test/compiler/regalloc/C1ObjectSpillInLogicOp.java Changeset: 94a83e0f9ce1 Author: iveresov Date: 2013-11-05 01:57 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/94a83e0f9ce1 8017065: C2 allows safepoint checks to leak into G1 pre-barriers Summary: Make all raw loads strictly respect control dependencies, make sure RCE doesn't move raw loads, add verification of G1 pre-barriers. Reviewed-by: kvn, roland ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/memnode.hpp Changeset: 613e6a6fc328 Author: iveresov Date: 2013-11-05 02:29 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/613e6a6fc328 Merge ! src/share/vm/opto/compile.cpp Changeset: be525e91f65b Author: mikael Date: 2013-11-06 06:51 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/be525e91f65b 8026775: nsk/jvmti/RedefineClasses/StressRedefine crashes due to EXCEPTION_ACCESS_VIOLATION Summary: Uncommon trap blob did not bang all the stack shadow pages Reviewed-by: kvn, twisti, iveresov, jrose ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/asm/assembler.cpp + test/compiler/uncommontrap/UncommonTrapStackBang.java Changeset: 53662b2f1d68 Author: drchase Date: 2013-11-07 10:02 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/53662b2f1d68 Merge Changeset: e510dfdec6dd Author: amurillo Date: 2013-11-08 07:02 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e510dfdec6dd Merge Changeset: 52b076e6ffae Author: amurillo Date: 2013-11-08 07:02 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/52b076e6ffae Added tag hs25-b58 for changeset e510dfdec6dd ! .hgtags Changeset: 20c72bec2707 Author: amurillo Date: 2013-11-08 07:13 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/20c72bec2707 8028061: new hotspot build - hs25-b59 Reviewed-by: jcoomes ! make/hotspot_version From roger.riggs at oracle.com Fri Nov 8 15:52:52 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 08 Nov 2013 23:52:52 +0000 Subject: hg: jdk8/tl/jdk: 8028041: Serialized Form description of j.l.String is not consistent with the implementation Message-ID: <20131108235304.9453E6248E@hg.openjdk.java.net> Changeset: df2f7f288353 Author: rriggs Date: 2013-11-08 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df2f7f288353 8028041: Serialized Form description of j.l.String is not consistent with the implementation Summary: Replaced incorrect description with reference to the serialization specification Reviewed-by: alanb, smarks ! src/share/classes/java/lang/String.java From mikael.gerdin at oracle.com Fri Nov 8 16:56:28 2013 From: mikael.gerdin at oracle.com (mikael.gerdin at oracle.com) Date: Sat, 09 Nov 2013 00:56:28 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20131109005632.F05BA62497@hg.openjdk.java.net> Changeset: 9d8b29a0548c Author: mgerdin Date: 2013-11-08 16:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9d8b29a0548c 8027237: New tests on ReservedSpace/VirtualSpace classes Summary: Three tests added: 1) test stressing VirtualSpace by resizing it constantly 2) test running unit tests in several threads 3) test checking protected area in ReservedHeapSpace class Reviewed-by: stefank, zgu Contributed-by: aleksey.timofeev at oracle.com ! src/share/vm/prims/whitebox.cpp + test/runtime/memory/ReadFromNoaccessArea.java + test/runtime/memory/RunUnitTestsConcurrently.java + test/runtime/memory/StressVirtualSpaceResize.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 19f8a5d7600b Author: mgerdin Date: 2013-11-08 23:49 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/19f8a5d7600b Merge From mandy.chung at oracle.com Fri Nov 8 18:45:22 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 08 Nov 2013 18:45:22 -0800 Subject: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument In-Reply-To: <527D0C95.8050605@oracle.com> References: <527D0C95.8050605@oracle.com> Message-ID: <527DA1C2.6020500@oracle.com> On 11/8/2013 8:08 AM, bill.pittore at oracle.com wrote: > If you are running a non-minimal VM build with compact 1 or 2 JRE and > you pass in -Dcom.sun.management argument, VM will exit silently with > exit code 1. Fix adds an error check when attempting to load the class > sun.management.Agent (missing from compact 1 and 2) and will print a > message before exiting. > > http://cr.openjdk.java.net/~bpittore/8027914/webrev.00/ > Since sun.management.Agent is not always present, would it better to change to call resolve_or_null and check the returned Klass? Mandy From lana.steuck at oracle.com Fri Nov 8 20:49:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:32 +0000 Subject: hg: jdk8/tl/corba: 4 new changesets Message-ID: <20131109044935.16142624A0@hg.openjdk.java.net> Changeset: d425685e0b74 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d425685e0b74 Added tag jdk8-b114 for changeset 0bbccf77c23e ! .hgtags Changeset: 8d07115924b7 Author: lana Date: 2013-10-31 16:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8d07115924b7 Merge Changeset: 5fdc44652089 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5fdc44652089 Added tag jdk8-b115 for changeset 8d07115924b7 ! .hgtags Changeset: 4796555c4dc8 Author: lana Date: 2013-11-08 17:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4796555c4dc8 Merge From lana.steuck at oracle.com Fri Nov 8 20:49:45 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:45 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20131109044958.ECB0A624A4@hg.openjdk.java.net> Changeset: fea486d30d41 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fea486d30d41 Added tag jdk8-b114 for changeset 850d2602ae98 ! .hgtags Changeset: 6b4d6205366c Author: lana Date: 2013-10-31 16:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b4d6205366c Merge - test/tools/javac/ExtDirs/ext1/pkg1.jar - test/tools/javac/ExtDirs/ext2/pkg2.jar - test/tools/javac/ExtDirs/ext3/pkg1.jar - test/tools/javac/ExtDirs/ext3/pkg2.jar - test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: 3c040b04af05 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3c040b04af05 Added tag jdk8-b115 for changeset 6b4d6205366c ! .hgtags Changeset: 21294feaf311 Author: lana Date: 2013-11-08 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/21294feaf311 Merge From lana.steuck at oracle.com Fri Nov 8 20:49:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:37 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20131109044945.B4268624A3@hg.openjdk.java.net> Changeset: d3b6da1b3e25 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d3b6da1b3e25 Added tag jdk8-b114 for changeset 1b1e12117fe2 ! .hgtags Changeset: f610fd46463e Author: lana Date: 2013-10-31 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f610fd46463e Merge Changeset: e757eb9aee3d Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e757eb9aee3d Added tag jdk8-b115 for changeset f610fd46463e ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:49:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:32 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20131109044932.DBA866249F@hg.openjdk.java.net> Changeset: b65d48f6938a Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b65d48f6938a Added tag jdk8-b114 for changeset 4f2011496393 ! .hgtags Changeset: 763ada2a1d8c Author: lana Date: 2013-10-31 16:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/763ada2a1d8c Merge Changeset: 40e892e2a4f2 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/40e892e2a4f2 Added tag jdk8-b115 for changeset 763ada2a1d8c ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:49:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:37 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20131109044943.86205624A2@hg.openjdk.java.net> Changeset: e126d8eca69b Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e126d8eca69b Added tag jdk8-b114 for changeset 9ad289610fc6 ! .hgtags Changeset: 587560c222a2 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/587560c222a2 Added tag jdk8-b115 for changeset e126d8eca69b ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:49:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:37 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131109044942.71D6A624A1@hg.openjdk.java.net> Changeset: f109bb255b80 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f109bb255b80 Added tag jdk8-b114 for changeset 79f7b79bf97b ! .hgtags Changeset: f0d3ac2474ee Author: lana Date: 2013-10-31 16:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f0d3ac2474ee Merge - src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java Changeset: 0fb1a427fbf6 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0fb1a427fbf6 Added tag jdk8-b115 for changeset f0d3ac2474ee ! .hgtags Changeset: d091499d67fc Author: lana Date: 2013-11-08 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d091499d67fc Merge From lana.steuck at oracle.com Fri Nov 8 20:49:52 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:52 +0000 Subject: hg: jdk8/tl/hotspot: 37 new changesets Message-ID: <20131109045108.186F9624A5@hg.openjdk.java.net> Changeset: ddc3758f68db Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ddc3758f68db Added tag jdk8-b114 for changeset 7fd913010dbb ! .hgtags Changeset: 205834867346 Author: lana Date: 2013-10-31 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/205834867346 Merge Changeset: f94a9f0746d8 Author: amurillo Date: 2013-10-25 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f94a9f0746d8 8027173: new hotspot build - hs25-b57 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e64f1fe9756b Author: farvidsson Date: 2013-10-24 10:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e64f1fe9756b 8024423: JVMTI: GetLoadedClasses doesn't enumerate anonymous classes Summary: Rewrite of the getLoadedClasses() method implementation to include anonymous classes. Reviewed-by: coleenp, sspitsyn ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/prims/jvmtiGetLoadedClasses.cpp Changeset: d70a665e25d7 Author: iklam Date: 2013-10-24 22:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d70a665e25d7 8020753: JNI_CreateJavaVM on Mac OSX 10.9 Mavericks corrupts the callers stack size Summary: Use hard-coded DEFAULT_MAIN_THREAD_STACK_PAGES = 2048 for 10.9 Reviewed-by: dcubed, iveresov Contributed-by: gerard.ziemski at oracle.com ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: e4f478e7781b Author: jbachorik Date: 2013-10-25 09:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4f478e7781b 8027294: Prepare hotspot for non TOD based uptime counter Summary: Use HR timer when available for os::elapsed_counter() on linux/bsd. Add a new counter for the JVM uptime. Reviewed-by: dholmes, sla ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp Changeset: a6177f601c64 Author: hseigel Date: 2013-10-25 11:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6177f601c64 8026822: metaspace/flags/maxMetaspaceSize throws OOM of unexpected type.java.lang.OutOfMemoryError: Compressed class space Summary: Incorporate chunk size when seeing if OutOfMemoryError was caused by Metaspace or Compressed class space. Reviewed-by: stefank, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: 634715d59d9e Author: hseigel Date: 2013-10-25 11:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/634715d59d9e Merge Changeset: 209aa13ab8c0 Author: coleenp Date: 2013-10-25 15:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/209aa13ab8c0 8024927: Nashorn performance regression with CompressedOops Summary: Allocate compressed class space at end of Java heap. For small heap sizes, without CDS, save some space so compressed classes can have the same favorable compression as oops Reviewed-by: stefank, hseigel, goetz ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/utilities/globalDefinitions.hpp + test/runtime/CompressedOops/CompressedClassPointers.java Changeset: b4aa8fc5d0d5 Author: ccheung Date: 2013-10-25 22:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4aa8fc5d0d5 Merge ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/memory/metaspace.cpp - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: 1a04de1aaedb Author: dsamersoff Date: 2013-10-28 21:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1a04de1aaedb 8026950: Nits in agent ps_proc.c file breaks compilation of open hotspot Summary: Fixed two compilation-breaking nits Reviewed-by: sla, dholmes ! agent/src/os/bsd/ps_proc.c Changeset: 85730a185147 Author: ccheung Date: 2013-10-30 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/85730a185147 Merge Changeset: 292050e5d5ea Author: dholmes Date: 2013-10-24 00:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/292050e5d5ea 8026877: Error in opening JAR file when invalid jar specified with -Xbootclasspath/a on OpenJDK build Reviewed-by: coleenp, twisti ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/thread.cpp Changeset: 066778844ed9 Author: jprovino Date: 2013-10-27 14:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/066778844ed9 Merge Changeset: f2f9139ccde9 Author: jprovino Date: 2013-10-30 16:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f2f9139ccde9 Merge Changeset: a007575ea726 Author: vladidan Date: 2013-10-30 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a007575ea726 Merge Changeset: 3b3133d93fb6 Author: brutisso Date: 2013-10-28 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b3133d93fb6 8027132: Print deprecation warning message for the flags controlling the CMS foreground collector Reviewed-by: stefank, ehelin, ysr, tschatzl ! src/share/vm/runtime/arguments.cpp + test/gc/startup_warnings/TestCMSForegroundFlags.java Changeset: 6d965678f21e Author: ehelin Date: 2013-10-31 21:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6d965678f21e Merge Changeset: bd3237e0e18d Author: twisti Date: 2013-10-24 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bd3237e0e18d 8026328: Setting a breakpoint on invokedynamic crashes the JVM Reviewed-by: jrose, roland ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/cppInterpreter.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreter.hpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/handles.cpp Changeset: cbe8ba0fb8fc Author: twisti Date: 2013-10-24 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbe8ba0fb8fc Merge - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: f01788f13696 Author: adlertz Date: 2013-10-25 10:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f01788f13696 8026940: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc Summary: Remove input to junk phi if they also become dead during post_allocate_copy_removal Reviewed-by: roland ! src/share/vm/opto/postaloc.cpp Changeset: 7ae254fd0b3c Author: adlertz Date: 2013-10-25 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ae254fd0b3c Merge Changeset: 6c2f07d1495f Author: roland Date: 2013-10-28 09:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6c2f07d1495f 8027140: Assertion in compiler when running bigapps/Kitchensink/stability Summary: filter() code for TypeKlassPtr not moved when permgen removal was introduced Reviewed-by: twisti, iveresov ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: bfdb530cdffa Author: roland Date: 2013-10-28 12:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bfdb530cdffa Merge Changeset: a196f1aaec86 Author: anoll Date: 2013-10-25 22:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a196f1aaec86 8026949: -Xint flag prints wrong warning: Initialization of C1 thread failed (no space to run compilers) Summary: Exit compiler threads early during startup so that wrong error message is not printed Reviewed-by: iveresov, twisti ! src/share/vm/compiler/compileBroker.cpp + test/compiler/startup/StartupOutput.java Changeset: 8c16f426dbb2 Author: iveresov Date: 2013-10-28 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c16f426dbb2 Merge Changeset: fc1632f5021a Author: iveresov Date: 2013-10-28 17:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fc1632f5021a Merge Changeset: a57a165b8296 Author: rbackman Date: 2013-10-28 08:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a57a165b8296 8027353: Exact intrinsics: assert(n != NULL) failed: must not be null Reviewed-by: kvn, roland ! src/share/vm/opto/library_call.cpp ! test/compiler/intrinsics/mathexact/SubExactLConstantTest.java ! test/compiler/intrinsics/mathexact/SubExactLNonConstantTest.java Changeset: 60a32bb8ff99 Author: rbackman Date: 2013-10-30 13:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/60a32bb8ff99 8027444: mathExact: assert(i < _max) failed: oob: i=1, _max=1 Reviewed-by: duke ! src/share/vm/opto/loopTransform.cpp + test/compiler/intrinsics/mathexact/NestedMathExactTest.java Changeset: 4d3575d37a07 Author: iveresov Date: 2013-10-30 22:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4d3575d37a07 8026735: Stream tests throw java.lang.IncompatibleClassChangeError Summary: Put a band-aid to disable CHA-based inlining for interfaces with default methods in C1 Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp + test/compiler/inlining/InlineDefaultMethod.java Changeset: 946a8294ab15 Author: iveresov Date: 2013-10-31 04:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/946a8294ab15 8024919: G1: SPECjbb2013 crashes due to a broken object reference Summary: Pass correct new value to post_barrer() in Unsafe.getAndSetObject() C1 intrinsic Reviewed-by: kvn, roland ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp Changeset: 2dcd0bd2920d Author: iveresov Date: 2013-10-31 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2dcd0bd2920d Merge Changeset: 0836a3c28c6a Author: iveresov Date: 2013-10-31 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0836a3c28c6a Merge Changeset: 3b32d287da89 Author: amurillo Date: 2013-11-01 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b32d287da89 Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: afd012c940e4 Author: amurillo Date: 2013-11-01 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/afd012c940e4 Added tag hs25-b57 for changeset 3b32d287da89 ! .hgtags Changeset: 9ebaac78a8a0 Author: amurillo Date: 2013-11-05 14:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ebaac78a8a0 Merge Changeset: 842b6ce4dfb4 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/842b6ce4dfb4 Added tag jdk8-b115 for changeset 9ebaac78a8a0 ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:57:08 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:57:08 +0000 Subject: hg: jdk8/tl/jdk: 70 new changesets Message-ID: <20131109051116.55949624A6@hg.openjdk.java.net> Changeset: 62982664dc72 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62982664dc72 Added tag jdk8-b114 for changeset f26a0c8071bd ! .hgtags Changeset: 180c05796c45 Author: bae Date: 2013-10-10 18:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/180c05796c45 7058618: PNG parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java Changeset: 0c2ba6a67b0d Author: morris Date: 2013-10-11 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c2ba6a67b0d 7195597: ThreadStateTest gets different results with -Xcomp Reviewed-by: kvn ! test/java/lang/Thread/ThreadStateTest.java Changeset: 124bffc749ea Author: lana Date: 2013-10-12 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/124bffc749ea Merge - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java - test/java/util/regex/PatternTest.java Changeset: 7ed340e7d894 Author: bae Date: 2013-10-14 15:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ed340e7d894 7058602: BMP parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java ! src/share/classes/com/sun/imageio/plugins/common/iio-plugin.properties ! src/share/classes/java/awt/image/ComponentSampleModel.java Changeset: cb9fa40f73f7 Author: bae Date: 2013-10-14 15:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb9fa40f73f7 7058607: GIF parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java Changeset: 478f7a9b3b12 Author: bae Date: 2013-10-14 16:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/478f7a9b3b12 7058611: JPG parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/jpeg/MarkerSegment.java ! src/share/classes/com/sun/imageio/plugins/jpeg/SOFMarkerSegment.java Changeset: b164c8eb1295 Author: jgodinez Date: 2013-10-14 09:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b164c8eb1295 8022536: closed/javax/print/TextFlavorTest.java fails Reviewed-by: prr, jchen ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! test/java/awt/print/PrinterJob/PrintLatinCJKTest.java + test/javax/print/TextFlavorTest.java Changeset: 8a59181b3c6d Author: vadim Date: 2013-10-15 08:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a59181b3c6d 8023590: REGRESSION: large count of graphics artifacts with Java 8 on Windows 8 on Intel HD card. Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 0df5cda89a50 Author: jchen Date: 2013-10-15 14:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0df5cda89a50 8025429: [parfait] warnings from b107 for sun.java2d.cmm: JNI exception pending Reviewed-by: prr, bae ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: c9c945cea665 Author: jgodinez Date: 2013-10-15 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9c945cea665 8015586: [macosx] Test closed/java/awt/print/PrinterJob/PrintToDir.java fails on MacOSX Reviewed-by: prr, jchen ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java + test/java/awt/print/PrinterJob/PrintToDir.java Changeset: 070e8ec9d82c Author: bae Date: 2013-10-16 17:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/070e8ec9d82c 8026702: Fix for 8025429 breaks jdk build on windows Reviewed-by: serb ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 73d212a3b2eb Author: jchen Date: 2013-10-16 14:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73d212a3b2eb 8024461: [macosx] Java crashed on mac10.9 for swing and 2d function manual test Reviewed-by: prr, vadim, serb ! src/share/native/sun/java2d/opengl/OGLBlitLoops.c Changeset: bcf8e9a59968 Author: jgodinez Date: 2013-10-18 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf8e9a59968 8025988: [macosx] Attribute settings don't work for JobAttributes range 8025990: [macosx] Attribute settings don't work for JobAttributes setOrientationRequested, setMedia Reviewed-by: prr, jchen ! src/macosx/native/sun/awt/CPrinterJob.m ! src/share/classes/sun/print/RasterPrinterJob.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java ! test/java/awt/PrintJob/SaveDialogTitleTest.java Changeset: 2a3e21fe9d0d Author: jgodinez Date: 2013-10-21 13:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a3e21fe9d0d 8026951: Fix for 8025988 breaks jdk build on windows Reviewed-by: prr, jchen ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 923f39485651 Author: bae Date: 2013-10-22 13:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/923f39485651 8026780: Crash on PPC and PPC v2 for Java_awt test suit Reviewed-by: prr, jchen ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 739ed3f0e796 Author: ceisserer Date: 2013-10-22 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/739ed3f0e796 8023483: sun/java2d/DirectX/TransformedPaintTest/TransformedPaintTest.java failed with jdk8 on linux platforms Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRBackend.java ! src/solaris/classes/sun/java2d/xr/XRBackendNative.java ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java ! src/solaris/classes/sun/java2d/xr/XRPaints.java ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c + test/java/awt/GradientPaint/GradientTransformTest.java + test/java/awt/GradientPaint/LinearColorSpaceGradientTest.java ! test/sun/java2d/DirectX/TransformedPaintTest/TransformedPaintTest.java Changeset: c55a8480cc27 Author: ceisserer Date: 2013-10-22 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c55a8480cc27 8023098: XRender : AlphaComposite test results are incorrect. Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/MaskTileManager.java ! src/solaris/classes/sun/java2d/xr/XRColor.java ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java ! src/solaris/classes/sun/java2d/xr/XRDrawImage.java ! src/solaris/classes/sun/java2d/xr/XRMaskBlit.java + src/solaris/classes/sun/java2d/xr/XRSolidSrcPict.java ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/classes/sun/java2d/xr/XRUtils.java Changeset: aca4a67e560d Author: vadim Date: 2013-10-23 08:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aca4a67e560d 8001173: [findbugs] Evaluate FindBug output for sun.font.CompositeFont, sun.font.CompositeFontDescriptor Reviewed-by: prr, bae ! src/share/classes/sun/font/StandardTextSource.java ! src/share/classes/sun/font/TextLabelFactory.java ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: 92af0666c168 Author: prr Date: 2013-10-23 08:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92af0666c168 8027169: Xrender: Cleaner version of the fix for 7159455 Nimbus scrollbar glitch Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRPMBlitLoops.java Changeset: d27525c346fa Author: lana Date: 2013-10-24 21:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d27525c346fa Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/net/HttpURLPermission.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 3371047f56f3 Author: lana Date: 2013-10-31 15:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3371047f56f3 Merge Changeset: 2e59014ef38f Author: alexsch Date: 2013-10-09 13:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e59014ef38f 8025649: need test to cover JDK-8000423 Reviewed-by: anthony, serb Contributed-by: Alexander Stepanov + test/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.html + test/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java Changeset: 84c766f6796b Author: bagiras Date: 2013-10-09 14:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84c766f6796b 8016356: Any swing frame resizes ugly. Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 929dc0915f8c Author: anthony Date: 2013-10-09 15:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/929dc0915f8c 7159266: [macosx] ApplicationDelegate should not be set in the headless mode Summary: Don't install ApplicationDelegate in headless mode Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m Changeset: 976e5f580124 Author: leonidr Date: 2013-10-09 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/976e5f580124 8019623: Lack of synchronization in AppContext.getAppContext() Reviewed-by: anthony, art ! src/share/classes/sun/awt/AppContext.java + test/sun/awt/AppContext/MultiThread/MultiThreadTest.java Changeset: fba62451d705 Author: leonidr Date: 2013-10-09 21:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fba62451d705 8016551: JMenuItem in WindowsLookAndFeel can't paint default icons Reviewed-by: alexsch, serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java + test/com/sun/java/swing/plaf/windows/8016551/bug8016551.java Changeset: cea6ca16142e Author: cl Date: 2013-10-09 14:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cea6ca16142e 8026021: more fix of javadoc errors and warnings reported by doclint, see the description Reviewed-by: anthony, serb ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/LinearGradientPaint.java ! src/share/classes/java/awt/RadialGradientPaint.java ! src/share/classes/java/awt/font/LineBreakMeasurer.java ! src/share/classes/java/awt/font/MultipleMaster.java ! src/share/classes/java/awt/font/NumericShaper.java ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/im/InputContext.java ! src/share/classes/javax/swing/Action.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java Changeset: 81ea6299230a Author: serb Date: 2013-10-10 02:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81ea6299230a 7058662: AiffFileReader throws java.lang.ArithmeticException: division by zero when frame size is zero 7058666: Unexpected exception in AU parser code 7058672: Unexpected exceptions and freezes in WAV parser code Reviewed-by: prr ! src/share/classes/com/sun/media/sound/AiffFileReader.java ! src/share/classes/com/sun/media/sound/AuFileReader.java ! src/share/classes/com/sun/media/sound/WaveFileReader.java + test/javax/sound/sampled/FileReader/ReadersExceptions.java Changeset: 857d6f78f241 Author: pchelko Date: 2013-10-10 11:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/857d6f78f241 8025588: [macosx] Frozen AppKit thread in 7u40 Reviewed-by: anthony, art, serb ! src/macosx/classes/sun/lwawt/macosx/CInputMethod.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/event/InvocationEvent.java ! src/share/classes/sun/awt/AWTAccessor.java Changeset: 31a156bae7cb Author: pchelko Date: 2013-10-10 19:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31a156bae7cb 8024864: [macosx] Problems with rendering of controls Reviewed-by: serb, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/java/awt/Paint/bug8024864.java Changeset: de36486eadd2 Author: pchelko Date: 2013-10-11 11:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de36486eadd2 8026143: [macosx] Maximized state could be inconsistent between peer and frame Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Frame/MaximizedByPlatform/MaximizedByPlatform.java Changeset: d96f9a8cf89a Author: kshefov Date: 2013-10-11 15:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d96f9a8cf89a 7124338: [macosx] Selection lost if a selected item removed from a java.awt.List Reviewed-by: serb, anthony + test/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html + test/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java Changeset: 2e04843f1c1d Author: art Date: 2013-10-11 16:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e04843f1c1d 8022185: Fix Raw and unchecked warnings in classes belonging to java.awt.datatransfer Reviewed-by: art, pchelko Contributed-by: Srikalyan Chandrashekar ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/awt/datatransfer/MimeTypeParameterList.java Changeset: 2f7f6995fa64 Author: pchelko Date: 2013-10-11 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f7f6995fa64 8026262: NPE in SystemFlavorMap.getAllNativesForType - regression in jdk8 b110 by fix of #JDK-8024987 Reviewed-by: art, serb ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java Changeset: af273c9b564a Author: pchelko Date: 2013-10-11 18:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af273c9b564a 8024329: [macosx] JRadioButtonMenuItem behaves like a checkbox when using the ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/classes/com/apple/laf/ScreenMenuItemCheckbox.java Changeset: f65895a2959e Author: lana Date: 2013-10-11 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f65895a2959e Merge - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java - test/java/util/regex/PatternTest.java Changeset: d874963706dc Author: yan Date: 2013-10-14 11:47 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d874963706dc 8025824: [cleanup] Fix tidy errors and warnings in preformatted HTML files related to 2d/awt/swing Reviewed-by: anthony, alexsch ! src/macosx/classes/com/apple/eawt/event/package.html ! src/macosx/classes/com/apple/eawt/package.html ! src/share/classes/java/awt/color/package.html ! src/share/classes/java/awt/datatransfer/package.html ! src/share/classes/java/awt/dnd/package.html ! src/share/classes/java/awt/doc-files/AWTThreadIssues.html ! src/share/classes/java/awt/doc-files/DesktopProperties.html ! src/share/classes/java/awt/doc-files/FocusSpec.html ! src/share/classes/java/awt/doc-files/Modality.html ! src/share/classes/java/awt/event/package.html ! src/share/classes/java/awt/font/package.html ! src/share/classes/java/awt/geom/package.html ! src/share/classes/java/awt/image/package.html ! src/share/classes/java/awt/image/renderable/package.html ! src/share/classes/java/awt/package.html ! src/share/classes/java/awt/print/package.html ! src/share/classes/javax/print/attribute/package.html ! src/share/classes/javax/print/attribute/standard/package.html ! src/share/classes/javax/print/event/package.html ! src/share/classes/javax/print/package.html ! src/share/classes/javax/swing/border/package.html ! src/share/classes/javax/swing/colorchooser/package.html ! src/share/classes/javax/swing/event/package.html ! src/share/classes/javax/swing/filechooser/package.html ! src/share/classes/javax/swing/plaf/basic/package.html ! src/share/classes/javax/swing/plaf/metal/package.html ! src/share/classes/javax/swing/plaf/multi/doc-files/multi_tsc.html ! src/share/classes/javax/swing/plaf/multi/package.html ! src/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html ! src/share/classes/javax/swing/plaf/nimbus/package.html ! src/share/classes/javax/swing/plaf/package.html ! src/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html ! src/share/classes/javax/swing/plaf/synth/package.html ! src/share/classes/javax/swing/table/package.html ! src/share/classes/javax/swing/text/html/package.html ! src/share/classes/javax/swing/text/html/parser/package.html ! src/share/classes/javax/swing/text/package.html ! src/share/classes/javax/swing/text/rtf/package.html ! src/share/classes/javax/swing/tree/package.html ! src/share/classes/javax/swing/undo/package.html Changeset: 69a17384fe22 Author: malenkov Date: 2013-10-14 13:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69a17384fe22 7165112: Incomprehensible garbage in doc for RootPaneContainer Reviewed-by: alexsch ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/RootPaneContainer.java Changeset: 9f49b055e983 Author: malenkov Date: 2013-10-14 13:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f49b055e983 7016396: (spec) JCK test mentioned in 6735293 is still failing Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/CompositeView.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/View.java Changeset: 54a6e22b749c Author: malenkov Date: 2013-10-14 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54a6e22b749c 7035495: javax.swing.ImageIcon spec should be clarified Reviewed-by: alexsch ! src/share/classes/javax/swing/ImageIcon.java Changeset: 5e0ed469c36a Author: alexsch Date: 2013-10-14 18:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e0ed469c36a 8005391: Floating behavior of HTMLEditorKit parser Reviewed-by: malenkov, leonidr Contributed-by: Alexander Shusherov ! src/share/classes/javax/swing/text/SimpleAttributeSet.java + test/javax/swing/text/html/8005391/bug8005391.java Changeset: 24fd0716d8d6 Author: alexsch Date: 2013-10-14 18:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24fd0716d8d6 8020708: NLS mnemonics missing in SwingSet2/JInternalFrame demo Reviewed-by: malenkov, leonidr ! src/share/classes/com/sun/java/swing/plaf/motif/MotifInternalFrameTitlePane.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameTitlePane.java + test/javax/swing/JInternalFrame/8020708/bug8020708.java Changeset: 9546631f14ca Author: serb Date: 2013-10-14 20:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9546631f14ca 8019591: JCK: testICSEthrowing_fullScreen fails: no ICSE thrown Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java + test/java/awt/Window/WindowGCInFullScreen/WindowGCInFullScreen.java Changeset: f9548641d699 Author: serb Date: 2013-10-15 20:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9548641d699 7059886: 6 JCK manual awt/Desktop tests fail with GTKLookAndFeel - GTK intialization issue Reviewed-by: anthony, art Contributed-by: alexander.zvegintsev at oracle.com + src/solaris/classes/sun/misc/GThreadHelper.java ! src/solaris/native/sun/awt/awt_UNIXToolkit.c ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/gtk2_interface.h ! src/solaris/native/sun/xawt/awt_Desktop.c Changeset: 89546b9be510 Author: serb Date: 2013-10-15 20:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89546b9be510 8025225: Window.setAlwaysOnTop documentation should be updated Reviewed-by: anthony, art Contributed-by: alexander.zvegintsev at oracle.com ! src/share/classes/java/awt/Window.java Changeset: 229b10e97bd2 Author: bagiras Date: 2013-10-16 19:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/229b10e97bd2 2228674: Fix failed for CR 7162144 Reviewed-by: art, anthony ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java Changeset: 70242d821c66 Author: serb Date: 2013-10-17 20:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70242d821c66 8022657: Add FunctionalInterface annotation to awt interfaces Reviewed-by: anthony, art ! src/share/classes/java/awt/KeyEventDispatcher.java ! src/share/classes/java/awt/KeyEventPostProcessor.java Changeset: 3c2d4569a6a3 Author: serb Date: 2013-10-17 21:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c2d4569a6a3 8026356: [macosx] Found one Java-level deadlock:"AWT-EventQueue-0" && main Reviewed-by: anthony, art ! src/share/classes/java/awt/Component.java Changeset: 5334c651c7ba Author: yan Date: 2013-10-18 15:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5334c651c7ba 7002846: Fix for 6989505 may be incomplete Reviewed-by: anthony, art Contributed-by: Andrei Eremeev ! src/windows/classes/sun/awt/windows/WRobotPeer.java ! src/windows/native/sun/windows/awt_Robot.cpp ! src/windows/native/sun/windows/awt_Robot.h Changeset: 84ae644933b6 Author: serb Date: 2013-10-18 20:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84ae644933b6 8026476: Choice does not get mouse events if it does not have enough place for popup menu Reviewed-by: anthony, serb Contributed-by: alexander.zvegintsev at oracle.com ! src/solaris/classes/sun/awt/X11/XChoicePeer.java Changeset: d72ca6dac444 Author: leonidr Date: 2013-10-22 16:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d72ca6dac444 8020209: [macosx] Mac OS X key event confusion for "COMMAND PLUS" Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/osxapp/NSApplicationAWT.m + test/java/awt/event/KeyEvent/8020209/bug8020209.java ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 4ad826a08e6f Author: serb Date: 2013-10-23 16:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad826a08e6f 8020851: java.awt.event.WindowEvent spec should state that WINDOW_CLOSED event may not be delivered under certain circumstances Reviewed-by: anthony, art ! src/share/classes/java/awt/event/WindowEvent.java Changeset: cd2e3c63ee42 Author: serb Date: 2013-10-24 14:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd2e3c63ee42 7090424: TestGlyphVectorLayout failed automately with java.lang.StackOverflowError Reviewed-by: anthony, art ! src/solaris/classes/sun/awt/X11/XButtonPeer.java ! src/solaris/classes/sun/awt/X11/XCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XLabelPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java + test/java/awt/Paint/ButtonRepaint.java + test/java/awt/Paint/CheckboxRepaint.java + test/java/awt/Paint/ExposeOnEDT.java + test/java/awt/Paint/LabelRepaint.java + test/java/awt/Paint/ListRepaint.java Changeset: 7c84aff91033 Author: pchelko Date: 2013-10-24 19:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c84aff91033 8027030: AWT Multiple JVM DnD Test Failing on Linux (OEL and Ubuntu) and Solaris (Sparc and x64) Reviewed-by: anthony, serb ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: c561db53a24c Author: pchelko Date: 2013-10-24 19:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c561db53a24c 8027025: [macosx] getLocationOnScreen returns 0 if parent invisible Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/Window/8027025/Test8027025.java Changeset: 6fe5443c3dde Author: alitvinov Date: 2013-10-25 13:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fe5443c3dde 8027066: XMLDecoder in java 7 cannot properly deserialize object arrays Reviewed-by: alexsch, malenkov Contributed-by: anton.nashatyrev at oracle.com ! src/share/classes/com/sun/beans/decoder/ArrayElementHandler.java + test/java/beans/XMLEncoder/Test8027066.java Changeset: 75ae2a980db5 Author: malenkov Date: 2013-10-25 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75ae2a980db5 8026705: [TEST_BUG] java/beans/Introspector/TestTypeResolver.java failed Reviewed-by: art, jfranck ! test/java/beans/Introspector/TestTypeResolver.java Changeset: dab1d3798016 Author: serb Date: 2013-10-25 19:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dab1d3798016 7172770: Default Toolkit implementation return null value for property "awt.dynamicLayoutSupported" Reviewed-by: anthony, art ! src/share/classes/java/awt/Toolkit.java Changeset: 162c57b874d4 Author: lana Date: 2013-10-25 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/162c57b874d4 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html ! src/share/classes/java/awt/datatransfer/DataFlavor.java - src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/sun/awt/AppContext.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 55cab2211ae9 Author: ant Date: 2013-10-29 16:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55cab2211ae9 8027157: [SwingNode] needs explicit expose for JWindow Reviewed-by: art, anthony ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WLightweightFramePeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: bedc29a6d074 Author: malenkov Date: 2013-10-29 17:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bedc29a6d074 8022746: List of spelling errors in API doc Reviewed-by: alexsch, smarks ! src/macosx/bundle/JavaAppLauncher/src/JVMArgs.m ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/AquaMenuPainter.java ! src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java ! src/macosx/classes/com/apple/laf/AquaTreeUI.java ! src/macosx/classes/java/net/DefaultInterface.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java ! src/macosx/classes/sun/font/CFontManager.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/CTextPipe.m ! src/share/back/commonRef.c ! src/share/back/eventFilter.c ! src/share/back/util.c ! src/share/classes/com/sun/beans/decoder/AccessorElementHandler.java ! src/share/classes/com/sun/beans/decoder/ArrayElementHandler.java ! src/share/classes/com/sun/beans/decoder/BooleanElementHandler.java ! src/share/classes/com/sun/beans/decoder/ByteElementHandler.java ! src/share/classes/com/sun/beans/decoder/CharElementHandler.java ! src/share/classes/com/sun/beans/decoder/ClassElementHandler.java ! src/share/classes/com/sun/beans/decoder/DoubleElementHandler.java ! src/share/classes/com/sun/beans/decoder/ElementHandler.java ! src/share/classes/com/sun/beans/decoder/FalseElementHandler.java ! src/share/classes/com/sun/beans/decoder/FieldElementHandler.java ! src/share/classes/com/sun/beans/decoder/FloatElementHandler.java ! src/share/classes/com/sun/beans/decoder/IntElementHandler.java ! src/share/classes/com/sun/beans/decoder/JavaElementHandler.java ! src/share/classes/com/sun/beans/decoder/LongElementHandler.java ! src/share/classes/com/sun/beans/decoder/MethodElementHandler.java ! src/share/classes/com/sun/beans/decoder/NewElementHandler.java ! src/share/classes/com/sun/beans/decoder/NullElementHandler.java ! src/share/classes/com/sun/beans/decoder/ObjectElementHandler.java ! src/share/classes/com/sun/beans/decoder/PropertyElementHandler.java ! src/share/classes/com/sun/beans/decoder/ShortElementHandler.java ! src/share/classes/com/sun/beans/decoder/StringElementHandler.java ! src/share/classes/com/sun/beans/decoder/TrueElementHandler.java ! src/share/classes/com/sun/beans/decoder/VarElementHandler.java ! src/share/classes/com/sun/beans/decoder/VoidElementHandler.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBES1Core.java ! src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java ! src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java ! src/share/classes/com/sun/imageio/plugins/common/StandardMetadataFormat.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsGraphicsUtils.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTextFieldUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTextUI.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/jdi/connect/ListeningConnector.java ! src/share/classes/com/sun/jdi/connect/spi/TransportService.java ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/TokenMgrError.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpErrorHandlerAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgentMBean.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpRequestTree.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpTableSupport.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServerMBean.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubNextRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubRequestHandler.java ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/Filter.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapName.java ! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java ! src/share/classes/com/sun/jndi/toolkit/dir/ContextEnumerator.java ! src/share/classes/com/sun/media/sound/AbstractMidiDevice.java ! src/share/classes/com/sun/media/sound/AudioSynthesizerPropertyInfo.java ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/SoftMixingSourceDataLine.java ! src/share/classes/com/sun/net/httpserver/Headers.java ! src/share/classes/com/sun/net/httpserver/HttpExchange.java ! src/share/classes/com/sun/net/ssl/internal/ssl/Provider.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/package.html ! src/share/classes/com/sun/security/auth/module/LdapLoginModule.java ! src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java ! src/share/classes/com/sun/tools/example/debug/expr/TokenMgrError.java ! src/share/classes/com/sun/tools/hat/resources/hat.js ! src/share/classes/com/sun/tools/jdi/SocketAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/SocketListeningConnector.java ! src/share/classes/com/sun/tools/jdi/ThreadListener.java ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/share/classes/java/awt/AWTEventMulticaster.java ! src/share/classes/java/awt/AlphaComposite.java ! src/share/classes/java/awt/BasicStroke.java ! src/share/classes/java/awt/BorderLayout.java ! src/share/classes/java/awt/CheckboxMenuItem.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Event.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/Graphics.java ! src/share/classes/java/awt/Graphics2D.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/MediaTracker.java ! src/share/classes/java/awt/MenuComponent.java ! src/share/classes/java/awt/MultipleGradientPaintContext.java ! src/share/classes/java/awt/Polygon.java ! src/share/classes/java/awt/PopupMenu.java ! src/share/classes/java/awt/RenderingHints.java ! src/share/classes/java/awt/ScrollPane.java ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/java/awt/Shape.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/datatransfer/FlavorMap.java ! src/share/classes/java/awt/datatransfer/MimeTypeParameterList.java ! src/share/classes/java/awt/dnd/DragGestureListener.java ! src/share/classes/java/awt/dnd/DragGestureRecognizer.java ! src/share/classes/java/awt/dnd/DragSourceContext.java ! src/share/classes/java/awt/dnd/DragSourceEvent.java ! src/share/classes/java/awt/dnd/DropTarget.java ! src/share/classes/java/awt/dnd/InvalidDnDOperationException.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/java/awt/font/FontRenderContext.java ! src/share/classes/java/awt/font/GlyphMetrics.java ! src/share/classes/java/awt/font/GlyphVector.java ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/java/awt/font/TextLayout.java ! src/share/classes/java/awt/font/TransformAttribute.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/awt/geom/Path2D.java ! src/share/classes/java/awt/geom/QuadCurve2D.java ! src/share/classes/java/awt/im/InputMethodRequests.java ! src/share/classes/java/awt/image/BandedSampleModel.java ! src/share/classes/java/awt/image/BufferStrategy.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/awt/image/ComponentColorModel.java ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/java/awt/image/ImageConsumer.java ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/java/awt/image/PixelInterleavedSampleModel.java ! src/share/classes/java/awt/image/renderable/RenderableImage.java ! src/share/classes/java/awt/image/renderable/RenderableImageOp.java ! src/share/classes/java/beans/AppletInitializer.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/PropertyEditorSupport.java ! src/share/classes/java/beans/beancontext/BeanContextChildSupport.java ! src/share/classes/java/beans/beancontext/BeanContextServiceRevokedListener.java ! src/share/classes/java/beans/beancontext/BeanContextServicesSupport.java ! src/share/classes/java/beans/beancontext/BeanContextSupport.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/ObjectStreamConstants.java ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/management/CompilationMXBean.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java ! src/share/classes/java/net/Authenticator.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/InetSocketAddress.java ! src/share/classes/java/net/InterfaceAddress.java ! src/share/classes/java/net/JarURLConnection.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/StandardSocketOptions.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/MembershipKey.java ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java ! src/share/classes/java/rmi/MarshalledObject.java ! src/share/classes/java/security/AccessControlException.java ! src/share/classes/java/security/DigestOutputStream.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/cert/CertificateRevokedException.java ! src/share/classes/java/security/spec/ECFieldF2m.java ! src/share/classes/java/sql/Array.java ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Clob.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DataTruncation.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/DriverPropertyInfo.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLException.java ! src/share/classes/java/sql/SQLFeatureNotSupportedException.java ! src/share/classes/java/sql/SQLIntegrityConstraintViolationException.java ! src/share/classes/java/sql/SQLInvalidAuthorizationSpecException.java ! src/share/classes/java/sql/SQLNonTransientConnectionException.java ! src/share/classes/java/sql/SQLNonTransientException.java ! src/share/classes/java/sql/SQLRecoverableException.java ! src/share/classes/java/sql/SQLSyntaxErrorException.java ! src/share/classes/java/sql/SQLTimeoutException.java ! src/share/classes/java/sql/SQLTransactionRollbackException.java ! src/share/classes/java/sql/SQLTransientConnectionException.java ! src/share/classes/java/sql/SQLTransientException.java ! src/share/classes/java/sql/SQLWarning.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Struct.java ! src/share/classes/java/sql/package.html ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/FieldPosition.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RuleBasedCollator.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/MissingFormatWidthException.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ExecutorCompletionService.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/share/classes/javax/accessibility/AccessibleText.java ! src/share/classes/javax/crypto/NullCipher.java ! src/share/classes/javax/crypto/NullCipherSpi.java ! src/share/classes/javax/imageio/IIOParam.java ! src/share/classes/javax/imageio/ImageIO.java ! src/share/classes/javax/imageio/ImageReader.java ! src/share/classes/javax/imageio/ImageWriteParam.java ! src/share/classes/javax/imageio/ImageWriter.java ! src/share/classes/javax/imageio/event/IIOReadProgressListener.java ! src/share/classes/javax/imageio/event/IIOReadUpdateListener.java ! src/share/classes/javax/imageio/event/IIOReadWarningListener.java ! src/share/classes/javax/imageio/event/IIOWriteWarningListener.java ! src/share/classes/javax/imageio/metadata/IIOMetadata.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormat.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormatImpl.java ! src/share/classes/javax/imageio/metadata/doc-files/standard_metadata.html ! src/share/classes/javax/imageio/spi/ImageReaderSpi.java ! src/share/classes/javax/imageio/spi/ImageReaderWriterSpi.java ! src/share/classes/javax/imageio/stream/ImageInputStream.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationServiceMBean.java ! src/share/classes/javax/management/remote/rmi/package.html ! src/share/classes/javax/naming/Binding.java ! src/share/classes/javax/naming/InsufficientResourcesException.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/net/ssl/SSLPeerUnverifiedException.java ! src/share/classes/javax/net/ssl/SSLSocket.java ! src/share/classes/javax/print/CancelablePrintJob.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/DocPrintJob.java ! src/share/classes/javax/print/MultiDoc.java ! src/share/classes/javax/print/PrintService.java ! src/share/classes/javax/print/attribute/standard/MediaTray.java ! src/share/classes/javax/print/attribute/standard/PresentationDirection.java ! src/share/classes/javax/print/attribute/standard/PrinterIsAcceptingJobs.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReason.java ! src/share/classes/javax/print/package.html ! src/share/classes/javax/script/AbstractScriptEngine.java ! src/share/classes/javax/script/CompiledScript.java ! src/share/classes/javax/script/Invocable.java ! src/share/classes/javax/script/ScriptEngine.java ! src/share/classes/javax/script/ScriptEngineFactory.java ! src/share/classes/javax/security/sasl/RealmChoiceCallback.java ! src/share/classes/javax/security/sasl/Sasl.java ! src/share/classes/javax/security/sasl/SaslClient.java ! src/share/classes/javax/security/sasl/SaslException.java ! src/share/classes/javax/smartcardio/CardChannel.java ! src/share/classes/javax/smartcardio/CardTerminal.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/MidiMessage.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/midi/ShortMessage.java ! src/share/classes/javax/sound/midi/Soundbank.java ! src/share/classes/javax/sound/midi/Synthesizer.java ! src/share/classes/javax/sound/sampled/AudioFormat.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/sound/sampled/ReverbType.java ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/JoinRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java ! src/share/classes/javax/sql/rowset/spi/TransactionalWriter.java ! src/share/classes/javax/sql/rowset/spi/XmlReader.java ! src/share/classes/javax/sql/rowset/spi/XmlWriter.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DefaultRowSorter.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JFormattedTextField.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/LookAndFeel.java ! src/share/classes/javax/swing/ProgressMonitor.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/ScrollPaneConstants.java ! src/share/classes/javax/swing/SpinnerDateModel.java ! src/share/classes/javax/swing/SpinnerModel.java ! src/share/classes/javax/swing/SpinnerNumberModel.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/ToolTipManager.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/event/DocumentEvent.java ! src/share/classes/javax/swing/event/HyperlinkEvent.java ! src/share/classes/javax/swing/event/TableModelEvent.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/filechooser/FileSystemView.java ! src/share/classes/javax/swing/plaf/ComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicBorders.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTableUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolTipUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTreeUI.java ! src/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java ! src/share/classes/javax/swing/plaf/nimbus/LoweredBorder.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html ! src/share/classes/javax/swing/table/DefaultTableColumnModel.java ! src/share/classes/javax/swing/table/JTableHeader.java ! src/share/classes/javax/swing/table/TableColumn.java ! src/share/classes/javax/swing/table/TableColumnModel.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/AbstractWriter.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/BoxView.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultHighlighter.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/DocumentFilter.java ! src/share/classes/javax/swing/text/ElementIterator.java ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/GapContent.java ! src/share/classes/javax/swing/text/GapVector.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/ParagraphView.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/WrappedPlainView.java ! src/share/classes/javax/swing/text/ZoneView.java ! src/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/share/classes/javax/swing/text/html/BlockView.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/CSSParser.java ! src/share/classes/javax/swing/text/html/FormSubmitEvent.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/FrameSetView.java ! src/share/classes/javax/swing/text/html/HTML.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/HTMLFrameHyperlinkEvent.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/javax/swing/text/html/ParagraphView.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/TableView.java ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src/share/classes/javax/swing/text/html/parser/DocumentParser.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/TreeModel.java ! src/share/classes/javax/swing/tree/TreeSelectionModel.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/javax/xml/crypto/KeySelector.java ! src/share/classes/javax/xml/crypto/MarshalException.java ! src/share/classes/javax/xml/crypto/dsig/TransformException.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignatureException.java ! src/share/classes/jdi-overview.html ! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java ! src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java ! src/share/classes/jdk/internal/util/xml/XMLStreamException.java ! src/share/classes/jdk/internal/util/xml/impl/Parser.java ! src/share/classes/org/ietf/jgss/GSSContext.java ! src/share/classes/org/ietf/jgss/GSSCredential.java ! src/share/classes/org/ietf/jgss/GSSException.java ! src/share/classes/org/ietf/jgss/GSSManager.java ! src/share/classes/org/ietf/jgss/GSSName.java ! src/share/classes/org/ietf/jgss/package.html ! src/share/classes/sun/applet/AppletSecurity.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/GlobalCursorManager.java ! src/share/classes/sun/awt/shell/ShellFolderManager.java ! src/share/classes/sun/dc/DuctusRenderingEngine.java ! src/share/classes/sun/font/ExtendedTextSourceLabel.java ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/FontRunIterator.java ! src/share/classes/sun/font/LayoutPathImpl.java ! src/share/classes/sun/font/ScriptRun.java ! src/share/classes/sun/font/StrikeCache.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/font/Type1Font.java ! src/share/classes/sun/java2d/SurfaceDataProxy.java ! src/share/classes/sun/java2d/loops/ProcessPath.java ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/pipe/BufferedMaskFill.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/BufferedTextPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/classes/sun/java2d/pipe/RenderingEngine.java ! src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventNotifier.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfDataBufferImpl.java ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/FileMonitoredVm.java ! src/share/classes/sun/management/counter/perf/InstrumentationException.java ! src/share/classes/sun/management/counter/perf/PerfDataType.java ! src/share/classes/sun/misc/CRC16.java ! src/share/classes/sun/misc/CharacterDecoder.java ! src/share/classes/sun/misc/PerformanceLogger.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/TelnetOutputStream.java ! src/share/classes/sun/net/ftp/FtpClient.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/idn/StringPrep.java ! src/share/classes/sun/net/smtp/SmtpProtocolException.java ! src/share/classes/sun/net/www/http/ChunkedInputStream.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/http/PosterOutputStream.java ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/print/PSPathGraphics.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/print/PathGraphics.java ! src/share/classes/sun/print/PrintJob2D.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/share/classes/sun/rmi/rmic/RemoteClass.java ! src/share/classes/sun/rmi/rmic/Util.java ! src/share/classes/sun/rmi/rmic/newrmic/jrmp/StubSkeletonWriter.java ! src/share/classes/sun/rmi/runtime/Log.java ! src/share/classes/sun/rmi/server/Activation.java ! src/share/classes/sun/rmi/transport/ObjectTable.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/rmi/transport/tcp/MultiplexOutputStream.java ! src/share/classes/sun/rmi/transport/tcp/TCPChannel.java ! src/share/classes/sun/security/jca/GetInstance.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5NameElement.java ! src/share/classes/sun/security/jgss/krb5/MessageToken.java ! src/share/classes/sun/security/jgss/spi/GSSContextSpi.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/internal/CredentialsUtil.java ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/share/classes/sun/security/krb5/internal/crypto/DesCbcEType.java ! src/share/classes/sun/security/pkcs11/P11DHKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java ! src/share/classes/sun/security/provider/DSA.java ! src/share/classes/sun/security/provider/certpath/AdjacencyList.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/rsa/RSAKeyPairGenerator.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/RSASignature.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/util/HostnameChecker.java ! src/share/classes/sun/security/x509/AlgIdDSA.java ! src/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/share/classes/sun/swing/plaf/synth/Paint9Painter.java ! src/share/classes/sun/text/normalizer/ReplaceableUCharacterIterator.java ! src/share/classes/sun/text/resources/th/CollationData_th.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jconsole/BorderedComponent.java ! src/share/classes/sun/tools/jconsole/inspector/XTextField.java ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jstat/ColumnFormat.java ! src/share/classes/sun/tools/jstat/resources/jstat_options ! src/share/classes/sun/tools/tree/ExprExpression.java ! src/share/classes/sun/tools/tree/FieldExpression.java ! src/share/classes/sun/util/locale/provider/RuleBasedBreakIterator.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! src/share/demo/jfc/Font2DTest/FontPanel.java ! src/share/demo/jfc/TableExample/TableExample4.java ! src/share/demo/jvmti/hprof/debug_malloc.c ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/javavm/export/jvm.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/share/native/com/sun/media/sound/PlatformMidi.h ! src/share/native/common/jni_util.h ! src/share/native/java/lang/fdlibm/src/k_rem_pio2.c ! src/share/native/java/util/zip/zip_util.c ! src/share/native/sun/awt/image/cvutils/img_dcm.h ! src/share/native/sun/awt/image/cvutils/img_replscale.h ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/image/jpeg/jpegdecoder.c ! src/share/native/sun/awt/libpng/CHANGES ! src/share/native/sun/awt/libpng/png.h ! src/share/native/sun/awt/libpng/pngconf.h ! src/share/native/sun/awt/libpng/pngpriv.h ! src/share/native/sun/awt/libpng/pngrutil.c ! src/share/native/sun/font/layout/ArabicLayoutEngine.h ! src/share/native/sun/font/layout/IndicReordering.h ! src/share/native/sun/font/layout/KhmerReordering.cpp ! src/share/native/sun/font/layout/OpenTypeLayoutEngine.h ! src/share/native/sun/font/layout/TibetanReordering.cpp ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! src/share/native/sun/java2d/cmm/lcms/cmslut.c ! src/share/native/sun/java2d/loops/ProcessPath.c ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sessmgmt.c ! src/share/sample/jmx/jmx-scandir/index.html ! src/share/sample/nio/chatserver/ClientReader.java ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/solaris/classes/java/net/DefaultInterface.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XMenuItemPeer.java ! src/solaris/classes/sun/awt/X11/XScrollbar.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/font/XMap.java ! src/solaris/classes/sun/java2d/jules/JulesAATileGenerator.java ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixUriUtils.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/demo/jni/Poller/Poller.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_BsdOS_ALSA_Ports.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_PCM.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_Utils.h ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/multiVis.c ! src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite.h ! src/windows/classes/com/sun/tools/jdi/SharedMemoryAttachingConnector.java ! src/windows/classes/com/sun/tools/jdi/SharedMemoryListeningConnector.java ! src/windows/classes/java/net/DefaultInterface.java ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java ! src/windows/native/java/io/canonicalize_md.c ! src/windows/native/java/net/DualStackPlainSocketImpl.c ! src/windows/native/java/net/icmp.h ! src/windows/native/sun/font/fontpath.c ! src/windows/native/sun/java2d/d3d/D3DTextRenderer.cpp ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp ! src/windows/native/sun/nio/ch/SocketChannelImpl.c ! src/windows/native/sun/security/krb5/NativeCreds.c ! src/windows/native/sun/windows/ThemeReader.cpp ! src/windows/native/sun/windows/awt_BitmapUtil.cpp ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Dialog.h ! src/windows/native/sun/windows/awt_DnDDS.cpp ! src/windows/native/sun/windows/awt_Font.h ! src/windows/native/sun/windows/awt_InputTextInfor.cpp ! src/windows/native/sun/windows/awt_PrintJob.cpp ! src/windows/native/sun/windows/awt_TextComponent.cpp Changeset: d4eb25382baf Author: malenkov Date: 2013-10-29 19:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4eb25382baf 8027442: JDK compilation fails on MacOS Reviewed-by: alexsch, pchelko ! src/share/classes/java/awt/Component.java Changeset: a2b42e558211 Author: bagiras Date: 2013-10-29 21:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2b42e558211 8027151: AWT_DnD/Basic_DnD/Automated/DnDMerlinQL/MultipleJVM failing on windows machine Reviewed-by: anthony, pchelko ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java Changeset: db2838f25a85 Author: pchelko Date: 2013-10-30 12:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db2838f25a85 8027152: Regression: test closed/java/awt/Serialize/NullSerializationTest/NullSerializationTest.html fails since JDK 8 b112 Reviewed-by: art, serb ! src/share/classes/java/awt/Window.java + test/java/awt/Window/OwnedWindowsSerialization/OwnedWindowsSerialization.java Changeset: 05f04b1c5bd0 Author: leonidr Date: 2013-10-30 20:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05f04b1c5bd0 8013581: [macosx] Key Bindings break with awt GraphicsEnvironment setFullScreenWindow Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformLWView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CWrapper.m + test/java/awt/FullScreen/8013581/bug8013581.java Changeset: 6f436140049d Author: lana Date: 2013-10-31 16:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f436140049d Merge ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: f82b730c798b Author: lana Date: 2013-10-31 16:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f82b730c798b Merge - src/share/classes/java/lang/invoke/MagicLambdaImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/tools/jar/Main.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties ! src/share/javavm/export/jvm.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/solaris/classes/sun/nio/fs/UnixPath.java - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: a389b4f5723f Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a389b4f5723f Added tag jdk8-b115 for changeset f82b730c798b ! .hgtags Changeset: a579e2f73bca Author: lana Date: 2013-11-08 17:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a579e2f73bca Merge ! src/share/classes/java/lang/invoke/MethodType.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! test/java/lang/Thread/ThreadStateTest.java From jan.lahoda at oracle.com Sat Nov 9 06:30:13 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Sat, 09 Nov 2013 14:30:13 +0000 Subject: hg: jdk8/tl/langtools: 8027142: Invokedynamic instructions don't get line number table entries Message-ID: <20131109143017.187C7624B8@hg.openjdk.java.net> Changeset: 6e0f31d61e56 Author: jlahoda Date: 2013-11-09 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e0f31d61e56 8027142: Invokedynamic instructions don't get line number table entries Summary: When emitting invokedynamic instruction, write pendingStatPos, if set, into the LineNumberTable. Invokedynamic itself does not set the pendingStatPos. Reviewed-by: jjg, jrose, ksrini, vromero ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! test/tools/javac/T8019486/WrongLNTForLambdaTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java From alan.bateman at oracle.com Sat Nov 9 08:48:10 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 09 Nov 2013 16:48:10 +0000 Subject: hg: jdk8/tl/jdk: 8028044: [TEST_BUG] Calendar shell tests do not pass TESTVMOPTS Message-ID: <20131109164823.E49F0624BB@hg.openjdk.java.net> Changeset: 9130770fb6e3 Author: alanb Date: 2013-11-09 16:46 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9130770fb6e3 8028044: [TEST_BUG] Calendar shell tests do not pass TESTVMOPTS Reviewed-by: dholmes, alanb Contributed-by: patrick.zhang at oracle.com ! test/java/util/Calendar/GenericTimeZoneNamesTest.sh ! test/java/util/Calendar/NarrowNamesTest.sh From roger.riggs at oracle.com Sat Nov 9 11:32:24 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Sat, 09 Nov 2013 19:32:24 +0000 Subject: hg: jdk8/tl/jdk: 8028092: Lint cleanup of java.time.format Message-ID: <20131109193236.7865F624BE@hg.openjdk.java.net> Changeset: 3add16c86970 Author: rriggs Date: 2013-11-09 14:30 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3add16c86970 8028092: Lint cleanup of java.time.format Summary: correct declarations and add @SuppressWarnings Reviewed-by: darcy, lancea ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/Parsed.java From jaroslav.bachorik at oracle.com Sun Nov 10 11:07:18 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Sun, 10 Nov 2013 19:07:18 +0000 Subject: hg: jdk8/tl/jdk: 6523160: RuntimeMXBean.getUptime() returns negative values Message-ID: <20131110190730.17488624D7@hg.openjdk.java.net> Changeset: 0c75cc07d264 Author: jbachorik Date: 2013-11-10 20:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c75cc07d264 6523160: RuntimeMXBean.getUptime() returns negative values Summary: RuntimeMXBean.getUptime() should be based on HR timers rather than on the OS time Reviewed-by: dholmes, sla ! make/java/management/mapfile-vers ! makefiles/mapfiles/libmanagement/mapfile-vers ! src/share/classes/sun/management/RuntimeImpl.java ! src/share/classes/sun/management/VMManagement.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/javavm/export/jmm.h ! src/share/native/sun/management/VMManagementImpl.c ! test/java/lang/management/RuntimeMXBean/UpTime.java From bill.pittore at oracle.com Sun Nov 10 10:57:12 2013 From: bill.pittore at oracle.com (Bill Pittore) Date: Sun, 10 Nov 2013 10:57:12 -0800 (PST) Subject: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument In-Reply-To: <527DA1C2.6020500@oracle.com> References: <527D0C95.8050605@oracle.com> <527DA1C2.6020500@oracle.com> Message-ID: <527FD708.9050607@oracle.com> I think that's a good idea since we now have the distinct possibility of the class not being available in certain profiles. I'll re-do the change and send out a new webrev. thanks, bill On 11/8/2013 9:45 PM, Mandy Chung wrote: > > On 11/8/2013 8:08 AM, bill.pittore at oracle.com wrote: >> If you are running a non-minimal VM build with compact 1 or 2 JRE and >> you pass in -Dcom.sun.management argument, VM will exit silently with >> exit code 1. Fix adds an error check when attempting to load the >> class sun.management.Agent (missing from compact 1 and 2) and will >> print a message before exiting. >> >> http://cr.openjdk.java.net/~bpittore/8027914/webrev.00/ >> > > Since sun.management.Agent is not always present, would it better to > change to call resolve_or_null and check the returned Klass? > > Mandy From Alan.Bateman at oracle.com Sun Nov 10 12:30:01 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sun, 10 Nov 2013 20:30:01 +0000 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public In-Reply-To: <527D07CA.8040703@oracle.com> References: <527C250B.5000507@oracle.com> <527CA360.8060403@oracle.com> <527CE57A.20808@oracle.com> <527D07CA.8040703@oracle.com> Message-ID: <527FECC9.4050507@oracle.com> On 08/11/2013 15:48, Mandy Chung wrote: > Thanks you all for the review. > > I'll rename AbstractOperatingSystemImpl before I push. > > Mandy I think there is a problem with the change that was pushed. The Windows implementation of OperatingSystemImpl now implements java.lang.management.OperatingSystemMXBean whereas it actually implements com.sun.management.OperatingSystemMXBean. This causes a number of management tests to fail (only on Windows). If you agree then I'd like to fix it up with the attached patch to get the tests passing on Windows again. -Alan. diff --git a/src/windows/classes/sun/management/OperatingSystemImpl.java b/src/windows/classes/sun/management/OperatingSystemImpl.java --- a/src/windows/classes/sun/management/OperatingSystemImpl.java +++ b/src/windows/classes/sun/management/OperatingSystemImpl.java @@ -25,7 +25,7 @@ package sun.management; -import java.lang.management.OperatingSystemMXBean; +import com.sun.management.OperatingSystemMXBean; /** * Implementation class for the operating system. From mandy.chung at oracle.com Sun Nov 10 20:47:21 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Sun, 10 Nov 2013 20:47:21 -0800 Subject: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public In-Reply-To: <527FECC9.4050507@oracle.com> References: <527C250B.5000507@oracle.com> <527CA360.8060403@oracle.com> <527CE57A.20808@oracle.com> <527D07CA.8040703@oracle.com> <527FECC9.4050507@oracle.com> Message-ID: <52806159.9030101@oracle.com> On 11/10/2013 12:30 PM, Alan Bateman wrote: > On 08/11/2013 15:48, Mandy Chung wrote: >> Thanks you all for the review. >> >> I'll rename AbstractOperatingSystemImpl before I push. >> >> Mandy > > I think there is a problem with the change that was pushed. The > Windows implementation of OperatingSystemImpl now implements > java.lang.management.OperatingSystemMXBean whereas it actually > implements com.sun.management.OperatingSystemMXBean. This causes a > number of management tests to fail (only on Windows). If you agree > then I'd like to fix it up with the attached patch to get the tests > passing on Windows again. Thanks for fixing it. The patch looks good. Mandy > > -Alan. > > > diff --git > a/src/windows/classes/sun/management/OperatingSystemImpl.java > b/src/windows/classes/sun/management/OperatingSystemImpl.java > --- a/src/windows/classes/sun/management/OperatingSystemImpl.java > +++ b/src/windows/classes/sun/management/OperatingSystemImpl.java > @@ -25,7 +25,7 @@ > > package sun.management; > > -import java.lang.management.OperatingSystemMXBean; > +import com.sun.management.OperatingSystemMXBean; > > /** > * Implementation class for the operating system. From alan.bateman at oracle.com Mon Nov 11 00:39:34 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 11 Nov 2013 08:39:34 +0000 Subject: hg: jdk8/tl/jdk: 8028099: Many com/sun/management/OperatingSystemMXBean tests failing with CCE (win) Message-ID: <20131111083948.C6350624E3@hg.openjdk.java.net> Changeset: 2525b91ca5a6 Author: alanb Date: 2013-11-11 08:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2525b91ca5a6 8028099: Many com/sun/management/OperatingSystemMXBean tests failing with CCE (win) Reviewed-by: mchung ! src/windows/classes/sun/management/OperatingSystemImpl.java From weijun.wang at oracle.com Mon Nov 11 00:56:02 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 11 Nov 2013 08:56:02 +0000 Subject: hg: jdk8/tl/jdk: 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main Message-ID: <20131111085614.8B424624E4@hg.openjdk.java.net> Changeset: 7304b3195212 Author: weijun Date: 2013-11-11 16:54 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7304b3195212 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main Reviewed-by: xuelei ! src/share/classes/sun/security/tools/jarsigner/Main.java + test/sun/security/tools/jarsigner/CertChainUnclosed.java From taras.ledkov at oracle.com Mon Nov 11 01:17:27 2013 From: taras.ledkov at oracle.com (taras ledkov) Date: Mon, 11 Nov 2013 13:17:27 +0400 Subject: RFR for JDK-7195249 Some jtreg tests use hard coded ports In-Reply-To: <527A4C6D.8040804@oracle.com> References: <527A4C6D.8040804@oracle.com> Message-ID: <5280A0A7.5080004@oracle.com> Hi Everyone I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. After a conversation with Jaroslav Bachorik, the suggested fix for sun/management/jmxremote/bootstrap/RmiBootstrapTest.java consists in replacing errStr = testConfiguration(file,port+testPort++); and errStr = testConfigurationKo(conf[i],port+testPort++); with errStr = testConfiguration(file,jdk.testlibrary.Utils.getFreePort()); errStr = testConfigurationKo(conf[i],jdk.testlibrary.Utils.getFreePort()); Selecting a range of ports is more error prone than selecting ports one by one. Please let me know if you see anything wrong with this fix. Taras -- With best regards, Taras Ledkov Mail-To: taras.ledkov at oracle.com skype: taras_ledkov Phone: 7(812)3346-157 From staffan.larsen at oracle.com Mon Nov 11 01:32:12 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 10:32:12 +0100 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: <5277FEA3.4010101@oracle.com> References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> <5277FEA3.4010101@oracle.com> Message-ID: Thanks Serguei! Can I have an official Review as well? /Staffan On 04 Nov 2013, at 21:08, serguei.spitsyn at oracle.com wrote: > Staffan, > > This one is really old: 11+ years. :) > The fix is good, I do not see any issues. > > Thanks, > Serguei > > > On 11/4/13 6:41 AM, Staffan Larsen wrote: >> This is an old one! Nothing like being bored on a plane... >> >> The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints. >> >> While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored). >> >> There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done. >> >> webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ >> bug: https://bugs.openjdk.java.net/browse/JDK-4660158 >> >> Thanks, >> /Staffan > From chris.hegarty at oracle.com Mon Nov 11 02:34:18 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 11 Nov 2013 10:34:18 +0000 Subject: hg: jdk8/tl/jdk: 8028102: All test targets, jdk/test/Makefile, fail on Windows Message-ID: <20131111103441.A2965624F0@hg.openjdk.java.net> Changeset: b48eded97dff Author: chegar Date: 2013-11-11 10:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b48eded97dff 8028102: All test targets, jdk/test/Makefile, fail on Windows Reviewed-by: mduigou ! test/Makefile From staffan.larsen at oracle.com Mon Nov 11 05:19:08 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 14:19:08 +0100 Subject: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature In-Reply-To: <527D2323.8080403@oracle.com> References: <51A31867.9080602@oracle.com> <51CAC09B.7070706@oracle.com> <7E2E50A8-1FB1-429B-8AAB-94863C215623@oracle.com> <51D56A11.5030600@oracle.com> <5214AC0A.4010603@oracle.com> <70F043F0-9F19-4761-B175-1D6652B5A146@oracle.com> <3B20B5DC-9E92-4EB6-97FF-0F2D2B4E1E10@oracle.com> <52244497.8010902@oracle.com> <5267C65A.9060602@oracle.com> <4EDB8911-E772-4B13-B0EB-AA90C729A49A@oracle.com> <526FCC02.3050308@oracle.com> <527D0B02.6040705@oracle.com> <527D2323.8080403@oracle.com> Message-ID: Why are there changes to the existing tests? Most look like whitespace changes, but JdpTest.sh changes the ?testsuites? that are being run. /Staffan On 08 Nov 2013, at 18:45, Mikael Auno wrote: > There was some unintended whitespace changes in webrev.05 that Alex had missed. I removed them and uploaded webrev.06 for him. > > http://cr.openjdk.java.net/~miauno/8014506/webrev.06/ > > Mikael > > On 2013-11-08 17:02, Alex Schenkman wrote: >> Hi list, >> >> Latest version is up for review here [1]. >> It fixes Staffan's latest comments (see below), as well as some >> indentation and tab/spaces nits. >> >> Thanks! >> >> [1] http://cr.openjdk.java.net/~miauno/8014506/ >> >> >> On 2013-10-30 16:03, Staffan Larsen wrote: >>> Alex, >>> >>> This looks much better! Thanks for spending the time. >>> >>> README: >>> nit: contribuited -> contributed >>> >>> JdpTestUtilTest.java: >>> Can you add a comment saying this is a test for the tests - just >>> like PacketTest.java and PortAlreadyInUseTest.java? >>> >>> PortFinder.java: >>> Please remove this and use Utils.getFreePort() since ykantser's fix >>> is now pushed. >>> >>> Thanks, >>> /Staffan >>> >>> On 29 okt 2013, at 15:53, Alex Schenkman >> > wrote: >>> >>>> Hi Staffan, >>>> >>>> There is a new webrev here [1], addressing your comments. >>>> >>>> The Jdp specs have changed a bit, adding three optional fields to the >>>> Jdp packet [2]. >>>> The JEP-168 [3] is not updated yet, but Dmitry will do it soon. >>>> This enhancement request is tracking the changes needed for SQE [4]. >>>> >>>> See inlined answers for details on your previos comments, please. >>>> >>>> Thanks! >>>> >>>> >>>> [1] >>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/aschenkman/8014506/webrev.04/ >>>> >>>> [2] https://bugs.openjdk.java.net/browse/JDK-8004213 >>>> [3] http://openjdk.java.net/jeps/168 >>>> [4] https://bugs.openjdk.java.net/browse/JDK-8027436 >>>> >>>> On 2013-10-24 10:54, Staffan Larsen wrote: >>>>> Alex, >>>>> >>>>> test/sun/management/jdp/README >>>>> Thanks for providing a README! >>>>> References to JDK-7169888 seem incorrect to me. >>>>> L8: "written by" appears twice. >>>>> L11: "defautl" -> "default" >>>>> >>>> Fixed. >>>>> test/lib/testlibrary/jdk/testlibrary/PortFinder.java >>>>> This should be coordinated with the review for 8022229 which >>>>> contains the same code in a different testlibrary class: >>>>> http://cr.openjdk.java.net/~ykantser/8022229/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html >>>>> >>>>> >>>> I made a private copy of this function, and have marked it as deprecated. >>>> As soon as ykanster's code is merged I can delete my private function >>>> and use the library. >>>> The reason for this is to get this patch pushed without further delay. >>>> >>>>> test/sun/management/jdp/7169888/JdpClient.java >>>>> test/sun/management/jdp/7169888/JdpDoSomething.java >>>>> test/sun/management/jdp/7169888/JdpTest.sh >>>>> test/sun/management/jdp/7169888/JdpUnitTest.java >>>>> These were moved to a subdirectory, but these tests have nothing >>>>> to do with bug 7169888, so why that name? In any case we should >>>>> avoid naming test directories after bug ids, and instead use a >>>>> descriptive name. >>>>> >>>> This bug number was wrong. These tests were now moved back to the jdp >>>> folder. >>>> I have expanded the README file with some details about these tests. >>>> >>>> Dmitry's shell-based are as follows: >>>> test_01 - basic test, check if JDP packet assembler and other >>>> parts of JDP is not broken >>>> >>>> test_02 - test if JDP starts with custom parameters. >>>> >>>> test_03 - test if jcmd is able to start jdp with >>>> custom parameters (disabled) >>>> >>>> test_04 - test if JDP starts with default parameters >>>> >>>> test_05 - test if jcmd is able to start jdp with default >>>> parameters (disabled) >>>> >>>> >>>> test_03 and test_05 are diabled becuase there is a mismatch between >>>> hotsport and jdk repos, according to Dmitry. These cases (jcmd) are >>>> not covered by this patch, and are part of the test enhacements [4]. >>>> >>>> test_01 does partly overlap with the Java-based tests, but we should >>>> keep it until we implement the latest enhacements [4]. >>>> >>>> >>>>> test/sun/management/jdp/ClientConnection.java >>>>> No comments. >>>>> >>>>> test/sun/management/jdp/DefaultLauncher.java >>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>> /lib/testlibrary" ? >>>>> >>>> Fixed. >>>>> test/sun/management/jdp/OffLauncher.java >>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>> /lib/testlibrary" ? >>>>> >>>> Fixed. >>>> >>>>> test/sun/management/jdp/SpecificJdpAddressLauncher.java >>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>> /lib/testlibrary" ? >>>>> >>>> Fixed. >>>>> test/sun/management/jdp/DynamicLauncher.java >>>>> No comments. >>>>> >>>> Fixed. >>>> >>>>> test/sun/management/jdp/JdpOffTest.java >>>>> For the future: it is customary that the file containing the jtreg >>>>> directives be named xxxTest.java, and supporting files not ending in >>>>> Test. >>>>> >>>> I have renamed the tests following your recomendation. >>>> Jtreg tests have now the test suffix. >>>> >>>>> test/sun/management/jdp/JdpOnTest.java >>>>> For the future: it is customary that the file containing the jtreg >>>>> directives be named xxxTest.java, and supporting files not ending in >>>>> Test. >>>>> >>>> Same as above. >>>>> test/sun/management/jdp/JdpTest.java >>>>> No comments. >>>>> >>>>> test/sun/management/jdp/JdpTestUtil.java >>>>> No comments. >>>>> >>>>> test/sun/management/jdp/JdpTestUtilTest.java >>>>> test/sun/management/jdp/PacketTest.java >>>>> test/sun/management/jdp/PortAlreadyInUseTest.java >>>>> These are tests for the tests. But where are the tests for the >>>>> tests for the tests? :) >>>>> Not reviewed. >>>>> >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>> >>> >> >> -- >> Alex Schenkman >> Java VM SQE Stockholm -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/2c20ea15/attachment-0001.html From staffan.larsen at oracle.com Mon Nov 11 05:23:47 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 14:23:47 +0100 Subject: Removal of sample code from tools.jar In-Reply-To: <20131108133947.GB3185@e6430> References: <20131108133947.GB3185@e6430> Message-ID: I put a comment in the bug report. In essence this package contains the code for the ?jdb? command line debugger which is shipped as a supported tool in the JDK. I don?t think we can simply remove it. /Staffan On 08 Nov 2013, at 14:39, Andreas Lundblad wrote: > Regarding bug JDK-8008602: Sample code in tools.jar. > > Does anyone have any insight in whether or not the JPDA example code in com.sun.tools.example.** should be kept, or if should be removed altogether? > > AFAIK no code outside of the example package depends upon it. The build does however fail with > > "make[2]: *** No rule to make target `.../tl/jdk/src/share/classes/com/sun/tools/example/README', needed by `.../tl/build/linux-x86_64-normal-server-release/jdk/demo/jpda/com/sun/tools/example/README'. Stop." > > and I can't find the reason while browsing / grepping in the make files. > > Any input on the matter would be greately appreciated. > > best regardrs, > Andreas Lundblad From mikael.auno at oracle.com Mon Nov 11 05:57:53 2013 From: mikael.auno at oracle.com (Mikael Auno) Date: Mon, 11 Nov 2013 14:57:53 +0100 Subject: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature In-Reply-To: References: <51A31867.9080602@oracle.com> <51CAC09B.7070706@oracle.com> <7E2E50A8-1FB1-429B-8AAB-94863C215623@oracle.com> <51D56A11.5030600@oracle.com> <5214AC0A.4010603@oracle.com> <70F043F0-9F19-4761-B175-1D6652B5A146@oracle.com> <3B20B5DC-9E92-4EB6-97FF-0F2D2B4E1E10@oracle.com> <52244497.8010902@oracle.com> <5267C65A.9060602@oracle.com> <4EDB8911-E772-4B13-B0EB-AA90C729A49A@oracle.com> <526FCC02.3050308@oracle.com> <527D0B02.6040705@oracle.com> <527D2323.8080403@oracle.com> Message-ID: <5280E261.1070800@oracle.com> The reduction in testsuites in JdpTest.sh is due to those "testsuites" removed being ported to Java with this change. The last "testsuite" in JdpTest.sh however, has not been ported yet, therefore JdpTest.sh can't be removed completely. Mikael On 2013-11-11 14:19, Staffan Larsen wrote: > Why are there changes to the existing tests? Most look like whitespace > changes, but JdpTest.sh changes the ?testsuites? that are being run. > > /Staffan > > On 08 Nov 2013, at 18:45, Mikael Auno > wrote: > >> There was some unintended whitespace changes in webrev.05 that Alex >> had missed. I removed them and uploaded webrev.06 for him. >> >> http://cr.openjdk.java.net/~miauno/8014506/webrev.06/ >> >> Mikael >> >> On 2013-11-08 17:02, Alex Schenkman wrote: >>> Hi list, >>> >>> Latest version is up for review here [1]. >>> It fixes Staffan's latest comments (see below), as well as some >>> indentation and tab/spaces nits. >>> >>> Thanks! >>> >>> [1]http://cr.openjdk.java.net/~miauno/8014506/ >>> >>> >>> On 2013-10-30 16:03, Staffan Larsen wrote: >>>> Alex, >>>> >>>> This looks much better! Thanks for spending the time. >>>> >>>> README: >>>> nit: contribuited -> contributed >>>> >>>> JdpTestUtilTest.java: >>>> Can you add a comment saying this is a test for the tests - just >>>> like PacketTest.java and PortAlreadyInUseTest.java? >>>> >>>> PortFinder.java: >>>> Please remove this and use Utils.getFreePort() since ykantser's fix >>>> is now pushed. >>>> >>>> Thanks, >>>> /Staffan >>>> >>>> On 29 okt 2013, at 15:53, Alex Schenkman >>> >>>> > wrote: >>>> >>>>> Hi Staffan, >>>>> >>>>> There is a new webrev here [1], addressing your comments. >>>>> >>>>> The Jdp specs have changed a bit, adding three optional fields to the >>>>> Jdp packet [2]. >>>>> The JEP-168 [3] is not updated yet, but Dmitry will do it soon. >>>>> This enhancement request is tracking the changes needed for SQE [4]. >>>>> >>>>> See inlined answers for details on your previos comments, please. >>>>> >>>>> Thanks! >>>>> >>>>> >>>>> [1] >>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/aschenkman/8014506/webrev.04/ >>>>> >>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8004213 >>>>> [3] http://openjdk.java.net/jeps/168 >>>>> [4] https://bugs.openjdk.java.net/browse/JDK-8027436 >>>>> >>>>> On 2013-10-24 10:54, Staffan Larsen wrote: >>>>>> Alex, >>>>>> >>>>>> test/sun/management/jdp/README >>>>>> Thanks for providing a README! >>>>>> References to JDK-7169888 seem incorrect to me. >>>>>> L8: "written by" appears twice. >>>>>> L11: "defautl" -> "default" >>>>>> >>>>> Fixed. >>>>>> test/lib/testlibrary/jdk/testlibrary/PortFinder.java >>>>>> This should be coordinated with the review for 8022229 which >>>>>> contains the same code in a different testlibrary class: >>>>>> http://cr.openjdk.java.net/~ykantser/8022229/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html >>>>>> >>>>>> >>>>> I made a private copy of this function, and have marked it as >>>>> deprecated. >>>>> As soon as ykanster's code is merged I can delete my private function >>>>> and use the library. >>>>> The reason for this is to get this patch pushed without further delay. >>>>> >>>>>> test/sun/management/jdp/7169888/JdpClient.java >>>>>> test/sun/management/jdp/7169888/JdpDoSomething.java >>>>>> test/sun/management/jdp/7169888/JdpTest.sh >>>>>> test/sun/management/jdp/7169888/JdpUnitTest.java >>>>>> These were moved to a subdirectory, but these tests have nothing >>>>>> to do with bug 7169888, so why that name? In any case we should >>>>>> avoid naming test directories after bug ids, and instead use a >>>>>> descriptive name. >>>>>> >>>>> This bug number was wrong. These tests were now moved back to the jdp >>>>> folder. >>>>> I have expanded the README file with some details about these tests. >>>>> >>>>> Dmitry's shell-based are as follows: >>>>> test_01 - basic test, check if JDP packet assembler and other >>>>> parts of JDP is not broken >>>>> >>>>> test_02 - test if JDP starts with custom parameters. >>>>> >>>>> test_03 - test if jcmd is able to start jdp with >>>>> custom parameters (disabled) >>>>> >>>>> test_04 - test if JDP starts with default parameters >>>>> >>>>> test_05 - test if jcmd is able to start jdp with default >>>>> parameters (disabled) >>>>> >>>>> >>>>> test_03 and test_05 are diabled becuase there is a mismatch between >>>>> hotsport and jdk repos, according to Dmitry. These cases (jcmd) are >>>>> not covered by this patch, and are part of the test enhacements [4]. >>>>> >>>>> test_01 does partly overlap with the Java-based tests, but we should >>>>> keep it until we implement the latest enhacements [4]. >>>>> >>>>> >>>>>> test/sun/management/jdp/ClientConnection.java >>>>>> No comments. >>>>>> >>>>>> test/sun/management/jdp/DefaultLauncher.java >>>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>>> /lib/testlibrary" ? >>>>>> >>>>> Fixed. >>>>>> test/sun/management/jdp/OffLauncher.java >>>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>>> /lib/testlibrary" ? >>>>>> >>>>> Fixed. >>>>> >>>>>> test/sun/management/jdp/SpecificJdpAddressLauncher.java >>>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>>> /lib/testlibrary" ? >>>>>> >>>>> Fixed. >>>>>> test/sun/management/jdp/DynamicLauncher.java >>>>>> No comments. >>>>>> >>>>> Fixed. >>>>> >>>>>> test/sun/management/jdp/JdpOffTest.java >>>>>> For the future: it is customary that the file containing the jtreg >>>>>> directives be named xxxTest.java, and supporting files not ending in >>>>>> Test. >>>>>> >>>>> I have renamed the tests following your recomendation. >>>>> Jtreg tests have now the test suffix. >>>>> >>>>>> test/sun/management/jdp/JdpOnTest.java >>>>>> For the future: it is customary that the file containing the jtreg >>>>>> directives be named xxxTest.java, and supporting files not ending in >>>>>> Test. >>>>>> >>>>> Same as above. >>>>>> test/sun/management/jdp/JdpTest.java >>>>>> No comments. >>>>>> >>>>>> test/sun/management/jdp/JdpTestUtil.java >>>>>> No comments. >>>>>> >>>>>> test/sun/management/jdp/JdpTestUtilTest.java >>>>>> test/sun/management/jdp/PacketTest.java >>>>>> test/sun/management/jdp/PortAlreadyInUseTest.java >>>>>> These are tests for the tests. But where are the tests for the >>>>>> tests for the tests? :) >>>>>> Not reviewed. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>>> >>>>> >>>> >>> >>> -- >>> Alex Schenkman >>> Java VM SQE Stockholm > From eric.mccorkle at oracle.com Mon Nov 11 06:48:13 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Mon, 11 Nov 2013 14:48:13 +0000 Subject: hg: jdk8/tl/langtools: 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass(); ... Message-ID: <20131111144816.61A23624F7@hg.openjdk.java.net> Changeset: 4788eb38cac5 Author: emc Date: 2013-11-11 09:47 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4788eb38cac5 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass() 8027253: javac illegally accepts array as bound Summary: backing out change allowing arrays in intersection types Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/ArraysInIntersections.java - test/tools/javac/InferArraysInIntersections.java - test/tools/javac/diags/examples/InterfaceOrArrayExpected.java ! test/tools/javac/generics/typevars/6680106/T6680106.out From joel.franck at oracle.com Mon Nov 11 08:29:23 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Mon, 11 Nov 2013 16:29:23 +0000 Subject: hg: jdk8/tl/langtools: 8027375: javac asserts on nested erroneous annotations Message-ID: <20131111162926.A5F28624FD@hg.openjdk.java.net> Changeset: f3ca12d680f3 Author: jfranck Date: 2013-11-11 17:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3ca12d680f3 8027375: javac asserts on nested erroneous annotations Summary: make sure JCAnnotation trees have type != null before annotation processing Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Annotate.java + test/tools/javac/annotations/testCrashNestedAnnos/TestCrashNestedAnnos.java + test/tools/javac/annotations/testCrashNestedAnnos/TestCrashNestedAnnos.out From bill.pittore at oracle.com Mon Nov 11 09:11:12 2013 From: bill.pittore at oracle.com (bill pittore) Date: Mon, 11 Nov 2013 12:11:12 -0500 Subject: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument In-Reply-To: <527FD708.9050607@oracle.com> References: <527D0C95.8050605@oracle.com> <527DA1C2.6020500@oracle.com> <527FD708.9050607@oracle.com> Message-ID: <52810FB0.9040208@oracle.com> Modified change based on feedback. New webrev at http://cr.openjdk.java.net/~bpittore/8027914/webrev.01/ thanks, bill On 11/10/2013 1:57 PM, Bill Pittore wrote: > I think that's a good idea since we now have the distinct possibility > of the class not being available in certain profiles. I'll re-do the > change and send out a new webrev. > > thanks, > bill > > On 11/8/2013 9:45 PM, Mandy Chung wrote: >> >> On 11/8/2013 8:08 AM, bill.pittore at oracle.com wrote: >>> If you are running a non-minimal VM build with compact 1 or 2 JRE >>> and you pass in -Dcom.sun.management argument, VM will exit silently >>> with exit code 1. Fix adds an error check when attempting to load >>> the class sun.management.Agent (missing from compact 1 and 2) and >>> will print a message before exiting. >>> >>> http://cr.openjdk.java.net/~bpittore/8027914/webrev.00/ >>> >> >> Since sun.management.Agent is not always present, would it better to >> change to call resolve_or_null and check the returned Klass? >> >> Mandy > > From michael.x.mcmahon at oracle.com Mon Nov 11 08:06:42 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 11 Nov 2013 16:06:42 +0000 Subject: hg: jdk8/tl/jdk: 8028060: test/java/net/URLPermission/nstest/lookup.sh failing (win) Message-ID: <20131111160655.11C41624FB@hg.openjdk.java.net> Changeset: 0e47462f03a0 Author: michaelm Date: 2013-11-11 16:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e47462f03a0 8028060: test/java/net/URLPermission/nstest/lookup.sh failing (win) Reviewed-by: alanb ! test/java/net/URLPermission/nstest/LookupTest.java ! test/java/net/URLPermission/nstest/lookup.sh From staffan.larsen at oracle.com Mon Nov 11 10:42:58 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 19:42:58 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream Message-ID: Please review this small fix to output SA message to stdout instead of stderr. webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6626412 Thanks, /Staffan From staffan.larsen at oracle.com Mon Nov 11 10:43:48 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 19:43:48 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: References: Message-ID: <0669FE15-113B-4AF9-AB5F-A701ADAB6C1B@oracle.com> (and now with the correct email aliases) On 11 Nov 2013, at 19:42, Staffan Larsen wrote: > Please review this small fix to output SA message to stdout instead of stderr. > > webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-6626412 > > Thanks, > /Staffan From serguei.spitsyn at oracle.com Mon Nov 11 10:55:39 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 11 Nov 2013 10:55:39 -0800 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: <0669FE15-113B-4AF9-AB5F-A701ADAB6C1B@oracle.com> References: <0669FE15-113B-4AF9-AB5F-A701ADAB6C1B@oracle.com> Message-ID: <5281282B.30805@oracle.com> Looks good. Thanks, Serguei On 11/11/13 10:43 AM, Staffan Larsen wrote: > (and now with the correct email aliases) > > On 11 Nov 2013, at 19:42, Staffan Larsen wrote: > >> Please review this small fix to output SA message to stdout instead of stderr. >> >> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ >> bug: https://bugs.openjdk.java.net/browse/JDK-6626412 >> >> Thanks, >> /Staffan From staffan.larsen at oracle.com Mon Nov 11 11:01:52 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 20:01:52 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: <5281282B.30805@oracle.com> References: <0669FE15-113B-4AF9-AB5F-A701ADAB6C1B@oracle.com> <5281282B.30805@oracle.com> Message-ID: Thanks Serguei! On 11 Nov 2013, at 19:55, serguei.spitsyn at oracle.com wrote: > Looks good. > > Thanks, > Serguei > > On 11/11/13 10:43 AM, Staffan Larsen wrote: >> (and now with the correct email aliases) >> >> On 11 Nov 2013, at 19:42, Staffan Larsen wrote: >> >>> Please review this small fix to output SA message to stdout instead of stderr. >>> >>> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-6626412 >>> >>> Thanks, >>> /Staffan > From lance.andersen at oracle.com Mon Nov 11 11:22:50 2013 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Mon, 11 Nov 2013 19:22:50 +0000 Subject: hg: jdk8/tl/jdk: 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Message-ID: <20131111192304.9BEBB62502@hg.openjdk.java.net> Changeset: 59ff7957c26f Author: lancea Date: 2013-11-11 14:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59ff7957c26f 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java From staffan.larsen at oracle.com Mon Nov 11 11:28:23 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 20:28:23 +0100 Subject: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing Message-ID: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> The problem here is that ?jinfo -flags? only looks at the command line, but if a user has changed a flag after the VM started (for example by using ?jinfo -flag?) that new value does not show up. I am changing the output so that ?jinfo -flags? now prints something like this: Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC Command line: -XX:+PrintGCDetails webrev: http://cr.openjdk.java.net/~sla/6606002/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6606002 Thanks, /Staffan From dmitry.samersoff at oracle.com Mon Nov 11 11:43:22 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 11 Nov 2013 23:43:22 +0400 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: <0669FE15-113B-4AF9-AB5F-A701ADAB6C1B@oracle.com> References: <0669FE15-113B-4AF9-AB5F-A701ADAB6C1B@oracle.com> Message-ID: <5281335A.8060303@oracle.com> Looks good for me. -Dmitry On 2013-11-11 22:43, Staffan Larsen wrote: > (and now with the correct email aliases) > > On 11 Nov 2013, at 19:42, Staffan Larsen wrote: > >> Please review this small fix to output SA message to stdout instead of stderr. >> >> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ >> bug: https://bugs.openjdk.java.net/browse/JDK-6626412 >> >> Thanks, >> /Staffan > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From staffan.larsen at oracle.com Mon Nov 11 11:49:22 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 20:49:22 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Message-ID: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> The contract for the tools should be (similarly from other tools, eg javac): If the arguments are wrong or not specified: exit code != 0, usage output on stderr If -help or -h is specified: exit code == 0, usage output on stderr webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8027765 Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/8d8b2b8d/attachment.html From serguei.spitsyn at oracle.com Mon Nov 11 12:06:07 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 11 Nov 2013 12:06:07 -0800 Subject: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing In-Reply-To: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> References: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> Message-ID: <528138AF.6010705@oracle.com> It looks good. The only one nit is about the line: 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags()); If one or both ofArguments.getJVMArgs() and Arguments.getJVMFlags() return null (not sure if it is the case) then the output will have "null" like this: "Command line: nullnull" Would it make sense to keep the original checks for non-null strings? Thanks, Serguei On 11/11/13 11:28 AM, Staffan Larsen wrote: > The problem here is that ?jinfo -flags? only looks at the command line, but if a user has changed a flag after the VM started (for example by using ?jinfo -flag?) that new value does not show up. > > I am changing the output so that ?jinfo -flags? now prints something like this: > > Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC > Command line: -XX:+PrintGCDetails > > > webrev: http://cr.openjdk.java.net/~sla/6606002/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-6606002 > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/45423fa3/attachment.html From staffan.larsen at oracle.com Mon Nov 11 12:13:33 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 21:13:33 +0100 Subject: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature In-Reply-To: <5280E261.1070800@oracle.com> References: <51A31867.9080602@oracle.com> <51CAC09B.7070706@oracle.com> <7E2E50A8-1FB1-429B-8AAB-94863C215623@oracle.com> <51D56A11.5030600@oracle.com> <5214AC0A.4010603@oracle.com> <70F043F0-9F19-4761-B175-1D6652B5A146@oracle.com> <3B20B5DC-9E92-4EB6-97FF-0F2D2B4E1E10@oracle.com> <52244497.8010902@oracle.com> <5267C65A.9060602@oracle.com> <4EDB8911-E772-4B13-B0EB-AA90C729A49A@oracle.com> <526FCC02.3050308@oracle.com> <527D0B02.6040705@oracle.com> <527D2323.8080403@oracle.com> <5280E261.1070800@oracle.com> Message-ID: <525D7BCF-CA07-4C78-9C93-C19F10B660BA@oracle.com> Thanks for the explanation. Reviewed! I will sponsor the push. And thanks for hanging in there during the review process. /Staffan On 11 Nov 2013, at 14:57, Mikael Auno wrote: > The reduction in testsuites in JdpTest.sh is due to those "testsuites" removed being ported to Java with this change. The last "testsuite" in JdpTest.sh however, has not been ported yet, therefore JdpTest.sh can't be removed completely. > > Mikael > > On 2013-11-11 14:19, Staffan Larsen wrote: >> Why are there changes to the existing tests? Most look like whitespace >> changes, but JdpTest.sh changes the ?testsuites? that are being run. >> >> /Staffan >> >> On 08 Nov 2013, at 18:45, Mikael Auno > > wrote: >> >>> There was some unintended whitespace changes in webrev.05 that Alex >>> had missed. I removed them and uploaded webrev.06 for him. >>> >>> http://cr.openjdk.java.net/~miauno/8014506/webrev.06/ >>> >>> Mikael >>> >>> On 2013-11-08 17:02, Alex Schenkman wrote: >>>> Hi list, >>>> >>>> Latest version is up for review here [1]. >>>> It fixes Staffan's latest comments (see below), as well as some >>>> indentation and tab/spaces nits. >>>> >>>> Thanks! >>>> >>>> [1]http://cr.openjdk.java.net/~miauno/8014506/ >>>> >>>> >>>> On 2013-10-30 16:03, Staffan Larsen wrote: >>>>> Alex, >>>>> >>>>> This looks much better! Thanks for spending the time. >>>>> >>>>> README: >>>>> nit: contribuited -> contributed >>>>> >>>>> JdpTestUtilTest.java: >>>>> Can you add a comment saying this is a test for the tests - just >>>>> like PacketTest.java and PortAlreadyInUseTest.java? >>>>> >>>>> PortFinder.java: >>>>> Please remove this and use Utils.getFreePort() since ykantser's fix >>>>> is now pushed. >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> On 29 okt 2013, at 15:53, Alex Schenkman >>>> >>>>> > wrote: >>>>> >>>>>> Hi Staffan, >>>>>> >>>>>> There is a new webrev here [1], addressing your comments. >>>>>> >>>>>> The Jdp specs have changed a bit, adding three optional fields to the >>>>>> Jdp packet [2]. >>>>>> The JEP-168 [3] is not updated yet, but Dmitry will do it soon. >>>>>> This enhancement request is tracking the changes needed for SQE [4]. >>>>>> >>>>>> See inlined answers for details on your previos comments, please. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> >>>>>> [1] >>>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/aschenkman/8014506/webrev.04/ >>>>>> >>>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8004213 >>>>>> [3] http://openjdk.java.net/jeps/168 >>>>>> [4] https://bugs.openjdk.java.net/browse/JDK-8027436 >>>>>> >>>>>> On 2013-10-24 10:54, Staffan Larsen wrote: >>>>>>> Alex, >>>>>>> >>>>>>> test/sun/management/jdp/README >>>>>>> Thanks for providing a README! >>>>>>> References to JDK-7169888 seem incorrect to me. >>>>>>> L8: "written by" appears twice. >>>>>>> L11: "defautl" -> "default" >>>>>>> >>>>>> Fixed. >>>>>>> test/lib/testlibrary/jdk/testlibrary/PortFinder.java >>>>>>> This should be coordinated with the review for 8022229 which >>>>>>> contains the same code in a different testlibrary class: >>>>>>> http://cr.openjdk.java.net/~ykantser/8022229/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html >>>>>>> >>>>>>> >>>>>> I made a private copy of this function, and have marked it as >>>>>> deprecated. >>>>>> As soon as ykanster's code is merged I can delete my private function >>>>>> and use the library. >>>>>> The reason for this is to get this patch pushed without further delay. >>>>>> >>>>>>> test/sun/management/jdp/7169888/JdpClient.java >>>>>>> test/sun/management/jdp/7169888/JdpDoSomething.java >>>>>>> test/sun/management/jdp/7169888/JdpTest.sh >>>>>>> test/sun/management/jdp/7169888/JdpUnitTest.java >>>>>>> These were moved to a subdirectory, but these tests have nothing >>>>>>> to do with bug 7169888, so why that name? In any case we should >>>>>>> avoid naming test directories after bug ids, and instead use a >>>>>>> descriptive name. >>>>>>> >>>>>> This bug number was wrong. These tests were now moved back to the jdp >>>>>> folder. >>>>>> I have expanded the README file with some details about these tests. >>>>>> >>>>>> Dmitry's shell-based are as follows: >>>>>> test_01 - basic test, check if JDP packet assembler and other >>>>>> parts of JDP is not broken >>>>>> >>>>>> test_02 - test if JDP starts with custom parameters. >>>>>> >>>>>> test_03 - test if jcmd is able to start jdp with >>>>>> custom parameters (disabled) >>>>>> >>>>>> test_04 - test if JDP starts with default parameters >>>>>> >>>>>> test_05 - test if jcmd is able to start jdp with default >>>>>> parameters (disabled) >>>>>> >>>>>> >>>>>> test_03 and test_05 are diabled becuase there is a mismatch between >>>>>> hotsport and jdk repos, according to Dmitry. These cases (jcmd) are >>>>>> not covered by this patch, and are part of the test enhacements [4]. >>>>>> >>>>>> test_01 does partly overlap with the Java-based tests, but we should >>>>>> keep it until we implement the latest enhacements [4]. >>>>>> >>>>>> >>>>>>> test/sun/management/jdp/ClientConnection.java >>>>>>> No comments. >>>>>>> >>>>>>> test/sun/management/jdp/DefaultLauncher.java >>>>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>>>> /lib/testlibrary" ? >>>>>>> >>>>>> Fixed. >>>>>>> test/sun/management/jdp/OffLauncher.java >>>>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>>>> /lib/testlibrary" ? >>>>>>> >>>>>> Fixed. >>>>>> >>>>>>> test/sun/management/jdp/SpecificJdpAddressLauncher.java >>>>>>> Can "@library ../../../lib/testlibrary" be replaced by "@library >>>>>>> /lib/testlibrary" ? >>>>>>> >>>>>> Fixed. >>>>>>> test/sun/management/jdp/DynamicLauncher.java >>>>>>> No comments. >>>>>>> >>>>>> Fixed. >>>>>> >>>>>>> test/sun/management/jdp/JdpOffTest.java >>>>>>> For the future: it is customary that the file containing the jtreg >>>>>>> directives be named xxxTest.java, and supporting files not ending in >>>>>>> Test. >>>>>>> >>>>>> I have renamed the tests following your recomendation. >>>>>> Jtreg tests have now the test suffix. >>>>>> >>>>>>> test/sun/management/jdp/JdpOnTest.java >>>>>>> For the future: it is customary that the file containing the jtreg >>>>>>> directives be named xxxTest.java, and supporting files not ending in >>>>>>> Test. >>>>>>> >>>>>> Same as above. >>>>>>> test/sun/management/jdp/JdpTest.java >>>>>>> No comments. >>>>>>> >>>>>>> test/sun/management/jdp/JdpTestUtil.java >>>>>>> No comments. >>>>>>> >>>>>>> test/sun/management/jdp/JdpTestUtilTest.java >>>>>>> test/sun/management/jdp/PacketTest.java >>>>>>> test/sun/management/jdp/PortAlreadyInUseTest.java >>>>>>> These are tests for the tests. But where are the tests for the >>>>>>> tests for the tests? :) >>>>>>> Not reviewed. >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>>> >>>>>> >>>>> >>>> >>>> -- >>>> Alex Schenkman >>>> Java VM SQE Stockholm -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/9880db66/attachment.html From staffan.larsen at oracle.com Mon Nov 11 12:15:35 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 21:15:35 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: <5281335A.8060303@oracle.com> References: <0669FE15-113B-4AF9-AB5F-A701ADAB6C1B@oracle.com> <5281335A.8060303@oracle.com> Message-ID: <8E83CD6D-7B79-4B0D-8597-B5F4173CC12E@oracle.com> Thanks Dmitry! On 11 Nov 2013, at 20:43, Dmitry Samersoff wrote: > Looks good for me. > > -Dmitry > > On 2013-11-11 22:43, Staffan Larsen wrote: >> (and now with the correct email aliases) >> >> On 11 Nov 2013, at 19:42, Staffan Larsen wrote: >> >>> Please review this small fix to output SA message to stdout instead of stderr. >>> >>> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-6626412 >>> >>> Thanks, >>> /Staffan >> > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources. From staffan.larsen at oracle.com Mon Nov 11 12:25:20 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 11 Nov 2013 21:25:20 +0100 Subject: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing In-Reply-To: <528138AF.6010705@oracle.com> References: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> <528138AF.6010705@oracle.com> Message-ID: Ah, good catch. Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/ Thanks, /Staffan On 11 Nov 2013, at 21:06, serguei.spitsyn at oracle.com wrote: > It looks good. > > The only one nit is about the line: > 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags()); > > If one or both of Arguments.getJVMArgs() and Arguments.getJVMFlags() return null > (not sure if it is the case) then the output will have "null" like this: > "Command line: nullnull" > > Would it make sense to keep the original checks for non-null strings? > > > Thanks, > Serguei > > > On 11/11/13 11:28 AM, Staffan Larsen wrote: >> The problem here is that ?jinfo -flags? only looks at the command line, but if a user has changed a flag after the VM started (for example by using ?jinfo -flag?) that new value does not show up. >> >> I am changing the output so that ?jinfo -flags? now prints something like this: >> >> Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC >> Command line: -XX:+PrintGCDetails >> >> >> webrev: http://cr.openjdk.java.net/~sla/6606002/webrev.00/ >> bug: https://bugs.openjdk.java.net/browse/JDK-6606002 >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/42720181/attachment-0001.html From serguei.spitsyn at oracle.com Mon Nov 11 12:40:21 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 11 Nov 2013 12:40:21 -0800 Subject: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing In-Reply-To: References: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> <528138AF.6010705@oracle.com> Message-ID: <528140B5.8020903@oracle.com> Looks good. Thanks, Serguei On 11/11/13 12:25 PM, Staffan Larsen wrote: > Ah, good catch. > > Here is an updated review: > http://cr.openjdk.java.net/~sla/6606002/webrev.01/ > > > Thanks, > /Staffan > > On 11 Nov 2013, at 21:06, serguei.spitsyn at oracle.com > wrote: > >> It looks good. >> >> The only one nit is about the line: >> 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags()); >> >> If one or both ofArguments.getJVMArgs() and Arguments.getJVMFlags() >> return null >> (not sure if it is the case) then the output will have "null" like this: >> "Command line: nullnull" >> >> Would it make sense to keep the original checks for non-null strings? >> >> >> Thanks, >> Serguei >> >> >> On 11/11/13 11:28 AM, Staffan Larsen wrote: >>> The problem here is that ?jinfo -flags? only looks at the command line, but if a user has changed a flag after the VM started (for example by using ?jinfo -flag?) that new value does not show up. >>> >>> I am changing the output so that ?jinfo -flags? now prints something like this: >>> >>> Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC >>> Command line: -XX:+PrintGCDetails >>> >>> >>> webrev:http://cr.openjdk.java.net/~sla/6606002/webrev.00/ >>> bug:https://bugs.openjdk.java.net/browse/JDK-6606002 >>> >>> Thanks, >>> /Staffan >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/779d11a5/attachment.html From markus.gronlund at oracle.com Mon Nov 11 13:24:31 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Mon, 11 Nov 2013 13:24:31 -0800 (PST) Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> Message-ID: Looks good Staffan! Thanks for fixing up this (mess). Thanks Markus From: Staffan Larsen Sent: den 11 november 2013 20:49 To: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent The contract for the tools should be (similarly from other tools, eg javac): If the arguments are wrong or not specified: exit code != 0, usage output on stderr If -help or -h is specified: exit code == 0, usage output on stderr webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8027765 Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/aae1122d/attachment.html From staffan.larsen at oracle.com Mon Nov 11 12:17:23 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 11 Nov 2013 20:17:23 +0000 Subject: hg: jdk8/tl/jdk: 8014506: Test of Jdp feature Message-ID: <20131111201735.59C2462503@hg.openjdk.java.net> Changeset: 0cacac7f5c37 Author: sla Date: 2013-11-08 18:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cacac7f5c37 8014506: Test of Jdp feature Reviewed-by: sla Contributed-by: Alex Schenkman + test/sun/management/jdp/ClientConnection.java + test/sun/management/jdp/DynamicLauncher.java ! test/sun/management/jdp/JdpClient.java + test/sun/management/jdp/JdpDefaultsTest.java ! test/sun/management/jdp/JdpDoSomething.java + test/sun/management/jdp/JdpOffTest.java + test/sun/management/jdp/JdpOffTestCase.java + test/sun/management/jdp/JdpOnTestCase.java + test/sun/management/jdp/JdpSpecificAddressTest.java ! test/sun/management/jdp/JdpTest.sh + test/sun/management/jdp/JdpTestCase.java + test/sun/management/jdp/JdpTestUtil.java + test/sun/management/jdp/JdpTestUtilTest.java ! test/sun/management/jdp/JdpUnitTest.java + test/sun/management/jdp/PacketTest.java + test/sun/management/jdp/PortAlreadyInUseTest.java + test/sun/management/jdp/README From xueming.shen at oracle.com Mon Nov 11 14:41:14 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 11 Nov 2013 22:41:14 +0000 Subject: hg: jdk8/tl/jdk: 8026330: java.util.Base64 urlEncoder should omit padding Message-ID: <20131111224131.E205562510@hg.openjdk.java.net> Changeset: 8e8e423fa3dc Author: sherman Date: 2013-11-11 14:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e8e423fa3dc 8026330: java.util.Base64 urlEncoder should omit padding Summary: to add Encoder.withoutPadding() Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java From serguei.spitsyn at oracle.com Mon Nov 11 15:37:44 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 11 Nov 2013 15:37:44 -0800 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> Message-ID: <52816A48.2080504@oracle.com> The fix looks good. Thanks, Serguei On 11/11/13 11:49 AM, Staffan Larsen wrote: > The contract for the tools should be (similarly from other tools, eg > javac): > > If the arguments are wrong or not specified: exit code != 0, usage > output on stderr > If -help or -h is specified: exit code == 0, usage output on stderr > > webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.00/ > > bug: https://bugs.openjdk.java.net/browse/JDK-8027765 > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131111/d27e2b85/attachment.html From robert.field at oracle.com Mon Nov 11 16:14:35 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 12 Nov 2013 00:14:35 +0000 Subject: hg: jdk8/tl/jdk: 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails Message-ID: <20131112001448.1A5AD62519@hg.openjdk.java.net> Changeset: c04e46dbfea8 Author: rfield Date: 2013-11-11 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c04e46dbfea8 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails Summary: fix NPE in test infrastructure Reviewed-by: ksrini, jfranck, alanb, rfield Contributed-by: alan.bateman at oracle.com ! test/lib/testlibrary/ClassFileInstaller.java From david.holmes at oracle.com Mon Nov 11 17:39:55 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 12 Nov 2013 11:39:55 +1000 Subject: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument In-Reply-To: <52810FB0.9040208@oracle.com> References: <527D0C95.8050605@oracle.com> <527DA1C2.6020500@oracle.com> <527FD708.9050607@oracle.com> <52810FB0.9040208@oracle.com> Message-ID: <528186EB.9090701@oracle.com> On 12/11/2013 3:11 AM, bill pittore wrote: > Modified change based on feedback. New webrev at > http://cr.openjdk.java.net/~bpittore/8027914/webrev.01/ Looks good to me. Thanks, David > thanks, > bill > > On 11/10/2013 1:57 PM, Bill Pittore wrote: >> I think that's a good idea since we now have the distinct possibility >> of the class not being available in certain profiles. I'll re-do the >> change and send out a new webrev. >> >> thanks, >> bill >> >> On 11/8/2013 9:45 PM, Mandy Chung wrote: >>> >>> On 11/8/2013 8:08 AM, bill.pittore at oracle.com wrote: >>>> If you are running a non-minimal VM build with compact 1 or 2 JRE >>>> and you pass in -Dcom.sun.management argument, VM will exit silently >>>> with exit code 1. Fix adds an error check when attempting to load >>>> the class sun.management.Agent (missing from compact 1 and 2) and >>>> will print a message before exiting. >>>> >>>> http://cr.openjdk.java.net/~bpittore/8027914/webrev.00/ >>>> >>> >>> Since sun.management.Agent is not always present, would it better to >>> change to call resolve_or_null and check the returned Klass? >>> >>> Mandy >> >> > From mandy.chung at oracle.com Mon Nov 11 18:30:33 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 11 Nov 2013 18:30:33 -0800 Subject: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument In-Reply-To: <52810FB0.9040208@oracle.com> References: <527D0C95.8050605@oracle.com> <527DA1C2.6020500@oracle.com> <527FD708.9050607@oracle.com> <52810FB0.9040208@oracle.com> Message-ID: <528192C9.6020205@oracle.com> On 11/11/2013 9:11 AM, bill pittore wrote: > Modified change based on feedback. New webrev at > http://cr.openjdk.java.net/~bpittore/8027914/webrev.01/ > Thanks for the update. Looks fine to me. Mandy > thanks, > bill > > On 11/10/2013 1:57 PM, Bill Pittore wrote: >> I think that's a good idea since we now have the distinct possibility >> of the class not being available in certain profiles. I'll re-do the >> change and send out a new webrev. >> >> thanks, >> bill >> >> On 11/8/2013 9:45 PM, Mandy Chung wrote: >>> >>> On 11/8/2013 8:08 AM, bill.pittore at oracle.com wrote: >>>> If you are running a non-minimal VM build with compact 1 or 2 JRE >>>> and you pass in -Dcom.sun.management argument, VM will exit >>>> silently with exit code 1. Fix adds an error check when attempting >>>> to load the class sun.management.Agent (missing from compact 1 and >>>> 2) and will print a message before exiting. >>>> >>>> http://cr.openjdk.java.net/~bpittore/8027914/webrev.00/ >>>> >>> >>> Since sun.management.Agent is not always present, would it better >>> to change to call resolve_or_null and check the returned Klass? >>> >>> Mandy >> >> > From john.r.rose at oracle.com Mon Nov 11 20:34:34 2013 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Tue, 12 Nov 2013 04:34:34 +0000 Subject: hg: jdk8/tl/jdk: 8027823: catchException combinator fails with 9 argument target Message-ID: <20131112043449.1415862520@hg.openjdk.java.net> Changeset: 9fcb07df1c92 Author: vlivanov Date: 2013-11-09 04:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fcb07df1c92 8027823: catchException combinator fails with 9 argument target Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java + test/java/lang/invoke/MethodHandles/TestCatchException.java From jaroslav.bachorik at oracle.com Tue Nov 12 00:37:31 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 12 Nov 2013 09:37:31 +0100 Subject: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing In-Reply-To: References: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> <528138AF.6010705@oracle.com> Message-ID: <5281E8CB.7000104@oracle.com> Looks fine (not-a-reviewer) -JB- On 11.11.2013 21:25, Staffan Larsen wrote: > Ah, good catch. > > Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/ > > Thanks, > /Staffan > > On 11 Nov 2013, at 21:06, serguei.spitsyn at oracle.com wrote: > >> It looks good. >> >> The only one nit is about the line: >> 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags()); >> >> If one or both of Arguments.getJVMArgs() and Arguments.getJVMFlags() return null >> (not sure if it is the case) then the output will have "null" like this: >> "Command line: nullnull" >> >> Would it make sense to keep the original checks for non-null strings? >> >> >> Thanks, >> Serguei >> >> >> On 11/11/13 11:28 AM, Staffan Larsen wrote: >>> The problem here is that ?jinfo -flags? only looks at the command line, but if a user has changed a flag after the VM started (for example by using ?jinfo -flag?) that new value does not show up. >>> >>> I am changing the output so that ?jinfo -flags? now prints something like this: >>> >>> Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC >>> Command line: -XX:+PrintGCDetails >>> >>> >>> webrev: http://cr.openjdk.java.net/~sla/6606002/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-6606002 >>> >>> Thanks, >>> /Staffan >> > > From jaroslav.bachorik at oracle.com Tue Nov 12 00:45:14 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 12 Nov 2013 09:45:14 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: References: Message-ID: <5281EA9A.3020201@oracle.com> Looks fine. -JB- On 11.11.2013 19:42, Staffan Larsen wrote: > Please review this small fix to output SA message to stdout instead of stderr. > > webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-6626412 > > Thanks, > /Staffan > From fredrik.arvidsson at oracle.com Tue Nov 12 00:48:26 2013 From: fredrik.arvidsson at oracle.com (Fredrik Arvidsson) Date: Tue, 12 Nov 2013 09:48:26 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: <5281EA9A.3020201@oracle.com> References: <5281EA9A.3020201@oracle.com> Message-ID: <5281EB5A.2020001@oracle.com> Looks good to me (not a reviewer). /F On 2013-11-12 09:45, Jaroslav Bachorik wrote: > Looks fine. > > -JB- > > On 11.11.2013 19:42, Staffan Larsen wrote: >> Please review this small fix to output SA message to stdout instead >> of stderr. >> >> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ >> bug: https://bugs.openjdk.java.net/browse/JDK-6626412 >> >> Thanks, >> /Staffan >> > From sundararajan.athijegannathan at oracle.com Tue Nov 12 00:47:45 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 12 Nov 2013 08:47:45 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131112084747.6305262530@hg.openjdk.java.net> Changeset: e65a98146b94 Author: attila Date: 2013-11-11 14:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e65a98146b94 8028020: Function parameter as last expression in comma in return value causes bad type calculation Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8028020.js + test/script/basic/JDK-8028020.js.EXPECTED Changeset: 2f0f8d1d0753 Author: sundar Date: 2013-11-12 10:23 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f0f8d1d0753 Merge From markus.gronlund at oracle.com Tue Nov 12 03:17:29 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Tue, 12 Nov 2013 03:17:29 -0800 (PST) Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data Message-ID: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> Greetings, Kindly asking for reviews for the following changeset: Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 Description: Currently, when working with counter based data, the primary data type representation in the VM are raw jlong's. jlong's are employed to represent both: 1. a single instance in time, for example a "now" timestamp 2. a time duration, a timespan, for example the duration between "now" - "then" Having a raw jlong type represent both of these shifts the responsibility to the programmer to always ensure the correct validity of the counter data, without any assistance either at compile time or at runtime. The event based tracing framework relies heavily on counter based data in order to keep track of time and timing related information and we have seen counter data errors where the representation sent to the tracing framework has submitted the wrong time, i.e. a timespan when a time instant was expected and vice versa. We should therefore add an alternative to jlongs for representing counter based data. We should enlist the help of the type system to enforce the correct data types at compile time as well as introduce strong runtime asserts in order to help with the correct usage of time and to reduce the number of potential bugs. I will therefore add two new types in src/share/vm/utilities: 1. "Ticks" - represents a single counter based timestamp, a single instance in time. 2. "Tickspan" - represents a counter based duration, a timespan, between two "Ticks" Please see the added files: - src/share/vm/utilities/ticks.hpp - src/share/vm/utilities/ticks.inline.hpp - src/share/vm/utilities/ticks.cpp I have also updated some of the existing event based tracing "event sites" to employ usage of these new types as well as updated a few places in the event based tracing framework implementation to accommodate these types. Testing completed: nsk.stress.testlist (UTE/Aurora) GC nightlies (Aurora) gc/gctests/* (UTE/Aurora) nsk.gc.testlist (UTE/Aurora) SpecJBB2013 (no regression) SpecJBB2005 (no regression) Kitchensink (locally Windows) runs for +> 9 days (still running.) Thanks in advance Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131112/04447f61/attachment-0001.html From erik.gahlin at oracle.com Tue Nov 12 05:51:03 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 12 Nov 2013 13:51:03 +0000 Subject: hg: jdk8/tl/jdk: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently Message-ID: <20131112135120.AA67362538@hg.openjdk.java.net> Changeset: 41dcb0c2e194 Author: egahlin Date: 2013-11-12 14:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcb0c2e194 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently Reviewed-by: sla, jbachorik ! test/javax/management/monitor/ThreadPoolAccTest.java From markus.gronlund at oracle.com Tue Nov 12 07:34:28 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Tue, 12 Nov 2013 07:34:28 -0800 (PST) Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> Message-ID: <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> Hi Vitaly, Thanks for you input! "You have some operator overloads for these that can compare them against jlongs - doesn't that still make it easy to mix up what you're comparing? Personally, since these are value types I'd make their API work only against these new types and make caller create the right type for comparison." Thanks for spotting these - the compare against jlongs in from an older version of the webrev where this was allowed - you are right, it should not be allowed, I thought I had updated this, will remove them - many thanks for spotting. As for the names, "Ticks and Tickspan don't seem too optimal of names. What about TimeInstance and TimeSpan?" I agree with you that the names could possibly be improved, believe me I have tried to use multiple names - one thing I wanted was to emphasize that these types (currently) are only based on counter's (i.e ticks), and do not represent any higher "time" abstraction. That is, the implementation is tied to data from counters (based on ticks with a specific ticks frequency). In my current context, I use these values to talk about "time" (as you saw from the original post), but "time" can mean many things to different people, esp. many implementations and clock sources. Also, there already exist a few "Time/Timer" types (although they are not as good as I want them to be for current purposes), for example there is a type called Timestamp (in runtime/timers.hpp). I have come to the conclusion that in order to address the overall time abstractions in Hotspot, we would need to make a larger effort - this we should indeed do, but it's outside the current scope. Also I am pretty sure that when we do revisit the time abstractions, the names for these types will most likely change - that made me leave the names to emphasize the "ticks" sources. Thanks for your input. Best regards Markus From: Vitaly Davidovich [mailto:vitalyd at gmail.com] Sent: den 12 november 2013 15:37 To: Markus Gronlund Cc: serviceability-dev; hotspot-runtime-dev at openjdk.java.net; hotspot-gc-dev at openjdk.java.net Subject: Re: RFR(M): 8028128: Add a type safe alternative for working with counter based data Hi Markus, Ticks and Tickspan don't seem too optimal of names. What about TimeInstance and TimeSpan? You have some operator overloads for these that can compare them against jlongs - doesn't that still make it easy to mix up what you're comparing? Personally, since these are value types I'd make their API work only against these new types and make caller create the right type for comparison. Just my $.02, feel free to ignore :). Thanks Sent from my phone On Nov 12, 2013 6:16 AM, "Markus Gronlund" wrote: Greetings, Kindly asking for reviews for the following changeset: Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 Description: Currently, when working with counter based data, the primary data type representation in the VM are raw jlong's. jlong's are employed to represent both: 1. a single instance in time, for example a "now" timestamp 2. a time duration, a timespan, for example the duration between "now" - "then" Having a raw jlong type represent both of these shifts the responsibility to the programmer to always ensure the correct validity of the counter data, without any assistance either at compile time or at runtime. The event based tracing framework relies heavily on counter based data in order to keep track of time and timing related information and we have seen counter data errors where the representation sent to the tracing framework has submitted the wrong time, i.e. a timespan when a time instant was expected and vice versa. We should therefore add an alternative to jlongs for representing counter based data. We should enlist the help of the type system to enforce the correct data types at compile time as well as introduce strong runtime asserts in order to help with the correct usage of time and to reduce the number of potential bugs. I will therefore add two new types in src/share/vm/utilities: 1. "Ticks" - represents a single counter based timestamp, a single instance in time. 2. "Tickspan" - represents a counter based duration, a timespan, between two "Ticks" Please see the added files: - src/share/vm/utilities/ticks.hpp - src/share/vm/utilities/ticks.inline.hpp - src/share/vm/utilities/ticks.cpp I have also updated some of the existing event based tracing "event sites" to employ usage of these new types as well as updated a few places in the event based tracing framework implementation to accommodate these types. Testing completed: nsk.stress.testlist (UTE/Aurora) GC nightlies (Aurora) gc/gctests/* (UTE/Aurora) nsk.gc.testlist (UTE/Aurora) SpecJBB2013 (no regression) SpecJBB2005 (no regression) Kitchensink (locally Windows) runs for +> 9 days (still running.) Thanks in advance Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131112/661bcd31/attachment.html From stuart.marks at oracle.com Tue Nov 12 07:59:42 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 12 Nov 2013 15:59:42 +0000 Subject: hg: jdk8/tl/jdk: 8028027: serialver should emit declaration with the 'private' modifier Message-ID: <20131112155956.6B77A62540@hg.openjdk.java.net> Changeset: f6012ca3bdd3 Author: smarks Date: 2013-11-12 16:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6012ca3bdd3 8028027: serialver should emit declaration with the 'private' modifier Reviewed-by: darcy, mchung, alanb, chegar ! src/share/classes/sun/tools/serialver/SerialVer.java From erik.gahlin at oracle.com Tue Nov 12 08:43:21 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 12 Nov 2013 16:43:21 +0000 Subject: hg: jdk8/tl/jdk: 6543856: MonitorVmStartTerminate.sh fails intermittently Message-ID: <20131112164335.7ADD962548@hg.openjdk.java.net> Changeset: 4cff9f59644f Author: egahlin Date: 2013-11-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f 6543856: MonitorVmStartTerminate.sh fails intermittently Reviewed-by: sla, dholmes ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/jvmstat/testlibrary/JavaProcess.java From erik.gahlin at oracle.com Tue Nov 12 09:14:54 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 12 Nov 2013 17:14:54 +0000 Subject: hg: jdk8/tl/jdk: 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes() Message-ID: <20131112171507.B29336254A@hg.openjdk.java.net> Changeset: d9f827e4d20c Author: egahlin Date: 2013-11-12 18:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f827e4d20c 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes() Reviewed-by: sla ! test/sun/management/HotspotThreadMBean/GetInternalThreads.java From joe.darcy at oracle.com Tue Nov 12 09:44:54 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 12 Nov 2013 17:44:54 +0000 Subject: hg: jdk8/tl/jdk: 8028229: Fix more raw types lint warning in core libraries Message-ID: <20131112174506.65E876254F@hg.openjdk.java.net> Changeset: 69432cb5bca2 Author: darcy Date: 2013-11-12 09:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69432cb5bca2 8028229: Fix more raw types lint warning in core libraries Reviewed-by: chegar, forax, lancea, alanb, jfranck ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/nio/file/TempFileHelper.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/sun/misc/Cleaner.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java ! src/share/classes/sun/rmi/server/Util.java From alan.bateman at oracle.com Tue Nov 12 09:39:38 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 12 Nov 2013 17:39:38 +0000 Subject: hg: jdk8/tl/jdk: 8028208: (aio) Assertion in clearPendingIoMap when closing at around time file lock is acquired immediately (win) Message-ID: <20131112173950.14FC86254D@hg.openjdk.java.net> Changeset: 0c414ac10700 Author: alanb Date: 2013-11-12 17:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c414ac10700 8028208: (aio) Assertion in clearPendingIoMap when closing at around time file lock is acquired immediately (win) Reviewed-by: chegar ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! test/ProblemList.txt From roger.riggs at oracle.com Tue Nov 12 11:04:28 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 12 Nov 2013 19:04:28 +0000 Subject: hg: jdk8/tl/jdk: 8028014: Doclint warning/error cleanup in javax.management Message-ID: <20131112190440.BADB762550@hg.openjdk.java.net> Changeset: ebe27e1a2e2d Author: rriggs Date: 2013-11-12 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebe27e1a2e2d 8028014: Doclint warning/error cleanup in javax.management Summary: Improve generated html by fixing doclint warnings Reviewed-by: sla, jbachorik ! src/share/classes/javax/management/AttributeList.java ! src/share/classes/javax/management/BooleanValueExp.java ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/management/DescriptorKey.java ! src/share/classes/javax/management/ImmutableDescriptor.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/MBeanServerNotification.java ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/NumericValueExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/PersistentMBean.java ! src/share/classes/javax/management/Query.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetParser.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationBroadcaster.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanParameterInfoSupport.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/Relation.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationServiceMBean.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/remote/JMXConnectionNotification.java ! src/share/classes/javax/management/remote/JMXConnector.java ! src/share/classes/javax/management/remote/JMXConnectorProvider.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java From erik.gahlin at oracle.com Tue Nov 12 12:33:53 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 12 Nov 2013 21:33:53 +0100 Subject: RFR(S): 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Message-ID: <528290B1.20507@oracle.com> Could I please have a review of a regression test that fails intermittently because a full GC is not always triggered. Fix is to call System.gc() Webrev: http://cr.openjdk.java.net/~egahlin/6954510_1 Bug: https://bugs.openjdk.java.net/browse/JDK-6954510 Thanks Erik From Alan.Bateman at oracle.com Tue Nov 12 13:35:04 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 12 Nov 2013 21:35:04 +0000 Subject: 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError Message-ID: <52829F08.2080909@oracle.com> This test was liberated earlier today via JDK- 6543856 [1]. Unfortunately it is failing again, this time with a NoClassDefFoundError because it can't locate the JavaProcess class. The issue can be quickly fixed with the attached patched (to add testlibrary to the classpah). Alternatively we can exclude this test again, pending a re-visit of this test and perhaps eliminating the shell script. -Alan. diff --git a/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh b/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh --- a/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh +++ b/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh @@ -38,6 +38,6 @@ verify_os JAVA="${TESTJAVA}/bin/java" -CP=${TESTJAVA}${FS}lib${FS}tools.jar${PS}${TESTCLASSES} +CP=${TESTJAVA}${FS}lib${FS}tools.jar${PS}${TESTCLASSES}${PS}${TESTCLASSES}${FS}..${FS}..${FS}testlibrary ${JAVA} ${TESTVMOPTS} -classpath ${CP} MonitorVmStartTerminate [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131112/d48786e7/attachment.html From erik.gahlin at oracle.com Tue Nov 12 13:47:19 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 12 Nov 2013 22:47:19 +0100 Subject: 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError In-Reply-To: <52829F08.2080909@oracle.com> References: <52829F08.2080909@oracle.com> Message-ID: <5282A1E7.7070902@oracle.com> My fault, thanks for fixing. Looks good. Erik Alan Bateman skrev 2013-11-12 22:35: > > This test was liberated earlier today via JDK- 6543856 [1]. > Unfortunately it is failing again, this time with a > NoClassDefFoundError because it can't locate the JavaProcess class. > The issue can be quickly fixed with the attached patched (to add > testlibrary to the classpah). Alternatively we can exclude this test > again, pending a re-visit of this test and perhaps eliminating the > shell script. > > -Alan. > > > diff --git > a/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > b/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > --- a/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > +++ b/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > @@ -38,6 +38,6 @@ > verify_os > > JAVA="${TESTJAVA}/bin/java" > -CP=${TESTJAVA}${FS}lib${FS}tools.jar${PS}${TESTCLASSES} > +CP=${TESTJAVA}${FS}lib${FS}tools.jar${PS}${TESTCLASSES}${PS}${TESTCLASSES}${FS}..${FS}..${FS}testlibrary > > ${JAVA} ${TESTVMOPTS} -classpath ${CP} MonitorVmStartTerminate > > > > [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131112/aea40473/attachment.html From mandy.chung at oracle.com Tue Nov 12 14:03:58 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 12 Nov 2013 14:03:58 -0800 Subject: 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError In-Reply-To: <52829F08.2080909@oracle.com> References: <52829F08.2080909@oracle.com> Message-ID: <5282A5CE.6050001@oracle.com> The patch looks okay to me. Mandy On 11/12/2013 1:35 PM, Alan Bateman wrote: > > This test was liberated earlier today via JDK- 6543856 [1]. > Unfortunately it is failing again, this time with a > NoClassDefFoundError because it can't locate the JavaProcess class. > The issue can be quickly fixed with the attached patched (to add > testlibrary to the classpah). Alternatively we can exclude this test > again, pending a re-visit of this test and perhaps eliminating the > shell script. > > -Alan. > > > diff --git > a/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > b/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > --- a/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > +++ b/test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh > @@ -38,6 +38,6 @@ > verify_os > > JAVA="${TESTJAVA}/bin/java" > -CP=${TESTJAVA}${FS}lib${FS}tools.jar${PS}${TESTCLASSES} > +CP=${TESTJAVA}${FS}lib${FS}tools.jar${PS}${TESTCLASSES}${PS}${TESTCLASSES}${FS}..${FS}..${FS}testlibrary > > ${JAVA} ${TESTVMOPTS} -classpath ${CP} MonitorVmStartTerminate > > > > [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131112/1a4ff8b0/attachment.html From serguei.spitsyn at oracle.com Tue Nov 12 14:19:07 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 12 Nov 2013 14:19:07 -0800 Subject: RFR(S): 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh In-Reply-To: <528290B1.20507@oracle.com> References: <528290B1.20507@oracle.com> Message-ID: <5282A95B.6030306@oracle.com> Erik, The fix looks good. Thanks, Serguei On 11/12/13 12:33 PM, Erik Gahlin wrote: > Could I please have a review of a regression test that fails > intermittently because a full GC is not always triggered. > > Fix is to call System.gc() > > Webrev: > http://cr.openjdk.java.net/~egahlin/6954510_1 > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6954510 > > Thanks > Erik From alan.bateman at oracle.com Tue Nov 12 23:44:59 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 13 Nov 2013 07:44:59 +0000 Subject: hg: jdk8/tl/jdk: 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError Message-ID: <20131113074515.A6FB762564@hg.openjdk.java.net> Changeset: c4c84b5a3dfa Author: alanb Date: 2013-11-13 07:43 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4c84b5a3dfa 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError Reviewed-by: mchung, egahlin ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh From staffan.larsen at oracle.com Wed Nov 13 01:31:19 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 13 Nov 2013 10:31:19 +0100 Subject: RFR(S): 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh In-Reply-To: <528290B1.20507@oracle.com> References: <528290B1.20507@oracle.com> Message-ID: <690E7A6F-815F-4E4B-AE66-6139D829C6E0@oracle.com> Looks good! Thanks, /Staffan On 12 Nov 2013, at 21:33, Erik Gahlin wrote: > Could I please have a review of a regression test that fails intermittently because a full GC is not always triggered. > > Fix is to call System.gc() > > Webrev: > http://cr.openjdk.java.net/~egahlin/6954510_1 > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6954510 > > Thanks > Erik From markus.gronlund at oracle.com Wed Nov 13 01:46:02 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Wed, 13 Nov 2013 01:46:02 -0800 (PST) Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> Message-ID: <58a6b698-bf13-424a-9b95-deb676155b39@default> Hi again! Thank you for spotting these! I'm sorry, silly mistakes. I have updated lines 51-53 to: 51 inline bool operator<=(const Tickspan& lhs, const Tickspan& rhs) { 52 return !operator>(lhs,rhs); 53 } And lines 97-99 as: 97 inline bool operator<=(const Ticks& lhs, const Ticks& rhs) { 98 return !operator>(lhs,rhs); 99 } Thanks Vitaly! Cheers Markus From: Vitaly Davidovich [mailto:vitalyd at gmail.com] Sent: den 13 november 2013 02:19 To: Markus Gronlund Cc: hotspot-runtime-dev at openjdk.java.net; serviceability-dev; hotspot-gc-dev at openjdk.java.net Subject: RE: RFR(M): 8028128: Add a type safe alternative for working with counter based data Similar issue with the Ticks versions. Sent from my phone On Nov 12, 2013 8:17 PM, "Vitaly Davidovich" wrote: Yeah, naming things is often a pain. 51 inline bool operator<=(const Tickspan& lhs, const Tickspan& rhs) { 52 return !operator<(lhs,rhs); 53 } 54 55 inline bool operator>=(const Tickspan& lhs, const Tickspan& rhs) { 56 return !operator<(lhs,rhs); 57 } These look like bugs; first one should probably be !operator>(lhs,rhs) and !operator<(lhs,rhs), respectively. Sent from my phone On Nov 12, 2013 10:32 AM, "Markus Gronlund" wrote: Hi Vitaly, Thanks for you input! "You have some operator overloads for these that can compare them against jlongs - doesn't that still make it easy to mix up what you're comparing? Personally, since these are value types I'd make their API work only against these new types and make caller create the right type for comparison." Thanks for spotting these - the compare against jlongs in from an older version of the webrev where this was allowed - you are right, it should not be allowed, I thought I had updated this, will remove them - many thanks for spotting. As for the names, "Ticks and Tickspan don't seem too optimal of names. What about TimeInstance and TimeSpan?" I agree with you that the names could possibly be improved, believe me I have tried to use multiple names - one thing I wanted was to emphasize that these types (currently) are only based on counter's (i.e ticks), and do not represent any higher "time" abstraction. That is, the implementation is tied to data from counters (based on ticks with a specific ticks frequency). In my current context, I use these values to talk about "time" (as you saw from the original post), but "time" can mean many things to different people, esp. many implementations and clock sources. Also, there already exist a few "Time/Timer" types (although they are not as good as I want them to be for current purposes), for example there is a type called Timestamp (in runtime/timers.hpp). I have come to the conclusion that in order to address the overall time abstractions in Hotspot, we would need to make a larger effort - this we should indeed do, but it's outside the current scope. Also I am pretty sure that when we do revisit the time abstractions, the names for these types will most likely change - that made me leave the names to emphasize the "ticks" sources. Thanks for your input. Best regards Markus From: Vitaly Davidovich [mailto:HYPERLINK "mailto:vitalyd at gmail.com" \nvitalyd at gmail.com] Sent: den 12 november 2013 15:37 To: Markus Gronlund Cc: serviceability-dev; HYPERLINK "mailto:hotspot-runtime-dev at openjdk.java.net" \nhotspot-runtime-dev at openjdk.java.net; HYPERLINK "mailto:hotspot-gc-dev at openjdk.java.net" \nhotspot-gc-dev at openjdk.java.net Subject: Re: RFR(M): 8028128: Add a type safe alternative for working with counter based data Hi Markus, Ticks and Tickspan don't seem too optimal of names. What about TimeInstance and TimeSpan? You have some operator overloads for these that can compare them against jlongs - doesn't that still make it easy to mix up what you're comparing? Personally, since these are value types I'd make their API work only against these new types and make caller create the right type for comparison. Just my $.02, feel free to ignore :). Thanks Sent from my phone On Nov 12, 2013 6:16 AM, "Markus Gronlund" wrote: Greetings, Kindly asking for reviews for the following changeset: Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 Description: Currently, when working with counter based data, the primary data type representation in the VM are raw jlong's. jlong's are employed to represent both: 1. a single instance in time, for example a "now" timestamp 2. a time duration, a timespan, for example the duration between "now" - "then" Having a raw jlong type represent both of these shifts the responsibility to the programmer to always ensure the correct validity of the counter data, without any assistance either at compile time or at runtime. The event based tracing framework relies heavily on counter based data in order to keep track of time and timing related information and we have seen counter data errors where the representation sent to the tracing framework has submitted the wrong time, i.e. a timespan when a time instant was expected and vice versa. We should therefore add an alternative to jlongs for representing counter based data. We should enlist the help of the type system to enforce the correct data types at compile time as well as introduce strong runtime asserts in order to help with the correct usage of time and to reduce the number of potential bugs. I will therefore add two new types in src/share/vm/utilities: 1. "Ticks" - represents a single counter based timestamp, a single instance in time. 2. "Tickspan" - represents a counter based duration, a timespan, between two "Ticks" Please see the added files: - src/share/vm/utilities/ticks.hpp - src/share/vm/utilities/ticks.inline.hpp - src/share/vm/utilities/ticks.cpp I have also updated some of the existing event based tracing "event sites" to employ usage of these new types as well as updated a few places in the event based tracing framework implementation to accommodate these types. Testing completed: nsk.stress.testlist (UTE/Aurora) GC nightlies (Aurora) gc/gctests/* (UTE/Aurora) nsk.gc.testlist (UTE/Aurora) SpecJBB2013 (no regression) SpecJBB2005 (no regression) Kitchensink (locally Windows) runs for +> 9 days (still running.) Thanks in advance Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131113/afd1dcff/attachment-0001.html From xuelei.fan at oracle.com Wed Nov 13 01:16:44 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 13 Nov 2013 09:16:44 +0000 Subject: hg: jdk8/tl/jdk: 8023147: Test DisabledShortRSAKeys.java intermittent failed Message-ID: <20131113091702.709E062568@hg.openjdk.java.net> Changeset: 1158d504e39e Author: xuelei Date: 2013-11-13 01:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1158d504e39e 8023147: Test DisabledShortRSAKeys.java intermittent failed Reviewed-by: mullan ! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java From daniel.fuchs at oracle.com Wed Nov 13 01:51:29 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Wed, 13 Nov 2013 09:51:29 +0000 Subject: hg: jdk8/tl/jdk: 8026952: Test java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has wrong @bug id Message-ID: <20131113095143.6488E6256C@hg.openjdk.java.net> Changeset: 30a3aefc4084 Author: dfuchs Date: 2013-11-13 10:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30a3aefc4084 8026952: Test java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has wrong @bug id Summary: Trivial: change @bug 8023163 into @bug 8026499 Reviewed-by: mchung, alanb ! test/java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java From staffan.larsen at oracle.com Wed Nov 13 02:20:10 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 13 Nov 2013 11:20:10 +0100 Subject: RFR (XS): 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently In-Reply-To: <32a27f01-bf13-4f28-ba10-7e5408611387@default> References: <32a27f01-bf13-4f28-ba10-7e5408611387@default> Message-ID: <7CE0962A-ACC3-4F83-80EC-98351D61C84A@oracle.com> Looks good! Sorry for taking so long to review. ./test/lib/testlibrary/jdk/testlibrary/Utils.java L78: nit: missing spaces around = and < /Staffan On 08 Nov 2013, at 15:48, Mattias Tobiasson wrote: > Hi, > Could you please review this fix. > The tests for java/lang/instrument/PremainClass/PremainAgent has been ported from script to java. > The purpose is to make the tests more stable and easier to maintain. > > Thanks, > Mattias > > Webrev: > http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8023138 From staffan.larsen at oracle.com Wed Nov 13 02:23:43 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 13 Nov 2013 11:23:43 +0100 Subject: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary In-Reply-To: <527BB658.4000208@oracle.com> References: <527B9F28.3060303@oracle.com> <527BB658.4000208@oracle.com> Message-ID: Assuming that you have verified the changes by running relevant tests this looks good. Reviewed. Thanks, /Staffan On 07 Nov 2013, at 16:48, Yekaterina Kantserova wrote: > Adding hotspot-dev group. > > -------- Original Message -------- > Subject: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary > Date: Thu, 07 Nov 2013 15:09:44 +0100 > From: Yekaterina Kantserova > To: Serviceability Dev > > > > Hi, > > Could I please have a review of this fix. > > The following has been done: > - updated OutputAnalyzer and ProcessTool with changes from hotspot/testlibrary; > - added test classes AssertsTest and OutputAnalyzerReportingTest from hotspot/testlibrary; > - added InputArguments class from hotspot/testlibrary (provides access to the input arguments to the VM); > - removed JdkFinder (it's replaced with JDKToolLauncher); > - re-wrote JcmdBase to use JDKToolLauncher instead of JdkFinder. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8015497 > > Webrev: > http://cr.openjdk.java.net/~ykantser/8015497/webrev.00/ > > Thanks, > Katja > From yekaterina.kantserova at oracle.com Wed Nov 13 02:34:51 2013 From: yekaterina.kantserova at oracle.com (Yekaterina Kantserova) Date: Wed, 13 Nov 2013 11:34:51 +0100 Subject: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary In-Reply-To: References: <527B9F28.3060303@oracle.com> <527BB658.4000208@oracle.com> Message-ID: <528355CB.4060604@oracle.com> On 11/13/2013 11:23 AM, Staffan Larsen wrote: > Assuming that you have verified the changes by running relevant tests this looks good. Yes, I did. Thanks! > > Reviewed. > > Thanks, > /Staffan > > On 07 Nov 2013, at 16:48, Yekaterina Kantserova wrote: > >> Adding hotspot-dev group. >> >> -------- Original Message -------- >> Subject: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary >> Date: Thu, 07 Nov 2013 15:09:44 +0100 >> From: Yekaterina Kantserova >> To: Serviceability Dev >> >> >> >> Hi, >> >> Could I please have a review of this fix. >> >> The following has been done: >> - updated OutputAnalyzer and ProcessTool with changes from hotspot/testlibrary; >> - added test classes AssertsTest and OutputAnalyzerReportingTest from hotspot/testlibrary; >> - added InputArguments class from hotspot/testlibrary (provides access to the input arguments to the VM); >> - removed JdkFinder (it's replaced with JDKToolLauncher); >> - re-wrote JcmdBase to use JDKToolLauncher instead of JdkFinder. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8015497 >> >> Webrev: >> http://cr.openjdk.java.net/~ykantser/8015497/webrev.00/ >> >> Thanks, >> Katja >> From jaroslav.bachorik at oracle.com Wed Nov 13 04:13:53 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Wed, 13 Nov 2013 12:13:53 +0000 Subject: hg: jdk8/tl/jdk: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently Message-ID: <20131113121406.976CA6256E@hg.openjdk.java.net> Changeset: 680ef14a2cc0 Author: jbachorik Date: 2013-11-13 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/680ef14a2cc0 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently Reviewed-by: dholmes, ykantser ! test/com/sun/jdi/BadHandshakeTest.java From erik.gahlin at oracle.com Wed Nov 13 06:27:41 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Wed, 13 Nov 2013 14:27:41 +0000 Subject: hg: jdk8/tl/jdk: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java Message-ID: <20131113142753.A0AA96256F@hg.openjdk.java.net> Changeset: ddaa9a8acaed Author: egahlin Date: 2013-11-13 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddaa9a8acaed 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java Reviewed-by: sla, jbachorik ! test/ProblemList.txt ! test/javax/management/loading/LibraryLoader/LibraryLoaderTest.java From staffan.larsen at oracle.com Wed Nov 13 06:34:56 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 13 Nov 2013 14:34:56 +0000 Subject: hg: jdk8/tl/jdk: 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Message-ID: <20131113143508.BBA8062570@hg.openjdk.java.net> Changeset: a42a416351b8 Author: ykantser Date: 2013-11-13 11:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42a416351b8 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Reviewed-by: sla + test/lib/testlibrary/AssertsTest.java + test/lib/testlibrary/OutputAnalyzerReportingTest.java + test/lib/testlibrary/jdk/testlibrary/InputArguments.java ! test/lib/testlibrary/jdk/testlibrary/JcmdBase.java - test/lib/testlibrary/jdk/testlibrary/JdkFinder.java ! test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java From mandy.chung at oracle.com Wed Nov 13 07:55:40 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 13 Nov 2013 15:55:40 +0000 Subject: hg: jdk8/tl/jdk: 8028234: Remove unused methods in sun.misc.JavaAWTAccess Message-ID: <20131113155557.74F7162577@hg.openjdk.java.net> Changeset: 7c55fecfae65 Author: mchung Date: 2013-11-13 07:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c55fecfae65 8028234: Remove unused methods in sun.misc.JavaAWTAccess Reviewed-by: art, dfuchs, lancea ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/misc/JavaAWTAccess.java ! test/java/util/logging/TestAppletLoggerContext.java From chris.hegarty at oracle.com Wed Nov 13 08:50:22 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 13 Nov 2013 16:50:22 +0000 Subject: hg: jdk8/tl/jdk: 8022213: Intermittent test failures in java/net/URLClassLoader Message-ID: <20131113165036.69A376257A@hg.openjdk.java.net> Changeset: 70f1bed5e7fd Author: chegar Date: 2013-11-13 16:44 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70f1bed5e7fd 8022213: Intermittent test failures in java/net/URLClassLoader Reviewed-by: dxu, alanb ! test/java/net/URLClassLoader/closetest/CloseTest.java ! test/java/net/URLClassLoader/closetest/Common.java ! test/java/net/URLClassLoader/closetest/GetResourceAsStream.java + test/lib/testlibrary/jdk/testlibrary/FileUtils.java From alan.bateman at oracle.com Wed Nov 13 09:08:02 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 13 Nov 2013 17:08:02 +0000 Subject: hg: jdk8/tl/jdk: 8028270: Files.readSymbolicLink calls AccessController directly so security manager can't grant the permission Message-ID: <20131113170815.347746257C@hg.openjdk.java.net> Changeset: a493871959c2 Author: alanb Date: 2013-11-13 16:52 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a493871959c2 8028270: Files.readSymbolicLink calls AccessController directly so security manager can't grant the permission Reviewed-by: mchung, martin, chegar ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! test/java/nio/file/Files/CheckPermissions.java From erik.gahlin at oracle.com Wed Nov 13 09:39:05 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Wed, 13 Nov 2013 17:39:05 +0000 Subject: hg: jdk8/tl/jdk: 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Message-ID: <20131113173917.E60F76257F@hg.openjdk.java.net> Changeset: 256b3395346b Author: egahlin Date: 2013-11-13 18:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/256b3395346b 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Reviewed-by: sla, sspitsyn ! test/com/sun/jdi/BreakpointWithFullGC.sh From karen.kinnear at oracle.com Wed Nov 13 09:57:20 2013 From: karen.kinnear at oracle.com (karen.kinnear at oracle.com) Date: Wed, 13 Nov 2013 17:57:20 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8027229: ICCE expected for >=2 maximally specific default methods. Message-ID: <20131113175722.706E962582@hg.openjdk.java.net> Changeset: fce21ac5968d Author: acorn Date: 2013-11-13 07:31 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fce21ac5968d 8027229: ICCE expected for >=2 maximally specific default methods. Summary: Need to process defaults for interfaces for invokespecial Reviewed-by: lfoltan, hseigel, coleenp, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/oops/klassVtable.cpp From joe.darcy at oracle.com Wed Nov 13 11:07:25 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 13 Nov 2013 19:07:25 +0000 Subject: hg: jdk8/tl/jdk: 8028300: Fix raw type lint warnings in java.util.concurrent Message-ID: <20131113190739.7517462583@hg.openjdk.java.net> Changeset: e6333788b117 Author: darcy Date: 2013-11-13 11:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117 8028300: Fix raw type lint warnings in java.util.concurrent Reviewed-by: chegar, martin ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java From xueming.shen at oracle.com Wed Nov 13 11:32:02 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 13 Nov 2013 19:32:02 +0000 Subject: hg: jdk8/tl/jdk: 8027645: Pattern.split() with positive lookahead; ... Message-ID: <20131113193214.D483262584@hg.openjdk.java.net> Changeset: 9e37caf07ce0 Author: sherman Date: 2013-11-13 11:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e37caf07ce0 8027645: Pattern.split() with positive lookahead 6559590: Pattern.compile(".*").split("") returns incorrect result Summary: updated spec/impl for these two corner cases Reviewed-by: alanb, psandoz ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/regex/Pattern.java ! test/java/lang/String/Split.java ! test/java/util/regex/RegExTest.java From lana.steuck at oracle.com Wed Nov 13 11:49:57 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Nov 2013 19:49:57 +0000 Subject: hg: jdk8/tl/hotspot: 18 new changesets Message-ID: <20131113195035.6D74A62586@hg.openjdk.java.net> Changeset: 5b84039ca739 Author: amurillo Date: 2013-11-01 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5b84039ca739 8027580: new hotspot build - hs25-b58 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ea79ab313e98 Author: mgerdin Date: 2013-10-30 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea79ab313e98 8027252: Crash in interpreter because get_unsigned_2_byte_index_at_bcp reads 4 bytes Summary: Use 2-byte loads to load indexes from the byte code stream to avoid out of bounds reads. Reviewed-by: coleenp, sspitsyn ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: fdd464c8d62e Author: acorn Date: 2013-10-30 09:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fdd464c8d62e 8027304: Lambda: inheriting abstract + 1 default -> default, not ICCE Reviewed-by: hseigel, zgu ! src/share/vm/classfile/defaultMethods.cpp Changeset: 4fe7815b04f5 Author: acorn Date: 2013-10-30 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4fe7815b04f5 Merge Changeset: c8fc12209830 Author: coleenp Date: 2013-10-31 14:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c8fc12209830 8027616: Off by one error in putback for compressed oops nashorn performance improvement Summary: Should compare bounds greater than or equal 4G when deciding if shift is needed or CDS area + compressed class space are within 4G of each other. Reviewed-by: stefank, hseigel, zgu ! src/share/vm/memory/metaspace.cpp Changeset: 910026b800b8 Author: coleenp Date: 2013-11-01 10:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/910026b800b8 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodHandle 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might not work with anonymous classes Summary: Walk methods in breakpoints for marking on stack so they aren't deallocated by redefine classes. Use class_holder rather than class_loader to keep GC from reclaiming class owning the method. Reviewed-by: sspitsyn, ehelin, sla ! src/share/vm/classfile/metadataOnStackMark.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp Changeset: 42790b7e4d48 Author: mgronlun Date: 2013-11-01 15:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/42790b7e4d48 Merge ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: f8b56489e455 Author: mgronlun Date: 2013-11-01 17:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f8b56489e455 Merge Changeset: 04df110c8655 Author: mgronlun Date: 2013-11-02 20:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/04df110c8655 Merge Changeset: 208ebea980f8 Author: roland Date: 2013-11-04 21:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/208ebea980f8 8027445: SIGSEGV at TestFloatingDecimal.testAppendToDouble()I Summary: String.equals() intrinsic shouldn't use integer length input in pointer arithmetic without an i2l. Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sparc.ad + test/compiler/intrinsics/stringequals/TestStringEqualsBadLength.java Changeset: e428d5e768e3 Author: rbackman Date: 2013-11-04 10:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e428d5e768e3 8027622: java.time.Instant.create failing since hs25-b56 Reviewed-by: kvn, iveresov ! src/share/vm/opto/compile.cpp + test/compiler/intrinsics/mathexact/CompareTest.java Changeset: a905d33ce13a Author: iveresov Date: 2013-11-05 00:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a905d33ce13a 8027751: C1 crashes in Weblogic with G1 enabled Summary: Keep T_OBJECT operands in registers for logical operations on x64 Reviewed-by: kvn, roland ! src/share/vm/c1/c1_LinearScan.cpp + test/compiler/regalloc/C1ObjectSpillInLogicOp.java Changeset: 94a83e0f9ce1 Author: iveresov Date: 2013-11-05 01:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/94a83e0f9ce1 8017065: C2 allows safepoint checks to leak into G1 pre-barriers Summary: Make all raw loads strictly respect control dependencies, make sure RCE doesn't move raw loads, add verification of G1 pre-barriers. Reviewed-by: kvn, roland ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/memnode.hpp Changeset: 613e6a6fc328 Author: iveresov Date: 2013-11-05 02:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/613e6a6fc328 Merge ! src/share/vm/opto/compile.cpp Changeset: be525e91f65b Author: mikael Date: 2013-11-06 06:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/be525e91f65b 8026775: nsk/jvmti/RedefineClasses/StressRedefine crashes due to EXCEPTION_ACCESS_VIOLATION Summary: Uncommon trap blob did not bang all the stack shadow pages Reviewed-by: kvn, twisti, iveresov, jrose ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/asm/assembler.cpp + test/compiler/uncommontrap/UncommonTrapStackBang.java Changeset: 53662b2f1d68 Author: drchase Date: 2013-11-07 10:02 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/53662b2f1d68 Merge Changeset: e510dfdec6dd Author: amurillo Date: 2013-11-08 07:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e510dfdec6dd Merge Changeset: 52b076e6ffae Author: amurillo Date: 2013-11-08 07:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/52b076e6ffae Added tag hs25-b58 for changeset e510dfdec6dd ! .hgtags From eric.mccorkle at oracle.com Wed Nov 13 12:50:23 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Wed, 13 Nov 2013 20:50:23 +0000 Subject: hg: jdk8/tl/jdk: 8026884: test for fix of JDK-8021398 does not have @bug tag; ... Message-ID: <20131113205036.438CA6258F@hg.openjdk.java.net> Changeset: ea91826bc2e9 Author: emc Date: 2013-11-13 15:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea91826bc2e9 8026884: test for fix of JDK-8021398 does not have @bug tag 8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in generated api docs Summary: two documentation fixes Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! test/java/lang/reflect/Parameter/GetAnnotatedTypeTest.java From coleen.phillimore at oracle.com Wed Nov 13 16:33:33 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Thu, 14 Nov 2013 00:33:33 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change Message-ID: <20131114003335.75D5062592@hg.openjdk.java.net> Changeset: 41cb10cbfb3c Author: coleenp Date: 2013-11-13 16:42 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/41cb10cbfb3c 8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change Summary: Create extra constant pool cache entries for invokespecial/InterfaceMethodref to hold the alternate resolution. Reviewed-by: jrose, lfoltan, hseigel ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp From sonali.goel at oracle.com Wed Nov 13 16:36:45 2013 From: sonali.goel at oracle.com (sonali.goel at oracle.com) Date: Thu, 14 Nov 2013 00:36:45 +0000 Subject: hg: jdk8/tl/langtools: 8025113: Convert 7 tools TryWithResources tests to jtreg format Message-ID: <20131114003648.C95BA62593@hg.openjdk.java.net> Changeset: f90d88913c5f Author: sogoel Date: 2013-11-13 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f90d88913c5f 8025113: Convert 7 tools TryWithResources tests to jtreg format Reviewed-by: darcy, jjg + test/tools/javac/TryWithResources/ResDeclOutsideTry.java + test/tools/javac/TryWithResources/ResDeclOutsideTry.out + test/tools/javac/TryWithResources/ResInNestedExpr.java + test/tools/javac/TryWithResources/ResourceNameConflict.java + test/tools/javac/TryWithResources/ResourceNameConflict.out + test/tools/javac/TryWithResources/ResourceRedecl.java + test/tools/javac/TryWithResources/ResourceRedecl.out + test/tools/javac/TryWithResources/ResourceShadow.java + test/tools/javac/TryWithResources/TestTwr09.java From yumin.qi at oracle.com Wed Nov 13 19:17:31 2013 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Thu, 14 Nov 2013 03:17:31 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20131114031735.E915762597@hg.openjdk.java.net> Changeset: cdf20166ec45 Author: minqi Date: 2013-11-13 16:24 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cdf20166ec45 8025632: Remove all references to MagicLambdaImpl from Hotspot Summary: MagicLambdaImpl was removed from jdk side, this should be done in vm side too Reviewed-by: coleenp, hseigel, rdurbin ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/reflection.cpp ! test/compiler/jsr292/ConcurrentClassLoadingTest.java Changeset: 3edddbff4865 Author: minqi Date: 2013-11-13 16:35 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3edddbff4865 Merge From xueming.shen at oracle.com Wed Nov 13 22:29:09 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 14 Nov 2013 06:29:09 +0000 Subject: hg: jdk8/tl/jdk: 8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression Message-ID: <20131114062922.B87BA6259B@hg.openjdk.java.net> Changeset: 1d790a56de4e Author: sherman Date: 2013-11-13 22:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d790a56de4e 8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression Summary: to undo the change for 6559590 Reviewed-by: darcy ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/regex/Pattern.java ! test/java/lang/String/Split.java ! test/java/util/regex/RegExTest.java From staffan.larsen at oracle.com Wed Nov 13 23:34:09 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 08:34:09 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> Message-ID: <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> Still looking for an official Review of this change. Thanks, /Staffan On 11 Nov 2013, at 20:49, Staffan Larsen wrote: > The contract for the tools should be (similarly from other tools, eg javac): > > If the arguments are wrong or not specified: exit code != 0, usage output on stderr > If -help or -h is specified: exit code == 0, usage output on stderr > > webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-8027765 > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/d9494ee0/attachment.html From staffan.larsen at oracle.com Wed Nov 13 23:34:32 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 08:34:32 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: References: Message-ID: <7D602307-8075-4898-B172-4592C7C89F97@oracle.com> Still looking for an official Review of this change. Thanks, /Staffan On 11 Nov 2013, at 19:42, Staffan Larsen wrote: > Please review this small fix to output SA message to stdout instead of stderr. > > webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-6626412 > > Thanks, > /Staffan From staffan.larsen at oracle.com Wed Nov 13 23:34:48 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 08:34:48 +0100 Subject: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing In-Reply-To: References: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> <528138AF.6010705@oracle.com> Message-ID: <0351D9FE-7E6E-4D50-A97D-02635F74F8C7@oracle.com> Still looking for an official Review of this change. Thanks, /Staffan On 11 Nov 2013, at 21:25, Staffan Larsen wrote: > Ah, good catch. > > Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/ > > Thanks, > /Staffan > > On 11 Nov 2013, at 21:06, serguei.spitsyn at oracle.com wrote: > >> It looks good. >> >> The only one nit is about the line: >> 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags()); >> >> If one or both of Arguments.getJVMArgs() and Arguments.getJVMFlags() return null >> (not sure if it is the case) then the output will have "null" like this: >> "Command line: nullnull" >> >> Would it make sense to keep the original checks for non-null strings? >> >> >> Thanks, >> Serguei >> >> >> On 11/11/13 11:28 AM, Staffan Larsen wrote: >>> The problem here is that ?jinfo -flags? only looks at the command line, but if a user has changed a flag after the VM started (for example by using ?jinfo -flag?) that new value does not show up. >>> >>> I am changing the output so that ?jinfo -flags? now prints something like this: >>> >>> Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC >>> Command line: -XX:+PrintGCDetails >>> >>> >>> webrev: http://cr.openjdk.java.net/~sla/6606002/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-6606002 >>> >>> Thanks, >>> /Staffan >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/d7c72012/attachment-0001.html From staffan.larsen at oracle.com Wed Nov 13 23:35:30 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 08:35:30 +0100 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> <5277FEA3.4010101@oracle.com> Message-ID: <6D07D448-3A6F-4B69-AA26-6EF55B34CEB0@oracle.com> Still looking for an official Review of this change. Thanks, /Staffan On 11 Nov 2013, at 10:32, Staffan Larsen wrote: > Thanks Serguei! > > Can I have an official Review as well? > > /Staffan > > On 04 Nov 2013, at 21:08, serguei.spitsyn at oracle.com wrote: > >> Staffan, >> >> This one is really old: 11+ years. :) >> The fix is good, I do not see any issues. >> >> Thanks, >> Serguei >> >> >> On 11/4/13 6:41 AM, Staffan Larsen wrote: >>> This is an old one! Nothing like being bored on a plane... >>> >>> The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints. >>> >>> While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored). >>> >>> There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done. >>> >>> webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-4660158 >>> >>> Thanks, >>> /Staffan >> > From Alan.Bateman at oracle.com Wed Nov 13 23:57:25 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 14 Nov 2013 07:57:25 +0000 Subject: RFR for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <528440BF.2070909@oracle.com> References: <528440BF.2070909@oracle.com> Message-ID: <52848265.2070200@oracle.com> If you have a preliminary patch then I would suggest bringing it to serviceability-dev to discuss it. -Alan On 14/11/2013 03:17, Eric Wang wrote: > Hi Everyone, > > I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. > > It is a test bug as the test doesn't guarantee memory allocated from > the Old Gen, if the used memory is zero and doesn't cross the > threshold, no notification is sent, so both the main thread and > Checker thread are blocked to wait for the GC notification. > > so the suggested fix is similar as the fix ResetPeakMemoryUsage.java > to create > big object to make sure the old gen usage crosses the threshold and > run test with different GC vmoptions. > > Please let me know if you have any comments or suggestions. If you are > OK with the solution, I'll send a webrev in the next mail. > > Thanks, > Eric -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/e1b4e49f/attachment.html From Alan.Bateman at oracle.com Thu Nov 14 01:38:17 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 14 Nov 2013 09:38:17 +0000 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> Message-ID: <52849A09.7080407@oracle.com> On 14/11/2013 07:34, Staffan Larsen wrote: > Still looking for an official Review of this change. This looks okay to me (I surprised we hadn't noticed the usage message going to stderr before). Slightly different styles for if-the-else in JStack but not too interesting. I guess we could use strings-in-switch here if there are more options added. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/cc018583/attachment.html From weijun.wang at oracle.com Thu Nov 14 01:46:57 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 14 Nov 2013 17:46:57 +0800 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <52849A09.7080407@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> Message-ID: <52849C11.1060903@oracle.com> But it's changing from stdout to stderr in the webrev. At least GNU believes [1] it should go to stdout. It make the output more'able. Also, I am not sure if int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses. Thanks Max [1] http://www.gnu.org/prep/standards/html_node/_002d_002dhelp.html On 11/14/13, 17:38, Alan Bateman wrote: > On 14/11/2013 07:34, Staffan Larsen wrote: >> Still looking for an official Review of this change. > This looks okay to me (I surprised we hadn't noticed the usage message > going to stderr before). Slightly different styles for if-the-else in > JStack but not too interesting. I guess we could use strings-in-switch > here if there are more options added. > > -Alan From Alan.Bateman at oracle.com Thu Nov 14 02:08:36 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 14 Nov 2013 10:08:36 +0000 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <52849C11.1060903@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> Message-ID: <5284A124.6020508@oracle.com> On 14/11/2013 09:46, Weijun Wang wrote: > But it's changing from stdout to stderr in the webrev. At least GNU > believes [1] it should go to stdout. It make the output more'able. This is a confusing topic. I think the normal convention is that when there are invalid arguments that usage message is essentially the error message and so should go to stderr with the program exiting with an error code. On the other hand, -help is supposed to print to stderr and exit with a success. We should double check the launcher to make sure that we are consistent (although it has its own issues there). -Alan. From Alan.Bateman at oracle.com Thu Nov 14 02:10:44 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 14 Nov 2013 10:10:44 +0000 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <5284A124.6020508@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <5284A124.6020508@oracle.com> Message-ID: <5284A1A4.6040702@oracle.com> On 14/11/2013 10:08, Alan Bateman wrote: > On the other hand, -help is supposed to print to stderr and exit with > a success. I meant stdout here of course. From alan.bateman at oracle.com Thu Nov 14 02:43:36 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 14 Nov 2013 10:43:36 +0000 Subject: hg: jdk8/tl/jdk: 8028343: More ProblemList.txt updates (11/2013) Message-ID: <20131114104348.19AE1625A2@hg.openjdk.java.net> Changeset: ecf85f4aecf0 Author: alanb Date: 2013-11-14 10:40 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecf85f4aecf0 8028343: More ProblemList.txt updates (11/2013) Reviewed-by: chegar ! test/ProblemList.txt From joel.franck at oracle.com Thu Nov 14 03:42:36 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 14 Nov 2013 11:42:36 +0000 Subject: hg: jdk8/tl/jdk: 8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with -Dsun.reflect.noInflation=true Message-ID: <20131114114248.958AD625A8@hg.openjdk.java.net> Changeset: 83c768d6cb93 Author: jfranck Date: 2013-11-14 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c768d6cb93 8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with -Dsun.reflect.noInflation=true Reviewed-by: briangoetz ! src/share/classes/sun/reflect/ReflectionFactory.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java ! test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java From staffan.larsen at oracle.com Thu Nov 14 04:12:04 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 13:12:04 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <5284A124.6020508@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <5284A124.6020508@oracle.com> Message-ID: I?ve been trying to copy whatever javac does to be consistent. From the bug report: * If the arguments are wrong or not specified: exit code != 0, usage output on stderr * If -help or -h is specified: exit code == 0, usage output on stderr /Staffan On 14 Nov 2013, at 11:08, Alan Bateman wrote: > On 14/11/2013 09:46, Weijun Wang wrote: >> But it's changing from stdout to stderr in the webrev. At least GNU believes [1] it should go to stdout. It make the output more'able. > This is a confusing topic. I think the normal convention is that when there are invalid arguments that usage message is essentially the error message and so should go to stderr with the program exiting with an error code. On the other hand, -help is supposed to print to stderr and exit with a success. We should double check the launcher to make sure that we are consistent (although it has its own issues there). > > -Alan. From staffan.larsen at oracle.com Thu Nov 14 04:12:35 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 13:12:35 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <52849C11.1060903@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> Message-ID: On 14 Nov 2013, at 10:46, Weijun Wang wrote: > Also, I am not sure if > > int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; > > really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses. Good point. I?ll add parentheses. /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/9fbfc3a9/attachment.html From staffan.larsen at oracle.com Thu Nov 14 04:19:57 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 13:19:57 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> Message-ID: <22150EB2-055C-4FA6-9832-6133B3E6B7D6@oracle.com> Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ On 14 Nov 2013, at 13:12, Staffan Larsen wrote: > > On 14 Nov 2013, at 10:46, Weijun Wang wrote: > >> Also, I am not sure if >> >> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; >> >> really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses. > > Good point. I?ll add parentheses. > > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/a2ba83f5/attachment.html From aph at redhat.com Thu Nov 14 04:37:57 2013 From: aph at redhat.com (Andrew Haley) Date: Thu, 14 Nov 2013 12:37:57 +0000 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> Message-ID: <5284C425.10800@redhat.com> On 11/14/2013 12:12 PM, Staffan Larsen wrote: >> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; Please do not call a variable "exit". exit() is a standard function. Andrew. From staffan.larsen at oracle.com Thu Nov 14 04:44:05 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 13:44:05 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <5284C425.10800@redhat.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <5284C425.10800@redhat.com> Message-ID: <50B95961-B990-4957-950A-91DA19E6C18F@oracle.com> On 14 Nov 2013, at 13:37, Andrew Haley wrote: > On 11/14/2013 12:12 PM, Staffan Larsen wrote: >>> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; > > Please do not call a variable "exit". exit() is a standard function. Not in Java, unless you "import static java.lang.System.exit;". /Staffan From aph at redhat.com Thu Nov 14 04:45:12 2013 From: aph at redhat.com (Andrew Haley) Date: Thu, 14 Nov 2013 12:45:12 +0000 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <50B95961-B990-4957-950A-91DA19E6C18F@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <5284C425.10800@redhat.com> <50B95961-B990-4957-950A-91DA19E6C18F@oracle.com> Message-ID: <5284C5D8.3060706@redhat.com> On 11/14/2013 12:44 PM, Staffan Larsen wrote: > Not in Java, unless you "import static java.lang.System.exit;". Lord above, I am an idiot. My excuse is that I have been deep in HotSpot all morning. Please forget I ever posted that. :-) Andrew. From mattias.tobiasson at oracle.com Thu Nov 14 06:09:36 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Thu, 14 Nov 2013 06:09:36 -0800 (PST) Subject: RFR (XS): 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Message-ID: <98802a9c-a019-4307-945f-0397e9b09094@default> I have made the changes from the review: http://cr.openjdk.java.net/~ykantser/8023138/webrev.01 Could you please be my sponsor and submit the patch? Mattias ----- Original Message ----- From: staffan.larsen at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 13, 2013 11:20:12 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (XS): 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Looks good! Sorry for taking so long to review. ./test/lib/testlibrary/jdk/testlibrary/Utils.java L78: nit: missing spaces around = and < /Staffan On 08 Nov 2013, at 15:48, Mattias Tobiasson wrote: > Hi, > Could you please review this fix. > The tests for java/lang/instrument/PremainClass/PremainAgent has been ported from script to java. > The purpose is to make the tests more stable and easier to maintain. > > Thanks, > Mattias > > Webrev: > http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8023138 -------------- next part -------------- A non-text attachment was scrubbed... Name: 8023138.diff Type: text/x-patch Size: 19396 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/b5c9ef6d/8023138-0001.diff From coleen.phillimore at oracle.com Thu Nov 14 06:42:35 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 14 Nov 2013 09:42:35 -0500 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: <7D602307-8075-4898-B172-4592C7C89F97@oracle.com> References: <7D602307-8075-4898-B172-4592C7C89F97@oracle.com> Message-ID: <5284E15B.4030104@oracle.com> Looks good. Nice cleanup for the imports. Coleen On 11/14/2013 02:34 AM, Staffan Larsen wrote: > Still looking for an official Review of this change. > > Thanks, > /Staffan > > On 11 Nov 2013, at 19:42, Staffan Larsen wrote: > >> Please review this small fix to output SA message to stdout instead of stderr. >> >> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ >> bug: https://bugs.openjdk.java.net/browse/JDK-6626412 >> >> Thanks, >> /Staffan From erik.gahlin at oracle.com Thu Nov 14 06:53:48 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 14 Nov 2013 15:53:48 +0100 Subject: RFR: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails Message-ID: <5284E3FC.9030107@oracle.com> Could I have a review of a test that fails intermittently with an OOM. The fix is to reduce the amount allocated objects. Bug: https://bugs.openjdk.java.net/browse/JDK-7141544 Webrev: http://cr.openjdk.java.net/~egahlin/7141544_1/ Erik From Alan.Bateman at oracle.com Thu Nov 14 07:22:54 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 14 Nov 2013 15:22:54 +0000 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <22150EB2-055C-4FA6-9832-6133B3E6B7D6@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <22150EB2-055C-4FA6-9832-6133B3E6B7D6@oracle.com> Message-ID: <5284EACE.1040101@oracle.com> On 14/11/2013 12:19, Staffan Larsen wrote: > Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ > > A good spot by Max. The updated webrev looks okay to me in that it makes things consistent with the java launcher. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/68644574/attachment.html From staffan.larsen at oracle.com Thu Nov 14 07:43:33 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 16:43:33 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <5284EACE.1040101@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <22150EB2-055C-4FA6-9832-6133B3E6B7D6@oracle.com> <5284EACE.1040101@oracle.com> Message-ID: Thanks! On 14 Nov 2013, at 16:22, Alan Bateman wrote: > On 14/11/2013 12:19, Staffan Larsen wrote: >> >> Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ >> > A good spot by Max. The updated webrev looks okay to me in that it makes things consistent with the java launcher. > > -Alan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/b5ceb8d6/attachment.html From staffan.larsen at oracle.com Thu Nov 14 07:43:20 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 16:43:20 +0100 Subject: RFR: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails In-Reply-To: <5284E3FC.9030107@oracle.com> References: <5284E3FC.9030107@oracle.com> Message-ID: <00F98B2A-E7C1-4204-88D4-4620A3BB88ED@oracle.com> Looks good! Thanks, /Staffan On 14 Nov 2013, at 15:53, Erik Gahlin wrote: > Could I have a review of a test that fails intermittently with an OOM. > > The fix is to reduce the amount allocated objects. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-7141544 > > Webrev: > http://cr.openjdk.java.net/~egahlin/7141544_1/ > > Erik From peter.allwin at oracle.com Thu Nov 14 07:53:06 2013 From: peter.allwin at oracle.com (Peter Allwin) Date: Thu, 14 Nov 2013 16:53:06 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <22150EB2-055C-4FA6-9832-6133B3E6B7D6@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <22150EB2-055C-4FA6-9832-6133B3E6B7D6@oracle.com> Message-ID: <58FFE735-F3FA-4692-8F5C-9DC068E67840@oracle.com> Hi Staffan, 84 int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; Looks like one more case of this. Thanks! /peter On 14 Nov 2013, at 13:19, Staffan Larsen wrote: > Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ > > On 14 Nov 2013, at 13:12, Staffan Larsen wrote: > >> >> On 14 Nov 2013, at 10:46, Weijun Wang wrote: >> >>> Also, I am not sure if >>> >>> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; >>> >>> really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses. >> >> Good point. I?ll add parentheses. >> >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/9a4a27c1/attachment.html From eric.mccorkle at oracle.com Thu Nov 14 09:33:25 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 14 Nov 2013 17:33:25 +0000 Subject: hg: jdk8/tl/langtools: 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java Message-ID: <20131114173330.0D859625BF@hg.openjdk.java.net> Changeset: 24eaf41a3974 Author: emc Date: 2013-11-14 12:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/24eaf41a3974 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java Summary: Remove @ignore from test Reviewed-by: jjg ! test/tools/javac/T7042623.java From staffan.larsen at oracle.com Thu Nov 14 10:24:39 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 19:24:39 +0100 Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent In-Reply-To: <58FFE735-F3FA-4692-8F5C-9DC068E67840@oracle.com> References: <784FF126-70FD-4C9D-88B6-470A98447086@oracle.com> <75826516-39AC-4DC0-9A1D-8133272A630D@oracle.com> <52849A09.7080407@oracle.com> <52849C11.1060903@oracle.com> <22150EB2-055C-4FA6-9832-6133B3E6B7D6@oracle.com> <58FFE735-F3FA-4692-8F5C-9DC068E67840@oracle.com> Message-ID: <12352F7C-5FF3-4B8E-889B-2B1A45F17E62@oracle.com> Missed that one. I?ll fix it in the same way before pushing. /Staffan On 14 Nov 2013, at 16:53, Peter Allwin wrote: > Hi Staffan, > 84 int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; > Looks like one more case of this. > > > Thanks! > /peter > > > On 14 Nov 2013, at 13:19, Staffan Larsen wrote: > >> Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ >> >> On 14 Nov 2013, at 13:12, Staffan Larsen wrote: >> >>> >>> On 14 Nov 2013, at 10:46, Weijun Wang wrote: >>> >>>> Also, I am not sure if >>>> >>>> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; >>>> >>>> really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses. >>> >>> Good point. I?ll add parentheses. >>> >>> /Staffan >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/07b1a839/attachment.html From staffan.larsen at oracle.com Thu Nov 14 10:26:29 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 19:26:29 +0100 Subject: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing In-Reply-To: <5284E25B.7070600@oracle.com> References: <9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com> <528138AF.6010705@oracle.com> <0351D9FE-7E6E-4D50-A97D-02635F74F8C7@oracle.com> <5284E25B.7070600@oracle.com> Message-ID: <99289190-3379-491F-A716-FD828D7DBC58@oracle.com> Good one. I?ll fix that before pushing. Thanks for the review! /Staffan On 14 Nov 2013, at 15:46, Coleen Phillimore wrote: > > You could change this line to be the nicer Java way to iterate over arrays: > > + for (int f = 0; f < flags.length; f++) { > > > Otherwise, looks good. > > Coleen > > On 11/14/2013 02:34 AM, Staffan Larsen wrote: >> Still looking for an official Review of this change. >> >> Thanks, >> /Staffan >> >> On 11 Nov 2013, at 21:25, Staffan Larsen wrote: >> >>> Ah, good catch. >>> >>> Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/ >>> >>> Thanks, >>> /Staffan >>> >>> On 11 Nov 2013, at 21:06, serguei.spitsyn at oracle.com wrote: >>> >>>> It looks good. >>>> >>>> The only one nit is about the line: >>>> 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags()); >>>> >>>> If one or both of Arguments.getJVMArgs() and Arguments.getJVMFlags() return null >>>> (not sure if it is the case) then the output will have "null" like this: >>>> "Command line: nullnull" >>>> >>>> Would it make sense to keep the original checks for non-null strings? >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 11/11/13 11:28 AM, Staffan Larsen wrote: >>>>> The problem here is that ?jinfo -flags? only looks at the command line, but if a user has changed a flag after the VM started (for example by using ?jinfo -flag?) that new value does not show up. >>>>> >>>>> I am changing the output so that ?jinfo -flags? now prints something like this: >>>>> >>>>> Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC >>>>> Command line: -XX:+PrintGCDetails >>>>> >>>>> >>>>> webrev: http://cr.openjdk.java.net/~sla/6606002/webrev.00/ >>>>> bug: https://bugs.openjdk.java.net/browse/JDK-6606002 >>>>> >>>>> Thanks, >>>>> /Staffan >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/d7c25481/attachment.html From staffan.larsen at oracle.com Thu Nov 14 10:34:23 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 14 Nov 2013 18:34:23 +0000 Subject: hg: jdk8/tl/jdk: 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Message-ID: <20131114183436.E0B7A625CE@hg.openjdk.java.net> Changeset: 65f7b83ab477 Author: sla Date: 2013-11-14 19:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65f7b83ab477 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Reviewed-by: alanb, allwin, sspitsyn, mgronlun ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jps/Jps.java ! src/share/classes/sun/tools/jstack/JStack.java From staffan.larsen at oracle.com Thu Nov 14 11:01:31 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 14 Nov 2013 20:01:31 +0100 Subject: RFR(S): 6626412 jstack using SA prints some info messages into err stream In-Reply-To: <5284E15B.4030104@oracle.com> References: <7D602307-8075-4898-B172-4592C7C89F97@oracle.com> <5284E15B.4030104@oracle.com> Message-ID: <9DD0683A-3052-4C64-BB0B-AE69E3A980B1@oracle.com> The import cleanup was done automatically by the IDE. Thanks, /Staffan On 14 Nov 2013, at 15:42, Coleen Phillimore wrote: > > Looks good. Nice cleanup for the imports. > Coleen > > On 11/14/2013 02:34 AM, Staffan Larsen wrote: >> Still looking for an official Review of this change. >> >> Thanks, >> /Staffan >> >> On 11 Nov 2013, at 19:42, Staffan Larsen wrote: >> >>> Please review this small fix to output SA message to stdout instead of stderr. >>> >>> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-6626412 >>> >>> Thanks, >>> /Staffan > From john.coomes at oracle.com Thu Nov 14 11:11:51 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 14 Nov 2013 19:11:51 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b116 for changeset 5fdc44652089 Message-ID: <20131114191153.4279D625EA@hg.openjdk.java.net> Changeset: 7299367c8aa4 Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/7299367c8aa4 Added tag jdk8-b116 for changeset 5fdc44652089 ! .hgtags From john.coomes at oracle.com Thu Nov 14 11:12:01 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 14 Nov 2013 19:12:01 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b116 for changeset e757eb9aee3d Message-ID: <20131114191208.4B0AF625EB@hg.openjdk.java.net> Changeset: c1d234d4f164 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/c1d234d4f164 Added tag jdk8-b116 for changeset e757eb9aee3d ! .hgtags From john.coomes at oracle.com Thu Nov 14 11:12:15 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 14 Nov 2013 19:12:15 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b116 for changeset 587560c222a2 Message-ID: <20131114191222.D2064625EC@hg.openjdk.java.net> Changeset: fe56ba456fd3 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/fe56ba456fd3 Added tag jdk8-b116 for changeset 587560c222a2 ! .hgtags From john.coomes at oracle.com Thu Nov 14 11:11:44 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 14 Nov 2013 19:11:44 +0000 Subject: hg: hsx/hotspot-rt: 3 new changesets Message-ID: <20131114191144.D1C1B625E9@hg.openjdk.java.net> Changeset: c1029b02ca87 Author: ihse Date: 2013-11-08 09:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c1029b02ca87 8027836: Webrev should handle files that has been moved from a directory which now is removed. Reviewed-by: mduigou, tbell ! make/scripts/webrev.ksh Changeset: cbfe5da942c6 Author: katleman Date: 2013-11-11 15:06 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/cbfe5da942c6 Merge Changeset: a4afb0a8d55e Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/a4afb0a8d55e Added tag jdk8-b116 for changeset cbfe5da942c6 ! .hgtags From john.coomes at oracle.com Thu Nov 14 11:15:26 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 14 Nov 2013 19:15:26 +0000 Subject: hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b116 for changeset 0fb1a427fbf6 Message-ID: <20131114191529.DB50E625EF@hg.openjdk.java.net> Changeset: 774c63629870 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/774c63629870 Added tag jdk8-b116 for changeset 0fb1a427fbf6 ! .hgtags From john.coomes at oracle.com Thu Nov 14 11:12:36 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 14 Nov 2013 19:12:36 +0000 Subject: hg: hsx/hotspot-rt/jdk: 5 new changesets Message-ID: <20131114191410.2D937625ED@hg.openjdk.java.net> Changeset: bdcba4854576 Author: erikj Date: 2013-11-07 10:51 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bdcba4854576 8027698: Platform specific jars are not being signed by the sign-jars target Reviewed-by: ihse, tbell, wetmore ! makefiles/SignJars.gmk Changeset: 295a641fc86b Author: erikj Date: 2013-11-07 14:06 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/295a641fc86b 8027406: JDK demos are missing source files Reviewed-by: alexsch, ihse ! makefiles/CompileDemos.gmk Changeset: 43168d403243 Author: anthony Date: 2013-11-08 20:07 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/43168d403243 8027912: [macosx] Provide means to force the headful mode on OS X when running via ssh Summary: Bypass AquaSession check if AWT_FORCE_HEADFUL env. variable is set to TRUE Reviewed-by: anthony, art Contributed-by: David Dehaven ! src/solaris/native/java/lang/java_props_macosx.c Changeset: 0dc0067f3b8e Author: katleman Date: 2013-11-11 15:06 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0dc0067f3b8e Merge Changeset: 483148bf625e Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/483148bf625e Added tag jdk8-b116 for changeset 0dc0067f3b8e ! .hgtags From john.coomes at oracle.com Thu Nov 14 11:15:10 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 14 Nov 2013 19:15:10 +0000 Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b116 for changeset 3c040b04af05 Message-ID: <20131114191520.B844B625EE@hg.openjdk.java.net> Changeset: 64d119680f0a Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/64d119680f0a Added tag jdk8-b116 for changeset 3c040b04af05 ! .hgtags From vicente.romero at oracle.com Thu Nov 14 11:28:57 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 14 Nov 2013 19:28:57 +0000 Subject: hg: jdk8/tl/langtools: 8026963: type annotations code crashes for code with erroneous trees Message-ID: <20131114192901.60365625F2@hg.openjdk.java.net> Changeset: e79d6425f1c4 Author: vromero Date: 2013-11-14 19:28 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e79d6425f1c4 8026963: type annotations code crashes for code with erroneous trees Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/T8026963/TypeAnnotationsCrashWithErroneousTreeTest.java + test/tools/javac/T8026963/TypeAnnotationsCrashWithErroneousTreeTest.out From coleen.phillimore at oracle.com Thu Nov 14 11:18:26 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Thu, 14 Nov 2013 19:18:26 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131114191851.C3BDD625F0@hg.openjdk.java.net> Changeset: 59f46f135584 Author: hseigel Date: 2013-11-14 10:44 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59f46f135584 8023041: The CDS classlist needs to be updated for JDK 8 Summary: Generate new classlists from JDK 8 classes Reviewed-by: alanb, coleenp, hseigel Contributed-by: ekaterina.pavlova at oracle.com ! make/tools/sharing/classlist.linux ! make/tools/sharing/classlist.macosx ! make/tools/sharing/classlist.solaris ! make/tools/sharing/classlist.windows Changeset: f893901ba29c Author: coleenp Date: 2013-11-14 14:01 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f893901ba29c Merge From bhavesh.x.patel at oracle.com Thu Nov 14 13:48:47 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Thu, 14 Nov 2013 21:48:47 +0000 Subject: hg: jdk8/tl/langtools: 8025524: javadoc does not correctly locate constructors for nested classes Message-ID: <20131114214851.77B44625FA@hg.openjdk.java.net> Changeset: 5ae66d372d57 Author: bpatel Date: 2013-11-14 13:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5ae66d372d57 8025524: javadoc does not correctly locate constructors for nested classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! test/com/sun/javadoc/testAnchorNames/TestAnchorNames.java + test/com/sun/javadoc/testConstructors/TestConstructors.java + test/com/sun/javadoc/testConstructors/pkg1/Outer.java ! test/tools/javadoc/generics/genericInnerAndOuter/expected.out From staffan.larsen at oracle.com Thu Nov 14 14:51:46 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 14 Nov 2013 22:51:46 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 6606002: jinfo doesn't detect dynamic vm flags changing Message-ID: <20131114225148.D2B8F625FC@hg.openjdk.java.net> Changeset: b03f33670080 Author: sla Date: 2013-11-14 19:30 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b03f33670080 6606002: jinfo doesn't detect dynamic vm flags changing Reviewed-by: coleenp, jbachorik, sspitsyn ! agent/src/share/classes/sun/jvm/hotspot/tools/JInfo.java From staffan.larsen at oracle.com Thu Nov 14 15:54:57 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 14 Nov 2013 23:54:57 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 6626412: jstack using SA prints some info messages into err stream Message-ID: <20131114235459.BB3DA625FE@hg.openjdk.java.net> Changeset: 5280822ddfcd Author: sla Date: 2013-11-14 20:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5280822ddfcd 6626412: jstack using SA prints some info messages into err stream Reviewed-by: coleenp, farvidsson, jbachorik, dsamersoff, sspitsyn ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java From xuelei.fan at oracle.com Thu Nov 14 16:09:50 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 15 Nov 2013 00:09:50 +0000 Subject: hg: jdk8/tl/jdk: 8014266: regression test AsyncSSLSocketClose.java time out. Message-ID: <20131115001002.D76A3625FF@hg.openjdk.java.net> Changeset: 40d0ccd00f87 Author: xuelei Date: 2013-11-14 16:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d0ccd00f87 8014266: regression test AsyncSSLSocketClose.java time out. Reviewed-by: xuelei Contributed-by: Rajan Halade ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java From yiming.wang at oracle.com Thu Nov 14 18:16:37 2013 From: yiming.wang at oracle.com (Eric Wang) Date: Fri, 15 Nov 2013 10:16:37 +0800 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently Message-ID: <52858405.2090809@oracle.com> Hi Everyone, I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. It is a test bug as the test doesn't guarantee memory allocated from the Old Gen, if the used memory is zero and doesn't cross the threshold, no notification is sent, so both the main thread and Checker thread are blocked to wait for the GC notification. so the suggested fix is similar as the fix ResetPeakMemoryUsage.java to create big object to make sure the old gen usage crosses the threshold and run test with different GC vmoptions. The different GC vmoptions are planed to be tested as below: @run main/othervm/timeout=300 -XX:+PrintGCDetails -XX:+UseSerialGC CollectionUsageThreshold @run main/othervm/timeout=300 -XX:+PrintGCDetails -XX:+UseParallelGC CollectionUsageThreshold @run main/othervm/timeout=300 -XX:+PrintGCDetails -XX:+UseG1GC CollectionUsageThreshold @run main/othervm/timeout=300 -XX:+PrintGCDetails -XX:+UseConcMarkSweepGC CollectionUsageThreshold @run main/othervm/timeout=300 -XX:+PrintGCDetails -Xmx2m -XX:+UseConcMarkSweepGC -XX:+ExplicitGCInvokesConcurrent CollectionUsageThreshold @run main/othervm/timeout=300 -XX:+PrintGCDetails -Xmx2m -Xconc -XX:+ExplicitGCInvokesConcurrent CollectionUsageThreshold @run main/othervm/timeout=300 -XX:+PrintGCDetails -Xmx2m -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent CollectionUsageThreshold Can you please give some suggestion about the solution? BTW, the fix is still in an internal discussion, i'll post the webrev when it is ready. Thanks, Eric -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131115/a51f5c80/attachment.html From mandy.chung at oracle.com Thu Nov 14 18:55:00 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 14 Nov 2013 18:55:00 -0800 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <52858405.2090809@oracle.com> References: <52858405.2090809@oracle.com> Message-ID: <52858D04.3080206@oracle.com> Hi Eric, On 11/14/2013 6:16 PM, Eric Wang wrote: > Hi Everyone, > > I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. > > It is a test bug as the test doesn't guarantee memory allocated from > the Old Gen, if the used memory is zero and doesn't cross the > threshold, no notification is sent, so both the main thread and > Checker thread are blocked to wait for the GC notification. > > so the suggested fix is similar as the fix ResetPeakMemoryUsage.java > to create > big object to make sure the old gen usage crosses the threshold and > run test with different GC vmoptions. What are you looking for specifically? I have provided the above information. I need to see the webrev to provide further feedback. Mandy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131114/8a5847f1/attachment.html From staffan.larsen at oracle.com Fri Nov 15 01:47:51 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 15 Nov 2013 10:47:51 +0100 Subject: RFR: 8027630 SIGSEGV in const char*Klass::external_name() Message-ID: <59A1AE6C-FA68-49C3-87EC-5DC0EAB7C19D@oracle.com> All, The StackFrameInfo class used when creating stack dumps from the management APIs keeps references to Methods. This is similar to what BacktraceBuilder does when creating stack traces in java_lang_Throwable::fill_in_stack_trace(). For permgen removal, BacktraceBuilder was updated to add a reference to the holder class of the methods, otherwise these classes can be unloaded. This fix adds the same kind of code to StackFrameInfo so that it now has an oop reference to the class. The new pop has been added to the oops_do() method. In addition, the Method reference needs to be made visible to the MetadataOnStackMark class. To fix this a long chain of metadata_do() calls have been added. I would really like to create a test for this race, but can?t figure out a reliable way to do so. bug: http://bugs.openjdk.java.net/browse/JDK-8027630 webrev: http://cr.openjdk.java.net/~sla/8027630/webrev.00/ Thanks, /Staffan From vicente.romero at oracle.com Fri Nov 15 03:09:04 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 15 Nov 2013 11:09:04 +0000 Subject: hg: jdk8/tl/langtools: 8026231: Look at 'static' flag when checking method references Message-ID: <20131115110918.2F41062617@hg.openjdk.java.net> Changeset: d4cbb671de1c Author: vromero Date: 2013-11-15 11:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4cbb671de1c 8026231: Look at 'static' flag when checking method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/lambda/MethodReference22.java ! test/tools/javac/lambda/MethodReference22.out ! test/tools/javac/lambda/MethodReference51.java ! test/tools/javac/lambda/MethodReference68.out + test/tools/javac/lambda/MethodReference73.java + test/tools/javac/lambda/MethodReference73.out ! test/tools/javac/lambda/TargetType60.java ! test/tools/javac/lambda/TargetType60.out From markus.gronlund at oracle.com Fri Nov 15 05:11:06 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Fri, 15 Nov 2013 05:11:06 -0800 (PST) Subject: RFR: 8027630 SIGSEGV in const char*Klass::external_name() In-Reply-To: <59A1AE6C-FA68-49C3-87EC-5DC0EAB7C19D@oracle.com> References: <59A1AE6C-FA68-49C3-87EC-5DC0EAB7C19D@oracle.com> Message-ID: <475ff467-c2c8-40b1-837b-68532267b7b7@default> Hi Staffan, Looks good. Thanks Markus -----Original Message----- From: Staffan Larsen Sent: den 15 november 2013 10:48 To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net Subject: RFR: 8027630 SIGSEGV in const char*Klass::external_name() All, The StackFrameInfo class used when creating stack dumps from the management APIs keeps references to Methods. This is similar to what BacktraceBuilder does when creating stack traces in java_lang_Throwable::fill_in_stack_trace(). For permgen removal, BacktraceBuilder was updated to add a reference to the holder class of the methods, otherwise these classes can be unloaded. This fix adds the same kind of code to StackFrameInfo so that it now has an oop reference to the class. The new pop has been added to the oops_do() method. In addition, the Method reference needs to be made visible to the MetadataOnStackMark class. To fix this a long chain of metadata_do() calls have been added. I would really like to create a test for this race, but can't figure out a reliable way to do so. bug: http://bugs.openjdk.java.net/browse/JDK-8027630 webrev: http://cr.openjdk.java.net/~sla/8027630/webrev.00/ Thanks, /Staffan From staffan.larsen at oracle.com Fri Nov 15 06:18:22 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 15 Nov 2013 15:18:22 +0100 Subject: RFR: JDK-8028430 JDI: ReferenceType.visibleMethods() return wrong visible methods Message-ID: All, ReferenceType.visibleMethods() has some problems with diamond shaped interface hierarchies. There is more information on the problem in the bug report. The solution here is to maintain a list of interfaces that we have visited so that we do not visit interfaces (above the top of the diamond) more than once. This change is targeted for jdk9 so I will hold on to it until the repos open up. webrev: http://cr.openjdk.java.net/~sla/8028430/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8028430 Thanks, /Staffan From jaroslav.bachorik at oracle.com Fri Nov 15 06:25:32 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 15 Nov 2013 15:25:32 +0100 Subject: RFR 8022221: Intermittent test failures in sun/management/jmxremote/startstop/JMXStartStopTest.sh Message-ID: <52862EDC.4080703@oracle.com> Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8022221 Webrev: http://cr.openjdk.java.net/~jbachorik/8022221/webrev.00 The test was facing intermittent failures due to not 100% failproof interprocess synchronization using lock files. The solution is rewriting the shell test to pure Java and use stdout/stderr processing for the application started by the test to assess its status. A part of the change is also few improvements to the jdk.testlibrary.ProcessTools. Thanks, -JB- From serguei.spitsyn at oracle.com Fri Nov 15 09:55:22 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 15 Nov 2013 09:55:22 -0800 Subject: RFR: 8027630 SIGSEGV in const char*Klass::external_name() In-Reply-To: <59A1AE6C-FA68-49C3-87EC-5DC0EAB7C19D@oracle.com> References: <59A1AE6C-FA68-49C3-87EC-5DC0EAB7C19D@oracle.com> Message-ID: <5286600A.5050209@oracle.com> Looks good. Thanks, Serguei On 11/15/13 1:47 AM, Staffan Larsen wrote: > All, > > The StackFrameInfo class used when creating stack dumps from the management APIs keeps references to Methods. This is similar to what BacktraceBuilder does when creating stack traces in java_lang_Throwable::fill_in_stack_trace(). For permgen removal, BacktraceBuilder was updated to add a reference to the holder class of the methods, otherwise these classes can be unloaded. > > This fix adds the same kind of code to StackFrameInfo so that it now has an oop reference to the class. The new pop has been added to the oops_do() method. > > In addition, the Method reference needs to be made visible to the MetadataOnStackMark class. To fix this a long chain of metadata_do() calls have been added. > > I would really like to create a test for this race, but can?t figure out a reliable way to do so. > > bug: http://bugs.openjdk.java.net/browse/JDK-8027630 > webrev: http://cr.openjdk.java.net/~sla/8027630/webrev.00/ > > Thanks, > /Staffan > From markus.gronlund at oracle.com Fri Nov 15 14:00:57 2013 From: markus.gronlund at oracle.com (markus.gronlund at oracle.com) Date: Fri, 15 Nov 2013 22:00:57 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 32 new changesets Message-ID: <20131115220204.11CB76262E@hg.openjdk.java.net> Changeset: 4288e54fd145 Author: jwilhelm Date: 2013-10-21 18:51 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4288e54fd145 8026851: Remove unnecessary code in GenRemSet Summary: Removed the GenRemSet::rem_set_name() since we only have one remset. Reviewed-by: stefank, mgerdin, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: 3aee6bc29547 Author: jwilhelm Date: 2013-10-21 18:52 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3aee6bc29547 8026852: Use restricted_align_down in collector policy code Summary: Moved restricted_align_down to globalDefinitions and renamed it align_size_down_bounded Reviewed-by: stefank, mgerdin, tschatzl ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 46d7652b223c Author: jwilhelm Date: 2013-10-21 18:56 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/46d7652b223c 8026853: Prepare GC code for collector policy regression fix Summary: Cleanup related to the NewSize and MaxNewSize bugs Reviewed-by: tschatzl, jcoomes, ehelin ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 8f07aa079343 Author: jwilhelm Date: 2013-11-01 17:09 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8f07aa079343 8016309: assert(eden_size > 0 && survivor_size > 0) failed: just checking 7057939: jmap shows MaxNewSize=4GB when Java is using parallel collector Summary: Major cleanup of the collectorpolicy classes Reviewed-by: tschatzl, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.hpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp + src/share/vm/gc_implementation/parallelScavenge/generationSizer.cpp ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! test/gc/arguments/TestMaxHeapSizeTools.java + test/gc/arguments/TestMaxNewSize.java Changeset: 610be0309a79 Author: amurillo Date: 2013-11-02 13:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/610be0309a79 Merge ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 28674af341ac Author: tschatzl Date: 2013-11-07 15:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region? Summary: Change checks for isHumongous() to continuesHumongous() as installing a code root for a humongous object is valid, but not for continuations of humongous objects. Cleaned up asserts. Reviewed-by: jmasa, tamao ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp + test/gc/g1/TestHumongousCodeCacheRoots.java Changeset: 40b8c6bad703 Author: jmasa Date: 2013-10-16 15:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/40b8c6bad703 8024954: CMS: CMSClassUnloadingMaxInterval is not implemented correctly. This change is also part of the fix for 8024483. Reviewed-by: mgerdin, brutisso, tschatzl Contributed-by: jwha at google.com ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 592d8b01fedd Author: jmasa Date: 2013-11-08 06:14 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/592d8b01fedd 8024483: assertion failure: (!mirror_alive || loader_alive) failed: Reviewed-by: brutisso, tschatzl, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 3ad2b68d107e Author: jwilhelm Date: 2013-11-10 00:07 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3ad2b68d107e 8027911: Assertion in the collector policy when running gc/arguments/TestMaxNewSize.java Summary: Update NewSize when _initial_gen0_size is changed Reviewed-by: tschatzl, brutisso ! src/share/vm/memory/collectorPolicy.cpp Changeset: 236cecd9ec97 Author: jwilhelm Date: 2013-11-11 13:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/236cecd9ec97 8028093: Initial young size is smaller than minimum young size Summary: Remove min_gen1_size argument from adjust_gen0_sizes() Reviewed-by: tschatzl, brutisso ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: bde526e3667e Author: jwilhelm Date: 2013-11-11 05:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bde526e3667e Merge Changeset: 11b116661830 Author: mgerdin Date: 2013-11-11 16:20 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/11b116661830 Merge ! src/share/vm/memory/metaspace.cpp Changeset: ee527493b36d Author: sjohanss Date: 2013-11-08 17:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ee527493b36d 8027960: Assertion assert(end >= start) failed during nightly testing on solaris Summary: Needed to update _space_alignment in generation sizer to ensure correct sizing of spaces. Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.cpp Changeset: 755c423791ab Author: ehelin Date: 2013-11-14 21:05 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/755c423791ab Merge ! src/share/vm/prims/whitebox.cpp Changeset: e2509677809c Author: vlivanov Date: 2013-11-08 01:13 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e2509677809c 8023037: Race between ciEnv::register_method and nmethod::make_not_entrant_or_zombie Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/globals.hpp Changeset: 83c8f6f4ab09 Author: drchase Date: 2013-11-08 14:19 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/83c8f6f4ab09 Merge Changeset: 1dcea64e9f00 Author: kvn Date: 2013-11-11 11:53 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1dcea64e9f00 8024830: SEGV in org.apache.lucene.codecs.compressing.CompressingTermVectorsReader.get Summary: Exclude last input argument's stack slots from vector's spilling masks. Reviewed-by: iveresov ! src/share/vm/opto/matcher.cpp Changeset: 78da3894b86f Author: anoll Date: 2013-11-12 09:32 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/78da3894b86f 8027593: performance drop with constrained codecache starting with hs25 b111 Summary: Fixed proper sweeping of small code cache sizes Reviewed-by: kvn, iveresov ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: 144b23411b51 Author: roland Date: 2013-11-12 13:58 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/144b23411b51 8027632: assert(xtype->klass_is_exact()) failed: Should be exact at graphKit.cpp Summary: receiver type collected by profiling for default method may be interface Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f675976a61e7 Author: rbackman Date: 2013-11-12 13:47 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f675976a61e7 8028198: SIGSEGV in PhaseIdealLoop::build_loop_late_post Reviewed-by: iveresov, kvn ! src/share/vm/opto/loopopts.cpp + test/compiler/intrinsics/mathexact/SplitThruPhiTest.java Changeset: b957c650babb Author: rbackman Date: 2013-11-12 14:52 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b957c650babb 8028207: assert(_outcnt==1) failed: not unique in compile.cpp Reviewed-by: iveresov, kvn ! src/share/vm/opto/mathexactnode.hpp + test/compiler/intrinsics/mathexact/GVNTest.java Changeset: e6ba215af802 Author: roland Date: 2013-11-13 09:45 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e6ba215af802 8027631: "unexpected profiling mismatch" error with new type profiling Summary: inlined method handle calls can call methods with different signatures Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp + test/compiler/profiling/TestUnexpectedProfilingMismatch.java Changeset: 924c32982a12 Author: roland Date: 2013-11-13 01:50 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/924c32982a12 Merge Changeset: 6e1826d5c23e Author: roland Date: 2013-11-13 13:45 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6e1826d5c23e 8027572: assert(r != 0) failed: invalid Summary: null classes should be expected in profiles with conflicts Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp + test/compiler/profiling/unloadingconflict/B.java + test/compiler/profiling/unloadingconflict/TestProfileConflictClassUnloading.java Changeset: e74074c34312 Author: vlivanov Date: 2013-11-14 09:14 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e74074c34312 8028159: C2: compiler stack overflow during inlining of @ForceInline methods Reviewed-by: roland, kvn ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/runtime/globals.hpp Changeset: df0df745224c Author: drchase Date: 2013-11-14 15:58 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/df0df745224c Merge Changeset: 6f206b5d258f Author: drchase Date: 2013-11-14 13:38 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6f206b5d258f Merge ! src/share/vm/runtime/arguments.cpp Changeset: aec3226be72d Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aec3226be72d Added tag jdk8-b116 for changeset 52b076e6ffae ! .hgtags Changeset: c78d517c7ea4 Author: amurillo Date: 2013-11-15 07:50 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c78d517c7ea4 Merge Changeset: f573d00213b7 Author: amurillo Date: 2013-11-15 07:50 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f573d00213b7 Added tag hs25-b59 for changeset c78d517c7ea4 ! .hgtags Changeset: 854a42db7069 Author: amurillo Date: 2013-11-15 07:58 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/854a42db7069 8028444: new hotspot build - hs25-b60 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 438fe38c63c8 Author: mgronlun Date: 2013-11-15 21:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/438fe38c63c8 Merge ! src/share/vm/runtime/globals.hpp From coleen.phillimore at oracle.com Fri Nov 15 15:53:01 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Fri, 15 Nov 2013 23:53:01 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8028347: Rewriter::scan_method asserts with array oob in RT_Baseline Message-ID: <20131115235303.A6D3562638@hg.openjdk.java.net> Changeset: d61a1a166f44 Author: coleenp Date: 2013-11-15 17:20 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d61a1a166f44 8028347: Rewriter::scan_method asserts with array oob in RT_Baseline Summary: Fix reversing rewriting for invokespecial Reviewed-by: jrose, hseigel ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp From staffan.larsen at oracle.com Mon Nov 18 01:23:38 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 18 Nov 2013 09:23:38 +0000 Subject: hg: jdk8/tl/jdk: 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Message-ID: <20131118092351.C8CA76265B@hg.openjdk.java.net> Changeset: 64a492bc0ba7 Author: sla Date: 2013-11-14 12:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64a492bc0ba7 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Summary: Port tests for java/lang/instrument/PremainClass from script to java Reviewed-by: sla Contributed-by: mattias.tobiasson at oracle.com - test/java/lang/instrument/PremainClass/NoPremainAgent.sh + test/java/lang/instrument/PremainClass/NoPremainAgentTest.java + test/java/lang/instrument/PremainClass/PremainClassTest.java - test/java/lang/instrument/PremainClass/PremainClassTest.sh - test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh + test/java/lang/instrument/PremainClass/ZeroArgPremainAgentTest.java ! test/lib/testlibrary/jdk/testlibrary/Utils.java From staffan.larsen at oracle.com Mon Nov 18 01:26:13 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Nov 2013 10:26:13 +0100 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: <6D07D448-3A6F-4B69-AA26-6EF55B34CEB0@oracle.com> References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> <5277FEA3.4010101@oracle.com> <6D07D448-3A6F-4B69-AA26-6EF55B34CEB0@oracle.com> Message-ID: <99A95A98-D9D2-456B-8937-4F1C8B0D05B1@oracle.com> Anyone dare look at this? :-) On 14 Nov 2013, at 08:35, Staffan Larsen wrote: > Still looking for an official Review of this change. > > Thanks, > /Staffan > > On 11 Nov 2013, at 10:32, Staffan Larsen wrote: > >> Thanks Serguei! >> >> Can I have an official Review as well? >> >> /Staffan >> >> On 04 Nov 2013, at 21:08, serguei.spitsyn at oracle.com wrote: >> >>> Staffan, >>> >>> This one is really old: 11+ years. :) >>> The fix is good, I do not see any issues. >>> >>> Thanks, >>> Serguei >>> >>> >>> On 11/4/13 6:41 AM, Staffan Larsen wrote: >>>> This is an old one! Nothing like being bored on a plane... >>>> >>>> The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints. >>>> >>>> While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored). >>>> >>>> There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done. >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ >>>> bug: https://bugs.openjdk.java.net/browse/JDK-4660158 >>>> >>>> Thanks, >>>> /Staffan >>> >> > From jaroslav.bachorik at oracle.com Mon Nov 18 01:59:17 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 18 Nov 2013 10:59:17 +0100 Subject: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep In-Reply-To: <52651646.4050705@oracle.com> References: <52651646.4050705@oracle.com> Message-ID: <5289E4F5.1080807@oracle.com> Hi, after discussing this with Mandy I've rewritten the test to use the j.u.concurrent for synchronization - this also makes it much easier to follow the test logic. The waited time, the blocked time and the waited counts are only checked for sanity (increasing values) since it is not possible to do the reliable checks against hard numbers. I ran the test in a tight loop for 1500 times using -Xcomp and -Xint and the test seems to pass constantly. New webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.03 Thanks, -JB- On 21.10.2013 13:55, Jaroslav Bachorik wrote: > Please, review this small patch for a test failing due to the updated > implementation in JDK6. > > Issue: https://bugs.openjdk.java.net/browse/JDK-6309226 > Webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.00/ > > The test fails due to the change in mustang where > ThreadMXBean.getThreadInfo().getWaitedTime() and > ThreadMXBean.getThreadInfo().getWaitedCount() include Thread.sleep() > too. Unfortunately, Thread.sleep() is used throughout the test for > synchronization purposes and this breaks the test. > > In the patch I propose to replace Thread.sleep() with busy wait and > hinting the scheduler by Thread.yield(). While not very elegant it > successfully works around inclusion of unknown number of Thread.sleep()s > (they are called in loop). > > Thanks, > > -JB- From jaroslav.bachorik at oracle.com Mon Nov 18 02:09:24 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 18 Nov 2013 11:09:24 +0100 Subject: [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: <52779BFE.1080704@oracle.com> References: <52779BFE.1080704@oracle.com> Message-ID: <5289E754.7050503@oracle.com> Could I get this reviewed, please? -JB- On 4.11.2013 14:07, Jaroslav Bachorik wrote: > Please, review the following test change: > > Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 > Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ > > Currently, the test is designed to work only on solaris-32bit. With the > support removed it is necessary to adapt the test as well. This includes > generating the solaris-sparcv9 and solaris-amd64 binaries for the > launcher the test is using. > > The test itself needs changing the way it retrieves the ARCH name for > sparcv9 architecture. Also, since it is forbidden to check in any files > with executable permissions the test must account for this and adjust > the file permissions temporarily while executing. It needs to revert to > the original permissions when it's finished to prevent reporting the > launcher files as modified in HG. > > While testing the changes the > sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing > intermittently (50%) when run in agentvm mode together with > CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests > to run in othervm mode seems to fix the problem. > > There is a small debugging improvement in > ProcessTools.java#startProcess() method - when the phaser timesout or is > interrupted all the stack traces are dumped to stderr to help diagnosing > any locking situations. > > Thanks, > > -JB- From staffan.larsen at oracle.com Mon Nov 18 02:44:59 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 18 Nov 2013 10:44:59 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8027630: SIGSEGV in const char*Klass::external_name() Message-ID: <20131118104503.DA99D6265F@hg.openjdk.java.net> Changeset: 0b9ea9a72436 Author: sla Date: 2013-11-18 10:20 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0b9ea9a72436 8027630: SIGSEGV in const char*Klass::external_name() Reviewed-by: coleenp, sspitsyn, mgronlun ! src/share/vm/classfile/metadataOnStackMark.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/services/threadService.hpp From staffan.larsen at oracle.com Mon Nov 18 03:50:29 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Nov 2013 12:50:29 +0100 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: <5289E754.7050503@oracle.com> References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> Message-ID: Shouldn?t test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be removed as part of this change? /Staffan On 18 Nov 2013, at 11:09, Jaroslav Bachorik wrote: > Could I get this reviewed, please? > > -JB- > > On 4.11.2013 14:07, Jaroslav Bachorik wrote: >> Please, review the following test change: >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >> >> Currently, the test is designed to work only on solaris-32bit. With the >> support removed it is necessary to adapt the test as well. This includes >> generating the solaris-sparcv9 and solaris-amd64 binaries for the >> launcher the test is using. >> >> The test itself needs changing the way it retrieves the ARCH name for >> sparcv9 architecture. Also, since it is forbidden to check in any files >> with executable permissions the test must account for this and adjust >> the file permissions temporarily while executing. It needs to revert to >> the original permissions when it's finished to prevent reporting the >> launcher files as modified in HG. >> >> While testing the changes the >> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing >> intermittently (50%) when run in agentvm mode together with >> CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests >> to run in othervm mode seems to fix the problem. >> >> There is a small debugging improvement in >> ProcessTools.java#startProcess() method - when the phaser timesout or is >> interrupted all the stack traces are dumped to stderr to help diagnosing >> any locking situations. >> >> Thanks, >> >> -JB- > From jaroslav.bachorik at oracle.com Mon Nov 18 04:00:28 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 18 Nov 2013 13:00:28 +0100 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> Message-ID: <528A015C.20706@oracle.com> On 18.11.2013 12:50, Staffan Larsen wrote: > Shouldn?t test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be removed as part of this change? Probably yes - if there are no 32bit solaris build hosts then it can be removed. -JB- > > /Staffan > > On 18 Nov 2013, at 11:09, Jaroslav Bachorik wrote: > >> Could I get this reviewed, please? >> >> -JB- >> >> On 4.11.2013 14:07, Jaroslav Bachorik wrote: >>> Please, review the following test change: >>> >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >>> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >>> >>> Currently, the test is designed to work only on solaris-32bit. With the >>> support removed it is necessary to adapt the test as well. This includes >>> generating the solaris-sparcv9 and solaris-amd64 binaries for the >>> launcher the test is using. >>> >>> The test itself needs changing the way it retrieves the ARCH name for >>> sparcv9 architecture. Also, since it is forbidden to check in any files >>> with executable permissions the test must account for this and adjust >>> the file permissions temporarily while executing. It needs to revert to >>> the original permissions when it's finished to prevent reporting the >>> launcher files as modified in HG. >>> >>> While testing the changes the >>> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing >>> intermittently (50%) when run in agentvm mode together with >>> CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests >>> to run in othervm mode seems to fix the problem. >>> >>> There is a small debugging improvement in >>> ProcessTools.java#startProcess() method - when the phaser timesout or is >>> interrupted all the stack traces are dumped to stderr to help diagnosing >>> any locking situations. >>> >>> Thanks, >>> >>> -JB- >> > From staffan.larsen at oracle.com Mon Nov 18 04:06:39 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Nov 2013 13:06:39 +0100 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: <528A015C.20706@oracle.com> References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> <528A015C.20706@oracle.com> Message-ID: <17C44C25-C9D0-477A-A673-8306B608483C@oracle.com> We don?t have solaris 32bit support any more, so please remove that file. Otherwise: looks good! /Staffan On 18 Nov 2013, at 13:00, Jaroslav Bachorik wrote: > On 18.11.2013 12:50, Staffan Larsen wrote: >> Shouldn?t test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be removed as part of this change? > > Probably yes - if there are no 32bit solaris build hosts then it can be removed. > > -JB- > >> >> /Staffan >> >> On 18 Nov 2013, at 11:09, Jaroslav Bachorik wrote: >> >>> Could I get this reviewed, please? >>> >>> -JB- >>> >>> On 4.11.2013 14:07, Jaroslav Bachorik wrote: >>>> Please, review the following test change: >>>> >>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >>>> >>>> Currently, the test is designed to work only on solaris-32bit. With the >>>> support removed it is necessary to adapt the test as well. This includes >>>> generating the solaris-sparcv9 and solaris-amd64 binaries for the >>>> launcher the test is using. >>>> >>>> The test itself needs changing the way it retrieves the ARCH name for >>>> sparcv9 architecture. Also, since it is forbidden to check in any files >>>> with executable permissions the test must account for this and adjust >>>> the file permissions temporarily while executing. It needs to revert to >>>> the original permissions when it's finished to prevent reporting the >>>> launcher files as modified in HG. >>>> >>>> While testing the changes the >>>> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing >>>> intermittently (50%) when run in agentvm mode together with >>>> CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests >>>> to run in othervm mode seems to fix the problem. >>>> >>>> There is a small debugging improvement in >>>> ProcessTools.java#startProcess() method - when the phaser timesout or is >>>> interrupted all the stack traces are dumped to stderr to help diagnosing >>>> any locking situations. >>>> >>>> Thanks, >>>> >>>> -JB- >>> >> > From jaroslav.bachorik at oracle.com Mon Nov 18 04:15:51 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 18 Nov 2013 13:15:51 +0100 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: <17C44C25-C9D0-477A-A673-8306B608483C@oracle.com> References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> <528A015C.20706@oracle.com> <17C44C25-C9D0-477A-A673-8306B608483C@oracle.com> Message-ID: <528A04F7.9090605@oracle.com> On 18.11.2013 13:06, Staffan Larsen wrote: > We don?t have solaris 32bit support any more, so please remove that file. In that case I will remove also solaris-i586 -JB- > > Otherwise: looks good! > > /Staffan > > On 18 Nov 2013, at 13:00, Jaroslav Bachorik wrote: > >> On 18.11.2013 12:50, Staffan Larsen wrote: >>> Shouldn?t test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be removed as part of this change? >> >> Probably yes - if there are no 32bit solaris build hosts then it can be removed. >> >> -JB- >> >>> >>> /Staffan >>> >>> On 18 Nov 2013, at 11:09, Jaroslav Bachorik wrote: >>> >>>> Could I get this reviewed, please? >>>> >>>> -JB- >>>> >>>> On 4.11.2013 14:07, Jaroslav Bachorik wrote: >>>>> Please, review the following test change: >>>>> >>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >>>>> >>>>> Currently, the test is designed to work only on solaris-32bit. With the >>>>> support removed it is necessary to adapt the test as well. This includes >>>>> generating the solaris-sparcv9 and solaris-amd64 binaries for the >>>>> launcher the test is using. >>>>> >>>>> The test itself needs changing the way it retrieves the ARCH name for >>>>> sparcv9 architecture. Also, since it is forbidden to check in any files >>>>> with executable permissions the test must account for this and adjust >>>>> the file permissions temporarily while executing. It needs to revert to >>>>> the original permissions when it's finished to prevent reporting the >>>>> launcher files as modified in HG. >>>>> >>>>> While testing the changes the >>>>> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing >>>>> intermittently (50%) when run in agentvm mode together with >>>>> CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests >>>>> to run in othervm mode seems to fix the problem. >>>>> >>>>> There is a small debugging improvement in >>>>> ProcessTools.java#startProcess() method - when the phaser timesout or is >>>>> interrupted all the stack traces are dumped to stderr to help diagnosing >>>>> any locking situations. >>>>> >>>>> Thanks, >>>>> >>>>> -JB- >>>> >>> >> > From erik.gahlin at oracle.com Mon Nov 18 04:53:23 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Mon, 18 Nov 2013 13:53:23 +0100 Subject: RFR: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt Message-ID: <528A0DC3.9020404@oracle.com> Could I please have a review. Thanks Erik Bug: https://bugs.openjdk.java.net/browse/JDK-8028505 Webrev: http://cr.openjdk.java.net/~egahlin/8028505/ From staffan.larsen at oracle.com Mon Nov 18 04:51:39 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Nov 2013 13:51:39 +0100 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: <528A04F7.9090605@oracle.com> References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> <528A015C.20706@oracle.com> <17C44C25-C9D0-477A-A673-8306B608483C@oracle.com> <528A04F7.9090605@oracle.com> Message-ID: Ah! Yes. /S On 18 Nov 2013, at 13:15, Jaroslav Bachorik wrote: > On 18.11.2013 13:06, Staffan Larsen wrote: >> We don?t have solaris 32bit support any more, so please remove that file. > > In that case I will remove also solaris-i586 > > -JB- > >> >> Otherwise: looks good! >> >> /Staffan >> >> On 18 Nov 2013, at 13:00, Jaroslav Bachorik wrote: >> >>> On 18.11.2013 12:50, Staffan Larsen wrote: >>>> Shouldn?t test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be removed as part of this change? >>> >>> Probably yes - if there are no 32bit solaris build hosts then it can be removed. >>> >>> -JB- >>> >>>> >>>> /Staffan >>>> >>>> On 18 Nov 2013, at 11:09, Jaroslav Bachorik wrote: >>>> >>>>> Could I get this reviewed, please? >>>>> >>>>> -JB- >>>>> >>>>> On 4.11.2013 14:07, Jaroslav Bachorik wrote: >>>>>> Please, review the following test change: >>>>>> >>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >>>>>> >>>>>> Currently, the test is designed to work only on solaris-32bit. With the >>>>>> support removed it is necessary to adapt the test as well. This includes >>>>>> generating the solaris-sparcv9 and solaris-amd64 binaries for the >>>>>> launcher the test is using. >>>>>> >>>>>> The test itself needs changing the way it retrieves the ARCH name for >>>>>> sparcv9 architecture. Also, since it is forbidden to check in any files >>>>>> with executable permissions the test must account for this and adjust >>>>>> the file permissions temporarily while executing. It needs to revert to >>>>>> the original permissions when it's finished to prevent reporting the >>>>>> launcher files as modified in HG. >>>>>> >>>>>> While testing the changes the >>>>>> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing >>>>>> intermittently (50%) when run in agentvm mode together with >>>>>> CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests >>>>>> to run in othervm mode seems to fix the problem. >>>>>> >>>>>> There is a small debugging improvement in >>>>>> ProcessTools.java#startProcess() method - when the phaser timesout or is >>>>>> interrupted all the stack traces are dumped to stderr to help diagnosing >>>>>> any locking situations. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> -JB- >>>>> >>>> >>> >> > From Alan.Bateman at oracle.com Mon Nov 18 04:54:38 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 18 Nov 2013 12:54:38 +0000 Subject: RFR: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt In-Reply-To: <528A0DC3.9020404@oracle.com> References: <528A0DC3.9020404@oracle.com> Message-ID: <528A0E0E.2080701@oracle.com> On 18/11/2013 12:53, Erik Gahlin wrote: > Could I please have a review. > > Thanks > Erik > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8028505 > > Webrev: > http://cr.openjdk.java.net/~egahlin/8028505/ When we add a test to the exclude list then we try to link it to the bug that explains why the bug is excluded. So in this case then I assume the comment reference 8028474 (rather than 8028505). -Alan. From erik.gahlin at oracle.com Mon Nov 18 05:29:23 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Mon, 18 Nov 2013 14:29:23 +0100 Subject: RFR: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt In-Reply-To: <528A0E0E.2080701@oracle.com> References: <528A0DC3.9020404@oracle.com> <528A0E0E.2080701@oracle.com> Message-ID: <528A1633.9030907@oracle.com> Thanks for explaining. Here is an updated webrev http://cr.openjdk.java.net/~egahlin/8028505_2/ Erik Alan Bateman skrev 2013-11-18 13:54: > On 18/11/2013 12:53, Erik Gahlin wrote: >> Could I please have a review. >> >> Thanks >> Erik >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8028505 >> >> Webrev: >> http://cr.openjdk.java.net/~egahlin/8028505/ > When we add a test to the exclude list then we try to link it to the > bug that explains why the bug is excluded. So in this case then I > assume the comment reference 8028474 (rather than 8028505). > > -Alan. From jaroslav.bachorik at oracle.com Mon Nov 18 05:41:29 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 18 Nov 2013 14:41:29 +0100 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> <528A015C.20706@oracle.com> <17C44C25-C9D0-477A-A673-8306B608483C@oracle.com> <528A04F7.9090605@oracle.com> Message-ID: <528A1909.1050106@oracle.com> Ok, just to be sure - http://cr.openjdk.java.net/~jbachorik/8027163/webrev.01 -JB- On 18.11.2013 13:51, Staffan Larsen wrote: > Ah! Yes. > > /S > > On 18 Nov 2013, at 13:15, Jaroslav Bachorik wrote: > >> On 18.11.2013 13:06, Staffan Larsen wrote: >>> We don?t have solaris 32bit support any more, so please remove that file. >> >> In that case I will remove also solaris-i586 >> >> -JB- >> >>> >>> Otherwise: looks good! >>> >>> /Staffan >>> >>> On 18 Nov 2013, at 13:00, Jaroslav Bachorik wrote: >>> >>>> On 18.11.2013 12:50, Staffan Larsen wrote: >>>>> Shouldn?t test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be removed as part of this change? >>>> >>>> Probably yes - if there are no 32bit solaris build hosts then it can be removed. >>>> >>>> -JB- >>>> >>>>> >>>>> /Staffan >>>>> >>>>> On 18 Nov 2013, at 11:09, Jaroslav Bachorik wrote: >>>>> >>>>>> Could I get this reviewed, please? >>>>>> >>>>>> -JB- >>>>>> >>>>>> On 4.11.2013 14:07, Jaroslav Bachorik wrote: >>>>>>> Please, review the following test change: >>>>>>> >>>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >>>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >>>>>>> >>>>>>> Currently, the test is designed to work only on solaris-32bit. With the >>>>>>> support removed it is necessary to adapt the test as well. This includes >>>>>>> generating the solaris-sparcv9 and solaris-amd64 binaries for the >>>>>>> launcher the test is using. >>>>>>> >>>>>>> The test itself needs changing the way it retrieves the ARCH name for >>>>>>> sparcv9 architecture. Also, since it is forbidden to check in any files >>>>>>> with executable permissions the test must account for this and adjust >>>>>>> the file permissions temporarily while executing. It needs to revert to >>>>>>> the original permissions when it's finished to prevent reporting the >>>>>>> launcher files as modified in HG. >>>>>>> >>>>>>> While testing the changes the >>>>>>> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing >>>>>>> intermittently (50%) when run in agentvm mode together with >>>>>>> CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests >>>>>>> to run in othervm mode seems to fix the problem. >>>>>>> >>>>>>> There is a small debugging improvement in >>>>>>> ProcessTools.java#startProcess() method - when the phaser timesout or is >>>>>>> interrupted all the stack traces are dumped to stderr to help diagnosing >>>>>>> any locking situations. >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> -JB- >>>>>> >>>>> >>>> >>> >> > From Alan.Bateman at oracle.com Mon Nov 18 05:44:54 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 18 Nov 2013 13:44:54 +0000 Subject: RFR: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt In-Reply-To: <528A1633.9030907@oracle.com> References: <528A0DC3.9020404@oracle.com> <528A0E0E.2080701@oracle.com> <528A1633.9030907@oracle.com> Message-ID: <528A19D6.3000606@oracle.com> On 18/11/2013 13:29, Erik Gahlin wrote: > Thanks for explaining. Here is an updated webrev > > http://cr.openjdk.java.net/~egahlin/8028505_2/ That's it, looks fine to me. -Alan. From staffan.larsen at oracle.com Mon Nov 18 06:09:21 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Nov 2013 15:09:21 +0100 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: <528A1909.1050106@oracle.com> References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> <528A015C.20706@oracle.com> <17C44C25-C9D0-477A-A673-8306B608483C@oracle.com> <528A04F7.9090605@oracle.com> <528A1909.1050106@oracle.com> Message-ID: <38B51663-5BAF-4FE0-B7D4-715576C69E24@oracle.com> Reviewed. /Staffan On 18 Nov 2013, at 14:41, Jaroslav Bachorik wrote: > Ok, just to be sure - http://cr.openjdk.java.net/~jbachorik/8027163/webrev.01 > > -JB- > > On 18.11.2013 13:51, Staffan Larsen wrote: >> Ah! Yes. >> >> /S >> >> On 18 Nov 2013, at 13:15, Jaroslav Bachorik wrote: >> >>> On 18.11.2013 13:06, Staffan Larsen wrote: >>>> We don?t have solaris 32bit support any more, so please remove that file. >>> >>> In that case I will remove also solaris-i586 >>> >>> -JB- >>> >>>> >>>> Otherwise: looks good! >>>> >>>> /Staffan >>>> >>>> On 18 Nov 2013, at 13:00, Jaroslav Bachorik wrote: >>>> >>>>> On 18.11.2013 12:50, Staffan Larsen wrote: >>>>>> Shouldn?t test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be removed as part of this change? >>>>> >>>>> Probably yes - if there are no 32bit solaris build hosts then it can be removed. >>>>> >>>>> -JB- >>>>> >>>>>> >>>>>> /Staffan >>>>>> >>>>>> On 18 Nov 2013, at 11:09, Jaroslav Bachorik wrote: >>>>>> >>>>>>> Could I get this reviewed, please? >>>>>>> >>>>>>> -JB- >>>>>>> >>>>>>> On 4.11.2013 14:07, Jaroslav Bachorik wrote: >>>>>>>> Please, review the following test change: >>>>>>>> >>>>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >>>>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >>>>>>>> >>>>>>>> Currently, the test is designed to work only on solaris-32bit. With the >>>>>>>> support removed it is necessary to adapt the test as well. This includes >>>>>>>> generating the solaris-sparcv9 and solaris-amd64 binaries for the >>>>>>>> launcher the test is using. >>>>>>>> >>>>>>>> The test itself needs changing the way it retrieves the ARCH name for >>>>>>>> sparcv9 architecture. Also, since it is forbidden to check in any files >>>>>>>> with executable permissions the test must account for this and adjust >>>>>>>> the file permissions temporarily while executing. It needs to revert to >>>>>>>> the original permissions when it's finished to prevent reporting the >>>>>>>> launcher files as modified in HG. >>>>>>>> >>>>>>>> While testing the changes the >>>>>>>> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept failing >>>>>>>> intermittently (50%) when run in agentvm mode together with >>>>>>>> CustomLauncherTest.java on sparcv9 machines. Forcing both of these tests >>>>>>>> to run in othervm mode seems to fix the problem. >>>>>>>> >>>>>>>> There is a small debugging improvement in >>>>>>>> ProcessTools.java#startProcess() method - when the phaser timesout or is >>>>>>>> interrupted all the stack traces are dumped to stderr to help diagnosing >>>>>>>> any locking situations. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> -JB- >>>>>>> >>>>>> >>>>> >>>> >>> >> > From jaroslav.bachorik at oracle.com Mon Nov 18 06:27:18 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 18 Nov 2013 14:27:18 +0000 Subject: hg: jdk8/tl/jdk: 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support Message-ID: <20131118142734.7C3B362664@hg.openjdk.java.net> Changeset: d842131d12d8 Author: jbachorik Date: 2013-11-18 15:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d842131d12d8 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support Reviewed-by: sla ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.java + test/sun/management/jmxremote/bootstrap/solaris-amd64/launcher - test/sun/management/jmxremote/bootstrap/solaris-i586/launcher - test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher + test/sun/management/jmxremote/bootstrap/solaris-sparcv9/launcher From jaroslav.bachorik at oracle.com Mon Nov 18 06:57:37 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 18 Nov 2013 15:57:37 +0100 Subject: RFR 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests Message-ID: <528A2AE1.705@oracle.com> Please, review this simple test change. Issue : https://bugs.openjdk.java.net/browse/JDK-8028433 Webrev: http://cr.openjdk.java.net/~jbachorik/8028433/webrev.00 The tests relying on the availability of the perf counters need to add -XX:+UserPerfData jvm arg in order for them to be available on the embedded platforms. Additionally, the tests must be run in othervm mode - due to the specified jvm arg. -JB- From staffan.larsen at oracle.com Mon Nov 18 07:07:31 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 18 Nov 2013 16:07:31 +0100 Subject: RFR 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests In-Reply-To: <528A2AE1.705@oracle.com> References: <528A2AE1.705@oracle.com> Message-ID: Looks good! Thanks, /Staffan On 18 Nov 2013, at 15:57, Jaroslav Bachorik wrote: > Please, review this simple test change. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8028433 > Webrev: http://cr.openjdk.java.net/~jbachorik/8028433/webrev.00 > > The tests relying on the availability of the perf counters need to add -XX:+UserPerfData jvm arg in order for them to be available on the embedded platforms. Additionally, the tests must be run in othervm mode - due to the specified jvm arg. > > -JB- From erik.gahlin at oracle.com Mon Nov 18 07:13:03 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Mon, 18 Nov 2013 16:13:03 +0100 Subject: RFR 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests In-Reply-To: <528A2AE1.705@oracle.com> References: <528A2AE1.705@oracle.com> Message-ID: <528A2E7F.1070705@oracle.com> Looks good. Erik Jaroslav Bachorik skrev 2013-11-18 15:57: > Please, review this simple test change. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8028433 > Webrev: http://cr.openjdk.java.net/~jbachorik/8028433/webrev.00 > > The tests relying on the availability of the perf counters need to add > -XX:+UserPerfData jvm arg in order for them to be available on the > embedded platforms. Additionally, the tests must be run in othervm > mode - due to the specified jvm arg. > > -JB- From jaroslav.bachorik at oracle.com Mon Nov 18 07:22:31 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 18 Nov 2013 15:22:31 +0000 Subject: hg: jdk8/tl/jdk: 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests Message-ID: <20131118152246.47D0762666@hg.openjdk.java.net> Changeset: 0298ebbaf3b8 Author: jbachorik Date: 2013-11-18 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0298ebbaf3b8 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests Reviewed-by: sla, egahlin ! test/sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java ! test/sun/management/HotspotClassLoadingMBean/GetInitializedClassCount.java ! test/sun/management/HotspotClassLoadingMBean/GetLoadedClassSize.java ! test/sun/management/HotspotClassLoadingMBean/GetMethodDataSize.java ! test/sun/management/HotspotClassLoadingMBean/GetUnloadedClassSize.java ! test/sun/management/HotspotRuntimeMBean/GetSafepointCount.java From alexander.zuev at oracle.com Mon Nov 18 08:23:09 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Mon, 18 Nov 2013 16:23:09 +0000 Subject: hg: jdk8/tl/jdk: 8028197: tools/launcher/DiacriticTest.java failed on MacOSX: Input length = 1 Message-ID: <20131118162324.0DF626266A@hg.openjdk.java.net> Changeset: c2b56fe61626 Author: kizune Date: 2013-11-18 20:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2b56fe61626 8028197: tools/launcher/DiacriticTest.java failed on MacOSX: Input length = 1 Reviewed-by: ksrini ! test/tools/launcher/DiacriticTest.java From magnus.ihse.bursie at oracle.com Mon Nov 18 09:53:58 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:53:58 +0000 Subject: hg: jdk8/tl: 8027566: Remove the old build system Message-ID: <20131118175359.385806266D@hg.openjdk.java.net> Changeset: a667caba1e84 Author: ihse Date: 2013-11-14 10:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a667caba1e84 8027566: Remove the old build system Reviewed-by: erikj, tbell ! Makefile - NewMakefile.gmk ! common/autoconf/Makefile.in ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/bin/compare.sh - common/makefiles/HotspotWrapper.gmk - common/makefiles/IdlCompilation.gmk - common/makefiles/JavaCompilation.gmk - common/makefiles/Jprt.gmk - common/makefiles/Main.gmk - common/makefiles/MakeBase.gmk - common/makefiles/MakeHelpers.gmk - common/makefiles/Makefile - common/makefiles/NativeCompilation.gmk - common/makefiles/RMICompilation.gmk - common/makefiles/devkit/Makefile - common/makefiles/devkit/Tools.gmk - common/makefiles/javadoc/CORE_PKGS.gmk - common/makefiles/javadoc/Javadoc.gmk - common/makefiles/javadoc/NON_CORE_PKGS.gmk - common/makefiles/javadoc/Notes.html - common/makefiles/support/ListPathsSafely-post-compress.incl - common/makefiles/support/ListPathsSafely-pre-compress.incl - common/makefiles/support/ListPathsSafely-uncompress.sed - common/makefiles/support/unicode2x.sed ! common/nb_native/nbproject/configurations.xml - make/Defs-internal.gmk + make/HotspotWrapper.gmk + make/Javadoc.gmk + make/Jprt.gmk + make/Main.gmk + make/MakeHelpers.gmk - make/README.pre-components + make/common/CORE_PKGS.gmk + make/common/IdlCompilation.gmk + make/common/JavaCompilation.gmk + make/common/MakeBase.gmk + make/common/NON_CORE_PKGS.gmk + make/common/NativeCompilation.gmk + make/common/RMICompilation.gmk + make/common/support/ListPathsSafely-post-compress.incl + make/common/support/ListPathsSafely-pre-compress.incl + make/common/support/ListPathsSafely-uncompress.sed + make/common/support/unicode2x.sed - make/corba-rules.gmk - make/deploy-rules.gmk + make/devkit/Makefile + make/devkit/Tools.gmk - make/hotspot-rules.gmk - make/install-rules.gmk - make/jaxp-rules.gmk - make/jaxws-rules.gmk - make/jdk-rules.gmk - make/jprt.gmk - make/langtools-rules.gmk - make/nashorn-rules.gmk - make/sanity-rules.gmk - make/scripts/fixpath.pl - make/scripts/vsvars.sh - make/sponsors-rules.gmk From magnus.ihse.bursie at oracle.com Mon Nov 18 09:54:40 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:54:40 +0000 Subject: hg: jdk8/tl/jaxp: 8027566: Remove the old build system Message-ID: <20131118175447.806826266F@hg.openjdk.java.net> Changeset: 80acb8151797 Author: ihse Date: 2013-11-04 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/80acb8151797 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildJaxp.gmk ! make/Makefile - make/jprt.properties - make/scripts/update_src.sh - makefiles/BuildJaxp.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:54:07 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:54:07 +0000 Subject: hg: jdk8/tl/corba: 8027566: Remove the old build system Message-ID: <20131118175409.7B3D76266E@hg.openjdk.java.net> Changeset: 9729f9862eb4 Author: ihse Date: 2013-11-04 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9729f9862eb4 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildCorba.gmk ! make/Makefile - make/com/Makefile - make/com/sun/Makefile - make/com/sun/corba/Makefile - make/com/sun/corba/minclude/com_sun_corba_se_PortableActivationIDL.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_activation.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_corba.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_core.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_dynamicany.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_encoding.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_interceptors.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_io.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_ior.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_legacy.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_logging.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_monitoring.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_cosnaming.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_namingutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_pcosnaming.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_poa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_toa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_orb.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_presentation_rmi.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_protocol.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_resolver.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_transport.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_util.jmk - make/com/sun/corba/minclude/com_sun_corba_se_internal_LegacyFiles.jmk - make/com/sun/corba/minclude/com_sun_corba_se_pept.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_activation.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_copyobject.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_encoding.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_extension.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_ior.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_connection.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_interceptor.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_logging.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_monitoring.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_oa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_orb.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_orbutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_presentation_rmi.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_protocol.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_resolver.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_servicecontext.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_transport.jmk - make/com/sun/corba/minclude/com_sun_tools_corba_se_idl_toJavaPortable.jmk - make/com/sun/corba/minclude/javax_activity.jmk - make/com/sun/corba/minclude/javax_rmi.jmk - make/com/sun/corba/minclude/javax_rmi_CORBA.jmk - make/com/sun/corba/minclude/javax_transaction.jmk - make/com/sun/corba/minclude/org_omg_CORBA.jmk - make/com/sun/corba/minclude/org_omg_CORBAX.jmk - make/com/sun/corba/minclude/org_omg_CORBA_2_3.jmk - make/com/sun/corba/minclude/org_omg_CosNaming.jmk - make/com/sun/corba/minclude/org_omg_DynamicAny.jmk - make/com/sun/corba/minclude/org_omg_IOP.jmk - make/com/sun/corba/minclude/org_omg_Messaging.jmk - make/com/sun/corba/minclude/org_omg_PortableInterceptor.jmk - make/com/sun/corba/minclude/org_omg_PortableServer.jmk - make/com/sun/corba/minclude/org_omg_SendingContext.jmk - make/com/sun/corba/minclude/sun_corba.jmk - make/com/sun/corba/se/Makefile - make/com/sun/corba/se/PortableActivationIDL/Makefile - make/com/sun/corba/se/connection/FILES_java.gmk - make/com/sun/corba/se/connection/Makefile - make/com/sun/corba/se/core/Makefile - make/com/sun/corba/se/corespi/Makefile - make/com/sun/corba/se/impl/Makefile - make/com/sun/corba/se/impl/activation/Makefile - make/com/sun/corba/se/impl/activation/orbd/Makefile - make/com/sun/corba/se/impl/activation/servertool/Makefile - make/com/sun/corba/se/impl/interceptors/Makefile - make/com/sun/corba/se/impl/logging/Makefile - make/com/sun/corba/se/impl/monitoring/Makefile - make/com/sun/corba/se/impl/naming/Makefile - make/com/sun/corba/se/impl/naming/cosnaming/Makefile - make/com/sun/corba/se/impl/naming/namingutil/Makefile - make/com/sun/corba/se/impl/naming/pcosnaming/Makefile - make/com/sun/corba/se/impl/oa/Makefile - make/com/sun/corba/se/impl/oa/poa/Makefile - make/com/sun/corba/se/impl/oa/toa/Makefile - make/com/sun/corba/se/interceptor/FILES_java.gmk - make/com/sun/corba/se/interceptor/Makefile - make/com/sun/corba/se/pept/Makefile - make/com/sun/corba/se/rmi/Makefile - make/com/sun/corba/se/rmi/rmic/Makefile - make/com/sun/corba/se/rmi/rmic/SUN_RMI_RMIC_IIOP_java.gmk - make/com/sun/corba/se/sources/Makefile - make/com/sun/corba/se/spi/Makefile - make/com/sun/corba/se/spi/activation/Makefile - make/com/sun/corba/se/spi/copyobject/Makefile - make/com/sun/corba/se/spi/encoding/Makefile - make/com/sun/corba/se/spi/extension/Makefile - make/com/sun/corba/se/spi/legacy/Makefile - make/com/sun/corba/se/spi/legacy/connection/Makefile - make/com/sun/corba/se/spi/legacy/interceptor/Makefile - make/com/sun/corba/se/spi/logging/Makefile - make/com/sun/corba/se/spi/monitoring/Makefile - make/common/BuildToolJar.gmk - make/common/CancelImplicits.gmk - make/common/Classes.gmk - make/common/Defs-bsd.gmk - make/common/Defs-linux.gmk - make/common/Defs-solaris.gmk - make/common/Defs-windows.gmk - make/common/Defs.gmk - make/common/Rules.gmk - make/common/internal/Resources.gmk - make/common/shared/Defs-bsd.gmk - make/common/shared/Defs-java.gmk - make/common/shared/Defs-linux.gmk - make/common/shared/Defs-solaris.gmk - make/common/shared/Defs-utils.gmk - make/common/shared/Defs-windows.gmk - make/common/shared/Defs.gmk - make/common/shared/Platform.gmk - make/javax/Makefile - make/javax/xa/Makefile - make/jprt.properties - make/org/Makefile - make/org/omg/CORBA/Makefile - make/org/omg/CORBAX_java.gmk - make/org/omg/CosNaming/Makefile - make/org/omg/DynamicAny/Makefile - make/org/omg/Makefile - make/org/omg/PortableInterceptor/Makefile - make/org/omg/PortableServer/Makefile - make/org/omg/idl/FILES_java.gmk - make/org/omg/idl/Makefile - make/org/omg/sources/Makefile - make/sun/Makefile - make/sun/corba/Makefile - make/sun/corba/core/Makefile - make/sun/corba/org/Makefile - make/sun/corba/org/omg/FILES_java.gmk - make/sun/corba/org/omg/Makefile - make/sun/rmi/Makefile - make/sun/rmi/corbalogcompile/Makefile - make/sun/rmi/corbalogsources/Makefile - make/sun/rmi/rmic/FILES.gmk - make/sun/rmi/rmic/Makefile - make/tools/Makefile - make/tools/idlj/Makefile - make/tools/logutil/Makefile - make/tools/strip_properties/Makefile - makefiles/BuildCorba.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:55:06 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:55:06 +0000 Subject: hg: jdk8/tl/jdk: 8027566: Remove the old build system Message-ID: <20131118175522.0FECE62671@hg.openjdk.java.net> Changeset: 4be14673b9bf Author: ihse Date: 2013-11-14 11:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4be14673b9bf 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildJdk.gmk + make/Bundles.gmk + make/CompileDemos.gmk + make/CompileJavaClasses.gmk + make/CompileLaunchers.gmk + make/CompileNativeLibraries.gmk + make/CopyFiles.gmk + make/CopyIntoClasses.gmk + make/CopySamples.gmk + make/CreateJars.gmk + make/CreateSecurityJars.gmk + make/GenerateClasses.gmk + make/GenerateData.gmk + make/GenerateSources.gmk + make/Images.gmk + make/Import.gmk ! make/Makefile - make/PatchList.solaris + make/ProfileNames.gmk + make/Profiles.gmk + make/Setup.gmk + make/SignJars.gmk + make/Tools.gmk - make/altclasses/Makefile - make/apple/Makefile - make/apple/applescript/Makefile - make/bridge/AccessBridgeJava/Makefile - make/bridge/JAWTAccessBridge/Files_cpp.gmk - make/bridge/JAWTAccessBridge/Makefile - make/bridge/Jabswitch/Makefile - make/bridge/Jaccess/Makefile - make/bridge/JavaAccessBridge/Files_cpp.gmk - make/bridge/JavaAccessBridge/Makefile - make/bridge/Makefile - make/bridge/WindowsAccessBridge/Files_cpp.gmk - make/bridge/WindowsAccessBridge/Makefile - make/com/Makefile - make/com/apple/Makefile - make/com/apple/osx/Makefile - make/com/apple/osxui/Makefile - make/com/oracle/Makefile - make/com/oracle/jfr/Makefile - make/com/oracle/net/Makefile - make/com/oracle/nio/Makefile - make/com/oracle/security/ucrypto/FILES_c.gmk - make/com/oracle/security/ucrypto/Makefile - make/com/oracle/security/ucrypto/mapfile-vers - make/com/oracle/util/Makefile - make/com/sun/Makefile - make/com/sun/crypto/provider/Makefile - make/com/sun/demo/Makefile - make/com/sun/demo/jvmti/Makefile - make/com/sun/demo/jvmti/hprof/Makefile - make/com/sun/image/Makefile - make/com/sun/jarsigner/Makefile - make/com/sun/java/Makefile - make/com/sun/java/browser/Makefile - make/com/sun/java/browser/dom/Makefile - make/com/sun/java/browser/net/Makefile - make/com/sun/java/pack/FILES_cpp.gmk - make/com/sun/java/pack/Makefile - make/com/sun/java/pack/mapfile-vers - make/com/sun/java/pack/mapfile-vers-unpack200 - make/com/sun/java/pack/prop/Makefile - make/com/sun/jmx/Makefile - make/com/sun/jmx/snmp/Makefile - make/com/sun/jndi/Makefile - make/com/sun/jndi/cosnaming/Makefile - make/com/sun/jndi/dns/Makefile - make/com/sun/jndi/ldap/Makefile - make/com/sun/jndi/rmi/Makefile - make/com/sun/jndi/rmi/registry/Makefile - make/com/sun/jndi/toolkit/Makefile - make/com/sun/net/httpserver/Makefile - make/com/sun/net/ssl/Makefile - make/com/sun/nio/Makefile - make/com/sun/nio/sctp/Exportedfiles.gmk - make/com/sun/nio/sctp/FILES_c.gmk - make/com/sun/nio/sctp/FILES_java.gmk - make/com/sun/nio/sctp/Makefile - make/com/sun/nio/sctp/mapfile-vers - make/com/sun/org/Makefile - make/com/sun/org/apache/Makefile - make/com/sun/org/apache/xml/Makefile - make/com/sun/rowset/Makefile - make/com/sun/security/Makefile - make/com/sun/security/auth/FILES_java.gmk - make/com/sun/security/auth/Makefile - make/com/sun/security/auth/module/FILES_c_solaris.gmk - make/com/sun/security/auth/module/FILES_c_unix.gmk - make/com/sun/security/auth/module/FILES_c_windows.gmk - make/com/sun/security/auth/module/FILES_export_solaris.gmk - make/com/sun/security/auth/module/FILES_export_unix.gmk - make/com/sun/security/auth/module/FILES_export_windows.gmk - make/com/sun/security/auth/module/FILES_java.gmk - make/com/sun/security/auth/module/Makefile - make/com/sun/security/auth/module/mapfile-vers - make/com/sun/security/jgss/Makefile - make/com/sun/security/ntlm/Makefile - make/com/sun/security/sasl/Makefile - make/com/sun/sql/FILES_java.gmk - make/com/sun/sql/Makefile - make/com/sun/tools/Makefile - make/com/sun/tools/attach/Exportedfiles.gmk - make/com/sun/tools/attach/FILES_c.gmk - make/com/sun/tools/attach/FILES_java.gmk - make/com/sun/tools/attach/Makefile - make/com/sun/tools/attach/mapfile-bsd - make/com/sun/tools/attach/mapfile-linux - make/com/sun/tools/attach/mapfile-solaris - make/com/sun/tracing/Makefile - make/com/sun/tracing/dtrace/Makefile - make/common/BuildToolJar.gmk - make/common/CancelImplicits.gmk - make/common/Classes.gmk - make/common/Cscope.gmk - make/common/Defs-linux.gmk - make/common/Defs-macosx.gmk - make/common/Defs-solaris.gmk - make/common/Defs-windows.gmk - make/common/Defs.gmk - make/common/Demo.gmk - make/common/Library.gmk - make/common/Mapfile-vers.gmk - make/common/Program.gmk - make/common/Release-macosx.gmk - make/common/Release.gmk - make/common/Rules.gmk - make/common/Sanity.gmk - make/common/Subdirs.gmk - make/common/internal/Defs-corba.gmk - make/common/internal/Defs-jaxp.gmk - make/common/internal/Defs-jaxws.gmk - make/common/internal/Defs-langtools.gmk - make/common/internal/ImportComponents.gmk - make/common/internal/NativeCompileRules.gmk - make/common/internal/Resources.gmk - make/common/shared/Compiler-gcc.gmk - make/common/shared/Compiler-llvm.gmk - make/common/shared/Compiler-msvc.gmk - make/common/shared/Compiler-sun.gmk - make/common/shared/Defs-control.gmk - make/common/shared/Defs-java.gmk - make/common/shared/Defs-javadoc.gmk - make/common/shared/Defs-linux.gmk - make/common/shared/Defs-macosx.gmk - make/common/shared/Defs-solaris.gmk - make/common/shared/Defs-utils.gmk - make/common/shared/Defs-versions.gmk - make/common/shared/Defs-windows.gmk - make/common/shared/Defs.gmk - make/common/shared/Platform.gmk - make/common/shared/PrivateDefs.gmk-example - make/common/shared/Sanity-Settings.gmk - make/common/shared/Sanity.gmk + make/data/characterdata/CharacterData00.java.template + make/data/characterdata/CharacterData01.java.template + make/data/characterdata/CharacterData02.java.template + make/data/characterdata/CharacterData0E.java.template + make/data/characterdata/CharacterDataLatin1.java.template + make/data/characterdata/CharacterDataPrivateUse.java.template + make/data/characterdata/CharacterDataUndefined.java.template + make/data/charsetmapping/Big5.map + make/data/charsetmapping/Big5.nr + make/data/charsetmapping/DoubleByte-X.java.template + make/data/charsetmapping/EUC_CN.map + make/data/charsetmapping/EUC_KR.map + make/data/charsetmapping/GBK.map + make/data/charsetmapping/HKSCS2001.c2b + make/data/charsetmapping/HKSCS2001.map + make/data/charsetmapping/HKSCS2008.c2b + make/data/charsetmapping/HKSCS2008.map + make/data/charsetmapping/HKSCS_XP.c2b + make/data/charsetmapping/HKSCS_XP.map + make/data/charsetmapping/IBM037.c2b + make/data/charsetmapping/IBM037.map + make/data/charsetmapping/IBM037.nr + make/data/charsetmapping/IBM1006.map + make/data/charsetmapping/IBM1025.c2b + make/data/charsetmapping/IBM1025.map + make/data/charsetmapping/IBM1025.nr + make/data/charsetmapping/IBM1026.c2b + make/data/charsetmapping/IBM1026.map + make/data/charsetmapping/IBM1026.nr + make/data/charsetmapping/IBM1046.map + make/data/charsetmapping/IBM1047.map + make/data/charsetmapping/IBM1097.map + make/data/charsetmapping/IBM1098.map + make/data/charsetmapping/IBM1112.c2b + make/data/charsetmapping/IBM1112.map + make/data/charsetmapping/IBM1112.nr + make/data/charsetmapping/IBM1122.c2b + make/data/charsetmapping/IBM1122.map + make/data/charsetmapping/IBM1122.nr + make/data/charsetmapping/IBM1123.c2b + make/data/charsetmapping/IBM1123.map + make/data/charsetmapping/IBM1123.nr + make/data/charsetmapping/IBM1124.map + make/data/charsetmapping/IBM1140.c2b + make/data/charsetmapping/IBM1140.map + make/data/charsetmapping/IBM1141.c2b + make/data/charsetmapping/IBM1141.map + make/data/charsetmapping/IBM1142.c2b + make/data/charsetmapping/IBM1142.map + make/data/charsetmapping/IBM1143.c2b + make/data/charsetmapping/IBM1143.map + make/data/charsetmapping/IBM1144.c2b + make/data/charsetmapping/IBM1144.map + make/data/charsetmapping/IBM1145.c2b + make/data/charsetmapping/IBM1145.map + make/data/charsetmapping/IBM1146.c2b + make/data/charsetmapping/IBM1146.map + make/data/charsetmapping/IBM1147.c2b + make/data/charsetmapping/IBM1147.map + make/data/charsetmapping/IBM1148.c2b + make/data/charsetmapping/IBM1148.map + make/data/charsetmapping/IBM1149.c2b + make/data/charsetmapping/IBM1149.map + make/data/charsetmapping/IBM1364.c2b + make/data/charsetmapping/IBM1364.map + make/data/charsetmapping/IBM1381.c2b + make/data/charsetmapping/IBM1381.map + make/data/charsetmapping/IBM1383.c2b + make/data/charsetmapping/IBM1383.map + make/data/charsetmapping/IBM1383.nr + make/data/charsetmapping/IBM273.c2b + make/data/charsetmapping/IBM273.map + make/data/charsetmapping/IBM273.nr + make/data/charsetmapping/IBM277.c2b + make/data/charsetmapping/IBM277.map + make/data/charsetmapping/IBM277.nr + make/data/charsetmapping/IBM278.c2b + make/data/charsetmapping/IBM278.map + make/data/charsetmapping/IBM278.nr + make/data/charsetmapping/IBM280.c2b + make/data/charsetmapping/IBM280.map + make/data/charsetmapping/IBM280.nr + make/data/charsetmapping/IBM284.c2b + make/data/charsetmapping/IBM284.map + make/data/charsetmapping/IBM284.nr + make/data/charsetmapping/IBM285.c2b + make/data/charsetmapping/IBM285.map + make/data/charsetmapping/IBM285.nr + make/data/charsetmapping/IBM290.c2b + make/data/charsetmapping/IBM290.map + make/data/charsetmapping/IBM297.c2b + make/data/charsetmapping/IBM297.map + make/data/charsetmapping/IBM297.nr + make/data/charsetmapping/IBM300.c2b + make/data/charsetmapping/IBM300.map + make/data/charsetmapping/IBM420.c2b + make/data/charsetmapping/IBM420.map + make/data/charsetmapping/IBM420.nr + make/data/charsetmapping/IBM424.c2b + make/data/charsetmapping/IBM424.map + make/data/charsetmapping/IBM424.nr + make/data/charsetmapping/IBM437.map + make/data/charsetmapping/IBM500.c2b + make/data/charsetmapping/IBM500.map + make/data/charsetmapping/IBM500.nr + make/data/charsetmapping/IBM737.map + make/data/charsetmapping/IBM775.map + make/data/charsetmapping/IBM833.c2b + make/data/charsetmapping/IBM833.map + make/data/charsetmapping/IBM838.c2b + make/data/charsetmapping/IBM838.map + make/data/charsetmapping/IBM838.nr + make/data/charsetmapping/IBM850.map + make/data/charsetmapping/IBM852.map + make/data/charsetmapping/IBM855.map + make/data/charsetmapping/IBM856.map + make/data/charsetmapping/IBM857.map + make/data/charsetmapping/IBM858.map + make/data/charsetmapping/IBM860.map + make/data/charsetmapping/IBM861.map + make/data/charsetmapping/IBM862.map + make/data/charsetmapping/IBM863.map + make/data/charsetmapping/IBM864.map + make/data/charsetmapping/IBM865.map + make/data/charsetmapping/IBM866.map + make/data/charsetmapping/IBM868.map + make/data/charsetmapping/IBM869.map + make/data/charsetmapping/IBM870.c2b + make/data/charsetmapping/IBM870.map + make/data/charsetmapping/IBM870.nr + make/data/charsetmapping/IBM871.c2b + make/data/charsetmapping/IBM871.map + make/data/charsetmapping/IBM871.nr + make/data/charsetmapping/IBM874.map + make/data/charsetmapping/IBM874.nr + make/data/charsetmapping/IBM875.c2b + make/data/charsetmapping/IBM875.map + make/data/charsetmapping/IBM875.nr + make/data/charsetmapping/IBM918.c2b + make/data/charsetmapping/IBM918.map + make/data/charsetmapping/IBM918.nr + make/data/charsetmapping/IBM921.map + make/data/charsetmapping/IBM922.map + make/data/charsetmapping/IBM930.c2b + make/data/charsetmapping/IBM930.map + make/data/charsetmapping/IBM930.nr + make/data/charsetmapping/IBM933.c2b + make/data/charsetmapping/IBM933.map + make/data/charsetmapping/IBM935.c2b + make/data/charsetmapping/IBM935.map + make/data/charsetmapping/IBM935.nr + make/data/charsetmapping/IBM937.c2b + make/data/charsetmapping/IBM937.map + make/data/charsetmapping/IBM937.nr + make/data/charsetmapping/IBM939.c2b + make/data/charsetmapping/IBM939.map + make/data/charsetmapping/IBM939.nr + make/data/charsetmapping/IBM942.c2b + make/data/charsetmapping/IBM942.map + make/data/charsetmapping/IBM943.map + make/data/charsetmapping/IBM943.nr + make/data/charsetmapping/IBM948.c2b + make/data/charsetmapping/IBM948.map + make/data/charsetmapping/IBM949.map + make/data/charsetmapping/IBM950.c2b + make/data/charsetmapping/IBM950.map + make/data/charsetmapping/IBM970.c2b + make/data/charsetmapping/IBM970.map + make/data/charsetmapping/ISO_8859_11.map + make/data/charsetmapping/ISO_8859_13.map + make/data/charsetmapping/ISO_8859_15.map + make/data/charsetmapping/ISO_8859_2.map + make/data/charsetmapping/ISO_8859_3.map + make/data/charsetmapping/ISO_8859_4.map + make/data/charsetmapping/ISO_8859_5.map + make/data/charsetmapping/ISO_8859_6.map + make/data/charsetmapping/ISO_8859_7.map + make/data/charsetmapping/ISO_8859_8.map + make/data/charsetmapping/ISO_8859_9.map + make/data/charsetmapping/JIS_X_0201.c2b + make/data/charsetmapping/JIS_X_0201.map + make/data/charsetmapping/JIS_X_0208.map + make/data/charsetmapping/JIS_X_0208_MS5022X.c2b + make/data/charsetmapping/JIS_X_0208_MS5022X.map + make/data/charsetmapping/JIS_X_0208_MS932.map + make/data/charsetmapping/JIS_X_0208_MS932.nr + make/data/charsetmapping/JIS_X_0208_Solaris.map + make/data/charsetmapping/JIS_X_0208_Solaris.nr + make/data/charsetmapping/JIS_X_0212.map + make/data/charsetmapping/JIS_X_0212_MS5022X.map + make/data/charsetmapping/JIS_X_0212_Solaris.map + make/data/charsetmapping/JIS_X_0212_Solaris.nr + make/data/charsetmapping/Johab.map + make/data/charsetmapping/KOI8_R.map + make/data/charsetmapping/KOI8_U.map + make/data/charsetmapping/MS1250.map + make/data/charsetmapping/MS1251.map + make/data/charsetmapping/MS1252.map + make/data/charsetmapping/MS1253.map + make/data/charsetmapping/MS1254.map + make/data/charsetmapping/MS1255.map + make/data/charsetmapping/MS1256.map + make/data/charsetmapping/MS1257.map + make/data/charsetmapping/MS1258.map + make/data/charsetmapping/MS874.map + make/data/charsetmapping/MS932.c2b + make/data/charsetmapping/MS932.map + make/data/charsetmapping/MS932.nr + make/data/charsetmapping/MS936.map + make/data/charsetmapping/MS949.map + make/data/charsetmapping/MS950.map + make/data/charsetmapping/MS950.nr + make/data/charsetmapping/MacArabic.map + make/data/charsetmapping/MacCentralEurope.map + make/data/charsetmapping/MacCroatian.map + make/data/charsetmapping/MacCyrillic.map + make/data/charsetmapping/MacDingbat.map + make/data/charsetmapping/MacGreek.map + make/data/charsetmapping/MacHebrew.map + make/data/charsetmapping/MacIceland.map + make/data/charsetmapping/MacRoman.map + make/data/charsetmapping/MacRomania.map + make/data/charsetmapping/MacSymbol.map + make/data/charsetmapping/MacThai.map + make/data/charsetmapping/MacTurkish.map + make/data/charsetmapping/MacUkraine.map + make/data/charsetmapping/PCK.c2b + make/data/charsetmapping/PCK.map + make/data/charsetmapping/PCK.nr + make/data/charsetmapping/SJIS.c2b + make/data/charsetmapping/SJIS.map + make/data/charsetmapping/SingleByte-X.java.template + make/data/charsetmapping/TIS_620.map + make/data/charsetmapping/dbcs + make/data/charsetmapping/euc_tw.map + make/data/charsetmapping/extsbcs + make/data/charsetmapping/sbcs + make/data/charsetmapping/sjis0213.map + make/data/checkdeps/refs.allowed + make/data/classlist/classlist.linux + make/data/classlist/classlist.macosx + make/data/classlist/classlist.solaris + make/data/classlist/classlist.windows + make/data/cryptopolicy/limited/LIMITED + make/data/cryptopolicy/limited/default_local.policy + make/data/cryptopolicy/limited/exempt_local.policy + make/data/cryptopolicy/unlimited/UNLIMITED + make/data/cryptopolicy/unlimited/default_US_export.policy + make/data/cryptopolicy/unlimited/default_local.policy + make/data/dtdbuilder/HTMLlat1.sgml + make/data/dtdbuilder/HTMLspecial.sgml + make/data/dtdbuilder/HTMLsymbol.sgml + make/data/dtdbuilder/html32.dtd + make/data/dtdbuilder/public.map + make/data/jdwp/jdwp.spec + make/data/mainmanifest/manifest.mf + make/data/swingbeaninfo/SwingBeanInfo.template + make/data/swingbeaninfo/images/AbstractButtonColor16.gif + make/data/swingbeaninfo/images/BorderColor16.gif + make/data/swingbeaninfo/images/BoxColor16.gif + make/data/swingbeaninfo/images/BoxColor32.gif + make/data/swingbeaninfo/images/BoxMono16.gif + make/data/swingbeaninfo/images/BoxMono32.gif + make/data/swingbeaninfo/images/JAppletColor16.gif + make/data/swingbeaninfo/images/JAppletColor32.gif + make/data/swingbeaninfo/images/JAppletMono16.gif + make/data/swingbeaninfo/images/JAppletMono32.gif + make/data/swingbeaninfo/images/JButtonColor16.gif + make/data/swingbeaninfo/images/JButtonColor32.gif + make/data/swingbeaninfo/images/JButtonMono16.gif + make/data/swingbeaninfo/images/JButtonMono32.gif + make/data/swingbeaninfo/images/JCheckBoxColor16.gif + make/data/swingbeaninfo/images/JCheckBoxColor32.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemColor16.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemColor32.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemMono16.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemMono32.gif + make/data/swingbeaninfo/images/JCheckBoxMono16.gif + make/data/swingbeaninfo/images/JCheckBoxMono32.gif + make/data/swingbeaninfo/images/JColorChooserColor16.gif + make/data/swingbeaninfo/images/JColorChooserColor32.gif + make/data/swingbeaninfo/images/JColorChooserMono16.gif + make/data/swingbeaninfo/images/JColorChooserMono32.gif + make/data/swingbeaninfo/images/JComboBoxColor16.gif + make/data/swingbeaninfo/images/JComboBoxColor32.gif + make/data/swingbeaninfo/images/JComboBoxMono16.gif + make/data/swingbeaninfo/images/JComboBoxMono32.gif + make/data/swingbeaninfo/images/JComponentColor16.gif + make/data/swingbeaninfo/images/JDesktopPaneColor16.gif + make/data/swingbeaninfo/images/JDesktopPaneColor32.gif + make/data/swingbeaninfo/images/JDesktopPaneMono16.gif + make/data/swingbeaninfo/images/JDesktopPaneMono32.gif + make/data/swingbeaninfo/images/JDialogColor16.gif + make/data/swingbeaninfo/images/JDialogColor32.gif + make/data/swingbeaninfo/images/JDialogMono16.gif + make/data/swingbeaninfo/images/JDialogMono32.gif + make/data/swingbeaninfo/images/JEditorPaneColor16.gif + make/data/swingbeaninfo/images/JEditorPaneColor32.gif + make/data/swingbeaninfo/images/JEditorPaneMono16.gif + make/data/swingbeaninfo/images/JEditorPaneMono32.gif + make/data/swingbeaninfo/images/JFileChooserColor16.gif + make/data/swingbeaninfo/images/JFileChooserColor32.gif + make/data/swingbeaninfo/images/JFileChooserMono16.gif + make/data/swingbeaninfo/images/JFileChooserMono32.gif + make/data/swingbeaninfo/images/JFormattedTextFieldColor16.gif + make/data/swingbeaninfo/images/JFormattedTextFieldColor32.gif + make/data/swingbeaninfo/images/JFormattedTextFieldMono16.gif + make/data/swingbeaninfo/images/JFormattedTextFieldMono32.gif + make/data/swingbeaninfo/images/JFrameColor16.gif + make/data/swingbeaninfo/images/JFrameColor32.gif + make/data/swingbeaninfo/images/JFrameMono16.gif + make/data/swingbeaninfo/images/JFrameMono32.gif + make/data/swingbeaninfo/images/JInternalFrameColor16.gif + make/data/swingbeaninfo/images/JInternalFrameColor32.gif + make/data/swingbeaninfo/images/JInternalFrameMono16.gif + make/data/swingbeaninfo/images/JInternalFrameMono32.gif + make/data/swingbeaninfo/images/JLabelColor16.gif + make/data/swingbeaninfo/images/JLabelColor32.gif + make/data/swingbeaninfo/images/JLabelMono16.gif + make/data/swingbeaninfo/images/JLabelMono32.gif + make/data/swingbeaninfo/images/JLayeredPaneColor16.gif + make/data/swingbeaninfo/images/JLayeredPaneColor32.gif + make/data/swingbeaninfo/images/JLayeredPaneMono16.gif + make/data/swingbeaninfo/images/JLayeredPaneMono32.gif + make/data/swingbeaninfo/images/JListColor16.gif + make/data/swingbeaninfo/images/JListColor32.gif + make/data/swingbeaninfo/images/JListMono16.gif + make/data/swingbeaninfo/images/JListMono32.gif + make/data/swingbeaninfo/images/JMenuBarColor16.gif + make/data/swingbeaninfo/images/JMenuBarColor32.gif + make/data/swingbeaninfo/images/JMenuBarMono16.gif + make/data/swingbeaninfo/images/JMenuBarMono32.gif + make/data/swingbeaninfo/images/JMenuColor16.gif + make/data/swingbeaninfo/images/JMenuColor32.gif + make/data/swingbeaninfo/images/JMenuItemColor16.gif + make/data/swingbeaninfo/images/JMenuItemColor32.gif + make/data/swingbeaninfo/images/JMenuItemMono16.gif + make/data/swingbeaninfo/images/JMenuItemMono32.gif + make/data/swingbeaninfo/images/JMenuMono16.gif + make/data/swingbeaninfo/images/JMenuMono32.gif + make/data/swingbeaninfo/images/JOptionPaneColor16.gif + make/data/swingbeaninfo/images/JOptionPaneColor32.gif + make/data/swingbeaninfo/images/JOptionPaneMono16.gif + make/data/swingbeaninfo/images/JOptionPaneMono32.gif + make/data/swingbeaninfo/images/JPanelColor16.gif + make/data/swingbeaninfo/images/JPanelColor32.gif + make/data/swingbeaninfo/images/JPanelMono16.gif + make/data/swingbeaninfo/images/JPanelMono32.gif + make/data/swingbeaninfo/images/JPasswordFieldColor16.gif + make/data/swingbeaninfo/images/JPasswordFieldColor32.gif + make/data/swingbeaninfo/images/JPasswordFieldMono16.gif + make/data/swingbeaninfo/images/JPasswordFieldMono32.gif + make/data/swingbeaninfo/images/JPopupMenuColor16.gif + make/data/swingbeaninfo/images/JPopupMenuColor32.gif + make/data/swingbeaninfo/images/JPopupMenuMono16.gif + make/data/swingbeaninfo/images/JPopupMenuMono32.gif + make/data/swingbeaninfo/images/JProgressBarColor16.gif + make/data/swingbeaninfo/images/JProgressBarColor32.gif + make/data/swingbeaninfo/images/JProgressBarMono16.gif + make/data/swingbeaninfo/images/JProgressBarMono32.gif + make/data/swingbeaninfo/images/JRadioButtonColor16.gif + make/data/swingbeaninfo/images/JRadioButtonColor32.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemColor16.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemColor32.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemMono16.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemMono32.gif + make/data/swingbeaninfo/images/JRadioButtonMono16.gif + make/data/swingbeaninfo/images/JRadioButtonMono32.gif + make/data/swingbeaninfo/images/JRootPaneColor16.gif + make/data/swingbeaninfo/images/JRootPaneColor32.gif + make/data/swingbeaninfo/images/JRootPaneMono16.gif + make/data/swingbeaninfo/images/JRootPaneMono32.gif + make/data/swingbeaninfo/images/JScrollBarColor16.gif + make/data/swingbeaninfo/images/JScrollBarColor32.gif + make/data/swingbeaninfo/images/JScrollBarMono16.gif + make/data/swingbeaninfo/images/JScrollBarMono32.gif + make/data/swingbeaninfo/images/JScrollPaneColor16.gif + make/data/swingbeaninfo/images/JScrollPaneColor32.gif + make/data/swingbeaninfo/images/JScrollPaneMono16.gif + make/data/swingbeaninfo/images/JScrollPaneMono32.gif + make/data/swingbeaninfo/images/JSeparatorColor16.gif + make/data/swingbeaninfo/images/JSeparatorColor32.gif + make/data/swingbeaninfo/images/JSeparatorMono16.gif + make/data/swingbeaninfo/images/JSeparatorMono32.gif + make/data/swingbeaninfo/images/JSliderColor16.gif + make/data/swingbeaninfo/images/JSliderColor32.gif + make/data/swingbeaninfo/images/JSliderMono16.gif + make/data/swingbeaninfo/images/JSliderMono32.gif + make/data/swingbeaninfo/images/JSpinnerColor16.gif + make/data/swingbeaninfo/images/JSpinnerColor32.gif + make/data/swingbeaninfo/images/JSpinnerMono16.gif + make/data/swingbeaninfo/images/JSpinnerMono32.gif + make/data/swingbeaninfo/images/JSplitPaneColor16.gif + make/data/swingbeaninfo/images/JSplitPaneColor32.gif + make/data/swingbeaninfo/images/JSplitPaneMono16.gif + make/data/swingbeaninfo/images/JSplitPaneMono32.gif + make/data/swingbeaninfo/images/JTabbedPaneColor16.gif + make/data/swingbeaninfo/images/JTabbedPaneColor32.gif + make/data/swingbeaninfo/images/JTabbedPaneMono16.gif + make/data/swingbeaninfo/images/JTabbedPaneMono32.gif + make/data/swingbeaninfo/images/JTableColor16.gif + make/data/swingbeaninfo/images/JTableColor32.gif + make/data/swingbeaninfo/images/JTableMono16.gif + make/data/swingbeaninfo/images/JTableMono32.gif + make/data/swingbeaninfo/images/JTextAreaColor16.gif + make/data/swingbeaninfo/images/JTextAreaColor32.gif + make/data/swingbeaninfo/images/JTextAreaMono16.gif + make/data/swingbeaninfo/images/JTextAreaMono32.gif + make/data/swingbeaninfo/images/JTextFieldColor16.gif + make/data/swingbeaninfo/images/JTextFieldColor32.gif + make/data/swingbeaninfo/images/JTextFieldMono16.gif + make/data/swingbeaninfo/images/JTextFieldMono32.gif + make/data/swingbeaninfo/images/JTextPaneColor16.gif + make/data/swingbeaninfo/images/JTextPaneColor32.gif + make/data/swingbeaninfo/images/JTextPaneMono16.gif + make/data/swingbeaninfo/images/JTextPaneMono32.gif + make/data/swingbeaninfo/images/JToggleButtonColor16.gif + make/data/swingbeaninfo/images/JToggleButtonColor32.gif + make/data/swingbeaninfo/images/JToggleButtonMono16.gif + make/data/swingbeaninfo/images/JToggleButtonMono32.gif + make/data/swingbeaninfo/images/JToolBarColor16.gif + make/data/swingbeaninfo/images/JToolBarColor32.gif + make/data/swingbeaninfo/images/JToolBarMono16.gif + make/data/swingbeaninfo/images/JToolBarMono32.gif + make/data/swingbeaninfo/images/JTreeColor16.gif + make/data/swingbeaninfo/images/JTreeColor32.gif + make/data/swingbeaninfo/images/JTreeMono16.gif + make/data/swingbeaninfo/images/JTreeMono32.gif + make/data/swingbeaninfo/images/JViewportColor16.gif + make/data/swingbeaninfo/images/JViewportColor32.gif + make/data/swingbeaninfo/images/JViewportMono16.gif + make/data/swingbeaninfo/images/JViewportMono32.gif + make/data/swingbeaninfo/images/JWindowColor16.gif + make/data/swingbeaninfo/images/JWindowColor32.gif + make/data/swingbeaninfo/images/JWindowMono16.gif + make/data/swingbeaninfo/images/JWindowMono32.gif + make/data/swingbeaninfo/javax/swing/SwingBeanInfoBase.java + make/data/swingbeaninfo/manifest.mf + make/data/swingbeaninfo/sun/swing/BeanInfoUtils.java + make/data/tzdata/VERSION + make/data/tzdata/africa + make/data/tzdata/antarctica + make/data/tzdata/asia + make/data/tzdata/australasia + make/data/tzdata/backward + make/data/tzdata/etcetera + make/data/tzdata/europe + make/data/tzdata/factory + make/data/tzdata/gmt + make/data/tzdata/iso3166.tab + make/data/tzdata/jdk11_backward + make/data/tzdata/leapseconds + make/data/tzdata/northamerica + make/data/tzdata/pacificnew + make/data/tzdata/solar87 + make/data/tzdata/solar88 + make/data/tzdata/solar89 + make/data/tzdata/southamerica + make/data/tzdata/systemv + make/data/tzdata/zone.tab + make/data/unicodedata/PropList.txt + make/data/unicodedata/Scripts.txt + make/data/unicodedata/SpecialCasing.txt + make/data/unicodedata/UnicodeData.txt + make/data/unicodedata/VERSION - make/docs/CORE_PKGS.gmk - make/docs/Makefile - make/docs/NON_CORE_PKGS.gmk - make/docs/Notes.html + make/gendata/GendataBreakIterator.gmk + make/gendata/GendataFontConfig.gmk + make/gendata/GendataHtml32dtd.gmk + make/gendata/GendataTZDB.gmk + make/gensrc/GensrcBuffer.gmk + make/gensrc/GensrcCLDR.gmk + make/gensrc/GensrcCharacterData.gmk + make/gensrc/GensrcCharsetCoder.gmk + make/gensrc/GensrcCharsetMapping.gmk + make/gensrc/GensrcExceptions.gmk + make/gensrc/GensrcIcons.gmk + make/gensrc/GensrcJDWP.gmk + make/gensrc/GensrcJObjC.gmk + make/gensrc/GensrcLocaleDataMetaInfo.gmk + make/gensrc/GensrcMisc.gmk + make/gensrc/GensrcProperties.gmk + make/gensrc/GensrcSwing.gmk + make/gensrc/GensrcX11Wrappers.gmk - make/java/Makefile - make/java/applet/Makefile - make/java/awt/Makefile - make/java/beans/Makefile - make/java/fdlibm/FILES_c.gmk - make/java/fdlibm/Makefile - make/java/instrument/Makefile - make/java/instrument/mapfile-vers - make/java/invoke/Makefile - make/java/jar/Makefile - make/java/java/Exportedfiles.gmk - make/java/java/FILES_c.gmk - make/java/java/FILES_java.gmk - make/java/java/Makefile - make/java/java/genlocales.gmk - make/java/java/localegen.sh - make/java/java/localelist.sh - make/java/java/mapfile-vers - make/java/java/reflect/Makefile - make/java/java/reorder-i586 - make/java/java/reorder-sparc - make/java/java/reorder-sparcv9 - make/java/java_crw_demo/Makefile - make/java/java_crw_demo/mapfile-vers - make/java/java_hprof_demo/Makefile - make/java/java_hprof_demo/mapfile-vers - make/java/jexec/Makefile - make/java/jli/Makefile - make/java/jli/mapfile-vers - make/java/jobjc/Makefile - make/java/jvm/Makefile - make/java/logging/Makefile - make/java/main/Makefile - make/java/main/java/Makefile - make/java/main/java/mapfile-amd64 - make/java/main/java/mapfile-i586 - make/java/main/java/mapfile-sparc - make/java/main/java/mapfile-sparcv9 - make/java/main/javaw/Makefile - make/java/management/Exportedfiles.gmk - make/java/management/FILES_c.gmk - make/java/management/Makefile - make/java/management/mapfile-vers - make/java/math/Makefile - make/java/net/FILES_c.gmk - make/java/net/Makefile - make/java/net/mapfile-vers - make/java/nio/Exportedfiles.gmk - make/java/nio/FILES_c.gmk - make/java/nio/FILES_java.gmk - make/java/nio/Makefile - make/java/nio/addNotices.sh - make/java/nio/genBuffer.sh - make/java/nio/genCharsetProvider.sh - make/java/nio/genCoder.sh - make/java/nio/genExceptions.sh - make/java/nio/mapfile-bsd - make/java/nio/mapfile-linux - make/java/nio/mapfile-solaris - make/java/nio/reorder-i586 - make/java/nio/reorder-sparc - make/java/nio/reorder-sparcv9 - make/java/npt/Makefile - make/java/npt/mapfile-vers - make/java/redist/Makefile - make/java/redist/fonts/Makefile - make/java/redist/sajdi/Makefile - make/java/rmi/Makefile - make/java/security/Makefile - make/java/sql/Makefile - make/java/sun_nio/FILES_java.gmk - make/java/sun_nio/Makefile - make/java/text/Makefile - make/java/text/base/FILES_java.gmk - make/java/text/base/Makefile - make/java/text/bidi/Makefile - make/java/time/Makefile - make/java/util/FILES_java.gmk - make/java/util/FILES_properties.gmk - make/java/util/Makefile - make/java/verify/Makefile - make/java/verify/mapfile-vers - make/java/verify/reorder-i586 - make/java/verify/reorder-sparc - make/java/verify/reorder-sparcv9 - make/java/version/Makefile - make/java/zip/FILES_c.gmk - make/java/zip/FILES_java.gmk - make/java/zip/Makefile - make/java/zip/mapfile-vers - make/java/zip/reorder-i586 - make/java/zip/reorder-sparc - make/java/zip/reorder-sparcv9 - make/javax/Makefile - make/javax/accessibility/Makefile - make/javax/crypto/Defs-jce.gmk - make/javax/crypto/Makefile - make/javax/crypto/policy/limited/LIMITED - make/javax/crypto/policy/limited/default_local.policy - make/javax/crypto/policy/limited/exempt_local.policy - make/javax/crypto/policy/unlimited/UNLIMITED - make/javax/crypto/policy/unlimited/default_US_export.policy - make/javax/crypto/policy/unlimited/default_local.policy - make/javax/imageio/Makefile - make/javax/management/Makefile - make/javax/others/Makefile - make/javax/print/Makefile - make/javax/rmi/Makefile - make/javax/rmi/ssl/Makefile - make/javax/security/Makefile - make/javax/sound/FILES_c.gmk - make/javax/sound/Makefile - make/javax/sound/SoundDefs.gmk - make/javax/sound/jsoundalsa/Makefile - make/javax/sound/jsoundalsa/mapfile-vers - make/javax/sound/jsoundds/Makefile - make/javax/sound/mapfile-vers - make/javax/sql/Makefile - make/javax/swing/FILES.gmk - make/javax/swing/Makefile - make/javax/swing/beaninfo/FILES.gmk - make/javax/swing/beaninfo/Makefile - make/javax/swing/beaninfo/SwingBeans.gmk - make/javax/swing/beaninfo/manifest - make/javax/swing/html32dtd/Makefile - make/javax/swing/plaf/FILES.gmk - make/javax/swing/plaf/Makefile - make/jdk/Makefile - make/jdk_generic_profile.sh - make/jpda/Makefile - make/jpda/back/Makefile - make/jpda/back/mapfile-vers - make/jpda/bdi/Makefile - make/jpda/expr/Makefile - make/jpda/front/Makefile - make/jpda/gui/Makefile - make/jpda/jdwp/Makefile - make/jpda/jdwp/jdwp.spec - make/jpda/transport/Makefile - make/jpda/transport/shmem/Makefile - make/jpda/transport/shmem/mapfile-vers - make/jpda/transport/socket/Makefile - make/jpda/transport/socket/mapfile-vers - make/jpda/tty/Makefile - make/jprt.gmk - make/jprt.properties - make/launchers/Makefile - make/launchers/Makefile.launcher + make/lib/Awt2dLibraries.gmk + make/lib/CoreLibraries.gmk + make/lib/NetworkingLibraries.gmk + make/lib/NioLibraries.gmk + make/lib/PlatformLibraries.gmk + make/lib/SecurityLibraries.gmk + make/lib/ServiceabilityLibraries.gmk + make/lib/SoundLibraries.gmk + make/mapfiles/launchers/mapfile-sparc + make/mapfiles/launchers/mapfile-sparcv9 + make/mapfiles/launchers/mapfile-x86 + make/mapfiles/launchers/mapfile-x86_64 + make/mapfiles/libattach/mapfile-linux + make/mapfiles/libattach/mapfile-solaris + make/mapfiles/libattach/reorder-windows-x86 + make/mapfiles/libattach/reorder-windows-x86_64 + make/mapfiles/libawt/mapfile-mawt-vers + make/mapfiles/libawt/mapfile-vers + make/mapfiles/libawt/mapfile-vers-linux + make/mapfiles/libawt_headless/mapfile-vers + make/mapfiles/libawt_headless/reorder-sparc + make/mapfiles/libawt_headless/reorder-sparcv9 + make/mapfiles/libawt_headless/reorder-x86 + make/mapfiles/libawt_xawt/mapfile-vers + make/mapfiles/libdcpr/mapfile-vers + make/mapfiles/libdt_socket/mapfile-vers + make/mapfiles/libfontmanager/mapfile-vers + make/mapfiles/libfontmanager/mapfile-vers.openjdk + make/mapfiles/libhprof/mapfile-vers + make/mapfiles/libinstrument/mapfile-vers + make/mapfiles/libj2gss/mapfile-vers + make/mapfiles/libj2pcsc/mapfile-vers + make/mapfiles/libj2pkcs11/mapfile-vers + make/mapfiles/libj2ucrypto/mapfile-vers + make/mapfiles/libjaas/mapfile-vers + make/mapfiles/libjava/mapfile-vers + make/mapfiles/libjava/reorder-sparc + make/mapfiles/libjava/reorder-sparcv9 + make/mapfiles/libjava/reorder-x86 + make/mapfiles/libjava_crw_demo/mapfile-vers + make/mapfiles/libjawt/mapfile-vers + make/mapfiles/libjdga/mapfile-vers + make/mapfiles/libjdwp/mapfile-vers + make/mapfiles/libjfr/mapfile-vers + make/mapfiles/libjli/mapfile-vers + make/mapfiles/libjpeg/mapfile-vers + make/mapfiles/libjpeg/mapfile-vers-closed + make/mapfiles/libjpeg/reorder-sparc + make/mapfiles/libjpeg/reorder-sparcv9 + make/mapfiles/libjpeg/reorder-x86 + make/mapfiles/libjsdt/mapfile-vers + make/mapfiles/libjsound/mapfile-vers + make/mapfiles/libjsoundalsa/mapfile-vers + make/mapfiles/libkcms/mapfile-vers + make/mapfiles/liblcms/mapfile-vers + make/mapfiles/libmanagement/mapfile-vers + make/mapfiles/libmlib_image/mapfile-vers + make/mapfiles/libnet/mapfile-vers + make/mapfiles/libnio/mapfile-linux + make/mapfiles/libnio/mapfile-macosx + make/mapfiles/libnio/mapfile-solaris + make/mapfiles/libnio/reorder-sparc + make/mapfiles/libnio/reorder-sparcv9 + make/mapfiles/libnio/reorder-x86 + make/mapfiles/libnpt/mapfile-vers + make/mapfiles/libsctp/mapfile-vers + make/mapfiles/libsplashscreen/mapfile-vers + make/mapfiles/libsunec/mapfile-vers + make/mapfiles/libt2k/mapfile-vers + make/mapfiles/libunpack/mapfile-vers + make/mapfiles/libunpack/mapfile-vers-unpack200 + make/mapfiles/libverify/mapfile-vers + make/mapfiles/libverify/reorder-sparc + make/mapfiles/libverify/reorder-sparcv9 + make/mapfiles/libverify/reorder-x86 + make/mapfiles/libzip/mapfile-vers + make/mapfiles/libzip/reorder-sparc + make/mapfiles/libzip/reorder-sparcv9 + make/mapfiles/libzip/reorder-x86 - make/mkdemo/Makefile - make/mkdemo/applets/Animator/Makefile - make/mkdemo/applets/ArcTest/Makefile - make/mkdemo/applets/BarChart/Makefile - make/mkdemo/applets/Blink/Makefile - make/mkdemo/applets/CardTest/Makefile - make/mkdemo/applets/Clock/Makefile - make/mkdemo/applets/DitherTest/Makefile - make/mkdemo/applets/DrawTest/Makefile - make/mkdemo/applets/Fractal/Makefile - make/mkdemo/applets/GraphLayout/Makefile - make/mkdemo/applets/GraphicsTest/Makefile - make/mkdemo/applets/JumpingBox/Makefile - make/mkdemo/applets/Makefile - make/mkdemo/applets/MoleculeViewer/Makefile - make/mkdemo/applets/NervousText/Makefile - make/mkdemo/applets/SimpleGraph/Makefile - make/mkdemo/applets/SortDemo/Makefile - make/mkdemo/applets/SpreadSheet/Makefile - make/mkdemo/applets/TicTacToe/Makefile - make/mkdemo/applets/WireFrame/Makefile - make/mkdemo/jfc/CodePointIM/Makefile - make/mkdemo/jfc/FileChooserDemo/Makefile - make/mkdemo/jfc/Font2DTest/Makefile - make/mkdemo/jfc/Java2D/Makefile - make/mkdemo/jfc/Laffy/Makefile - make/mkdemo/jfc/Makefile - make/mkdemo/jfc/Metalworks/Makefile - make/mkdemo/jfc/Notepad/Makefile - make/mkdemo/jfc/SampleTree/Makefile - make/mkdemo/jfc/Stylepad/Makefile - make/mkdemo/jfc/SwingApplet/Makefile - make/mkdemo/jfc/SwingSet2/Makefile - make/mkdemo/jfc/SwingSet3/Makefile - make/mkdemo/jfc/TableExample/Makefile - make/mkdemo/jfc/TransparentRuler/Makefile - make/mkdemo/jni/Makefile - make/mkdemo/jni/Poller/Makefile - make/mkdemo/jpda/Makefile - make/mkdemo/jvmti/Makefile - make/mkdemo/jvmti/README.txt - make/mkdemo/jvmti/compiledMethodLoad/Makefile - make/mkdemo/jvmti/gctest/Makefile - make/mkdemo/jvmti/heapTracker/Makefile - make/mkdemo/jvmti/heapViewer/Makefile - make/mkdemo/jvmti/hprof/Makefile - make/mkdemo/jvmti/mapfile-vers - make/mkdemo/jvmti/minst/Makefile - make/mkdemo/jvmti/mtrace/Makefile - make/mkdemo/jvmti/versionCheck/Makefile - make/mkdemo/jvmti/waiters/Makefile - make/mkdemo/management/FullThreadDump/Makefile - make/mkdemo/management/JTop/Makefile - make/mkdemo/management/Makefile - make/mkdemo/management/MemoryMonitor/Makefile - make/mkdemo/management/README.txt - make/mkdemo/management/VerboseGC/Makefile - make/mkdemo/nio/Makefile - make/mkdemo/nio/zipfs/Makefile - make/mkdemo/scripting/Makefile - make/mkdemo/scripting/jconsole-plugin/Makefile - make/mksample/Makefile - make/mksample/dtrace/Makefile - make/mksample/forkjoin/Makefile - make/mksample/forkjoin/mergesort/Makefile - make/mksample/jmx/Makefile - make/mksample/jmx/jmx-scandir/Makefile - make/mksample/nbproject/Makefile - make/mksample/nio/Makefile - make/mksample/nio/chatserver/Makefile - make/mksample/nio/file/Makefile - make/mksample/nio/multicast/Makefile - make/mksample/nio/server/Makefile - make/mksample/scripting/Makefile - make/mksample/scripting/scriptpad/Makefile - make/mksample/webservices/EbayClient/Makefile - make/mksample/webservices/EbayServer/Makefile - make/mksample/webservices/Makefile ! make/netbeans/jdwpgen/nbproject/project.properties + make/non-build-utils/reorder/Makefile + make/non-build-utils/reorder/tests/Exit.java + make/non-build-utils/reorder/tests/Hello.java + make/non-build-utils/reorder/tests/IntToString.java + make/non-build-utils/reorder/tests/JHello.java + make/non-build-utils/reorder/tests/LoadFrame.java + make/non-build-utils/reorder/tests/LoadJFrame.java + make/non-build-utils/reorder/tests/LoadToolkit.java + make/non-build-utils/reorder/tests/Null.java + make/non-build-utils/reorder/tests/Sleep.java + make/non-build-utils/reorder/tools/Combine.java + make/non-build-utils/reorder/tools/MaxTime.java + make/non-build-utils/reorder/tools/mcount.c + make/non-build-utils/reorder/tools/remove_mcount.c + make/non-build-utils/reorder/tools/util-i586.il + make/non-build-utils/reorder/tools/util-sparc.il + make/non-build-utils/reorder/tools/util-sparcv9.il + make/non-build-utils/sharing/README.txt + make/non-build-utils/sharing/tests/GHello.java + make/non-build-utils/sharing/tests/Hello.java + make/non-build-utils/sharing/tests/JHello.java + make/non-build-utils/src/build/tools/commentchecker/CommentChecker.java + make/non-build-utils/src/build/tools/dirdiff/DirDiff.java + make/non-build-utils/src/build/tools/makeclasslist/MakeClasslist.java - make/org/Makefile - make/org/ietf/Makefile - make/org/ietf/jgss/FILES_java.gmk - make/org/ietf/jgss/Makefile - make/org/jcp/Makefile + make/profile-includes.txt + make/profile-rtjar-includes.txt + make/scripts/addNotices.sh + make/scripts/genCharsetProvider.sh + make/scripts/genExceptions.sh + make/scripts/localelist.sh + make/src/classes/build/tools/addjsum/AddJsum.java + make/src/classes/build/tools/addtorestrictedpkgs/AddToRestrictedPkgs.java + make/src/classes/build/tools/buildmetaindex/BuildMetaIndex.java + make/src/classes/build/tools/charsetmapping/DBCS.java + make/src/classes/build/tools/charsetmapping/EUC_TW.java + make/src/classes/build/tools/charsetmapping/HKSCS.java + make/src/classes/build/tools/charsetmapping/JIS0213.java + make/src/classes/build/tools/charsetmapping/Main.java + make/src/classes/build/tools/charsetmapping/SBCS.java + make/src/classes/build/tools/charsetmapping/Utils.java + make/src/classes/build/tools/classfile/RemoveMethods.java + make/src/classes/build/tools/cldrconverter/AbstractLDMLHandler.java + make/src/classes/build/tools/cldrconverter/Bundle.java + make/src/classes/build/tools/cldrconverter/BundleGenerator.java + make/src/classes/build/tools/cldrconverter/CLDRConverter.java + make/src/classes/build/tools/cldrconverter/CalendarType.java + make/src/classes/build/tools/cldrconverter/Container.java + make/src/classes/build/tools/cldrconverter/CopyrightHeaders.java + make/src/classes/build/tools/cldrconverter/Entry.java + make/src/classes/build/tools/cldrconverter/IgnoredContainer.java + make/src/classes/build/tools/cldrconverter/KeyContainer.java + make/src/classes/build/tools/cldrconverter/LDMLParseHandler.java + make/src/classes/build/tools/cldrconverter/MetaZonesParseHandler.java + make/src/classes/build/tools/cldrconverter/NumberingSystemsParseHandler.java + make/src/classes/build/tools/cldrconverter/ResourceBundleGenerator.java + make/src/classes/build/tools/cldrconverter/StringArrayElement.java + make/src/classes/build/tools/cldrconverter/StringArrayEntry.java + make/src/classes/build/tools/cldrconverter/StringEntry.java + make/src/classes/build/tools/cldrconverter/SupplementDataParseHandler.java + make/src/classes/build/tools/compilefontconfig/CompileFontConfig.java + make/src/classes/build/tools/compileproperties/CompileProperties.java + make/src/classes/build/tools/deps/CheckDeps.java + make/src/classes/build/tools/dtdbuilder/DTDBuilder.java + make/src/classes/build/tools/dtdbuilder/DTDInputStream.java + make/src/classes/build/tools/dtdbuilder/DTDParser.java + make/src/classes/build/tools/dtdbuilder/PublicMapping.java + make/src/classes/build/tools/dtdbuilder/README.txt + make/src/classes/build/tools/generatebreakiteratordata/BreakIteratorRBControl.java + make/src/classes/build/tools/generatebreakiteratordata/CharSet.java + make/src/classes/build/tools/generatebreakiteratordata/CharacterCategory.java + make/src/classes/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java + make/src/classes/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java + make/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java + make/src/classes/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java + make/src/classes/build/tools/generatecharacter/CharacterName.java + make/src/classes/build/tools/generatecharacter/CharacterScript.java + make/src/classes/build/tools/generatecharacter/GenerateCharacter.java + make/src/classes/build/tools/generatecharacter/PrintCharacterRanges.java + make/src/classes/build/tools/generatecharacter/PropList.java + make/src/classes/build/tools/generatecharacter/SpecialCaseMap.java + make/src/classes/build/tools/generatecharacter/UnicodeSpec.java + make/src/classes/build/tools/generatecharacter/Utility.java + make/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java + make/src/classes/build/tools/generatenimbus/AbstractGradient.java + make/src/classes/build/tools/generatenimbus/Border.java + make/src/classes/build/tools/generatenimbus/Canvas.java + make/src/classes/build/tools/generatenimbus/ComponentColor.java + make/src/classes/build/tools/generatenimbus/Dimension.java + make/src/classes/build/tools/generatenimbus/Ellipse.java + make/src/classes/build/tools/generatenimbus/Generator.java + make/src/classes/build/tools/generatenimbus/Gradient.java + make/src/classes/build/tools/generatenimbus/GradientStop.java + make/src/classes/build/tools/generatenimbus/Insets.java + make/src/classes/build/tools/generatenimbus/Layer.java + make/src/classes/build/tools/generatenimbus/Matte.java + make/src/classes/build/tools/generatenimbus/ObjectFactory.java + make/src/classes/build/tools/generatenimbus/Paint.java + make/src/classes/build/tools/generatenimbus/PainterGenerator.java + make/src/classes/build/tools/generatenimbus/Path.java + make/src/classes/build/tools/generatenimbus/Point.java + make/src/classes/build/tools/generatenimbus/RadialGradient.java + make/src/classes/build/tools/generatenimbus/Rectangle.java + make/src/classes/build/tools/generatenimbus/Shape.java + make/src/classes/build/tools/generatenimbus/SynthModel.java + make/src/classes/build/tools/generatenimbus/Typeface.java + make/src/classes/build/tools/generatenimbus/UIColor.java + make/src/classes/build/tools/generatenimbus/UIComponent.java + make/src/classes/build/tools/generatenimbus/UIDefault.java + make/src/classes/build/tools/generatenimbus/UIFont.java + make/src/classes/build/tools/generatenimbus/UIIconRegion.java + make/src/classes/build/tools/generatenimbus/UIProperty.java + make/src/classes/build/tools/generatenimbus/UIRegion.java + make/src/classes/build/tools/generatenimbus/UIState.java + make/src/classes/build/tools/generatenimbus/UIStateType.java + make/src/classes/build/tools/generatenimbus/UIStyle.java + make/src/classes/build/tools/generatenimbus/Utils.java + make/src/classes/build/tools/hasher/Hasher.java + make/src/classes/build/tools/icondata/awt/ToBin.java + make/src/classes/build/tools/icondata/osxapp/ToBin.java + make/src/classes/build/tools/jarreorder/JarReorder.java + make/src/classes/build/tools/jdwpgen/AbstractCommandNode.java + make/src/classes/build/tools/jdwpgen/AbstractGroupNode.java + make/src/classes/build/tools/jdwpgen/AbstractNamedNode.java + make/src/classes/build/tools/jdwpgen/AbstractSimpleNode.java + make/src/classes/build/tools/jdwpgen/AbstractSimpleTypeNode.java + make/src/classes/build/tools/jdwpgen/AbstractTypeListNode.java + make/src/classes/build/tools/jdwpgen/AbstractTypeNode.java + make/src/classes/build/tools/jdwpgen/AltNode.java + make/src/classes/build/tools/jdwpgen/ArrayObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ArrayRegionTypeNode.java + make/src/classes/build/tools/jdwpgen/ArrayTypeNode.java + make/src/classes/build/tools/jdwpgen/BooleanTypeNode.java + make/src/classes/build/tools/jdwpgen/ByteTypeNode.java + make/src/classes/build/tools/jdwpgen/ClassLoaderObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ClassObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ClassTypeNode.java + make/src/classes/build/tools/jdwpgen/CommandNode.java + make/src/classes/build/tools/jdwpgen/CommandSetNode.java + make/src/classes/build/tools/jdwpgen/CommentNode.java + make/src/classes/build/tools/jdwpgen/ConstantNode.java + make/src/classes/build/tools/jdwpgen/ConstantSetNode.java + make/src/classes/build/tools/jdwpgen/Context.java + make/src/classes/build/tools/jdwpgen/ErrorNode.java + make/src/classes/build/tools/jdwpgen/ErrorSetNode.java + make/src/classes/build/tools/jdwpgen/EventNode.java + make/src/classes/build/tools/jdwpgen/FieldTypeNode.java + make/src/classes/build/tools/jdwpgen/FrameTypeNode.java + make/src/classes/build/tools/jdwpgen/GroupNode.java + make/src/classes/build/tools/jdwpgen/IntTypeNode.java + make/src/classes/build/tools/jdwpgen/InterfaceTypeNode.java + make/src/classes/build/tools/jdwpgen/LocationTypeNode.java + make/src/classes/build/tools/jdwpgen/LongTypeNode.java + make/src/classes/build/tools/jdwpgen/Main.java + make/src/classes/build/tools/jdwpgen/MethodTypeNode.java + make/src/classes/build/tools/jdwpgen/NameNode.java + make/src/classes/build/tools/jdwpgen/NameValueNode.java + make/src/classes/build/tools/jdwpgen/Node.java + make/src/classes/build/tools/jdwpgen/ObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/OutNode.java + make/src/classes/build/tools/jdwpgen/Parse.java + make/src/classes/build/tools/jdwpgen/ReferenceIDTypeNode.java + make/src/classes/build/tools/jdwpgen/ReferenceTypeNode.java + make/src/classes/build/tools/jdwpgen/RepeatNode.java + make/src/classes/build/tools/jdwpgen/ReplyNode.java + make/src/classes/build/tools/jdwpgen/RootNode.java + make/src/classes/build/tools/jdwpgen/SelectNode.java + make/src/classes/build/tools/jdwpgen/StringObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/StringTypeNode.java + make/src/classes/build/tools/jdwpgen/TaggedObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ThreadGroupObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ThreadObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/TypeNode.java + make/src/classes/build/tools/jdwpgen/UntaggedValueTypeNode.java + make/src/classes/build/tools/jdwpgen/ValueTypeNode.java + make/src/classes/build/tools/spp/Spp.java + make/src/classes/build/tools/stripproperties/StripProperties.java + make/src/classes/build/tools/swingbeaninfo/DocBeanInfo.java + make/src/classes/build/tools/swingbeaninfo/GenDocletBeanInfo.java + make/src/classes/build/tools/swingbeaninfo/GenSwingBeanInfo.java + make/src/classes/build/tools/tzdb/ChronoField.java + make/src/classes/build/tools/tzdb/DateTimeException.java + make/src/classes/build/tools/tzdb/LocalDate.java + make/src/classes/build/tools/tzdb/LocalDateTime.java + make/src/classes/build/tools/tzdb/LocalTime.java + make/src/classes/build/tools/tzdb/TimeDefinition.java + make/src/classes/build/tools/tzdb/TzdbZoneRulesCompiler.java + make/src/classes/build/tools/tzdb/Utils.java + make/src/classes/build/tools/tzdb/ZoneOffset.java + make/src/classes/build/tools/tzdb/ZoneOffsetTransition.java + make/src/classes/build/tools/tzdb/ZoneOffsetTransitionRule.java + make/src/classes/build/tools/tzdb/ZoneRules.java + make/src/classes/build/tools/tzdb/ZoneRulesBuilder.java + make/src/native/add_gnu_debuglink/add_gnu_debuglink.c + make/src/native/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c - make/sun/Makefile - make/sun/applet/Makefile - make/sun/audio/Makefile - make/sun/awt/CondenseRules.awk - make/sun/awt/Depend.mak - make/sun/awt/Depend.sed - make/sun/awt/FILES_c_unix.gmk - make/sun/awt/FILES_c_windows.gmk - make/sun/awt/FILES_export_unix.gmk - make/sun/awt/FILES_export_windows.gmk - make/sun/awt/Makefile - make/sun/awt/README - make/sun/awt/ToBin.java - make/sun/awt/make.depend - make/sun/awt/mapfile-mawt-vers - make/sun/awt/mapfile-vers - make/sun/awt/mapfile-vers-bsd - make/sun/awt/mapfile-vers-linux - make/sun/awt/mawt.gmk - make/sun/cldr/Makefile - make/sun/cmm/Makefile - make/sun/cmm/kcms/FILES_c_unix.gmk - make/sun/cmm/kcms/FILES_c_windows.gmk - make/sun/cmm/kcms/Makefile - make/sun/cmm/kcms/mapfile-vers - make/sun/cmm/lcms/FILES_c_unix.gmk - make/sun/cmm/lcms/FILES_c_windows.gmk - make/sun/cmm/lcms/Makefile - make/sun/cmm/lcms/mapfile-vers - make/sun/dcpr/FILES_c.gmk - make/sun/dcpr/Makefile - make/sun/dcpr/mapfile-vers - make/sun/font/FILES_c.gmk - make/sun/font/Makefile - make/sun/font/mapfile-vers - make/sun/font/mapfile-vers.openjdk - make/sun/font/reorder-i586 - make/sun/font/reorder-sparc - make/sun/font/reorder-sparcv9 - make/sun/font/t2k/FILES_c.gmk - make/sun/font/t2k/Makefile - make/sun/font/t2k/mapfile-vers - make/sun/headless/Makefile - make/sun/headless/mapfile-vers - make/sun/headless/reorder-i586 - make/sun/headless/reorder-sparc - make/sun/headless/reorder-sparcv9 - make/sun/image/Makefile - make/sun/image/generic/FILES_c.gmk - make/sun/image/generic/Makefile - make/sun/image/generic/mapfile-vers - make/sun/image/vis/FILES_c.gmk - make/sun/image/vis/Makefile - make/sun/jar/Makefile - make/sun/javazic/Makefile - make/sun/javazic/javatz/fullset.txt - make/sun/javazic/javatz/java_11_ids.txt - make/sun/javazic/javatz/java_us_ids.txt - make/sun/javazic/javatz/java_win_ids.txt - make/sun/javazic/javatz/java_zone_ids.txt - make/sun/javazic/javatz/jdk1.1.x_zone_ids.txt - make/sun/javazic/tzdata/VERSION - make/sun/javazic/tzdata/africa - make/sun/javazic/tzdata/antarctica - make/sun/javazic/tzdata/asia - make/sun/javazic/tzdata/australasia - make/sun/javazic/tzdata/backward - make/sun/javazic/tzdata/etcetera - make/sun/javazic/tzdata/europe - make/sun/javazic/tzdata/factory - make/sun/javazic/tzdata/gmt - make/sun/javazic/tzdata/iso3166.tab - make/sun/javazic/tzdata/jdk11_backward - make/sun/javazic/tzdata/leapseconds - make/sun/javazic/tzdata/northamerica - make/sun/javazic/tzdata/pacificnew - make/sun/javazic/tzdata/solar87 - make/sun/javazic/tzdata/solar88 - make/sun/javazic/tzdata/solar89 - make/sun/javazic/tzdata/southamerica - make/sun/javazic/tzdata/systemv - make/sun/javazic/tzdata/zone.tab - make/sun/javazic/tzdata_jdk/gmt - make/sun/javazic/tzdata_jdk/jdk11_backward - make/sun/javazic/tzdata_jdk/jdk11_full_backward - make/sun/jawt/Depend.mak - make/sun/jawt/Depend.sed - make/sun/jawt/Makefile - make/sun/jawt/make.depend - make/sun/jawt/mapfile-vers - make/sun/jconsole/FILES.gmk - make/sun/jconsole/Makefile - make/sun/jdga/Makefile - make/sun/jdga/mapfile-vers - make/sun/jpeg/FILES_c.gmk - make/sun/jpeg/Makefile - make/sun/jpeg/mapfile-vers - make/sun/jpeg/mapfile-vers-closed - make/sun/jpeg/reorder-i586 - make/sun/jpeg/reorder-sparc - make/sun/jpeg/reorder-sparcv9 - make/sun/launcher/Makefile - make/sun/lwawt/FILES_c_macosx.gmk - make/sun/lwawt/FILES_export_macosx.gmk - make/sun/lwawt/Makefile - make/sun/management/Makefile - make/sun/management/jmxremote/Makefile - make/sun/management/snmp/Makefile - make/sun/misc/Makefile - make/sun/native2ascii/Makefile - make/sun/net/FILES_java.gmk - make/sun/net/Makefile - make/sun/net/others/Makefile - make/sun/net/spi/Makefile - make/sun/net/spi/nameservice/Makefile - make/sun/net/spi/nameservice/dns/Makefile - make/sun/nio/Makefile - make/sun/nio/cs/FILES_java.gmk - make/sun/nio/cs/Makefile - make/sun/osxapp/Makefile - make/sun/osxapp/ToBin.java - make/sun/pisces/Makefile - make/sun/rmi/Makefile - make/sun/rmi/cgi/Makefile - make/sun/rmi/oldtools/FILES_java.gmk - make/sun/rmi/oldtools/Makefile - make/sun/rmi/registry/Makefile - make/sun/rmi/rmi/Makefile - make/sun/rmi/rmi/mapfile-vers - make/sun/rmi/rmic/FILES.gmk - make/sun/rmi/rmic/Makefile - make/sun/rmi/rmid/Makefile - make/sun/security/Makefile - make/sun/security/action/Makefile - make/sun/security/ec/FILES_c.gmk - make/sun/security/ec/Makefile - make/sun/security/ec/mapfile-vers - make/sun/security/jgss/Makefile - make/sun/security/jgss/wrapper/FILES_c.gmk - make/sun/security/jgss/wrapper/Makefile - make/sun/security/jgss/wrapper/mapfile-vers - make/sun/security/krb5/FILES_c_windows.gmk - make/sun/security/krb5/Makefile - make/sun/security/mscapi/FILES_cpp.gmk - make/sun/security/mscapi/Makefile - make/sun/security/other/Makefile - make/sun/security/pkcs11/FILES_c.gmk - make/sun/security/pkcs11/Makefile - make/sun/security/pkcs11/mapfile-vers - make/sun/security/smartcardio/FILES_c.gmk - make/sun/security/smartcardio/Makefile - make/sun/security/smartcardio/mapfile-vers - make/sun/security/tools/Makefile - make/sun/security/util/Makefile - make/sun/serialver/Makefile - make/sun/splashscreen/FILES_c.gmk - make/sun/splashscreen/Makefile - make/sun/splashscreen/mapfile-vers - make/sun/text/FILES_java.gmk - make/sun/text/FILES_properties.gmk - make/sun/text/Makefile - make/sun/tools/Makefile - make/sun/tracing/Makefile - make/sun/tracing/dtrace/Makefile - make/sun/tracing/dtrace/mapfile-vers - make/sun/tzdb/Makefile - make/sun/usagetracker/Makefile - make/sun/util/Makefile - make/sun/xawt/FILES_c_unix.gmk - make/sun/xawt/FILES_export_unix.gmk - make/sun/xawt/Makefile - make/sun/xawt/mapfile-vers - make/templates/bsd-header - make/templates/gpl-cp-header - make/templates/gpl-header - make/tools/CharsetMapping/Big5.map - make/tools/CharsetMapping/Big5.nr - make/tools/CharsetMapping/DoubleByte-X.java.template - make/tools/CharsetMapping/EUC_CN.map - make/tools/CharsetMapping/EUC_KR.map - make/tools/CharsetMapping/GBK.map - make/tools/CharsetMapping/HKSCS2001.c2b - make/tools/CharsetMapping/HKSCS2001.map - make/tools/CharsetMapping/HKSCS2008.c2b - make/tools/CharsetMapping/HKSCS2008.map - make/tools/CharsetMapping/HKSCS_XP.c2b - make/tools/CharsetMapping/HKSCS_XP.map - make/tools/CharsetMapping/IBM037.c2b - make/tools/CharsetMapping/IBM037.map - make/tools/CharsetMapping/IBM037.nr - make/tools/CharsetMapping/IBM1006.map - make/tools/CharsetMapping/IBM1025.c2b - make/tools/CharsetMapping/IBM1025.map - make/tools/CharsetMapping/IBM1025.nr - make/tools/CharsetMapping/IBM1026.c2b - make/tools/CharsetMapping/IBM1026.map - make/tools/CharsetMapping/IBM1026.nr - make/tools/CharsetMapping/IBM1046.map - make/tools/CharsetMapping/IBM1047.map - make/tools/CharsetMapping/IBM1097.map - make/tools/CharsetMapping/IBM1098.map - make/tools/CharsetMapping/IBM1112.c2b - make/tools/CharsetMapping/IBM1112.map - make/tools/CharsetMapping/IBM1112.nr - make/tools/CharsetMapping/IBM1122.c2b - make/tools/CharsetMapping/IBM1122.map - make/tools/CharsetMapping/IBM1122.nr - make/tools/CharsetMapping/IBM1123.c2b - make/tools/CharsetMapping/IBM1123.map - make/tools/CharsetMapping/IBM1123.nr - make/tools/CharsetMapping/IBM1124.map - make/tools/CharsetMapping/IBM1140.c2b - make/tools/CharsetMapping/IBM1140.map - make/tools/CharsetMapping/IBM1141.c2b - make/tools/CharsetMapping/IBM1141.map - make/tools/CharsetMapping/IBM1142.c2b - make/tools/CharsetMapping/IBM1142.map - make/tools/CharsetMapping/IBM1143.c2b - make/tools/CharsetMapping/IBM1143.map - make/tools/CharsetMapping/IBM1144.c2b - make/tools/CharsetMapping/IBM1144.map - make/tools/CharsetMapping/IBM1145.c2b - make/tools/CharsetMapping/IBM1145.map - make/tools/CharsetMapping/IBM1146.c2b - make/tools/CharsetMapping/IBM1146.map - make/tools/CharsetMapping/IBM1147.c2b - make/tools/CharsetMapping/IBM1147.map - make/tools/CharsetMapping/IBM1148.c2b - make/tools/CharsetMapping/IBM1148.map - make/tools/CharsetMapping/IBM1149.c2b - make/tools/CharsetMapping/IBM1149.map - make/tools/CharsetMapping/IBM1364.c2b - make/tools/CharsetMapping/IBM1364.map - make/tools/CharsetMapping/IBM1381.c2b - make/tools/CharsetMapping/IBM1381.map - make/tools/CharsetMapping/IBM1383.c2b - make/tools/CharsetMapping/IBM1383.map - make/tools/CharsetMapping/IBM1383.nr - make/tools/CharsetMapping/IBM273.c2b - make/tools/CharsetMapping/IBM273.map - make/tools/CharsetMapping/IBM273.nr - make/tools/CharsetMapping/IBM277.c2b - make/tools/CharsetMapping/IBM277.map - make/tools/CharsetMapping/IBM277.nr - make/tools/CharsetMapping/IBM278.c2b - make/tools/CharsetMapping/IBM278.map - make/tools/CharsetMapping/IBM278.nr - make/tools/CharsetMapping/IBM280.c2b - make/tools/CharsetMapping/IBM280.map - make/tools/CharsetMapping/IBM280.nr - make/tools/CharsetMapping/IBM284.c2b - make/tools/CharsetMapping/IBM284.map - make/tools/CharsetMapping/IBM284.nr - make/tools/CharsetMapping/IBM285.c2b - make/tools/CharsetMapping/IBM285.map - make/tools/CharsetMapping/IBM285.nr - make/tools/CharsetMapping/IBM290.c2b - make/tools/CharsetMapping/IBM290.map - make/tools/CharsetMapping/IBM297.c2b - make/tools/CharsetMapping/IBM297.map - make/tools/CharsetMapping/IBM297.nr - make/tools/CharsetMapping/IBM300.c2b - make/tools/CharsetMapping/IBM300.map - make/tools/CharsetMapping/IBM420.c2b - make/tools/CharsetMapping/IBM420.map - make/tools/CharsetMapping/IBM420.nr - make/tools/CharsetMapping/IBM424.c2b - make/tools/CharsetMapping/IBM424.map - make/tools/CharsetMapping/IBM424.nr - make/tools/CharsetMapping/IBM437.map - make/tools/CharsetMapping/IBM500.c2b - make/tools/CharsetMapping/IBM500.map - make/tools/CharsetMapping/IBM500.nr - make/tools/CharsetMapping/IBM737.map - make/tools/CharsetMapping/IBM775.map - make/tools/CharsetMapping/IBM833.c2b - make/tools/CharsetMapping/IBM833.map - make/tools/CharsetMapping/IBM838.c2b - make/tools/CharsetMapping/IBM838.map - make/tools/CharsetMapping/IBM838.nr - make/tools/CharsetMapping/IBM850.map - make/tools/CharsetMapping/IBM852.map - make/tools/CharsetMapping/IBM855.map - make/tools/CharsetMapping/IBM856.map - make/tools/CharsetMapping/IBM857.map - make/tools/CharsetMapping/IBM858.map - make/tools/CharsetMapping/IBM860.map - make/tools/CharsetMapping/IBM861.map - make/tools/CharsetMapping/IBM862.map - make/tools/CharsetMapping/IBM863.map - make/tools/CharsetMapping/IBM864.map - make/tools/CharsetMapping/IBM865.map - make/tools/CharsetMapping/IBM866.map - make/tools/CharsetMapping/IBM868.map - make/tools/CharsetMapping/IBM869.map - make/tools/CharsetMapping/IBM870.c2b - make/tools/CharsetMapping/IBM870.map - make/tools/CharsetMapping/IBM870.nr - make/tools/CharsetMapping/IBM871.c2b - make/tools/CharsetMapping/IBM871.map - make/tools/CharsetMapping/IBM871.nr - make/tools/CharsetMapping/IBM874.map - make/tools/CharsetMapping/IBM874.nr - make/tools/CharsetMapping/IBM875.c2b - make/tools/CharsetMapping/IBM875.map - make/tools/CharsetMapping/IBM875.nr - make/tools/CharsetMapping/IBM918.c2b - make/tools/CharsetMapping/IBM918.map - make/tools/CharsetMapping/IBM918.nr - make/tools/CharsetMapping/IBM921.map - make/tools/CharsetMapping/IBM922.map - make/tools/CharsetMapping/IBM930.c2b - make/tools/CharsetMapping/IBM930.map - make/tools/CharsetMapping/IBM930.nr - make/tools/CharsetMapping/IBM933.c2b - make/tools/CharsetMapping/IBM933.map - make/tools/CharsetMapping/IBM935.c2b - make/tools/CharsetMapping/IBM935.map - make/tools/CharsetMapping/IBM935.nr - make/tools/CharsetMapping/IBM937.c2b - make/tools/CharsetMapping/IBM937.map - make/tools/CharsetMapping/IBM937.nr - make/tools/CharsetMapping/IBM939.c2b - make/tools/CharsetMapping/IBM939.map - make/tools/CharsetMapping/IBM939.nr - make/tools/CharsetMapping/IBM942.c2b - make/tools/CharsetMapping/IBM942.map - make/tools/CharsetMapping/IBM943.map - make/tools/CharsetMapping/IBM943.nr - make/tools/CharsetMapping/IBM948.c2b - make/tools/CharsetMapping/IBM948.map - make/tools/CharsetMapping/IBM949.map - make/tools/CharsetMapping/IBM950.c2b - make/tools/CharsetMapping/IBM950.map - make/tools/CharsetMapping/IBM970.c2b - make/tools/CharsetMapping/IBM970.map - make/tools/CharsetMapping/ISO_8859_11.map - make/tools/CharsetMapping/ISO_8859_13.map - make/tools/CharsetMapping/ISO_8859_15.map - make/tools/CharsetMapping/ISO_8859_2.map - make/tools/CharsetMapping/ISO_8859_3.map - make/tools/CharsetMapping/ISO_8859_4.map - make/tools/CharsetMapping/ISO_8859_5.map - make/tools/CharsetMapping/ISO_8859_6.map - make/tools/CharsetMapping/ISO_8859_7.map - make/tools/CharsetMapping/ISO_8859_8.map - make/tools/CharsetMapping/ISO_8859_9.map - make/tools/CharsetMapping/JIS_X_0201.c2b - make/tools/CharsetMapping/JIS_X_0201.map - make/tools/CharsetMapping/JIS_X_0208.map - make/tools/CharsetMapping/JIS_X_0208_MS5022X.c2b - make/tools/CharsetMapping/JIS_X_0208_MS5022X.map - make/tools/CharsetMapping/JIS_X_0208_MS932.map - make/tools/CharsetMapping/JIS_X_0208_MS932.nr - make/tools/CharsetMapping/JIS_X_0208_Solaris.map - make/tools/CharsetMapping/JIS_X_0208_Solaris.nr - make/tools/CharsetMapping/JIS_X_0212.map - make/tools/CharsetMapping/JIS_X_0212_MS5022X.map - make/tools/CharsetMapping/JIS_X_0212_Solaris.map - make/tools/CharsetMapping/JIS_X_0212_Solaris.nr - make/tools/CharsetMapping/Johab.map - make/tools/CharsetMapping/KOI8_R.map - make/tools/CharsetMapping/KOI8_U.map - make/tools/CharsetMapping/MS1250.map - make/tools/CharsetMapping/MS1251.map - make/tools/CharsetMapping/MS1252.map - make/tools/CharsetMapping/MS1253.map - make/tools/CharsetMapping/MS1254.map - make/tools/CharsetMapping/MS1255.map - make/tools/CharsetMapping/MS1256.map - make/tools/CharsetMapping/MS1257.map - make/tools/CharsetMapping/MS1258.map - make/tools/CharsetMapping/MS874.map - make/tools/CharsetMapping/MS932.c2b - make/tools/CharsetMapping/MS932.map - make/tools/CharsetMapping/MS932.nr - make/tools/CharsetMapping/MS936.map - make/tools/CharsetMapping/MS949.map - make/tools/CharsetMapping/MS950.map - make/tools/CharsetMapping/MS950.nr - make/tools/CharsetMapping/MacArabic.map - make/tools/CharsetMapping/MacCentralEurope.map - make/tools/CharsetMapping/MacCroatian.map - make/tools/CharsetMapping/MacCyrillic.map - make/tools/CharsetMapping/MacDingbat.map - make/tools/CharsetMapping/MacGreek.map - make/tools/CharsetMapping/MacHebrew.map - make/tools/CharsetMapping/MacIceland.map - make/tools/CharsetMapping/MacRoman.map - make/tools/CharsetMapping/MacRomania.map - make/tools/CharsetMapping/MacSymbol.map - make/tools/CharsetMapping/MacThai.map - make/tools/CharsetMapping/MacTurkish.map - make/tools/CharsetMapping/MacUkraine.map - make/tools/CharsetMapping/Makefile - make/tools/CharsetMapping/PCK.c2b - make/tools/CharsetMapping/PCK.map - make/tools/CharsetMapping/PCK.nr - make/tools/CharsetMapping/SJIS.c2b - make/tools/CharsetMapping/SJIS.map - make/tools/CharsetMapping/SingleByte-X.java.template - make/tools/CharsetMapping/TIS_620.map - make/tools/CharsetMapping/dbcs - make/tools/CharsetMapping/euc_tw.map - make/tools/CharsetMapping/extsbcs - make/tools/CharsetMapping/sbcs - make/tools/CharsetMapping/sjis0213.map - make/tools/GenerateCharacter/Character.c.template - make/tools/GenerateCharacter/CharacterData00.java.template - make/tools/GenerateCharacter/CharacterData01.java.template - make/tools/GenerateCharacter/CharacterData02.java.template - make/tools/GenerateCharacter/CharacterData0E.java.template - make/tools/GenerateCharacter/CharacterDataLatin1.java.template - make/tools/GenerateCharacter/CharacterDataPrivateUse.java.template - make/tools/GenerateCharacter/CharacterDataUndefined.java.template - make/tools/GenerateCharacter/Makefile - make/tools/GenerateCharacter/check_class.c.template - make/tools/Makefile - make/tools/README.txt - make/tools/UnicodeData/PropList.txt - make/tools/UnicodeData/Scripts.txt - make/tools/UnicodeData/SpecialCasing.txt - make/tools/UnicodeData/UnicodeData.txt - make/tools/UnicodeData/VERSION - make/tools/add_gnu_debuglink/Makefile - make/tools/add_gnu_debuglink/add_gnu_debuglink.c - make/tools/addjsum/Makefile - make/tools/addtorestrictedpkgs/Makefile - make/tools/buildmetaindex/Makefile - make/tools/cldrconverter/Makefile - make/tools/commentchecker/Makefile - make/tools/compile_font_config/Makefile - make/tools/compile_properties/Makefile - make/tools/dir_diff/Makefile - make/tools/dtdbuilder/Makefile - make/tools/dtdbuilder/dtds/HTMLlat1.sgml - make/tools/dtdbuilder/dtds/HTMLspecial.sgml - make/tools/dtdbuilder/dtds/HTMLsymbol.sgml - make/tools/dtdbuilder/dtds/html32.dtd - make/tools/dtdbuilder/dtds/public.map - make/tools/fix_empty_sec_hdr_flags/Makefile - make/tools/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c - make/tools/freetypecheck/Makefile - make/tools/freetypecheck/freetypecheck.c - make/tools/generate_break_iterator/Makefile - make/tools/generate_nimbus/Makefile - make/tools/generatecurrencydata/Makefile - make/tools/hasher_classes/Makefile - make/tools/jarreorder/Makefile - make/tools/jarsplit/Makefile - make/tools/jdwpgen/Makefile - make/tools/makeclasslist/Makefile - make/tools/manifest.mf - make/tools/msys_build_scripts/dospath.sh - make/tools/msys_build_scripts/dospath.vbs - make/tools/reorder/Makefile - make/tools/reorder/tests/Exit.java - make/tools/reorder/tests/Hello.java - make/tools/reorder/tests/IntToString.java - make/tools/reorder/tests/JHello.java - make/tools/reorder/tests/LoadFrame.java - make/tools/reorder/tests/LoadJFrame.java - make/tools/reorder/tests/LoadToolkit.java - make/tools/reorder/tests/Null.java - make/tools/reorder/tests/Sleep.java - make/tools/reorder/tools/Combine.java - make/tools/reorder/tools/MaxTime.java - make/tools/reorder/tools/mcount.c - make/tools/reorder/tools/remove_mcount.c - make/tools/reorder/tools/util-i586.il - make/tools/reorder/tools/util-sparc.il - make/tools/reorder/tools/util-sparcv9.il - make/tools/sharing/README.txt - make/tools/sharing/classlist.linux - make/tools/sharing/classlist.macosx - make/tools/sharing/classlist.solaris - make/tools/sharing/classlist.windows - make/tools/sharing/tests/GHello.java - make/tools/sharing/tests/Hello.java - make/tools/sharing/tests/JHello.java - make/tools/spp/Makefile - make/tools/src/build/tools/addjsum/AddJsum.java - make/tools/src/build/tools/addtorestrictedpkgs/AddToRestrictedPkgs.java - make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java - make/tools/src/build/tools/charsetmapping/DBCS.java - make/tools/src/build/tools/charsetmapping/EUC_TW.java - make/tools/src/build/tools/charsetmapping/HKSCS.java - make/tools/src/build/tools/charsetmapping/JIS0213.java - make/tools/src/build/tools/charsetmapping/Main.java - make/tools/src/build/tools/charsetmapping/SBCS.java - make/tools/src/build/tools/charsetmapping/Utils.java - make/tools/src/build/tools/classfile/RemoveMethods.java - make/tools/src/build/tools/cldrconverter/AbstractLDMLHandler.java - make/tools/src/build/tools/cldrconverter/Bundle.java - make/tools/src/build/tools/cldrconverter/BundleGenerator.java - make/tools/src/build/tools/cldrconverter/CLDRConverter.java - make/tools/src/build/tools/cldrconverter/CalendarType.java - make/tools/src/build/tools/cldrconverter/Container.java - make/tools/src/build/tools/cldrconverter/CopyrightHeaders.java - make/tools/src/build/tools/cldrconverter/Entry.java - make/tools/src/build/tools/cldrconverter/IgnoredContainer.java - make/tools/src/build/tools/cldrconverter/KeyContainer.java - make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java - make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java - make/tools/src/build/tools/cldrconverter/NumberingSystemsParseHandler.java - make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java - make/tools/src/build/tools/cldrconverter/StringArrayElement.java - make/tools/src/build/tools/cldrconverter/StringArrayEntry.java - make/tools/src/build/tools/cldrconverter/StringEntry.java - make/tools/src/build/tools/cldrconverter/SupplementDataParseHandler.java - make/tools/src/build/tools/commentchecker/CommentChecker.java - make/tools/src/build/tools/compilefontconfig/CompileFontConfig.java - make/tools/src/build/tools/compileproperties/CompileProperties.java - make/tools/src/build/tools/deps/CheckDeps.java - make/tools/src/build/tools/deps/refs.allowed - make/tools/src/build/tools/dirdiff/DirDiff.java - make/tools/src/build/tools/dtdbuilder/DTDBuilder.java - make/tools/src/build/tools/dtdbuilder/DTDInputStream.java - make/tools/src/build/tools/dtdbuilder/DTDParser.java - make/tools/src/build/tools/dtdbuilder/PublicMapping.java - make/tools/src/build/tools/dtdbuilder/README.txt - make/tools/src/build/tools/generatebreakiteratordata/BreakIteratorRBControl.java - make/tools/src/build/tools/generatebreakiteratordata/CharSet.java - make/tools/src/build/tools/generatebreakiteratordata/CharacterCategory.java - make/tools/src/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java - make/tools/src/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java - make/tools/src/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java - make/tools/src/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java - make/tools/src/build/tools/generatecharacter/CharacterName.java - make/tools/src/build/tools/generatecharacter/CharacterScript.java - make/tools/src/build/tools/generatecharacter/GenerateCharacter.java - make/tools/src/build/tools/generatecharacter/PrintCharacterRanges.java - make/tools/src/build/tools/generatecharacter/PropList.java - make/tools/src/build/tools/generatecharacter/SpecialCaseMap.java - make/tools/src/build/tools/generatecharacter/UnicodeSpec.java - make/tools/src/build/tools/generatecharacter/Utility.java - make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java - make/tools/src/build/tools/generatenimbus/AbstractGradient.java - make/tools/src/build/tools/generatenimbus/Border.java - make/tools/src/build/tools/generatenimbus/Canvas.java - make/tools/src/build/tools/generatenimbus/ComponentColor.java - make/tools/src/build/tools/generatenimbus/Dimension.java - make/tools/src/build/tools/generatenimbus/Ellipse.java - make/tools/src/build/tools/generatenimbus/Generator.java - make/tools/src/build/tools/generatenimbus/Gradient.java - make/tools/src/build/tools/generatenimbus/GradientStop.java - make/tools/src/build/tools/generatenimbus/Insets.java - make/tools/src/build/tools/generatenimbus/Layer.java - make/tools/src/build/tools/generatenimbus/Matte.java - make/tools/src/build/tools/generatenimbus/ObjectFactory.java - make/tools/src/build/tools/generatenimbus/Paint.java - make/tools/src/build/tools/generatenimbus/PainterGenerator.java - make/tools/src/build/tools/generatenimbus/Path.java - make/tools/src/build/tools/generatenimbus/Point.java - make/tools/src/build/tools/generatenimbus/RadialGradient.java - make/tools/src/build/tools/generatenimbus/Rectangle.java - make/tools/src/build/tools/generatenimbus/Shape.java - make/tools/src/build/tools/generatenimbus/SynthModel.java - make/tools/src/build/tools/generatenimbus/Typeface.java - make/tools/src/build/tools/generatenimbus/UIColor.java - make/tools/src/build/tools/generatenimbus/UIComponent.java - make/tools/src/build/tools/generatenimbus/UIDefault.java - make/tools/src/build/tools/generatenimbus/UIFont.java - make/tools/src/build/tools/generatenimbus/UIIconRegion.java - make/tools/src/build/tools/generatenimbus/UIProperty.java - make/tools/src/build/tools/generatenimbus/UIRegion.java - make/tools/src/build/tools/generatenimbus/UIState.java - make/tools/src/build/tools/generatenimbus/UIStateType.java - make/tools/src/build/tools/generatenimbus/UIStyle.java - make/tools/src/build/tools/generatenimbus/Utils.java - make/tools/src/build/tools/hasher/Hasher.java - make/tools/src/build/tools/jarreorder/JarReorder.java - make/tools/src/build/tools/jarsplit/JarSplit.java - make/tools/src/build/tools/jdwpgen/AbstractCommandNode.java - make/tools/src/build/tools/jdwpgen/AbstractGroupNode.java - make/tools/src/build/tools/jdwpgen/AbstractNamedNode.java - make/tools/src/build/tools/jdwpgen/AbstractSimpleNode.java - make/tools/src/build/tools/jdwpgen/AbstractSimpleTypeNode.java - make/tools/src/build/tools/jdwpgen/AbstractTypeListNode.java - make/tools/src/build/tools/jdwpgen/AbstractTypeNode.java - make/tools/src/build/tools/jdwpgen/AltNode.java - make/tools/src/build/tools/jdwpgen/ArrayObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ArrayRegionTypeNode.java - make/tools/src/build/tools/jdwpgen/ArrayTypeNode.java - make/tools/src/build/tools/jdwpgen/BooleanTypeNode.java - make/tools/src/build/tools/jdwpgen/ByteTypeNode.java - make/tools/src/build/tools/jdwpgen/ClassLoaderObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ClassObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ClassTypeNode.java - make/tools/src/build/tools/jdwpgen/CommandNode.java - make/tools/src/build/tools/jdwpgen/CommandSetNode.java - make/tools/src/build/tools/jdwpgen/CommentNode.java - make/tools/src/build/tools/jdwpgen/ConstantNode.java - make/tools/src/build/tools/jdwpgen/ConstantSetNode.java - make/tools/src/build/tools/jdwpgen/Context.java - make/tools/src/build/tools/jdwpgen/ErrorNode.java - make/tools/src/build/tools/jdwpgen/ErrorSetNode.java - make/tools/src/build/tools/jdwpgen/EventNode.java - make/tools/src/build/tools/jdwpgen/FieldTypeNode.java - make/tools/src/build/tools/jdwpgen/FrameTypeNode.java - make/tools/src/build/tools/jdwpgen/GroupNode.java - make/tools/src/build/tools/jdwpgen/IntTypeNode.java - make/tools/src/build/tools/jdwpgen/InterfaceTypeNode.java - make/tools/src/build/tools/jdwpgen/LocationTypeNode.java - make/tools/src/build/tools/jdwpgen/LongTypeNode.java - make/tools/src/build/tools/jdwpgen/Main.java - make/tools/src/build/tools/jdwpgen/MethodTypeNode.java - make/tools/src/build/tools/jdwpgen/NameNode.java - make/tools/src/build/tools/jdwpgen/NameValueNode.java - make/tools/src/build/tools/jdwpgen/Node.java - make/tools/src/build/tools/jdwpgen/ObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/OutNode.java - make/tools/src/build/tools/jdwpgen/Parse.java - make/tools/src/build/tools/jdwpgen/ReferenceIDTypeNode.java - make/tools/src/build/tools/jdwpgen/ReferenceTypeNode.java - make/tools/src/build/tools/jdwpgen/RepeatNode.java - make/tools/src/build/tools/jdwpgen/ReplyNode.java - make/tools/src/build/tools/jdwpgen/RootNode.java - make/tools/src/build/tools/jdwpgen/SelectNode.java - make/tools/src/build/tools/jdwpgen/StringObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/StringTypeNode.java - make/tools/src/build/tools/jdwpgen/TaggedObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ThreadGroupObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ThreadObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/TypeNode.java - make/tools/src/build/tools/jdwpgen/UntaggedValueTypeNode.java - make/tools/src/build/tools/jdwpgen/ValueTypeNode.java - make/tools/src/build/tools/makeclasslist/MakeClasslist.java - make/tools/src/build/tools/spp/Spp.java - make/tools/src/build/tools/stripproperties/StripProperties.java - make/tools/src/build/tools/tzdb/ChronoField.java - make/tools/src/build/tools/tzdb/DateTimeException.java - make/tools/src/build/tools/tzdb/LocalDate.java - make/tools/src/build/tools/tzdb/LocalDateTime.java - make/tools/src/build/tools/tzdb/LocalTime.java - make/tools/src/build/tools/tzdb/TimeDefinition.java - make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java - make/tools/src/build/tools/tzdb/Utils.java - make/tools/src/build/tools/tzdb/ZoneOffset.java - make/tools/src/build/tools/tzdb/ZoneOffsetTransition.java - make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java - make/tools/src/build/tools/tzdb/ZoneRules.java - make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java - make/tools/strip_properties/Makefile - make/tools/swing-beans/DocBeanInfo.java - make/tools/swing-beans/GenDocletBeanInfo.java - make/tools/swing-beans/GenSwingBeanInfo.java - make/tools/swing-beans/SwingBeanInfo.template - make/tools/swing-beans/beaninfo/images/AbstractButtonColor16.gif - make/tools/swing-beans/beaninfo/images/BorderColor16.gif - make/tools/swing-beans/beaninfo/images/BoxColor16.gif - make/tools/swing-beans/beaninfo/images/BoxColor32.gif - make/tools/swing-beans/beaninfo/images/BoxMono16.gif - make/tools/swing-beans/beaninfo/images/BoxMono32.gif - make/tools/swing-beans/beaninfo/images/JAppletColor16.gif - make/tools/swing-beans/beaninfo/images/JAppletColor32.gif - make/tools/swing-beans/beaninfo/images/JAppletMono16.gif - make/tools/swing-beans/beaninfo/images/JAppletMono32.gif - make/tools/swing-beans/beaninfo/images/JButtonColor16.gif - make/tools/swing-beans/beaninfo/images/JButtonColor32.gif - make/tools/swing-beans/beaninfo/images/JButtonMono16.gif - make/tools/swing-beans/beaninfo/images/JButtonMono32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxColor16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxColor32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemColor16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemColor32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemMono16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemMono32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMono16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMono32.gif - make/tools/swing-beans/beaninfo/images/JColorChooserColor16.gif - make/tools/swing-beans/beaninfo/images/JColorChooserColor32.gif - make/tools/swing-beans/beaninfo/images/JColorChooserMono16.gif - make/tools/swing-beans/beaninfo/images/JColorChooserMono32.gif - make/tools/swing-beans/beaninfo/images/JComboBoxColor16.gif - make/tools/swing-beans/beaninfo/images/JComboBoxColor32.gif - make/tools/swing-beans/beaninfo/images/JComboBoxMono16.gif - make/tools/swing-beans/beaninfo/images/JComboBoxMono32.gif - make/tools/swing-beans/beaninfo/images/JComponentColor16.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JDialogColor16.gif - make/tools/swing-beans/beaninfo/images/JDialogColor32.gif - make/tools/swing-beans/beaninfo/images/JDialogMono16.gif - make/tools/swing-beans/beaninfo/images/JDialogMono32.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JFileChooserColor16.gif - make/tools/swing-beans/beaninfo/images/JFileChooserColor32.gif - make/tools/swing-beans/beaninfo/images/JFileChooserMono16.gif - make/tools/swing-beans/beaninfo/images/JFileChooserMono32.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldColor16.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldColor32.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldMono16.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldMono32.gif - make/tools/swing-beans/beaninfo/images/JFrameColor16.gif - make/tools/swing-beans/beaninfo/images/JFrameColor32.gif - make/tools/swing-beans/beaninfo/images/JFrameMono16.gif - make/tools/swing-beans/beaninfo/images/JFrameMono32.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameColor16.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameColor32.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameMono16.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameMono32.gif - make/tools/swing-beans/beaninfo/images/JLabelColor16.gif - make/tools/swing-beans/beaninfo/images/JLabelColor32.gif - make/tools/swing-beans/beaninfo/images/JLabelMono16.gif - make/tools/swing-beans/beaninfo/images/JLabelMono32.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JListColor16.gif - make/tools/swing-beans/beaninfo/images/JListColor32.gif - make/tools/swing-beans/beaninfo/images/JListMono16.gif - make/tools/swing-beans/beaninfo/images/JListMono32.gif - make/tools/swing-beans/beaninfo/images/JMenuBarColor16.gif - make/tools/swing-beans/beaninfo/images/JMenuBarColor32.gif - make/tools/swing-beans/beaninfo/images/JMenuBarMono16.gif - make/tools/swing-beans/beaninfo/images/JMenuBarMono32.gif - make/tools/swing-beans/beaninfo/images/JMenuColor16.gif - make/tools/swing-beans/beaninfo/images/JMenuColor32.gif - make/tools/swing-beans/beaninfo/images/JMenuItemColor16.gif - make/tools/swing-beans/beaninfo/images/JMenuItemColor32.gif - make/tools/swing-beans/beaninfo/images/JMenuItemMono16.gif - make/tools/swing-beans/beaninfo/images/JMenuItemMono32.gif - make/tools/swing-beans/beaninfo/images/JMenuMono16.gif - make/tools/swing-beans/beaninfo/images/JMenuMono32.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JPanelColor16.gif - make/tools/swing-beans/beaninfo/images/JPanelColor32.gif - make/tools/swing-beans/beaninfo/images/JPanelMono16.gif - make/tools/swing-beans/beaninfo/images/JPanelMono32.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldColor16.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldColor32.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldMono16.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldMono32.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuColor16.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuColor32.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuMono16.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuMono32.gif - make/tools/swing-beans/beaninfo/images/JProgressBarColor16.gif - make/tools/swing-beans/beaninfo/images/JProgressBarColor32.gif - make/tools/swing-beans/beaninfo/images/JProgressBarMono16.gif - make/tools/swing-beans/beaninfo/images/JProgressBarMono32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonColor16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonColor32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemColor16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemColor32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemMono16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemMono32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMono16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMono32.gif - make/tools/swing-beans/beaninfo/images/JRootPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JRootPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JRootPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JRootPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JScrollBarColor16.gif - make/tools/swing-beans/beaninfo/images/JScrollBarColor32.gif - make/tools/swing-beans/beaninfo/images/JScrollBarMono16.gif - make/tools/swing-beans/beaninfo/images/JScrollBarMono32.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JSeparatorColor16.gif - make/tools/swing-beans/beaninfo/images/JSeparatorColor32.gif - make/tools/swing-beans/beaninfo/images/JSeparatorMono16.gif - make/tools/swing-beans/beaninfo/images/JSeparatorMono32.gif - make/tools/swing-beans/beaninfo/images/JSliderColor16.gif - make/tools/swing-beans/beaninfo/images/JSliderColor32.gif - make/tools/swing-beans/beaninfo/images/JSliderMono16.gif - make/tools/swing-beans/beaninfo/images/JSliderMono32.gif - make/tools/swing-beans/beaninfo/images/JSpinnerColor16.gif - make/tools/swing-beans/beaninfo/images/JSpinnerColor32.gif - make/tools/swing-beans/beaninfo/images/JSpinnerMono16.gif - make/tools/swing-beans/beaninfo/images/JSpinnerMono32.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JTableColor16.gif - make/tools/swing-beans/beaninfo/images/JTableColor32.gif - make/tools/swing-beans/beaninfo/images/JTableMono16.gif - make/tools/swing-beans/beaninfo/images/JTableMono32.gif - make/tools/swing-beans/beaninfo/images/JTextAreaColor16.gif - make/tools/swing-beans/beaninfo/images/JTextAreaColor32.gif - make/tools/swing-beans/beaninfo/images/JTextAreaMono16.gif - make/tools/swing-beans/beaninfo/images/JTextAreaMono32.gif - make/tools/swing-beans/beaninfo/images/JTextFieldColor16.gif - make/tools/swing-beans/beaninfo/images/JTextFieldColor32.gif - make/tools/swing-beans/beaninfo/images/JTextFieldMono16.gif - make/tools/swing-beans/beaninfo/images/JTextFieldMono32.gif - make/tools/swing-beans/beaninfo/images/JTextPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JTextPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JTextPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JTextPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonColor16.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonColor32.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonMono16.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonMono32.gif - make/tools/swing-beans/beaninfo/images/JToolBarColor16.gif - make/tools/swing-beans/beaninfo/images/JToolBarColor32.gif - make/tools/swing-beans/beaninfo/images/JToolBarMono16.gif - make/tools/swing-beans/beaninfo/images/JToolBarMono32.gif - make/tools/swing-beans/beaninfo/images/JTreeColor16.gif - make/tools/swing-beans/beaninfo/images/JTreeColor32.gif - make/tools/swing-beans/beaninfo/images/JTreeMono16.gif - make/tools/swing-beans/beaninfo/images/JTreeMono32.gif - make/tools/swing-beans/beaninfo/images/JViewportColor16.gif - make/tools/swing-beans/beaninfo/images/JViewportColor32.gif - make/tools/swing-beans/beaninfo/images/JViewportMono16.gif - make/tools/swing-beans/beaninfo/images/JViewportMono32.gif - make/tools/swing-beans/beaninfo/images/JWindowColor16.gif - make/tools/swing-beans/beaninfo/images/JWindowColor32.gif - make/tools/swing-beans/beaninfo/images/JWindowMono16.gif - make/tools/swing-beans/beaninfo/images/JWindowMono32.gif - make/tools/swing-beans/javax/swing/SwingBeanInfoBase.java - make/tools/swing-beans/sun/swing/BeanInfoUtils.java - make/tools/tzdb/Makefile - makefiles/BuildJdk.gmk - makefiles/Bundles.gmk - makefiles/CompileDemos.gmk - makefiles/CompileJavaClasses.gmk - makefiles/CompileLaunchers.gmk - makefiles/CompileNativeLibraries.gmk - makefiles/CopyFiles.gmk - makefiles/CopyIntoClasses.gmk - makefiles/CopySamples.gmk - makefiles/CreateJars.gmk - makefiles/CreateSecurityJars.gmk - makefiles/GenerateClasses.gmk - makefiles/GenerateData.gmk - makefiles/GenerateSources.gmk - makefiles/Images.gmk - makefiles/Import.gmk - makefiles/Makefile - makefiles/PatchList.solaris - makefiles/ProfileNames.gmk - makefiles/Profiles.gmk - makefiles/Setup.gmk - makefiles/SignJars.gmk - makefiles/Tools.gmk - makefiles/gendata/GendataBreakIterator.gmk - makefiles/gendata/GendataFontConfig.gmk - makefiles/gendata/GendataHtml32dtd.gmk - makefiles/gendata/GendataTZDB.gmk - makefiles/gendata/GendataTimeZone.gmk - makefiles/gensrc/GensrcBuffer.gmk - makefiles/gensrc/GensrcCLDR.gmk - makefiles/gensrc/GensrcCharacterData.gmk - makefiles/gensrc/GensrcCharsetCoder.gmk - makefiles/gensrc/GensrcCharsetMapping.gmk - makefiles/gensrc/GensrcExceptions.gmk - makefiles/gensrc/GensrcIcons.gmk - makefiles/gensrc/GensrcJDWP.gmk - makefiles/gensrc/GensrcJObjC.gmk - makefiles/gensrc/GensrcLocaleDataMetaInfo.gmk - makefiles/gensrc/GensrcMisc.gmk - makefiles/gensrc/GensrcProperties.gmk - makefiles/gensrc/GensrcSwing.gmk - makefiles/gensrc/GensrcX11Wrappers.gmk - makefiles/jpda/jdwp/jdwp.spec - makefiles/jprt.gmk - makefiles/jprt.properties - makefiles/lib/Awt2dLibraries.gmk - makefiles/lib/CoreLibraries.gmk - makefiles/lib/NetworkingLibraries.gmk - makefiles/lib/NioLibraries.gmk - makefiles/lib/PlatformLibraries.gmk - makefiles/lib/SecurityLibraries.gmk - makefiles/lib/ServiceabilityLibraries.gmk - makefiles/lib/SoundLibraries.gmk - makefiles/mapfiles/launchers/mapfile-sparc - makefiles/mapfiles/launchers/mapfile-sparcv9 - makefiles/mapfiles/launchers/mapfile-x86 - makefiles/mapfiles/launchers/mapfile-x86_64 - makefiles/mapfiles/libattach/mapfile-linux - makefiles/mapfiles/libattach/mapfile-solaris - makefiles/mapfiles/libattach/reorder-windows-x86 - makefiles/mapfiles/libattach/reorder-windows-x86_64 - makefiles/mapfiles/libawt/mapfile-mawt-vers - makefiles/mapfiles/libawt/mapfile-vers - makefiles/mapfiles/libawt/mapfile-vers-linux - makefiles/mapfiles/libawt_headless/mapfile-vers - makefiles/mapfiles/libawt_headless/reorder-sparc - makefiles/mapfiles/libawt_headless/reorder-sparcv9 - makefiles/mapfiles/libawt_headless/reorder-x86 - makefiles/mapfiles/libawt_xawt/mapfile-vers - makefiles/mapfiles/libdcpr/mapfile-vers - makefiles/mapfiles/libdt_socket/mapfile-vers - makefiles/mapfiles/libfontmanager/mapfile-vers - makefiles/mapfiles/libfontmanager/mapfile-vers.openjdk - makefiles/mapfiles/libhprof/mapfile-vers - makefiles/mapfiles/libinstrument/mapfile-vers - makefiles/mapfiles/libj2gss/mapfile-vers - makefiles/mapfiles/libj2pcsc/mapfile-vers - makefiles/mapfiles/libj2pkcs11/mapfile-vers - makefiles/mapfiles/libj2ucrypto/mapfile-vers - makefiles/mapfiles/libjaas/mapfile-vers - makefiles/mapfiles/libjava/mapfile-vers - makefiles/mapfiles/libjava/reorder-sparc - makefiles/mapfiles/libjava/reorder-sparcv9 - makefiles/mapfiles/libjava/reorder-x86 - makefiles/mapfiles/libjava_crw_demo/mapfile-vers - makefiles/mapfiles/libjawt/mapfile-vers - makefiles/mapfiles/libjdga/mapfile-vers - makefiles/mapfiles/libjdwp/mapfile-vers - makefiles/mapfiles/libjfr/mapfile-vers - makefiles/mapfiles/libjli/mapfile-vers - makefiles/mapfiles/libjpeg/mapfile-vers - makefiles/mapfiles/libjpeg/mapfile-vers-closed - makefiles/mapfiles/libjpeg/reorder-sparc - makefiles/mapfiles/libjpeg/reorder-sparcv9 - makefiles/mapfiles/libjpeg/reorder-x86 - makefiles/mapfiles/libjsdt/mapfile-vers - makefiles/mapfiles/libjsound/mapfile-vers - makefiles/mapfiles/libjsoundalsa/mapfile-vers - makefiles/mapfiles/libkcms/mapfile-vers - makefiles/mapfiles/liblcms/mapfile-vers - makefiles/mapfiles/libmanagement/mapfile-vers - makefiles/mapfiles/libmlib_image/mapfile-vers - makefiles/mapfiles/libnet/mapfile-vers - makefiles/mapfiles/libnio/mapfile-linux - makefiles/mapfiles/libnio/mapfile-macosx - makefiles/mapfiles/libnio/mapfile-solaris - makefiles/mapfiles/libnio/reorder-sparc - makefiles/mapfiles/libnio/reorder-sparcv9 - makefiles/mapfiles/libnio/reorder-x86 - makefiles/mapfiles/libnpt/mapfile-vers - makefiles/mapfiles/libsctp/mapfile-vers - makefiles/mapfiles/libsplashscreen/mapfile-vers - makefiles/mapfiles/libsunec/mapfile-vers - makefiles/mapfiles/libt2k/mapfile-vers - makefiles/mapfiles/libunpack/mapfile-vers - makefiles/mapfiles/libunpack/mapfile-vers-unpack200 - makefiles/mapfiles/libverify/mapfile-vers - makefiles/mapfiles/libverify/reorder-sparc - makefiles/mapfiles/libverify/reorder-sparcv9 - makefiles/mapfiles/libverify/reorder-x86 - makefiles/mapfiles/libzip/mapfile-vers - makefiles/mapfiles/libzip/reorder-sparc - makefiles/mapfiles/libzip/reorder-sparcv9 - makefiles/mapfiles/libzip/reorder-x86 - makefiles/profile-includes.txt - makefiles/profile-rtjar-includes.txt - makefiles/scripts/addNotices.sh - makefiles/scripts/genCharsetProvider.sh - makefiles/scripts/genExceptions.sh - makefiles/scripts/localelist.sh - makefiles/sun/awt/ToBin.java - makefiles/sun/osxapp/ToBin.java From magnus.ihse.bursie at oracle.com Mon Nov 18 09:54:44 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:54:44 +0000 Subject: hg: jdk8/tl/jaxws: 8027566: Remove the old build system Message-ID: <20131118175449.7656262670@hg.openjdk.java.net> Changeset: 1d1af4ce8eeb Author: ihse Date: 2013-11-04 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1d1af4ce8eeb 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildJaxws.gmk ! make/Makefile - make/jprt.properties - make/scripts/update_src.sh - makefiles/BuildJaxws.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:55:28 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:55:28 +0000 Subject: hg: jdk8/tl/nashorn: 8027566: Remove the old build system Message-ID: <20131118175530.C4FAE62672@hg.openjdk.java.net> Changeset: 779e155419b8 Author: ihse Date: 2013-11-04 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/779e155419b8 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildNashorn.gmk ! make/Makefile - makefiles/BuildNashorn.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:55:19 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:55:19 +0000 Subject: hg: jdk8/tl/langtools: 8027566: Remove the old build system Message-ID: <20131118175531.0687062673@hg.openjdk.java.net> Changeset: 8043b9cf31ab Author: ihse Date: 2013-11-04 11:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8043b9cf31ab 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildLangtools.gmk ! make/Makefile - make/jprt.properties - makefiles/BuildLangtools.gmk - makefiles/Makefile From david.holmes at oracle.com Mon Nov 18 12:43:20 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Nov 2013 06:43:20 +1000 Subject: jmx-dev [ping] Re: RFR 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support In-Reply-To: <528A1909.1050106@oracle.com> References: <52779BFE.1080704@oracle.com> <5289E754.7050503@oracle.com> <528A015C.20706@oracle.com> <17C44C25-C9D0-477A-A673-8306B608483C@oracle.com> <528A04F7.9090605@oracle.com> <528A1909.1050106@oracle.com> Message-ID: <528A7BE8.5010400@oracle.com> On 18/11/2013 11:41 PM, Jaroslav Bachorik wrote: > Ok, just to be sure - > http://cr.openjdk.java.net/~jbachorik/8027163/webrev.01 Minor nits ... Missing space after for( in test/lib/testlibrary/jdk/testlibrary/ProcessTools.java + for(Map.Entry s BTW you should be able to simply to: + for(Map.Entry<> s --- test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java Need space around && Cheers, David ------ > -JB- > > On 18.11.2013 13:51, Staffan Larsen wrote: >> Ah! Yes. >> >> /S >> >> On 18 Nov 2013, at 13:15, Jaroslav Bachorik >> wrote: >> >>> On 18.11.2013 13:06, Staffan Larsen wrote: >>>> We don?t have solaris 32bit support any more, so please remove that >>>> file. >>> >>> In that case I will remove also solaris-i586 >>> >>> -JB- >>> >>>> >>>> Otherwise: looks good! >>>> >>>> /Staffan >>>> >>>> On 18 Nov 2013, at 13:00, Jaroslav Bachorik >>>> wrote: >>>> >>>>> On 18.11.2013 12:50, Staffan Larsen wrote: >>>>>> Shouldn?t >>>>>> test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher be >>>>>> removed as part of this change? >>>>> >>>>> Probably yes - if there are no 32bit solaris build hosts then it >>>>> can be removed. >>>>> >>>>> -JB- >>>>> >>>>>> >>>>>> /Staffan >>>>>> >>>>>> On 18 Nov 2013, at 11:09, Jaroslav Bachorik >>>>>> wrote: >>>>>> >>>>>>> Could I get this reviewed, please? >>>>>>> >>>>>>> -JB- >>>>>>> >>>>>>> On 4.11.2013 14:07, Jaroslav Bachorik wrote: >>>>>>>> Please, review the following test change: >>>>>>>> >>>>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8027163 >>>>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8027163/webrev.00/ >>>>>>>> >>>>>>>> Currently, the test is designed to work only on solaris-32bit. >>>>>>>> With the >>>>>>>> support removed it is necessary to adapt the test as well. This >>>>>>>> includes >>>>>>>> generating the solaris-sparcv9 and solaris-amd64 binaries for the >>>>>>>> launcher the test is using. >>>>>>>> >>>>>>>> The test itself needs changing the way it retrieves the ARCH >>>>>>>> name for >>>>>>>> sparcv9 architecture. Also, since it is forbidden to check in >>>>>>>> any files >>>>>>>> with executable permissions the test must account for this and >>>>>>>> adjust >>>>>>>> the file permissions temporarily while executing. It needs to >>>>>>>> revert to >>>>>>>> the original permissions when it's finished to prevent reporting >>>>>>>> the >>>>>>>> launcher files as modified in HG. >>>>>>>> >>>>>>>> While testing the changes the >>>>>>>> sun/management/jmxremote/bootstrap/LocalManagementTest.java kept >>>>>>>> failing >>>>>>>> intermittently (50%) when run in agentvm mode together with >>>>>>>> CustomLauncherTest.java on sparcv9 machines. Forcing both of >>>>>>>> these tests >>>>>>>> to run in othervm mode seems to fix the problem. >>>>>>>> >>>>>>>> There is a small debugging improvement in >>>>>>>> ProcessTools.java#startProcess() method - when the phaser >>>>>>>> timesout or is >>>>>>>> interrupted all the stack traces are dumped to stderr to help >>>>>>>> diagnosing >>>>>>>> any locking situations. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> -JB- >>>>>>> >>>>>> >>>>> >>>> >>> >> > From david.holmes at oracle.com Mon Nov 18 13:03:00 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Nov 2013 07:03:00 +1000 Subject: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep In-Reply-To: <5289E4F5.1080807@oracle.com> References: <52651646.4050705@oracle.com> <5289E4F5.1080807@oracle.com> Message-ID: <528A8084.5060406@oracle.com> Hi Jaroslav, I think your phaser usage is incorrect: 88 public void run() { 89 p.arriveAndAwaitAdvance(); // phase[1] 90 synchronized(lock1) { 91 System.out.println("[LockerThread obtained Lock1]"); 92 p.arrive(); // phase[2] 93 } 94 p.arriveAndAwaitAdvance(); // phase[3] 95 } Here the current thread can release itself at line 94. You have assumed that the phase[2] arrive will be a trigger to release the main thread but it may not have reached its arriveAndAwaitAdvance phase[2] statement yet, so the current thread arrives then does arrive-and-wait but the number of arrivals is 2 so it doesn't wait. A CyclicBarrier per phase may be clearer. David On 18/11/2013 7:59 PM, Jaroslav Bachorik wrote: > Hi, > > after discussing this with Mandy I've rewritten the test to use the > j.u.concurrent for synchronization - this also makes it much easier to > follow the test logic. > > The waited time, the blocked time and the waited counts are only checked > for sanity (increasing values) since it is not possible to do the > reliable checks against hard numbers. > > I ran the test in a tight loop for 1500 times using -Xcomp and -Xint and > the test seems to pass constantly. > > New webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.03 > > Thanks, > > -JB- > > > On 21.10.2013 13:55, Jaroslav Bachorik wrote: >> Please, review this small patch for a test failing due to the updated >> implementation in JDK6. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-6309226 >> Webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.00/ >> >> The test fails due to the change in mustang where >> ThreadMXBean.getThreadInfo().getWaitedTime() and >> ThreadMXBean.getThreadInfo().getWaitedCount() include Thread.sleep() >> too. Unfortunately, Thread.sleep() is used throughout the test for >> synchronization purposes and this breaks the test. >> >> In the patch I propose to replace Thread.sleep() with busy wait and >> hinting the scheduler by Thread.yield(). While not very elegant it >> successfully works around inclusion of unknown number of Thread.sleep()s >> (they are called in loop). >> >> Thanks, >> >> -JB- > From roger.riggs at oracle.com Mon Nov 18 13:59:53 2013 From: roger.riggs at oracle.com (roger riggs) Date: Mon, 18 Nov 2013 16:59:53 -0500 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <528A83DC.5070806@oracle.com> References: <528A83DC.5070806@oracle.com> Message-ID: <528A8DD9.6030807@oracle.com> Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail with ClassNotFound. The tests did not include the jdk.testlibrary in the classpath when it spawns a new process. The failure mode is dependent on the order that tests had been run. Also note that if a test depends on classes in the jdk.testlibrary it should include @build to ensure they are built in the @library directory Webrev: http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ Thanks, Roger From chris.hegarty at oracle.com Mon Nov 18 14:25:47 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 18 Nov 2013 22:25:47 +0000 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <528A8DD9.6030807@oracle.com> References: <528A83DC.5070806@oracle.com> <528A8DD9.6030807@oracle.com> Message-ID: <209FB014-D534-4F42-ADC7-4CE535125B8B@oracle.com> > On 18 Nov 2013, at 21:59, roger riggs wrote: > > Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail with ClassNotFound. > > The tests did not include the jdk.testlibrary in the classpath when it spawns a new process. The failure mode is dependent on the order that tests had been run. > > Also note that if a test depends on classes in the jdk.testlibrary it should include @build to ensure they are built in the @library directory > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ I've come across some of these before. The changes to the tags make sense. About the change to the property, test.class.path, I thought test.classes was right. Is this different from what other tests are doing? -Chris. > > Thanks, Roger > > From mandy.chung at oracle.com Mon Nov 18 14:44:13 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 18 Nov 2013 14:44:13 -0800 Subject: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep In-Reply-To: <528A8084.5060406@oracle.com> References: <52651646.4050705@oracle.com> <5289E4F5.1080807@oracle.com> <528A8084.5060406@oracle.com> Message-ID: <528A983D.7080804@oracle.com> Hi Jaroslav, This is a good cleanup to make the test more reliable. Thanks for doing that. I agree with David that it could be possible for the current thread to arrive at the phaser two times at the same phase while the test expects both threads move to the next step when both arrive. CyclicBarrier per phase is a good suggestion. Nits: testBlocked() has some debugging code that can be removed. It'd be good to add more comments to describe the individual test case. thanks Mandy On 11/18/2013 1:03 PM, David Holmes wrote: > Hi Jaroslav, > > I think your phaser usage is incorrect: > > 88 public void run() { > 89 p.arriveAndAwaitAdvance(); // phase[1] > 90 synchronized(lock1) { > 91 System.out.println("[LockerThread obtained > Lock1]"); > 92 p.arrive(); // phase[2] > 93 } > 94 p.arriveAndAwaitAdvance(); // phase[3] > 95 } > > Here the current thread can release itself at line 94. You have > assumed that the phase[2] arrive will be a trigger to release the main > thread but it may not have reached its arriveAndAwaitAdvance phase[2] > statement yet, so the current thread arrives then does arrive-and-wait > but the number of arrivals is 2 so it doesn't wait. > > A CyclicBarrier per phase may be clearer. > > David > > On 18/11/2013 7:59 PM, Jaroslav Bachorik wrote: >> Hi, >> >> after discussing this with Mandy I've rewritten the test to use the >> j.u.concurrent for synchronization - this also makes it much easier to >> follow the test logic. >> >> The waited time, the blocked time and the waited counts are only checked >> for sanity (increasing values) since it is not possible to do the >> reliable checks against hard numbers. >> >> I ran the test in a tight loop for 1500 times using -Xcomp and -Xint and >> the test seems to pass constantly. >> >> New webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.03 >> >> Thanks, >> >> -JB- >> >> >> On 21.10.2013 13:55, Jaroslav Bachorik wrote: >>> Please, review this small patch for a test failing due to the updated >>> implementation in JDK6. >>> >>> Issue: https://bugs.openjdk.java.net/browse/JDK-6309226 >>> Webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.00/ >>> >>> The test fails due to the change in mustang where >>> ThreadMXBean.getThreadInfo().getWaitedTime() and >>> ThreadMXBean.getThreadInfo().getWaitedCount() include Thread.sleep() >>> too. Unfortunately, Thread.sleep() is used throughout the test for >>> synchronization purposes and this breaks the test. >>> >>> In the patch I propose to replace Thread.sleep() with busy wait and >>> hinting the scheduler by Thread.yield(). While not very elegant it >>> successfully works around inclusion of unknown number of >>> Thread.sleep()s >>> (they are called in loop). >>> >>> Thanks, >>> >>> -JB- >> From erik.gahlin at oracle.com Mon Nov 18 15:29:07 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 19 Nov 2013 00:29:07 +0100 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization Message-ID: <528AA2C3.7090505@oracle.com> Could I have a review of this test fix. It appears it takes more than 10 s to write to a file on slow machines. Instead of sleeping 10 s the test now polls for the file to appear. There may be other issues with the test, but it's hard to know without ruling this race out. Thanks Erik Testing: - I have run the test 20+ times locally on a highly saturated CPU without failure - JPRT. Bug: https://bugs.openjdk.java.net/browse/JDK-6402201 Webrev: http://cr.openjdk.java.net/~egahlin/6402201_1/ From roger.riggs at oracle.com Mon Nov 18 17:09:47 2013 From: roger.riggs at oracle.com (roger riggs) Date: Mon, 18 Nov 2013 20:09:47 -0500 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <209FB014-D534-4F42-ADC7-4CE535125B8B@oracle.com> References: <528A83DC.5070806@oracle.com> <528A8DD9.6030807@oracle.com> <209FB014-D534-4F42-ADC7-4CE535125B8B@oracle.com> Message-ID: <528ABA5B.9040902@oracle.com> Hi Chris, Here's an example from a failing test run: -J-Dtest.classes=/export/jdk8-tl-test/JTwork/classes/0/sun/management/jmxremote/bootstrap \\ -J-Dtest.class.path=/export/jdk8-tl-test/JTwork/classes/0/sun/management/jmxremote/bootstrap:/export/jdk8-tl-test/JTwork/classes/0/lib/testlibrary Note that test.classes does not include the @library path lib/testlibrary. So if lib/testlibrary is supposed to be available to the spawned process then using test.class.path is needed. Including @build will compile the library classes into /lib/testlibrary but that's not enough. It happens that if the classes are not already compiled in lib/testlibrary (and there is no @build) then the files will be compiled on demand by javac into the test.classes directory. And in that case they are 'accidentally' available to the spawned process but by using @library that does not seem to be the intention. The test fails if the lib/testlibrary classes have been compiled by a previous test. Yes, there are other tests using jdk.testlibrary that do not have the @build; there maybe some tests that fail to pass the full test.class.path. I'll recheck , but that's out of scope for the particular issue. Thanks, Roger On 11/18/2013 5:25 PM, Chris Hegarty wrote: >> On 18 Nov 2013, at 21:59, roger riggs wrote: >> >> Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail with ClassNotFound. >> >> The tests did not include the jdk.testlibrary in the classpath when it spawns a new process. The failure mode is dependent on the order that tests had been run. >> >> Also note that if a test depends on classes in the jdk.testlibrary it should include @build to ensure they are built in the @library directory >> >> Webrev: >> http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ > I've come across some of these before. The changes to the tags make sense. > > About the change to the property, test.class.path, I thought test.classes was right. Is this different from what other tests are doing? > > -Chris. > >> Thanks, Roger >> >> From david.holmes at oracle.com Mon Nov 18 17:47:07 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Nov 2013 11:47:07 +1000 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <528A8DD9.6030807@oracle.com> References: <528A83DC.5070806@oracle.com> <528A8DD9.6030807@oracle.com> Message-ID: <528AC31B.8050405@oracle.com> Roger, FYI Jaroslav also has changes to these tests in-flight (different issue): http://cr.openjdk.java.net/~jbachorik/8027163/webrev.01/ David On 19/11/2013 7:59 AM, roger riggs wrote: > Please review this fix to improve the reliability of the > jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may > apply to other tests that fail with ClassNotFound. > > The tests did not include the jdk.testlibrary in the classpath when it > spawns a new process. The failure mode is dependent on the order that > tests had been run. > > Also note that if a test depends on classes in the jdk.testlibrary it > should include @build to ensure they are built in the > @library directory > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ > > Thanks, Roger > > From david.holmes at oracle.com Mon Nov 18 17:57:59 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Nov 2013 11:57:59 +1000 Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: <58a6b698-bf13-424a-9b95-deb676155b39@default> References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> <58a6b698-bf13-424a-9b95-deb676155b39@default> Message-ID: <528AC5A7.8070907@oracle.com> Hi Markus, On 13/11/2013 7:46 PM, Markus Gronlund wrote: > Hi again! > > Thank you for spotting these! I?m sorry, silly mistakes. > > I have updated lines 51-53 to: > > 51 inline bool operator<=(const Tickspan& lhs, const Tickspan& rhs) { > > 52 return !operator>(lhs,rhs); > > 53 } > > And lines 97-99 as: > > 97 inline bool operator<=(const Ticks& lhs, const Ticks& rhs) { > > 98 return !operator>(lhs,rhs); > > 99 } Would have been nice to generate an updated webrev for these fixes for late reviewers :) I don't have any further comments. Reviewed. Thanks, David > > > > > Thanks Vitaly! > > Cheers > > Markus > > *From:*Vitaly Davidovich [mailto:vitalyd at gmail.com] > *Sent:* den 13 november 2013 02:19 > *To:* Markus Gronlund > *Cc:* hotspot-runtime-dev at openjdk.java.net; serviceability-dev; > hotspot-gc-dev at openjdk.java.net > *Subject:* RE: RFR(M): 8028128: Add a type safe alternative for working > with counter based data > > Similar issue with the Ticks versions. > > Sent from my phone > > On Nov 12, 2013 8:17 PM, "Vitaly Davidovich" > wrote: > > Yeah, naming things is often a pain. > > 51 inline bool operator<=(const Tickspan& lhs, const Tickspan& rhs) { > 52 return !operator<(lhs,rhs); > 53 } > 54 > 55 inline bool operator>=(const Tickspan& lhs, const Tickspan& rhs) { > 56 return !operator<(lhs,rhs); > 57 } > > These look like bugs; first one should probably be !operator>(lhs,rhs) > and !operator<(lhs,rhs), respectively. > > Sent from my phone > > On Nov 12, 2013 10:32 AM, "Markus Gronlund" > wrote: > > Hi Vitaly, > > Thanks for you input! > > ?You have some operator overloads for these that can compare them > against jlongs - doesn't that still make it easy to mix up what you're > comparing? Personally, since these are value types I'd make their API > work only against these new types and make caller create the right type > for comparison.? > > Thanks for spotting these ? the compare against jlongs in from an older > version of the webrev where this was allowed ? you are right, it should > not be allowed, I thought I had updated this, will remove them ? many > thanks for spotting? > > As for the names, > > ?Ticks and Tickspan don't seem too optimal of names. What about > TimeInstance and TimeSpan?? > > I agree with you that the names could possibly be improved, believe me I > have tried to use multiple names ? one thing I wanted was to emphasize > that these types (currently) are only based on counter?s (i.e ticks), > and do not represent any higher ?time? abstraction. That is, the > implementation is tied to data from counters (based on ticks with a > specific ticks frequency). In my current context, I use these values to > talk about ?time? (as you saw from the original post), but ?time? can > mean many things to different people, esp. many implementations and > clock sources. > > Also, there already exist a few ?Time/Timer? types (although they are > not as good as I want them to be for current purposes), for example > there is a type called Timestamp (in runtime/timers.hpp). > > I have come to the conclusion that in order to address the overall time > abstractions in Hotspot, we would need to make a larger effort ? this we > should indeed do, but it?s outside the current scope. > > Also I am pretty sure that when we do revisit the time abstractions, the > names for these types will most likely change ? that made me leave the > names to emphasize the ?ticks? sources. > > Thanks for your input. > > Best regards > > Markus > > *From:*Vitaly Davidovich [mailto:vitalyd at gmail.com > ] > *Sent:* den 12 november 2013 15:37 > *To:* Markus Gronlund > *Cc:* serviceability-dev; hotspot-runtime-dev at openjdk.java.net > ; > hotspot-gc-dev at openjdk.java.net > *Subject:* Re: RFR(M): 8028128: Add a type safe alternative for working > with counter based data > > Hi Markus, > > Ticks and Tickspan don't seem too optimal of names. What about > TimeInstance and TimeSpan? > > You have some operator overloads for these that can compare them against > jlongs - doesn't that still make it easy to mix up what you're > comparing? Personally, since these are value types I'd make their API > work only against these new types and make caller create the right type > for comparison. > > Just my $.02, feel free to ignore :). > > Thanks > > Sent from my phone > > On Nov 12, 2013 6:16 AM, "Markus Gronlund" > wrote: > > Greetings, > > Kindly asking for reviews for the following changeset: > > Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 > > *Description:* > > Currently, when working with counter based data, the primary data type > representation in the VM are raw jlong's. jlong's are employed to > represent both: > > 1. a single instance in time, for example a "now" timestamp > 2. a time duration, a timespan, for example the duration between "now" - > "then" > > Having a raw jlong type represent both of these shifts the > responsibility to the programmer to always ensure the correct validity > of the counter data, without any assistance either at compile time or at > runtime. > > The event based tracing framework relies heavily on counter based data > in order to keep track of time and timing related information and we > have seen counter data errors where the representation sent to the > tracing framework has submitted the wrong time, i.e. a timespan when a > time instant was expected and vice versa. > > We should therefore add an alternative to jlongs for representing > counter based data. We should enlist the help of the type system to > enforce the correct data types at compile time as well as introduce > strong runtime asserts in order to help with the correct usage of time > and to reduce the number of potential bugs. > > I will therefore add two new types in src/share/vm/utilities: > > 1. "Ticks" - represents a single counter based timestamp, a single > instance in time. > 2. "Tickspan" - represents a counter based duration, a timespan, > between two "Ticks" > > Please see the added files: > > -src/share/vm/utilities/ticks.hpp > > -src/share/vm/utilities/ticks.inline.hpp > > -src/share/vm/utilities/ticks.cpp > > I have also updated some of the existing event based tracing "event > sites" to employ usage of these new types as well as updated a few > places in the event based tracing framework implementation to > accommodate these types. > > *Testing completed:* > > nsk.stress.testlist (UTE/Aurora) > > GC nightlies (Aurora) > > gc/gctests/* (UTE/Aurora) > > nsk.gc.testlist (UTE/Aurora) > > SpecJBB2013 (no regression) > > SpecJBB2005 (no regression) > > Kitchensink (locally Windows) runs for +> 9 days (still running?) > > Thanks in advance > Markus > From weijun.wang at oracle.com Mon Nov 18 22:15:41 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 19 Nov 2013 06:15:41 +0000 Subject: hg: jdk8/tl/jdk: 8028479: runNameEquals still cannot precisely detect if a usable native krb5 is available Message-ID: <20131119061604.35CBD62692@hg.openjdk.java.net> Changeset: 7b71e53c6a2b Author: weijun Date: 2013-11-19 14:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b71e53c6a2b 8028479: runNameEquals still cannot precisely detect if a usable native krb5 is available Reviewed-by: xuelei ! test/sun/security/krb5/runNameEquals.sh From taras.ledkov at oracle.com Tue Nov 19 00:05:00 2013 From: taras.ledkov at oracle.com (taras ledkov) Date: Tue, 19 Nov 2013 12:05:00 +0400 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <528A8DD9.6030807@oracle.com> References: <528A83DC.5070806@oracle.com> <528A8DD9.6030807@oracle.com> Message-ID: <528B1BAC.8080907@oracle.com> Dis you see the review: http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html (e.g. please take a look at the Utils.addTestJavaOpts) What do you think about common solution for test properties inheritance (for ProcessTools utils) because it is the frequent pattern. On 19.11.2013 1:59, roger riggs wrote: > Please review this fix to improve the reliability of the > jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may > apply to other tests that fail with ClassNotFound. > > The tests did not include the jdk.testlibrary in the classpath when it > spawns a new process. The failure mode is dependent on the order that > tests had been run. > > Also note that if a test depends on classes in the jdk.testlibrary it > should include @build to ensure they are built in the > @library directory > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ > > Thanks, Roger > > -- With best regards, Taras Ledkov Mail-To: taras.ledkov at oracle.com skype: taras_ledkov Phone: 7(812)3346-157 From Alan.Bateman at oracle.com Tue Nov 19 00:45:35 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Nov 2013 08:45:35 +0000 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528AA2C3.7090505@oracle.com> References: <528AA2C3.7090505@oracle.com> Message-ID: <528B252F.2020105@oracle.com> On 18/11/2013 23:29, Erik Gahlin wrote: > Could I have a review of this test fix. > > It appears it takes more than 10 s to write to a file on slow > machines. Instead of sleeping 10 s the test now polls for the file to > appear. There may be other issues with the test, but it's hard to know > without ruling this race out. > > Thanks > Erik > > Testing: > - I have run the test 20+ times locally on a highly saturated CPU > without failure > - JPRT. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6402201 > > Webrev: > http://cr.openjdk.java.net/~egahlin/6402201_1/ This looks okay to me. The only thing that comes to mind is whether it is possible for to observe the port file before the port is written. Keeping the sleep so that it happens after you've file the file without significantly reduce that possibility. -Alan. From jaroslav.bachorik at oracle.com Tue Nov 19 01:00:52 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 19 Nov 2013 10:00:52 +0100 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528B252F.2020105@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> Message-ID: <528B28C4.3070204@oracle.com> On 19.11.2013 09:45, Alan Bateman wrote: > On 18/11/2013 23:29, Erik Gahlin wrote: >> Could I have a review of this test fix. >> >> It appears it takes more than 10 s to write to a file on slow >> machines. Instead of sleeping 10 s the test now polls for the file to >> appear. There may be other issues with the test, but it's hard to know >> without ruling this race out. >> >> Thanks >> Erik >> >> Testing: >> - I have run the test 20+ times locally on a highly saturated CPU >> without failure >> - JPRT. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6402201 >> >> Webrev: >> http://cr.openjdk.java.net/~egahlin/6402201_1/ > This looks okay to me. The only thing that comes to mind is whether it > is possible for to observe the port file before the port is written. I think it is. Writing to a file does not guarantee that it's creation and actual write are atomic :( What I used to do was to write the data to one file and the use a second signaling file to notify the other party that the data has been successfully written and can be read. -JB- > Keeping the sleep so that it happens after you've file the file without > significantly reduce that possibility. > > -Alan. From Alan.Bateman at oracle.com Tue Nov 19 01:19:41 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Nov 2013 09:19:41 +0000 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528B28C4.3070204@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528B28C4.3070204@oracle.com> Message-ID: <528B2D2D.2000309@oracle.com> On 19/11/2013 09:00, Jaroslav Bachorik wrote: > > I think it is. Writing to a file does not guarantee that it's creation > and actual write are atomic :( > > What I used to do was to write the data to one file and the use a > second signaling file to notify the other party that the data has been > successfully written and can be read. It's probably overkill here. The more usual "protocol" is to create the file with a different name and then rename it to the expected file. -Alan From dmitry.samersoff at oracle.com Tue Nov 19 01:33:30 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 19 Nov 2013 13:33:30 +0400 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528B28C4.3070204@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528B28C4.3070204@oracle.com> Message-ID: <528B306A.7080306@oracle.com> Jaroslav, Use fuser command to wait until file being closed is better way to do it if fuser -s filename; then Busy; else Ready; fi -Dmitry On 2013-11-19 13:00, Jaroslav Bachorik wrote: > On 19.11.2013 09:45, Alan Bateman wrote: >> On 18/11/2013 23:29, Erik Gahlin wrote: >>> Could I have a review of this test fix. >>> >>> It appears it takes more than 10 s to write to a file on slow >>> machines. Instead of sleeping 10 s the test now polls for the file to >>> appear. There may be other issues with the test, but it's hard to know >>> without ruling this race out. >>> >>> Thanks >>> Erik >>> >>> Testing: >>> - I have run the test 20+ times locally on a highly saturated CPU >>> without failure >>> - JPRT. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-6402201 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~egahlin/6402201_1/ >> This looks okay to me. The only thing that comes to mind is whether it >> is possible for to observe the port file before the port is written. > > I think it is. Writing to a file does not guarantee that it's creation > and actual write are atomic :( > > What I used to do was to write the data to one file and the use a second > signaling file to notify the other party that the data has been > successfully written and can be read. > > -JB- > >> Keeping the sleep so that it happens after you've file the file without >> significantly reduce that possibility. >> >> -Alan. > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From jaroslav.bachorik at oracle.com Tue Nov 19 01:38:05 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 19 Nov 2013 10:38:05 +0100 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528B306A.7080306@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528B28C4.3070204@oracle.com> <528B306A.7080306@oracle.com> Message-ID: <528B317D.2050206@oracle.com> On 19.11.2013 10:33, Dmitry Samersoff wrote: > Jaroslav, > > Use fuser command to wait until file being closed is better way to do it > > if fuser -s filename; then Busy; else Ready; fi Thanks. Will try it. Currently I am rewriting such tests to java and using stdout redirection instead. -JB- > > -Dmitry > > > On 2013-11-19 13:00, Jaroslav Bachorik wrote: >> On 19.11.2013 09:45, Alan Bateman wrote: >>> On 18/11/2013 23:29, Erik Gahlin wrote: >>>> Could I have a review of this test fix. >>>> >>>> It appears it takes more than 10 s to write to a file on slow >>>> machines. Instead of sleeping 10 s the test now polls for the file to >>>> appear. There may be other issues with the test, but it's hard to know >>>> without ruling this race out. >>>> >>>> Thanks >>>> Erik >>>> >>>> Testing: >>>> - I have run the test 20+ times locally on a highly saturated CPU >>>> without failure >>>> - JPRT. >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-6402201 >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~egahlin/6402201_1/ >>> This looks okay to me. The only thing that comes to mind is whether it >>> is possible for to observe the port file before the port is written. >> >> I think it is. Writing to a file does not guarantee that it's creation >> and actual write are atomic :( >> >> What I used to do was to write the data to one file and the use a second >> signaling file to notify the other party that the data has been >> successfully written and can be read. >> >> -JB- >> >>> Keeping the sleep so that it happens after you've file the file without >>> significantly reduce that possibility. >>> >>> -Alan. >> > > From erik.gahlin at oracle.com Tue Nov 19 02:48:43 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 19 Nov 2013 10:48:43 +0000 Subject: hg: jdk8/tl/jdk: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt Message-ID: <20131119104913.3A8DB62699@hg.openjdk.java.net> Changeset: d6195774dd1f Author: egahlin Date: 2013-11-19 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6195774dd1f 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt From Alan.Bateman at oracle.com Tue Nov 19 02:58:04 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Nov 2013 10:58:04 +0000 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528B306A.7080306@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528B28C4.3070204@oracle.com> <528B306A.7080306@oracle.com> Message-ID: <528B443C.2030403@oracle.com> On 19/11/2013 09:33, Dmitry Samersoff wrote: > Jaroslav, > > Use fuser command to wait until file being closed is better way to do it > > if fuser -s filename; then Busy; else Ready; fi > > -Dmitry > Do you know if this works on all platforms? -Alan From dmitry.samersoff at oracle.com Tue Nov 19 03:22:53 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 19 Nov 2013 15:22:53 +0400 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528B443C.2030403@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528B28C4.3070204@oracle.com> <528B306A.7080306@oracle.com> <528B443C.2030403@oracle.com> Message-ID: <528B4A0D.5060203@oracle.com> Alan, It works on linux, solaris and macos. fuser should work on Windows/CYGWIN, No ideas what happens with Windows/MKS For Windows it might be better to use handle.exe from sysinternals - it do exactly the same and very reiliable in my experience. -Dmitry On 2013-11-19 14:58, Alan Bateman wrote: > On 19/11/2013 09:33, Dmitry Samersoff wrote: >> Jaroslav, >> >> Use fuser command to wait until file being closed is better way to do it >> >> if fuser -s filename; then Busy; else Ready; fi >> >> -Dmitry >> > Do you know if this works on all platforms? > > -Alan -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From Alan.Bateman at oracle.com Tue Nov 19 04:00:12 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Nov 2013 12:00:12 +0000 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <528A8DD9.6030807@oracle.com> References: <528A83DC.5070806@oracle.com> <528A8DD9.6030807@oracle.com> Message-ID: <528B52CC.2060906@oracle.com> On 18/11/2013 21:59, roger riggs wrote: > Please review this fix to improve the reliability of the > jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may > apply to other tests that fail with ClassNotFound. > > The tests did not include the jdk.testlibrary in the classpath when it > spawns a new process. The failure mode is dependent on the order that > tests had been run. > > Also note that if a test depends on classes in the jdk.testlibrary it > should include @build to ensure they are built in the > @library directory > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ > > Thanks, Roger This looks good to me. On the test.classes vs. test.class.path point then I think the test would be clearer if TEST_CLASSES were renamed to say TEST_CLASSPATH as it is used as a class path. -Alan From chris.hegarty at oracle.com Tue Nov 19 04:01:39 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 19 Nov 2013 12:01:39 +0000 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <528ABA5B.9040902@oracle.com> References: <528A83DC.5070806@oracle.com> <528A8DD9.6030807@oracle.com> <209FB014-D534-4F42-ADC7-4CE535125B8B@oracle.com> <528ABA5B.9040902@oracle.com> Message-ID: <528B5323.3060300@oracle.com> Roger, Thanks for the reply. I agree completely with your explanation. I understand there are multiple efforts running to address this issue, so I'll leave it to yourselves to work out the details, but as far as a point fix, yours is good. -Chris. On 11/19/2013 01:09 AM, roger riggs wrote: > Hi Chris, > > Here's an example from a failing test run: > > > -J-Dtest.classes=/export/jdk8-tl-test/JTwork/classes/0/sun/management/jmxremote/bootstrap > \\ > > -J-Dtest.class.path=/export/jdk8-tl-test/JTwork/classes/0/sun/management/jmxremote/bootstrap:/export/jdk8-tl-test/JTwork/classes/0/lib/testlibrary > > > Note that test.classes does not include the @library path lib/testlibrary. > > So if lib/testlibrary is supposed to be available to the spawned process > then using test.class.path is needed. > > Including @build will compile the library classes into /lib/testlibrary > but that's not enough. > > It happens that if the classes are not already compiled in > lib/testlibrary (and there is no @build) > then the files will be compiled on demand by javac into the test.classes > directory. > And in that case they are 'accidentally' available to the spawned > process but by using @library > that does not seem to be the intention. > > The test fails if the lib/testlibrary classes have been compiled by a > previous test. > > Yes, there are other tests using jdk.testlibrary that do not have the > @build; > there maybe some tests that fail to pass the full test.class.path. > I'll recheck , but that's out of scope for the particular issue. > > Thanks, Roger > > > > > > On 11/18/2013 5:25 PM, Chris Hegarty wrote: >>> On 18 Nov 2013, at 21:59, roger riggs wrote: >>> >>> Please review this fix to improve the reliability of the >>> jmxRemote/LocalManagementTest and CustomLauncherTest. The solution >>> may apply to other tests that fail with ClassNotFound. >>> >>> The tests did not include the jdk.testlibrary in the classpath when >>> it spawns a new process. The failure mode is dependent on the order >>> that tests had been run. >>> >>> Also note that if a test depends on classes in the jdk.testlibrary it >>> should include @build to ensure they are built in the >>> @library directory >>> >>> Webrev: >>> http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ >> I've come across some of these before. The changes to the tags make >> sense. >> >> About the change to the property, test.class.path, I thought >> test.classes was right. Is this different from what other tests are >> doing? >> >> -Chris. >> >>> Thanks, Roger >>> >>> > From staffan.larsen at oracle.com Tue Nov 19 04:11:25 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 19 Nov 2013 13:11:25 +0100 Subject: RFR(XS): 6605915 jinfo -flag functionality doesn't work with core files Message-ID: <8E96E116-DB52-4E2C-9029-7F46F569464B@oracle.com> This is a small change to the usage message of jinfo to clarify that the -flag option is not available for core files. The change is targeted for jdk9 and won?t be pushed until the jdk9 repos open up. webrev: http://cr.openjdk.java.net/~sla/6605915/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6605915 Thanks, /Staffan From chris.hegarty at oracle.com Tue Nov 19 05:48:42 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 19 Nov 2013 13:48:42 +0000 Subject: hg: jdk8/tl/jdk: 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled Message-ID: <20131119134856.8CE416269D@hg.openjdk.java.net> Changeset: d5ddde25d107 Author: tyan Date: 2013-11-19 13:46 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5ddde25d107 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled Reviewed-by: chegar ! test/ProblemList.txt From alan.bateman at oracle.com Tue Nov 19 06:11:27 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 19 Nov 2013 14:11:27 +0000 Subject: hg: jdk8/tl/jdk: 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Message-ID: <20131119141142.E7A146269E@hg.openjdk.java.net> Changeset: 2e574350a2b6 Author: alanb Date: 2013-11-19 14:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e574350a2b6 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Reviewed-by: dholmes, sla, tbell ! test/Makefile From alan.bateman at oracle.com Tue Nov 19 06:14:04 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 19 Nov 2013 14:14:04 +0000 Subject: hg: jdk8/tl: 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Message-ID: <20131119141404.EAF086269F@hg.openjdk.java.net> Changeset: 9937f406e27e Author: alanb Date: 2013-11-19 14:11 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9937f406e27e 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Reviewed-by: dholmes, sla, tbell ! make/jprt.properties ! test/Makefile From jaroslav.bachorik at oracle.com Tue Nov 19 06:23:04 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 19 Nov 2013 15:23:04 +0100 Subject: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS Message-ID: <528B7448.3090005@oracle.com> Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 The fix moves the execution of the test routine to the GarbageCollectorMXBean notification handler - at that moment it's certain that GC has already happened and it is safe to assert the data provided by the MBean. Thanks, -JB- From jaroslav.bachorik at oracle.com Tue Nov 19 06:43:18 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 19 Nov 2013 15:43:18 +0100 Subject: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep In-Reply-To: <528A8084.5060406@oracle.com> References: <52651646.4050705@oracle.com> <5289E4F5.1080807@oracle.com> <528A8084.5060406@oracle.com> Message-ID: <528B7906.7010708@oracle.com> Hi David, On 18.11.2013 22:03, David Holmes wrote: > Hi Jaroslav, > > I think your phaser usage is incorrect: > > 88 public void run() { > 89 p.arriveAndAwaitAdvance(); // phase[1] > 90 synchronized(lock1) { > 91 System.out.println("[LockerThread obtained > Lock1]"); > 92 p.arrive(); // phase[2] > 93 } > 94 p.arriveAndAwaitAdvance(); // phase[3] > 95 } > > Here the current thread can release itself at line 94. You have assumed > that the phase[2] arrive will be a trigger to release the main thread > but it may not have reached its arriveAndAwaitAdvance phase[2] statement > yet, so the current thread arrives then does arrive-and-wait but the > number of arrivals is 2 so it doesn't wait. > > A CyclicBarrier per phase may be clearer. Yes, thanks for pointing this out. But, wouldn't p.arriveAndAwaitAdvance() instead of p.arrive() suffice? I've tried to replace Phaser with CyclicBarrier but while it seems to work as expected it pollutes code with the necessity to catch various exceptions (InterruptedException, BarrierException etc.). So, if the simple fix with Phaser would do the trick I would better use that. -JB- > > David > > On 18/11/2013 7:59 PM, Jaroslav Bachorik wrote: >> Hi, >> >> after discussing this with Mandy I've rewritten the test to use the >> j.u.concurrent for synchronization - this also makes it much easier to >> follow the test logic. >> >> The waited time, the blocked time and the waited counts are only checked >> for sanity (increasing values) since it is not possible to do the >> reliable checks against hard numbers. >> >> I ran the test in a tight loop for 1500 times using -Xcomp and -Xint and >> the test seems to pass constantly. >> >> New webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.03 >> >> Thanks, >> >> -JB- >> >> >> On 21.10.2013 13:55, Jaroslav Bachorik wrote: >>> Please, review this small patch for a test failing due to the updated >>> implementation in JDK6. >>> >>> Issue: https://bugs.openjdk.java.net/browse/JDK-6309226 >>> Webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.00/ >>> >>> The test fails due to the change in mustang where >>> ThreadMXBean.getThreadInfo().getWaitedTime() and >>> ThreadMXBean.getThreadInfo().getWaitedCount() include Thread.sleep() >>> too. Unfortunately, Thread.sleep() is used throughout the test for >>> synchronization purposes and this breaks the test. >>> >>> In the patch I propose to replace Thread.sleep() with busy wait and >>> hinting the scheduler by Thread.yield(). While not very elegant it >>> successfully works around inclusion of unknown number of Thread.sleep()s >>> (they are called in loop). >>> >>> Thanks, >>> >>> -JB- >> From sean.coffey at oracle.com Tue Nov 19 06:49:32 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 19 Nov 2013 14:49:32 +0000 Subject: hg: jdk8/tl/jdk: 8028583: Add helper methods to test libraries Message-ID: <20131119144948.38D95626A2@hg.openjdk.java.net> Changeset: d1bb85f0a45a Author: coffeys Date: 2013-11-19 14:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1bb85f0a45a 8028583: Add helper methods to test libraries Reviewed-by: chegar ! test/java/rmi/testlibrary/TestLibrary.java ! test/lib/testlibrary/jdk/testlibrary/FileUtils.java From jaroslav.bachorik at oracle.com Tue Nov 19 06:52:06 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 19 Nov 2013 15:52:06 +0100 Subject: RFR(XS): 6605915 jinfo -flag functionality doesn't work with core files In-Reply-To: <8E96E116-DB52-4E2C-9029-7F46F569464B@oracle.com> References: <8E96E116-DB52-4E2C-9029-7F46F569464B@oracle.com> Message-ID: <528B7B16.8050605@oracle.com> Nice and harmless. +1 -JB- On 19.11.2013 13:11, Staffan Larsen wrote: > This is a small change to the usage message of jinfo to clarify that the -flag option is not available for core files. > > The change is targeted for jdk9 and won?t be pushed until the jdk9 repos open up. > > webrev: http://cr.openjdk.java.net/~sla/6605915/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-6605915 > > Thanks, > /Staffan > From kumar.x.srinivasan at oracle.com Tue Nov 19 07:18:48 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 19 Nov 2013 15:18:48 +0000 Subject: hg: jdk8/tl/jdk: 8023978: [TEST_BUG] launcher tests must exclude platforms without server vm Message-ID: <20131119151900.74DC2626A6@hg.openjdk.java.net> Changeset: 40462a41b41b Author: ksrini Date: 2013-11-19 07:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40462a41b41b 8023978: [TEST_BUG] launcher tests must exclude platforms without server vm Reviewed-by: dholmes, mchung ! test/tools/launcher/ExecutionEnvironment.java ! test/tools/launcher/Test7029048.java ! test/tools/launcher/TestHelper.java From kevin.walls at oracle.com Tue Nov 19 07:22:35 2013 From: kevin.walls at oracle.com (kevin.walls at oracle.com) Date: Tue, 19 Nov 2013 15:22:35 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8028341: PSR:FUNC: SCOPE PARAMETER MISSING FROM THE -XX:+PRINTFLAGSFINAL Message-ID: <20131119152252.23CDC626A7@hg.openjdk.java.net> Changeset: 396564992823 Author: sgabdura Date: 2013-11-18 08:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/396564992823 8028341: PSR:FUNC: SCOPE PARAMETER MISSING FROM THE -XX:+PRINTFLAGSFINAL Reviewed-by: dcubed, sla ! src/share/vm/runtime/globals.cpp From chris.hegarty at oracle.com Tue Nov 19 07:32:22 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 19 Nov 2013 15:32:22 +0000 Subject: hg: jdk8/tl/jdk: 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves "sleep 6666" processes behind Message-ID: <20131119153235.07A90626A8@hg.openjdk.java.net> Changeset: cfbee8ee71bf Author: bvaidya Date: 2013-11-19 15:31 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfbee8ee71bf 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves "sleep 6666" processes behind Reviewed-by: chegar ! test/java/lang/ProcessBuilder/Basic.java From vincent.x.ryan at oracle.com Tue Nov 19 07:43:44 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 19 Nov 2013 15:43:44 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131119154408.4933E626A9@hg.openjdk.java.net> Changeset: e8daf5a83e42 Author: vinnie Date: 2013-11-19 15:39 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8daf5a83e42 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} Reviewed-by: alanb, weijun ! test/sun/security/provider/KeyStore/DKSTest.java ! test/sun/security/provider/KeyStore/domains.cfg Changeset: bfd4e632eeda Author: vinnie Date: 2013-11-19 15:42 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bfd4e632eeda Merge From rob.mckenna at oracle.com Tue Nov 19 08:06:07 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 19 Nov 2013 16:06:07 +0000 Subject: hg: jdk8/tl/jdk: 8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java Message-ID: <20131119160620.363B5626AB@hg.openjdk.java.net> Changeset: 63b696dafc8a Author: robm Date: 2013-11-19 15:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63b696dafc8a 8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java Reviewed-by: chegar, alanb ! test/java/lang/ProcessBuilder/Basic.java From sean.coffey at oracle.com Tue Nov 19 08:30:26 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 19 Nov 2013 16:30:26 +0000 Subject: hg: jdk8/tl/jdk: 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently Message-ID: <20131119163041.0246A626AD@hg.openjdk.java.net> Changeset: f2ccd3530476 Author: coffeys Date: 2013-11-19 16:22 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ccd3530476 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently Reviewed-by: chegar ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java From roger.riggs at oracle.com Tue Nov 19 08:55:28 2013 From: roger.riggs at oracle.com (roger riggs) Date: Tue, 19 Nov 2013 11:55:28 -0500 Subject: RFR 8028141 intermittent test failure of LocalManagementTest In-Reply-To: <528B1BAC.8080907@oracle.com> References: <528A83DC.5070806@oracle.com> <528A8DD9.6030807@oracle.com> <528B1BAC.8080907@oracle.com> Message-ID: <528B9800.9060507@oracle.com> Hi, The new utilities are useful though not directly for this fix because the code needs to append to the classpath, not just the command arguments. Minor comments on the new utilities, for future consideration. - In the getCommandLine impl; java.util.StringJoiner may be useful though not much shorter. - A bit more esoteric but using the latest lambda/streams, the method could be implemented as: public static String getCommandLine(ProcessBuilder pb) { return pb.command().stream().collect(Collectors.joining(" ")).toString(); } - getTestOpts:93, 105 could supply a String[opts.size()] so the string array does not needs to be reallocated. - The mapping between lists and arrays seems awkward here and in ProcessTools. Some cleanup might be able to treat that more consistently and be easier to read. Thanks, Roger On 11/19/2013 3:05 AM, taras ledkov wrote: > Dis you see the review: > http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html > (e.g. please take a look at the Utils.addTestJavaOpts) > > What do you think about common solution for test properties inheritance > (for ProcessTools utils) because it is the frequent pattern. > > On 19.11.2013 1:59, roger riggs wrote: >> Please review this fix to improve the reliability of the >> jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may >> apply to other tests that fail with ClassNotFound. >> >> The tests did not include the jdk.testlibrary in the classpath when it >> spawns a new process. The failure mode is dependent on the order that >> tests had been run. >> >> Also note that if a test depends on classes in the jdk.testlibrary it >> should include @build to ensure they are built in the >> @library directory >> >> Webrev: >> http://cr.openjdk.java.net/~rriggs/webrev-localmanagement-8028141/ >> >> Thanks, Roger >> >> > From alan.bateman at oracle.com Tue Nov 19 07:12:37 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 19 Nov 2013 15:12:37 +0000 Subject: hg: jdk8/tl/jdk: 8028589: Instrument tools/jar/JarEntryTime.java to make it easier to diagnose failures Message-ID: <20131119151253.8563A626A4@hg.openjdk.java.net> Changeset: 36821ee241a2 Author: alanb Date: 2013-11-19 15:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36821ee241a2 8028589: Instrument tools/jar/JarEntryTime.java to make it easier to diagnose failures Reviewed-by: chegar ! test/tools/jar/JarEntryTime.java From michael.x.mcmahon at oracle.com Tue Nov 19 09:51:03 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Tue, 19 Nov 2013 17:51:03 +0000 Subject: hg: jdk8/tl/jdk: 8028581: [TESTBUG] java/net/Socket/LingerTest.java failing Message-ID: <20131119175115.950A1626B3@hg.openjdk.java.net> Changeset: 79e975dfeb8a Author: michaelm Date: 2013-11-19 17:49 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79e975dfeb8a 8028581: [TESTBUG] java/net/Socket/LingerTest.java failing Reviewed-by: alanb ! test/java/net/Socket/LingerTest.java From alexander.zuev at oracle.com Tue Nov 19 10:06:03 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 19 Nov 2013 18:06:03 +0000 Subject: hg: jdk8/tl/jdk: 8027900: pack200 option is broken due to the incorrect makefile definition for its driver Message-ID: <20131119180616.795F1626B9@hg.openjdk.java.net> Changeset: 5aa853ca08a8 Author: kizune Date: 2013-11-19 22:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aa853ca08a8 8027900: pack200 option is broken due to the incorrect makefile definition for its driver Reviewed-by: ksrini, ihse ! make/CompileLaunchers.gmk From vincent.x.ryan at oracle.com Tue Nov 19 09:56:25 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 19 Nov 2013 17:56:25 +0000 Subject: hg: jdk8/tl/jdk: 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set Message-ID: <20131119175637.7FF9F626B4@hg.openjdk.java.net> Changeset: f8b24e1a609e Author: vinnie Date: 2013-11-19 17:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b24e1a609e 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set Reviewed-by: mullan, xuelei ! src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/OCSPRequest.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/x509/X509CertImpl.java From mandy.chung at oracle.com Tue Nov 19 10:21:34 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 19 Nov 2013 18:21:34 +0000 Subject: hg: jdk8/tl/jdk: 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt Message-ID: <20131119182147.C2F65626BC@hg.openjdk.java.net> Changeset: 48c61808374f Author: mchung Date: 2013-11-19 10:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48c61808374f 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt Reviewed-by: sla ! test/ProblemList.txt From roger.riggs at oracle.com Tue Nov 19 10:29:28 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 19 Nov 2013 18:29:28 +0000 Subject: hg: jdk8/tl/jdk: 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again Message-ID: <20131119182942.7F43E626BE@hg.openjdk.java.net> Changeset: 3f47e393e1dd Author: rriggs Date: 2013-11-19 13:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f47e393e1dd 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again Summary: Correct to use the test.class.path instead of test.classes Reviewed-by: alanb, chegar ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.java From alexander.zuev at oracle.com Tue Nov 19 10:15:02 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 19 Nov 2013 18:15:02 +0000 Subject: hg: jdk8/tl/langtools: 6726154: javadoc generated with incorrect version in comment Message-ID: <20131119181507.11E2C626BA@hg.openjdk.java.net> Changeset: f42a22e2b2cd Author: kizune Date: 2013-11-19 22:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f42a22e2b2cd 6726154: javadoc generated with incorrect version in comment Reviewed-by: jjg, bpatel, erikj, tbell ! make/BuildLangtools.gmk ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java From david.holmes at oracle.com Tue Nov 19 10:55:22 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 20 Nov 2013 04:55:22 +1000 Subject: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep In-Reply-To: <528B7906.7010708@oracle.com> References: <52651646.4050705@oracle.com> <5289E4F5.1080807@oracle.com> <528A8084.5060406@oracle.com> <528B7906.7010708@oracle.com> Message-ID: <528BB41A.4070107@oracle.com> On 20/11/2013 12:43 AM, Jaroslav Bachorik wrote: > Hi David, > > On 18.11.2013 22:03, David Holmes wrote: >> Hi Jaroslav, >> >> I think your phaser usage is incorrect: >> >> 88 public void run() { >> 89 p.arriveAndAwaitAdvance(); // phase[1] >> 90 synchronized(lock1) { >> 91 System.out.println("[LockerThread obtained >> Lock1]"); >> 92 p.arrive(); // phase[2] >> 93 } >> 94 p.arriveAndAwaitAdvance(); // phase[3] >> 95 } >> >> Here the current thread can release itself at line 94. You have assumed >> that the phase[2] arrive will be a trigger to release the main thread >> but it may not have reached its arriveAndAwaitAdvance phase[2] statement >> yet, so the current thread arrives then does arrive-and-wait but the >> number of arrivals is 2 so it doesn't wait. >> >> A CyclicBarrier per phase may be clearer. > > Yes, thanks for pointing this out. But, wouldn't > p.arriveAndAwaitAdvance() instead of p.arrive() suffice? I've tried to > replace Phaser with CyclicBarrier but while it seems to work as expected > it pollutes code with the necessity to catch various exceptions > (InterruptedException, BarrierException etc.). So, if the simple fix > with Phaser would do the trick I would better use that. In this case yes arriveAndAwaitAdvance would fix it. I don't know if other tests have the same issue - the concern would be ensuring there's no possibility of deadlocks in general. Thanks, David > -JB- > >> >> David >> >> On 18/11/2013 7:59 PM, Jaroslav Bachorik wrote: >>> Hi, >>> >>> after discussing this with Mandy I've rewritten the test to use the >>> j.u.concurrent for synchronization - this also makes it much easier to >>> follow the test logic. >>> >>> The waited time, the blocked time and the waited counts are only checked >>> for sanity (increasing values) since it is not possible to do the >>> reliable checks against hard numbers. >>> >>> I ran the test in a tight loop for 1500 times using -Xcomp and -Xint and >>> the test seems to pass constantly. >>> >>> New webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.03 >>> >>> Thanks, >>> >>> -JB- >>> >>> >>> On 21.10.2013 13:55, Jaroslav Bachorik wrote: >>>> Please, review this small patch for a test failing due to the updated >>>> implementation in JDK6. >>>> >>>> Issue: https://bugs.openjdk.java.net/browse/JDK-6309226 >>>> Webrev: http://cr.openjdk.java.net/~jbachorik/6309226/webrev.00/ >>>> >>>> The test fails due to the change in mustang where >>>> ThreadMXBean.getThreadInfo().getWaitedTime() and >>>> ThreadMXBean.getThreadInfo().getWaitedCount() include Thread.sleep() >>>> too. Unfortunately, Thread.sleep() is used throughout the test for >>>> synchronization purposes and this breaks the test. >>>> >>>> In the patch I propose to replace Thread.sleep() with busy wait and >>>> hinting the scheduler by Thread.yield(). While not very elegant it >>>> successfully works around inclusion of unknown number of >>>> Thread.sleep()s >>>> (they are called in loop). >>>> >>>> Thanks, >>>> >>>> -JB- >>> > From mandy.chung at oracle.com Tue Nov 19 11:06:43 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 19 Nov 2013 11:06:43 -0800 Subject: RFR: JDK-8028430 JDI: ReferenceType.visibleMethods() return wrong visible methods In-Reply-To: References: Message-ID: <528BB6C3.8040106@oracle.com> On 11/15/2013 6:18 AM, Staffan Larsen wrote: > All, > > ReferenceType.visibleMethods() has some problems with diamond shaped interface hierarchies. There is more information on the problem in the bug report. > > The solution here is to maintain a list of interfaces that we have visited so that we do not visit interfaces (above the top of the diamond) more than once. > > This change is targeted for jdk9 so I will hold on to it until the repos open up. > > webrev: http://cr.openjdk.java.net/~sla/8028430/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-8028430 This fix looks okay. I think these two lines in the tests meant to test different m methods: 115 verifyContains(visible, 1, "Two.m(java.lang.String)"); 116 verifyContains(visible, 1, "Two.m(java.lang.String)"); Nits: the test has some inconsistent indentations. Mandy From daniel.fuchs at oracle.com Tue Nov 19 11:11:47 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 19 Nov 2013 19:11:47 +0000 Subject: hg: jdk8/tl/jdk: 8028185: XMLFormatter.format emits incorrect year Message-ID: <20131119191201.11AAF626C0@hg.openjdk.java.net> Changeset: 67d742c75971 Author: dfuchs Date: 2013-11-19 20:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67d742c75971 8028185: XMLFormatter.format emits incorrect year Summary: Fixes a regression where the year in the date was increased by 1900. Reviewed-by: alanb, mchung ! src/share/classes/java/util/logging/XMLFormatter.java + test/java/util/logging/XMLFormatterDate.java From staffan.larsen at oracle.com Tue Nov 19 11:28:09 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 19 Nov 2013 20:28:09 +0100 Subject: RFR: JDK-8028430 JDI: ReferenceType.visibleMethods() return wrong visible methods In-Reply-To: <528BB6C3.8040106@oracle.com> References: <528BB6C3.8040106@oracle.com> Message-ID: On 19 nov 2013, at 20:06, Mandy Chung wrote: > On 11/15/2013 6:18 AM, Staffan Larsen wrote: >> All, >> >> ReferenceType.visibleMethods() has some problems with diamond shaped interface hierarchies. There is more information on the problem in the bug report. >> >> The solution here is to maintain a list of interfaces that we have visited so that we do not visit interfaces (above the top of the diamond) more than once. >> >> This change is targeted for jdk9 so I will hold on to it until the repos open up. >> >> webrev: http://cr.openjdk.java.net/~sla/8028430/webrev.00/ >> bug: https://bugs.openjdk.java.net/browse/JDK-8028430 > > This fix looks okay. > > I think these two lines in the tests meant to test different m methods: > > 115 verifyContains(visible, 1, "Two.m(java.lang.String)"); > 116 verifyContains(visible, 1, "Two.m(java.lang.String)?); Cut and paste error I think. One test of this method is enough. I?ve removed one of these lines. > Nits: the test has some inconsistent indentations. Lots of tabs had escaped into the file. Sorry about that. I?ve fixed both of the above an will push with those changes. Thanks for the review, /Staffan > > Mandy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131119/3520d464/attachment.html From daniel.fuchs at oracle.com Tue Nov 19 13:29:06 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 19 Nov 2013 21:29:06 +0000 Subject: hg: jdk8/tl/jdk: 8005202: java/util/logging/CheckLockLocationTest.java fail on solars_10 Message-ID: <20131119212918.8D7EB626C9@hg.openjdk.java.net> Changeset: 059530c5ae9a Author: dfuchs Date: 2013-11-19 22:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/059530c5ae9a 8005202: java/util/logging/CheckLockLocationTest.java fail on solars_10 Summary: this test has been seen failing on Solaris 10, presumably because it was run as root. The fix will skip the non-writable case if it can't make a non-writable dir. Reviewed-by: mchung ! test/java/util/logging/CheckLockLocationTest.java From dan.xu at oracle.com Tue Nov 19 13:23:22 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Tue, 19 Nov 2013 21:23:22 +0000 Subject: hg: jdk8/tl/jdk: 8028631: Improve the test coverage to the pathname handling on unix-like platforms Message-ID: <20131119212335.5AA70626C7@hg.openjdk.java.net> Changeset: f496565c4eec Author: dxu Date: 2013-11-19 13:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f496565c4eec 8028631: Improve the test coverage to the pathname handling on unix-like platforms Summary: Add GeneralSolaris.java testcase and fix the concurrency issue Reviewed-by: lancea, chegar, alanb ! test/java/io/pathNames/General.java + test/java/io/pathNames/GeneralSolaris.java ! test/java/io/pathNames/GeneralWin32.java From mandy.chung at oracle.com Tue Nov 19 15:12:06 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 19 Nov 2013 15:12:06 -0800 Subject: Review request for 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt Message-ID: <528BF046.6000209@oracle.com> Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028647/webrev.00/ This patch turns the trace on by default and also add the instrumentation to print the safepoint count to help troubleshooting the test failure. test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java is no longer reproducible on jdk8 b109. GetSafepointSyncTime.java should be removed from the ProblemList.txt. This still fails with 7u45 and so I want to backport this change to 7u-dev. There might be a hotspot fix in jdk8 that resolves the zero safepoint sync time issue for further investigation. thanks Mandy From stuart.marks at oracle.com Tue Nov 19 15:23:40 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 19 Nov 2013 23:23:40 +0000 Subject: hg: jdk8/tl/jdk: 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails Message-ID: <20131119232352.AC246626D8@hg.openjdk.java.net> Changeset: 19d2e9649138 Author: smarks Date: 2013-11-19 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19d2e9649138 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails Reviewed-by: lancea ! test/java/rmi/testlibrary/RMID.java From vicente.romero at oracle.com Tue Nov 19 15:36:44 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 19 Nov 2013 23:36:44 +0000 Subject: hg: jdk8/tl/langtools: 8028504: javac generates LocalVariableTable even with -g:none Message-ID: <20131119233647.AF78F626D9@hg.openjdk.java.net> Changeset: 66bcd5d4b3d1 Author: vromero Date: 2013-11-19 23:35 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/66bcd5d4b3d1 8028504: javac generates LocalVariableTable even with -g:none Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java + test/tools/javac/T8028504/DontGenerateLVTForGNoneOpTest.java From staffan.larsen at oracle.com Wed Nov 20 00:23:35 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 20 Nov 2013 09:23:35 +0100 Subject: Review request for 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt In-Reply-To: <528BF046.6000209@oracle.com> References: <528BF046.6000209@oracle.com> Message-ID: <6BF69AF8-2A9D-4A25-9240-0E174B690B8A@oracle.com> Looks good! Thanks for picking this up, /Staffan On 20 nov 2013, at 00:12, Mandy Chung wrote: > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028647/webrev.00/ > > This patch turns the trace on by default and also add the instrumentation to print the safepoint count to help troubleshooting the test failure. > > test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java is no longer reproducible on jdk8 b109. GetSafepointSyncTime.java should be removed from the ProblemList.txt. This still fails with 7u45 and so I want to backport this change to 7u-dev. There might be a hotspot fix in jdk8 that resolves the zero safepoint sync time issue for further investigation. > > thanks > Mandy > From markus.gronlund at oracle.com Wed Nov 20 01:32:56 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Wed, 20 Nov 2013 01:32:56 -0800 (PST) Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: <528A066F.3050105@oracle.com> References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <528A066F.3050105@oracle.com> Message-ID: Hi Per, Thanks for taking a look! Inline. Cheers Markus From: Per Liden Sent: den 18 november 2013 13:22 To: Markus Gronlund; hotspot-runtime-dev at openjdk.java.net; hotspot-gc-dev at openjdk.java.net; serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net Subject: Re: RFR(M): 8028128: Add a type safe alternative for working with counter based data Hi Markus, Looks like a nice cleanup. Naming it always hard, so I'll avoid that topic ;) A few other minor comments, feel free to ignore. [MG] i agree on the naming parts. I also agree that the current names are not the best possible. I have assumed they will change. 101 class TicksToTimeHelper : public AllStatic { 102 public: 103 enum Unit { 104 SECONDS = 1, 105 MILLISECONDS = 1000 106 }; 107 static double seconds(const Tickspan& span); 108 static jlong milliseconds(const Tickspan& span); 109 }; Do we really want a separate class for this instead of having Tickspan::seconds() and Tickspan::milliseconds()? If moved inside Tickspan, maybe value() should be ticks() to be consistent (and I guess Ticks::value() -> Ticks::ticks() would follow)? [MG] In this particular case I would prefer to keep the convenience functions non-member, non-friends since a convenience member function really does not add anything extra that cannot be retrieved from outside the type. I also think that keeping the convenience functions outside/decoupled from the type itself increases encapsulation and increases flexibility - esp. for this case very much so where the convenience functions for at ticks/time representation is very much open ended; I just whacked together a seconds() and milliseconds(), but what about microseconds(), nanoseconds() and other timing convenience functions that might be needed further? I think keeping it outside increases the flexibility to add convenience functions without affecting the primary type. 43 inline bool operator!=(const Tickspan& lhs, const Tickspan& rhs) { 44 return !operator==(lhs,rhs); 45 } In many of the operators you have code like the example above. Is there a reason you want to spell it out like that instead of just "return !(lhs == rhs);"? [MG] I use this way of writing to make it explicit that a particular non-member operator is implemented in terms of another non-member operator. This point of view might be considered a bit too "implementation" centric, but I have found it useful sometimes as an easy way to directly point to the implementation - granted, for a case such as !(lhs == rhs) that might already be obvious.. 145 void register_gc_phase_start(const char* name, const Ticks& time = Ticks::now()); There are quite a few places where you've added default values like the one above. But as far as I can tell most (I think I saw at least one exception in there) of these functions are either always called without the argument or always called with the argument. Seems a bit unnecessary to provide this flexibility when it's never used (as it opens up for incorrect use of the interface)? [MG] Most of the default parameters are there in order to avoid polluting all the GC collectors with the knowledge about the Ticks/Tickspan types - I can encapsulate the usages only to gcTrace and gcTimer modules. You are right about this for the register_gc_phase_* functions though - they always pass a parameter, providing a default parameter for them might be a bit gratuitous. I will update the phase functions accordingly: void register_gc_phase_start(const char* name, const Ticks& time); void register_gc_phase_end(const Ticks& time); Thanks Per! I will send out an updated webrev. cheers, /Per On 2013-11-12 12:17, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following changeset: Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Emgronlun/8028128/webrev01/"http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 Description: Currently, when working with counter based data, the primary data type representation in the VM are raw jlong's. jlong's are employed to represent both: 1. a single instance in time, for example a "now" timestamp 2. a time duration, a timespan, for example the duration between "now" - "then" Having a raw jlong type represent both of these shifts the responsibility to the programmer to always ensure the correct validity of the counter data, without any assistance either at compile time or at runtime. The event based tracing framework relies heavily on counter based data in order to keep track of time and timing related information and we have seen counter data errors where the representation sent to the tracing framework has submitted the wrong time, i.e. a timespan when a time instant was expected and vice versa. We should therefore add an alternative to jlongs for representing counter based data. We should enlist the help of the type system to enforce the correct data types at compile time as well as introduce strong runtime asserts in order to help with the correct usage of time and to reduce the number of potential bugs. I will therefore add two new types in src/share/vm/utilities: 1. "Ticks" - represents a single counter based timestamp, a single instance in time. 2. "Tickspan" - represents a counter based duration, a timespan, between two "Ticks" Please see the added files: - src/share/vm/utilities/ticks.hpp - src/share/vm/utilities/ticks.inline.hpp - src/share/vm/utilities/ticks.cpp I have also updated some of the existing event based tracing "event sites" to employ usage of these new types as well as updated a few places in the event based tracing framework implementation to accommodate these types. Testing completed: nsk.stress.testlist (UTE/Aurora) GC nightlies (Aurora) gc/gctests/* (UTE/Aurora) nsk.gc.testlist (UTE/Aurora) SpecJBB2013 (no regression) SpecJBB2005 (no regression) Kitchensink (locally Windows) runs for +> 9 days (still running.) Thanks in advance Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131120/2f8e54ad/attachment-0001.html From markus.gronlund at oracle.com Wed Nov 20 01:55:32 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Wed, 20 Nov 2013 01:55:32 -0800 (PST) Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: <528AC5A7.8070907@oracle.com> References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> <58a6b698-bf13-424a-9b95-deb676155b39@default> <528AC5A7.8070907@oracle.com> Message-ID: Hi David, I'm sorry I haven't got around to updating and re-posting a new version for the webrev :( Thanks very much for reviewing. I intend to send out an updated webrev which will contain the updates from the feedback I have gotten so far. In addition, I have a few improvements to the original suggestion that will be included in the updated webrev. I will include a detailed list of where the deltas are compared to the previous webrev as well to make life a bit easier :) Thanks again Markus -----Original Message----- From: David Holmes Sent: den 19 november 2013 02:58 To: Markus Gronlund Cc: serviceability-dev; hotspot-gc-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: Re: RFR(M): 8028128: Add a type safe alternative for working with counter based data Hi Markus, On 13/11/2013 7:46 PM, Markus Gronlund wrote: > Hi again! > > Thank you for spotting these! I'm sorry, silly mistakes. > > I have updated lines 51-53 to: > > 51 inline bool operator<=(const Tickspan& lhs, const Tickspan& rhs) > { > > 52 return !operator>(lhs,rhs); > > 53 } > > And lines 97-99 as: > > 97 inline bool operator<=(const Ticks& lhs, const Ticks& rhs) { > > 98 return !operator>(lhs,rhs); > > 99 } Would have been nice to generate an updated webrev for these fixes for late reviewers :) I don't have any further comments. Reviewed. Thanks, David > > > > > Thanks Vitaly! > > Cheers > > Markus > > *From:*Vitaly Davidovich [mailto:vitalyd at gmail.com] > *Sent:* den 13 november 2013 02:19 > *To:* Markus Gronlund > *Cc:* hotspot-runtime-dev at openjdk.java.net; serviceability-dev; > hotspot-gc-dev at openjdk.java.net > *Subject:* RE: RFR(M): 8028128: Add a type safe alternative for > working with counter based data > > Similar issue with the Ticks versions. > > Sent from my phone > > On Nov 12, 2013 8:17 PM, "Vitaly Davidovich" > wrote: > > Yeah, naming things is often a pain. > > 51 inline bool operator<=(const Tickspan& lhs, const Tickspan& rhs) { > 52 return !operator<(lhs,rhs); > 53 } > 54 > 55 inline bool operator>=(const Tickspan& lhs, const Tickspan& rhs) { > 56 return !operator<(lhs,rhs); > 57 } > > These look like bugs; first one should probably be !operator>(lhs,rhs) > and !operator<(lhs,rhs), respectively. > > Sent from my phone > > On Nov 12, 2013 10:32 AM, "Markus Gronlund" > > wrote: > > Hi Vitaly, > > Thanks for you input! > > "You have some operator overloads for these that can compare them > against jlongs - doesn't that still make it easy to mix up what you're > comparing? Personally, since these are value types I'd make their API > work only against these new types and make caller create the right > type for comparison." > > Thanks for spotting these - the compare against jlongs in from an > older version of the webrev where this was allowed - you are right, it > should not be allowed, I thought I had updated this, will remove them > - many thanks for spotting. > > As for the names, > > "Ticks and Tickspan don't seem too optimal of names. What about > TimeInstance and TimeSpan?" > > I agree with you that the names could possibly be improved, believe me > I have tried to use multiple names - one thing I wanted was to > emphasize that these types (currently) are only based on counter's > (i.e ticks), and do not represent any higher "time" abstraction. That > is, the implementation is tied to data from counters (based on ticks > with a specific ticks frequency). In my current context, I use these > values to talk about "time" (as you saw from the original post), but > "time" can mean many things to different people, esp. many > implementations and clock sources. > > Also, there already exist a few "Time/Timer" types (although they are > not as good as I want them to be for current purposes), for example > there is a type called Timestamp (in runtime/timers.hpp). > > I have come to the conclusion that in order to address the overall > time abstractions in Hotspot, we would need to make a larger effort - > this we should indeed do, but it's outside the current scope. > > Also I am pretty sure that when we do revisit the time abstractions, > the names for these types will most likely change - that made me leave > the names to emphasize the "ticks" sources. > > Thanks for your input. > > Best regards > > Markus > > *From:*Vitaly Davidovich [mailto:vitalyd at gmail.com > ] > *Sent:* den 12 november 2013 15:37 > *To:* Markus Gronlund > *Cc:* serviceability-dev; hotspot-runtime-dev at openjdk.java.net > ; > hotspot-gc-dev at openjdk.java.net > > *Subject:* Re: RFR(M): 8028128: Add a type safe alternative for > working with counter based data > > Hi Markus, > > Ticks and Tickspan don't seem too optimal of names. What about > TimeInstance and TimeSpan? > > You have some operator overloads for these that can compare them > against jlongs - doesn't that still make it easy to mix up what you're > comparing? Personally, since these are value types I'd make their API > work only against these new types and make caller create the right > type for comparison. > > Just my $.02, feel free to ignore :). > > Thanks > > Sent from my phone > > On Nov 12, 2013 6:16 AM, "Markus Gronlund" > wrote: > > Greetings, > > Kindly asking for reviews for the following changeset: > > Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 > > *Description:* > > Currently, when working with counter based data, the primary data type > representation in the VM are raw jlong's. jlong's are employed to > represent both: > > 1. a single instance in time, for example a "now" timestamp 2. a time > duration, a timespan, for example the duration between "now" - "then" > > Having a raw jlong type represent both of these shifts the > responsibility to the programmer to always ensure the correct validity > of the counter data, without any assistance either at compile time or > at runtime. > > The event based tracing framework relies heavily on counter based data > in order to keep track of time and timing related information and we > have seen counter data errors where the representation sent to the > tracing framework has submitted the wrong time, i.e. a timespan when a > time instant was expected and vice versa. > > We should therefore add an alternative to jlongs for representing > counter based data. We should enlist the help of the type system to > enforce the correct data types at compile time as well as introduce > strong runtime asserts in order to help with the correct usage of time > and to reduce the number of potential bugs. > > I will therefore add two new types in src/share/vm/utilities: > > 1. "Ticks" - represents a single counter based timestamp, a single > instance in time. > 2. "Tickspan" - represents a counter based duration, a timespan, > between two "Ticks" > > Please see the added files: > > -src/share/vm/utilities/ticks.hpp > > -src/share/vm/utilities/ticks.inline.hpp > > -src/share/vm/utilities/ticks.cpp > > I have also updated some of the existing event based tracing "event > sites" to employ usage of these new types as well as updated a few > places in the event based tracing framework implementation to > accommodate these types. > > *Testing completed:* > > nsk.stress.testlist (UTE/Aurora) > > GC nightlies (Aurora) > > gc/gctests/* (UTE/Aurora) > > nsk.gc.testlist (UTE/Aurora) > > SpecJBB2013 (no regression) > > SpecJBB2005 (no regression) > > Kitchensink (locally Windows) runs for +> 9 days (still running.) > > Thanks in advance > Markus > From erik.gahlin at oracle.com Wed Nov 20 03:25:46 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 20 Nov 2013 12:25:46 +0100 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528B252F.2020105@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> Message-ID: <528C9C3A.4020608@oracle.com> Thanks for your feedback Here is an updated webrev where the file is renamed. http://cr.openjdk.java.net/~egahlin/6402201_2/ Erik Alan Bateman skrev 2013-11-19 09:45: > On 18/11/2013 23:29, Erik Gahlin wrote: >> Could I have a review of this test fix. >> >> It appears it takes more than 10 s to write to a file on slow >> machines. Instead of sleeping 10 s the test now polls for the file to >> appear. There may be other issues with the test, but it's hard to >> know without ruling this race out. >> >> Thanks >> Erik >> >> Testing: >> - I have run the test 20+ times locally on a highly saturated CPU >> without failure >> - JPRT. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6402201 >> >> Webrev: >> http://cr.openjdk.java.net/~egahlin/6402201_1/ > This looks okay to me. The only thing that comes to mind is whether it > is possible for to observe the port file before the port is written. > Keeping the sleep so that it happens after you've file the file > without significantly reduce that possibility. > > -Alan. From Alan.Bateman at oracle.com Wed Nov 20 03:43:12 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 20 Nov 2013 11:43:12 +0000 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528C9C3A.4020608@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528C9C3A.4020608@oracle.com> Message-ID: <528CA050.8000805@oracle.com> On 20/11/2013 11:25, Erik Gahlin wrote: > Thanks for your feedback > > Here is an updated webrev where the file is renamed. > http://cr.openjdk.java.net/~egahlin/6402201_2/ That looks okay to me. One small improvement would be to use try-with-resources around the file write. Alternatively you could use Files.write and do it in one method call (which would get you using the new file system API and then you could use Files.move and specific the ATOMIC_MOVE option). It's not strictly required for this and what you have seems to fix the reported issue. -Alan From balchandra.vaidya at oracle.com Wed Nov 20 03:49:30 2013 From: balchandra.vaidya at oracle.com (Balchandra Vaidya) Date: Wed, 20 Nov 2013 11:49:30 +0000 Subject: Should ProblemList.txt be updated to reflect JDK-8024423 fix ? Message-ID: <528CA1CA.1080203@oracle.com> Hi, It looks like 8024423 is already fixed in jdk 8 b115 and following tests are passing as a result: demo/jvmti/hprof/HeapAllTest.java demo/jvmti/hprof/HeapBinaryFormatTest.java demo/jvmti/hprof/HeapDumpTest.java demo/jvmti/hprof/OptionsTest.java demo/jvmti/hprof/StackMapTableTest.java But, the above tests are still present in ProblemList.txt. Is there any issue to remove the above tests from ProblemList.txt file? If yes, please review the following webrev: http://cr.openjdk.java.net/~bvaidya/8/8028632/webrev/ Thanks Balchandra From chris.hegarty at oracle.com Wed Nov 20 03:59:06 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 20 Nov 2013 11:59:06 +0000 Subject: Review request for 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt In-Reply-To: <528BF046.6000209@oracle.com> References: <528BF046.6000209@oracle.com> Message-ID: <528CA40A.2030305@oracle.com> Mandy, The changes look ok to me, and the approach of adding additional diagnostic information makes sense. Trivially, you can remove 'trace', as I don't think it is being used any more. -Chris. On 19/11/13 23:12, Mandy Chung wrote: > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028647/webrev.00/ > > This patch turns the trace on by default and also add the > instrumentation to print the safepoint count to help troubleshooting the > test failure. > > test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java is no > longer reproducible on jdk8 b109. GetSafepointSyncTime.java should be > removed from the ProblemList.txt. This still fails with 7u45 and so I > want to backport this change to 7u-dev. There might be a hotspot fix > in jdk8 that resolves the zero safepoint sync time issue for further > investigation. > > thanks > Mandy > From taras.ledkov at oracle.com Wed Nov 20 03:54:04 2013 From: taras.ledkov at oracle.com (taras ledkov) Date: Wed, 20 Nov 2013 15:54:04 +0400 Subject: Review request for 7195249: Some jtreg tests use hard coded ports Message-ID: <528CA2DC.5000700@oracle.com> Hi Everyone, I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. There are two webrevs: Webrev for jdk part: http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ Webrev for hs part: http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ Please take a look at some notes: - After discussing with Yekaterina Kantserova & Jaroslav Bachorik some shell tests have been converted to java based tests - PasswordFilePermissionTest & SSLConfigFilePermissionTest tests looked very similar, so a common parent class was created for them: AbstractFilePermissionTest - What was called RmiRegistrySslTest.java I've renamed to RmiRegistrySslTestApp.java. The java code to replace old shell script RmiRegistrySslTest.sh is called RmiRegistrySslTest.java, hence the huge diff. - The new RmiRegistrySslTest.java has some lines similar to the AbstractFilePermissionTest.java, I nevertheless decided to not complicate the code further and leave it as is. Please let me know if this is somehow not acceptable - com/oracle/java/testlibrary/Utils.java that is added to hotspot repository is taken from this patch: http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html - These tests will need additional changes when test library process tools will support command line options inheritance (http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013235.html) -- With best regards, Taras Ledkov Mail-To: taras.ledkov at oracle.com skype: taras_ledkov Phone: 7(812)3346-157 From erik.gahlin at oracle.com Wed Nov 20 03:31:41 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Wed, 20 Nov 2013 11:31:41 +0000 Subject: hg: jdk8/tl/jdk: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails Message-ID: <20131120113219.D2F4A626F7@hg.openjdk.java.net> Changeset: 894a4bae9e33 Author: egahlin Date: 2013-11-20 12:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/894a4bae9e33 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails Reviewed-by: sla ! test/com/sun/jdi/BreakpointWithFullGC.sh From markus.gronlund at oracle.com Wed Nov 20 04:17:30 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Wed, 20 Nov 2013 04:17:30 -0800 (PST) Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> <58a6b698-bf13-424a-9b95-deb676155b39@default> <528AC5A7.8070907@oracle.com> Message-ID: <583240ce-cf21-44d8-b1e9-4b53d547d6b9@default> Hi again, I have created an updated webrev02 for the feedback I have gotten so far. In addition, I have added a few improvements to the original suggestion. Updated Webrev02: http://cr.openjdk.java.net/~mgronlun/8028128/webrev02/ Original Webrev01: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 Thanks a lot for your help/patience in reviewing this large change - very much appreciated. Cheers Markus Description of deltas/updates to Webrev02 compared to Webrev01: // updates based on feedback utilities/ticks.inline.hpp // removed functions comparing against jlong(s) - #63 inline bool operator==(const Ticks& lhs, jlong compare_value) { - #64 return lhs.value() == compare_value; - #65 } - #89 inline bool operator!=(const Ticks& lhs, jlong compare_value) { - #90 return lhs.value() != compare_value; - #91 } // updated to gt signs for operator<= functions - #52 return !operator<(lhs, rhs); + #52 return !operator >(lhs, rhs); - #98 return !operator<(lhs,rhs); + #98 return !operator>(lhs,rhs); // thanks to Vitaly Davidovich. share/vm/gc_implementation/gcTimer.hpp // removed default parameter for report_gc_phase_* functions - #114 void report_gc_phase_start(const char* name, const Ticks& time = Ticks::now()); + #114 void report_gc_phase_start(const char* name, const Ticks& time); - #115 void report_gc_phase_end(const Ticks& time = Ticks::now()); + #115 void report_gc_phase_end(const Ticks& time); - #145 void register_gc_phase_start(const char* name, const Ticks& time = Ticks::now()); + #145 void register_gc_phase_start(const char* name, const Ticks& time); - #146 void register_gc_phase_end(const Ticks& time = Ticks::now()); + #146 void register_gc_phase_end(const Ticks& time); // thanks to Per Liden. // // // // Additional changes compared to webrev01 (delta) // webrev01 still allows a user to pass in a jlong (knowingly and/or unknowingly) for event.starttime() and event.endtime(). For example: event.set_endtime(os::elapsed_counter()); // direct call using os::elapsed_counter() This can be avoided by increasing encapsulation: src/share/vm/trace/traceEvent.hpp: set_starttime(const TracingTime& time) // remove default parameter and make protected set_endtime(const TracingTime& time) // remove default parameter and make protected Now, the only visible external API for setting the start and/or endtime of an event is by passing a "Ticks" type (a compiler enforced constraint): Using the same example as above, now if attempting to pass a jlong, like a direct call using os::elapsed_counter(), this now yields (at compile time): >..\..\src\share\vm\gc_implementation\shared\gcTraceSend.cpp(63): error C2248: 'TraceEvent::set_endtime' : cannot access protected member declared in class 'TraceEvent' In order to make these functions protected, i have also had to update the class loader events in SystemDictionary and ClassLoaderDataGraph: share/vm/classfile/SystemDictionary.hpp: // remove include file: - #34 #include "trace/traceTime.hpp" + #80 forward declare class Ticks; // update the signature - #640 static void post_class_load_event(const TracingTime& start_time, instanceKlassHandle k, Handle initiating_loader); + #640 static void post_class_load_event(const Ticks& start_time, instanceKlassHandle k, Handle initiating_loader); share/vm/classfile/SystemDictionary.cpp: // added include files +#58 #include "utilities/macros.hpp" +#59 #include "utilities/ticks.hpp" // removed old include file: - #61 #include "trace/traceMacros.hpp" // updated type - #601 TracingTime class_load_start_time = Tracing::time(); + #601 Ticks class_load_start_time = Ticks::now(); // updated type - #1009 TracingTime class_load_start_time = Tracing::time(); + #1009 Ticks class_load_start_time = Ticks::now(); // updated signature - #2668 void SystemDictionary::post_class_load_event(TracingTime start_time, instanceKlassHandle k, Handle initiating_loader) + #2668 void SystemDictionary::post_class_load_event(const Ticks& start_time, instanceKlassHandle k, Handle initiating_loader) // removed setting the endtime - #2674 event.set_endtime(Tracing::time()); src/share/vm/classfile/classLoaderData.hpp: // update include - #36 #include "trace/traceTime.hpp" + #36 #include "utilities/ticks.hpp" // updated type for _class_unload_time; - #101 static TracingTime _class_unload_time; + #101 static Ticks _class_unload_time; src/share/vm/classfile/classLoaderData.cpp: + #65 #include "utilities/macros.hpp" // updated timestamp - #757 _class_unload_time = Tracing::time(); + #757 _class_unload_time = Ticks::now(); // updated type definition - #835 TracingTime ClassLoaderDataGraph::_class_unload_time; + #835 Ticks ClassLoaderDataGraph::_class_unload_time; src/share/vm/trace/traceEventClasses.xls: // update the !INCLUDE_TRACE stubs - #59 void set_starttime(jlong time) const {} - #60 void set_endtime(jlong time) const {} + #59 void set_starttime(const Ticks& time) {} + #59 void set_endtime(const Ticks& time) {} Thanks Markus > > Greetings, > > Kindly asking for reviews for the following changeset: > > Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 > > *Description:* > > Currently, when working with counter based data, the primary data type > representation in the VM are raw jlong's. jlong's are employed to > represent both: > > 1. a single instance in time, for example a "now" timestamp 2. a time > duration, a timespan, for example the duration between "now" - "then" > > Having a raw jlong type represent both of these shifts the > responsibility to the programmer to always ensure the correct validity > of the counter data, without any assistance either at compile time or > at runtime. > > The event based tracing framework relies heavily on counter based data > in order to keep track of time and timing related information and we > have seen counter data errors where the representation sent to the > tracing framework has submitted the wrong time, i.e. a timespan when a > time instant was expected and vice versa. > > We should therefore add an alternative to jlongs for representing > counter based data. We should enlist the help of the type system to > enforce the correct data types at compile time as well as introduce > strong runtime asserts in order to help with the correct usage of time > and to reduce the number of potential bugs. > > I will therefore add two new types in src/share/vm/utilities: > > 1. "Ticks" - represents a single counter based timestamp, a single > instance in time. > 2. "Tickspan" - represents a counter based duration, a timespan, > between two "Ticks" > > Please see the added files: > > -src/share/vm/utilities/ticks.hpp > > -src/share/vm/utilities/ticks.inline.hpp > > -src/share/vm/utilities/ticks.cpp > > I have also updated some of the existing event based tracing "event > sites" to employ usage of these new types as well as updated a few > places in the event based tracing framework implementation to > accommodate these types. > > *Testing completed:* > > nsk.stress.testlist (UTE/Aurora) > > GC nightlies (Aurora) > > gc/gctests/* (UTE/Aurora) > > nsk.gc.testlist (UTE/Aurora) > > SpecJBB2013 (no regression) > > SpecJBB2005 (no regression) > > Kitchensink (locally Windows) runs for +> 9 days (still running.) > > Thanks in advance > Markus > From jan.lahoda at oracle.com Wed Nov 20 05:01:24 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Wed, 20 Nov 2013 13:01:24 +0000 Subject: hg: jdk8/tl/langtools: 6557966: Multiple upper bounds of the TypeVariable Message-ID: <20131120130134.99358626FC@hg.openjdk.java.net> Changeset: 7c89d200781b Author: jlahoda Date: 2013-11-20 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7c89d200781b 6557966: Multiple upper bounds of the TypeVariable Summary: Adjusting javax.lang.model javadoc regarding IntersectionType, IntersectionType.accept now calls visitIntersection for all kinds of IntersectionTypes. Reviewed-by: darcy, vromero Contributed-by: joe.darcy at oracle.com, jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/javax/lang/model/type/DeclaredType.java ! src/share/classes/javax/lang/model/type/IntersectionType.java ! src/share/classes/javax/lang/model/type/TypeVariable.java ! test/tools/javac/processing/model/type/IntersectionPropertiesTest.java From staffan.larsen at oracle.com Wed Nov 20 05:05:14 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 20 Nov 2013 14:05:14 +0100 Subject: RFR: 4990369 SAJDI: visibleMethods() and methodsByName() return wrong visible methods Message-ID: This is more or less a copy of a previous patch that was made to JDI [1], but this patch applies to the SA implementation of JDI. ReferenceType.visibleMethods() has some problems with diamond shaped interface hierarchies. The solution here is to maintain a list of interfaces that we have visited so that we do not visit interfaces (above the top of the diamond) more than once. This change is targeted for jdk9 so I will hold on to it until the repos open up. webrev: http://cr.openjdk.java.net/~sla/4990369/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-4990369 Thanks, /Staffan [1] http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013166.html From dmitry.samersoff at oracle.com Wed Nov 20 05:04:21 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 20 Nov 2013 17:04:21 +0400 Subject: Review request for 7195249: Some jtreg tests use hard coded ports In-Reply-To: <528CA2DC.5000700@oracle.com> References: <528CA2DC.5000700@oracle.com> Message-ID: <528CB355.60104@oracle.com> Taras, *The only* correct way to take really free port is: 1. Chose random number between 49152 and 65535 2. Open socket if socket fails - repeat step 1 if socket OK - return *socket* If you can't keep the socket open (e.g. you have to pass port number as property value) you shouldn't do any pre-check as it has no value - as as soon as you close socket someone can take the port. So just choose a random number within the range above and let networking code opening socket to handle port conflict. -Dmitry On 2013-11-20 15:54, taras ledkov wrote: > Hi Everyone, > > I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. > > There are two webrevs: > Webrev for jdk part: > http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ > > Webrev for hs part: > http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ > > Please take a look at some notes: > - After discussing with Yekaterina Kantserova & Jaroslav Bachorik some > shell tests have been converted to java based tests > > - PasswordFilePermissionTest & SSLConfigFilePermissionTest tests looked > very similar, so a common parent class was created for them: > AbstractFilePermissionTest > > - What was called RmiRegistrySslTest.java I've renamed to > RmiRegistrySslTestApp.java. The java code to replace old shell script > RmiRegistrySslTest.sh is called RmiRegistrySslTest.java, hence the huge > diff. > > - The new RmiRegistrySslTest.java has some lines similar to the > AbstractFilePermissionTest.java, I nevertheless decided to not > complicate the code further and leave it as is. Please let me know if > this is somehow not acceptable > > - com/oracle/java/testlibrary/Utils.java that is added to hotspot > repository is taken from this patch: > http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html > > > - These tests will need additional changes when test library process > tools will support command line options inheritance > (http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013235.html) > > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From joel.franck at oracle.com Wed Nov 20 04:24:58 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Wed, 20 Nov 2013 12:24:58 +0000 Subject: hg: jdk8/tl/jdk: 8027413: Clarify javadoc for j.l.a.Target and j.l.a.ElementType Message-ID: <20131120122511.7F611626F9@hg.openjdk.java.net> Changeset: f39be11835ff Author: jfranck Date: 2013-11-20 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f39be11835ff 8027413: Clarify javadoc for j.l.a.Target and j.l.a.ElementType Reviewed-by: darcy ! src/share/classes/java/lang/annotation/ElementType.java ! src/share/classes/java/lang/annotation/Target.java From staffan.larsen at oracle.com Wed Nov 20 05:27:34 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 20 Nov 2013 14:27:34 +0100 Subject: Should ProblemList.txt be updated to reflect JDK-8024423 fix ? In-Reply-To: <528CA1CA.1080203@oracle.com> References: <528CA1CA.1080203@oracle.com> Message-ID: <04824322-E4ED-4934-B2C7-43D161F1843F@oracle.com> Looks good! Thanks for doing this, /Staffan On 20 nov 2013, at 12:49, Balchandra Vaidya wrote: > > Hi, > > It looks like 8024423 is already fixed in jdk 8 b115 and following > tests are passing as a result: > demo/jvmti/hprof/HeapAllTest.java > demo/jvmti/hprof/HeapBinaryFormatTest.java > demo/jvmti/hprof/HeapDumpTest.java > demo/jvmti/hprof/OptionsTest.java > demo/jvmti/hprof/StackMapTableTest.java > > But, the above tests are still present in ProblemList.txt. Is there > any issue to remove the above tests from ProblemList.txt > file? If yes, please review the following webrev: > > http://cr.openjdk.java.net/~bvaidya/8/8028632/webrev/ > > > > Thanks > Balchandra > From jaroslav.bachorik at oracle.com Wed Nov 20 05:42:58 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 20 Nov 2013 14:42:58 +0100 Subject: Review request for 7195249: Some jtreg tests use hard coded ports In-Reply-To: <528CB355.60104@oracle.com> References: <528CA2DC.5000700@oracle.com> <528CB355.60104@oracle.com> Message-ID: <528CBC62.1060801@oracle.com> On 20.11.2013 14:04, Dmitry Samersoff wrote: > Taras, > > *The only* correct way to take really free port is: > > 1. Chose random number between 49152 and 65535 > 2. Open socket > > if socket fails - repeat step 1 > if socket OK - return *socket* > > > If you can't keep the socket open (e.g. you have to pass port number as > property value) you shouldn't do any pre-check as it has no value - as > as soon as you close socket someone can take the port. > > So just choose a random number within the range above and let networking > code opening socket to handle port conflict. The problem is that the majority of the uses here is passing the port as an argument to the external application. There is no chance of forwarding the allocated socket. I've tried to experiment with the code that would try to "discover" a free port for the external application (eg. starting the application with random ports until it does not report any binding related exception and then returning the port back to the caller). It is achievable but relatively a lot of work - not sure how well this fail-proof system would measure against picking random ports and relying on the chance of the chosen port not being swept away by another process. -JB- > > -Dmitry > > > > On 2013-11-20 15:54, taras ledkov wrote: >> Hi Everyone, >> >> I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. >> >> There are two webrevs: >> Webrev for jdk part: >> http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ >> >> Webrev for hs part: >> http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ >> >> Please take a look at some notes: >> - After discussing with Yekaterina Kantserova & Jaroslav Bachorik some >> shell tests have been converted to java based tests >> >> - PasswordFilePermissionTest & SSLConfigFilePermissionTest tests looked >> very similar, so a common parent class was created for them: >> AbstractFilePermissionTest >> >> - What was called RmiRegistrySslTest.java I've renamed to >> RmiRegistrySslTestApp.java. The java code to replace old shell script >> RmiRegistrySslTest.sh is called RmiRegistrySslTest.java, hence the huge >> diff. >> >> - The new RmiRegistrySslTest.java has some lines similar to the >> AbstractFilePermissionTest.java, I nevertheless decided to not >> complicate the code further and leave it as is. Please let me know if >> this is somehow not acceptable >> >> - com/oracle/java/testlibrary/Utils.java that is added to hotspot >> repository is taken from this patch: >> http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html >> >> >> - These tests will need additional changes when test library process >> tools will support command line options inheritance >> (http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013235.html) >> >> > > From mattias.tobiasson at oracle.com Wed Nov 20 05:47:00 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Wed, 20 Nov 2013 05:47:00 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <14e8fbc6-9705-4c73-8ed5-fd79828ad8b6@default> Hi, Could you please review this fix. Summary of changes: 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. 2. Ported the following bash scripts to java: BasicTests.sh -> TestBasic.java PermissionTests.sh -> TestPermission.java ProviderTests.sh -> TestProvider.java 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: BasicsTest.java -> TestBasicImpl.java PermissionTest.java -> TestPermissionImpl.java ProviderTest.java -> TestProviderImpl.java 4. Added some utility functions to jdk/testlibrary. 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. Thanks, Mattias Webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-6461635 From Alan.Bateman at oracle.com Wed Nov 20 05:48:54 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 20 Nov 2013 13:48:54 +0000 Subject: Review request for 7195249: Some jtreg tests use hard coded ports In-Reply-To: <528CA2DC.5000700@oracle.com> References: <528CA2DC.5000700@oracle.com> Message-ID: <528CBDC6.8040209@oracle.com> On 20/11/2013 11:54, taras ledkov wrote: > Hi Everyone, > > I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. > > There are two webrevs: > Webrev for jdk part: > http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ One comment on LocalManagementTest.java, you could just replace 7775 with 0 to just bind to an ephemeral port (as the test itself doesn't need to know the port number). -Alan. From Alan.Bateman at oracle.com Wed Nov 20 05:50:53 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 20 Nov 2013 13:50:53 +0000 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <14e8fbc6-9705-4c73-8ed5-fd79828ad8b6@default> References: <14e8fbc6-9705-4c73-8ed5-fd79828ad8b6@default> Message-ID: <528CBE3D.30108@oracle.com> Out of curiosity, what is the reason for the rename? I ask because we use Basic and similar names in many areas. Also anything in the test tree should be a test. -Alan. On 20/11/2013 13:47, Mattias Tobiasson wrote: > Hi, > Could you please review this fix. > > Summary of changes: > > 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. > > 2. Ported the following bash scripts to java: > BasicTests.sh -> TestBasic.java > PermissionTests.sh -> TestPermission.java > ProviderTests.sh -> TestProvider.java > > 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: > BasicsTest.java -> TestBasicImpl.java > PermissionTest.java -> TestPermissionImpl.java > ProviderTest.java -> TestProviderImpl.java > > 4. Added some utility functions to jdk/testlibrary. > > 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. > > > Thanks, > Mattias > > Webrev: > http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6461635 From Alan.Bateman at oracle.com Wed Nov 20 05:56:36 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 20 Nov 2013 13:56:36 +0000 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: <99A95A98-D9D2-456B-8937-4F1C8B0D05B1@oracle.com> References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> <5277FEA3.4010101@oracle.com> <6D07D448-3A6F-4B69-AA26-6EF55B34CEB0@oracle.com> <99A95A98-D9D2-456B-8937-4F1C8B0D05B1@oracle.com> Message-ID: <528CBF94.1070107@oracle.com> I don't know if you are still looking for a Reviewer for this one. It looks okay to me (initially it looked like a lot of changes to review but its not the case). You might need to adjust the copyright dates on the script, unless of course the plane you were involved time travel :-) -Alan. On 18/11/2013 09:26, Staffan Larsen wrote: > Anyone dare look at this? :-) > > On 14 Nov 2013, at 08:35, Staffan Larsen wrote: > >> Still looking for an official Review of this change. >> >> Thanks, >> /Staffan >> >> On 11 Nov 2013, at 10:32, Staffan Larsen wrote: >> >>> Thanks Serguei! >>> >>> Can I have an official Review as well? >>> >>> /Staffan >>> >>> On 04 Nov 2013, at 21:08, serguei.spitsyn at oracle.com wrote: >>> >>>> Staffan, >>>> >>>> This one is really old: 11+ years. :) >>>> The fix is good, I do not see any issues. >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 11/4/13 6:41 AM, Staffan Larsen wrote: >>>>> This is an old one! Nothing like being bored on a plane... >>>>> >>>>> The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints. >>>>> >>>>> While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored). >>>>> >>>>> There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done. >>>>> >>>>> webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ >>>>> bug: https://bugs.openjdk.java.net/browse/JDK-4660158 >>>>> >>>>> Thanks, >>>>> /Staffan From staffan.larsen at oracle.com Wed Nov 20 05:58:57 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 20 Nov 2013 14:58:57 +0100 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: <528CBF94.1070107@oracle.com> References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> <5277FEA3.4010101@oracle.com> <6D07D448-3A6F-4B69-AA26-6EF55B34CEB0@oracle.com> <99A95A98-D9D2-456B-8937-4F1C8B0D05B1@oracle.com> <528CBF94.1070107@oracle.com> Message-ID: Thanks Alan! I?ll fix the copyright. Do you know if the javacc-generated files require copyright headers? /Staffan On 20 nov 2013, at 14:56, Alan Bateman wrote: > > I don't know if you are still looking for a Reviewer for this one. It looks okay to me (initially it looked like a lot of changes to review but its not the case). You might need to adjust the copyright dates on the script, unless of course the plane you were involved time travel :-) > > -Alan. > > On 18/11/2013 09:26, Staffan Larsen wrote: >> Anyone dare look at this? :-) >> >> On 14 Nov 2013, at 08:35, Staffan Larsen wrote: >> >>> Still looking for an official Review of this change. >>> >>> Thanks, >>> /Staffan >>> >>> On 11 Nov 2013, at 10:32, Staffan Larsen wrote: >>> >>>> Thanks Serguei! >>>> >>>> Can I have an official Review as well? >>>> >>>> /Staffan >>>> >>>> On 04 Nov 2013, at 21:08, serguei.spitsyn at oracle.com wrote: >>>> >>>>> Staffan, >>>>> >>>>> This one is really old: 11+ years. :) >>>>> The fix is good, I do not see any issues. >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> On 11/4/13 6:41 AM, Staffan Larsen wrote: >>>>>> This is an old one! Nothing like being bored on a plane... >>>>>> >>>>>> The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints. >>>>>> >>>>>> While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored). >>>>>> >>>>>> There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done. >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/ >>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-4660158 >>>>>> >>>>>> Thanks, >>>>>> /Staffan > From dmitry.samersoff at oracle.com Wed Nov 20 05:59:09 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 20 Nov 2013 17:59:09 +0400 Subject: Review request for 7195249: Some jtreg tests use hard coded ports In-Reply-To: <528CBC62.1060801@oracle.com> References: <528CA2DC.5000700@oracle.com> <528CB355.60104@oracle.com> <528CBC62.1060801@oracle.com> Message-ID: <528CC02D.1040103@oracle.com> Jaroslav, Generally speacking - test getting port number from command line should get it from harness and harness have to maintain a pool of free ports. But it's a long term goal. Today we don't have better option than chose a random number and hope this port is free. Any pre-check just sligthly decrease the probability of conflict at the cost of waisting time and resources. -Dmitry On 2013-11-20 17:42, Jaroslav Bachorik wrote: > On 20.11.2013 14:04, Dmitry Samersoff wrote: >> Taras, >> >> *The only* correct way to take really free port is: >> >> 1. Chose random number between 49152 and 65535 >> 2. Open socket >> >> if socket fails - repeat step 1 >> if socket OK - return *socket* >> >> >> If you can't keep the socket open (e.g. you have to pass port number as >> property value) you shouldn't do any pre-check as it has no value - as >> as soon as you close socket someone can take the port. >> >> So just choose a random number within the range above and let networking >> code opening socket to handle port conflict. > > The problem is that the majority of the uses here is passing the port as > an argument to the external application. There is no chance of > forwarding the allocated socket. > > I've tried to experiment with the code that would try to "discover" a > free port for the external application (eg. starting the application > with random ports until it does not report any binding related exception > and then returning the port back to the caller). It is achievable but > relatively a lot of work - not sure how well this fail-proof system > would measure against picking random ports and relying on the chance of > the chosen port not being swept away by another process. > > -JB- > >> >> -Dmitry >> >> >> >> On 2013-11-20 15:54, taras ledkov wrote: >>> Hi Everyone, >>> >>> I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. >>> >>> There are two webrevs: >>> Webrev for jdk part: >>> http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ >>> >>> Webrev for hs part: >>> http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ >>> >>> Please take a look at some notes: >>> - After discussing with Yekaterina Kantserova & Jaroslav Bachorik some >>> shell tests have been converted to java based tests >>> >>> - PasswordFilePermissionTest & SSLConfigFilePermissionTest tests looked >>> very similar, so a common parent class was created for them: >>> AbstractFilePermissionTest >>> >>> - What was called RmiRegistrySslTest.java I've renamed to >>> RmiRegistrySslTestApp.java. The java code to replace old shell script >>> RmiRegistrySslTest.sh is called RmiRegistrySslTest.java, hence the huge >>> diff. >>> >>> - The new RmiRegistrySslTest.java has some lines similar to the >>> AbstractFilePermissionTest.java, I nevertheless decided to not >>> complicate the code further and leave it as is. Please let me know if >>> this is somehow not acceptable >>> >>> - com/oracle/java/testlibrary/Utils.java that is added to hotspot >>> repository is taken from this patch: >>> http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html >>> >>> >>> >>> - These tests will need additional changes when test library process >>> tools will support command line options inheritance >>> (http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013235.html) >>> >>> >>> >> >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From Alan.Bateman at oracle.com Wed Nov 20 06:04:39 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 20 Nov 2013 14:04:39 +0000 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> <5277FEA3.4010101@oracle.com> <6D07D448-3A6F-4B69-AA26-6EF55B34CEB0@oracle.com> <99A95A98-D9D2-456B-8937-4F1C8B0D05B1@oracle.com> <528CBF94.1070107@oracle.com> Message-ID: <528CC177.3010504@oracle.com> On 20/11/2013 13:58, Staffan Larsen wrote: > Thanks Alan! > > I?ll fix the copyright. Do you know if the javacc-generated files require copyright headers? > I wondering that too, it's probably safer to keep them. -Alan. From staffan.larsen at oracle.com Wed Nov 20 06:20:47 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 20 Nov 2013 15:20:47 +0100 Subject: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command In-Reply-To: <528CC177.3010504@oracle.com> References: <131DF663-50BA-44A4-A271-CF29F986636E@oracle.com> <5277FEA3.4010101@oracle.com> <6D07D448-3A6F-4B69-AA26-6EF55B34CEB0@oracle.com> <99A95A98-D9D2-456B-8937-4F1C8B0D05B1@oracle.com> <528CBF94.1070107@oracle.com> <528CC177.3010504@oracle.com> Message-ID: <435D8CF6-B3CC-4B4B-8B0B-7FC633B813EE@oracle.com> Will do. On 20 nov 2013, at 15:04, Alan Bateman wrote: > On 20/11/2013 13:58, Staffan Larsen wrote: >> Thanks Alan! >> >> I?ll fix the copyright. Do you know if the javacc-generated files require copyright headers? >> > I wondering that too, it's probably safer to keep them. > > -Alan. From mattias.tobiasson at oracle.com Wed Nov 20 06:41:50 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Wed, 20 Nov 2013 06:41:50 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <6428d76b-2530-485a-bfdf-4a621b527fac@default> Hi, Each test requires 2 files, the actual test code and a helper file. The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. For example: PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java PermissionTest.java: The actual test code that attaches to the Application. It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. I used these names: TestPermission.java: Helper file. TestPermissionImpl.java: Actual test code. I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. Mattias ----- Original Message ----- From: Alan.Bateman at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Out of curiosity, what is the reason for the rename? I ask because we use Basic and similar names in many areas. Also anything in the test tree should be a test. -Alan. On 20/11/2013 13:47, Mattias Tobiasson wrote: > Hi, > Could you please review this fix. > > Summary of changes: > > 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. > > 2. Ported the following bash scripts to java: > BasicTests.sh -> TestBasic.java > PermissionTests.sh -> TestPermission.java > ProviderTests.sh -> TestProvider.java > > 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: > BasicsTest.java -> TestBasicImpl.java > PermissionTest.java -> TestPermissionImpl.java > ProviderTest.java -> TestProviderImpl.java > > 4. Added some utility functions to jdk/testlibrary. > > 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. > > > Thanks, > Mattias > > Webrev: > http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6461635 From mikael.auno at oracle.com Wed Nov 20 07:11:43 2013 From: mikael.auno at oracle.com (Mikael Auno) Date: Wed, 20 Nov 2013 16:11:43 +0100 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <6428d76b-2530-485a-bfdf-4a621b527fac@default> References: <6428d76b-2530-485a-bfdf-4a621b527fac@default> Message-ID: <528CD12F.5050007@oracle.com> How about defining the class that you want to attach to as a static inner class to the actual test? That would give you only one file, but with two classes, each with its own main method and clear correlation between them. Mikael On 2013-11-20 15:41, Mattias Tobiasson wrote: > Hi, > Each test requires 2 files, the actual test code and a helper file. > > The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. > > For example: > PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java > PermissionTest.java: The actual test code that attaches to the Application. > > It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). > > When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. > > I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. > > I used these names: > TestPermission.java: Helper file. > TestPermissionImpl.java: Actual test code. > > I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. > > Mattias > > > ----- Original Message ----- > From: Alan.Bateman at oracle.com > To: mattias.tobiasson at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > > Out of curiosity, what is the reason for the rename? I ask because we > use Basic and similar names in many areas. Also anything in the test > tree should be a test. > > -Alan. > > On 20/11/2013 13:47, Mattias Tobiasson wrote: >> Hi, >> Could you please review this fix. >> >> Summary of changes: >> >> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >> >> 2. Ported the following bash scripts to java: >> BasicTests.sh -> TestBasic.java >> PermissionTests.sh -> TestPermission.java >> ProviderTests.sh -> TestProvider.java >> >> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >> BasicsTest.java -> TestBasicImpl.java >> PermissionTest.java -> TestPermissionImpl.java >> ProviderTest.java -> TestProviderImpl.java >> >> 4. Added some utility functions to jdk/testlibrary. >> >> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >> >> >> Thanks, >> Mattias >> >> Webrev: >> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6461635 > From roger.riggs at oracle.com Wed Nov 20 07:40:46 2013 From: roger.riggs at oracle.com (roger riggs) Date: Wed, 20 Nov 2013 10:40:46 -0500 Subject: Review request for 7195249: Some jtreg tests use hard coded ports In-Reply-To: <528CB355.60104@oracle.com> References: <528CA2DC.5000700@oracle.com> <528CB355.60104@oracle.com> Message-ID: <528CD7FE.3010401@oracle.com> Hi, fyi, The jdk.testlibrary.Utils.getFreePort() method will Open an free Socket, close it and return the port number. And as Alan recommended, use (0) when possible to have the system assign the port #. Roger On 11/20/2013 8:04 AM, Dmitry Samersoff wrote: > Taras, > > *The only* correct way to take really free port is: > > 1. Chose random number between 49152 and 65535 > 2. Open socket > > if socket fails - repeat step 1 > if socket OK - return *socket* > > > If you can't keep the socket open (e.g. you have to pass port number as > property value) you shouldn't do any pre-check as it has no value - as > as soon as you close socket someone can take the port. > > So just choose a random number within the range above and let networking > code opening socket to handle port conflict. > > -Dmitry > > > > On 2013-11-20 15:54, taras ledkov wrote: >> Hi Everyone, >> >> I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. >> >> There are two webrevs: >> Webrev for jdk part: >> http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ >> >> Webrev for hs part: >> http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ >> >> Please take a look at some notes: >> - After discussing with Yekaterina Kantserova & Jaroslav Bachorik some >> shell tests have been converted to java based tests >> >> - PasswordFilePermissionTest & SSLConfigFilePermissionTest tests looked >> very similar, so a common parent class was created for them: >> AbstractFilePermissionTest >> >> - What was called RmiRegistrySslTest.java I've renamed to >> RmiRegistrySslTestApp.java. The java code to replace old shell script >> RmiRegistrySslTest.sh is called RmiRegistrySslTest.java, hence the huge >> diff. >> >> - The new RmiRegistrySslTest.java has some lines similar to the >> AbstractFilePermissionTest.java, I nevertheless decided to not >> complicate the code further and leave it as is. Please let me know if >> this is somehow not acceptable >> >> - com/oracle/java/testlibrary/Utils.java that is added to hotspot >> repository is taken from this patch: >> http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html >> >> >> - These tests will need additional changes when test library process >> tools will support command line options inheritance >> (http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013235.html) >> >> > From mandy.chung at oracle.com Wed Nov 20 08:14:49 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 20 Nov 2013 08:14:49 -0800 Subject: Review request for 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt In-Reply-To: <528CA40A.2030305@oracle.com> References: <528BF046.6000209@oracle.com> <528CA40A.2030305@oracle.com> Message-ID: <528CDFF9.1030906@oracle.com> Staffan, Chris, Thanks for the review. On 11/20/2013 3:59 AM, Chris Hegarty wrote: > Mandy, > > The changes look ok to me, and the approach of adding additional > diagnostic information makes sense. > > Trivially, you can remove 'trace', as I don't think it is being used > any more. > Will remove it before I push. Mandy > -Chris. > > On 19/11/13 23:12, Mandy Chung wrote: >> Webrev at: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028647/webrev.00/ >> >> This patch turns the trace on by default and also add the >> instrumentation to print the safepoint count to help troubleshooting the >> test failure. >> >> test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java is no >> longer reproducible on jdk8 b109. GetSafepointSyncTime.java should be >> removed from the ProblemList.txt. This still fails with 7u45 and so I >> want to backport this change to 7u-dev. There might be a hotspot fix >> in jdk8 that resolves the zero safepoint sync time issue for further >> investigation. >> >> thanks >> Mandy >> From ivan.gerasimov at oracle.com Wed Nov 20 08:34:17 2013 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 20 Nov 2013 20:34:17 +0400 Subject: RFR [8025886] replace == and [[ bash extensions In-Reply-To: <52546C67.7090904@oracle.com> References: <524D7AF6.2000705@oracle.com> <524EA7D1.7030908@oracle.com> <52500E4D.6020307@oracle.com> <52504CB4.9090103@oracle.com> <52546C67.7090904@oracle.com> Message-ID: <528CE489.5090006@oracle.com> Hello all! Any chance to have this simple fix approved? The proposal is to get rid of == and [[ bash extensions, as this is the only place they are used in jdk regtests and sh-shell is not happy with them. Thanks in advance, Ivan Gerasimov --- a/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh +++ b/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh @@ -34,12 +34,13 @@ OS=`uname -s` UMASK=`umask` -if [[ $OS == CYGWIN_NT* ]] ; then +case $OS in +CYGWIN_NT*) OS="Windows_NT" if [ -z "$SystemRoot" ] ; then - SystemRoot=$SYSTEMROOT + SystemRoot=$SYSTEMROOT fi -fi +esac case $OS in SunOS | Linux | Darwin) On 09.10.2013 0:34, Ivan Gerasimov wrote: > Thanks, Dmitry! > > I assume I still need an approval from the Reviewer. > > Sincerely yours, > Ivan > > On 05.10.2013 21:30, Dmitry Samersoff wrote: >> Ivan, >> >> Looks good for me. >> >> -Dmitry >> >> On 2013-10-05 17:04, Ivan Gerasimov wrote: >>> Dmitry, thanks for suggestion! >>> >>> Yes, == comparison isn't the only sh-incompatible thing in the script. >>> Sh may be unhappy with [[ as well. >>> So I replaced it with case as you suggested. >>> Grep shows that it was the only place where [[ and == were used in >>> regtests, so it would be good to make things consistent. >>> >>> Please find a new patch below. >>> >>> Sincerely yours, >>> Ivan >>> >>> --- >>> a/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh >>> +++ >>> b/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh >>> @@ -34,12 +34,13 @@ >>> OS=`uname -s` >>> UMASK=`umask` >>> >>> -if [[ $OS == CYGWIN_NT* ]] ; then >>> +case $OS in >>> +CYGWIN_NT*) >>> OS="Windows_NT" >>> if [ -z "$SystemRoot" ] ; then >>> - SystemRoot=$SYSTEMROOT >>> + SystemRoot=$SYSTEMROOT >>> fi >>> -fi >>> +esac >>> >>> case $OS in >>> SunOS | Linux | Darwin) >>> >>> >>> >>> On 04.10.2013 15:34, Dmitry Samersoff wrote: >>>> Ivan, >>>> >>>> If you need shell pattern match CYGWIN_NT* >>>> it's better to use >>>> >>>> case >>>> >>>> but not >>>> >>>> if >>>> >>>> -Dmitry >>>> >>>> >> > > > From staffan.larsen at oracle.com Wed Nov 20 09:18:59 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 20 Nov 2013 18:18:59 +0100 Subject: RFR [8025886] replace == and [[ bash extensions In-Reply-To: <528CE489.5090006@oracle.com> References: <524D7AF6.2000705@oracle.com> <524EA7D1.7030908@oracle.com> <52500E4D.6020307@oracle.com> <52504CB4.9090103@oracle.com> <52546C67.7090904@oracle.com> <528CE489.5090006@oracle.com> Message-ID: Reviewed. /Staffan On 20 nov 2013, at 17:34, Ivan Gerasimov wrote: > Hello all! > > Any chance to have this simple fix approved? > The proposal is to get rid of == and [[ bash extensions, as this is the only place they are used in jdk regtests and sh-shell is not happy with them. > > Thanks in advance, > Ivan Gerasimov > > --- a/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > +++ b/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > @@ -34,12 +34,13 @@ > OS=`uname -s` > UMASK=`umask` > > -if [[ $OS == CYGWIN_NT* ]] ; then > +case $OS in > +CYGWIN_NT*) > OS="Windows_NT" > if [ -z "$SystemRoot" ] ; then > - SystemRoot=$SYSTEMROOT > + SystemRoot=$SYSTEMROOT > fi > -fi > +esac > > case $OS in > SunOS | Linux | Darwin) > > > > > On 09.10.2013 0:34, Ivan Gerasimov wrote: >> Thanks, Dmitry! >> >> I assume I still need an approval from the Reviewer. >> >> Sincerely yours, >> Ivan >> >> On 05.10.2013 21:30, Dmitry Samersoff wrote: >>> Ivan, >>> >>> Looks good for me. >>> >>> -Dmitry >>> >>> On 2013-10-05 17:04, Ivan Gerasimov wrote: >>>> Dmitry, thanks for suggestion! >>>> >>>> Yes, == comparison isn't the only sh-incompatible thing in the script. >>>> Sh may be unhappy with [[ as well. >>>> So I replaced it with case as you suggested. >>>> Grep shows that it was the only place where [[ and == were used in >>>> regtests, so it would be good to make things consistent. >>>> >>>> Please find a new patch below. >>>> >>>> Sincerely yours, >>>> Ivan >>>> >>>> --- a/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh >>>> +++ b/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh >>>> @@ -34,12 +34,13 @@ >>>> OS=`uname -s` >>>> UMASK=`umask` >>>> >>>> -if [[ $OS == CYGWIN_NT* ]] ; then >>>> +case $OS in >>>> +CYGWIN_NT*) >>>> OS="Windows_NT" >>>> if [ -z "$SystemRoot" ] ; then >>>> - SystemRoot=$SYSTEMROOT >>>> + SystemRoot=$SYSTEMROOT >>>> fi >>>> -fi >>>> +esac >>>> >>>> case $OS in >>>> SunOS | Linux | Darwin) >>>> >>>> >>>> >>>> On 04.10.2013 15:34, Dmitry Samersoff wrote: >>>>> Ivan, >>>>> >>>>> If you need shell pattern match CYGWIN_NT* >>>>> it's better to use >>>>> >>>>> case >>>>> >>>>> but not >>>>> >>>>> if >>>>> >>>>> -Dmitry >>>>> >>>>> >>> >> >> >> > From dmitry.samersoff at oracle.com Wed Nov 20 09:38:35 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 20 Nov 2013 21:38:35 +0400 Subject: Review request for 7195249: Some jtreg tests use hard coded ports In-Reply-To: <528CD7FE.3010401@oracle.com> References: <528CA2DC.5000700@oracle.com> <528CB355.60104@oracle.com> <528CD7FE.3010401@oracle.com> Message-ID: <528CF39B.3060607@oracle.com> Roger, As soon as we close a socket nobody can guarantee that the port is free. Moreover, port returned by getFreePort()[1] remains not accessible for some time - it depends to system setup, take a look to discussions around SO_REUSEPORT for Linux or SO_REUSEADDR and SO_LINGER for BSD. So from stability point of view it's better to just return random number between 49152 and 65535. -Dmitry [1] 141 public static int getFreePort() throws InterruptedException, IOException { 142 int port = -1; 143 144 while (port <= 0) { 145 Thread.sleep(100); 146 147 ServerSocket serverSocket = null; 148 try { 149 serverSocket = new ServerSocket(0); 150 port = serverSocket.getLocalPort(); 151 } finally { 152 serverSocket.close(); 153 } 154 } 155 156 return port; 157 } 158 On 2013-11-20 19:40, roger riggs wrote: > Hi, > > fyi, The jdk.testlibrary.Utils.getFreePort() method will Open an free > Socket, close it and return > the port number. > > And as Alan recommended, use (0) when possible to have the system assign > the port #. > > Roger > > On 11/20/2013 8:04 AM, Dmitry Samersoff wrote: >> Taras, >> >> *The only* correct way to take really free port is: >> >> 1. Chose random number between 49152 and 65535 >> 2. Open socket >> >> if socket fails - repeat step 1 >> if socket OK - return *socket* >> >> >> If you can't keep the socket open (e.g. you have to pass port number as >> property value) you shouldn't do any pre-check as it has no value - as >> as soon as you close socket someone can take the port. >> >> So just choose a random number within the range above and let networking >> code opening socket to handle port conflict. >> >> -Dmitry >> >> >> >> On 2013-11-20 15:54, taras ledkov wrote: >>> Hi Everyone, >>> >>> I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. >>> >>> There are two webrevs: >>> Webrev for jdk part: >>> http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ >>> >>> Webrev for hs part: >>> http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ >>> >>> Please take a look at some notes: >>> - After discussing with Yekaterina Kantserova & Jaroslav Bachorik some >>> shell tests have been converted to java based tests >>> >>> - PasswordFilePermissionTest & SSLConfigFilePermissionTest tests looked >>> very similar, so a common parent class was created for them: >>> AbstractFilePermissionTest >>> >>> - What was called RmiRegistrySslTest.java I've renamed to >>> RmiRegistrySslTestApp.java. The java code to replace old shell script >>> RmiRegistrySslTest.sh is called RmiRegistrySslTest.java, hence the huge >>> diff. >>> >>> - The new RmiRegistrySslTest.java has some lines similar to the >>> AbstractFilePermissionTest.java, I nevertheless decided to not >>> complicate the code further and leave it as is. Please let me know if >>> this is somehow not acceptable >>> >>> - com/oracle/java/testlibrary/Utils.java that is added to hotspot >>> repository is taken from this patch: >>> http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html >>> >>> >>> >>> - These tests will need additional changes when test library process >>> tools will support command line options inheritance >>> (http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013235.html) >>> >>> >>> >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From mandy.chung at oracle.com Wed Nov 20 10:02:35 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 20 Nov 2013 18:02:35 +0000 Subject: hg: jdk8/tl/jdk: 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt Message-ID: <20131120180250.5B94562711@hg.openjdk.java.net> Changeset: 90e27a47ff28 Author: mchung Date: 2013-11-20 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90e27a47ff28 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt Reviewed-by: sla, chegar ! test/ProblemList.txt ! test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java From volker.simonis at gmail.com Wed Nov 20 10:26:35 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 20 Nov 2013 19:26:35 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX Message-ID: Hi, this is the second review round for "8024854: Basic changes and files to build the class library on AIX". The previous reviews can be found at the end of this mail in the references section. I've tried to address all the comments and suggestions from the first round and to further streamline the patch (it perfectly builds on Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The biggest change compared to the first review round is the new "aix/" subdirectory which I've now created under "jdk/src" and which contains AIX-only code. The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ Below (and in the webrev) you can find some comments which explain the changes to each file. In order to be able to push this big change, I need the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. So please don't hesitate to jump at it - there are enough changes for everybody:) Thank you and best regards, Volker *References:* The following reviews have been posted so far (thanks Iris for collecting them :) - Alan Bateman (lib): Initial comments (16 Sep [2]) - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) - Michael McMahon (net): Initial comments (20 Sept [4]) - Steffan Larsen (svc): APPROVED (20 Sept [5]) - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments (15 Oct [7]) - Sean Mullan (sec): Initial comments (26 Sept [8]) [2]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html [3]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html [4]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html [5]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html [6]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html [8]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html *Detailed change description:* The new "jdk/src/aix" subdirectory contains the following new and AIX-specific files for now: src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java src/aix/classes/sun/nio/ch/AixPollPort.java src/aix/classes/sun/nio/fs/AixFileStore.java src/aix/classes/sun/nio/fs/AixFileSystem.java src/aix/classes/sun/nio/fs/AixFileSystemProvider.java src/aix/classes/sun/nio/fs/AixNativeDispatcher.java src/aix/classes/sun/tools/attach/AixAttachProvider.java src/aix/classes/sun/tools/attach/AixVirtualMachine.java src/aix/native/java/net/aix_close.c src/aix/native/sun/nio/ch/AixPollPort.c src/aix/native/sun/nio/fs/AixNativeDispatcher.c src/aix/native/sun/tools/attach/AixVirtualMachine.c src/aix/porting/porting_aix.c src/aix/porting/porting_aix.h src/aix/porting/porting_aix.c src/aix/porting/porting_aix.h - Added these two files for AIX relevant utility code. - Currently these files only contain an implementation of dladdr which is not available on AIX. - In the first review round the existing dladdr users in the code either called the version from the HotSpot on AIX ( src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). This is now not necessary any more. The new file layout required some small changes to the makefiles to make them aware of the new directory locations: makefiles/CompileDemos.gmk - Add an extra argument to SetupJVMTIDemo which can be used to pass additional source locations. - Currently this is only used on AIX for the AIX porting utilities which are required by hprof. makefiles/lib/Awt2dLibraries.gmk makefiles/lib/ServiceabilityLibraries.gmk - On AIX add the sources of the AIX porting utilities to the build. They are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not available on AIX. makefiles/lib/NioLibraries.gmk - Make the AIX-build aware of the new NIO source locations under src/aix/native/sun/nio/. makefiles/lib/NetworkingLibraries.gmk - Make the AIX-build aware of the new aix_close.c source location under src/aix/native/java/net/. src/share/bin/jli_util.h - Define JLI_Lseek on AIX. src/share/lib/security/java.security-aix - Provide default java.security-aix for AIX based on the latest Linux version as suggested by Sean Mullan. src/share/native/common/check_code.c - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is legal, but the code in check_code.c does not handles this properly. So we wrap the two methods on AIX and return a non-NULL pointer even if we allocate 0 bytes. src/share/native/sun/awt/medialib/mlib_sys.c - malloc always returns 8-byte aligned pointers on AIX as well. src/share/native/sun/awt/medialib/mlib_types.h - Add AIX to the list of known platforms. src/share/native/sun/font/layout/KernTable.cpp - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too common and may be defined in other headers as well as on the command line and xlc bails out on macro redefinitions with a different value. src/share/native/sun/security/ec/impl/ecc_impl.h - Define required types and macros on AIX. src/solaris/back/exec_md.c - AIX behaves like Linux in this case so check for it in the Linux branch. src/solaris/bin/java_md_solinux.c, src/solaris/bin/java_md_solinux.h - On AIX LD_LIBRARY_PATH is called LIBPATH - Always use LD_LIBRARY_PATH macro instead of using the string " LD_LIBRARY_PATH" directly to cope with different library path names. - Add jre/lib//jli to the standard library search path on AIX because the AIX linker doesn't support the -rpath option. - Replace #ifdef __linux__ by #ifndef __solaris__ because in this case, AIX behaves like Linux. - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from java_md_solinux.h because the macros are redefined in the corresponding .c files anyway. src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties - Provide basic fontconfig.propertiesfor AIX. src/solaris/classes/java/lang/UNIXProcess.java.aix, src/aix/classes/sun/tools/attach/AixAttachProvider.java, src/aix/classes/sun/tools/attach/AixVirtualMachine.java, src/aix/native/sun/tools/attach/AixVirtualMachine.c - Provide AIX specific Java versions, mostly based on the corresponding Linux versions. src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java - Detect AIX operating system and return the corresponding channel and file system providers. src/solaris/classes/sun/nio/ch/Port.java - Add a callback function unregisterImpl(int fd) for implementations that need special handling when fd is removed and call it from unregister(int fd). By default the implementation of unregisterImpl(int fd) is empty except for the derived AixPollPort class on AIX. src/solaris/demo/jvmti/hprof/hprof_md.c - Add AIX support. AIX mostly behaves like Linux, with the one exception that it has no dladdr functionality. - Use the dladdr implementation from porting_aix.{c,h} on AIX. src/solaris/native/com/sun/management/UnixOperatingSystem_md.c - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). src/solaris/native/common/jdk_util_md.h - Add AIX definitions of the ISNANF and ISNAND macros. src/solaris/native/java/io/io_util_md.c - AIX behaves like Linux in this case so check for it in the Linux branch. src/solaris/native/java/lang/UNIXProcess_md.c - AIX behaves mostly like Solraris in this case so adjust the ifdefs accordingly. src/solaris/native/java/lang/childproc.c - AIX does not understand '/proc/self' - it requires the real process ID to query the proc file system for the current process. src/solaris/native/java/net/NetworkInterface.c - Add AIX support into the Linux branch because AIX mostly behaves like AIX for IPv4. - AIX needs a special function to enumerate IPv6 interfaces and to query the MAC address. - Moved the declaration of siocgifconfRequest to the beginning a the function (as recommend by Michael McMahon) to remain C89 compatible. src/solaris/native/java/net/PlainSocketImpl.c - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the socket is closed. The default error message is then confusing. src/aix/native/java/net/aix_close.c, src/share/native/java/net/net_util.c - As recommended by Michael McMahon and Alan Bateman I've move an adapted version of linux_close.c to src/aix/native/java/net/aix_close.cbecause we also need the file and socket wrappers on AIX. - Compared to the Linux version, we've added the initialization of some previously uninitialized data structures. - Also, on AIX we don't have __attribute((constructor)) so we need to initialize manually (from JNI_OnLoad() in src/share/native/java/net/net_util.c. src/solaris/native/java/net/net_util_md.h - AIX needs the same workaround for I/O cancellation like Linux and MacOSX. src/solaris/native/java/net/net_util_md.c - SO_REUSEADDR is called SO_REUSEPORT on AIX. - On AIX we have to ignore failures due to ENOBUFS when setting the SO_SNDBUF/SO_RCVBUF socket options. src/solaris/native/java/util/TimeZone_md.c - Currently on AIX the only way to get the platform time zone is to read it from the TZ environment variable. src/solaris/native/sun/awt/awt_LoadLibrary.c - Use the dladdr from porting_aix.{c,h} on AIX. src/solaris/native/sun/awt/fontpath.c - Changed some macros from if !defined(__linux__) to if defined(__solaris__) because that's their real meaning. - Add AIX specific fontpath settings and library search paths for libfontconfig.so. src/solaris/native/sun/java2d/x11/X11SurfaceData.c - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name clashes (MIN and MAX are much too common and thexy are already defined in some AIX system headers). src/solaris/native/sun/java2d/x11/XRBackendNative.c - Handle AIX like Solaris. src/solaris/native/sun/nio/ch/Net.c - Add AIX-specific includes and constant definitions. - On AIX "socket extensions for multicast source filters" support depends on the OS version. Check for this and throw appropriate exceptions if it is requested but not supported. This is needed to pass JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to NULL for the directory stream end. Otherwise, 'errno' will contain the error code. - Handle some AIX corner cases for the results of the statvfs64() call. - On AIX getgrgid_r() returns ESRCH if group does not exist. src/solaris/native/sun/security/pkcs11/j2secmod_md.c - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. test/java/lang/ProcessBuilder/Basic.java test/java/lang/ProcessBuilder/DestroyTest.java - Port this test to AIX and make it more robust (i.e. recognize the "C" locale as isEnglish(), ignore VM-warnings in the output, make sure the "grandchild" processes created by the test don't run too long (60s vs. 6666s) because in the case of test problems these processes will pollute the process space, make sure the test fails with an error and doesn't hang indefinitley in the case of a problem). *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this intended? Well, _AIX is defined in some system headers while AIX is defined by the build system. This is already used inconsistently (i.e. __linux__ vs. LINUX) and in general I try to be consistent with the style of the file where I the changes are. That said, I changes most of the occurences of AIX to _AIX. *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are they supposed to be there? We currently don't support OS/400 (later renamed into i5/OS and currently called IBM i) in our OpenJDK port but we do support it in our internel, SAP JVM build. We stripped out all the extra OS/400 functionality from the port but in some places where there is common functionality needd by both, AIX and OS/400 the OS/400 support may still be visible in the OpenJDK port. I don't think this is a real problem and it helps us to keep our internel sources in sync with the OpenJDK port. That said, I think I've removed all the references to OS/400 now. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131120/95330cdb/attachment-0001.html From bhavesh.x.patel at oracle.com Wed Nov 20 10:54:26 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 20 Nov 2013 18:54:26 +0000 Subject: hg: jdk8/tl/langtools: 8027977: javadoc dies on NumberFormat/DateFormat subclass Message-ID: <20131120185429.D7D4462717@hg.openjdk.java.net> Changeset: ef44a2971cb1 Author: bpatel Date: 2013-11-20 10:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef44a2971cb1 8027977: javadoc dies on NumberFormat/DateFormat subclass Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/DocEnv.java + test/com/sun/javadoc/testCompletionFailure/TestCompletionFailure.java + test/com/sun/javadoc/testCompletionFailure/pkg1/NumberFormatTest.java From alan.bateman at oracle.com Wed Nov 20 13:36:54 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 20 Nov 2013 21:36:54 +0000 Subject: hg: jdk8/tl/jdk: 8028734: test/java/util/Locale/InternationalBAT.java changes does not restore the default TimeZone Message-ID: <20131120213710.E21EF6271F@hg.openjdk.java.net> Changeset: ecd6c25b54ce Author: alanb Date: 2013-11-20 21:34 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecd6c25b54ce 8028734: test/java/util/Locale/InternationalBAT.java changes does not restore the default TimeZone Reviewed-by: naoto ! test/java/util/Locale/InternationalBAT.java From david.holmes at oracle.com Wed Nov 20 14:10:59 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 21 Nov 2013 08:10:59 +1000 Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: <583240ce-cf21-44d8-b1e9-4b53d547d6b9@default> References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> <58a6b698-bf13-424a-9b95-deb676155b39@default> <528AC5A7.8070907@oracle.com> <583240ce-cf21-44d8-b1e9-4b53d547d6b9@default> Message-ID: <528D3373.2080000@oracle.com> Hi Markus, I couldn't quite work out if TracingTime is obsolete after these changes? Otherwise I have no further comments. Thanks, David On 20/11/2013 10:17 PM, Markus Gronlund wrote: > Hi again, > > I have created an updated webrev02 for the feedback I have gotten so far. In addition, I have added a few improvements to the original suggestion. > > Updated Webrev02: http://cr.openjdk.java.net/~mgronlun/8028128/webrev02/ > Original Webrev01: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 > > Thanks a lot for your help/patience in reviewing this large change - very much appreciated. > > Cheers > Markus > > Description of deltas/updates to Webrev02 compared to Webrev01: > > // updates based on feedback > > utilities/ticks.inline.hpp > > // removed functions comparing against jlong(s) > > - #63 inline bool operator==(const Ticks& lhs, jlong compare_value) { > - #64 return lhs.value() == compare_value; > - #65 } > > - #89 inline bool operator!=(const Ticks& lhs, jlong compare_value) { > - #90 return lhs.value() != compare_value; > - #91 } > > // updated to gt signs for operator<= functions > - #52 return !operator<(lhs, rhs); > + #52 return !operator >(lhs, rhs); > > - #98 return !operator<(lhs,rhs); > + #98 return !operator>(lhs,rhs); > > // thanks to Vitaly Davidovich. > > > share/vm/gc_implementation/gcTimer.hpp > > // removed default parameter for report_gc_phase_* functions > > - #114 void report_gc_phase_start(const char* name, const Ticks& time = Ticks::now()); > + #114 void report_gc_phase_start(const char* name, const Ticks& time); > > - #115 void report_gc_phase_end(const Ticks& time = Ticks::now()); > + #115 void report_gc_phase_end(const Ticks& time); > > - #145 void register_gc_phase_start(const char* name, const Ticks& time = Ticks::now()); > + #145 void register_gc_phase_start(const char* name, const Ticks& time); > > - #146 void register_gc_phase_end(const Ticks& time = Ticks::now()); > + #146 void register_gc_phase_end(const Ticks& time); > > // thanks to Per Liden. > > > // > // > // > // Additional changes compared to webrev01 (delta) > // > > webrev01 still allows a user to pass in a jlong (knowingly and/or unknowingly) for event.starttime() and event.endtime(). > For example: > > event.set_endtime(os::elapsed_counter()); // direct call using os::elapsed_counter() > > This can be avoided by increasing encapsulation: > > src/share/vm/trace/traceEvent.hpp: > > set_starttime(const TracingTime& time) // remove default parameter and make protected > set_endtime(const TracingTime& time) // remove default parameter and make protected > > Now, the only visible external API for setting the start and/or endtime of an event is by passing a "Ticks" type (a compiler enforced constraint): > > Using the same example as above, now if attempting to pass a jlong, like a direct call using os::elapsed_counter(), this now yields (at compile time): > >> ..\..\src\share\vm\gc_implementation\shared\gcTraceSend.cpp(63): error C2248: 'TraceEvent::set_endtime' : cannot access protected member declared in class 'TraceEvent' > > > In order to make these functions protected, i have also had to update the class loader events in SystemDictionary and ClassLoaderDataGraph: > > share/vm/classfile/SystemDictionary.hpp: > > // remove include file: > - #34 #include "trace/traceTime.hpp" > > + #80 forward declare class Ticks; > > > // update the signature > - #640 static void post_class_load_event(const TracingTime& start_time, instanceKlassHandle k, > Handle initiating_loader); > > + #640 static void post_class_load_event(const Ticks& start_time, instanceKlassHandle k, > Handle initiating_loader); > > > > share/vm/classfile/SystemDictionary.cpp: > > // added include files > +#58 #include "utilities/macros.hpp" > +#59 #include "utilities/ticks.hpp" > > // removed old include file: > - #61 #include "trace/traceMacros.hpp" > > // updated type > - #601 TracingTime class_load_start_time = Tracing::time(); > + #601 Ticks class_load_start_time = Ticks::now(); > > // updated type > - #1009 TracingTime class_load_start_time = Tracing::time(); > + #1009 Ticks class_load_start_time = Ticks::now(); > > // updated signature > - #2668 void SystemDictionary::post_class_load_event(TracingTime start_time, instanceKlassHandle k, Handle initiating_loader) > + #2668 void SystemDictionary::post_class_load_event(const Ticks& start_time, instanceKlassHandle k, Handle initiating_loader) > > // removed setting the endtime > - #2674 event.set_endtime(Tracing::time()); > > > src/share/vm/classfile/classLoaderData.hpp: > > // update include > - #36 #include "trace/traceTime.hpp" > + #36 #include "utilities/ticks.hpp" > > // updated type for _class_unload_time; > - #101 static TracingTime _class_unload_time; > + #101 static Ticks _class_unload_time; > > > src/share/vm/classfile/classLoaderData.cpp: > > + #65 #include "utilities/macros.hpp" > > // updated timestamp > - #757 _class_unload_time = Tracing::time(); > + #757 _class_unload_time = Ticks::now(); > > // updated type definition > - #835 TracingTime ClassLoaderDataGraph::_class_unload_time; > + #835 Ticks ClassLoaderDataGraph::_class_unload_time; > > > src/share/vm/trace/traceEventClasses.xls: > > // update the !INCLUDE_TRACE stubs > - #59 void set_starttime(jlong time) const {} > - #60 void set_endtime(jlong time) const {} > > + #59 void set_starttime(const Ticks& time) {} > + #59 void set_endtime(const Ticks& time) {} > > > Thanks > Markus > > > >> >> Greetings, >> >> Kindly asking for reviews for the following changeset: >> >> Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 >> >> *Description:* >> >> Currently, when working with counter based data, the primary data type >> representation in the VM are raw jlong's. jlong's are employed to >> represent both: >> >> 1. a single instance in time, for example a "now" timestamp 2. a time >> duration, a timespan, for example the duration between "now" - "then" >> >> Having a raw jlong type represent both of these shifts the >> responsibility to the programmer to always ensure the correct validity >> of the counter data, without any assistance either at compile time or >> at runtime. >> >> The event based tracing framework relies heavily on counter based data >> in order to keep track of time and timing related information and we >> have seen counter data errors where the representation sent to the >> tracing framework has submitted the wrong time, i.e. a timespan when a >> time instant was expected and vice versa. >> >> We should therefore add an alternative to jlongs for representing >> counter based data. We should enlist the help of the type system to >> enforce the correct data types at compile time as well as introduce >> strong runtime asserts in order to help with the correct usage of time >> and to reduce the number of potential bugs. >> >> I will therefore add two new types in src/share/vm/utilities: >> >> 1. "Ticks" - represents a single counter based timestamp, a single >> instance in time. >> 2. "Tickspan" - represents a counter based duration, a timespan, >> between two "Ticks" >> >> Please see the added files: >> >> -src/share/vm/utilities/ticks.hpp >> >> -src/share/vm/utilities/ticks.inline.hpp >> >> -src/share/vm/utilities/ticks.cpp >> >> I have also updated some of the existing event based tracing "event >> sites" to employ usage of these new types as well as updated a few >> places in the event based tracing framework implementation to >> accommodate these types. >> >> *Testing completed:* >> >> nsk.stress.testlist (UTE/Aurora) >> >> GC nightlies (Aurora) >> >> gc/gctests/* (UTE/Aurora) >> >> nsk.gc.testlist (UTE/Aurora) >> >> SpecJBB2013 (no regression) >> >> SpecJBB2005 (no regression) >> >> Kitchensink (locally Windows) runs for +> 9 days (still running.) >> >> Thanks in advance >> Markus >> From mattias.tobiasson at oracle.com Thu Nov 21 00:22:11 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Thu, 21 Nov 2013 00:22:11 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: I agree that merging both files in a single file may be good. The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. Mattias ----- Original Message ----- From: mikael.auno at oracle.com To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently How about defining the class that you want to attach to as a static inner class to the actual test? That would give you only one file, but with two classes, each with its own main method and clear correlation between them. Mikael On 2013-11-20 15:41, Mattias Tobiasson wrote: > Hi, > Each test requires 2 files, the actual test code and a helper file. > > The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. > > For example: > PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java > PermissionTest.java: The actual test code that attaches to the Application. > > It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). > > When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. > > I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. > > I used these names: > TestPermission.java: Helper file. > TestPermissionImpl.java: Actual test code. > > I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. > > Mattias > > > ----- Original Message ----- > From: Alan.Bateman at oracle.com > To: mattias.tobiasson at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > > Out of curiosity, what is the reason for the rename? I ask because we > use Basic and similar names in many areas. Also anything in the test > tree should be a test. > > -Alan. > > On 20/11/2013 13:47, Mattias Tobiasson wrote: >> Hi, >> Could you please review this fix. >> >> Summary of changes: >> >> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >> >> 2. Ported the following bash scripts to java: >> BasicTests.sh -> TestBasic.java >> PermissionTests.sh -> TestPermission.java >> ProviderTests.sh -> TestProvider.java >> >> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >> BasicsTest.java -> TestBasicImpl.java >> PermissionTest.java -> TestPermissionImpl.java >> ProviderTest.java -> TestProviderImpl.java >> >> 4. Added some utility functions to jdk/testlibrary. >> >> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >> >> >> Thanks, >> Mattias >> >> Webrev: >> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6461635 > From markus.gronlund at oracle.com Thu Nov 21 02:49:31 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Thu, 21 Nov 2013 02:49:31 -0800 (PST) Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: <528D3373.2080000@oracle.com> References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> <58a6b698-bf13-424a-9b95-deb676155b39@default> <528AC5A7.8070907@oracle.com> <583240ce-cf21-44d8-b1e9-4b53d547d6b9@default> <528D3373.2080000@oracle.com> Message-ID: Hi David, Thanks for taking a look again. Once transitioned from the external API boundary, TracingTime is/can be used internally in the tracing framework. I would like to keep this possibility, so I will leave it in. I will considered this Reviewed if you don't disagree then? Many thanks for your help again Cheers Markus -----Original Message----- From: David Holmes Sent: den 20 november 2013 23:11 To: Markus Gronlund Cc: serviceability-dev; hotspot-gc-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net Subject: Re: RFR(M): 8028128: Add a type safe alternative for working with counter based data Hi Markus, I couldn't quite work out if TracingTime is obsolete after these changes? Otherwise I have no further comments. Thanks, David On 20/11/2013 10:17 PM, Markus Gronlund wrote: > Hi again, > > I have created an updated webrev02 for the feedback I have gotten so far. In addition, I have added a few improvements to the original suggestion. > > Updated Webrev02: > http://cr.openjdk.java.net/~mgronlun/8028128/webrev02/ > Original Webrev01: > http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 > > Thanks a lot for your help/patience in reviewing this large change - very much appreciated. > > Cheers > Markus > > Description of deltas/updates to Webrev02 compared to Webrev01: > > // updates based on feedback > > utilities/ticks.inline.hpp > > // removed functions comparing against jlong(s) > > - #63 inline bool operator==(const Ticks& lhs, jlong compare_value) { > - #64 return lhs.value() == compare_value; > - #65 } > > - #89 inline bool operator!=(const Ticks& lhs, jlong compare_value) { > - #90 return lhs.value() != compare_value; > - #91 } > > // updated to gt signs for operator<= functions > - #52 return !operator<(lhs, rhs); > + #52 return !operator >(lhs, rhs); > > - #98 return !operator<(lhs,rhs); > + #98 return !operator>(lhs,rhs); > > // thanks to Vitaly Davidovich. > > > share/vm/gc_implementation/gcTimer.hpp > > // removed default parameter for report_gc_phase_* functions > > - #114 void report_gc_phase_start(const char* name, const Ticks& time > = Ticks::now()); > + #114 void report_gc_phase_start(const char* name, const Ticks& > + time); > > - #115 void report_gc_phase_end(const Ticks& time = Ticks::now()); > + #115 void report_gc_phase_end(const Ticks& time); > > - #145 void register_gc_phase_start(const char* name, const Ticks& > time = Ticks::now()); > + #145 void register_gc_phase_start(const char* name, const Ticks& > + time); > > - #146 void register_gc_phase_end(const Ticks& time = Ticks::now()); > + #146 void register_gc_phase_end(const Ticks& time); > > // thanks to Per Liden. > > > // > // > // > // Additional changes compared to webrev01 (delta) // > > webrev01 still allows a user to pass in a jlong (knowingly and/or unknowingly) for event.starttime() and event.endtime(). > For example: > > event.set_endtime(os::elapsed_counter()); // direct call using > os::elapsed_counter() > > This can be avoided by increasing encapsulation: > > src/share/vm/trace/traceEvent.hpp: > > set_starttime(const TracingTime& time) // remove default parameter and make protected > set_endtime(const TracingTime& time) // remove default parameter and make protected > > Now, the only visible external API for setting the start and/or endtime of an event is by passing a "Ticks" type (a compiler enforced constraint): > > Using the same example as above, now if attempting to pass a jlong, like a direct call using os::elapsed_counter(), this now yields (at compile time): > >> ..\..\src\share\vm\gc_implementation\shared\gcTraceSend.cpp(63): error C2248: 'TraceEvent::set_endtime' : cannot access protected member declared in class 'TraceEvent' > > > In order to make these functions protected, i have also had to update the class loader events in SystemDictionary and ClassLoaderDataGraph: > > share/vm/classfile/SystemDictionary.hpp: > > // remove include file: > - #34 #include "trace/traceTime.hpp" > > + #80 forward declare class Ticks; > > > // update the signature > - #640 static void post_class_load_event(const TracingTime& start_time, instanceKlassHandle k, > Handle initiating_loader); > > + #640 static void post_class_load_event(const Ticks& start_time, > + instanceKlassHandle k, > Handle initiating_loader); > > > > share/vm/classfile/SystemDictionary.cpp: > > // added include files > +#58 #include "utilities/macros.hpp" > +#59 #include "utilities/ticks.hpp" > > // removed old include file: > - #61 #include "trace/traceMacros.hpp" > > // updated type > - #601 TracingTime class_load_start_time = Tracing::time(); > + #601 Ticks class_load_start_time = Ticks::now(); > > // updated type > - #1009 TracingTime class_load_start_time = Tracing::time(); > + #1009 Ticks class_load_start_time = Ticks::now(); > > // updated signature > - #2668 void SystemDictionary::post_class_load_event(TracingTime > start_time, instanceKlassHandle k, Handle initiating_loader) > + #2668 void SystemDictionary::post_class_load_event(const Ticks& > + start_time, instanceKlassHandle k, Handle initiating_loader) > > // removed setting the endtime > - #2674 event.set_endtime(Tracing::time()); > > > src/share/vm/classfile/classLoaderData.hpp: > > // update include > - #36 #include "trace/traceTime.hpp" > + #36 #include "utilities/ticks.hpp" > > // updated type for _class_unload_time; > - #101 static TracingTime _class_unload_time; > + #101 static Ticks _class_unload_time; > > > src/share/vm/classfile/classLoaderData.cpp: > > + #65 #include "utilities/macros.hpp" > > // updated timestamp > - #757 _class_unload_time = Tracing::time(); > + #757 _class_unload_time = Ticks::now(); > > // updated type definition > - #835 TracingTime ClassLoaderDataGraph::_class_unload_time; > + #835 Ticks ClassLoaderDataGraph::_class_unload_time; > > > src/share/vm/trace/traceEventClasses.xls: > > // update the !INCLUDE_TRACE stubs > - #59 void set_starttime(jlong time) const {} > - #60 void set_endtime(jlong time) const {} > > + #59 void set_starttime(const Ticks& time) {} > + #59 void set_endtime(const Ticks& time) {} > > > Thanks > Markus > > > >> >> Greetings, >> >> Kindly asking for reviews for the following changeset: >> >> Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 >> >> *Description:* >> >> Currently, when working with counter based data, the primary data >> type representation in the VM are raw jlong's. jlong's are employed >> to represent both: >> >> 1. a single instance in time, for example a "now" timestamp 2. a time >> duration, a timespan, for example the duration between "now" - "then" >> >> Having a raw jlong type represent both of these shifts the >> responsibility to the programmer to always ensure the correct >> validity of the counter data, without any assistance either at >> compile time or at runtime. >> >> The event based tracing framework relies heavily on counter based >> data in order to keep track of time and timing related information >> and we have seen counter data errors where the representation sent to >> the tracing framework has submitted the wrong time, i.e. a timespan >> when a time instant was expected and vice versa. >> >> We should therefore add an alternative to jlongs for representing >> counter based data. We should enlist the help of the type system to >> enforce the correct data types at compile time as well as introduce >> strong runtime asserts in order to help with the correct usage of >> time and to reduce the number of potential bugs. >> >> I will therefore add two new types in src/share/vm/utilities: >> >> 1. "Ticks" - represents a single counter based timestamp, a single >> instance in time. >> 2. "Tickspan" - represents a counter based duration, a timespan, >> between two "Ticks" >> >> Please see the added files: >> >> -src/share/vm/utilities/ticks.hpp >> >> -src/share/vm/utilities/ticks.inline.hpp >> >> -src/share/vm/utilities/ticks.cpp >> >> I have also updated some of the existing event based tracing "event >> sites" to employ usage of these new types as well as updated a few >> places in the event based tracing framework implementation to >> accommodate these types. >> >> *Testing completed:* >> >> nsk.stress.testlist (UTE/Aurora) >> >> GC nightlies (Aurora) >> >> gc/gctests/* (UTE/Aurora) >> >> nsk.gc.testlist (UTE/Aurora) >> >> SpecJBB2013 (no regression) >> >> SpecJBB2005 (no regression) >> >> Kitchensink (locally Windows) runs for +> 9 days (still running.) >> >> Thanks in advance >> Markus >> From jaroslav.bachorik at oracle.com Thu Nov 21 03:00:37 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 21 Nov 2013 12:00:37 +0100 Subject: Review request for 7195249: Some jtreg tests use hard coded ports In-Reply-To: <528CF39B.3060607@oracle.com> References: <528CA2DC.5000700@oracle.com> <528CB355.60104@oracle.com> <528CD7FE.3010401@oracle.com> <528CF39B.3060607@oracle.com> Message-ID: <528DE7D5.70802@oracle.com> On 20.11.2013 18:38, Dmitry Samersoff wrote: > Roger, > > As soon as we close a socket nobody can guarantee that the port is free. > > Moreover, port returned by getFreePort()[1] remains not accessible for > some time - it depends to system setup, take a look to discussions > around SO_REUSEPORT for Linux or SO_REUSEADDR and SO_LINGER for BSD. > > So from stability point of view it's better to just return random number > between 49152 and 65535. Well, this doesn't seem to improve the odds by much. When there are more tests run in parallel, all of them requiring a free port, nothing prevents the random function to return the same port to all of them. Also, two subsequent requests can return the same port and cause problems with timing when a port used by a previous test is not fully ready to be assigned to a different socket. And as Dmitry pointed out unless one can keep hold of the allocated socket and use it later there is no guarantee that a port which was tested unallocated will remain unallocated also for the next few milliseconds. The only fail proof solution would be a port allocating service provided by the harness. Until then we can only (hopefully) decrease the chance of intermittent failures due to a port being in use. -JB- > > -Dmitry > > > [1] > > 141 public static int getFreePort() throws InterruptedException, > IOException { > 142 int port = -1; > 143 > 144 while (port <= 0) { > 145 Thread.sleep(100); > 146 > 147 ServerSocket serverSocket = null; > 148 try { > 149 serverSocket = new ServerSocket(0); > 150 port = serverSocket.getLocalPort(); > 151 } finally { > 152 serverSocket.close(); > 153 } > 154 } > 155 > 156 return port; > 157 } > 158 > > > On 2013-11-20 19:40, roger riggs wrote: >> Hi, >> >> fyi, The jdk.testlibrary.Utils.getFreePort() method will Open an free >> Socket, close it and return >> the port number. >> >> And as Alan recommended, use (0) when possible to have the system assign >> the port #. >> >> Roger >> >> On 11/20/2013 8:04 AM, Dmitry Samersoff wrote: >>> Taras, >>> >>> *The only* correct way to take really free port is: >>> >>> 1. Chose random number between 49152 and 65535 >>> 2. Open socket >>> >>> if socket fails - repeat step 1 >>> if socket OK - return *socket* >>> >>> >>> If you can't keep the socket open (e.g. you have to pass port number as >>> property value) you shouldn't do any pre-check as it has no value - as >>> as soon as you close socket someone can take the port. >>> >>> So just choose a random number within the range above and let networking >>> code opening socket to handle port conflict. >>> >>> -Dmitry >>> >>> >>> >>> On 2013-11-20 15:54, taras ledkov wrote: >>>> Hi Everyone, >>>> >>>> I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. >>>> >>>> There are two webrevs: >>>> Webrev for jdk part: >>>> http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.00/ >>>> >>>> Webrev for hs part: >>>> http://cr.openjdk.java.net/~anazarov/7195249/hs/webrev.00/ >>>> >>>> Please take a look at some notes: >>>> - After discussing with Yekaterina Kantserova & Jaroslav Bachorik some >>>> shell tests have been converted to java based tests >>>> >>>> - PasswordFilePermissionTest & SSLConfigFilePermissionTest tests looked >>>> very similar, so a common parent class was created for them: >>>> AbstractFilePermissionTest >>>> >>>> - What was called RmiRegistrySslTest.java I've renamed to >>>> RmiRegistrySslTestApp.java. The java code to replace old shell script >>>> RmiRegistrySslTest.sh is called RmiRegistrySslTest.java, hence the huge >>>> diff. >>>> >>>> - The new RmiRegistrySslTest.java has some lines similar to the >>>> AbstractFilePermissionTest.java, I nevertheless decided to not >>>> complicate the code further and leave it as is. Please let me know if >>>> this is somehow not acceptable >>>> >>>> - com/oracle/java/testlibrary/Utils.java that is added to hotspot >>>> repository is taken from this patch: >>>> http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html >>>> >>>> >>>> >>>> - These tests will need additional changes when test library process >>>> tools will support command line options inheritance >>>> (http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-November/013235.html) >>>> >>>> >>>> >>> >> > > From erik.gahlin at oracle.com Thu Nov 21 03:41:32 2013 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 21 Nov 2013 12:41:32 +0100 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528CA050.8000805@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528C9C3A.4020608@oracle.com> <528CA050.8000805@oracle.com> Message-ID: <528DF16C.7080409@oracle.com> Thanks, didn't know about ATOMIC_MOVE. it will be useful for other tests as well. http://cr.openjdk.java.net/~egahlin/6402201_3/ Erik Alan Bateman skrev 2013-11-20 12:43: > On 20/11/2013 11:25, Erik Gahlin wrote: >> Thanks for your feedback >> >> Here is an updated webrev where the file is renamed. >> http://cr.openjdk.java.net/~egahlin/6402201_2/ > That looks okay to me. One small improvement would be to use > try-with-resources around the file write. Alternatively you could use > Files.write and do it in one method call (which would get you using > the new file system API and then you could use Files.move and specific > the ATOMIC_MOVE option). It's not strictly required for this and what > you have seems to fix the reported issue. > > -Alan From Alan.Bateman at oracle.com Thu Nov 21 04:01:31 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 21 Nov 2013 12:01:31 +0000 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <528DF61B.6060403@oracle.com> On 20/11/2013 18:26, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files > to build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). > The biggest change compared to the first review round is the new > "aix/" subdirectory which I've now created under "jdk/src" and which > contains AIX-only code. Thanks for the update and addressing all the original comments and suggestions. In particular, moving most of the AIX specific files to src/aix and including an implementation of dladdr, make a big difference and makes this much easier to review. I've skimmed through all the non-client files in the webrev and just have a few comments: NetworkLibraries.gmk - is the exclude of bsd_close.c right? It looks like it will add this to LIBNET_EXCLUDE_FILES even when building on Mac. In the old verifier code (check_code.c) then it's not clear to me that the caller wrapper is needed but in any case the change suggests to me that we should look at the malloc usages so that they better handle the size==0 case. I realize the wrappers are to avoid changing too much and it should be okay to handle this via a separate bug. In net_util.c then it's a bit ugly to be calling aix_close_init. Michael/Chris - what you would think about the JNI_OnLoad calling into a platform specific function to do platform specific initialization? The changes to java_md_solinux.c look okay to me but it makes me wonder if this should be renamed as it no longer exclusively Solaris + Linux. Port.java - one suggestion for unregisterImpl is to rename it to preUnregister and change it to protected so that it's more obvious that it supposed to be overridden. UnixNativeDispatcher.c - this looks okay (must reduced since the first round), I just wonder if the changes to *_getpwuid and *_getgrgid are really needed as this just impacts the error message. Also might be good to indent the #ifdef to be consistent with the other usages in these functions. That's mostly it. I notice that only a small number of tests have been updated. Are there more test updates to come? I'm pretty sure we have a lot more tests that may require update (searching for SunOS might give some hints). -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131121/62f03fbc/attachment.html From Alan.Bateman at oracle.com Thu Nov 21 04:07:28 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 21 Nov 2013 12:07:28 +0000 Subject: RFR: 6402201: ProcessAttachTest.sh needs better synchronization In-Reply-To: <528DF16C.7080409@oracle.com> References: <528AA2C3.7090505@oracle.com> <528B252F.2020105@oracle.com> <528C9C3A.4020608@oracle.com> <528CA050.8000805@oracle.com> <528DF16C.7080409@oracle.com> Message-ID: <528DF780.5020307@oracle.com> On 21/11/2013 11:41, Erik Gahlin wrote: > Thanks, didn't know about ATOMIC_MOVE. it will be useful for other > tests as well. > > http://cr.openjdk.java.net/~egahlin/6402201_3/ > > Erik This looks very good. -Alan. From erik.gahlin at oracle.com Thu Nov 21 04:46:40 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Thu, 21 Nov 2013 12:46:40 +0000 Subject: hg: jdk8/tl/jdk: 6402201: ProcessAttachTest.sh needs better synchronization Message-ID: <20131121124655.9331D62737@hg.openjdk.java.net> Changeset: 91ec3bc92793 Author: egahlin Date: 2013-11-21 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91ec3bc92793 6402201: ProcessAttachTest.sh needs better synchronization Reviewed-by: alanb ! test/ProblemList.txt ! test/com/sun/jdi/ProcessAttachDebuggee.java ! test/com/sun/jdi/ProcessAttachTest.sh From piotr at bzdyl.net Thu Nov 21 05:06:39 2013 From: piotr at bzdyl.net (Piotr Bzdyl) Date: Thu, 21 Nov 2013 14:06:39 +0100 Subject: jstack and the target output Message-ID: Hello, I wasn't sure which OpenJDK mailing list I should choose for my question. As I have issues with jstack SA related group seemed the best place. I have the following issue: On console one (let's call it pts/1) I start a sample java app (let's say its pid is 1234). On another console (pts/2) I execute: jstack 1234 As a result pts/2 displays: 1234: Unable to open socket file: target process not responding or HotSpot VM not loaded The -F option can be used when the target process is not responding And on pts/1 I see the thread dump printed. I would rather expect that the thread dump will be displayed on pts/2 and nothing will be printed to pts/1. I tried to use different versions of OpenJDK but the result was always the same. Could you provide me any hints what might be wrong? Best regards, Piotr -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131121/4c06e633/attachment-0001.html From Alan.Bateman at oracle.com Thu Nov 21 05:14:54 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 21 Nov 2013 13:14:54 +0000 Subject: jstack and the target output In-Reply-To: References: Message-ID: <528E074E.8020709@oracle.com> On 21/11/2013 13:06, Piotr Bzdyl wrote: > Hello, > > I wasn't sure which OpenJDK mailing list I should choose for my > question. As I have issues with jstack SA related group seemed the > best place. > > I have the following issue: > > On console one (let's call it pts/1) I start a sample java app (let's > say its pid is 1234). On another console (pts/2) I execute: > > jstack 1234 > > As a result pts/2 displays: > 1234: Unable to open socket file: target process not responding or > HotSpot VM not loaded > The -F option can be used when the target process is not responding > > And on pts/1 I see the thread dump printed. I would rather expect that > the thread dump will be displayed on pts/2 and nothing will be printed > to pts/1. I tried to use different versions of OpenJDK but the result > was always the same. > > Could you provide me any hints what might be wrong? > > Best regards, > Piotr Are pts/1 and pts/2 the same user? Alternatively, any special options to the target VM that disables the attach mechanism? In any case, I suspect the reason that pts/1 is print the stack trace is that the mechanism to start the attach mechanism in the target VM requires signalling the target VM with SIGQUIT, the same signal that is used to get a VM to do a thread dump to its own stdout. -Alan From staffan.larsen at oracle.com Thu Nov 21 05:26:06 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 21 Nov 2013 13:26:06 +0000 Subject: hg: jdk8/tl/jdk: 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423 Message-ID: <20131121132618.AEF2B6273A@hg.openjdk.java.net> Changeset: fc9f24b9408e Author: sla Date: 2013-11-21 12:57 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc9f24b9408e 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423 Summary: Removed 5 testcases from the ProblemList Reviewed-by: sla Contributed-by: balchandra.vaidya at oracle.com ! test/ProblemList.txt From piotr at bzdyl.net Thu Nov 21 05:30:17 2013 From: piotr at bzdyl.net (Piotr Bzdyl) Date: Thu, 21 Nov 2013 14:30:17 +0100 Subject: jstack and the target output In-Reply-To: <528E074E.8020709@oracle.com> References: <528E074E.8020709@oracle.com> Message-ID: Both (java and jstack) are started using the same user. It happens on some systems and if it happens it does with all java versions I checked (java 7 & java 8). On systems where ptrace_scope is available it is set to 0. Best regards, Piotr On Thu, Nov 21, 2013 at 2:14 PM, Alan Bateman wrote: > On 21/11/2013 13:06, Piotr Bzdyl wrote: > >> Hello, >> >> I wasn't sure which OpenJDK mailing list I should choose for my question. >> As I have issues with jstack SA related group seemed the best place. >> >> I have the following issue: >> >> On console one (let's call it pts/1) I start a sample java app (let's say >> its pid is 1234). On another console (pts/2) I execute: >> >> jstack 1234 >> >> As a result pts/2 displays: >> 1234: Unable to open socket file: target process not responding or >> HotSpot VM not loaded >> The -F option can be used when the target process is not responding >> >> And on pts/1 I see the thread dump printed. I would rather expect that >> the thread dump will be displayed on pts/2 and nothing will be printed to >> pts/1. I tried to use different versions of OpenJDK but the result was >> always the same. >> >> Could you provide me any hints what might be wrong? >> >> Best regards, >> Piotr >> > Are pts/1 and pts/2 the same user? Alternatively, any special options to > the target VM that disables the attach mechanism? > > In any case, I suspect the reason that pts/1 is print the stack trace is > that the mechanism to start the attach mechanism in the target VM requires > signalling the target VM with SIGQUIT, the same signal that is used to get > a VM to do a thread dump to its own stdout. > > -Alan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131121/96607792/attachment.html From staffan.larsen at oracle.com Thu Nov 21 05:42:33 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 21 Nov 2013 14:42:33 +0100 Subject: jstack and the target output In-Reply-To: <528E074E.8020709@oracle.com> References: <528E074E.8020709@oracle.com> Message-ID: <1B50BB6A-40E0-4E59-B469-49C545C7FF82@oracle.com> It could also be that one of the processes do not have access to /tmp (or that it is mapped differently). /Staffan On 21 nov 2013, at 14:14, Alan Bateman wrote: > On 21/11/2013 13:06, Piotr Bzdyl wrote: >> Hello, >> >> I wasn't sure which OpenJDK mailing list I should choose for my question. As I have issues with jstack SA related group seemed the best place. >> >> I have the following issue: >> >> On console one (let's call it pts/1) I start a sample java app (let's say its pid is 1234). On another console (pts/2) I execute: >> >> jstack 1234 >> >> As a result pts/2 displays: >> 1234: Unable to open socket file: target process not responding or HotSpot VM not loaded >> The -F option can be used when the target process is not responding >> >> And on pts/1 I see the thread dump printed. I would rather expect that the thread dump will be displayed on pts/2 and nothing will be printed to pts/1. I tried to use different versions of OpenJDK but the result was always the same. >> >> Could you provide me any hints what might be wrong? >> >> Best regards, >> Piotr > Are pts/1 and pts/2 the same user? Alternatively, any special options to the target VM that disables the attach mechanism? > > In any case, I suspect the reason that pts/1 is print the stack trace is that the mechanism to start the attach mechanism in the target VM requires signalling the target VM with SIGQUIT, the same signal that is used to get a VM to do a thread dump to its own stdout. > > -Alan From chris.hegarty at oracle.com Thu Nov 21 05:44:33 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 21 Nov 2013 13:44:33 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131121134510.833B16273B@hg.openjdk.java.net> Changeset: 2972241cf7eb Author: tyan Date: 2013-11-21 13:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2972241cf7eb 7036666: test/com/sun/net/httpserver/Test9a.java fails intermittently Summary: Additional stacktrace information is printed on failure Reviewed-by: alanb, dfuchs, chegar ! test/ProblemList.txt ! test/com/sun/net/httpserver/Test9a.java Changeset: ed979f9b40cd Author: tyan Date: 2013-11-21 13:42 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ed979f9b40cd 8022212: Intermittent test failures in java/net Reviewed-by: chegar ! test/java/net/NetworkInterface/IndexTest.java From piotr at bzdyl.net Thu Nov 21 05:47:01 2013 From: piotr at bzdyl.net (Piotr Bzdyl) Date: Thu, 21 Nov 2013 14:47:01 +0100 Subject: jstack and the target output In-Reply-To: <1B50BB6A-40E0-4E59-B469-49C545C7FF82@oracle.com> References: <528E074E.8020709@oracle.com> <1B50BB6A-40E0-4E59-B469-49C545C7FF82@oracle.com> Message-ID: I recreated this problem in RedHat 6.4 installed in a virtual machine where I login as the same user on tty1 and tty2 - the setup for tmp is the same. I also tried with VM running Fedora 19 with 2 terminal windows in the X session. I tried to read files from /tmp/hsperfdata_$username/* from the terminal where I run jstack and I was able to read files (named after java processes pids). On Thu, Nov 21, 2013 at 2:42 PM, Staffan Larsen wrote: > It could also be that one of the processes do not have access to /tmp (or > that it is mapped differently). > > /Staffan > > On 21 nov 2013, at 14:14, Alan Bateman wrote: > > > On 21/11/2013 13:06, Piotr Bzdyl wrote: > >> Hello, > >> > >> I wasn't sure which OpenJDK mailing list I should choose for my > question. As I have issues with jstack SA related group seemed the best > place. > >> > >> I have the following issue: > >> > >> On console one (let's call it pts/1) I start a sample java app (let's > say its pid is 1234). On another console (pts/2) I execute: > >> > >> jstack 1234 > >> > >> As a result pts/2 displays: > >> 1234: Unable to open socket file: target process not responding or > HotSpot VM not loaded > >> The -F option can be used when the target process is not responding > >> > >> And on pts/1 I see the thread dump printed. I would rather expect that > the thread dump will be displayed on pts/2 and nothing will be printed to > pts/1. I tried to use different versions of OpenJDK but the result was > always the same. > >> > >> Could you provide me any hints what might be wrong? > >> > >> Best regards, > >> Piotr > > Are pts/1 and pts/2 the same user? Alternatively, any special options to > the target VM that disables the attach mechanism? > > > > In any case, I suspect the reason that pts/1 is print the stack trace is > that the mechanism to start the attach mechanism in the target VM requires > signalling the target VM with SIGQUIT, the same signal that is used to get > a VM to do a thread dump to its own stdout. > > > > -Alan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131121/56fba5f1/attachment.html From david.holmes at oracle.com Thu Nov 21 05:57:00 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 21 Nov 2013 23:57:00 +1000 Subject: RFR(M): 8028128: Add a type safe alternative for working with counter based data In-Reply-To: References: <061fa021-3b40-4161-aecd-a946c0ddde3e@default> <68fcba7b-b6a6-47f7-a785-2eba9a2631e5@default> <58a6b698-bf13-424a-9b95-deb676155b39@default> <528AC5A7.8070907@oracle.com> <583240ce-cf21-44d8-b1e9-4b53d547d6b9@default> <528D3373.2080000@oracle.com> Message-ID: <528E112C.5050406@oracle.com> On 21/11/2013 8:49 PM, Markus Gronlund wrote: > Hi David, > > Thanks for taking a look again. > > Once transitioned from the external API boundary, TracingTime is/can be used internally in the tracing framework. > I would like to keep this possibility, so I will leave it in. Ok. > I will considered this Reviewed if you don't disagree then? Yes. > Many thanks for your help again > You are welcome. :) David > Cheers > Markus > > > > -----Original Message----- > From: David Holmes > Sent: den 20 november 2013 23:11 > To: Markus Gronlund > Cc: serviceability-dev; hotspot-gc-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net > Subject: Re: RFR(M): 8028128: Add a type safe alternative for working with counter based data > > Hi Markus, > > I couldn't quite work out if TracingTime is obsolete after these changes? > > Otherwise I have no further comments. > > Thanks, > David > > On 20/11/2013 10:17 PM, Markus Gronlund wrote: >> Hi again, >> >> I have created an updated webrev02 for the feedback I have gotten so far. In addition, I have added a few improvements to the original suggestion. >> >> Updated Webrev02: >> http://cr.openjdk.java.net/~mgronlun/8028128/webrev02/ >> Original Webrev01: >> http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ >> Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 >> >> Thanks a lot for your help/patience in reviewing this large change - very much appreciated. >> >> Cheers >> Markus >> >> Description of deltas/updates to Webrev02 compared to Webrev01: >> >> // updates based on feedback >> >> utilities/ticks.inline.hpp >> >> // removed functions comparing against jlong(s) >> >> - #63 inline bool operator==(const Ticks& lhs, jlong compare_value) { >> - #64 return lhs.value() == compare_value; >> - #65 } >> >> - #89 inline bool operator!=(const Ticks& lhs, jlong compare_value) { >> - #90 return lhs.value() != compare_value; >> - #91 } >> >> // updated to gt signs for operator<= functions >> - #52 return !operator<(lhs, rhs); >> + #52 return !operator >(lhs, rhs); >> >> - #98 return !operator<(lhs,rhs); >> + #98 return !operator>(lhs,rhs); >> >> // thanks to Vitaly Davidovich. >> >> >> share/vm/gc_implementation/gcTimer.hpp >> >> // removed default parameter for report_gc_phase_* functions >> >> - #114 void report_gc_phase_start(const char* name, const Ticks& time >> = Ticks::now()); >> + #114 void report_gc_phase_start(const char* name, const Ticks& >> + time); >> >> - #115 void report_gc_phase_end(const Ticks& time = Ticks::now()); >> + #115 void report_gc_phase_end(const Ticks& time); >> >> - #145 void register_gc_phase_start(const char* name, const Ticks& >> time = Ticks::now()); >> + #145 void register_gc_phase_start(const char* name, const Ticks& >> + time); >> >> - #146 void register_gc_phase_end(const Ticks& time = Ticks::now()); >> + #146 void register_gc_phase_end(const Ticks& time); >> >> // thanks to Per Liden. >> >> >> // >> // >> // >> // Additional changes compared to webrev01 (delta) // >> >> webrev01 still allows a user to pass in a jlong (knowingly and/or unknowingly) for event.starttime() and event.endtime(). >> For example: >> >> event.set_endtime(os::elapsed_counter()); // direct call using >> os::elapsed_counter() >> >> This can be avoided by increasing encapsulation: >> >> src/share/vm/trace/traceEvent.hpp: >> >> set_starttime(const TracingTime& time) // remove default parameter and make protected >> set_endtime(const TracingTime& time) // remove default parameter and make protected >> >> Now, the only visible external API for setting the start and/or endtime of an event is by passing a "Ticks" type (a compiler enforced constraint): >> >> Using the same example as above, now if attempting to pass a jlong, like a direct call using os::elapsed_counter(), this now yields (at compile time): >> >>> ..\..\src\share\vm\gc_implementation\shared\gcTraceSend.cpp(63): error C2248: 'TraceEvent::set_endtime' : cannot access protected member declared in class 'TraceEvent' >> >> >> In order to make these functions protected, i have also had to update the class loader events in SystemDictionary and ClassLoaderDataGraph: >> >> share/vm/classfile/SystemDictionary.hpp: >> >> // remove include file: >> - #34 #include "trace/traceTime.hpp" >> >> + #80 forward declare class Ticks; >> >> >> // update the signature >> - #640 static void post_class_load_event(const TracingTime& start_time, instanceKlassHandle k, >> Handle initiating_loader); >> >> + #640 static void post_class_load_event(const Ticks& start_time, >> + instanceKlassHandle k, >> Handle initiating_loader); >> >> >> >> share/vm/classfile/SystemDictionary.cpp: >> >> // added include files >> +#58 #include "utilities/macros.hpp" >> +#59 #include "utilities/ticks.hpp" >> >> // removed old include file: >> - #61 #include "trace/traceMacros.hpp" >> >> // updated type >> - #601 TracingTime class_load_start_time = Tracing::time(); >> + #601 Ticks class_load_start_time = Ticks::now(); >> >> // updated type >> - #1009 TracingTime class_load_start_time = Tracing::time(); >> + #1009 Ticks class_load_start_time = Ticks::now(); >> >> // updated signature >> - #2668 void SystemDictionary::post_class_load_event(TracingTime >> start_time, instanceKlassHandle k, Handle initiating_loader) >> + #2668 void SystemDictionary::post_class_load_event(const Ticks& >> + start_time, instanceKlassHandle k, Handle initiating_loader) >> >> // removed setting the endtime >> - #2674 event.set_endtime(Tracing::time()); >> >> >> src/share/vm/classfile/classLoaderData.hpp: >> >> // update include >> - #36 #include "trace/traceTime.hpp" >> + #36 #include "utilities/ticks.hpp" >> >> // updated type for _class_unload_time; >> - #101 static TracingTime _class_unload_time; >> + #101 static Ticks _class_unload_time; >> >> >> src/share/vm/classfile/classLoaderData.cpp: >> >> + #65 #include "utilities/macros.hpp" >> >> // updated timestamp >> - #757 _class_unload_time = Tracing::time(); >> + #757 _class_unload_time = Ticks::now(); >> >> // updated type definition >> - #835 TracingTime ClassLoaderDataGraph::_class_unload_time; >> + #835 Ticks ClassLoaderDataGraph::_class_unload_time; >> >> >> src/share/vm/trace/traceEventClasses.xls: >> >> // update the !INCLUDE_TRACE stubs >> - #59 void set_starttime(jlong time) const {} >> - #60 void set_endtime(jlong time) const {} >> >> + #59 void set_starttime(const Ticks& time) {} >> + #59 void set_endtime(const Ticks& time) {} >> >> >> Thanks >> Markus >> >> >> >>> >>> Greetings, >>> >>> Kindly asking for reviews for the following changeset: >>> >>> Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/ >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028128 >>> >>> *Description:* >>> >>> Currently, when working with counter based data, the primary data >>> type representation in the VM are raw jlong's. jlong's are employed >>> to represent both: >>> >>> 1. a single instance in time, for example a "now" timestamp 2. a time >>> duration, a timespan, for example the duration between "now" - "then" >>> >>> Having a raw jlong type represent both of these shifts the >>> responsibility to the programmer to always ensure the correct >>> validity of the counter data, without any assistance either at >>> compile time or at runtime. >>> >>> The event based tracing framework relies heavily on counter based >>> data in order to keep track of time and timing related information >>> and we have seen counter data errors where the representation sent to >>> the tracing framework has submitted the wrong time, i.e. a timespan >>> when a time instant was expected and vice versa. >>> >>> We should therefore add an alternative to jlongs for representing >>> counter based data. We should enlist the help of the type system to >>> enforce the correct data types at compile time as well as introduce >>> strong runtime asserts in order to help with the correct usage of >>> time and to reduce the number of potential bugs. >>> >>> I will therefore add two new types in src/share/vm/utilities: >>> >>> 1. "Ticks" - represents a single counter based timestamp, a single >>> instance in time. >>> 2. "Tickspan" - represents a counter based duration, a timespan, >>> between two "Ticks" >>> >>> Please see the added files: >>> >>> -src/share/vm/utilities/ticks.hpp >>> >>> -src/share/vm/utilities/ticks.inline.hpp >>> >>> -src/share/vm/utilities/ticks.cpp >>> >>> I have also updated some of the existing event based tracing "event >>> sites" to employ usage of these new types as well as updated a few >>> places in the event based tracing framework implementation to >>> accommodate these types. >>> >>> *Testing completed:* >>> >>> nsk.stress.testlist (UTE/Aurora) >>> >>> GC nightlies (Aurora) >>> >>> gc/gctests/* (UTE/Aurora) >>> >>> nsk.gc.testlist (UTE/Aurora) >>> >>> SpecJBB2013 (no regression) >>> >>> SpecJBB2005 (no regression) >>> >>> Kitchensink (locally Windows) runs for +> 9 days (still running.) >>> >>> Thanks in advance >>> Markus >>> From david.holmes at oracle.com Thu Nov 21 06:47:21 2013 From: david.holmes at oracle.com (David Holmes) Date: Fri, 22 Nov 2013 00:47:21 +1000 Subject: jstack and the target output In-Reply-To: References: <528E074E.8020709@oracle.com> <1B50BB6A-40E0-4E59-B469-49C545C7FF82@oracle.com> Message-ID: <528E1CF9.1070002@oracle.com> On 21/11/2013 11:47 PM, Piotr Bzdyl wrote: > I recreated this problem in RedHat 6.4 installed in a virtual machine > where I login as the same user on tty1 and tty2 - the setup for tmp is > the same. I also tried with VM running Fedora 19 with 2 terminal windows > in the X session. I tried to read files from /tmp/hsperfdata_$username/* > from the terminal where I run jstack and I was able to read files (named > after java processes pids). I can recreate this using the minimal VM, which doesn't support libattach. So it definitely seems like something is going wrong in the attach process, but I can't say what. Not sure what debugging hooks we have for the attach mechanism ?? David ------ > > > On Thu, Nov 21, 2013 at 2:42 PM, Staffan Larsen > > wrote: > > It could also be that one of the processes do not have access to > /tmp (or that it is mapped differently). > > /Staffan > > On 21 nov 2013, at 14:14, Alan Bateman > wrote: > > > On 21/11/2013 13:06, Piotr Bzdyl wrote: > >> Hello, > >> > >> I wasn't sure which OpenJDK mailing list I should choose for my > question. As I have issues with jstack SA related group seemed the > best place. > >> > >> I have the following issue: > >> > >> On console one (let's call it pts/1) I start a sample java app > (let's say its pid is 1234). On another console (pts/2) I execute: > >> > >> jstack 1234 > >> > >> As a result pts/2 displays: > >> 1234: Unable to open socket file: target process not responding > or HotSpot VM not loaded > >> The -F option can be used when the target process is not responding > >> > >> And on pts/1 I see the thread dump printed. I would rather > expect that the thread dump will be displayed on pts/2 and nothing > will be printed to pts/1. I tried to use different versions of > OpenJDK but the result was always the same. > >> > >> Could you provide me any hints what might be wrong? > >> > >> Best regards, > >> Piotr > > Are pts/1 and pts/2 the same user? Alternatively, any special > options to the target VM that disables the attach mechanism? > > > > In any case, I suspect the reason that pts/1 is print the stack > trace is that the mechanism to start the attach mechanism in the > target VM requires signalling the target VM with SIGQUIT, the same > signal that is used to get a VM to do a thread dump to its own stdout. > > > > -Alan > > From yuri.nesterenko at oracle.com Mon Nov 18 05:01:09 2013 From: yuri.nesterenko at oracle.com (yuri.nesterenko at oracle.com) Date: Mon, 18 Nov 2013 13:01:09 +0000 Subject: hg: jdk8/tl/jdk: 8028049: Tidy warnings cleanup for packages java.nio/java.io Message-ID: <20131118130121.9329A62663@hg.openjdk.java.net> Changeset: 19ff80da8283 Author: yan Date: 2013-11-18 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19ff80da8283 8028049: Tidy warnings cleanup for packages java.nio/java.io Reviewed-by: alanb, darcy Contributed-by: Sergey Lugovoy ! src/share/classes/java/io/EOFException.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/package.html From mark.sheppard at oracle.com Thu Nov 21 03:35:13 2013 From: mark.sheppard at oracle.com (mark.sheppard at oracle.com) Date: Thu, 21 Nov 2013 11:35:13 +0000 Subject: hg: jdk8/tl/corba: 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Message-ID: <20131121113515.1971C62731@hg.openjdk.java.net> Changeset: fe781b3badd6 Author: msheppar Date: 2013-11-21 11:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/fe781b3badd6 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Summary: check for default ORBImpl and ORBSingleton set via properties or System properties Reviewed-by: alanb, coffeys, mchung ! src/share/classes/org/omg/CORBA/ORB.java From mark.sheppard at oracle.com Thu Nov 21 03:37:57 2013 From: mark.sheppard at oracle.com (mark.sheppard at oracle.com) Date: Thu, 21 Nov 2013 11:37:57 +0000 Subject: hg: jdk8/tl/jdk: 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Message-ID: <20131121113853.3C1B762732@hg.openjdk.java.net> Changeset: d5d4b9a63174 Author: msheppar Date: 2013-11-21 11:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5d4b9a63174 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Summary: check for default ORBImpl and ORBSingleton set via properties or System properties Reviewed-by: alanb, coffeys, mchung + test/com/sun/corba/se/impl/orb/SetDefaultORBTest.java From volker.simonis at gmail.com Thu Nov 21 07:54:07 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 21 Nov 2013 16:54:07 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <528DF61B.6060403@oracle.com> References: <528DF61B.6060403@oracle.com> Message-ID: Hi Alan, thanks a lot for the fast review and your valuable comments. Please find my answers inline: On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman wrote: > On 20/11/2013 18:26, Volker Simonis wrote: > > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > Thanks for the update and addressing all the original comments and > suggestions. In particular, moving most of the AIX specific files to > src/aix and including an implementation of dladdr, make a big difference > and makes this much easier to review. > > I've skimmed through all the non-client files in the webrev and just have > a few comments: > > NetworkLibraries.gmk - is the exclude of bsd_close.c right? It looks like > it will add this to LIBNET_EXCLUDE_FILES even when building on Mac. > > You're right, that's a typo. That should have read: 48 ifneq ($(OPENJDK_TARGET_OS), aix) 49 LIBNET_EXCLUDE_FILES += aix_close.c 50 else 51 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ 52 endif But actually I've just realized that it is not need at all, because 'aix_close.c' isn't in the PATH for any other OS than AIX (that could be probably called a feature of the new file layout:) So I'll simply change it to: 48 ifeq ($(OPENJDK_TARGET_OS), aix) 49 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ 50 endif In the old verifier code (check_code.c) then it's not clear to me that the > caller wrapper is needed but in any case the change suggests to me that we > should look at the malloc usages so that they better handle the size==0 > case. I realize the wrappers are to avoid changing too much and it should > be okay to handle this via a separate bug. > > Yes, exactly. I didn't wanted to change too much code. But as the C-Standard states ( http://pubs.opengroup.org/onlinepubs/000095399/functions/malloc.html) "...If size is 0, either a null pointer or a unique pointer that can be successfully passed to free() shall be returned..." it is perfectly legal that malloc/calloc return a NULL pointer if called with a zero argument. This case is currently not handled (i.e. it's handled as an 'out of memory' error) in check_code.c and I agree that this should be fixed via a separate bug. > In net_util.c then it's a bit ugly to be calling aix_close_init. > Michael/Chris - what you would think about the JNI_OnLoad calling into a > platform specific function to do platform specific initialization? > > What about renaming 'initLocalAddrTable()' into something like 'platformInit()' and moving the call to 'aix_close_init' to a AIX-specific version of 'platformInit()' in net_util_md.c? > The changes to java_md_solinux.c look okay to me but it makes me wonder if > this should be renamed as it no longer exclusively Solaris + Linux. > > You're right - we could rename it to something like 'java_md_unix.c'. But no matter how fancy the name would be, the file would still be in the 'src/solaris/bin' subdirectory:( So I think we'd better leave this for a later change when we completely factor out the Linux/Mac code from the 'solaris/' directory. > Port.java - one suggestion for unregisterImpl is to rename it to > preUnregister and change it to protected so that it's more obvious that it > supposed to be overridden. > > Done. Also changed the comment to JavaDoc style to be more consistent with the other comments in that file. > UnixNativeDispatcher.c - this looks okay (must reduced since the first > round), I just wonder if the changes to *_getpwuid and *_getgrgid are > really needed as this just impacts the error message. Also might be good to > indent the #ifdef to be consistent with the other usages in these functions. > > You're right. This change was done before you fixed "7043788: (fs) PosixFileAttributes.owner() or group() throws NPE if owner/group not in passwd/group database" ( http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f91c799f7bfb). After you're fix it was "automatically" adapted. I've removed the special AIX handling as suggested because I think as well that another error message in the exception won't have any impact. > That's mostly it. I notice that only a small number of tests have been > updated. Are there more test updates to come? I'm pretty sure we have a lot > more tests that may require update (searching for SunOS might give some > hints). > > I'm currently working on it and created "8028537: PPC64: Updated jdk/test scripts to understand the AIX os and environment" for it because I didn't wanted to blow up this change unnecessarily. -Alan. > > > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131121/c32891cb/attachment.html From rob.mckenna at oracle.com Thu Nov 21 08:08:17 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 21 Nov 2013 16:08:17 +0000 Subject: hg: jdk8/tl/jdk: 6703075: (process) java/lang/ProcessBuilder/Basic.java fails with fastdebug Message-ID: <20131121160829.C978862741@hg.openjdk.java.net> Changeset: 89fccc5a7469 Author: martin Date: 2013-11-21 16:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89fccc5a7469 6703075: (process) java/lang/ProcessBuilder/Basic.java fails with fastdebug Reviewed-by: alanb ! test/java/lang/ProcessBuilder/Basic.java From mandy.chung at oracle.com Thu Nov 21 08:51:34 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 21 Nov 2013 08:51:34 -0800 Subject: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS In-Reply-To: <528B7448.3090005@oracle.com> References: <528B7448.3090005@oracle.com> Message-ID: <528E3A16.6060401@oracle.com> Hi Jaroslav, On 11/19/2013 6:23 AM, Jaroslav Bachorik wrote: > Please, review this test fix. > > Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 > Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 > > The fix moves the execution of the test routine to the > GarbageCollectorMXBean notification handler - at that moment it's > certain that GC has already happened and it is safe to assert the data > provided by the MBean. This patch may have a potential issue when GC happens during the process of adding the notification handlers such as the number of increments is greater than the number of registered handlers. By the time the main thread reaches p.arriveAndAwaitAdvance, the phaser has advanced to the next phase with few arrived parties and will wait forever (until the next GC happens). This should rarely happen though. Note that p.arriveAndAwaitAdvance continue to run even if the thread is interrupted and what happens if jtreg attempts to time out the test? Does this issue only happen to CMS with background GC thread? The proposed patch seems a little overkill. I wonder if the test should skip if running in CMS background mode. Does -XX:+ExplicitGCInvokesConcurrent flag will get System.gc() to run in foreground mode in CMS (I think that may get the GC to complete before System.gc() returns?) Mandy From Alan.Bateman at oracle.com Thu Nov 21 10:18:16 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 21 Nov 2013 18:18:16 +0000 Subject: jstack and the target output In-Reply-To: <528E1CF9.1070002@oracle.com> References: <528E074E.8020709@oracle.com> <1B50BB6A-40E0-4E59-B469-49C545C7FF82@oracle.com> <528E1CF9.1070002@oracle.com> Message-ID: <528E4E68.1050403@oracle.com> On 21/11/2013 14:47, David Holmes wrote: > > I can recreate this using the minimal VM, which doesn't support > libattach. So it definitely seems like something is going wrong in the > attach process, but I can't say what. Not sure what debugging hooks we > have for the attach mechanism ?? The first attach involves signaling the target VM to start up the attach mechanism. So for the minimal VM or a VM running with attach disabled (or as Staffan pointed out, running with a different tmp directory) then the target VM gets a SIGQUIT and just prints the thread dump. It's hard to say what Piotr is running into but I think this at least explains it for the minimal VM. -Alan From valerie.peng at oracle.com Thu Nov 21 12:03:27 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Thu, 21 Nov 2013 20:03:27 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131121200356.B232D6276B@hg.openjdk.java.net> Changeset: 93826827e8b4 Author: valeriep Date: 2013-11-19 15:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93826827e8b4 8026943: SQE test jce/Global/Cipher/SameBuffer failed Summary: Always use different input/output buffers when calling FeedbackCipher objects Reviewed-by: mullan ! src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java + test/com/sun/crypto/provider/Cipher/AES/TestCopySafe.java Changeset: 06d155a7c9b0 Author: valeriep Date: 2013-11-21 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06d155a7c9b0 Merge From john.coomes at oracle.com Thu Nov 21 12:38:34 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 21 Nov 2013 20:38:34 +0000 Subject: hg: hsx/hotspot-rt: Added tag jdk8-b117 for changeset a4afb0a8d55e Message-ID: <20131121203834.A4FAB62778@hg.openjdk.java.net> Changeset: 0a6db1aac998 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/0a6db1aac998 Added tag jdk8-b117 for changeset a4afb0a8d55e ! .hgtags From john.coomes at oracle.com Thu Nov 21 12:38:43 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 21 Nov 2013 20:38:43 +0000 Subject: hg: hsx/hotspot-rt/corba: 4 new changesets Message-ID: <20131121203847.C338F62779@hg.openjdk.java.net> Changeset: b99535e22efe Author: mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb, lancea ! src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java Changeset: 4796555c4dc8 Author: lana Date: 2013-11-08 17:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/4796555c4dc8 Merge Changeset: e53d1ee4d2ae Author: lana Date: 2013-11-14 23:33 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/e53d1ee4d2ae Merge Changeset: d6820a414f18 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/d6820a414f18 Added tag jdk8-b117 for changeset e53d1ee4d2ae ! .hgtags From john.coomes at oracle.com Thu Nov 21 12:38:55 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 21 Nov 2013 20:38:55 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b117 for changeset c1d234d4f164 Message-ID: <20131121203905.744226277A@hg.openjdk.java.net> Changeset: e4e5069250e7 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/e4e5069250e7 Added tag jdk8-b117 for changeset c1d234d4f164 ! .hgtags From john.coomes at oracle.com Thu Nov 21 12:39:13 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 21 Nov 2013 20:39:13 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b117 for changeset fe56ba456fd3 Message-ID: <20131121203922.1FCC56277B@hg.openjdk.java.net> Changeset: 76a598cf50c4 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/76a598cf50c4 Added tag jdk8-b117 for changeset fe56ba456fd3 ! .hgtags From john.coomes at oracle.com Thu Nov 21 12:43:08 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 21 Nov 2013 20:43:08 +0000 Subject: hg: hsx/hotspot-rt/jdk: 90 new changesets Message-ID: <20131121210229.1E0886277D@hg.openjdk.java.net> Changeset: f2ae86dba4bc Author: prr Date: 2013-11-13 11:59 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f2ae86dba4bc 8028206: sun/java2d/cmm/ProfileOp/SetDataTest.java fails Reviewed-by: bae, jchen ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! test/sun/java2d/cmm/ProfileOp/SetDataTest.java Changeset: b691a6abf9e0 Author: lana Date: 2013-11-14 23:29 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b691a6abf9e0 Merge Changeset: 30766f910509 Author: malenkov Date: 2013-11-01 21:45 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/30766f910509 8026491: Typos in string literals Reviewed-by: alexsch, anthony ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties ! src/share/classes/com/sun/imageio/plugins/common/StandardMetadataFormatResources.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubNextRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubRequestHandler.java ! src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java ! src/share/classes/com/sun/tools/script/shell/init.js ! src/share/classes/com/sun/tools/script/shell/messages.properties ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/swing/KeyboardManager.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/rmi/rmic/RMIGenerator.java ! src/share/classes/sun/security/jgss/krb5/InitialToken.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/share/demo/jfc/FileChooserDemo/FileChooserDemo.java ! src/share/native/sun/security/pkcs11/wrapper/p11_util.c ! src/share/sample/nio/chatserver/ClientReader.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java ! src/windows/classes/sun/security/krb5/internal/tools/Ktab.java Changeset: b8eb21e93fa7 Author: yan Date: 2013-11-07 18:57 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b8eb21e93fa7 8025234: [javadoc] fix some errors in javax.swing.** Reviewed-by: alexsch, malenkov Contributed-by: Dmitry Ginzburg ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/Action.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/CellRendererPane.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DesktopManager.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JTextField.java Changeset: 29f979efbabf Author: malenkov Date: 2013-11-08 14:09 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/29f979efbabf 8027648: Type of overridden property is resolved incorrectly Reviewed-by: alexsch ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java + test/java/beans/Introspector/Test8027648.java + test/java/beans/Introspector/Test8027905.java Changeset: 184f13eeed41 Author: lana Date: 2013-11-08 15:02 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/184f13eeed41 Merge - src/share/classes/java/lang/invoke/MagicLambdaImpl.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: 4bc2414624e2 Author: leonidr Date: 2013-11-12 20:02 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4bc2414624e2 8027972: [macosx] Provide a regression test for JDK-8007006 Reviewed-by: anthony + test/java/awt/MenuBar/8007006/bug8007006.java Changeset: 0242fce0f717 Author: serb Date: 2013-11-12 20:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0242fce0f717 8027696: Incorrect copyright header in the tests Reviewed-by: alanb, malenkov, mullan ! test/ProblemList.txt ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java ! test/com/sun/jndi/cosnaming/CNNameParser.java ! test/com/sun/jndi/cosnaming/IiopUrlIPv6.java ! test/demo/zipfs/ZipFSTester.java ! test/java/awt/AlphaComposite/TestAlphaCompositeForNaN.java ! test/java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html ! test/java/awt/Choice/NonFocusablePopupMenuTest/NonFocusablePopupMenuTest.html ! test/java/awt/Component/F10TopToplevel/F10TopToplevel.html ! test/java/awt/Component/UpdatingBootTime/UpdatingBootTime.html ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/NextFramePositionCalculator.java ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/SourcePanel.java ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/TargetPanel.java ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html ! test/java/awt/EventQueue/MainAppContext/MainAppContext.java ! test/java/awt/EventQueue/PostEventOrderingTest/PostEventOrderingTest.java ! test/java/awt/FileDialog/FileDialogReturnTest/FileDialogReturnTest.html ! test/java/awt/FileDialog/FileNameOverrideTest/FileNameOverrideTest.html ! test/java/awt/FileDialog/FileNameOverrideTest/FileNameOverrideTest.java ! test/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html ! test/java/awt/FileDialog/MultipleMode/MultipleMode.html ! test/java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.html ! test/java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html ! test/java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.java ! test/java/awt/Focus/6981400/Test1.java ! test/java/awt/Focus/6981400/Test2.java ! test/java/awt/Focus/6981400/Test3.java ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java ! test/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html ! test/java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_AWT.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_Swing.java ! test/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html ! test/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html ! test/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html ! test/java/awt/Frame/FrameSetSizeStressTest/FrameSetSizeStressTest.java ! test/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html ! test/java/awt/Frame/ShownOnPack/ShownOnPack.html ! test/java/awt/Graphics/DrawImageBG/SystemBgColorTest.java ! test/java/awt/Graphics2D/FillTexturePaint/FillTexturePaint.java ! test/java/awt/InputMethods/InputMethodsTest/InputMethodsTest.html ! test/java/awt/JAWT/JAWT.sh ! test/java/awt/JAWT/Makefile.cygwin ! test/java/awt/JAWT/Makefile.unix ! test/java/awt/JAWT/Makefile.win ! test/java/awt/JAWT/MyCanvas.java ! test/java/awt/JAWT/myfile.c ! test/java/awt/JAWT/myfile.cpp ! test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_AWT.java ! test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java ! test/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html ! test/java/awt/List/SetFontTest/SetFontTest.html ! test/java/awt/Menu/NullMenuLabelTest/NullMenuLabelTest.java ! test/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html ! test/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java ! test/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java ! test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java ! test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java ! test/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html ! test/java/awt/Multiscreen/TranslucencyThrowsExceptionWhenFullScreen/TranslucencyThrowsExceptionWhenFullScreen.java ! test/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html ! test/java/awt/PrintJob/Text/stringwidth.sh ! test/java/awt/Robot/AcceptExtraMouseButtons/AcceptExtraMouseButtons.java ! test/java/awt/Robot/ManualInstructions/ManualInstructions.java ! test/java/awt/Robot/RobotExtraButton/RobotExtraButton.java ! test/java/awt/ScrollPane/ScrollPanePreferredSize/ScrollPanePreferredSize.java ! test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test.java ! test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test1.java ! test/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.html ! test/java/awt/TextArea/TextAreaTwicePack/TextAreaTwicePack.java ! test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.html ! test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.html ! test/java/awt/Toolkit/Headless/AWTEventListener/AWTListener.java ! test/java/awt/Toolkit/Headless/ExceptionContract/ExceptionContract.java ! test/java/awt/Toolkit/Headless/GetPrintJob/GetPrintJob.java ! test/java/awt/Toolkit/Headless/GetPrintJob/GetPrintJobHeadless.java ! test/java/awt/Toolkit/SecurityTest/SecurityTest2.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_1.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_2.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_3.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_4.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_5.java ! test/java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Disable.java ! test/java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Enable.java ! test/java/awt/Window/Grab/GrabTest.java ! test/java/awt/Window/TranslucentShapedFrameTest/TSFrame.java ! test/java/awt/Window/TranslucentShapedFrameTest/TranslucentShapedFrameTest.java ! test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh ! test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/test.html ! test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html ! test/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.html ! test/java/awt/dnd/Button2DragTest/Button2DragTest.html ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDTarget.java ! test/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html ! test/java/awt/dnd/ImageDecoratedDnD/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnD/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.html ! test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java ! test/java/awt/dnd/ImageDecoratedDnD/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnD/MyCursor.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/MyCursor.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/MyCursor.java ! test/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html ! test/java/awt/event/InputEvent/ButtonArraysEquality/ButtonArraysEquality.java ! test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.html ! test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java ! test/java/awt/event/KeyEvent/KeyReleasedInAppletTest/KeyReleasedInAppletTest.html ! test/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html ! test/java/awt/event/MouseEvent/AWTPanelSmoothWheel/AWTPanelSmoothWheel.html ! test/java/awt/event/MouseEvent/AcceptExtraButton/AcceptExtraButton.java ! test/java/awt/event/MouseEvent/CTORRestrictions/CTORRestrictions.java ! test/java/awt/event/MouseEvent/CTORRestrictions/CTORRestrictions_Disable.java ! test/java/awt/event/MouseEvent/CheckGetMaskForButton/CheckGetMaskForButton.java ! test/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html ! test/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html ! test/java/awt/event/OtherEvents/UngrabID/UngrabID.java ! test/java/awt/im/4490692/bug4490692.html ! test/java/awt/im/4959409/bug4959409.html ! test/java/awt/im/JTextFieldTest.html ! test/java/awt/image/BufferedImage/TinyScale.java ! test/java/awt/image/DrawImage/EABlitTest.java ! test/java/awt/print/PrinterJob/CustomPrintService/PrintServiceStub.java ! test/java/awt/print/PrinterJob/CustomPrintService/SetPrintServiceTest.java ! test/java/awt/print/bug8023392/bug8023392.html ! test/java/awt/print/bug8023392/bug8023392.java ! test/java/beans/Introspector/6380849/beans/FirstBean.java ! test/java/beans/Introspector/6380849/beans/FirstBeanBeanInfo.java ! test/java/beans/Introspector/6380849/beans/SecondBean.java ! test/java/beans/Introspector/6380849/beans/ThirdBean.java ! test/java/beans/Introspector/6380849/infos/SecondBeanBeanInfo.java ! test/java/beans/Introspector/6380849/infos/ThirdBeanBeanInfo.java ! test/java/beans/Introspector/6976577/test/Accessor.java ! test/java/beans/Introspector/7122138/pack/Sub.java ! test/java/beans/Introspector/7122138/pack/Super.java ! test/java/beans/XMLEncoder/6380849/Bean.java ! test/java/beans/XMLEncoder/6380849/BeanPersistenceDelegate.java ! test/java/io/FileInputStream/OpsAfterClose.java ! test/java/io/FileOutputStream/OpsAfterClose.java ! test/java/io/RandomAccessFile/OpsAfterClose.java ! test/java/lang/StringBuffer/BufferForwarding.java ! test/java/lang/StringBuilder/BuilderForwarding.java ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java ! test/java/lang/invoke/AccessControlTest.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/ClassValueTest.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/PermuteArgsTest.java ! test/java/lang/invoke/PrivateInvokeTest.java ! test/java/lang/invoke/RevealDirectTest.java ! test/java/lang/invoke/RicochetTest.java ! test/java/lang/invoke/TestCatchExceptionWithVarargs.java ! test/java/lang/invoke/ThrowExceptionsTest.java ! test/java/lang/invoke/remote/RemoteExample.java ! test/java/lang/ref/ReferenceEnqueuePending.java ! test/java/net/URLClassLoader/closetest/build.sh ! test/java/security/cert/CertPathBuilder/selfIssued/generate.sh ! test/java/security/cert/CertPathValidator/indirectCRL/generate.sh ! test/java/security/cert/CertPathValidator/nameConstraints/generate.sh ! test/java/security/cert/CertificateRevokedException/Basic.java ! test/java/util/Calendar/CldrFormatNamesTest.java ! test/java/util/Locale/LocaleEnhanceTest.java ! test/java/util/Locale/LocaleTestFmwk.java ! test/java/util/Locale/tools/EquivMapsGenerator.java ! test/java/util/TimeZone/Bug6912560.java ! test/java/util/TimeZone/CLDRDisplayNamesTest.java ! test/java/util/TimeZone/ListTimeZones.java ! test/java/util/TimeZone/OldIDMappingTest.java ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/SetDefaultSecurityTest.java ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.java ! test/java/util/TimeZone/TzIDOldMapping.java ! test/java/util/prefs/AddNodeChangeListener.java ! test/java/util/prefs/CheckUserPrefFirst.java ! test/java/util/prefs/CheckUserPrefLater.java ! test/java/util/regex/RegExTest.java ! test/java/util/spi/ResourceBundleControlProvider/providersrc/UserControlProvider.java ! test/java/util/zip/LargeZip.java ! test/java/util/zip/TotalInOut.java ! test/javax/imageio/plugins/gif/GifTransparencyTest.java ! test/javax/management/modelmbean/LoggingExceptionTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/print/DialogMargins.java ! test/javax/print/StreamPrintingOrientation.java ! test/javax/print/applet/AppletPrintLookup.html ! test/javax/sound/midi/File/SMPTESequence.java ! test/javax/sound/midi/Gervill/AudioFloatConverter/GetFormat.java ! test/javax/sound/midi/Gervill/AudioFloatConverter/ToFloatArray.java ! test/javax/sound/midi/Gervill/AudioFloatFormatConverter/SkipTest.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Available.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Close.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/GetFormat.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/GetFrameLength.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/MarkSupported.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Read.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/ReadFloatArray.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/ReadFloatArrayIntInt.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Reset.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Skip.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankFile.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankInputStream.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankInputStream2.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankUrl.java ! test/javax/sound/midi/Gervill/EmergencySoundbank/TestCreateSoundbank.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/GetInputStream.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/GetRoot.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/Load.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/LoadAll.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferByteArray.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferByteArrayIntInt.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferFile.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferFileLongLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Available.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Close.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/MarkReset.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/MarkSupported.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Read.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/ReadByte.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/ReadByteIntInt.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Skip.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLongLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLongLongBoolean.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/Unload.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/WriteTo.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetAttenuation.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetChannels.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetLoopLength.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetLoopStart.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetPitchCorrection.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBuffer.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferAudioFormat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferAudioFormatFloat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferFloat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/Open.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/OpenStream.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/Set8BitExtensionBuffer.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/SetLoopType.java ! test/javax/sound/midi/Gervill/ModelDestination/NewModelDestination.java ! test/javax/sound/midi/Gervill/ModelDestination/NewModelDestinationModelIdentifier.java ! test/javax/sound/midi/Gervill/ModelDestination/SetIdentifier.java ! test/javax/sound/midi/Gervill/ModelDestination/SetTransform.java ! test/javax/sound/midi/Gervill/ModelIdentifier/EqualsObject.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierString.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringInt.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringString.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringStringInt.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetInstance.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetObject.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetVariable.java ! test/javax/sound/midi/Gervill/ModelPerformer/GetOscillators.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetConnectionBlocks.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetDefaultConnectionsEnabled.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetExclusiveClass.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetKeyFrom.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetKeyTo.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetName.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetSelfNonExclusive.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetVelFrom.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetVelTo.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSource.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifier.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBoolean.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBooleanBoolean.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBooleanBooleanInt.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierModelTransform.java ! test/javax/sound/midi/Gervill/ModelSource/SetIdentifier.java ! test/javax/sound/midi/Gervill/ModelSource/SetTransform.java ! test/javax/sound/midi/Gervill/ModelStandardIndexedDirector/ModelStandardIndexedDirectorTest.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransform.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBoolean.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBooleanBoolean.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBooleanBooleanInt.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetDirection.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetPolarity.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetTransform.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformAbsolute.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformConcave.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformConvex.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformLinear.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformSwitch.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Available.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Close.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/GetFilePointer.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/GetSize.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/HasNextChunk.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Read.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadByte.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadByteArrayIntInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadLong.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadShort.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadString.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedByte.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedShort.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Skip.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/WriteOutputStream.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankFile.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankInputStream.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankInputStream2.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankUrl.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrument.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformer.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArray.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/Clear.java ! test/javax/sound/midi/Gervill/SimpleInstrument/SetName.java ! test/javax/sound/midi/Gervill/SimpleInstrument/SetPatch.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/AddInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/AddResource.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/GetInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/RemoveInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetDescription.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetName.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetVendor.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetVersion.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Array.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Clear.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Get.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/NewSoftAudioBuffer.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/GetFormat.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/GetPropertyInfo.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/Open.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/OpenStream.java ! test/javax/sound/midi/Gervill/SoftChannel/AllNotesOff.java ! test/javax/sound/midi/Gervill/SoftChannel/AllSoundOff.java ! test/javax/sound/midi/Gervill/SoftChannel/ChannelPressure.java ! test/javax/sound/midi/Gervill/SoftChannel/Controller.java ! test/javax/sound/midi/Gervill/SoftChannel/LocalControl.java ! test/javax/sound/midi/Gervill/SoftChannel/Mono.java ! test/javax/sound/midi/Gervill/SoftChannel/Mute.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOff.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOff2.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOn.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest2.java ! test/javax/sound/midi/Gervill/SoftChannel/Omni.java ! test/javax/sound/midi/Gervill/SoftChannel/PitchBend.java ! test/javax/sound/midi/Gervill/SoftChannel/PolyPressure.java ! test/javax/sound/midi/Gervill/SoftChannel/ProgramAndBankChange.java ! test/javax/sound/midi/Gervill/SoftChannel/ProgramChange.java ! test/javax/sound/midi/Gervill/SoftChannel/ResetAllControllers.java ! test/javax/sound/midi/Gervill/SoftChannel/SoftTestUtils.java ! test/javax/sound/midi/Gervill/SoftChannel/Solo.java ! test/javax/sound/midi/Gervill/SoftCubicResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftFilter/TestProcessAudio.java ! test/javax/sound/midi/Gervill/SoftLanczosResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_mono.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_mono_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_normal.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_normal_mono.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_overdrive_mono.java ! test/javax/sound/midi/Gervill/SoftLinearResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLinearResampler2/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java ! test/javax/sound/midi/Gervill/SoftPointResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftProvider/GetDevice.java ! test/javax/sound/midi/Gervill/SoftReceiver/Close.java ! test/javax/sound/midi/Gervill/SoftReceiver/GetMidiDevice.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ActiveSense.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_AllNotesOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_AllSoundOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ChannelPressure.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Controller.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Mono.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_AllChannels.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_Delayed.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_Multiple.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Omni.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_PitchBend.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_PolyPressure.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ProgramChange.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ResetAllControllers.java ! test/javax/sound/midi/Gervill/SoftReceiver/SoftTestUtils.java ! test/javax/sound/midi/Gervill/SoftSincResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/Close.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetAvailableInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetAvailableInstruments2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetChannels.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetDefaultSoundbank.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetDeviceInfo.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLatency.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLoadedInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLoadedInstruments2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxPolyphony.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxReceivers.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxTransmitters.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMicrosecondPosition.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetPropertyInfo.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceiver.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceiver2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceivers.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetTransmitter.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetTransmitters.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetVoiceStatus.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/ImplicitOpenClose.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/IsOpen.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/IsSoundbankSupported.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/Open.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/OpenStream.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/RemapInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestDisableLoadDefaultSoundbank.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestPreciseTimestampRendering.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestRender1.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstruments.java ! test/javax/sound/midi/Gervill/SoftTuning/GetName.java ! test/javax/sound/midi/Gervill/SoftTuning/GetTuning.java ! test/javax/sound/midi/Gervill/SoftTuning/GetTuningInt.java ! test/javax/sound/midi/Gervill/SoftTuning/Load1.java ! test/javax/sound/midi/Gervill/SoftTuning/Load2.java ! test/javax/sound/midi/Gervill/SoftTuning/Load4.java ! test/javax/sound/midi/Gervill/SoftTuning/Load5.java ! test/javax/sound/midi/Gervill/SoftTuning/Load6.java ! test/javax/sound/midi/Gervill/SoftTuning/Load7.java ! test/javax/sound/midi/Gervill/SoftTuning/Load8.java ! test/javax/sound/midi/Gervill/SoftTuning/Load9.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuning.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningByteArray.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningPatch.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningPatchByteArray.java ! test/javax/sound/midi/Gervill/SoftTuning/RealTimeTuning.java ! test/javax/sound/midi/MidiDeviceConnectors/TestAllDevices.java ! test/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java ! test/javax/sound/sampled/AudioFormat/Matches_NOT_SPECIFIED.java ! test/javax/sound/sampled/AudioFormat/PCM_FLOAT_support.java ! test/javax/sound/sampled/Clip/ClipSetPos.java ! test/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java ! test/javax/sound/sampled/DirectAudio/bug6400879.java ! test/javax/sound/sampled/FileWriter/AlawEncoderSync.java ! test/javax/sound/sampled/FileWriter/WriterCloseInput.java ! test/javax/swing/JCheckBox/4449413/bug4449413.html ! test/javax/swing/JColorChooser/Test4222508.html ! test/javax/swing/JColorChooser/Test4759306.html ! test/javax/swing/JColorChooser/Test4759934.html ! test/javax/swing/JColorChooser/Test4887836.html ! test/javax/swing/JColorChooser/Test6348456.html ! test/javax/swing/JColorChooser/Test6977726.html ! test/javax/swing/JComponent/4337267/bug4337267.java ! test/javax/swing/JComponent/6683775/bug6683775.java ! test/javax/swing/JEditorPane/4492274/test.html ! test/javax/swing/JEditorPane/6917744/test.html ! test/javax/swing/JEditorPane/bug4714674.java ! test/javax/swing/JFileChooser/6570445/bug6570445.java ! test/javax/swing/JFileChooser/6698013/bug6698013.html ! test/javax/swing/JFileChooser/6698013/bug6698013.java ! test/javax/swing/JFileChooser/6798062/bug6798062.html ! test/javax/swing/JInternalFrame/6726866/bug6726866.html ! test/javax/swing/JInternalFrame/6726866/bug6726866.java ! test/javax/swing/JSlider/4987336/bug4987336.html ! test/javax/swing/JSlider/6524424/bug6524424.html ! test/javax/swing/JSlider/6587742/bug6587742.html ! test/javax/swing/JSlider/6742358/bug6742358.html ! test/javax/swing/JTabbedPane/4310381/bug4310381.html ! test/javax/swing/JTree/4314199/bug4314199.html ! test/javax/swing/SwingUtilities/7170657/bug7170657.java ! test/javax/swing/border/Test4129681.html ! test/javax/swing/border/Test4243289.html ! test/javax/swing/border/Test4247606.html ! test/javax/swing/border/Test4252164.html ! test/javax/swing/border/Test4760089.html ! test/javax/swing/border/Test6910490.html ! test/javax/swing/border/Test7022041.java ! test/javax/swing/text/html/TableView/7030332/bug7030332.html ! test/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html ! test/sun/nio/cs/EUC_TW_OLD.java ! test/sun/nio/cs/TestStringCoding.java ! test/sun/nio/cs/X11CNS11643.java ! test/sun/nio/cs/X11CNS11643P1.java ! test/sun/nio/cs/X11CNS11643P2.java ! test/sun/nio/cs/X11CNS11643P3.java ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.java ! test/sun/security/pkcs11/ec/TestECGenSpec.java ! test/sun/security/pkcs11/ec/TestKeyFactory.java ! test/sun/util/resources/Locale/Bug6275682.java ! test/tools/launcher/DiacriticTest.java ! test/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java ! test/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java Changeset: d6fe4e451dfb Author: bagiras Date: 2013-11-13 20:16 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d6fe4e451dfb 8028283: Revert JavaDoc changes pushed for JDK-7068423 Reviewed-by: art, serb ! src/share/classes/java/awt/GraphicsDevice.java Changeset: 535f19dd3960 Author: pchelko Date: 2013-11-14 10:52 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/535f19dd3960 8028230: Behavior of SystemFlavorMap.getNativesForFlavor differ from that in Java 7 Reviewed-by: anthony, serb ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java + test/java/awt/datatransfer/DuplicatedNativesTest/DuplicatedNativesTest.java Changeset: 8d17ebcef958 Author: pchelko Date: 2013-11-14 11:42 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8d17ebcef958 8025440: [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108 Reviewed-by: anthony + test/com/sun/awt/SecurityWarning/CustomSecurityManager.java ! test/com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java + test/java/awt/regtesthelpers/CopyClassFile.java Changeset: ca0db77f6d6b Author: lana Date: 2013-11-14 23:32 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ca0db77f6d6b Merge Changeset: c35f6df5bce9 Author: sla Date: 2013-11-01 10:08 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c35f6df5bce9 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Reviewed-by: stefank, alanb ! test/ProblemList.txt Changeset: c59ccad6eb72 Author: sla Date: 2013-11-01 15:10 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c59ccad6eb72 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Reviewed-by: dcubed ! test/com/sun/jdi/JdbMethodExitTest.sh ! test/com/sun/jdi/ShellScaffold.sh Changeset: 6a6faa00acc4 Author: dxu Date: 2013-11-01 14:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6a6faa00acc4 8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again Reviewed-by: wetmore ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java Changeset: adcc01f5bc93 Author: jrose Date: 2013-11-02 20:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/adcc01f5bc93 8024635: Caching MethodType's descriptor string improves lambda linkage performance Summary: Better interpreted and compiled performance of operations in MethodType important to LambdaMetafactory. Reviewed-by: jrose, twisti, mchung Contributed-by: sergey.kuksenko at oracle.com ! src/share/classes/java/lang/invoke/MethodType.java Changeset: d19ab5da83cc Author: dholmes Date: 2013-11-04 06:58 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d19ab5da83cc 8025198: Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Reviewed-by: martin, dholmes Contributed-by: Tristan Yan ! makefiles/CompileLaunchers.gmk ! makefiles/lib/CoreLibraries.gmk ! src/share/bin/java.c ! test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Changeset: 23982079ad49 Author: dholmes Date: 2013-11-04 07:39 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/23982079ad49 8027755: Anti-delta incorrect push for 8025198 Reviewed-by: alanb ! makefiles/CompileLaunchers.gmk ! makefiles/lib/CoreLibraries.gmk ! src/share/bin/java.c Changeset: 92fb6baaebc4 Author: bpb Date: 2013-11-04 08:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/92fb6baaebc4 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size Summary: Add @run tag to specify heap size Reviewed-by: alanb, dxu ! test/java/math/BigInteger/ExtremeShiftingTests.java Changeset: 48449b5390fa Author: michaelm Date: 2013-11-04 17:47 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/48449b5390fa 8027687: The constructors of URLPermission class do not behave as described in javad Reviewed-by: chegar, mduigou ! src/share/classes/java/net/HostPortrange.java ! src/share/classes/java/net/URLPermission.java ! test/java/net/URLPermission/URLPermissionTest.java Changeset: 51b002381b35 Author: rfield Date: 2013-11-04 10:12 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/51b002381b35 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class 8027681: Lambda serialization fails once reflection proxy generation kicks in Reviewed-by: ksrini, briangoetz, jfranck Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java Changeset: 78a0dcde6b67 Author: alundblad Date: 2013-11-04 15:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/78a0dcde6b67 8016725: TEST_BUG: java/lang/reflect/Method/DefaultMethodModeling.java failing intermittently Summary: Moved DefaultMethodModeling.java to its own directory to avoid conflicts with Equals.java. Reviewed-by: darcy - test/java/lang/reflect/Method/DefaultMethodModeling.java + test/java/lang/reflect/Method/defaultMethodModeling/DefaultMethodModeling.java Changeset: 6d1f3ba68db2 Author: dxu Date: 2013-11-04 15:48 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6d1f3ba68db2 8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up stage Reviewed-by: chegar ! test/java/io/File/MaxPathLength.java Changeset: d5b3f83ffc40 Author: psandoz Date: 2013-11-05 12:08 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d5b3f83ffc40 8027712: DistinctOpTest fails for unordered test Reviewed-by: henryjen, alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java Changeset: a8a044db575c Author: joehw Date: 2013-11-05 11:18 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a8a044db575c 8027860: [TEST_BUG] File not closed in javax/xml/jaxp/parsers/8022548/XOMParserTest.java Reviewed-by: alanb ! test/javax/xml/jaxp/parsers/8022548/XOMParserTest.java Changeset: 85fd2ae0a845 Author: mchung Date: 2013-11-05 17:33 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/85fd2ae0a845 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java 6944188: ThreadMXBean/ThreadStateTest.java fails intermittently Reviewed-by: dholmes, chegar + test/java/lang/Thread/ThreadStateController.java ! test/java/lang/Thread/ThreadStateTest.java + test/java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java - test/java/lang/management/ThreadMXBean/ThreadStateTest.java Changeset: 9c30cbc316e9 Author: mduigou Date: 2013-11-05 19:44 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9c30cbc316e9 8021309: replace test/Makefile jdk_* targets with jtreg groups 8015068: Use jtreg -exclude for handling problemList.txt exclusions Reviewed-by: jjg, smarks, chegar, alanb, dholmes ! .hgignore ! test/Makefile Changeset: 6ea1f9d8ec78 Author: dxu Date: 2013-11-06 13:25 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6ea1f9d8ec78 8025698: (fs) Typo in exception thrown by encode() in UnixPath.java Reviewed-by: dxu, mduigou, henryjen, weijun Contributed-by: ajuckel at gmail.com ! src/solaris/classes/sun/nio/fs/UnixPath.java Changeset: 81cbdd5876e8 Author: ksrini Date: 2013-11-06 11:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/81cbdd5876e8 8027227: [asm] generate CONSTANT_InterfaceMethodref for invoke{special/static) of non-abstract methods on ifaces Reviewed-by: ksrini, lagergren Contributed-by: ebruneton at free.fr, forax at univ-mlv.fr, john.r.rose at oracle.com, paul.sandoz at oracle.com ! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/version.txt Changeset: dbda97d6aa3a Author: ksrini Date: 2013-11-06 11:31 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/dbda97d6aa3a 8027232: Update j.l.invoke code generating class files to use ASM enhancements for invocation of non-abstract methods on ifaces Reviewed-by: ksrini, rfield Contributed-by: john.r.rose at oracle.com, paul.sandoz at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java + test/java/lang/invoke/lambda/LambdaAsm.java Changeset: f37d62e295c0 Author: chegar Date: 2013-11-07 08:04 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f37d62e295c0 8027822: ProblemList.txt Updates (11/2013) Reviewed-by: chegar, alanb Contributed-by: Amy Lu ! test/ProblemList.txt Changeset: 82b276590b85 Author: chegar Date: 2013-11-07 08:23 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/82b276590b85 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Reviewed-by: michaelm, rriggs ! src/share/native/java/net/Inet4Address.c ! src/share/native/java/net/Inet6Address.c ! src/share/native/java/net/InetAddress.c ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c Changeset: 88d1ed05a246 Author: michaelm Date: 2013-11-07 10:22 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88d1ed05a246 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient Reviewed-by: chegar ! test/java/net/URLPermission/URLPermissionTest.java ! test/java/net/URLPermission/nstest/LookupTest.java + test/java/net/URLPermission/nstest/lookup.sh - test/java/net/URLPermission/nstest/policy Changeset: 44fa6bf42846 Author: jfranck Date: 2013-11-07 13:33 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/44fa6bf42846 8027796: Refactor Core Reflection for Type Annotations Reviewed-by: psandoz ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java Changeset: fb7abd509bd2 Author: naoto Date: 2013-11-07 10:03 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fb7abd509bd2 8027930: ResourceBundle test failures in fr locale Reviewed-by: smarks ! test/java/util/ResourceBundle/ResourceBundleTest.java ! test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java Changeset: 04f071a95c29 Author: rriggs Date: 2013-11-07 20:56 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/04f071a95c29 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Summary: fix the typo Reviewed-by: lancea, chegar, dxu ! src/share/classes/java/io/DataInput.java Changeset: e10a182c973a Author: yhuang Date: 2013-11-07 22:30 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e10a182c973a 8027695: There should be a space before % sign in Swedish locale Reviewed-by: naoto ! src/share/classes/sun/text/resources/sv/FormatData_sv_SE.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: b5748857ef42 Author: jbachorik Date: 2013-11-08 08:47 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b5748857ef42 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c Reviewed-by: dholmes ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c Changeset: 8a4405fb40ba Author: ykantser Date: 2013-11-07 16:55 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a4405fb40ba 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Reviewed-by: sla, jbachorik ! test/sun/tools/jstatd/JstatdTest.java Changeset: 41d7ce111bd8 Author: mchung Date: 2013-11-08 07:53 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/41d7ce111bd8 8027351: (ref) Private finalize method invoked in preference to protected superclass method Reviewed-by: alanb, dholmes, mr, plevart, psandoz ! makefiles/lib/CoreLibraries.gmk ! makefiles/mapfiles/libjava/mapfile-vers ! makefiles/mapfiles/libjava/reorder-sparc ! makefiles/mapfiles/libjava/reorder-sparcv9 ! makefiles/mapfiles/libjava/reorder-x86 ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/misc/VM.java + test/java/lang/ref/FinalizeOverride.java Changeset: 3112729d6b74 Author: tyan Date: 2013-11-08 15:12 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3112729d6b74 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Reviewed-by: chegar ! test/java/net/MulticastSocket/TestInterfaces.java ! test/java/net/NetworkInterface/Equals.java Changeset: 771c77b49bb6 Author: chegar Date: 2013-11-08 15:15 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/771c77b49bb6 8019834: InetAddress.getByName hangs for bad IPv6 literals Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java ! test/java/net/ipv6tests/BadIPv6Addresses.java Changeset: 1c9ba18198d5 Author: mchung Date: 2013-11-08 09:43 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1c9ba18198d5 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Reviewed-by: alanb - src/share/native/java/lang/ref/Finalizer.c Changeset: 46982ca895b4 Author: tyan Date: 2013-11-08 18:54 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/46982ca895b4 8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6433018.java Changeset: 40ca9e4866de Author: mchung Date: 2013-11-08 12:13 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/40ca9e4866de 8025985: com.sun.management.OSMBeanFactory should not be public Reviewed-by: alanb, erikj, ihse, jbachorik ! makefiles/lib/ServiceabilityLibraries.gmk ! makefiles/mapfiles/libmanagement/mapfile-vers + src/share/classes/sun/management/BaseOperatingSystemImpl.java ! src/share/classes/sun/management/ManagementFactoryHelper.java - src/share/classes/sun/management/OperatingSystemImpl.java - src/solaris/classes/com/sun/management/OSMBeanFactory.java - src/solaris/classes/com/sun/management/UnixOperatingSystem.java + src/solaris/classes/sun/management/OperatingSystemImpl.java - src/solaris/native/com/sun/management/LinuxOperatingSystem.c - src/solaris/native/com/sun/management/MacosxOperatingSystem.c - src/solaris/native/com/sun/management/SolarisOperatingSystem.c - src/solaris/native/com/sun/management/UnixOperatingSystem_md.c + src/solaris/native/sun/management/LinuxOperatingSystem.c + src/solaris/native/sun/management/MacosxOperatingSystem.c + src/solaris/native/sun/management/OperatingSystemImpl.c + src/solaris/native/sun/management/SolarisOperatingSystem.c - src/windows/classes/com/sun/management/OSMBeanFactory.java - src/windows/classes/com/sun/management/OperatingSystem.java + src/windows/classes/sun/management/OperatingSystemImpl.java - src/windows/native/com/sun/management/OperatingSystem_md.c + src/windows/native/sun/management/OperatingSystemImpl.c Changeset: 11376ad23e21 Author: darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/repository/GenericDeclRepository.java Changeset: 50df04934e86 Author: alanb Date: 2013-11-08 21:07 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/50df04934e86 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f Reviewed-by: chegar ! src/share/classes/java/net/InetAddress.java Changeset: df2f7f288353 Author: rriggs Date: 2013-11-08 17:50 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/df2f7f288353 8028041: Serialized Form description of j.l.String is not consistent with the implementation Summary: Replaced incorrect description with reference to the serialization specification Reviewed-by: alanb, smarks ! src/share/classes/java/lang/String.java Changeset: a579e2f73bca Author: lana Date: 2013-11-08 17:36 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a579e2f73bca Merge ! src/share/classes/java/lang/invoke/MethodType.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! test/java/lang/Thread/ThreadStateTest.java Changeset: 9130770fb6e3 Author: alanb Date: 2013-11-09 16:46 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9130770fb6e3 8028044: [TEST_BUG] Calendar shell tests do not pass TESTVMOPTS Reviewed-by: dholmes, alanb Contributed-by: patrick.zhang at oracle.com ! test/java/util/Calendar/GenericTimeZoneNamesTest.sh ! test/java/util/Calendar/NarrowNamesTest.sh Changeset: 3add16c86970 Author: rriggs Date: 2013-11-09 14:30 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3add16c86970 8028092: Lint cleanup of java.time.format Summary: correct declarations and add @SuppressWarnings Reviewed-by: darcy, lancea ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/Parsed.java Changeset: 0c75cc07d264 Author: jbachorik Date: 2013-11-10 20:05 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0c75cc07d264 6523160: RuntimeMXBean.getUptime() returns negative values Summary: RuntimeMXBean.getUptime() should be based on HR timers rather than on the OS time Reviewed-by: dholmes, sla ! make/java/management/mapfile-vers ! makefiles/mapfiles/libmanagement/mapfile-vers ! src/share/classes/sun/management/RuntimeImpl.java ! src/share/classes/sun/management/VMManagement.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/javavm/export/jmm.h ! src/share/native/sun/management/VMManagementImpl.c ! test/java/lang/management/RuntimeMXBean/UpTime.java Changeset: 2525b91ca5a6 Author: alanb Date: 2013-11-11 08:36 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2525b91ca5a6 8028099: Many com/sun/management/OperatingSystemMXBean tests failing with CCE (win) Reviewed-by: mchung ! src/windows/classes/sun/management/OperatingSystemImpl.java Changeset: 7304b3195212 Author: weijun Date: 2013-11-11 16:54 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7304b3195212 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main Reviewed-by: xuelei ! src/share/classes/sun/security/tools/jarsigner/Main.java + test/sun/security/tools/jarsigner/CertChainUnclosed.java Changeset: b48eded97dff Author: chegar Date: 2013-11-11 10:33 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b48eded97dff 8028102: All test targets, jdk/test/Makefile, fail on Windows Reviewed-by: mduigou ! test/Makefile Changeset: 0e47462f03a0 Author: michaelm Date: 2013-11-11 16:06 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0e47462f03a0 8028060: test/java/net/URLPermission/nstest/lookup.sh failing (win) Reviewed-by: alanb ! test/java/net/URLPermission/nstest/LookupTest.java ! test/java/net/URLPermission/nstest/lookup.sh Changeset: 59ff7957c26f Author: lancea Date: 2013-11-11 14:22 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/59ff7957c26f 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java Changeset: 0cacac7f5c37 Author: sla Date: 2013-11-08 18:16 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0cacac7f5c37 8014506: Test of Jdp feature Reviewed-by: sla Contributed-by: Alex Schenkman + test/sun/management/jdp/ClientConnection.java + test/sun/management/jdp/DynamicLauncher.java ! test/sun/management/jdp/JdpClient.java + test/sun/management/jdp/JdpDefaultsTest.java ! test/sun/management/jdp/JdpDoSomething.java + test/sun/management/jdp/JdpOffTest.java + test/sun/management/jdp/JdpOffTestCase.java + test/sun/management/jdp/JdpOnTestCase.java + test/sun/management/jdp/JdpSpecificAddressTest.java ! test/sun/management/jdp/JdpTest.sh + test/sun/management/jdp/JdpTestCase.java + test/sun/management/jdp/JdpTestUtil.java + test/sun/management/jdp/JdpTestUtilTest.java ! test/sun/management/jdp/JdpUnitTest.java + test/sun/management/jdp/PacketTest.java + test/sun/management/jdp/PortAlreadyInUseTest.java + test/sun/management/jdp/README Changeset: 8e8e423fa3dc Author: sherman Date: 2013-11-11 14:35 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8e8e423fa3dc 8026330: java.util.Base64 urlEncoder should omit padding Summary: to add Encoder.withoutPadding() Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: c04e46dbfea8 Author: rfield Date: 2013-11-11 16:14 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c04e46dbfea8 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails Summary: fix NPE in test infrastructure Reviewed-by: ksrini, jfranck, alanb, rfield Contributed-by: alan.bateman at oracle.com ! test/lib/testlibrary/ClassFileInstaller.java Changeset: 9fcb07df1c92 Author: vlivanov Date: 2013-11-09 04:21 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9fcb07df1c92 8027823: catchException combinator fails with 9 argument target Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java + test/java/lang/invoke/MethodHandles/TestCatchException.java Changeset: 41dcb0c2e194 Author: egahlin Date: 2013-11-12 14:52 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/41dcb0c2e194 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently Reviewed-by: sla, jbachorik ! test/javax/management/monitor/ThreadPoolAccTest.java Changeset: f6012ca3bdd3 Author: smarks Date: 2013-11-12 16:59 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f6012ca3bdd3 8028027: serialver should emit declaration with the 'private' modifier Reviewed-by: darcy, mchung, alanb, chegar ! src/share/classes/sun/tools/serialver/SerialVer.java Changeset: 4cff9f59644f Author: egahlin Date: 2013-11-12 17:40 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4cff9f59644f 6543856: MonitorVmStartTerminate.sh fails intermittently Reviewed-by: sla, dholmes ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/jvmstat/testlibrary/JavaProcess.java Changeset: d9f827e4d20c Author: egahlin Date: 2013-11-12 18:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d9f827e4d20c 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes() Reviewed-by: sla ! test/sun/management/HotspotThreadMBean/GetInternalThreads.java Changeset: 0c414ac10700 Author: alanb Date: 2013-11-12 17:37 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0c414ac10700 8028208: (aio) Assertion in clearPendingIoMap when closing at around time file lock is acquired immediately (win) Reviewed-by: chegar ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! test/ProblemList.txt Changeset: 69432cb5bca2 Author: darcy Date: 2013-11-12 09:44 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/69432cb5bca2 8028229: Fix more raw types lint warning in core libraries Reviewed-by: chegar, forax, lancea, alanb, jfranck ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/nio/file/TempFileHelper.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/sun/misc/Cleaner.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java ! src/share/classes/sun/rmi/server/Util.java Changeset: ebe27e1a2e2d Author: rriggs Date: 2013-11-12 14:03 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ebe27e1a2e2d 8028014: Doclint warning/error cleanup in javax.management Summary: Improve generated html by fixing doclint warnings Reviewed-by: sla, jbachorik ! src/share/classes/javax/management/AttributeList.java ! src/share/classes/javax/management/BooleanValueExp.java ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/management/DescriptorKey.java ! src/share/classes/javax/management/ImmutableDescriptor.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/MBeanServerNotification.java ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/NumericValueExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/PersistentMBean.java ! src/share/classes/javax/management/Query.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetParser.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationBroadcaster.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanParameterInfoSupport.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/Relation.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationServiceMBean.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/remote/JMXConnectionNotification.java ! src/share/classes/javax/management/remote/JMXConnector.java ! src/share/classes/javax/management/remote/JMXConnectorProvider.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java Changeset: c4c84b5a3dfa Author: alanb Date: 2013-11-13 07:43 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c4c84b5a3dfa 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError Reviewed-by: mchung, egahlin ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh Changeset: 1158d504e39e Author: xuelei Date: 2013-11-13 01:14 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1158d504e39e 8023147: Test DisabledShortRSAKeys.java intermittent failed Reviewed-by: mullan ! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java Changeset: 30a3aefc4084 Author: dfuchs Date: 2013-11-13 10:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/30a3aefc4084 8026952: Test java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has wrong @bug id Summary: Trivial: change @bug 8023163 into @bug 8026499 Reviewed-by: mchung, alanb ! test/java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java Changeset: 680ef14a2cc0 Author: jbachorik Date: 2013-11-13 13:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/680ef14a2cc0 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently Reviewed-by: dholmes, ykantser ! test/com/sun/jdi/BadHandshakeTest.java Changeset: ddaa9a8acaed Author: egahlin Date: 2013-11-13 15:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ddaa9a8acaed 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java Reviewed-by: sla, jbachorik ! test/ProblemList.txt ! test/javax/management/loading/LibraryLoader/LibraryLoaderTest.java Changeset: a42a416351b8 Author: ykantser Date: 2013-11-13 11:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a42a416351b8 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Reviewed-by: sla + test/lib/testlibrary/AssertsTest.java + test/lib/testlibrary/OutputAnalyzerReportingTest.java + test/lib/testlibrary/jdk/testlibrary/InputArguments.java ! test/lib/testlibrary/jdk/testlibrary/JcmdBase.java - test/lib/testlibrary/jdk/testlibrary/JdkFinder.java ! test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java Changeset: 7c55fecfae65 Author: mchung Date: 2013-11-13 07:49 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7c55fecfae65 8028234: Remove unused methods in sun.misc.JavaAWTAccess Reviewed-by: art, dfuchs, lancea ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/misc/JavaAWTAccess.java ! test/java/util/logging/TestAppletLoggerContext.java Changeset: 70f1bed5e7fd Author: chegar Date: 2013-11-13 16:44 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/70f1bed5e7fd 8022213: Intermittent test failures in java/net/URLClassLoader Reviewed-by: dxu, alanb ! test/java/net/URLClassLoader/closetest/CloseTest.java ! test/java/net/URLClassLoader/closetest/Common.java ! test/java/net/URLClassLoader/closetest/GetResourceAsStream.java + test/lib/testlibrary/jdk/testlibrary/FileUtils.java Changeset: a493871959c2 Author: alanb Date: 2013-11-13 16:52 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a493871959c2 8028270: Files.readSymbolicLink calls AccessController directly so security manager can't grant the permission Reviewed-by: mchung, martin, chegar ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! test/java/nio/file/Files/CheckPermissions.java Changeset: 256b3395346b Author: egahlin Date: 2013-11-13 18:41 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/256b3395346b 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Reviewed-by: sla, sspitsyn ! test/com/sun/jdi/BreakpointWithFullGC.sh Changeset: e6333788b117 Author: darcy Date: 2013-11-13 11:06 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e6333788b117 8028300: Fix raw type lint warnings in java.util.concurrent Reviewed-by: chegar, martin ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java Changeset: 9e37caf07ce0 Author: sherman Date: 2013-11-13 11:26 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9e37caf07ce0 8027645: Pattern.split() with positive lookahead 6559590: Pattern.compile(".*").split("") returns incorrect result Summary: updated spec/impl for these two corner cases Reviewed-by: alanb, psandoz ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/regex/Pattern.java ! test/java/lang/String/Split.java ! test/java/util/regex/RegExTest.java Changeset: ea91826bc2e9 Author: emc Date: 2013-11-13 15:48 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ea91826bc2e9 8026884: test for fix of JDK-8021398 does not have @bug tag 8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in generated api docs Summary: two documentation fixes Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! test/java/lang/reflect/Parameter/GetAnnotatedTypeTest.java Changeset: 1d790a56de4e Author: sherman Date: 2013-11-13 22:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1d790a56de4e 8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression Summary: to undo the change for 6559590 Reviewed-by: darcy ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/regex/Pattern.java ! test/java/lang/String/Split.java ! test/java/util/regex/RegExTest.java Changeset: ecf85f4aecf0 Author: alanb Date: 2013-11-14 10:40 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ecf85f4aecf0 8028343: More ProblemList.txt updates (11/2013) Reviewed-by: chegar ! test/ProblemList.txt Changeset: 83c768d6cb93 Author: jfranck Date: 2013-11-14 12:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/83c768d6cb93 8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with -Dsun.reflect.noInflation=true Reviewed-by: briangoetz ! src/share/classes/sun/reflect/ReflectionFactory.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java ! test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java Changeset: 65f7b83ab477 Author: sla Date: 2013-11-14 19:31 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/65f7b83ab477 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Reviewed-by: alanb, allwin, sspitsyn, mgronlun ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jps/Jps.java ! src/share/classes/sun/tools/jstack/JStack.java Changeset: 59f46f135584 Author: hseigel Date: 2013-11-14 10:44 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/59f46f135584 8023041: The CDS classlist needs to be updated for JDK 8 Summary: Generate new classlists from JDK 8 classes Reviewed-by: alanb, coleenp, hseigel Contributed-by: ekaterina.pavlova at oracle.com ! make/tools/sharing/classlist.linux ! make/tools/sharing/classlist.macosx ! make/tools/sharing/classlist.solaris ! make/tools/sharing/classlist.windows Changeset: f893901ba29c Author: coleenp Date: 2013-11-14 14:01 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f893901ba29c Merge Changeset: 40d0ccd00f87 Author: xuelei Date: 2013-11-14 16:08 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/40d0ccd00f87 8014266: regression test AsyncSSLSocketClose.java time out. Reviewed-by: xuelei Contributed-by: Rajan Halade ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java Changeset: fc4ac66aa657 Author: lana Date: 2013-11-15 07:14 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fc4ac66aa657 Merge ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/sun/awt/AppContext.java - src/share/classes/sun/management/OperatingSystemImpl.java - src/share/native/java/lang/ref/Finalizer.c - src/solaris/classes/com/sun/management/OSMBeanFactory.java - src/solaris/classes/com/sun/management/UnixOperatingSystem.java - src/solaris/native/com/sun/management/LinuxOperatingSystem.c - src/solaris/native/com/sun/management/MacosxOperatingSystem.c - src/solaris/native/com/sun/management/SolarisOperatingSystem.c - src/solaris/native/com/sun/management/UnixOperatingSystem_md.c - src/windows/classes/com/sun/management/OSMBeanFactory.java - src/windows/classes/com/sun/management/OperatingSystem.java - src/windows/native/com/sun/management/OperatingSystem_md.c ! test/ProblemList.txt - test/java/lang/management/ThreadMXBean/ThreadStateTest.java - test/java/lang/reflect/Method/DefaultMethodModeling.java - test/java/net/URLPermission/nstest/policy ! test/java/util/regex/RegExTest.java - test/lib/testlibrary/jdk/testlibrary/JdkFinder.java Changeset: 8bc258c021a3 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8bc258c021a3 Added tag jdk8-b117 for changeset fc4ac66aa657 ! .hgtags From john.coomes at oracle.com Thu Nov 21 13:05:45 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 21 Nov 2013 21:05:45 +0000 Subject: hg: hsx/hotspot-rt/langtools: 18 new changesets Message-ID: <20131121210649.DE7B86277F@hg.openjdk.java.net> Changeset: cc80c03c41e4 Author: vromero Date: 2013-11-01 19:08 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/cc80c03c41e4 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Reviewed-by: jjg Contributed-by: vicente.romero at oracle.com, jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! test/tools/javac/flow/LVTHarness.java + test/tools/javac/flow/tests/TestCaseLocalInInnerBlock.java Changeset: 8b4e1421a9b7 Author: jlahoda Date: 2013-11-01 21:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8b4e1421a9b7 8027310: Annotation Processor crashes with NPE Summary: JCAnnotation.attribute is null when annotation type is unavailable Reviewed-by: jjg, jfranck ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/processing/errors/CrashOnNonExistingAnnotation/Processor.java + test/tools/javac/processing/errors/CrashOnNonExistingAnnotation/Source.java Changeset: 106b8fa32d71 Author: cl Date: 2013-11-04 17:38 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/106b8fa32d71 8025844: Need test to provide coverage for new DocumentationTool.Location enum Reviewed-by: jjg + test/tools/javadoc/api/basic/DocumentationToolLocationTest.java Changeset: 658861d1b36e Author: cl Date: 2013-11-04 18:04 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/658861d1b36e 8027411: javap tonga tests cleanup: write a java program to test invalid options -h and -b Reviewed-by: jjg + test/tools/javap/InvalidOptions.java Changeset: 126dc007ba3f Author: cl Date: 2013-11-04 18:51 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/126dc007ba3f 8027530: javap tonga tests cleanup: test -public, -protected, -package, -private options Reviewed-by: jjg + test/tools/javap/AccessModifiers.java Changeset: 75c8cde12ab6 Author: jlahoda Date: 2013-11-06 17:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/75c8cde12ab6 8027281: Incorrect invokespecial generated for JCK lang EXPR/expr636/expr63602m* tests Summary: When invoking interface default method via a superclass, use the direct superclass in the reference. Reviewed-by: vromero, dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/defaultMethods/super/TestDirectSuperInterfaceInvoke.java Changeset: e39bd9401ea5 Author: darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java + test/tools/javac/processing/model/util/TestIntersectionTypeVisitors.java Changeset: 21294feaf311 Author: lana Date: 2013-11-08 17:39 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/21294feaf311 Merge Changeset: 6e0f31d61e56 Author: jlahoda Date: 2013-11-09 15:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6e0f31d61e56 8027142: Invokedynamic instructions don't get line number table entries Summary: When emitting invokedynamic instruction, write pendingStatPos, if set, into the LineNumberTable. Invokedynamic itself does not set the pendingStatPos. Reviewed-by: jjg, jrose, ksrini, vromero ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! test/tools/javac/T8019486/WrongLNTForLambdaTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: 4788eb38cac5 Author: emc Date: 2013-11-11 09:47 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4788eb38cac5 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass() 8027253: javac illegally accepts array as bound Summary: backing out change allowing arrays in intersection types Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/ArraysInIntersections.java - test/tools/javac/InferArraysInIntersections.java - test/tools/javac/diags/examples/InterfaceOrArrayExpected.java ! test/tools/javac/generics/typevars/6680106/T6680106.out Changeset: f3ca12d680f3 Author: jfranck Date: 2013-11-11 17:26 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f3ca12d680f3 8027375: javac asserts on nested erroneous annotations Summary: make sure JCAnnotation trees have type != null before annotation processing Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Annotate.java + test/tools/javac/annotations/testCrashNestedAnnos/TestCrashNestedAnnos.java + test/tools/javac/annotations/testCrashNestedAnnos/TestCrashNestedAnnos.out Changeset: f90d88913c5f Author: sogoel Date: 2013-11-13 16:36 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f90d88913c5f 8025113: Convert 7 tools TryWithResources tests to jtreg format Reviewed-by: darcy, jjg + test/tools/javac/TryWithResources/ResDeclOutsideTry.java + test/tools/javac/TryWithResources/ResDeclOutsideTry.out + test/tools/javac/TryWithResources/ResInNestedExpr.java + test/tools/javac/TryWithResources/ResourceNameConflict.java + test/tools/javac/TryWithResources/ResourceNameConflict.out + test/tools/javac/TryWithResources/ResourceRedecl.java + test/tools/javac/TryWithResources/ResourceRedecl.out + test/tools/javac/TryWithResources/ResourceShadow.java + test/tools/javac/TryWithResources/TestTwr09.java Changeset: 24eaf41a3974 Author: emc Date: 2013-11-14 12:32 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/24eaf41a3974 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java Summary: Remove @ignore from test Reviewed-by: jjg ! test/tools/javac/T7042623.java Changeset: e79d6425f1c4 Author: vromero Date: 2013-11-14 19:28 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e79d6425f1c4 8026963: type annotations code crashes for code with erroneous trees Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/T8026963/TypeAnnotationsCrashWithErroneousTreeTest.java + test/tools/javac/T8026963/TypeAnnotationsCrashWithErroneousTreeTest.out Changeset: 5ae66d372d57 Author: bpatel Date: 2013-11-14 13:47 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/5ae66d372d57 8025524: javadoc does not correctly locate constructors for nested classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! test/com/sun/javadoc/testAnchorNames/TestAnchorNames.java + test/com/sun/javadoc/testConstructors/TestConstructors.java + test/com/sun/javadoc/testConstructors/pkg1/Outer.java ! test/tools/javadoc/generics/genericInnerAndOuter/expected.out Changeset: d4cbb671de1c Author: vromero Date: 2013-11-15 11:08 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d4cbb671de1c 8026231: Look at 'static' flag when checking method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/lambda/MethodReference22.java ! test/tools/javac/lambda/MethodReference22.out ! test/tools/javac/lambda/MethodReference51.java ! test/tools/javac/lambda/MethodReference68.out + test/tools/javac/lambda/MethodReference73.java + test/tools/javac/lambda/MethodReference73.out ! test/tools/javac/lambda/TargetType60.java ! test/tools/javac/lambda/TargetType60.out Changeset: 19de039a03a6 Author: lana Date: 2013-11-15 07:15 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/19de039a03a6 Merge - test/tools/javac/ArraysInIntersections.java - test/tools/javac/InferArraysInIntersections.java - test/tools/javac/diags/examples/InterfaceOrArrayExpected.java Changeset: 4fd6a7ff8c06 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/4fd6a7ff8c06 Added tag jdk8-b117 for changeset 19de039a03a6 ! .hgtags From john.coomes at oracle.com Thu Nov 21 13:07:10 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 21 Nov 2013 21:07:10 +0000 Subject: hg: hsx/hotspot-rt/nashorn: 13 new changesets Message-ID: <20131121210730.00ECC62780@hg.openjdk.java.net> Changeset: ae5f2130c3b9 Author: sundar Date: 2013-11-01 19:54 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/ae5f2130c3b9 8027700: function redeclaration checks missing for declaration binding instantiation Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! test/script/basic/JDK-8015355.js + test/script/basic/JDK-8027700.js Changeset: 98bab0cdd7bf Author: attila Date: 2013-11-01 15:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/98bab0cdd7bf 8027236: Ensure ScriptObject and ConsString aren't visible to Java Reviewed-by: lagergren, sundar ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/ConsString.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaSuperAdapterLinker.java + src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java + test/script/basic/JDK-8027236.js + test/script/basic/JDK-8027236.js.EXPECTED + test/src/jdk/nashorn/api/javaaccess/ConsStringTest.java Changeset: 144861e24260 Author: sundar Date: 2013-11-04 09:29 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/144861e24260 Merge Changeset: dcedc753fd09 Author: sundar Date: 2013-11-04 18:52 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/dcedc753fd09 8027753: Support ScriptObject to JSObject, ScriptObjectMirror, Map, Bindings auto-conversion as well as explicit wrap, unwrap Reviewed-by: jlaskey, hannesw, attila ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java + test/script/basic/JDK-8027753.js + test/script/basic/JDK-8027753.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/api/scripting/Window.java Changeset: b0d4ef6fb2db Author: sundar Date: 2013-11-05 09:13 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b0d4ef6fb2db Merge Changeset: bda654c6d59c Author: kshefov Date: 2013-11-05 13:09 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/bda654c6d59c 8027708: NASHORN TEST: Create Nashorn test that draws image step-by-step using JavaFX canvas. Reviewed-by: jlaskey, lagergren ! make/build.xml ! make/project.properties ! test/script/jfx.js ! test/script/jfx/flyingimage.js ! test/script/jfx/flyingimage/flyingimage.png ! test/script/jfx/flyingimage/golden/linux.png ! test/script/jfx/flyingimage/golden/macosx.png ! test/script/jfx/flyingimage/golden/windows.png ! test/script/jfx/kaleidoscope.js ! test/script/jfx/kaleidoscope/golden/linux.png ! test/script/jfx/kaleidoscope/golden/macosx.png ! test/script/jfx/kaleidoscope/golden/windows.png + test/script/jfx/spread.js + test/script/jfx/spread/golden/linux.png + test/script/jfx/spread/golden/macosx.png + test/script/jfx/spread/golden/windows.png Changeset: 2f07b4234451 Author: sundar Date: 2013-11-07 17:26 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2f07b4234451 8027828: ClassCastException when converting return value of a Java method to boolean Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java + test/script/basic/JDK-8027828.js + test/script/basic/JDK-8027828.js.EXPECTED + test/script/basic/convert.js + test/script/basic/convert.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java Changeset: 3b794f364c77 Author: sundar Date: 2013-11-07 18:11 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/3b794f364c77 Merge Changeset: d091499d67fc Author: lana Date: 2013-11-08 17:39 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/d091499d67fc Merge Changeset: e65a98146b94 Author: attila Date: 2013-11-11 14:25 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/e65a98146b94 8028020: Function parameter as last expression in comma in return value causes bad type calculation Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8028020.js + test/script/basic/JDK-8028020.js.EXPECTED Changeset: 2f0f8d1d0753 Author: sundar Date: 2013-11-12 10:23 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/2f0f8d1d0753 Merge Changeset: 1db3d4e4d189 Author: lana Date: 2013-11-15 07:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/1db3d4e4d189 Merge Changeset: 8d014b039b44 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/8d014b039b44 Added tag jdk8-b117 for changeset 1db3d4e4d189 ! .hgtags From dan.xu at oracle.com Thu Nov 21 14:24:03 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 21 Nov 2013 22:24:03 +0000 Subject: hg: jdk8/tl/jdk: 8028628: java/nio/channels/FileChannel/Size.java failed once in the same binary run Message-ID: <20131121222415.EA98D62787@hg.openjdk.java.net> Changeset: 81708985c0a2 Author: dxu Date: 2013-11-21 14:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81708985c0a2 8028628: java/nio/channels/FileChannel/Size.java failed once in the same binary run Reviewed-by: alanb, chegar, mchung, lancea ! test/java/nio/channels/FileChannel/Size.java From dan.xu at oracle.com Thu Nov 21 14:17:15 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 21 Nov 2013 22:17:15 +0000 Subject: hg: jdk8/tl/jdk: 7065902: (file) test/java/nio/file/Files/Misc.java fails on Solaris 11 when run as root Message-ID: <20131121221729.3D0E962785@hg.openjdk.java.net> Changeset: a74d6aa51654 Author: dxu Date: 2013-11-21 14:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a74d6aa51654 7065902: (file) test/java/nio/file/Files/Misc.java fails on Solaris 11 when run as root Reviewed-by: alanb ! test/java/nio/file/Files/Misc.java From stuart.marks at oracle.com Thu Nov 21 16:01:51 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 22 Nov 2013 00:01:51 +0000 Subject: hg: jdk8/tl/jdk: 7174936: several String methods claim to always create new String Message-ID: <20131122000217.394126278A@hg.openjdk.java.net> Changeset: 4bc37b6c4133 Author: smarks Date: 2013-11-21 16:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bc37b6c4133 7174936: several String methods claim to always create new String Reviewed-by: dholmes, bchristi, alanb, lancea ! src/share/classes/java/lang/String.java From harold.seigel at oracle.com Thu Nov 21 19:12:55 2013 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Fri, 22 Nov 2013 03:12:55 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8028520: JVM should not throw VerifyError when a private method overrides a final method Message-ID: <20131122031258.580F262796@hg.openjdk.java.net> Changeset: 19146c82b6fc Author: hseigel Date: 2013-11-21 14:41 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/19146c82b6fc 8028520: JVM should not throw VerifyError when a private method overrides a final method Summary: Exclude private methods when checking for final method override. Reviewed-by: kamg, coleenp, dholmes, mseledtsov ! src/share/vm/classfile/classFileParser.cpp From sundararajan.athijegannathan at oracle.com Thu Nov 21 20:32:44 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 22 Nov 2013 04:32:44 +0000 Subject: hg: jdk8/tl/nashorn: 5 new changesets Message-ID: <20131122043249.EB1926279A@hg.openjdk.java.net> Changeset: fea9f0f9bbde Author: sundar Date: 2013-11-14 15:53 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fea9f0f9bbde 8028161: nashorn: src/jdk/nashorn/api/scripting/ScriptEngineTest.java Reviewed-by: lagergren, hannesw ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: a165c0fb5be6 Author: hannesw Date: 2013-11-16 00:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a165c0fb5be6 8028210: Missing conversions on array index expression Reviewed-by: attila, jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java + test/script/basic/JDK-8028210.js + test/script/basic/JDK-8028210.js.EXPECTED Changeset: bce2bbfb35ae Author: lagergren Date: 2013-11-18 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bce2bbfb35ae 8028434: Line number nodes were off for while nodes and do while nodes - the line number of a loop node should be treated as the location of the test expression Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8028434.js + test/script/basic/JDK-8028434.js.EXPECTED Changeset: b375d261e56c Author: lagergren Date: 2013-11-19 10:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b375d261e56c 8028573: Line number nodes were off for while nodes and do while nodes - the line number of a loop node should be treated as the location of the test expression Reviewed-by: attila, hannesw ! test/script/basic/JDK-8028434.js Changeset: 73d741231651 Author: sundar Date: 2013-11-22 08:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/73d741231651 Merge From piotr at bzdyl.net Fri Nov 22 00:21:56 2013 From: piotr at bzdyl.net (Piotr Bzdyl) Date: Fri, 22 Nov 2013 09:21:56 +0100 Subject: jstack and the target output In-Reply-To: <528E4E68.1050403@oracle.com> References: <528E074E.8020709@oracle.com> <1B50BB6A-40E0-4E59-B469-49C545C7FF82@oracle.com> <528E1CF9.1070002@oracle.com> <528E4E68.1050403@oracle.com> Message-ID: Is there any other information I could collect to help troubleshoot this problem? How could I check if VM runs with attach disabled? I noticed the same behavior when trying to connect to the process using JConsole: JConsole displays the sample app in the list and when I try to connect it finally displays an error that it cannot connect whereas the sample app prints thread dump on its console. On Thu, Nov 21, 2013 at 7:18 PM, Alan Bateman wrote: > On 21/11/2013 14:47, David Holmes wrote: > >> >> I can recreate this using the minimal VM, which doesn't support >> libattach. So it definitely seems like something is going wrong in the >> attach process, but I can't say what. Not sure what debugging hooks we have >> for the attach mechanism ?? >> > The first attach involves signaling the target VM to start up the attach > mechanism. So for the minimal VM or a VM running with attach disabled (or > as Staffan pointed out, running with a different tmp directory) then the > target VM gets a SIGQUIT and just prints the thread dump. It's hard to say > what Piotr is running into but I think this at least explains it for the > minimal VM. > > -Alan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131122/fada8386/attachment.html From mikael.gerdin at oracle.com Fri Nov 22 00:51:03 2013 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Fri, 22 Nov 2013 09:51:03 +0100 Subject: jstack and the target output In-Reply-To: References: <528E4E68.1050403@oracle.com> Message-ID: <1973377.nqVMCdxkVJ@mgerdin03> Piotr, On Friday 22 November 2013 09.21.56 Piotr Bzdyl wrote: > Is there any other information I could collect to help troubleshoot this > problem? How could I check if VM runs with attach disabled? The comments in http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java describe the handshaking involved in dynamically enabling the attach mechanism on Linux. The mechanism is basically: * The attacher checks for the existence of the socket file /tmp/.java_pid${PID} * If that does not exist it creates a file .attach_pid${PID} in the target process' working directory and sends a SIGQUIT (kill -QUIT) to that process. * The SIGQUIT handler notices the .attach_pid${PID} file and creates the socket at /tmp/.java_pid${PID} * The attacher notices the socket file and unlinks the .attach_pid${PID} file. You can force the target process to always create the socket file at startup by using the -XX:+StartAttachListener command line flag. To further troubleshoot the problem I suggest that you try strace:ing the target process and jstack with the following flags enabled: (target process) $ strace -f -e trace=accept,stat,socket,bind $JAVA_HOME/bin/java donothing (jstack process) $ strace -f -e trace=open,connect,stat,unlink,write,kill $JAVA_HOME/bin/jstack You should get something similar to the following: (target process) (...) [pid 12602] --- SIGQUIT {si_signo=SIGQUIT, si_code=SI_USER, si_pid=12687, si_uid=726} --- [pid 12630] stat(".attach_pid12602", {st_mode=S_IFREG|0644, st_size=0, ...}) = 0 Process 12733 attached [pid 12733] socket(PF_LOCAL, SOCK_STREAM, 0) = 5 [pid 12733] bind(5, {sa_family=AF_LOCAL, sun_path="/tmp/.java_pid12602.tmp"}, 110) = 0 [pid 12733] accept(5, {sa_family=AF_LOCAL, NULL}, [2]) = 6 (jstack process) [pid 12688] stat("/localhome/java/jdk-8-ea-bin- b112/jre/lib/amd64/libattach.so", {st_mode=S_IFREG|0755, st_size=16029, ...}) = 0 [pid 12688] open("/localhome/java/jdk-8-ea-bin- b112/jre/lib/amd64/libattach.so", O_RDONLY) = 7 [pid 12688] open("/localhome/java/jdk-8-ea-bin- b112/jre/lib/amd64/libattach.so", O_RDONLY|O_CLOEXEC) = 7 [pid 12688] stat("/tmp/.java_pid12602", 0x7fe53183e3a0) = -1 ENOENT (No such file or directory) [pid 12688] open("/proc/12602/cwd/.attach_pid12602", O_RDWR|O_CREAT|O_EXCL, 0666) = 7 [pid 12688] kill(12602, SIGQUIT) = 0 [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, st_size=0, ...}) = 0 [pid 12688] unlink("/proc/12602/cwd/.attach_pid12602") = 0 [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, st_size=0, ...}) = 0 [pid 12688] connect(7, {sa_family=AF_LOCAL, sun_path="/tmp/.java_pid12602"}, 110) = 0 [pid 12688] connect(7, {sa_family=AF_LOCAL, sun_path="/tmp/.java_pid12602"}, 110) = 0 [pid 12688] write(7, "1", 1) = 1 [pid 12688] write(7, "\0", 1) = 1 [pid 12688] write(7, "threaddump", 10) = 10 [pid 12688] write(7, "\0", 1) = 1 /Mikael > > I noticed the same behavior when trying to connect to the process using > JConsole: JConsole displays the sample app in the list and when I try to > connect it finally displays an error that it cannot connect whereas the > sample app prints thread dump on its console. > > On Thu, Nov 21, 2013 at 7:18 PM, Alan Bateman wrote: > > On 21/11/2013 14:47, David Holmes wrote: > >> I can recreate this using the minimal VM, which doesn't support > >> libattach. So it definitely seems like something is going wrong in the > >> attach process, but I can't say what. Not sure what debugging hooks we > >> have > >> for the attach mechanism ?? > > > > The first attach involves signaling the target VM to start up the attach > > mechanism. So for the minimal VM or a VM running with attach disabled (or > > as Staffan pointed out, running with a different tmp directory) then the > > target VM gets a SIGQUIT and just prints the thread dump. It's hard to say > > what Piotr is running into but I think this at least explains it for the > > minimal VM. > > > > -Alan From piotr at bzdyl.net Fri Nov 22 01:30:50 2013 From: piotr at bzdyl.net (Piotr Bzdyl) Date: Fri, 22 Nov 2013 10:30:50 +0100 Subject: jstack and the target output In-Reply-To: <1973377.nqVMCdxkVJ@mgerdin03> References: <528E4E68.1050403@oracle.com> <1973377.nqVMCdxkVJ@mgerdin03> Message-ID: Thank you Mikael for the detailed information - I learned a lot about how SA tools attache to the target process. When I was running the test you suggested I noticed one "detail" in my setup which turned out to be the cause of my problems: as I mentioned previously I was running my tests inside a virtual machine (namely VirtualBox). The issue was that the cwd dir of my target process was on the mounted shared directory (vboxsf filesystem) in VirtualBox VM and it was causing the problems. I still have to go through the strace outputs to find out if it is because of the access rights of because how vboxsf file system driver works (attached the output). On Fri, Nov 22, 2013 at 9:51 AM, Mikael Gerdin wrote: > Piotr, > > On Friday 22 November 2013 09.21.56 Piotr Bzdyl wrote: > > Is there any other information I could collect to help troubleshoot this > > problem? How could I check if VM runs with attach disabled? > > The comments in > > http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java > describe the handshaking involved in dynamically enabling the attach > mechanism > on Linux. > > The mechanism is basically: > * The attacher checks for the existence of the socket file > /tmp/.java_pid${PID} > * If that does not exist it creates a file .attach_pid${PID} in the target > process' working directory and sends a SIGQUIT (kill -QUIT) to that > process. > * The SIGQUIT handler notices the .attach_pid${PID} file and creates the > socket at /tmp/.java_pid${PID} > * The attacher notices the socket file and unlinks the .attach_pid${PID} > file. > > You can force the target process to always create the socket file at > startup > by using the -XX:+StartAttachListener command line flag. > > To further troubleshoot the problem I suggest that you try strace:ing the > target process and jstack with the following flags enabled: > > (target process) > $ strace -f -e trace=accept,stat,socket,bind $JAVA_HOME/bin/java donothing > > (jstack process) > $ strace -f -e trace=open,connect,stat,unlink,write,kill > $JAVA_HOME/bin/jstack > > > You should get something similar to the following: > (target process) > (...) > [pid 12602] --- SIGQUIT {si_signo=SIGQUIT, si_code=SI_USER, si_pid=12687, > si_uid=726} --- > [pid 12630] stat(".attach_pid12602", {st_mode=S_IFREG|0644, st_size=0, > ...}) = > 0 > Process 12733 attached > [pid 12733] socket(PF_LOCAL, SOCK_STREAM, 0) = 5 > [pid 12733] bind(5, {sa_family=AF_LOCAL, > sun_path="/tmp/.java_pid12602.tmp"}, > 110) = 0 > [pid 12733] accept(5, {sa_family=AF_LOCAL, NULL}, [2]) = 6 > > (jstack process) > [pid 12688] stat("/localhome/java/jdk-8-ea-bin- > b112/jre/lib/amd64/libattach.so", {st_mode=S_IFREG|0755, st_size=16029, > ...}) > = 0 > [pid 12688] open("/localhome/java/jdk-8-ea-bin- > b112/jre/lib/amd64/libattach.so", O_RDONLY) = 7 > [pid 12688] open("/localhome/java/jdk-8-ea-bin- > b112/jre/lib/amd64/libattach.so", O_RDONLY|O_CLOEXEC) = 7 > [pid 12688] stat("/tmp/.java_pid12602", 0x7fe53183e3a0) = -1 ENOENT (No > such > file or directory) > [pid 12688] open("/proc/12602/cwd/.attach_pid12602", O_RDWR|O_CREAT|O_EXCL, > 0666) = 7 > [pid 12688] kill(12602, SIGQUIT) = 0 > [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, st_size=0, > ...}) = 0 > [pid 12688] unlink("/proc/12602/cwd/.attach_pid12602") = 0 > [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, st_size=0, > ...}) = 0 > [pid 12688] connect(7, {sa_family=AF_LOCAL, > sun_path="/tmp/.java_pid12602"}, > 110) = 0 > [pid 12688] connect(7, {sa_family=AF_LOCAL, > sun_path="/tmp/.java_pid12602"}, > 110) = 0 > [pid 12688] write(7, "1", 1) = 1 > [pid 12688] write(7, "\0", 1) = 1 > [pid 12688] write(7, "threaddump", 10) = 10 > [pid 12688] write(7, "\0", 1) = 1 > > /Mikael > > > > > I noticed the same behavior when trying to connect to the process using > > JConsole: JConsole displays the sample app in the list and when I try to > > connect it finally displays an error that it cannot connect whereas the > > sample app prints thread dump on its console. > > > > On Thu, Nov 21, 2013 at 7:18 PM, Alan Bateman > wrote: > > > On 21/11/2013 14:47, David Holmes wrote: > > >> I can recreate this using the minimal VM, which doesn't support > > >> libattach. So it definitely seems like something is going wrong in the > > >> attach process, but I can't say what. Not sure what debugging hooks we > > >> have > > >> for the attach mechanism ?? > > > > > > The first attach involves signaling the target VM to start up the > attach > > > mechanism. So for the minimal VM or a VM running with attach disabled > (or > > > as Staffan pointed out, running with a different tmp directory) then > the > > > target VM gets a SIGQUIT and just prints the thread dump. It's hard to > say > > > what Piotr is running into but I think this at least explains it for > the > > > minimal VM. > > > > > > -Alan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131122/2a0b1eb6/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: strace-out.tgz Type: application/x-gzip Size: 3044 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131122/2a0b1eb6/strace-out-0001.tgz From sean.coffey at oracle.com Fri Nov 22 01:58:40 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 22 Nov 2013 09:58:40 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131122095935.EEE41627A8@hg.openjdk.java.net> Changeset: cd56de5896b4 Author: aefimov Date: 2013-11-15 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd56de5896b4 8027848: The ZoneInfoFile doesn't honor future GMT offset changes Reviewed-by: sherman, coffeys ! src/share/classes/sun/util/calendar/ZoneInfoFile.java Changeset: ebd47f6ab172 Author: aefimov Date: 2013-11-21 20:48 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebd47f6ab172 8027370: Support tzdata2013h Reviewed-by: sherman, coffeys ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/southamerica ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/southamerica Changeset: 3b50d682e7c1 Author: coffeys Date: 2013-11-22 09:56 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b50d682e7c1 Merge From volker.simonis at gmail.com Fri Nov 22 02:45:25 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 22 Nov 2013 11:45:25 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: We've synced our staging repository yesterday with the latest jdk8-b117 and I noticed that change "8025985: com.sun.management.OSMBeanFactory should not be public" moved the file src/solaris/native/com/sun/ management/UnixOperatingSystem_md.c to src/solaris/native/sun/management/OperatingSystemImpl.c. Fortunately, my changes to UnixOperatingSystem_md.c described in the webrev apply cleanly to the new file (I've tested this locally). I'll update the webrev accordingly once I've collected some more feedback. Thank you and best regards, Volker On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I need > the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. > So please don't hesitate to jump at it - there are enough changes for > everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for collecting > them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > - Added these two files for AIX relevant utility code. > - Currently these files only contain an implementation of dladdr which > is not available on AIX. > - In the first review round the existing dladdr users in the code > either called the version from the HotSpot on AIX ( > src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of > the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). > This is now not necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > makefiles/CompileDemos.gmk > > - Add an extra argument to SetupJVMTIDemo which can be used to pass > additional source locations. > - Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > - On AIX add the sources of the AIX porting utilities to the build. > They are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and > src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not > available on AIX. > > makefiles/lib/NioLibraries.gmk > > - Make the AIX-build aware of the new NIO source locations under > src/aix/native/sun/nio/. > > makefiles/lib/NetworkingLibraries.gmk > > - Make the AIX-build aware of the new aix_close.c source location > under src/aix/native/java/net/. > > src/share/bin/jli_util.h > > - Define JLI_Lseek on AIX. > > src/share/lib/security/java.security-aix > > - Provide default java.security-aix for AIX based on the latest Linux > version as suggested by Sean Mullan. > > src/share/native/common/check_code.c > > - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in check_code.c does not handles this properly. So > we wrap the two methods on AIX and return a non-NULL pointer even if we > allocate 0 bytes. > > src/share/native/sun/awt/medialib/mlib_sys.c > > - malloc always returns 8-byte aligned pointers on AIX as well. > > src/share/native/sun/awt/medialib/mlib_types.h > > - Add AIX to the list of known platforms. > > src/share/native/sun/font/layout/KernTable.cpp > > - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too > common and may be defined in other headers as well as on the command line > and xlc bails out on macro redefinitions with a different value. > > src/share/native/sun/security/ec/impl/ecc_impl.h > > - Define required types and macros on AIX. > > src/solaris/back/exec_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > - On AIX LD_LIBRARY_PATH is called LIBPATH > - Always use LD_LIBRARY_PATH macro instead of using the string " > LD_LIBRARY_PATH" directly to cope with different library path names. > - Add jre/lib//jli to the standard library search path on AIX > because the AIX linker doesn't support the -rpath option. > - Replace #ifdef __linux__ by #ifndef __solaris__ because in this > case, AIX behaves like Linux. > - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from > java_md_solinux.h because the macros are redefined in the > corresponding .c files anyway. > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > - Provide basic fontconfig.propertiesfor AIX. > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > - Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > - Detect AIX operating system and return the corresponding channel and > file system providers. > > src/solaris/classes/sun/nio/ch/Port.java > > - Add a callback function unregisterImpl(int fd) for implementations > that need special handling when fd is removed and call it from unregister(int > fd). By default the implementation of unregisterImpl(int fd) is empty > except for the derived AixPollPort class on AIX. > > src/solaris/demo/jvmti/hprof/hprof_md.c > > - Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no dladdr functionality. > - Use the dladdr implementation from porting_aix.{c,h} on AIX. > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). > > src/solaris/native/common/jdk_util_md.h > > - Add AIX definitions of the ISNANF and ISNAND macros. > > src/solaris/native/java/io/io_util_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/native/java/lang/UNIXProcess_md.c > > - AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > src/solaris/native/java/lang/childproc.c > > - AIX does not understand '/proc/self' - it requires the real process > ID to query the proc file system for the current process. > > src/solaris/native/java/net/NetworkInterface.c > > - Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > - AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > - Moved the declaration of siocgifconfRequest to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > src/solaris/native/java/net/PlainSocketImpl.c > > - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the > socket is closed. The default error message is then confusing. > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > - As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of linux_close.c to src/aix/native/java/net/aix_close.cbecause we also need the file and socket wrappers on AIX. > - Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > - Also, on AIX we don't have __attribute((constructor)) so we need to > initialize manually (from JNI_OnLoad() in > src/share/native/java/net/net_util.c. > > src/solaris/native/java/net/net_util_md.h > > - AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > src/solaris/native/java/net/net_util_md.c > > - SO_REUSEADDR is called SO_REUSEPORT on AIX. > - On AIX we have to ignore failures due to ENOBUFS when setting the > SO_SNDBUF/SO_RCVBUF socket options. > > src/solaris/native/java/util/TimeZone_md.c > > - Currently on AIX the only way to get the platform time zone is to > read it from the TZ environment variable. > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > - Use the dladdr from porting_aix.{c,h} on AIX. > > src/solaris/native/sun/awt/fontpath.c > > - Changed some macros from if !defined(__linux__) to if > defined(__solaris__) because that's their real meaning. > - Add AIX specific fontpath settings and library search paths for > libfontconfig.so. > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name > clashes (MIN and MAX are much too common and thexy are already defined > in some AIX system headers). > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > - Handle AIX like Solaris. > > src/solaris/native/sun/nio/ch/Net.c > > - Add AIX-specific includes and constant definitions. > - On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate exceptions > if it is requested but not supported. This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. > - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain the > error code. > - Handle some AIX corner cases for the results of the statvfs64() call. > - On AIX getgrgid_r() returns ESRCH if group does not exist. > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > - Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as isEnglish(), ignore VM-warnings in the output, make sure > the "grandchild" processes created by the test don't run too long (60s vs. > 6666s) because in the case of test problems these processes will pollute > the process space, make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, _AIX is defined in some system headers while AIX is defined by the > build system. This is already used inconsistently (i.e. __linux__ vs. > LINUX) and in general I try to be consistent with the style of the file > where I the changes are. That said, I changes most of the occurences of > AIX to _AIX. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and currently > called IBM i) in our OpenJDK port but we do support it in our internel, SAP > JVM build. We stripped out all the extra OS/400 functionality from the port > but in some places where there is common functionality needd by both, AIX > and OS/400 the OS/400 support may still be visible in the OpenJDK port. I > don't think this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've removed all > the references to OS/400 now. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131122/c71b0541/attachment-0001.html From joel.franck at oracle.com Fri Nov 22 02:38:19 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Fri, 22 Nov 2013 10:38:19 +0000 Subject: hg: jdk8/tl/jdk: 8023278: Reflection API methods do not throw AnnotationFormatError in case of malformed Runtime[In]VisibleTypeAnnotations attribute Message-ID: <20131122103836.EEC29627AA@hg.openjdk.java.net> Changeset: 0775f4f6532a Author: jfranck Date: 2013-11-22 11:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0775f4f6532a 8023278: Reflection API methods do not throw AnnotationFormatError in case of malformed Runtime[In]VisibleTypeAnnotations attribute Reviewed-by: darcy ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/annotation/typeAnnotations/BadCPIndex.java From piotr at bzdyl.net Fri Nov 22 03:59:42 2013 From: piotr at bzdyl.net (Piotr Bzdyl) Date: Fri, 22 Nov 2013 12:59:42 +0100 Subject: jstack and the target output In-Reply-To: References: <528E4E68.1050403@oracle.com> <1973377.nqVMCdxkVJ@mgerdin03> Message-ID: After checking the strace output I notice that the issue was caused by the file mode for files created on vboxsf mount. By default (when automount option is used in virtualbox configuration) it creates .attach_pid with file mode 0770. When I manually mounted shared folder specifying fmode=660 jstack worked as expected. Thank you for pointing me to the right path to narrow down the issue. BTW, where I could find the JVM code responsible for handling SIGQUIT signal to see what it does that file mode matters? On Fri, Nov 22, 2013 at 10:30 AM, Piotr Bzdyl wrote: > Thank you Mikael for the detailed information - I learned a lot about how > SA tools attache to the target process. > > When I was running the test you suggested I noticed one "detail" in my > setup which turned out to be the cause of my problems: as I mentioned > previously I was running my tests inside a virtual machine (namely > VirtualBox). The issue was that the cwd dir of my target process was on the > mounted shared directory (vboxsf filesystem) in VirtualBox VM and it was > causing the problems. I still have to go through the strace outputs to find > out if it is because of the access rights of because how vboxsf file system > driver works (attached the output). > > > On Fri, Nov 22, 2013 at 9:51 AM, Mikael Gerdin wrote: > >> Piotr, >> >> On Friday 22 November 2013 09.21.56 Piotr Bzdyl wrote: >> > Is there any other information I could collect to help troubleshoot this >> > problem? How could I check if VM runs with attach disabled? >> >> The comments in >> >> http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java >> describe the handshaking involved in dynamically enabling the attach >> mechanism >> on Linux. >> >> The mechanism is basically: >> * The attacher checks for the existence of the socket file >> /tmp/.java_pid${PID} >> * If that does not exist it creates a file .attach_pid${PID} in the target >> process' working directory and sends a SIGQUIT (kill -QUIT) to that >> process. >> * The SIGQUIT handler notices the .attach_pid${PID} file and creates the >> socket at /tmp/.java_pid${PID} >> * The attacher notices the socket file and unlinks the .attach_pid${PID} >> file. >> >> You can force the target process to always create the socket file at >> startup >> by using the -XX:+StartAttachListener command line flag. >> >> To further troubleshoot the problem I suggest that you try strace:ing the >> target process and jstack with the following flags enabled: >> >> (target process) >> $ strace -f -e trace=accept,stat,socket,bind $JAVA_HOME/bin/java donothing >> >> (jstack process) >> $ strace -f -e trace=open,connect,stat,unlink,write,kill >> $JAVA_HOME/bin/jstack >> >> >> You should get something similar to the following: >> (target process) >> (...) >> [pid 12602] --- SIGQUIT {si_signo=SIGQUIT, si_code=SI_USER, si_pid=12687, >> si_uid=726} --- >> [pid 12630] stat(".attach_pid12602", {st_mode=S_IFREG|0644, st_size=0, >> ...}) = >> 0 >> Process 12733 attached >> [pid 12733] socket(PF_LOCAL, SOCK_STREAM, 0) = 5 >> [pid 12733] bind(5, {sa_family=AF_LOCAL, >> sun_path="/tmp/.java_pid12602.tmp"}, >> 110) = 0 >> [pid 12733] accept(5, {sa_family=AF_LOCAL, NULL}, [2]) = 6 >> >> (jstack process) >> [pid 12688] stat("/localhome/java/jdk-8-ea-bin- >> b112/jre/lib/amd64/libattach.so", {st_mode=S_IFREG|0755, st_size=16029, >> ...}) >> = 0 >> [pid 12688] open("/localhome/java/jdk-8-ea-bin- >> b112/jre/lib/amd64/libattach.so", O_RDONLY) = 7 >> [pid 12688] open("/localhome/java/jdk-8-ea-bin- >> b112/jre/lib/amd64/libattach.so", O_RDONLY|O_CLOEXEC) = 7 >> [pid 12688] stat("/tmp/.java_pid12602", 0x7fe53183e3a0) = -1 ENOENT (No >> such >> file or directory) >> [pid 12688] open("/proc/12602/cwd/.attach_pid12602", >> O_RDWR|O_CREAT|O_EXCL, >> 0666) = 7 >> [pid 12688] kill(12602, SIGQUIT) = 0 >> [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, st_size=0, >> ...}) = 0 >> [pid 12688] unlink("/proc/12602/cwd/.attach_pid12602") = 0 >> [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, st_size=0, >> ...}) = 0 >> [pid 12688] connect(7, {sa_family=AF_LOCAL, >> sun_path="/tmp/.java_pid12602"}, >> 110) = 0 >> [pid 12688] connect(7, {sa_family=AF_LOCAL, >> sun_path="/tmp/.java_pid12602"}, >> 110) = 0 >> [pid 12688] write(7, "1", 1) = 1 >> [pid 12688] write(7, "\0", 1) = 1 >> [pid 12688] write(7, "threaddump", 10) = 10 >> [pid 12688] write(7, "\0", 1) = 1 >> >> /Mikael >> >> > >> > I noticed the same behavior when trying to connect to the process using >> > JConsole: JConsole displays the sample app in the list and when I try to >> > connect it finally displays an error that it cannot connect whereas the >> > sample app prints thread dump on its console. >> > >> > On Thu, Nov 21, 2013 at 7:18 PM, Alan Bateman >> wrote: >> > > On 21/11/2013 14:47, David Holmes wrote: >> > >> I can recreate this using the minimal VM, which doesn't support >> > >> libattach. So it definitely seems like something is going wrong in >> the >> > >> attach process, but I can't say what. Not sure what debugging hooks >> we >> > >> have >> > >> for the attach mechanism ?? >> > > >> > > The first attach involves signaling the target VM to start up the >> attach >> > > mechanism. So for the minimal VM or a VM running with attach disabled >> (or >> > > as Staffan pointed out, running with a different tmp directory) then >> the >> > > target VM gets a SIGQUIT and just prints the thread dump. It's hard >> to say >> > > what Piotr is running into but I think this at least explains it for >> the >> > > minimal VM. >> > > >> > > -Alan >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131122/c40f9840/attachment.html From mikael.gerdin at oracle.com Fri Nov 22 04:17:28 2013 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Fri, 22 Nov 2013 13:17:28 +0100 Subject: jstack and the target output In-Reply-To: References: Message-ID: <1776617.MpLX0xEhNQ@mgerdin03> On Friday 22 November 2013 12.59.42 Piotr Bzdyl wrote: > After checking the strace output I notice that the issue was caused by the > file mode for files created on vboxsf mount. By default (when automount > option is used in virtualbox configuration) it creates .attach_pid > with file mode 0770. When I manually mounted shared folder specifying > fmode=660 jstack worked as expected. > > Thank you for pointing me to the right path to narrow down the issue. > > BTW, where I could find the JVM code responsible for handling SIGQUIT > signal to see what it does that file mode matters? http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/file/tip/src/os/linux/vm/attachListener_linux.cpp and http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/file/tip/src/share/vm/runtime/os.cpp (see signal_thread_entry and its call to AttachListener::is_init_trigger() /Mikael > > On Fri, Nov 22, 2013 at 10:30 AM, Piotr Bzdyl wrote: > > Thank you Mikael for the detailed information - I learned a lot about how > > SA tools attache to the target process. > > > > When I was running the test you suggested I noticed one "detail" in my > > setup which turned out to be the cause of my problems: as I mentioned > > previously I was running my tests inside a virtual machine (namely > > VirtualBox). The issue was that the cwd dir of my target process was on > > the > > mounted shared directory (vboxsf filesystem) in VirtualBox VM and it was > > causing the problems. I still have to go through the strace outputs to > > find > > out if it is because of the access rights of because how vboxsf file > > system > > driver works (attached the output). > > > > On Fri, Nov 22, 2013 at 9:51 AM, Mikael Gerdin wrote: > >> Piotr, > >> > >> On Friday 22 November 2013 09.21.56 Piotr Bzdyl wrote: > >> > Is there any other information I could collect to help troubleshoot > >> > this > >> > problem? How could I check if VM runs with attach disabled? > >> > >> The comments in > >> > >> http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/solaris/classes/sun > >> /tools/attach/LinuxVirtualMachine.java describe the handshaking involved > >> in dynamically enabling the attach mechanism > >> on Linux. > >> > >> The mechanism is basically: > >> * The attacher checks for the existence of the socket file > >> /tmp/.java_pid${PID} > >> * If that does not exist it creates a file .attach_pid${PID} in the > >> target > >> process' working directory and sends a SIGQUIT (kill -QUIT) to that > >> process. > >> * The SIGQUIT handler notices the .attach_pid${PID} file and creates the > >> socket at /tmp/.java_pid${PID} > >> * The attacher notices the socket file and unlinks the .attach_pid${PID} > >> file. > >> > >> You can force the target process to always create the socket file at > >> startup > >> by using the -XX:+StartAttachListener command line flag. > >> > >> To further troubleshoot the problem I suggest that you try strace:ing the > >> target process and jstack with the following flags enabled: > >> > >> (target process) > >> $ strace -f -e trace=accept,stat,socket,bind $JAVA_HOME/bin/java > >> donothing > >> > >> (jstack process) > >> $ strace -f -e trace=open,connect,stat,unlink,write,kill > >> $JAVA_HOME/bin/jstack > >> > >> > >> You should get something similar to the following: > >> (target process) > >> (...) > >> [pid 12602] --- SIGQUIT {si_signo=SIGQUIT, si_code=SI_USER, si_pid=12687, > >> si_uid=726} --- > >> [pid 12630] stat(".attach_pid12602", {st_mode=S_IFREG|0644, st_size=0, > >> ...}) = > >> 0 > >> Process 12733 attached > >> [pid 12733] socket(PF_LOCAL, SOCK_STREAM, 0) = 5 > >> [pid 12733] bind(5, {sa_family=AF_LOCAL, > >> sun_path="/tmp/.java_pid12602.tmp"}, > >> 110) = 0 > >> [pid 12733] accept(5, {sa_family=AF_LOCAL, NULL}, [2]) = 6 > >> > >> (jstack process) > >> [pid 12688] stat("/localhome/java/jdk-8-ea-bin- > >> b112/jre/lib/amd64/libattach.so", {st_mode=S_IFREG|0755, st_size=16029, > >> ...}) > >> = 0 > >> [pid 12688] open("/localhome/java/jdk-8-ea-bin- > >> b112/jre/lib/amd64/libattach.so", O_RDONLY) = 7 > >> [pid 12688] open("/localhome/java/jdk-8-ea-bin- > >> b112/jre/lib/amd64/libattach.so", O_RDONLY|O_CLOEXEC) = 7 > >> [pid 12688] stat("/tmp/.java_pid12602", 0x7fe53183e3a0) = -1 ENOENT (No > >> such > >> file or directory) > >> [pid 12688] open("/proc/12602/cwd/.attach_pid12602", > >> O_RDWR|O_CREAT|O_EXCL, > >> 0666) = 7 > >> [pid 12688] kill(12602, SIGQUIT) = 0 > >> [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, > >> st_size=0, > >> ...}) = 0 > >> [pid 12688] unlink("/proc/12602/cwd/.attach_pid12602") = 0 > >> [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, > >> st_size=0, > >> ...}) = 0 > >> [pid 12688] connect(7, {sa_family=AF_LOCAL, > >> sun_path="/tmp/.java_pid12602"}, > >> 110) = 0 > >> [pid 12688] connect(7, {sa_family=AF_LOCAL, > >> sun_path="/tmp/.java_pid12602"}, > >> 110) = 0 > >> [pid 12688] write(7, "1", 1) = 1 > >> [pid 12688] write(7, "\0", 1) = 1 > >> [pid 12688] write(7, "threaddump", 10) = 10 > >> [pid 12688] write(7, "\0", 1) = 1 > >> > >> /Mikael > >> > >> > I noticed the same behavior when trying to connect to the process using > >> > JConsole: JConsole displays the sample app in the list and when I try > >> > to > >> > connect it finally displays an error that it cannot connect whereas the > >> > sample app prints thread dump on its console. > >> > > >> > On Thu, Nov 21, 2013 at 7:18 PM, Alan Bateman > >> > >> wrote: > >> > > On 21/11/2013 14:47, David Holmes wrote: > >> > >> I can recreate this using the minimal VM, which doesn't support > >> > >> libattach. So it definitely seems like something is going wrong in > >> > >> the > >> > >> > >> attach process, but I can't say what. Not sure what debugging hooks > >> > >> we > >> > >> > >> have > >> > >> for the attach mechanism ?? > >> > > > >> > > The first attach involves signaling the target VM to start up the > >> > >> attach > >> > >> > > mechanism. So for the minimal VM or a VM running with attach disabled > >> > >> (or > >> > >> > > as Staffan pointed out, running with a different tmp directory) then > >> > >> the > >> > >> > > target VM gets a SIGQUIT and just prints the thread dump. It's hard > >> > >> to say > >> > >> > > what Piotr is running into but I think this at least explains it for > >> > >> the > >> > >> > > minimal VM. > >> > > > >> > > -Alan From piotr at bzdyl.net Fri Nov 22 05:01:53 2013 From: piotr at bzdyl.net (Piotr Bzdyl) Date: Fri, 22 Nov 2013 14:01:53 +0100 Subject: jstack and the target output In-Reply-To: <1776617.MpLX0xEhNQ@mgerdin03> References: <1776617.MpLX0xEhNQ@mgerdin03> Message-ID: Thank you Mikael. Now with the is_init_trigger() code I understand that it wasn't the problem with file mask but rather with the file owner (lines 504-507 from http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/file/tip/src/os/linux/vm/attachListener_linux.cpp ). What helped was specyfing uid i gid options to mount where provided IDs were IDs of the user running jvm. On Fri, Nov 22, 2013 at 1:17 PM, Mikael Gerdin wrote: > On Friday 22 November 2013 12.59.42 Piotr Bzdyl wrote: > > After checking the strace output I notice that the issue was caused by > the > > file mode for files created on vboxsf mount. By default (when automount > > option is used in virtualbox configuration) it creates .attach_pid > > with file mode 0770. When I manually mounted shared folder specifying > > fmode=660 jstack worked as expected. > > > > Thank you for pointing me to the right path to narrow down the issue. > > > > BTW, where I could find the JVM code responsible for handling SIGQUIT > > signal to see what it does that file mode matters? > > > http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/file/tip/src/os/linux/vm/attachListener_linux.cpp > > and > > > http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/file/tip/src/share/vm/runtime/os.cpp > (see signal_thread_entry and its call to AttachListener::is_init_trigger() > > /Mikael > > > > > > On Fri, Nov 22, 2013 at 10:30 AM, Piotr Bzdyl wrote: > > > Thank you Mikael for the detailed information - I learned a lot about > how > > > SA tools attache to the target process. > > > > > > When I was running the test you suggested I noticed one "detail" in my > > > setup which turned out to be the cause of my problems: as I mentioned > > > previously I was running my tests inside a virtual machine (namely > > > VirtualBox). The issue was that the cwd dir of my target process was on > > > the > > > mounted shared directory (vboxsf filesystem) in VirtualBox VM and it > was > > > causing the problems. I still have to go through the strace outputs to > > > find > > > out if it is because of the access rights of because how vboxsf file > > > system > > > driver works (attached the output). > > > > > > On Fri, Nov 22, 2013 at 9:51 AM, Mikael Gerdin > wrote: > > >> Piotr, > > >> > > >> On Friday 22 November 2013 09.21.56 Piotr Bzdyl wrote: > > >> > Is there any other information I could collect to help troubleshoot > > >> > this > > >> > problem? How could I check if VM runs with attach disabled? > > >> > > >> The comments in > > >> > > >> > http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/solaris/classes/sun > > >> /tools/attach/LinuxVirtualMachine.java describe the handshaking > involved > > >> in dynamically enabling the attach mechanism > > >> on Linux. > > >> > > >> The mechanism is basically: > > >> * The attacher checks for the existence of the socket file > > >> /tmp/.java_pid${PID} > > >> * If that does not exist it creates a file .attach_pid${PID} in the > > >> target > > >> process' working directory and sends a SIGQUIT (kill -QUIT) to that > > >> process. > > >> * The SIGQUIT handler notices the .attach_pid${PID} file and creates > the > > >> socket at /tmp/.java_pid${PID} > > >> * The attacher notices the socket file and unlinks the > .attach_pid${PID} > > >> file. > > >> > > >> You can force the target process to always create the socket file at > > >> startup > > >> by using the -XX:+StartAttachListener command line flag. > > >> > > >> To further troubleshoot the problem I suggest that you try strace:ing > the > > >> target process and jstack with the following flags enabled: > > >> > > >> (target process) > > >> $ strace -f -e trace=accept,stat,socket,bind $JAVA_HOME/bin/java > > >> donothing > > >> > > >> (jstack process) > > >> $ strace -f -e trace=open,connect,stat,unlink,write,kill > > >> $JAVA_HOME/bin/jstack > > >> > > >> > > >> You should get something similar to the following: > > >> (target process) > > >> (...) > > >> [pid 12602] --- SIGQUIT {si_signo=SIGQUIT, si_code=SI_USER, > si_pid=12687, > > >> si_uid=726} --- > > >> [pid 12630] stat(".attach_pid12602", {st_mode=S_IFREG|0644, st_size=0, > > >> ...}) = > > >> 0 > > >> Process 12733 attached > > >> [pid 12733] socket(PF_LOCAL, SOCK_STREAM, 0) = 5 > > >> [pid 12733] bind(5, {sa_family=AF_LOCAL, > > >> sun_path="/tmp/.java_pid12602.tmp"}, > > >> 110) = 0 > > >> [pid 12733] accept(5, {sa_family=AF_LOCAL, NULL}, [2]) = 6 > > >> > > >> (jstack process) > > >> [pid 12688] stat("/localhome/java/jdk-8-ea-bin- > > >> b112/jre/lib/amd64/libattach.so", {st_mode=S_IFREG|0755, > st_size=16029, > > >> ...}) > > >> = 0 > > >> [pid 12688] open("/localhome/java/jdk-8-ea-bin- > > >> b112/jre/lib/amd64/libattach.so", O_RDONLY) = 7 > > >> [pid 12688] open("/localhome/java/jdk-8-ea-bin- > > >> b112/jre/lib/amd64/libattach.so", O_RDONLY|O_CLOEXEC) = 7 > > >> [pid 12688] stat("/tmp/.java_pid12602", 0x7fe53183e3a0) = -1 ENOENT > (No > > >> such > > >> file or directory) > > >> [pid 12688] open("/proc/12602/cwd/.attach_pid12602", > > >> O_RDWR|O_CREAT|O_EXCL, > > >> 0666) = 7 > > >> [pid 12688] kill(12602, SIGQUIT) = 0 > > >> [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, > > >> st_size=0, > > >> ...}) = 0 > > >> [pid 12688] unlink("/proc/12602/cwd/.attach_pid12602") = 0 > > >> [pid 12688] stat("/tmp/.java_pid12602", {st_mode=S_IFSOCK|0600, > > >> st_size=0, > > >> ...}) = 0 > > >> [pid 12688] connect(7, {sa_family=AF_LOCAL, > > >> sun_path="/tmp/.java_pid12602"}, > > >> 110) = 0 > > >> [pid 12688] connect(7, {sa_family=AF_LOCAL, > > >> sun_path="/tmp/.java_pid12602"}, > > >> 110) = 0 > > >> [pid 12688] write(7, "1", 1) = 1 > > >> [pid 12688] write(7, "\0", 1) = 1 > > >> [pid 12688] write(7, "threaddump", 10) = 10 > > >> [pid 12688] write(7, "\0", 1) = 1 > > >> > > >> /Mikael > > >> > > >> > I noticed the same behavior when trying to connect to the process > using > > >> > JConsole: JConsole displays the sample app in the list and when I > try > > >> > to > > >> > connect it finally displays an error that it cannot connect whereas > the > > >> > sample app prints thread dump on its console. > > >> > > > >> > On Thu, Nov 21, 2013 at 7:18 PM, Alan Bateman > > >> > > >> wrote: > > >> > > On 21/11/2013 14:47, David Holmes wrote: > > >> > >> I can recreate this using the minimal VM, which doesn't support > > >> > >> libattach. So it definitely seems like something is going wrong > in > > >> > > >> the > > >> > > >> > >> attach process, but I can't say what. Not sure what debugging > hooks > > >> > > >> we > > >> > > >> > >> have > > >> > >> for the attach mechanism ?? > > >> > > > > >> > > The first attach involves signaling the target VM to start up the > > >> > > >> attach > > >> > > >> > > mechanism. So for the minimal VM or a VM running with attach > disabled > > >> > > >> (or > > >> > > >> > > as Staffan pointed out, running with a different tmp directory) > then > > >> > > >> the > > >> > > >> > > target VM gets a SIGQUIT and just prints the thread dump. It's > hard > > >> > > >> to say > > >> > > >> > > what Piotr is running into but I think this at least explains it > for > > >> > > >> the > > >> > > >> > > minimal VM. > > >> > > > > >> > > -Alan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131122/25afbfe1/attachment-0001.html From Alan.Bateman at oracle.com Fri Nov 22 05:24:56 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 22 Nov 2013 13:24:56 +0000 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: <528DF61B.6060403@oracle.com> Message-ID: <528F5B28.7000404@oracle.com> On 21/11/2013 15:54, Volker Simonis wrote: > : > But actually I've just realized that it is not need at all, because > 'aix_close.c' isn't in the PATH for any other OS than AIX (that could > be probably called a feature of the new file layout:) So I'll simply > change it to: > 48 ifeq ($(OPENJDK_TARGET_OS), aix) > 49 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ > 50 endif This make sense. > > Yes, exactly. I didn't wanted to change too much code. But as the > C-Standard states > (http://pubs.opengroup.org/onlinepubs/000095399/functions/malloc.html) > "...If size is 0, either a null pointer or a unique pointer that can > be successfully passed to free() shall be returned..." it is perfectly > legal that malloc/calloc return a NULL pointer if called with a zero > argument. This case is currently not handled (i.e. it's handled as an > 'out of memory' error) in check_code.c and I agree that this should be > fixed via a separate bug. Yes, let's use a separate bug for this. > In net_util.c then it's a bit ugly to be calling aix_close_init. > Michael/Chris - what you would think about the JNI_OnLoad calling > into a platform specific function to do platform specific > initialization? > > > What about renaming 'initLocalAddrTable()' into something like > 'platformInit()' and moving the call to 'aix_close_init' to a > AIX-specific version of 'platformInit()' in net_util_md.c? I don't have a strong opinion on the name of the function, platformInit is fine for now. > : > > > You're right - we could rename it to something like 'java_md_unix.c'. > But no matter how fancy the name would be, the file would still be in > the 'src/solaris/bin' subdirectory:( So I think we'd better leave this > for a later change when we completely factor out the Linux/Mac code > from the 'solaris/' directory. I think JDK 9 is a good time to finally tackle this issue (as you probably know, this is something that I've brought up on porters-dev or build-dev a few times). > Port.java - one suggestion for unregisterImpl is to rename it to > preUnregister and change it to protected so that it's more obvious > that it supposed to be overridden. > > > Done. Also changed the comment to JavaDoc style to be more consistent > with the other comments in that file. Thanks. > UnixNativeDispatcher.c - this looks okay (must reduced since the > first round), I just wonder if the changes to *_getpwuid and > *_getgrgid are really needed as this just impacts the error > message. Also might be good to indent the #ifdef to be consistent > with the other usages in these functions. > > > You're right. This change was done before you fixed "7043788: (fs) > PosixFileAttributes.owner() or group() throws NPE if owner/group not > in passwd/group database" > (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f91c799f7bfb). After > you're fix it was "automatically" adapted. I've removed the special > AIX handling as suggested because I think as well that another error > message in the exception won't have any impact. Thanks. > : > > > I'm currently working on it and created "8028537: PPC64: Updated > jdk/test scripts to understand the AIX os and environment" for it > because I didn't wanted to blow up this change unnecessarily. Okay. So overall I think this patch is in good shape (I have not reviewed the AWT/2D/client changes in any detail) and I don't see any blocking issues to this going in. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131122/30623543/attachment.html From jaroslav.bachorik at oracle.com Fri Nov 22 05:57:11 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 22 Nov 2013 14:57:11 +0100 Subject: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS In-Reply-To: <528E3A16.6060401@oracle.com> References: <528B7448.3090005@oracle.com> <528E3A16.6060401@oracle.com> Message-ID: <528F62B7.3060207@oracle.com> On 21.11.2013 17:51, Mandy Chung wrote: > Hi Jaroslav, > > On 11/19/2013 6:23 AM, Jaroslav Bachorik wrote: >> Please, review this test fix. >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 >> Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 >> >> The fix moves the execution of the test routine to the >> GarbageCollectorMXBean notification handler - at that moment it's >> certain that GC has already happened and it is safe to assert the data >> provided by the MBean. > > This patch may have a potential issue when GC happens during the process > of adding the notification handlers such as the number of increments is > greater than the number of registered handlers. By the time the main > thread reaches p.arriveAndAwaitAdvance, the phaser has advanced to the > next phase with few arrived parties and will wait forever (until the > next GC happens). This should rarely happen though. Note that > p.arriveAndAwaitAdvance continue to run even if the thread is > interrupted and what happens if jtreg attempts to time out the test? Thanks for catching this. It seems that using a Semaphore with adding permissions when a GC notification arrives would be more stable. > > Does this issue only happen to CMS with background GC thread? The > proposed patch seems a little overkill. I wonder if the test should > skip if running in CMS background mode. Does > -XX:+ExplicitGCInvokesConcurrent flag will get System.gc() to run in > foreground mode in CMS (I think that may get the GC to complete before > System.gc() returns?) Yes, currently only CMS. It seems that the semantics of System.gc() ("When control returns from the method call, the Java Virtual Machine has made a best effort to reclaim space from all discarded objects.") doesn't apply to the CMS collector. Adding "-XX:-ExplicitGCInvokesConcurrent" should force System.gc() to wait till the GC has been performed. This could help resolve this particular problem. -JB- > > Mandy > From volker.simonis at gmail.com Fri Nov 22 08:37:55 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 22 Nov 2013 17:37:55 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <528F5B28.7000404@oracle.com> References: <528DF61B.6060403@oracle.com> <528F5B28.7000404@oracle.com> Message-ID: Hi Alan, so I'll rename 'initLocalAddrTable()' into 'platformInit()' and move the call to 'aix_close_init' to a AIX-specific version of 'platformInit()' in net_util_md.c as discussed. I'll post a final webrev once I got the comments from the AWT/2D guys. As far as I understood, you've now reviewed the 'core-lib'/'net' parts right? That would mean that I'll still need a review from the AWT/2D and the Security group - any volunteers:). Once again thanks a lot for your help, Volker On Fri, Nov 22, 2013 at 2:24 PM, Alan Bateman wrote: > On 21/11/2013 15:54, Volker Simonis wrote: > > : > But actually I've just realized that it is not need at all, because > 'aix_close.c' isn't in the PATH for any other OS than AIX (that could be > probably called a feature of the new file layout:) So I'll simply change it > to: > > 48 ifeq ($(OPENJDK_TARGET_OS), aix) > 49 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ > 50 endif > > This make sense. > > > > > Yes, exactly. I didn't wanted to change too much code. But as the C-Standard > states > (http://pubs.opengroup.org/onlinepubs/000095399/functions/malloc.html) > "...If size is 0, either a null pointer or a unique pointer that can be > successfully passed to free() shall be returned..." it is perfectly legal > that malloc/calloc return a NULL pointer if called with a zero argument. > This case is currently not handled (i.e. it's handled as an 'out of memory' > error) in check_code.c and I agree that this should be fixed via a separate > bug. > > Yes, let's use a separate bug for this. > > > > > >> >> In net_util.c then it's a bit ugly to be calling aix_close_init. >> Michael/Chris - what you would think about the JNI_OnLoad calling into a >> platform specific function to do platform specific initialization? >> > > What about renaming 'initLocalAddrTable()' into something like > 'platformInit()' and moving the call to 'aix_close_init' to a AIX-specific > version of 'platformInit()' in net_util_md.c? > > I don't have a strong opinion on the name of the function, platformInit is > fine for now. > > > > : > > > You're right - we could rename it to something like 'java_md_unix.c'. But no > matter how fancy the name would be, the file would still be in the > 'src/solaris/bin' subdirectory:( So I think we'd better leave this for a > later change when we completely factor out the Linux/Mac code from the > 'solaris/' directory. > > I think JDK 9 is a good time to finally tackle this issue (as you probably > know, this is something that I've brought up on porters-dev or build-dev a > few times). > > > > >> >> Port.java - one suggestion for unregisterImpl is to rename it to >> preUnregister and change it to protected so that it's more obvious that it >> supposed to be overridden. >> > > Done. Also changed the comment to JavaDoc style to be more consistent with > the other comments in that file. > > Thanks. > > > >> >> UnixNativeDispatcher.c - this looks okay (must reduced since the first >> round), I just wonder if the changes to *_getpwuid and *_getgrgid are really >> needed as this just impacts the error message. Also might be good to indent >> the #ifdef to be consistent with the other usages in these functions. >> > > You're right. This change was done before you fixed "7043788: (fs) > PosixFileAttributes.owner() or group() throws NPE if owner/group not in > passwd/group database" > (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f91c799f7bfb). After you're > fix it was "automatically" adapted. I've removed the special AIX handling > as suggested because I think as well that another error message in the > exception won't have any impact. > > Thanks. > > > > : > > > I'm currently working on it and created "8028537: PPC64: Updated jdk/test > scripts to understand the AIX os and environment" for it because I didn't > wanted to blow up this change unnecessarily. > > Okay. > > So overall I think this patch is in good shape (I have not reviewed the > AWT/2D/client changes in any detail) and I don't see any blocking issues to > this going in. > > -Alan > > > From robert.field at oracle.com Fri Nov 22 17:08:04 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Sat, 23 Nov 2013 01:08:04 +0000 Subject: hg: jdk8/tl/langtools: 8028739: javac generates incorrect descriptor for MethodHandle::invoke Message-ID: <20131123010808.22666627CB@hg.openjdk.java.net> Changeset: 4fa835472e3c Author: rfield Date: 2013-11-22 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fa835472e3c 8028739: javac generates incorrect descriptor for MethodHandle::invoke Summary: introduce special handling for signature polymorphic methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestMethodHandle.java From markus.gronlund at oracle.com Sat Nov 23 02:15:37 2013 From: markus.gronlund at oracle.com (markus.gronlund at oracle.com) Date: Sat, 23 Nov 2013 10:15:37 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 9 new changesets Message-ID: <20131123101558.24F54627D6@hg.openjdk.java.net> Changeset: 570aaefce624 Author: morris Date: 2013-11-18 12:26 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/570aaefce624 8028319: ConflictingDefaultsTest.testReabstract spins when running with -mode invoke and -Xcomp Summary: Change _abstract_method_handler to return AbstractMethodError i2c, c2i and c2iv entries. Reviewed-by: kvn, vlivanov ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 938e1e64e28f Author: anoll Date: 2013-11-14 19:27 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/938e1e64e28f 8028306: nsk stress tests, CodeCache fills, then safepoint asserts Summary: Move handle_full_code_cache() out of block that forbids safepoints Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/runtime/sweeper.cpp Changeset: fca8f4799229 Author: roland Date: 2013-11-20 12:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fca8f4799229 8028308: nsk regression, assert(obj->is_oop()) failed: not an oop Summary: rbp not restored when stack overflow is thrown from deopt/uncommon trap blobs Reviewed-by: kvn, iveresov ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp + test/compiler/uncommontrap/TestStackBangRbp.java Changeset: aa933e6b061d Author: mgronlun Date: 2013-11-22 20:26 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aa933e6b061d Merge Changeset: 55be5aac78e2 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/55be5aac78e2 Added tag jdk8-b117 for changeset f573d00213b7 ! .hgtags Changeset: abad3b2d905d Author: amurillo Date: 2013-11-22 13:34 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/abad3b2d905d Merge Changeset: c9f439732b18 Author: amurillo Date: 2013-11-22 13:34 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c9f439732b18 Added tag hs25-b60 for changeset abad3b2d905d ! .hgtags Changeset: e51d73189692 Author: amurillo Date: 2013-11-22 13:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e51d73189692 8028815: new hotspot build - hs25-b61 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 260ac69dc096 Author: mgronlun Date: 2013-11-23 09:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/260ac69dc096 Merge From markus.gronlund at oracle.com Sat Nov 23 04:37:42 2013 From: markus.gronlund at oracle.com (markus.gronlund at oracle.com) Date: Sat, 23 Nov 2013 12:37:42 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8028128: Add a type safe alternative for working with counter based data Message-ID: <20131123123744.C99AB627D7@hg.openjdk.java.net> Changeset: 86e6d691f2e1 Author: mgronlun Date: 2013-11-23 12:25 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/86e6d691f2e1 8028128: Add a type safe alternative for working with counter based data Reviewed-by: dholmes, egahlin ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/gcTimer.cpp ! src/share/vm/gc_implementation/shared/gcTimer.hpp ! src/share/vm/gc_implementation/shared/gcTrace.cpp ! src/share/vm/gc_implementation/shared/gcTrace.hpp ! src/share/vm/gc_implementation/shared/gcTraceSend.cpp ! src/share/vm/gc_implementation/shared/gcTraceTime.cpp ! src/share/vm/gc_implementation/shared/gcTraceTime.hpp ! src/share/vm/gc_implementation/shared/objectCountEventSender.cpp ! src/share/vm/gc_implementation/shared/objectCountEventSender.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/generation.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/trace/noTraceBackend.hpp ! src/share/vm/trace/trace.xml ! src/share/vm/trace/traceBackend.hpp ! src/share/vm/trace/traceEvent.hpp ! src/share/vm/trace/traceEventClasses.xsl ! src/share/vm/trace/traceTime.hpp ! src/share/vm/trace/traceTypes.xsl ! src/share/vm/trace/tracetypes.xml + src/share/vm/utilities/ticks.cpp + src/share/vm/utilities/ticks.hpp + src/share/vm/utilities/ticks.inline.hpp From yiming.wang at oracle.com Sun Nov 24 19:41:23 2013 From: yiming.wang at oracle.com (Eric Wang) Date: Mon, 25 Nov 2013 11:41:23 +0800 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <52858D04.3080206@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> Message-ID: <5292C6E3.4050101@oracle.com> Hi Mandy & All, Sorry for late! The webrev below is just finished based on the comments from peers, please help to review. http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ Thanks, Eric On 2013/11/15 10:55, Mandy Chung wrote: > Hi Eric, > > On 11/14/2013 6:16 PM, Eric Wang wrote: >> Hi Everyone, >> >> I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. >> >> It is a test bug as the test doesn't guarantee memory allocated from >> the Old Gen, if the used memory is zero and doesn't cross the >> threshold, no notification is sent, so both the main thread and >> Checker thread are blocked to wait for the GC notification. >> >> so the suggested fix is similar as the fix ResetPeakMemoryUsage.java >> to create >> big object to make sure the old gen usage crosses the threshold and >> run test with different GC vmoptions. > > What are you looking for specifically? I have provided the above > information. I need to see the webrev to provide further feedback. > > Mandy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131125/b8577c6a/attachment.html From paul.sandoz at oracle.com Mon Nov 25 01:18:15 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Mon, 25 Nov 2013 09:18:15 +0000 Subject: hg: jdk8/tl/jdk: 8028516: Java doc error in Int/Long/Double/Stream.peek Message-ID: <20131125091828.3B135627FF@hg.openjdk.java.net> Changeset: 1f45b24ffe4b Author: psandoz Date: 2013-11-25 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f45b24ffe4b 8028516: Java doc error in Int/Long/Double/Stream.peek Reviewed-by: chegar ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java From dmitry.samersoff at oracle.com Mon Nov 25 02:08:09 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 25 Nov 2013 14:08:09 +0400 Subject: RR(XS): JDK-8028408 unused-value warning on forte.cpp when build on Mac Message-ID: <52932189.5000809@oracle.com> Please, review one-line fix http://cr.openjdk.java.net/~dsamersoff/JDK-8028408/webrev.01/ -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From staffan.larsen at oracle.com Mon Nov 25 02:39:33 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 25 Nov 2013 11:39:33 +0100 Subject: RR(XS): JDK-8028408 unused-value warning on forte.cpp when build on Mac In-Reply-To: <52932189.5000809@oracle.com> References: <52932189.5000809@oracle.com> Message-ID: <33974AAB-96C6-4106-9794-E4A5A0E0A8EE@oracle.com> Looks good, although you need to wait for the new repos to appear before you can push it. Thanks, /Staffan On 25 nov 2013, at 11:08, Dmitry Samersoff wrote: > Please, review one-line fix > > http://cr.openjdk.java.net/~dsamersoff/JDK-8028408/webrev.01/ > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources. From serguei.spitsyn at oracle.com Mon Nov 25 03:26:20 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 25 Nov 2013 03:26:20 -0800 Subject: RR(XS): JDK-8028408 unused-value warning on forte.cpp when build on Mac In-Reply-To: <52932189.5000809@oracle.com> References: <52932189.5000809@oracle.com> Message-ID: <529333DC.6090305@oracle.com> This is very simple and a safe fix. :) Thanks, Serguei On 11/25/13 2:08 AM, Dmitry Samersoff wrote: > Please, review one-line fix > > http://cr.openjdk.java.net/~dsamersoff/JDK-8028408/webrev.01/ > > From dmitry.samersoff at oracle.com Mon Nov 25 05:25:55 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 25 Nov 2013 17:25:55 +0400 Subject: RR(S): JDK-8026319: Some tmtools tests failed with nsk.share.TestFailure: Line does not match entry pattern Message-ID: <52934FE3.1030201@oracle.com> Hi Everybody, Please review the fix in VM testbase http://cr.openjdk.java.net/~dsamersoff/JDK-8026319/webrev.01/ With this changes, we skip lines that doesn't look like pmap entry rather than abort on it. Skipped lines logged to stderr. -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From staffan.larsen at oracle.com Mon Nov 25 06:00:44 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 25 Nov 2013 15:00:44 +0100 Subject: RR(S): JDK-8026319: Some tmtools tests failed with nsk.share.TestFailure: Line does not match entry pattern In-Reply-To: <52934FE3.1030201@oracle.com> References: <52934FE3.1030201@oracle.com> Message-ID: <98067173-4B5D-43B2-8A96-F066FC83AD56@oracle.com> Dmitry, VM testbase is not part of OpenJDK and review requests should go on internal email lists. /Staffan On 25 nov 2013, at 14:25, Dmitry Samersoff wrote: > Hi Everybody, > > Please review the fix in VM testbase > > http://cr.openjdk.java.net/~dsamersoff/JDK-8026319/webrev.01/ > > With this changes, we skip lines that doesn't look like pmap entry > rather than abort on it. Skipped lines logged to stderr. > > -Dmitry > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources. From artem.ananiev at oracle.com Mon Nov 25 07:52:03 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 25 Nov 2013 19:52:03 +0400 Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <52937223.408@oracle.com> Hi, Volker, just a few very minor comments about the client changes: 1. mlib_sys.c: the change is fine, but it makes the following comment obsolete. 2. XRBackendNative.c: the same comment here. 3. Awt2dLibraries.gmk: $(JDK_TOPDIR)/src/aix/porting/porting_aix.c would be better than just porting_aix.c Thanks, Artem On 11/20/2013 10:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stage > repository which has been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I > need the approval of reviewers from the lib, net, svc, 2d, awt and sec > groups. So please don't hesitate to jump at it - there are enough > changes for everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for > collecting them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > * Added these two files for AIX relevant utility code. > * Currently these files only contain an implementation of |dladdr| > which is not available on AIX. > * In the first review round the existing |dladdr| users in the code > either called the version from the HotSpot on AIX > (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private > copy of the whole implementation > (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not > necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > > makefiles/CompileDemos.gmk > > * Add an extra argument to |SetupJVMTIDemo| which can be used to pass > additional source locations. > * Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > * On AIX add the sources of the AIX porting utilities to the build. > They are required by |src/solaris/native/sun/awt/awt_LoadLibrary.c| > and |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is > not available on AIX. > > > makefiles/lib/NioLibraries.gmk > > * Make the AIX-build aware of the new NIO source locations under > |src/aix/native/sun/nio/|. > > > makefiles/lib/NetworkingLibraries.gmk > > * Make the AIX-build aware of the new |aix_close.c| source location > under |src/aix/native/java/net/|. > > > src/share/bin/jli_util.h > > * Define |JLI_Lseek| on AIX. > > > src/share/lib/security/java.security-aix > > * Provide default |java.security-aix| for AIX based on the latest > Linux version as suggested by Sean Mullan. > > > src/share/native/common/check_code.c > > * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in |check_code.c| does not handles this > properly. So we wrap the two methods on AIX and return a non-NULL > pointer even if we allocate 0 bytes. > > > src/share/native/sun/awt/medialib/mlib_sys.c > > * |malloc| always returns 8-byte aligned pointers on AIX as well. > > > src/share/native/sun/awt/medialib/mlib_types.h > > * Add AIX to the list of known platforms. > > > src/share/native/sun/font/layout/KernTable.cpp > > * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is > too common and may be defined in other headers as well as on the > command line and |xlc| bails out on macro redefinitions with a > different value. > > > src/share/native/sun/security/ec/impl/ecc_impl.h > > * Define required types and macros on AIX. > > > src/solaris/back/exec_md.c > > * AIX behaves like Linux in this case so check for it in the Linux branch. > > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| > * Always use |LD_LIBRARY_PATH| macro instead of using the string > "|LD_LIBRARY_PATH|" directly to cope with different library path names. > * Add |jre/lib//jli| to the standard library search path on AIX > because the AIX linker doesn't support the |-rpath| option. > * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in this > case, AIX behaves like Linux. > * Removed the definition of |JVM_DLL|, |JAVA_DLL| and > |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are > redefined in the corresponding |.c| files anyway. > > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > * Provide basic |fontconfig.properties|for AIX. > > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > * Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > * Detect AIX operating system and return the corresponding channel and > file system providers. > > > src/solaris/classes/sun/nio/ch/Port.java > > * Add a callback function |unregisterImpl(int fd)| for implementations > that need special handling when |fd| is removed and call it from > |unregister(int fd)|. By default the implementation of > |unregisterImpl(int fd)| is empty except for the derived > |AixPollPort| class on AIX. > > > src/solaris/demo/jvmti/hprof/hprof_md.c > > * Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no |dladdr| functionality. > * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). > > > src/solaris/native/common/jdk_util_md.h > > * Add AIX definitions of the |ISNANF| and |ISNAND| macros. > > > src/solaris/native/java/io/io_util_md.c > > * AIX behaves like Linux in this case so check for it in the Linux branch. > > > src/solaris/native/java/lang/UNIXProcess_md.c > > * AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > > src/solaris/native/java/lang/childproc.c > > * AIX does not understand '/proc/self' - it requires the real process > ID to query the proc file system for the current process. > > > src/solaris/native/java/net/NetworkInterface.c > > * Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > * AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > * Moved the declaration of |siocgifconfRequest| to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > > src/solaris/native/java/net/PlainSocketImpl.c > > * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| if > the socket is closed. The default error message is then confusing. > > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > * As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of |linux_close.c| to > |src/aix/native/java/net/aix_close.c| because we also need the file > and socket wrappers on AIX. > * Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > * Also, on AIX we don't have |__attribute((constructor))| so we need > to initialize manually (from |JNI_OnLoad()| in > |src/share/native/java/net/net_util.c|. > > > src/solaris/native/java/net/net_util_md.h > > * AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > > src/solaris/native/java/net/net_util_md.c > > * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. > * On AIX we have to ignore failures due to |ENOBUFS| when setting the > |SO_SNDBUF|/|SO_RCVBUF| socket options. > > > src/solaris/native/java/util/TimeZone_md.c > > * Currently on AIX the only way to get the platform time zone is to > read it from the |TZ| environment variable. > > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > * Use the |dladdr| from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/sun/awt/fontpath.c > > * Changed some macros from |if !defined(__linux__)| to |if > defined(__solaris__)| because that's their real meaning. > * Add AIX specific fontpath settings and library search paths for > |libfontconfig.so|. > > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to > avoid name clashes (|MIN| and |MAX| are much too common and thexy > are already defined in some AIX system headers). > > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > * Handle AIX like Solaris. > > > src/solaris/native/sun/nio/ch/Net.c > > * Add AIX-specific includes and constant definitions. > * On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate > exceptions if it is requested but not supported. This is needed to > pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > * On AIX |strerror()| is not thread-safe so we have to use > |strerror_r()| instead. > * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain > the error code. > * Handle some AIX corner cases for the results of the |statvfs64()| call. > * On AIX |getgrgid_r()| returns ESRCH if group does not exist. > > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. > > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > * Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as |isEnglish()|, ignore VM-warnings in the output, make > sure the "grandchild" processes created by the test don't run too > long (60s vs. 6666s) because in the case of test problems these > processes will pollute the process space, make sure the test fails > with an error and doesn't hang indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, |_AIX| is defined in some system headers while |AIX| is defined by > the build system. This is already used inconsistently (i.e. |__linux__| > vs. |LINUX|) and in general I try to be consistent with the style of the > file where I the changes are. That said, I changes most of the > occurences of |AIX| to |_AIX|. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and > currently called IBM i) in our OpenJDK port but we do support it in our > internel, SAP JVM build. We stripped out all the extra OS/400 > functionality from the port but in some places where there is common > functionality needd by both, AIX and OS/400 the OS/400 support may still > be visible in the OpenJDK port. I don't think this is a real problem and > it helps us to keep our internel sources in sync with the OpenJDK port. > That said, I think I've removed all the references to OS/400 now. > > From mattias.tobiasson at oracle.com Mon Nov 25 08:28:49 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Mon, 25 Nov 2013 08:28:49 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <5f479f04-0ede-4a15-beff-699fab538837@default> Hi, The test has been updated after the first review. The two java files for each test has been merged to a single file. Updated summary of changes: 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. 2. Removed all bash scripts. 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. 4. Added some utility functions to jdk/testlibrary. 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. Webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-6461635 Mattias ----- Original Message ----- From: mattias.tobiasson at oracle.com To: mikael.auno at oracle.com Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently I agree that merging both files in a single file may be good. The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. Mattias ----- Original Message ----- From: mikael.auno at oracle.com To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently How about defining the class that you want to attach to as a static inner class to the actual test? That would give you only one file, but with two classes, each with its own main method and clear correlation between them. Mikael On 2013-11-20 15:41, Mattias Tobiasson wrote: > Hi, > Each test requires 2 files, the actual test code and a helper file. > > The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. > > For example: > PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java > PermissionTest.java: The actual test code that attaches to the Application. > > It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). > > When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. > > I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. > > I used these names: > TestPermission.java: Helper file. > TestPermissionImpl.java: Actual test code. > > I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. > > Mattias > > > ----- Original Message ----- > From: Alan.Bateman at oracle.com > To: mattias.tobiasson at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > > Out of curiosity, what is the reason for the rename? I ask because we > use Basic and similar names in many areas. Also anything in the test > tree should be a test. > > -Alan. > > On 20/11/2013 13:47, Mattias Tobiasson wrote: >> Hi, >> Could you please review this fix. >> >> Summary of changes: >> >> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >> >> 2. Ported the following bash scripts to java: >> BasicTests.sh -> TestBasic.java >> PermissionTests.sh -> TestPermission.java >> ProviderTests.sh -> TestProvider.java >> >> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >> BasicsTest.java -> TestBasicImpl.java >> PermissionTest.java -> TestPermissionImpl.java >> ProviderTest.java -> TestProviderImpl.java >> >> 4. Added some utility functions to jdk/testlibrary. >> >> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >> >> >> Thanks, >> Mattias >> >> Webrev: >> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6461635 > From leonid.mesnik at oracle.com Mon Nov 25 09:24:52 2013 From: leonid.mesnik at oracle.com (Leonid Mesnik) Date: Mon, 25 Nov 2013 21:24:52 +0400 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <5f479f04-0ede-4a15-beff-699fab538837@default> References: <5f479f04-0ede-4a15-beff-699fab538837@default> Message-ID: <529387E4.6000809@oracle.com> Hi I have a couple of high-level questions. On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: > Hi, > The test has been updated after the first review. > The two java files for each test has been merged to a single file. > > > Updated summary of changes: > 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. What is the reason of this intermittent failure? > > 2. Removed all bash scripts. Great! > > 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. > > 4. Added some utility functions to jdk/testlibrary. Here some comments about library code. http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html + try { + output = new OutputAnalyzer(this.process); + } catch (Throwable t) { + String name = Thread.currentThread().getName(); + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); + throw t; + } finally { + String logMsg = ProcessTools.getProcessLog(processBuilder, output); + System.out.println(logMsg); + } You used output in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html 1) Same in as previous in executeProcess method. 2) getCommandLine (...) + /** + * @return The full command line for the ProcessBuilder. + */ + public static String getCommandLine(ProcessBuilder pb) { + StringBuilder cmd = new StringBuilder(); + for (String s : pb.command()) { + cmd.append(s).append(" "); + } + return cmd.toString(); + } Should we also trim cmd to remove last " "? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html public static int waitForJvmPid(String key) throws Throwable { Why it throw Trowable? Could we deal with exceptions in this method and re-throw some more meaningful exception here? Could you force flush for out here: System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); Hope it should be enough. It is scary to investigate such "timeouts". Would it be better to add some internal timeout in testlibrary? Really jtreg doesn't kill all processes and we have alive java processes in such case. For samevm tests timeouts are even worse. There is no good way to kill test in samevm. Should be public static int tryFindJvmPid(String key) throws Throwable { private? Are we going to use it in tests or only waitForJvmPid? Leonid > > 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. > > > Webrev: > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6461635 > > Mattias > > > ----- Original Message ----- > From: mattias.tobiasson at oracle.com > To: mikael.auno at oracle.com > Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com > Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > I agree that merging both files in a single file may be good. > The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. > > But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. > > Mattias > > ----- Original Message ----- > From: mikael.auno at oracle.com > To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > How about defining the class that you want to attach to as a static > inner class to the actual test? That would give you only one file, but > with two classes, each with its own main method and clear correlation > between them. > > Mikael > > On 2013-11-20 15:41, Mattias Tobiasson wrote: >> Hi, >> Each test requires 2 files, the actual test code and a helper file. >> >> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >> >> For example: >> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >> PermissionTest.java: The actual test code that attaches to the Application. >> >> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >> >> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >> >> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >> >> I used these names: >> TestPermission.java: Helper file. >> TestPermissionImpl.java: Actual test code. >> >> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >> >> Mattias >> >> >> ----- Original Message ----- >> From: Alan.Bateman at oracle.com >> To: mattias.tobiasson at oracle.com >> Cc: serviceability-dev at openjdk.java.net >> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> >> Out of curiosity, what is the reason for the rename? I ask because we >> use Basic and similar names in many areas. Also anything in the test >> tree should be a test. >> >> -Alan. >> >> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>> Hi, >>> Could you please review this fix. >>> >>> Summary of changes: >>> >>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>> >>> 2. Ported the following bash scripts to java: >>> BasicTests.sh -> TestBasic.java >>> PermissionTests.sh -> TestPermission.java >>> ProviderTests.sh -> TestProvider.java >>> >>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>> BasicsTest.java -> TestBasicImpl.java >>> PermissionTest.java -> TestPermissionImpl.java >>> ProviderTest.java -> TestProviderImpl.java >>> >>> 4. Added some utility functions to jdk/testlibrary. >>> >>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>> >>> >>> Thanks, >>> Mattias >>> >>> Webrev: >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-6461635 -- Leonid Mesnik JVM SQE From dmitry.samersoff at oracle.com Mon Nov 25 09:49:16 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 25 Nov 2013 21:49:16 +0400 Subject: RR(XS): JDK-6969276 minor memory leak detected by cppcheck in agent/src/os/linux/symtab.c Message-ID: <52938D9C.2060806@oracle.com> Hi Everyone, Please review an XS fix - missed free() call discovered by cppcheck tool. http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/ -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From dmitry.samersoff at oracle.com Mon Nov 25 10:04:50 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 25 Nov 2013 22:04:50 +0400 Subject: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name Message-ID: <52939142.3020202@oracle.com> Hi Everyone, Please review a day-1 typeo in jsdbproc64.sh http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/ -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From staffan.larsen at oracle.com Mon Nov 25 10:25:06 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 25 Nov 2013 19:25:06 +0100 Subject: RR(XS): JDK-6969276 minor memory leak detected by cppcheck in agent/src/os/linux/symtab.c In-Reply-To: <52938D9C.2060806@oracle.com> References: <52938D9C.2060806@oracle.com> Message-ID: <0071BDC5-B22E-4DFD-B876-B079447BD131@oracle.com> Looks good! Thanks, /Staffan On 25 nov 2013, at 18:49, Dmitry Samersoff wrote: > Hi Everyone, > > Please review an XS fix - missed free() call discovered by cppcheck tool. > > http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/ > > -Dmitry > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources. From staffan.larsen at oracle.com Mon Nov 25 10:26:04 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 25 Nov 2013 19:26:04 +0100 Subject: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name In-Reply-To: <52939142.3020202@oracle.com> References: <52939142.3020202@oracle.com> Message-ID: <5C8CAC15-55F8-42FA-943B-16BA386B98E8@oracle.com> Looks good! (Although we should probably remove these shell scripts sometime). Thanks, /Staffan On 25 nov 2013, at 19:04, Dmitry Samersoff wrote: > Hi Everyone, > > Please review a day-1 typeo in jsdbproc64.sh > > http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/ > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources. From lana.steuck at oracle.com Mon Nov 25 11:08:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:46 +0000 Subject: hg: jdk8/tl/corba: 4 new changesets Message-ID: <20131125190851.92AAF62825@hg.openjdk.java.net> Changeset: 7299367c8aa4 Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7299367c8aa4 Added tag jdk8-b116 for changeset 5fdc44652089 ! .hgtags Changeset: e53d1ee4d2ae Author: lana Date: 2013-11-14 23:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e53d1ee4d2ae Merge Changeset: d6820a414f18 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d6820a414f18 Added tag jdk8-b117 for changeset e53d1ee4d2ae ! .hgtags Changeset: e648df60c8a2 Author: lana Date: 2013-11-25 09:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e648df60c8a2 Merge From lana.steuck at oracle.com Mon Nov 25 11:08:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:56 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131125190907.26CBC62827@hg.openjdk.java.net> Changeset: 774c63629870 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/774c63629870 Added tag jdk8-b116 for changeset 0fb1a427fbf6 ! .hgtags Changeset: 1db3d4e4d189 Author: lana Date: 2013-11-15 07:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1db3d4e4d189 Merge Changeset: 8d014b039b44 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d014b039b44 Added tag jdk8-b117 for changeset 1db3d4e4d189 ! .hgtags Changeset: 44ea3815e414 Author: lana Date: 2013-11-25 09:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/44ea3815e414 Merge From lana.steuck at oracle.com Mon Nov 25 11:08:51 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:51 +0000 Subject: hg: jdk8/tl/jaxws: 3 new changesets Message-ID: <20131125190908.5C8FC62828@hg.openjdk.java.net> Changeset: fe56ba456fd3 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fe56ba456fd3 Added tag jdk8-b116 for changeset 587560c222a2 ! .hgtags Changeset: 76a598cf50c4 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/76a598cf50c4 Added tag jdk8-b117 for changeset fe56ba456fd3 ! .hgtags Changeset: 4900fcaae498 Author: lana Date: 2013-11-25 09:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/4900fcaae498 Merge From lana.steuck at oracle.com Mon Nov 25 11:08:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:56 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20131125190919.64DCC62829@hg.openjdk.java.net> Changeset: 64d119680f0a Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64d119680f0a Added tag jdk8-b116 for changeset 3c040b04af05 ! .hgtags Changeset: 19de039a03a6 Author: lana Date: 2013-11-15 07:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19de039a03a6 Merge - test/tools/javac/ArraysInIntersections.java - test/tools/javac/InferArraysInIntersections.java - test/tools/javac/diags/examples/InterfaceOrArrayExpected.java Changeset: 4fd6a7ff8c06 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fd6a7ff8c06 Added tag jdk8-b117 for changeset 19de039a03a6 ! .hgtags Changeset: 7ef88faaa16c Author: lana Date: 2013-11-25 09:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7ef88faaa16c Merge From lana.steuck at oracle.com Mon Nov 25 11:08:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:46 +0000 Subject: hg: jdk8/tl: 5 new changesets Message-ID: <20131125190847.985AE62824@hg.openjdk.java.net> Changeset: c1029b02ca87 Author: ihse Date: 2013-11-08 09:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c1029b02ca87 8027836: Webrev should handle files that has been moved from a directory which now is removed. Reviewed-by: mduigou, tbell ! make/scripts/webrev.ksh Changeset: cbfe5da942c6 Author: katleman Date: 2013-11-11 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cbfe5da942c6 Merge Changeset: a4afb0a8d55e Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a4afb0a8d55e Added tag jdk8-b116 for changeset cbfe5da942c6 ! .hgtags Changeset: 0a6db1aac998 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0a6db1aac998 Added tag jdk8-b117 for changeset a4afb0a8d55e ! .hgtags Changeset: 24847bd96465 Author: lana Date: 2013-11-25 09:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/24847bd96465 Merge From lana.steuck at oracle.com Mon Nov 25 11:09:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:09:14 +0000 Subject: hg: jdk8/tl/hotspot: 36 new changesets Message-ID: <20131125191035.64E3D6282A@hg.openjdk.java.net> Changeset: aec3226be72d Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aec3226be72d Added tag jdk8-b116 for changeset 52b076e6ffae ! .hgtags Changeset: 20c72bec2707 Author: amurillo Date: 2013-11-08 07:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20c72bec2707 8028061: new hotspot build - hs25-b59 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9d8b29a0548c Author: mgerdin Date: 2013-11-08 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d8b29a0548c 8027237: New tests on ReservedSpace/VirtualSpace classes Summary: Three tests added: 1) test stressing VirtualSpace by resizing it constantly 2) test running unit tests in several threads 3) test checking protected area in ReservedHeapSpace class Reviewed-by: stefank, zgu Contributed-by: aleksey.timofeev at oracle.com ! src/share/vm/prims/whitebox.cpp + test/runtime/memory/ReadFromNoaccessArea.java + test/runtime/memory/RunUnitTestsConcurrently.java + test/runtime/memory/StressVirtualSpaceResize.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 19f8a5d7600b Author: mgerdin Date: 2013-11-08 23:49 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/19f8a5d7600b Merge Changeset: fce21ac5968d Author: acorn Date: 2013-11-13 07:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fce21ac5968d 8027229: ICCE expected for >=2 maximally specific default methods. Summary: Need to process defaults for interfaces for invokespecial Reviewed-by: lfoltan, hseigel, coleenp, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/oops/klassVtable.cpp Changeset: 41cb10cbfb3c Author: coleenp Date: 2013-11-13 16:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41cb10cbfb3c 8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change Summary: Create extra constant pool cache entries for invokespecial/InterfaceMethodref to hold the alternate resolution. Reviewed-by: jrose, lfoltan, hseigel ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: 4288e54fd145 Author: jwilhelm Date: 2013-10-21 18:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4288e54fd145 8026851: Remove unnecessary code in GenRemSet Summary: Removed the GenRemSet::rem_set_name() since we only have one remset. Reviewed-by: stefank, mgerdin, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: 3aee6bc29547 Author: jwilhelm Date: 2013-10-21 18:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3aee6bc29547 8026852: Use restricted_align_down in collector policy code Summary: Moved restricted_align_down to globalDefinitions and renamed it align_size_down_bounded Reviewed-by: stefank, mgerdin, tschatzl ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 46d7652b223c Author: jwilhelm Date: 2013-10-21 18:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/46d7652b223c 8026853: Prepare GC code for collector policy regression fix Summary: Cleanup related to the NewSize and MaxNewSize bugs Reviewed-by: tschatzl, jcoomes, ehelin ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 8f07aa079343 Author: jwilhelm Date: 2013-11-01 17:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f07aa079343 8016309: assert(eden_size > 0 && survivor_size > 0) failed: just checking 7057939: jmap shows MaxNewSize=4GB when Java is using parallel collector Summary: Major cleanup of the collectorpolicy classes Reviewed-by: tschatzl, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.hpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp + src/share/vm/gc_implementation/parallelScavenge/generationSizer.cpp ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! test/gc/arguments/TestMaxHeapSizeTools.java + test/gc/arguments/TestMaxNewSize.java Changeset: 610be0309a79 Author: amurillo Date: 2013-11-02 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/610be0309a79 Merge ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 28674af341ac Author: tschatzl Date: 2013-11-07 15:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region? Summary: Change checks for isHumongous() to continuesHumongous() as installing a code root for a humongous object is valid, but not for continuations of humongous objects. Cleaned up asserts. Reviewed-by: jmasa, tamao ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp + test/gc/g1/TestHumongousCodeCacheRoots.java Changeset: 40b8c6bad703 Author: jmasa Date: 2013-10-16 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/40b8c6bad703 8024954: CMS: CMSClassUnloadingMaxInterval is not implemented correctly. This change is also part of the fix for 8024483. Reviewed-by: mgerdin, brutisso, tschatzl Contributed-by: jwha at google.com ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 592d8b01fedd Author: jmasa Date: 2013-11-08 06:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/592d8b01fedd 8024483: assertion failure: (!mirror_alive || loader_alive) failed: Reviewed-by: brutisso, tschatzl, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 3ad2b68d107e Author: jwilhelm Date: 2013-11-10 00:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3ad2b68d107e 8027911: Assertion in the collector policy when running gc/arguments/TestMaxNewSize.java Summary: Update NewSize when _initial_gen0_size is changed Reviewed-by: tschatzl, brutisso ! src/share/vm/memory/collectorPolicy.cpp Changeset: 236cecd9ec97 Author: jwilhelm Date: 2013-11-11 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/236cecd9ec97 8028093: Initial young size is smaller than minimum young size Summary: Remove min_gen1_size argument from adjust_gen0_sizes() Reviewed-by: tschatzl, brutisso ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: bde526e3667e Author: jwilhelm Date: 2013-11-11 05:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bde526e3667e Merge Changeset: 11b116661830 Author: mgerdin Date: 2013-11-11 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11b116661830 Merge ! src/share/vm/memory/metaspace.cpp Changeset: ee527493b36d Author: sjohanss Date: 2013-11-08 17:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee527493b36d 8027960: Assertion assert(end >= start) failed during nightly testing on solaris Summary: Needed to update _space_alignment in generation sizer to ensure correct sizing of spaces. Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.cpp Changeset: 755c423791ab Author: ehelin Date: 2013-11-14 21:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/755c423791ab Merge ! src/share/vm/prims/whitebox.cpp Changeset: e2509677809c Author: vlivanov Date: 2013-11-08 01:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e2509677809c 8023037: Race between ciEnv::register_method and nmethod::make_not_entrant_or_zombie Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/globals.hpp Changeset: 83c8f6f4ab09 Author: drchase Date: 2013-11-08 14:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/83c8f6f4ab09 Merge Changeset: 1dcea64e9f00 Author: kvn Date: 2013-11-11 11:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1dcea64e9f00 8024830: SEGV in org.apache.lucene.codecs.compressing.CompressingTermVectorsReader.get Summary: Exclude last input argument's stack slots from vector's spilling masks. Reviewed-by: iveresov ! src/share/vm/opto/matcher.cpp Changeset: 78da3894b86f Author: anoll Date: 2013-11-12 09:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78da3894b86f 8027593: performance drop with constrained codecache starting with hs25 b111 Summary: Fixed proper sweeping of small code cache sizes Reviewed-by: kvn, iveresov ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: 144b23411b51 Author: roland Date: 2013-11-12 13:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/144b23411b51 8027632: assert(xtype->klass_is_exact()) failed: Should be exact at graphKit.cpp Summary: receiver type collected by profiling for default method may be interface Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f675976a61e7 Author: rbackman Date: 2013-11-12 13:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f675976a61e7 8028198: SIGSEGV in PhaseIdealLoop::build_loop_late_post Reviewed-by: iveresov, kvn ! src/share/vm/opto/loopopts.cpp + test/compiler/intrinsics/mathexact/SplitThruPhiTest.java Changeset: b957c650babb Author: rbackman Date: 2013-11-12 14:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b957c650babb 8028207: assert(_outcnt==1) failed: not unique in compile.cpp Reviewed-by: iveresov, kvn ! src/share/vm/opto/mathexactnode.hpp + test/compiler/intrinsics/mathexact/GVNTest.java Changeset: e6ba215af802 Author: roland Date: 2013-11-13 09:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e6ba215af802 8027631: "unexpected profiling mismatch" error with new type profiling Summary: inlined method handle calls can call methods with different signatures Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp + test/compiler/profiling/TestUnexpectedProfilingMismatch.java Changeset: 924c32982a12 Author: roland Date: 2013-11-13 01:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/924c32982a12 Merge Changeset: 6e1826d5c23e Author: roland Date: 2013-11-13 13:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e1826d5c23e 8027572: assert(r != 0) failed: invalid Summary: null classes should be expected in profiles with conflicts Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp + test/compiler/profiling/unloadingconflict/B.java + test/compiler/profiling/unloadingconflict/TestProfileConflictClassUnloading.java Changeset: e74074c34312 Author: vlivanov Date: 2013-11-14 09:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e74074c34312 8028159: C2: compiler stack overflow during inlining of @ForceInline methods Reviewed-by: roland, kvn ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/runtime/globals.hpp Changeset: df0df745224c Author: drchase Date: 2013-11-14 15:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df0df745224c Merge Changeset: 6f206b5d258f Author: drchase Date: 2013-11-14 13:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f206b5d258f Merge ! src/share/vm/runtime/arguments.cpp Changeset: c78d517c7ea4 Author: amurillo Date: 2013-11-15 07:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c78d517c7ea4 Merge Changeset: f573d00213b7 Author: amurillo Date: 2013-11-15 07:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f573d00213b7 Added tag hs25-b59 for changeset c78d517c7ea4 ! .hgtags Changeset: 55be5aac78e2 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/55be5aac78e2 Added tag jdk8-b117 for changeset f573d00213b7 ! .hgtags From lana.steuck at oracle.com Mon Nov 25 11:08:49 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:49 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20131125190906.CEE8762826@hg.openjdk.java.net> Changeset: c1d234d4f164 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c1d234d4f164 Added tag jdk8-b116 for changeset e757eb9aee3d ! .hgtags Changeset: e4e5069250e7 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e4e5069250e7 Added tag jdk8-b117 for changeset c1d234d4f164 ! .hgtags Changeset: 7ce7e38868d3 Author: lana Date: 2013-11-25 09:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7ce7e38868d3 Merge From lana.steuck at oracle.com Mon Nov 25 11:11:22 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:11:22 +0000 Subject: hg: jdk8/tl/jdk: 20 new changesets Message-ID: <20131125191534.9FACF6282B@hg.openjdk.java.net> Changeset: bdcba4854576 Author: erikj Date: 2013-11-07 10:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdcba4854576 8027698: Platform specific jars are not being signed by the sign-jars target Reviewed-by: ihse, tbell, wetmore ! makefiles/SignJars.gmk Changeset: 295a641fc86b Author: erikj Date: 2013-11-07 14:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/295a641fc86b 8027406: JDK demos are missing source files Reviewed-by: alexsch, ihse ! makefiles/CompileDemos.gmk Changeset: 43168d403243 Author: anthony Date: 2013-11-08 20:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43168d403243 8027912: [macosx] Provide means to force the headful mode on OS X when running via ssh Summary: Bypass AquaSession check if AWT_FORCE_HEADFUL env. variable is set to TRUE Reviewed-by: anthony, art Contributed-by: David Dehaven ! src/solaris/native/java/lang/java_props_macosx.c Changeset: 0dc0067f3b8e Author: katleman Date: 2013-11-11 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0dc0067f3b8e Merge Changeset: 483148bf625e Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/483148bf625e Added tag jdk8-b116 for changeset 0dc0067f3b8e ! .hgtags Changeset: f2ae86dba4bc Author: prr Date: 2013-11-13 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ae86dba4bc 8028206: sun/java2d/cmm/ProfileOp/SetDataTest.java fails Reviewed-by: bae, jchen ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! test/sun/java2d/cmm/ProfileOp/SetDataTest.java Changeset: b691a6abf9e0 Author: lana Date: 2013-11-14 23:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b691a6abf9e0 Merge Changeset: 30766f910509 Author: malenkov Date: 2013-11-01 21:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30766f910509 8026491: Typos in string literals Reviewed-by: alexsch, anthony ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties ! src/share/classes/com/sun/imageio/plugins/common/StandardMetadataFormatResources.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubNextRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubRequestHandler.java ! src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java ! src/share/classes/com/sun/tools/script/shell/init.js ! src/share/classes/com/sun/tools/script/shell/messages.properties ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/swing/KeyboardManager.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/rmi/rmic/RMIGenerator.java ! src/share/classes/sun/security/jgss/krb5/InitialToken.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/share/demo/jfc/FileChooserDemo/FileChooserDemo.java ! src/share/native/sun/security/pkcs11/wrapper/p11_util.c ! src/share/sample/nio/chatserver/ClientReader.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java ! src/windows/classes/sun/security/krb5/internal/tools/Ktab.java Changeset: b8eb21e93fa7 Author: yan Date: 2013-11-07 18:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8eb21e93fa7 8025234: [javadoc] fix some errors in javax.swing.** Reviewed-by: alexsch, malenkov Contributed-by: Dmitry Ginzburg ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/Action.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/CellRendererPane.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DesktopManager.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JTextField.java Changeset: 29f979efbabf Author: malenkov Date: 2013-11-08 14:09 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29f979efbabf 8027648: Type of overridden property is resolved incorrectly Reviewed-by: alexsch ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java + test/java/beans/Introspector/Test8027648.java + test/java/beans/Introspector/Test8027905.java Changeset: 184f13eeed41 Author: lana Date: 2013-11-08 15:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184f13eeed41 Merge - src/share/classes/java/lang/invoke/MagicLambdaImpl.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: 4bc2414624e2 Author: leonidr Date: 2013-11-12 20:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bc2414624e2 8027972: [macosx] Provide a regression test for JDK-8007006 Reviewed-by: anthony + test/java/awt/MenuBar/8007006/bug8007006.java Changeset: 0242fce0f717 Author: serb Date: 2013-11-12 20:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0242fce0f717 8027696: Incorrect copyright header in the tests Reviewed-by: alanb, malenkov, mullan ! test/ProblemList.txt ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java ! test/com/sun/jndi/cosnaming/CNNameParser.java ! test/com/sun/jndi/cosnaming/IiopUrlIPv6.java ! test/demo/zipfs/ZipFSTester.java ! test/java/awt/AlphaComposite/TestAlphaCompositeForNaN.java ! test/java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html ! test/java/awt/Choice/NonFocusablePopupMenuTest/NonFocusablePopupMenuTest.html ! test/java/awt/Component/F10TopToplevel/F10TopToplevel.html ! test/java/awt/Component/UpdatingBootTime/UpdatingBootTime.html ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/NextFramePositionCalculator.java ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/SourcePanel.java ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/TargetPanel.java ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html ! test/java/awt/EventQueue/MainAppContext/MainAppContext.java ! test/java/awt/EventQueue/PostEventOrderingTest/PostEventOrderingTest.java ! test/java/awt/FileDialog/FileDialogReturnTest/FileDialogReturnTest.html ! test/java/awt/FileDialog/FileNameOverrideTest/FileNameOverrideTest.html ! test/java/awt/FileDialog/FileNameOverrideTest/FileNameOverrideTest.java ! test/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html ! test/java/awt/FileDialog/MultipleMode/MultipleMode.html ! test/java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.html ! test/java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html ! test/java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.java ! test/java/awt/Focus/6981400/Test1.java ! test/java/awt/Focus/6981400/Test2.java ! test/java/awt/Focus/6981400/Test3.java ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java ! test/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html ! test/java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_AWT.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_Swing.java ! test/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html ! test/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html ! test/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html ! test/java/awt/Frame/FrameSetSizeStressTest/FrameSetSizeStressTest.java ! test/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html ! test/java/awt/Frame/ShownOnPack/ShownOnPack.html ! test/java/awt/Graphics/DrawImageBG/SystemBgColorTest.java ! test/java/awt/Graphics2D/FillTexturePaint/FillTexturePaint.java ! test/java/awt/InputMethods/InputMethodsTest/InputMethodsTest.html ! test/java/awt/JAWT/JAWT.sh ! test/java/awt/JAWT/Makefile.cygwin ! test/java/awt/JAWT/Makefile.unix ! test/java/awt/JAWT/Makefile.win ! test/java/awt/JAWT/MyCanvas.java ! test/java/awt/JAWT/myfile.c ! test/java/awt/JAWT/myfile.cpp ! test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_AWT.java ! test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java ! test/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html ! test/java/awt/List/SetFontTest/SetFontTest.html ! test/java/awt/Menu/NullMenuLabelTest/NullMenuLabelTest.java ! test/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html ! test/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java ! test/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java ! test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java ! test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java ! test/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html ! test/java/awt/Multiscreen/TranslucencyThrowsExceptionWhenFullScreen/TranslucencyThrowsExceptionWhenFullScreen.java ! test/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html ! test/java/awt/PrintJob/Text/stringwidth.sh ! test/java/awt/Robot/AcceptExtraMouseButtons/AcceptExtraMouseButtons.java ! test/java/awt/Robot/ManualInstructions/ManualInstructions.java ! test/java/awt/Robot/RobotExtraButton/RobotExtraButton.java ! test/java/awt/ScrollPane/ScrollPanePreferredSize/ScrollPanePreferredSize.java ! test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test.java ! test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test1.java ! test/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.html ! test/java/awt/TextArea/TextAreaTwicePack/TextAreaTwicePack.java ! test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.html ! test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.html ! test/java/awt/Toolkit/Headless/AWTEventListener/AWTListener.java ! test/java/awt/Toolkit/Headless/ExceptionContract/ExceptionContract.java ! test/java/awt/Toolkit/Headless/GetPrintJob/GetPrintJob.java ! test/java/awt/Toolkit/Headless/GetPrintJob/GetPrintJobHeadless.java ! test/java/awt/Toolkit/SecurityTest/SecurityTest2.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_1.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_2.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_3.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_4.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_5.java ! test/java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Disable.java ! test/java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Enable.java ! test/java/awt/Window/Grab/GrabTest.java ! test/java/awt/Window/TranslucentShapedFrameTest/TSFrame.java ! test/java/awt/Window/TranslucentShapedFrameTest/TranslucentShapedFrameTest.java ! test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh ! test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/test.html ! test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html ! test/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.html ! test/java/awt/dnd/Button2DragTest/Button2DragTest.html ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDTarget.java ! test/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html ! test/java/awt/dnd/ImageDecoratedDnD/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnD/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.html ! test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java ! test/java/awt/dnd/ImageDecoratedDnD/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnD/MyCursor.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/MyCursor.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/MyCursor.java ! test/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html ! test/java/awt/event/InputEvent/ButtonArraysEquality/ButtonArraysEquality.java ! test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.html ! test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java ! test/java/awt/event/KeyEvent/KeyReleasedInAppletTest/KeyReleasedInAppletTest.html ! test/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html ! test/java/awt/event/MouseEvent/AWTPanelSmoothWheel/AWTPanelSmoothWheel.html ! test/java/awt/event/MouseEvent/AcceptExtraButton/AcceptExtraButton.java ! test/java/awt/event/MouseEvent/CTORRestrictions/CTORRestrictions.java ! test/java/awt/event/MouseEvent/CTORRestrictions/CTORRestrictions_Disable.java ! test/java/awt/event/MouseEvent/CheckGetMaskForButton/CheckGetMaskForButton.java ! test/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html ! test/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html ! test/java/awt/event/OtherEvents/UngrabID/UngrabID.java ! test/java/awt/im/4490692/bug4490692.html ! test/java/awt/im/4959409/bug4959409.html ! test/java/awt/im/JTextFieldTest.html ! test/java/awt/image/BufferedImage/TinyScale.java ! test/java/awt/image/DrawImage/EABlitTest.java ! test/java/awt/print/PrinterJob/CustomPrintService/PrintServiceStub.java ! test/java/awt/print/PrinterJob/CustomPrintService/SetPrintServiceTest.java ! test/java/awt/print/bug8023392/bug8023392.html ! test/java/awt/print/bug8023392/bug8023392.java ! test/java/beans/Introspector/6380849/beans/FirstBean.java ! test/java/beans/Introspector/6380849/beans/FirstBeanBeanInfo.java ! test/java/beans/Introspector/6380849/beans/SecondBean.java ! test/java/beans/Introspector/6380849/beans/ThirdBean.java ! test/java/beans/Introspector/6380849/infos/SecondBeanBeanInfo.java ! test/java/beans/Introspector/6380849/infos/ThirdBeanBeanInfo.java ! test/java/beans/Introspector/6976577/test/Accessor.java ! test/java/beans/Introspector/7122138/pack/Sub.java ! test/java/beans/Introspector/7122138/pack/Super.java ! test/java/beans/XMLEncoder/6380849/Bean.java ! test/java/beans/XMLEncoder/6380849/BeanPersistenceDelegate.java ! test/java/io/FileInputStream/OpsAfterClose.java ! test/java/io/FileOutputStream/OpsAfterClose.java ! test/java/io/RandomAccessFile/OpsAfterClose.java ! test/java/lang/StringBuffer/BufferForwarding.java ! test/java/lang/StringBuilder/BuilderForwarding.java ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java ! test/java/lang/invoke/AccessControlTest.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/ClassValueTest.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/PermuteArgsTest.java ! test/java/lang/invoke/PrivateInvokeTest.java ! test/java/lang/invoke/RevealDirectTest.java ! test/java/lang/invoke/RicochetTest.java ! test/java/lang/invoke/TestCatchExceptionWithVarargs.java ! test/java/lang/invoke/ThrowExceptionsTest.java ! test/java/lang/invoke/remote/RemoteExample.java ! test/java/lang/ref/ReferenceEnqueuePending.java ! test/java/net/URLClassLoader/closetest/build.sh ! test/java/security/cert/CertPathBuilder/selfIssued/generate.sh ! test/java/security/cert/CertPathValidator/indirectCRL/generate.sh ! test/java/security/cert/CertPathValidator/nameConstraints/generate.sh ! test/java/security/cert/CertificateRevokedException/Basic.java ! test/java/util/Calendar/CldrFormatNamesTest.java ! test/java/util/Locale/LocaleEnhanceTest.java ! test/java/util/Locale/LocaleTestFmwk.java ! test/java/util/Locale/tools/EquivMapsGenerator.java ! test/java/util/TimeZone/Bug6912560.java ! test/java/util/TimeZone/CLDRDisplayNamesTest.java ! test/java/util/TimeZone/ListTimeZones.java ! test/java/util/TimeZone/OldIDMappingTest.java ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/SetDefaultSecurityTest.java ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.java ! test/java/util/TimeZone/TzIDOldMapping.java ! test/java/util/prefs/AddNodeChangeListener.java ! test/java/util/prefs/CheckUserPrefFirst.java ! test/java/util/prefs/CheckUserPrefLater.java ! test/java/util/regex/RegExTest.java ! test/java/util/spi/ResourceBundleControlProvider/providersrc/UserControlProvider.java ! test/java/util/zip/LargeZip.java ! test/java/util/zip/TotalInOut.java ! test/javax/imageio/plugins/gif/GifTransparencyTest.java ! test/javax/management/modelmbean/LoggingExceptionTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/print/DialogMargins.java ! test/javax/print/StreamPrintingOrientation.java ! test/javax/print/applet/AppletPrintLookup.html ! test/javax/sound/midi/File/SMPTESequence.java ! test/javax/sound/midi/Gervill/AudioFloatConverter/GetFormat.java ! test/javax/sound/midi/Gervill/AudioFloatConverter/ToFloatArray.java ! test/javax/sound/midi/Gervill/AudioFloatFormatConverter/SkipTest.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Available.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Close.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/GetFormat.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/GetFrameLength.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/MarkSupported.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Read.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/ReadFloatArray.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/ReadFloatArrayIntInt.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Reset.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Skip.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankFile.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankInputStream.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankInputStream2.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankUrl.java ! test/javax/sound/midi/Gervill/EmergencySoundbank/TestCreateSoundbank.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/GetInputStream.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/GetRoot.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/Load.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/LoadAll.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferByteArray.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferByteArrayIntInt.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferFile.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferFileLongLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Available.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Close.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/MarkReset.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/MarkSupported.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Read.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/ReadByte.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/ReadByteIntInt.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Skip.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLongLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLongLongBoolean.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/Unload.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/WriteTo.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetAttenuation.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetChannels.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetLoopLength.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetLoopStart.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetPitchCorrection.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBuffer.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferAudioFormat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferAudioFormatFloat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferFloat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/Open.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/OpenStream.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/Set8BitExtensionBuffer.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/SetLoopType.java ! test/javax/sound/midi/Gervill/ModelDestination/NewModelDestination.java ! test/javax/sound/midi/Gervill/ModelDestination/NewModelDestinationModelIdentifier.java ! test/javax/sound/midi/Gervill/ModelDestination/SetIdentifier.java ! test/javax/sound/midi/Gervill/ModelDestination/SetTransform.java ! test/javax/sound/midi/Gervill/ModelIdentifier/EqualsObject.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierString.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringInt.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringString.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringStringInt.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetInstance.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetObject.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetVariable.java ! test/javax/sound/midi/Gervill/ModelPerformer/GetOscillators.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetConnectionBlocks.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetDefaultConnectionsEnabled.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetExclusiveClass.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetKeyFrom.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetKeyTo.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetName.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetSelfNonExclusive.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetVelFrom.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetVelTo.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSource.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifier.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBoolean.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBooleanBoolean.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBooleanBooleanInt.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierModelTransform.java ! test/javax/sound/midi/Gervill/ModelSource/SetIdentifier.java ! test/javax/sound/midi/Gervill/ModelSource/SetTransform.java ! test/javax/sound/midi/Gervill/ModelStandardIndexedDirector/ModelStandardIndexedDirectorTest.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransform.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBoolean.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBooleanBoolean.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBooleanBooleanInt.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetDirection.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetPolarity.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetTransform.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformAbsolute.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformConcave.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformConvex.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformLinear.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformSwitch.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Available.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Close.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/GetFilePointer.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/GetSize.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/HasNextChunk.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Read.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadByte.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadByteArrayIntInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadLong.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadShort.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadString.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedByte.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedShort.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Skip.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/WriteOutputStream.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankFile.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankInputStream.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankInputStream2.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankUrl.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrument.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformer.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArray.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/Clear.java ! test/javax/sound/midi/Gervill/SimpleInstrument/SetName.java ! test/javax/sound/midi/Gervill/SimpleInstrument/SetPatch.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/AddInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/AddResource.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/GetInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/RemoveInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetDescription.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetName.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetVendor.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetVersion.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Array.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Clear.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Get.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/NewSoftAudioBuffer.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/GetFormat.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/GetPropertyInfo.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/Open.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/OpenStream.java ! test/javax/sound/midi/Gervill/SoftChannel/AllNotesOff.java ! test/javax/sound/midi/Gervill/SoftChannel/AllSoundOff.java ! test/javax/sound/midi/Gervill/SoftChannel/ChannelPressure.java ! test/javax/sound/midi/Gervill/SoftChannel/Controller.java ! test/javax/sound/midi/Gervill/SoftChannel/LocalControl.java ! test/javax/sound/midi/Gervill/SoftChannel/Mono.java ! test/javax/sound/midi/Gervill/SoftChannel/Mute.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOff.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOff2.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOn.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest2.java ! test/javax/sound/midi/Gervill/SoftChannel/Omni.java ! test/javax/sound/midi/Gervill/SoftChannel/PitchBend.java ! test/javax/sound/midi/Gervill/SoftChannel/PolyPressure.java ! test/javax/sound/midi/Gervill/SoftChannel/ProgramAndBankChange.java ! test/javax/sound/midi/Gervill/SoftChannel/ProgramChange.java ! test/javax/sound/midi/Gervill/SoftChannel/ResetAllControllers.java ! test/javax/sound/midi/Gervill/SoftChannel/SoftTestUtils.java ! test/javax/sound/midi/Gervill/SoftChannel/Solo.java ! test/javax/sound/midi/Gervill/SoftCubicResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftFilter/TestProcessAudio.java ! test/javax/sound/midi/Gervill/SoftLanczosResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_mono.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_mono_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_normal.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_normal_mono.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_overdrive_mono.java ! test/javax/sound/midi/Gervill/SoftLinearResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLinearResampler2/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java ! test/javax/sound/midi/Gervill/SoftPointResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftProvider/GetDevice.java ! test/javax/sound/midi/Gervill/SoftReceiver/Close.java ! test/javax/sound/midi/Gervill/SoftReceiver/GetMidiDevice.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ActiveSense.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_AllNotesOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_AllSoundOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ChannelPressure.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Controller.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Mono.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_AllChannels.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_Delayed.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_Multiple.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Omni.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_PitchBend.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_PolyPressure.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ProgramChange.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ResetAllControllers.java ! test/javax/sound/midi/Gervill/SoftReceiver/SoftTestUtils.java ! test/javax/sound/midi/Gervill/SoftSincResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/Close.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetAvailableInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetAvailableInstruments2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetChannels.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetDefaultSoundbank.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetDeviceInfo.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLatency.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLoadedInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLoadedInstruments2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxPolyphony.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxReceivers.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxTransmitters.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMicrosecondPosition.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetPropertyInfo.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceiver.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceiver2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceivers.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetTransmitter.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetTransmitters.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetVoiceStatus.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/ImplicitOpenClose.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/IsOpen.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/IsSoundbankSupported.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/Open.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/OpenStream.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/RemapInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestDisableLoadDefaultSoundbank.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestPreciseTimestampRendering.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestRender1.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstruments.java ! test/javax/sound/midi/Gervill/SoftTuning/GetName.java ! test/javax/sound/midi/Gervill/SoftTuning/GetTuning.java ! test/javax/sound/midi/Gervill/SoftTuning/GetTuningInt.java ! test/javax/sound/midi/Gervill/SoftTuning/Load1.java ! test/javax/sound/midi/Gervill/SoftTuning/Load2.java ! test/javax/sound/midi/Gervill/SoftTuning/Load4.java ! test/javax/sound/midi/Gervill/SoftTuning/Load5.java ! test/javax/sound/midi/Gervill/SoftTuning/Load6.java ! test/javax/sound/midi/Gervill/SoftTuning/Load7.java ! test/javax/sound/midi/Gervill/SoftTuning/Load8.java ! test/javax/sound/midi/Gervill/SoftTuning/Load9.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuning.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningByteArray.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningPatch.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningPatchByteArray.java ! test/javax/sound/midi/Gervill/SoftTuning/RealTimeTuning.java ! test/javax/sound/midi/MidiDeviceConnectors/TestAllDevices.java ! test/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java ! test/javax/sound/sampled/AudioFormat/Matches_NOT_SPECIFIED.java ! test/javax/sound/sampled/AudioFormat/PCM_FLOAT_support.java ! test/javax/sound/sampled/Clip/ClipSetPos.java ! test/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java ! test/javax/sound/sampled/DirectAudio/bug6400879.java ! test/javax/sound/sampled/FileWriter/AlawEncoderSync.java ! test/javax/sound/sampled/FileWriter/WriterCloseInput.java ! test/javax/swing/JCheckBox/4449413/bug4449413.html ! test/javax/swing/JColorChooser/Test4222508.html ! test/javax/swing/JColorChooser/Test4759306.html ! test/javax/swing/JColorChooser/Test4759934.html ! test/javax/swing/JColorChooser/Test4887836.html ! test/javax/swing/JColorChooser/Test6348456.html ! test/javax/swing/JColorChooser/Test6977726.html ! test/javax/swing/JComponent/4337267/bug4337267.java ! test/javax/swing/JComponent/6683775/bug6683775.java ! test/javax/swing/JEditorPane/4492274/test.html ! test/javax/swing/JEditorPane/6917744/test.html ! test/javax/swing/JEditorPane/bug4714674.java ! test/javax/swing/JFileChooser/6570445/bug6570445.java ! test/javax/swing/JFileChooser/6698013/bug6698013.html ! test/javax/swing/JFileChooser/6698013/bug6698013.java ! test/javax/swing/JFileChooser/6798062/bug6798062.html ! test/javax/swing/JInternalFrame/6726866/bug6726866.html ! test/javax/swing/JInternalFrame/6726866/bug6726866.java ! test/javax/swing/JSlider/4987336/bug4987336.html ! test/javax/swing/JSlider/6524424/bug6524424.html ! test/javax/swing/JSlider/6587742/bug6587742.html ! test/javax/swing/JSlider/6742358/bug6742358.html ! test/javax/swing/JTabbedPane/4310381/bug4310381.html ! test/javax/swing/JTree/4314199/bug4314199.html ! test/javax/swing/SwingUtilities/7170657/bug7170657.java ! test/javax/swing/border/Test4129681.html ! test/javax/swing/border/Test4243289.html ! test/javax/swing/border/Test4247606.html ! test/javax/swing/border/Test4252164.html ! test/javax/swing/border/Test4760089.html ! test/javax/swing/border/Test6910490.html ! test/javax/swing/border/Test7022041.java ! test/javax/swing/text/html/TableView/7030332/bug7030332.html ! test/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html ! test/sun/nio/cs/EUC_TW_OLD.java ! test/sun/nio/cs/TestStringCoding.java ! test/sun/nio/cs/X11CNS11643.java ! test/sun/nio/cs/X11CNS11643P1.java ! test/sun/nio/cs/X11CNS11643P2.java ! test/sun/nio/cs/X11CNS11643P3.java ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.java ! test/sun/security/pkcs11/ec/TestECGenSpec.java ! test/sun/security/pkcs11/ec/TestKeyFactory.java ! test/sun/util/resources/Locale/Bug6275682.java ! test/tools/launcher/DiacriticTest.java ! test/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java ! test/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java Changeset: d6fe4e451dfb Author: bagiras Date: 2013-11-13 20:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6fe4e451dfb 8028283: Revert JavaDoc changes pushed for JDK-7068423 Reviewed-by: art, serb ! src/share/classes/java/awt/GraphicsDevice.java Changeset: 535f19dd3960 Author: pchelko Date: 2013-11-14 10:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/535f19dd3960 8028230: Behavior of SystemFlavorMap.getNativesForFlavor differ from that in Java 7 Reviewed-by: anthony, serb ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java + test/java/awt/datatransfer/DuplicatedNativesTest/DuplicatedNativesTest.java Changeset: 8d17ebcef958 Author: pchelko Date: 2013-11-14 11:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d17ebcef958 8025440: [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108 Reviewed-by: anthony + test/com/sun/awt/SecurityWarning/CustomSecurityManager.java ! test/com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java + test/java/awt/regtesthelpers/CopyClassFile.java Changeset: ca0db77f6d6b Author: lana Date: 2013-11-14 23:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca0db77f6d6b Merge Changeset: fc4ac66aa657 Author: lana Date: 2013-11-15 07:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc4ac66aa657 Merge ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/sun/awt/AppContext.java - src/share/classes/sun/management/OperatingSystemImpl.java - src/share/native/java/lang/ref/Finalizer.c - src/solaris/classes/com/sun/management/OSMBeanFactory.java - src/solaris/classes/com/sun/management/UnixOperatingSystem.java - src/solaris/native/com/sun/management/LinuxOperatingSystem.c - src/solaris/native/com/sun/management/MacosxOperatingSystem.c - src/solaris/native/com/sun/management/SolarisOperatingSystem.c - src/solaris/native/com/sun/management/UnixOperatingSystem_md.c - src/windows/classes/com/sun/management/OSMBeanFactory.java - src/windows/classes/com/sun/management/OperatingSystem.java - src/windows/native/com/sun/management/OperatingSystem_md.c ! test/ProblemList.txt - test/java/lang/management/ThreadMXBean/ThreadStateTest.java - test/java/lang/reflect/Method/DefaultMethodModeling.java - test/java/net/URLPermission/nstest/policy ! test/java/util/regex/RegExTest.java - test/lib/testlibrary/jdk/testlibrary/JdkFinder.java Changeset: 8bc258c021a3 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8bc258c021a3 Added tag jdk8-b117 for changeset fc4ac66aa657 ! .hgtags Changeset: ee3c7ab60373 Author: lana Date: 2013-11-25 09:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee3c7ab60373 Merge ! make/CompileDemos.gmk ! make/SignJars.gmk ! test/ProblemList.txt ! test/tools/launcher/DiacriticTest.java From serguei.spitsyn at oracle.com Mon Nov 25 11:42:43 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 25 Nov 2013 11:42:43 -0800 Subject: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name In-Reply-To: <52939142.3020202@oracle.com> References: <52939142.3020202@oracle.com> Message-ID: <5293A833.9030500@oracle.com> It looks good. Checking 'name' instead of 'debug_name' before 'debug_name' is allocated would be even better. But it'd be a multi-line fix. :) Thanks, Serguei On 11/25/13 10:04 AM, Dmitry Samersoff wrote: > Hi Everyone, > > Please review a day-1 typeo in jsdbproc64.sh > > http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/ > > From serguei.spitsyn at oracle.com Mon Nov 25 11:46:04 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 25 Nov 2013 11:46:04 -0800 Subject: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name In-Reply-To: <5293A833.9030500@oracle.com> References: <52939142.3020202@oracle.com> <5293A833.9030500@oracle.com> Message-ID: <5293A8FC.2080107@oracle.com> Please, skip it. My comment belongs to another review request. I'll re-send it in a separate e-mail. Thanks, Serguei On 11/25/13 11:42 AM, serguei.spitsyn at oracle.com wrote: > It looks good. > Checking 'name' instead of 'debug_name' before 'debug_name' is > allocated would be even better. > But it'd be a multi-line fix. :) > > Thanks, > Serguei > > On 11/25/13 10:04 AM, Dmitry Samersoff wrote: >> Hi Everyone, >> >> Please review a day-1 typeo in jsdbproc64.sh >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/ >> >> > From serguei.spitsyn at oracle.com Mon Nov 25 11:46:47 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 25 Nov 2013 11:46:47 -0800 Subject: RR(XS): JDK-6969276 minor memory leak detected by cppcheck in agent/src/os/linux/symtab.c In-Reply-To: <52938D9C.2060806@oracle.com> References: <52938D9C.2060806@oracle.com> Message-ID: <5293A927.9080009@oracle.com> It looks good. Checking 'name' instead of 'debug_name' before 'debug_name' is allocated would be even better. But it'd be a multi-line fix. :) Thanks, Serguei On 11/25/13 9:49 AM, Dmitry Samersoff wrote: > Hi Everyone, > > Please review an XS fix - missed free() call discovered by cppcheck tool. > > http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/ > > -Dmitry > From serguei.spitsyn at oracle.com Mon Nov 25 11:47:11 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 25 Nov 2013 11:47:11 -0800 Subject: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name In-Reply-To: <52939142.3020202@oracle.com> References: <52939142.3020202@oracle.com> Message-ID: <5293A93F.6010007@oracle.com> It looks good. Thanks, Serguei On 11/25/13 10:04 AM, Dmitry Samersoff wrote: > Hi Everyone, > > Please review a day-1 typeo in jsdbproc64.sh > > http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/ > > From dmitry.samersoff at oracle.com Mon Nov 25 11:53:38 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 25 Nov 2013 23:53:38 +0400 Subject: RR(XS): JDK-6969276 minor memory leak detected by cppcheck in agent/src/os/linux/symtab.c In-Reply-To: <5293A927.9080009@oracle.com> References: <52938D9C.2060806@oracle.com> <5293A927.9080009@oracle.com> Message-ID: <5293AAC2.3060104@oracle.com> Serguei, Thank you for the review. Actually, I don't see a reason to use malloc here - UNIX path is limited to 1024 bytes so it's possible to just allocate on-stack buffer and use snprintf to make sure we don't overflow it. But it's out of scope of this simple fix. -Dmitry On 2013-11-25 23:46, serguei.spitsyn at oracle.com wrote: > > It looks good. > Checking 'name' instead of 'debug_name' before 'debug_name' is allocated > would be even better. > But it'd be a multi-line fix. :) > > Thanks, > Serguei > On 11/25/13 9:49 AM, Dmitry Samersoff wrote: >> Hi Everyone, >> >> Please review an XS fix - missed free() call discovered by cppcheck tool. >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/ >> >> -Dmitry >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From serguei.spitsyn at oracle.com Mon Nov 25 12:00:01 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 25 Nov 2013 12:00:01 -0800 Subject: RR(XS): JDK-6969276 minor memory leak detected by cppcheck in agent/src/os/linux/symtab.c In-Reply-To: <5293AAC2.3060104@oracle.com> References: <52938D9C.2060806@oracle.com> <5293A927.9080009@oracle.com> <5293AAC2.3060104@oracle.com> Message-ID: <5293AC41.9070401@oracle.com> Agreed. Thanks, Serguei On 11/25/13 11:53 AM, Dmitry Samersoff wrote: > Serguei, > > Thank you for the review. > > Actually, I don't see a reason to use malloc here - UNIX path is limited > to 1024 bytes so it's possible to just allocate on-stack buffer and use > snprintf to make sure we don't overflow it. > > But it's out of scope of this simple fix. > > -Dmitry > > > On 2013-11-25 23:46, serguei.spitsyn at oracle.com wrote: >> It looks good. >> Checking 'name' instead of 'debug_name' before 'debug_name' is allocated >> would be even better. >> But it'd be a multi-line fix. :) >> >> Thanks, >> Serguei >> On 11/25/13 9:49 AM, Dmitry Samersoff wrote: >>> Hi Everyone, >>> >>> Please review an XS fix - missed free() call discovered by cppcheck tool. >>> >>> http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/ >>> >>> -Dmitry >>> > From sean.mullan at oracle.com Mon Nov 25 13:06:43 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 25 Nov 2013 16:06:43 -0500 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5293BBE3.7040709@oracle.com> Hi Volker, The security changes look fine. I'm not crazy that we now have to maintain one additional java.security file which is the exact same as java.security-linux, but this is really an existing issue with duplicated content across the java.security files which I will try to fix early in JDK 9: https://bugs.openjdk.java.net/browse/JDK-6997010 Thanks, Sean On 11/20/2013 01:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on > AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first round > and to further streamline the patch (it perfectly builds on Linux/x86_64, > Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The biggest change > compared to the first review round is the new "aix/" subdirectory which > I've now created under "jdk/src" and which contains AIX-only code. > > The webrev is against our > http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been > recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I need > the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. > So please don't hesitate to jump at it - there are enough changes for > everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for collecting > them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments (15 > Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > - Added these two files for AIX relevant utility code. > - Currently these files only contain an implementation of dladdr which > is not available on AIX. > - In the first review round the existing dladdr users in the code either > called the version from the HotSpot on AIX ( > src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of > the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). This > is now not necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > makefiles/CompileDemos.gmk > > - Add an extra argument to SetupJVMTIDemo which can be used to pass > additional source locations. > - Currently this is only used on AIX for the AIX porting utilities which > are required by hprof. > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > - On AIX add the sources of the AIX porting utilities to the build. They > are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and > src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not available > on AIX. > > makefiles/lib/NioLibraries.gmk > > - Make the AIX-build aware of the new NIO source locations under > src/aix/native/sun/nio/. > > makefiles/lib/NetworkingLibraries.gmk > > - Make the AIX-build aware of the new aix_close.c source location under > src/aix/native/java/net/. > > src/share/bin/jli_util.h > > - Define JLI_Lseek on AIX. > > src/share/lib/security/java.security-aix > > - Provide default java.security-aix for AIX based on the latest Linux > version as suggested by Sean Mullan. > > src/share/native/common/check_code.c > > - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in check_code.c does not handles this properly. So > we wrap the two methods on AIX and return a non-NULL pointer even if we > allocate 0 bytes. > > src/share/native/sun/awt/medialib/mlib_sys.c > > - malloc always returns 8-byte aligned pointers on AIX as well. > > src/share/native/sun/awt/medialib/mlib_types.h > > - Add AIX to the list of known platforms. > > src/share/native/sun/font/layout/KernTable.cpp > > - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too common > and may be defined in other headers as well as on the command line and > xlc bails out on macro redefinitions with a different value. > > src/share/native/sun/security/ec/impl/ecc_impl.h > > - Define required types and macros on AIX. > > src/solaris/back/exec_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > - On AIX LD_LIBRARY_PATH is called LIBPATH > - Always use LD_LIBRARY_PATH macro instead of using the string " > LD_LIBRARY_PATH" directly to cope with different library path names. > - Add jre/lib//jli to the standard library search path on AIX > because the AIX linker doesn't support the -rpath option. > - Replace #ifdef __linux__ by #ifndef __solaris__ because in this case, > AIX behaves like Linux. > - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from > java_md_solinux.h because the macros are redefined in the corresponding > .c files anyway. > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > - Provide basic fontconfig.propertiesfor AIX. > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > - Provide AIX specific Java versions, mostly based on the corresponding > Linux versions. > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > - Detect AIX operating system and return the corresponding channel and > file system providers. > > src/solaris/classes/sun/nio/ch/Port.java > > - Add a callback function unregisterImpl(int fd) for implementations > that need special handling when fd is removed and call it from > unregister(int > fd). By default the implementation of unregisterImpl(int fd) is empty > except for the derived AixPollPort class on AIX. > > src/solaris/demo/jvmti/hprof/hprof_md.c > > - Add AIX support. AIX mostly behaves like Linux, with the one exception > that it has no dladdr functionality. > - Use the dladdr implementation from porting_aix.{c,h} on AIX. > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). > > src/solaris/native/common/jdk_util_md.h > > - Add AIX definitions of the ISNANF and ISNAND macros. > > src/solaris/native/java/io/io_util_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/native/java/lang/UNIXProcess_md.c > > - AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > src/solaris/native/java/lang/childproc.c > > - AIX does not understand '/proc/self' - it requires the real process ID > to query the proc file system for the current process. > > src/solaris/native/java/net/NetworkInterface.c > > - Add AIX support into the Linux branch because AIX mostly behaves like > AIX for IPv4. > - AIX needs a special function to enumerate IPv6 interfaces and to query > the MAC address. > - Moved the declaration of siocgifconfRequest to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > src/solaris/native/java/net/PlainSocketImpl.c > > - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the > socket is closed. The default error message is then confusing. > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > - As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of linux_close.c to > src/aix/native/java/net/aix_close.cbecause we also need the file and > socket wrappers on AIX. > - Compared to the Linux version, we've added the initialization of some > previously uninitialized data structures. > - Also, on AIX we don't have __attribute((constructor)) so we need to > initialize manually (from JNI_OnLoad() in > src/share/native/java/net/net_util.c. > > src/solaris/native/java/net/net_util_md.h > > - AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > src/solaris/native/java/net/net_util_md.c > > - SO_REUSEADDR is called SO_REUSEPORT on AIX. > - On AIX we have to ignore failures due to ENOBUFS when setting the > SO_SNDBUF/SO_RCVBUF socket options. > > src/solaris/native/java/util/TimeZone_md.c > > - Currently on AIX the only way to get the platform time zone is to read > it from the TZ environment variable. > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > - Use the dladdr from porting_aix.{c,h} on AIX. > > src/solaris/native/sun/awt/fontpath.c > > - Changed some macros from if !defined(__linux__) to if > defined(__solaris__) because that's their real meaning. > - Add AIX specific fontpath settings and library search paths for > libfontconfig.so. > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name > clashes (MIN and MAX are much too common and thexy are already defined > in some AIX system headers). > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > - Handle AIX like Solaris. > > src/solaris/native/sun/nio/ch/Net.c > > - Add AIX-specific includes and constant definitions. > - On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate exceptions > if it is requested but not supported. This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. > - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to NULL > for the directory stream end. Otherwise, 'errno' will contain the error > code. > - Handle some AIX corner cases for the results of the statvfs64() call. > - On AIX getgrgid_r() returns ESRCH if group does not exist. > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > - Port this test to AIX and make it more robust (i.e. recognize the "C" > locale as isEnglish(), ignore VM-warnings in the output, make sure the > "grandchild" processes created by the test don't run too long (60s vs. > 6666s) because in the case of test problems these processes will pollute > the process space, make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, _AIX is defined in some system headers while AIX is defined by the > build system. This is already used inconsistently (i.e. __linux__ vs. LINUX) > and in general I try to be consistent with the style of the file where I > the changes are. That said, I changes most of the occurences of AIX to _AIX. > > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and currently > called IBM i) in our OpenJDK port but we do support it in our internel, SAP > JVM build. We stripped out all the extra OS/400 functionality from the port > but in some places where there is common functionality needd by both, AIX > and OS/400 the OS/400 support may still be visible in the OpenJDK port. I > don't think this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've removed all > the references to OS/400 now. > From michael.fang at oracle.com Mon Nov 25 14:15:35 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Mon, 25 Nov 2013 22:15:35 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20131125221542.D8A6C62830@hg.openjdk.java.net> Changeset: abd44ea60dbe Author: mfang Date: 2013-11-21 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/abd44ea60dbe 8028803: jdk8 l10n resource file translation update 5 - jaxp repo Reviewed-by: joehw, yhuang ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_CN.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_CN.java Changeset: e65463c785ed Author: mfang Date: 2013-11-25 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e65463c785ed Merge From volker.simonis at gmail.com Mon Nov 25 14:30:26 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 25 Nov 2013 23:30:26 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <52937223.408@oracle.com> References: <52937223.408@oracle.com> Message-ID: Hi Artem, thanks a lot for your review. Please find my comments inline: On Monday, November 25, 2013, Artem Ananiev wrote: > Hi, Volker, > > just a few very minor comments about the client changes: > > 1. mlib_sys.c: the change is fine, but it makes the following comment > obsolete. You're right. I'll update the comment and try to find a corresponding reference for the AIX compiler. > 2. XRBackendNative.c: the same comment here. Again, I'll update the comment accordingly. > 3. Awt2dLibraries.gmk: $(JDK_TOPDIR)/src/aix/porting/porting_aix.c would > be better than just porting_aix.c Good catch! I think the right solution would be to add $(JDK_TOPDIR)/src/aix/porting to LIBAWT_DIRS. This will also add the directory automatically to LIBAWT_CFLAGS. I'll prepare a final webrev with all the proposed changes tomorrow. Thanks once again, Volker > > Thanks, > > Artem > > On 11/20/2013 10:26 PM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on AIX >> ". The previous >> reviews can be found at the end of this mail in the references section. >> >> I've tried to address all the comments and suggestions from the first >> round and to further streamline the patch (it perfectly builds on >> Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The >> biggest change compared to the first review round is the new "aix/" >> subdirectory which I've now created under "jdk/src" and which contains >> AIX-only code. >> >> The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stage >> repository which has been recently synchronised with the jdk8 master: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ >> >> Below (and in the webrev) you can find some comments which explain the >> changes to each file. In order to be able to push this big change, I >> need the approval of reviewers from the lib, net, svc, 2d, awt and sec >> groups. So please don't hesitate to jump at it - there are enough >> changes for everybody:) >> >> Thank you and best regards, >> Volker >> >> *References:* >> >> The following reviews have been posted so far (thanks Iris for >> collecting them :) >> >> - Alan Bateman (lib): Initial comments (16 Sep [2]) >> - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) >> - Michael McMahon (net): Initial comments (20 Sept [4]) >> - Steffan Larsen (svc): APPROVED (20 Sept [5]) >> - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments >> (15 Oct [7]) >> - Sean Mullan (sec): Initial comments (26 Sept [8]) >> >> [2]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001045.html >> [3]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001078.html >> [4]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001079.html >> [5]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001077.html >> [6]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001069.html >> [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/ >> 003826.html >> [8]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001081.html >> >> >> *Detailed change description:* >> >> The new "jdk/src/aix" subdirectory contains the following new and >> AIX-specific files for now: >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java >> src/aix/classes/sun/nio/ch/AixPollPort.java >> src/aix/classes/sun/nio/fs/AixFileStore.java >> src/aix/classes/sun/nio/fs/AixFileSystem.java >> src/aix/classes/sun/nio/fs/AixFileSystemProvider.java >> src/aix/classes/sun/nio/fs/AixNativeDispatcher.java >> src/aix/classes/sun/tools/attach/AixAttachProvider.java >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java >> src/aix/native/java/net/aix_close.c >> src/aix/native/sun/nio/ch/AixPollPort.c >> src/aix/native/sun/nio/fs/AixNativeDispatcher.c >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> * Added these two files for AIX relevant utility code. >> * Currently these files only contain an implementation of |dladdr| >> which is not available on AIX. >> * In the first review round the existing |dladdr| users in the code >> either called the version from the HotSpot on AIX >> (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private >> copy of the whole implementation >> (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not >> necessary any more. >> >> The new file layout required some small changes to the makefiles to make >> them aware of the new directory locations: >> >> >> makefiles/CompileDemos.gmk >> >> * Add an extra argument to |SetupJVMTIDemo| which can be used to pass >> additional source locations. >> * Currently this is only used on AIX for the AIX porting utilities >> which are required by hprof. >> >> >> makefiles/lib/Awt2dLibraries.gmk >> makefiles/lib/ServiceabilityLibraries.gmk >> >> * On AIX add the sources of the AIX porting utilities to the build. >> They are required by |src/solaris/native/sun/awt/awt_LoadLibrary.c| >> and |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is >> not available on AIX. >> >> >> makefiles/lib/NioLibraries.gmk >> >> * Make the AIX-build aware of the new NIO source locations under >> |src/aix/native/sun/nio/|. >> >> >> makefiles/lib/NetworkingLibraries.gmk >> >> * Make the AIX-build aware of the new |aix_close.c| source location >> under |src/aix/native/java/net/|. >> >> >> src/share/bin/jli_util.h >> >> * Define |JLI_Lseek| on AIX. >> >> >> src/share/lib/security/java.security-aix >> >> * Provide default |java.security-aix| for AIX based on the latest >> Linux version as suggested by Sean Mullan. >> >> >> src/share/native/common/check_code.c >> >> * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is >> legal, but the code in |check_code.c| does not handles this >> properly. So we wrap the two methods on AIX and return a non-NULL >> pointer even if we allocate 0 bytes. >> >> >> src/share/native/sun/awt/medialib/mlib_sys.c >> >> * |malloc| always returns 8-byte aligned pointers on AIX as well. >> >> >> src/share/native/sun/awt/medialib/mlib_types.h >> >> * Add AIX to the list of known platforms. >> >> >> src/share/native/sun/font/layout/KernTable.cpp >> >> * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is >> too common and may be defined in other headers as well as on the >> command line and |xlc| bails out on macro redefinitions with a >> different value. >> >> >> src/share/native/sun/security/ec/impl/ecc_impl.h >> >> * Define required types and macros on AIX. >> >> >> src/solaris/back/exec_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/bin/java_md_solinux.c, >> src/solaris/bin/java_md_solinux.h >> >> * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| >> * Always use |LD_LIBRARY_PATH| macro instead of using the string >> "|LD_LIBRARY_PATH|" directly to cope with different library path >> names. >> * Add |jre/lib//jli| to the standard library search path on AIX >> because the AIX linker doesn't support the |-rpath| option. >> * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in this >> case, AIX behaves like Linux. >> * Removed the definition of |JVM_DLL|, |JAVA_DLL| and >> |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are >> redefined in the corresponding |.c| files anyway. >> >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> >> * Provide basic |fontconfig.properties|for AIX. >> >> >> src/solaris/classes/java/lang/UNIXProcess.java.aix, >> src/aix/classes/sun/tools/attach/AixAttachProvider.java, >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java, >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> >> * Provide AIX specific Java versions, mostly based on the >> corresponding Linux versions. >> >> >> src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProv >> ider.java >> src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java >> >> * Detect AIX operating system and return the corresponding channel and >> file system providers. >> >> >> src/solaris/classes/sun/nio/ch/Port.java >> >> * Add a callback function |unregisterImpl(int fd)| for implementations >> that need special handling when |fd| is removed and call it from >> |unregister(int fd)|. By default the implementation of >> |unregisterImpl(int fd)| is empty except for the derived >> |AixPollPort| class on AIX. >> >> >> src/solaris/demo/jvmti/hprof/hprof_md.c >> >> * Add AIX support. AIX mostly behaves like Linux, with the one >> exception that it has no |dladdr| functionality. >> * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/com/sun/management/UnixOperatingSystem_md.c >> >> * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). >> >> >> src/solaris/native/common/jdk_util_md.h >> >> * Add AIX definitions of the |ISNANF| and |ISNAND| macros. >> >> >> src/solaris/native/java/io/io_util_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/native/java/lang/UNIXProcess_md.c >> >> * AIX behaves mostly like Solraris in this case so adjust the ifdefs >> accordingly. >> >> >> src/solaris/native/java/lang/childproc.c >> >> * AIX does not understand '/proc/self' - it requires the real process >> ID to query the proc file system for the current process. >> >> >> src/solaris/native/java/net/NetworkInterface.c >> >> * Add AIX support into the Linux branch because AIX mostly behaves >> like AIX for IPv4. >> * AIX needs a special function to enumerate IPv6 interfaces and to >> query the MAC address. >> * Moved the declaration of |siocgifconfRequest| to the beginning a the >> function (as recommend by Michael McMahon) to remain C89 compatible. >> >> >> src/solaris/native/java/net/PlainSocketImpl.c >> >> * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| if >> the socket is closed. The default error message is then confusing. >> >> >> src/aix/native/java/net/aix_close.c, >> src/share/native/java/net/net_util.c >> >> * As recommended by Michael McMahon and Alan Bateman I've move an >> adapted version of |linux_close.c| to >> |src/aix/native/java/net/aix_close.c| because we also need the file >> and socket wrappers on AIX. >> * Compared to the Linux version, we've added the initialization of >> some previously uninitialized data structures. >> * Also, on AIX we don't have |__attribute((constructor))| so we need >> to initialize manually (from |JNI_OnLoad()| in >> |src/share/native/java/net/net_util.c|. >> >> >> src/solaris/native/java/net/net_util_md.h >> >> * AIX needs the same workaround for I/O cancellation like Linux and >> MacOSX. >> >> >> src/solaris/native/java/net/net_util_md.c >> >> * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. >> * On AIX we have to ignore failures due to |ENOBUFS| when setting the >> |SO_SNDBUF|/|SO_RCVBUF| socket options. >> >> >> src/solaris/native/java/util/TimeZone_md.c >> >> * Currently on AIX the only way to get the platform time zone is to >> read it from the |TZ| environment variable. >> >> >> src/solaris/native/sun/awt/awt_LoadLibrary.c >> >> * Use the |dladdr| from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/sun/awt/fontpath.c >> >> * Changed some macros from |if !defined(__linux__)| to |if >> defined(__solaris__)| because that's their real meaning. >> * Add AIX specific fontpath settings and library search paths for >> |libfontconfig.so|. >> >> >> src/solaris/native/sun/java2d/x11/X11SurfaceData.c >> >> * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to >> avoid name clashes (|MIN| and |MAX| are much too common and thexy >> are already defined in some AIX system headers). >> >> >> src/solaris/native/sun/java2d/x11/XRBackendNative.c >> >> * Handle AIX like Solaris. >> >> >> src/solaris/native/sun/nio/ch/Net.c >> >> * Add AIX-specific includes and constant definitions. >> * On AIX "socket extensions for multicast source filters" support >> depends on the OS version. Check for this and throw appropriate >> exceptions if it is requested but not supported. This is needed to >> pass >> JCK-api/java_nio/channels/DatagramChannel/ >> DatagramChannel.html#Multicast >> >> >> src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c >> >> * On AIX |strerror()| is not thread-safe so we have to use >> |strerror_r()| instead. >> * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to >> NULL for the directory stream end. Otherwise, 'errno' will contain >> the error code. >> * Handle some AIX corner cases for the results of the |statvfs64()| >> call. >> * On AIX |getgrgid_r()| returns ESRCH if group does not exist. >> >> >> src/solaris/native/sun/security/pkcs11/j2secmod_md.c >> >> * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. >> >> >> test/java/lang/ProcessBuilder/Basic.java >> test/java/lang/ProcessBuilder/DestroyTest.java >> >> * Port this test to AIX and make it more robust (i.e. recognize the >> "C" locale as |isEnglish()|, ignore VM-warnings in the output, make >> sure the "grandchild" processes created by the test don't run too >> long (60s vs. 6666s) because in the case of test problems these >> processes will pollute the process space, make sure the test fails >> with an error and doesn't hang indefinitley in the case of a problem). >> >> *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this >> intended? >> >> Well, |_AIX| is defined in some system headers while |AIX| is defined by >> the build system. This is already used inconsistently (i.e. |__linux__| >> vs. |LINUX|) and in general I try to be consistent with the style of the >> file where I the changes are. That said, I changes most of the >> occurences of |AIX| to |_AIX|. >> >> *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are >> they supposed to be there? >> >> We currently don't support OS/400 (later renamed into i5/OS and >> currently called IBM i) in our OpenJDK port but we do support it in our >> internel, SAP JVM build. We stripped out all the extra OS/400 >> functionality from the port but in some places where there is common >> functionality needd by both, AIX and OS/400 the OS/400 support may still >> be visible in the OpenJDK port. I don't think this is a real problem and >> it helps us to keep our internel sources in sync with the OpenJDK port. >> That said, I think I've removed all the references to OS/400 now. >> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131125/dfce4466/attachment-0001.html From volker.simonis at gmail.com Mon Nov 25 14:35:33 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 25 Nov 2013 23:35:33 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <5293BBE3.7040709@oracle.com> References: <5293BBE3.7040709@oracle.com> Message-ID: Hi Sean, thanks a lot for you review. Please let me know once you start working on 6997010 so I can update the corresponding AIX file accordingly. Regards, Volker On Monday, November 25, 2013, Sean Mullan wrote: > Hi Volker, > > The security changes look fine. I'm not crazy that we now have to maintain > one additional java.security file which is the exact same as > java.security-linux, but this is really an existing issue with duplicated > content across the java.security files which I will try to fix early in JDK > 9: https://bugs.openjdk.java.net/browse/JDK-6997010 > > Thanks, > Sean > > On 11/20/2013 01:26 PM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on >> AIX". >> The previous reviews can be found at the end of this mail in the >> references >> section. >> >> I've tried to address all the comments and suggestions from the first >> round >> and to further streamline the patch (it perfectly builds on Linux/x86_64, >> Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The biggest change >> compared to the first review round is the new "aix/" subdirectory which >> I've now created under "jdk/src" and which contains AIX-only code. >> >> The webrev is against our >> http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been >> recently synchronised with the jdk8 master: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ >> >> Below (and in the webrev) you can find some comments which explain the >> changes to each file. In order to be able to push this big change, I need >> the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. >> So please don't hesitate to jump at it - there are enough changes for >> everybody:) >> >> Thank you and best regards, >> Volker >> >> *References:* >> >> The following reviews have been posted so far (thanks Iris for collecting >> them :) >> >> - Alan Bateman (lib): Initial comments (16 Sep [2]) >> - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) >> - Michael McMahon (net): Initial comments (20 Sept [4]) >> - Steffan Larsen (svc): APPROVED (20 Sept [5]) >> - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments (15 >> Oct [7]) >> - Sean Mullan (sec): Initial comments (26 Sept [8]) >> >> [2]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001045.html >> [3]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001078.html >> [4]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001079.html >> [5]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001077.html >> [6]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001069.html >> [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/ >> 003826.html >> [8]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001081.html >> >> >> *Detailed change description:* >> >> The new "jdk/src/aix" subdirectory contains the following new and >> AIX-specific files for now: >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java >> src/aix/classes/sun/nio/ch/AixPollPort.java >> src/aix/classes/sun/nio/fs/AixFileStore.java >> src/aix/classes/sun/nio/fs/AixFileSystem.java >> src/aix/classes/sun/nio/fs/AixFileSystemProvider.java >> src/aix/classes/sun/nio/fs/AixNativeDispatcher.java >> src/aix/classes/sun/tools/attach/AixAttachProvider.java >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java >> src/aix/native/java/net/aix_close.c >> src/aix/native/sun/nio/ch/AixPollPort.c >> src/aix/native/sun/nio/fs/AixNativeDispatcher.c >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> - Added these two files for AIX relevant utility code. >> - Currently these files only contain an implementation of dladdr which >> is not available on AIX. >> - In the first review round the existing dladdr users in the code >> either >> called the version from the HotSpot on AIX ( >> src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy >> of >> the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). >> This >> is now not necessary any more. >> >> The new file layout required some small changes to the makefiles to make >> them aware of the new directory locations: >> >> makefiles/CompileDemos.gmk >> >> - Add an extra argument to SetupJVMTIDemo which can be used to pass >> additional source locations. >> - Currently this is only used on AIX for the AIX porting utilities >> which >> are required by hprof. >> >> makefiles/lib/Awt2dLibraries.gmk >> makefiles/lib/ServiceabilityLibraries.gmk >> >> - On AIX add the sources of the AIX porting utilities to the build. >> They >> are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and >> src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not >> available >> on AIX. >> >> makefiles/lib/NioLibraries.gmk >> >> - Make the AIX-build aware of the new NIO source locations under >> src/aix/native/sun/nio/. >> >> makefiles/lib/NetworkingLibraries.gmk >> >> - Make the AIX-build aware of the new aix_close.c source location >> under >> src/aix/native/java/net/. >> >> src/share/bin/jli_util.h >> >> - Define JLI_Lseek on AIX. >> >> src/share/lib/security/java.security-aix >> >> - Provide default java.security-aix for AIX based on the latest Linux >> version as suggested by Sean Mullan. >> >> src/share/native/common/check_code.c >> >> - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is >> legal, but the code in check_code.c does not handles this properly. So >> we wrap the two methods on AIX and return a non-NULL pointer even if >> we >> allocate 0 bytes. >> >> src/share/native/sun/awt/medialib/mlib_sys.c >> >> - malloc always returns 8-byte aligned pointers on AIX as well. >> >> src/share/native/sun/awt/medialib/mlib_types.h >> >> - Add AIX to the list of known platforms. >> >> src/share/native/sun/font/layout/KernTable.cpp >> >> - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too >> common >> and may be defined in other headers as well as on the command line and >> xlc bails out on macro redefinitions with a different value. >> >> src/share/native/sun/security/ec/impl/ecc_impl.h >> >> - Define required types and macros on AIX. >> >> src/solaris/back/exec_md.c >> >> - AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> src/solaris/bin/java_md_solinux.c, >> src/solaris/bin/java_md_solinux.h >> >> - On AIX LD_LIBRARY_PATH is called LIBPATH >> - Always use LD_LIBRARY_PATH macro instead of using the string " >> LD_LIBRARY_PATH" directly to cope with different library path names. >> - Add jre/lib//jli to the standard library search path on AIX >> because the AIX linker doesn't support the -rpath option. >> - Replace #ifdef __linux__ by #ifndef __solaris__ because in this >> case, >> AIX behaves like Linux. >> - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from >> java_md_solinux.h because the macros are redefined in the >> corresponding >> .c files anyway. >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> >> - Provide basic fontconfig.propertiesfor AIX. >> >> src/solaris/classes/java/lang/UNIXProcess.java.aix, >> src/aix/classes/sun/tools/attach/AixAttachProvider.java, >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java, >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> >> - Provide AIX specific Java versions, mostly based on the >> corresponding >> Linux versions. >> >> src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java >> src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java >> >> - Detect AIX operating system and return the corresponding channel and >> file system providers. >> >> src/solaris/classes/sun/nio/ch/Port.java >> >> - Add a callback function unregisterImpl(int fd) for implementations >> that need special handling when fd is removed and call it from >> unregister(int >> fd). By default the implementation of unregisterImpl(int fd) is empty >> except for the derived AixPollPort class on AIX. >> >> src/solaris/demo/jvmti/hprof/hprof_md.c >> >> - Add AIX support. AIX mostly behaves like Linux, with the one >> exception >> that it has no dladdr functionality. >> - Use the dladdr implementation from porting_aix.{c,h} on AIX. >> >> src/solaris/native/com/sun/management/UnixOperatingSystem_md.c >> >> - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). >> >> src/solaris/native/common/jdk_util_md.h >> >> - Add AIX definitions of the ISNANF and ISNAND macros. >> >> src/solaris/native/java/io/io_util_md.c >> >> - AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> src/solaris/native/java/lang/UNIXProcess_md.c >> >> - AIX behaves mostly like Solraris in this case so adjust the ifdefs >> accordingly. >> >> src/solaris/native/java/lang/childproc.c >> >> - AIX does not understand '/proc/self' - it requires the real process >> ID >> to query the proc file system for the current process. >> >> src/solaris/native/java/net/NetworkInterface.c >> >> - Add AIX support into the Linux branch because AIX mostly behaves >> like >> AIX for IPv4. >> - AIX needs a special function to enumerate IPv6 interfaces and to >> query >> the MAC address. >> - Moved the declaration of siocgifconfRequest to the beginning a the >> function (as recommend by Michael McMahon) to remain C89 compatible. >> >> src/solaris/native/java/net/PlainSocketImpl.c >> >> - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the >> socket is closed. The default error message is then confusing. >> >> src/aix/native/java/net/aix_close.c, >> src/share/native/java/net/net_util.c >> >> - As recommended by Michael McMahon and Alan Bateman I've move an >> adapted version of linux_close.c to >> src/aix/native/java/net/aix_close.cbecause we also need the file and >> socket wrappers on AIX. >> - Compared to the Linux version, we've added the initialization of >> some >> previously uninitialized data structures. >> - Also, on AIX we don't have __attribute((constructor)) so we need to >> initialize manually (from JNI_OnLoad() in >> src/share/native/java/net/net_util.c. >> >> src/solaris/native/java/net/net_util_md.h >> >> - AIX needs the same workaround for I/O cancellation like Linux and >> MacOSX. >> >> src/solaris/native/java/net/net_util_md.c >> >> - SO_REUSEADDR is called SO_REUSEPORT on AIX. >> - On AIX we have to ignore failures due to ENOBUFS when setting the >> SO_SNDBUF/SO_RCVBUF socket options. >> >> src/solaris/native/java/util/TimeZone_md.c >> >> - Currently on AIX the only way to get the platform time zone is to >> read >> it from the TZ environment variable. >> >> src/solaris/native/sun/awt/awt_LoadLibrary.c >> >> - Use the dladdr from porting_aix.{c,h} on AIX. >> >> src/solaris/native/sun/awt/fontpath.c >> >> - Changed some macros from if !defined(__linux__) to if >> defined(__solaris__) because that's their real meaning. >> - Add AIX specific fontpath settings and library search paths for >> libfontconfig.so. >> >> src/solaris/native/sun/java2d/x11/X11SurfaceData.c >> >> - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name >> clashes (MIN and MAX are much too common and thexy are already defined >> in some AIX system headers). >> >> src/solaris/native/sun/java2d/x11/XRBackendNative.c >> >> - Handle AIX like Solaris. >> >> src/solaris/native/sun/nio/ch/Net.c >> >> - Add AIX-specific includes and constant definitions. >> - On AIX "socket extensions for multicast source filters" support >> depends on the OS version. Check for this and throw appropriate >> exceptions >> if it is requested but not supported. This is needed to pass >> JCK-api/java_nio/channels/DatagramChannel/ >> DatagramChannel.html#Multicast >> >> src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c >> >> - On AIX strerror() is not thread-safe so we have to use >> strerror_r()instead. >> - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to >> NULL >> for the directory stream end. Otherwise, 'errno' will contain the >> error >> code. >> - Handle some AIX corner cases for the results of the statvfs64() >> call. >> - On AIX getgrgid_r() returns ESRCH if group does not exist. >> >> src/solaris/native/sun/security/pkcs11/j2secmod_md.c >> >> - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. >> >> test/java/lang/ProcessBuilder/Basic.java >> test/java/lang/ProcessBuilder/DestroyTest.java >> >> - Port this test to AIX and make it more robust (i.e. recognize the >> "C" >> locale as isEnglish(), ignore VM-warnings in the output, make sure the >> "grandchild" processes created by the test don't run too long (60s vs. >> 6666s) because in the case of test problems these processes will >> pollute >> the process space, make sure the test fails with an error and doesn't >> hang >> indefinitley in the case of a problem). >> >> *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this >> intended? >> >> Well, _AIX is defined in some system headers while AIX is defined by the >> build system. This is already used inconsistently (i.e. __linux__ vs. >> LINUX) >> and in general I try to be consistent with the style of the file where I >> the changes are. That said, I changes most of the occurences of AIX to >> _AIX. >> >> >> *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are >> they supposed to be there? >> >> We currently don't support OS/400 (later renamed into i5/OS and currently >> called IBM i) in our OpenJDK port but we do support it in our internel, >> SAP >> JVM build. We stripped out all the extra OS/400 functionality from the >> port >> but in some places where there is common functionality needd by both, AIX >> and OS/400 the OS/400 support may still be visible in the OpenJDK port. I >> don't think this is a real problem and it helps us to keep our internel >> sources in sync with the OpenJDK port. That said, I think I've removed all >> the references to OS/400 now. >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131125/bd221e42/attachment-0001.html From valerie.peng at oracle.com Mon Nov 25 14:49:50 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Mon, 25 Nov 2013 22:49:50 +0000 Subject: hg: jdk8/tl/jdk: 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() Message-ID: <20131125225013.32D1362839@hg.openjdk.java.net> Changeset: 8d5a9245b9ca Author: valeriep Date: 2013-11-25 11:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d5a9245b9ca 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() Summary: Add key length checks to P11Signature class Reviewed-by: mullan ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/Token.java + test/sun/security/pkcs11/Signature/TestDSAKeyLength.java From philip.race at oracle.com Mon Nov 25 15:24:15 2013 From: philip.race at oracle.com (Phil Race) Date: Mon, 25 Nov 2013 15:24:15 -0800 Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5293DC1F.4060205@oracle.com> Hi, I see you've already received a ton of good feedback on this v2. I have just a few things to add. I don't know what symlinks might exist on AIX but it seems odd to me that you have :- 138 static char *fullAixFontPath[] = { 139 "/usr/lpp/X11/lib/X11/fonts/Type1", .. but the paths in the new file aix.fontconfig.properties look like this :- /usr/lib/X11/fonts/Type1/cour.pfa Also for the build to pick up a file called *src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties *it seems like you should have added a section to handle this path to jdk/makefiles/gendata/GenDataFontConfig.gmk That seems to be where the new build handles such files. Are you seeing the .bfc and .src files created ? At runtime it'll get picked up so so long as System.getProperty("os.name") returns "aix" (all lower-case) so I think that's OK. Its the build time part I'd expect to see but don't. -phil. On 11/20/2013 10:26 AM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files > to build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). > The biggest change compared to the first review round is the new > "aix/" subdirectory which I've now created under "jdk/src" and which > contains AIX-only code. > > The webrev is against our > http://hg.openjdk.java.net/ppc-aix-port/stage repository which has > been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I > need the approval of reviewers from the lib, net, svc, 2d, awt and sec > groups. So please don't hesitate to jump at it - there are enough > changes for everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for > collecting them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > * Added these two files for AIX relevant utility code. > * Currently these files only contain an implementation of |dladdr| > which is not available on AIX. > * In the first review round the existing |dladdr| users in the code > either called the version from the HotSpot on AIX > (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private > copy of the whole implementation > (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not > necessary any more. > > The new file layout required some small changes to the makefiles to > make them aware of the new directory locations: > > > makefiles/CompileDemos.gmk > > * Add an extra argument to |SetupJVMTIDemo| which can be used to > pass additional source locations. > * Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > * On AIX add the sources of the AIX porting utilities to the build. > They are required by > |src/solaris/native/sun/awt/awt_LoadLibrary.c| and > |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is not > available on AIX. > > > makefiles/lib/NioLibraries.gmk > > * Make the AIX-build aware of the new NIO source locations under > |src/aix/native/sun/nio/|. > > > makefiles/lib/NetworkingLibraries.gmk > > * Make the AIX-build aware of the new |aix_close.c| source location > under |src/aix/native/java/net/|. > > > src/share/bin/jli_util.h > > * Define |JLI_Lseek| on AIX. > > > src/share/lib/security/java.security-aix > > * Provide default |java.security-aix| for AIX based on the latest > Linux version as suggested by Sean Mullan. > > > src/share/native/common/check_code.c > > * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which > is legal, but the code in |check_code.c| does not handles this > properly. So we wrap the two methods on AIX and return a non-NULL > pointer even if we allocate 0 bytes. > > > src/share/native/sun/awt/medialib/mlib_sys.c > > * |malloc| always returns 8-byte aligned pointers on AIX as well. > > > src/share/native/sun/awt/medialib/mlib_types.h > > * Add AIX to the list of known platforms. > > > src/share/native/sun/font/layout/KernTable.cpp > > * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is > too common and may be defined in other headers as well as on the > command line and |xlc| bails out on macro redefinitions with a > different value. > > > src/share/native/sun/security/ec/impl/ecc_impl.h > > * Define required types and macros on AIX. > > > src/solaris/back/exec_md.c > > * AIX behaves like Linux in this case so check for it in the Linux > branch. > > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| > * Always use |LD_LIBRARY_PATH| macro instead of using the string > "|LD_LIBRARY_PATH|" directly to cope with different library path > names. > * Add |jre/lib//jli| to the standard library search path on > AIX because the AIX linker doesn't support the |-rpath| option. > * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in > this case, AIX behaves like Linux. > * Removed the definition of |JVM_DLL|, |JAVA_DLL| and > |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are > redefined in the corresponding |.c| files anyway. > > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > * Provide basic |fontconfig.properties|for AIX. > > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > * Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > * Detect AIX operating system and return the corresponding channel > and file system providers. > > > src/solaris/classes/sun/nio/ch/Port.java > > * Add a callback function |unregisterImpl(int fd)| for > implementations that need special handling when |fd| is removed > and call it from |unregister(int fd)|. By default the > implementation of |unregisterImpl(int fd)| is empty except for the > derived |AixPollPort| class on AIX. > > > src/solaris/demo/jvmti/hprof/hprof_md.c > > * Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no |dladdr| functionality. > * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). > > > src/solaris/native/common/jdk_util_md.h > > * Add AIX definitions of the |ISNANF| and |ISNAND| macros. > > > src/solaris/native/java/io/io_util_md.c > > * AIX behaves like Linux in this case so check for it in the Linux > branch. > > > src/solaris/native/java/lang/UNIXProcess_md.c > > * AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > > src/solaris/native/java/lang/childproc.c > > * AIX does not understand '/proc/self' - it requires the real > process ID to query the proc file system for the current process. > > > src/solaris/native/java/net/NetworkInterface.c > > * Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > * AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > * Moved the declaration of |siocgifconfRequest| to the beginning a > the function (as recommend by Michael McMahon) to remain C89 > compatible. > > > src/solaris/native/java/net/PlainSocketImpl.c > > * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| > if the socket is closed. The default error message is then confusing. > > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > * As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of |linux_close.c| to > |src/aix/native/java/net/aix_close.c| because we also need the > file and socket wrappers on AIX. > * Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > * Also, on AIX we don't have |__attribute((constructor))| so we need > to initialize manually (from |JNI_OnLoad()| in > |src/share/native/java/net/net_util.c|. > > > src/solaris/native/java/net/net_util_md.h > > * AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > > src/solaris/native/java/net/net_util_md.c > > * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. > * On AIX we have to ignore failures due to |ENOBUFS| when setting > the |SO_SNDBUF|/|SO_RCVBUF| socket options. > > > src/solaris/native/java/util/TimeZone_md.c > > * Currently on AIX the only way to get the platform time zone is to > read it from the |TZ| environment variable. > > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > * Use the |dladdr| from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/sun/awt/fontpath.c > > * Changed some macros from |if !defined(__linux__)| to |if > defined(__solaris__)| because that's their real meaning. > * Add AIX specific fontpath settings and library search paths for > |libfontconfig.so|. > > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to > avoid name clashes (|MIN| and |MAX| are much too common and thexy > are already defined in some AIX system headers). > > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > * Handle AIX like Solaris. > > > src/solaris/native/sun/nio/ch/Net.c > > * Add AIX-specific includes and constant definitions. > * On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate > exceptions if it is requested but not supported. This is needed to > pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > * On AIX |strerror()| is not thread-safe so we have to use > |strerror_r()| instead. > * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain > the error code. > * Handle some AIX corner cases for the results of the |statvfs64()| > call. > * On AIX |getgrgid_r()| returns ESRCH if group does not exist. > > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. > > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > * Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as |isEnglish()|, ignore VM-warnings in the output, > make sure the "grandchild" processes created by the test don't run > too long (60s vs. 6666s) because in the case of test problems > these processes will pollute the process space, make sure the test > fails with an error and doesn't hang indefinitley in the case of a > problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, |_AIX| is defined in some system headers while |AIX| is defined > by the build system. This is already used inconsistently (i.e. > |__linux__| vs. |LINUX|) and in general I try to be consistent with > the style of the file where I the changes are. That said, I changes > most of the occurences of |AIX| to |_AIX|. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, > are they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and > currently called IBM i) in our OpenJDK port but we do support it in > our internel, SAP JVM build. We stripped out all the extra OS/400 > functionality from the port but in some places where there is common > functionality needd by both, AIX and OS/400 the OS/400 support may > still be visible in the OpenJDK port. I don't think this is a real > problem and it helps us to keep our internel sources in sync with the > OpenJDK port. That said, I think I've removed all the references to > OS/400 now. > > From mandy.chung at oracle.com Mon Nov 25 16:37:59 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 25 Nov 2013 16:37:59 -0800 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <5292C6E3.4050101@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> <5292C6E3.4050101@oracle.com> Message-ID: <5293ED67.9010406@oracle.com> Hi Eric, On 11/24/2013 7:41 PM, Eric Wang wrote: > Hi Mandy & All, > > Sorry for late! > The webrev below is just finished based on the comments from peers, > please help to review. > http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ > > Thanks for the patch that looks okay. Some comments: L34-40: can you explain why you want to run all 7 settings? I would expect one for each collector. L61: I think the static checker variable is meant to be a local variable (and looks like "pools" and "managers" don't need to be static variable). Mandy > Thanks, > Eric > On 2013/11/15 10:55, Mandy Chung wrote: >> Hi Eric, >> >> On 11/14/2013 6:16 PM, Eric Wang wrote: >>> Hi Everyone, >>> >>> I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. >>> >>> It is a test bug as the test doesn't guarantee memory allocated from >>> the Old Gen, if the used memory is zero and doesn't cross the >>> threshold, no notification is sent, so both the main thread and >>> Checker thread are blocked to wait for the GC notification. >>> >>> so the suggested fix is similar as the fix ResetPeakMemoryUsage.java >>> to create >>> big object to make sure the old gen usage crosses the threshold and >>> run test with different GC vmoptions. >> >> What are you looking for specifically? I have provided the above >> information. I need to see the webrev to provide further feedback. >> >> Mandy > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131125/3d63d309/attachment.html From huizhe.wang at oracle.com Mon Nov 25 16:58:34 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 26 Nov 2013 00:58:34 +0000 Subject: hg: jdk8/tl/jdk: 8027973: javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java hangs (win) Message-ID: <20131126005849.E0B5E62846@hg.openjdk.java.net> Changeset: 0bf3a58a1783 Author: joehw Date: 2013-11-25 16:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0bf3a58a1783 8027973: javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java hangs (win) Reviewed-by: alanb, dfuchs, joehw Contributed-by: patrick.zhang at oracle.com + test/javax/xml/jaxp/transform/8004476/SecureProcessingTest.xml + test/javax/xml/jaxp/transform/8004476/TestBase.java + test/javax/xml/jaxp/transform/8004476/XPathExFuncTest.java + test/javax/xml/jaxp/transform/8004476/XSLTExFuncTest.java + test/javax/xml/jaxp/transform/8004476/tokenize.xml + test/javax/xml/jaxp/transform/8004476/tokenize.xsl - test/javax/xml/jaxp/transform/jdk8004476/SecureProcessingTest.xml - test/javax/xml/jaxp/transform/jdk8004476/TestBase.java - test/javax/xml/jaxp/transform/jdk8004476/XPathExFuncTest.java - test/javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java - test/javax/xml/jaxp/transform/jdk8004476/tokenize.xml - test/javax/xml/jaxp/transform/jdk8004476/tokenize.xsl From jonathan.gibbons at oracle.com Mon Nov 25 17:45:23 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 26 Nov 2013 01:45:23 +0000 Subject: hg: jdk8/tl/langtools: 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Message-ID: <20131126014526.64AEE62847@hg.openjdk.java.net> Changeset: a78f51d6bd5e Author: jjg Date: 2013-11-25 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! test/tools/doclint/CustomTagTest.java ! test/tools/doclint/CustomTagTest.out ! test/tools/doclint/CustomTagTestWithOption.out From yiming.wang at oracle.com Mon Nov 25 20:53:57 2013 From: yiming.wang at oracle.com (Eric Wang) Date: Tue, 26 Nov 2013 12:53:57 +0800 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <5293ED67.9010406@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> <5292C6E3.4050101@oracle.com> <5293ED67.9010406@oracle.com> Message-ID: <52942965.40102@oracle.com> Hi Mandy, 1. for L34-40, executing tests with 7 settings is trying to cover more cases (normal cases and special cases), especially last 3 settings, as found that the test hung if using vm option "-XX:+ExplicitGCInvokesConcurrent" with one of 3 options -XX:+UseG1GC, -XX:+UseConcMarkSweepGC or -Xconcgc 2. for L61, that is right, the test has been updated. please review. http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ Thanks, Eric On 2013/11/26 8:37, Mandy Chung wrote: > Hi Eric, > > On 11/24/2013 7:41 PM, Eric Wang wrote: >> Hi Mandy & All, >> >> Sorry for late! >> The webrev below is just finished based on the comments from peers, >> please help to review. >> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >> >> > > Thanks for the patch that looks okay. Some comments: > > L34-40: can you explain why you want to run all 7 settings? I would > expect one for each collector. > L61: I think the static checker variable is meant to be a local > variable (and looks like "pools" and "managers" don't need to be > static variable). > > Mandy > >> Thanks, >> Eric >> On 2013/11/15 10:55, Mandy Chung wrote: >>> Hi Eric, >>> >>> On 11/14/2013 6:16 PM, Eric Wang wrote: >>>> Hi Everyone, >>>> >>>> I'm working on the bug >>>> https://bugs.openjdk.java.net/browse/JDK-7067973. >>>> >>>> It is a test bug as the test doesn't guarantee memory allocated >>>> from the Old Gen, if the used memory is zero and doesn't cross the >>>> threshold, no notification is sent, so both the main thread and >>>> Checker thread are blocked to wait for the GC notification. >>>> >>>> so the suggested fix is similar as the fix >>>> ResetPeakMemoryUsage.java >>>> to create >>>> big object to make sure the old gen usage crosses the threshold and >>>> run test with different GC vmoptions. >>> >>> What are you looking for specifically? I have provided the above >>> information. I need to see the webrev to provide further feedback. >>> >>> Mandy >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131126/8d47f7e6/attachment.html From yuka.kamiya at oracle.com Mon Nov 25 21:51:08 2013 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Tue, 26 Nov 2013 05:51:08 +0000 Subject: hg: jdk8/tl/jdk: 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Message-ID: <20131126055121.962F06284F@hg.openjdk.java.net> Changeset: 4d9078b1f25b Author: peytoia Date: 2013-11-26 14:49 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d9078b1f25b 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Reviewed-by: okutsu - test/java/text/Bidi/Bug6665028.java From volker.simonis at gmail.com Tue Nov 26 01:57:17 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 26 Nov 2013 10:57:17 +0100 Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <5293DC1F.4060205@oracle.com> References: <5293DC1F.4060205@oracle.com> Message-ID: Hi Phil, thanks a lot for the review. Please find my comments inline: On Tue, Nov 26, 2013 at 12:24 AM, Phil Race wrote: > Hi, > I see you've already received a ton of good feedback on this v2. > > I have just a few things to add. > I don't know what symlinks might exist on AIX but it seems odd to > me that you have :- > > 138 static char *fullAixFontPath[] = { > 139 "/usr/lpp/X11/lib/X11/fonts/Type1", > .. > > but the paths in the new file aix.fontconfig.properties look like this :- > > /usr/lib/X11/fonts/Type1/cour.pfa > > You're absolutely right. I've updated 'aix.fontconfig.properties' to contain the same absolute path like 'fontpath.c'. I've also added a comment which describes to which AIX-package the fonts belong to and to which locations they are sym-linked to. Also for the build to pick up a file called > *src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > *it seems like you should have added a section to handle this path to > jdk/makefiles/gendata/GenDataFontConfig.gmk > > That seems to be where the new build handles such files. > > Are you seeing the .bfc and .src files created ? > > You're right. But that was already added by the general AIX-build change "8024900: PPC64: Enable new build on AIX (jdk part)" ( http://hg.openjdk.java.net/ppc-aix-port/stage/jdk/diff/3ac08cd5e2e8/makefiles/GendataFontConfig.gmk ). And yes, the .bfc and .src files are created and copied to the right places. > At runtime it'll get picked up so so long as System.getProperty("os.name") > returns "aix" (all lower-case) so I think that's OK. Its the build time > part > I'd expect to see but don't. > > I did split the AIX change into several changes and the build changes have been reviewed separately: 8024265: PPC64: Enable new build on AIX ( https://bugs.openjdk.java.net/browse/JDK-8024265) 8024900: PPC64: Enable new build on AIX (jdk part) ( https://bugs.openjdk.java.net/browse/JDK-8024900) This change only contains the additional make changes which became necessary after I started to move AIX-specific files into their own jdk/src/aix/ directory. Everything else is already in place. I'll prepare and test a finaly webrev with all the changes from this review round today. Thanks a lot, Volker > -phil. > > > On 11/20/2013 10:26 AM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on AIX > net/browse/JDK-8024854>". The previous reviews can be found at the end >> of this mail in the references section. >> >> >> I've tried to address all the comments and suggestions from the first >> round and to further streamline the patch (it perfectly builds on >> Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The >> biggest change compared to the first review round is the new "aix/" >> subdirectory which I've now created under "jdk/src" and which contains >> AIX-only code. >> >> The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ < >> http://cr.openjdk.java.net/%7Esimonis/webrevs/8024854.v2/> >> >> >> Below (and in the webrev) you can find some comments which explain the >> changes to each file. In order to be able to push this big change, I need >> the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. >> So please don't hesitate to jump at it - there are enough changes for >> everybody:) >> >> Thank you and best regards, >> Volker >> >> *References:* >> >> >> The following reviews have been posted so far (thanks Iris for collecting >> them :) >> >> - Alan Bateman (lib): Initial comments (16 Sep [2]) >> - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) >> - Michael McMahon (net): Initial comments (20 Sept [4]) >> - Steffan Larsen (svc): APPROVED (20 Sept [5]) >> - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments >> (15 Oct [7]) >> - Sean Mullan (sec): Initial comments (26 Sept [8]) >> >> [2]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001045.html >> [3]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001078.html >> [4]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001079.html >> [5]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001077.html >> [6]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001069.html >> [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/ >> 003826.html >> [8]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001081.html >> >> >> *Detailed change description:* >> >> >> The new "jdk/src/aix" subdirectory contains the following new and >> AIX-specific files for now: >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java >> src/aix/classes/sun/nio/ch/AixPollPort.java >> src/aix/classes/sun/nio/fs/AixFileStore.java >> src/aix/classes/sun/nio/fs/AixFileSystem.java >> src/aix/classes/sun/nio/fs/AixFileSystemProvider.java >> src/aix/classes/sun/nio/fs/AixNativeDispatcher.java >> src/aix/classes/sun/tools/attach/AixAttachProvider.java >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java >> src/aix/native/java/net/aix_close.c >> src/aix/native/sun/nio/ch/AixPollPort.c >> src/aix/native/sun/nio/fs/AixNativeDispatcher.c >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> * Added these two files for AIX relevant utility code. >> * Currently these files only contain an implementation of |dladdr| >> >> which is not available on AIX. >> * In the first review round the existing |dladdr| users in the code >> >> either called the version from the HotSpot on AIX >> (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private >> >> copy of the whole implementation >> (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not >> >> necessary any more. >> >> The new file layout required some small changes to the makefiles to make >> them aware of the new directory locations: >> >> >> makefiles/CompileDemos.gmk >> >> * Add an extra argument to |SetupJVMTIDemo| which can be used to >> pass additional source locations. >> * Currently this is only used on AIX for the AIX porting utilities >> >> which are required by hprof. >> >> >> makefiles/lib/Awt2dLibraries.gmk >> makefiles/lib/ServiceabilityLibraries.gmk >> >> * On AIX add the sources of the AIX porting utilities to the build. >> >> They are required by >> |src/solaris/native/sun/awt/awt_LoadLibrary.c| and >> |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is not >> available on AIX. >> >> >> makefiles/lib/NioLibraries.gmk >> >> * Make the AIX-build aware of the new NIO source locations under >> |src/aix/native/sun/nio/|. >> >> >> makefiles/lib/NetworkingLibraries.gmk >> >> * Make the AIX-build aware of the new |aix_close.c| source location >> under |src/aix/native/java/net/|. >> >> >> src/share/bin/jli_util.h >> >> * Define |JLI_Lseek| on AIX. >> >> >> src/share/lib/security/java.security-aix >> >> * Provide default |java.security-aix| for AIX based on the latest >> >> Linux version as suggested by Sean Mullan. >> >> >> src/share/native/common/check_code.c >> >> * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which >> >> is legal, but the code in |check_code.c| does not handles this >> properly. So we wrap the two methods on AIX and return a non-NULL >> pointer even if we allocate 0 bytes. >> >> >> src/share/native/sun/awt/medialib/mlib_sys.c >> >> * |malloc| always returns 8-byte aligned pointers on AIX as well. >> >> >> src/share/native/sun/awt/medialib/mlib_types.h >> >> * Add AIX to the list of known platforms. >> >> >> src/share/native/sun/font/layout/KernTable.cpp >> >> * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is >> >> too common and may be defined in other headers as well as on the >> command line and |xlc| bails out on macro redefinitions with a >> different value. >> >> >> src/share/native/sun/security/ec/impl/ecc_impl.h >> >> * Define required types and macros on AIX. >> >> >> src/solaris/back/exec_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/bin/java_md_solinux.c, >> src/solaris/bin/java_md_solinux.h >> >> * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| >> * Always use |LD_LIBRARY_PATH| macro instead of using the string >> >> "|LD_LIBRARY_PATH|" directly to cope with different library path >> names. >> * Add |jre/lib//jli| to the standard library search path on >> >> AIX because the AIX linker doesn't support the |-rpath| option. >> * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in >> >> this case, AIX behaves like Linux. >> * Removed the definition of |JVM_DLL|, |JAVA_DLL| and >> >> |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are >> redefined in the corresponding |.c| files anyway. >> >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> >> * Provide basic |fontconfig.properties|for AIX. >> >> >> src/solaris/classes/java/lang/UNIXProcess.java.aix, >> src/aix/classes/sun/tools/attach/AixAttachProvider.java, >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java, >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> >> * Provide AIX specific Java versions, mostly based on the >> >> corresponding Linux versions. >> >> >> src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProv >> ider.java >> src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java >> >> * Detect AIX operating system and return the corresponding channel >> >> and file system providers. >> >> >> src/solaris/classes/sun/nio/ch/Port.java >> >> * Add a callback function |unregisterImpl(int fd)| for >> >> implementations that need special handling when |fd| is removed >> and call it from |unregister(int fd)|. By default the >> >> implementation of |unregisterImpl(int fd)| is empty except for the >> derived |AixPollPort| class on AIX. >> >> >> src/solaris/demo/jvmti/hprof/hprof_md.c >> >> * Add AIX support. AIX mostly behaves like Linux, with the one >> >> exception that it has no |dladdr| functionality. >> * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/com/sun/management/UnixOperatingSystem_md.c >> >> * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). >> >> >> src/solaris/native/common/jdk_util_md.h >> >> * Add AIX definitions of the |ISNANF| and |ISNAND| macros. >> >> >> src/solaris/native/java/io/io_util_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/native/java/lang/UNIXProcess_md.c >> >> * AIX behaves mostly like Solraris in this case so adjust the ifdefs >> accordingly. >> >> >> src/solaris/native/java/lang/childproc.c >> >> * AIX does not understand '/proc/self' - it requires the real >> >> process ID to query the proc file system for the current process. >> >> >> src/solaris/native/java/net/NetworkInterface.c >> >> * Add AIX support into the Linux branch because AIX mostly behaves >> like AIX for IPv4. >> * AIX needs a special function to enumerate IPv6 interfaces and to >> query the MAC address. >> * Moved the declaration of |siocgifconfRequest| to the beginning a >> >> the function (as recommend by Michael McMahon) to remain C89 >> compatible. >> >> >> src/solaris/native/java/net/PlainSocketImpl.c >> >> * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| >> >> if the socket is closed. The default error message is then confusing. >> >> >> src/aix/native/java/net/aix_close.c, >> src/share/native/java/net/net_util.c >> >> * As recommended by Michael McMahon and Alan Bateman I've move an >> >> adapted version of |linux_close.c| to >> |src/aix/native/java/net/aix_close.c| because we also need the >> file and socket wrappers on AIX. >> * Compared to the Linux version, we've added the initialization of >> >> some previously uninitialized data structures. >> * Also, on AIX we don't have |__attribute((constructor))| so we need >> >> to initialize manually (from |JNI_OnLoad()| in >> |src/share/native/java/net/net_util.c|. >> >> >> src/solaris/native/java/net/net_util_md.h >> >> * AIX needs the same workaround for I/O cancellation like Linux and >> MacOSX. >> >> >> src/solaris/native/java/net/net_util_md.c >> >> * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. >> * On AIX we have to ignore failures due to |ENOBUFS| when setting >> the |SO_SNDBUF|/|SO_RCVBUF| socket options. >> >> >> src/solaris/native/java/util/TimeZone_md.c >> >> * Currently on AIX the only way to get the platform time zone is to >> >> read it from the |TZ| environment variable. >> >> >> src/solaris/native/sun/awt/awt_LoadLibrary.c >> >> * Use the |dladdr| from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/sun/awt/fontpath.c >> >> * Changed some macros from |if !defined(__linux__)| to |if >> >> defined(__solaris__)| because that's their real meaning. >> * Add AIX specific fontpath settings and library search paths for >> |libfontconfig.so|. >> >> >> src/solaris/native/sun/java2d/x11/X11SurfaceData.c >> >> * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to >> avoid name clashes (|MIN| and |MAX| are much too common and thexy >> >> are already defined in some AIX system headers). >> >> >> src/solaris/native/sun/java2d/x11/XRBackendNative.c >> >> * Handle AIX like Solaris. >> >> >> src/solaris/native/sun/nio/ch/Net.c >> >> * Add AIX-specific includes and constant definitions. >> * On AIX "socket extensions for multicast source filters" support >> >> depends on the OS version. Check for this and throw appropriate >> exceptions if it is requested but not supported. This is needed to >> pass >> JCK-api/java_nio/channels/DatagramChannel/ >> DatagramChannel.html#Multicast >> >> >> src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c >> >> * On AIX |strerror()| is not thread-safe so we have to use >> |strerror_r()| instead. >> * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to >> >> NULL for the directory stream end. Otherwise, 'errno' will contain >> the error code. >> * Handle some AIX corner cases for the results of the |statvfs64()| >> call. >> * On AIX |getgrgid_r()| returns ESRCH if group does not exist. >> >> >> src/solaris/native/sun/security/pkcs11/j2secmod_md.c >> >> * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. >> >> >> test/java/lang/ProcessBuilder/Basic.java >> test/java/lang/ProcessBuilder/DestroyTest.java >> >> * Port this test to AIX and make it more robust (i.e. recognize the >> "C" locale as |isEnglish()|, ignore VM-warnings in the output, >> >> make sure the "grandchild" processes created by the test don't run >> too long (60s vs. 6666s) because in the case of test problems >> these processes will pollute the process space, make sure the test >> fails with an error and doesn't hang indefinitley in the case of a >> problem). >> >> *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this >> intended? >> >> Well, |_AIX| is defined in some system headers while |AIX| is defined by >> the build system. This is already used inconsistently (i.e. |__linux__| vs. >> |LINUX|) and in general I try to be consistent with the style of the file >> where I the changes are. That said, I changes most of the occurences of >> |AIX| to |_AIX|. >> >> *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are >> they supposed to be there? >> >> >> We currently don't support OS/400 (later renamed into i5/OS and currently >> called IBM i) in our OpenJDK port but we do support it in our internel, SAP >> JVM build. We stripped out all the extra OS/400 functionality from the port >> but in some places where there is common functionality needd by both, AIX >> and OS/400 the OS/400 support may still be visible in the OpenJDK port. I >> don't think this is a real problem and it helps us to keep our internel >> sources in sync with the OpenJDK port. That said, I think I've removed all >> the references to OS/400 now. >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131126/3276cd8c/attachment-0001.html From joel.franck at oracle.com Tue Nov 26 04:41:42 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 26 Nov 2013 12:41:42 +0000 Subject: hg: jdk8/tl/langtools: 8028428: strictfp allowed as annotation element modifier Message-ID: <20131126124146.5D77562860@hg.openjdk.java.net> Changeset: 3ea55d523981 Author: jfranck Date: 2013-11-26 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ea55d523981 8028428: strictfp allowed as annotation element modifier Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java + test/tools/javac/annotations/AnnotationTypeElementModifiers.java + test/tools/javac/annotations/AnnotationTypeElementModifiers.out From jan.lahoda at oracle.com Tue Nov 26 06:40:55 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Tue, 26 Nov 2013 14:40:55 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20131126144102.1944F62864@hg.openjdk.java.net> Changeset: 8acb838c9b79 Author: jlahoda Date: 2013-11-26 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8acb838c9b79 8026374: javac accepts void as a method parameter Summary: Changing Check.validate to reject void types. Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/declaration/method/MethodVoidParameter.java + test/tools/javac/declaration/method/MethodVoidParameter.out Changeset: 756ae3791c45 Author: jlahoda Date: 2013-11-26 15:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/756ae3791c45 8027789: Access method for Outer.super.m() references indirect superclass Summary: Internally convert the qualified super access to an equivalent of an unqualified super access inside the access method. Reviewed-by: vromero, jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/expression/_super/NonDirectSuper/Base.java + test/tools/javac/expression/_super/NonDirectSuper/NonDirectSuper.java + test/tools/javac/expression/_super/NonDirectSuper/Target11.java From rednaxelafx at gmail.com Tue Nov 26 07:56:20 2013 From: rednaxelafx at gmail.com (Krystal Mok) Date: Tue, 26 Nov 2013 23:56:20 +0800 Subject: RR(XS): JDK-7050685 jsdbproc64.sh has a typo in the package name In-Reply-To: <5293A93F.6010007@oracle.com> References: <52939142.3020202@oracle.com> <5293A93F.6010007@oracle.com> Message-ID: Hi all, I thought this was familiar...I reported the bug back in June 2011 to serviceability-dev, and Dan opened 7050685 for it. http://mail.openjdk.java.net/pipermail/serviceability-dev/2011-May/004056.html Nice to see the fix finally goes in. Thank you. - Kris On Tue, Nov 26, 2013 at 3:47 AM, serguei.spitsyn at oracle.com < serguei.spitsyn at oracle.com> wrote: > It looks good. > > > Thanks, > Serguei > > On 11/25/13 10:04 AM, Dmitry Samersoff wrote: > >> Hi Everyone, >> >> Please review a day-1 typeo in jsdbproc64.sh >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-7050685/webrev.01/ >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131126/b6de5b55/attachment.html From volker.simonis at gmail.com Tue Nov 26 08:23:37 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 26 Nov 2013 17:23:37 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second review round: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ I've successfully build (and run some smoke tests) with these changes on Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, MacOSX and AIX (5.3, 7.1). So if nobody vetoes these changes are ready for push into our staging repository. @Vladimir: can I push them or do you want to run them trough JPRT? Thank you and best regards, Volker PS: compared to the last webrev ( http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/), I've slightly changed the following files: makefiles/lib/Awt2dLibraries.gmk makefiles/lib/NetworkingLibraries.gmk makefiles/Setup.gmk src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties src/aix/classes/sun/nio/ch/AixPollPort.java src/aix/classes/sun/nio/fs/AixFileSystem.java src/aix/native/java/net/aix_close.c src/aix/porting/porting_aix.c src/share/native/java/net/net_util.c src/share/native/java/net/net_util.h src/share/native/sun/awt/medialib/mlib_sys.c src/solaris/bin/java_md_solinux.c src/solaris/classes/sun/nio/ch/Port.java src/solaris/native/java/net/net_util_md.c src/solaris/native/sun/java2d/x11/XRBackendNative.c src/solaris/native/sun/management/OperatingSystemImpl.c src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c src/windows/native/java/net/net_util_md.c Most of the changes are cosmetic, except the ones in: src/share/native/java/net/net_util.c src/share/native/java/net/net_util.h src/solaris/native/java/net/net_util_md.c src/windows/native/java/net/net_util_md.c where I renamed 'initLocalAddrTable()' to 'platformInit()'. For AIX, this method will now call 'aix_close_init()' as suggested by Alan. The changes to src/solaris/native/com/sun/ management/UnixOperatingSystem_md.c are now in src/solaris/native/sun/management/OperatingSystemImpl.c because that file was moved by an upstream change. On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I need > the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. > So please don't hesitate to jump at it - there are enough changes for > everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for collecting > them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > - Added these two files for AIX relevant utility code. > - Currently these files only contain an implementation of dladdr which > is not available on AIX. > - In the first review round the existing dladdr users in the code > either called the version from the HotSpot on AIX ( > src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of > the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). > This is now not necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > makefiles/CompileDemos.gmk > > - Add an extra argument to SetupJVMTIDemo which can be used to pass > additional source locations. > - Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > - On AIX add the sources of the AIX porting utilities to the build. > They are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and > src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not > available on AIX. > > makefiles/lib/NioLibraries.gmk > > - Make the AIX-build aware of the new NIO source locations under > src/aix/native/sun/nio/. > > makefiles/lib/NetworkingLibraries.gmk > > - Make the AIX-build aware of the new aix_close.c source location > under src/aix/native/java/net/. > > src/share/bin/jli_util.h > > - Define JLI_Lseek on AIX. > > src/share/lib/security/java.security-aix > > - Provide default java.security-aix for AIX based on the latest Linux > version as suggested by Sean Mullan. > > src/share/native/common/check_code.c > > - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in check_code.c does not handles this properly. So > we wrap the two methods on AIX and return a non-NULL pointer even if we > allocate 0 bytes. > > src/share/native/sun/awt/medialib/mlib_sys.c > > - malloc always returns 8-byte aligned pointers on AIX as well. > > src/share/native/sun/awt/medialib/mlib_types.h > > - Add AIX to the list of known platforms. > > src/share/native/sun/font/layout/KernTable.cpp > > - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too > common and may be defined in other headers as well as on the command line > and xlc bails out on macro redefinitions with a different value. > > src/share/native/sun/security/ec/impl/ecc_impl.h > > - Define required types and macros on AIX. > > src/solaris/back/exec_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > - On AIX LD_LIBRARY_PATH is called LIBPATH > - Always use LD_LIBRARY_PATH macro instead of using the string " > LD_LIBRARY_PATH" directly to cope with different library path names. > - Add jre/lib//jli to the standard library search path on AIX > because the AIX linker doesn't support the -rpath option. > - Replace #ifdef __linux__ by #ifndef __solaris__ because in this > case, AIX behaves like Linux. > - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from > java_md_solinux.h because the macros are redefined in the > corresponding .c files anyway. > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > - Provide basic fontconfig.propertiesfor AIX. > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > - Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > - Detect AIX operating system and return the corresponding channel and > file system providers. > > src/solaris/classes/sun/nio/ch/Port.java > > - Add a callback function unregisterImpl(int fd) for implementations > that need special handling when fd is removed and call it from unregister(int > fd). By default the implementation of unregisterImpl(int fd) is empty > except for the derived AixPollPort class on AIX. > > src/solaris/demo/jvmti/hprof/hprof_md.c > > - Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no dladdr functionality. > - Use the dladdr implementation from porting_aix.{c,h} on AIX. > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). > > src/solaris/native/common/jdk_util_md.h > > - Add AIX definitions of the ISNANF and ISNAND macros. > > src/solaris/native/java/io/io_util_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/native/java/lang/UNIXProcess_md.c > > - AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > src/solaris/native/java/lang/childproc.c > > - AIX does not understand '/proc/self' - it requires the real process > ID to query the proc file system for the current process. > > src/solaris/native/java/net/NetworkInterface.c > > - Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > - AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > - Moved the declaration of siocgifconfRequest to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > src/solaris/native/java/net/PlainSocketImpl.c > > - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the > socket is closed. The default error message is then confusing. > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > - As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of linux_close.c to src/aix/native/java/net/aix_close.cbecause we also need the file and socket wrappers on AIX. > - Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > - Also, on AIX we don't have __attribute((constructor)) so we need to > initialize manually (from JNI_OnLoad() in > src/share/native/java/net/net_util.c. > > src/solaris/native/java/net/net_util_md.h > > - AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > src/solaris/native/java/net/net_util_md.c > > - SO_REUSEADDR is called SO_REUSEPORT on AIX. > - On AIX we have to ignore failures due to ENOBUFS when setting the > SO_SNDBUF/SO_RCVBUF socket options. > > src/solaris/native/java/util/TimeZone_md.c > > - Currently on AIX the only way to get the platform time zone is to > read it from the TZ environment variable. > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > - Use the dladdr from porting_aix.{c,h} on AIX. > > src/solaris/native/sun/awt/fontpath.c > > - Changed some macros from if !defined(__linux__) to if > defined(__solaris__) because that's their real meaning. > - Add AIX specific fontpath settings and library search paths for > libfontconfig.so. > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name > clashes (MIN and MAX are much too common and thexy are already defined > in some AIX system headers). > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > - Handle AIX like Solaris. > > src/solaris/native/sun/nio/ch/Net.c > > - Add AIX-specific includes and constant definitions. > - On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate exceptions > if it is requested but not supported. This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. > - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain the > error code. > - Handle some AIX corner cases for the results of the statvfs64() call. > - On AIX getgrgid_r() returns ESRCH if group does not exist. > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > - Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as isEnglish(), ignore VM-warnings in the output, make sure > the "grandchild" processes created by the test don't run too long (60s vs. > 6666s) because in the case of test problems these processes will pollute > the process space, make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, _AIX is defined in some system headers while AIX is defined by the > build system. This is already used inconsistently (i.e. __linux__ vs. > LINUX) and in general I try to be consistent with the style of the file > where I the changes are. That said, I changes most of the occurences of > AIX to _AIX. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and currently > called IBM i) in our OpenJDK port but we do support it in our internel, SAP > JVM build. We stripped out all the extra OS/400 functionality from the port > but in some places where there is common functionality needd by both, AIX > and OS/400 the OS/400 support may still be visible in the OpenJDK port. I > don't think this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've removed all > the references to OS/400 now. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131126/07f59421/attachment-0001.html From mattias.tobiasson at oracle.com Tue Nov 26 08:35:33 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Tue, 26 Nov 2013 08:35:33 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <34378054-94f4-453f-9a30-c2bedb3df9dd@default> Hi, Thanks for the review. I have summarized the questions and answers: Q: What is the reason of this intermittent failure? A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. I got the idea for -Xshare:dump from this bug: https://bugs.openjdk.java.net/browse/JDK-6571866 I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". Q: In getCommandLine(), should we also trim cmd to remove last " "? A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. Q: Timeouts in function waitForJvmPid(String key)? A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. I will add a flush() to stdout to make sure we log before we wait. Mattias ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com, serviceability-dev at openjdk.java.net Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Hi I have a couple of high-level questions. On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: > Hi, > The test has been updated after the first review. > The two java files for each test has been merged to a single file. > > > Updated summary of changes: > 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. What is the reason of this intermittent failure? > > 2. Removed all bash scripts. Great! > > 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. > > 4. Added some utility functions to jdk/testlibrary. Here some comments about library code. http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html + try { + output = new OutputAnalyzer(this.process); + } catch (Throwable t) { + String name = Thread.currentThread().getName(); + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); + throw t; + } finally { + String logMsg = ProcessTools.getProcessLog(processBuilder, output); + System.out.println(logMsg); + } You used output in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html 1) Same in as previous in executeProcess method. 2) getCommandLine (...) + /** + * @return The full command line for the ProcessBuilder. + */ + public static String getCommandLine(ProcessBuilder pb) { + StringBuilder cmd = new StringBuilder(); + for (String s : pb.command()) { + cmd.append(s).append(" "); + } + return cmd.toString(); + } Should we also trim cmd to remove last " "? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html public static int waitForJvmPid(String key) throws Throwable { Why it throw Trowable? Could we deal with exceptions in this method and re-throw some more meaningful exception here? Could you force flush for out here: System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); Hope it should be enough. It is scary to investigate such "timeouts". Would it be better to add some internal timeout in testlibrary? Really jtreg doesn't kill all processes and we have alive java processes in such case. For samevm tests timeouts are even worse. There is no good way to kill test in samevm. Should be public static int tryFindJvmPid(String key) throws Throwable { private? Are we going to use it in tests or only waitForJvmPid? Leonid > > 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. > > > Webrev: > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6461635 > > Mattias > > > ----- Original Message ----- > From: mattias.tobiasson at oracle.com > To: mikael.auno at oracle.com > Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com > Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > I agree that merging both files in a single file may be good. > The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. > > But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. > > Mattias > > ----- Original Message ----- > From: mikael.auno at oracle.com > To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > How about defining the class that you want to attach to as a static > inner class to the actual test? That would give you only one file, but > with two classes, each with its own main method and clear correlation > between them. > > Mikael > > On 2013-11-20 15:41, Mattias Tobiasson wrote: >> Hi, >> Each test requires 2 files, the actual test code and a helper file. >> >> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >> >> For example: >> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >> PermissionTest.java: The actual test code that attaches to the Application. >> >> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >> >> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >> >> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >> >> I used these names: >> TestPermission.java: Helper file. >> TestPermissionImpl.java: Actual test code. >> >> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >> >> Mattias >> >> >> ----- Original Message ----- >> From: Alan.Bateman at oracle.com >> To: mattias.tobiasson at oracle.com >> Cc: serviceability-dev at openjdk.java.net >> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> >> Out of curiosity, what is the reason for the rename? I ask because we >> use Basic and similar names in many areas. Also anything in the test >> tree should be a test. >> >> -Alan. >> >> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>> Hi, >>> Could you please review this fix. >>> >>> Summary of changes: >>> >>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>> >>> 2. Ported the following bash scripts to java: >>> BasicTests.sh -> TestBasic.java >>> PermissionTests.sh -> TestPermission.java >>> ProviderTests.sh -> TestProvider.java >>> >>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>> BasicsTest.java -> TestBasicImpl.java >>> PermissionTest.java -> TestPermissionImpl.java >>> ProviderTest.java -> TestProviderImpl.java >>> >>> 4. Added some utility functions to jdk/testlibrary. >>> >>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>> >>> >>> Thanks, >>> Mattias >>> >>> Webrev: >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-6461635 -- Leonid Mesnik JVM SQE From harold.seigel at oracle.com Tue Nov 26 08:49:15 2013 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Tue, 26 Nov 2013 16:49:15 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8026065: InterfaceMethodref for invokespecial must name a direct superinterface Message-ID: <20131126164918.0FAAE6286C@hg.openjdk.java.net> Changeset: 22eaa15b7960 Author: hseigel Date: 2013-11-26 09:52 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/22eaa15b7960 8026065: InterfaceMethodref for invokespecial must name a direct superinterface Summary: Add verification to check that invokespecial of an InterfaceMethodref names a method in a direct superinterface of the current class or interface in accordance with JSR 335, JVMS 4.9.2 Structural Constraints. Reviewed-by: acorn, hseigel, coleenp Contributed-by: lois.foltan at oracle.com ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp From Alan.Bateman at oracle.com Tue Nov 26 09:03:15 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 26 Nov 2013 17:03:15 +0000 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5294D453.5050402@oracle.com> On 26/11/2013 16:23, Volker Simonis wrote: > Hi, > > thanks to everybody for the prompt and helpful reviews. Here comes the > final webrev which incorporates all the corrections and suggestions from > the second review round: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > > I've successfully build (and run some smoke tests) with these changes on > Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, MacOSX and > AIX (5.3, 7.1). > I've skimmed over the last webrev with focus on: NetworkingLibraries.gmk where I see this is now fixed for all platforms. net_util.* and the platform specific net_util_md.* where I see you've added platformInit so it's much cleaner. UnixNativeDispatcher.c where the error translation is now removed (and looks fine). So overall it looks good to me and should be pushed to the staging forest once you hear from others that commented previously. -Alan From iris.clark at oracle.com Tue Nov 26 11:18:19 2013 From: iris.clark at oracle.com (Iris Clark) Date: Tue, 26 Nov 2013 11:18:19 -0800 (PST) Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <5294EDB7.8020408@oracle.com> References: <5294D453.5050402@oracle.com> <5294EDB7.8020408@oracle.com> Message-ID: <20bfb263-7e01-484f-b7b2-94d6516141bd@default> Hi. >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > + src/solaris/classes/java/lang/UNIXProcess.java.aix > 2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights reserved. > 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. Oracle copyright in acceptable location and uses correct format. > + src/aix/porting/porting_aix.h > 2 * Copyright 2012, 2013 SAP AG. All rights reserved. > 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. SAP copyright in acceptable location. > + src/aix/native/sun/tools/attach/AixVirtualMachine.c > 2 * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved. > 3 * Copyright 2013 SAP AG. All rights reserved. > 4 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER Oracle and SAP copyrights in acceptable locations. Oracle format is correct. The licenses (GPL+CP) look fine to me. Thanks, iris -----Original Message----- From: Sergey Bylokhov Sent: Tuesday, November 26, 2013 10:52 AM To: Alan Bateman; Volker Simonis Cc: 2d-dev at openjdk.java.net; serviceability-dev at openjdk.java.net; security-dev; ppc-aix-port-dev at openjdk.java.net; awt-dev at openjdk.java.net; Java Core Libs; net-dev Subject: Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX On 26.11.2013 21:03, Alan Bateman wrote: > On 26/11/2013 16:23, Volker Simonis wrote: >> Hi, >> >> thanks to everybody for the prompt and helpful reviews. Here comes >> the final webrev which incorporates all the corrections and >> suggestions from the second review round: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ >> >> I've successfully build (and run some smoke tests) with these changes >> on Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, >> MacOSX and AIX (5.3, 7.1). >> > I've skimmed over the last webrev with focus on: > > NetworkingLibraries.gmk where I see this is now fixed for all platforms. > > net_util.* and the platform specific net_util_md.* where I see you've > added platformInit so it's much cleaner. I have a question about boolean_t in the [1]. Is it correct to skip it in the new block? http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/src/share/native/sun/security/ec/impl/ecc_impl.h.frames.html Also I have a question about headers in the added files. Looks like different templates are used: + src/solaris/classes/java/lang/UNIXProcess.java.aix 2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights reserved. 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + src/aix/porting/porting_aix.h 2 * Copyright 2012, 2013 SAP AG. All rights reserved. 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + src/aix/native/sun/tools/attach/AixVirtualMachine.c 2 * Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved. 3 * Copyright 2013 SAP AG. All rights reserved. 4 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. etc.. Do we have some rules about that? > > UnixNativeDispatcher.c where the error translation is now removed (and > looks fine). > > So overall it looks good to me and should be pushed to the staging > forest once you hear from others that commented previously. > > -Alan -- Best regards, Sergey. From philip.race at oracle.com Tue Nov 26 12:01:11 2013 From: philip.race at oracle.com (Phil Race) Date: Tue, 26 Nov 2013 12:01:11 -0800 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5294FE07.3060309@oracle.com> Looking only at what you needed to change this time round, all seems fine now. -phil. On 11/26/13 8:23 AM, Volker Simonis wrote: > Hi, > > thanks to everybody for the prompt and helpful reviews. Here comes the > final webrev which incorporates all the corrections and suggestions > from the second review round: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > > > I've successfully build (and run some smoke tests) with these changes > on Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, > MacOSX and AIX (5.3, 7.1). > > So if nobody vetoes these changes are ready for push into our staging > repository. > > @Vladimir: can I push them or do you want to run them trough JPRT? > > Thank you and best regards, > Volker > > PS: compared to the last webrev > (http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > ), I've > slightly changed the following files: > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/NetworkingLibraries.gmk > makefiles/Setup.gmk > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/native/java/net/aix_close.c > src/aix/porting/porting_aix.c > src/share/native/java/net/net_util.c > src/share/native/java/net/net_util.h > src/share/native/sun/awt/medialib/mlib_sys.c > src/solaris/bin/java_md_solinux.c > src/solaris/classes/sun/nio/ch/Port.java > src/solaris/native/java/net/net_util_md.c > src/solaris/native/sun/java2d/x11/XRBackendNative.c > src/solaris/native/sun/management/OperatingSystemImpl.c > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > src/windows/native/java/net/net_util_md.c > > Most of the changes are cosmetic, except the ones in: > > src/share/native/java/net/net_util.c > src/share/native/java/net/net_util.h > src/solaris/native/java/net/net_util_md.c > src/windows/native/java/net/net_util_md.c > > where I renamed 'initLocalAddrTable()' to 'platformInit()'. For AIX, > this method will now call 'aix_close_init()' as suggested by Alan. > > The changes to src/solaris/native/com/sun/ > management/UnixOperatingSystem_md.c are now in > src/solaris/native/sun/management/OperatingSystemImpl.c because that > file was moved by an upstream change. > > > > On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis > > wrote: > > Hi, > > this is the second review round for "8024854: Basic changes and > files to build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the > first round and to further streamline the patch (it perfectly > builds on Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and > Windows/x86_64). The biggest change compared to the first review > round is the new "aix/" subdirectory which I've now created under > "jdk/src" and which contains AIX-only code. > > The webrev is against our > http://hg.openjdk.java.net/ppc-aix-port/stage repository which has > been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > > Below (and in the webrev) you can find some comments which explain > the changes to each file. In order to be able to push this big > change, I need the approval of reviewers from the lib, net, svc, > 2d, awt and sec groups. So please don't hesitate to jump at it - > there are enough changes for everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for > collecting them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional > comments (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > * Added these two files for AIX relevant utility code. > * Currently these files only contain an implementation of > |dladdr| which is not available on AIX. > * In the first review round the existing |dladdr| users in the > code either called the version from the HotSpot on AIX > (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a > private copy of the whole implementation > (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not > necessary any more. > > The new file layout required some small changes to the makefiles > to make them aware of the new directory locations: > > > makefiles/CompileDemos.gmk > > * Add an extra argument to |SetupJVMTIDemo| which can be used to > pass additional source locations. > * Currently this is only used on AIX for the AIX porting > utilities which are required by hprof. > > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > * On AIX add the sources of the AIX porting utilities to the > build. They are required by > |src/solaris/native/sun/awt/awt_LoadLibrary.c| and > |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is > not available on AIX. > > > makefiles/lib/NioLibraries.gmk > > * Make the AIX-build aware of the new NIO source locations under > |src/aix/native/sun/nio/|. > > > makefiles/lib/NetworkingLibraries.gmk > > * Make the AIX-build aware of the new |aix_close.c| source > location under |src/aix/native/java/net/|. > > > src/share/bin/jli_util.h > > * Define |JLI_Lseek| on AIX. > > > src/share/lib/security/java.security-aix > > * Provide default |java.security-aix| for AIX based on the > latest Linux version as suggested by Sean Mullan. > > > src/share/native/common/check_code.c > > * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, > which is legal, but the code in |check_code.c| does not > handles this properly. So we wrap the two methods on AIX and > return a non-NULL pointer even if we allocate 0 bytes. > > > src/share/native/sun/awt/medialib/mlib_sys.c > > * |malloc| always returns 8-byte aligned pointers on AIX as well. > > > src/share/native/sun/awt/medialib/mlib_types.h > > * Add AIX to the list of known platforms. > > > src/share/native/sun/font/layout/KernTable.cpp > > * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| > is too common and may be defined in other headers as well as > on the command line and |xlc| bails out on macro redefinitions > with a different value. > > > src/share/native/sun/security/ec/impl/ecc_impl.h > > * Define required types and macros on AIX. > > > src/solaris/back/exec_md.c > > * AIX behaves like Linux in this case so check for it in the > Linux branch. > > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| > * Always use |LD_LIBRARY_PATH| macro instead of using the string > "|LD_LIBRARY_PATH|" directly to cope with different library > path names. > * Add |jre/lib//jli| to the standard library search path > on AIX because the AIX linker doesn't support the |-rpath| option. > * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in > this case, AIX behaves like Linux. > * Removed the definition of |JVM_DLL|, |JAVA_DLL| and > |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros > are redefined in the corresponding |.c| files anyway. > > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > * Provide basic |fontconfig.properties|for AIX. > > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > * Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > * Detect AIX operating system and return the corresponding > channel and file system providers. > > > src/solaris/classes/sun/nio/ch/Port.java > > * Add a callback function |unregisterImpl(int fd)| for > implementations that need special handling when |fd| is > removed and call it from |unregister(int fd)|. By default the > implementation of |unregisterImpl(int fd)| is empty except for > the derived |AixPollPort| class on AIX. > > > src/solaris/demo/jvmti/hprof/hprof_md.c > > * Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no |dladdr| functionality. > * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). > > > src/solaris/native/common/jdk_util_md.h > > * Add AIX definitions of the |ISNANF| and |ISNAND| macros. > > > src/solaris/native/java/io/io_util_md.c > > * AIX behaves like Linux in this case so check for it in the > Linux branch. > > > src/solaris/native/java/lang/UNIXProcess_md.c > > * AIX behaves mostly like Solraris in this case so adjust the > ifdefs accordingly. > > > src/solaris/native/java/lang/childproc.c > > * AIX does not understand '/proc/self' - it requires the real > process ID to query the proc file system for the current process. > > > src/solaris/native/java/net/NetworkInterface.c > > * Add AIX support into the Linux branch because AIX mostly > behaves like AIX for IPv4. > * AIX needs a special function to enumerate IPv6 interfaces and > to query the MAC address. > * Moved the declaration of |siocgifconfRequest| to the beginning > a the function (as recommend by Michael McMahon) to remain C89 > compatible. > > > src/solaris/native/java/net/PlainSocketImpl.c > > * On AIX (like on Solaris) |setsockopt| will set errno to > |EINVAL| if the socket is closed. The default error message is > then confusing. > > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > * As recommended by Michael McMahon and Alan Bateman I've move > an adapted version of |linux_close.c| to > |src/aix/native/java/net/aix_close.c| because we also need the > file and socket wrappers on AIX. > * Compared to the Linux version, we've added the initialization > of some previously uninitialized data structures. > * Also, on AIX we don't have |__attribute((constructor))| so we > need to initialize manually (from |JNI_OnLoad()| in > |src/share/native/java/net/net_util.c|. > > > src/solaris/native/java/net/net_util_md.h > > * AIX needs the same workaround for I/O cancellation like Linux > and MacOSX. > > > src/solaris/native/java/net/net_util_md.c > > * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. > * On AIX we have to ignore failures due to |ENOBUFS| when > setting the |SO_SNDBUF|/|SO_RCVBUF| socket options. > > > src/solaris/native/java/util/TimeZone_md.c > > * Currently on AIX the only way to get the platform time zone is > to read it from the |TZ| environment variable. > > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > * Use the |dladdr| from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/sun/awt/fontpath.c > > * Changed some macros from |if !defined(__linux__)| to |if > defined(__solaris__)| because that's their real meaning. > * Add AIX specific fontpath settings and library search paths > for |libfontconfig.so|. > > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| > to avoid name clashes (|MIN| and |MAX| are much too common and > thexy are already defined in some AIX system headers). > > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > * Handle AIX like Solaris. > > > src/solaris/native/sun/nio/ch/Net.c > > * Add AIX-specific includes and constant definitions. > * On AIX "socket extensions for multicast source filters" > support depends on the OS version. Check for this and throw > appropriate exceptions if it is requested but not supported. > This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > * On AIX |strerror()| is not thread-safe so we have to use > |strerror_r()| instead. > * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets > 'result' to NULL for the directory stream end. Otherwise, > 'errno' will contain the error code. > * Handle some AIX corner cases for the results of the > |statvfs64()| call. > * On AIX |getgrgid_r()| returns ESRCH if group does not exist. > > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. > > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > * Port this test to AIX and make it more robust (i.e. recognize > the "C" locale as |isEnglish()|, ignore VM-warnings in the > output, make sure the "grandchild" processes created by the > test don't run too long (60s vs. 6666s) because in the case of > test problems these processes will pollute the process space, > make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is > this intended? > > Well, |_AIX| is defined in some system headers while |AIX| is > defined by the build system. This is already used inconsistently > (i.e. |__linux__| vs. |LINUX|) and in general I try to be > consistent with the style of the file where I the changes are. > That said, I changes most of the occurences of |AIX| to |_AIX|. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the > patch, are they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and > currently called IBM i) in our OpenJDK port but we do support it > in our internel, SAP JVM build. We stripped out all the extra > OS/400 functionality from the port but in some places where there > is common functionality needd by both, AIX and OS/400 the OS/400 > support may still be visible in the OpenJDK port. I don't think > this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've > removed all the references to OS/400 now. > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131126/51b1b229/attachment-0001.html From harold.seigel at oracle.com Tue Nov 26 15:11:05 2013 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Tue, 26 Nov 2013 23:11:05 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8028160: [TESTBUG] Exclude failing (runtime) jtreg tests using @ignore Message-ID: <20131126231107.9AE736288C@hg.openjdk.java.net> Changeset: e567d5afd4dd Author: hseigel Date: 2013-11-26 16:03 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e567d5afd4dd 8028160: [TESTBUG] Exclude failing (runtime) jtreg tests using @ignore Summary: Use @ignore to exclude failing tests Reviewed-by: coleenp, ctornqvi, mseledtsov Contributed-by: george.triantafillou at oracle.com ! test/runtime/6626217/Test6626217.sh ! test/runtime/6929067/Test6929067.sh ! test/runtime/CDSCompressedKPtrs/XShareAuto.java ! test/runtime/InitialThreadOverflow/testme.sh ! test/runtime/LoadClass/LoadClassNegative.java ! test/runtime/XCheckJniJsig/XCheckJSig.java ! test/runtime/jsig/Test8017498.sh ! test/runtime/memory/ReadFromNoaccessArea.java From vladimir.kozlov at oracle.com Tue Nov 26 15:13:38 2013 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Tue, 26 Nov 2013 23:13:38 +0000 Subject: hg: jdk8/tl/jdk: 8016839: JSR292: AME instead of IAE when calling a method Message-ID: <20131126231350.CD08F6288D@hg.openjdk.java.net> Changeset: e822676cd3cd Author: jrose Date: 2013-11-26 17:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e822676cd3cd 8016839: JSR292: AME instead of IAE when calling a method Summary: Catch missing-because-illegal case for itable entries and use an exception-throwing method instead of null. Reviewed-by: acorn, jrose, coleenp Contributed-by: david.r.chase at oracle.com ! src/share/classes/sun/misc/Unsafe.java From lana.steuck at oracle.com Tue Nov 26 16:12:00 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Nov 2013 00:12:00 +0000 Subject: hg: jdk8/tl/hotspot: 15 new changesets Message-ID: <20131127001231.9F49462895@hg.openjdk.java.net> Changeset: 854a42db7069 Author: amurillo Date: 2013-11-15 07:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/854a42db7069 8028444: new hotspot build - hs25-b60 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 570aaefce624 Author: morris Date: 2013-11-18 12:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/570aaefce624 8028319: ConflictingDefaultsTest.testReabstract spins when running with -mode invoke and -Xcomp Summary: Change _abstract_method_handler to return AbstractMethodError i2c, c2i and c2iv entries. Reviewed-by: kvn, vlivanov ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 938e1e64e28f Author: anoll Date: 2013-11-14 19:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/938e1e64e28f 8028306: nsk stress tests, CodeCache fills, then safepoint asserts Summary: Move handle_full_code_cache() out of block that forbids safepoints Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/runtime/sweeper.cpp Changeset: fca8f4799229 Author: roland Date: 2013-11-20 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fca8f4799229 8028308: nsk regression, assert(obj->is_oop()) failed: not an oop Summary: rbp not restored when stack overflow is thrown from deopt/uncommon trap blobs Reviewed-by: kvn, iveresov ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp + test/compiler/uncommontrap/TestStackBangRbp.java Changeset: cdf20166ec45 Author: minqi Date: 2013-11-13 16:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cdf20166ec45 8025632: Remove all references to MagicLambdaImpl from Hotspot Summary: MagicLambdaImpl was removed from jdk side, this should be done in vm side too Reviewed-by: coleenp, hseigel, rdurbin ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/reflection.cpp ! test/compiler/jsr292/ConcurrentClassLoadingTest.java Changeset: 3edddbff4865 Author: minqi Date: 2013-11-13 16:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3edddbff4865 Merge Changeset: b03f33670080 Author: sla Date: 2013-11-14 19:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b03f33670080 6606002: jinfo doesn't detect dynamic vm flags changing Reviewed-by: coleenp, jbachorik, sspitsyn ! agent/src/share/classes/sun/jvm/hotspot/tools/JInfo.java Changeset: 5280822ddfcd Author: sla Date: 2013-11-14 20:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5280822ddfcd 6626412: jstack using SA prints some info messages into err stream Reviewed-by: coleenp, farvidsson, jbachorik, dsamersoff, sspitsyn ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java Changeset: 438fe38c63c8 Author: mgronlun Date: 2013-11-15 21:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/438fe38c63c8 Merge ! src/share/vm/runtime/globals.hpp Changeset: d61a1a166f44 Author: coleenp Date: 2013-11-15 17:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d61a1a166f44 8028347: Rewriter::scan_method asserts with array oob in RT_Baseline Summary: Fix reversing rewriting for invokespecial Reviewed-by: jrose, hseigel ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp Changeset: 0b9ea9a72436 Author: sla Date: 2013-11-18 10:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b9ea9a72436 8027630: SIGSEGV in const char*Klass::external_name() Reviewed-by: coleenp, sspitsyn, mgronlun ! src/share/vm/classfile/metadataOnStackMark.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/services/threadService.hpp Changeset: 396564992823 Author: sgabdura Date: 2013-11-18 08:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/396564992823 8028341: PSR:FUNC: SCOPE PARAMETER MISSING FROM THE -XX:+PRINTFLAGSFINAL Reviewed-by: dcubed, sla ! src/share/vm/runtime/globals.cpp Changeset: aa933e6b061d Author: mgronlun Date: 2013-11-22 20:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aa933e6b061d Merge Changeset: abad3b2d905d Author: amurillo Date: 2013-11-22 13:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/abad3b2d905d Merge Changeset: c9f439732b18 Author: amurillo Date: 2013-11-22 13:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9f439732b18 Added tag hs25-b60 for changeset abad3b2d905d ! .hgtags From serguei.spitsyn at oracle.com Tue Nov 26 17:34:19 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 26 Nov 2013 17:34:19 -0800 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers Message-ID: <52954C1B.60908@oracle.com> Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8028126 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ Summary: This is a fix for a possible race condition between the VMOp_GetCurrentLocation reaching a safepoint and target debuggee thread exiting from Java execution. The fix is to recheck the existence of the last Java frame at a safepoint and clean the thread current location if the thread has been already exited from Java. I'm suggesting to fix this in hs25/JDK 8. It is important to fix as it is a P2 bug and the risk of fixing it is low. But need reviewers to share opinions on this. I'll add the 8-critical-request label if reviewers agree with the above. Testing: The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was originally failed. In progress: nsk.jvmti, nsk.jdi, nsk.jdwp Thanks, Serguei From weijun.wang at oracle.com Tue Nov 26 17:57:12 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 27 Nov 2013 01:57:12 +0000 Subject: hg: jdk8/tl/jdk: 8029181: ts.sh generates invalid file after JDK-8027026 Message-ID: <20131127015726.CB73162897@hg.openjdk.java.net> Changeset: 1738dfb0c52a Author: weijun Date: 2013-11-27 09:56 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1738dfb0c52a 8029181: ts.sh generates invalid file after JDK-8027026 Reviewed-by: vinnie, mullan ! test/sun/security/tools/jarsigner/TimestampCheck.java From mandy.chung at oracle.com Tue Nov 26 18:17:09 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 26 Nov 2013 18:17:09 -0800 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <52942965.40102@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> <5292C6E3.4050101@oracle.com> <5293ED67.9010406@oracle.com> <52942965.40102@oracle.com> Message-ID: <52955625.4050907@oracle.com> Hi Eric, I'll defer this to the serviceability team to sponsor it and also get one more review. I don't think you need all 7 @runs. -Xconcgc is equivalent to setting -XX:+UseConcMarkSweepGC. For G1 and CMS, you should use -XX:+ExplicitGCInvokesConcurrent so that System.gc will force a GC in foreground that you can count the GC reliably. The test wants to get notified for each System.gc and if there is any GC caused by allocation failure, the test would fail due to the unexpected GC count. It seems that you may run into this issue setting -Xmx2m. Have you got the test passed in all settings? I'm seeing that the test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent without -Xmx2m. Looks like there is no GC in the old gen - I'm not familiar with G1 if it allocates the big object in the old gen. Jarolsav - can you help Eric diagnose this issue? I recalled you ran into something like that before - maybe Staffan? thanks Mandy On 11/25/2013 8:53 PM, Eric Wang wrote: > Hi Mandy, > > 1. for L34-40, executing tests with 7 settings is trying to cover more > cases (normal cases and special cases), especially last 3 settings, as > found that the test hung if using vm option > "-XX:+ExplicitGCInvokesConcurrent" with one of 3 options -XX:+UseG1GC, > -XX:+UseConcMarkSweepGC or -Xconcgc > > 2. for L61, that is right, the test has been updated. please review. > http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ > > > Thanks, > Eric > On 2013/11/26 8:37, Mandy Chung wrote: >> Hi Eric, >> >> On 11/24/2013 7:41 PM, Eric Wang wrote: >>> Hi Mandy & All, >>> >>> Sorry for late! >>> The webrev below is just finished based on the comments from peers, >>> please help to review. >>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>> >>> >> >> Thanks for the patch that looks okay. Some comments: >> >> L34-40: can you explain why you want to run all 7 settings? I would >> expect one for each collector. >> L61: I think the static checker variable is meant to be a local >> variable (and looks like "pools" and "managers" don't need to be >> static variable). >> >> Mandy >> >>> Thanks, >>> Eric >>> On 2013/11/15 10:55, Mandy Chung wrote: >>>> Hi Eric, >>>> >>>> On 11/14/2013 6:16 PM, Eric Wang wrote: >>>>> Hi Everyone, >>>>> >>>>> I'm working on the bug >>>>> https://bugs.openjdk.java.net/browse/JDK-7067973. >>>>> >>>>> It is a test bug as the test doesn't guarantee memory allocated >>>>> from the Old Gen, if the used memory is zero and doesn't cross the >>>>> threshold, no notification is sent, so both the main thread and >>>>> Checker thread are blocked to wait for the GC notification. >>>>> >>>>> so the suggested fix is similar as the fix >>>>> ResetPeakMemoryUsage.java >>>>> to >>>>> create big object to make sure the old gen usage crosses the >>>>> threshold and run test with different GC vmoptions. >>>> >>>> What are you looking for specifically? I have provided the above >>>> information. I need to see the webrev to provide further feedback. >>>> >>>> Mandy >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131126/e3768ee5/attachment.html From staffan.larsen at oracle.com Wed Nov 27 00:07:44 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 27 Nov 2013 09:07:44 +0100 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <52954C1B.60908@oracle.com> References: <52954C1B.60908@oracle.com> Message-ID: <730E8C30-2C04-4984-978F-C2286765A448@oracle.com> Looks good! The fix looks safe enough to include in jdk8, however this does not look like a recent regression - the bug must have been there for a long time. Let?s try to get it approved for jdk8. Thanks, /Staffan On 27 nov 2013, at 02:34, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > https://bugs.openjdk.java.net/browse/JDK-8028126 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ > > Summary: > This is a fix for a possible race condition between the VMOp_GetCurrentLocation > reaching a safepoint and target debuggee thread exiting from Java execution. > The fix is to recheck the existence of the last Java frame at a safepoint > and clean the thread current location if the thread has been already exited from Java. > > I'm suggesting to fix this in hs25/JDK 8. > It is important to fix as it is a P2 bug and the risk of fixing it is low. > But need reviewers to share opinions on this. > I'll add the 8-critical-request label if reviewers agree with the above. > > > Testing: > The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was originally failed. > In progress: nsk.jvmti, nsk.jdi, nsk.jdwp > > > Thanks, > Serguei From dmitry.samersoff at oracle.com Wed Nov 27 00:08:28 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 27 Nov 2013 12:08:28 +0400 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <52954C1B.60908@oracle.com> References: <52954C1B.60908@oracle.com> Message-ID: <5295A87C.5070000@oracle.com> Serguei, Is it better to just convert assert at ll. 273 into if (vf != NULL) ... ? -Dmitry On 2013-11-27 05:34, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > https://bugs.openjdk.java.net/browse/JDK-8028126 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ > > > Summary: > This is a fix for a possible race condition between the > VMOp_GetCurrentLocation > reaching a safepoint and target debuggee thread exiting from Java > execution. > The fix is to recheck the existence of the last Java frame at a safepoint > and clean the thread current location if the thread has been already > exited from Java. > > I'm suggesting to fix this in hs25/JDK 8. > It is important to fix as it is a P2 bug and the risk of fixing it is > low. > But need reviewers to share opinions on this. > I'll add the 8-critical-request label if reviewers agree with the above. > > > Testing: > The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was > originally failed. > In progress: nsk.jvmti, nsk.jdi, nsk.jdwp > > > Thanks, > Serguei -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the source code. From leonid.mesnik at oracle.com Wed Nov 27 00:18:09 2013 From: leonid.mesnik at oracle.com (Leonid Mesnik) Date: Wed, 27 Nov 2013 12:18:09 +0400 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <34378054-94f4-453f-9a30-c2bedb3df9dd@default> References: <34378054-94f4-453f-9a30-c2bedb3df9dd@default> Message-ID: <5295AAC1.6020407@oracle.com> Hi Generally I am ok with your comments and fix. However you still needed to get official review. The only question is about failure related from retransformation of j.l.BigInteger with CDS. Could it be JDK issue? In this case it would be better to file it as a part of fix. I understand that using of CDS and instrumentation of JDK classes is not related with this test and your fix make it cleaner. However could you please verify that we don't have JDK issue here. see other comments inline On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: > Hi, > Thanks for the review. I have summarized the questions and answers: > > Q: What is the reason of this intermittent failure? > A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. > I got the idea for -Xshare:dump from this bug: > https://bugs.openjdk.java.net/browse/JDK-6571866 > I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. > > Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. > > Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? > A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". Thank you for explanation. > > Q: In getCommandLine(), should we also trim cmd to remove last " "? > A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. Ok > > Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? > A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. > > Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? > A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. Ok > > Q: Timeouts in function waitForJvmPid(String key)? > A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. > I will add a flush() to stdout to make sure we log before we wait. Hope we will update jtreg before get into this issue :) Leonid > Mattias > > ----- Original Message ----- > From: leonid.mesnik at oracle.com > To: mattias.tobiasson at oracle.com, serviceability-dev at openjdk.java.net > Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > Hi > > I have a couple of high-level questions. > > On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: >> Hi, >> The test has been updated after the first review. >> The two java files for each test has been merged to a single file. >> >> >> Updated summary of changes: >> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. > What is the reason of this intermittent failure? >> 2. Removed all bash scripts. > Great! >> 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. >> >> 4. Added some utility functions to jdk/testlibrary. > Here some comments about library code. > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html > > + try { > + output = new OutputAnalyzer(this.process); > + } catch (Throwable t) { > + String name = Thread.currentThread().getName(); > + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); > + throw t; > + } finally { > + String logMsg = ProcessTools.getProcessLog(processBuilder, output); > + System.out.println(logMsg); > + } > > > You used output in finally which is not initialized properly in the case > of Exception. > Could we get another uncaught exception in finally? > > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html > > 1) Same in as previous in executeProcess method. > > 2) getCommandLine (...) > > + /** > + * @return The full command line for the ProcessBuilder. > + */ > + public static String getCommandLine(ProcessBuilder pb) { > + StringBuilder cmd = new StringBuilder(); > + for (String s : pb.command()) { > + cmd.append(s).append(" "); > + } > + return cmd.toString(); > + } > > > Should we also trim cmd to remove last " "? > > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html > > public static int waitForJvmPid(String key) throws Throwable { > > > Why it throw Trowable? Could we deal with exceptions in this method and > re-throw some more meaningful exception here? > Could you force flush for out here: > > System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); > > Hope it should be enough. It is scary to investigate such "timeouts". > Would it be better to add some > internal timeout in testlibrary? Really jtreg doesn't kill all processes > and we have alive java processes in such case. > For samevm tests timeouts are even worse. There is no good way to kill > test in samevm. > > Should be > > public static int tryFindJvmPid(String key) throws Throwable { > > private? Are we going to use it in tests or only waitForJvmPid? > > Leonid >> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >> >> >> Webrev: >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6461635 >> >> Mattias >> >> >> ----- Original Message ----- >> From: mattias.tobiasson at oracle.com >> To: mikael.auno at oracle.com >> Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com >> Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> I agree that merging both files in a single file may be good. >> The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. >> >> But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. >> >> Mattias >> >> ----- Original Message ----- >> From: mikael.auno at oracle.com >> To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com >> Cc: serviceability-dev at openjdk.java.net >> Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> How about defining the class that you want to attach to as a static >> inner class to the actual test? That would give you only one file, but >> with two classes, each with its own main method and clear correlation >> between them. >> >> Mikael >> >> On 2013-11-20 15:41, Mattias Tobiasson wrote: >>> Hi, >>> Each test requires 2 files, the actual test code and a helper file. >>> >>> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >>> >>> For example: >>> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >>> PermissionTest.java: The actual test code that attaches to the Application. >>> >>> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >>> >>> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >>> >>> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >>> >>> I used these names: >>> TestPermission.java: Helper file. >>> TestPermissionImpl.java: Actual test code. >>> >>> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >>> >>> Mattias >>> >>> >>> ----- Original Message ----- >>> From: Alan.Bateman at oracle.com >>> To: mattias.tobiasson at oracle.com >>> Cc: serviceability-dev at openjdk.java.net >>> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> >>> Out of curiosity, what is the reason for the rename? I ask because we >>> use Basic and similar names in many areas. Also anything in the test >>> tree should be a test. >>> >>> -Alan. >>> >>> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>>> Hi, >>>> Could you please review this fix. >>>> >>>> Summary of changes: >>>> >>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>>> >>>> 2. Ported the following bash scripts to java: >>>> BasicTests.sh -> TestBasic.java >>>> PermissionTests.sh -> TestPermission.java >>>> ProviderTests.sh -> TestProvider.java >>>> >>>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>>> BasicsTest.java -> TestBasicImpl.java >>>> PermissionTest.java -> TestPermissionImpl.java >>>> ProviderTest.java -> TestProviderImpl.java >>>> >>>> 4. Added some utility functions to jdk/testlibrary. >>>> >>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>> >>>> >>>> Thanks, >>>> Mattias >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-6461635 > -- Leonid Mesnik JVM SQE From serguei.spitsyn at oracle.com Wed Nov 27 01:04:01 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 27 Nov 2013 01:04:01 -0800 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <730E8C30-2C04-4984-978F-C2286765A448@oracle.com> References: <52954C1B.60908@oracle.com> <730E8C30-2C04-4984-978F-C2286765A448@oracle.com> Message-ID: <5295B581.3080701@oracle.com> Thanks, Staffan! Serguei On 11/27/13 12:07 AM, Staffan Larsen wrote: > Looks good! > > The fix looks safe enough to include in jdk8, however this does not look like a recent regression - the bug must have been there for a long time. Let?s try to get it approved for jdk8. > > Thanks, > /Staffan > > On 27 nov 2013, at 02:34, serguei.spitsyn at oracle.com wrote: > >> Please, review the fix for: >> https://bugs.openjdk.java.net/browse/JDK-8028126 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ >> >> Summary: >> This is a fix for a possible race condition between the VMOp_GetCurrentLocation >> reaching a safepoint and target debuggee thread exiting from Java execution. >> The fix is to recheck the existence of the last Java frame at a safepoint >> and clean the thread current location if the thread has been already exited from Java. >> >> I'm suggesting to fix this in hs25/JDK 8. >> It is important to fix as it is a P2 bug and the risk of fixing it is low. >> But need reviewers to share opinions on this. >> I'll add the 8-critical-request label if reviewers agree with the above. >> >> >> Testing: >> The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was originally failed. >> In progress: nsk.jvmti, nsk.jdi, nsk.jdwp >> >> >> Thanks, >> Serguei From david.holmes at oracle.com Wed Nov 27 01:04:54 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 27 Nov 2013 19:04:54 +1000 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <52954C1B.60908@oracle.com> References: <52954C1B.60908@oracle.com> Message-ID: <5295B5B6.5050203@oracle.com> Hi Serguei, This looks fine to me. Definitely low risk but not sure it is critical enough for 8. Minor nit: _method_id = (jmethodID)NULL; It should never be necessary to cast NULL if assigning to a pointer type. Thanks, David On 27/11/2013 11:34 AM, serguei.spitsyn at oracle.com wrote: > Please, review the fix for: > https://bugs.openjdk.java.net/browse/JDK-8028126 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ > > > Summary: > This is a fix for a possible race condition between the > VMOp_GetCurrentLocation > reaching a safepoint and target debuggee thread exiting from Java > execution. > The fix is to recheck the existence of the last Java frame at a > safepoint > and clean the thread current location if the thread has been already > exited from Java. > > I'm suggesting to fix this in hs25/JDK 8. > It is important to fix as it is a P2 bug and the risk of fixing it is > low. > But need reviewers to share opinions on this. > I'll add the 8-critical-request label if reviewers agree with the above. > > > Testing: > The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was > originally failed. > In progress: nsk.jvmti, nsk.jdi, nsk.jdwp > > > Thanks, > Serguei From serguei.spitsyn at oracle.com Wed Nov 27 01:31:54 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 27 Nov 2013 01:31:54 -0800 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <5295A87C.5070000@oracle.com> References: <52954C1B.60908@oracle.com> <5295A87C.5070000@oracle.com> Message-ID: <5295BC0A.2020108@oracle.com> Dmitry, Thank you for reviewing! On 11/27/13 12:08 AM, Dmitry Samersoff wrote: > Serguei, > > Is it better to just convert > assert at ll. 273 into if (vf != NULL) ... ? Your suggestion does not help as we hit another assert in the call to last_java_vframe(): javaVFrame* vf = _thread->last_java_vframe(&rm); This is the original assert that was reported in the bug: # Internal Error (/tmp/jprt/P1/150447.amurillo/s/src/cpu/sparc/vm/frame_sparc.cpp:718), pid=29913, tid=5 # guarantee(Thread::current() == (Thread*)thread) failed: only current thread can flush its registers The stack is: Stack: [0xffffffff06e00000,0xffffffff06f00000], sp=0xffffffff06efea60, free space=1018k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x12379ac] void VMError::report_and_die()+0x714;; __1cHVMErrorOreport_and_die6M_v_+0x714 V [libjvm.so+0x71daf8] void report_vm_error(const char*,int,const char*,const char*)+0x78;; __1cPreport_vm_error6Fpkci11_v_+0x78 V [libjvm.so+0x7e76bc] void JavaFrameAnchor::make_walkable(JavaThread*)+0x68;; __1cPJavaFrameAnchorNmake_walkable6MpnKJavaThread__v_+0x68 *V [libjvm.so+0x1189358] javaVFrame*JavaThread::last_java_vframe(RegisterMap*)+0x50;; __1cKJavaThreadQlast_java_vframe6MpnLRegisterMap__pnKjavaVFrame__+0x50* V [libjvm.so+0xc6b3c8] void VM_GetCurrentLocation::doit()+0xd0;; __1cVVM_GetCurrentLocationEdoit6M_v_+0xd0 V [libjvm.so+0x1267a50] void VM_Operation::evaluate()+0xf8;; __1cMVM_OperationIevaluate6M_v_+0xf8 V [libjvm.so+0x1263994] void VMThread::evaluate_operation(VM_Operation*)+0x254;; __1cIVMThreadSevaluate_operation6MpnMVM_Operation__v_+0x254 V [libjvm.so+0x1264454] void VMThread::loop()+0x6a4;; __1cIVMThreadEloop6M_v_+0x6a4 V [libjvm.so+0x12633fc] void VMThread::run()+0xe4;; __1cIVMThreadDrun6M_v_+0xe4 V [libjvm.so+0xf183b8] java_start+0x258;; java_start+0x258 Thanks, Serguei > > -Dmitry > > > > On 2013-11-27 05:34, serguei.spitsyn at oracle.com wrote: >> Please, review the fix for: >> https://bugs.openjdk.java.net/browse/JDK-8028126 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ >> >> >> Summary: >> This is a fix for a possible race condition between the >> VMOp_GetCurrentLocation >> reaching a safepoint and target debuggee thread exiting from Java >> execution. >> The fix is to recheck the existence of the last Java frame at a safepoint >> and clean the thread current location if the thread has been already >> exited from Java. >> >> I'm suggesting to fix this in hs25/JDK 8. >> It is important to fix as it is a P2 bug and the risk of fixing it is >> low. >> But need reviewers to share opinions on this. >> I'll add the 8-critical-request label if reviewers agree with the above. >> >> >> Testing: >> The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was >> originally failed. >> In progress: nsk.jvmti, nsk.jdi, nsk.jdwp >> >> >> Thanks, >> Serguei > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131127/18682fd5/attachment-0001.html From markus.gronlund at oracle.com Wed Nov 27 01:47:09 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Wed, 27 Nov 2013 01:47:09 -0800 (PST) Subject: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 Message-ID: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> Greetings, Kindly asking for reviews for the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8028412 Webrev: http://cr.openjdk.java.net/~mgronlun/8028412/webrev01/ Description: AsynchGetCallTrace() uses platform specific code for stack frame traversals. On x86, there currently exist a defensive construct that practically disallows stack traversal over entry_frame code stubs, such as StubRoutine(1) frames: src/cpu/x86/vm/frame_x86.cpp b/src/cpu/x86/vm/frame_x86.cpp: bool frame::safe_for_sender(JavaThread* thread) { . if (!Interpreter::contains(_pc) && _cb->frame_size() <= 0) { //assert(0, "Invalid frame_size"); return false; } . Since entry frames (such as StubRoutine(1)) have a frame size of 0, the code returns prematurely. Fix is to move this frame size check post handling of is_entry_frame(), where the code_stubs are processed. Testing completed: Sun Studio Profiler reproducer testcase SpecJBB2005 Kitchensink Thanks Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131127/0399508b/attachment.html From serguei.spitsyn at oracle.com Wed Nov 27 01:59:17 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 27 Nov 2013 01:59:17 -0800 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <5295B5B6.5050203@oracle.com> References: <52954C1B.60908@oracle.com> <5295B5B6.5050203@oracle.com> Message-ID: <5295C275.1030802@oracle.com> Hi David, Thank you for the review! On 11/27/13 1:04 AM, David Holmes wrote: > Hi Serguei, > > This looks fine to me. Definitely low risk but not sure it is critical > enough for 8. Thanks. The priority is high and it impacts the tests stabilization as some other tests may potentially intermittently fail by the same reason. > > Minor nit: > _method_id = (jmethodID)NULL; > > It should never be necessary to cast NULL if assigning to a pointer type. Let's consider this type cast as a hint for the code reader. :) Also other places in the code use the same pattern, better keep it for consistency. Thanks, Serguei > > Thanks, > David > > On 27/11/2013 11:34 AM, serguei.spitsyn at oracle.com wrote: >> Please, review the fix for: >> https://bugs.openjdk.java.net/browse/JDK-8028126 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ >> >> >> >> Summary: >> This is a fix for a possible race condition between the >> VMOp_GetCurrentLocation >> reaching a safepoint and target debuggee thread exiting from Java >> execution. >> The fix is to recheck the existence of the last Java frame at a >> safepoint >> and clean the thread current location if the thread has been already >> exited from Java. >> >> I'm suggesting to fix this in hs25/JDK 8. >> It is important to fix as it is a P2 bug and the risk of fixing it is >> low. >> But need reviewers to share opinions on this. >> I'll add the 8-critical-request label if reviewers agree with the >> above. >> >> >> Testing: >> The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was >> originally failed. >> In progress: nsk.jvmti, nsk.jdi, nsk.jdwp >> >> >> Thanks, >> Serguei From dmitry.samersoff at oracle.com Wed Nov 27 02:13:53 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 27 Nov 2013 14:13:53 +0400 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <5295BC0A.2020108@oracle.com> References: <52954C1B.60908@oracle.com> <5295A87C.5070000@oracle.com> <5295BC0A.2020108@oracle.com> Message-ID: <5295C5E1.7020208@oracle.com> Serguei, Thank you for the explanation. Looks good for me. -Dmitry On 2013-11-27 13:31, serguei.spitsyn at oracle.com wrote: > Dmitry, > > Thank you for reviewing! > > On 11/27/13 12:08 AM, Dmitry Samersoff wrote: >> Serguei, >> >> Is it better to just convert >> assert at ll. 273 into if (vf != NULL) ... ? > > Your suggestion does not help as we hit another assert in the call to > last_java_vframe(): > javaVFrame* vf = _thread->last_java_vframe(&rm); > > This is the original assert that was reported in the bug: > > # Internal Error > (/tmp/jprt/P1/150447.amurillo/s/src/cpu/sparc/vm/frame_sparc.cpp:718), > pid=29913, tid=5 > # guarantee(Thread::current() == (Thread*)thread) failed: only current > thread can flush its registers > > The stack is: > Stack: [0xffffffff06e00000,0xffffffff06f00000], sp=0xffffffff06efea60, > free space=1018k > Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, > C=native code) > V [libjvm.so+0x12379ac] void VMError::report_and_die()+0x714;; > __1cHVMErrorOreport_and_die6M_v_+0x714 > V [libjvm.so+0x71daf8] void report_vm_error(const char*,int,const > char*,const char*)+0x78;; __1cPreport_vm_error6Fpkci11_v_+0x78 > V [libjvm.so+0x7e76bc] void > JavaFrameAnchor::make_walkable(JavaThread*)+0x68;; > __1cPJavaFrameAnchorNmake_walkable6MpnKJavaThread__v_+0x68 > *V [libjvm.so+0x1189358] > javaVFrame*JavaThread::last_java_vframe(RegisterMap*)+0x50;; > __1cKJavaThreadQlast_java_vframe6MpnLRegisterMap__pnKjavaVFrame__+0x50* > V [libjvm.so+0xc6b3c8] void VM_GetCurrentLocation::doit()+0xd0;; > __1cVVM_GetCurrentLocationEdoit6M_v_+0xd0 > V [libjvm.so+0x1267a50] void VM_Operation::evaluate()+0xf8;; > __1cMVM_OperationIevaluate6M_v_+0xf8 > V [libjvm.so+0x1263994] void > VMThread::evaluate_operation(VM_Operation*)+0x254;; > __1cIVMThreadSevaluate_operation6MpnMVM_Operation__v_+0x254 > V [libjvm.so+0x1264454] void VMThread::loop()+0x6a4;; > __1cIVMThreadEloop6M_v_+0x6a4 > V [libjvm.so+0x12633fc] void VMThread::run()+0xe4;; > __1cIVMThreadDrun6M_v_+0xe4 > V [libjvm.so+0xf183b8] java_start+0x258;; java_start+0x258 > > > Thanks, > Serguei > >> >> -Dmitry >> >> >> >> On 2013-11-27 05:34, serguei.spitsyn at oracle.com wrote: >>> Please, review the fix for: >>> https://bugs.openjdk.java.net/browse/JDK-8028126 >>> >>> Open webrev: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ >>> >>> >>> Summary: >>> This is a fix for a possible race condition between the >>> VMOp_GetCurrentLocation >>> reaching a safepoint and target debuggee thread exiting from Java >>> execution. >>> The fix is to recheck the existence of the last Java frame at a safepoint >>> and clean the thread current location if the thread has been already >>> exited from Java. >>> >>> I'm suggesting to fix this in hs25/JDK 8. >>> It is important to fix as it is a P2 bug and the risk of fixing it is >>> low. >>> But need reviewers to share opinions on this. >>> I'll add the 8-critical-request label if reviewers agree with the above. >>> >>> >>> Testing: >>> The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was >>> originally failed. >>> In progress: nsk.jvmti, nsk.jdi, nsk.jdwp >>> >>> >>> Thanks, >>> Serguei >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From serguei.spitsyn at oracle.com Wed Nov 27 02:16:33 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 27 Nov 2013 02:16:33 -0800 Subject: Review Request (S) 8028126: nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the vm on Solaris-sparc64 fastdebug builds: only current thread can flush its registers In-Reply-To: <5295C5E1.7020208@oracle.com> References: <52954C1B.60908@oracle.com> <5295A87C.5070000@oracle.com> <5295BC0A.2020108@oracle.com> <5295C5E1.7020208@oracle.com> Message-ID: <5295C681.3000406@oracle.com> Thanks, Dmitry! Serguei On 11/27/13 2:13 AM, Dmitry Samersoff wrote: > Serguei, > > Thank you for the explanation. Looks good for me. > > -Dmitry > > On 2013-11-27 13:31, serguei.spitsyn at oracle.com wrote: >> Dmitry, >> >> Thank you for reviewing! >> >> On 11/27/13 12:08 AM, Dmitry Samersoff wrote: >>> Serguei, >>> >>> Is it better to just convert >>> assert at ll. 273 into if (vf != NULL) ... ? >> Your suggestion does not help as we hit another assert in the call to >> last_java_vframe(): >> javaVFrame* vf = _thread->last_java_vframe(&rm); >> >> This is the original assert that was reported in the bug: >> >> # Internal Error >> (/tmp/jprt/P1/150447.amurillo/s/src/cpu/sparc/vm/frame_sparc.cpp:718), >> pid=29913, tid=5 >> # guarantee(Thread::current() == (Thread*)thread) failed: only current >> thread can flush its registers >> >> The stack is: >> Stack: [0xffffffff06e00000,0xffffffff06f00000], sp=0xffffffff06efea60, >> free space=1018k >> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, >> C=native code) >> V [libjvm.so+0x12379ac] void VMError::report_and_die()+0x714;; >> __1cHVMErrorOreport_and_die6M_v_+0x714 >> V [libjvm.so+0x71daf8] void report_vm_error(const char*,int,const >> char*,const char*)+0x78;; __1cPreport_vm_error6Fpkci11_v_+0x78 >> V [libjvm.so+0x7e76bc] void >> JavaFrameAnchor::make_walkable(JavaThread*)+0x68;; >> __1cPJavaFrameAnchorNmake_walkable6MpnKJavaThread__v_+0x68 >> *V [libjvm.so+0x1189358] >> javaVFrame*JavaThread::last_java_vframe(RegisterMap*)+0x50;; >> __1cKJavaThreadQlast_java_vframe6MpnLRegisterMap__pnKjavaVFrame__+0x50* >> V [libjvm.so+0xc6b3c8] void VM_GetCurrentLocation::doit()+0xd0;; >> __1cVVM_GetCurrentLocationEdoit6M_v_+0xd0 >> V [libjvm.so+0x1267a50] void VM_Operation::evaluate()+0xf8;; >> __1cMVM_OperationIevaluate6M_v_+0xf8 >> V [libjvm.so+0x1263994] void >> VMThread::evaluate_operation(VM_Operation*)+0x254;; >> __1cIVMThreadSevaluate_operation6MpnMVM_Operation__v_+0x254 >> V [libjvm.so+0x1264454] void VMThread::loop()+0x6a4;; >> __1cIVMThreadEloop6M_v_+0x6a4 >> V [libjvm.so+0x12633fc] void VMThread::run()+0xe4;; >> __1cIVMThreadDrun6M_v_+0xe4 >> V [libjvm.so+0xf183b8] java_start+0x258;; java_start+0x258 >> >> >> Thanks, >> Serguei >> >>> -Dmitry >>> >>> >>> >>> On 2013-11-27 05:34, serguei.spitsyn at oracle.com wrote: >>>> Please, review the fix for: >>>> https://bugs.openjdk.java.net/browse/JDK-8028126 >>>> >>>> Open webrev: >>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8028126-JVMTI-HS101.1/ >>>> >>>> >>>> Summary: >>>> This is a fix for a possible race condition between the >>>> VMOp_GetCurrentLocation >>>> reaching a safepoint and target debuggee thread exiting from Java >>>> execution. >>>> The fix is to recheck the existence of the last Java frame at a safepoint >>>> and clean the thread current location if the thread has been already >>>> exited from Java. >>>> >>>> I'm suggesting to fix this in hs25/JDK 8. >>>> It is important to fix as it is a P2 bug and the risk of fixing it is >>>> low. >>>> But need reviewers to share opinions on this. >>>> I'll add the 8-critical-request label if reviewers agree with the above. >>>> >>>> >>>> Testing: >>>> The test nsk/jvmti/scenarios/hotswap/HS101/hs101t006 that was >>>> originally failed. >>>> In progress: nsk.jvmti, nsk.jdi, nsk.jdwp >>>> >>>> >>>> Thanks, >>>> Serguei > From serguei.spitsyn at oracle.com Wed Nov 27 02:30:32 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 27 Nov 2013 02:30:32 -0800 Subject: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 In-Reply-To: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> References: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> Message-ID: <5295C9C8.5080107@oracle.com> Hi Markus, The fix looks Ok. It'd be helpful if Oleg and the Solaris Studio guys could confirm this fix works fine for them. I've added Oleg and Nik to the CC-list. They might request a link to the Solaris or Linux binaries. Thanks, Serguei On 11/27/13 1:47 AM, Markus Gronlund wrote: > > Greetings, > > Kindly asking for reviews for the following change: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028412 > > Webrev: http://cr.openjdk.java.net/~mgronlun/8028412/webrev01/ > > > Description: > > AsynchGetCallTrace() uses platform specific code for stack frame > traversals. > > On x86, there currently exist a defensive construct that practically > disallows stack traversal over entry_frame code stubs, such as > StubRoutine(1) frames: > > src/cpu/x86/vm/frame_x86.cpp b/src/cpu/x86/vm/frame_x86.cpp: > > bool frame::safe_for_sender(JavaThread* thread) { > > ... > > if (!Interpreter::contains(_pc) && _cb->frame_size() <= 0) { > //assert(0, "Invalid frame_size"); > > return false; > } > > ... > > Since entry frames (such as StubRoutine(1)) have a frame size of 0, > the code returns prematurely. > > Fix is to move this frame size check post handling of > is_entry_frame(), where the code_stubs are processed. > > Testing completed: > > Sun Studio Profiler reproducer testcase > > SpecJBB2005 > > Kitchensink > > Thanks > Markus > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131127/4cda0aa6/attachment-0001.html From markus.gronlund at oracle.com Wed Nov 27 02:32:25 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Wed, 27 Nov 2013 02:32:25 -0800 (PST) Subject: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 In-Reply-To: <5295C9C8.5080107@oracle.com> References: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> <5295C9C8.5080107@oracle.com> Message-ID: <25d24144-d3a9-4f5a-8a11-bbd5e4ed708c@default> Hi Sergei, I have already worked with Nik on this issue and got his confirmation on the fix. Thanks Markus From: Serguei Spitsyn Sent: den 27 november 2013 11:31 To: Markus Gronlund; hotspot-compiler-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net; serviceability-dev Cc: Oleg Mazurov; Nikolay Molchanov Subject: Re: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 Hi Markus, The fix looks Ok. It'd be helpful if Oleg and the Solaris Studio guys could confirm this fix works fine for them. I've added Oleg and Nik to the CC-list. They might request a link to the Solaris or Linux binaries. Thanks, Serguei On 11/27/13 1:47 AM, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8028412 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Emgronlun/8028412/webrev01/"http://cr.openjdk.java.net/~mgronlun/8028412/webrev01/ Description: AsynchGetCallTrace() uses platform specific code for stack frame traversals. On x86, there currently exist a defensive construct that practically disallows stack traversal over entry_frame code stubs, such as StubRoutine(1) frames: src/cpu/x86/vm/frame_x86.cpp b/src/cpu/x86/vm/frame_x86.cpp: bool frame::safe_for_sender(JavaThread* thread) { . if (!Interpreter::contains(_pc) && _cb->frame_size() <= 0) { //assert(0, "Invalid frame_size"); return false; } . Since entry frames (such as StubRoutine(1)) have a frame size of 0, the code returns prematurely. Fix is to move this frame size check post handling of is_entry_frame(), where the code_stubs are processed. Testing completed: Sun Studio Profiler reproducer testcase SpecJBB2005 Kitchensink Thanks Markus -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131127/0280cdff/attachment.html From serguei.spitsyn at oracle.com Wed Nov 27 02:34:14 2013 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 27 Nov 2013 02:34:14 -0800 Subject: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 In-Reply-To: <25d24144-d3a9-4f5a-8a11-bbd5e4ed708c@default> References: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> <5295C9C8.5080107@oracle.com> <25d24144-d3a9-4f5a-8a11-bbd5e4ed708c@default> Message-ID: <5295CAA6.5080208@oracle.com> On 11/27/13 2:32 AM, Markus Gronlund wrote: > > Hi Sergei, > > I have already worked with Nik on this issue and got his confirmation > on the fix. > Cool! Thanks, Serguei > Thanks > > Markus > > *From:*Serguei Spitsyn > *Sent:* den 27 november 2013 11:31 > *To:* Markus Gronlund; hotspot-compiler-dev at openjdk.java.net; > hotspot-runtime-dev at openjdk.java.net; serviceability-dev > *Cc:* Oleg Mazurov; Nikolay Molchanov > *Subject:* Re: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 > in JDK7u40 > > Hi Markus, > > The fix looks Ok. > > It'd be helpful if Oleg and the Solaris Studio guys could confirm this > fix works fine for them. > I've added Oleg and Nik to the CC-list. > They might request a link to the Solaris or Linux binaries. > > Thanks, > Serguei > > > On 11/27/13 1:47 AM, Markus Gronlund wrote: > > Greetings, > > Kindly asking for reviews for the following change: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028412 > > Webrev: http://cr.openjdk.java.net/~mgronlun/8028412/webrev01/ > > > Description: > > AsynchGetCallTrace() uses platform specific code for stack frame > traversals. > > On x86, there currently exist a defensive construct that > practically disallows stack traversal over entry_frame code stubs, > such as StubRoutine(1) frames: > > src/cpu/x86/vm/frame_x86.cpp b/src/cpu/x86/vm/frame_x86.cpp: > > bool frame::safe_for_sender(JavaThread* thread) { > > ... > > if (!Interpreter::contains(_pc) && _cb->frame_size() <= 0) { > //assert(0, "Invalid frame_size"); > > return false; > } > > ... > > Since entry frames (such as StubRoutine(1)) have a frame size of > 0, the code returns prematurely. > > Fix is to move this frame size check post handling of > is_entry_frame(), where the code_stubs are processed. > > Testing completed: > > Sun Studio Profiler reproducer testcase > > SpecJBB2005 > > Kitchensink > > Thanks > Markus > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131127/6c6c986f/attachment.html From mattias.tobiasson at oracle.com Wed Nov 27 02:46:53 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Wed, 27 Nov 2013 02:46:53 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <9ef40962-06a0-4bbf-90ed-ffda95b9aa98@default> Hi, I now have a reproducer for this test that fails every time. I just need to verify that it really is a test bug and not a product bug. This is a summary of the test: 1. It loads a javaagent jar that implements ClassFileTransformer. 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. When the reproducer is run with flag "-Xshare:off" it passes every time. When run with "-Xshare:auto" it fails every time. When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. public class TestRedefine implements ClassFileTransformer { public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { try { inst.addTransformer(new TestRedefine()); ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); if (!isTransformCalled) { throw new Exception("transform() NOT called for " + targetName); } } catch (Throwable t) { t.printStackTrace(); throw t; } } public byte[] transform(ClassLoader loader, String className, Class classBeingRedefined, ProtectionDomain protectionDomain, byte[] classfileBuffer) { System.out.println("transform called: " + className); if (className.equals("java/math/BigInteger")) { isTransformCalled = true; } return null; } public static void main(String args[]) throws Exception { String pid = getProcessId(); try { VirtualMachine vm = VirtualMachine.attach(pid); vm.loadAgent("TestRedefine.jar"); } catch (Exception e) { e.printStackTrace(); throw e; } } ... more code ... } ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Hi Generally I am ok with your comments and fix. However you still needed to get official review. The only question is about failure related from retransformation of j.l.BigInteger with CDS. Could it be JDK issue? In this case it would be better to file it as a part of fix. I understand that using of CDS and instrumentation of JDK classes is not related with this test and your fix make it cleaner. However could you please verify that we don't have JDK issue here. see other comments inline On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: > Hi, > Thanks for the review. I have summarized the questions and answers: > > Q: What is the reason of this intermittent failure? > A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. > I got the idea for -Xshare:dump from this bug: > https://bugs.openjdk.java.net/browse/JDK-6571866 > I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. > > Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. > > Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? > A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". Thank you for explanation. > > Q: In getCommandLine(), should we also trim cmd to remove last " "? > A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. Ok > > Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? > A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. > > Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? > A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. Ok > > Q: Timeouts in function waitForJvmPid(String key)? > A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. > I will add a flush() to stdout to make sure we log before we wait. Hope we will update jtreg before get into this issue :) Leonid > Mattias > > ----- Original Message ----- > From: leonid.mesnik at oracle.com > To: mattias.tobiasson at oracle.com, serviceability-dev at openjdk.java.net > Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > Hi > > I have a couple of high-level questions. > > On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: >> Hi, >> The test has been updated after the first review. >> The two java files for each test has been merged to a single file. >> >> >> Updated summary of changes: >> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. > What is the reason of this intermittent failure? >> 2. Removed all bash scripts. > Great! >> 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. >> >> 4. Added some utility functions to jdk/testlibrary. > Here some comments about library code. > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html > > + try { > + output = new OutputAnalyzer(this.process); > + } catch (Throwable t) { > + String name = Thread.currentThread().getName(); > + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); > + throw t; > + } finally { > + String logMsg = ProcessTools.getProcessLog(processBuilder, output); > + System.out.println(logMsg); > + } > > > You used output in finally which is not initialized properly in the case > of Exception. > Could we get another uncaught exception in finally? > > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html > > 1) Same in as previous in executeProcess method. > > 2) getCommandLine (...) > > + /** > + * @return The full command line for the ProcessBuilder. > + */ > + public static String getCommandLine(ProcessBuilder pb) { > + StringBuilder cmd = new StringBuilder(); > + for (String s : pb.command()) { > + cmd.append(s).append(" "); > + } > + return cmd.toString(); > + } > > > Should we also trim cmd to remove last " "? > > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html > > public static int waitForJvmPid(String key) throws Throwable { > > > Why it throw Trowable? Could we deal with exceptions in this method and > re-throw some more meaningful exception here? > Could you force flush for out here: > > System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); > > Hope it should be enough. It is scary to investigate such "timeouts". > Would it be better to add some > internal timeout in testlibrary? Really jtreg doesn't kill all processes > and we have alive java processes in such case. > For samevm tests timeouts are even worse. There is no good way to kill > test in samevm. > > Should be > > public static int tryFindJvmPid(String key) throws Throwable { > > private? Are we going to use it in tests or only waitForJvmPid? > > Leonid >> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >> >> >> Webrev: >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-6461635 >> >> Mattias >> >> >> ----- Original Message ----- >> From: mattias.tobiasson at oracle.com >> To: mikael.auno at oracle.com >> Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com >> Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> I agree that merging both files in a single file may be good. >> The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. >> >> But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. >> >> Mattias >> >> ----- Original Message ----- >> From: mikael.auno at oracle.com >> To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com >> Cc: serviceability-dev at openjdk.java.net >> Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> How about defining the class that you want to attach to as a static >> inner class to the actual test? That would give you only one file, but >> with two classes, each with its own main method and clear correlation >> between them. >> >> Mikael >> >> On 2013-11-20 15:41, Mattias Tobiasson wrote: >>> Hi, >>> Each test requires 2 files, the actual test code and a helper file. >>> >>> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >>> >>> For example: >>> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >>> PermissionTest.java: The actual test code that attaches to the Application. >>> >>> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >>> >>> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >>> >>> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >>> >>> I used these names: >>> TestPermission.java: Helper file. >>> TestPermissionImpl.java: Actual test code. >>> >>> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >>> >>> Mattias >>> >>> >>> ----- Original Message ----- >>> From: Alan.Bateman at oracle.com >>> To: mattias.tobiasson at oracle.com >>> Cc: serviceability-dev at openjdk.java.net >>> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> >>> Out of curiosity, what is the reason for the rename? I ask because we >>> use Basic and similar names in many areas. Also anything in the test >>> tree should be a test. >>> >>> -Alan. >>> >>> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>>> Hi, >>>> Could you please review this fix. >>>> >>>> Summary of changes: >>>> >>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>>> >>>> 2. Ported the following bash scripts to java: >>>> BasicTests.sh -> TestBasic.java >>>> PermissionTests.sh -> TestPermission.java >>>> ProviderTests.sh -> TestProvider.java >>>> >>>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>>> BasicsTest.java -> TestBasicImpl.java >>>> PermissionTest.java -> TestPermissionImpl.java >>>> ProviderTest.java -> TestProviderImpl.java >>>> >>>> 4. Added some utility functions to jdk/testlibrary. >>>> >>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>> >>>> >>>> Thanks, >>>> Mattias >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-6461635 > -- Leonid Mesnik JVM SQE From david.holmes at oracle.com Wed Nov 27 03:21:47 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 27 Nov 2013 21:21:47 +1000 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <9ef40962-06a0-4bbf-90ed-ffda95b9aa98@default> References: <9ef40962-06a0-4bbf-90ed-ffda95b9aa98@default> Message-ID: <5295D5CB.80309@oracle.com> On 27/11/2013 8:46 PM, Mattias Tobiasson wrote: > Hi, I now have a reproducer for this test that fails every time. > I just need to verify that it really is a test bug and not a product bug. > > This is a summary of the test: > 1. It loads a javaagent jar that implements ClassFileTransformer. > 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. > > I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. -Xshare:auto will default to off for server compiler, but on for client > When the reproducer is run with flag "-Xshare:off" it passes every time. > When run with "-Xshare:auto" it fails every time. > When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. > > My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. If the whole point of the test is to transform a file from the shared archive then changing to a class not in the archive will defeat that. So you need to verify what the intent of the test is. David > > > The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. > > public class TestRedefine implements ClassFileTransformer { > > public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { > try { > inst.addTransformer(new TestRedefine()); > ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); > if (!isTransformCalled) { > throw new Exception("transform() NOT called for " + targetName); > } > } catch (Throwable t) { > t.printStackTrace(); > throw t; > } > } > > public byte[] transform(ClassLoader loader, > String className, > Class classBeingRedefined, > ProtectionDomain protectionDomain, > byte[] classfileBuffer) { > System.out.println("transform called: " + className); > if (className.equals("java/math/BigInteger")) { > isTransformCalled = true; > } > return null; > } > > public static void main(String args[]) throws Exception { > String pid = getProcessId(); > try { > VirtualMachine vm = VirtualMachine.attach(pid); > vm.loadAgent("TestRedefine.jar"); > } catch (Exception e) { > e.printStackTrace(); > throw e; > } > } > > ... more code ... > } > > > > > > ----- Original Message ----- > From: leonid.mesnik at oracle.com > To: mattias.tobiasson at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > Hi > > Generally I am ok with your comments and fix. However you still needed > to get official review. > > The only question is about failure related from retransformation of > j.l.BigInteger with CDS. > Could it be JDK issue? In this case it would be better to file it as a > part of fix. > I understand that using of CDS and instrumentation of JDK classes is not > related with this test > and your fix make it cleaner. However could you please verify that we > don't have JDK issue here. > > see other comments inline > > On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: >> Hi, >> Thanks for the review. I have summarized the questions and answers: >> >> Q: What is the reason of this intermittent failure? >> A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. >> I got the idea for -Xshare:dump from this bug: >> https://bugs.openjdk.java.net/browse/JDK-6571866 >> I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. >> >> Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. > >> >> Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? >> A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". > Thank you for explanation. >> >> Q: In getCommandLine(), should we also trim cmd to remove last " "? >> A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. > Ok >> >> Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? >> A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. > >> >> Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? >> A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. > Ok >> >> Q: Timeouts in function waitForJvmPid(String key)? >> A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. >> I will add a flush() to stdout to make sure we log before we wait. > Hope we will update jtreg before get into this issue :) > > Leonid >> Mattias >> >> ----- Original Message ----- >> From: leonid.mesnik at oracle.com >> To: mattias.tobiasson at oracle.com, serviceability-dev at openjdk.java.net >> Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> Hi >> >> I have a couple of high-level questions. >> >> On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: >>> Hi, >>> The test has been updated after the first review. >>> The two java files for each test has been merged to a single file. >>> >>> >>> Updated summary of changes: >>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >> What is the reason of this intermittent failure? >>> 2. Removed all bash scripts. >> Great! >>> 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. >>> >>> 4. Added some utility functions to jdk/testlibrary. >> Here some comments about library code. >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html >> >> + try { >> + output = new OutputAnalyzer(this.process); >> + } catch (Throwable t) { >> + String name = Thread.currentThread().getName(); >> + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); >> + throw t; >> + } finally { >> + String logMsg = ProcessTools.getProcessLog(processBuilder, output); >> + System.out.println(logMsg); >> + } >> >> >> You used output in finally which is not initialized properly in the case >> of Exception. >> Could we get another uncaught exception in finally? >> >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html >> >> 1) Same in as previous in executeProcess method. >> >> 2) getCommandLine (...) >> >> + /** >> + * @return The full command line for the ProcessBuilder. >> + */ >> + public static String getCommandLine(ProcessBuilder pb) { >> + StringBuilder cmd = new StringBuilder(); >> + for (String s : pb.command()) { >> + cmd.append(s).append(" "); >> + } >> + return cmd.toString(); >> + } >> >> >> Should we also trim cmd to remove last " "? >> >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html >> >> public static int waitForJvmPid(String key) throws Throwable { >> >> >> Why it throw Trowable? Could we deal with exceptions in this method and >> re-throw some more meaningful exception here? >> Could you force flush for out here: >> >> System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); >> >> Hope it should be enough. It is scary to investigate such "timeouts". >> Would it be better to add some >> internal timeout in testlibrary? Really jtreg doesn't kill all processes >> and we have alive java processes in such case. >> For samevm tests timeouts are even worse. There is no good way to kill >> test in samevm. >> >> Should be >> >> public static int tryFindJvmPid(String key) throws Throwable { >> >> private? Are we going to use it in tests or only waitForJvmPid? >> >> Leonid >>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>> >>> >>> Webrev: >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-6461635 >>> >>> Mattias >>> >>> >>> ----- Original Message ----- >>> From: mattias.tobiasson at oracle.com >>> To: mikael.auno at oracle.com >>> Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com >>> Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> I agree that merging both files in a single file may be good. >>> The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. >>> >>> But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. >>> >>> Mattias >>> >>> ----- Original Message ----- >>> From: mikael.auno at oracle.com >>> To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com >>> Cc: serviceability-dev at openjdk.java.net >>> Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> How about defining the class that you want to attach to as a static >>> inner class to the actual test? That would give you only one file, but >>> with two classes, each with its own main method and clear correlation >>> between them. >>> >>> Mikael >>> >>> On 2013-11-20 15:41, Mattias Tobiasson wrote: >>>> Hi, >>>> Each test requires 2 files, the actual test code and a helper file. >>>> >>>> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >>>> >>>> For example: >>>> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >>>> PermissionTest.java: The actual test code that attaches to the Application. >>>> >>>> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >>>> >>>> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >>>> >>>> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >>>> >>>> I used these names: >>>> TestPermission.java: Helper file. >>>> TestPermissionImpl.java: Actual test code. >>>> >>>> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >>>> >>>> Mattias >>>> >>>> >>>> ----- Original Message ----- >>>> From: Alan.Bateman at oracle.com >>>> To: mattias.tobiasson at oracle.com >>>> Cc: serviceability-dev at openjdk.java.net >>>> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>> >>>> >>>> Out of curiosity, what is the reason for the rename? I ask because we >>>> use Basic and similar names in many areas. Also anything in the test >>>> tree should be a test. >>>> >>>> -Alan. >>>> >>>> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>>>> Hi, >>>>> Could you please review this fix. >>>>> >>>>> Summary of changes: >>>>> >>>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>>>> >>>>> 2. Ported the following bash scripts to java: >>>>> BasicTests.sh -> TestBasic.java >>>>> PermissionTests.sh -> TestPermission.java >>>>> ProviderTests.sh -> TestProvider.java >>>>> >>>>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>>>> BasicsTest.java -> TestBasicImpl.java >>>>> PermissionTest.java -> TestPermissionImpl.java >>>>> ProviderTest.java -> TestProviderImpl.java >>>>> >>>>> 4. Added some utility functions to jdk/testlibrary. >>>>> >>>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>>> >>>>> >>>>> Thanks, >>>>> Mattias >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>>>> >>>>> Bug: >>>>> https://bugs.openjdk.java.net/browse/JDK-6461635 >> > > From staffan.larsen at oracle.com Wed Nov 27 03:43:38 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 27 Nov 2013 12:43:38 +0100 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <5295D5CB.80309@oracle.com> References: <9ef40962-06a0-4bbf-90ed-ffda95b9aa98@default> <5295D5CB.80309@oracle.com> Message-ID: On 27 nov 2013, at 12:21, David Holmes wrote: > On 27/11/2013 8:46 PM, Mattias Tobiasson wrote: >> Hi, I now have a reproducer for this test that fails every time. >> I just need to verify that it really is a test bug and not a product bug. >> >> This is a summary of the test: >> 1. It loads a javaagent jar that implements ClassFileTransformer. >> 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. >> >> I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. > > -Xshare:auto will default to off for server compiler, but on for client > >> When the reproducer is run with flag "-Xshare:off" it passes every time. >> When run with "-Xshare:auto" it fails every time. >> When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. >> >> My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. > > If the whole point of the test is to transform a file from the shared archive then changing to a class not in the archive will defeat that. So you need to verify what the intent of the test is. There is nothing in the test that expects class data sharing to be tested. The test is a basic verification of the attach mechanism. As far as I can tell, It is expected that ClassFileTransformer.transform() is not called for classes in the shared archive (BigInteger) in this case. Thus, I think it is a good idea to either use a different class or to explicitly disable class data sharing (simpler). /Staffan > > David > >> >> >> The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. >> >> public class TestRedefine implements ClassFileTransformer { >> >> public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { >> try { >> inst.addTransformer(new TestRedefine()); >> ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); >> if (!isTransformCalled) { >> throw new Exception("transform() NOT called for " + targetName); >> } >> } catch (Throwable t) { >> t.printStackTrace(); >> throw t; >> } >> } >> >> public byte[] transform(ClassLoader loader, >> String className, >> Class classBeingRedefined, >> ProtectionDomain protectionDomain, >> byte[] classfileBuffer) { >> System.out.println("transform called: " + className); >> if (className.equals("java/math/BigInteger")) { >> isTransformCalled = true; >> } >> return null; >> } >> >> public static void main(String args[]) throws Exception { >> String pid = getProcessId(); >> try { >> VirtualMachine vm = VirtualMachine.attach(pid); >> vm.loadAgent("TestRedefine.jar"); >> } catch (Exception e) { >> e.printStackTrace(); >> throw e; >> } >> } >> >> ... more code ... >> } >> >> >> >> >> >> ----- Original Message ----- >> From: leonid.mesnik at oracle.com >> To: mattias.tobiasson at oracle.com >> Cc: serviceability-dev at openjdk.java.net >> Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> Hi >> >> Generally I am ok with your comments and fix. However you still needed >> to get official review. >> >> The only question is about failure related from retransformation of >> j.l.BigInteger with CDS. >> Could it be JDK issue? In this case it would be better to file it as a >> part of fix. >> I understand that using of CDS and instrumentation of JDK classes is not >> related with this test >> and your fix make it cleaner. However could you please verify that we >> don't have JDK issue here. >> >> see other comments inline >> >> On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: >>> Hi, >>> Thanks for the review. I have summarized the questions and answers: >>> >>> Q: What is the reason of this intermittent failure? >>> A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. >>> I got the idea for -Xshare:dump from this bug: >>> https://bugs.openjdk.java.net/browse/JDK-6571866 >>> I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. >>> >>> Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. >> >>> >>> Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? >>> A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". >> Thank you for explanation. >>> >>> Q: In getCommandLine(), should we also trim cmd to remove last " "? >>> A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. >> Ok >>> >>> Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? >>> A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. >> >>> >>> Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? >>> A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. >> Ok >>> >>> Q: Timeouts in function waitForJvmPid(String key)? >>> A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. >>> I will add a flush() to stdout to make sure we log before we wait. >> Hope we will update jtreg before get into this issue :) >> >> Leonid >>> Mattias >>> >>> ----- Original Message ----- >>> From: leonid.mesnik at oracle.com >>> To: mattias.tobiasson at oracle.com, serviceability-dev at openjdk.java.net >>> Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> Hi >>> >>> I have a couple of high-level questions. >>> >>> On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: >>>> Hi, >>>> The test has been updated after the first review. >>>> The two java files for each test has been merged to a single file. >>>> >>>> >>>> Updated summary of changes: >>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>> What is the reason of this intermittent failure? >>>> 2. Removed all bash scripts. >>> Great! >>>> 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. >>>> >>>> 4. Added some utility functions to jdk/testlibrary. >>> Here some comments about library code. >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html >>> >>> + try { >>> + output = new OutputAnalyzer(this.process); >>> + } catch (Throwable t) { >>> + String name = Thread.currentThread().getName(); >>> + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); >>> + throw t; >>> + } finally { >>> + String logMsg = ProcessTools.getProcessLog(processBuilder, output); >>> + System.out.println(logMsg); >>> + } >>> >>> >>> You used output in finally which is not initialized properly in the case >>> of Exception. >>> Could we get another uncaught exception in finally? >>> >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html >>> >>> 1) Same in as previous in executeProcess method. >>> >>> 2) getCommandLine (...) >>> >>> + /** >>> + * @return The full command line for the ProcessBuilder. >>> + */ >>> + public static String getCommandLine(ProcessBuilder pb) { >>> + StringBuilder cmd = new StringBuilder(); >>> + for (String s : pb.command()) { >>> + cmd.append(s).append(" "); >>> + } >>> + return cmd.toString(); >>> + } >>> >>> >>> Should we also trim cmd to remove last " "? >>> >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html >>> >>> public static int waitForJvmPid(String key) throws Throwable { >>> >>> >>> Why it throw Trowable? Could we deal with exceptions in this method and >>> re-throw some more meaningful exception here? >>> Could you force flush for out here: >>> >>> System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); >>> >>> Hope it should be enough. It is scary to investigate such "timeouts". >>> Would it be better to add some >>> internal timeout in testlibrary? Really jtreg doesn't kill all processes >>> and we have alive java processes in such case. >>> For samevm tests timeouts are even worse. There is no good way to kill >>> test in samevm. >>> >>> Should be >>> >>> public static int tryFindJvmPid(String key) throws Throwable { >>> >>> private? Are we going to use it in tests or only waitForJvmPid? >>> >>> Leonid >>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>> >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-6461635 >>>> >>>> Mattias >>>> >>>> >>>> ----- Original Message ----- >>>> From: mattias.tobiasson at oracle.com >>>> To: mikael.auno at oracle.com >>>> Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com >>>> Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>> >>>> I agree that merging both files in a single file may be good. >>>> The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. >>>> >>>> But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. >>>> >>>> Mattias >>>> >>>> ----- Original Message ----- >>>> From: mikael.auno at oracle.com >>>> To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com >>>> Cc: serviceability-dev at openjdk.java.net >>>> Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>> >>>> How about defining the class that you want to attach to as a static >>>> inner class to the actual test? That would give you only one file, but >>>> with two classes, each with its own main method and clear correlation >>>> between them. >>>> >>>> Mikael >>>> >>>> On 2013-11-20 15:41, Mattias Tobiasson wrote: >>>>> Hi, >>>>> Each test requires 2 files, the actual test code and a helper file. >>>>> >>>>> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >>>>> >>>>> For example: >>>>> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >>>>> PermissionTest.java: The actual test code that attaches to the Application. >>>>> >>>>> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >>>>> >>>>> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >>>>> >>>>> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >>>>> >>>>> I used these names: >>>>> TestPermission.java: Helper file. >>>>> TestPermissionImpl.java: Actual test code. >>>>> >>>>> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >>>>> >>>>> Mattias >>>>> >>>>> >>>>> ----- Original Message ----- >>>>> From: Alan.Bateman at oracle.com >>>>> To: mattias.tobiasson at oracle.com >>>>> Cc: serviceability-dev at openjdk.java.net >>>>> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>>> >>>>> >>>>> Out of curiosity, what is the reason for the rename? I ask because we >>>>> use Basic and similar names in many areas. Also anything in the test >>>>> tree should be a test. >>>>> >>>>> -Alan. >>>>> >>>>> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>>>>> Hi, >>>>>> Could you please review this fix. >>>>>> >>>>>> Summary of changes: >>>>>> >>>>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>>>>> >>>>>> 2. Ported the following bash scripts to java: >>>>>> BasicTests.sh -> TestBasic.java >>>>>> PermissionTests.sh -> TestPermission.java >>>>>> ProviderTests.sh -> TestProvider.java >>>>>> >>>>>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>>>>> BasicsTest.java -> TestBasicImpl.java >>>>>> PermissionTest.java -> TestPermissionImpl.java >>>>>> ProviderTest.java -> TestProviderImpl.java >>>>>> >>>>>> 4. Added some utility functions to jdk/testlibrary. >>>>>> >>>>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Mattias >>>>>> >>>>>> Webrev: >>>>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>>>>> >>>>>> Bug: >>>>>> https://bugs.openjdk.java.net/browse/JDK-6461635 >>> >> >> From mattias.tobiasson at oracle.com Wed Nov 27 03:46:02 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Wed, 27 Nov 2013 03:46:02 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <68c32d89-9858-4442-b7c7-1f00b1b9390f@default> According to the test documentation and bug references the test verifies the manifest attribute "Can-Redefine-Classes". The test does not mention shared class archive or -Xshare. But maybe the test has found a problem accidentally... Mattias ----- Original Message ----- From: david.holmes at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 27, 2013 12:21:50 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently On 27/11/2013 8:46 PM, Mattias Tobiasson wrote: > Hi, I now have a reproducer for this test that fails every time. > I just need to verify that it really is a test bug and not a product bug. > > This is a summary of the test: > 1. It loads a javaagent jar that implements ClassFileTransformer. > 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. > > I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. -Xshare:auto will default to off for server compiler, but on for client > When the reproducer is run with flag "-Xshare:off" it passes every time. > When run with "-Xshare:auto" it fails every time. > When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. > > My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. If the whole point of the test is to transform a file from the shared archive then changing to a class not in the archive will defeat that. So you need to verify what the intent of the test is. David > > > The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. > > public class TestRedefine implements ClassFileTransformer { > > public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { > try { > inst.addTransformer(new TestRedefine()); > ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); > if (!isTransformCalled) { > throw new Exception("transform() NOT called for " + targetName); > } > } catch (Throwable t) { > t.printStackTrace(); > throw t; > } > } > > public byte[] transform(ClassLoader loader, > String className, > Class classBeingRedefined, > ProtectionDomain protectionDomain, > byte[] classfileBuffer) { > System.out.println("transform called: " + className); > if (className.equals("java/math/BigInteger")) { > isTransformCalled = true; > } > return null; > } > > public static void main(String args[]) throws Exception { > String pid = getProcessId(); > try { > VirtualMachine vm = VirtualMachine.attach(pid); > vm.loadAgent("TestRedefine.jar"); > } catch (Exception e) { > e.printStackTrace(); > throw e; > } > } > > ... more code ... > } > > > > > > ----- Original Message ----- > From: leonid.mesnik at oracle.com > To: mattias.tobiasson at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > Hi > > Generally I am ok with your comments and fix. However you still needed > to get official review. > > The only question is about failure related from retransformation of > j.l.BigInteger with CDS. > Could it be JDK issue? In this case it would be better to file it as a > part of fix. > I understand that using of CDS and instrumentation of JDK classes is not > related with this test > and your fix make it cleaner. However could you please verify that we > don't have JDK issue here. > > see other comments inline > > On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: >> Hi, >> Thanks for the review. I have summarized the questions and answers: >> >> Q: What is the reason of this intermittent failure? >> A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. >> I got the idea for -Xshare:dump from this bug: >> https://bugs.openjdk.java.net/browse/JDK-6571866 >> I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. >> >> Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. > >> >> Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? >> A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". > Thank you for explanation. >> >> Q: In getCommandLine(), should we also trim cmd to remove last " "? >> A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. > Ok >> >> Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? >> A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. > >> >> Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? >> A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. > Ok >> >> Q: Timeouts in function waitForJvmPid(String key)? >> A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. >> I will add a flush() to stdout to make sure we log before we wait. > Hope we will update jtreg before get into this issue :) > > Leonid >> Mattias >> >> ----- Original Message ----- >> From: leonid.mesnik at oracle.com >> To: mattias.tobiasson at oracle.com, serviceability-dev at openjdk.java.net >> Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> Hi >> >> I have a couple of high-level questions. >> >> On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: >>> Hi, >>> The test has been updated after the first review. >>> The two java files for each test has been merged to a single file. >>> >>> >>> Updated summary of changes: >>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >> What is the reason of this intermittent failure? >>> 2. Removed all bash scripts. >> Great! >>> 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. >>> >>> 4. Added some utility functions to jdk/testlibrary. >> Here some comments about library code. >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html >> >> + try { >> + output = new OutputAnalyzer(this.process); >> + } catch (Throwable t) { >> + String name = Thread.currentThread().getName(); >> + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); >> + throw t; >> + } finally { >> + String logMsg = ProcessTools.getProcessLog(processBuilder, output); >> + System.out.println(logMsg); >> + } >> >> >> You used output in finally which is not initialized properly in the case >> of Exception. >> Could we get another uncaught exception in finally? >> >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html >> >> 1) Same in as previous in executeProcess method. >> >> 2) getCommandLine (...) >> >> + /** >> + * @return The full command line for the ProcessBuilder. >> + */ >> + public static String getCommandLine(ProcessBuilder pb) { >> + StringBuilder cmd = new StringBuilder(); >> + for (String s : pb.command()) { >> + cmd.append(s).append(" "); >> + } >> + return cmd.toString(); >> + } >> >> >> Should we also trim cmd to remove last " "? >> >> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html >> >> public static int waitForJvmPid(String key) throws Throwable { >> >> >> Why it throw Trowable? Could we deal with exceptions in this method and >> re-throw some more meaningful exception here? >> Could you force flush for out here: >> >> System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); >> >> Hope it should be enough. It is scary to investigate such "timeouts". >> Would it be better to add some >> internal timeout in testlibrary? Really jtreg doesn't kill all processes >> and we have alive java processes in such case. >> For samevm tests timeouts are even worse. There is no good way to kill >> test in samevm. >> >> Should be >> >> public static int tryFindJvmPid(String key) throws Throwable { >> >> private? Are we going to use it in tests or only waitForJvmPid? >> >> Leonid >>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>> >>> >>> Webrev: >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-6461635 >>> >>> Mattias >>> >>> >>> ----- Original Message ----- >>> From: mattias.tobiasson at oracle.com >>> To: mikael.auno at oracle.com >>> Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com >>> Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> I agree that merging both files in a single file may be good. >>> The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. >>> >>> But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. >>> >>> Mattias >>> >>> ----- Original Message ----- >>> From: mikael.auno at oracle.com >>> To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com >>> Cc: serviceability-dev at openjdk.java.net >>> Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> How about defining the class that you want to attach to as a static >>> inner class to the actual test? That would give you only one file, but >>> with two classes, each with its own main method and clear correlation >>> between them. >>> >>> Mikael >>> >>> On 2013-11-20 15:41, Mattias Tobiasson wrote: >>>> Hi, >>>> Each test requires 2 files, the actual test code and a helper file. >>>> >>>> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >>>> >>>> For example: >>>> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >>>> PermissionTest.java: The actual test code that attaches to the Application. >>>> >>>> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >>>> >>>> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >>>> >>>> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >>>> >>>> I used these names: >>>> TestPermission.java: Helper file. >>>> TestPermissionImpl.java: Actual test code. >>>> >>>> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >>>> >>>> Mattias >>>> >>>> >>>> ----- Original Message ----- >>>> From: Alan.Bateman at oracle.com >>>> To: mattias.tobiasson at oracle.com >>>> Cc: serviceability-dev at openjdk.java.net >>>> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>> >>>> >>>> Out of curiosity, what is the reason for the rename? I ask because we >>>> use Basic and similar names in many areas. Also anything in the test >>>> tree should be a test. >>>> >>>> -Alan. >>>> >>>> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>>>> Hi, >>>>> Could you please review this fix. >>>>> >>>>> Summary of changes: >>>>> >>>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>>>> >>>>> 2. Ported the following bash scripts to java: >>>>> BasicTests.sh -> TestBasic.java >>>>> PermissionTests.sh -> TestPermission.java >>>>> ProviderTests.sh -> TestProvider.java >>>>> >>>>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>>>> BasicsTest.java -> TestBasicImpl.java >>>>> PermissionTest.java -> TestPermissionImpl.java >>>>> ProviderTest.java -> TestProviderImpl.java >>>>> >>>>> 4. Added some utility functions to jdk/testlibrary. >>>>> >>>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>>> >>>>> >>>>> Thanks, >>>>> Mattias >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>>>> >>>>> Bug: >>>>> https://bugs.openjdk.java.net/browse/JDK-6461635 >> > > From dmitry.samersoff at oracle.com Wed Nov 27 04:06:13 2013 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Wed, 27 Nov 2013 12:06:13 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7050685: jsdbproc64.sh has a typo in the package name Message-ID: <20131127120623.83977628A6@hg.openjdk.java.net> Changeset: 8a42e81e2f9d Author: dsamersoff Date: 2013-11-27 14:26 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8a42e81e2f9d 7050685: jsdbproc64.sh has a typo in the package name Summary: fixed typeo Reviewed-by: sla, kmo, sspitsyn ! agent/make/jsdbproc64.sh From leonid.mesnik at oracle.com Wed Nov 27 07:13:40 2013 From: leonid.mesnik at oracle.com (Leonid Mesnik) Date: Wed, 27 Nov 2013 19:13:40 +0400 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <68c32d89-9858-4442-b7c7-1f00b1b9390f@default> References: <68c32d89-9858-4442-b7c7-1f00b1b9390f@default> Message-ID: <52960C24.3010103@oracle.com> I think test should test instrumentation of custom, JDK, JDK shared classes as a part of scenario. This is how tools could use this mechanism. May be I am wrong. Also I found * JDK-5002268 Allow class sharing use with RedefineClasses which allow to redefine of classes when class sharing is used. I don't exactly know should it work for j.l.instrument as well as for JVMTI Dan Could you please help us with this? Is it a legal scenario to redefine shared classes? Leonid On 11/27/2013 03:46 PM, Mattias Tobiasson wrote: > According to the test documentation and bug references the test verifies the manifest attribute "Can-Redefine-Classes". > The test does not mention shared class archive or -Xshare. > But maybe the test has found a problem accidentally... > > Mattias > > ----- Original Message ----- > From: david.holmes at oracle.com > To: mattias.tobiasson at oracle.com > Cc: serviceability-dev at openjdk.java.net > Sent: Wednesday, November 27, 2013 12:21:50 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > On 27/11/2013 8:46 PM, Mattias Tobiasson wrote: >> Hi, I now have a reproducer for this test that fails every time. >> I just need to verify that it really is a test bug and not a product bug. >> >> This is a summary of the test: >> 1. It loads a javaagent jar that implements ClassFileTransformer. >> 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. >> >> I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. > -Xshare:auto will default to off for server compiler, but on for client > >> When the reproducer is run with flag "-Xshare:off" it passes every time. >> When run with "-Xshare:auto" it fails every time. >> When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. >> >> My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. > If the whole point of the test is to transform a file from the shared > archive then changing to a class not in the archive will defeat that. So > you need to verify what the intent of the test is. > > David > >> >> The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. >> >> public class TestRedefine implements ClassFileTransformer { >> >> public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { >> try { >> inst.addTransformer(new TestRedefine()); >> ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); >> if (!isTransformCalled) { >> throw new Exception("transform() NOT called for " + targetName); >> } >> } catch (Throwable t) { >> t.printStackTrace(); >> throw t; >> } >> } >> >> public byte[] transform(ClassLoader loader, >> String className, >> Class classBeingRedefined, >> ProtectionDomain protectionDomain, >> byte[] classfileBuffer) { >> System.out.println("transform called: " + className); >> if (className.equals("java/math/BigInteger")) { >> isTransformCalled = true; >> } >> return null; >> } >> >> public static void main(String args[]) throws Exception { >> String pid = getProcessId(); >> try { >> VirtualMachine vm = VirtualMachine.attach(pid); >> vm.loadAgent("TestRedefine.jar"); >> } catch (Exception e) { >> e.printStackTrace(); >> throw e; >> } >> } >> >> ... more code ... >> } >> >> >> >> >> >> ----- Original Message ----- >> From: leonid.mesnik at oracle.com >> To: mattias.tobiasson at oracle.com >> Cc: serviceability-dev at openjdk.java.net >> Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >> >> Hi >> >> Generally I am ok with your comments and fix. However you still needed >> to get official review. >> >> The only question is about failure related from retransformation of >> j.l.BigInteger with CDS. >> Could it be JDK issue? In this case it would be better to file it as a >> part of fix. >> I understand that using of CDS and instrumentation of JDK classes is not >> related with this test >> and your fix make it cleaner. However could you please verify that we >> don't have JDK issue here. >> >> see other comments inline >> >> On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: >>> Hi, >>> Thanks for the review. I have summarized the questions and answers: >>> >>> Q: What is the reason of this intermittent failure? >>> A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. >>> I got the idea for -Xshare:dump from this bug: >>> https://bugs.openjdk.java.net/browse/JDK-6571866 >>> I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. >>> >>> Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. >>> Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? >>> A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". >> Thank you for explanation. >>> Q: In getCommandLine(), should we also trim cmd to remove last " "? >>> A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. >> Ok >>> Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? >>> A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. >>> Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? >>> A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. >> Ok >>> Q: Timeouts in function waitForJvmPid(String key)? >>> A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. >>> I will add a flush() to stdout to make sure we log before we wait. >> Hope we will update jtreg before get into this issue :) >> >> Leonid >>> Mattias >>> >>> ----- Original Message ----- >>> From: leonid.mesnik at oracle.com >>> To: mattias.tobiasson at oracle.com, serviceability-dev at openjdk.java.net >>> Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>> >>> Hi >>> >>> I have a couple of high-level questions. >>> >>> On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: >>>> Hi, >>>> The test has been updated after the first review. >>>> The two java files for each test has been merged to a single file. >>>> >>>> >>>> Updated summary of changes: >>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>> What is the reason of this intermittent failure? >>>> 2. Removed all bash scripts. >>> Great! >>>> 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. >>>> >>>> 4. Added some utility functions to jdk/testlibrary. >>> Here some comments about library code. >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html >>> >>> + try { >>> + output = new OutputAnalyzer(this.process); >>> + } catch (Throwable t) { >>> + String name = Thread.currentThread().getName(); >>> + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); >>> + throw t; >>> + } finally { >>> + String logMsg = ProcessTools.getProcessLog(processBuilder, output); >>> + System.out.println(logMsg); >>> + } >>> >>> >>> You used output in finally which is not initialized properly in the case >>> of Exception. >>> Could we get another uncaught exception in finally? >>> >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html >>> >>> 1) Same in as previous in executeProcess method. >>> >>> 2) getCommandLine (...) >>> >>> + /** >>> + * @return The full command line for the ProcessBuilder. >>> + */ >>> + public static String getCommandLine(ProcessBuilder pb) { >>> + StringBuilder cmd = new StringBuilder(); >>> + for (String s : pb.command()) { >>> + cmd.append(s).append(" "); >>> + } >>> + return cmd.toString(); >>> + } >>> >>> >>> Should we also trim cmd to remove last " "? >>> >>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html >>> >>> public static int waitForJvmPid(String key) throws Throwable { >>> >>> >>> Why it throw Trowable? Could we deal with exceptions in this method and >>> re-throw some more meaningful exception here? >>> Could you force flush for out here: >>> >>> System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); >>> >>> Hope it should be enough. It is scary to investigate such "timeouts". >>> Would it be better to add some >>> internal timeout in testlibrary? Really jtreg doesn't kill all processes >>> and we have alive java processes in such case. >>> For samevm tests timeouts are even worse. There is no good way to kill >>> test in samevm. >>> >>> Should be >>> >>> public static int tryFindJvmPid(String key) throws Throwable { >>> >>> private? Are we going to use it in tests or only waitForJvmPid? >>> >>> Leonid >>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>> >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-6461635 >>>> >>>> Mattias >>>> >>>> >>>> ----- Original Message ----- >>>> From: mattias.tobiasson at oracle.com >>>> To: mikael.auno at oracle.com >>>> Cc: serviceability-dev at openjdk.java.net, Alan.Bateman at oracle.com >>>> Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>> >>>> I agree that merging both files in a single file may be good. >>>> The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. >>>> >>>> But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. >>>> >>>> Mattias >>>> >>>> ----- Original Message ----- >>>> From: mikael.auno at oracle.com >>>> To: mattias.tobiasson at oracle.com, Alan.Bateman at oracle.com >>>> Cc: serviceability-dev at openjdk.java.net >>>> Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>> >>>> How about defining the class that you want to attach to as a static >>>> inner class to the actual test? That would give you only one file, but >>>> with two classes, each with its own main method and clear correlation >>>> between them. >>>> >>>> Mikael >>>> >>>> On 2013-11-20 15:41, Mattias Tobiasson wrote: >>>>> Hi, >>>>> Each test requires 2 files, the actual test code and a helper file. >>>>> >>>>> The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. >>>>> >>>>> For example: >>>>> PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java >>>>> PermissionTest.java: The actual test code that attaches to the Application. >>>>> >>>>> It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). >>>>> >>>>> When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. >>>>> >>>>> I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. >>>>> >>>>> I used these names: >>>>> TestPermission.java: Helper file. >>>>> TestPermissionImpl.java: Actual test code. >>>>> >>>>> I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. >>>>> >>>>> Mattias >>>>> >>>>> >>>>> ----- Original Message ----- >>>>> From: Alan.Bateman at oracle.com >>>>> To: mattias.tobiasson at oracle.com >>>>> Cc: serviceability-dev at openjdk.java.net >>>>> Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna >>>>> Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently >>>>> >>>>> >>>>> Out of curiosity, what is the reason for the rename? I ask because we >>>>> use Basic and similar names in many areas. Also anything in the test >>>>> tree should be a test. >>>>> >>>>> -Alan. >>>>> >>>>> On 20/11/2013 13:47, Mattias Tobiasson wrote: >>>>>> Hi, >>>>>> Could you please review this fix. >>>>>> >>>>>> Summary of changes: >>>>>> >>>>>> 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. >>>>>> >>>>>> 2. Ported the following bash scripts to java: >>>>>> BasicTests.sh -> TestBasic.java >>>>>> PermissionTests.sh -> TestPermission.java >>>>>> ProviderTests.sh -> TestProvider.java >>>>>> >>>>>> 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: >>>>>> BasicsTest.java -> TestBasicImpl.java >>>>>> PermissionTest.java -> TestPermissionImpl.java >>>>>> ProviderTest.java -> TestProviderImpl.java >>>>>> >>>>>> 4. Added some utility functions to jdk/testlibrary. >>>>>> >>>>>> 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Mattias >>>>>> >>>>>> Webrev: >>>>>> http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ >>>>>> >>>>>> Bug: >>>>>> https://bugs.openjdk.java.net/browse/JDK-6461635 >> -- Leonid Mesnik JVM SQE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131127/671d0296/attachment-0001.html From shanliang.jiang at oracle.com Wed Nov 27 07:41:39 2013 From: shanliang.jiang at oracle.com (shanliang) Date: Wed, 27 Nov 2013 16:41:39 +0100 Subject: Codereview request: 8029063 test/com/sun/jmx/snmp/NoInfoLeakTest.java does not compile with OpenJDK builds Message-ID: <529612B3.4000904@oracle.com> This is a simple test fix, have to remove the test in OpenJDK because the SNMP classes in the OpenJDK will not be compiled if the closed part is not present. -------------- next part -------------- A non-text attachment was scrubbed... Name: diff8029063-open Type: video/x-flv Size: 5049 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131127/3cdd0fcb/diff8029063-open.bin From Alan.Bateman at oracle.com Wed Nov 27 07:52:10 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 27 Nov 2013 15:52:10 +0000 Subject: Codereview request: 8029063 test/com/sun/jmx/snmp/NoInfoLeakTest.java does not compile with OpenJDK builds In-Reply-To: <529612B3.4000904@oracle.com> References: <529612B3.4000904@oracle.com> Message-ID: <5296152A.4050202@oracle.com> On 27/11/2013 15:41, shanliang wrote: > This is a simple test fix, have to remove the test in OpenJDK because > the SNMP classes in the OpenJDK will not be compiled if the closed > part is not present. Deleting it make sense, thumbs up from me. -Alan. From daniel.fuchs at oracle.com Wed Nov 27 07:55:01 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 27 Nov 2013 16:55:01 +0100 Subject: Codereview request: 8029063 test/com/sun/jmx/snmp/NoInfoLeakTest.java does not compile with OpenJDK builds In-Reply-To: <529612B3.4000904@oracle.com> References: <529612B3.4000904@oracle.com> Message-ID: <529615D5.60806@oracle.com> On 11/27/13 4:41 PM, shanliang wrote: > This is a simple test fix, have to remove the test in OpenJDK because > the SNMP classes in the OpenJDK will not be compiled if the closed part > is not present. looks good. -- daniel From naoto.sato at oracle.com Wed Nov 27 10:01:47 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 27 Nov 2013 18:01:47 +0000 Subject: hg: jdk8/tl/jdk: 8028771: regression test java/util/Locale/LocaleProviders.sh failed Message-ID: <20131127180205.D38E9628AC@hg.openjdk.java.net> Changeset: 2370d285d08b Author: naoto Date: 2013-11-27 10:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2370d285d08b 8028771: regression test java/util/Locale/LocaleProviders.sh failed Reviewed-by: alanb ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From vladimir.kozlov at oracle.com Wed Nov 27 10:03:50 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 27 Nov 2013 10:03:50 -0800 Subject: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 In-Reply-To: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> References: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> Message-ID: <52963406.1050200@oracle.com> Hi, Markus I think the bug report should link to 8005849 which introduced this additional check and regression. Is it possible to prepare a jtreg test which will use AsynchGetCallTrace and catch such situations in a future? The fix itself looks good. Thanks, Vladimir On 11/27/13 1:47 AM, Markus Gronlund wrote: > Greetings, > > Kindly asking for reviews for the following change: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028412 > > Webrev: http://cr.openjdk.java.net/~mgronlun/8028412/webrev01/ > > Description: > > AsynchGetCallTrace() uses platform specific code for stack frame traversals. > > On x86, there currently exist a defensive construct that practically > disallows stack traversal over entry_frame code stubs, such as > StubRoutine(1) frames: > > src/cpu/x86/vm/frame_x86.cpp b/src/cpu/x86/vm/frame_x86.cpp: > > bool frame::safe_for_sender(JavaThread* thread) { > > ? > > if (!Interpreter::contains(_pc) && _cb->frame_size() <= 0) { > //assert(0, "Invalid frame_size"); > > return false; > } > > ? > > Since entry frames (such as StubRoutine(1)) have a frame size of 0, the > code returns prematurely. > > Fix is to move this frame size check post handling of is_entry_frame(), > where the code_stubs are processed. > > Testing completed: > > Sun Studio Profiler reproducer testcase > > SpecJBB2005 > > Kitchensink > > Thanks > Markus > From jaroslav.bachorik at oracle.com Wed Nov 27 10:41:07 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 27 Nov 2013 19:41:07 +0100 Subject: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS In-Reply-To: <528F62B7.3060207@oracle.com> References: <528B7448.3090005@oracle.com> <528E3A16.6060401@oracle.com> <528F62B7.3060207@oracle.com> Message-ID: <52963CC3.90102@oracle.com> Hi, I've uploaded the patch with the minimal changes that should resolve this particular problem. http://cr.openjdk.java.net/~jbachorik/6987597/webrev.04 -JB- On 22.11.2013 14:57, Jaroslav Bachorik wrote: > On 21.11.2013 17:51, Mandy Chung wrote: >> Hi Jaroslav, >> >> On 11/19/2013 6:23 AM, Jaroslav Bachorik wrote: >>> Please, review this test fix. >>> >>> Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 >>> Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 >>> >>> The fix moves the execution of the test routine to the >>> GarbageCollectorMXBean notification handler - at that moment it's >>> certain that GC has already happened and it is safe to assert the data >>> provided by the MBean. >> >> This patch may have a potential issue when GC happens during the process >> of adding the notification handlers such as the number of increments is >> greater than the number of registered handlers. By the time the main >> thread reaches p.arriveAndAwaitAdvance, the phaser has advanced to the >> next phase with few arrived parties and will wait forever (until the >> next GC happens). This should rarely happen though. Note that >> p.arriveAndAwaitAdvance continue to run even if the thread is >> interrupted and what happens if jtreg attempts to time out the test? > > Thanks for catching this. It seems that using a Semaphore with adding > permissions when a GC notification arrives would be more stable. > >> >> Does this issue only happen to CMS with background GC thread? The >> proposed patch seems a little overkill. I wonder if the test should >> skip if running in CMS background mode. Does >> -XX:+ExplicitGCInvokesConcurrent flag will get System.gc() to run in >> foreground mode in CMS (I think that may get the GC to complete before >> System.gc() returns?) > > Yes, currently only CMS. It seems that the semantics of System.gc() > ("When control returns from the method call, the Java Virtual Machine > has made a best effort to reclaim space from all discarded objects.") > doesn't apply to the CMS collector. > > Adding "-XX:-ExplicitGCInvokesConcurrent" should force System.gc() to > wait till the GC has been performed. This could help resolve this > particular problem. > > -JB- > >> >> Mandy >> From mandy.chung at oracle.com Wed Nov 27 12:33:15 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 27 Nov 2013 12:33:15 -0800 Subject: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS In-Reply-To: <52963CC3.90102@oracle.com> References: <528B7448.3090005@oracle.com> <528E3A16.6060401@oracle.com> <528F62B7.3060207@oracle.com> <52963CC3.90102@oracle.com> Message-ID: <5296570B.50801@oracle.com> On 11/27/2013 10:41 AM, Jaroslav Bachorik wrote: > Hi, > > I've uploaded the patch with the minimal changes that should resolve > this particular problem. > > http://cr.openjdk.java.net/~jbachorik/6987597/webrev.04 > Looks good. I'm happy to see this simple change resolves the issue. It would be useful to add a comment before you push to explain why -XX:+ExplicitGCInvokesConcurrent flag is used for simplicity even though this flag is ignored by non-concurrent GC. Mandy > -JB- > > On 22.11.2013 14:57, Jaroslav Bachorik wrote: >> On 21.11.2013 17:51, Mandy Chung wrote: >>> Hi Jaroslav, >>> >>> On 11/19/2013 6:23 AM, Jaroslav Bachorik wrote: >>>> Please, review this test fix. >>>> >>>> Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 >>>> Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 >>>> >>>> The fix moves the execution of the test routine to the >>>> GarbageCollectorMXBean notification handler - at that moment it's >>>> certain that GC has already happened and it is safe to assert the data >>>> provided by the MBean. >>> >>> This patch may have a potential issue when GC happens during the >>> process >>> of adding the notification handlers such as the number of increments is >>> greater than the number of registered handlers. By the time the main >>> thread reaches p.arriveAndAwaitAdvance, the phaser has advanced to the >>> next phase with few arrived parties and will wait forever (until the >>> next GC happens). This should rarely happen though. Note that >>> p.arriveAndAwaitAdvance continue to run even if the thread is >>> interrupted and what happens if jtreg attempts to time out the test? >> >> Thanks for catching this. It seems that using a Semaphore with adding >> permissions when a GC notification arrives would be more stable. >> >>> >>> Does this issue only happen to CMS with background GC thread? The >>> proposed patch seems a little overkill. I wonder if the test should >>> skip if running in CMS background mode. Does >>> -XX:+ExplicitGCInvokesConcurrent flag will get System.gc() to run in >>> foreground mode in CMS (I think that may get the GC to complete before >>> System.gc() returns?) >> >> Yes, currently only CMS. It seems that the semantics of System.gc() >> ("When control returns from the method call, the Java Virtual Machine >> has made a best effort to reclaim space from all discarded objects.") >> doesn't apply to the CMS collector. >> >> Adding "-XX:-ExplicitGCInvokesConcurrent" should force System.gc() to >> wait till the GC has been performed. This could help resolve this >> particular problem. >> >> -JB- >> >>> >>> Mandy >>> > From jaroslav.bachorik at oracle.com Wed Nov 27 13:15:37 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 27 Nov 2013 22:15:37 +0100 Subject: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS In-Reply-To: <5296570B.50801@oracle.com> References: <528B7448.3090005@oracle.com> <528E3A16.6060401@oracle.com> <528F62B7.3060207@oracle.com> <52963CC3.90102@oracle.com> <5296570B.50801@oracle.com> Message-ID: <529660F9.5060608@oracle.com> Thanks for looking at this, Mandy. Here is the patch with added explanatory comments - http://cr.openjdk.java.net/~jbachorik/6987597/webrev.05 -JB- On 27.11.2013 21:33, Mandy Chung wrote: > On 11/27/2013 10:41 AM, Jaroslav Bachorik wrote: >> Hi, >> >> I've uploaded the patch with the minimal changes that should resolve >> this particular problem. >> >> http://cr.openjdk.java.net/~jbachorik/6987597/webrev.04 >> > > Looks good. I'm happy to see this simple change resolves the issue. It > would be useful to add a comment before you push to explain why > -XX:+ExplicitGCInvokesConcurrent flag is used for simplicity even though > this flag is ignored by non-concurrent GC. > > Mandy > >> -JB- >> >> On 22.11.2013 14:57, Jaroslav Bachorik wrote: >>> On 21.11.2013 17:51, Mandy Chung wrote: >>>> Hi Jaroslav, >>>> >>>> On 11/19/2013 6:23 AM, Jaroslav Bachorik wrote: >>>>> Please, review this test fix. >>>>> >>>>> Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 >>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 >>>>> >>>>> The fix moves the execution of the test routine to the >>>>> GarbageCollectorMXBean notification handler - at that moment it's >>>>> certain that GC has already happened and it is safe to assert the data >>>>> provided by the MBean. >>>> >>>> This patch may have a potential issue when GC happens during the >>>> process >>>> of adding the notification handlers such as the number of increments is >>>> greater than the number of registered handlers. By the time the main >>>> thread reaches p.arriveAndAwaitAdvance, the phaser has advanced to the >>>> next phase with few arrived parties and will wait forever (until the >>>> next GC happens). This should rarely happen though. Note that >>>> p.arriveAndAwaitAdvance continue to run even if the thread is >>>> interrupted and what happens if jtreg attempts to time out the test? >>> >>> Thanks for catching this. It seems that using a Semaphore with adding >>> permissions when a GC notification arrives would be more stable. >>> >>>> >>>> Does this issue only happen to CMS with background GC thread? The >>>> proposed patch seems a little overkill. I wonder if the test should >>>> skip if running in CMS background mode. Does >>>> -XX:+ExplicitGCInvokesConcurrent flag will get System.gc() to run in >>>> foreground mode in CMS (I think that may get the GC to complete before >>>> System.gc() returns?) >>> >>> Yes, currently only CMS. It seems that the semantics of System.gc() >>> ("When control returns from the method call, the Java Virtual Machine >>> has made a best effort to reclaim space from all discarded objects.") >>> doesn't apply to the CMS collector. >>> >>> Adding "-XX:-ExplicitGCInvokesConcurrent" should force System.gc() to >>> wait till the GC has been performed. This could help resolve this >>> particular problem. >>> >>> -JB- >>> >>>> >>>> Mandy >>>> >> > From mandy.chung at oracle.com Wed Nov 27 13:30:35 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 27 Nov 2013 13:30:35 -0800 Subject: RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS In-Reply-To: <529660F9.5060608@oracle.com> References: <528B7448.3090005@oracle.com> <528E3A16.6060401@oracle.com> <528F62B7.3060207@oracle.com> <52963CC3.90102@oracle.com> <5296570B.50801@oracle.com> <529660F9.5060608@oracle.com> Message-ID: Thumbs up Mandy > On Nov 27, 2013, at 1:15 PM, Jaroslav Bachorik wrote: > > Thanks for looking at this, Mandy. > > Here is the patch with added explanatory comments - http://cr.openjdk.java.net/~jbachorik/6987597/webrev.05 > > -JB- > >> On 27.11.2013 21:33, Mandy Chung wrote: >>> On 11/27/2013 10:41 AM, Jaroslav Bachorik wrote: >>> Hi, >>> >>> I've uploaded the patch with the minimal changes that should resolve >>> this particular problem. >>> >>> http://cr.openjdk.java.net/~jbachorik/6987597/webrev.04 >> >> Looks good. I'm happy to see this simple change resolves the issue. It >> would be useful to add a comment before you push to explain why >> -XX:+ExplicitGCInvokesConcurrent flag is used for simplicity even though >> this flag is ignored by non-concurrent GC. >> >> Mandy >> >>> -JB- >>> >>>> On 22.11.2013 14:57, Jaroslav Bachorik wrote: >>>>> On 21.11.2013 17:51, Mandy Chung wrote: >>>>> Hi Jaroslav, >>>>> >>>>>> On 11/19/2013 6:23 AM, Jaroslav Bachorik wrote: >>>>>> Please, review this test fix. >>>>>> >>>>>> Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 >>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 >>>>>> >>>>>> The fix moves the execution of the test routine to the >>>>>> GarbageCollectorMXBean notification handler - at that moment it's >>>>>> certain that GC has already happened and it is safe to assert the data >>>>>> provided by the MBean. >>>>> >>>>> This patch may have a potential issue when GC happens during the >>>>> process >>>>> of adding the notification handlers such as the number of increments is >>>>> greater than the number of registered handlers. By the time the main >>>>> thread reaches p.arriveAndAwaitAdvance, the phaser has advanced to the >>>>> next phase with few arrived parties and will wait forever (until the >>>>> next GC happens). This should rarely happen though. Note that >>>>> p.arriveAndAwaitAdvance continue to run even if the thread is >>>>> interrupted and what happens if jtreg attempts to time out the test? >>>> >>>> Thanks for catching this. It seems that using a Semaphore with adding >>>> permissions when a GC notification arrives would be more stable. >>>> >>>>> >>>>> Does this issue only happen to CMS with background GC thread? The >>>>> proposed patch seems a little overkill. I wonder if the test should >>>>> skip if running in CMS background mode. Does >>>>> -XX:+ExplicitGCInvokesConcurrent flag will get System.gc() to run in >>>>> foreground mode in CMS (I think that may get the GC to complete before >>>>> System.gc() returns?) >>>> >>>> Yes, currently only CMS. It seems that the semantics of System.gc() >>>> ("When control returns from the method call, the Java Virtual Machine >>>> has made a best effort to reclaim space from all discarded objects.") >>>> doesn't apply to the CMS collector. >>>> >>>> Adding "-XX:-ExplicitGCInvokesConcurrent" should force System.gc() to >>>> wait till the GC has been performed. This could help resolve this >>>> particular problem. >>>> >>>> -JB- >>>> >>>>> >>>>> Mandy > From jason.uh at oracle.com Wed Nov 27 15:27:00 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Wed, 27 Nov 2013 23:27:00 +0000 Subject: hg: jdk8/tl/jdk: 8021418: Intermittent: SSLSocketSSLEngineTemplate.java test fails with timeout Message-ID: <20131127232713.D3EFD628C0@hg.openjdk.java.net> Changeset: 5ac7cd164300 Author: juh Date: 2013-11-27 15:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ac7cd164300 8021418: Intermittent: SSLSocketSSLEngineTemplate.java test fails with timeout Reviewed-by: xuelei, wetmore Contributed-by: rajan.halade at oracle.com ! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java From yiming.wang at oracle.com Wed Nov 27 21:21:05 2013 From: yiming.wang at oracle.com (Eric Wang) Date: Thu, 28 Nov 2013 13:21:05 +0800 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <52955625.4050907@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> <5292C6E3.4050101@oracle.com> <5293ED67.9010406@oracle.com> <52942965.40102@oracle.com> <52955625.4050907@oracle.com> Message-ID: <5296D2C1.3080209@oracle.com> Hi Mandy, Yes, I have tested and all settings are passed, as you mentioned the test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent and default heap size as no GC happens on Old Gen. That is why to add -Xmx2m and big object to make sure GC happens. I didn't realized the -Xconcgc is same as -XX:+UseConcMarkSweepGC, i have updated the webrev: http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ Thanks, Eric On 2013/11/27 10:17, Mandy Chung wrote: > Hi Eric, > > I'll defer this to the serviceability team to sponsor it and also get > one more review. > > I don't think you need all 7 @runs. -Xconcgc is equivalent to setting > -XX:+UseConcMarkSweepGC. For G1 and CMS, you should use > -XX:+ExplicitGCInvokesConcurrent so that System.gc will force a GC in > foreground that you can count the GC reliably. The test wants to get > notified for each System.gc and if there is any GC caused by > allocation failure, the test would fail due to the unexpected GC > count. It seems that you may run into this issue setting -Xmx2m. > > Have you got the test passed in all settings? I'm seeing that the > test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent without > -Xmx2m. Looks like there is no GC in the old gen - I'm not familiar > with G1 if it allocates the big object in the old gen. Jarolsav - can > you help Eric diagnose this issue? I recalled you ran into something > like that before - maybe Staffan? > > thanks > Mandy > > On 11/25/2013 8:53 PM, Eric Wang wrote: >> Hi Mandy, >> >> 1. for L34-40, executing tests with 7 settings is trying to cover >> more cases (normal cases and special cases), especially last 3 >> settings, as found that the test hung if using vm option >> "-XX:+ExplicitGCInvokesConcurrent" with one of 3 options >> -XX:+UseG1GC, -XX:+UseConcMarkSweepGC or -Xconcgc >> >> 2. for L61, that is right, the test has been updated. please review. >> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >> >> >> Thanks, >> Eric >> On 2013/11/26 8:37, Mandy Chung wrote: >>> Hi Eric, >>> >>> On 11/24/2013 7:41 PM, Eric Wang wrote: >>>> Hi Mandy & All, >>>> >>>> Sorry for late! >>>> The webrev below is just finished based on the comments from peers, >>>> please help to review. >>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>>> >>>> >>> >>> Thanks for the patch that looks okay. Some comments: >>> >>> L34-40: can you explain why you want to run all 7 settings? I would >>> expect one for each collector. >>> L61: I think the static checker variable is meant to be a local >>> variable (and looks like "pools" and "managers" don't need to be >>> static variable). >>> >>> Mandy >>> >>>> Thanks, >>>> Eric >>>> On 2013/11/15 10:55, Mandy Chung wrote: >>>>> Hi Eric, >>>>> >>>>> On 11/14/2013 6:16 PM, Eric Wang wrote: >>>>>> Hi Everyone, >>>>>> >>>>>> I'm working on the bug >>>>>> https://bugs.openjdk.java.net/browse/JDK-7067973. >>>>>> >>>>>> It is a test bug as the test doesn't guarantee memory allocated >>>>>> from the Old Gen, if the used memory is zero and doesn't cross >>>>>> the threshold, no notification is sent, so both the main thread >>>>>> and Checker thread are blocked to wait for the GC notification. >>>>>> >>>>>> so the suggested fix is similar as the fix >>>>>> ResetPeakMemoryUsage.java >>>>>> to >>>>>> create big object to make sure the old gen usage crosses the >>>>>> threshold and run test with different GC vmoptions. >>>>> >>>>> What are you looking for specifically? I have provided the above >>>>> information. I need to see the webrev to provide further feedback. >>>>> >>>>> Mandy >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131128/38fcf412/attachment-0001.html From jaroslav.bachorik at oracle.com Thu Nov 28 00:16:50 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 28 Nov 2013 08:16:50 +0000 Subject: hg: jdk8/tl/jdk: 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS Message-ID: <20131128081759.A7522628D2@hg.openjdk.java.net> Changeset: 4afe1281c837 Author: jbachorik Date: 2013-11-28 09:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4afe1281c837 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS Reviewed-by: mchung ! test/com/sun/management/GarbageCollectorMXBean/LastGCInfo.java ! test/java/lang/management/GarbageCollectorMXBean/GcInfoCompositeType.java From mattias.tobiasson at oracle.com Thu Nov 28 01:48:56 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Thu, 28 Nov 2013 01:48:56 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <4aaddb4a-5eb3-48e9-924d-386ce929ac29@default> Is it ok if I check in the current test as it is now, and add a new bug for the (possible) problem of retransforming classes from the shared archive? Reasons for why I want to check in the current test as it is are: The purpose of the current test is not about the shared archive and is already quite large. A simpler reproducer could be used for the new bug. The new bug may not even be a bug, but working as expected. I want someone else to look at the bug before adding a new test. This fix also contains updates for the testlibrary that are needed for other tests. This bug was reported in 2006, so it is not a regression in jdk8. Mattias ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com, david.holmes at oracle.com Cc: serviceability-dev at openjdk.java.net, daniel.daugherty at oracle.com Sent: Wednesday, November 27, 2013 4:15:09 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently I think test should test instrumentation of custom, JDK, JDK shared classes as a part of scenario. This is how tools could use this mechanism. May be I am wrong. Also I found ? JDK-5002268 Allow class sharing use with RedefineClasses which allow to redefine of classes when class sharing is used. I don't exactly know should it work for j.l.instrument as well as for JVMTI Dan Could you please help us with this? Is it a legal scenario to redefine shared classes? Leonid On 11/27/2013 03:46 PM, Mattias Tobiasson wrote: According to the test documentation and bug references the test verifies the manifest attribute "Can-Redefine-Classes". The test does not mention shared class archive or -Xshare. But maybe the test has found a problem accidentally... Mattias ----- Original Message ----- From: david.holmes at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 27, 2013 12:21:50 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently On 27/11/2013 8:46 PM, Mattias Tobiasson wrote: Hi, I now have a reproducer for this test that fails every time. I just need to verify that it really is a test bug and not a product bug. This is a summary of the test: 1. It loads a javaagent jar that implements ClassFileTransformer. 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. -Xshare:auto will default to off for server compiler, but on for client When the reproducer is run with flag "-Xshare:off" it passes every time. When run with "-Xshare:auto" it fails every time. When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. If the whole point of the test is to transform a file from the shared archive then changing to a class not in the archive will defeat that. So you need to verify what the intent of the test is. David The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. public class TestRedefine implements ClassFileTransformer { public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { try { inst.addTransformer(new TestRedefine()); ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); if (!isTransformCalled) { throw new Exception("transform() NOT called for " + targetName); } } catch (Throwable t) { t.printStackTrace(); throw t; } } public byte[] transform(ClassLoader loader, String className, Class classBeingRedefined, ProtectionDomain protectionDomain, byte[] classfileBuffer) { System.out.println("transform called: " + className); if (className.equals("java/math/BigInteger")) { isTransformCalled = true; } return null; } public static void main(String args[]) throws Exception { String pid = getProcessId(); try { VirtualMachine vm = VirtualMachine.attach(pid); vm.loadAgent("TestRedefine.jar"); } catch (Exception e) { e.printStackTrace(); throw e; } } ... more code ... } ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Hi Generally I am ok with your comments and fix. However you still needed to get official review. The only question is about failure related from retransformation of j.l.BigInteger with CDS. Could it be JDK issue? In this case it would be better to file it as a part of fix. I understand that using of CDS and instrumentation of JDK classes is not related with this test and your fix make it cleaner. However could you please verify that we don't have JDK issue here. see other comments inline On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: Hi, Thanks for the review. I have summarized the questions and answers: Q: What is the reason of this intermittent failure? A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. I got the idea for -Xshare:dump from this bug: https://bugs.openjdk.java.net/browse/JDK-6571866 I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". Thank you for explanation. Q: In getCommandLine(), should we also trim cmd to remove last " "? A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. Ok Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. Ok Q: Timeouts in function waitForJvmPid(String key)? A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. I will add a flush() to stdout to make sure we log before we wait. Hope we will update jtreg before get into this issue :) Leonid Mattias ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com , serviceability-dev at openjdk.java.net Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Hi I have a couple of high-level questions. On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: Hi, The test has been updated after the first review. The two java files for each test has been merged to a single file. Updated summary of changes: 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. What is the reason of this intermittent failure? 2. Removed all bash scripts. Great! 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. 4. Added some utility functions to jdk/testlibrary. Here some comments about library code. http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html + try { + output = new OutputAnalyzer(this.process); + } catch (Throwable t) { + String name = Thread.currentThread().getName(); + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); + throw t; + } finally { + String logMsg = ProcessTools.getProcessLog(processBuilder, output); + System.out.println(logMsg); + } You used output in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html 1) Same in as previous in executeProcess method. 2) getCommandLine (...) + /** + * @return The full command line for the ProcessBuilder. + */ + public static String getCommandLine(ProcessBuilder pb) { + StringBuilder cmd = new StringBuilder(); + for (String s : pb.command()) { + cmd.append(s).append(" "); + } + return cmd.toString(); + } Should we also trim cmd to remove last " "? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html public static int waitForJvmPid(String key) throws Throwable { Why it throw Trowable? Could we deal with exceptions in this method and re-throw some more meaningful exception here? Could you force flush for out here: System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); Hope it should be enough. It is scary to investigate such "timeouts". Would it be better to add some internal timeout in testlibrary? Really jtreg doesn't kill all processes and we have alive java processes in such case. For samevm tests timeouts are even worse. There is no good way to kill test in samevm. Should be public static int tryFindJvmPid(String key) throws Throwable { private? Are we going to use it in tests or only waitForJvmPid? Leonid 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. Webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-6461635 Mattias ----- Original Message ----- From: mattias.tobiasson at oracle.com To: mikael.auno at oracle.com Cc: serviceability-dev at openjdk.java.net , Alan.Bateman at oracle.com Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently I agree that merging both files in a single file may be good. The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. Mattias ----- Original Message ----- From: mikael.auno at oracle.com To: mattias.tobiasson at oracle.com , Alan.Bateman at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently How about defining the class that you want to attach to as a static inner class to the actual test? That would give you only one file, but with two classes, each with its own main method and clear correlation between them. Mikael On 2013-11-20 15:41, Mattias Tobiasson wrote: Hi, Each test requires 2 files, the actual test code and a helper file. The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. For example: PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java PermissionTest.java: The actual test code that attaches to the Application. It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. I used these names: TestPermission.java: Helper file. TestPermissionImpl.java: Actual test code. I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. Mattias ----- Original Message ----- From: Alan.Bateman at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Out of curiosity, what is the reason for the rename? I ask because we use Basic and similar names in many areas. Also anything in the test tree should be a test. -Alan. On 20/11/2013 13:47, Mattias Tobiasson wrote: Hi, Could you please review this fix. Summary of changes: 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. 2. Ported the following bash scripts to java: BasicTests.sh -> TestBasic.java PermissionTests.sh -> TestPermission.java ProviderTests.sh -> TestProvider.java 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: BasicsTest.java -> TestBasicImpl.java PermissionTest.java -> TestPermissionImpl.java ProviderTest.java -> TestProviderImpl.java 4. Added some utility functions to jdk/testlibrary. 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. Thanks, Mattias Webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-6461635 -- Leonid Mesnik JVM SQE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131128/599b8a51/attachment-0001.html From leonid.mesnik at oracle.com Thu Nov 28 02:01:03 2013 From: leonid.mesnik at oracle.com (Leonid Mesnik) Date: Thu, 28 Nov 2013 14:01:03 +0400 Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently In-Reply-To: <4aaddb4a-5eb3-48e9-924d-386ce929ac29@default> References: <4aaddb4a-5eb3-48e9-924d-386ce929ac29@default> Message-ID: <5297145F.2020904@oracle.com> Mattias On 11/28/2013 01:48 PM, Mattias Tobiasson wrote: > Is it ok if I check in the current test as it is now, and add a new > bug for the (possible) problem of retransforming classes from the > shared archive? > It is ok if you check current test which redefine non-shared class and add new bug about shared transformation. The usage of non-shared class is cleaner rather disabling sharing explicitly. However you still need a review for this fix. > Reasons for why I want to check in the current test as it is are: > The purpose of the current test is not about the shared archive and is > already quite large. A simpler reproducer could be used for the new bug. I think it would be better to add more testcases into this test or more tests with similar but different scenarios. The new tests could be part of fix of new issue which you are going to file. Leonid > The new bug may not even be a bug, but working as expected. I want > someone else to look at the bug before adding a new test. > This fix also contains updates for the testlibrary that are needed for > other tests. > This bug was reported in 2006, so it is not a regression in jdk8. > > Mattias > > ----- Original Message ----- > From: leonid.mesnik at oracle.com > To: mattias.tobiasson at oracle.com, david.holmes at oracle.com > Cc: serviceability-dev at openjdk.java.net, daniel.daugherty at oracle.com > Sent: Wednesday, November 27, 2013 4:15:09 PM GMT +01:00 Amsterdam / > Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails > intermittently > > I think test should test instrumentation of custom, JDK, JDK shared > classes as a part of scenario. > This is how tools could use this mechanism. May be I am wrong. > > Also I found > > * JDK-5002268 > Allow class sharing use with RedefineClasses > > which allow to redefine of classes when class sharing is used. I don't > exactly know should it work > for j.l.instrument as well as for JVMTI > > Dan > Could you please help us with this? Is it a legal scenario to redefine > shared classes? > > > Leonid > > > On 11/27/2013 03:46 PM, Mattias Tobiasson wrote: > > According to the test documentation and bug references the test verifies the manifest attribute "Can-Redefine-Classes". > The test does not mention shared class archive or -Xshare. > But maybe the test has found a problem accidentally... > > Mattias > > ----- Original Message ----- > From:david.holmes at oracle.com > To:mattias.tobiasson at oracle.com > Cc:serviceability-dev at openjdk.java.net > Sent: Wednesday, November 27, 2013 12:21:50 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > On 27/11/2013 8:46 PM, Mattias Tobiasson wrote: > > Hi, I now have a reproducer for this test that fails every time. > I just need to verify that it really is a test bug and not a product bug. > > This is a summary of the test: > 1. It loads a javaagent jar that implements ClassFileTransformer. > 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. > > I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. > > -Xshare:auto will default to off for server compiler, but on for client > > When the reproducer is run with flag "-Xshare:off" it passes every time. > When run with "-Xshare:auto" it fails every time. > When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. > > My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. > > If the whole point of the test is to transform a file from the shared > archive then changing to a class not in the archive will defeat that. So > you need to verify what the intent of the test is. > > David > > The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. > > public class TestRedefine implements ClassFileTransformer { > > public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { > try { > inst.addTransformer(new TestRedefine()); > ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); > if (!isTransformCalled) { > throw new Exception("transform() NOT called for " + targetName); > } > } catch (Throwable t) { > t.printStackTrace(); > throw t; > } > } > > public byte[] transform(ClassLoader loader, > String className, > Class classBeingRedefined, > ProtectionDomain protectionDomain, > byte[] classfileBuffer) { > System.out.println("transform called: " + className); > if (className.equals("java/math/BigInteger")) { > isTransformCalled = true; > } > return null; > } > > public static void main(String args[]) throws Exception { > String pid = getProcessId(); > try { > VirtualMachine vm = VirtualMachine.attach(pid); > vm.loadAgent("TestRedefine.jar"); > } catch (Exception e) { > e.printStackTrace(); > throw e; > } > } > > ... more code ... > } > > > > > > ----- Original Message ----- > From:leonid.mesnik at oracle.com > To:mattias.tobiasson at oracle.com > Cc:serviceability-dev at openjdk.java.net > Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > Hi > > Generally I am ok with your comments and fix. However you still needed > to get official review. > > The only question is about failure related from retransformation of > j.l.BigInteger with CDS. > Could it be JDK issue? In this case it would be better to file it as a > part of fix. > I understand that using of CDS and instrumentation of JDK classes is not > related with this test > and your fix make it cleaner. However could you please verify that we > don't have JDK issue here. > > see other comments inline > > On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: > > Hi, > Thanks for the review. I have summarized the questions and answers: > > Q: What is the reason of this intermittent failure? > A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. > I got the idea for -Xshare:dump from this bug: > https://bugs.openjdk.java.net/browse/JDK-6571866 > I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. > > Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. > > Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? > A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". > > Thank you for explanation. > > Q: In getCommandLine(), should we also trim cmd to remove last " "? > A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. > > Ok > > Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? > A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. > > Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? > A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. > > Ok > > Q: Timeouts in function waitForJvmPid(String key)? > A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. > I will add a flush() to stdout to make sure we log before we wait. > > Hope we will update jtreg before get into this issue :) > > Leonid > > Mattias > > ----- Original Message ----- > From:leonid.mesnik at oracle.com > To:mattias.tobiasson at oracle.com,serviceability-dev at openjdk.java.net > Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > Hi > > I have a couple of high-level questions. > > On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: > > Hi, > The test has been updated after the first review. > The two java files for each test has been merged to a single file. > > > Updated summary of changes: > 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. > > What is the reason of this intermittent failure? > > 2. Removed all bash scripts. > > Great! > > 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. > > 4. Added some utility functions to jdk/testlibrary. > > Here some comments about library code. > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html > > + try { > + output = new OutputAnalyzer(this.process); > + } catch (Throwable t) { > + String name = Thread.currentThread().getName(); > + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); > + throw t; > + } finally { > + String logMsg = ProcessTools.getProcessLog(processBuilder, output); > + System.out.println(logMsg); > + } > > > You used output in finally which is not initialized properly in the case > of Exception. > Could we get another uncaught exception in finally? > > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html > > 1) Same in as previous in executeProcess method. > > 2) getCommandLine (...) > > + /** > + * @return The full command line for the ProcessBuilder. > + */ > + public static String getCommandLine(ProcessBuilder pb) { > + StringBuilder cmd = new StringBuilder(); > + for (String s : pb.command()) { > + cmd.append(s).append(" "); > + } > + return cmd.toString(); > + } > > > Should we also trim cmd to remove last " "? > > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html > > public static int waitForJvmPid(String key) throws Throwable { > > > Why it throw Trowable? Could we deal with exceptions in this method and > re-throw some more meaningful exception here? > Could you force flush for out here: > > System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); > > Hope it should be enough. It is scary to investigate such "timeouts". > Would it be better to add some > internal timeout in testlibrary? Really jtreg doesn't kill all processes > and we have alive java processes in such case. > For samevm tests timeouts are even worse. There is no good way to kill > test in samevm. > > Should be > > public static int tryFindJvmPid(String key) throws Throwable { > > private? Are we going to use it in tests or only waitForJvmPid? > > Leonid > > 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. > > > Webrev: > http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6461635 > > Mattias > > > ----- Original Message ----- > From:mattias.tobiasson at oracle.com > To:mikael.auno at oracle.com > Cc:serviceability-dev at openjdk.java.net,Alan.Bateman at oracle.com > Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > I agree that merging both files in a single file may be good. > The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. > > But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. > > Mattias > > ----- Original Message ----- > From:mikael.auno at oracle.com > To:mattias.tobiasson at oracle.com,Alan.Bateman at oracle.com > Cc:serviceability-dev at openjdk.java.net > Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > How about defining the class that you want to attach to as a static > inner class to the actual test? That would give you only one file, but > with two classes, each with its own main method and clear correlation > between them. > > Mikael > > On 2013-11-20 15:41, Mattias Tobiasson wrote: > > Hi, > Each test requires 2 files, the actual test code and a helper file. > > The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. > > For example: > PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java > PermissionTest.java: The actual test code that attaches to the Application. > > It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). > > When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. > > I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. > > I used these names: > TestPermission.java: Helper file. > TestPermissionImpl.java: Actual test code. > > I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. > > Mattias > > > ----- Original Message ----- > From:Alan.Bateman at oracle.com > To:mattias.tobiasson at oracle.com > Cc:serviceability-dev at openjdk.java.net > Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently > > > Out of curiosity, what is the reason for the rename? I ask because we > use Basic and similar names in many areas. Also anything in the test > tree should be a test. > > -Alan. > > On 20/11/2013 13:47, Mattias Tobiasson wrote: > > Hi, > Could you please review this fix. > > Summary of changes: > > 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. > > 2. Ported the following bash scripts to java: > BasicTests.sh -> TestBasic.java > PermissionTests.sh -> TestPermission.java > ProviderTests.sh -> TestProvider.java > > 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: > BasicsTest.java -> TestBasicImpl.java > PermissionTest.java -> TestPermissionImpl.java > ProviderTest.java -> TestProviderImpl.java > > 4. Added some utility functions to jdk/testlibrary. > > 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. > > > Thanks, > Mattias > > Webrev: > http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ > > Bug: > https://bugs.openjdk.java.net/browse/JDK-6461635 > > > > -- > Leonid Mesnik > JVM SQE -- Leonid Mesnik JVM SQE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131128/19c6d3fb/attachment-0001.html From leonid.mesnik at oracle.com Thu Nov 28 02:16:33 2013 From: leonid.mesnik at oracle.com (Leonid Mesnik) Date: Thu, 28 Nov 2013 14:16:33 +0400 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <5296D2C1.3080209@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> <5292C6E3.4050101@oracle.com> <5293ED67.9010406@oracle.com> <52942965.40102@oracle.com> <52955625.4050907@oracle.com> <5296D2C1.3080209@oracle.com> Message-ID: <52971801.6010905@oracle.com> Eric, Mandy Sorry that I looping on very late step. It is not a review just suggestion. We have whitebox API in Hotspot which includes fullGC() method. It could be used to reliably provoke full GC. See example in http://hg.openjdk.java.net/jdk8/tl/hotspot/file/c9f439732b18/test/runtime/interned/SanityTest.java Should such approach works for you? Also please note that your new variant of test fails if any of GC is set explicitly. It is incompatible with GC setting. We set GC's and GC-related options during Promotion/Nightly/PIT in Hotspot/SVC. For us is better if test just works with any GC set externally. Do you need to run it with all GC each time? Leonid On 11/28/2013 09:21 AM, Eric Wang wrote: > Hi Mandy, > > Yes, I have tested and all settings are passed, as you mentioned the > test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent and > default heap size as no GC happens on Old Gen. That is why to add > -Xmx2m and big object to make sure GC happens. > > I didn't realized the -Xconcgc is same as -XX:+UseConcMarkSweepGC, i > have updated the webrev: > http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ > > > Thanks, > Eric > On 2013/11/27 10:17, Mandy Chung wrote: >> Hi Eric, >> >> I'll defer this to the serviceability team to sponsor it and also get >> one more review. >> >> I don't think you need all 7 @runs. -Xconcgc is equivalent to >> setting -XX:+UseConcMarkSweepGC. For G1 and CMS, you should use >> -XX:+ExplicitGCInvokesConcurrent so that System.gc will force a GC in >> foreground that you can count the GC reliably. The test wants to get >> notified for each System.gc and if there is any GC caused by >> allocation failure, the test would fail due to the unexpected GC >> count. It seems that you may run into this issue setting -Xmx2m. >> >> Have you got the test passed in all settings? I'm seeing that the >> test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent without >> -Xmx2m. Looks like there is no GC in the old gen - I'm not familiar >> with G1 if it allocates the big object in the old gen. Jarolsav - >> can you help Eric diagnose this issue? I recalled you ran into >> something like that before - maybe Staffan? >> >> thanks >> Mandy >> >> On 11/25/2013 8:53 PM, Eric Wang wrote: >>> Hi Mandy, >>> >>> 1. for L34-40, executing tests with 7 settings is trying to cover >>> more cases (normal cases and special cases), especially last 3 >>> settings, as found that the test hung if using vm option >>> "-XX:+ExplicitGCInvokesConcurrent" with one of 3 options >>> -XX:+UseG1GC, -XX:+UseConcMarkSweepGC or -Xconcgc >>> >>> 2. for L61, that is right, the test has been updated. please review. >>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>> >>> >>> Thanks, >>> Eric >>> On 2013/11/26 8:37, Mandy Chung wrote: >>>> Hi Eric, >>>> >>>> On 11/24/2013 7:41 PM, Eric Wang wrote: >>>>> Hi Mandy & All, >>>>> >>>>> Sorry for late! >>>>> The webrev below is just finished based on the comments from >>>>> peers, please help to review. >>>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>>>> >>>>> >>>> >>>> Thanks for the patch that looks okay. Some comments: >>>> >>>> L34-40: can you explain why you want to run all 7 settings? I would >>>> expect one for each collector. >>>> L61: I think the static checker variable is meant to be a local >>>> variable (and looks like "pools" and "managers" don't need to be >>>> static variable). >>>> >>>> Mandy >>>> >>>>> Thanks, >>>>> Eric >>>>> On 2013/11/15 10:55, Mandy Chung wrote: >>>>>> Hi Eric, >>>>>> >>>>>> On 11/14/2013 6:16 PM, Eric Wang wrote: >>>>>>> Hi Everyone, >>>>>>> >>>>>>> I'm working on the bug >>>>>>> https://bugs.openjdk.java.net/browse/JDK-7067973. >>>>>>> >>>>>>> It is a test bug as the test doesn't guarantee memory allocated >>>>>>> from the Old Gen, if the used memory is zero and doesn't cross >>>>>>> the threshold, no notification is sent, so both the main thread >>>>>>> and Checker thread are blocked to wait for the GC notification. >>>>>>> >>>>>>> so the suggested fix is similar as the fix >>>>>>> ResetPeakMemoryUsage.java >>>>>>> to >>>>>>> create big object to make sure the old gen usage crosses the >>>>>>> threshold and run test with different GC vmoptions. >>>>>> >>>>>> What are you looking for specifically? I have provided the above >>>>>> information. I need to see the webrev to provide further feedback. >>>>>> >>>>>> Mandy >>>>> >>>> >>> >> > -- Leonid Mesnik JVM SQE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131128/1e803854/attachment.html From markus.gronlund at oracle.com Thu Nov 28 02:42:53 2013 From: markus.gronlund at oracle.com (Markus Gronlund) Date: Thu, 28 Nov 2013 02:42:53 -0800 (PST) Subject: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 In-Reply-To: <52963406.1050200@oracle.com> References: <3ee2cce7-8c32-448f-b1c0-252df5996516@default> <52963406.1050200@oracle.com> Message-ID: Hi Vladimir, Thanks for taking a look. I have updated the bug with a link to 8005849, thanks. "Is it possible to prepare a jtreg test which will use AsynchGetCallTrace and catch such situations in a future?" I agree that having a way to check for regression here would be ideal. I also realize that creating reliable regression tests for this part of the code is a non-trivial undertaking. For example, the code showing this particular regression needs to be a call tree with intertwined Java/JNI/native code. For one, a regression test for AsyncGetCallTrace needs, besides logic for AsyncGetCallTrace thread suspension itself, also involve a target using native code, and this means compiling native code etc etc.... I will create a separate bug/enhancement to track investigation efforts as to what kind of regression tests can be done here (maybe the native parts can be done in the VM itself and then using RegisterNatives() to hook up a test case...hmm...) Thanks again for reviewing /Markus -----Original Message----- From: Vladimir Kozlov Sent: den 27 november 2013 19:04 To: Markus Gronlund; hotspot-compiler-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net; serviceability-dev Subject: Re: RFR(S): 8028412 - AsyncGetCallTrace() is broken on x86 in JDK7u40 Hi, Markus I think the bug report should link to 8005849 which introduced this additional check and regression. Is it possible to prepare a jtreg test which will use AsynchGetCallTrace and catch such situations in a future? The fix itself looks good. Thanks, Vladimir On 11/27/13 1:47 AM, Markus Gronlund wrote: > Greetings, > > Kindly asking for reviews for the following change: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028412 > > Webrev: http://cr.openjdk.java.net/~mgronlun/8028412/webrev01/ > > Description: > > AsynchGetCallTrace() uses platform specific code for stack frame traversals. > > On x86, there currently exist a defensive construct that practically > disallows stack traversal over entry_frame code stubs, such as > StubRoutine(1) frames: > > src/cpu/x86/vm/frame_x86.cpp b/src/cpu/x86/vm/frame_x86.cpp: > > bool frame::safe_for_sender(JavaThread* thread) { > > . > > if (!Interpreter::contains(_pc) && _cb->frame_size() <= 0) { > //assert(0, "Invalid frame_size"); > > return false; > } > > . > > Since entry frames (such as StubRoutine(1)) have a frame size of 0, > the code returns prematurely. > > Fix is to move this frame size check post handling of is_entry_frame(), > where the code_stubs are processed. > > Testing completed: > > Sun Studio Profiler reproducer testcase > > SpecJBB2005 > > Kitchensink > > Thanks > Markus > From staffan.larsen at oracle.com Thu Nov 28 04:33:48 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 28 Nov 2013 13:33:48 +0100 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <52971801.6010905@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> <5292C6E3.4050101@oracle.com> <5293ED67.9010406@oracle.com> <52942965.40102@oracle.com> <52955625.4050907@oracle.com> <5296D2C1.3080209@oracle.com> <52971801.6010905@oracle.com> Message-ID: <577D3085-FB34-4623-8F2F-6C001799A002@oracle.com> On 28 nov 2013, at 11:16, Leonid Mesnik wrote: > Eric, Mandy > > Sorry that I looping on very late step. It is not a review just suggestion. > We have whitebox API in Hotspot which includes fullGC() method. It could be used to reliably provoke full GC. > See example in http://hg.openjdk.java.net/jdk8/tl/hotspot/file/c9f439732b18/test/runtime/interned/SanityTest.java > > Should such approach works for you? It?s not necessary. System.gc is implemented as a full GC for all of our GC implementations. I don?t think there is a problem in relying on that fact. > > Also please note that your new variant of test fails if any of GC is set explicitly. It is incompatible with GC setting. > We set GC's and GC-related options during Promotion/Nightly/PIT in Hotspot/SVC. For us is better if test just works > with any GC set externally. This is broken (as has been discussed many times). Tests *need* to be able to provide their own flags without someone overriding them and still expecting the test to work. /Staffan > > Do you need to run it with all GC each time? > > Leonid > On 11/28/2013 09:21 AM, Eric Wang wrote: >> Hi Mandy, >> >> Yes, I have tested and all settings are passed, as you mentioned the test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent and default heap size as no GC happens on Old Gen. That is why to add -Xmx2m and big object to make sure GC happens. >> >> I didn't realized the -Xconcgc is same as -XX:+UseConcMarkSweepGC, i have updated the webrev: >> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >> >> Thanks, >> Eric >> On 2013/11/27 10:17, Mandy Chung wrote: >>> Hi Eric, >>> >>> I'll defer this to the serviceability team to sponsor it and also get one more review. >>> >>> I don't think you need all 7 @runs. -Xconcgc is equivalent to setting -XX:+UseConcMarkSweepGC. For G1 and CMS, you should use -XX:+ExplicitGCInvokesConcurrent so that System.gc will force a GC in foreground that you can count the GC reliably. The test wants to get notified for each System.gc and if there is any GC caused by allocation failure, the test would fail due to the unexpected GC count. It seems that you may run into this issue setting -Xmx2m. >>> >>> Have you got the test passed in all settings? I'm seeing that the test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent without -Xmx2m. Looks like there is no GC in the old gen - I'm not familiar with G1 if it allocates the big object in the old gen. Jarolsav - can you help Eric diagnose this issue? I recalled you ran into something like that before - maybe Staffan? >>> >>> thanks >>> Mandy >>> >>> On 11/25/2013 8:53 PM, Eric Wang wrote: >>>> Hi Mandy, >>>> >>>> 1. for L34-40, executing tests with 7 settings is trying to cover more cases (normal cases and special cases), especially last 3 settings, as found that the test hung if using vm option "-XX:+ExplicitGCInvokesConcurrent" with one of 3 options -XX:+UseG1GC, -XX:+UseConcMarkSweepGC or -Xconcgc >>>> >>>> 2. for L61, that is right, the test has been updated. please review. >>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>>> >>>> Thanks, >>>> Eric >>>> On 2013/11/26 8:37, Mandy Chung wrote: >>>>> Hi Eric, >>>>> >>>>> On 11/24/2013 7:41 PM, Eric Wang wrote: >>>>>> Hi Mandy & All, >>>>>> >>>>>> Sorry for late! >>>>>> The webrev below is just finished based on the comments from peers, please help to review. >>>>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>>>>> >>>>> >>>>> Thanks for the patch that looks okay. Some comments: >>>>> >>>>> L34-40: can you explain why you want to run all 7 settings? I would expect one for each collector. >>>>> L61: I think the static checker variable is meant to be a local variable (and looks like "pools" and "managers" don't need to be static variable). >>>>> >>>>> Mandy >>>>> >>>>>> Thanks, >>>>>> Eric >>>>>> On 2013/11/15 10:55, Mandy Chung wrote: >>>>>>> Hi Eric, >>>>>>> >>>>>>> On 11/14/2013 6:16 PM, Eric Wang wrote: >>>>>>>> Hi Everyone, >>>>>>>> >>>>>>>> I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. >>>>>>>> >>>>>>>> It is a test bug as the test doesn't guarantee memory allocated from the Old Gen, if the used memory is zero and doesn't cross the threshold, no notification is sent, so both the main thread and Checker thread are blocked to wait for the GC notification. >>>>>>>> >>>>>>>> so the suggested fix is similar as the fix ResetPeakMemoryUsage.java to create big object to make sure the old gen usage crosses the threshold and run test with different GC vmoptions. >>>>>>> >>>>>>> What are you looking for specifically? I have provided the above information. I need to see the webrev to provide further feedback. >>>>>>> >>>>>>> Mandy >>>>>> >>>>> >>>> >>> >> > > > -- > Leonid Mesnik > JVM SQE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131128/4f170bce/attachment-0001.html From mattias.tobiasson at oracle.com Thu Nov 28 04:56:47 2013 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Thu, 28 Nov 2013 04:56:47 -0800 (PST) Subject: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Message-ID: <4a6b7b07-eb55-48b1-9d0c-086a8fa2c3a5@default> The change has been updated after review. Current summary of changes: 1. To avoid the complication of shared archives, the test now uses a dummy class for the retransform test. A new bug has been created for the possible problem of transforming classes loaded from archive: https://bugs.openjdk.java.net/browse/JDK-8029334 2. Removed all bash scripts. 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. 4. Added some utility functions to jdk/testlibrary. webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.03/ bug: https://bugs.openjdk.java.net/browse/JDK-6461635 Mattias ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com Cc: daniel.daugherty at oracle.com, serviceability-dev at openjdk.java.net, david.holmes at oracle.com Sent: Thursday, November 28, 2013 11:02:30 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Mattias On 11/28/2013 01:48 PM, Mattias Tobiasson wrote: Is it ok if I check in the current test as it is now, and add a new bug for the (possible) problem of retransforming classes from the shared archive? It is ok if you check current test which redefine non-shared class and add new bug about shared transformation. The usage of non-shared class is cleaner rather disabling sharing explicitly. However you still need a review for this fix. Reasons for why I want to check in the current test as it is are: The purpose of the current test is not about the shared archive and is already quite large. A simpler reproducer could be used for the new bug. I think it would be better to add more testcases into this test or more tests with similar but different scenarios. The new tests could be part of fix of new issue which you are going to file. Leonid The new bug may not even be a bug, but working as expected. I want someone else to look at the bug before adding a new test. This fix also contains updates for the testlibrary that are needed for other tests. This bug was reported in 2006, so it is not a regression in jdk8. Mattias ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com , david.holmes at oracle.com Cc: serviceability-dev at openjdk.java.net , daniel.daugherty at oracle.com Sent: Wednesday, November 27, 2013 4:15:09 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently I think test should test instrumentation of custom, JDK, JDK shared classes as a part of scenario. This is how tools could use this mechanism. May be I am wrong. Also I found ? JDK-5002268 Allow class sharing use with RedefineClasses which allow to redefine of classes when class sharing is used. I don't exactly know should it work for j.l.instrument as well as for JVMTI Dan Could you please help us with this? Is it a legal scenario to redefine shared classes? Leonid On 11/27/2013 03:46 PM, Mattias Tobiasson wrote: According to the test documentation and bug references the test verifies the manifest attribute "Can-Redefine-Classes". The test does not mention shared class archive or -Xshare. But maybe the test has found a problem accidentally... Mattias ----- Original Message ----- From: david.holmes at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 27, 2013 12:21:50 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently On 27/11/2013 8:46 PM, Mattias Tobiasson wrote: Hi, I now have a reproducer for this test that fails every time. I just need to verify that it really is a test bug and not a product bug. This is a summary of the test: 1. It loads a javaagent jar that implements ClassFileTransformer. 2. The agent loads class java.math.BigInteger and expects a callback to ClassFileTransformer.transform(). But it sometimes does not get that callback. I believe the reason for the intermittent failures are that the jvm flag -Xshare have different default values on different servers. -Xshare:auto will default to off for server compiler, but on for client When the reproducer is run with flag "-Xshare:off" it passes every time. When run with "-Xshare:auto" it fails every time. When the reproducer is changed to use a dummy class (RedefineDummy) instead of BigInteger, then the test passes every time no matter what value -Xshare has. My proposed fix for the bug is to use a dummy class instead of BigInteger. I just need to verify that it is ok that ClassFileTransformer.transform() is NOT called for BigInteger when -Xshare is enabled. If the whole point of the test is to transform a file from the shared archive then changing to a class not in the archive will defeat that. So you need to verify what the intent of the test is. David The reproducer is shown below. It loads the javaagent into its own vm so I don't need to set up multiple jvms. public class TestRedefine implements ClassFileTransformer { public static void agentmain(String agentArgs, Instrumentation inst) throws Throwable { try { inst.addTransformer(new TestRedefine()); ClassLoader.getSystemClassLoader().loadClass("java.math.BigInteger"); if (!isTransformCalled) { throw new Exception("transform() NOT called for " + targetName); } } catch (Throwable t) { t.printStackTrace(); throw t; } } public byte[] transform(ClassLoader loader, String className, Class classBeingRedefined, ProtectionDomain protectionDomain, byte[] classfileBuffer) { System.out.println("transform called: " + className); if (className.equals("java/math/BigInteger")) { isTransformCalled = true; } return null; } public static void main(String args[]) throws Exception { String pid = getProcessId(); try { VirtualMachine vm = VirtualMachine.attach(pid); vm.loadAgent("TestRedefine.jar"); } catch (Exception e) { e.printStackTrace(); throw e; } } ... more code ... } ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 27, 2013 9:19:37 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Hi Generally I am ok with your comments and fix. However you still needed to get official review. The only question is about failure related from retransformation of j.l.BigInteger with CDS. Could it be JDK issue? In this case it would be better to file it as a part of fix. I understand that using of CDS and instrumentation of JDK classes is not related with this test and your fix make it cleaner. However could you please verify that we don't have JDK issue here. see other comments inline On 11/26/2013 08:35 PM, Mattias Tobiasson wrote: Hi, Thanks for the review. I have summarized the questions and answers: Q: What is the reason of this intermittent failure? A: The test expects the callback ClassFileTransformer.transform() to be called when it loads a new class. That function does not seem to be called when class sharing is enabled and a previous test has called "-Xshare:dump". I am not really sure how ClassFileTransformer works together with class sharing. I got the idea for -Xshare:dump from this bug: https://bugs.openjdk.java.net/browse/JDK-6571866 I have verified on jprt that it fails without that flag. I have not been able to reproduce a failure when -Xshare:off is set. Having thought more about the problem, I would like to use another fix. The test currently uses java.lang.BigInteger for the transform test. I want to change that and instead use my own class (RedefineDummy.java). Since loading my own class is not affected by -Xshare, I do not need to set the flag. Q: You used "output" in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? A: output is only sent to getProcessLog() to get a log message. That function can handle null values, which it just logs as "null". Thank you for explanation. Q: In getCommandLine(), should we also trim cmd to remove last " "? A: Yes. I will fix that. I will also add a check if ProcessBuilder is null. Ok Q: waitForJvmPid(String key) throws Throwable. Why throw throwable? A: I think there are so many things that can go wrong when starting a separate java process, that I do not want to check for expected errors. I also don't know how a test writer should handle different kind of exceptions from this function. Any exception is logged in the sub function. Q: Should tryFindJvmPid(String key) be private? Are we going to use it in tests or only waitForJvmPid? A: Yes, that function may also be used by tests. It is currently not used by any test, but it might be useful. Ok Q: Timeouts in function waitForJvmPid(String key)? A: I definitely agree of the problem. The reason for not adding a timeout parameter to the function is that I do not want the tests to be responsible for setting hard coded timeouts. Timeouts should be handled by the framework. I know there are plans of adding better process handling to jtreg (with ProcessHandler). After that jtreg should be better at handling timeouts. I will add a flush() to stdout to make sure we log before we wait. Hope we will update jtreg before get into this issue :) Leonid Mattias ----- Original Message ----- From: leonid.mesnik at oracle.com To: mattias.tobiasson at oracle.com , serviceability-dev at openjdk.java.net Sent: Monday, November 25, 2013 6:26:27 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Hi I have a couple of high-level questions. On 11/25/2013 08:28 PM, Mattias Tobiasson wrote: Hi, The test has been updated after the first review. The two java files for each test has been merged to a single file. Updated summary of changes: 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. What is the reason of this intermittent failure? 2. Removed all bash scripts. Great! 3. Merged the setup bash script and the java test code for each test to a single java file. The old java test code is unchanged, it has just been moved to static nested class in the new java setup file. 4. Added some utility functions to jdk/testlibrary. Here some comments about library code. http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessThread.java.udiff.html + try { + output = new OutputAnalyzer(this.process); + } catch (Throwable t) { + String name = Thread.currentThread().getName(); + System.out.println(String.format("ProcessThread[%s] failed: %s", name, t.toString())); + throw t; + } finally { + String logMsg = ProcessTools.getProcessLog(processBuilder, output); + System.out.println(logMsg); + } You used output in finally which is not initialized properly in the case of Exception. Could we get another uncaught exception in finally? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/ProcessTools.java.udiff.html 1) Same in as previous in executeProcess method. 2) getCommandLine (...) + /** + * @return The full command line for the ProcessBuilder. + */ + public static String getCommandLine(ProcessBuilder pb) { + StringBuilder cmd = new StringBuilder(); + for (String s : pb.command()) { + cmd.append(s).append(" "); + } + return cmd.toString(); + } Should we also trim cmd to remove last " "? http://cr.openjdk.java.net/~miauno/6461635/webrev.01/jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java.udiff.html public static int waitForJvmPid(String key) throws Throwable { Why it throw Trowable? Could we deal with exceptions in this method and re-throw some more meaningful exception here? Could you force flush for out here: System.out.println("waitForJvmPid: Waiting for key '" + key + "'"); Hope it should be enough. It is scary to investigate such "timeouts". Would it be better to add some internal timeout in testlibrary? Really jtreg doesn't kill all processes and we have alive java processes in such case. For samevm tests timeouts are even worse. There is no good way to kill test in samevm. Should be public static int tryFindJvmPid(String key) throws Throwable { private? Are we going to use it in tests or only waitForJvmPid? Leonid 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. Webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-6461635 Mattias ----- Original Message ----- From: mattias.tobiasson at oracle.com To: mikael.auno at oracle.com Cc: serviceability-dev at openjdk.java.net , Alan.Bateman at oracle.com Sent: Thursday, November 21, 2013 9:22:11 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently I agree that merging both files in a single file may be good. The main reason why I did not do that is that I wanted to keep the history of the existing test. If I copy the test to a new file, all history of the code is lost. But this test bug was reported 8 years ago, and I don't believe much has changed in the code since then. So keeping the history may not be that important. Mattias ----- Original Message ----- From: mikael.auno at oracle.com To: mattias.tobiasson at oracle.com , Alan.Bateman at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 20, 2013 4:11:45 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently How about defining the class that you want to attach to as a static inner class to the actual test? That would give you only one file, but with two classes, each with its own main method and clear correlation between them. Mikael On 2013-11-20 15:41, Mattias Tobiasson wrote: Hi, Each test requires 2 files, the actual test code and a helper file. The helper file will launch a separate java process (called Application), and then start the actual test. The actual test will then attach to the Application. For example: PermissionTests.sh: Helper file that will launch Application instance and then start PermissionTest.java PermissionTest.java: The actual test code that attaches to the Application. It is the PermissionTests.sh that is started by jtreg (contains the "@test"-tag). When I port PermissionTest.sh to java I would get 2 files called PermissionTest.java, so some name change is required. I could have kept the old PermissionTest.java unchanged, but then I would need another name for the prevoius PermissionTest.sh. And I wanted a "clean" Test name for the file containing the "@test"-tag. I used these names: TestPermission.java: Helper file. TestPermissionImpl.java: Actual test code. I am still new to adding tests for open jdk. I am happy to change the names if they do not follow the naming convention. Mattias ----- Original Message ----- From: Alan.Bateman at oracle.com To: mattias.tobiasson at oracle.com Cc: serviceability-dev at openjdk.java.net Sent: Wednesday, November 20, 2013 2:50:52 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently Out of curiosity, what is the reason for the rename? I ask because we use Basic and similar names in many areas. Also anything in the test tree should be a test. -Alan. On 20/11/2013 13:47, Mattias Tobiasson wrote: Hi, Could you please review this fix. Summary of changes: 1. The real test bug fix is to add flag "-Xshare:off" when starting the "Application" instance. Without that flag, the test for ClassFileTransformer in RedefineAgent.java fails intermittently. The flag is added in function startApplication() in RunnerUtil.java. 2. Ported the following bash scripts to java: BasicTests.sh -> TestBasic.java PermissionTests.sh -> TestPermission.java ProviderTests.sh -> TestProvider.java 3. Renamed the java test code to avoid name clash with new java classes ported from bash script: BasicsTest.java -> TestBasicImpl.java PermissionTest.java -> TestPermissionImpl.java ProviderTest.java -> TestProviderImpl.java 4. Added some utility functions to jdk/testlibrary. 5. Moved exit code check from the common utility function in ProcessThread.java to the test JstatdTest.java. The check is moved to the test because other tests in the future may have other expected exit codes. Thanks, Mattias Webrev: http://cr.openjdk.java.net/~miauno/6461635/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-6461635 -- Leonid Mesnik JVM SQE -- Leonid Mesnik JVM SQE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131128/d847c843/attachment-0001.html From mikael.gerdin at oracle.com Thu Nov 28 05:06:52 2013 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Thu, 28 Nov 2013 14:06:52 +0100 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <577D3085-FB34-4623-8F2F-6C001799A002@oracle.com> References: <52858405.2090809@oracle.com> <52971801.6010905@oracle.com> <577D3085-FB34-4623-8F2F-6C001799A002@oracle.com> Message-ID: <2359532.Kelx54AFsm@mgerdin03> On Thursday 28 November 2013 13.33.48 Staffan Larsen wrote: > On 28 nov 2013, at 11:16, Leonid Mesnik wrote: > > Eric, Mandy > > > > Sorry that I looping on very late step. It is not a review just > > suggestion. > > We have whitebox API in Hotspot which includes fullGC() method. It could > > be used to reliably provoke full GC. See example in > > http://hg.openjdk.java.net/jdk8/tl/hotspot/file/c9f439732b18/test/runtime > > /interned/SanityTest.java > > > > Should such approach works for you? > > It?s not necessary. System.gc is implemented as a full GC for all of our GC > implementations. I don?t think there is a problem in relying on that fact. F?rutom om SQE injicerar commandline-flaggor i tester, typ -XX: +ExplicitGCInvokesConcurrent, eller rentav -XX:+DisableExpicitGC... tycker inte att ni ska ?ndra till WBapi-fullgc, men det ?r nog d?rifr?n Leonid kommer. /m > > Also please note that your new variant of test fails if any of GC is set > > explicitly. It is incompatible with GC setting. We set GC's and > > GC-related options during Promotion/Nightly/PIT in Hotspot/SVC. For us is > > better if test just works with any GC set externally. > > This is broken (as has been discussed many times). Tests *need* to be able > to provide their own flags without someone overriding them and still > expecting the test to work. > > /Staffan > > > Do you need to run it with all GC each time? > > > > Leonid > > > > On 11/28/2013 09:21 AM, Eric Wang wrote: > >> Hi Mandy, > >> > >> Yes, I have tested and all settings are passed, as you mentioned the test > >> hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent and default > >> heap size as no GC happens on Old Gen. That is why to add -Xmx2m and big > >> object to make sure GC happens. > >> > >> I didn't realized the -Xconcgc is same as -XX:+UseConcMarkSweepGC, i have > >> updated the webrev: > >> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ > >> > >> Thanks, > >> Eric > >> > >> On 2013/11/27 10:17, Mandy Chung wrote: > >>> Hi Eric, > >>> > >>> I'll defer this to the serviceability team to sponsor it and also get > >>> one more review. > >>> > >>> I don't think you need all 7 @runs. -Xconcgc is equivalent to setting > >>> -XX:+UseConcMarkSweepGC. For G1 and CMS, you should use > >>> -XX:+ExplicitGCInvokesConcurrent so that System.gc will force a GC in > >>> foreground that you can count the GC reliably. The test wants to get > >>> notified for each System.gc and if there is any GC caused by allocation > >>> failure, the test would fail due to the unexpected GC count. It seems > >>> that you may run into this issue setting -Xmx2m. > >>> > >>> Have you got the test passed in all settings? I'm seeing that the test > >>> hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent without > >>> -Xmx2m. Looks like there is no GC in the old gen - I'm not familiar > >>> with G1 if it allocates the big object in the old gen. Jarolsav - can > >>> you help Eric diagnose this issue? I recalled you ran into something > >>> like that before - maybe Staffan? > >>> > >>> thanks > >>> Mandy > >>> > >>> On 11/25/2013 8:53 PM, Eric Wang wrote: > >>>> Hi Mandy, > >>>> > >>>> 1. for L34-40, executing tests with 7 settings is trying to cover more > >>>> cases (normal cases and special cases), especially last 3 settings, as > >>>> found that the test hung if using vm option > >>>> "-XX:+ExplicitGCInvokesConcurrent" with one of 3 options -XX:+UseG1GC, > >>>> -XX:+UseConcMarkSweepGC or -Xconcgc > >>>> > >>>> 2. for L61, that is right, the test has been updated. please review. > >>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ > >>>> > >>>> Thanks, > >>>> Eric > >>>> > >>>> On 2013/11/26 8:37, Mandy Chung wrote: > >>>>> Hi Eric, > >>>>> > >>>>> On 11/24/2013 7:41 PM, Eric Wang wrote: > >>>>>> Hi Mandy & All, > >>>>>> > >>>>>> Sorry for late! > >>>>>> The webrev below is just finished based on the comments from peers, > >>>>>> please help to review. > >>>>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ > >>>>> > >>>>> Thanks for the patch that looks okay. Some comments: > >>>>> > >>>>> L34-40: can you explain why you want to run all 7 settings? I would > >>>>> expect one for each collector. L61: I think the static checker > >>>>> variable is meant to be a local variable (and looks like "pools" and > >>>>> "managers" don't need to be static variable). > >>>>> > >>>>> Mandy > >>>>> > >>>>>> Thanks, > >>>>>> Eric > >>>>>> > >>>>>> On 2013/11/15 10:55, Mandy Chung wrote: > >>>>>>> Hi Eric, > >>>>>>> > >>>>>>> On 11/14/2013 6:16 PM, Eric Wang wrote: > >>>>>>>> Hi Everyone, > >>>>>>>> > >>>>>>>> I'm working on the bug > >>>>>>>> https://bugs.openjdk.java.net/browse/JDK-7067973. > >>>>>>>> > >>>>>>>> It is a test bug as the test doesn't guarantee memory allocated > >>>>>>>> from the Old Gen, if the used memory is zero and doesn't cross the > >>>>>>>> threshold, no notification is sent, so both the main thread and > >>>>>>>> Checker thread are blocked to wait for the GC notification. > >>>>>>>> > >>>>>>>> so the suggested fix is similar as the fix > >>>>>>>> ResetPeakMemoryUsage.java to create big object to make sure the > >>>>>>>> old gen usage crosses the threshold and run test with different GC > >>>>>>>> vmoptions.>>>>>>> > >>>>>>> What are you looking for specifically? I have provided the above > >>>>>>> information. I need to see the webrev to provide further feedback. > >>>>>>> > >>>>>>> Mandy From leonid.mesnik at oracle.com Thu Nov 28 06:17:24 2013 From: leonid.mesnik at oracle.com (Leonid Mesnik) Date: Thu, 28 Nov 2013 18:17:24 +0400 Subject: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently In-Reply-To: <577D3085-FB34-4623-8F2F-6C001799A002@oracle.com> References: <52858405.2090809@oracle.com> <52858D04.3080206@oracle.com> <5292C6E3.4050101@oracle.com> <5293ED67.9010406@oracle.com> <52942965.40102@oracle.com> <52955625.4050907@oracle.com> <5296D2C1.3080209@oracle.com> <52971801.6010905@oracle.com> <577D3085-FB34-4623-8F2F-6C001799A002@oracle.com> Message-ID: <52975074.5070208@oracle.com> On 11/28/2013 04:33 PM, Staffan Larsen wrote: > > On 28 nov 2013, at 11:16, Leonid Mesnik > wrote: > >> Eric, Mandy >> >> Sorry that I looping on very late step. It is not a review just >> suggestion. >> We have whitebox API in Hotspot which includes fullGC() method. It >> could be used to reliably provoke full GC. >> See example in >> http://hg.openjdk.java.net/jdk8/tl/hotspot/file/c9f439732b18/test/runtime/interned/SanityTest.java >> >> Should such approach works for you? > > It?s not necessary. System.gc is implemented as a full GC for all of > our GC implementations. I don?t think there is a problem in relying on > that fact. > >> >> Also please note that your new variant of test fails if any of GC is >> set explicitly. It is incompatible with GC setting. >> We set GC's and GC-related options during Promotion/Nightly/PIT in >> Hotspot/SVC. For us is better if test just works >> with any GC set externally. > > This is broken (as has been discussed many times). Tests *need* to be > able to provide their own flags without someone overriding them and > still expecting the test to work. > I agree that this is not good however it is how all works now. There are several proposals about jtreg improvement but they are not implemented yet. Leonid > /Staffan > >> >> Do you need to run it with all GC each time? >> >> Leonid >> On 11/28/2013 09:21 AM, Eric Wang wrote: >>> Hi Mandy, >>> >>> Yes, I have tested and all settings are passed, as you mentioned the >>> test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent and >>> default heap size as no GC happens on Old Gen. That is why to add >>> -Xmx2m and big object to make sure GC happens. >>> >>> I didn't realized the -Xconcgc is same as -XX:+UseConcMarkSweepGC, i >>> have updated the webrev: >>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>> >>> >>> Thanks, >>> Eric >>> On 2013/11/27 10:17, Mandy Chung wrote: >>>> Hi Eric, >>>> >>>> I'll defer this to the serviceability team to sponsor it and also >>>> get one more review. >>>> >>>> I don't think you need all 7 @runs. -Xconcgc is equivalent to >>>> setting -XX:+UseConcMarkSweepGC. For G1 and CMS, you should use >>>> -XX:+ExplicitGCInvokesConcurrent so that System.gc will force a GC >>>> in foreground that you can count the GC reliably. The test wants to >>>> get notified for each System.gc and if there is any GC caused by >>>> allocation failure, the test would fail due to the unexpected GC >>>> count. It seems that you may run into this issue setting -Xmx2m. >>>> >>>> Have you got the test passed in all settings? I'm seeing that the >>>> test hangs with -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent >>>> without -Xmx2m. Looks like there is no GC in the old gen - I'm not >>>> familiar with G1 if it allocates the big object in the old gen. >>>> Jarolsav - can you help Eric diagnose this issue? I recalled you >>>> ran into something like that before - maybe Staffan? >>>> >>>> thanks >>>> Mandy >>>> >>>> On 11/25/2013 8:53 PM, Eric Wang wrote: >>>>> Hi Mandy, >>>>> >>>>> 1. for L34-40, executing tests with 7 settings is trying to cover >>>>> more cases (normal cases and special cases), especially last 3 >>>>> settings, as found that the test hung if using vm option >>>>> "-XX:+ExplicitGCInvokesConcurrent" with one of 3 options >>>>> -XX:+UseG1GC, -XX:+UseConcMarkSweepGC or -Xconcgc >>>>> >>>>> 2. for L61, that is right, the test has been updated. please review. >>>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>>>> >>>>> >>>>> Thanks, >>>>> Eric >>>>> On 2013/11/26 8:37, Mandy Chung wrote: >>>>>> Hi Eric, >>>>>> >>>>>> On 11/24/2013 7:41 PM, Eric Wang wrote: >>>>>>> Hi Mandy & All, >>>>>>> >>>>>>> Sorry for late! >>>>>>> The webrev below is just finished based on the comments from >>>>>>> peers, please help to review. >>>>>>> http://cr.openjdk.java.net/~ewang/JDK-7067973/webrev.00/ >>>>>>> >>>>>>> >>>>>> >>>>>> Thanks for the patch that looks okay. Some comments: >>>>>> >>>>>> L34-40: can you explain why you want to run all 7 settings? I >>>>>> would expect one for each collector. >>>>>> L61: I think the static checker variable is meant to be a local >>>>>> variable (and looks like "pools" and "managers" don't need to be >>>>>> static variable). >>>>>> >>>>>> Mandy >>>>>> >>>>>>> Thanks, >>>>>>> Eric >>>>>>> On 2013/11/15 10:55, Mandy Chung wrote: >>>>>>>> Hi Eric, >>>>>>>> >>>>>>>> On 11/14/2013 6:16 PM, Eric Wang wrote: >>>>>>>>> Hi Everyone, >>>>>>>>> >>>>>>>>> I'm working on the bug >>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-7067973. >>>>>>>>> >>>>>>>>> It is a test bug as the test doesn't guarantee memory >>>>>>>>> allocated from the Old Gen, if the used memory is zero and >>>>>>>>> doesn't cross the threshold, no notification is sent, so both >>>>>>>>> the main thread and Checker thread are blocked to wait for the >>>>>>>>> GC notification. >>>>>>>>> >>>>>>>>> so the suggested fix is similar as the fix >>>>>>>>> ResetPeakMemoryUsage.java >>>>>>>>> to >>>>>>>>> create big object to make sure the old gen usage crosses the >>>>>>>>> threshold and run test with different GC vmoptions. >>>>>>>> >>>>>>>> What are you looking for specifically? I have provided the >>>>>>>> above information. I need to see the webrev to provide further >>>>>>>> feedback. >>>>>>>> >>>>>>>> Mandy >>>>>>> >>>>>> >>>>> >>>> >>> >> >> >> -- >> Leonid Mesnik >> JVM SQE > -- Leonid Mesnik JVM SQE -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131128/f3d7c354/attachment-0001.html From john.coomes at oracle.com Thu Nov 28 11:14:51 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 28 Nov 2013 19:14:51 +0000 Subject: hg: hsx/hotspot-rt: Added tag jdk8-b118 for changeset 0a6db1aac998 Message-ID: <20131128191451.4CDEA6291D@hg.openjdk.java.net> Changeset: 06d512d44c31 Author: cl Date: 2013-11-28 08:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/06d512d44c31 Added tag jdk8-b118 for changeset 0a6db1aac998 ! .hgtags From john.coomes at oracle.com Thu Nov 28 11:14:57 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 28 Nov 2013 19:14:57 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b118 for changeset d6820a414f18 Message-ID: <20131128191500.D9A8C6291E@hg.openjdk.java.net> Changeset: 5029f982dfae Author: cl Date: 2013-11-28 08:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/5029f982dfae Added tag jdk8-b118 for changeset d6820a414f18 ! .hgtags From john.coomes at oracle.com Thu Nov 28 11:15:09 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 28 Nov 2013 19:15:09 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b118 for changeset e4e5069250e7 Message-ID: <20131128191522.1C82F6291F@hg.openjdk.java.net> Changeset: 6b37ae056340 Author: cl Date: 2013-11-28 08:23 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6b37ae056340 Added tag jdk8-b118 for changeset e4e5069250e7 ! .hgtags From john.coomes at oracle.com Thu Nov 28 11:15:31 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 28 Nov 2013 19:15:31 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b118 for changeset 76a598cf50c4 Message-ID: <20131128191540.A2B7C62920@hg.openjdk.java.net> Changeset: 7ac7d1afd966 Author: cl Date: 2013-11-28 08:23 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/7ac7d1afd966 Added tag jdk8-b118 for changeset 76a598cf50c4 ! .hgtags From john.coomes at oracle.com Thu Nov 28 11:16:00 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 28 Nov 2013 19:16:00 +0000 Subject: hg: hsx/hotspot-rt/jdk: 4 new changesets Message-ID: <20131128191808.9D50462921@hg.openjdk.java.net> Changeset: 6c1f5c7baab0 Author: ksrini Date: 2013-11-21 12:01 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6c1f5c7baab0 8028645: [infra] purge applet demos from the Solaris distros Reviewed-by: erikj ! makefiles/CompileDemos.gmk Changeset: 66c98bd811f1 Author: rgallard Date: 2013-11-25 20:19 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/66c98bd811f1 8029043: Update nroff files for JDK 8 Reviewed-by: weijun, alanb, ksrini, naoto ! src/bsd/doc/man/appletviewer.1 ! src/bsd/doc/man/extcheck.1 ! src/bsd/doc/man/idlj.1 ! src/bsd/doc/man/jar.1 ! src/bsd/doc/man/jarsigner.1 ! src/bsd/doc/man/java.1 ! src/bsd/doc/man/javac.1 ! src/bsd/doc/man/javadoc.1 ! src/bsd/doc/man/javah.1 ! src/bsd/doc/man/javap.1 + src/bsd/doc/man/jcmd.1 ! src/bsd/doc/man/jconsole.1 ! src/bsd/doc/man/jdb.1 + src/bsd/doc/man/jdeps.1 ! src/bsd/doc/man/jhat.1 ! src/bsd/doc/man/jinfo.1 + src/bsd/doc/man/jjs.1 ! src/bsd/doc/man/jmap.1 ! src/bsd/doc/man/jps.1 ! src/bsd/doc/man/jrunscript.1 ! src/bsd/doc/man/jsadebugd.1 ! src/bsd/doc/man/jstack.1 ! src/bsd/doc/man/jstat.1 ! src/bsd/doc/man/jstatd.1 ! src/bsd/doc/man/keytool.1 ! src/bsd/doc/man/native2ascii.1 ! src/bsd/doc/man/orbd.1 ! src/bsd/doc/man/pack200.1 ! src/bsd/doc/man/policytool.1 ! src/bsd/doc/man/rmic.1 ! src/bsd/doc/man/rmid.1 ! src/bsd/doc/man/rmiregistry.1 ! src/bsd/doc/man/schemagen.1 ! src/bsd/doc/man/serialver.1 ! src/bsd/doc/man/servertool.1 ! src/bsd/doc/man/tnameserv.1 ! src/bsd/doc/man/unpack200.1 ! src/bsd/doc/man/wsgen.1 ! src/bsd/doc/man/wsimport.1 ! src/bsd/doc/man/xjc.1 ! src/linux/doc/man/appletviewer.1 ! src/linux/doc/man/extcheck.1 ! src/linux/doc/man/idlj.1 ! src/linux/doc/man/jar.1 ! src/linux/doc/man/jarsigner.1 ! src/linux/doc/man/java.1 ! src/linux/doc/man/javac.1 ! src/linux/doc/man/javadoc.1 ! src/linux/doc/man/javah.1 ! src/linux/doc/man/javap.1 ! src/linux/doc/man/jcmd.1 ! src/linux/doc/man/jconsole.1 ! src/linux/doc/man/jdb.1 + src/linux/doc/man/jdeps.1 ! src/linux/doc/man/jhat.1 ! src/linux/doc/man/jinfo.1 + src/linux/doc/man/jjs.1 ! src/linux/doc/man/jmap.1 ! src/linux/doc/man/jps.1 ! src/linux/doc/man/jrunscript.1 ! src/linux/doc/man/jsadebugd.1 ! src/linux/doc/man/jstack.1 ! src/linux/doc/man/jstat.1 ! src/linux/doc/man/jstatd.1 ! src/linux/doc/man/keytool.1 ! src/linux/doc/man/native2ascii.1 ! src/linux/doc/man/orbd.1 ! src/linux/doc/man/pack200.1 ! src/linux/doc/man/policytool.1 ! src/linux/doc/man/rmic.1 ! src/linux/doc/man/rmid.1 ! src/linux/doc/man/rmiregistry.1 ! src/linux/doc/man/schemagen.1 ! src/linux/doc/man/serialver.1 ! src/linux/doc/man/servertool.1 ! src/linux/doc/man/tnameserv.1 ! src/linux/doc/man/unpack200.1 ! src/linux/doc/man/wsgen.1 ! src/linux/doc/man/wsimport.1 ! src/linux/doc/man/xjc.1 ! src/solaris/doc/sun/man/man1/appletviewer.1 ! src/solaris/doc/sun/man/man1/extcheck.1 ! src/solaris/doc/sun/man/man1/idlj.1 ! src/solaris/doc/sun/man/man1/jar.1 ! src/solaris/doc/sun/man/man1/jarsigner.1 ! src/solaris/doc/sun/man/man1/java.1 ! src/solaris/doc/sun/man/man1/javac.1 ! src/solaris/doc/sun/man/man1/javadoc.1 ! src/solaris/doc/sun/man/man1/javah.1 ! src/solaris/doc/sun/man/man1/javap.1 ! src/solaris/doc/sun/man/man1/jcmd.1 ! src/solaris/doc/sun/man/man1/jconsole.1 ! src/solaris/doc/sun/man/man1/jdb.1 + src/solaris/doc/sun/man/man1/jdeps.1 ! src/solaris/doc/sun/man/man1/jhat.1 ! src/solaris/doc/sun/man/man1/jinfo.1 + src/solaris/doc/sun/man/man1/jjs.1 ! src/solaris/doc/sun/man/man1/jmap.1 ! src/solaris/doc/sun/man/man1/jps.1 ! src/solaris/doc/sun/man/man1/jrunscript.1 ! src/solaris/doc/sun/man/man1/jsadebugd.1 ! src/solaris/doc/sun/man/man1/jstack.1 ! src/solaris/doc/sun/man/man1/jstat.1 ! src/solaris/doc/sun/man/man1/jstatd.1 ! src/solaris/doc/sun/man/man1/keytool.1 ! src/solaris/doc/sun/man/man1/native2ascii.1 ! src/solaris/doc/sun/man/man1/orbd.1 ! src/solaris/doc/sun/man/man1/pack200.1 ! src/solaris/doc/sun/man/man1/policytool.1 ! src/solaris/doc/sun/man/man1/rmic.1 ! src/solaris/doc/sun/man/man1/rmid.1 ! src/solaris/doc/sun/man/man1/rmiregistry.1 ! src/solaris/doc/sun/man/man1/schemagen.1 ! src/solaris/doc/sun/man/man1/serialver.1 ! src/solaris/doc/sun/man/man1/servertool.1 ! src/solaris/doc/sun/man/man1/tnameserv.1 ! src/solaris/doc/sun/man/man1/unpack200.1 ! src/solaris/doc/sun/man/man1/wsgen.1 ! src/solaris/doc/sun/man/man1/wsimport.1 ! src/solaris/doc/sun/man/man1/xjc.1 Changeset: 28ca338366ff Author: rgallard Date: 2013-11-25 20:22 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/28ca338366ff Merge Changeset: a1c49f8881ae Author: cl Date: 2013-11-28 08:24 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a1c49f8881ae Added tag jdk8-b118 for changeset 28ca338366ff ! .hgtags From john.coomes at oracle.com Thu Nov 28 11:19:36 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 28 Nov 2013 19:19:36 +0000 Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b118 for changeset 4fd6a7ff8c06 Message-ID: <20131128191947.CFAD062922@hg.openjdk.java.net> Changeset: 1f6ffcd56363 Author: cl Date: 2013-11-28 08:24 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1f6ffcd56363 Added tag jdk8-b118 for changeset 4fd6a7ff8c06 ! .hgtags From john.coomes at oracle.com Thu Nov 28 11:19:58 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 28 Nov 2013 19:19:58 +0000 Subject: hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b118 for changeset 8d014b039b44 Message-ID: <20131128192004.E84AD62923@hg.openjdk.java.net> Changeset: b55a011cf8ae Author: cl Date: 2013-11-28 08:24 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b55a011cf8ae Added tag jdk8-b118 for changeset 8d014b039b44 ! .hgtags From chris.hegarty at oracle.com Fri Nov 29 01:26:20 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 29 Nov 2013 09:26:20 +0000 Subject: hg: jdk8/tl/jdk: 8029348: ProblemList.txt updates (11/2013) Message-ID: <20131129092634.5775662930@hg.openjdk.java.net> Changeset: 5bcaf730ceb8 Author: tyan Date: 2013-11-29 09:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bcaf730ceb8 8029348: ProblemList.txt updates (11/2013) Reviewed-by: chegar ! test/ProblemList.txt From ivan.gerasimov at oracle.com Fri Nov 29 12:59:10 2013 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Sat, 30 Nov 2013 00:59:10 +0400 Subject: RR(XS): JDK-6969276 minor memory leak detected by cppcheck in agent/src/os/linux/symtab.c In-Reply-To: <52938D9C.2060806@oracle.com> References: <52938D9C.2060806@oracle.com> Message-ID: <5299001E.9040205@oracle.com> Hi Dmitry! I think you should surround the if body with braces, or you'll get unconditional return from the function otherwise. 217 if (last_slash == NULL) 218 free(debug_pathname); 219 return -1; Should be 217 if (last_slash == NULL) { 218 free(debug_pathname); 219 return -1; 220 } Sincerely yours, Ivan On 25.11.2013 21:49, Dmitry Samersoff wrote: > Hi Everyone, > > Please review an XS fix - missed free() call discovered by cppcheck tool. > > http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/ > > -Dmitry > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131130/49415635/attachment.html From dmitry.samersoff at oracle.com Fri Nov 29 15:08:32 2013 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Sat, 30 Nov 2013 03:08:32 +0400 Subject: RR(XS): JDK-6969276 minor memory leak detected by cppcheck in agent/src/os/linux/symtab.c In-Reply-To: <5299001E.9040205@oracle.com> References: <52938D9C.2060806@oracle.com> <5299001E.9040205@oracle.com> Message-ID: <52991E70.8030800@oracle.com> Ivan, Good catch. Thank you! -Dmitry On 2013-11-30 00:59, Ivan Gerasimov wrote: > Hi Dmitry! > > I think you should surround the if body with braces, or you'll get > unconditional return from the function otherwise. > > 217 if (last_slash == NULL) > 218 free(debug_pathname); > 219 return -1; > > > Should be > > 217 if (last_slash == NULL) { > 218 free(debug_pathname); > 219 return -1; > 220 } > > > Sincerely yours, > Ivan > > > On 25.11.2013 21:49, Dmitry Samersoff wrote: >> Hi Everyone, >> >> Please review an XS fix - missed free() call discovered by cppcheck tool. >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-6969276/webrev.01/ >> >> -Dmitry >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources. From iris.clark at oracle.com Tue Nov 26 10:08:51 2013 From: iris.clark at oracle.com (Iris Clark) Date: Tue, 26 Nov 2013 10:08:51 -0800 (PST) Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <5294D453.5050402@oracle.com> References: <5294D453.5050402@oracle.com> Message-ID: > So overall it looks good to me and should be pushed to the staging > forest once you hear from others that commented previously. I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan, please correct me if I'm wrong. Thanks, iris -----Original Message----- From: Alan Bateman Sent: Tuesday, November 26, 2013 9:03 AM To: Volker Simonis Cc: Vladimir Kozlov; 2d-dev at openjdk.java.net; serviceability-dev at openjdk.java.net; security-dev; ppc-aix-port-dev at openjdk.java.net; awt-dev at openjdk.java.net; Java Core Libs; net-dev Subject: Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX On 26/11/2013 16:23, Volker Simonis wrote: > Hi, > > thanks to everybody for the prompt and helpful reviews. Here comes the > final webrev which incorporates all the corrections and suggestions > from the second review round: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > > I've successfully build (and run some smoke tests) with these changes > on Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, > MacOSX and AIX (5.3, 7.1). > I've skimmed over the last webrev with focus on: NetworkingLibraries.gmk where I see this is now fixed for all platforms. net_util.* and the platform specific net_util_md.* where I see you've added platformInit so it's much cleaner. UnixNativeDispatcher.c where the error translation is now removed (and looks fine). So overall it looks good to me and should be pushed to the staging forest once you hear from others that commented previously. -Alan From george.triantafillou at oracle.com Wed Nov 27 07:09:46 2013 From: george.triantafillou at oracle.com (George Triantafillou) Date: Wed, 27 Nov 2013 10:09:46 -0500 Subject: hg: hsx/hotspot-rt/hotspot: 8028160: [TESTBUG] Exclude failing (runtime) jtreg tests using @ignore In-Reply-To: <20131126231107.9AE736288C@hg.openjdk.java.net> References: <20131126231107.9AE736288C@hg.openjdk.java.net> Message-ID: <52960B3A.5010601@oracle.com> Thanks Harold for pushing the fix. Thanks also to my reviewers for your time. -George On 11/26/2013 6:11 PM, harold.seigel at oracle.com wrote: > Changeset: e567d5afd4dd > Author: hseigel > Date: 2013-11-26 16:03 -0500 > URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e567d5afd4dd > > 8028160: [TESTBUG] Exclude failing (runtime) jtreg tests using @ignore > Summary: Use @ignore to exclude failing tests > Reviewed-by: coleenp, ctornqvi, mseledtsov > Contributed-by: george.triantafillou at oracle.com > > ! test/runtime/6626217/Test6626217.sh > ! test/runtime/6929067/Test6929067.sh > ! test/runtime/CDSCompressedKPtrs/XShareAuto.java > ! test/runtime/InitialThreadOverflow/testme.sh > ! test/runtime/LoadClass/LoadClassNegative.java > ! test/runtime/XCheckJniJsig/XCheckJSig.java > ! test/runtime/jsig/Test8017498.sh > ! test/runtime/memory/ReadFromNoaccessArea.java > From andrei.eremeev at oracle.com Fri Nov 29 04:18:59 2013 From: andrei.eremeev at oracle.com (andrei.eremeev) Date: Fri, 29 Nov 2013 16:18:59 +0400 Subject: JDK-8004127 Message-ID: <52988633.5090106@oracle.com> Hi, I am analyzing this bug . And I think that is is duplicate of JDK-6498631 . Test hangs in native code. Can I close my bug as duplicate? Andrei -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131129/f2c7f292/attachment.html