RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

[Yekaterina Kantserova]

On 11/07/2013 03:29 PM, Jaroslav Bachorik wrote:
> On 7.11.2013 15:24, Yekaterina Kantserova wrote:
>> Hi,
>>
>> would you like to use JDKToolLauncher instead of JdkFinder? The
>> JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from
>> hotspot/test/testlibrary to jdk/test/lib/testlibrary).
>>
>> The example how to use can be found in
>> sun/management/jmxremote/bootstrap/LocalManagementTest.java.
>
> Why not. But I will need to wait till your changes are in ...

Sorry, ProcessBuilder's createJavaProcessBuilder() of course, which in 
turn uses JDKToolLauncher.

If you'll use ProcessBuilder's createJavaProcessBuilder() you don't need 
to wait. Before my fix it will use JdkFinder and after it JDKToolLauncher.

// Katja

>
> -JB-
>
>>
>> Thanks,
>> Katja
>>
>>
>>
>> On 11/07/2013 03:01 PM, Jaroslav Bachorik wrote:
>>> Please, review this test fix.
>>>
>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8004126
>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00
>>>
>>> The failure was caused by the IOHandler not waiting for the actual
>>> message stating the the debugee was ready. The patch uses the library
>>> functions to start the debugee and wait for the actual message to
>>> appear. Also, it detects problems while starting the debugee and
>>> reports them instead of failing only when the debugger can not connect.
>>>
>>> Thanks,
>>>
>>> -JB-
>>
>