Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Fri Nov 8 00:40:00 PST 2013


On 8.11.2013 00:40, Mandy Chung wrote:
> com.sun.management API is an exported API [1] except
> com.sun.management.OSMBeanFactory class which is an
> implementation-specific class and it's currently annotated as
> @jdk.Exported(false) [2].  This patch will eliminate one use of
> @jdk.Exported(false).
>
> This is simply refactoring of the existing implementation:
> o remove com.sun.management.OSMBeanFactory
> o move the implementation classes to sun.management including
>    - rename com.sun.management.UnixOperatingSystemImpl (or
> OperatingSystem windows version) to sun.management.OperatingSystemImpl
> along with its native implementation
>    - sun.management.ManagementFactoryHelper creates the
> sun.management.OperatingSystemImpl instance directly (no need of the
> factory OSMBeanFactory method)
>
> I'm including build-dev as there are changes in the makefiles.
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8025985/webrev.00/

AbstractOperatingSystemImpl should be an abstract class as its name 
already indicates.

The rest looks fine to me (not a reviewer, though)

-JB-

>
> thanks
> Mandy
> [1]
> http://download.java.net/jdk8/docs/jre/api/management/extension/index.html
> [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55



More information about the serviceability-dev mailing list