Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

Alan Bateman Alan.Bateman at oracle.com
Sun Nov 10 12:30:01 PST 2013


On 08/11/2013 15:48, Mandy Chung wrote:
> Thanks you all for the review.
>
> I'll rename AbstractOperatingSystemImpl before I push.
>
> Mandy

I think there is a problem with the change that was pushed. The Windows 
implementation of OperatingSystemImpl now implements 
java.lang.management.OperatingSystemMXBean whereas it actually 
implements com.sun.management.OperatingSystemMXBean. This causes a 
number of management tests to fail (only on Windows). If you agree then 
I'd like to fix it up with the attached patch to get the tests passing 
on Windows again.

-Alan.


diff --git a/src/windows/classes/sun/management/OperatingSystemImpl.java 
b/src/windows/classes/sun/management/OperatingSystemImpl.java
--- a/src/windows/classes/sun/management/OperatingSystemImpl.java
+++ b/src/windows/classes/sun/management/OperatingSystemImpl.java
@@ -25,7 +25,7 @@

  package sun.management;

-import java.lang.management.OperatingSystemMXBean;
+import com.sun.management.OperatingSystemMXBean;

  /**
   * Implementation class for the operating system.


More information about the serviceability-dev mailing list