RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary

Staffan Larsen staffan.larsen at oracle.com
Wed Nov 13 02:23:43 PST 2013


Assuming that you have verified the changes by running relevant tests this looks good.

Reviewed.

Thanks,
/Staffan

On 07 Nov 2013, at 16:48, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:

> Adding hotspot-dev group.
> 
> -------- Original Message --------
> Subject: 	RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary
> Date: 	Thu, 07 Nov 2013 15:09:44 +0100
> From: 	Yekaterina Kantserova <yekaterina.kantserova at oracle.com>
> To: 	Serviceability Dev <serviceability-dev at openjdk.java.net>
> 
> 
> 
> Hi,
> 
> Could I please have a review of this fix.
> 
> The following has been done:
> - updated OutputAnalyzer and ProcessTool with changes from hotspot/testlibrary;
> - added test classes AssertsTest and OutputAnalyzerReportingTest from hotspot/testlibrary;
> - added InputArguments class from hotspot/testlibrary (provides access to the input arguments to the VM);
> - removed JdkFinder (it's replaced with JDKToolLauncher);
> - re-wrote JcmdBase to use JDKToolLauncher instead of JdkFinder.
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8015497
> 
> Webrev:
> http://cr.openjdk.java.net/~ykantser/8015497/webrev.00/
> 
> Thanks,
> Katja
> 



More information about the serviceability-dev mailing list