RFR: 6402201: ProcessAttachTest.sh needs better synchronization
Alan Bateman
Alan.Bateman at oracle.com
Wed Nov 20 03:43:12 PST 2013
On 20/11/2013 11:25, Erik Gahlin wrote:
> Thanks for your feedback
>
> Here is an updated webrev where the file is renamed.
> http://cr.openjdk.java.net/~egahlin/6402201_2/
That looks okay to me. One small improvement would be to use
try-with-resources around the file write. Alternatively you could use
Files.write and do it in one method call (which would get you using the
new file system API and then you could use Files.move and specific the
ATOMIC_MOVE option). It's not strictly required for this and what you
have seems to fix the reported issue.
-Alan
More information about the serviceability-dev
mailing list