RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command

[Staffan Larsen]

Thanks Alan!

I’ll fix the copyright. Do you know if the javacc-generated files require copyright headers?

/Staffan

On 20 nov 2013, at 14:56, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> 
> I don't know if you are still looking for a Reviewer for this one. It looks okay to me (initially it looked like a lot of changes to review but its not the case). You might need to adjust the copyright dates on the script, unless of course the plane you were involved time travel :-)
> 
> -Alan.
> 
> On 18/11/2013 09:26, Staffan Larsen wrote:
>> Anyone dare look at this? :-)
>> 
>> On 14 Nov 2013, at 08:35, Staffan Larsen<staffan.larsen at oracle.com>  wrote:
>> 
>>> Still looking for an official Review of this change.
>>> 
>>> Thanks,
>>> /Staffan
>>> 
>>> On 11 Nov 2013, at 10:32, Staffan Larsen<staffan.larsen at oracle.com>  wrote:
>>> 
>>>> Thanks Serguei!
>>>> 
>>>> Can I have an official Review as well?
>>>> 
>>>> /Staffan
>>>> 
>>>> On 04 Nov 2013, at 21:08, serguei.spitsyn at oracle.com wrote:
>>>> 
>>>>> Staffan,
>>>>> 
>>>>> This one is really old: 11+ years. :)
>>>>> The fix is good, I do not see any issues.
>>>>> 
>>>>> Thanks,
>>>>> Serguei
>>>>> 
>>>>> 
>>>>> On 11/4/13 6:41 AM, Staffan Larsen wrote:
>>>>>> This is an old one! Nothing like being bored on a plane...
>>>>>> 
>>>>>> The problem here was that the expression evaluator in jdb did not handle numbers larger than Integer.MAX_VALUE. When necessary these need to be converted to longs instead of ints.
>>>>>> 
>>>>>> While I was touching the code, I added support for the unary operations: -, +, ~ and ! (did I mention I was bored).
>>>>>> 
>>>>>> There are many files changed in the webrev, but I've actually only touched three (Expr.jj, LValue.java, JdbExprTest.sh) the rest are generated by javacc. The generated files have lost their copyright headers. If needed, I can add those back before pushing the change, but since it's manual work I want to do it after the review is done.
>>>>>> 
>>>>>> webrev: http://cr.openjdk.java.net/~sla/4660158/webrev.00/
>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-4660158
>>>>>> 
>>>>>> Thanks,
>>>>>> /Staffan
>