RFR (S): 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2"

[Peter Allwin]

Hi Fredrik,

Looks great!


Thanks for fixing this,
/peter

On Sep 20, 2013, at 2:35 PM, Fredrik Arvidsson <fredrik.arvidsson at oracle.com> wrote:

> Hi
> 
> Please help me and review the changes below:
> 
> Webrev: http://cr.openjdk.java.net/~allwin/farvidss/6313383/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-6313383
> 
> This change adds support for dumping large heaps (> 4G) using jmap by implementing the "JAVA PROFILE 1.0.2" file format with segmented heap dump records.
> The HPROF binary format specification can be found here: https://java.net/downloads/heap-snapshot/hprof-binary-format.html.
> 
> I added a simple test to verify that heaps smaller than 2G are dumped using the "JAVA PROFILE 1.0.1" format. The last section in the test, aiming to test the format used when dumping heaps larger than 2G, is commented out since the test system didn't like that kind of heap sizes and ultimately failed (OOM and sometimes timeout). The test should be reintroduced once we can reliably support such tests in the test system.
> 
> Thanks 'allwin' for hosting my review :)
> 
> Cheers
> /Fredrik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131002/6d76ccd9/attachment.html