jmx-dev RFR: 8024613 javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently

[Jaroslav Bachorik]

On 20.9.2013 14:54, shanliang wrote:
> Jaroslav,
>
> It is a good idea to use the RMI Testlibrary.
>
> Better to call:
>         agent.close();
>
> at Line 55,  close the RMIRegistry (rmid.shutdown(rmidPort) Line 55)
> does not ensure the JMX connector doing full clean, it is always better
> to do clean within a test.

Thanks. Implemented.

http://cr.openjdk.java.net/~jbachorik/8024613/webrev.01

-JB-

>
> Shanliang
>
>
> Jaroslav Bachorik wrote:
>> Please, review the following change for JDK-8024613
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8024613
>> Webrev: http://cr.openjdk.java.net/~jbachorik/8024613/webrev.00/
>> <http://cr.openjdk.java.net/%7Ejbachorik/8024613/webrev.00/>
>>
>> The patch takes care of intermittent test failures caused by timing
>> issues when starting the RMID process. It could happen that the RMID
>> process hasn't been properly initialized in the timeframe of 5 seconds
>> and the test would fail.
>>
>> The patch replaces the home-brewed RMID process management with the
>> one available in the RMI Testlibrary which is used by more tests and
>> therefore should be more stable.
>>
>> Thanks,
>>
>> -JB-
>