RFR [8025886] typo in shell regtest == instead of =

[Dmitry Samersoff]

Ivan,

If you need shell pattern match CYGWIN_NT*
it's better to use

case

but not

if

-Dmitry


On 2013-10-03 18:11, Ivan Gerasimov wrote:
> Hello!
> 
> May I please have a review for a simple fix of the shell regtest?
> Bash seems to accept both = and == comparisons, but sh accepts only =.
> 
> http://bugs.sun.com/view_bug.do?bug_id=8025886 (not yet visible.)
> 
> Sincerely yours,
> Ivan
> 
> 
> --- a/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
> +++ b/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
> @@ -34,7 +34,7 @@
>  OS=`uname -s`
>  UMASK=`umask`
> 
> -if [[ $OS == CYGWIN_NT* ]] ; then
> +if [[ $OS = CYGWIN_NT* ]] ; then
>      OS="Windows_NT"
>      if [ -z "$SystemRoot" ] ;  then
>      SystemRoot=$SYSTEMROOT
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.