RFR (S): 8025427 jstat tests fails on 32-bit platforms
David Holmes
david.holmes at oracle.com
Wed Oct 9 21:03:16 PDT 2013
On 9/10/2013 3:04 AM, Staffan Larsen wrote:
> Thanks Serguei!
>
> Still need an official Reviewer.
Reviewed!
Thanks for explaining the diff to the regex :) Hard to spot.
David
-----
> Thanks,
> /Staffan
>
> On 8 okt 2013, at 17:24, serguei.spitsyn at oracle.com wrote:
>
>> Looks good.
>>
>> Thanks,
>> Serguei
>>
>> On 10/8/13 5:06 AM, Staffan Larsen wrote:
>>> Pinging again: Please, pretty please? :)
>>>
>>> /Staffan
>>>
>>> On 1 okt 2013, at 20:46, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>>
>>>> Any Reviewer who can take a look?
>>>>
>>>> Thanks,
>>>> /Staffan
>>>>
>>>> On 27 sep 2013, at 23:59, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>>>
>>>>> This change makes jstat output '-' instead of '\ufffd' when the result of a calculation is NaN. '\ufffd' is typically not displayable in a terminal.
>>>>>
>>>>> This change also updates the tests to allow '-' as the output int the CCS (Compressed Class Space Space - Percent Used) column from -gcutil and -gccause. It can be hard to see from the diff but what I have done is change the regexp for that column from:
>>>>>
>>>>> [0-9]+\.[0-9]+
>>>>>
>>>>> to:
>>>>>
>>>>> ([0-9]+\.[0-9]+)|-
>>>>>
>>>>> Testing: Passes tests locally, currently running JPRT.
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~sla/8025427/webrev.00/
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8025427
>>>>>
>>>>> Thanks,
>>>>> /Staffan
>>
>
More information about the serviceability-dev
mailing list