RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump

[David Holmes]

Fredrik,

On 10/10/2013 8:24 PM, Fredrik Arvidsson wrote:
> Hi
>
> Please help me to review the changes below:
>
> Jira case: https://bugs.openjdk.java.net/browse/JDK-8024425
> <https://bugs.openjdk.java.net/browse/JDK-8024423>
> Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8024425/webrev.00/
> <http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.00/>

Please make sure what you have in your html email is consistent. Your 
visible text refers to a different bug id to the actual link - and the 
links are different to the subject. Can you please re-send this email 
with corrected links and subject - thanks.

Style issues:
- ensure spaces are after keywords ie if(x) should be if (x)
- two-space indent not four

David
-----

> About this change.
> I switched from using the SystemDictionary to use ClassLoaderDataGraph
> instead since the SystemDictionary lack information about the
> 'anonymous' classes related to this bug.
>
> Previously failed Aurora tests have been run using UTE and verified to
> PASS. The heap dump file have been successfully opened and parsed using
> jhat and eclipse MAT.
>
> Cheers
> /Fredrik