RR(S): JDK-8004213 jdp packet need pid, broadcast interval and rmi server hostname fields.

Staffan Larsen staffan.larsen at oracle.com
Thu Oct 10 23:32:27 PDT 2013


Dmitry,

This looks good, just two small nits:

test/sun/management/jdp/JdpClient.java: 56: "Packet error fileld " -> "Packet error: field "

test/sun/management/jdp/JdpClient.java: 68-74: missing space after the comma

Thanks,
/Staffan


On 10 okt 2013, at 20:33, Dmitry Samersoff <Dmitry.Samersoff at oracle.com> wrote:

> Hi Everyone,
> 
> This fix covers
> 
> JDK JDK-8004213 JDP packets should contain PID
> JDK-8004215 JDP packets should contain the configured broadcast interval
> JDK-8007071 JDP does not work well with java.rmi.server.hostname overrides.
> 
> and add three extra fields to JDP packet: PID, rmi server name,
> broadcast interval.
> 
> PID gathering code mostly borrowed from hotspot testlibrary.
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-8004213/webrev.01/
> 
> -Dmitry
> 
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.



More information about the serviceability-dev mailing list