code review round 1 for Full Debug Symbols on MacOS X hotspot (7165611)

[Magnus Ihse Bursie]

On 2013-10-11 22:27, Daniel D. Daugherty wrote:
> Greetings,
>
> I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
> Below is the original code review round 0 invite (slightly edited for
> clarity). Working on FDS is like pulling a thread on a sweater... so
> there are four additional changed files along with more changes to
> many of the files from round 0.
>
> Here is the code review round 1 JDK8/HSX-25 webrev URL:
>
> OpenJDK: 
> http://cr.openjdk.java.net/~dcubed/fds_revamp/7165611-webrev/1-jdk8/
> Internal: 
> http://javaweb.us.oracle.com/~ddaugher/fds_revamp/7165611-webrev/1-jdk8/

New build system parts overall looks good. Just one note: Your webrev is 
based on the code before the whitespace/indentation cleanup. Please try 
to keep to the new indentation policy (see 
http://mail.openjdk.java.net/pipermail/build-dev/2013-October/010477.html) 
when merging. That means e.g. that code like:

         ifneq ($(OPENJDK_TARGET_OS), macosx)   # OBJCOPY is not used on 
MacOS X
         ifneq ($(OPENJDK_TARGET_OS), windows)  # nor on Windows


shoud be properly indented and not on the same level.

/Magnus