RFR: 8021897 EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

[Staffan Larsen]

Alan, Serguei: Thanks for the reviews!

I updated the fix with Serguei's comment and will push this version: http://cr.openjdk.java.net/~sla/8021897/webrev.01/

/Staffan

On 18 okt 2013, at 11:23, serguei.spitsyn at oracle.com wrote:

> Staffan,
> 
> It looks good.
> A minor suggestion is to initialize length here:
>      jint      length = string != NULL ? (int)strlen(string) : 0;
> 
> Thanks,
> Serguei
> 
> 
> On 10/18/13 1:37 AM, Staffan Larsen wrote:
>> This is a continuation of a review from the hotspot repo: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-October/009657.html The hotspot fix has now reached JDK8-TL so I can now push the test and JDK fix.
>> 
>> The problem has to do with stepping into the String constructor and asking to see the value of the String. JDWP does this via GetStringUTFChars which crashed if the String didn't have a value field. That call now returns NULL and needs to be checked in JDWP.
>> 
>> I have also added a test that breakpoints in String's constructor and verifies that it is ok to get the value of the String.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8021897/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8021897
>> 
>> Thanks,
>> /Staffan
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131018/73867c57/attachment-0001.html