RFR 7140929: NotSerializableNotifTest.java fails intermittently
Alan Bateman
Alan.Bateman at oracle.com
Mon Oct 21 04:20:17 PDT 2013
On 21/10/2013 12:03, Jaroslav Bachorik wrote:
> Hi,
>
> please, review the following small test change:
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-7140929
> Webrev: http://cr.openjdk.java.net/~jbachorik/7140929/webrev.00
>
> The test fails intermittently, mostly when it is run with -Xcomp
> option. The failure is due to fixed timeout used in the test when
> waiting for the notifications arrival. Tests of such slow
> configurations are run with "timeoutfactor" set but the
> NotSerializableNotifTest does not respect the timeoutfactor.
>
> The patch allows the test to reflect the provided "timeoutfactor" and
> therefore successfully pass even when -Xcomp is used.
Good to see test.timeout.factor being used (I think a lot of tests could
benefit from using it). The change in the webrev looks okay, in the
sense that you have scaled the existing 10s timeout.
-Alan.
More information about the serviceability-dev
mailing list