jmx-dev RFR 7112404: 2 tests in java/lang/management/ManagementFactory fails with G1 because expect non-zero pools

shanliang shanliang.jiang at oracle.com
Mon Oct 21 08:14:18 PDT 2013


Looks OK.
    164         // sanity check to have non-zero usage
should be changed to ?
    164         // sanity check to have non-negative usage

Shanliang

Jaroslav Bachorik wrote:
> Please, review this simple test fix.
>
> Issue:  https://bugs.openjdk.java.net/browse/JDK-7112404
> Webrev: http://cr.openjdk.java.net/~jbachorik/7112404/webrev.00
>
> The tests assume the MemoryUsage#commited values to be positive (>0) 
> while according to the MemoryUsage only negative values are invalid. 
> Therefore the tests should check and fail only when 
> MemoryUsage#commited is < 0.
>
> Thanks,
>
> -JB-



More information about the serviceability-dev mailing list