RR(XS): JDK-8026950 Nits in agent ps_proc.c file breaks compilation of open hotspot

Dmitry Samersoff dmitry.samersoff at oracle.com
Wed Oct 23 02:38:04 PDT 2013


David,

SA doesn't support live process debugging on OSX, so this file is not
compiled during libsaproc.dynlib build.

But yes, if I enable compilation of this file during OSX build it fails
as well, so this fix is required to go froward.

May I consider you as a reviewer?

-Dmitry


On 2013-10-23 06:37, David Holmes wrote:
> On 21/10/2013 7:50 PM, Dmitry Samersoff wrote:
>> Hi Everybody,
>>
>> Please review a small fix.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8026950/webrev.01/
> 
> I don't understand why this is only a compile error on "open hotspot"?
> PT_CONTINUE seems to be the necessary value for OSX and other BSD
> systems. Do some systems have an alias in place?
> 
> Reviewed.
> 
> David
> 
>> -Dmitry
>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list