code review round 0 for MacOS X FDS whitespace/indent fixes (8027117)

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Oct 23 13:59:29 PDT 2013


Adding back the other two aliases...

Dan


On 10/23/13 2:50 PM, Daniel D. Daugherty wrote:
> Harold,
>
> Thanks for the fast review!
>
> Dan
>
> On 10/23/13 2:36 PM, harold seigel wrote:
>> Hi Dan,
>>
>> The whitespace/indents look good.
>>
>> Harold
>>
>> On 10/23/2013 4:26 PM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I have some MacOS X Full Debug Symbols whitespace/indent fixes.
>>> Here is the JDK8/HSX-25 webrev URL:
>>>
>>> OpenJDK: 
>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/
>>> Internal: 
>>> http://javaweb.us.oracle.com/~ddaugher/fds_revamp/8027117-webrev/0-jdk8/ 
>>>
>>>
>>> Because these are whitespace/indent fixes, only the "Cdiffs" and
>>> "Udiffs" links show all the changes.
>>>
>>> This webrev includes changes for the follow repos:
>>>
>>>     jdk8
>>>     jdk8/jdk
>>>
>>> Gory details are below...
>>>
>>> As always, comments, questions and suggestions are welcome.
>>>
>>> Dan
>>>
>>>
>>> The fixes for the following two bugs hit JDK8 at the same time, but
>>> came up via different sub-baselines:
>>>
>>>     7165611 implement Full Debug Symbols on MacOS X hotspot
>>>     https://bugs.openjdk.java.net/browse/JDK-7165611
>>>
>>>     8001931 build-infra: Apply consistent formatting/indentation to
>>>             new build-infra files
>>>     https://bugs.openjdk.java.net/browse/JDK-8001931
>>>
>>> During the JDK8 merge process some of the changes from 7165611 were not
>>> properly adjusted to meet the new whitespace/indent policy implemented
>>> by 8001931. This changeset fixes those style issues.
>>>
>>> Testing:
>>> - JPRT JDK8 forest build and test on all platforms (in process)
>>
>



More information about the serviceability-dev mailing list