jmx-dev RFR: 8004179: test/java/lang/management/ThreadMXBean/SynchronizerLockingThread.java doesn't clean up

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Tue Sep 3 04:26:32 PDT 2013


On 09/03/2013 12:57 PM, Alan Bateman wrote:
> On 03/09/2013 09:02, Jaroslav Bachorik wrote:
>> Please, review the following patch:
>> http://cr.openjdk.java.net/~jbachorik/8004179/webrev.01
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8004179
>>
>> It addresses the problem of the test not properly cleaning up the
>> created threads at exit. It does so by running the test in "othervm"
>> mode. Although it is possible to modify the test to cleanup the threads
>> at exit it would add more complexity to the test while achieving the
>> same result as running the test in "othervm" mode.
>>
>> Thanks,
>>
>> -JB -
> This looks okay. There is a second test that I noted in the bug that has
> a similar issue, maybe that needs its own bug.

Hm, actually there are 6 other tests using the LockingThread class which
leaves the threads running. So all those tests should be made running in
"othervm" mode.

Does increasing the number of tests running in "othervm" mode have any
negative consequences?

-JB-

> 
> -Alan



More information about the serviceability-dev mailing list