RFR: 8022220 Intermittent test failures in javax/management/remote/mandatory/connection/RMIConnectionIdTest.java

[Jaroslav Bachorik]

On 09/11/2013 05:06 PM, shanliang wrote:
> The fix looks OK for me.
> 
> I am wondering that in case of loopback address, is it better to always
> using "127.0.0.1" to generate a connectionId? this will make sure to
> have a unique id.

I am afraid we are getting the 127.0.1.1 variant from RMI
(java.rmi.server.RemoteServer#getClientHost()). I don't know what else
might break if we start fiddling around with it. For now I would better
keep it the simplest possible.

-JB-

> 
> Shanliang
> 
> Jaroslav Bachorik wrote:
>> Please, review this simple patch for an intermittently failing test.
>>
>> The test fails in cases when the connection loopback is resolved to be
>> 127.0.1.1 - it may happen under certain circumstances in eg. Ubuntu. The
>> test does not anticipate this possibility and requires the loopback
>> address to be exactly 127.0.0.1
>>
>> The test will end comparing 127.0.0.1 against 127.0.1.1 and will
>> consider them non equal even though they are both the same loopback. The
>> patch adds a bit of flexibility to the test allowing for any two valid
>> loopback addresses (127.0.0.0/8) to be equal.
>>
>> Issue  : JDK-8022220
>> Webrev : http://cr.openjdk.java.net/~jbachorik/8022220/webrev.00
>>
>> Thanks,
>>
>> -JB-
>>   
>