RR(S): JDK-8015848: SA: ByteCodeRewriter needs implementation for invokedynamic

[Dmitry Samersoff]

Chris,

Thank you for the verification.

I withdraw this review request and will go further. Any advice is much
appreciated.

-Dmitry


On 2013-09-11 23:09, Christian Thalinger wrote:
> Yes, the dumping works but when I try to use the boot.jar file it complains about missing BootstrapMethods attributes:
> 
> $ /java/re/jdk/8/promoted/all/b95/binaries/linux-amd64/fastdebug/bin/java -XX:+ReplayCompiles -XX:ReplayDataFile=replay_pid26233.log -Xbootclasspath/p:boot.jar -cp app.jar 
> Error occurred during initialization of VM
> java/lang/ClassFormatError: Missing BootstrapMethods attribute in class file java/lang/CharSequence
> 
> Unfortunately I was expecting that.
> 
> -- Chris
> 
> On Sep 11, 2013, at 10:39 AM, Dmitry Samersoff <Dmitry.Samersoff at oracle.com> wrote:
> 
>> Thanks!
>>
>>
>> On 2013-09-11 20:37, Christian Thalinger wrote:
>>>
>>> On Sep 5, 2013, at 12:31 AM, Dmitry Samersoff <Dmitry.Samersoff at oracle.com> wrote:
>>>
>>>> On 2013-09-05 02:30, Christian Thalinger wrote:
>>>>>
>>>>> On Sep 4, 2013, at 1:35 PM, Dmitry Samersoff <Dmitry.Samersoff at oracle.com> wrote:
>>>>>
>>>>>> Please, review the changes.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8015848/webrev.01/
>>>>>
>>>>> With this change you can dump the boot class path classes again?
>>>>>
>>>> Yes. Also I manually checked generated classes with javap.
>>>>
>>>> But I'll much appreciate you if you can apply the patch and confirm that
>>>> output is OK from compiler team point of view.
>>>
>>> Sorry.  I missed this email.  Let me give it a try today.
>>>
>>> -- Chris
>>>
>>>>
>>>> -Dmitry
>>>>
>>>> -- 
>>>> Dmitry Samersoff
>>>> Oracle Java development team, Saint Petersburg, Russia
>>>> * I would love to change the world, but they won't give me the source code.
>>>
>>
>>
>> -- 
>> Dmitry Samersoff
>> Oracle Java development team, Saint Petersburg, Russia
>> * I would love to change the world, but they won't give me the sources.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.